1 2007-08-14 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
4 Renabled the call to add_mmc_account() because I do not believe
5 it could be the cause of the mentioned hang (in scratchbox, where
6 there is no memory card), and because I have tested that it works
9 2007-08-14 Murray Cumming <murrayc@murrayc.com>
11 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
12 Comment out part of the last commit because it apparently causes
15 2007-08-14 Murray Cumming <murrayc@murrayc.com>
17 * src/modest-tny-account-store.c: Added the add_mmc_account()
18 function to save some copy/pasting.
19 (modest_tny_account_store_new): If the memory card is mounted,
20 create an account for it at the start, instead of waiting for the
21 user to unmount it and mount it.
23 2007-08-13 Murray Cumming <murrayc@murrayc.com>
25 * src/widgets/modest-account-view.c: (on_account_changed):
26 Do not try to use the human-readable TnyAccount name instead of the
27 ID of the modest account to get the transport account. And unref
28 the transport account. This prevents a g_warning(), and a possible
31 2007-08-13 Murray Cumming <murrayc@murrayc.com>
33 * src/maemo/modest-platform.c:
34 (modest_platform_set_update_interval): Handle the new
35 alarmd error to warn when alarmd is not running, as is the case in
36 scratchbox for me now because
37 "Module /usr/lib/alarmd/libretu.so initialization failed"
39 2007-08-13 Murray Cumming <murrayc@murrayc.com>
41 * src/widgets/modest-header-view-render.c:
42 (_modest_header_view_compact_header_cell_data):
43 NULL some strings after freeing them, trying to deal with
44 the double deletion found in projects.maemo.org bug 64183,
45 probably having no effect.
47 2007-08-13 Murray Cumming <murrayc@murrayc.com>
49 * src/maemo/modest-account-settings-dialog.c:
50 (create_page_incoming), (create_page_outgoing): Use a define
51 for the min and max port numbers.
53 (check_hildon_number_editor_and_warn_value_not_in_range),
54 (check_data): Do an extra check for an invalid port number, as needed
55 in projects.maemo.org bug #64275, when the number is cleared, but this
56 does not work due to bugs.maemo.org bug #1806.
58 2007-08-13 Murray Cumming <murrayc@murrayc.com>
60 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
61 Comment out the debug warning about the unexpected D-Bus methods.
62 They are just annoying now.
63 * src/maemo/modest-platform.c:
64 (modest_platform_set_update_interval): Correct the D-Bus path, instead
65 of using a file path, though it did not seem to break things before.
66 It might be needed now:
67 Use the ALARM_EVENT_ACTIVATION flag so that emails are updated even when
68 modest is not already running. This is the behaviour of the old client, and
69 Mox says it is what we should do for modest.
70 This closes projects.maemo.org bug NB#64327.
72 2007-08-04 Johannes Schmid <johannes.schmid@openismus.com>
74 * src/modest-text-utils.c:
75 Fixed invalid jump due to incorrect string/pointer
77 (See https://projects.maemo.org/trac/email/wiki/ValgrindErrors
80 2007-08-01 Murray Cumming <murrayc@murrayc.com>
82 * src/modest-account-mgr-helpers.h:
83 * src/modest-account-mgr-helpers.c:
84 Added modest_account_mgr_get_first_account_name(),
85 using code from modest_account_mgr_set_first_account_as_default().
87 * src/maemo/modest-main-window.c: Added set_at_least_one_account_visible().
88 (account_number_changed): Call set_at_least_one_account_visible() so that
89 the first account is visible when first added, without the user having to
91 I do wonder how this worked before.
93 2007-08-01 Murray Cumming <murrayc@murrayc.com>
95 * src/modest-tny-account-store.c: (show_password_warning_only),
96 (show_wrong_password), (request_password_and_wait), (get_password),
97 (modest_tny_account_store_alert): Remove the (incomplete anyway)
98 attempts to show UI only in the main context, which used g_idle_add()
99 and mainloops, because tinymail now guarantees that it only calls these
100 callbacks in the mainloop with the gdk lock. This makes everything much
103 2007-08-01 Murray Cumming <murrayc@murrayc.com>
105 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
106 Handle TNY_ACCOUNT_ERROR_TRY_CONNECT_SERVICE_UNAVAILABLE in the same
107 way as TNY_ACCOUNT_ERROR_TRY_CONNECT_HOST_LOOKUP_FAILED, showing an
108 error dialog, instead of ignoring it.
110 2007-08-01 Murray Cumming <murrayc@murrayc.com>
112 * src/maemo/modest-msg-view-window.c:
113 (modest_msg_view_window_get_header),
114 (modest_msg_view_window_last_message_selected):
115 Added comments to explain the use of priv->header_model.
116 * src/modest-ui-dimming-rules.c:
117 (modest_ui_dimming_rules_on_open_msg),
118 (modest_ui_dimming_rules_on_mark_as_read_msg),
119 (modest_ui_dimming_rules_on_mark_as_unread_msg),
120 (modest_ui_dimming_rules_on_remove_attachments),
121 (_invalid_attach_selected), (_selected_msg_marked_as):
122 Renamed _marked_as_deleted() to _selected_message_is_marked_as_deleted(),
123 and changed the parameter to a ModestMainWindow to make it clearer that
124 it never uses any other kind of window.
125 Added _message_is_marked_as_deleted() for examining a ModestMsgViewWindow
126 instead of the selected message.
127 I notice that much of the dimming code and the ModestMsgViewWindow code
128 hard-codes the assumption that the viewed message is always selected in
129 the header view. This does not seem wise or simple.
131 (modest_ui_dimming_rules_on_delete_msg): For a ModestMsgViewWindow,
132 examine the actual message instead of whatever might be selected
133 in the header view. This stops the delete toolbar button and menu item
134 from being dimmed when opening a message view the search UI,
135 partially fixing projects.maemo.org bug NB#63811.
137 However, when actually deleting, I now get this warning:
138 "tny_header_set_flags: This is a header instance for a new message.
139 Only priority and attachment flags are supported"
141 2007-07-30 Johannes Schmid <johannes.schmid@openismus.com>
143 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
145 Show account wizard if no accounts are defined while sending
146 (automatic sending after the account wizard finished does not
147 work because it takes some time until the account manager
148 synchronizes everything. (projects.maemo.org NB#62792)
150 2007-07-30 Murray Cumming <murrayc@murrayc.com>
152 * src/modest-tny-account-store.c: (on_account_removed),
153 (on_account_changed): Emit the ACCOUNT_UPDATE signal so that the
154 account is removed from the View menu. We have TnyAccountStore
155 and ModestTnyAccountStore signals that seem very similar, but this
156 seems to work for now.
158 * src/maemo/modest-main-window.c:
159 (on_show_account_action_activated): Prevent dereference
160 of a NULL if the accoutn does not really exist, though that
161 should not happen anymore.
163 This fixes projects.maemo.org bug NB#64606.
165 2007-07-30 Murray Cumming <murrayc@murrayc.com>
167 * src/modest-ui-actions.c: (run_account_setup_wizard),
168 (modest_ui_actions_on_accounts): Revert a change that set these
169 to modal dialogs, freezing the UI when they show secondary dialogs.
170 This fixed projects.maemo.org bug NB#64519.
172 2007-07-27 Murray Cumming <murrayc@murrayc.com>
174 * src/widgets/modest-header-view-render.c:
175 (_modest_header_view_compact_header_cell_data):
176 Some checks and initialization to try to deal with a crash,
177 probably ineffective.
179 2007-07-27 Murray Cumming <murrayc@murrayc.com>
181 * src/maemo/modest-maemo-utils.c:
182 (modest_maemo_utils_get_supported_secure_authentication_methods):
183 Make sure that we have a connection, asking the user for one
185 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
186 Check for a connection before showing the wizard, because
187 the wizard needs a connection to check for server capabilities.
189 2007-07-27 Murray Cumming <murrayc@murrayc.com>
191 * src/maemo/modest-account-view-window.c:
192 (on_new_button_clicked): Remember the wizard dialog instance,
193 so we can just present it again if necessary. This prevents
194 multiple windows from appearing if you click again quickly on the
195 New button before the dialog appears, fixing projects.maemo.org
198 2007-07-27 Murray Cumming <murrayc@murrayc.com>
200 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
201 Offer a connection dialog if there is no connection when
202 starting modest. This should fix projects.maemo.org bug NB#61134.
204 2007-07-27 Murray Cumming <murrayc@murrayc.com>
206 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
207 Reverted my last commit. I was able to fix the build by doing
208 apt-get install wpeditor0 (replacing other wpeditor packages) and
209 an explicit apt-get install wpeditor-dev to upgrade the -dev
212 2007-07-27 Murray Cumming <murrayc@murrayc.com>
214 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
215 Commented out the use of wp_text_buffer_replace_image()
216 because it does not exist, to break the build. Added a TODO for it.
218 2007-07-26 Murray Cumming <murrayc@murrayc.com>
220 * src/modest-tny-account-store.c: (recreate_all_accounts):
221 Recreate them even if they were NULL before. I guess something
222 else was already creating them before, or this would never
224 (modest_tny_account_store_get_server_account): Make sure that
225 the tny accounts have been created before trying to find one.
226 This allows libmodest_dbus_client_compose_mail() to work
227 when the UI is not yet visible.
228 This is probably useful in other cases too.
230 (get_password): When the password is wrong after it is entered
231 in the protected password dialog, show an info banner (in an
232 idle handler) before showing the protected password dialog
235 2007-07-26 Murray Cumming <murrayc@murrayc.com>
237 * src/modest-ui-actions.h:
238 * src/modest-ui-actions.c: Added
239 modest_do_refresh_current_folder() containing some code from
240 modest_ui_actions_on_send_receive().
241 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
242 Call modest_do_refresh_current_folder() before refreshing the
243 requested account, as in modest_ui_actions_on_send_receive().
244 This is strange, but seems to be necessary to show new mails.
245 Now new emails are finally visible in the UI when downloaded
246 via the automatic update interval, fixing bug NB#57458.
247 This also works because bug NB#57458 has been fixed somehow.
249 2007-07-26 Murray Cumming <murrayc@murrayc.com>
251 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
252 printf more details when we get unhandled D-Bus methods, because
255 * src/modest-mail-operation.c: (update_account_thread):
256 Comment out the tny_camel_pop_store_account_reconnect(), because this
257 is apparently no longer needed, and it did not work before anyway.
258 See the comment in the code.
260 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
261 by checking the header flags. This fixes projects.maemo.org bug
264 2007-07-25 Murray Cumming <murrayc@murrayc.com>
266 * src/maemo/modest-maemo-utils.h:
267 * src/maemo/modest-maemo-utils.c: Added
268 modest_maemo_show_information_note_in_main_context_and_forget().
269 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
270 Use the new function to show simple error dialogs in the main
271 context, though question dialogs are still in the current context,
272 which is unfortunately usually not the main context. This should
275 2007-07-25 Murray Cumming <murrayc@murrayc.com>
277 * src/modest-tny-account-store.c: (get_password):
278 Never save the entered username and password in gconf,
279 because the UI spec says we should not. This helps
280 slightly with projects.maemo.org bug NB#63671.
282 2007-07-25 Murray Cumming <murrayc@murrayc.com>
284 * src/widgets/modest-msg-edit-window.h:
285 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
286 Moved some code here to make it simpler.
287 (modest_msg_edit_window_attach_file_one): Renamed from
288 modest_msg_edit_window_attach_file_interactive().
289 (modest_msg_edit_window_offer_attach_file): Renamed from
290 modest_msg_edit_window_attach_file() and used
291 modest_msg_edit_window_attach_file_one() instead of
292 copy/pasting the code. The old code for one was not using
293 GnomeVFS. This allows use of smb:// URLs when using send-as
294 from external applications, fixing bug NB#63741.
296 (modest_msg_edit_window_insert_image),
297 (modest_msg_edit_window_add_attachment_clicked):
298 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
299 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
300 Adapted to the new function names.
302 2007-07-25 Murray Cumming <murrayc@murrayc.com>
304 (modest_platform_set_update_interval): Set the alarm recurrence
305 fields so that auto-update does not just happen the first time.
306 This should have fixed projects.maemo.org bug NB#63938.
308 When this happens you can see a printf when the D-Bus method is
310 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
312 However, I do not actually seem to get new POP messages even when
313 clicking the refresh button manually. A restart gets them.
314 This might be a problem in today's tinymail only.
316 2007-07-24 Murray Cumming <murrayc@murrayc.com>
318 * src/maemo/modest-maemo-global-settings-dialog.c:
319 (current_connection):
320 Avoid a crash (probably only in scratchbox) when strcmp()ing a
321 NULL when closing the dialog.
323 2007-07-24 Murray Cumming <murrayc@murrayc.com>
325 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
326 Remove the hacky send/receive that didn't work, and instead
327 refilter the treemodel to make the deleted email really vanish from
328 the UI (though the delete-from-menu code does has commented out
329 the code that does that). This fixes projects.maemo.org bug
332 2007-07-24 Murray Cumming <murrayc@murrayc.com>
334 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
335 Try a couple of tricks to force the treeview to update (
336 poke the folder, and do a send/receive refresh), but the deleted
337 email still appears with a strike-through instead of really being
340 2007-07-23 Murray Cumming <murrayc@murrayc.com>
342 * src/dbus_api/modest-dbus-callbacks.c:
343 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
344 because their ID is not human-readable (see the comment about
345 improvements needed to the osso-email-interface API) and
346 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
348 2007-07-23 Murray Cumming <murrayc@murrayc.com>
350 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
351 (add_folders_to_list), (on_dbus_method_get_folders),
352 (modest_dbus_req_filter):
353 * src/maemo/modest-maemo-utils.c:
354 (on_camel_account_get_supported_secure_authentication):
355 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
356 (on_header_view_focus_in):
357 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
358 * src/modest-formatter.c: (modest_formatter_create_body_part):
359 * src/modest-mail-operation.c: (recurse_folders),
360 (update_account_thread), (get_msgs_full_thread),
361 (modest_mail_operation_get_msgs_full),
362 (modest_mail_operation_xfer_msgs):
363 * src/modest-search.c: (search_mime_part_and_child_parts),
364 (modest_search_account), (modest_search_all_accounts):
365 * src/modest-tny-account.c:
366 (modest_tny_account_get_special_folder), (recurse_folders):
367 * src/modest-tny-local-folders-account.c:
368 (modest_tny_local_folders_account_query_passes):
369 * src/modest-tny-msg.c: (copy_mime_part),
370 (modest_tny_msg_find_body_part_from_mime_part):
371 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
372 (modest_tny_send_queue_try_to_send):
373 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
374 (_modest_ui_actions_open), (download_uncached_messages),
375 (reply_forward), (modest_ui_actions_on_copy),
376 (modest_ui_actions_on_details), (has_retrieved_msgs),
377 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
379 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
380 (_selected_msg_marked_as), (_msg_download_completed),
381 (_selected_msg_sent_in_progress):
382 * src/widgets/modest-attachments-view.c:
383 (modest_attachments_view_set_message):
384 * src/widgets/modest-msg-view.c: (find_cid_image):
385 * tests/check_folder-transfer.c: (find_folders):
386 * tests/check_update-account.c: (func):
387 * tests/dbus_api/test_get_folders.c: (main):
388 Checked all uses of tny_iterator_get_current(), making sure
389 that the object is unreferenced (3 or 4 places did not),
390 and adding checks for NULL.
392 2007-07-23 Murray Cumming <murrayc@murrayc.com>
394 * src/dbus_api/modest-dbus-callbacks.c:
395 (on_idle_open_default_inbox): Make sure that the application UI is
397 * src/maemo/easysetup/modest-easysetup-wizard.c:
398 (on_entry_invalid_character): Show the word whitespace instead
399 of (null) in the banner when whitespace was entered.
400 (show_error): Add a comment that this does not work in
401 Maemo Bora, though we do not know why.
403 2007-07-23 Murray Cumming <murrayc@murrayc.com>
405 * src/modest-tny-account.c:
406 (modest_tny_account_get_special_folder): Use an if instead of
407 an assert for when the parent account name is NULL, because this
408 might be causing a crash in projects.maemo.org bug 63192.
409 * src/modest-mail-operation.c:
410 (modest_mail_operation_send_new_mail_cb),
411 (modest_mail_operation_remove_folder): unref the folder that is
412 returned from modest_tny_account_get_special_folder().
414 2007-07-23 Murray Cumming <murrayc@murrayc.com>
416 * src/modest-ui-actions.c:
417 (modest_ui_actions_on_password_requested):
418 Show mail_ib_login_cancelled info banner when the user cancels
419 the protected password dialog, to fix projects.maemo.org
422 2007-07-23 Murray Cumming <murrayc@murrayc.com>
424 * src/maemo/modest-account-settings-dialog.c:
425 (create_page_outgoing): Put this page in a GtkScrolledWindow,
426 matching the UI mock-up in the UI spec, and allowing access
427 to all widgets even when the on-screen keyboard is active.
429 2007-07-23 Murray Cumming <murrayc@murrayc.com>
431 Reverted this previous commit from Johannes,
432 because the scrollbars are always visible and because
433 I think we only need it on onepage of the account
434 settings, not the account wizard.
435 (I wrote the wrong instructions in the bug.)
437 * src/maemo/easysetup/modest-easysetup-wizard.c:
438 Added scrollbars to account wizard dialog.
439 Fixed projects.maemo.org NB #62744
441 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
443 * src/maemo/easysetup/modest-easysetup-wizard.c:
444 (create_page_user_details):
445 Use auto-cap for name (projects.maemo.org NB#63716)
446 * src/widgets/modest-account-view.c: (on_account_busy_changed):
448 2007-07-22 Armin Burgmeier <armin@openismus.com>
450 * src/maemo/modest-ui-actions.c: Use current account instead of
451 default account for creating viewer windows, so that the viewer
452 window knows to which account the viewed message belongs.
454 * src/maemo/modest-msg-view-window.c: Destroy the window when the
455 corresponding account is deleted. This fixes projects.maemo.org bug
458 2007-07-18 Armin Burgmeier <armin@openismus.com>
460 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
461 the dialog close after entering an invalid port number and clicking
462 OK. This fixes projects.maemo.org bug NB#63602.
464 2007-07-18 Armin Burgmeier <armin@openismus.com>
466 * src/modest-tny-account-store.c:
467 (get_server_accounts): Set parent modest account name for each
468 connection-specific transport account so that special folders of such
469 an account can be looked up. This fixes a crash when changing account
470 settings. This might also be related to projects.maemo.org bug
473 2007-07-16 Armin Burgmeier <armin@openismus.com>
475 * src/modest-ui-actions.c: Added a button to create a folder to the
476 move-to dialog. This fixes projects.maemo.org bug NB#.
478 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
480 * src/maemo/easysetup/modest-easysetup-wizard.c:
481 Added scrollbars to account wizard dialog.
482 Fixed projects.maemo.org NB #62744
484 2007-07-16 Murray Cumming <murrayc@murrayc.com>
486 * src/widgets/modest-msg-view.h:
487 * src/widgets/modest-msg-view.c:
488 Added modest_msg_view_get_message_is_empty() but this needs
490 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
491 Check if there is any text in the message yet.
492 But this needs to be implemented properly.
493 (modest_msg_edit_window_toggle_find_toolbar):
494 * src/maemo/modest-msg-view-window.c:
495 (modest_msg_view_window_toggle_find_toolbar):
496 Show a banner warning if there is no text to search, when
497 trying to start a search. This partially fixes
498 projects.maemo.org bug NB#62350.
500 2007-07-13 Murray Cumming <murrayc@murrayc.com>
502 * src/modest-mail-operation.c: (update_account_thread):
503 Initialized num_new_headers to fix the build.
505 2007-07-13 Murray Cumming <murrayc@murrayc.com>
507 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
508 Ignore modest accounts whose server accounts don't exist in gconf.
509 This prevents us trying to create TnyAccount instances for those
510 server accounts when the server account has been removed from gconf,
511 but the parent modest account has not yet been removed from modest.
512 I don't know why this is only noticeable now. It was probably just
513 a harmeless g_warning() anyway.
515 2007-07-13 Murray Cumming <murrayc@murrayc.com>
517 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
518 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
520 2007-07-12 Armin Burgmeier <armin@openismus.com>
522 * src/maemo/modest-main-window.c: Make default account appear bold
523 in view, tools/send & receive and toolbar/send & receive SCM menus.
524 This fixes projects.maemo.org bug NB#59010.
526 2007-07-12 Murray Cumming <murrayc@murrayc.com>
528 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
529 Add a short-cut, by checking if the folder store is an account.
530 This ensures that the Sort menu item and toolbar is dimmed for
531 the local-folders account root item, fixing
532 projects.maemo.org bug NB#62545.
534 2007-07-12 Murray Cumming <murrayc@murrayc.com>
536 * src/modest-tny-account-store.c: (get_password):
537 Show the password dialog (via the signal) only in the mainloop, via
538 an idle handler that we wait for. This could theoretically prevent
539 hangs, though I worry that it could introduce some too.
541 2007-07-12 Murray Cumming <murrayc@murrayc.com>
543 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
544 * src/maemo/modest-platform.c:
545 (modest_platform_connect_and_wait):
546 Take a TnyAccount* parameter and try to set it to online
547 (a TnyCamel-only API), because tinymail sets accounts to offline
548 when the user cancels a password dialog, and doesn't ask again until
549 it has been set to online.
550 However, this is commented out because it causes a hang now.
552 (modest_platform_connect_and_wait_if_network_account):
553 * src/modest-mail-operation.c:
554 (modest_mail_operation_update_account):
555 * src/modest-platform.h:
556 * src/modest-ui-actions.c: (_modest_ui_actions_open),
557 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
559 2007-07-12 Armin Burgmeier <armin@openismus.com>
561 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
563 * src/modest-mail-operation.c:
564 * src/modest-ui-actions.c: Check for already existing folder before
565 querying the server, show error message from camel if the request
566 still fails. This fixes projects.maemo.org bug NB#58701.
568 2007-07-12 Murray Cumming <murrayc@murrayc.com>
570 * src/modest-tny-account-store.h:
571 * src/modest-tny-account-store.c:
572 Added modest_tny_account_store_forget_password_in_memory(),
573 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
574 when creating a new account, so that new passwords will be used, instead of
575 us thinking that it's a second request as a result of a failed password again.
577 2007-07-12 Murray Cumming <murrayc@murrayc.com>
579 * src/dbus_api/modest-dbus-callbacks.c:
580 (on_idle_open_message): If the message is in drafts then open it
581 in an edit window instead of a view window. This fixes
582 projects.maemo.org bug NB#63005.
584 2007-07-12 Murray Cumming <murrayc@murrayc.com>
586 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
587 Avoided a harmless g_warning().
589 2007-07-12 Murray Cumming <murrayc@murrayc.com>
591 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
592 Pass the modest account name, not the TnyAccount display name to
593 modest_msg_view_window_new() so that the reply feature works,
594 fixing projects.maemo.org bug NB#62892.
596 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
597 (modest_msg_view_window_new_with_header_model):
598 * src/maemo/modest-msg-view-window.c:
599 (modest_msg_view_window_new_with_header_model),
600 (modest_msg_view_window_new):
601 * src/modest-ui-actions.c: (reply_forward):
602 * src/widgets/modest-msg-view-window.h:
603 * src/widgets/modest-window.c: (modest_window_set_active_account):
604 Rename an account parameter to modest_account_name to make this clearer.
606 2007-07-11 Murray Cumming <murrayc@murrayc.com>
608 * src/modest-ui-actions.h:
609 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
610 modest_do_message_delete().
611 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
612 Call modest_do_message_delete(), hoping that this would cause messages
613 to be really deleted from search instead of just marked with strike through.
614 Does not seem to help.
616 2007-07-11 Armin Burgmeier <armin@openismus.com>
618 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
619 priv->reselect to FALSE prior to calling
620 modest_folder_view_select_first_inbox_or_local() to prevent endless
621 recursion and thus a crash on startup.
623 2007-07-11 Armin Burgmeier <armin@openismus.com>
625 * src/maemo/modest-account-settings-dialog.h: Include
626 <gtk/gtknotebook.h> to fix the build (at least for me).
628 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
629 Use "New FolderN" as default suggested name if "New folder" already
630 exists, with N being the first free number, though never exceed "New
631 folder99" in which case we just fall back to "New Folder" even though
632 it already exists. This fixes projects.maemo.org bug NB#58663.
634 2007-07-11 Murray Cumming <murrayc@murrayc.com>
636 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
637 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
638 projects.maemo.org bug NB#62778.
640 2007-07-11 Murray Cumming <murrayc@murrayc.com>
642 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
643 Ignore the wrong (for now) secure-smtp setting in the presets -
644 just default to requiring secure authentication for SMTP, because
647 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
649 * src/widgets/modest-folder-view.c: (filter_row)
650 Do not show drafts folder (see UI specs)
652 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
654 * src/modest-ui-actions.c:
655 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
656 place and also not necessary.
658 * src/widgets/modest-folder-view.c: (filter_row)
659 Guess folder type and hide Sent & Outbox if necessary.
660 Fixed project.maemo.org NB#57328
662 2007-07-11 Murray Cumming <murrayc@murrayc.com>
664 * src/modest-ui-actions.h:
665 * src/modest-ui-actions.c:
666 (modest_ui_actions_on_delete_message):
667 Move some code into a new
668 modest_ui_actions_refresh_message_window_after_delete()
669 function so we can use it from elsewhere.
671 * src/dbus_api/modest-dbus-callbacks.c:
672 (on_idle_delete_message), (on_delete_message): Used an idle
673 handler, as we do for the other D-Bus method handlers.
674 Call modest_ui_actions_refresh_message_window_after_delete()
675 if the deleted message was open in a window. This fixed
676 projects.maemo.org bug NB#62862.
678 2007-07-11 Murray Cumming <murrayc@murrayc.com>
680 * src/modest-main.c: (main): Only show the UI at the start if
681 the showui command line option was given. For instance,
682 run-standalone src/modest showui
683 Otherwise, we wait for the top_application D-Bus method to
684 be sent by hildon-desktop when the application is selected
686 This allows us to run without a UI when osso-global-search
687 uses our D-Bus methods.
689 2007-07-11 Murray Cumming <murrayc@murrayc.com>
691 * src/dbus_api/modest-dbus-api.h: Added a define for a
692 top-application D-Bus method.
693 * src/dbus_api/modest-dbus-callbacks.c:
694 (on_top_application),
695 (modest_dbus_req_handler): Handle the top-application D-Bus
696 method, which might be an undocumented D-Bus signal sent by
697 hildon-desktop when it starts the application from the menu.
698 But I am not sure and I need to test it on the device, because
699 my scratchbox does not have the application in the menu now.
700 This method shows the main window, so that it can be invisible
701 when started, for instance, just for email searching from
704 * src/maemo/modest-main-window.c: (restore_settings),
705 (modest_main_window_new): Do not show the window immediately
706 upon creation. We show it later.
707 * src/modest-widget-memory.c: (save_settings_paned):
708 Try (unsuccessfully) to avoid saving the paned position when
709 it is not even visible.
710 (restore_settings_paned): Do not allow a silly paned position.
711 This seems necessary when not showing the window at first.
713 * tests/dbus_api/Makefile.am:
714 * tests/dbus_api/test_top_application.c: (main): Test for the
717 2007-07-10 Murray Cumming <murrayc@murrayc.com>
719 * src/modest-ui-dimming-rules.c:
720 (modest_ui_dimming_rules_on_new_msg),
721 (modest_ui_dimming_rules_on_reply_msg),
722 (modest_ui_dimming_rules_on_delete_msg),
723 (modest_ui_dimming_rules_on_details),
724 (modest_ui_dimming_rules_on_view_window_move_to),
725 (modest_ui_dimming_rules_on_view_previous),
726 (modest_ui_dimming_rules_on_view_next),
727 (_invalid_folder_for_purge): Added checks before
728 casting the window. This looks like an actual
729 logic error in _invalid_folder_for_purge(), because it
730 tries to use a ModestMainWindow as a message window.
732 2007-07-10 Murray Cumming <murrayc@murrayc.com>
734 * src/maemo/modest-account-settings-dialog.c:
735 (show_error): Use the same implementation as in
736 modest-easysetup-wizard.c:
737 (on_entry_invalid_character): The logical ID contains a %s.
738 Guessed what it should be.
739 (on_entry_max), (check_data), (on_response): Adapt to
740 changed show_error().
741 (create_page_account_details): Really call
742 modest_validating_entry_set_func() on the correct widgets.
743 * src/maemo/easysetup/modest-easysetup-wizard.c:
744 (on_entry_invalid_character): Fix the logical ID here too.
745 (create_page_account_details),
746 (create_page_user_details):
748 modest_validating_entry_set_func() on the correct widgets.
750 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
751 Do not try to use the account if it is NULL.
753 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
755 * src/modest-ui-actions.c: (create_move_to_dialog),
756 (modest_ui_actions_on_main_window_move_to),
757 (modest_ui_actions_on_msg_view_window_move_to):
758 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
759 (filter_row), (modest_folder_view_show_non_move_folders):
760 * src/widgets/modest-folder-view.h:
762 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
763 the Sent folder yet as it does not report the correct folder type.
765 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
767 * src/maemo/modest-msg-edit-window.c: (init_window):
770 2007-07-10 Murray Cumming <murrayc@murrayc.com>
772 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
773 Take a parent widget instead of a parent window, and
774 implement this with hildon_banner_show_information() instead.
775 Non-Maemo builds can just ifdef that there.
776 This fixed projects.maemo.org bug NB#62766.
778 (on_entry_invalid_character): Use show_error() again instead
779 of using hildon directly, and use the _CS() macro to use the correct
781 (create_account), (check_for_supported_auth_methods), (on_entry_max):
782 Pass a widget instead od a window to show_error().
784 2007-07-10 Murray Cumming <murrayc@murrayc.com>
786 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
787 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
788 This allows us to show the server name in the error message, fixing
789 projects.maemo.org bug NB#62904.
790 Also, use the appropriate logical ID message for the account protocol.
792 2007-07-10 Murray Cumming <murrayc@murrayc.com>
794 * src/modest-tny-account-store.c: (on_idle_wrong_password):
795 A compilation fix, though the build wasn't broken for me.
797 2007-07-09 Murray Cumming <murrayc@murrayc.com>
799 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
800 Do not try to unref a NULL folder store, to avoid a runtime warning.
801 This seems to happen sometimes when changing accounts settings.
803 2007-07-09 Murray Cumming <murrayc@murrayc.com>
805 * src/modest-tny-account-store.c:
806 (modest_tny_account_store_instance_init),
807 (modest_tny_account_store_finalize),
808 (on_account_settings_hide), (on_idle_wrong_password):
809 Use a GHashTable to ensure that we only show one account settings
810 dialog per modest account. This avoids us having a dialog open for
811 both the store and transport accounts, or due to repeated get_password()
812 calls that shouldn't happen anyway.
814 2007-07-09 Murray Cumming <murrayc@murrayc.com>
816 * src/maemo/modest-maemo-utils.c: (on_hide),
817 (modest_maemo_show_dialog_and_forget): Handle the response, because
818 the window is not even hidden by default.
820 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
821 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
822 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
823 which seems to prevent some modality problems.
825 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
826 Ignore user cancellation errors.
828 * src/modest-account-mgr-helpers.h:
829 * src/modest-account-mgr-helpers.c:
830 Added modest_server_account_get_password() and
831 modest_server_account_get_has_password() to avoid direct use of
834 * src/maemo/modest-account-settings-dialog.h:
835 * src/maemo/modest-account-settings-dialog.c:
836 (modest_account_settings_dialog_init): Store the notebook so we can
838 Added modest_account_settings_dialog_switch_to_user_info().
840 * src/modest-tny-account-store.c:
841 (get_password): When the password in the account settings is wrong (we think),
842 show the relevant page of the account settings dialog, in the mainloop.
843 However, we currently get many of these at once because cancel does not
845 (forget_password): Do not forget the password
846 from the account settings, because this causes side-effects when
847 tinymail seems to call it at strange time, maybe because of how we
848 are cancelling get_password().
849 (modest_tny_account_store_alert): Ignore user cancellations.
851 2007-07-09 Murray Cumming <murrayc@murrayc.com>
853 * src/maemo/modest-maemo-utils.h:
854 * src/maemo/modest-maemo-utils.c:
855 Added modest_maemo_show_information_note_and_forget() for use instead of
856 gtk_dialog_run() when the response is not needed, to avoid an extra
857 mainloop which could cause a hang.
859 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
860 Use the logical IDs for the error message, though they are not
861 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
862 because gtk_dialog_run() caused a hang here (the window did not close).
863 This fixes projects.maemo.org bug NB#62646.
865 2007-07-09 Murray Cumming <murrayc@murrayc.com>
867 * src/modest-account-mgr-helpers.h:
868 * src/modest-account-mgr-helpers.c:
869 Added modest_account_mgr_get_store_protocol().
871 * src/maemo/modest-account-view-window.c:
872 (on_delete_button_clicked): Show different warning text depending on
873 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
874 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
877 2007-07-09 Murray Cumming <murrayc@murrayc.com>
879 * src/maemo/modest-msg-edit-window.c:
880 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
881 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
883 2007-07-07 Armin Burgmeier <armin@openismus.com>
885 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
886 ckdg_ib_maximum_characters_reached from correct package.
888 * src/modest-ui-actions.c: Show an error message when a folder could
889 not be created. Tinymail does not give us specific error codes about
890 what has gone wrong, so we assume that a folder with that name
891 already exists, though there might be other reasons.
893 2007-07-06 Murray Cumming <murrayc@murrayc.com>
895 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
896 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
897 give a more exact error message that can be partly translated.
899 2007-07-05 Murray Cumming <murrayc@murrayc.com>
901 * src/maemo/modest-address-book.c:
902 (select_email_addrs_for_contact): Specify a default window size for the
903 select-email-address dialog, so that it is probably big enough for the
904 title. This should fix projects.maemo.org bug NB#62277.
906 2007-07-05 Murray Cumming <murrayc@murrayc.com>
908 * src/maemo/easysetup/modest-easysetup-wizard.c:
909 (create_page_complete_easysetup): Use
910 gtk_widget_set_size() request to ensure that the text wraps
913 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
915 * src/maemo/easysetup/modest-easysetup-wizard.c:
916 (on_entry_invalid_character), (create_page_account_details),
917 (create_page_user_details):
918 Use new API of ModestValidatingEntry. But for some reason the banner is
919 not shown. I will have to investigate that further.
921 * src/widgets/modest-validating-entry.c: (on_insert_text),
922 (modest_validating_entry_set_func):
923 * src/widgets/modest-validating-entry.h:
924 Added a new callback function to be able to react to prevented
925 characters whitespaces to e.g show a banner.
927 2007-07-05 Armin Burgmeier <armin@openismus.com>
929 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
930 notification of HildonNumberEditor instead of remembering the port
931 number. Thanks to Johannes for pointing this out.
933 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
935 * src/maemo/easysetup/modest-easysetup-wizard.c:
936 Check if there are any user changes before showing a confirmation
937 dialog (projects.maemo.org NB#60946)
939 2007-07-05 Armin Burgmeier <armin@openismus.com>
941 * src/maemo/modest-account-settings-dialog.c: Remember custom port
942 number at the beginning of the dialog and set the modified flag at the
943 end if the port number has changed. This is necessary because
944 HildonNumberEditor does not support notification when the value has
947 2007-07-05 Murray Cumming <murrayc@murrayc.com>
949 * src/modest-ui-actions.c:
950 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
951 a connection before asking anything else. Correct the check for the destination
952 folder so that it succeeds when online.
953 This fixed projects.maemo.org bug NB#61645.
955 2007-07-05 Murray Cumming <murrayc@murrayc.com>
957 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
958 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
959 to fix projects.maemo.org bug NB#62439.
961 2007-07-05 Murray Cumming <murrayc@murrayc.com>
963 * src/modest-tny-account.c: (on_connection_status_changed):
964 Really do not use tny_device_force_offline() here. See the previous comment.
966 2007-07-04 Murray Cumming <murrayc@murrayc.com>
968 * src/modest-tny-account.c: (on_connection_status_changed):
969 Do not use tny_device_force_offline() when tinymail says that something
970 went wrong with the connection. It seems to report this unnecessarily.
972 2007-07-04 Murray Cumming <murrayc@murrayc.com>
974 * src/maemo/modest-connection-specific-smtp-window.c:
975 (modest_connection_specific_smtp_window_init):
976 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
977 does not seem to have any effect in osso 1.1 (though it works in
978 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
980 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
982 * src/maemo/modest-connection-specific-smtp-window.c:
983 Fix UI specification problems with projects.meamo.org NB#60479
985 2007-07-04 Murray Cumming <murrayc@murrayc.com>
987 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
988 clue when this has failed, because the error dialog is not always shown
989 (at least in earlier version).
991 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
992 GError message, because the generic error dialog is not helpful.
994 'This message is not currently available (can't let a new connection go online)'
995 when trying to open an IMAP message.
997 (_modest_ui_actions_open): Offer a connection when some messages would
998 have to be downloaded and we are offline.
1000 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1002 * src/widgets/modest-folder-view.c:
1003 Don't check for MERGE type anymore as we use the correct type
1005 NOTE: For the last two changes you need to update your tinymail copy
1006 because of API changes!
1008 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1010 * src/modest-tny-local-folders-account.c:
1011 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
1012 (see projects.maemo.org NB#61580)
1014 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1016 * src/modest-tny-account.c: (on_connection_status_changed):
1017 Commented out the call to modest_platform_connect_and_wait() because this
1018 seems to always hang, and I would like to know if this is the only thing
1019 that causes a hang when showing the connection dialog.
1020 It is not very useful anyway.
1022 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1024 * src/maemo/modest-msg-view-window.c:
1025 (modest_msg_view_window_select_next_message):
1027 * src/modest-platform.h:
1028 * src/maemo/modest-platform.c:
1029 Added modest_platform_connect_and_wait(), which calls
1030 tny_maemo_conic_device_connect() always in the main thread, by calling it
1031 in an idle handler and waiting for the idle handler to run. It should be
1032 in the main thread because it uses GTK+ UI code. It just returns TRUE
1033 if the device is already online.
1035 There is some nasty code to ensure that subsequent calls to
1036 modest_platform_connect_and_wait() just wait for the first one to finish,
1037 by checking repeatedly in another idle handler. This is necessary,
1038 because other threads (or even the main thread, via another idle handler)
1039 can call modest_platform_connect_and_wait() while
1040 modest_platform_connect_and_wait() is running.
1042 (modest_platform_connect_and_wait_if_network_account),
1043 (modest_platform_connect_and_wait_if_network_folderstore):
1044 Convenience functions that calls modest_platform_connect_and_wait() if
1045 the account or folder might want network access.
1047 * src/modest-mail-operation.c:
1048 (modest_mail_operation_update_account):
1049 * src/modest-ui-actions.c: (download_uncached_messages),
1050 (modest_ui_actions_on_rename_folder), (delete_folder),
1051 (modest_ui_actions_on_main_window_move_to),
1052 (modest_ui_actions_on_msg_view_window_move_to):
1053 * src/widgets/modest-folder-view.c:
1054 (drag_and_drop_from_folder_view):
1055 Offer a connection if we are offline.
1057 * src/modest-tny-account.c: (on_connection_status_changed):
1058 Document this as only handling errors during network operations in progress,
1059 and replace the idle code with a simple call to
1060 modest_platform_connect_and_wait(), which does this instead.
1062 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1064 * src/modest-tny-account.c:
1065 (modest_tny_account_get_special_folder): (util_on_idle),
1066 Handle the GError so we can see when tny_folder_store_get_folders()
1067 fails, as it currently does while something else is connecting.
1069 Added util_run_in_main_thread_and_wait()
1070 which uses an idlen handler and mainloop to ensure that the function
1071 is called in the main thread.
1072 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
1073 to make sure that we call attempt the connection in the mainloop only,
1074 which might solve some hangs.
1076 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1078 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
1079 be found by their display name. This is never useful.
1080 * src/modest-tny-account-store.c: (on_account_removed): Find the account
1081 by its ID, instead of trying to use its ID as its display name.
1083 * src/modest-tny-account-store.h:
1084 * src/modest-tny-account.c:
1085 (modest_tny_account_get_special_folder): Add a g_warning() when
1086 tny_folder_store_get_folders() returns an empty list for the maildir.
1088 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
1089 Add a g_warning() when this returns NULL, because that it not allowed
1092 2007-07-02 Armin Burgmeier <armin@openismus.com>
1094 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
1095 note when trying to cancel the wizard. This fixes projects.maemo.org
1098 2007-07-02 Murray Cumming <murrayc@murrayc.com>
1100 * src/modest-tny-account.h:
1101 * src/modest-tny-account.c:
1102 (modest_tny_account_new_from_server_account),
1103 (modest_tny_account_new_from_server_account_name),
1104 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
1105 because this must now be set before setting the proto. This is usd in
1106 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
1107 warning in camel_session_get_service() caused by
1108 tny_camel_transport_account_prepare().
1110 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
1113 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
1115 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1117 (modest_connection_specific_smtp_edit_window_init):
1119 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
1120 of "changed" for now
1122 2007-06-29 Murray Cumming <murrayc@murrayc.com>
1124 * src/modest-tny-account.c:
1125 (modest_tny_account_new_from_server_account):
1126 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
1127 now uses to request a connection when it needs one, and which it uses
1128 to tell us that something is wrong with the connection, so we can force
1129 the accounts offline to prevent further problems.
1131 * src/modest-defs.h:
1132 * src/modest-init.c: (init_default_settings):
1133 * src/modest-mail-operation.c:
1134 (modest_mail_operation_update_account):
1135 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
1136 This should not be necessary anymore. Do not set the conf key that
1137 determined this (it was always TRUE and not set anywhere else).
1139 * src/modest-ui-actions.h: Remove unused and unimplemented
1140 modest_ui_actions_on_online_toggle_toggled().
1142 2007-06-29 Murray Cumming <murrayc@murrayc.com
1144 * src/maemo/modest-main-window.c: (connect_signals):
1145 Don't connect to delete_event twice. Maybe this was harmless.
1147 2007-06-29 Murray Cumming <murrayc@murrayc.com
1149 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
1150 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
1151 Debug output to give some more clue when a folder move is not allowed.
1153 2007-06-28 Murray Cumming <murrayc@murrayc.com
1155 * src/modest-tny-account.c: (on_modest_file_system_info),
1156 (modest_tny_account_get_mmc_account_name):
1157 Always call the callback, without checking whether the name has changed.
1158 * src/widgets/modest-folder-view.c: (strings_are_equal),
1159 (on_model_foreach_set_name), (on_get_mmc_account_name),
1160 (text_cell_data): Compare the name here, and use the name from
1161 the account rather than from the
1162 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
1163 if the name was changed after the account was added to the model.
1164 That's a tinymail bug but not one that I want to fix now.
1166 This finally fixes projects.maemo.org bug NB#59301.
1168 2007-06-27 Armin Burgmeier <armin@openismus.com>
1170 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
1173 2007-06-27 Murray Cumming <murrayc@murrayc.com
1175 * src/modest-tny-account.h:
1176 * src/modest-tny-account.c:
1177 Added modest_tny_account_get_mmc_account_name(), to set the memory
1178 card name asynchronously for the given account and then notify.
1179 (modest_tny_account_new_for_local_folders): Use this new function instead
1180 of using hildon_file_system_info_async_new() directly.
1182 * src/widgets/modest-folder-view.c: (text_cell_data):
1183 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
1184 gtk_tree_model_row_changed() when it is available.
1186 This should fix projects.maemo.org bug NB#59301.
1188 2007-06-27 Murray Cumming <murrayc@murrayc.com
1190 * src/modest-mail-operation.c: (update_account_thread),
1191 (get_msgs_full_thread): Fix typo failures in the revert
1194 2007-06-27 Murray Cumming <murrayc@murrayc.com
1196 * src/maemo/modest-maemo-global-settings-dialog.c:
1197 (idle_select_default_focus):
1198 * src/modest-mail-operation.c: (idle_notify_progress),
1199 (idle_notify_progress_once), (set_last_updated_idle),
1200 (update_account_thread), (get_msgs_full_thread):
1201 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1202 * src/widgets/modest-header-view.c:
1203 (idle_notify_headers_count_changed_destroy),
1204 (idle_notify_headers_count_changed):
1205 Reverted the additions of gdk_threads_enter/leave(), in case this
1206 helps with a startup hang on the device.
1208 2007-06-26 Armin Burgmeier <armin@openismus.com>
1210 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
1211 for supported secure authentication methods from server by
1212 gtk_dialog_run(), saving CPU time and a potential race condition.
1214 2007-06-26 Armin Burgmeier <armin@openismus.com>
1216 * src/maemo/modest-maemo-utils.h:
1217 * src/maemo/modest-maemo-utils.c: Added a
1218 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
1219 only error code to tell the calling code when the user canceled the
1222 * src/maemo/modest-account-settings-dialog.h:
1223 * src/maemo/modest-account-settings-dialog.c:
1224 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
1225 message if the retrieval of secure authentication methods was canceled
1226 by the user. Perform the check before saving anything to configuration
1227 to not end up with half-committed configuration changes, do not show
1228 a "Saving to configuration failed" note when authentication methods
1229 could not be retrieved.
1231 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
1234 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1236 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1237 Only return the first level of folders under accounts, because the
1238 osso-global-search UI spec doesn't want the rest.
1239 This fixed projects.maemo.org bug NB#61811.
1241 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1243 * src/modest-tny-account-store.c:
1244 * src/modest-tny-account-store.h:
1245 Added modest_tny_account_is_memory_card_account().
1246 * src/maemo/modest-main-window.c: (create_details_widget):
1247 Show the same information items for the memory card as we show for the
1248 local-folders, to fix projects.maemo.org bug NB#59307.
1250 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1252 * src/modest-tny-account-store.c: (get_password):
1253 Added some checks for NULL to maybe prevent crashes, though I think
1254 it was Philip's last commit that actually prevented the crash here
1255 when creating a first new account.
1256 But the new account is still not usable (no messages are shown)
1257 until a restart of the application.
1259 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1261 * src/maemo/modest-maemo-global-settings-dialog.c:
1262 (idle_select_default_focus):
1263 * src/modest-mail-operation.c: (idle_notify_progress),
1264 (idle_notify_progress_once), (idle_notify_update_account_queue),
1265 (set_last_updated_idle), (update_account_thread),
1266 (notify_get_msgs_full), (get_msgs_full_destroyer),
1267 (get_msgs_full_thread):
1268 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1269 * src/widgets/modest-header-view.c:
1270 (idle_notify_headers_count_changed_destroy),
1271 (idle_notify_headers_count_changed):
1272 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1273 all idle handlers, because some other thread could be blocking
1274 the GDK lock, so that it can do GUI stuff.
1276 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1278 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1279 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1280 (on_idle_send_receive), (on_idle_open_default_inbox):
1281 * src/maemo/modest-msg-edit-window.c:
1282 (modest_msg_edit_window_attach_file_noninteractive):
1283 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1284 to prevent a hang. I don't quite understand why these are necessary,
1285 beause we should already be in the main loop. I guess something outside
1286 of the main loop is taking the lock.
1288 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1289 we are really using URIs, and use files that are more likely to exist.
1291 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1293 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1294 necessary because configure.ac now defines different variables.
1296 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1298 * libmodest-dbus-client/libmodest-dbus-client.c:
1299 * libmodest-dbus-client/libmodest-dbus-client.h:
1300 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1301 libmodest_dbus_client_compose_mail() is what things actually use.
1303 * src/dbus_api/modest-dbus-api.h:
1304 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1305 * tests/dbus_api/Makefile.am:
1306 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1309 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1311 * src/modest-init.c: (modest_init_local_folders):
1312 For memory-card (or other non local-folders) maildir accounts,
1313 always create an Archive folder, so that there is somewhere to put
1314 messages. This should be less confusing, because the user does not need
1315 to guess that the need to create a folder.
1317 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1319 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1320 Fixed icon size by using (50, 50) which is the same as defined by
1323 2007-06-25 Armin Burgmeier <armin@openismus.com>
1325 * src/widgets/modest-window-mgr.c:
1326 * src/modest-init.c:
1327 * configure.ac: Correctly recognize hildon-notify presence and fixed
1328 the build without it being installed.
1330 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1332 * libmodest-dbus-client/libmodest-dbus-client.c:
1333 (libmodest_dbus_client_search): Fix the build. Sorry.
1334 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1335 (reply_forward_cb): Initialize variables to fix the build.
1337 * src/modest-tny-account-store.c:
1338 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1339 comparison (a silly typo) so that email search results can be opened
1340 when there are more than one account.
1342 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1344 * libmodest-dbus-client/libmodest-dbus-client.c:
1345 (libmodest_dbus_client_search),
1346 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1347 instead of 1 second, because the search gets folders and messages from
1348 the server, which can take a long time. When it times out,
1349 osso-global-search will report no results.
1351 We need to specify whether we should search only cached information
1352 (maybe with a user preference), and the osso-email-search-plugin
1353 API should really be improved to allow that option, and to allow results
1354 to be delivered asynchronously in batches.
1356 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1358 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1359 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1360 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1362 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1364 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1365 that is an empty string. D-Bus seems to give us these instead of NULL.
1367 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1369 * src/dbus_api/modest-dbus-callbacks.c:
1370 * src/maemo/easysetup/modest-easysetup-wizard.h:
1371 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1372 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1373 (modest_connection_specific_smtp_edit_window_init):
1374 * src/maemo/modest-maemo-global-settings-dialog.c:
1376 * src/maemo/modest-maemo-utils.c:
1377 (modest_maemo_utils_setup_images_filechooser):
1378 * src/maemo/modest-main-window.c: (create_details_widget):
1379 * src/maemo/modest-msg-edit-window.c:
1380 (modest_msg_edit_window_attach_file_noninteractive),
1381 (modest_msg_edit_window_color_button_change),
1382 (modest_msg_edit_window_set_zoom):
1383 * src/modest-mail-operation.c: (update_account_thread):
1384 * src/modest-tny-account-store.c:
1385 * src/modest-tny-account.c:
1386 * src/widgets/modest-global-settings-dialog.c:
1387 * src/widgets/modest-window.h:
1389 Fixed build on bora!
1391 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1393 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1394 * src/modest-search.c: (modest_search_folder),
1395 (modest_search_all_accounts): Actually search only in the specified folder,
1396 doing a simple match on the folder ID.
1397 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1398 and added some documentation.
1400 2007-06-22 Armin Burgmeier <armin@openismus.com>
1402 * src/maemo/modest-maemo-utils.h:
1403 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1404 modest_maemo_utils_get_supported_secure_authentication_methods.
1406 * src/maemo/easysetup/modest-easysetup-wizard.c:
1407 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1408 one occured, not just "Server does not support secure authentication".
1410 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1412 * src/modest-tny-account-store.c: (get_password):
1413 Restored the call to tny_account_set_user() because Philip seems to have
1414 stopped this from crashing (by not using the freed string). It still does
1415 not work, but now we can test it.
1417 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1419 * src/maemo/modest-msg-edit-window.c: (init_window):
1420 Comment out use of an uninitialzed GtkScrolledWindow variable,
1421 to fix the build and stop a crash. Yet again.
1423 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1425 * src/modest-tny-account-store.c: (get_password):
1426 Remove the call to tny_account_set_user() because this actually crashes.
1427 As mentioned in the last commit, it is known to not work anyway.
1429 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1431 * src/modest-tny-account-store.c: (get_password):
1432 Use tny_account_set_username() to tell tinymail that the username might
1433 have changed too. But tinymail ignores this: see projects.maemo.org
1435 * src/modest-ui-actions.c:
1436 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1437 reset the connection when changing the username, and improve the comments.
1438 Save the changed username to gconf at least, so it is used when Modest is
1441 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1443 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1444 Do not use a query, so that we get all folders, including for POP and
1445 local-folders. They work as search criteria too.
1446 This fixes projects.maemo.org bug NB#57740.
1448 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1450 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1451 Comment out the use of hildon_notification_set_sound() because it is
1452 not declared, to fix the build. Warnings are serious, people.
1454 2007-06-21 Armin Burgmeier <armin@openismus.com>
1456 * src/maemo/modest-maemo-utils.h:
1457 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1458 modest_maemo_utils_get_supported_secure_authentication_methods()
1459 to query authentication methods for a specific user. This should fix
1460 projects.maemo.org bug NB#61369.
1462 * src/maemo/easysetup/modest-easysetup-wizard.c:
1463 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1466 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1468 * libmodest-dbus-client/libmodest-dbus-client.h:
1469 * libmodest-dbus-client/libmodest-dbus-client.c:
1470 (modest_dbus_message_iter_get_search_hit),
1471 (libmodest_dbus_client_search):
1472 Reorganised and commented this.
1473 Removed modest_search_hit_free() from the public API because it
1476 Added libmodest_dbus_client_get_folders() and
1477 modest_folder_result_list_free().
1479 * src/dbus_api/modest-dbus-api.h:
1480 * src/dbus_api/modest-dbus-callbacks.c:
1481 (modest_dbus_req_filter): Commented. Moved most code to
1482 on_dbus_method_search() and added on_dbus_method_get_folders().
1484 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1485 of the extra D-Bus handler.
1487 * tests/dbus_api/Makefile.am:
1488 * tests/dbus_api/test_get_folders.c: New test for
1489 libmodest_dbus_client_get_folders(). This seems to return an empty list
1490 at the moment. That could be the same error that causes the message list
1491 to be empty sometimes.
1492 This should help with projects.maemo.org bug NB#57740.
1494 2007-06-21 Armin Burgmeier <armin@openismus.com>
1496 * src/modest-mail-operation.c: Do not call
1497 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1498 notify the operation's end after having set the status to CANCELED for
1499 the operation queue to listen on. This fixes a deadlock when there
1500 were mail operations in the queue during its finalization.
1502 * src/modest-singletons.c: Reordered uninitialization of the account
1503 manager to happen after the mail operation queue was uninitialized
1504 because the mail operation's in the queue might still try to access
1505 the account manager (see modest_mail_operation_notify_end()). This
1506 fixes a potential crash when terminating the application.
1508 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1510 * src/modest-search.c:
1511 (search_mime_part_and_child_parts): Moved some code here so we
1512 can search recursively in child folders.
1513 (modest_search_folder): Search in the message as a mime part, instead
1514 of just its child mime parts.
1515 (read_chunk), (search_mime_part_ogs):
1516 Check how many bytes were read, to prevent an endless loop.
1517 Searching in message bodies now works. This finishes the fix for
1518 projects.maemo.org bug NB#61007.
1520 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1522 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1523 Add a g_warning when the item is not a folder.
1525 * src/modest-ui-dimming-rules.c:
1526 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1527 when selected item is not a folder (for instance, an account), because
1528 the UI spec only talks about folders.
1529 I am not sure what the UI spec wants, so this might not totally fix
1530 projects.maemo.org bug NB#60794.
1532 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1534 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1535 (load_from_file): Sort the list. The unsorted list would be more noticeable
1536 in non-English locales.
1538 * src/maemo/modest-msg-edit-window.c:
1539 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1540 warning and fix the build.
1542 * src/maemo/modest-progress-bar-widget.c:
1543 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1544 avoid a g_warning, and probably to avoid a crash.
1546 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1548 * src/modest-search.c: (modest_search_folder): Check for a GError
1549 when calling tny_folder_get_headers(), to show that this is not the cause
1552 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1554 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1555 Actually set the body query instead of the subject query.
1557 * src/modest-search.c: (search_mime_part_ogs),
1558 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1559 which would probably cause it to fail if we got this far.
1561 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1562 to simplify the code.
1563 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1564 be causing search-in-body to fail.
1566 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1568 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1570 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1571 Better debug message when the folder cannot be found.
1572 This should help with fixing projects.maemo.org bug #61287.
1573 * src/modest-search.c: (add_hit): Do not leak the furl string.
1575 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1577 * src/modest-ui-actions.c:
1578 (modest_ui_actions_on_folder_selection_changed):
1579 Do not special-case TNY_MERGE_FOLDER here, because
1580 modest_tny_folder_get_account() already does that. This fixes
1581 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1582 shown when the Outbox was selected).
1584 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1586 * libmodest-dbus-client/libmodest-dbus-client.c:
1587 (_dbus_iter_get_string_or_null): Initialize the string variable in
1588 case this helps with Dirk's crash.
1590 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1592 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1593 though it is not implemented yet (this function is maybe not even used),
1594 to avoid breaking ABI in future.
1595 * libmodest-dbus-client/libmodest-dbus-client.c:
1596 (get_attachments_string): Moved some code into this generic function.
1597 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1598 sends email. It is maybe not used.
1599 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1600 (on_send_mail): Use attachments.
1602 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1603 * src/maemo/modest-msg-edit-window.c:
1604 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1605 a filename before using it, to fix projects.maemo.org bug NB#58233.
1607 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1609 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1610 Initialize the continue_download variable to fix the build, and probably
1611 to fix randome behaviour.
1613 2007-06-18 Armin Burgmeier <armin@openismus.com>
1615 * src/modest-tny-send-queue.h:
1616 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1617 the queue so we can later show it in the UI. Replaced
1618 modest_tny_send_queue_msg_is_being_sent() by
1619 modest_tny_send_queue_get_msg_status().
1621 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1623 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1624 gpointer. This probably was not harmful, but just to be sure.
1626 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1628 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1629 Fix the build, but leave the function broken on Bora, because
1630 hildon_uri_action_get_service() does not exist.
1631 osso_uri_action_get_service() does not exist either, it seems.
1633 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1635 * src/modest-tny-account.c:
1636 (modest_tny_account_new_from_server_account):
1637 Uncommented the url debug output again, because it is useful for
1638 debugging, as I said in the comment.
1640 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1642 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1644 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1645 for Mameo Bora, to fix the build.
1647 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1650 Fixed build with hildon < 0.99
1652 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1653 Check if the selected account is busy instead of checking all accounts
1655 * src/modest-account-mgr-priv.h:
1656 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1657 (modest_account_mgr_init), (compare_account_name),
1658 (modest_account_mgr_set_account_busy),
1659 (modest_account_mgr_account_is_busy):
1660 * src/modest-account-mgr.h:
1661 Added busy information to the account manager. It possible to
1662 set an account to busy or not busy now.
1664 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1665 (modest_mail_operation_update_account),
1666 (modest_mail_operation_notify_end):
1667 Set the account to busy/not busy depending on the operation state.
1669 * src/widgets/modest-account-view.c:
1670 (modest_account_view_finalize), (get_last_updated_string),
1671 (update_account_view), (on_account_busy_changed), (init_view):
1672 Show string "Refreshing..." if the account is currently busy.
1674 All this fixes projects.maemo.org bug NB#59711
1676 2007-06-14 Armin Burgmeier <armin@openismus.com>
1678 * src/widgets/modest-attachments-view.h:
1679 * src/widgets/modest-attachments-view.c: Added
1680 modest_attachments_view_has_attachments() and fixed coordinate
1681 transformation in get_att_view_at_coords(). This fixes attachment
1684 * src/widgets/modest-msg-view.c: Make use of
1685 modest_attachments_view_has_attachments() to decide whether to show
1686 attachments in the header.
1688 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1690 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1691 (on_change), (on_combo_security_changed),
1692 (modest_connection_specific_smtp_edit_window_init),
1693 (modest_connection_specific_smtp_edit_window_set_connection),
1694 (modest_connection_specific_smtp_edit_window_is_dirty):
1695 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1696 * src/maemo/modest-connection-specific-smtp-window.c:
1699 Show an comfirmation dialog for the smpt-edit-window if there are
1700 unsaved changes and the user hits cancel.
1701 (projects.maemo.org bug NB#60479)
1703 2007-06-14 Armin Burgmeier <armin@openismus.com>
1705 * src/maemo/easysetup/modest-easysetup-wizard.c:
1706 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1707 address" info in banner instead of node, and select all the text as
1708 per UI spec. This fixes projects.maemo.org bug NB#60550.
1710 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1712 reviewed by: <delete if not using a buddy>
1714 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1715 * src/modest-ui-actions.c: (folder_refreshed_cb):
1717 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1719 * src/widgets/modest-folder-view.c: (filter_row):
1720 Explictly filter out the per-account outbox accounts. I don't know why
1721 these only sometimes show up, but now they should never show up in the UI.
1722 This should fix projects.maemo.org bug NB#60160.
1724 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1726 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1727 when the toolbar does not exist yet.
1728 * src/modest-widget-memory.c: (save_settings_header_view):
1729 Added g_warnings() to help us to discover when we are trying to set
1730 an empty columns list in gconf.
1732 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1734 * src/modest-init.h:
1735 * src/modest-init.c:
1736 Added modest_init_get_default_header_view_column_ids().
1738 * src/modest-widget-memory.c: (restore_settings_header_view):
1739 Use the new function to get defaults, if the gconf key is empty,
1740 instead of not creating any columns. This seems to fix the
1741 empty right-hand pane problems.
1743 * src/widgets/modest-header-view.h: Improved documentation.
1745 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1747 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1748 Revert the use of the display name as the account name, because this
1749 is generally wrong and would break the code that follows.
1751 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1753 * src/maemo/easysetup/modest-easysetup-wizard.c:
1754 (check_for_supported_auth_methods), (on_before_next),
1757 More correct fix for projects.maemo.org bug NB# 58991
1758 Do not longer accept AUTH_PASSWORD as secure method and choose
1759 correct method when creating the account.
1761 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1763 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1764 Fixed projects.maemo.org bug NB# 58991
1766 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1768 * src/modest-init.c: (modest_init_init_core),
1769 (modest_init_local_folders): Fixed compilation errors.
1771 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1773 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1774 Remove unnecessary lib/include, though it is good in principle when needed.
1776 * src/modest-init.c: (modest_init_one_local_folder),
1777 (modest_init_local_folders):
1778 * src/modest-init.h: Initialize the .modest library for memory cards,
1779 instead of just doing nothing for them. This should allow us to create
1780 folders there, fixing projects.maemo.org bug NB#59297.
1782 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1784 * libmodest-dbus-client/libmodest-dbus-client.c:
1785 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1786 (libmodest_dbus_client_compose_mail),
1787 (libmodest_dbus_client_open_message),
1788 (libmodest_dbus_client_send_and_receive),
1789 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1791 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1792 (on_idle_open_message), (modest_dbus_req_handler),
1793 (search_result_to_message), (modest_dbus_req_filter):
1794 * src/modest-search.c: (add_hit), (modest_search_folder),
1795 (modest_search_all_accounts): Improved debug messages.
1797 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1799 * src/modest-tny-account-store.c:
1800 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1803 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1806 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1808 * src/modest-tny-account-store.c: (get_server_accounts):
1809 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1810 even when there are no accounts, so that the Outbox folder is always
1811 visible. This fixes projects.maemo.org bug NB#60158.
1813 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1815 * src/maemo/modest-main-window.c: (create_details_widget):
1816 Use the mcen_va_never logical ID.
1818 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1820 * src/dbus_api/modest-dbus-api.h:
1821 * src/dbus_api/modest-dbus-callbacks.c:
1822 (on_idle_open_default_inbox), (on_open_default_inbox),
1823 (modest_dbus_req_handler):
1824 Added a new OpenDefaultInbox method.
1826 * libmodest-dbus-client/libmodest-dbus-client.h:
1827 * libmodest-dbus-client/libmodest-dbus-client.c:
1828 Added libmodest_dbus_client_open_default_inbox() to call the new
1829 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1830 though it should maybe be used by a new osso-email-interface function.
1832 * tests/dbus_api/Makefile.am:
1833 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1836 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1838 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1839 NULL, so that the signals get all the keys. This should not actually
1840 change any behaviour because we currently update everything when anything
1843 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1845 * src/widgets/modest-folder-view.c: (text_cell_data),
1846 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1847 (find_inbox_iter): If tinymail tells us that the folder is
1848 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1849 This causes the inbox to be selected at startup, fixing part of
1850 projects.maemo.org bug NB#56305.
1852 * src/modest-ui-dimming-rules.c:
1853 (modest_ui_dimming_rules_on_tools_smtp_servers):
1854 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1855 the SMTP servers menu item.
1856 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1857 that the SMTP Servers menu item is dimmed when there are no accounts,
1858 as a future version of the UI spec will require. This fixes
1859 projects.maemo.org bug NB#56305.
1861 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1863 * src/maemo/modest-maemo-utils.c:
1864 (modest_maemo_utils_get_supported_secure_authentication_methods):
1865 Added label to dialog instead of unreadable title
1867 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1868 (modest_main_window_new):
1869 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1872 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1873 * src/modest-account-mgr.h:
1874 Added method to avoid code duplication
1876 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1877 (modest_ui_actions_on_send_receive):
1878 Use modest_account_mgr_has_accounts
1880 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1882 * src/maemo/easysetup/modest-presets.c:
1883 (modest_presets_get_info_server_security): Do not report secure auth
1885 * src/modest-protocol-info.c: Use the defines for the gconf key names
1886 for secure authentication. This was not working because we were writing
1887 Password and reading password, and the check was case sensitive.
1888 With this, gmail now works for receiving and sending when created via
1891 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1893 * src/maemo/easysetup/modest-presets.c:
1894 (modest_presets_get_info_server_security): Correct the key name for
1895 SecureSmtp, because it seems to be case-sensitive.
1896 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1897 Do not try to get the 0th notebook page if there are 0 pages, to
1898 avoid a g_warning().
1900 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1902 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1903 Prevent use of the new notification feature for now, because it currently
1904 shows one dialog for each new email, which is annoying.
1906 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1908 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1909 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1910 when no country was selected, so that we show the global ones.
1911 * src/maemo/easysetup/modest-presets.c:
1912 (modest_presets_get_providers): Return only the global providers, not
1913 all providers when mmc=0 was requested.
1915 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1917 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1918 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1919 provider ID in the combo.
1921 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1922 Do not show the page numbers, because it would be confusing when we add
1923 the 2 extra pages for the custom setup, when the user chooses the "Other"
1924 provider. This fixes projects.maemo.org bug NB#59028
1926 * src/modest-init.c: (modest_init_init_core),
1927 (modest_init_local_folders):
1928 * src/modest-init.h:
1929 * src/modest-tny-account.c:
1930 (modest_tny_account_new_for_local_folders): Do not create default folders
1931 for the memory card. This should fix projects.maemo.org bug NB#59328.
1933 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1935 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1936 Free the changed_conf_keys string items. They are already freed in the
1937 idle handler if that runs first.
1939 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1941 * src/modest-ui-actions.c:
1942 (modest_ui_actions_on_password_requested): Check that the server name
1943 is not NULL, because I just saw a password dialog with (null) as the
1946 * src/modest-tny-folder.[h|c]: Added
1947 modest_tny_folder_is_memory_card_folder().
1948 * src/modest-ui-dimming-rules.c:
1949 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1950 menu item for memory cards, as per the UI spec (section 7.4). This should
1951 fix projects.maemo.org bug NB#59297.
1953 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1955 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1956 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1957 is another problem with the code, see Murray's comment at line 772)
1959 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1961 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1962 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1963 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1964 (load_from_file), (easysetup_country_combo_box_init),
1965 (easysetup_country_combo_box_get_active_country_ids),
1966 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1967 instead of just one ID, to avoid duplicate country names in the UI.
1969 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1970 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1971 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1972 a single ID, avoiding duplicate providers.
1973 * src/maemo/easysetup/modest-easysetup-wizard.c:
1974 (on_combo_account_country): Adapt to use a list.
1976 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1978 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1979 keys changed in the last X seconds.
1981 * src/modest-account-mgr.h:
1982 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1983 (on_key_change), (modest_account_mgr_class_init),
1984 (modest_account_mgr_init), (modest_account_mgr_finalize):
1985 As the keys are changed, save them in a GSList* and signal that GSList*
1986 further every X seconds, to batch changes, to allow us to do just one
1987 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1988 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1990 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1991 changed signal signature.
1993 * src/modest-conf.c: (modest_conf_set_list),
1994 (modest_conf_on_change): Reenable notification.
1996 (modest_conf_maemo_fake_on_change): Comment out the hack that
1997 notified immediately instead of asynchronously.
1999 * src/widgets/modest-account-view.h:
2000 * src/widgets/modest-account-view.c:
2001 (update_account_view): Select the previously-selected account ID,
2002 if possible. This fixes projects.maemo.org bug NB#56933.
2004 (on_account_changed), (on_account_removed),
2005 (modest_account_view_select_account):
2007 Remove the block/unblock functions
2008 because they were not useful.
2010 * src/maemo/modest-account-view-window.c:
2011 (on_delete_button_clicked), (on_edit_button_clicked),
2012 (on_new_button_clicked): Remove the use of the non-working block/unblock.
2014 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2016 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2017 Improve the error dialog to show Incorrect Account Settings, which seems
2018 clearer, and say that the internal error message (to be removed from the
2019 dialog later) is often misleading.
2020 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
2022 * src/modest-tny-account.c:
2023 (modest_tny_account_new_from_server_account): Uncomment the printf of the
2024 URL because this is so useful for debugging on the device.
2026 * src/widgets/modest-serversecurity-combo-box.c:
2027 (modest_serversecurity_combo_box_fill): Correct a logical ID.
2029 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2031 * src/modest-mail-operation.c:
2032 (modest_mail_operation_send_new_mail):
2033 Added a comment about a nasty but apparently harmless message. Details
2034 added to the wiki g_warnings() page.
2036 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2038 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
2039 (modest_tny_send_queue_class_init):
2040 Do not use the priv struct because it is empty, to avoid g_warnings
2041 about a non-existant priv struct.
2043 * src/modest-tny-account-store.c:
2044 (modest_tny_account_store_get_server_account),
2045 (modest_tny_account_store_get_transport_account_for_open_connection
2046 ): Do not try to get transport server accounts for local folders,
2047 because they don't have any. This avoids a g_warning().
2049 * src/maemo/modest-main-window.c:
2050 (modest_main_window_notify_send_receive_initied),
2051 (on_configuration_key_changed):
2052 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
2053 * src/modest-defs.h:
2054 * src/modest-mail-operation.c:
2055 (modest_mail_operation_update_account):
2056 * src/modest-tny-account-store.h:
2057 * src/modest-tny-account.c:
2058 (modest_tny_account_get_special_folder),
2059 (modest_tny_account_new_for_local_folders),
2060 (modest_tny_account_new_for_per_account_local_outbox_folder):
2061 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
2062 * src/modest-tny-local-folders-account.c:
2063 (add_account_folders_to_merged_folder):
2064 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
2065 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
2066 (modest_ui_actions_on_send):
2067 * src/widgets/modest-folder-view.c: (update_model):
2068 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
2069 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
2070 modest_tny_account_store_get_tny_account_by_account() to
2071 modest_tny_account_store_get_server_account() to make the code clearer.
2073 2007-06-07 Marcus Bauer <marcusb@openismus.com>
2075 * src/dbus_api/modest-dbus-api.h:
2076 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
2077 * src/maemo/modest-msg-edit-window.c:
2078 (modest_msg_edit_window_attach_file_noninteractive):
2079 added g_warning in case the file to be attached does not exist
2080 * tests/dbus_api/test_compose_mail.c: (main):
2081 removed obsolete comment, added generic files as test case
2083 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2085 * src/modest-tny-account-store.c: (get_server_accounts):
2086 Create the local folders account only once, not once for each outbox, and
2087 not only when there are some outboxes.
2089 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2091 * src/widgets/modest-folder-view.c: (update_model): Comment out some
2092 code that is causing a crash at startup. Sergio says that he is fixing this.
2094 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
2096 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2097 * src/maemo/modest-account-settings-dialog.c:
2098 (create_page_outgoing),
2099 (modest_account_settings_dialog_set_account_name),
2100 (save_configuration):
2101 - Fixed handling of the "Use secure authentication" toggle to comply with
2102 the ui specification. See also projects.maemo.org bug NB#58400
2104 - Restore the Secure connection setting combo correctly when loading
2107 * src/maemo/modest-maemo-utils.c:
2108 (on_camel_account_get_supported_secure_authentication),
2109 (modest_maemo_utils_get_supported_secure_authentication_methods):
2110 Fixed a crasher if operation is canceled
2112 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
2113 (modest_protocol_info_auth_is_secure):
2114 * src/modest-protocol-info.h:
2116 Added two new methods to determine if a protocol/auth method is secure/encrypted in
2117 the sense of the "Use secure authentication" toggle.
2119 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2121 * src/modest-tny-account-store.h:
2122 * src/modest-tny-account-store.c:
2123 Added modest_tny_account_store_get_local_folders_account().
2125 * src/modest-tny-folder.h:
2126 * src/modest-tny-folder.c:
2127 (modest_tny_folder_get_account):
2128 Added this replacement for tny_folder_get_account() which returns
2129 the local-folders account for TnyMergeFolders, to avoid the
2130 warning about the unimplemented get_account_func() vfunc().
2132 (modest_tny_folder_get_rules),
2133 * src/modest-ui-actions.c:
2134 (modest_ui_actions_on_folder_selection_changed):
2135 * src/modest-mail-operation.c:
2136 (modest_mail_operation_remove_folder),
2137 (modest_mail_operation_xfer_folder),
2138 (modest_mail_operation_rename_folder),
2139 (modest_mail_operation_get_msg),
2140 (modest_mail_operation_get_msgs_full),
2141 (modest_mail_operation_remove_msg),
2142 (modest_mail_operation_xfer_msgs),
2143 (modest_mail_operation_refresh_folder):
2144 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
2146 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2148 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
2149 (modest_server_account_set_security):
2150 * src/modest-defs.h: Add comments explaining that our
2151 UI spec means TLS when it says Normal, so these do not look like errors.
2153 * src/modest-tny-account.c:
2154 (modest_tny_account_new_from_server_account): Use the new tinymail
2155 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
2156 for TLS. This should fix projects.maemo.org bug NB#58460.
2158 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2160 * src/maemo/easysetup/modest-easysetup-wizard.c:
2161 (create_account): Correct the position of the gconf sanity check warning.
2162 (on_button_edit_advanced_settings): Show the dialog immediately, instead
2163 of using the g_idle_add() hack, because this does not seem to be necessary
2164 on osso 1.1. It might even work on Maemo Bora if the problems were actually
2165 caused by something other than maemo's gconf.
2166 This fixes projects.maemo.org bug #59022.
2168 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2170 * src/modest-account-mgr-helpers.c:
2171 (modest_account_mgr_get_default_account): Do not check that the account
2172 exists if there is no default account (NULL), to fix a runtime warning.
2174 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2176 * src/widgets/modest-folder-view.c: (update_model):
2177 Do not unref the treemodel before we have finished with it.
2178 This prevents a valgrind warning and an occasional crash at startup.
2180 2007-06-06 Marcus Bauer <marcusb@openismus.com>
2182 * libmodest-dbus-client/libmodest-dbus-client.h:
2183 added libmodest_dbus_client_compose_mail()
2184 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2186 added functions needed for SendAsMail() functionality
2187 * src/maemo/modest-msg-edit-window.c:
2188 (modest_msg_edit_window_attach_file_noninteractive):
2189 non interactively attaching files to message edit window
2190 * src/widgets/modest-msg-edit-window.h:
2191 * tests/dbus_api/Makefile.am:
2192 added test_compose_mail.c
2193 * tests/dbus_api/test_compose_mail.c: (main):
2195 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2197 * src/modest-account-view.c:
2198 Fixed bug projects.maemo.org bug NB#59307
2200 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2202 * src/maemo/easysetup/modest-easysetup-wizard.c:
2203 (get_serverport_incoming), (on_before_next), (create_account):
2204 * src/maemo/modest-account-settings-dialog.c:
2205 (modest_account_settings_dialog_set_account_name):
2206 * src/maemo/modest-maemo-utils.c:
2207 (on_camel_account_get_supported_secure_authentication_status),
2208 (on_camel_account_get_supported_secure_authentication),
2209 (on_secure_auth_cancel),
2210 (modest_maemo_utils_get_supported_secure_authentication_methods):
2212 Implemented security authentication for settings and easysetup.
2214 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2216 * src/maemo/modest-main-window.c: (create_details_widget):
2217 Show the total size for memory card accounts too, instead of showing
2218 the name again. Fixes bug projects.maemo.org bug NB#59307.
2220 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2223 * src/modest-tny-simple-folder-store.c:
2224 * src/modest-tny-simple-folder-store.h: Removed.
2226 * src/modest-tny-local-folders-account.h
2227 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
2228 for the local-folders maildir, with an extra TnyMergedFolder containing
2229 the folders of the per-account outbox store accounts.
2230 * src/modest-tny-account-store.c: (get_server_accounts):
2231 Add the outboxes to the special local folders account after creating it.
2233 * src/modest-tny-account.c:
2234 (modest_tny_account_new_for_local_folders): Create the derived
2235 account when creating the main local-folders account.
2237 * src/maemo/modest-main-window.c: (create_details_widget),
2238 (modest_main_window_set_contents_style):
2239 Adapted to the use of the derived account instead of the folder store.
2241 * src/modest-ui-actions.c:
2242 (modest_ui_actions_on_folder_selection_changed):
2243 * src/modest-ui-dimming-rules.c:
2244 (modest_ui_dimming_rules_on_new_folder):
2245 * src/widgets/modest-folder-view.c: (text_cell_data),
2246 (icon_cell_data), (filter_row), (update_model),
2247 (get_cmp_rows_type_pos):
2250 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2251 Do not get the priv struct, because no priv struct has been set,
2252 to avoid a runtime warning.
2254 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2255 #ifelse with #else, to fix a warning, to fix the build.
2258 2007-06-05 Christian Kellner <ckellner@openismus.com>
2260 * libmodest-dbus-client/libmodest-dbus-client.c:
2261 Fix small typo in doc (why do you always see them
2262 AFTER committing stuff?)
2265 2007-06-05 Christian Kellner <ckellner@openismus.com>
2267 * libmodest-dbus-client/libmodest-dbus-client.c:
2268 (libmodest_dbus_client_search):
2269 Initialize hit list with NULL. Also set folder list
2270 to "" if NULL was supplied.
2273 2007-06-03 Christian Kellner <ckellner@openismus.com>
2275 * libmodest-dbus-client/libmodest-dbus-client.c:
2276 (modest_search_hit_list_free):
2277 Make it save to call it with NULL.
2279 * src/dbus_api/modest-dbus-callbacks.c:
2280 * src/modest-search.c:
2281 Return full ModestSearchHits as the search result list not TnyHeader
2282 since can't be around withouth the correspoding TnyFolder.
2284 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2286 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2287 Added currently commented code to check for secure auth
2289 * src/maemo/modest-account-settings-dialog.c: (on_response),
2290 (save_configuration), (show_ok):
2291 Fixed projects.maemo.org bugs NB #59248 and #59251
2293 * src/maemo/modest-maemo-utils.c:
2294 (on_camel_account_get_supported_secure_authentication_status),
2295 (on_camel_account_get_supported_secure_authentication),
2296 (modest_maemo_utils_get_supported_secure_authentication_methods):
2297 * src/maemo/modest-maemo-utils.h:
2298 Moved get_supported_secure_authentication() method here to be able
2299 to use it from easysetup wizard.
2301 * src/modest-pair.c: (on_pair_compare_as_string):
2302 Should compare string with first part of pair and not
2303 strcmp pairs which will crash.
2305 * src/modest-protocol-info.c:
2306 (modest_protocol_info_protocol_is_store):
2307 * src/modest-protocol-info.h:
2308 Added modest_protocol_info_get_auth_protocol_name()
2310 2007-06-03 Armin Burgmeier <armin@openismus.com>
2312 * src/modest-mail-operation.c:
2313 (modest_mail_operation_get_msgs_full): Set priv->account also when
2314 only retrieving a single message. This avoids a crash when canceling
2317 (modest_mail_operation_notify_end): Do not explicitely remove the
2318 operation from the queue but only emit the progress_changed signal.
2319 The queue itself listens to that signal to remove the operation when
2320 it is finished. This reduces coupling and removes a potential deadlock
2321 when modest_mail_operation_notify_end() is called from the queue
2322 itself. If that is a problem performance-wise, I would suggest to
2323 implement a status-changed signal or something.
2325 * src/modest-mail-operation-queue.c: Make sure to never call a
2326 function from another file while the queue is locked. This (hopefully)
2327 fixes another deadlock when exiting the application while retrieving
2330 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2332 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2333 Fixed build if libogs is not available
2335 2007-06-03 Christian Kellner <ckellner@openismus.com>
2337 * libmodest-dbus-client/libmodest-dbus-client.h:
2338 * libmodest-dbus-client/libmodest-dbus-client.c:
2339 (libmodest_dbus_client_delete_message):
2340 Implement deletion of messages (Client side).
2342 (modest_search_hit_free),
2343 (modest_search_hit_list_free):
2344 Utility functions to free the result hits.
2346 * src/dbus_api/modest-dbus-api.h:
2347 * src/dbus_api/modest-dbus-callbacks.c:
2348 (on_delete_message),
2349 (modest_dbus_req_handler):
2350 Implement deletion of messages (Server side).
2352 * tests/dbus_api/test_search.c: (main):
2355 * tests/dbus_api/Makefile.am:
2356 * tests/dbus_api/test_delete_message:
2357 Add little test for the message deletion logic
2359 2007-06-03 Armin Burgmeier <armin@openismus.com>
2361 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2362 when the operation queue was not empty. projects.maemo.org bug
2365 2007-06-03 Armin Burgmeier <armin@openismus.com>
2367 * src/widgets/modest-account-view.c
2368 (on_account_default_toggled): Toggle default account column
2369 explicitely instead of waiting for gconf notification (which is
2370 currently ignored). This should fix projects.maemo.org bug NB#56910
2371 for now. It should probably be removed when gconf notifications are
2374 2007-06-03 Christian Kellner <ckellner@openismus.com>
2376 * libmodest-dbus-client/libmodest-dbus-client.c:
2377 Removed debugging spew.
2379 * src/dbus_api/modest-dbus-callbacks.c:
2380 Added debugging info.
2382 * src/modest-search.c:
2383 (modest_search_all_accounts):
2384 Use tny_account_store_get_accounts () on the account store
2385 to get all accounts which is the way to get all accounts.
2387 * tests/dbus_api/test_search.c: (main):
2388 Make it possible to supply the search term on the command line.
2390 2007-06-03 Christian Kellner <ckellner@openismus.com>
2392 * libmodest-dbus-client/libmodest-dbus-client.c:
2393 * libmodest-dbus-client/libmodest-dbus-client.h:
2394 Implement searching for mesages over raw dbus. (Client side)
2396 * src/dbus_api/Makefile.am:
2397 * src/dbus_api/modest-dbus-api.h:
2398 * src/dbus_api/modest-dbus-callbacks.c:
2399 * src/dbus_api/modest-dbus-callbacks.h:
2400 Search framework (Server side). Also implement on_idle_open_message().
2402 * src/maemo/modest-platform.c: (modest_platform_init):
2403 Prepare for raw dbus/osso rpc interaction.
2405 * src/modest-search.h:
2406 Changed minsize from unspecific guint to guint32.
2408 * src/modest-search.c:
2410 Added strange hack which magically made tnymail work.
2412 (modest_search_folder),
2413 (modest_search_account),
2414 (modest_search_all_accounts):
2415 Implement helper functions to search all accounts, specific account
2418 * tests/dbus_api/Makefile.am:
2419 * tests/dbus_api/test_open_message.c:
2420 Read url to open from commandline.
2422 * tests/dbus_api/test_search.c:
2423 Implement small test for dbus search stuff
2425 2007-06-02 Armin Burgmeier <armin@openismus.com>
2427 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2428 include account type and account title. This fixes projects.maemo.org
2431 * src/maemo/modest-account-view-window.c: Set a title for the window.
2433 2007-06-02 Armin Burgmeier <armin@openismus.com>
2435 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2436 incoming and outgoing server name based on email address and server
2437 types as long as the names have not been edited manually. This fixes
2438 projects.maemo.org bug NB#58671.
2440 2007-06-02 Armin Burgmeier <armin@openismus.com>
2442 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2443 server type cannot be changed in future to the incoming details page
2444 when creating an account. This fixes projects.maemo.org bug NB#59029.
2446 2007-06-02 Armin Burgmeier <armin@openismus.com>
2448 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2449 and assigned max width chars so that they wrap instead of being
2450 truncated. Fixes projects.maemo.org bug NB#56126.
2452 2007-06-02 Armin Burgmeier <armin@openismus.com>
2454 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2455 introductory note to the connection specific smtp servers dialog, as
2456 section 8.12 of the email UI specification requires. This fixes
2457 projects.maemo.org bug NB#59212.
2459 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2461 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2462 Check for running mail operations, and offer to cancel them, as per the UI
2463 spec. This fixes projects.maemo.org bug NB#59041 .
2464 However, I suspect that tinymail may still use the network connection
2465 in ways that we cannot detect or cancel. But it should at least adapt to
2466 changes fairly well.
2468 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2470 * src/modest-tny-account-store.c: (recreate_all_accounts),
2471 (get_cached_accounts), (get_server_accounts): Do more sensible
2472 ref-counting of the temporarily-cached outbox accounts list. This seems
2473 to fix a crash when entering the password when the password was wrong.
2475 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2477 * src/gnome/modest-main-window.c: (connect_signals):
2478 * src/modest-tny-account-store.c: (get_password),
2479 (modest_tny_account_store_alert): Added comments and clues and
2480 commented-out code about how we currently fail to deal with connection
2481 errors and wrong passwords, and how we should.
2483 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2485 * src/widgets/modest-retrieve-combo-box.c:
2486 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2487 This fixes projects.maemo.org bug NB#58472 .
2489 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2491 * src/maemo/easysetup/modest-easysetup-wizard.c:
2492 (create_page_complete_easysetup):
2493 (create_page_complete_custom): Correct the last commit,
2494 putting the correct sentences in the correct pages.
2496 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2498 * src/maemo/easysetup/modest-easysetup-wizard.c:
2499 (create_page_complete_custom): Show the second sentence of text
2500 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2503 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2505 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2506 Set the leave-on-server conf key by default. This fixes
2507 projects.maemo.org bug NB#59258 .
2509 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2511 * src/maemo/modest-account-view-window.c:
2512 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2513 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2516 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2518 * src/maemo/easysetup/modest-easysetup-wizard.c:
2519 (create_caption_new_with_asterisk):
2520 * src/maemo/modest-account-settings-dialog.c:
2521 (create_caption_new_with_asterisk):
2522 Uncomment the code to add the asterisk, because they are no longer in the
2523 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2524 (update_incoming_server_title): Add an asterisk here too.
2526 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2528 * src/maemo/modest-maemo-global-settings-dialog.c:
2529 (current_connection): Check that we are even connected before trying to
2530 get the current connection name, to prevent a warning.
2532 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2533 Change the comments because tny_maemo_conic_device_connect() is now meant to
2535 * src/modest-mail-operation.c:
2536 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2537 make sure we have a connection and fail if we can't connect.
2539 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2541 * src/maemo/modest-main-window.c:
2542 (on_account_store_connecting_finished): Do not try to get the
2543 connection ID if we are not really connected. I am surprised that
2544 this signal handler is called when we are not connected.
2546 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2548 * src/modest-error.h:
2549 * src/modest-ui-actions.c:
2550 (modest_ui_actions_get_msgs_full_error_handler):
2551 Renamed an enum, added comments, added an enum
2552 for retrieve-limit errors.
2554 * src/modest-mail-operation.c: (foreach_add_item),
2555 (internal_folder_observer_update), (update_account_thread),
2556 (modest_mail_operation_get_msgs_full):
2557 (modest_mail_operation_update_account),
2558 Added comments about how this works, and some code that should
2559 (but does not) check the retrieve-limit. See the TODO comment.
2561 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2563 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2564 Initialize help_id to fix the build. Warnings are good.
2566 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2568 * src/widgets/modest-hbox-cell-renderer.c:
2569 (modest_hbox_cell_renderer_append):
2570 * src/widgets/modest-vbox-cell-renderer.c:
2571 (modest_vbox_cell_renderer_append):
2572 Fix the last commit by doing an extra ref.
2574 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2576 * src/widgets/modest-hbox-cell-renderer.c:
2577 (modest_hbox_cell_renderer_append):
2578 * src/widgets/modest-vbox-cell-renderer.c:
2579 (modest_vbox_cell_renderer_append):
2580 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2581 to fix the build with Maemo Bora.
2582 However, there seems to be a remaining crash, probably due to reference
2585 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2587 * src/modest-tny-account.c:
2588 (modest_tny_account_new_for_local_folders):
2589 Use hildon_file_system_info_async_new() to get a better name for
2590 the memory card account, setting it as the account name.
2591 The timing seems to work, but this is probably
2592 not the best place to do this. See the TODO comment.
2593 * src/maemo/modest-main-window.c: (create_details_widget):
2594 * src/widgets/modest-folder-view.c: (text_cell_data):
2595 Use the tny account name instead of hardcoding a name.
2597 2007-05-30 Christian Kellner <ckellner@openismus.com>
2599 * src/modest-search.c: (modest_search):
2600 Correctly set part_search_func even if we have already parsed
2601 the query and thus a valid OgsTextSearcher object.
2603 2007-05-30 Christian Kellner <ckellner@openismus.com>
2606 Search and check for libogs.
2609 Incooparte the ogs build env.
2611 * src/modest-mime-part-search-stream.c:
2612 * src/modest-mime-part-search-stream.h:
2613 Removed since we do the real searching now in modest-search.c.
2615 * src/modest-search.c:
2616 * src/modest-search.h:
2617 Implement support for ogs. We use that if available and requested
2618 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2619 should now handle the corner case when the search term is spread
2620 across multiple reads.
2621 Also the logic in modest_search () was corrected to search all
2622 requested fields until one is found.
2624 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2626 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2628 * src/modest-init.h:
2629 * src/modest-init.c: Made modest_init_local_folders() take a
2630 path and be public so we can iniitialize maildir folders on
2633 * src/modest-local-folder-info.h:
2634 * src/modest-local-folder-info.c:
2635 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2637 * src/modest-tny-account.c:
2638 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2639 still means the standard local-folders path on the local volume.
2641 * src/modest-tny-account-store.c:
2642 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2643 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2644 all accounts when that happens.
2645 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2646 this too, so it shows up in the treeview.
2648 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2650 * src/maemo/modest-maemo-global-settings-dialog.c:
2651 (current_connection):
2652 * src/widgets/modest-global-settings-dialog.c:
2653 (current_connection_default):
2654 Use the enum values instead of 0, 1 and -1,
2655 to make the code clearer.
2657 * src/modest-account-mgr-helpers.c:
2658 (modest_account_mgr_get_connection_specific_smtp): Make this code
2661 * src/modest-runtime.h:
2662 * src/modest-runtime.c:
2663 Added modest_runtime_remove_all_send_queues().
2664 * src/maemo/modest-main-window.c:
2665 (on_account_store_connecting_finished): Recreate the send queues,
2666 using the appropriate transport accounts for this new connection.
2667 Some futher adapting might be needed if the old send queues are not
2668 automatically stopped at this point.
2670 * src/modest-tny-account-store.c: (get_server_accounts):
2671 Create the connection-specific transport accounts, so that they can
2672 be found later by their ID.
2674 * src/modest-tny-account.h:
2675 * src/modest-tny-account.c:
2676 Added modest_tny_account_new_from_server_account_name().
2677 modest_tny_account_new_from_server_account(): Do not create the
2678 send queues here, because they will be
2679 recreated anyway when the connection changes for the first time.
2681 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2683 * src/modest-local-folder-info.h:
2684 * src/modest-local-folder-info.c:
2685 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2686 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2687 tbox_folder): Take a modest account name instead of a server TnyAccount,
2688 so we can have per-modest-account rather than per-transport-account
2690 We must make sure that we change or recreate the exisitng send queues
2691 when the connection changes for connection-specific transport accounts.
2693 * src/modest-tny-account-store.c:
2694 (create_per_account_local_outbox_folders): Create outboxed per modest
2695 account, not per transport account.
2697 * src/modest-tny-account.h:
2698 * src/modest-tny-account.c:
2699 (modest_tny_account_get_special_folder): For outboxes, get the
2700 parent modest account name. The account is ignored for other folders.
2701 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2702 modest account name rather than a server TnyAccount.
2704 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2706 * src/modest-tny-account.c:
2707 (modest_tny_account_new_from_server_account):
2708 Call modest_runtime_get_send_queue() immediately after creating transport
2709 accounts, so that they start trying to send email from the outbox as soon
2710 as possible at startup. This is probably what we want.
2712 * src/modest-mail-operation.c: (update_account_thread):
2713 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2714 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2715 * src/modest-tny-send-queue.h:
2716 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2717 (modest_ui_actions_on_send):
2718 Added comments about how sending works, though it needs some more work.
2720 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2722 * src/modest-tny-account.c:
2723 (modest_tny_account_get_special_folder): Add TODO because this fails when
2724 the network is busy.
2725 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2726 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2727 Do not try to show this window when there is no active account. The UI
2728 specs does not tell us what to do in this case.
2730 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2734 * src/maemo/Makefile.am:
2735 * src/widgets/Makefile.am: Some dist fixes.
2737 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2739 * src/maemo/modest-connection-specific-smtp-window.c:
2740 (on_button_edit): Make the code clearer, to prevent a double free.
2742 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2744 * src/maemo/modest-account-settings-dialog.c:
2745 (modest_account_settings_dialog_set_account_name),
2746 Check the connection-specific smtp servers checkbox if there are any.
2748 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2749 (modest_connection_specific_smtp_edit_window_init):
2750 Start with a suitable port number.
2752 * src/modest-account-mgr-helpers.h:
2753 * src/modest-account-mgr-helpers.c: Added
2754 modest_account_mgr_get_has_connection_specific_smtp().
2756 (modest_account_mgr_set_connection_specific_smtp),
2757 (modest_account_mgr_remove_connection_specific_smtp),
2758 (modest_account_mgr_get_has_connection_specific_smtp),
2759 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2760 connection-specific smtp server accounts in the account, rather than
2761 the server account conf dir.
2763 This fixes bug projects.maemo.org bug NB#58263 .
2765 * src/modest-tny-account-store.c:
2766 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2767 if there are no server accounts yet, to prevent an infinite loop when there
2768 are no accounts. Document that one must be called before the other.
2770 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2772 * src/modest-account-mgr-helpers.c:
2773 (modest_account_mgr_get_default_account): Make sure that at least
2774 one account is always the default, if there are any enabled accounts.
2775 This is just a sanity check that shouldn't be necessary.
2777 * src/modest-account-mgr-priv.c:
2778 (_modest_account_mgr_account_from_key): Unescape the conf key to
2779 get the real account name. For instance, this is an issue if a space
2780 was in the account name, which can happen because the account name
2781 is generated from the display name.
2782 (_modest_account_mgr_get_account_keyname): Always escape the
2784 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2785 Unescape the conf keys to get the real account names.
2787 For instance, previously the is-default radio button in the accounts
2788 list was not checked for any accounts at first. This fixes that,
2789 and might fix several similar bugs.
2791 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2793 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2794 Removed some debug printfs.
2796 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2798 Modest on-disk outbox directories are now here, for instance:
2799 $HOME/.modest/outboxes/<account-id-1>/outbox
2800 $HOME/.modest/outboxes/<account-id-2>/outbox
2802 $HOME/.modest/local-folders/outbox
2803 so we can have a separate outbox for each account.
2804 But they are shown as one outbox in the GtkTreeView, by using a
2805 TnyMergeFolder in a ModestTnySimpleFolderStore.
2808 * src/modest-tny-simple-folder-store.c:
2809 * src/modest-tny-simple-folder-store.h:
2810 Added ModestTnySimpleFolderStore, used to contain folders from
2811 other folder stores, such as other accounts.
2813 * src/modest-tny-outbox-account.h:
2814 * src/modest-tny-outbox-account.c:
2815 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2816 used for the per-account local outbox folders.
2818 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2819 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2820 only use this (internally) now for the non-outbox local folders.
2822 * src/modest-init.h:
2823 * src/modest-init.c: Added modest_init_one_local_folder(), for
2824 setting up the directory structure for each local folder.
2826 * src/modest-local-folder-info.c:
2827 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2828 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2830 * src/modest-local-folder-info.h:
2831 * src/modest-tny-account-store.c: (on_account_removed),
2832 (on_account_changed), (create_per_account_local_outbox_folders),
2833 (get_server_accounts), (modest_tny_account_store_get_accounts),
2834 (modest_tny_account_store_get_tny_account_by_account),
2835 (modest_tny_folder_store_is_virtual_local_folders):
2837 * src/modest-tny-account.h:
2838 * src/modest-tny-account.c:
2839 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2840 to create an on-disk per-account local outbox folder for each
2842 (create_per_account_local_outbox_folders): Create a local outbox folder
2843 for each transport account.
2844 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2845 for all local folders.
2847 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2848 instead of using g_object_get/set() directly. It is clearer.
2850 (modest_tny_folder_store_get_message_count),
2851 (modest_tny_folder_store_get_local_size
2852 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2853 because we now use these with non-acount folder stores.
2855 (modest_tny_account_get_special_folder),
2856 (modest_tny_account_new_from_server_account),
2857 (modest_tny_account_new_from_account):
2858 (recurse_folders): Adjust to the new outbox system.
2860 * src/modest-tny-folder.h:
2861 * src/modest-tny-folder.c:
2862 (modest_tny_folder_is_local_folder),
2863 (modest_tny_folder_get_local_folder_type),
2864 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2866 * src/widgets/modest-main-window.h:
2867 * src/maemo/modest-main-window.c: (create_details_widget),
2868 (modest_main_window_set_contents_style): Show details for any folder store,
2871 (modest_tny_folder_get_rules):
2872 Remove the const. C does not support constness enough for this.
2874 * src/modest-ui-actions.c:
2875 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2876 make all outboxes appear as one, in the usual local-folders tree node.
2878 (set_active_account_from_tny_account),
2879 (modest_ui_actions_on_folder_selection_changed):
2880 * src/widgets/modest-folder-view.c: (text_cell_data),
2881 (icon_cell_data), (filter_row),
2882 (add_account_folders_to_merged_folder),
2883 (add_account_folders_to_simple_folder_store), (),
2884 (get_cmp_rows_type_pos), (cmp_rows),
2885 (modest_folder_view_set_account_id_of_visible_server_account):
2886 Adjust to the new outbox system, using generic folder stores and folders
2887 in the GtkTreeModel.
2889 2007-05-23 Christian Kellner <ckellner@openismus.com>
2891 * src/modest-mail-operation.c:
2892 (modest_mail_operation_update_account):
2893 Use info->max_size instead of unintialized local var [small
2894 build fix]. (Added TODO to review that change since I don't
2897 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2899 * libmodest-dbus-client/libmodest-dbus-client.c:
2900 (libmodest_dbus_client_compose_mail): function added
2901 * src/dbus_api/modest-dbus-api.h:
2902 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2903 (on_compose_mail): Implementation of the SendAsMail functionality
2905 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2907 * src/modest-account-mgr.c:
2908 (modest_account_mgr_add_server_account): Set the secure-connection
2909 conf key for transport accounts as well as store accounts. I don't know
2910 why the if was there. For instance, this makes sure that we use SSL
2911 for the gmail preset from the easysetup wizard.
2913 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2915 * src/gnome/modest-main-window.c:
2916 (on_account_store_connecting_finished), (connect_signals):
2917 * src/maemo/modest-main-window.c:
2918 (on_account_store_connecting_finished), (connect_signals),
2919 (modest_main_window_new):
2920 Handle TnyAccountStore::connecting-finished instead of
2921 TnyDevice::connection-changed, because we cannot actually perform
2922 operations on accounts until TnyAccountStore has itself responded to
2923 the TnyDevice::connection-changed signal. This prevents a GError from
2925 Do not try to update at startup, because we (at least on scratchbox)
2926 already do an update at startup when the device goes online.
2927 This prevents a GError from tinymail.
2928 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2929 Added TODO about stopping simultaneous operations.
2931 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2933 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2934 * src/modest-mail-operation-queue.c:
2935 (modest_mail_operation_queue_remove):
2936 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2937 about where they happened.
2939 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2941 * src/modest-ui-actions.c:
2942 (modest_ui_actions_on_password_requested): Make sure that the remember
2943 output parameter is always TRUE.
2945 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2947 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2948 Show a OK/Cancel dialog if the error is a question, though we still do not
2949 know anything more about what we are asking the user.
2950 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2951 Fix an uninitialized variable (helper). This is a logic error, however.
2953 2007-05-21 Christian Kellner <ckellner@openismus.com>
2955 * src/modest-search.h:
2956 Correct bit shifting in the ModestSearchFlags enum.
2958 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2960 * src/modest-tny-account.c:
2961 (modest_tny_account_new_from_server_account): Do not use the lsub and
2962 check-all hard-coded IMAP options when using POP.
2964 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2966 * src/modest-tny-account.c:
2967 (modest_tny_account_new_from_server_account):
2968 Use NULL for the secure-auth method for POP when Password auth has been
2969 specified by the user, as we already do for IMAP. "auth=Login" causes
2970 an error from camel or the server.
2972 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2974 * src/maemo/modest-account-settings-dialog.c:
2975 (create_page_account_details),
2976 (modest_account_settings_dialog_set_account_name):
2977 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2978 for the leave-on-server checkbox, rathr than just the checkbox, when
2979 the protocol is not POP.
2981 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2983 * src/widgets/modest-account-view.c:
2984 * src/widgets/modest-account-view.h:
2985 Added modest_account_view_select_account() which will be useful later
2986 to asynchronously re-select the edited account.
2988 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2990 * src/maemo/modest-account-settings-dialog.c:
2991 (modest_account_settings_dialog_set_account_name):
2992 Automatically choose the port numbers based on the secure authentication
2993 methods, if they have not been chosen before.
2994 This fixes projects.maemo.org bug NB#56273 .
2996 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2998 * src/maemo/modest-main-window-ui.h:
2999 * src/modest-ui-actions.c:
3000 * src/modest-ui-actions.h:
3001 Connect the Tools/SMTP Servers menu item to
3002 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
3003 SMTP servers dialog, as in the UI specification and saves changes when it
3004 is closed. This fixed projects.maemo.org bug NB#56305 .
3006 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3008 * src/maemo/modest-connection-specific-smtp-window.c:
3009 (modest_connection_specific_smtp_window_init):
3010 Use gtk_window_set_default_size() to make this window big enough, so
3011 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
3013 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3015 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3016 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3017 (modest_connection_specific_smtp_edit_window_init),
3018 Do not try to connect to a combobox signal before the combobox exists.
3019 This fixes the cras in projects.maemo.org bug NB#56288 .
3020 (modest_connection_specific_smtp_edit_window_get_settings):
3021 Remove the server_account_name parameter which was being checked for NULL
3022 though it was not used.
3024 * src/maemo/modest-connection-specific-smtp-window.c:
3025 (modest_connection_specific_smtp_window_fill_with_connections),
3026 (on_button_edit), (modest_connection_specific_smtp_window_init):
3027 Correct the number of treemodel columns to prevent a warning.
3028 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
3029 libconic does not work.
3031 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3033 * src/modest-tny-account.c:
3034 (modest_tny_account_new_from_server_account):
3035 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
3036 SMTP when "None" was chosen by the user. However, with my SMTP server that
3037 does not support ANONYMOUS, the emails do not leave the Outbox and I see
3040 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3042 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
3043 to explain the memory management issue with the ID in the ModestPair.
3045 * src/gnome/modest-account-assistant.c: (add_receiving_page),
3046 (add_sending_page), (modest_account_assistant_finalize):
3047 * src/gnome/modest-gnome-global-settings-dialog.c:
3048 (create_updating_page), (create_composing_page):
3049 * src/gnome/modest-msg-edit-window.c: (get_transports),
3050 (init_window), (modest_msg_edit_window_finalize),
3051 (modest_msg_edit_window_get_msg_data):
3052 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
3053 * src/gnome/modest-transport-widget.c:
3054 (modest_transport_widget_finalize), (smtp_configuration):
3055 * src/maemo/modest-maemo-global-settings-dialog.c:
3056 (create_updating_page), (create_composing_page):
3057 * src/maemo/modest-msg-edit-window.c: (get_transports),
3058 (init_window), (modest_msg_edit_window_finalize),
3059 (modest_msg_edit_window_get_msg_data),
3060 (modest_msg_edit_window_free_msg_data):
3061 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
3062 (modest_store_widget_finalize):
3063 * src/maemo/modest-transport-widget.c:
3064 (modest_transport_widget_finalize), (smtp_configuration):
3065 * src/modest-main.c: (send_mail):
3066 * src/widgets/modest-combo-box.h:
3067 * src/widgets/modest-global-settings-dialog-priv.h:
3068 * src/widgets/modest-global-settings-dialog.c:
3069 (modest_global_settings_dialog_finalize):
3070 * src/widgets/modest-msg-edit-window.h:
3071 Whenever using modest_combo_box_new(), keep the ModestPairList alive
3072 as long as the combo box, to prevent use of freed memory for the ID.
3074 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3076 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
3077 get_accounts(), to make this clearer. Do not check for the enabled gconf
3078 key, because we do not use this for server accounts (at least, not yet).
3079 This allows us to send email again.
3081 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3083 * src/maemo/modest-platform.c:
3084 (on_modest_conf_update_interval_changed), (modest_platform_init):
3085 Only respond to this particular key change. All these strcmp()s cannot be
3088 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3090 * src/maemo/modest-maemo-global-settings-dialog.c:
3091 (current_connection): Prevent a crash in scratchbox when
3092 ny_maemo_conic_device_get_current_iap_id() returns NULL.
3093 * src/maemo/modest-platform.c:
3094 (on_modest_conf_update_interval_changed), (modest_platform_init):
3095 Get the update interval from gconf and reset it when the gconf key changes.
3097 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3099 * src/modest-protocol-info.c:
3100 * src/modest-protocol-info.h: Adde enum-specific get functions,
3101 instead of using a ModestProtocolType enum parameter.
3103 * src/gnome/modest-account-assistant.c:
3104 * src/gnome/modest-store-widget.c:
3105 * src/gnome/modest-store-widget.h:
3106 * src/gnome/modest-transport-widget.c:
3107 * src/gnome/modest-transport-widget.h:
3108 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
3109 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
3110 * src/maemo/easysetup/modest-easysetup-wizard.c:
3111 * src/maemo/modest-account-settings-dialog.c:
3112 * src/maemo/modest-account-settings-dialog.h:
3113 * src/maemo/modest-store-widget.c:
3114 * src/maemo/modest-store-widget.h:
3115 * src/maemo/modest-transport-widget.c:
3116 * src/maemo/modest-transport-widget.h:
3117 * src/modest-account-mgr-helpers.c:
3118 * src/modest-account-mgr-helpers.h:
3119 * src/modest-account-mgr.c:
3120 * src/modest-account-mgr.h:
3121 * src/modest-tny-account.c:
3122 * src/modest-tny-folder.c:
3123 * src/widgets/modest-account-view.c:
3124 * src/widgets/modest-retrieve-combo-box.c:
3125 * src/widgets/modest-retrieve-combo-box.h:
3126 * src/widgets/modest-secureauth-combo-box.c:
3127 * src/widgets/modest-serversecurity-combo-box.c:
3128 * src/widgets/modest-serversecurity-combo-box.h:
3129 * tests/check_account-mgr.c:
3130 Use the specific functions, and use the re-renamed enum values for GNOME too.
3132 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3134 * src/modest-pair.h:
3135 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
3136 so we can get the second based on the first.
3138 * src/maemo/modest-account-settings-dialog.h:
3139 * src/maemo/modest-account-settings-dialog.c:
3140 Added get_supported_secure_authentication_methods(), though it is mostly
3141 commented-out for now until the necessary API is committed to tinymail.
3142 (modest_account_settings_dialog_set_account_name),
3143 (save_configuration): Request the supported authentication methods from the
3144 server, so we can choose a working method.
3146 * src/modest-tny-account-store.h:
3147 * src/modest-tny-account-store.c:
3148 (modest_tny_account_store_get_session): Rename from
3149 tny_account_store_get_session().
3151 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3153 * src/modest-protocol-info.h: Split the ModestProtocol enum
3154 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
3155 There was no need to have these unrelated values in one enum.
3157 * src/: many files: Adapted to changed enum. This makes the code a bit
3158 clearer, and the compiler could catch some errors.
3160 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3162 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3163 Show the detailed internal camel error message when an error happens
3164 during the configuration, so that our testers can give us more clues.
3165 For instance, in projects.maemo.org bug NB#56910 .
3167 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3169 * src/modest-tny-account.c:
3170 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
3171 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
3173 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3175 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3176 * src/maemo/modest-account-settings-dialog.c:
3177 (modest_account_settings_dialog_set_account_name),
3178 (save_configuration): For the incoming secure authentication checkbox,
3179 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
3180 the UI specification. PLAIN does not seem to be supported for most IMAP
3181 servers anyway, and I am not sure what it would mean.
3182 However, we probably need to discover which of the secure-authentication
3183 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
3184 * src/modest-account-mgr-helpers.c:
3185 (modest_account_mgr_get_server_account_data):
3187 * src/modest-tny-account.c:
3188 (modest_tny_account_new_from_server_account):
3189 Use tny_account_set_mech() to set secure-authentication methods,
3190 with some special-casing for IMAP, based on my observations of how
3193 * src/modest-account-mgr-helpers.h:
3194 * src/modest-account-mgr.c:
3195 * src/modest-defs.h: Comment that the URI is only used for local folders.
3197 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3199 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
3200 parameter const, just to be neat.
3201 * src/modest-text-utils.c: (modest_text_utils_inline):
3202 End g_strconcat() with NULL, as its documentation says. This is almost
3203 certainly the cause of my crash at startup on the device. Interestingly,
3204 valgrind doesn't tell us about these errors.
3206 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3208 * scripts/build-packages: Added more precise comments about how to use
3209 this script, though I still get this error:
3210 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
3211 error building tinymail
3213 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3215 * src/maemo/modest-main-window.c: (on_account_update):
3216 Very slight cleanup, hoping to make it simpler to discover what causes
3217 a crash here sometimes.
3219 * src/modest-tny-account.c:
3220 (modest_tny_account_new_from_server_account): Set the port. Added
3221 comments about the options and a TODO comment because I need to find out
3222 how to specify the secure authentication method.
3224 2007-05-11 Marcus Bauer <marcusb@openismus.com>
3226 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3227 changed CFlags paths form modest to libmodest
3229 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3231 * src/modest-account-mgr-helpers.c:
3232 (modest_account_mgr_get_server_account_data),
3233 (modest_account_mgr_free_server_account_data):
3234 * src/modest-account-mgr-helpers.h:
3235 * src/modest-account-mgr.c:
3236 (modest_account_mgr_add_server_account):
3237 * src/modest-defs.h:
3238 * src/modest-tny-account.c:
3239 (modest_tny_account_new_from_server_account):
3240 Determine the options for tny_camel_account_add_option() here,
3241 based on the settings, rather than storing them directly in gconf.
3243 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3245 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3246 Show a more friendly error dialog now that we expect (from the tinymail
3247 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3249 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3251 * src/maemo/modest-main-window.c: (on_account_update): Check that
3252 account_name is not NULL, to prevent a crash at startup that I am
3253 seeing on the N800. I do wonder why it is NULL.
3255 * src/maemo/easysetup/modest-easysetup-wizard.c:
3256 (create_page_user_details):
3257 * src/maemo/modest-account-settings-dialog.c:
3258 (create_page_user_details), (create_page_outgoing):
3259 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3260 (modest_connection_specific_smtp_edit_window_init):
3261 * src/modest-ui-actions.c:
3262 (modest_ui_actions_on_password_requested):
3263 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3264 might do something useful with the on-screen keyboard.
3266 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3268 * src/maemo/modest-main-window.c: (on_account_update):
3269 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3270 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3272 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3274 * src/modest-tny-account-store.c: (on_account_changed):
3275 Correct the signature of this signal handler.
3277 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3279 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3280 Show a HildonNote instead of a GtkDialog for Maemo.
3282 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3284 * src/widgets/modest-account-view.h:
3285 * src/widgets/modest-account-view.c: (on_account_changed),
3286 (on_account_removed). Added a boolean flag, set/unset by
3287 modest_account_view_block_conf_updates(),
3288 modest_account_view_unblock_conf_updates() to prevent unnecessary
3289 updates, but this is not very useful because the gconf notifications are
3290 so delays (maybe only on Maemo Bora).
3291 So auto-updating is turned off, and these functions do an explicit
3292 update when necessary.
3293 However, something else is still doing too much work when adding/removing
3294 accounts, probably in another part of the application.
3296 * src/maemo/modest-account-view-window.c:
3297 (on_delete_button_clicked), (on_edit_button_clicked),
3298 (on_new_button_clicked): Use the new functions.
3300 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3302 * src/modest-account-mgr-helpers.c:
3303 (modest_account_mgr_set_first_account_as_default):
3304 Sort the list of names alphabetically-by-title, so we choose the first one
3306 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3307 alphabetically by the title.
3309 This fixes projects.maemo.org bug NB#56418 .
3311 * src/modest-account-mgr-priv.c:
3312 (_modest_account_mgr_account_from_key):
3313 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3314 avoid a valgrind error, and possible random behaviour.
3316 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3318 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3319 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3320 tinymail documentation to say that this can be expected.
3321 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3322 pretty, and should not happen, but I would prefer to know when it does.
3324 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3326 * configure.ac: When using the older hildon version, probably on Bora,
3327 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3329 * src/widgets/modest-attachment-view.c:
3330 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3333 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3335 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3336 Implemented the prototype. Can be tested with
3337 tests/dbus_api/test_open_message:
3339 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3341 * src/modest-tny-account-store.c:
3342 (modest_tny_account_store_instance_init), (get_password):
3343 * src/modest-ui-actions.c:
3344 (modest_ui_actions_on_password_requested):
3345 Do not store the password in gconf, because this function is called
3346 for non-remembered passwords. Actually use the cached (in the hash map)
3347 password instead of releasing it.
3348 The password will now not be remembered if it is asked via the protected
3349 password dialog, as per the UI spec.
3351 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3353 * src/modest-defs.h:
3354 * src/modest-account-mgr-helpers.h:
3355 * src/modest-account-mgr-helpers.c:
3356 Added modest_server_account_get_username_has_succeeded(),
3357 modest_server_account_set_username_has_succeeded().
3358 (modest_server_account_set_username),
3359 Reset the has-succeeded flag if the username changes.
3361 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3362 * src/maemo/modest-connection-specific-smtp-window.c:
3363 (modest_connection_specific_smtp_window_save_server_accounts):
3364 Use modest_server_account_set_username() instead of using
3365 modest_conf_set_string() directly, so that the has-succeeded flag is always
3368 * src/modest-ui-actions.c:
3369 (modest_ui_actions_on_password_requested): Dim the username entry if
3370 the username has ever worked, as per the UI spec.
3372 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3374 * src/modest-tny-account-store.c: (get_password):
3375 * src/modest-ui-actions.c:
3376 (modest_ui_actions_on_password_requested):
3377 Allow the username to be changed too, though there is more work to
3378 be done on exactly how this behaves.
3380 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3382 * src/modest-account-mgr-helpers.h:
3383 * src/modest-account-mgr-helpers.c:
3384 Added modest_account_mgr_get_display_name(),
3385 modest_server_account_get_username(),
3386 modest_server_account_set_username(),
3387 modest_server_account_set_password(),
3388 modest_server_account_get_hostname() functions so we do not need to
3389 use the conf API directly.
3391 * src/maemo/modest-main-window.c: (connect_signals):
3392 Actually connect ot the ModestAccountStore::request-password signal,
3393 so that we show the dialog when the password is requested by Tinymail,
3394 for isntance if it is empty.
3396 * src/modest-marshal.list:
3397 * src/modest-tny-account-store.c:
3398 (modest_tny_account_store_class_init), (get_password),
3399 (modest_tny_account_store_alert):
3400 * src/modest-tny-account-store.h:
3401 * src/modest-ui-actions.h:
3402 * src/modest-ui-actions.c:
3403 (modest_ui_actions_on_password_requested):
3404 Change the signal parameters, so it is obvious that we are providing
3405 the non human-readable server name, and receiving both the username
3406 and password, though changing of the username is not yet implemented.
3407 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3408 for the GNOME version.
3410 This should fix the projects.maemo.org bug NB#56209, though it does not
3411 work on Bora, because the gconf_client_get() for the password fails
3412 immediately after we save it with gconf_client_set().
3414 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3417 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3418 caused an undefined symbol error:
3419 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3421 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3423 * src/modest-tny-account-store.c:
3424 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3425 using a GError instead of a string message, so we can translate it in
3428 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3430 * src/maemo/modest-address-book.c:
3431 (modest_address_book_check_names):
3432 * src/maemo/modest-msg-view-window.c:
3433 (modest_msg_view_window_clipboard_owner_change):
3434 * src/modest-init.c: (modest_init_init_ui):
3435 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3436 (update_folders_cb), (modest_mail_operation_update_account):
3437 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3438 (modest_ui_actions_on_msg_attachment_clicked),
3439 (modest_ui_actions_on_msg_recpt_activated):
3440 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3441 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3442 (modest_msg_view_search_next):
3443 * src/widgets/modest-recpt-editor.c:
3444 (modest_recpt_editor_on_button_release_event),
3445 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3446 g_message(). At this point we should only be seeing interesting errors on
3447 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3449 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3451 (modest_wizard_dialog_force_title_update):
3452 * src/maemo/easysetup/modest-wizard-dialog.h:
3453 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3454 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3455 can update the title when appropriate. Otherwise the title is wrong if the
3456 pages are added after adding the notebook to the dialog.
3457 This must be a problem in HildonWizardDialog too.
3458 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3460 * src/maemo/easysetup/modest-easysetup-wizard.c:
3461 (create_subsequent_customsetup_pages),
3462 (create_subsequent_easysetup_pages):
3463 Call modest_wizard_dialog_force_title_update() so that the title is
3464 correct even with GTK+ < 2.10.
3465 This fixes projects.maemo.org bug NB#56145 .
3467 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3469 * src/maemo/modest-platform.c:
3470 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3471 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3474 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3476 * src/widgets/modest-window.h:
3477 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3478 and modest_window_save_state(), which invokes it.
3480 * src/widgets/modest-window-mgr.h:
3481 * src/widgets/modest-window-mgr.c:
3482 Added modest_window_mgr_save_state_for_all_windows(), which calls
3483 the save_state vfunc on all registered windows, if implemented.
3485 * src/gnome/modest-msg-edit-window.c:
3486 * src/gnome/modest-msg-view-window.c:
3487 * src/maemo/modest-msg-edit-window.c:
3488 * src/maemo/modest-msg-view-window.c:
3489 * src/maemo/modest-main-window.c:
3490 Specify the existing save_settings functions as implementations of
3491 ModestWindow::save_state_func().
3493 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3494 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3495 enabling hibernation, for instance.
3497 We may need to do the same thing for restoring settings.
3500 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3502 * src/widgets/modest-window-mgr.c:
3503 * src/widgets/modest-window-mgr.h:
3504 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3505 modest_window_mgr_get_hibernation_is_prevented().
3507 * src/maemo/modest-main-window.c:
3508 (on_hildon_program_is_topmost_notify): Prevent hibernation
3509 (possible when the application goes to the background in the WM),
3510 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3512 * src/maemo/easysetup/modest-easysetup-wizard.c:
3513 (modest_easysetup_wizard_dialog_init):
3514 * src/maemo/modest-account-settings-dialog.c:
3515 (modest_account_settings_dialog_init):
3516 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3517 (modest_connection_specific_smtp_edit_window_init):
3518 * src/maemo/modest-connection-specific-smtp-window.c:
3519 (modest_connection_specific_smtp_window_init):
3520 * src/maemo/modest-signature-editor-dialog.c:
3521 (modest_signature_editor_dialog_init):
3522 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3523 prevent hibernation while any of these account settings dialogs are open.
3525 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3527 * src/maemo/Makefile.am:
3528 * src/maemo/modest-osso-state-saving.c:
3529 * src/maemo/modest-osso-state-saving.h: Added
3530 modest_osso_load_state() and modest_osso_save_state() though they do
3531 nothing now. They should iterate through all the open windows and load/save
3533 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3534 save state when closing.
3536 * src/maemo/modest-main-window.c:
3537 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3538 Add a notification handler for the HildonProgram::is-topmost property,
3539 so we can allow hibernation when the application goes into the background.
3540 But we still need to detect when the accounts setup windows are open so
3541 we can stop hibernation when they are open.
3542 To do this, I also added the main window the HildonProgram. This might have
3543 other side-effects/benefits, and should maybe be done for other windows.
3545 * src/maemo/modest-osso-autosave-callbacks.h:
3546 * src/maemo/modest-osso-autosave-callbacks.c:
3547 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3548 though it does not do anything yet, and we might never need this to do
3549 anything. For instance, we already save drafts.
3551 * src/maemo/modest-platform.c: (modest_platform_init):
3552 Specify the libosso auto-save callback.
3554 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3556 * src/maemo/modest-platform.c:
3557 (modest_platform_set_update_interval):
3558 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3559 aparently stays valid between application instances, so we can use this
3560 to remove and reset it later. According to a maemo-developers email from
3563 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3565 * configure.ac: Depend on libalarm for Maemo.
3567 * src/dbus_api/modest-dbus-api.h:
3568 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3569 (on_send_receive), (modest_dbus_req_handler):
3570 Handle a SEND_RECEIVE D-Bus method.
3572 * libmodest-dbus-client/libmodest-dbus-client.c:
3573 (libmodest_dbus_client_send_and_receive):
3574 * libmodest-dbus-client/libmodest-dbus-client.h:
3575 Add C convenience functions for calling the new D-Bus method.
3577 * src/modest-platform.h:
3578 * src/gnome/modest-platform.c:
3579 * src/maemo/modest-platform.c:
3580 Added modest_platform_set_update_interval(), which uses the
3581 alarmd API on Maemo.
3582 (modest_platform_init),
3583 Call modest_platform_set_update_interval(), using a hard-coded
3584 interval for now (until the global settings dialog is implemented),
3585 though I am not sure that this makes sense yet.
3587 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3589 * src/dbus_api/modest-dbus-callbacks.c:
3590 (modest_osso_cb_hw_state_handler):
3591 * src/dbus_api/modest-dbus-callbacks.h:
3592 * src/maemo/modest-platform.c: (modest_platform_init):
3593 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3594 in case this has some effect on the ability for Maemo to ping the
3597 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3599 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3600 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3601 warning. It is probably a logic error, but I need to fix the build.
3603 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3605 * src/modest-account-mgr.h:
3606 * src/modest-account-mgr.c:
3607 (modest_account_mgr_account_names): Add a gboolean enabled_only
3608 parameter, so we can get lists of onlt the enabled accounts.
3610 (modest_account_mgr_add_account),,
3611 (modest_account_mgr_account_with_display_name_exists):
3612 * src/maemo/modest-msg-edit-window.c: (get_transports):
3613 * src/modest-account-mgr-helpers.c:
3614 (modest_account_mgr_set_first_account_as_default):
3615 * src/modest-init.c: (init_default_account_maybe):
3616 * src/modest-tny-account-store.c: (get_accounts):
3617 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3618 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3619 * tests/check_account-mgr.c: (START_TEST):
3620 Provide the extra parameter, as appropriate.
3622 * src/widgets/modest-account-view.c: (update_account_view):
3623 Do not show disabled accounts (meaning that there is no way to
3624 enable/disable accounts in the UI (the feature is not in our UI
3625 specification), so we can use this internally only to mark unfinished
3626 or temporary account data.
3628 * src/maemo/easysetup/modest-easysetup-wizard.c:
3629 (create_account): Add boolean enable parameter, so we can specify FALSE
3630 to create the temporary account.
3631 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3632 (on_before_next): When finishing, when there is a temporary account, just
3634 Also, use a timeout to delay the showing of the dialog until gconf is likely
3635 to return correct information, due to a maemo gconf bug that is fixed in
3636 osso 1.1, but not yet in Bora.
3637 However, the dialog stays on screen after it is destroyed.
3639 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3640 for invalid data when cancelling. Use a hildon note instead of a dialog
3641 to complain about invalid data. Do not show the account-saved note if the
3642 account is disabled (a temporary account that will not really be saved for use
3645 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3647 * src/modest-account-mgr-helpers.h:
3648 * src/modest-account-mgr-helpers.c:
3649 Added modest_account_mgr_unset_default_account(),
3650 Added modest_account_mgr_set_first_account_as_default().
3652 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3653 If it was the default account, unset the default account name.
3655 * src/maemo/modest-account-view-window.c:
3656 (on_delete_button_clicked): If it was the default account,
3657 set the first remaining account as the default instead.
3659 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3660 a NULL account or a NULL default account, to prevent a crash. This should
3661 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3664 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3666 * src/widgets/modest-recpt-editor.c:
3667 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3668 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3669 TODO comment for this. This fixes the build.
3671 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3672 be the best place for it. This will in future update all auto-update accounts,
3673 rather than just the current/default account, when that gconf key exists.
3674 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3675 if there are no accounts, before calling do_send_receive().
3676 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3678 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3679 * src/maemo/modest-main-window-ui.h:
3680 * src/maemo/modest-main-window.c: (on_connection_changed),
3681 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3682 directly, becaue the signal handler does more.
3684 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3686 * src/modest-account-mgr-helpers.c:
3687 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3688 for the case that the account does not exist.
3690 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3691 (equivalent to the modest account name) rather than the tinymail account name
3692 (equivalent to the modest account title - human readable) to get the account data.
3693 Check for null account data to prevent the crash, and add a TODO comment saying that
3694 this needs fixing because it is using the server account name instead of the account name.
3696 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3698 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3699 * src/maemo/modest-account-settings-dialog.c: (show_error),
3701 Use hildon_note_new_information() for informative and error messages,
3702 which seems to be expected for Maemo applications (no documentation that I know of
3703 says this). I am surprised that there is no distinction between info and error
3706 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3708 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3709 it is easy to find where this is used.
3711 * src/maemo/easysetup/modest-easysetup-wizard.c:
3712 (create_page_welcome), (create_page_account_details),
3713 (create_page_user_details), (create_page_complete_easysetup),
3714 (create_page_custom_incoming), (create_page_custom_outgoing),
3715 (create_page_complete_custom):
3716 * src/maemo/modest-account-settings-dialog.c:
3717 (create_page_account_details), (create_page_user_details),
3718 (create_page_incoming), (create_page_outgoing):
3719 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3720 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3721 (modest_connection_specific_smtp_edit_window_init):
3722 * src/maemo/modest-connection-specific-smtp-window.c:
3723 (modest_connection_specific_smtp_window_init):
3724 * src/maemo/modest-signature-editor-dialog.c:
3725 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3726 and scrolling policy as per the Email Application Layout Guide, if I have
3729 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3731 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3732 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3733 which were empty, because these vfuncs have been removed from TnyAccountStore.
3734 This fixes the build.
3736 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3738 * src/maemo/modest-main-window.c:
3739 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3740 showing/hiding it. Added TODO because it probably should not be NULL.
3741 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3742 because unnecessary g_warnings() make degugging difficult.
3744 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3746 * src/maemo/modest-msg-edit-window.c:
3747 (modest_msg_edit_window_select_color),
3748 (modest_msg_edit_window_select_background_color): 2 const corrections and
3749 moving 2 #endifs before closing brackets, to fix the build.
3751 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3753 * src/maemo/easysetup/modest-easysetup-wizard.h:
3754 * src/maemo/easysetup/modest-easysetup-wizard.c:
3755 (modest_easysetup_wizard_dialog_finalize),
3756 (on_button_edit_advanced_settings), (create_page_complete_custom),
3757 (on_response), (create_account):
3758 Implement the Advanced Settings edit button, by saving the account information,
3759 for the Advanded Settings dialog to use directly from gconf, and removing it
3760 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3761 Bug #5533 in the projects.maemo.org bugzilla.
3763 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3765 * src/maemo/modest-msg-view-window.c:
3766 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3767 when opening a message window.
3769 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3771 * src/maemo/easysetup/modest-easysetup-wizard.c:
3772 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3775 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3776 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3777 gconf settings. I probably added more checks than necessary, but that is safer.
3779 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3780 variable to fix the build, but this seems to be used when it is still NULL.
3782 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3784 * src/modest-platform.h:
3785 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3786 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3787 * src/modest-main.c: Implement this function so we can avoid using
3788 maemo-specific API from cross-platform code.
3790 * src/modest-tny-account-store.c:
3791 (get_smtp_specific_transport_account_for_open_connection):
3792 * src/modest-ui-actions.c: (check_for_connection),
3793 (modest_ui_actions_on_item_not_found):
3794 Use modest_platform_connect_and_wait() and put #idefs around other
3795 maemo-specific code, because only maemo currently has a way to
3796 identify connection names.
3798 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3800 * src/modest-tny-account-store.h:
3801 * src/modest-tny-account-store.c:
3802 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3803 the connection-specific SMTP server settings in the configuration.
3805 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3807 * src/maemo/modest-main-window.c: (on_connection_changed),
3809 * src/modest-main.c: (main), (start_ui), (send_mail):
3810 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3811 that is what is intended.
3813 * src/modest-ui-actions.c: (action_send), (action_receive),
3814 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3815 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3816 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3817 SMTP server is used when it is specified.
3819 (modest_ui_actions_on_send_receive):
3820 Check that a connection is open before proceeding.
3821 Receive and then send, instead of vice-versa, as per the specification.
3823 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3825 * src/modest-mail-operation.c:
3826 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3827 though I guess it should be something other than NULL.
3829 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3831 * src/maemo/easysetup/modest-easysetup-wizard.c:
3832 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3833 combo twice, to avoid an g_warning and to make it visible again.
3834 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3835 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3836 (already intended) dereference when detaching, because we then recreate the menu.
3837 But I am not sure why the warning was happening, and it is possible that this is a memory
3840 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3842 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3843 and uri_parse_mailto() utility functions.
3844 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3846 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3848 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3850 * src/dbus_api/modest-dbus-api.h:
3851 * src/dbus_api/modest-dbus-callbacks.c:
3852 Use an idle callback to execute the modest code in the application's own thread.
3853 Remove the helloworld example method.
3854 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3855 parsed, and the open-message method is not implemented because this is not yet implemented in
3857 * libmodest-dbus-client/libmodest-dbus-client.c:
3858 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3859 (libmodest_dbus_client_open_message):
3860 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3862 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3863 body without crashing.
3865 * tests/dbus_api/Makefile.am:
3866 * tests/dbus_api/test_mail_to.c:
3867 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3869 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3871 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3872 Added file to fix the build. Sorry.
3874 * src/dbus_api/Makefile.am:
3875 * src/dbus_api/modest-dbus-api.h:
3876 * src/dbus_api/modest-dbus-callbacks.h:
3877 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3878 (modest_dbus_req_handler):
3879 Put constants in a separate header so it can be reused by the
3880 client library, without duplication
3882 * libmodest-dbus-client/Makefile.am:
3883 * libmodest-dbus-client/libmodest-dbus-client.c:
3884 (libmodest_dbus_client_call_helloworld),
3885 (libmodfest_dbus_client_send_mail),
3886 (libmodfest_dbus_client_mailto),
3887 (libmodfest_dbus_client_open_message):
3888 * libmodest-dbus-client/libmodest-dbus-client.h:
3889 (Partly) Implement a send_mail D-Bus method.
3891 * tests/dbus_api/Makefile.am:
3892 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3893 the send_email D-Bus method.
3895 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3899 * libmodest-dbus-client/Makefile.am:
3900 * libmodest-dbus-client/libmodest-dbus-client.c:
3901 * libmodest-dbus-client/libmodest-dbus-client.h:
3902 * tests/dbus_api/Makefile.am:
3903 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3904 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3906 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3908 * src/maemo/easysetup/modest-easysetup-wizard.c:
3909 (create_page_account_details):
3910 * src/maemo/modest-account-settings-dialog.c:
3911 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3912 widgets, because this might not be the default in future versions of the Maemo GTK+.
3913 However, I can not not get capitalization to work even in a simple test case.
3915 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3917 * src/maemo/easysetup/modest-easysetup-wizard.c:
3918 (create_page_custom_incoming), (create_page_custom_outgoing):
3919 * src/maemo/modest-account-settings-dialog.c:
3920 (create_page_account_details), (create_page_incoming),
3921 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3922 instead of using gtk_check_button_with_label(), so they are aligned like the other
3923 widgets, as per the UI spec.
3925 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3927 * src/maemo/easysetup/modest-easysetup-wizard.c:
3928 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3929 * src/widgets/modest-validating-entry.c:
3930 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3931 Modest prefix instead of an EasySetup prefix.
3933 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3935 * src/widgets/modest-validating-entry.h:
3936 * src/widgets/modest-validating-entry.c: (on_insert_text),
3937 Added easysetup_validating_entry_set_max_func(), used to set a callback
3938 to call when the max number of characters is reached. GtkEntry has a max-length
3939 already but is silent about it.
3941 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3942 (create_page_account_details), (create_page_user_details),
3944 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3945 (create_page_account_details), (create_page_user_details),
3946 (create_page_outgoing):
3947 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3948 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3949 the UI spec, when the user tries to enter more than the max number of characters.
3951 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3953 * src/maemo/easysetup/modest-easysetup-wizard.c:
3954 (create_page_user_details), (create_page_custom_incoming),
3955 (create_page_custom_outgoing):
3956 * src/maemo/modest-account-settings-dialog.c:
3957 (create_page_user_details), (create_page_incoming),
3958 (create_page_outgoing):
3959 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3960 (modest_connection_specific_smtp_edit_window_init):
3961 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3962 not appropriate. Bad Maemo-specific defaults!.
3964 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3966 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3967 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3968 (modest_signature_editor_dialog_set_settings):
3969 Disable the label and textview when the checkbox is disabled, and use the
3970 specified (UI spec) default signature text.
3972 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3974 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3975 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3977 * src/modest-defs.h:
3978 * src/modest-account-mgr-helpers.h:
3979 * src/modest-account-mgr-helpers.c:
3980 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3982 * src/maemo/Makefile.am:
3983 * src/maemo/modest-signature-editor-dialog.c:
3984 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3987 * src/maemo/modest-account-settings-dialog.h:
3988 * src/maemo/modest-account-settings-dialog.c:
3989 (modest_account_settings_dialog_finalize), (on_button_signature),
3990 (save_configuration): Use the new dialog when the Edit button is pressed, and
3991 save the changes if necessary, as per the UI spec.
3993 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3995 * src/maemo/Makefile.am:
3996 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3997 based on maemo-develoers email from Dirk.
3999 * src/maemo/easysetup/modest-easysetup-wizard.c:
4000 (create_page_welcome), (create_page_account_details),
4001 (create_page_user_details), (create_page_complete_easysetup),
4002 (create_page_custom_incoming), (create_page_custom_outgoing),
4003 (create_page_complete_custom),
4004 (modest_easysetup_wizard_dialog_init):
4005 * src/maemo/modest-account-settings-dialog.c:
4006 (create_page_account_details), (create_page_user_details),
4007 (create_page_incoming), (create_page_outgoing),
4008 (modest_account_settings_dialog_init):
4009 * src/maemo/modest-connection-specific-smtp-window.c:
4010 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
4012 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4014 * src/maemo/easysetup/modest-easysetup-wizard.c:
4015 (create_page_account_details), (create_page_custom_outgoing),
4016 (create_page_complete_custom):
4017 * src/maemo/modest-account-settings-dialog.c:
4018 (create_page_user_details), (create_page_incoming),
4019 (create_page_outgoing):
4020 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4021 (modest_connection_specific_smtp_edit_window_init):
4022 Use the correct (UI spec) port min/max, and use horizontal separators,
4025 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4027 * src/maemo/easysetup/modest-easysetup-wizard.c:
4028 (set_default_custom_servernames):
4029 * src/maemo/modest-account-settings-dialog.c:
4030 (create_page_incoming), (on_combo_outgoing_security_changed),
4031 (on_combo_incoming_security_changed), (create_page_outgoing),
4032 (modest_account_settings_dialog_set_account_name),
4033 (save_configuration):
4034 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4035 (on_combo_security_changed),
4036 (modest_connection_specific_smtp_edit_window_init),
4037 (modest_connection_specific_smtp_edit_window_set_connection),
4038 (modest_connection_specific_smtp_edit_window_get_settings):
4039 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
4042 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4045 * src/maemo/easysetup/modest-easysetup-wizard.c:
4046 (create_page_custom_outgoing), (create_page_complete_custom):
4047 * src/maemo/modest-account-settings-dialog.c:
4048 (create_page_user_details), (create_page_outgoing):
4049 * src/maemo/modest-account-view-window.c: (button_box_new):
4050 Use changed logical IDs as per the most recent UI spec:
4051 mcen_bd_emailsetup_edit -> mcen_bd_edit
4052 mcen_bd_emailsetup_delete -> mcen_bd_delete
4053 mcen_bd_emailsetup_close -> mcen_bd_close
4055 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4059 * src/dbus_api/Makefile.am:
4060 * src/dbus_api/modest-dbus-callbacks.c:
4061 * src/dbus_api/modest-dbus-callbacks.h:
4062 * src/maemo/modest-platform.c: (modest_platform_init):
4063 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
4065 * tests/Makefile.am:
4066 * tests/dbus_api/Makefile.am:
4067 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
4069 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4071 * src/maemo/modest-account-settings-dialog.c:
4072 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4073 Removed unnecessary includes.
4075 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4077 * src/maemo/easysetup/modest-easysetup-wizard.c:
4078 * src/maemo/modest-account-settings-dialog.c:
4079 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4080 * src/widgets/Makefile.am:
4081 * src/widgets/modest-easysetup-secureauth-combo-box.c:
4082 * src/widgets/modest-easysetup-secureauth-combo-box.h:
4083 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
4084 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
4085 * src/widgets/modest-secureauth-combo-box.c:
4086 * src/widgets/modest-secureauth-combo-box.h:
4087 * src/widgets/modest-serversecurity-combo-box.c:
4088 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
4089 made the GObject names more consistent with the rest of the Modest code.
4091 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4093 * src/maemo/easysetup/Makefile.am:
4094 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4095 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
4096 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4097 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4098 * src/maemo/easysetup/modest-easysetup-wizard.c:
4099 * src/maemo/easysetup/modest-validating-entry.c:
4100 * src/maemo/easysetup/modest-validating-entry.h:
4101 * src/maemo/modest-account-settings-dialog.c:
4102 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4103 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
4104 widgets/ because they are used outside of easysetup too. After checking in,
4105 svn will allow me to rename them too.
4107 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4109 * src/gnome/modest-msg-edit-window.c:
4110 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
4111 linker error, to fix the build on the GNOME platform.
4112 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
4113 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
4114 ifdefed out to avoid a warning.
4116 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4118 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
4119 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
4120 some alternative for GTK+ 2.6.
4122 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4124 * src/maemo/modest-address-book.c: Added include to avoid a warning.
4126 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
4127 specified for EmailAccountsDialog in UI spec.
4129 * src/maemo/easysetup/modest-easysetup-wizard.c:
4130 * src/maemo/easysetup/modest-easysetup-wizard.h:
4131 * src/maemo/modest-account-settings-dialog.c:
4132 * src/maemo/modest-account-settings-dialog.h:
4133 Reuse a member window widget for the connection-specific SMTP server accounts,
4134 so we can tell it to create/save the accounts only if we actually save changes.
4136 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4137 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4138 (modest_connection_specific_smtp_edit_window_get_settings):
4139 Return a struct instance for temporarily remembering the entered data.
4141 * src/maemo/modest-connection-specific-smtp-window.h:
4142 * src/maemo/modest-connection-specific-smtp-window.c:
4143 (modest_connection_specific_smtp_window_finalize),
4144 (modest_connection_specific_smtp_window_fill_with_connections),
4146 (modest_connection_specific_smtp_window_save_server_accounts),
4147 (update_model_server_names): Do not actually save data until asked,
4148 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
4150 (on_selection_changed),
4151 (modest_connection_specific_smtp_window_init): Disable the edit
4152 button when nothing is selected.
4154 * src/modest-account-mgr-helpers.c:
4155 * src/modest-account-mgr-helpers.h:
4156 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
4159 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4161 * src/modest-account-mgr-helpers.h:
4162 * src/modest-account-mgr-helpers.c:
4163 (modest_account_mgr_get_unused_account_name),
4164 (modest_account_mgr_get_unused_account_display_name): Added these
4165 utility functions, to avoid code duplication.
4167 * src/maemo/easysetup/modest-easysetup-wizard.c:
4168 (create_page_account_details), (create_account):
4169 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4170 (on_combo_security_changed),
4171 (modest_connection_specific_smtp_edit_window_init),
4172 (modest_connection_specific_smtp_edit_window_save_settings):
4173 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4174 * src/maemo/modest-connection-specific-smtp-window.c:
4175 (modest_connection_specific_smtp_window_finalize),
4176 (modest_connection_specific_smtp_window_fill_with_connections),
4177 (on_button_edit), (modest_connection_specific_smtp_window_init):
4178 * src/maemo/modest-connection-specific-smtp-window.h:
4179 Implementing saving of connection-specific server accounts.
4181 But I need to refactor this so we can save the data for each
4182 possible connection-specific account and only actually create the server accounts
4183 when the easysetup finished, or the OK button is pressed on the account settings
4186 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4188 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4189 (on_combo_security_changed):
4190 (modest_connection_specific_smtp_edit_window_init):
4191 Auto-fill the port number as in the account settings.
4193 (modest_connection_specific_smtp_edit_window_set_connection):
4194 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4195 * src/maemo/modest-connection-specific-smtp-window.c:
4196 (fill_with_connections), (on_button_edit),
4197 (modest_connection_specific_smtp_window_init):
4198 Turn the edit window into a dialog to simplify the code, and
4199 set a WM hint as in a GtkDialog, because only a popup can be on top of
4200 another window in Maemo, and popups usually have no WM decoration.
4202 * src/modest-defs.h:
4203 * src/modest-account-mgr-helpers.c:
4204 (modest_account_mgr_set_connection_specific_smtp),
4205 (modest_account_mgr_remove_connection_specific_smtp),
4206 (modest_account_mgr_get_connection_specific_smtp):
4207 * src/modest-account-mgr-helpers.h: Some functions to write the
4208 connection-specific SMTP server information. Not yet used.
4211 * src/widgets/modest-folder-view.c: (text_cell_data):
4212 Fix a warning about an uninitialized variable.
4213 (on_configuration_key_changed): Put an #ifdef around the use
4214 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
4216 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4218 * src/maemo/modest-account-settings-dialog.h:
4219 * src/maemo/modest-account-settings-dialog.c:
4220 Added connect_for_modified() utility function to mark the new modified boolean.
4222 (create_page_account_details), (create_page_user_details),
4223 (create_page_incoming), (create_page_outgoing), (on_response),
4224 (modest_account_settings_dialog_init),
4225 (modest_account_settings_dialog_set_account_name):
4226 Only warn about unsaved changes when there are actually unsaved changes.
4228 * src/modest-account-mgr-helpers.c:
4229 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
4230 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
4231 to get the data from there in future.
4233 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4235 * src/modest-defs.h:
4237 * src/modest-account-mgr-helpers.h:
4238 * src/modest-account-mgr-helpers.c:
4239 Store the security account setting in a single conf key instead of using
4240 the options list, so that the list is left for just the to-be-removed camel hack,
4241 and because gconf_client_set_list() is failing for some reason.
4243 * src/modest-account-mgr.c:
4244 (modest_account_mgr_add_server_account):
4245 * src/maemo/modest-account-settings-dialog.c:
4246 (modest_account_settings_dialog_set_account_name),
4247 (save_configuration): Use the renamed functions.
4250 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4252 * src/widgets/Makefile.am:
4253 * src/widgets/modest-limit-retrieve-combo-box.c:
4254 * src/widgets/modest-limit-retrieve-combo-box.h:
4255 * src/widgets/modest-retrieve-combo-box.c:
4256 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4257 the account settings dialog.
4259 * src/modest-defs.h:
4260 * src/modest-account-mgr-helpers.h:
4261 * src/modest-account-mgr-helpers.c:
4262 (modest_server_account_get_option_secure_auth),
4263 (modest_server_account_set_option_secure_auth):
4264 * src/modest-account-mgr.c:
4265 (modest_account_mgr_add_server_account):
4266 Use the existing AUTH_MECH conf key for the secure-auth setting,
4267 instead of putting it in the list options, because this was actually used already.
4269 * src/maemo/modest-account-settings-dialog.c:
4270 (create_page_account_details),
4271 (modest_account_settings_dialog_set_account_name),
4272 (save_configuration):
4273 * src/maemo/modest-account-settings-dialog.h:
4274 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4275 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4277 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4279 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4280 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4281 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4283 * src/modest-defs.h:
4284 * src/maemo/modest-account-settings-dialog.c:
4285 (create_page_incoming), (on_combo_outgoing_security_changed),
4286 (on_combo_incoming_security_changed), (create_page_outgoing),
4287 (modest_account_settings_dialog_set_account_name),
4288 (save_configuration): Load/Save the port number, and change it when the
4289 security combo changes, to suitable defaults.
4291 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4293 * src/modest-account-mgr.c:
4294 (modest_account_mgr_add_server_account): Set the security and secure-auth
4295 options, and add a comment saying that the other camel-specific options should be
4298 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4300 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4302 * src/modest-tny-account-store.c: (account_list_free),
4303 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4304 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4307 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4309 * src/modest-protocol-info.c:
4310 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4311 is required by our UI spec. Maybe something in our implementation will use this eventually.
4312 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4313 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4314 instead of the previous 0 placeholder.
4316 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4317 secure-auth settings.
4318 * src/modest-account-mgr-helpers.h:
4319 * src/modest-account-mgr-helpers.c:
4320 (modest_server_account_data_get_option_secure_auth),
4321 (modest_server_account_set_option_secure_auth),
4322 (modest_server_account_data_get_option_security),
4323 (modest_server_account_set_option_security): Added this API for getting and setting the security
4324 and secure-auth settings.
4326 * src/maemo/modest-account-settings-dialog.h:
4327 * src/maemo/modest-account-settings-dialog.c:
4328 (modest_account_settings_dialog_finalize), (check_data),
4329 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4330 about changing titles.
4331 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4332 (save_configuration): Save the security and secure-auth settings.
4334 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4335 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4337 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4339 * src/modest-defs.h:
4340 * src/modest-account-mgr.c:
4341 (modest_account_mgr_add_server_account):
4342 Added and used defines for the options key and value pair strings,
4343 that are used so far, though they do not seem to correspond to anything in our
4344 UI specs or ModestProtocol enum.
4346 * src/modest-account-mgr-helpers.h:
4347 * src/modest-account-mgr-helpers.c:
4348 (compare_option_strings_for_name),
4349 (modest_server_account_data_get_option_value),
4350 (modest_server_account_data_get_option_bool),
4351 (modest_account_mgr_get_server_account_option):
4352 Added helper functions for parsing the options GSList.
4354 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4356 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4357 display name is based on the supplied account name.
4358 * src/modest-account-mgr.c:
4359 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4360 with an inefficient, but good-enough, implementation.
4362 * src/maemo/easysetup/modest-easysetup-wizard.c:
4363 (create_page_account_details), (on_before_next), (create_account):
4364 Check for existing display names rather than (non-user-visible) account names, and just
4365 create and set a unique account name at the end.
4367 * src/maemo/modest-account-settings-dialog.c:
4368 (modest_account_settings_dialog_init),
4369 (modest_account_settings_dialog_set_account_name),
4370 (create_page_incoming): Show the display name, instead of the account name.
4371 (on_response): Do some (not all) extra checks, as in the UI spec.
4372 (save_configuration): Save the display name if it was changed.
4374 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4376 * po/en_GB.po: Added needed logical ID and translation.
4377 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4378 (init_view): Made the is-default column clicking work.
4380 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4383 * src/maemo/easysetup/Makefile.am:
4384 * src/maemo/easysetup/modest-easysetup-wizard.c:
4385 (modest_easysetup_wizard_dialog_init):
4386 * src/maemo/easysetup/provider-data-test.keyfile:
4387 * src/maemo/easysetup/provider-data.keyfile:
4388 Moved the provider data file to the new modest-providers-data package and used it from there.
4390 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4392 * src/modest-local-folder-info.c:
4393 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4394 N_() was already used on the static strings, but this just marks it for translation without
4395 using the translation.
4397 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4399 * src/maemo/modest-account-settings-dialog.c:
4400 (create_page_incoming),
4401 (modest_account_settings_dialog_set_account_name):
4402 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4403 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4404 I will do this if nobody else gets there first.
4406 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4408 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4409 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4410 save the security stuff.
4412 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4414 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4415 Set the email address and user fullname, which I now see must be
4418 * src/maemo/modest-account-settings-dialog.h:
4419 * src/maemo/modest-account-settings-dialog.c:
4421 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4422 leave-on-server and authentication.
4423 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4426 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4429 * src/maemo/modest-account-settings-dialog.c:
4430 * src/maemo/modest-account-settings-dialog.h:
4431 Most (but not all) of the widgets are now present as specified by the UI spec.
4432 No changes are yet saved, and some details are not properly shown yet.
4434 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4436 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4438 * src/maemo/Makefile.am:
4439 * src/maemo/modest-account-settings-dialog.c:
4440 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4441 an existing account. Doesn't do much yet.
4443 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4444 Open the accounts settings dialog when Edit is clicked.
4446 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4448 * src/maemo/easysetup/Makefile.am:
4449 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4451 * src/maemo/easysetup/modest-easysetup-wizard.c:
4452 (modest_easysetup_wizard_dialog_init):
4453 Try to get the source directory from the build system,
4454 instead of hard-coding "./" into the source code, when opening our local
4455 copies of the configuration files.
4456 But this still fails when opening the wizard from the Accounts window,
4457 maybe because the working directory seems to change at runtime.
4458 So the wizard will fail the second time unless you copy the files into their
4459 proper locations - see the stdout warnings for the paths.
4461 (create_page_account_details),(on_before_next):
4462 Check for existing non-server accounts instead of server accounts,
4463 so the default account name is useful again, and to prevent trying to
4466 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4467 Show the wizard when New is clicked.
4469 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4470 (init_view): Show the column headers, and show the columns that are
4471 specified in the UI specs. However, something in Maemo's GTK+ prevents
4472 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4473 change the default account. This is despite unsetting the special properties.
4475 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4477 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4478 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4479 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4480 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4481 to make that clearer.
4482 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4484 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4486 * src/maemo/modest-account-view-window.c:
4487 (modest_account_view_window_init),
4488 (modest_account_view_window_new):
4489 Use the same buttons as specified in the
4490 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4491 the existing widgets, which never had a chance of working.
4492 Put the ModestAccountView treeview in a scrolled window.
4493 Do not repeat the initialization in both _init() and _new().
4495 * src/widgets/modest-account-view.c: (update_account_view):
4496 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4497 this widget and window shows no accounts.
4499 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4501 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4503 * src/maemo/easysetup/modest-easysetup-wizard.c:
4504 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4505 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4506 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4509 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4510 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4511 accounts exist yet, as in the UI spec.
4513 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4515 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4517 * src/maemo/Makefile.am:
4518 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4519 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4520 New window for editing connection-specific smtp details.
4521 Not fully implemented.
4523 * src/maemo/modest-connection-specific-smtp-window.c:
4524 (modest_connection_specific_smtp_window_finalize) :
4525 unref the tree model.
4526 (on_button_edit): Show the edit window.
4528 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4530 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4533 * src/maemo/Makefile.am:
4534 * src/maemo/modest-connection-specific-smtp-window.c:
4535 * src/maemo/modest-connection-specific-smtp-window.h:
4536 New window for showing the list of connections, for connection-specific
4537 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4538 * src/maemo/easysetup/modest-easysetup-wizard.c:
4539 (create_page_custom_outgoing): Show the new window when the button is clicked.
4541 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4543 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4544 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4545 * src/maemo/modest-msg-edit-window.c:
4546 (modest_msg_edit_window_insert_image):
4547 * src/modest-conf.c: (modest_conf_key_escape):
4548 * src/modest-mail-operation.c:
4549 (modest_mail_operation_send_new_mail):
4550 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4551 (modest_ui_actions_on_new_account):
4552 * src/widgets/modest-attachment-view.c: (update_filename_request):
4553 * src/widgets/modest-mail-header-view.c:
4554 Corrected warnings that were breaking the build, by commenting out unused variables,
4555 and a function, and by including a header.
4557 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4559 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4560 so we can #ifdef around platform-specific code when necessary.
4561 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4562 to allow this to build for the GNOME platform too.
4564 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4566 * src/maemo/easysetup/modest-easysetup-wizard.c:
4567 Added util_increment_name() and used it in create_page_account_details()
4568 to make sure that the default account name is always a new name.
4570 (modest_easysetup_wizard_dialog_init),
4571 (set_default_custom_servernames): Some minor memory management fixes.
4573 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4577 * src/modest-runtime.c: (init_i18n): Restored the translation
4578 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4579 are defined in config.h, and the translations are installed.
4581 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4582 is defined for translation.
4584 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4586 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4588 * src/maemo/easysetup/modest-easysetup-wizard.c:
4589 (modest_easysetup_wizard_dialog_init):
4590 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4591 Use realistic paths (though they should use $prefix generically) to the
4592 mcc_mapping and provider-data.keyfile files which might work when they
4593 are installed by the future version of the operator-wizard package,
4594 and then fallback to paths in our source code, with an explanatory
4597 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4601 * src/maemo/Makefile.am:
4602 * src/maemo/easysetup/: Added files from the previously-exernal
4603 osso-modest-easysetup.
4604 * src/maemo/modest-main-window-ui.h:
4605 * src/modest-ui-actions.c:
4606 * src/modest-ui-actions.h:
4607 Added modest_ui_actions_on_new_account() as a signal handler for the
4608 New Account menu item. It shows the easysetup wizard.
4609 * po/en_GB.po: Added additional needed logical IDs and translations.