1 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
3 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4 Fixed projects.maemo.org bug NB# 58991
6 2007-06-13 Murray Cumming <murrayc@murrayc.com>
8 * src/modest-init.c: (modest_init_init_core),
9 (modest_init_local_folders): Fixed compilation errors.
11 2007-06-13 Murray Cumming <murrayc@murrayc.com>
13 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
14 Remove unnecessary lib/include, though it is good in principle when needed.
16 * src/modest-init.c: (modest_init_one_local_folder),
17 (modest_init_local_folders):
18 * src/modest-init.h: Initialize the .modest library for memory cards,
19 instead of just doing nothing for them. This should allow us to create
20 folders there, fixing projects.maemo.org bug NB#59297.
22 2007-06-13 Murray Cumming <murrayc@murrayc.com>
24 * libmodest-dbus-client/libmodest-dbus-client.c:
25 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
26 (libmodest_dbus_client_compose_mail),
27 (libmodest_dbus_client_open_message),
28 (libmodest_dbus_client_send_and_receive),
29 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
31 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
32 (on_idle_open_message), (modest_dbus_req_handler),
33 (search_result_to_message), (modest_dbus_req_filter):
34 * src/modest-search.c: (add_hit), (modest_search_folder),
35 (modest_search_all_accounts): Improved debug messages.
37 * tests/dbus_api/test_open_message.c: (main): Improved comments.
39 * src/modest-tny-account-store.c:
40 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
43 2007-06-13 Murray Cumming <murrayc@murrayc.com>
46 2007-06-12 Murray Cumming <murrayc@murrayc.com>
48 * src/modest-tny-account-store.c: (get_server_accounts):
49 Call modest_tny_local_folders_account_add_merged_outbox_folders()
50 even when there are no accounts, so that the Outbox folder is always
51 visible. This fixes projects.maemo.org bug NB#60158.
53 2007-06-12 Murray Cumming <murrayc@murrayc.com>
55 * src/maemo/modest-main-window.c: (create_details_widget):
56 Use the mcen_va_never logical ID.
58 2007-06-12 Murray Cumming <murrayc@murrayc.com>
60 * src/dbus_api/modest-dbus-api.h:
61 * src/dbus_api/modest-dbus-callbacks.c:
62 (on_idle_open_default_inbox), (on_open_default_inbox),
63 (modest_dbus_req_handler):
64 Added a new OpenDefaultInbox method.
66 * libmodest-dbus-client/libmodest-dbus-client.h:
67 * libmodest-dbus-client/libmodest-dbus-client.c:
68 Added libmodest_dbus_client_open_default_inbox() to call the new
69 dbus method. This should be useful to projects.maemo.org bug NB#57214,
70 though it should maybe be used by a new osso-email-interface function.
72 * tests/dbus_api/Makefile.am:
73 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
76 2007-06-12 Murray Cumming <murrayc@murrayc.com>
78 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
79 NULL, so that the signals get all the keys. This should not actually
80 change any behaviour because we currently update everything when anything
83 2007-06-12 Murray Cumming <murrayc@murrayc.com>
85 * src/widgets/modest-folder-view.c: (text_cell_data),
86 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
87 (find_inbox_iter): If tinymail tells us that the folder is
88 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
89 This causes the inbox to be selected at startup, fixing part of
90 projects.maemo.org bug NB#56305.
92 * src/modest-ui-dimming-rules.c:
93 (modest_ui_dimming_rules_on_tools_smtp_servers):
94 * src/modest-ui-dimming-rules.h: Added a callback function to dim
95 the SMTP servers menu item.
96 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
97 that the SMTP Servers menu item is dimmed when there are no accounts,
98 as a future version of the UI spec will require. This fixes
99 projects.maemo.org bug NB#56305.
101 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
103 * src/maemo/modest-maemo-utils.c:
104 (modest_maemo_utils_get_supported_secure_authentication_methods):
105 Added label to dialog instead of unreadable title
107 * src/maemo/modest-main-window.c: (sync_accounts_cb),
108 (modest_main_window_new):
109 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
112 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
113 * src/modest-account-mgr.h:
114 Added method to avoid code duplication
116 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
117 (modest_ui_actions_on_send_receive):
118 Use modest_account_mgr_has_accounts
120 2007-06-11 Murray Cumming <murrayc@murrayc.com>
122 * src/maemo/easysetup/modest-presets.c:
123 (modest_presets_get_info_server_security): Do not report secure auth
125 * src/modest-protocol-info.c: Use the defines for the gconf key names
126 for secure authentication. This was not working because we were writing
127 Password and reading password, and the check was case sensitive.
128 With this, gmail now works for receiving and sending when created via
131 2007-06-11 Murray Cumming <murrayc@murrayc.com>
133 * src/maemo/easysetup/modest-presets.c:
134 (modest_presets_get_info_server_security): Correct the key name for
135 SecureSmtp, because it seems to be case-sensitive.
136 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
137 Do not try to get the 0th notebook page if there are 0 pages, to
140 2007-06-11 Murray Cumming <murrayc@murrayc.com>
142 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
143 Prevent use of the new notification feature for now, because it currently
144 shows one dialog for each new email, which is annoying.
146 2007-06-11 Murray Cumming <murrayc@murrayc.com>
148 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
149 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
150 when no country was selected, so that we show the global ones.
151 * src/maemo/easysetup/modest-presets.c:
152 (modest_presets_get_providers): Return only the global providers, not
153 all providers when mmc=0 was requested.
155 2007-06-11 Murray Cumming <murrayc@murrayc.com>
157 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
158 (easysetup_provider_combo_box_fill): Remove debug code that showed the
159 provider ID in the combo.
161 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
162 Do not show the page numbers, because it would be confusing when we add
163 the 2 extra pages for the custom setup, when the user chooses the "Other"
164 provider. This fixes projects.maemo.org bug NB#59028
166 * src/modest-init.c: (modest_init_init_core),
167 (modest_init_local_folders):
169 * src/modest-tny-account.c:
170 (modest_tny_account_new_for_local_folders): Do not create default folders
171 for the memory card. This should fix projects.maemo.org bug NB#59328.
173 2007-06-11 Murray Cumming <murrayc@murrayc.com>
175 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
176 Free the changed_conf_keys string items. They are already freed in the
177 idle handler if that runs first.
179 2007-06-11 Murray Cumming <murrayc@murrayc.com>
181 * src/modest-ui-actions.c:
182 (modest_ui_actions_on_password_requested): Check that the server name
183 is not NULL, because I just saw a password dialog with (null) as the
186 * src/modest-tny-folder.[h|c]: Added
187 modest_tny_folder_is_memory_card_folder().
188 * src/modest-ui-dimming-rules.c:
189 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
190 menu item for memory cards, as per the UI spec (section 7.4). This should
191 fix projects.maemo.org bug NB#59297.
193 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
195 * src/maemo/modest-main-window.c: (sync_accounts_cb):
196 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
197 is another problem with the code, see Murray's comment at line 772)
199 2007-06-08 Murray Cumming <murrayc@murrayc.com>
201 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
202 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
203 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
204 (load_from_file), (easysetup_country_combo_box_init),
205 (easysetup_country_combo_box_get_active_country_ids),
206 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
207 instead of just one ID, to avoid duplicate country names in the UI.
209 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
210 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
211 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
212 a single ID, avoiding duplicate providers.
213 * src/maemo/easysetup/modest-easysetup-wizard.c:
214 (on_combo_account_country): Adapt to use a list.
216 2007-06-08 Murray Cumming <murrayc@murrayc.com>
218 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
219 keys changed in the last X seconds.
221 * src/modest-account-mgr.h:
222 * src/modest-account-mgr.c: (on_timeout_notify_changes),
223 (on_key_change), (modest_account_mgr_class_init),
224 (modest_account_mgr_init), (modest_account_mgr_finalize):
225 As the keys are changed, save them in a GSList* and signal that GSList*
226 further every X seconds, to batch changes, to allow us to do just one
227 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
228 bug NB#56941 and other (UI-blocking) delays when changing account settings.
230 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
231 changed signal signature.
233 * src/modest-conf.c: (modest_conf_set_list),
234 (modest_conf_on_change): Reenable notification.
236 (modest_conf_maemo_fake_on_change): Comment out the hack that
237 notified immediately instead of asynchronously.
239 * src/widgets/modest-account-view.h:
240 * src/widgets/modest-account-view.c:
241 (update_account_view): Select the previously-selected account ID,
242 if possible. This fixes projects.maemo.org bug NB#56933.
244 (on_account_changed), (on_account_removed),
245 (modest_account_view_select_account):
247 Remove the block/unblock functions
248 because they were not useful.
250 * src/maemo/modest-account-view-window.c:
251 (on_delete_button_clicked), (on_edit_button_clicked),
252 (on_new_button_clicked): Remove the use of the non-working block/unblock.
254 2007-06-08 Murray Cumming <murrayc@murrayc.com>
256 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
257 Improve the error dialog to show Incorrect Account Settings, which seems
258 clearer, and say that the internal error message (to be removed from the
259 dialog later) is often misleading.
260 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
262 * src/modest-tny-account.c:
263 (modest_tny_account_new_from_server_account): Uncomment the printf of the
264 URL because this is so useful for debugging on the device.
266 * src/widgets/modest-serversecurity-combo-box.c:
267 (modest_serversecurity_combo_box_fill): Correct a logical ID.
269 2007-06-08 Murray Cumming <murrayc@murrayc.com>
271 * src/modest-mail-operation.c:
272 (modest_mail_operation_send_new_mail):
273 Added a comment about a nasty but apparently harmless message. Details
274 added to the wiki g_warnings() page.
276 2007-06-08 Murray Cumming <murrayc@murrayc.com>
278 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
279 (modest_tny_send_queue_class_init):
280 Do not use the priv struct because it is empty, to avoid g_warnings
281 about a non-existant priv struct.
283 * src/modest-tny-account-store.c:
284 (modest_tny_account_store_get_server_account),
285 (modest_tny_account_store_get_transport_account_for_open_connection
286 ): Do not try to get transport server accounts for local folders,
287 because they don't have any. This avoids a g_warning().
289 * src/maemo/modest-main-window.c:
290 (modest_main_window_notify_send_receive_initied),
291 (on_configuration_key_changed):
292 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
294 * src/modest-mail-operation.c:
295 (modest_mail_operation_update_account):
296 * src/modest-tny-account-store.h:
297 * src/modest-tny-account.c:
298 (modest_tny_account_get_special_folder),
299 (modest_tny_account_new_for_local_folders),
300 (modest_tny_account_new_for_per_account_local_outbox_folder):
301 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
302 * src/modest-tny-local-folders-account.c:
303 (add_account_folders_to_merged_folder):
304 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
305 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
306 (modest_ui_actions_on_send):
307 * src/widgets/modest-folder-view.c: (update_model):
308 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
309 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
310 modest_tny_account_store_get_tny_account_by_account() to
311 modest_tny_account_store_get_server_account() to make the code clearer.
313 2007-06-07 Marcus Bauer <marcusb@openismus.com>
315 * src/dbus_api/modest-dbus-api.h:
316 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
317 * src/maemo/modest-msg-edit-window.c:
318 (modest_msg_edit_window_attach_file_noninteractive):
319 added g_warning in case the file to be attached does not exist
320 * tests/dbus_api/test_compose_mail.c: (main):
321 removed obsolete comment, added generic files as test case
323 2007-06-07 Murray Cumming <murrayc@murrayc.com>
325 * src/modest-tny-account-store.c: (get_server_accounts):
326 Create the local folders account only once, not once for each outbox, and
327 not only when there are some outboxes.
329 2007-06-07 Murray Cumming <murrayc@murrayc.com>
331 * src/widgets/modest-folder-view.c: (update_model): Comment out some
332 code that is causing a crash at startup. Sergio says that he is fixing this.
334 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
336 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
337 * src/maemo/modest-account-settings-dialog.c:
338 (create_page_outgoing),
339 (modest_account_settings_dialog_set_account_name),
340 (save_configuration):
341 - Fixed handling of the "Use secure authentication" toggle to comply with
342 the ui specification. See also projects.maemo.org bug NB#58400
344 - Restore the Secure connection setting combo correctly when loading
347 * src/maemo/modest-maemo-utils.c:
348 (on_camel_account_get_supported_secure_authentication),
349 (modest_maemo_utils_get_supported_secure_authentication_methods):
350 Fixed a crasher if operation is canceled
352 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
353 (modest_protocol_info_auth_is_secure):
354 * src/modest-protocol-info.h:
356 Added two new methods to determine if a protocol/auth method is secure/encrypted in
357 the sense of the "Use secure authentication" toggle.
359 2007-06-07 Murray Cumming <murrayc@murrayc.com>
361 * src/modest-tny-account-store.h:
362 * src/modest-tny-account-store.c:
363 Added modest_tny_account_store_get_local_folders_account().
365 * src/modest-tny-folder.h:
366 * src/modest-tny-folder.c:
367 (modest_tny_folder_get_account):
368 Added this replacement for tny_folder_get_account() which returns
369 the local-folders account for TnyMergeFolders, to avoid the
370 warning about the unimplemented get_account_func() vfunc().
372 (modest_tny_folder_get_rules),
373 * src/modest-ui-actions.c:
374 (modest_ui_actions_on_folder_selection_changed):
375 * src/modest-mail-operation.c:
376 (modest_mail_operation_remove_folder),
377 (modest_mail_operation_xfer_folder),
378 (modest_mail_operation_rename_folder),
379 (modest_mail_operation_get_msg),
380 (modest_mail_operation_get_msgs_full),
381 (modest_mail_operation_remove_msg),
382 (modest_mail_operation_xfer_msgs),
383 (modest_mail_operation_refresh_folder):
384 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
386 2007-06-07 Murray Cumming <murrayc@murrayc.com>
388 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
389 (modest_server_account_set_security):
390 * src/modest-defs.h: Add comments explaining that our
391 UI spec means TLS when it says Normal, so these do not look like errors.
393 * src/modest-tny-account.c:
394 (modest_tny_account_new_from_server_account): Use the new tinymail
395 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
396 for TLS. This should fix projects.maemo.org bug NB#58460.
398 2007-06-06 Murray Cumming <murrayc@murrayc.com>
400 * src/maemo/easysetup/modest-easysetup-wizard.c:
401 (create_account): Correct the position of the gconf sanity check warning.
402 (on_button_edit_advanced_settings): Show the dialog immediately, instead
403 of using the g_idle_add() hack, because this does not seem to be necessary
404 on osso 1.1. It might even work on Maemo Bora if the problems were actually
405 caused by something other than maemo's gconf.
406 This fixes projects.maemo.org bug #59022.
408 2007-06-06 Murray Cumming <murrayc@murrayc.com>
410 * src/modest-account-mgr-helpers.c:
411 (modest_account_mgr_get_default_account): Do not check that the account
412 exists if there is no default account (NULL), to fix a runtime warning.
414 2007-06-06 Murray Cumming <murrayc@murrayc.com>
416 * src/widgets/modest-folder-view.c: (update_model):
417 Do not unref the treemodel before we have finished with it.
418 This prevents a valgrind warning and an occasional crash at startup.
420 2007-06-06 Marcus Bauer <marcusb@openismus.com>
422 * libmodest-dbus-client/libmodest-dbus-client.h:
423 added libmodest_dbus_client_compose_mail()
424 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
426 added functions needed for SendAsMail() functionality
427 * src/maemo/modest-msg-edit-window.c:
428 (modest_msg_edit_window_attach_file_noninteractive):
429 non interactively attaching files to message edit window
430 * src/widgets/modest-msg-edit-window.h:
431 * tests/dbus_api/Makefile.am:
432 added test_compose_mail.c
433 * tests/dbus_api/test_compose_mail.c: (main):
435 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
437 * src/modest-account-view.c:
438 Fixed bug projects.maemo.org bug NB#59307
440 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
442 * src/maemo/easysetup/modest-easysetup-wizard.c:
443 (get_serverport_incoming), (on_before_next), (create_account):
444 * src/maemo/modest-account-settings-dialog.c:
445 (modest_account_settings_dialog_set_account_name):
446 * src/maemo/modest-maemo-utils.c:
447 (on_camel_account_get_supported_secure_authentication_status),
448 (on_camel_account_get_supported_secure_authentication),
449 (on_secure_auth_cancel),
450 (modest_maemo_utils_get_supported_secure_authentication_methods):
452 Implemented security authentication for settings and easysetup.
454 2007-06-05 Murray Cumming <murrayc@murrayc.com>
456 * src/maemo/modest-main-window.c: (create_details_widget):
457 Show the total size for memory card accounts too, instead of showing
458 the name again. Fixes bug projects.maemo.org bug NB#59307.
460 2007-06-05 Murray Cumming <murrayc@murrayc.com>
463 * src/modest-tny-simple-folder-store.c:
464 * src/modest-tny-simple-folder-store.h: Removed.
466 * src/modest-tny-local-folders-account.h
467 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
468 for the local-folders maildir, with an extra TnyMergedFolder containing
469 the folders of the per-account outbox store accounts.
470 * src/modest-tny-account-store.c: (get_server_accounts):
471 Add the outboxes to the special local folders account after creating it.
473 * src/modest-tny-account.c:
474 (modest_tny_account_new_for_local_folders): Create the derived
475 account when creating the main local-folders account.
477 * src/maemo/modest-main-window.c: (create_details_widget),
478 (modest_main_window_set_contents_style):
479 Adapted to the use of the derived account instead of the folder store.
481 * src/modest-ui-actions.c:
482 (modest_ui_actions_on_folder_selection_changed):
483 * src/modest-ui-dimming-rules.c:
484 (modest_ui_dimming_rules_on_new_folder):
485 * src/widgets/modest-folder-view.c: (text_cell_data),
486 (icon_cell_data), (filter_row), (update_model),
487 (get_cmp_rows_type_pos):
490 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
491 Do not get the priv struct, because no priv struct has been set,
492 to avoid a runtime warning.
494 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
495 #ifelse with #else, to fix a warning, to fix the build.
498 2007-06-05 Christian Kellner <ckellner@openismus.com>
500 * libmodest-dbus-client/libmodest-dbus-client.c:
501 Fix small typo in doc (why do you always see them
502 AFTER committing stuff?)
505 2007-06-05 Christian Kellner <ckellner@openismus.com>
507 * libmodest-dbus-client/libmodest-dbus-client.c:
508 (libmodest_dbus_client_search):
509 Initialize hit list with NULL. Also set folder list
510 to "" if NULL was supplied.
513 2007-06-03 Christian Kellner <ckellner@openismus.com>
515 * libmodest-dbus-client/libmodest-dbus-client.c:
516 (modest_search_hit_list_free):
517 Make it save to call it with NULL.
519 * src/dbus_api/modest-dbus-callbacks.c:
520 * src/modest-search.c:
521 Return full ModestSearchHits as the search result list not TnyHeader
522 since can't be around withouth the correspoding TnyFolder.
524 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
526 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
527 Added currently commented code to check for secure auth
529 * src/maemo/modest-account-settings-dialog.c: (on_response),
530 (save_configuration), (show_ok):
531 Fixed projects.maemo.org bugs NB #59248 and #59251
533 * src/maemo/modest-maemo-utils.c:
534 (on_camel_account_get_supported_secure_authentication_status),
535 (on_camel_account_get_supported_secure_authentication),
536 (modest_maemo_utils_get_supported_secure_authentication_methods):
537 * src/maemo/modest-maemo-utils.h:
538 Moved get_supported_secure_authentication() method here to be able
539 to use it from easysetup wizard.
541 * src/modest-pair.c: (on_pair_compare_as_string):
542 Should compare string with first part of pair and not
543 strcmp pairs which will crash.
545 * src/modest-protocol-info.c:
546 (modest_protocol_info_protocol_is_store):
547 * src/modest-protocol-info.h:
548 Added modest_protocol_info_get_auth_protocol_name()
550 2007-06-03 Armin Burgmeier <armin@openismus.com>
552 * src/modest-mail-operation.c:
553 (modest_mail_operation_get_msgs_full): Set priv->account also when
554 only retrieving a single message. This avoids a crash when canceling
557 (modest_mail_operation_notify_end): Do not explicitely remove the
558 operation from the queue but only emit the progress_changed signal.
559 The queue itself listens to that signal to remove the operation when
560 it is finished. This reduces coupling and removes a potential deadlock
561 when modest_mail_operation_notify_end() is called from the queue
562 itself. If that is a problem performance-wise, I would suggest to
563 implement a status-changed signal or something.
565 * src/modest-mail-operation-queue.c: Make sure to never call a
566 function from another file while the queue is locked. This (hopefully)
567 fixes another deadlock when exiting the application while retrieving
570 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
572 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
573 Fixed build if libogs is not available
575 2007-06-03 Christian Kellner <ckellner@openismus.com>
577 * libmodest-dbus-client/libmodest-dbus-client.h:
578 * libmodest-dbus-client/libmodest-dbus-client.c:
579 (libmodest_dbus_client_delete_message):
580 Implement deletion of messages (Client side).
582 (modest_search_hit_free),
583 (modest_search_hit_list_free):
584 Utility functions to free the result hits.
586 * src/dbus_api/modest-dbus-api.h:
587 * src/dbus_api/modest-dbus-callbacks.c:
589 (modest_dbus_req_handler):
590 Implement deletion of messages (Server side).
592 * tests/dbus_api/test_search.c: (main):
595 * tests/dbus_api/Makefile.am:
596 * tests/dbus_api/test_delete_message:
597 Add little test for the message deletion logic
599 2007-06-03 Armin Burgmeier <armin@openismus.com>
601 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
602 when the operation queue was not empty. projects.maemo.org bug
605 2007-06-03 Armin Burgmeier <armin@openismus.com>
607 * src/widgets/modest-account-view.c
608 (on_account_default_toggled): Toggle default account column
609 explicitely instead of waiting for gconf notification (which is
610 currently ignored). This should fix projects.maemo.org bug NB#56910
611 for now. It should probably be removed when gconf notifications are
614 2007-06-03 Christian Kellner <ckellner@openismus.com>
616 * libmodest-dbus-client/libmodest-dbus-client.c:
617 Removed debugging spew.
619 * src/dbus_api/modest-dbus-callbacks.c:
620 Added debugging info.
622 * src/modest-search.c:
623 (modest_search_all_accounts):
624 Use tny_account_store_get_accounts () on the account store
625 to get all accounts which is the way to get all accounts.
627 * tests/dbus_api/test_search.c: (main):
628 Make it possible to supply the search term on the command line.
630 2007-06-03 Christian Kellner <ckellner@openismus.com>
632 * libmodest-dbus-client/libmodest-dbus-client.c:
633 * libmodest-dbus-client/libmodest-dbus-client.h:
634 Implement searching for mesages over raw dbus. (Client side)
636 * src/dbus_api/Makefile.am:
637 * src/dbus_api/modest-dbus-api.h:
638 * src/dbus_api/modest-dbus-callbacks.c:
639 * src/dbus_api/modest-dbus-callbacks.h:
640 Search framework (Server side). Also implement on_idle_open_message().
642 * src/maemo/modest-platform.c: (modest_platform_init):
643 Prepare for raw dbus/osso rpc interaction.
645 * src/modest-search.h:
646 Changed minsize from unspecific guint to guint32.
648 * src/modest-search.c:
650 Added strange hack which magically made tnymail work.
652 (modest_search_folder),
653 (modest_search_account),
654 (modest_search_all_accounts):
655 Implement helper functions to search all accounts, specific account
658 * tests/dbus_api/Makefile.am:
659 * tests/dbus_api/test_open_message.c:
660 Read url to open from commandline.
662 * tests/dbus_api/test_search.c:
663 Implement small test for dbus search stuff
665 2007-06-02 Armin Burgmeier <armin@openismus.com>
667 * src/maemo/modest-account-settings-dialog.c: Changed window title to
668 include account type and account title. This fixes projects.maemo.org
671 * src/maemo/modest-account-view-window.c: Set a title for the window.
673 2007-06-02 Armin Burgmeier <armin@openismus.com>
675 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
676 incoming and outgoing server name based on email address and server
677 types as long as the names have not been edited manually. This fixes
678 projects.maemo.org bug NB#58671.
680 2007-06-02 Armin Burgmeier <armin@openismus.com>
682 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
683 server type cannot be changed in future to the incoming details page
684 when creating an account. This fixes projects.maemo.org bug NB#59029.
686 2007-06-02 Armin Burgmeier <armin@openismus.com>
688 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
689 and assigned max width chars so that they wrap instead of being
690 truncated. Fixes projects.maemo.org bug NB#56126.
692 2007-06-02 Armin Burgmeier <armin@openismus.com>
694 * src/maemo/modest-connection-specific-smtp-window.c: Add an
695 introductory note to the connection specific smtp servers dialog, as
696 section 8.12 of the email UI specification requires. This fixes
697 projects.maemo.org bug NB#59212.
699 2007-06-01 Murray Cumming <murrayc@murrayc.com>
701 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
702 Check for running mail operations, and offer to cancel them, as per the UI
703 spec. This fixes projects.maemo.org bug NB#59041 .
704 However, I suspect that tinymail may still use the network connection
705 in ways that we cannot detect or cancel. But it should at least adapt to
708 2007-06-01 Murray Cumming <murrayc@murrayc.com>
710 * src/modest-tny-account-store.c: (recreate_all_accounts),
711 (get_cached_accounts), (get_server_accounts): Do more sensible
712 ref-counting of the temporarily-cached outbox accounts list. This seems
713 to fix a crash when entering the password when the password was wrong.
715 2007-06-01 Murray Cumming <murrayc@murrayc.com>
717 * src/gnome/modest-main-window.c: (connect_signals):
718 * src/modest-tny-account-store.c: (get_password),
719 (modest_tny_account_store_alert): Added comments and clues and
720 commented-out code about how we currently fail to deal with connection
721 errors and wrong passwords, and how we should.
723 2007-06-01 Murray Cumming <murrayc@murrayc.com>
725 * src/widgets/modest-retrieve-combo-box.c:
726 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
727 This fixes projects.maemo.org bug NB#58472 .
729 2007-06-01 Murray Cumming <murrayc@murrayc.com>
731 * src/maemo/easysetup/modest-easysetup-wizard.c:
732 (create_page_complete_easysetup):
733 (create_page_complete_custom): Correct the last commit,
734 putting the correct sentences in the correct pages.
736 2007-06-01 Murray Cumming <murrayc@murrayc.com>
738 * src/maemo/easysetup/modest-easysetup-wizard.c:
739 (create_page_complete_custom): Show the second sentence of text
740 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
743 2007-06-01 Murray Cumming <murrayc@murrayc.com>
745 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
746 Set the leave-on-server conf key by default. This fixes
747 projects.maemo.org bug NB#59258 .
749 2007-06-01 Murray Cumming <murrayc@murrayc.com>
751 * src/maemo/modest-account-view-window.c:
752 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
753 logical ID for the confirmation messages. Fixed projects.maemo.org bug
756 2007-06-01 Murray Cumming <murrayc@murrayc.com>
758 * src/maemo/easysetup/modest-easysetup-wizard.c:
759 (create_caption_new_with_asterisk):
760 * src/maemo/modest-account-settings-dialog.c:
761 (create_caption_new_with_asterisk):
762 Uncomment the code to add the asterisk, because they are no longer in the
763 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
764 (update_incoming_server_title): Add an asterisk here too.
766 2007-06-01 Murray Cumming <murrayc@murrayc.com>
768 * src/maemo/modest-maemo-global-settings-dialog.c:
769 (current_connection): Check that we are even connected before trying to
770 get the current connection name, to prevent a warning.
772 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
773 Change the comments because tny_maemo_conic_device_connect() is now meant to
775 * src/modest-mail-operation.c:
776 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
777 make sure we have a connection and fail if we can't connect.
779 2007-05-31 Murray Cumming <murrayc@murrayc.com>
781 * src/maemo/modest-main-window.c:
782 (on_account_store_connecting_finished): Do not try to get the
783 connection ID if we are not really connected. I am surprised that
784 this signal handler is called when we are not connected.
786 2007-05-31 Murray Cumming <murrayc@murrayc.com>
788 * src/modest-error.h:
789 * src/modest-ui-actions.c:
790 (modest_ui_actions_get_msgs_full_error_handler):
791 Renamed an enum, added comments, added an enum
792 for retrieve-limit errors.
794 * src/modest-mail-operation.c: (foreach_add_item),
795 (internal_folder_observer_update), (update_account_thread),
796 (modest_mail_operation_get_msgs_full):
797 (modest_mail_operation_update_account),
798 Added comments about how this works, and some code that should
799 (but does not) check the retrieve-limit. See the TODO comment.
801 2007-05-31 Murray Cumming <murrayc@murrayc.com>
803 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
804 Initialize help_id to fix the build. Warnings are good.
806 2007-05-31 Murray Cumming <murrayc@murrayc.com>
808 * src/widgets/modest-hbox-cell-renderer.c:
809 (modest_hbox_cell_renderer_append):
810 * src/widgets/modest-vbox-cell-renderer.c:
811 (modest_vbox_cell_renderer_append):
812 Fix the last commit by doing an extra ref.
814 2007-05-31 Murray Cumming <murrayc@murrayc.com>
816 * src/widgets/modest-hbox-cell-renderer.c:
817 (modest_hbox_cell_renderer_append):
818 * src/widgets/modest-vbox-cell-renderer.c:
819 (modest_vbox_cell_renderer_append):
820 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
821 to fix the build with Maemo Bora.
822 However, there seems to be a remaining crash, probably due to reference
825 2007-05-30 Murray Cumming <murrayc@murrayc.com>
827 * src/modest-tny-account.c:
828 (modest_tny_account_new_for_local_folders):
829 Use hildon_file_system_info_async_new() to get a better name for
830 the memory card account, setting it as the account name.
831 The timing seems to work, but this is probably
832 not the best place to do this. See the TODO comment.
833 * src/maemo/modest-main-window.c: (create_details_widget):
834 * src/widgets/modest-folder-view.c: (text_cell_data):
835 Use the tny account name instead of hardcoding a name.
837 2007-05-30 Christian Kellner <ckellner@openismus.com>
839 * src/modest-search.c: (modest_search):
840 Correctly set part_search_func even if we have already parsed
841 the query and thus a valid OgsTextSearcher object.
843 2007-05-30 Christian Kellner <ckellner@openismus.com>
846 Search and check for libogs.
849 Incooparte the ogs build env.
851 * src/modest-mime-part-search-stream.c:
852 * src/modest-mime-part-search-stream.h:
853 Removed since we do the real searching now in modest-search.c.
855 * src/modest-search.c:
856 * src/modest-search.h:
857 Implement support for ogs. We use that if available and requested
858 and fall back to modest_text_utils_utf8_strcmp (). The search logic
859 should now handle the corner case when the search term is spread
860 across multiple reads.
861 Also the logic in modest_search () was corrected to search all
862 requested fields until one is found.
864 2007-05-30 Murray Cumming <murrayc@murrayc.com>
866 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
869 * src/modest-init.c: Made modest_init_local_folders() take a
870 path and be public so we can iniitialize maildir folders on
873 * src/modest-local-folder-info.h:
874 * src/modest-local-folder-info.c:
875 (modest_local_folder_info_get_maildir_path): Add a path parameter.
877 * src/modest-tny-account.c:
878 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
879 still means the standard local-folders path on the local volume.
881 * src/modest-tny-account-store.c:
882 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
883 signal so we can detect mount/unmount of the MMC1 card, and do an update of
884 all accounts when that happens.
885 (get_server_accounts): If the MMC1 card is mounted, create a store account for
886 this too, so it shows up in the treeview.
888 2007-05-28 Murray Cumming <murrayc@murrayc.com>
890 * src/maemo/modest-maemo-global-settings-dialog.c:
891 (current_connection):
892 * src/widgets/modest-global-settings-dialog.c:
893 (current_connection_default):
894 Use the enum values instead of 0, 1 and -1,
895 to make the code clearer.
897 * src/modest-account-mgr-helpers.c:
898 (modest_account_mgr_get_connection_specific_smtp): Make this code
901 * src/modest-runtime.h:
902 * src/modest-runtime.c:
903 Added modest_runtime_remove_all_send_queues().
904 * src/maemo/modest-main-window.c:
905 (on_account_store_connecting_finished): Recreate the send queues,
906 using the appropriate transport accounts for this new connection.
907 Some futher adapting might be needed if the old send queues are not
908 automatically stopped at this point.
910 * src/modest-tny-account-store.c: (get_server_accounts):
911 Create the connection-specific transport accounts, so that they can
912 be found later by their ID.
914 * src/modest-tny-account.h:
915 * src/modest-tny-account.c:
916 Added modest_tny_account_new_from_server_account_name().
917 modest_tny_account_new_from_server_account(): Do not create the
918 send queues here, because they will be
919 recreated anyway when the connection changes for the first time.
921 2007-05-28 Murray Cumming <murrayc@murrayc.com>
923 * src/modest-local-folder-info.h:
924 * src/modest-local-folder-info.c:
925 (modest_per_account_local_outbox_folder_info_get_maildir_path),
926 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
927 tbox_folder): Take a modest account name instead of a server TnyAccount,
928 so we can have per-modest-account rather than per-transport-account
930 We must make sure that we change or recreate the exisitng send queues
931 when the connection changes for connection-specific transport accounts.
933 * src/modest-tny-account-store.c:
934 (create_per_account_local_outbox_folders): Create outboxed per modest
935 account, not per transport account.
937 * src/modest-tny-account.h:
938 * src/modest-tny-account.c:
939 (modest_tny_account_get_special_folder): For outboxes, get the
940 parent modest account name. The account is ignored for other folders.
941 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
942 modest account name rather than a server TnyAccount.
944 2007-05-25 Murray Cumming <murrayc@murrayc.com>
946 * src/modest-tny-account.c:
947 (modest_tny_account_new_from_server_account):
948 Call modest_runtime_get_send_queue() immediately after creating transport
949 accounts, so that they start trying to send email from the outbox as soon
950 as possible at startup. This is probably what we want.
952 * src/modest-mail-operation.c: (update_account_thread):
953 * src/modest-runtime.c: (modest_runtime_get_send_queue):
954 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
955 * src/modest-tny-send-queue.h:
956 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
957 (modest_ui_actions_on_send):
958 Added comments about how sending works, though it needs some more work.
960 2007-05-25 Murray Cumming <murrayc@murrayc.com>
962 * src/modest-tny-account.c:
963 (modest_tny_account_get_special_folder): Add TODO because this fails when
965 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
966 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
967 Do not try to show this window when there is no active account. The UI
968 specs does not tell us what to do in this case.
970 2007-05-24 Murray Cumming <murrayc@murrayc.com>
974 * src/maemo/Makefile.am:
975 * src/widgets/Makefile.am: Some dist fixes.
977 2007-05-24 Murray Cumming <murrayc@murrayc.com>
979 * src/maemo/modest-connection-specific-smtp-window.c:
980 (on_button_edit): Make the code clearer, to prevent a double free.
982 2007-05-24 Murray Cumming <murrayc@murrayc.com>
984 * src/maemo/modest-account-settings-dialog.c:
985 (modest_account_settings_dialog_set_account_name),
986 Check the connection-specific smtp servers checkbox if there are any.
988 * src/maemo/modest-connection-specific-smtp-edit-window.c:
989 (modest_connection_specific_smtp_edit_window_init):
990 Start with a suitable port number.
992 * src/modest-account-mgr-helpers.h:
993 * src/modest-account-mgr-helpers.c: Added
994 modest_account_mgr_get_has_connection_specific_smtp().
996 (modest_account_mgr_set_connection_specific_smtp),
997 (modest_account_mgr_remove_connection_specific_smtp),
998 (modest_account_mgr_get_has_connection_specific_smtp),
999 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1000 connection-specific smtp server accounts in the account, rather than
1001 the server account conf dir.
1003 This fixes bug projects.maemo.org bug NB#58263 .
1005 * src/modest-tny-account-store.c:
1006 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1007 if there are no server accounts yet, to prevent an infinite loop when there
1008 are no accounts. Document that one must be called before the other.
1010 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1012 * src/modest-account-mgr-helpers.c:
1013 (modest_account_mgr_get_default_account): Make sure that at least
1014 one account is always the default, if there are any enabled accounts.
1015 This is just a sanity check that shouldn't be necessary.
1017 * src/modest-account-mgr-priv.c:
1018 (_modest_account_mgr_account_from_key): Unescape the conf key to
1019 get the real account name. For instance, this is an issue if a space
1020 was in the account name, which can happen because the account name
1021 is generated from the display name.
1022 (_modest_account_mgr_get_account_keyname): Always escape the
1024 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1025 Unescape the conf keys to get the real account names.
1027 For instance, previously the is-default radio button in the accounts
1028 list was not checked for any accounts at first. This fixes that,
1029 and might fix several similar bugs.
1031 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1033 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1034 Removed some debug printfs.
1036 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1038 Modest on-disk outbox directories are now here, for instance:
1039 $HOME/.modest/outboxes/<account-id-1>/outbox
1040 $HOME/.modest/outboxes/<account-id-2>/outbox
1042 $HOME/.modest/local-folders/outbox
1043 so we can have a separate outbox for each account.
1044 But they are shown as one outbox in the GtkTreeView, by using a
1045 TnyMergeFolder in a ModestTnySimpleFolderStore.
1048 * src/modest-tny-simple-folder-store.c:
1049 * src/modest-tny-simple-folder-store.h:
1050 Added ModestTnySimpleFolderStore, used to contain folders from
1051 other folder stores, such as other accounts.
1053 * src/modest-tny-outbox-account.h:
1054 * src/modest-tny-outbox-account.c:
1055 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1056 used for the per-account local outbox folders.
1058 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1059 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1060 only use this (internally) now for the non-outbox local folders.
1062 * src/modest-init.h:
1063 * src/modest-init.c: Added modest_init_one_local_folder(), for
1064 setting up the directory structure for each local folder.
1066 * src/modest-local-folder-info.c:
1067 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1068 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1070 * src/modest-local-folder-info.h:
1071 * src/modest-tny-account-store.c: (on_account_removed),
1072 (on_account_changed), (create_per_account_local_outbox_folders),
1073 (get_server_accounts), (modest_tny_account_store_get_accounts),
1074 (modest_tny_account_store_get_tny_account_by_account),
1075 (modest_tny_folder_store_is_virtual_local_folders):
1077 * src/modest-tny-account.h:
1078 * src/modest-tny-account.c:
1079 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1080 to create an on-disk per-account local outbox folder for each
1082 (create_per_account_local_outbox_folders): Create a local outbox folder
1083 for each transport account.
1084 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1085 for all local folders.
1087 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1088 instead of using g_object_get/set() directly. It is clearer.
1090 (modest_tny_folder_store_get_message_count),
1091 (modest_tny_folder_store_get_local_size
1092 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1093 because we now use these with non-acount folder stores.
1095 (modest_tny_account_get_special_folder),
1096 (modest_tny_account_new_from_server_account),
1097 (modest_tny_account_new_from_account):
1098 (recurse_folders): Adjust to the new outbox system.
1100 * src/modest-tny-folder.h:
1101 * src/modest-tny-folder.c:
1102 (modest_tny_folder_is_local_folder),
1103 (modest_tny_folder_get_local_folder_type),
1104 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1106 * src/widgets/modest-main-window.h:
1107 * src/maemo/modest-main-window.c: (create_details_widget),
1108 (modest_main_window_set_contents_style): Show details for any folder store,
1111 (modest_tny_folder_get_rules):
1112 Remove the const. C does not support constness enough for this.
1114 * src/modest-ui-actions.c:
1115 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1116 make all outboxes appear as one, in the usual local-folders tree node.
1118 (set_active_account_from_tny_account),
1119 (modest_ui_actions_on_folder_selection_changed):
1120 * src/widgets/modest-folder-view.c: (text_cell_data),
1121 (icon_cell_data), (filter_row),
1122 (add_account_folders_to_merged_folder),
1123 (add_account_folders_to_simple_folder_store), (),
1124 (get_cmp_rows_type_pos), (cmp_rows),
1125 (modest_folder_view_set_account_id_of_visible_server_account):
1126 Adjust to the new outbox system, using generic folder stores and folders
1127 in the GtkTreeModel.
1129 2007-05-23 Christian Kellner <ckellner@openismus.com>
1131 * src/modest-mail-operation.c:
1132 (modest_mail_operation_update_account):
1133 Use info->max_size instead of unintialized local var [small
1134 build fix]. (Added TODO to review that change since I don't
1137 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1139 * libmodest-dbus-client/libmodest-dbus-client.c:
1140 (libmodest_dbus_client_compose_mail): function added
1141 * src/dbus_api/modest-dbus-api.h:
1142 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1143 (on_compose_mail): Implementation of the SendAsMail functionality
1145 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1147 * src/modest-account-mgr.c:
1148 (modest_account_mgr_add_server_account): Set the secure-connection
1149 conf key for transport accounts as well as store accounts. I don't know
1150 why the if was there. For instance, this makes sure that we use SSL
1151 for the gmail preset from the easysetup wizard.
1153 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1155 * src/gnome/modest-main-window.c:
1156 (on_account_store_connecting_finished), (connect_signals):
1157 * src/maemo/modest-main-window.c:
1158 (on_account_store_connecting_finished), (connect_signals),
1159 (modest_main_window_new):
1160 Handle TnyAccountStore::connecting-finished instead of
1161 TnyDevice::connection-changed, because we cannot actually perform
1162 operations on accounts until TnyAccountStore has itself responded to
1163 the TnyDevice::connection-changed signal. This prevents a GError from
1165 Do not try to update at startup, because we (at least on scratchbox)
1166 already do an update at startup when the device goes online.
1167 This prevents a GError from tinymail.
1168 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1169 Added TODO about stopping simultaneous operations.
1171 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1173 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1174 * src/modest-mail-operation-queue.c:
1175 (modest_mail_operation_queue_remove):
1176 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1177 about where they happened.
1179 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1181 * src/modest-ui-actions.c:
1182 (modest_ui_actions_on_password_requested): Make sure that the remember
1183 output parameter is always TRUE.
1185 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1187 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1188 Show a OK/Cancel dialog if the error is a question, though we still do not
1189 know anything more about what we are asking the user.
1190 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1191 Fix an uninitialized variable (helper). This is a logic error, however.
1193 2007-05-21 Christian Kellner <ckellner@openismus.com>
1195 * src/modest-search.h:
1196 Correct bit shifting in the ModestSearchFlags enum.
1198 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1200 * src/modest-tny-account.c:
1201 (modest_tny_account_new_from_server_account): Do not use the lsub and
1202 check-all hard-coded IMAP options when using POP.
1204 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1206 * src/modest-tny-account.c:
1207 (modest_tny_account_new_from_server_account):
1208 Use NULL for the secure-auth method for POP when Password auth has been
1209 specified by the user, as we already do for IMAP. "auth=Login" causes
1210 an error from camel or the server.
1212 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1214 * src/maemo/modest-account-settings-dialog.c:
1215 (create_page_account_details),
1216 (modest_account_settings_dialog_set_account_name):
1217 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1218 for the leave-on-server checkbox, rathr than just the checkbox, when
1219 the protocol is not POP.
1221 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1223 * src/widgets/modest-account-view.c:
1224 * src/widgets/modest-account-view.h:
1225 Added modest_account_view_select_account() which will be useful later
1226 to asynchronously re-select the edited account.
1228 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1230 * src/maemo/modest-account-settings-dialog.c:
1231 (modest_account_settings_dialog_set_account_name):
1232 Automatically choose the port numbers based on the secure authentication
1233 methods, if they have not been chosen before.
1234 This fixes projects.maemo.org bug NB#56273 .
1236 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1238 * src/maemo/modest-main-window-ui.h:
1239 * src/modest-ui-actions.c:
1240 * src/modest-ui-actions.h:
1241 Connect the Tools/SMTP Servers menu item to
1242 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1243 SMTP servers dialog, as in the UI specification and saves changes when it
1244 is closed. This fixed projects.maemo.org bug NB#56305 .
1246 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1248 * src/maemo/modest-connection-specific-smtp-window.c:
1249 (modest_connection_specific_smtp_window_init):
1250 Use gtk_window_set_default_size() to make this window big enough, so
1251 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1253 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1255 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1256 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1257 (modest_connection_specific_smtp_edit_window_init),
1258 Do not try to connect to a combobox signal before the combobox exists.
1259 This fixes the cras in projects.maemo.org bug NB#56288 .
1260 (modest_connection_specific_smtp_edit_window_get_settings):
1261 Remove the server_account_name parameter which was being checked for NULL
1262 though it was not used.
1264 * src/maemo/modest-connection-specific-smtp-window.c:
1265 (modest_connection_specific_smtp_window_fill_with_connections),
1266 (on_button_edit), (modest_connection_specific_smtp_window_init):
1267 Correct the number of treemodel columns to prevent a warning.
1268 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1269 libconic does not work.
1271 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1273 * src/modest-tny-account.c:
1274 (modest_tny_account_new_from_server_account):
1275 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1276 SMTP when "None" was chosen by the user. However, with my SMTP server that
1277 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1280 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1282 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1283 to explain the memory management issue with the ID in the ModestPair.
1285 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1286 (add_sending_page), (modest_account_assistant_finalize):
1287 * src/gnome/modest-gnome-global-settings-dialog.c:
1288 (create_updating_page), (create_composing_page):
1289 * src/gnome/modest-msg-edit-window.c: (get_transports),
1290 (init_window), (modest_msg_edit_window_finalize),
1291 (modest_msg_edit_window_get_msg_data):
1292 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1293 * src/gnome/modest-transport-widget.c:
1294 (modest_transport_widget_finalize), (smtp_configuration):
1295 * src/maemo/modest-maemo-global-settings-dialog.c:
1296 (create_updating_page), (create_composing_page):
1297 * src/maemo/modest-msg-edit-window.c: (get_transports),
1298 (init_window), (modest_msg_edit_window_finalize),
1299 (modest_msg_edit_window_get_msg_data),
1300 (modest_msg_edit_window_free_msg_data):
1301 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1302 (modest_store_widget_finalize):
1303 * src/maemo/modest-transport-widget.c:
1304 (modest_transport_widget_finalize), (smtp_configuration):
1305 * src/modest-main.c: (send_mail):
1306 * src/widgets/modest-combo-box.h:
1307 * src/widgets/modest-global-settings-dialog-priv.h:
1308 * src/widgets/modest-global-settings-dialog.c:
1309 (modest_global_settings_dialog_finalize):
1310 * src/widgets/modest-msg-edit-window.h:
1311 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1312 as long as the combo box, to prevent use of freed memory for the ID.
1314 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1316 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1317 get_accounts(), to make this clearer. Do not check for the enabled gconf
1318 key, because we do not use this for server accounts (at least, not yet).
1319 This allows us to send email again.
1321 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1323 * src/maemo/modest-platform.c:
1324 (on_modest_conf_update_interval_changed), (modest_platform_init):
1325 Only respond to this particular key change. All these strcmp()s cannot be
1328 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1330 * src/maemo/modest-maemo-global-settings-dialog.c:
1331 (current_connection): Prevent a crash in scratchbox when
1332 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1333 * src/maemo/modest-platform.c:
1334 (on_modest_conf_update_interval_changed), (modest_platform_init):
1335 Get the update interval from gconf and reset it when the gconf key changes.
1337 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1339 * src/modest-protocol-info.c:
1340 * src/modest-protocol-info.h: Adde enum-specific get functions,
1341 instead of using a ModestProtocolType enum parameter.
1343 * src/gnome/modest-account-assistant.c:
1344 * src/gnome/modest-store-widget.c:
1345 * src/gnome/modest-store-widget.h:
1346 * src/gnome/modest-transport-widget.c:
1347 * src/gnome/modest-transport-widget.h:
1348 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1349 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1350 * src/maemo/easysetup/modest-easysetup-wizard.c:
1351 * src/maemo/modest-account-settings-dialog.c:
1352 * src/maemo/modest-account-settings-dialog.h:
1353 * src/maemo/modest-store-widget.c:
1354 * src/maemo/modest-store-widget.h:
1355 * src/maemo/modest-transport-widget.c:
1356 * src/maemo/modest-transport-widget.h:
1357 * src/modest-account-mgr-helpers.c:
1358 * src/modest-account-mgr-helpers.h:
1359 * src/modest-account-mgr.c:
1360 * src/modest-account-mgr.h:
1361 * src/modest-tny-account.c:
1362 * src/modest-tny-folder.c:
1363 * src/widgets/modest-account-view.c:
1364 * src/widgets/modest-retrieve-combo-box.c:
1365 * src/widgets/modest-retrieve-combo-box.h:
1366 * src/widgets/modest-secureauth-combo-box.c:
1367 * src/widgets/modest-serversecurity-combo-box.c:
1368 * src/widgets/modest-serversecurity-combo-box.h:
1369 * tests/check_account-mgr.c:
1370 Use the specific functions, and use the re-renamed enum values for GNOME too.
1372 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1374 * src/modest-pair.h:
1375 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1376 so we can get the second based on the first.
1378 * src/maemo/modest-account-settings-dialog.h:
1379 * src/maemo/modest-account-settings-dialog.c:
1380 Added get_supported_secure_authentication_methods(), though it is mostly
1381 commented-out for now until the necessary API is committed to tinymail.
1382 (modest_account_settings_dialog_set_account_name),
1383 (save_configuration): Request the supported authentication methods from the
1384 server, so we can choose a working method.
1386 * src/modest-tny-account-store.h:
1387 * src/modest-tny-account-store.c:
1388 (modest_tny_account_store_get_session): Rename from
1389 tny_account_store_get_session().
1391 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1393 * src/modest-protocol-info.h: Split the ModestProtocol enum
1394 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1395 There was no need to have these unrelated values in one enum.
1397 * src/: many files: Adapted to changed enum. This makes the code a bit
1398 clearer, and the compiler could catch some errors.
1400 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1402 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1403 Show the detailed internal camel error message when an error happens
1404 during the configuration, so that our testers can give us more clues.
1405 For instance, in projects.maemo.org bug NB#56910 .
1407 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1409 * src/modest-tny-account.c:
1410 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1411 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1413 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1415 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1416 * src/maemo/modest-account-settings-dialog.c:
1417 (modest_account_settings_dialog_set_account_name),
1418 (save_configuration): For the incoming secure authentication checkbox,
1419 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1420 the UI specification. PLAIN does not seem to be supported for most IMAP
1421 servers anyway, and I am not sure what it would mean.
1422 However, we probably need to discover which of the secure-authentication
1423 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1424 * src/modest-account-mgr-helpers.c:
1425 (modest_account_mgr_get_server_account_data):
1427 * src/modest-tny-account.c:
1428 (modest_tny_account_new_from_server_account):
1429 Use tny_account_set_mech() to set secure-authentication methods,
1430 with some special-casing for IMAP, based on my observations of how
1433 * src/modest-account-mgr-helpers.h:
1434 * src/modest-account-mgr.c:
1435 * src/modest-defs.h: Comment that the URI is only used for local folders.
1437 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1439 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1440 parameter const, just to be neat.
1441 * src/modest-text-utils.c: (modest_text_utils_inline):
1442 End g_strconcat() with NULL, as its documentation says. This is almost
1443 certainly the cause of my crash at startup on the device. Interestingly,
1444 valgrind doesn't tell us about these errors.
1446 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1448 * scripts/build-packages: Added more precise comments about how to use
1449 this script, though I still get this error:
1450 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1451 error building tinymail
1453 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1455 * src/maemo/modest-main-window.c: (on_account_update):
1456 Very slight cleanup, hoping to make it simpler to discover what causes
1457 a crash here sometimes.
1459 * src/modest-tny-account.c:
1460 (modest_tny_account_new_from_server_account): Set the port. Added
1461 comments about the options and a TODO comment because I need to find out
1462 how to specify the secure authentication method.
1464 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1466 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1467 changed CFlags paths form modest to libmodest
1469 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1471 * src/modest-account-mgr-helpers.c:
1472 (modest_account_mgr_get_server_account_data),
1473 (modest_account_mgr_free_server_account_data):
1474 * src/modest-account-mgr-helpers.h:
1475 * src/modest-account-mgr.c:
1476 (modest_account_mgr_add_server_account):
1477 * src/modest-defs.h:
1478 * src/modest-tny-account.c:
1479 (modest_tny_account_new_from_server_account):
1480 Determine the options for tny_camel_account_add_option() here,
1481 based on the settings, rather than storing them directly in gconf.
1483 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1485 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1486 Show a more friendly error dialog now that we expect (from the tinymail
1487 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1489 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1491 * src/maemo/modest-main-window.c: (on_account_update): Check that
1492 account_name is not NULL, to prevent a crash at startup that I am
1493 seeing on the N800. I do wonder why it is NULL.
1495 * src/maemo/easysetup/modest-easysetup-wizard.c:
1496 (create_page_user_details):
1497 * src/maemo/modest-account-settings-dialog.c:
1498 (create_page_user_details), (create_page_outgoing):
1499 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1500 (modest_connection_specific_smtp_edit_window_init):
1501 * src/modest-ui-actions.c:
1502 (modest_ui_actions_on_password_requested):
1503 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1504 might do something useful with the on-screen keyboard.
1506 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1508 * src/maemo/modest-main-window.c: (on_account_update):
1509 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1510 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1512 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1514 * src/modest-tny-account-store.c: (on_account_changed):
1515 Correct the signature of this signal handler.
1517 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1519 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1520 Show a HildonNote instead of a GtkDialog for Maemo.
1522 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1524 * src/widgets/modest-account-view.h:
1525 * src/widgets/modest-account-view.c: (on_account_changed),
1526 (on_account_removed). Added a boolean flag, set/unset by
1527 modest_account_view_block_conf_updates(),
1528 modest_account_view_unblock_conf_updates() to prevent unnecessary
1529 updates, but this is not very useful because the gconf notifications are
1530 so delays (maybe only on Maemo Bora).
1531 So auto-updating is turned off, and these functions do an explicit
1532 update when necessary.
1533 However, something else is still doing too much work when adding/removing
1534 accounts, probably in another part of the application.
1536 * src/maemo/modest-account-view-window.c:
1537 (on_delete_button_clicked), (on_edit_button_clicked),
1538 (on_new_button_clicked): Use the new functions.
1540 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1542 * src/modest-account-mgr-helpers.c:
1543 (modest_account_mgr_set_first_account_as_default):
1544 Sort the list of names alphabetically-by-title, so we choose the first one
1546 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1547 alphabetically by the title.
1549 This fixes projects.maemo.org bug NB#56418 .
1551 * src/modest-account-mgr-priv.c:
1552 (_modest_account_mgr_account_from_key):
1553 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1554 avoid a valgrind error, and possible random behaviour.
1556 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1558 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1559 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1560 tinymail documentation to say that this can be expected.
1561 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1562 pretty, and should not happen, but I would prefer to know when it does.
1564 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1566 * configure.ac: When using the older hildon version, probably on Bora,
1567 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1569 * src/widgets/modest-attachment-view.c:
1570 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1573 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1575 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1576 Implemented the prototype. Can be tested with
1577 tests/dbus_api/test_open_message:
1579 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1581 * src/modest-tny-account-store.c:
1582 (modest_tny_account_store_instance_init), (get_password):
1583 * src/modest-ui-actions.c:
1584 (modest_ui_actions_on_password_requested):
1585 Do not store the password in gconf, because this function is called
1586 for non-remembered passwords. Actually use the cached (in the hash map)
1587 password instead of releasing it.
1588 The password will now not be remembered if it is asked via the protected
1589 password dialog, as per the UI spec.
1591 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1593 * src/modest-defs.h:
1594 * src/modest-account-mgr-helpers.h:
1595 * src/modest-account-mgr-helpers.c:
1596 Added modest_server_account_get_username_has_succeeded(),
1597 modest_server_account_set_username_has_succeeded().
1598 (modest_server_account_set_username),
1599 Reset the has-succeeded flag if the username changes.
1601 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1602 * src/maemo/modest-connection-specific-smtp-window.c:
1603 (modest_connection_specific_smtp_window_save_server_accounts):
1604 Use modest_server_account_set_username() instead of using
1605 modest_conf_set_string() directly, so that the has-succeeded flag is always
1608 * src/modest-ui-actions.c:
1609 (modest_ui_actions_on_password_requested): Dim the username entry if
1610 the username has ever worked, as per the UI spec.
1612 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1614 * src/modest-tny-account-store.c: (get_password):
1615 * src/modest-ui-actions.c:
1616 (modest_ui_actions_on_password_requested):
1617 Allow the username to be changed too, though there is more work to
1618 be done on exactly how this behaves.
1620 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1622 * src/modest-account-mgr-helpers.h:
1623 * src/modest-account-mgr-helpers.c:
1624 Added modest_account_mgr_get_display_name(),
1625 modest_server_account_get_username(),
1626 modest_server_account_set_username(),
1627 modest_server_account_set_password(),
1628 modest_server_account_get_hostname() functions so we do not need to
1629 use the conf API directly.
1631 * src/maemo/modest-main-window.c: (connect_signals):
1632 Actually connect ot the ModestAccountStore::request-password signal,
1633 so that we show the dialog when the password is requested by Tinymail,
1634 for isntance if it is empty.
1636 * src/modest-marshal.list:
1637 * src/modest-tny-account-store.c:
1638 (modest_tny_account_store_class_init), (get_password),
1639 (modest_tny_account_store_alert):
1640 * src/modest-tny-account-store.h:
1641 * src/modest-ui-actions.h:
1642 * src/modest-ui-actions.c:
1643 (modest_ui_actions_on_password_requested):
1644 Change the signal parameters, so it is obvious that we are providing
1645 the non human-readable server name, and receiving both the username
1646 and password, though changing of the username is not yet implemented.
1647 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1648 for the GNOME version.
1650 This should fix the projects.maemo.org bug NB#56209, though it does not
1651 work on Bora, because the gconf_client_get() for the password fails
1652 immediately after we save it with gconf_client_set().
1654 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1657 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1658 caused an undefined symbol error:
1659 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1661 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1663 * src/modest-tny-account-store.c:
1664 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1665 using a GError instead of a string message, so we can translate it in
1668 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1670 * src/maemo/modest-address-book.c:
1671 (modest_address_book_check_names):
1672 * src/maemo/modest-msg-view-window.c:
1673 (modest_msg_view_window_clipboard_owner_change):
1674 * src/modest-init.c: (modest_init_init_ui):
1675 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1676 (update_folders_cb), (modest_mail_operation_update_account):
1677 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1678 (modest_ui_actions_on_msg_attachment_clicked),
1679 (modest_ui_actions_on_msg_recpt_activated):
1680 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1681 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1682 (modest_msg_view_search_next):
1683 * src/widgets/modest-recpt-editor.c:
1684 (modest_recpt_editor_on_button_release_event),
1685 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1686 g_message(). At this point we should only be seeing interesting errors on
1687 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1689 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1691 (modest_wizard_dialog_force_title_update):
1692 * src/maemo/easysetup/modest-wizard-dialog.h:
1693 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1694 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1695 can update the title when appropriate. Otherwise the title is wrong if the
1696 pages are added after adding the notebook to the dialog.
1697 This must be a problem in HildonWizardDialog too.
1698 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1700 * src/maemo/easysetup/modest-easysetup-wizard.c:
1701 (create_subsequent_customsetup_pages),
1702 (create_subsequent_easysetup_pages):
1703 Call modest_wizard_dialog_force_title_update() so that the title is
1704 correct even with GTK+ < 2.10.
1705 This fixes projects.maemo.org bug NB#56145 .
1707 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1709 * src/maemo/modest-platform.c:
1710 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1711 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1714 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1716 * src/widgets/modest-window.h:
1717 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1718 and modest_window_save_state(), which invokes it.
1720 * src/widgets/modest-window-mgr.h:
1721 * src/widgets/modest-window-mgr.c:
1722 Added modest_window_mgr_save_state_for_all_windows(), which calls
1723 the save_state vfunc on all registered windows, if implemented.
1725 * src/gnome/modest-msg-edit-window.c:
1726 * src/gnome/modest-msg-view-window.c:
1727 * src/maemo/modest-msg-edit-window.c:
1728 * src/maemo/modest-msg-view-window.c:
1729 * src/maemo/modest-main-window.c:
1730 Specify the existing save_settings functions as implementations of
1731 ModestWindow::save_state_func().
1733 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1734 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1735 enabling hibernation, for instance.
1737 We may need to do the same thing for restoring settings.
1740 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1742 * src/widgets/modest-window-mgr.c:
1743 * src/widgets/modest-window-mgr.h:
1744 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1745 modest_window_mgr_get_hibernation_is_prevented().
1747 * src/maemo/modest-main-window.c:
1748 (on_hildon_program_is_topmost_notify): Prevent hibernation
1749 (possible when the application goes to the background in the WM),
1750 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1752 * src/maemo/easysetup/modest-easysetup-wizard.c:
1753 (modest_easysetup_wizard_dialog_init):
1754 * src/maemo/modest-account-settings-dialog.c:
1755 (modest_account_settings_dialog_init):
1756 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1757 (modest_connection_specific_smtp_edit_window_init):
1758 * src/maemo/modest-connection-specific-smtp-window.c:
1759 (modest_connection_specific_smtp_window_init):
1760 * src/maemo/modest-signature-editor-dialog.c:
1761 (modest_signature_editor_dialog_init):
1762 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1763 prevent hibernation while any of these account settings dialogs are open.
1765 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1767 * src/maemo/Makefile.am:
1768 * src/maemo/modest-osso-state-saving.c:
1769 * src/maemo/modest-osso-state-saving.h: Added
1770 modest_osso_load_state() and modest_osso_save_state() though they do
1771 nothing now. They should iterate through all the open windows and load/save
1773 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1774 save state when closing.
1776 * src/maemo/modest-main-window.c:
1777 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1778 Add a notification handler for the HildonProgram::is-topmost property,
1779 so we can allow hibernation when the application goes into the background.
1780 But we still need to detect when the accounts setup windows are open so
1781 we can stop hibernation when they are open.
1782 To do this, I also added the main window the HildonProgram. This might have
1783 other side-effects/benefits, and should maybe be done for other windows.
1785 * src/maemo/modest-osso-autosave-callbacks.h:
1786 * src/maemo/modest-osso-autosave-callbacks.c:
1787 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1788 though it does not do anything yet, and we might never need this to do
1789 anything. For instance, we already save drafts.
1791 * src/maemo/modest-platform.c: (modest_platform_init):
1792 Specify the libosso auto-save callback.
1794 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1796 * src/maemo/modest-platform.c:
1797 (modest_platform_set_update_interval):
1798 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1799 aparently stays valid between application instances, so we can use this
1800 to remove and reset it later. According to a maemo-developers email from
1803 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1805 * configure.ac: Depend on libalarm for Maemo.
1807 * src/dbus_api/modest-dbus-api.h:
1808 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1809 (on_send_receive), (modest_dbus_req_handler):
1810 Handle a SEND_RECEIVE D-Bus method.
1812 * libmodest-dbus-client/libmodest-dbus-client.c:
1813 (libmodest_dbus_client_send_and_receive):
1814 * libmodest-dbus-client/libmodest-dbus-client.h:
1815 Add C convenience functions for calling the new D-Bus method.
1817 * src/modest-platform.h:
1818 * src/gnome/modest-platform.c:
1819 * src/maemo/modest-platform.c:
1820 Added modest_platform_set_update_interval(), which uses the
1821 alarmd API on Maemo.
1822 (modest_platform_init),
1823 Call modest_platform_set_update_interval(), using a hard-coded
1824 interval for now (until the global settings dialog is implemented),
1825 though I am not sure that this makes sense yet.
1827 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1829 * src/dbus_api/modest-dbus-callbacks.c:
1830 (modest_osso_cb_hw_state_handler):
1831 * src/dbus_api/modest-dbus-callbacks.h:
1832 * src/maemo/modest-platform.c: (modest_platform_init):
1833 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1834 in case this has some effect on the ability for Maemo to ping the
1837 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1839 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1840 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1841 warning. It is probably a logic error, but I need to fix the build.
1843 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1845 * src/modest-account-mgr.h:
1846 * src/modest-account-mgr.c:
1847 (modest_account_mgr_account_names): Add a gboolean enabled_only
1848 parameter, so we can get lists of onlt the enabled accounts.
1850 (modest_account_mgr_add_account),,
1851 (modest_account_mgr_account_with_display_name_exists):
1852 * src/maemo/modest-msg-edit-window.c: (get_transports):
1853 * src/modest-account-mgr-helpers.c:
1854 (modest_account_mgr_set_first_account_as_default):
1855 * src/modest-init.c: (init_default_account_maybe):
1856 * src/modest-tny-account-store.c: (get_accounts):
1857 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1858 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1859 * tests/check_account-mgr.c: (START_TEST):
1860 Provide the extra parameter, as appropriate.
1862 * src/widgets/modest-account-view.c: (update_account_view):
1863 Do not show disabled accounts (meaning that there is no way to
1864 enable/disable accounts in the UI (the feature is not in our UI
1865 specification), so we can use this internally only to mark unfinished
1866 or temporary account data.
1868 * src/maemo/easysetup/modest-easysetup-wizard.c:
1869 (create_account): Add boolean enable parameter, so we can specify FALSE
1870 to create the temporary account.
1871 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1872 (on_before_next): When finishing, when there is a temporary account, just
1874 Also, use a timeout to delay the showing of the dialog until gconf is likely
1875 to return correct information, due to a maemo gconf bug that is fixed in
1876 osso 1.1, but not yet in Bora.
1877 However, the dialog stays on screen after it is destroyed.
1879 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1880 for invalid data when cancelling. Use a hildon note instead of a dialog
1881 to complain about invalid data. Do not show the account-saved note if the
1882 account is disabled (a temporary account that will not really be saved for use
1885 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1887 * src/modest-account-mgr-helpers.h:
1888 * src/modest-account-mgr-helpers.c:
1889 Added modest_account_mgr_unset_default_account(),
1890 Added modest_account_mgr_set_first_account_as_default().
1892 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1893 If it was the default account, unset the default account name.
1895 * src/maemo/modest-account-view-window.c:
1896 (on_delete_button_clicked): If it was the default account,
1897 set the first remaining account as the default instead.
1899 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1900 a NULL account or a NULL default account, to prevent a crash. This should
1901 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1904 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1906 * src/widgets/modest-recpt-editor.c:
1907 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1908 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1909 TODO comment for this. This fixes the build.
1911 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1912 be the best place for it. This will in future update all auto-update accounts,
1913 rather than just the current/default account, when that gconf key exists.
1914 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1915 if there are no accounts, before calling do_send_receive().
1916 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1918 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1919 * src/maemo/modest-main-window-ui.h:
1920 * src/maemo/modest-main-window.c: (on_connection_changed),
1921 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1922 directly, becaue the signal handler does more.
1924 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1926 * src/modest-account-mgr-helpers.c:
1927 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1928 for the case that the account does not exist.
1930 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1931 (equivalent to the modest account name) rather than the tinymail account name
1932 (equivalent to the modest account title - human readable) to get the account data.
1933 Check for null account data to prevent the crash, and add a TODO comment saying that
1934 this needs fixing because it is using the server account name instead of the account name.
1936 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1938 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1939 * src/maemo/modest-account-settings-dialog.c: (show_error),
1941 Use hildon_note_new_information() for informative and error messages,
1942 which seems to be expected for Maemo applications (no documentation that I know of
1943 says this). I am surprised that there is no distinction between info and error
1946 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1948 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1949 it is easy to find where this is used.
1951 * src/maemo/easysetup/modest-easysetup-wizard.c:
1952 (create_page_welcome), (create_page_account_details),
1953 (create_page_user_details), (create_page_complete_easysetup),
1954 (create_page_custom_incoming), (create_page_custom_outgoing),
1955 (create_page_complete_custom):
1956 * src/maemo/modest-account-settings-dialog.c:
1957 (create_page_account_details), (create_page_user_details),
1958 (create_page_incoming), (create_page_outgoing):
1959 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1960 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1961 (modest_connection_specific_smtp_edit_window_init):
1962 * src/maemo/modest-connection-specific-smtp-window.c:
1963 (modest_connection_specific_smtp_window_init):
1964 * src/maemo/modest-signature-editor-dialog.c:
1965 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1966 and scrolling policy as per the Email Application Layout Guide, if I have
1969 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1971 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1972 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1973 which were empty, because these vfuncs have been removed from TnyAccountStore.
1974 This fixes the build.
1976 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1978 * src/maemo/modest-main-window.c:
1979 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1980 showing/hiding it. Added TODO because it probably should not be NULL.
1981 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1982 because unnecessary g_warnings() make degugging difficult.
1984 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1986 * src/maemo/modest-msg-edit-window.c:
1987 (modest_msg_edit_window_select_color),
1988 (modest_msg_edit_window_select_background_color): 2 const corrections and
1989 moving 2 #endifs before closing brackets, to fix the build.
1991 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1993 * src/maemo/easysetup/modest-easysetup-wizard.h:
1994 * src/maemo/easysetup/modest-easysetup-wizard.c:
1995 (modest_easysetup_wizard_dialog_finalize),
1996 (on_button_edit_advanced_settings), (create_page_complete_custom),
1997 (on_response), (create_account):
1998 Implement the Advanced Settings edit button, by saving the account information,
1999 for the Advanded Settings dialog to use directly from gconf, and removing it
2000 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2001 Bug #5533 in the projects.maemo.org bugzilla.
2003 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2005 * src/maemo/modest-msg-view-window.c:
2006 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2007 when opening a message window.
2009 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2011 * src/maemo/easysetup/modest-easysetup-wizard.c:
2012 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2015 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2016 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2017 gconf settings. I probably added more checks than necessary, but that is safer.
2019 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2020 variable to fix the build, but this seems to be used when it is still NULL.
2022 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2024 * src/modest-platform.h:
2025 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2026 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2027 * src/modest-main.c: Implement this function so we can avoid using
2028 maemo-specific API from cross-platform code.
2030 * src/modest-tny-account-store.c:
2031 (get_smtp_specific_transport_account_for_open_connection):
2032 * src/modest-ui-actions.c: (check_for_connection),
2033 (modest_ui_actions_on_item_not_found):
2034 Use modest_platform_connect_and_wait() and put #idefs around other
2035 maemo-specific code, because only maemo currently has a way to
2036 identify connection names.
2038 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2040 * src/modest-tny-account-store.h:
2041 * src/modest-tny-account-store.c:
2042 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2043 the connection-specific SMTP server settings in the configuration.
2045 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2047 * src/maemo/modest-main-window.c: (on_connection_changed),
2049 * src/modest-main.c: (main), (start_ui), (send_mail):
2050 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2051 that is what is intended.
2053 * src/modest-ui-actions.c: (action_send), (action_receive),
2054 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2055 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2056 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2057 SMTP server is used when it is specified.
2059 (modest_ui_actions_on_send_receive):
2060 Check that a connection is open before proceeding.
2061 Receive and then send, instead of vice-versa, as per the specification.
2063 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2065 * src/modest-mail-operation.c:
2066 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2067 though I guess it should be something other than NULL.
2069 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2071 * src/maemo/easysetup/modest-easysetup-wizard.c:
2072 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2073 combo twice, to avoid an g_warning and to make it visible again.
2074 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2075 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2076 (already intended) dereference when detaching, because we then recreate the menu.
2077 But I am not sure why the warning was happening, and it is possible that this is a memory
2080 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2082 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2083 and uri_parse_mailto() utility functions.
2084 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2086 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2088 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2090 * src/dbus_api/modest-dbus-api.h:
2091 * src/dbus_api/modest-dbus-callbacks.c:
2092 Use an idle callback to execute the modest code in the application's own thread.
2093 Remove the helloworld example method.
2094 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2095 parsed, and the open-message method is not implemented because this is not yet implemented in
2097 * libmodest-dbus-client/libmodest-dbus-client.c:
2098 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2099 (libmodest_dbus_client_open_message):
2100 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2102 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2103 body without crashing.
2105 * tests/dbus_api/Makefile.am:
2106 * tests/dbus_api/test_mail_to.c:
2107 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2109 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2111 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2112 Added file to fix the build. Sorry.
2114 * src/dbus_api/Makefile.am:
2115 * src/dbus_api/modest-dbus-api.h:
2116 * src/dbus_api/modest-dbus-callbacks.h:
2117 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2118 (modest_dbus_req_handler):
2119 Put constants in a separate header so it can be reused by the
2120 client library, without duplication
2122 * libmodest-dbus-client/Makefile.am:
2123 * libmodest-dbus-client/libmodest-dbus-client.c:
2124 (libmodest_dbus_client_call_helloworld),
2125 (libmodfest_dbus_client_send_mail),
2126 (libmodfest_dbus_client_mailto),
2127 (libmodfest_dbus_client_open_message):
2128 * libmodest-dbus-client/libmodest-dbus-client.h:
2129 (Partly) Implement a send_mail D-Bus method.
2131 * tests/dbus_api/Makefile.am:
2132 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2133 the send_email D-Bus method.
2135 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2139 * libmodest-dbus-client/Makefile.am:
2140 * libmodest-dbus-client/libmodest-dbus-client.c:
2141 * libmodest-dbus-client/libmodest-dbus-client.h:
2142 * tests/dbus_api/Makefile.am:
2143 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2144 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2146 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2148 * src/maemo/easysetup/modest-easysetup-wizard.c:
2149 (create_page_account_details):
2150 * src/maemo/modest-account-settings-dialog.c:
2151 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2152 widgets, because this might not be the default in future versions of the Maemo GTK+.
2153 However, I can not not get capitalization to work even in a simple test case.
2155 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2157 * src/maemo/easysetup/modest-easysetup-wizard.c:
2158 (create_page_custom_incoming), (create_page_custom_outgoing):
2159 * src/maemo/modest-account-settings-dialog.c:
2160 (create_page_account_details), (create_page_incoming),
2161 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2162 instead of using gtk_check_button_with_label(), so they are aligned like the other
2163 widgets, as per the UI spec.
2165 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2167 * src/maemo/easysetup/modest-easysetup-wizard.c:
2168 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2169 * src/widgets/modest-validating-entry.c:
2170 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2171 Modest prefix instead of an EasySetup prefix.
2173 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2175 * src/widgets/modest-validating-entry.h:
2176 * src/widgets/modest-validating-entry.c: (on_insert_text),
2177 Added easysetup_validating_entry_set_max_func(), used to set a callback
2178 to call when the max number of characters is reached. GtkEntry has a max-length
2179 already but is silent about it.
2181 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2182 (create_page_account_details), (create_page_user_details),
2184 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2185 (create_page_account_details), (create_page_user_details),
2186 (create_page_outgoing):
2187 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2188 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2189 the UI spec, when the user tries to enter more than the max number of characters.
2191 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2193 * src/maemo/easysetup/modest-easysetup-wizard.c:
2194 (create_page_user_details), (create_page_custom_incoming),
2195 (create_page_custom_outgoing):
2196 * src/maemo/modest-account-settings-dialog.c:
2197 (create_page_user_details), (create_page_incoming),
2198 (create_page_outgoing):
2199 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2200 (modest_connection_specific_smtp_edit_window_init):
2201 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2202 not appropriate. Bad Maemo-specific defaults!.
2204 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2206 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2207 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2208 (modest_signature_editor_dialog_set_settings):
2209 Disable the label and textview when the checkbox is disabled, and use the
2210 specified (UI spec) default signature text.
2212 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2214 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2215 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2217 * src/modest-defs.h:
2218 * src/modest-account-mgr-helpers.h:
2219 * src/modest-account-mgr-helpers.c:
2220 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2222 * src/maemo/Makefile.am:
2223 * src/maemo/modest-signature-editor-dialog.c:
2224 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2227 * src/maemo/modest-account-settings-dialog.h:
2228 * src/maemo/modest-account-settings-dialog.c:
2229 (modest_account_settings_dialog_finalize), (on_button_signature),
2230 (save_configuration): Use the new dialog when the Edit button is pressed, and
2231 save the changes if necessary, as per the UI spec.
2233 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2235 * src/maemo/Makefile.am:
2236 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2237 based on maemo-develoers email from Dirk.
2239 * src/maemo/easysetup/modest-easysetup-wizard.c:
2240 (create_page_welcome), (create_page_account_details),
2241 (create_page_user_details), (create_page_complete_easysetup),
2242 (create_page_custom_incoming), (create_page_custom_outgoing),
2243 (create_page_complete_custom),
2244 (modest_easysetup_wizard_dialog_init):
2245 * src/maemo/modest-account-settings-dialog.c:
2246 (create_page_account_details), (create_page_user_details),
2247 (create_page_incoming), (create_page_outgoing),
2248 (modest_account_settings_dialog_init):
2249 * src/maemo/modest-connection-specific-smtp-window.c:
2250 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2252 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2254 * src/maemo/easysetup/modest-easysetup-wizard.c:
2255 (create_page_account_details), (create_page_custom_outgoing),
2256 (create_page_complete_custom):
2257 * src/maemo/modest-account-settings-dialog.c:
2258 (create_page_user_details), (create_page_incoming),
2259 (create_page_outgoing):
2260 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2261 (modest_connection_specific_smtp_edit_window_init):
2262 Use the correct (UI spec) port min/max, and use horizontal separators,
2265 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2267 * src/maemo/easysetup/modest-easysetup-wizard.c:
2268 (set_default_custom_servernames):
2269 * src/maemo/modest-account-settings-dialog.c:
2270 (create_page_incoming), (on_combo_outgoing_security_changed),
2271 (on_combo_incoming_security_changed), (create_page_outgoing),
2272 (modest_account_settings_dialog_set_account_name),
2273 (save_configuration):
2274 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2275 (on_combo_security_changed),
2276 (modest_connection_specific_smtp_edit_window_init),
2277 (modest_connection_specific_smtp_edit_window_set_connection),
2278 (modest_connection_specific_smtp_edit_window_get_settings):
2279 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2282 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2285 * src/maemo/easysetup/modest-easysetup-wizard.c:
2286 (create_page_custom_outgoing), (create_page_complete_custom):
2287 * src/maemo/modest-account-settings-dialog.c:
2288 (create_page_user_details), (create_page_outgoing):
2289 * src/maemo/modest-account-view-window.c: (button_box_new):
2290 Use changed logical IDs as per the most recent UI spec:
2291 mcen_bd_emailsetup_edit -> mcen_bd_edit
2292 mcen_bd_emailsetup_delete -> mcen_bd_delete
2293 mcen_bd_emailsetup_close -> mcen_bd_close
2295 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2299 * src/dbus_api/Makefile.am:
2300 * src/dbus_api/modest-dbus-callbacks.c:
2301 * src/dbus_api/modest-dbus-callbacks.h:
2302 * src/maemo/modest-platform.c: (modest_platform_init):
2303 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2305 * tests/Makefile.am:
2306 * tests/dbus_api/Makefile.am:
2307 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2309 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2311 * src/maemo/modest-account-settings-dialog.c:
2312 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2313 Removed unnecessary includes.
2315 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2317 * src/maemo/easysetup/modest-easysetup-wizard.c:
2318 * src/maemo/modest-account-settings-dialog.c:
2319 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2320 * src/widgets/Makefile.am:
2321 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2322 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2323 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2324 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2325 * src/widgets/modest-secureauth-combo-box.c:
2326 * src/widgets/modest-secureauth-combo-box.h:
2327 * src/widgets/modest-serversecurity-combo-box.c:
2328 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2329 made the GObject names more consistent with the rest of the Modest code.
2331 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2333 * src/maemo/easysetup/Makefile.am:
2334 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2335 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2336 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2337 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2338 * src/maemo/easysetup/modest-easysetup-wizard.c:
2339 * src/maemo/easysetup/modest-validating-entry.c:
2340 * src/maemo/easysetup/modest-validating-entry.h:
2341 * src/maemo/modest-account-settings-dialog.c:
2342 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2343 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2344 widgets/ because they are used outside of easysetup too. After checking in,
2345 svn will allow me to rename them too.
2347 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2349 * src/gnome/modest-msg-edit-window.c:
2350 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2351 linker error, to fix the build on the GNOME platform.
2352 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2353 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2354 ifdefed out to avoid a warning.
2356 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2358 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2359 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2360 some alternative for GTK+ 2.6.
2362 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2364 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2366 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2367 specified for EmailAccountsDialog in UI spec.
2369 * src/maemo/easysetup/modest-easysetup-wizard.c:
2370 * src/maemo/easysetup/modest-easysetup-wizard.h:
2371 * src/maemo/modest-account-settings-dialog.c:
2372 * src/maemo/modest-account-settings-dialog.h:
2373 Reuse a member window widget for the connection-specific SMTP server accounts,
2374 so we can tell it to create/save the accounts only if we actually save changes.
2376 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2377 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2378 (modest_connection_specific_smtp_edit_window_get_settings):
2379 Return a struct instance for temporarily remembering the entered data.
2381 * src/maemo/modest-connection-specific-smtp-window.h:
2382 * src/maemo/modest-connection-specific-smtp-window.c:
2383 (modest_connection_specific_smtp_window_finalize),
2384 (modest_connection_specific_smtp_window_fill_with_connections),
2386 (modest_connection_specific_smtp_window_save_server_accounts),
2387 (update_model_server_names): Do not actually save data until asked,
2388 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2390 (on_selection_changed),
2391 (modest_connection_specific_smtp_window_init): Disable the edit
2392 button when nothing is selected.
2394 * src/modest-account-mgr-helpers.c:
2395 * src/modest-account-mgr-helpers.h:
2396 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2399 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2401 * src/modest-account-mgr-helpers.h:
2402 * src/modest-account-mgr-helpers.c:
2403 (modest_account_mgr_get_unused_account_name),
2404 (modest_account_mgr_get_unused_account_display_name): Added these
2405 utility functions, to avoid code duplication.
2407 * src/maemo/easysetup/modest-easysetup-wizard.c:
2408 (create_page_account_details), (create_account):
2409 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2410 (on_combo_security_changed),
2411 (modest_connection_specific_smtp_edit_window_init),
2412 (modest_connection_specific_smtp_edit_window_save_settings):
2413 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2414 * src/maemo/modest-connection-specific-smtp-window.c:
2415 (modest_connection_specific_smtp_window_finalize),
2416 (modest_connection_specific_smtp_window_fill_with_connections),
2417 (on_button_edit), (modest_connection_specific_smtp_window_init):
2418 * src/maemo/modest-connection-specific-smtp-window.h:
2419 Implementing saving of connection-specific server accounts.
2421 But I need to refactor this so we can save the data for each
2422 possible connection-specific account and only actually create the server accounts
2423 when the easysetup finished, or the OK button is pressed on the account settings
2426 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2428 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2429 (on_combo_security_changed):
2430 (modest_connection_specific_smtp_edit_window_init):
2431 Auto-fill the port number as in the account settings.
2433 (modest_connection_specific_smtp_edit_window_set_connection):
2434 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2435 * src/maemo/modest-connection-specific-smtp-window.c:
2436 (fill_with_connections), (on_button_edit),
2437 (modest_connection_specific_smtp_window_init):
2438 Turn the edit window into a dialog to simplify the code, and
2439 set a WM hint as in a GtkDialog, because only a popup can be on top of
2440 another window in Maemo, and popups usually have no WM decoration.
2442 * src/modest-defs.h:
2443 * src/modest-account-mgr-helpers.c:
2444 (modest_account_mgr_set_connection_specific_smtp),
2445 (modest_account_mgr_remove_connection_specific_smtp),
2446 (modest_account_mgr_get_connection_specific_smtp):
2447 * src/modest-account-mgr-helpers.h: Some functions to write the
2448 connection-specific SMTP server information. Not yet used.
2451 * src/widgets/modest-folder-view.c: (text_cell_data):
2452 Fix a warning about an uninitialized variable.
2453 (on_configuration_key_changed): Put an #ifdef around the use
2454 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2456 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2458 * src/maemo/modest-account-settings-dialog.h:
2459 * src/maemo/modest-account-settings-dialog.c:
2460 Added connect_for_modified() utility function to mark the new modified boolean.
2462 (create_page_account_details), (create_page_user_details),
2463 (create_page_incoming), (create_page_outgoing), (on_response),
2464 (modest_account_settings_dialog_init),
2465 (modest_account_settings_dialog_set_account_name):
2466 Only warn about unsaved changes when there are actually unsaved changes.
2468 * src/modest-account-mgr-helpers.c:
2469 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2470 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2471 to get the data from there in future.
2473 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2475 * src/modest-defs.h:
2477 * src/modest-account-mgr-helpers.h:
2478 * src/modest-account-mgr-helpers.c:
2479 Store the security account setting in a single conf key instead of using
2480 the options list, so that the list is left for just the to-be-removed camel hack,
2481 and because gconf_client_set_list() is failing for some reason.
2483 * src/modest-account-mgr.c:
2484 (modest_account_mgr_add_server_account):
2485 * src/maemo/modest-account-settings-dialog.c:
2486 (modest_account_settings_dialog_set_account_name),
2487 (save_configuration): Use the renamed functions.
2490 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2492 * src/widgets/Makefile.am:
2493 * src/widgets/modest-limit-retrieve-combo-box.c:
2494 * src/widgets/modest-limit-retrieve-combo-box.h:
2495 * src/widgets/modest-retrieve-combo-box.c:
2496 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2497 the account settings dialog.
2499 * src/modest-defs.h:
2500 * src/modest-account-mgr-helpers.h:
2501 * src/modest-account-mgr-helpers.c:
2502 (modest_server_account_get_option_secure_auth),
2503 (modest_server_account_set_option_secure_auth):
2504 * src/modest-account-mgr.c:
2505 (modest_account_mgr_add_server_account):
2506 Use the existing AUTH_MECH conf key for the secure-auth setting,
2507 instead of putting it in the list options, because this was actually used already.
2509 * src/maemo/modest-account-settings-dialog.c:
2510 (create_page_account_details),
2511 (modest_account_settings_dialog_set_account_name),
2512 (save_configuration):
2513 * src/maemo/modest-account-settings-dialog.h:
2514 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2515 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2517 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2519 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2520 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2521 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2523 * src/modest-defs.h:
2524 * src/maemo/modest-account-settings-dialog.c:
2525 (create_page_incoming), (on_combo_outgoing_security_changed),
2526 (on_combo_incoming_security_changed), (create_page_outgoing),
2527 (modest_account_settings_dialog_set_account_name),
2528 (save_configuration): Load/Save the port number, and change it when the
2529 security combo changes, to suitable defaults.
2531 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2533 * src/modest-account-mgr.c:
2534 (modest_account_mgr_add_server_account): Set the security and secure-auth
2535 options, and add a comment saying that the other camel-specific options should be
2538 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2540 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2542 * src/modest-tny-account-store.c: (account_list_free),
2543 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2544 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2547 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2549 * src/modest-protocol-info.c:
2550 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2551 is required by our UI spec. Maybe something in our implementation will use this eventually.
2552 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2553 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2554 instead of the previous 0 placeholder.
2556 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2557 secure-auth settings.
2558 * src/modest-account-mgr-helpers.h:
2559 * src/modest-account-mgr-helpers.c:
2560 (modest_server_account_data_get_option_secure_auth),
2561 (modest_server_account_set_option_secure_auth),
2562 (modest_server_account_data_get_option_security),
2563 (modest_server_account_set_option_security): Added this API for getting and setting the security
2564 and secure-auth settings.
2566 * src/maemo/modest-account-settings-dialog.h:
2567 * src/maemo/modest-account-settings-dialog.c:
2568 (modest_account_settings_dialog_finalize), (check_data),
2569 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2570 about changing titles.
2571 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2572 (save_configuration): Save the security and secure-auth settings.
2574 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2575 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2577 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2579 * src/modest-defs.h:
2580 * src/modest-account-mgr.c:
2581 (modest_account_mgr_add_server_account):
2582 Added and used defines for the options key and value pair strings,
2583 that are used so far, though they do not seem to correspond to anything in our
2584 UI specs or ModestProtocol enum.
2586 * src/modest-account-mgr-helpers.h:
2587 * src/modest-account-mgr-helpers.c:
2588 (compare_option_strings_for_name),
2589 (modest_server_account_data_get_option_value),
2590 (modest_server_account_data_get_option_bool),
2591 (modest_account_mgr_get_server_account_option):
2592 Added helper functions for parsing the options GSList.
2594 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2596 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2597 display name is based on the supplied account name.
2598 * src/modest-account-mgr.c:
2599 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2600 with an inefficient, but good-enough, implementation.
2602 * src/maemo/easysetup/modest-easysetup-wizard.c:
2603 (create_page_account_details), (on_before_next), (create_account):
2604 Check for existing display names rather than (non-user-visible) account names, and just
2605 create and set a unique account name at the end.
2607 * src/maemo/modest-account-settings-dialog.c:
2608 (modest_account_settings_dialog_init),
2609 (modest_account_settings_dialog_set_account_name),
2610 (create_page_incoming): Show the display name, instead of the account name.
2611 (on_response): Do some (not all) extra checks, as in the UI spec.
2612 (save_configuration): Save the display name if it was changed.
2614 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2616 * po/en_GB.po: Added needed logical ID and translation.
2617 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2618 (init_view): Made the is-default column clicking work.
2620 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2623 * src/maemo/easysetup/Makefile.am:
2624 * src/maemo/easysetup/modest-easysetup-wizard.c:
2625 (modest_easysetup_wizard_dialog_init):
2626 * src/maemo/easysetup/provider-data-test.keyfile:
2627 * src/maemo/easysetup/provider-data.keyfile:
2628 Moved the provider data file to the new modest-providers-data package and used it from there.
2630 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2632 * src/modest-local-folder-info.c:
2633 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2634 N_() was already used on the static strings, but this just marks it for translation without
2635 using the translation.
2637 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2639 * src/maemo/modest-account-settings-dialog.c:
2640 (create_page_incoming),
2641 (modest_account_settings_dialog_set_account_name):
2642 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2643 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2644 I will do this if nobody else gets there first.
2646 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2648 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2649 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2650 save the security stuff.
2652 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2654 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2655 Set the email address and user fullname, which I now see must be
2658 * src/maemo/modest-account-settings-dialog.h:
2659 * src/maemo/modest-account-settings-dialog.c:
2661 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2662 leave-on-server and authentication.
2663 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2666 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2669 * src/maemo/modest-account-settings-dialog.c:
2670 * src/maemo/modest-account-settings-dialog.h:
2671 Most (but not all) of the widgets are now present as specified by the UI spec.
2672 No changes are yet saved, and some details are not properly shown yet.
2674 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2676 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2678 * src/maemo/Makefile.am:
2679 * src/maemo/modest-account-settings-dialog.c:
2680 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2681 an existing account. Doesn't do much yet.
2683 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2684 Open the accounts settings dialog when Edit is clicked.
2686 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2688 * src/maemo/easysetup/Makefile.am:
2689 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2691 * src/maemo/easysetup/modest-easysetup-wizard.c:
2692 (modest_easysetup_wizard_dialog_init):
2693 Try to get the source directory from the build system,
2694 instead of hard-coding "./" into the source code, when opening our local
2695 copies of the configuration files.
2696 But this still fails when opening the wizard from the Accounts window,
2697 maybe because the working directory seems to change at runtime.
2698 So the wizard will fail the second time unless you copy the files into their
2699 proper locations - see the stdout warnings for the paths.
2701 (create_page_account_details),(on_before_next):
2702 Check for existing non-server accounts instead of server accounts,
2703 so the default account name is useful again, and to prevent trying to
2706 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2707 Show the wizard when New is clicked.
2709 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2710 (init_view): Show the column headers, and show the columns that are
2711 specified in the UI specs. However, something in Maemo's GTK+ prevents
2712 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2713 change the default account. This is despite unsetting the special properties.
2715 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2717 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2718 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2719 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2720 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2721 to make that clearer.
2722 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2724 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2726 * src/maemo/modest-account-view-window.c:
2727 (modest_account_view_window_init),
2728 (modest_account_view_window_new):
2729 Use the same buttons as specified in the
2730 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2731 the existing widgets, which never had a chance of working.
2732 Put the ModestAccountView treeview in a scrolled window.
2733 Do not repeat the initialization in both _init() and _new().
2735 * src/widgets/modest-account-view.c: (update_account_view):
2736 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2737 this widget and window shows no accounts.
2739 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2741 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2743 * src/maemo/easysetup/modest-easysetup-wizard.c:
2744 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2745 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2746 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2749 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2750 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2751 accounts exist yet, as in the UI spec.
2753 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2755 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2757 * src/maemo/Makefile.am:
2758 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2759 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2760 New window for editing connection-specific smtp details.
2761 Not fully implemented.
2763 * src/maemo/modest-connection-specific-smtp-window.c:
2764 (modest_connection_specific_smtp_window_finalize) :
2765 unref the tree model.
2766 (on_button_edit): Show the edit window.
2768 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2770 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2773 * src/maemo/Makefile.am:
2774 * src/maemo/modest-connection-specific-smtp-window.c:
2775 * src/maemo/modest-connection-specific-smtp-window.h:
2776 New window for showing the list of connections, for connection-specific
2777 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2778 * src/maemo/easysetup/modest-easysetup-wizard.c:
2779 (create_page_custom_outgoing): Show the new window when the button is clicked.
2781 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2783 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2784 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2785 * src/maemo/modest-msg-edit-window.c:
2786 (modest_msg_edit_window_insert_image):
2787 * src/modest-conf.c: (modest_conf_key_escape):
2788 * src/modest-mail-operation.c:
2789 (modest_mail_operation_send_new_mail):
2790 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2791 (modest_ui_actions_on_new_account):
2792 * src/widgets/modest-attachment-view.c: (update_filename_request):
2793 * src/widgets/modest-mail-header-view.c:
2794 Corrected warnings that were breaking the build, by commenting out unused variables,
2795 and a function, and by including a header.
2797 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2799 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2800 so we can #ifdef around platform-specific code when necessary.
2801 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2802 to allow this to build for the GNOME platform too.
2804 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2806 * src/maemo/easysetup/modest-easysetup-wizard.c:
2807 Added util_increment_name() and used it in create_page_account_details()
2808 to make sure that the default account name is always a new name.
2810 (modest_easysetup_wizard_dialog_init),
2811 (set_default_custom_servernames): Some minor memory management fixes.
2813 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2817 * src/modest-runtime.c: (init_i18n): Restored the translation
2818 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2819 are defined in config.h, and the translations are installed.
2821 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2822 is defined for translation.
2824 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2826 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2828 * src/maemo/easysetup/modest-easysetup-wizard.c:
2829 (modest_easysetup_wizard_dialog_init):
2830 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2831 Use realistic paths (though they should use $prefix generically) to the
2832 mcc_mapping and provider-data.keyfile files which might work when they
2833 are installed by the future version of the operator-wizard package,
2834 and then fallback to paths in our source code, with an explanatory
2837 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2841 * src/maemo/Makefile.am:
2842 * src/maemo/easysetup/: Added files from the previously-exernal
2843 osso-modest-easysetup.
2844 * src/maemo/modest-main-window-ui.h:
2845 * src/modest-ui-actions.c:
2846 * src/modest-ui-actions.h:
2847 Added modest_ui_actions_on_new_account() as a signal handler for the
2848 New Account menu item. It shows the easysetup wizard.
2849 * po/en_GB.po: Added additional needed logical IDs and translations.
2851 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2852 Apparently ChangeLog is not used for some vague Nokia legal reasons.