1 2007-06-26 Murray Cumming <murrayc@murrayc.com>
3 * libmodest-dbus-client/libmodest-dbus-client.c:
4 * libmodest-dbus-client/libmodest-dbus-client.h:
5 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
6 libmodest_dbus_client_compose_mail() is what things actually use.
8 * src/dbus_api/modest-dbus-api.h:
9 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
10 * tests/dbus_api/Makefile.am:
11 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
14 2007-06-26 Murray Cumming <murrayc@murrayc.com>
16 * src/modest-init.c: (modest_init_local_folders):
17 For memory-card (or other non local-folders) maildir accounts,
18 always create an Archive folder, so that there is somewhere to put
19 messages. This should be less confusing, because the user does not need
20 to guess that the need to create a folder.
22 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
24 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
25 Fixed icon size by using (50, 50) which is the same as defined by
28 2007-06-25 Armin Burgmeier <armin@openismus.com>
30 * src/widgets/modest-window-mgr.c:
32 * configure.ac: Correctly recognize hildon-notify presence and fixed
33 the build without it being installed.
35 2007-06-25 Murray Cumming <murrayc@murrayc.com>
37 * libmodest-dbus-client/libmodest-dbus-client.c:
38 (libmodest_dbus_client_search): Fix the build. Sorry.
39 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
40 (reply_forward_cb): Initialize variables to fix the build.
42 * src/modest-tny-account-store.c:
43 (modest_tny_account_store_get_tny_account_by): Fix the account URI
44 comparison (a silly typo) so that email search results can be opened
45 when there are more than one account.
47 2007-06-25 Murray Cumming <murrayc@murrayc.com>
49 * libmodest-dbus-client/libmodest-dbus-client.c:
50 (libmodest_dbus_client_search),
51 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
52 instead of 1 second, because the search gets folders and messages from
53 the server, which can take a long time. When it times out,
54 osso-global-search will report no results.
56 We need to specify whether we should search only cached information
57 (maybe with a user preference), and the osso-email-search-plugin
58 API should really be improved to allow that option, and to allow results
59 to be delivered asynchronously in batches.
61 2007-06-25 Murray Cumming <murrayc@murrayc.com>
63 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
64 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
65 GTK_ICON_SIZE_DIALOG is probably the wrong size.
67 2007-06-25 Murray Cumming <murrayc@murrayc.com>
69 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
70 that is an empty string. D-Bus seems to give us these instead of NULL.
72 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
74 * src/dbus_api/modest-dbus-callbacks.c:
75 * src/maemo/easysetup/modest-easysetup-wizard.h:
76 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
77 * src/maemo/modest-connection-specific-smtp-edit-window.c:
78 (modest_connection_specific_smtp_edit_window_init):
79 * src/maemo/modest-maemo-global-settings-dialog.c:
81 * src/maemo/modest-maemo-utils.c:
82 (modest_maemo_utils_setup_images_filechooser):
83 * src/maemo/modest-main-window.c: (create_details_widget):
84 * src/maemo/modest-msg-edit-window.c:
85 (modest_msg_edit_window_attach_file_noninteractive),
86 (modest_msg_edit_window_color_button_change),
87 (modest_msg_edit_window_set_zoom):
88 * src/modest-mail-operation.c: (update_account_thread):
89 * src/modest-tny-account-store.c:
90 * src/modest-tny-account.c:
91 * src/widgets/modest-global-settings-dialog.c:
92 * src/widgets/modest-window.h:
96 2007-06-25 Murray Cumming <murrayc@murrayc.com>
98 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
99 * src/modest-search.c: (modest_search_folder),
100 (modest_search_all_accounts): Actually search only in the specified folder,
101 doing a simple match on the folder ID.
102 * src/modest-search.h: Added a folder field to the ModestSearch struct,
103 and added some documentation.
105 2007-06-22 Armin Burgmeier <armin@openismus.com>
107 * src/maemo/modest-maemo-utils.h:
108 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
109 modest_maemo_utils_get_supported_secure_authentication_methods.
111 * src/maemo/easysetup/modest-easysetup-wizard.c:
112 * src/maemo/modest-account-settings-dialog.c: Show correct error if
113 one occured, not just "Server does not support secure authentication".
115 2007-06-22 Murray Cumming <murrayc@murrayc.com>
117 * src/modest-tny-account-store.c: (get_password):
118 Restored the call to tny_account_set_user() because Philip seems to have
119 stopped this from crashing (by not using the freed string). It still does
120 not work, but now we can test it.
122 2007-06-22 Murray Cumming <murrayc@murrayc.com>
124 * src/maemo/modest-msg-edit-window.c: (init_window):
125 Comment out use of an uninitialzed GtkScrolledWindow variable,
126 to fix the build and stop a crash. Yet again.
128 2007-06-22 Murray Cumming <murrayc@murrayc.com>
130 * src/modest-tny-account-store.c: (get_password):
131 Remove the call to tny_account_set_user() because this actually crashes.
132 As mentioned in the last commit, it is known to not work anyway.
134 2007-06-22 Murray Cumming <murrayc@murrayc.com>
136 * src/modest-tny-account-store.c: (get_password):
137 Use tny_account_set_username() to tell tinymail that the username might
138 have changed too. But tinymail ignores this: see projects.maemo.org
140 * src/modest-ui-actions.c:
141 (modest_ui_actions_on_password_requested): Remove the useless attempt to
142 reset the connection when changing the username, and improve the comments.
143 Save the changed username to gconf at least, so it is used when Modest is
146 2007-06-21 Murray Cumming <murrayc@murrayc.com>
148 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
149 Do not use a query, so that we get all folders, including for POP and
150 local-folders. They work as search criteria too.
151 This fixes projects.maemo.org bug NB#57740.
153 2007-06-21 Murray Cumming <murrayc@murrayc.com>
155 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
156 Comment out the use of hildon_notification_set_sound() because it is
157 not declared, to fix the build. Warnings are serious, people.
159 2007-06-21 Armin Burgmeier <armin@openismus.com>
161 * src/maemo/modest-maemo-utils.h:
162 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
163 modest_maemo_utils_get_supported_secure_authentication_methods()
164 to query authentication methods for a specific user. This should fix
165 projects.maemo.org bug NB#61369.
167 * src/maemo/easysetup/modest-easysetup-wizard.c:
168 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
171 2007-06-21 Murray Cumming <murrayc@murrayc.com>
173 * libmodest-dbus-client/libmodest-dbus-client.h:
174 * libmodest-dbus-client/libmodest-dbus-client.c:
175 (modest_dbus_message_iter_get_search_hit),
176 (libmodest_dbus_client_search):
177 Reorganised and commented this.
178 Removed modest_search_hit_free() from the public API because it
181 Added libmodest_dbus_client_get_folders() and
182 modest_folder_result_list_free().
184 * src/dbus_api/modest-dbus-api.h:
185 * src/dbus_api/modest-dbus-callbacks.c:
186 (modest_dbus_req_filter): Commented. Moved most code to
187 on_dbus_method_search() and added on_dbus_method_get_folders().
189 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
190 of the extra D-Bus handler.
192 * tests/dbus_api/Makefile.am:
193 * tests/dbus_api/test_get_folders.c: New test for
194 libmodest_dbus_client_get_folders(). This seems to return an empty list
195 at the moment. That could be the same error that causes the message list
196 to be empty sometimes.
197 This should help with projects.maemo.org bug NB#57740.
199 2007-06-21 Armin Burgmeier <armin@openismus.com>
201 * src/modest-mail-operation.c: Do not call
202 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
203 notify the operation's end after having set the status to CANCELED for
204 the operation queue to listen on. This fixes a deadlock when there
205 were mail operations in the queue during its finalization.
207 * src/modest-singletons.c: Reordered uninitialization of the account
208 manager to happen after the mail operation queue was uninitialized
209 because the mail operation's in the queue might still try to access
210 the account manager (see modest_mail_operation_notify_end()). This
211 fixes a potential crash when terminating the application.
213 2007-06-21 Murray Cumming <murrayc@murrayc.com>
215 * src/modest-search.c:
216 (search_mime_part_and_child_parts): Moved some code here so we
217 can search recursively in child folders.
218 (modest_search_folder): Search in the message as a mime part, instead
219 of just its child mime parts.
220 (read_chunk), (search_mime_part_ogs):
221 Check how many bytes were read, to prevent an endless loop.
222 Searching in message bodies now works. This finishes the fix for
223 projects.maemo.org bug NB#61007.
225 2007-06-20 Murray Cumming <murrayc@murrayc.com>
227 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
228 Add a g_warning when the item is not a folder.
230 * src/modest-ui-dimming-rules.c:
231 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
232 when selected item is not a folder (for instance, an account), because
233 the UI spec only talks about folders.
234 I am not sure what the UI spec wants, so this might not totally fix
235 projects.maemo.org bug NB#60794.
237 2007-06-20 Murray Cumming <murrayc@murrayc.com>
239 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
240 (load_from_file): Sort the list. The unsorted list would be more noticeable
241 in non-English locales.
243 * src/maemo/modest-msg-edit-window.c:
244 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
245 warning and fix the build.
247 * src/maemo/modest-progress-bar-widget.c:
248 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
249 avoid a g_warning, and probably to avoid a crash.
251 2007-06-20 Murray Cumming <murrayc@murrayc.com>
253 * src/modest-search.c: (modest_search_folder): Check for a GError
254 when calling tny_folder_get_headers(), to show that this is not the cause
257 2007-06-20 Murray Cumming <murrayc@murrayc.com>
259 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
260 Actually set the body query instead of the subject query.
262 * src/modest-search.c: (search_mime_part_ogs),
263 (search_mime_part_strcmp): Remove extra space from the text/* regex,
264 which would probably cause it to fail if we got this far.
266 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
267 to simplify the code.
268 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
269 be causing search-in-body to fail.
271 2007-06-20 Murray Cumming <murrayc@murrayc.com>
273 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
275 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
276 Better debug message when the folder cannot be found.
277 This should help with fixing projects.maemo.org bug #61287.
278 * src/modest-search.c: (add_hit): Do not leak the furl string.
280 2007-06-20 Murray Cumming <murrayc@murrayc.com>
282 * src/modest-ui-actions.c:
283 (modest_ui_actions_on_folder_selection_changed):
284 Do not special-case TNY_MERGE_FOLDER here, because
285 modest_tny_folder_get_account() already does that. This fixes
286 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
287 shown when the Outbox was selected).
289 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
291 * libmodest-dbus-client/libmodest-dbus-client.c:
292 (_dbus_iter_get_string_or_null): Initialize the string variable in
293 case this helps with Dirk's crash.
295 2007-06-19 Murray Cumming <murrayc@murrayc.com>
297 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
298 though it is not implemented yet (this function is maybe not even used),
299 to avoid breaking ABI in future.
300 * libmodest-dbus-client/libmodest-dbus-client.c:
301 (get_attachments_string): Moved some code into this generic function.
302 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
303 sends email. It is maybe not used.
304 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
305 (on_send_mail): Use attachments.
307 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
308 * src/maemo/modest-msg-edit-window.c:
309 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
310 a filename before using it, to fix projects.maemo.org bug NB#58233.
312 2007-06-19 Murray Cumming <murrayc@murrayc.com>
314 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
315 Initialize the continue_download variable to fix the build, and probably
316 to fix randome behaviour.
318 2007-06-18 Armin Burgmeier <armin@openismus.com>
320 * src/modest-tny-send-queue.h:
321 * src/modest-tny-send-queue.c: Keep track of the status of messages in
322 the queue so we can later show it in the UI. Replaced
323 modest_tny_send_queue_msg_is_being_sent() by
324 modest_tny_send_queue_get_msg_status().
326 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
328 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
329 gpointer. This probably was not harmful, but just to be sure.
331 2007-06-18 Murray Cumming <murrayc@murrayc.com>
333 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
334 Fix the build, but leave the function broken on Bora, because
335 hildon_uri_action_get_service() does not exist.
336 osso_uri_action_get_service() does not exist either, it seems.
338 2007-06-18 Murray Cumming <murrayc@murrayc.com>
340 * src/modest-tny-account.c:
341 (modest_tny_account_new_from_server_account):
342 Uncommented the url debug output again, because it is useful for
343 debugging, as I said in the comment.
345 2007-06-18 Murray Cumming <murrayc@murrayc.com>
347 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
349 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
350 for Mameo Bora, to fix the build.
352 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
355 Fixed build with hildon < 0.99
357 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
358 Check if the selected account is busy instead of checking all accounts
360 * src/modest-account-mgr-priv.h:
361 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
362 (modest_account_mgr_init), (compare_account_name),
363 (modest_account_mgr_set_account_busy),
364 (modest_account_mgr_account_is_busy):
365 * src/modest-account-mgr.h:
366 Added busy information to the account manager. It possible to
367 set an account to busy or not busy now.
369 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
370 (modest_mail_operation_update_account),
371 (modest_mail_operation_notify_end):
372 Set the account to busy/not busy depending on the operation state.
374 * src/widgets/modest-account-view.c:
375 (modest_account_view_finalize), (get_last_updated_string),
376 (update_account_view), (on_account_busy_changed), (init_view):
377 Show string "Refreshing..." if the account is currently busy.
379 All this fixes projects.maemo.org bug NB#59711
381 2007-06-14 Armin Burgmeier <armin@openismus.com>
383 * src/widgets/modest-attachments-view.h:
384 * src/widgets/modest-attachments-view.c: Added
385 modest_attachments_view_has_attachments() and fixed coordinate
386 transformation in get_att_view_at_coords(). This fixes attachment
389 * src/widgets/modest-msg-view.c: Make use of
390 modest_attachments_view_has_attachments() to decide whether to show
391 attachments in the header.
393 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
395 * src/maemo/modest-connection-specific-smtp-edit-window.c:
396 (on_change), (on_combo_security_changed),
397 (modest_connection_specific_smtp_edit_window_init),
398 (modest_connection_specific_smtp_edit_window_set_connection),
399 (modest_connection_specific_smtp_edit_window_is_dirty):
400 * src/maemo/modest-connection-specific-smtp-edit-window.h:
401 * src/maemo/modest-connection-specific-smtp-window.c:
404 Show an comfirmation dialog for the smpt-edit-window if there are
405 unsaved changes and the user hits cancel.
406 (projects.maemo.org bug NB#60479)
408 2007-06-14 Armin Burgmeier <armin@openismus.com>
410 * src/maemo/easysetup/modest-easysetup-wizard.c:
411 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
412 address" info in banner instead of node, and select all the text as
413 per UI spec. This fixes projects.maemo.org bug NB#60550.
415 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
417 reviewed by: <delete if not using a buddy>
419 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
420 * src/modest-ui-actions.c: (folder_refreshed_cb):
422 2007-06-14 Murray Cumming <murrayc@murrayc.com>
424 * src/widgets/modest-folder-view.c: (filter_row):
425 Explictly filter out the per-account outbox accounts. I don't know why
426 these only sometimes show up, but now they should never show up in the UI.
427 This should fix projects.maemo.org bug NB#60160.
429 2007-06-14 Murray Cumming <murrayc@murrayc.com>
431 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
432 when the toolbar does not exist yet.
433 * src/modest-widget-memory.c: (save_settings_header_view):
434 Added g_warnings() to help us to discover when we are trying to set
435 an empty columns list in gconf.
437 2007-06-14 Murray Cumming <murrayc@murrayc.com>
441 Added modest_init_get_default_header_view_column_ids().
443 * src/modest-widget-memory.c: (restore_settings_header_view):
444 Use the new function to get defaults, if the gconf key is empty,
445 instead of not creating any columns. This seems to fix the
446 empty right-hand pane problems.
448 * src/widgets/modest-header-view.h: Improved documentation.
450 2007-06-13 Murray Cumming <murrayc@murrayc.com>
452 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
453 Revert the use of the display name as the account name, because this
454 is generally wrong and would break the code that follows.
456 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
458 * src/maemo/easysetup/modest-easysetup-wizard.c:
459 (check_for_supported_auth_methods), (on_before_next),
462 More correct fix for projects.maemo.org bug NB# 58991
463 Do not longer accept AUTH_PASSWORD as secure method and choose
464 correct method when creating the account.
466 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
468 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
469 Fixed projects.maemo.org bug NB# 58991
471 2007-06-13 Murray Cumming <murrayc@murrayc.com>
473 * src/modest-init.c: (modest_init_init_core),
474 (modest_init_local_folders): Fixed compilation errors.
476 2007-06-13 Murray Cumming <murrayc@murrayc.com>
478 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
479 Remove unnecessary lib/include, though it is good in principle when needed.
481 * src/modest-init.c: (modest_init_one_local_folder),
482 (modest_init_local_folders):
483 * src/modest-init.h: Initialize the .modest library for memory cards,
484 instead of just doing nothing for them. This should allow us to create
485 folders there, fixing projects.maemo.org bug NB#59297.
487 2007-06-13 Murray Cumming <murrayc@murrayc.com>
489 * libmodest-dbus-client/libmodest-dbus-client.c:
490 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
491 (libmodest_dbus_client_compose_mail),
492 (libmodest_dbus_client_open_message),
493 (libmodest_dbus_client_send_and_receive),
494 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
496 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
497 (on_idle_open_message), (modest_dbus_req_handler),
498 (search_result_to_message), (modest_dbus_req_filter):
499 * src/modest-search.c: (add_hit), (modest_search_folder),
500 (modest_search_all_accounts): Improved debug messages.
502 * tests/dbus_api/test_open_message.c: (main): Improved comments.
504 * src/modest-tny-account-store.c:
505 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
508 2007-06-13 Murray Cumming <murrayc@murrayc.com>
511 2007-06-12 Murray Cumming <murrayc@murrayc.com>
513 * src/modest-tny-account-store.c: (get_server_accounts):
514 Call modest_tny_local_folders_account_add_merged_outbox_folders()
515 even when there are no accounts, so that the Outbox folder is always
516 visible. This fixes projects.maemo.org bug NB#60158.
518 2007-06-12 Murray Cumming <murrayc@murrayc.com>
520 * src/maemo/modest-main-window.c: (create_details_widget):
521 Use the mcen_va_never logical ID.
523 2007-06-12 Murray Cumming <murrayc@murrayc.com>
525 * src/dbus_api/modest-dbus-api.h:
526 * src/dbus_api/modest-dbus-callbacks.c:
527 (on_idle_open_default_inbox), (on_open_default_inbox),
528 (modest_dbus_req_handler):
529 Added a new OpenDefaultInbox method.
531 * libmodest-dbus-client/libmodest-dbus-client.h:
532 * libmodest-dbus-client/libmodest-dbus-client.c:
533 Added libmodest_dbus_client_open_default_inbox() to call the new
534 dbus method. This should be useful to projects.maemo.org bug NB#57214,
535 though it should maybe be used by a new osso-email-interface function.
537 * tests/dbus_api/Makefile.am:
538 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
541 2007-06-12 Murray Cumming <murrayc@murrayc.com>
543 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
544 NULL, so that the signals get all the keys. This should not actually
545 change any behaviour because we currently update everything when anything
548 2007-06-12 Murray Cumming <murrayc@murrayc.com>
550 * src/widgets/modest-folder-view.c: (text_cell_data),
551 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
552 (find_inbox_iter): If tinymail tells us that the folder is
553 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
554 This causes the inbox to be selected at startup, fixing part of
555 projects.maemo.org bug NB#56305.
557 * src/modest-ui-dimming-rules.c:
558 (modest_ui_dimming_rules_on_tools_smtp_servers):
559 * src/modest-ui-dimming-rules.h: Added a callback function to dim
560 the SMTP servers menu item.
561 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
562 that the SMTP Servers menu item is dimmed when there are no accounts,
563 as a future version of the UI spec will require. This fixes
564 projects.maemo.org bug NB#56305.
566 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
568 * src/maemo/modest-maemo-utils.c:
569 (modest_maemo_utils_get_supported_secure_authentication_methods):
570 Added label to dialog instead of unreadable title
572 * src/maemo/modest-main-window.c: (sync_accounts_cb),
573 (modest_main_window_new):
574 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
577 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
578 * src/modest-account-mgr.h:
579 Added method to avoid code duplication
581 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
582 (modest_ui_actions_on_send_receive):
583 Use modest_account_mgr_has_accounts
585 2007-06-11 Murray Cumming <murrayc@murrayc.com>
587 * src/maemo/easysetup/modest-presets.c:
588 (modest_presets_get_info_server_security): Do not report secure auth
590 * src/modest-protocol-info.c: Use the defines for the gconf key names
591 for secure authentication. This was not working because we were writing
592 Password and reading password, and the check was case sensitive.
593 With this, gmail now works for receiving and sending when created via
596 2007-06-11 Murray Cumming <murrayc@murrayc.com>
598 * src/maemo/easysetup/modest-presets.c:
599 (modest_presets_get_info_server_security): Correct the key name for
600 SecureSmtp, because it seems to be case-sensitive.
601 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
602 Do not try to get the 0th notebook page if there are 0 pages, to
605 2007-06-11 Murray Cumming <murrayc@murrayc.com>
607 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
608 Prevent use of the new notification feature for now, because it currently
609 shows one dialog for each new email, which is annoying.
611 2007-06-11 Murray Cumming <murrayc@murrayc.com>
613 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
614 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
615 when no country was selected, so that we show the global ones.
616 * src/maemo/easysetup/modest-presets.c:
617 (modest_presets_get_providers): Return only the global providers, not
618 all providers when mmc=0 was requested.
620 2007-06-11 Murray Cumming <murrayc@murrayc.com>
622 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
623 (easysetup_provider_combo_box_fill): Remove debug code that showed the
624 provider ID in the combo.
626 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
627 Do not show the page numbers, because it would be confusing when we add
628 the 2 extra pages for the custom setup, when the user chooses the "Other"
629 provider. This fixes projects.maemo.org bug NB#59028
631 * src/modest-init.c: (modest_init_init_core),
632 (modest_init_local_folders):
634 * src/modest-tny-account.c:
635 (modest_tny_account_new_for_local_folders): Do not create default folders
636 for the memory card. This should fix projects.maemo.org bug NB#59328.
638 2007-06-11 Murray Cumming <murrayc@murrayc.com>
640 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
641 Free the changed_conf_keys string items. They are already freed in the
642 idle handler if that runs first.
644 2007-06-11 Murray Cumming <murrayc@murrayc.com>
646 * src/modest-ui-actions.c:
647 (modest_ui_actions_on_password_requested): Check that the server name
648 is not NULL, because I just saw a password dialog with (null) as the
651 * src/modest-tny-folder.[h|c]: Added
652 modest_tny_folder_is_memory_card_folder().
653 * src/modest-ui-dimming-rules.c:
654 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
655 menu item for memory cards, as per the UI spec (section 7.4). This should
656 fix projects.maemo.org bug NB#59297.
658 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
660 * src/maemo/modest-main-window.c: (sync_accounts_cb):
661 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
662 is another problem with the code, see Murray's comment at line 772)
664 2007-06-08 Murray Cumming <murrayc@murrayc.com>
666 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
667 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
668 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
669 (load_from_file), (easysetup_country_combo_box_init),
670 (easysetup_country_combo_box_get_active_country_ids),
671 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
672 instead of just one ID, to avoid duplicate country names in the UI.
674 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
675 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
676 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
677 a single ID, avoiding duplicate providers.
678 * src/maemo/easysetup/modest-easysetup-wizard.c:
679 (on_combo_account_country): Adapt to use a list.
681 2007-06-08 Murray Cumming <murrayc@murrayc.com>
683 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
684 keys changed in the last X seconds.
686 * src/modest-account-mgr.h:
687 * src/modest-account-mgr.c: (on_timeout_notify_changes),
688 (on_key_change), (modest_account_mgr_class_init),
689 (modest_account_mgr_init), (modest_account_mgr_finalize):
690 As the keys are changed, save them in a GSList* and signal that GSList*
691 further every X seconds, to batch changes, to allow us to do just one
692 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
693 bug NB#56941 and other (UI-blocking) delays when changing account settings.
695 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
696 changed signal signature.
698 * src/modest-conf.c: (modest_conf_set_list),
699 (modest_conf_on_change): Reenable notification.
701 (modest_conf_maemo_fake_on_change): Comment out the hack that
702 notified immediately instead of asynchronously.
704 * src/widgets/modest-account-view.h:
705 * src/widgets/modest-account-view.c:
706 (update_account_view): Select the previously-selected account ID,
707 if possible. This fixes projects.maemo.org bug NB#56933.
709 (on_account_changed), (on_account_removed),
710 (modest_account_view_select_account):
712 Remove the block/unblock functions
713 because they were not useful.
715 * src/maemo/modest-account-view-window.c:
716 (on_delete_button_clicked), (on_edit_button_clicked),
717 (on_new_button_clicked): Remove the use of the non-working block/unblock.
719 2007-06-08 Murray Cumming <murrayc@murrayc.com>
721 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
722 Improve the error dialog to show Incorrect Account Settings, which seems
723 clearer, and say that the internal error message (to be removed from the
724 dialog later) is often misleading.
725 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
727 * src/modest-tny-account.c:
728 (modest_tny_account_new_from_server_account): Uncomment the printf of the
729 URL because this is so useful for debugging on the device.
731 * src/widgets/modest-serversecurity-combo-box.c:
732 (modest_serversecurity_combo_box_fill): Correct a logical ID.
734 2007-06-08 Murray Cumming <murrayc@murrayc.com>
736 * src/modest-mail-operation.c:
737 (modest_mail_operation_send_new_mail):
738 Added a comment about a nasty but apparently harmless message. Details
739 added to the wiki g_warnings() page.
741 2007-06-08 Murray Cumming <murrayc@murrayc.com>
743 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
744 (modest_tny_send_queue_class_init):
745 Do not use the priv struct because it is empty, to avoid g_warnings
746 about a non-existant priv struct.
748 * src/modest-tny-account-store.c:
749 (modest_tny_account_store_get_server_account),
750 (modest_tny_account_store_get_transport_account_for_open_connection
751 ): Do not try to get transport server accounts for local folders,
752 because they don't have any. This avoids a g_warning().
754 * src/maemo/modest-main-window.c:
755 (modest_main_window_notify_send_receive_initied),
756 (on_configuration_key_changed):
757 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
759 * src/modest-mail-operation.c:
760 (modest_mail_operation_update_account):
761 * src/modest-tny-account-store.h:
762 * src/modest-tny-account.c:
763 (modest_tny_account_get_special_folder),
764 (modest_tny_account_new_for_local_folders),
765 (modest_tny_account_new_for_per_account_local_outbox_folder):
766 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
767 * src/modest-tny-local-folders-account.c:
768 (add_account_folders_to_merged_folder):
769 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
770 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
771 (modest_ui_actions_on_send):
772 * src/widgets/modest-folder-view.c: (update_model):
773 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
774 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
775 modest_tny_account_store_get_tny_account_by_account() to
776 modest_tny_account_store_get_server_account() to make the code clearer.
778 2007-06-07 Marcus Bauer <marcusb@openismus.com>
780 * src/dbus_api/modest-dbus-api.h:
781 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
782 * src/maemo/modest-msg-edit-window.c:
783 (modest_msg_edit_window_attach_file_noninteractive):
784 added g_warning in case the file to be attached does not exist
785 * tests/dbus_api/test_compose_mail.c: (main):
786 removed obsolete comment, added generic files as test case
788 2007-06-07 Murray Cumming <murrayc@murrayc.com>
790 * src/modest-tny-account-store.c: (get_server_accounts):
791 Create the local folders account only once, not once for each outbox, and
792 not only when there are some outboxes.
794 2007-06-07 Murray Cumming <murrayc@murrayc.com>
796 * src/widgets/modest-folder-view.c: (update_model): Comment out some
797 code that is causing a crash at startup. Sergio says that he is fixing this.
799 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
801 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
802 * src/maemo/modest-account-settings-dialog.c:
803 (create_page_outgoing),
804 (modest_account_settings_dialog_set_account_name),
805 (save_configuration):
806 - Fixed handling of the "Use secure authentication" toggle to comply with
807 the ui specification. See also projects.maemo.org bug NB#58400
809 - Restore the Secure connection setting combo correctly when loading
812 * src/maemo/modest-maemo-utils.c:
813 (on_camel_account_get_supported_secure_authentication),
814 (modest_maemo_utils_get_supported_secure_authentication_methods):
815 Fixed a crasher if operation is canceled
817 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
818 (modest_protocol_info_auth_is_secure):
819 * src/modest-protocol-info.h:
821 Added two new methods to determine if a protocol/auth method is secure/encrypted in
822 the sense of the "Use secure authentication" toggle.
824 2007-06-07 Murray Cumming <murrayc@murrayc.com>
826 * src/modest-tny-account-store.h:
827 * src/modest-tny-account-store.c:
828 Added modest_tny_account_store_get_local_folders_account().
830 * src/modest-tny-folder.h:
831 * src/modest-tny-folder.c:
832 (modest_tny_folder_get_account):
833 Added this replacement for tny_folder_get_account() which returns
834 the local-folders account for TnyMergeFolders, to avoid the
835 warning about the unimplemented get_account_func() vfunc().
837 (modest_tny_folder_get_rules),
838 * src/modest-ui-actions.c:
839 (modest_ui_actions_on_folder_selection_changed):
840 * src/modest-mail-operation.c:
841 (modest_mail_operation_remove_folder),
842 (modest_mail_operation_xfer_folder),
843 (modest_mail_operation_rename_folder),
844 (modest_mail_operation_get_msg),
845 (modest_mail_operation_get_msgs_full),
846 (modest_mail_operation_remove_msg),
847 (modest_mail_operation_xfer_msgs),
848 (modest_mail_operation_refresh_folder):
849 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
851 2007-06-07 Murray Cumming <murrayc@murrayc.com>
853 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
854 (modest_server_account_set_security):
855 * src/modest-defs.h: Add comments explaining that our
856 UI spec means TLS when it says Normal, so these do not look like errors.
858 * src/modest-tny-account.c:
859 (modest_tny_account_new_from_server_account): Use the new tinymail
860 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
861 for TLS. This should fix projects.maemo.org bug NB#58460.
863 2007-06-06 Murray Cumming <murrayc@murrayc.com>
865 * src/maemo/easysetup/modest-easysetup-wizard.c:
866 (create_account): Correct the position of the gconf sanity check warning.
867 (on_button_edit_advanced_settings): Show the dialog immediately, instead
868 of using the g_idle_add() hack, because this does not seem to be necessary
869 on osso 1.1. It might even work on Maemo Bora if the problems were actually
870 caused by something other than maemo's gconf.
871 This fixes projects.maemo.org bug #59022.
873 2007-06-06 Murray Cumming <murrayc@murrayc.com>
875 * src/modest-account-mgr-helpers.c:
876 (modest_account_mgr_get_default_account): Do not check that the account
877 exists if there is no default account (NULL), to fix a runtime warning.
879 2007-06-06 Murray Cumming <murrayc@murrayc.com>
881 * src/widgets/modest-folder-view.c: (update_model):
882 Do not unref the treemodel before we have finished with it.
883 This prevents a valgrind warning and an occasional crash at startup.
885 2007-06-06 Marcus Bauer <marcusb@openismus.com>
887 * libmodest-dbus-client/libmodest-dbus-client.h:
888 added libmodest_dbus_client_compose_mail()
889 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
891 added functions needed for SendAsMail() functionality
892 * src/maemo/modest-msg-edit-window.c:
893 (modest_msg_edit_window_attach_file_noninteractive):
894 non interactively attaching files to message edit window
895 * src/widgets/modest-msg-edit-window.h:
896 * tests/dbus_api/Makefile.am:
897 added test_compose_mail.c
898 * tests/dbus_api/test_compose_mail.c: (main):
900 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
902 * src/modest-account-view.c:
903 Fixed bug projects.maemo.org bug NB#59307
905 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
907 * src/maemo/easysetup/modest-easysetup-wizard.c:
908 (get_serverport_incoming), (on_before_next), (create_account):
909 * src/maemo/modest-account-settings-dialog.c:
910 (modest_account_settings_dialog_set_account_name):
911 * src/maemo/modest-maemo-utils.c:
912 (on_camel_account_get_supported_secure_authentication_status),
913 (on_camel_account_get_supported_secure_authentication),
914 (on_secure_auth_cancel),
915 (modest_maemo_utils_get_supported_secure_authentication_methods):
917 Implemented security authentication for settings and easysetup.
919 2007-06-05 Murray Cumming <murrayc@murrayc.com>
921 * src/maemo/modest-main-window.c: (create_details_widget):
922 Show the total size for memory card accounts too, instead of showing
923 the name again. Fixes bug projects.maemo.org bug NB#59307.
925 2007-06-05 Murray Cumming <murrayc@murrayc.com>
928 * src/modest-tny-simple-folder-store.c:
929 * src/modest-tny-simple-folder-store.h: Removed.
931 * src/modest-tny-local-folders-account.h
932 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
933 for the local-folders maildir, with an extra TnyMergedFolder containing
934 the folders of the per-account outbox store accounts.
935 * src/modest-tny-account-store.c: (get_server_accounts):
936 Add the outboxes to the special local folders account after creating it.
938 * src/modest-tny-account.c:
939 (modest_tny_account_new_for_local_folders): Create the derived
940 account when creating the main local-folders account.
942 * src/maemo/modest-main-window.c: (create_details_widget),
943 (modest_main_window_set_contents_style):
944 Adapted to the use of the derived account instead of the folder store.
946 * src/modest-ui-actions.c:
947 (modest_ui_actions_on_folder_selection_changed):
948 * src/modest-ui-dimming-rules.c:
949 (modest_ui_dimming_rules_on_new_folder):
950 * src/widgets/modest-folder-view.c: (text_cell_data),
951 (icon_cell_data), (filter_row), (update_model),
952 (get_cmp_rows_type_pos):
955 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
956 Do not get the priv struct, because no priv struct has been set,
957 to avoid a runtime warning.
959 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
960 #ifelse with #else, to fix a warning, to fix the build.
963 2007-06-05 Christian Kellner <ckellner@openismus.com>
965 * libmodest-dbus-client/libmodest-dbus-client.c:
966 Fix small typo in doc (why do you always see them
967 AFTER committing stuff?)
970 2007-06-05 Christian Kellner <ckellner@openismus.com>
972 * libmodest-dbus-client/libmodest-dbus-client.c:
973 (libmodest_dbus_client_search):
974 Initialize hit list with NULL. Also set folder list
975 to "" if NULL was supplied.
978 2007-06-03 Christian Kellner <ckellner@openismus.com>
980 * libmodest-dbus-client/libmodest-dbus-client.c:
981 (modest_search_hit_list_free):
982 Make it save to call it with NULL.
984 * src/dbus_api/modest-dbus-callbacks.c:
985 * src/modest-search.c:
986 Return full ModestSearchHits as the search result list not TnyHeader
987 since can't be around withouth the correspoding TnyFolder.
989 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
991 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
992 Added currently commented code to check for secure auth
994 * src/maemo/modest-account-settings-dialog.c: (on_response),
995 (save_configuration), (show_ok):
996 Fixed projects.maemo.org bugs NB #59248 and #59251
998 * src/maemo/modest-maemo-utils.c:
999 (on_camel_account_get_supported_secure_authentication_status),
1000 (on_camel_account_get_supported_secure_authentication),
1001 (modest_maemo_utils_get_supported_secure_authentication_methods):
1002 * src/maemo/modest-maemo-utils.h:
1003 Moved get_supported_secure_authentication() method here to be able
1004 to use it from easysetup wizard.
1006 * src/modest-pair.c: (on_pair_compare_as_string):
1007 Should compare string with first part of pair and not
1008 strcmp pairs which will crash.
1010 * src/modest-protocol-info.c:
1011 (modest_protocol_info_protocol_is_store):
1012 * src/modest-protocol-info.h:
1013 Added modest_protocol_info_get_auth_protocol_name()
1015 2007-06-03 Armin Burgmeier <armin@openismus.com>
1017 * src/modest-mail-operation.c:
1018 (modest_mail_operation_get_msgs_full): Set priv->account also when
1019 only retrieving a single message. This avoids a crash when canceling
1022 (modest_mail_operation_notify_end): Do not explicitely remove the
1023 operation from the queue but only emit the progress_changed signal.
1024 The queue itself listens to that signal to remove the operation when
1025 it is finished. This reduces coupling and removes a potential deadlock
1026 when modest_mail_operation_notify_end() is called from the queue
1027 itself. If that is a problem performance-wise, I would suggest to
1028 implement a status-changed signal or something.
1030 * src/modest-mail-operation-queue.c: Make sure to never call a
1031 function from another file while the queue is locked. This (hopefully)
1032 fixes another deadlock when exiting the application while retrieving
1035 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1037 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1038 Fixed build if libogs is not available
1040 2007-06-03 Christian Kellner <ckellner@openismus.com>
1042 * libmodest-dbus-client/libmodest-dbus-client.h:
1043 * libmodest-dbus-client/libmodest-dbus-client.c:
1044 (libmodest_dbus_client_delete_message):
1045 Implement deletion of messages (Client side).
1047 (modest_search_hit_free),
1048 (modest_search_hit_list_free):
1049 Utility functions to free the result hits.
1051 * src/dbus_api/modest-dbus-api.h:
1052 * src/dbus_api/modest-dbus-callbacks.c:
1053 (on_delete_message),
1054 (modest_dbus_req_handler):
1055 Implement deletion of messages (Server side).
1057 * tests/dbus_api/test_search.c: (main):
1060 * tests/dbus_api/Makefile.am:
1061 * tests/dbus_api/test_delete_message:
1062 Add little test for the message deletion logic
1064 2007-06-03 Armin Burgmeier <armin@openismus.com>
1066 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1067 when the operation queue was not empty. projects.maemo.org bug
1070 2007-06-03 Armin Burgmeier <armin@openismus.com>
1072 * src/widgets/modest-account-view.c
1073 (on_account_default_toggled): Toggle default account column
1074 explicitely instead of waiting for gconf notification (which is
1075 currently ignored). This should fix projects.maemo.org bug NB#56910
1076 for now. It should probably be removed when gconf notifications are
1079 2007-06-03 Christian Kellner <ckellner@openismus.com>
1081 * libmodest-dbus-client/libmodest-dbus-client.c:
1082 Removed debugging spew.
1084 * src/dbus_api/modest-dbus-callbacks.c:
1085 Added debugging info.
1087 * src/modest-search.c:
1088 (modest_search_all_accounts):
1089 Use tny_account_store_get_accounts () on the account store
1090 to get all accounts which is the way to get all accounts.
1092 * tests/dbus_api/test_search.c: (main):
1093 Make it possible to supply the search term on the command line.
1095 2007-06-03 Christian Kellner <ckellner@openismus.com>
1097 * libmodest-dbus-client/libmodest-dbus-client.c:
1098 * libmodest-dbus-client/libmodest-dbus-client.h:
1099 Implement searching for mesages over raw dbus. (Client side)
1101 * src/dbus_api/Makefile.am:
1102 * src/dbus_api/modest-dbus-api.h:
1103 * src/dbus_api/modest-dbus-callbacks.c:
1104 * src/dbus_api/modest-dbus-callbacks.h:
1105 Search framework (Server side). Also implement on_idle_open_message().
1107 * src/maemo/modest-platform.c: (modest_platform_init):
1108 Prepare for raw dbus/osso rpc interaction.
1110 * src/modest-search.h:
1111 Changed minsize from unspecific guint to guint32.
1113 * src/modest-search.c:
1115 Added strange hack which magically made tnymail work.
1117 (modest_search_folder),
1118 (modest_search_account),
1119 (modest_search_all_accounts):
1120 Implement helper functions to search all accounts, specific account
1123 * tests/dbus_api/Makefile.am:
1124 * tests/dbus_api/test_open_message.c:
1125 Read url to open from commandline.
1127 * tests/dbus_api/test_search.c:
1128 Implement small test for dbus search stuff
1130 2007-06-02 Armin Burgmeier <armin@openismus.com>
1132 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1133 include account type and account title. This fixes projects.maemo.org
1136 * src/maemo/modest-account-view-window.c: Set a title for the window.
1138 2007-06-02 Armin Burgmeier <armin@openismus.com>
1140 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1141 incoming and outgoing server name based on email address and server
1142 types as long as the names have not been edited manually. This fixes
1143 projects.maemo.org bug NB#58671.
1145 2007-06-02 Armin Burgmeier <armin@openismus.com>
1147 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1148 server type cannot be changed in future to the incoming details page
1149 when creating an account. This fixes projects.maemo.org bug NB#59029.
1151 2007-06-02 Armin Burgmeier <armin@openismus.com>
1153 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1154 and assigned max width chars so that they wrap instead of being
1155 truncated. Fixes projects.maemo.org bug NB#56126.
1157 2007-06-02 Armin Burgmeier <armin@openismus.com>
1159 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1160 introductory note to the connection specific smtp servers dialog, as
1161 section 8.12 of the email UI specification requires. This fixes
1162 projects.maemo.org bug NB#59212.
1164 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1166 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1167 Check for running mail operations, and offer to cancel them, as per the UI
1168 spec. This fixes projects.maemo.org bug NB#59041 .
1169 However, I suspect that tinymail may still use the network connection
1170 in ways that we cannot detect or cancel. But it should at least adapt to
1171 changes fairly well.
1173 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1175 * src/modest-tny-account-store.c: (recreate_all_accounts),
1176 (get_cached_accounts), (get_server_accounts): Do more sensible
1177 ref-counting of the temporarily-cached outbox accounts list. This seems
1178 to fix a crash when entering the password when the password was wrong.
1180 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1182 * src/gnome/modest-main-window.c: (connect_signals):
1183 * src/modest-tny-account-store.c: (get_password),
1184 (modest_tny_account_store_alert): Added comments and clues and
1185 commented-out code about how we currently fail to deal with connection
1186 errors and wrong passwords, and how we should.
1188 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1190 * src/widgets/modest-retrieve-combo-box.c:
1191 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1192 This fixes projects.maemo.org bug NB#58472 .
1194 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1196 * src/maemo/easysetup/modest-easysetup-wizard.c:
1197 (create_page_complete_easysetup):
1198 (create_page_complete_custom): Correct the last commit,
1199 putting the correct sentences in the correct pages.
1201 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1203 * src/maemo/easysetup/modest-easysetup-wizard.c:
1204 (create_page_complete_custom): Show the second sentence of text
1205 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1208 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1210 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1211 Set the leave-on-server conf key by default. This fixes
1212 projects.maemo.org bug NB#59258 .
1214 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1216 * src/maemo/modest-account-view-window.c:
1217 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1218 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1221 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1223 * src/maemo/easysetup/modest-easysetup-wizard.c:
1224 (create_caption_new_with_asterisk):
1225 * src/maemo/modest-account-settings-dialog.c:
1226 (create_caption_new_with_asterisk):
1227 Uncomment the code to add the asterisk, because they are no longer in the
1228 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1229 (update_incoming_server_title): Add an asterisk here too.
1231 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1233 * src/maemo/modest-maemo-global-settings-dialog.c:
1234 (current_connection): Check that we are even connected before trying to
1235 get the current connection name, to prevent a warning.
1237 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1238 Change the comments because tny_maemo_conic_device_connect() is now meant to
1240 * src/modest-mail-operation.c:
1241 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1242 make sure we have a connection and fail if we can't connect.
1244 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1246 * src/maemo/modest-main-window.c:
1247 (on_account_store_connecting_finished): Do not try to get the
1248 connection ID if we are not really connected. I am surprised that
1249 this signal handler is called when we are not connected.
1251 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1253 * src/modest-error.h:
1254 * src/modest-ui-actions.c:
1255 (modest_ui_actions_get_msgs_full_error_handler):
1256 Renamed an enum, added comments, added an enum
1257 for retrieve-limit errors.
1259 * src/modest-mail-operation.c: (foreach_add_item),
1260 (internal_folder_observer_update), (update_account_thread),
1261 (modest_mail_operation_get_msgs_full):
1262 (modest_mail_operation_update_account),
1263 Added comments about how this works, and some code that should
1264 (but does not) check the retrieve-limit. See the TODO comment.
1266 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1268 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1269 Initialize help_id to fix the build. Warnings are good.
1271 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1273 * src/widgets/modest-hbox-cell-renderer.c:
1274 (modest_hbox_cell_renderer_append):
1275 * src/widgets/modest-vbox-cell-renderer.c:
1276 (modest_vbox_cell_renderer_append):
1277 Fix the last commit by doing an extra ref.
1279 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1281 * src/widgets/modest-hbox-cell-renderer.c:
1282 (modest_hbox_cell_renderer_append):
1283 * src/widgets/modest-vbox-cell-renderer.c:
1284 (modest_vbox_cell_renderer_append):
1285 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1286 to fix the build with Maemo Bora.
1287 However, there seems to be a remaining crash, probably due to reference
1290 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1292 * src/modest-tny-account.c:
1293 (modest_tny_account_new_for_local_folders):
1294 Use hildon_file_system_info_async_new() to get a better name for
1295 the memory card account, setting it as the account name.
1296 The timing seems to work, but this is probably
1297 not the best place to do this. See the TODO comment.
1298 * src/maemo/modest-main-window.c: (create_details_widget):
1299 * src/widgets/modest-folder-view.c: (text_cell_data):
1300 Use the tny account name instead of hardcoding a name.
1302 2007-05-30 Christian Kellner <ckellner@openismus.com>
1304 * src/modest-search.c: (modest_search):
1305 Correctly set part_search_func even if we have already parsed
1306 the query and thus a valid OgsTextSearcher object.
1308 2007-05-30 Christian Kellner <ckellner@openismus.com>
1311 Search and check for libogs.
1314 Incooparte the ogs build env.
1316 * src/modest-mime-part-search-stream.c:
1317 * src/modest-mime-part-search-stream.h:
1318 Removed since we do the real searching now in modest-search.c.
1320 * src/modest-search.c:
1321 * src/modest-search.h:
1322 Implement support for ogs. We use that if available and requested
1323 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1324 should now handle the corner case when the search term is spread
1325 across multiple reads.
1326 Also the logic in modest_search () was corrected to search all
1327 requested fields until one is found.
1329 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1331 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1333 * src/modest-init.h:
1334 * src/modest-init.c: Made modest_init_local_folders() take a
1335 path and be public so we can iniitialize maildir folders on
1338 * src/modest-local-folder-info.h:
1339 * src/modest-local-folder-info.c:
1340 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1342 * src/modest-tny-account.c:
1343 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1344 still means the standard local-folders path on the local volume.
1346 * src/modest-tny-account-store.c:
1347 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1348 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1349 all accounts when that happens.
1350 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1351 this too, so it shows up in the treeview.
1353 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1355 * src/maemo/modest-maemo-global-settings-dialog.c:
1356 (current_connection):
1357 * src/widgets/modest-global-settings-dialog.c:
1358 (current_connection_default):
1359 Use the enum values instead of 0, 1 and -1,
1360 to make the code clearer.
1362 * src/modest-account-mgr-helpers.c:
1363 (modest_account_mgr_get_connection_specific_smtp): Make this code
1366 * src/modest-runtime.h:
1367 * src/modest-runtime.c:
1368 Added modest_runtime_remove_all_send_queues().
1369 * src/maemo/modest-main-window.c:
1370 (on_account_store_connecting_finished): Recreate the send queues,
1371 using the appropriate transport accounts for this new connection.
1372 Some futher adapting might be needed if the old send queues are not
1373 automatically stopped at this point.
1375 * src/modest-tny-account-store.c: (get_server_accounts):
1376 Create the connection-specific transport accounts, so that they can
1377 be found later by their ID.
1379 * src/modest-tny-account.h:
1380 * src/modest-tny-account.c:
1381 Added modest_tny_account_new_from_server_account_name().
1382 modest_tny_account_new_from_server_account(): Do not create the
1383 send queues here, because they will be
1384 recreated anyway when the connection changes for the first time.
1386 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1388 * src/modest-local-folder-info.h:
1389 * src/modest-local-folder-info.c:
1390 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1391 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1392 tbox_folder): Take a modest account name instead of a server TnyAccount,
1393 so we can have per-modest-account rather than per-transport-account
1395 We must make sure that we change or recreate the exisitng send queues
1396 when the connection changes for connection-specific transport accounts.
1398 * src/modest-tny-account-store.c:
1399 (create_per_account_local_outbox_folders): Create outboxed per modest
1400 account, not per transport account.
1402 * src/modest-tny-account.h:
1403 * src/modest-tny-account.c:
1404 (modest_tny_account_get_special_folder): For outboxes, get the
1405 parent modest account name. The account is ignored for other folders.
1406 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1407 modest account name rather than a server TnyAccount.
1409 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1411 * src/modest-tny-account.c:
1412 (modest_tny_account_new_from_server_account):
1413 Call modest_runtime_get_send_queue() immediately after creating transport
1414 accounts, so that they start trying to send email from the outbox as soon
1415 as possible at startup. This is probably what we want.
1417 * src/modest-mail-operation.c: (update_account_thread):
1418 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1419 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1420 * src/modest-tny-send-queue.h:
1421 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1422 (modest_ui_actions_on_send):
1423 Added comments about how sending works, though it needs some more work.
1425 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1427 * src/modest-tny-account.c:
1428 (modest_tny_account_get_special_folder): Add TODO because this fails when
1429 the network is busy.
1430 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1431 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1432 Do not try to show this window when there is no active account. The UI
1433 specs does not tell us what to do in this case.
1435 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1439 * src/maemo/Makefile.am:
1440 * src/widgets/Makefile.am: Some dist fixes.
1442 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1444 * src/maemo/modest-connection-specific-smtp-window.c:
1445 (on_button_edit): Make the code clearer, to prevent a double free.
1447 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1449 * src/maemo/modest-account-settings-dialog.c:
1450 (modest_account_settings_dialog_set_account_name),
1451 Check the connection-specific smtp servers checkbox if there are any.
1453 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1454 (modest_connection_specific_smtp_edit_window_init):
1455 Start with a suitable port number.
1457 * src/modest-account-mgr-helpers.h:
1458 * src/modest-account-mgr-helpers.c: Added
1459 modest_account_mgr_get_has_connection_specific_smtp().
1461 (modest_account_mgr_set_connection_specific_smtp),
1462 (modest_account_mgr_remove_connection_specific_smtp),
1463 (modest_account_mgr_get_has_connection_specific_smtp),
1464 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1465 connection-specific smtp server accounts in the account, rather than
1466 the server account conf dir.
1468 This fixes bug projects.maemo.org bug NB#58263 .
1470 * src/modest-tny-account-store.c:
1471 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1472 if there are no server accounts yet, to prevent an infinite loop when there
1473 are no accounts. Document that one must be called before the other.
1475 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1477 * src/modest-account-mgr-helpers.c:
1478 (modest_account_mgr_get_default_account): Make sure that at least
1479 one account is always the default, if there are any enabled accounts.
1480 This is just a sanity check that shouldn't be necessary.
1482 * src/modest-account-mgr-priv.c:
1483 (_modest_account_mgr_account_from_key): Unescape the conf key to
1484 get the real account name. For instance, this is an issue if a space
1485 was in the account name, which can happen because the account name
1486 is generated from the display name.
1487 (_modest_account_mgr_get_account_keyname): Always escape the
1489 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1490 Unescape the conf keys to get the real account names.
1492 For instance, previously the is-default radio button in the accounts
1493 list was not checked for any accounts at first. This fixes that,
1494 and might fix several similar bugs.
1496 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1498 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1499 Removed some debug printfs.
1501 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1503 Modest on-disk outbox directories are now here, for instance:
1504 $HOME/.modest/outboxes/<account-id-1>/outbox
1505 $HOME/.modest/outboxes/<account-id-2>/outbox
1507 $HOME/.modest/local-folders/outbox
1508 so we can have a separate outbox for each account.
1509 But they are shown as one outbox in the GtkTreeView, by using a
1510 TnyMergeFolder in a ModestTnySimpleFolderStore.
1513 * src/modest-tny-simple-folder-store.c:
1514 * src/modest-tny-simple-folder-store.h:
1515 Added ModestTnySimpleFolderStore, used to contain folders from
1516 other folder stores, such as other accounts.
1518 * src/modest-tny-outbox-account.h:
1519 * src/modest-tny-outbox-account.c:
1520 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1521 used for the per-account local outbox folders.
1523 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1524 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1525 only use this (internally) now for the non-outbox local folders.
1527 * src/modest-init.h:
1528 * src/modest-init.c: Added modest_init_one_local_folder(), for
1529 setting up the directory structure for each local folder.
1531 * src/modest-local-folder-info.c:
1532 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1533 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1535 * src/modest-local-folder-info.h:
1536 * src/modest-tny-account-store.c: (on_account_removed),
1537 (on_account_changed), (create_per_account_local_outbox_folders),
1538 (get_server_accounts), (modest_tny_account_store_get_accounts),
1539 (modest_tny_account_store_get_tny_account_by_account),
1540 (modest_tny_folder_store_is_virtual_local_folders):
1542 * src/modest-tny-account.h:
1543 * src/modest-tny-account.c:
1544 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1545 to create an on-disk per-account local outbox folder for each
1547 (create_per_account_local_outbox_folders): Create a local outbox folder
1548 for each transport account.
1549 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1550 for all local folders.
1552 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1553 instead of using g_object_get/set() directly. It is clearer.
1555 (modest_tny_folder_store_get_message_count),
1556 (modest_tny_folder_store_get_local_size
1557 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1558 because we now use these with non-acount folder stores.
1560 (modest_tny_account_get_special_folder),
1561 (modest_tny_account_new_from_server_account),
1562 (modest_tny_account_new_from_account):
1563 (recurse_folders): Adjust to the new outbox system.
1565 * src/modest-tny-folder.h:
1566 * src/modest-tny-folder.c:
1567 (modest_tny_folder_is_local_folder),
1568 (modest_tny_folder_get_local_folder_type),
1569 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1571 * src/widgets/modest-main-window.h:
1572 * src/maemo/modest-main-window.c: (create_details_widget),
1573 (modest_main_window_set_contents_style): Show details for any folder store,
1576 (modest_tny_folder_get_rules):
1577 Remove the const. C does not support constness enough for this.
1579 * src/modest-ui-actions.c:
1580 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1581 make all outboxes appear as one, in the usual local-folders tree node.
1583 (set_active_account_from_tny_account),
1584 (modest_ui_actions_on_folder_selection_changed):
1585 * src/widgets/modest-folder-view.c: (text_cell_data),
1586 (icon_cell_data), (filter_row),
1587 (add_account_folders_to_merged_folder),
1588 (add_account_folders_to_simple_folder_store), (),
1589 (get_cmp_rows_type_pos), (cmp_rows),
1590 (modest_folder_view_set_account_id_of_visible_server_account):
1591 Adjust to the new outbox system, using generic folder stores and folders
1592 in the GtkTreeModel.
1594 2007-05-23 Christian Kellner <ckellner@openismus.com>
1596 * src/modest-mail-operation.c:
1597 (modest_mail_operation_update_account):
1598 Use info->max_size instead of unintialized local var [small
1599 build fix]. (Added TODO to review that change since I don't
1602 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1604 * libmodest-dbus-client/libmodest-dbus-client.c:
1605 (libmodest_dbus_client_compose_mail): function added
1606 * src/dbus_api/modest-dbus-api.h:
1607 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1608 (on_compose_mail): Implementation of the SendAsMail functionality
1610 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1612 * src/modest-account-mgr.c:
1613 (modest_account_mgr_add_server_account): Set the secure-connection
1614 conf key for transport accounts as well as store accounts. I don't know
1615 why the if was there. For instance, this makes sure that we use SSL
1616 for the gmail preset from the easysetup wizard.
1618 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1620 * src/gnome/modest-main-window.c:
1621 (on_account_store_connecting_finished), (connect_signals):
1622 * src/maemo/modest-main-window.c:
1623 (on_account_store_connecting_finished), (connect_signals),
1624 (modest_main_window_new):
1625 Handle TnyAccountStore::connecting-finished instead of
1626 TnyDevice::connection-changed, because we cannot actually perform
1627 operations on accounts until TnyAccountStore has itself responded to
1628 the TnyDevice::connection-changed signal. This prevents a GError from
1630 Do not try to update at startup, because we (at least on scratchbox)
1631 already do an update at startup when the device goes online.
1632 This prevents a GError from tinymail.
1633 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1634 Added TODO about stopping simultaneous operations.
1636 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1638 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1639 * src/modest-mail-operation-queue.c:
1640 (modest_mail_operation_queue_remove):
1641 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1642 about where they happened.
1644 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1646 * src/modest-ui-actions.c:
1647 (modest_ui_actions_on_password_requested): Make sure that the remember
1648 output parameter is always TRUE.
1650 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1652 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1653 Show a OK/Cancel dialog if the error is a question, though we still do not
1654 know anything more about what we are asking the user.
1655 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1656 Fix an uninitialized variable (helper). This is a logic error, however.
1658 2007-05-21 Christian Kellner <ckellner@openismus.com>
1660 * src/modest-search.h:
1661 Correct bit shifting in the ModestSearchFlags enum.
1663 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1665 * src/modest-tny-account.c:
1666 (modest_tny_account_new_from_server_account): Do not use the lsub and
1667 check-all hard-coded IMAP options when using POP.
1669 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1671 * src/modest-tny-account.c:
1672 (modest_tny_account_new_from_server_account):
1673 Use NULL for the secure-auth method for POP when Password auth has been
1674 specified by the user, as we already do for IMAP. "auth=Login" causes
1675 an error from camel or the server.
1677 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1679 * src/maemo/modest-account-settings-dialog.c:
1680 (create_page_account_details),
1681 (modest_account_settings_dialog_set_account_name):
1682 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1683 for the leave-on-server checkbox, rathr than just the checkbox, when
1684 the protocol is not POP.
1686 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1688 * src/widgets/modest-account-view.c:
1689 * src/widgets/modest-account-view.h:
1690 Added modest_account_view_select_account() which will be useful later
1691 to asynchronously re-select the edited account.
1693 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1695 * src/maemo/modest-account-settings-dialog.c:
1696 (modest_account_settings_dialog_set_account_name):
1697 Automatically choose the port numbers based on the secure authentication
1698 methods, if they have not been chosen before.
1699 This fixes projects.maemo.org bug NB#56273 .
1701 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1703 * src/maemo/modest-main-window-ui.h:
1704 * src/modest-ui-actions.c:
1705 * src/modest-ui-actions.h:
1706 Connect the Tools/SMTP Servers menu item to
1707 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1708 SMTP servers dialog, as in the UI specification and saves changes when it
1709 is closed. This fixed projects.maemo.org bug NB#56305 .
1711 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1713 * src/maemo/modest-connection-specific-smtp-window.c:
1714 (modest_connection_specific_smtp_window_init):
1715 Use gtk_window_set_default_size() to make this window big enough, so
1716 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1718 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1720 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1721 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1722 (modest_connection_specific_smtp_edit_window_init),
1723 Do not try to connect to a combobox signal before the combobox exists.
1724 This fixes the cras in projects.maemo.org bug NB#56288 .
1725 (modest_connection_specific_smtp_edit_window_get_settings):
1726 Remove the server_account_name parameter which was being checked for NULL
1727 though it was not used.
1729 * src/maemo/modest-connection-specific-smtp-window.c:
1730 (modest_connection_specific_smtp_window_fill_with_connections),
1731 (on_button_edit), (modest_connection_specific_smtp_window_init):
1732 Correct the number of treemodel columns to prevent a warning.
1733 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1734 libconic does not work.
1736 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1738 * src/modest-tny-account.c:
1739 (modest_tny_account_new_from_server_account):
1740 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1741 SMTP when "None" was chosen by the user. However, with my SMTP server that
1742 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1745 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1747 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1748 to explain the memory management issue with the ID in the ModestPair.
1750 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1751 (add_sending_page), (modest_account_assistant_finalize):
1752 * src/gnome/modest-gnome-global-settings-dialog.c:
1753 (create_updating_page), (create_composing_page):
1754 * src/gnome/modest-msg-edit-window.c: (get_transports),
1755 (init_window), (modest_msg_edit_window_finalize),
1756 (modest_msg_edit_window_get_msg_data):
1757 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1758 * src/gnome/modest-transport-widget.c:
1759 (modest_transport_widget_finalize), (smtp_configuration):
1760 * src/maemo/modest-maemo-global-settings-dialog.c:
1761 (create_updating_page), (create_composing_page):
1762 * src/maemo/modest-msg-edit-window.c: (get_transports),
1763 (init_window), (modest_msg_edit_window_finalize),
1764 (modest_msg_edit_window_get_msg_data),
1765 (modest_msg_edit_window_free_msg_data):
1766 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1767 (modest_store_widget_finalize):
1768 * src/maemo/modest-transport-widget.c:
1769 (modest_transport_widget_finalize), (smtp_configuration):
1770 * src/modest-main.c: (send_mail):
1771 * src/widgets/modest-combo-box.h:
1772 * src/widgets/modest-global-settings-dialog-priv.h:
1773 * src/widgets/modest-global-settings-dialog.c:
1774 (modest_global_settings_dialog_finalize):
1775 * src/widgets/modest-msg-edit-window.h:
1776 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1777 as long as the combo box, to prevent use of freed memory for the ID.
1779 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1781 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1782 get_accounts(), to make this clearer. Do not check for the enabled gconf
1783 key, because we do not use this for server accounts (at least, not yet).
1784 This allows us to send email again.
1786 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1788 * src/maemo/modest-platform.c:
1789 (on_modest_conf_update_interval_changed), (modest_platform_init):
1790 Only respond to this particular key change. All these strcmp()s cannot be
1793 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1795 * src/maemo/modest-maemo-global-settings-dialog.c:
1796 (current_connection): Prevent a crash in scratchbox when
1797 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1798 * src/maemo/modest-platform.c:
1799 (on_modest_conf_update_interval_changed), (modest_platform_init):
1800 Get the update interval from gconf and reset it when the gconf key changes.
1802 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1804 * src/modest-protocol-info.c:
1805 * src/modest-protocol-info.h: Adde enum-specific get functions,
1806 instead of using a ModestProtocolType enum parameter.
1808 * src/gnome/modest-account-assistant.c:
1809 * src/gnome/modest-store-widget.c:
1810 * src/gnome/modest-store-widget.h:
1811 * src/gnome/modest-transport-widget.c:
1812 * src/gnome/modest-transport-widget.h:
1813 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1814 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1815 * src/maemo/easysetup/modest-easysetup-wizard.c:
1816 * src/maemo/modest-account-settings-dialog.c:
1817 * src/maemo/modest-account-settings-dialog.h:
1818 * src/maemo/modest-store-widget.c:
1819 * src/maemo/modest-store-widget.h:
1820 * src/maemo/modest-transport-widget.c:
1821 * src/maemo/modest-transport-widget.h:
1822 * src/modest-account-mgr-helpers.c:
1823 * src/modest-account-mgr-helpers.h:
1824 * src/modest-account-mgr.c:
1825 * src/modest-account-mgr.h:
1826 * src/modest-tny-account.c:
1827 * src/modest-tny-folder.c:
1828 * src/widgets/modest-account-view.c:
1829 * src/widgets/modest-retrieve-combo-box.c:
1830 * src/widgets/modest-retrieve-combo-box.h:
1831 * src/widgets/modest-secureauth-combo-box.c:
1832 * src/widgets/modest-serversecurity-combo-box.c:
1833 * src/widgets/modest-serversecurity-combo-box.h:
1834 * tests/check_account-mgr.c:
1835 Use the specific functions, and use the re-renamed enum values for GNOME too.
1837 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1839 * src/modest-pair.h:
1840 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1841 so we can get the second based on the first.
1843 * src/maemo/modest-account-settings-dialog.h:
1844 * src/maemo/modest-account-settings-dialog.c:
1845 Added get_supported_secure_authentication_methods(), though it is mostly
1846 commented-out for now until the necessary API is committed to tinymail.
1847 (modest_account_settings_dialog_set_account_name),
1848 (save_configuration): Request the supported authentication methods from the
1849 server, so we can choose a working method.
1851 * src/modest-tny-account-store.h:
1852 * src/modest-tny-account-store.c:
1853 (modest_tny_account_store_get_session): Rename from
1854 tny_account_store_get_session().
1856 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1858 * src/modest-protocol-info.h: Split the ModestProtocol enum
1859 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1860 There was no need to have these unrelated values in one enum.
1862 * src/: many files: Adapted to changed enum. This makes the code a bit
1863 clearer, and the compiler could catch some errors.
1865 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1867 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1868 Show the detailed internal camel error message when an error happens
1869 during the configuration, so that our testers can give us more clues.
1870 For instance, in projects.maemo.org bug NB#56910 .
1872 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1874 * src/modest-tny-account.c:
1875 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1876 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1878 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1880 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1881 * src/maemo/modest-account-settings-dialog.c:
1882 (modest_account_settings_dialog_set_account_name),
1883 (save_configuration): For the incoming secure authentication checkbox,
1884 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1885 the UI specification. PLAIN does not seem to be supported for most IMAP
1886 servers anyway, and I am not sure what it would mean.
1887 However, we probably need to discover which of the secure-authentication
1888 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1889 * src/modest-account-mgr-helpers.c:
1890 (modest_account_mgr_get_server_account_data):
1892 * src/modest-tny-account.c:
1893 (modest_tny_account_new_from_server_account):
1894 Use tny_account_set_mech() to set secure-authentication methods,
1895 with some special-casing for IMAP, based on my observations of how
1898 * src/modest-account-mgr-helpers.h:
1899 * src/modest-account-mgr.c:
1900 * src/modest-defs.h: Comment that the URI is only used for local folders.
1902 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1904 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1905 parameter const, just to be neat.
1906 * src/modest-text-utils.c: (modest_text_utils_inline):
1907 End g_strconcat() with NULL, as its documentation says. This is almost
1908 certainly the cause of my crash at startup on the device. Interestingly,
1909 valgrind doesn't tell us about these errors.
1911 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1913 * scripts/build-packages: Added more precise comments about how to use
1914 this script, though I still get this error:
1915 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1916 error building tinymail
1918 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1920 * src/maemo/modest-main-window.c: (on_account_update):
1921 Very slight cleanup, hoping to make it simpler to discover what causes
1922 a crash here sometimes.
1924 * src/modest-tny-account.c:
1925 (modest_tny_account_new_from_server_account): Set the port. Added
1926 comments about the options and a TODO comment because I need to find out
1927 how to specify the secure authentication method.
1929 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1931 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1932 changed CFlags paths form modest to libmodest
1934 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1936 * src/modest-account-mgr-helpers.c:
1937 (modest_account_mgr_get_server_account_data),
1938 (modest_account_mgr_free_server_account_data):
1939 * src/modest-account-mgr-helpers.h:
1940 * src/modest-account-mgr.c:
1941 (modest_account_mgr_add_server_account):
1942 * src/modest-defs.h:
1943 * src/modest-tny-account.c:
1944 (modest_tny_account_new_from_server_account):
1945 Determine the options for tny_camel_account_add_option() here,
1946 based on the settings, rather than storing them directly in gconf.
1948 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1950 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1951 Show a more friendly error dialog now that we expect (from the tinymail
1952 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1954 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1956 * src/maemo/modest-main-window.c: (on_account_update): Check that
1957 account_name is not NULL, to prevent a crash at startup that I am
1958 seeing on the N800. I do wonder why it is NULL.
1960 * src/maemo/easysetup/modest-easysetup-wizard.c:
1961 (create_page_user_details):
1962 * src/maemo/modest-account-settings-dialog.c:
1963 (create_page_user_details), (create_page_outgoing):
1964 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1965 (modest_connection_specific_smtp_edit_window_init):
1966 * src/modest-ui-actions.c:
1967 (modest_ui_actions_on_password_requested):
1968 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1969 might do something useful with the on-screen keyboard.
1971 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1973 * src/maemo/modest-main-window.c: (on_account_update):
1974 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1975 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1977 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1979 * src/modest-tny-account-store.c: (on_account_changed):
1980 Correct the signature of this signal handler.
1982 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1984 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1985 Show a HildonNote instead of a GtkDialog for Maemo.
1987 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1989 * src/widgets/modest-account-view.h:
1990 * src/widgets/modest-account-view.c: (on_account_changed),
1991 (on_account_removed). Added a boolean flag, set/unset by
1992 modest_account_view_block_conf_updates(),
1993 modest_account_view_unblock_conf_updates() to prevent unnecessary
1994 updates, but this is not very useful because the gconf notifications are
1995 so delays (maybe only on Maemo Bora).
1996 So auto-updating is turned off, and these functions do an explicit
1997 update when necessary.
1998 However, something else is still doing too much work when adding/removing
1999 accounts, probably in another part of the application.
2001 * src/maemo/modest-account-view-window.c:
2002 (on_delete_button_clicked), (on_edit_button_clicked),
2003 (on_new_button_clicked): Use the new functions.
2005 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2007 * src/modest-account-mgr-helpers.c:
2008 (modest_account_mgr_set_first_account_as_default):
2009 Sort the list of names alphabetically-by-title, so we choose the first one
2011 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2012 alphabetically by the title.
2014 This fixes projects.maemo.org bug NB#56418 .
2016 * src/modest-account-mgr-priv.c:
2017 (_modest_account_mgr_account_from_key):
2018 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2019 avoid a valgrind error, and possible random behaviour.
2021 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2023 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2024 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2025 tinymail documentation to say that this can be expected.
2026 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2027 pretty, and should not happen, but I would prefer to know when it does.
2029 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2031 * configure.ac: When using the older hildon version, probably on Bora,
2032 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2034 * src/widgets/modest-attachment-view.c:
2035 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2038 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2040 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2041 Implemented the prototype. Can be tested with
2042 tests/dbus_api/test_open_message:
2044 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2046 * src/modest-tny-account-store.c:
2047 (modest_tny_account_store_instance_init), (get_password):
2048 * src/modest-ui-actions.c:
2049 (modest_ui_actions_on_password_requested):
2050 Do not store the password in gconf, because this function is called
2051 for non-remembered passwords. Actually use the cached (in the hash map)
2052 password instead of releasing it.
2053 The password will now not be remembered if it is asked via the protected
2054 password dialog, as per the UI spec.
2056 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2058 * src/modest-defs.h:
2059 * src/modest-account-mgr-helpers.h:
2060 * src/modest-account-mgr-helpers.c:
2061 Added modest_server_account_get_username_has_succeeded(),
2062 modest_server_account_set_username_has_succeeded().
2063 (modest_server_account_set_username),
2064 Reset the has-succeeded flag if the username changes.
2066 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2067 * src/maemo/modest-connection-specific-smtp-window.c:
2068 (modest_connection_specific_smtp_window_save_server_accounts):
2069 Use modest_server_account_set_username() instead of using
2070 modest_conf_set_string() directly, so that the has-succeeded flag is always
2073 * src/modest-ui-actions.c:
2074 (modest_ui_actions_on_password_requested): Dim the username entry if
2075 the username has ever worked, as per the UI spec.
2077 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2079 * src/modest-tny-account-store.c: (get_password):
2080 * src/modest-ui-actions.c:
2081 (modest_ui_actions_on_password_requested):
2082 Allow the username to be changed too, though there is more work to
2083 be done on exactly how this behaves.
2085 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2087 * src/modest-account-mgr-helpers.h:
2088 * src/modest-account-mgr-helpers.c:
2089 Added modest_account_mgr_get_display_name(),
2090 modest_server_account_get_username(),
2091 modest_server_account_set_username(),
2092 modest_server_account_set_password(),
2093 modest_server_account_get_hostname() functions so we do not need to
2094 use the conf API directly.
2096 * src/maemo/modest-main-window.c: (connect_signals):
2097 Actually connect ot the ModestAccountStore::request-password signal,
2098 so that we show the dialog when the password is requested by Tinymail,
2099 for isntance if it is empty.
2101 * src/modest-marshal.list:
2102 * src/modest-tny-account-store.c:
2103 (modest_tny_account_store_class_init), (get_password),
2104 (modest_tny_account_store_alert):
2105 * src/modest-tny-account-store.h:
2106 * src/modest-ui-actions.h:
2107 * src/modest-ui-actions.c:
2108 (modest_ui_actions_on_password_requested):
2109 Change the signal parameters, so it is obvious that we are providing
2110 the non human-readable server name, and receiving both the username
2111 and password, though changing of the username is not yet implemented.
2112 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2113 for the GNOME version.
2115 This should fix the projects.maemo.org bug NB#56209, though it does not
2116 work on Bora, because the gconf_client_get() for the password fails
2117 immediately after we save it with gconf_client_set().
2119 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2122 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2123 caused an undefined symbol error:
2124 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2126 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2128 * src/modest-tny-account-store.c:
2129 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2130 using a GError instead of a string message, so we can translate it in
2133 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2135 * src/maemo/modest-address-book.c:
2136 (modest_address_book_check_names):
2137 * src/maemo/modest-msg-view-window.c:
2138 (modest_msg_view_window_clipboard_owner_change):
2139 * src/modest-init.c: (modest_init_init_ui):
2140 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2141 (update_folders_cb), (modest_mail_operation_update_account):
2142 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2143 (modest_ui_actions_on_msg_attachment_clicked),
2144 (modest_ui_actions_on_msg_recpt_activated):
2145 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2146 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2147 (modest_msg_view_search_next):
2148 * src/widgets/modest-recpt-editor.c:
2149 (modest_recpt_editor_on_button_release_event),
2150 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2151 g_message(). At this point we should only be seeing interesting errors on
2152 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2154 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2156 (modest_wizard_dialog_force_title_update):
2157 * src/maemo/easysetup/modest-wizard-dialog.h:
2158 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2159 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2160 can update the title when appropriate. Otherwise the title is wrong if the
2161 pages are added after adding the notebook to the dialog.
2162 This must be a problem in HildonWizardDialog too.
2163 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2165 * src/maemo/easysetup/modest-easysetup-wizard.c:
2166 (create_subsequent_customsetup_pages),
2167 (create_subsequent_easysetup_pages):
2168 Call modest_wizard_dialog_force_title_update() so that the title is
2169 correct even with GTK+ < 2.10.
2170 This fixes projects.maemo.org bug NB#56145 .
2172 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2174 * src/maemo/modest-platform.c:
2175 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2176 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2179 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2181 * src/widgets/modest-window.h:
2182 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2183 and modest_window_save_state(), which invokes it.
2185 * src/widgets/modest-window-mgr.h:
2186 * src/widgets/modest-window-mgr.c:
2187 Added modest_window_mgr_save_state_for_all_windows(), which calls
2188 the save_state vfunc on all registered windows, if implemented.
2190 * src/gnome/modest-msg-edit-window.c:
2191 * src/gnome/modest-msg-view-window.c:
2192 * src/maemo/modest-msg-edit-window.c:
2193 * src/maemo/modest-msg-view-window.c:
2194 * src/maemo/modest-main-window.c:
2195 Specify the existing save_settings functions as implementations of
2196 ModestWindow::save_state_func().
2198 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2199 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2200 enabling hibernation, for instance.
2202 We may need to do the same thing for restoring settings.
2205 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2207 * src/widgets/modest-window-mgr.c:
2208 * src/widgets/modest-window-mgr.h:
2209 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2210 modest_window_mgr_get_hibernation_is_prevented().
2212 * src/maemo/modest-main-window.c:
2213 (on_hildon_program_is_topmost_notify): Prevent hibernation
2214 (possible when the application goes to the background in the WM),
2215 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2217 * src/maemo/easysetup/modest-easysetup-wizard.c:
2218 (modest_easysetup_wizard_dialog_init):
2219 * src/maemo/modest-account-settings-dialog.c:
2220 (modest_account_settings_dialog_init):
2221 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2222 (modest_connection_specific_smtp_edit_window_init):
2223 * src/maemo/modest-connection-specific-smtp-window.c:
2224 (modest_connection_specific_smtp_window_init):
2225 * src/maemo/modest-signature-editor-dialog.c:
2226 (modest_signature_editor_dialog_init):
2227 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2228 prevent hibernation while any of these account settings dialogs are open.
2230 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2232 * src/maemo/Makefile.am:
2233 * src/maemo/modest-osso-state-saving.c:
2234 * src/maemo/modest-osso-state-saving.h: Added
2235 modest_osso_load_state() and modest_osso_save_state() though they do
2236 nothing now. They should iterate through all the open windows and load/save
2238 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2239 save state when closing.
2241 * src/maemo/modest-main-window.c:
2242 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2243 Add a notification handler for the HildonProgram::is-topmost property,
2244 so we can allow hibernation when the application goes into the background.
2245 But we still need to detect when the accounts setup windows are open so
2246 we can stop hibernation when they are open.
2247 To do this, I also added the main window the HildonProgram. This might have
2248 other side-effects/benefits, and should maybe be done for other windows.
2250 * src/maemo/modest-osso-autosave-callbacks.h:
2251 * src/maemo/modest-osso-autosave-callbacks.c:
2252 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2253 though it does not do anything yet, and we might never need this to do
2254 anything. For instance, we already save drafts.
2256 * src/maemo/modest-platform.c: (modest_platform_init):
2257 Specify the libosso auto-save callback.
2259 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2261 * src/maemo/modest-platform.c:
2262 (modest_platform_set_update_interval):
2263 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2264 aparently stays valid between application instances, so we can use this
2265 to remove and reset it later. According to a maemo-developers email from
2268 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2270 * configure.ac: Depend on libalarm for Maemo.
2272 * src/dbus_api/modest-dbus-api.h:
2273 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2274 (on_send_receive), (modest_dbus_req_handler):
2275 Handle a SEND_RECEIVE D-Bus method.
2277 * libmodest-dbus-client/libmodest-dbus-client.c:
2278 (libmodest_dbus_client_send_and_receive):
2279 * libmodest-dbus-client/libmodest-dbus-client.h:
2280 Add C convenience functions for calling the new D-Bus method.
2282 * src/modest-platform.h:
2283 * src/gnome/modest-platform.c:
2284 * src/maemo/modest-platform.c:
2285 Added modest_platform_set_update_interval(), which uses the
2286 alarmd API on Maemo.
2287 (modest_platform_init),
2288 Call modest_platform_set_update_interval(), using a hard-coded
2289 interval for now (until the global settings dialog is implemented),
2290 though I am not sure that this makes sense yet.
2292 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2294 * src/dbus_api/modest-dbus-callbacks.c:
2295 (modest_osso_cb_hw_state_handler):
2296 * src/dbus_api/modest-dbus-callbacks.h:
2297 * src/maemo/modest-platform.c: (modest_platform_init):
2298 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2299 in case this has some effect on the ability for Maemo to ping the
2302 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2304 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2305 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2306 warning. It is probably a logic error, but I need to fix the build.
2308 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2310 * src/modest-account-mgr.h:
2311 * src/modest-account-mgr.c:
2312 (modest_account_mgr_account_names): Add a gboolean enabled_only
2313 parameter, so we can get lists of onlt the enabled accounts.
2315 (modest_account_mgr_add_account),,
2316 (modest_account_mgr_account_with_display_name_exists):
2317 * src/maemo/modest-msg-edit-window.c: (get_transports):
2318 * src/modest-account-mgr-helpers.c:
2319 (modest_account_mgr_set_first_account_as_default):
2320 * src/modest-init.c: (init_default_account_maybe):
2321 * src/modest-tny-account-store.c: (get_accounts):
2322 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2323 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2324 * tests/check_account-mgr.c: (START_TEST):
2325 Provide the extra parameter, as appropriate.
2327 * src/widgets/modest-account-view.c: (update_account_view):
2328 Do not show disabled accounts (meaning that there is no way to
2329 enable/disable accounts in the UI (the feature is not in our UI
2330 specification), so we can use this internally only to mark unfinished
2331 or temporary account data.
2333 * src/maemo/easysetup/modest-easysetup-wizard.c:
2334 (create_account): Add boolean enable parameter, so we can specify FALSE
2335 to create the temporary account.
2336 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2337 (on_before_next): When finishing, when there is a temporary account, just
2339 Also, use a timeout to delay the showing of the dialog until gconf is likely
2340 to return correct information, due to a maemo gconf bug that is fixed in
2341 osso 1.1, but not yet in Bora.
2342 However, the dialog stays on screen after it is destroyed.
2344 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2345 for invalid data when cancelling. Use a hildon note instead of a dialog
2346 to complain about invalid data. Do not show the account-saved note if the
2347 account is disabled (a temporary account that will not really be saved for use
2350 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2352 * src/modest-account-mgr-helpers.h:
2353 * src/modest-account-mgr-helpers.c:
2354 Added modest_account_mgr_unset_default_account(),
2355 Added modest_account_mgr_set_first_account_as_default().
2357 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2358 If it was the default account, unset the default account name.
2360 * src/maemo/modest-account-view-window.c:
2361 (on_delete_button_clicked): If it was the default account,
2362 set the first remaining account as the default instead.
2364 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2365 a NULL account or a NULL default account, to prevent a crash. This should
2366 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2369 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2371 * src/widgets/modest-recpt-editor.c:
2372 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2373 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2374 TODO comment for this. This fixes the build.
2376 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2377 be the best place for it. This will in future update all auto-update accounts,
2378 rather than just the current/default account, when that gconf key exists.
2379 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2380 if there are no accounts, before calling do_send_receive().
2381 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2383 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2384 * src/maemo/modest-main-window-ui.h:
2385 * src/maemo/modest-main-window.c: (on_connection_changed),
2386 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2387 directly, becaue the signal handler does more.
2389 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2391 * src/modest-account-mgr-helpers.c:
2392 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2393 for the case that the account does not exist.
2395 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2396 (equivalent to the modest account name) rather than the tinymail account name
2397 (equivalent to the modest account title - human readable) to get the account data.
2398 Check for null account data to prevent the crash, and add a TODO comment saying that
2399 this needs fixing because it is using the server account name instead of the account name.
2401 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2403 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2404 * src/maemo/modest-account-settings-dialog.c: (show_error),
2406 Use hildon_note_new_information() for informative and error messages,
2407 which seems to be expected for Maemo applications (no documentation that I know of
2408 says this). I am surprised that there is no distinction between info and error
2411 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2413 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2414 it is easy to find where this is used.
2416 * src/maemo/easysetup/modest-easysetup-wizard.c:
2417 (create_page_welcome), (create_page_account_details),
2418 (create_page_user_details), (create_page_complete_easysetup),
2419 (create_page_custom_incoming), (create_page_custom_outgoing),
2420 (create_page_complete_custom):
2421 * src/maemo/modest-account-settings-dialog.c:
2422 (create_page_account_details), (create_page_user_details),
2423 (create_page_incoming), (create_page_outgoing):
2424 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2425 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2426 (modest_connection_specific_smtp_edit_window_init):
2427 * src/maemo/modest-connection-specific-smtp-window.c:
2428 (modest_connection_specific_smtp_window_init):
2429 * src/maemo/modest-signature-editor-dialog.c:
2430 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2431 and scrolling policy as per the Email Application Layout Guide, if I have
2434 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2436 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2437 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2438 which were empty, because these vfuncs have been removed from TnyAccountStore.
2439 This fixes the build.
2441 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2443 * src/maemo/modest-main-window.c:
2444 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2445 showing/hiding it. Added TODO because it probably should not be NULL.
2446 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2447 because unnecessary g_warnings() make degugging difficult.
2449 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2451 * src/maemo/modest-msg-edit-window.c:
2452 (modest_msg_edit_window_select_color),
2453 (modest_msg_edit_window_select_background_color): 2 const corrections and
2454 moving 2 #endifs before closing brackets, to fix the build.
2456 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2458 * src/maemo/easysetup/modest-easysetup-wizard.h:
2459 * src/maemo/easysetup/modest-easysetup-wizard.c:
2460 (modest_easysetup_wizard_dialog_finalize),
2461 (on_button_edit_advanced_settings), (create_page_complete_custom),
2462 (on_response), (create_account):
2463 Implement the Advanced Settings edit button, by saving the account information,
2464 for the Advanded Settings dialog to use directly from gconf, and removing it
2465 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2466 Bug #5533 in the projects.maemo.org bugzilla.
2468 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2470 * src/maemo/modest-msg-view-window.c:
2471 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2472 when opening a message window.
2474 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2476 * src/maemo/easysetup/modest-easysetup-wizard.c:
2477 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2480 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2481 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2482 gconf settings. I probably added more checks than necessary, but that is safer.
2484 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2485 variable to fix the build, but this seems to be used when it is still NULL.
2487 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2489 * src/modest-platform.h:
2490 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2491 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2492 * src/modest-main.c: Implement this function so we can avoid using
2493 maemo-specific API from cross-platform code.
2495 * src/modest-tny-account-store.c:
2496 (get_smtp_specific_transport_account_for_open_connection):
2497 * src/modest-ui-actions.c: (check_for_connection),
2498 (modest_ui_actions_on_item_not_found):
2499 Use modest_platform_connect_and_wait() and put #idefs around other
2500 maemo-specific code, because only maemo currently has a way to
2501 identify connection names.
2503 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2505 * src/modest-tny-account-store.h:
2506 * src/modest-tny-account-store.c:
2507 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2508 the connection-specific SMTP server settings in the configuration.
2510 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2512 * src/maemo/modest-main-window.c: (on_connection_changed),
2514 * src/modest-main.c: (main), (start_ui), (send_mail):
2515 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2516 that is what is intended.
2518 * src/modest-ui-actions.c: (action_send), (action_receive),
2519 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2520 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2521 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2522 SMTP server is used when it is specified.
2524 (modest_ui_actions_on_send_receive):
2525 Check that a connection is open before proceeding.
2526 Receive and then send, instead of vice-versa, as per the specification.
2528 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2530 * src/modest-mail-operation.c:
2531 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2532 though I guess it should be something other than NULL.
2534 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2536 * src/maemo/easysetup/modest-easysetup-wizard.c:
2537 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2538 combo twice, to avoid an g_warning and to make it visible again.
2539 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2540 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2541 (already intended) dereference when detaching, because we then recreate the menu.
2542 But I am not sure why the warning was happening, and it is possible that this is a memory
2545 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2547 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2548 and uri_parse_mailto() utility functions.
2549 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2551 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2553 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2555 * src/dbus_api/modest-dbus-api.h:
2556 * src/dbus_api/modest-dbus-callbacks.c:
2557 Use an idle callback to execute the modest code in the application's own thread.
2558 Remove the helloworld example method.
2559 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2560 parsed, and the open-message method is not implemented because this is not yet implemented in
2562 * libmodest-dbus-client/libmodest-dbus-client.c:
2563 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2564 (libmodest_dbus_client_open_message):
2565 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2567 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2568 body without crashing.
2570 * tests/dbus_api/Makefile.am:
2571 * tests/dbus_api/test_mail_to.c:
2572 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2574 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2576 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2577 Added file to fix the build. Sorry.
2579 * src/dbus_api/Makefile.am:
2580 * src/dbus_api/modest-dbus-api.h:
2581 * src/dbus_api/modest-dbus-callbacks.h:
2582 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2583 (modest_dbus_req_handler):
2584 Put constants in a separate header so it can be reused by the
2585 client library, without duplication
2587 * libmodest-dbus-client/Makefile.am:
2588 * libmodest-dbus-client/libmodest-dbus-client.c:
2589 (libmodest_dbus_client_call_helloworld),
2590 (libmodfest_dbus_client_send_mail),
2591 (libmodfest_dbus_client_mailto),
2592 (libmodfest_dbus_client_open_message):
2593 * libmodest-dbus-client/libmodest-dbus-client.h:
2594 (Partly) Implement a send_mail D-Bus method.
2596 * tests/dbus_api/Makefile.am:
2597 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2598 the send_email D-Bus method.
2600 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2604 * libmodest-dbus-client/Makefile.am:
2605 * libmodest-dbus-client/libmodest-dbus-client.c:
2606 * libmodest-dbus-client/libmodest-dbus-client.h:
2607 * tests/dbus_api/Makefile.am:
2608 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2609 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2611 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2613 * src/maemo/easysetup/modest-easysetup-wizard.c:
2614 (create_page_account_details):
2615 * src/maemo/modest-account-settings-dialog.c:
2616 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2617 widgets, because this might not be the default in future versions of the Maemo GTK+.
2618 However, I can not not get capitalization to work even in a simple test case.
2620 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2622 * src/maemo/easysetup/modest-easysetup-wizard.c:
2623 (create_page_custom_incoming), (create_page_custom_outgoing):
2624 * src/maemo/modest-account-settings-dialog.c:
2625 (create_page_account_details), (create_page_incoming),
2626 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2627 instead of using gtk_check_button_with_label(), so they are aligned like the other
2628 widgets, as per the UI spec.
2630 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2632 * src/maemo/easysetup/modest-easysetup-wizard.c:
2633 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2634 * src/widgets/modest-validating-entry.c:
2635 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2636 Modest prefix instead of an EasySetup prefix.
2638 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2640 * src/widgets/modest-validating-entry.h:
2641 * src/widgets/modest-validating-entry.c: (on_insert_text),
2642 Added easysetup_validating_entry_set_max_func(), used to set a callback
2643 to call when the max number of characters is reached. GtkEntry has a max-length
2644 already but is silent about it.
2646 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2647 (create_page_account_details), (create_page_user_details),
2649 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2650 (create_page_account_details), (create_page_user_details),
2651 (create_page_outgoing):
2652 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2653 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2654 the UI spec, when the user tries to enter more than the max number of characters.
2656 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2658 * src/maemo/easysetup/modest-easysetup-wizard.c:
2659 (create_page_user_details), (create_page_custom_incoming),
2660 (create_page_custom_outgoing):
2661 * src/maemo/modest-account-settings-dialog.c:
2662 (create_page_user_details), (create_page_incoming),
2663 (create_page_outgoing):
2664 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2665 (modest_connection_specific_smtp_edit_window_init):
2666 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2667 not appropriate. Bad Maemo-specific defaults!.
2669 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2671 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2672 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2673 (modest_signature_editor_dialog_set_settings):
2674 Disable the label and textview when the checkbox is disabled, and use the
2675 specified (UI spec) default signature text.
2677 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2679 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2680 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2682 * src/modest-defs.h:
2683 * src/modest-account-mgr-helpers.h:
2684 * src/modest-account-mgr-helpers.c:
2685 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2687 * src/maemo/Makefile.am:
2688 * src/maemo/modest-signature-editor-dialog.c:
2689 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2692 * src/maemo/modest-account-settings-dialog.h:
2693 * src/maemo/modest-account-settings-dialog.c:
2694 (modest_account_settings_dialog_finalize), (on_button_signature),
2695 (save_configuration): Use the new dialog when the Edit button is pressed, and
2696 save the changes if necessary, as per the UI spec.
2698 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2700 * src/maemo/Makefile.am:
2701 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2702 based on maemo-develoers email from Dirk.
2704 * src/maemo/easysetup/modest-easysetup-wizard.c:
2705 (create_page_welcome), (create_page_account_details),
2706 (create_page_user_details), (create_page_complete_easysetup),
2707 (create_page_custom_incoming), (create_page_custom_outgoing),
2708 (create_page_complete_custom),
2709 (modest_easysetup_wizard_dialog_init):
2710 * src/maemo/modest-account-settings-dialog.c:
2711 (create_page_account_details), (create_page_user_details),
2712 (create_page_incoming), (create_page_outgoing),
2713 (modest_account_settings_dialog_init):
2714 * src/maemo/modest-connection-specific-smtp-window.c:
2715 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2717 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2719 * src/maemo/easysetup/modest-easysetup-wizard.c:
2720 (create_page_account_details), (create_page_custom_outgoing),
2721 (create_page_complete_custom):
2722 * src/maemo/modest-account-settings-dialog.c:
2723 (create_page_user_details), (create_page_incoming),
2724 (create_page_outgoing):
2725 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2726 (modest_connection_specific_smtp_edit_window_init):
2727 Use the correct (UI spec) port min/max, and use horizontal separators,
2730 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2732 * src/maemo/easysetup/modest-easysetup-wizard.c:
2733 (set_default_custom_servernames):
2734 * src/maemo/modest-account-settings-dialog.c:
2735 (create_page_incoming), (on_combo_outgoing_security_changed),
2736 (on_combo_incoming_security_changed), (create_page_outgoing),
2737 (modest_account_settings_dialog_set_account_name),
2738 (save_configuration):
2739 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2740 (on_combo_security_changed),
2741 (modest_connection_specific_smtp_edit_window_init),
2742 (modest_connection_specific_smtp_edit_window_set_connection),
2743 (modest_connection_specific_smtp_edit_window_get_settings):
2744 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2747 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2750 * src/maemo/easysetup/modest-easysetup-wizard.c:
2751 (create_page_custom_outgoing), (create_page_complete_custom):
2752 * src/maemo/modest-account-settings-dialog.c:
2753 (create_page_user_details), (create_page_outgoing):
2754 * src/maemo/modest-account-view-window.c: (button_box_new):
2755 Use changed logical IDs as per the most recent UI spec:
2756 mcen_bd_emailsetup_edit -> mcen_bd_edit
2757 mcen_bd_emailsetup_delete -> mcen_bd_delete
2758 mcen_bd_emailsetup_close -> mcen_bd_close
2760 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2764 * src/dbus_api/Makefile.am:
2765 * src/dbus_api/modest-dbus-callbacks.c:
2766 * src/dbus_api/modest-dbus-callbacks.h:
2767 * src/maemo/modest-platform.c: (modest_platform_init):
2768 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2770 * tests/Makefile.am:
2771 * tests/dbus_api/Makefile.am:
2772 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2774 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2776 * src/maemo/modest-account-settings-dialog.c:
2777 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2778 Removed unnecessary includes.
2780 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2782 * src/maemo/easysetup/modest-easysetup-wizard.c:
2783 * src/maemo/modest-account-settings-dialog.c:
2784 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2785 * src/widgets/Makefile.am:
2786 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2787 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2788 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2789 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2790 * src/widgets/modest-secureauth-combo-box.c:
2791 * src/widgets/modest-secureauth-combo-box.h:
2792 * src/widgets/modest-serversecurity-combo-box.c:
2793 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2794 made the GObject names more consistent with the rest of the Modest code.
2796 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2798 * src/maemo/easysetup/Makefile.am:
2799 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2800 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2801 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2802 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2803 * src/maemo/easysetup/modest-easysetup-wizard.c:
2804 * src/maemo/easysetup/modest-validating-entry.c:
2805 * src/maemo/easysetup/modest-validating-entry.h:
2806 * src/maemo/modest-account-settings-dialog.c:
2807 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2808 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2809 widgets/ because they are used outside of easysetup too. After checking in,
2810 svn will allow me to rename them too.
2812 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2814 * src/gnome/modest-msg-edit-window.c:
2815 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2816 linker error, to fix the build on the GNOME platform.
2817 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2818 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2819 ifdefed out to avoid a warning.
2821 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2823 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2824 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2825 some alternative for GTK+ 2.6.
2827 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2829 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2831 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2832 specified for EmailAccountsDialog in UI spec.
2834 * src/maemo/easysetup/modest-easysetup-wizard.c:
2835 * src/maemo/easysetup/modest-easysetup-wizard.h:
2836 * src/maemo/modest-account-settings-dialog.c:
2837 * src/maemo/modest-account-settings-dialog.h:
2838 Reuse a member window widget for the connection-specific SMTP server accounts,
2839 so we can tell it to create/save the accounts only if we actually save changes.
2841 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2842 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2843 (modest_connection_specific_smtp_edit_window_get_settings):
2844 Return a struct instance for temporarily remembering the entered data.
2846 * src/maemo/modest-connection-specific-smtp-window.h:
2847 * src/maemo/modest-connection-specific-smtp-window.c:
2848 (modest_connection_specific_smtp_window_finalize),
2849 (modest_connection_specific_smtp_window_fill_with_connections),
2851 (modest_connection_specific_smtp_window_save_server_accounts),
2852 (update_model_server_names): Do not actually save data until asked,
2853 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2855 (on_selection_changed),
2856 (modest_connection_specific_smtp_window_init): Disable the edit
2857 button when nothing is selected.
2859 * src/modest-account-mgr-helpers.c:
2860 * src/modest-account-mgr-helpers.h:
2861 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2864 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2866 * src/modest-account-mgr-helpers.h:
2867 * src/modest-account-mgr-helpers.c:
2868 (modest_account_mgr_get_unused_account_name),
2869 (modest_account_mgr_get_unused_account_display_name): Added these
2870 utility functions, to avoid code duplication.
2872 * src/maemo/easysetup/modest-easysetup-wizard.c:
2873 (create_page_account_details), (create_account):
2874 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2875 (on_combo_security_changed),
2876 (modest_connection_specific_smtp_edit_window_init),
2877 (modest_connection_specific_smtp_edit_window_save_settings):
2878 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2879 * src/maemo/modest-connection-specific-smtp-window.c:
2880 (modest_connection_specific_smtp_window_finalize),
2881 (modest_connection_specific_smtp_window_fill_with_connections),
2882 (on_button_edit), (modest_connection_specific_smtp_window_init):
2883 * src/maemo/modest-connection-specific-smtp-window.h:
2884 Implementing saving of connection-specific server accounts.
2886 But I need to refactor this so we can save the data for each
2887 possible connection-specific account and only actually create the server accounts
2888 when the easysetup finished, or the OK button is pressed on the account settings
2891 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2893 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2894 (on_combo_security_changed):
2895 (modest_connection_specific_smtp_edit_window_init):
2896 Auto-fill the port number as in the account settings.
2898 (modest_connection_specific_smtp_edit_window_set_connection):
2899 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2900 * src/maemo/modest-connection-specific-smtp-window.c:
2901 (fill_with_connections), (on_button_edit),
2902 (modest_connection_specific_smtp_window_init):
2903 Turn the edit window into a dialog to simplify the code, and
2904 set a WM hint as in a GtkDialog, because only a popup can be on top of
2905 another window in Maemo, and popups usually have no WM decoration.
2907 * src/modest-defs.h:
2908 * src/modest-account-mgr-helpers.c:
2909 (modest_account_mgr_set_connection_specific_smtp),
2910 (modest_account_mgr_remove_connection_specific_smtp),
2911 (modest_account_mgr_get_connection_specific_smtp):
2912 * src/modest-account-mgr-helpers.h: Some functions to write the
2913 connection-specific SMTP server information. Not yet used.
2916 * src/widgets/modest-folder-view.c: (text_cell_data):
2917 Fix a warning about an uninitialized variable.
2918 (on_configuration_key_changed): Put an #ifdef around the use
2919 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2921 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2923 * src/maemo/modest-account-settings-dialog.h:
2924 * src/maemo/modest-account-settings-dialog.c:
2925 Added connect_for_modified() utility function to mark the new modified boolean.
2927 (create_page_account_details), (create_page_user_details),
2928 (create_page_incoming), (create_page_outgoing), (on_response),
2929 (modest_account_settings_dialog_init),
2930 (modest_account_settings_dialog_set_account_name):
2931 Only warn about unsaved changes when there are actually unsaved changes.
2933 * src/modest-account-mgr-helpers.c:
2934 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2935 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2936 to get the data from there in future.
2938 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2940 * src/modest-defs.h:
2942 * src/modest-account-mgr-helpers.h:
2943 * src/modest-account-mgr-helpers.c:
2944 Store the security account setting in a single conf key instead of using
2945 the options list, so that the list is left for just the to-be-removed camel hack,
2946 and because gconf_client_set_list() is failing for some reason.
2948 * src/modest-account-mgr.c:
2949 (modest_account_mgr_add_server_account):
2950 * src/maemo/modest-account-settings-dialog.c:
2951 (modest_account_settings_dialog_set_account_name),
2952 (save_configuration): Use the renamed functions.
2955 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2957 * src/widgets/Makefile.am:
2958 * src/widgets/modest-limit-retrieve-combo-box.c:
2959 * src/widgets/modest-limit-retrieve-combo-box.h:
2960 * src/widgets/modest-retrieve-combo-box.c:
2961 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2962 the account settings dialog.
2964 * src/modest-defs.h:
2965 * src/modest-account-mgr-helpers.h:
2966 * src/modest-account-mgr-helpers.c:
2967 (modest_server_account_get_option_secure_auth),
2968 (modest_server_account_set_option_secure_auth):
2969 * src/modest-account-mgr.c:
2970 (modest_account_mgr_add_server_account):
2971 Use the existing AUTH_MECH conf key for the secure-auth setting,
2972 instead of putting it in the list options, because this was actually used already.
2974 * src/maemo/modest-account-settings-dialog.c:
2975 (create_page_account_details),
2976 (modest_account_settings_dialog_set_account_name),
2977 (save_configuration):
2978 * src/maemo/modest-account-settings-dialog.h:
2979 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2980 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2982 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2984 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2985 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2986 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2988 * src/modest-defs.h:
2989 * src/maemo/modest-account-settings-dialog.c:
2990 (create_page_incoming), (on_combo_outgoing_security_changed),
2991 (on_combo_incoming_security_changed), (create_page_outgoing),
2992 (modest_account_settings_dialog_set_account_name),
2993 (save_configuration): Load/Save the port number, and change it when the
2994 security combo changes, to suitable defaults.
2996 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2998 * src/modest-account-mgr.c:
2999 (modest_account_mgr_add_server_account): Set the security and secure-auth
3000 options, and add a comment saying that the other camel-specific options should be
3003 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3005 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3007 * src/modest-tny-account-store.c: (account_list_free),
3008 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3009 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3012 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3014 * src/modest-protocol-info.c:
3015 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3016 is required by our UI spec. Maybe something in our implementation will use this eventually.
3017 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3018 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3019 instead of the previous 0 placeholder.
3021 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3022 secure-auth settings.
3023 * src/modest-account-mgr-helpers.h:
3024 * src/modest-account-mgr-helpers.c:
3025 (modest_server_account_data_get_option_secure_auth),
3026 (modest_server_account_set_option_secure_auth),
3027 (modest_server_account_data_get_option_security),
3028 (modest_server_account_set_option_security): Added this API for getting and setting the security
3029 and secure-auth settings.
3031 * src/maemo/modest-account-settings-dialog.h:
3032 * src/maemo/modest-account-settings-dialog.c:
3033 (modest_account_settings_dialog_finalize), (check_data),
3034 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3035 about changing titles.
3036 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3037 (save_configuration): Save the security and secure-auth settings.
3039 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3040 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3042 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3044 * src/modest-defs.h:
3045 * src/modest-account-mgr.c:
3046 (modest_account_mgr_add_server_account):
3047 Added and used defines for the options key and value pair strings,
3048 that are used so far, though they do not seem to correspond to anything in our
3049 UI specs or ModestProtocol enum.
3051 * src/modest-account-mgr-helpers.h:
3052 * src/modest-account-mgr-helpers.c:
3053 (compare_option_strings_for_name),
3054 (modest_server_account_data_get_option_value),
3055 (modest_server_account_data_get_option_bool),
3056 (modest_account_mgr_get_server_account_option):
3057 Added helper functions for parsing the options GSList.
3059 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3061 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3062 display name is based on the supplied account name.
3063 * src/modest-account-mgr.c:
3064 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3065 with an inefficient, but good-enough, implementation.
3067 * src/maemo/easysetup/modest-easysetup-wizard.c:
3068 (create_page_account_details), (on_before_next), (create_account):
3069 Check for existing display names rather than (non-user-visible) account names, and just
3070 create and set a unique account name at the end.
3072 * src/maemo/modest-account-settings-dialog.c:
3073 (modest_account_settings_dialog_init),
3074 (modest_account_settings_dialog_set_account_name),
3075 (create_page_incoming): Show the display name, instead of the account name.
3076 (on_response): Do some (not all) extra checks, as in the UI spec.
3077 (save_configuration): Save the display name if it was changed.
3079 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3081 * po/en_GB.po: Added needed logical ID and translation.
3082 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3083 (init_view): Made the is-default column clicking work.
3085 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3088 * src/maemo/easysetup/Makefile.am:
3089 * src/maemo/easysetup/modest-easysetup-wizard.c:
3090 (modest_easysetup_wizard_dialog_init):
3091 * src/maemo/easysetup/provider-data-test.keyfile:
3092 * src/maemo/easysetup/provider-data.keyfile:
3093 Moved the provider data file to the new modest-providers-data package and used it from there.
3095 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3097 * src/modest-local-folder-info.c:
3098 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3099 N_() was already used on the static strings, but this just marks it for translation without
3100 using the translation.
3102 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3104 * src/maemo/modest-account-settings-dialog.c:
3105 (create_page_incoming),
3106 (modest_account_settings_dialog_set_account_name):
3107 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3108 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3109 I will do this if nobody else gets there first.
3111 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3113 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3114 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3115 save the security stuff.
3117 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3119 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3120 Set the email address and user fullname, which I now see must be
3123 * src/maemo/modest-account-settings-dialog.h:
3124 * src/maemo/modest-account-settings-dialog.c:
3126 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3127 leave-on-server and authentication.
3128 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3131 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3134 * src/maemo/modest-account-settings-dialog.c:
3135 * src/maemo/modest-account-settings-dialog.h:
3136 Most (but not all) of the widgets are now present as specified by the UI spec.
3137 No changes are yet saved, and some details are not properly shown yet.
3139 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3141 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3143 * src/maemo/Makefile.am:
3144 * src/maemo/modest-account-settings-dialog.c:
3145 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3146 an existing account. Doesn't do much yet.
3148 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3149 Open the accounts settings dialog when Edit is clicked.
3151 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3153 * src/maemo/easysetup/Makefile.am:
3154 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3156 * src/maemo/easysetup/modest-easysetup-wizard.c:
3157 (modest_easysetup_wizard_dialog_init):
3158 Try to get the source directory from the build system,
3159 instead of hard-coding "./" into the source code, when opening our local
3160 copies of the configuration files.
3161 But this still fails when opening the wizard from the Accounts window,
3162 maybe because the working directory seems to change at runtime.
3163 So the wizard will fail the second time unless you copy the files into their
3164 proper locations - see the stdout warnings for the paths.
3166 (create_page_account_details),(on_before_next):
3167 Check for existing non-server accounts instead of server accounts,
3168 so the default account name is useful again, and to prevent trying to
3171 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3172 Show the wizard when New is clicked.
3174 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3175 (init_view): Show the column headers, and show the columns that are
3176 specified in the UI specs. However, something in Maemo's GTK+ prevents
3177 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3178 change the default account. This is despite unsetting the special properties.
3180 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3182 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3183 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3184 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3185 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3186 to make that clearer.
3187 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3189 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3191 * src/maemo/modest-account-view-window.c:
3192 (modest_account_view_window_init),
3193 (modest_account_view_window_new):
3194 Use the same buttons as specified in the
3195 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3196 the existing widgets, which never had a chance of working.
3197 Put the ModestAccountView treeview in a scrolled window.
3198 Do not repeat the initialization in both _init() and _new().
3200 * src/widgets/modest-account-view.c: (update_account_view):
3201 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3202 this widget and window shows no accounts.
3204 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3206 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3208 * src/maemo/easysetup/modest-easysetup-wizard.c:
3209 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3210 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3211 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3214 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3215 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3216 accounts exist yet, as in the UI spec.
3218 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3220 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3222 * src/maemo/Makefile.am:
3223 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3224 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3225 New window for editing connection-specific smtp details.
3226 Not fully implemented.
3228 * src/maemo/modest-connection-specific-smtp-window.c:
3229 (modest_connection_specific_smtp_window_finalize) :
3230 unref the tree model.
3231 (on_button_edit): Show the edit window.
3233 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3235 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3238 * src/maemo/Makefile.am:
3239 * src/maemo/modest-connection-specific-smtp-window.c:
3240 * src/maemo/modest-connection-specific-smtp-window.h:
3241 New window for showing the list of connections, for connection-specific
3242 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3243 * src/maemo/easysetup/modest-easysetup-wizard.c:
3244 (create_page_custom_outgoing): Show the new window when the button is clicked.
3246 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3248 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3249 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3250 * src/maemo/modest-msg-edit-window.c:
3251 (modest_msg_edit_window_insert_image):
3252 * src/modest-conf.c: (modest_conf_key_escape):
3253 * src/modest-mail-operation.c:
3254 (modest_mail_operation_send_new_mail):
3255 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3256 (modest_ui_actions_on_new_account):
3257 * src/widgets/modest-attachment-view.c: (update_filename_request):
3258 * src/widgets/modest-mail-header-view.c:
3259 Corrected warnings that were breaking the build, by commenting out unused variables,
3260 and a function, and by including a header.
3262 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3264 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3265 so we can #ifdef around platform-specific code when necessary.
3266 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3267 to allow this to build for the GNOME platform too.
3269 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3271 * src/maemo/easysetup/modest-easysetup-wizard.c:
3272 Added util_increment_name() and used it in create_page_account_details()
3273 to make sure that the default account name is always a new name.
3275 (modest_easysetup_wizard_dialog_init),
3276 (set_default_custom_servernames): Some minor memory management fixes.
3278 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3282 * src/modest-runtime.c: (init_i18n): Restored the translation
3283 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3284 are defined in config.h, and the translations are installed.
3286 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3287 is defined for translation.
3289 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3291 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3293 * src/maemo/easysetup/modest-easysetup-wizard.c:
3294 (modest_easysetup_wizard_dialog_init):
3295 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3296 Use realistic paths (though they should use $prefix generically) to the
3297 mcc_mapping and provider-data.keyfile files which might work when they
3298 are installed by the future version of the operator-wizard package,
3299 and then fallback to paths in our source code, with an explanatory
3302 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3306 * src/maemo/Makefile.am:
3307 * src/maemo/easysetup/: Added files from the previously-exernal
3308 osso-modest-easysetup.
3309 * src/maemo/modest-main-window-ui.h:
3310 * src/modest-ui-actions.c:
3311 * src/modest-ui-actions.h:
3312 Added modest_ui_actions_on_new_account() as a signal handler for the
3313 New Account menu item. It shows the easysetup wizard.
3314 * po/en_GB.po: Added additional needed logical IDs and translations.