git.maemo.org Git - modest/blob - ChangeLog2

   1 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
   2
   3         * src/modest-account-mgr-helpers.c:
   4         (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
   5         for the case that the account does not exist.
   6
   7         * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
   8         (equivalent to the modest account name) rather than the tinymail account name
   9         (equivalent to the modest account title - human readable) to get the account data.
  10         Check for null account data to prevent the crash, and add a TODO comment saying that
  11         this needs fixing because it is using the server account name instead of the account name.
  12
  13 2007-04-29  Murray Cumming  <murrayc@murrayc.com>
  14
  15         * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
  16         * src/maemo/modest-account-settings-dialog.c: (show_error),
  17         (show_ok):
  18         Use hildon_note_new_information() for informative and error messages,
  19         which seems to be expected for Maemo applications (no documentation that I know of
  20         says this). I am surprised that there is no distinction between info and error
  21         dialogs.
  22
  23 2007-04-29  Murray Cumming  <murrayc@murrayc.com>
  24
  25         * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
  26         it is easy to find where this is used.
  27
  28         * src/maemo/easysetup/modest-easysetup-wizard.c:
  29         (create_page_welcome), (create_page_account_details),
  30         (create_page_user_details), (create_page_complete_easysetup),
  31         (create_page_custom_incoming), (create_page_custom_outgoing),
  32         (create_page_complete_custom):
  33         * src/maemo/modest-account-settings-dialog.c:
  34         (create_page_account_details), (create_page_user_details),
  35         (create_page_incoming), (create_page_outgoing):
  36         * src/maemo/modest-account-view-window.c: (window_vbox_new):
  37         * src/maemo/modest-connection-specific-smtp-edit-window.c:
  38         (modest_connection_specific_smtp_edit_window_init):
  39         * src/maemo/modest-connection-specific-smtp-window.c:
  40         (modest_connection_specific_smtp_window_init):
  41         * src/maemo/modest-signature-editor-dialog.c:
  42         (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
  43         and scrolling policy as per the Email Application Layout Guide, if I have
  44         understood it.
  45
  46 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
  47
  48         * src/modest-tny-account-store.c: (modest_tny_account_store_init):
  49         Remove the add_transport_account_func and add_store_account_func vfunc implementations,
  50         which were empty, because these vfuncs have been removed from TnyAccountStore.
  51         This fixes the build.
  52
  53 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
  54
  55         * src/maemo/modest-main-window.c:
  56         (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
  57         showing/hiding it. Added TODO because it probably should not be NULL.
  58         * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
  59         because unnecessary g_warnings() make degugging difficult.
  60
  61 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
  62
  63         * src/maemo/modest-msg-edit-window.c:
  64         (modest_msg_edit_window_select_color),
  65         (modest_msg_edit_window_select_background_color): 2 const corrections and
  66         moving 2 #endifs before closing brackets, to fix the build.
  67
  68 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
  69
  70         * src/maemo/easysetup/modest-easysetup-wizard.h:
  71         * src/maemo/easysetup/modest-easysetup-wizard.c:
  72         (modest_easysetup_wizard_dialog_finalize),
  73         (on_button_edit_advanced_settings), (create_page_complete_custom),
  74         (on_response), (create_account):
  75         Implement the Advanced Settings edit button, by saving the account information,
  76         for the Advanded Settings dialog to use directly from gconf, and removing it
  77         if Finish is never clicked. There is still some UI strangeness, so this is not finished.
  78         Bug #5533 in the projects.maemo.org bugzilla.
  79
  80 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
  81
  82         * src/maemo/modest-msg-view-window.c:
  83         (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
  84         when opening a message window.
  85
  86 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
  87
  88         * src/maemo/easysetup/modest-easysetup-wizard.c:
  89         (create_page_custom_outgoing): Correct the position of the horizontal separator to
  90         match the UI spec.
  91
  92         * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
  93         before showing/hiding them, to avoid a crash when clicking on folders when there are no
  94         gconf settings. I probably added more checks than necessary, but that is safer.
  95
  96         * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
  97         variable to fix the build, but this seems to be used when it is still NULL.
  98
  99 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 100
 101         * src/modest-platform.h:
 102         * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
 103         * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
 104         * src/modest-main.c: Implement this function so we can avoid using
 105         maemo-specific API from cross-platform code.
 106         (main):
 107         * src/modest-tny-account-store.c:
 108         (get_smtp_specific_transport_account_for_open_connection):
 109         * src/modest-ui-actions.c: (check_for_connection),
 110         (modest_ui_actions_on_item_not_found):
 111         Use modest_platform_connect_and_wait() and put #idefs around other
 112         maemo-specific code, because only maemo currently has a way to
 113         identify connection names.
 114
 115 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 116
 117         * src/modest-tny-account-store.h:
 118         * src/modest-tny-account-store.c:
 119         Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
 120         the connection-specific SMTP server settings in the configuration.
 121
 122         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
 123         (on_idle_mail_to):
 124         * src/maemo/modest-main-window.c: (on_connection_changed),
 125         (connect_signals):
 126         * src/modest-main.c: (main), (start_ui), (send_mail):
 127         Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
 128         that is what is intended.
 129
 130         * src/modest-ui-actions.c: (action_send), (action_receive),
 131         (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
 132         Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
 133         modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
 134         SMTP server is used when it is specified.
 135
 136         (modest_ui_actions_on_send_receive):
 137         Check that a connection is open before proceeding.
 138         Receive and then send, instead of vice-versa, as per the specification.
 139
 140 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 141
 142         * src/modest-mail-operation.c:
 143         (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
 144         though I guess it should be something other than NULL.
 145
 146 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 147
 148         * src/maemo/easysetup/modest-easysetup-wizard.c:
 149         (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
 150         combo twice, to avoid an g_warning and to make it visible again.
 151         * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
 152         attached before detaching it, to avoid a g_warning, and add comment about the implicit
 153         (already intended) dereference when detaching, because we then recreate the menu.
 154         But I am not sure why the warning was happening, and it is possible that this is a memory
 155         leak.
 156
 157 2007-04-25  Murray Cumming  <murrayc@murrayc.com>
 158
 159         * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
 160         and uri_parse_mailto() utility functions.
 161         (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
 162         the mailto URI.
 163         * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
 164
 165 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 166
 167         * src/dbus_api/modest-dbus-api.h:
 168         * src/dbus_api/modest-dbus-callbacks.c:
 169         Use an idle callback to execute the modest code in the application's own thread.
 170         Remove the helloworld example method.
 171         Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
 172         parsed, and the open-message method is not implemented because this is not yet implemented in
 173         modest itself.
 174         * libmodest-dbus-client/libmodest-dbus-client.c:
 175         (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
 176         (libmodest_dbus_client_open_message):
 177         * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
 178
 179         * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
 180         body without crashing.
 181
 182         * tests/dbus_api/Makefile.am:
 183         * tests/dbus_api/test_mail_to.c:
 184         * tests/dbus_api/test_open_message.c: New tests for the new methods.
 185
 186 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 187
 188         * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
 189         Added file to fix the build. Sorry.
 190
 191         * src/dbus_api/Makefile.am:
 192         * src/dbus_api/modest-dbus-api.h:
 193         * src/dbus_api/modest-dbus-callbacks.h:
 194         * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
 195         (modest_dbus_req_handler):
 196         Put constants in a separate header so it can be reused by the
 197         client library, without duplication
 198
 199         * libmodest-dbus-client/Makefile.am:
 200         * libmodest-dbus-client/libmodest-dbus-client.c:
 201         (libmodest_dbus_client_call_helloworld),
 202         (libmodfest_dbus_client_send_mail),
 203         (libmodfest_dbus_client_mailto),
 204         (libmodfest_dbus_client_open_message):
 205         * libmodest-dbus-client/libmodest-dbus-client.h:
 206         (Partly) Implement a send_mail D-Bus method.
 207
 208         * tests/dbus_api/Makefile.am:
 209         * tests/dbus_api/test_send_mail.c: (main): Added a test for
 210         the send_email D-Bus method.
 211
 212 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 213
 214         * Makefile.am:
 215         * configure.ac:
 216         * libmodest-dbus-client/Makefile.am:
 217         * libmodest-dbus-client/libmodest-dbus-client.c:
 218         * libmodest-dbus-client/libmodest-dbus-client.h:
 219         * tests/dbus_api/Makefile.am:
 220         * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
 221         for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
 222
 223 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 224
 225         * src/maemo/easysetup/modest-easysetup-wizard.c:
 226         (create_page_account_details):
 227         * src/maemo/modest-account-settings-dialog.c:
 228         (create_page_account_details): Explicitly set auto-capitalization mode for the title
 229         widgets, because this might not be the default in future versions of the Maemo GTK+.
 230         However, I can not not get capitalization to work even in a simple test case.
 231
 232 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 233
 234         * src/maemo/easysetup/modest-easysetup-wizard.c:
 235         (create_page_custom_incoming), (create_page_custom_outgoing):
 236         * src/maemo/modest-account-settings-dialog.c:
 237         (create_page_account_details), (create_page_incoming),
 238         (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
 239         instead of using gtk_check_button_with_label(), so they are aligned like the other
 240         widgets, as per the UI spec.
 241
 242 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 243
 244         * src/maemo/easysetup/modest-easysetup-wizard.c:
 245         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 246         * src/widgets/modest-validating-entry.c:
 247         * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
 248         Modest prefix instead of an EasySetup prefix.
 249
 250 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 251
 252         * src/widgets/modest-validating-entry.h:
 253         * src/widgets/modest-validating-entry.c: (on_insert_text),
 254         Added easysetup_validating_entry_set_max_func(), used to set a callback
 255         to call when the max number of characters is reached. GtkEntry has a max-length
 256         already but is silent about it.
 257
 258         * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
 259         (create_page_account_details), (create_page_user_details),
 260         (create_account):
 261         * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
 262         (create_page_account_details), (create_page_user_details),
 263         (create_page_outgoing):
 264         * src/modest-ui-actions.c: (modest_ui_actions_on_details):
 265         Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
 266         the UI spec, when the user tries to enter more than the max number of characters.
 267
 268 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 269
 270         * src/maemo/easysetup/modest-easysetup-wizard.c:
 271         (create_page_user_details), (create_page_custom_incoming),
 272         (create_page_custom_outgoing):
 273         * src/maemo/modest-account-settings-dialog.c:
 274         (create_page_user_details), (create_page_incoming),
 275         (create_page_outgoing):
 276         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 277         (modest_connection_specific_smtp_edit_window_init):
 278         Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
 279         not appropriate. Bad Maemo-specific defaults!.
 280
 281 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 282
 283         * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
 284         (on_toggle_button_changed), (modest_signature_editor_dialog_init),
 285         (modest_signature_editor_dialog_set_settings):
 286         Disable the label and textview when the checkbox is disabled, and use the
 287         specified (UI spec) default signature text.
 288
 289 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 290
 291         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 292         (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
 293
 294         * src/modest-defs.h:
 295         * src/modest-account-mgr-helpers.h:
 296         * src/modest-account-mgr-helpers.c:
 297         Added modest_account_mgr_get/set_signature(), using new gconf keys.
 298
 299         * src/maemo/Makefile.am:
 300         * src/maemo/modest-signature-editor-dialog.c:
 301         * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
 302         as per the UI spec.
 303
 304         * src/maemo/modest-account-settings-dialog.h:
 305         * src/maemo/modest-account-settings-dialog.c:
 306         (modest_account_settings_dialog_finalize), (on_button_signature),
 307         (save_configuration): Use the new dialog when the Edit button is pressed, and
 308         save the changes if necessary, as per the UI spec.
 309
 310 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 311
 312         * src/maemo/Makefile.am:
 313         * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
 314         based on maemo-develoers email from Dirk.
 315
 316         * src/maemo/easysetup/modest-easysetup-wizard.c:
 317         (create_page_welcome), (create_page_account_details),
 318         (create_page_user_details), (create_page_complete_easysetup),
 319         (create_page_custom_incoming), (create_page_custom_outgoing),
 320         (create_page_complete_custom),
 321         (modest_easysetup_wizard_dialog_init):
 322         * src/maemo/modest-account-settings-dialog.c:
 323         (create_page_account_details), (create_page_user_details),
 324         (create_page_incoming), (create_page_outgoing),
 325         (modest_account_settings_dialog_init):
 326         * src/maemo/modest-connection-specific-smtp-window.c:
 327         (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
 328
 329 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 330
 331         * src/maemo/easysetup/modest-easysetup-wizard.c:
 332         (create_page_account_details), (create_page_custom_outgoing),
 333         (create_page_complete_custom):
 334         * src/maemo/modest-account-settings-dialog.c:
 335         (create_page_user_details), (create_page_incoming),
 336         (create_page_outgoing):
 337         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 338         (modest_connection_specific_smtp_edit_window_init):
 339         Use the correct (UI spec) port min/max, and use horizontal separators,
 340         as per the UI spec.
 341
 342 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 343
 344         * src/maemo/easysetup/modest-easysetup-wizard.c:
 345         (set_default_custom_servernames):
 346         * src/maemo/modest-account-settings-dialog.c:
 347         (create_page_incoming), (on_combo_outgoing_security_changed),
 348         (on_combo_incoming_security_changed), (create_page_outgoing),
 349         (modest_account_settings_dialog_set_account_name),
 350         (save_configuration):
 351         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 352         (on_combo_security_changed),
 353         (modest_connection_specific_smtp_edit_window_init),
 354         (modest_connection_specific_smtp_edit_window_set_connection),
 355         (modest_connection_specific_smtp_edit_window_get_settings):
 356         Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
 357         as per the UI spec.
 358
 359 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 360
 361         * po/en_GB.po:
 362         * src/maemo/easysetup/modest-easysetup-wizard.c:
 363         (create_page_custom_outgoing), (create_page_complete_custom):
 364         * src/maemo/modest-account-settings-dialog.c:
 365         (create_page_user_details), (create_page_outgoing):
 366         * src/maemo/modest-account-view-window.c: (button_box_new):
 367         Use changed logical IDs as per the most recent UI spec:
 368         mcen_bd_emailsetup_edit -> mcen_bd_edit
 369         mcen_bd_emailsetup_delete -> mcen_bd_delete
 370         mcen_bd_emailsetup_close -> mcen_bd_close
 371
 372 2007-04-20  2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 373
 374         * configure.ac:
 375         * src/Makefile.am:
 376         * src/dbus_api/Makefile.am:
 377         * src/dbus_api/modest-dbus-callbacks.c:
 378         * src/dbus_api/modest-dbus-callbacks.h:
 379         * src/maemo/modest-platform.c: (modest_platform_init):
 380         Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
 381         method.
 382         * tests/Makefile.am:
 383         * tests/dbus_api/Makefile.am:
 384         * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
 385
 386 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 387
 388         * src/maemo/modest-account-settings-dialog.c:
 389         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 390         Removed unnecessary includes.
 391
 392 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 393
 394         * src/maemo/easysetup/modest-easysetup-wizard.c:
 395         * src/maemo/modest-account-settings-dialog.c:
 396         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 397         * src/widgets/Makefile.am:
 398         * src/widgets/modest-easysetup-secureauth-combo-box.c:
 399         * src/widgets/modest-easysetup-secureauth-combo-box.h:
 400         * src/widgets/modest-easysetup-serversecurity-combo-box.c:
 401         * src/widgets/modest-easysetup-serversecurity-combo-box.h:
 402         * src/widgets/modest-secureauth-combo-box.c:
 403         * src/widgets/modest-secureauth-combo-box.h:
 404         * src/widgets/modest-serversecurity-combo-box.c:
 405         * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
 406         made the GObject names more consistent with the rest of the Modest code.
 407
 408 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 409
 410         * src/maemo/easysetup/Makefile.am:
 411         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 412         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
 413         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 414         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 415         * src/maemo/easysetup/modest-easysetup-wizard.c:
 416         * src/maemo/easysetup/modest-validating-entry.c:
 417         * src/maemo/easysetup/modest-validating-entry.h:
 418         * src/maemo/modest-account-settings-dialog.c:
 419         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 420         * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
 421         widgets/ because they are used outside of easysetup too. After checking in,
 422         svn will allow me to rename them too.
 423
 424 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 425
 426         * src/gnome/modest-msg-edit-window.c:
 427         (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
 428         linker error, to fix the build on the GNOME platform.
 429         modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
 430         modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
 431         ifdefed out to avoid a warning.
 432
 433 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 434
 435         * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
 436         use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
 437         some alternative for GTK+ 2.6.
 438
 439 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 440
 441         * src/maemo/modest-address-book.c: Added include to avoid a warning.
 442
 443         * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
 444         specified for EmailAccountsDialog in UI spec.
 445
 446         * src/maemo/easysetup/modest-easysetup-wizard.c:
 447         * src/maemo/easysetup/modest-easysetup-wizard.h:
 448         * src/maemo/modest-account-settings-dialog.c:
 449         * src/maemo/modest-account-settings-dialog.h:
 450         Reuse a member window widget for the connection-specific SMTP server accounts,
 451         so we can tell it to create/save the accounts only if we actually save changes.
 452
 453         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 454         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 455         (modest_connection_specific_smtp_edit_window_get_settings):
 456         Return a struct instance for temporarily remembering the entered data.
 457
 458         * src/maemo/modest-connection-specific-smtp-window.h:
 459         * src/maemo/modest-connection-specific-smtp-window.c:
 460         (modest_connection_specific_smtp_window_finalize),
 461         (modest_connection_specific_smtp_window_fill_with_connections),
 462         (on_button_edit),
 463         (modest_connection_specific_smtp_window_save_server_accounts),
 464         (update_model_server_names): Do not actually save data until asked,
 465         when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
 466
 467         (on_selection_changed),
 468         (modest_connection_specific_smtp_window_init): Disable the edit
 469         button when nothing is selected.
 470
 471         * src/modest-account-mgr-helpers.c:
 472         * src/modest-account-mgr-helpers.h:
 473         Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
 474         elsewhere.
 475
 476 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 477
 478         * src/modest-account-mgr-helpers.h:
 479         * src/modest-account-mgr-helpers.c:
 480         (modest_account_mgr_get_unused_account_name),
 481         (modest_account_mgr_get_unused_account_display_name): Added these
 482         utility functions, to avoid code duplication.
 483
 484         * src/maemo/easysetup/modest-easysetup-wizard.c:
 485         (create_page_account_details), (create_account):
 486         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 487         (on_combo_security_changed),
 488         (modest_connection_specific_smtp_edit_window_init),
 489         (modest_connection_specific_smtp_edit_window_save_settings):
 490         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 491         * src/maemo/modest-connection-specific-smtp-window.c:
 492         (modest_connection_specific_smtp_window_finalize),
 493         (modest_connection_specific_smtp_window_fill_with_connections),
 494         (on_button_edit), (modest_connection_specific_smtp_window_init):
 495         * src/maemo/modest-connection-specific-smtp-window.h:
 496         Implementing saving of connection-specific server accounts.
 497
 498         But I need to refactor this so we can save the data for each
 499         possible connection-specific account and only actually create the server accounts
 500         when the easysetup finished, or the OK button is pressed on the account settings
 501         dialog.
 502
 503 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 504
 505         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 506         (on_combo_security_changed):
 507         (modest_connection_specific_smtp_edit_window_init):
 508         Auto-fill the port number as in the account settings.
 509
 510         (modest_connection_specific_smtp_edit_window_set_connection):
 511         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 512         * src/maemo/modest-connection-specific-smtp-window.c:
 513         (fill_with_connections), (on_button_edit),
 514         (modest_connection_specific_smtp_window_init):
 515         Turn the edit window into a dialog to simplify the code, and
 516         set a WM hint as in a GtkDialog, because only a popup can be on top of
 517         another window in Maemo, and popups usually have no WM decoration.
 518
 519         * src/modest-defs.h:
 520         * src/modest-account-mgr-helpers.c:
 521         (modest_account_mgr_set_connection_specific_smtp),
 522         (modest_account_mgr_remove_connection_specific_smtp),
 523         (modest_account_mgr_get_connection_specific_smtp):
 524         * src/modest-account-mgr-helpers.h: Some functions to write the
 525         connection-specific SMTP server information. Not yet used.
 526
 527
 528         * src/widgets/modest-folder-view.c: (text_cell_data):
 529         Fix a warning about an uninitialized variable.
 530         (on_configuration_key_changed): Put an #ifdef around the use
 531         of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
 532
 533 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 534
 535         * src/maemo/modest-account-settings-dialog.h:
 536         * src/maemo/modest-account-settings-dialog.c:
 537         Added connect_for_modified() utility function to mark the new modified boolean.
 538
 539         (create_page_account_details), (create_page_user_details),
 540         (create_page_incoming), (create_page_outgoing), (on_response),
 541         (modest_account_settings_dialog_init),
 542         (modest_account_settings_dialog_set_account_name):
 543         Only warn about unsaved changes when there are actually unsaved changes.
 544
 545         * src/modest-account-mgr-helpers.c:
 546         * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
 547         into the ModestServerAccountData struct. I do not use it yet, but someone might expect
 548         to get the data from there in future.
 549
 550 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 551
 552         * src/modest-defs.h:
 553
 554         * src/modest-account-mgr-helpers.h:
 555         * src/modest-account-mgr-helpers.c:
 556         Store the security account setting in a single conf key instead of using
 557         the options list, so that the list is left for just the to-be-removed camel hack,
 558         and because gconf_client_set_list() is failing for some reason.
 559
 560         * src/modest-account-mgr.c:
 561         (modest_account_mgr_add_server_account):
 562         * src/maemo/modest-account-settings-dialog.c:
 563         (modest_account_settings_dialog_set_account_name),
 564         (save_configuration): Use the renamed functions.
 565
 566
 567 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 568
 569         * src/widgets/Makefile.am:
 570         * src/widgets/modest-limit-retrieve-combo-box.c:
 571         * src/widgets/modest-limit-retrieve-combo-box.h:
 572         * src/widgets/modest-retrieve-combo-box.c:
 573         * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
 574         the account settings dialog.
 575
 576         * src/modest-defs.h:
 577         * src/modest-account-mgr-helpers.h:
 578         * src/modest-account-mgr-helpers.c:
 579         (modest_server_account_get_option_secure_auth),
 580         (modest_server_account_set_option_secure_auth):
 581         * src/modest-account-mgr.c:
 582         (modest_account_mgr_add_server_account):
 583         Use the existing AUTH_MECH conf key for the secure-auth setting,
 584         instead of putting it in the list options, because this was actually used already.
 585
 586         * src/maemo/modest-account-settings-dialog.c:
 587         (create_page_account_details),
 588         (modest_account_settings_dialog_set_account_name),
 589         (save_configuration):
 590         * src/maemo/modest-account-settings-dialog.h:
 591         Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
 592         Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
 593
 594 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 595
 596         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 597         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 598         Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
 599
 600         * src/modest-defs.h:
 601         * src/maemo/modest-account-settings-dialog.c:
 602         (create_page_incoming), (on_combo_outgoing_security_changed),
 603         (on_combo_incoming_security_changed), (create_page_outgoing),
 604         (modest_account_settings_dialog_set_account_name),
 605         (save_configuration): Load/Save the port number, and change it when the
 606         security combo changes, to suitable defaults.
 607
 608 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 609
 610         * src/modest-account-mgr.c:
 611         (modest_account_mgr_add_server_account): Set the security and secure-auth
 612         options, and add a comment saying that the other camel-specific options should be
 613         removed in future.
 614
 615 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 616
 617         * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
 618         found by valgrind.
 619         * src/modest-tny-account-store.c: (account_list_free),
 620         (on_account_changed): Add a TODO comment about a valgrind error, caused by using
 621         cursor->data after unreffing it. But there is some strange stuff there so it might not be
 622         easy to fix.
 623
 624 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 625
 626         * src/modest-protocol-info.c:
 627         * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
 628         is required by our UI spec. Maybe something in our implementation will use this eventually.
 629         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 630         (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
 631         instead of the previous 0 placeholder.
 632
 633         * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
 634         secure-auth settings.
 635         * src/modest-account-mgr-helpers.h:
 636         * src/modest-account-mgr-helpers.c:
 637         (modest_server_account_data_get_option_secure_auth),
 638         (modest_server_account_set_option_secure_auth),
 639         (modest_server_account_data_get_option_security),
 640         (modest_server_account_set_option_security): Added this API for getting and setting the security
 641         and secure-auth settings.
 642
 643         * src/maemo/modest-account-settings-dialog.h:
 644         * src/maemo/modest-account-settings-dialog.c:
 645         (modest_account_settings_dialog_finalize), (check_data),
 646         (on_response): Store the original title as well as the name, to avoid unnececessary warnings
 647         about changing titles.
 648         (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
 649         (save_configuration): Save the security and secure-auth settings.
 650
 651         * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
 652         is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
 653
 654 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 655
 656         * src/modest-defs.h:
 657         * src/modest-account-mgr.c:
 658         (modest_account_mgr_add_server_account):
 659         Added and used defines for the options key and value pair strings,
 660         that are used so far, though they do not seem to correspond to anything in our
 661         UI specs or ModestProtocol enum.
 662
 663         * src/modest-account-mgr-helpers.h:
 664         * src/modest-account-mgr-helpers.c:
 665         (compare_option_strings_for_name),
 666         (modest_server_account_data_get_option_value),
 667         (modest_server_account_data_get_option_bool),
 668         (modest_account_mgr_get_server_account_option):
 669         Added helper functions for parsing the options GSList.
 670
 671 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 672
 673         * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
 674         display name is based on the supplied account name.
 675         * src/modest-account-mgr.c:
 676         * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
 677         with an inefficient, but good-enough, implementation.
 678
 679         * src/maemo/easysetup/modest-easysetup-wizard.c:
 680         (create_page_account_details), (on_before_next), (create_account):
 681         Check for existing display names rather than (non-user-visible) account names, and just
 682         create and set a unique account name at the end.
 683
 684         * src/maemo/modest-account-settings-dialog.c:
 685         (modest_account_settings_dialog_init),
 686         (modest_account_settings_dialog_set_account_name),
 687         (create_page_incoming): Show the display name, instead of the account name.
 688         (on_response): Do some (not all) extra checks, as in the UI spec.
 689         (save_configuration): Save the display name if it was changed.
 690
 691 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 692
 693         * po/en_GB.po: Added needed logical ID and translation.
 694         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 695         (init_view): Made the is-default column clicking work.
 696
 697 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 698
 699         * configure.ac:
 700         * src/maemo/easysetup/Makefile.am:
 701         * src/maemo/easysetup/modest-easysetup-wizard.c:
 702         (modest_easysetup_wizard_dialog_init):
 703         * src/maemo/easysetup/provider-data-test.keyfile:
 704         * src/maemo/easysetup/provider-data.keyfile:
 705         Moved the provider data file to the new modest-providers-data package and used it from there.
 706
 707 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 708
 709         * src/modest-local-folder-info.c:
 710         (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
 711         N_() was already used on the static strings, but this just marks it for translation without
 712         using the translation.
 713
 714 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 715
 716         * src/maemo/modest-account-settings-dialog.c:
 717         (create_page_incoming),
 718         (modest_account_settings_dialog_set_account_name):
 719         Added comments about the need for new API in ModestAccountMgr to handle the authentication
 720         and secure-connection stuff that is stored in the options GSList* with hard-coded names.
 721         I will do this if nobody else gets there first.
 722
 723 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 724
 725         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
 726         Saved much of the incoming and outgoing data too, though I cannot yet see how to
 727         save the security stuff.
 728
 729 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 730
 731         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 732         Set the email address and user fullname, which I now see must be
 733         done separately.
 734
 735         * src/maemo/modest-account-settings-dialog.h:
 736         * src/maemo/modest-account-settings-dialog.c:
 737          (on_response),
 738         (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
 739         leave-on-server and authentication.
 740         (save_configuration): Save most of the non-server-account specific stuff, but I don't see
 741         how to do the rest.
 742
 743 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 744
 745
 746         * src/maemo/modest-account-settings-dialog.c:
 747         * src/maemo/modest-account-settings-dialog.h:
 748         Most (but not all) of the widgets are now present as specified by the UI spec.
 749         No changes are yet saved, and some details are not properly shown yet.
 750
 751         * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
 752
 753 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 754
 755         * src/maemo/Makefile.am:
 756         * src/maemo/modest-account-settings-dialog.c:
 757         * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
 758         an existing account. Doesn't do much yet.
 759
 760         * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
 761         Open the accounts settings dialog when Edit is clicked.
 762
 763 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 764
 765         * src/maemo/easysetup/Makefile.am:
 766         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
 767         (load_from_file):
 768         * src/maemo/easysetup/modest-easysetup-wizard.c:
 769         (modest_easysetup_wizard_dialog_init):
 770         Try to get the source directory from the build system,
 771         instead of hard-coding "./" into the source code, when opening our local
 772         copies of the configuration files.
 773         But this still fails when opening the wizard from the Accounts window,
 774         maybe because the working directory seems to change at runtime.
 775         So the wizard will fail the second time unless you copy the files into their
 776         proper locations - see the stdout warnings for the paths.
 777
 778         (create_page_account_details),(on_before_next):
 779         Check for existing non-server accounts instead of server accounts,
 780         so the default account name is useful again, and to prevent trying to
 781         recreate accounts.
 782
 783         * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
 784         Show the wizard when New is clicked.
 785
 786         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 787         (init_view): Show the column headers, and show the columns that are
 788         specified in the UI specs. However, something in Maemo's GTK+ prevents
 789         us from handling the GtkCellRendererToggle::toggled signal, so we cannot
 790         change the default account. This is despite unsetting the special properties.
 791
 792 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 793
 794         * docs/reference/modest-design.sgml: Corrected spelling mistake.
 795         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 796         Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
 797         This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
 798         to make that clearer.
 799         * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
 800
 801 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 802
 803         * src/maemo/modest-account-view-window.c:
 804         (modest_account_view_window_init),
 805         (modest_account_view_window_new):
 806         Use the same buttons as specified in the
 807         UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
 808         the existing widgets, which never had a chance of working.
 809         Put the ModestAccountView treeview in a scrolled window.
 810         Do not repeat the initialization in both _init() and _new().
 811
 812         * src/widgets/modest-account-view.c: (update_account_view):
 813         Add a warning about modest_account_mgr_account_names() returning NULL, which is why
 814         this widget and window shows no accounts.
 815
 816         * po/en_GB.po: Added translations needed for the dialog button logical IDs.
 817
 818 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 819
 820         * src/maemo/easysetup/modest-easysetup-wizard.c:
 821         (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
 822         (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
 823         returns NULL after modest_account_mgr_add_server_account() returned TRUE,
 824         which seems wrong.
 825
 826         * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
 827         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
 828         accounts exist yet, as in the UI spec.
 829
 830         * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
 831
 832 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 833
 834         * src/maemo/Makefile.am:
 835         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 836         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 837         New window for editing connection-specific smtp details.
 838         Not fully implemented.
 839
 840         * src/maemo/modest-connection-specific-smtp-window.c:
 841         (modest_connection_specific_smtp_window_finalize) :
 842         unref the tree model.
 843         (on_button_edit): Show the edit window.
 844
 845 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 846
 847         * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
 848         error for me.
 849
 850         * src/maemo/Makefile.am:
 851         * src/maemo/modest-connection-specific-smtp-window.c:
 852         * src/maemo/modest-connection-specific-smtp-window.h:
 853         New window for showing the list of connections, for connection-specific
 854         SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
 855         * src/maemo/easysetup/modest-easysetup-wizard.c:
 856         (create_page_custom_outgoing): Show the new window when the button is clicked.
 857
 858 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 859
 860         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 861         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
 862         * src/maemo/modest-msg-edit-window.c:
 863         (modest_msg_edit_window_insert_image):
 864         * src/modest-conf.c: (modest_conf_key_escape):
 865         * src/modest-mail-operation.c:
 866         (modest_mail_operation_send_new_mail):
 867         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
 868         (modest_ui_actions_on_new_account):
 869         * src/widgets/modest-attachment-view.c: (update_filename_request):
 870         * src/widgets/modest-mail-header-view.c:
 871         Corrected warnings that were breaking the build, by commenting out unused variables,
 872         and a function, and by including a header.
 873
 874 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 875
 876         * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
 877         so we can #ifdef around platform-specific code when necessary.
 878         * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
 879         to allow this to build for the GNOME platform too.
 880
 881 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 882
 883         * src/maemo/easysetup/modest-easysetup-wizard.c:
 884         Added util_increment_name() and used it in create_page_account_details()
 885         to make sure that the default account name is always a new name.
 886
 887         (modest_easysetup_wizard_dialog_init),
 888         (set_default_custom_servernames): Some minor memory management fixes.
 889
 890 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 891
 892         * Makefile.am:
 893         * configure.ac:
 894         * src/modest-runtime.c: (init_i18n): Restored the translation
 895         infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
 896         are defined in config.h, and the translations are installed.
 897
 898         * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
 899         is defined for translation.
 900
 901 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
 902
 903         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
 904         (load_from_file):
 905         * src/maemo/easysetup/modest-easysetup-wizard.c:
 906         (modest_easysetup_wizard_dialog_init):
 907         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
 908         Use realistic paths (though they should use $prefix generically) to the
 909         mcc_mapping and provider-data.keyfile files which might work when they
 910         are installed by the future version of the operator-wizard package,
 911         and then fallback to paths in our source code, with an explanatory
 912         warning.
 913
 914 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
 915
 916         * configure.ac:
 917         * src/Makefile.am:
 918         * src/maemo/Makefile.am:
 919         * src/maemo/easysetup/: Added files from the previously-exernal
 920         osso-modest-easysetup.
 921         * src/maemo/modest-main-window-ui.h:
 922         * src/modest-ui-actions.c:
 923         * src/modest-ui-actions.h:
 924         Added modest_ui_actions_on_new_account() as a signal handler for the
 925         New Account menu item. It shows the easysetup wizard.
 926         * po/en_GB.po: Added additional needed logical IDs and translations.
 927
 928 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
 929 Apparently ChangeLog is not used for some vague Nokia legal reasons.
 930