1 2007-05-30 Christian Kellner <ckellner@openismus.com>
4 Search and check for libogs.
7 Incooparte the ogs build env.
9 * src/modest-mime-part-search-stream.c:
10 * src/modest-mime-part-search-stream.h:
11 Removed since we do the real searching now in modest-search.c.
13 * src/modest-search.c:
14 * src/modest-search.h:
15 Implement support for ogs. We use that if available and requested
16 and fall back to modest_text_utils_utf8_strcmp (). The search logic
17 should now handle the corner case when the search term is spread
18 across multiple reads.
19 Also the logic in modest_search () was corrected to search all
20 requested fields until one is found.
22 2007-05-30 Murray Cumming <murrayc@murrayc.com>
24 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
27 * src/modest-init.c: Made modest_init_local_folders() take a
28 path and be public so we can iniitialize maildir folders on
31 * src/modest-local-folder-info.h:
32 * src/modest-local-folder-info.c:
33 (modest_local_folder_info_get_maildir_path): Add a path parameter.
35 * src/modest-tny-account.c:
36 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
37 still means the standard local-folders path on the local volume.
39 * src/modest-tny-account-store.c:
40 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
41 signal so we can detect mount/unmount of the MMC1 card, and do an update of
42 all accounts when that happens.
43 (get_server_accounts): If the MMC1 card is mounted, create a store account for
44 this too, so it shows up in the treeview.
46 2007-05-28 Murray Cumming <murrayc@murrayc.com>
48 * src/maemo/modest-maemo-global-settings-dialog.c:
50 * src/widgets/modest-global-settings-dialog.c:
51 (current_connection_default):
52 Use the enum values instead of 0, 1 and -1,
53 to make the code clearer.
55 * src/modest-account-mgr-helpers.c:
56 (modest_account_mgr_get_connection_specific_smtp): Make this code
59 * src/modest-runtime.h:
60 * src/modest-runtime.c:
61 Added modest_runtime_remove_all_send_queues().
62 * src/maemo/modest-main-window.c:
63 (on_account_store_connecting_finished): Recreate the send queues,
64 using the appropriate transport accounts for this new connection.
65 Some futher adapting might be needed if the old send queues are not
66 automatically stopped at this point.
68 * src/modest-tny-account-store.c: (get_server_accounts):
69 Create the connection-specific transport accounts, so that they can
70 be found later by their ID.
72 * src/modest-tny-account.h:
73 * src/modest-tny-account.c:
74 Added modest_tny_account_new_from_server_account_name().
75 modest_tny_account_new_from_server_account(): Do not create the
76 send queues here, because they will be
77 recreated anyway when the connection changes for the first time.
79 2007-05-28 Murray Cumming <murrayc@murrayc.com>
81 * src/modest-local-folder-info.h:
82 * src/modest-local-folder-info.c:
83 (modest_per_account_local_outbox_folder_info_get_maildir_path),
84 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
85 tbox_folder): Take a modest account name instead of a server TnyAccount,
86 so we can have per-modest-account rather than per-transport-account
88 We must make sure that we change or recreate the exisitng send queues
89 when the connection changes for connection-specific transport accounts.
91 * src/modest-tny-account-store.c:
92 (create_per_account_local_outbox_folders): Create outboxed per modest
93 account, not per transport account.
95 * src/modest-tny-account.h:
96 * src/modest-tny-account.c:
97 (modest_tny_account_get_special_folder): For outboxes, get the
98 parent modest account name. The account is ignored for other folders.
99 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
100 modest account name rather than a server TnyAccount.
102 2007-05-25 Murray Cumming <murrayc@murrayc.com>
104 * src/modest-tny-account.c:
105 (modest_tny_account_new_from_server_account):
106 Call modest_runtime_get_send_queue() immediately after creating transport
107 accounts, so that they start trying to send email from the outbox as soon
108 as possible at startup. This is probably what we want.
110 * src/modest-mail-operation.c: (update_account_thread):
111 * src/modest-runtime.c: (modest_runtime_get_send_queue):
112 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
113 * src/modest-tny-send-queue.h:
114 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
115 (modest_ui_actions_on_send):
116 Added comments about how sending works, though it needs some more work.
118 2007-05-25 Murray Cumming <murrayc@murrayc.com>
120 * src/modest-tny-account.c:
121 (modest_tny_account_get_special_folder): Add TODO because this fails when
123 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
124 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
125 Do not try to show this window when there is no active account. The UI
126 specs does not tell us what to do in this case.
128 2007-05-24 Murray Cumming <murrayc@murrayc.com>
132 * src/maemo/Makefile.am:
133 * src/widgets/Makefile.am: Some dist fixes.
135 2007-05-24 Murray Cumming <murrayc@murrayc.com>
137 * src/maemo/modest-connection-specific-smtp-window.c:
138 (on_button_edit): Make the code clearer, to prevent a double free.
140 2007-05-24 Murray Cumming <murrayc@murrayc.com>
142 * src/maemo/modest-account-settings-dialog.c:
143 (modest_account_settings_dialog_set_account_name),
144 Check the connection-specific smtp servers checkbox if there are any.
146 * src/maemo/modest-connection-specific-smtp-edit-window.c:
147 (modest_connection_specific_smtp_edit_window_init):
148 Start with a suitable port number.
150 * src/modest-account-mgr-helpers.h:
151 * src/modest-account-mgr-helpers.c: Added
152 modest_account_mgr_get_has_connection_specific_smtp().
154 (modest_account_mgr_set_connection_specific_smtp),
155 (modest_account_mgr_remove_connection_specific_smtp),
156 (modest_account_mgr_get_has_connection_specific_smtp),
157 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
158 connection-specific smtp server accounts in the account, rather than
159 the server account conf dir.
161 This fixes bug projects.maemo.org bug NB#58263 .
163 * src/modest-tny-account-store.c:
164 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
165 if there are no server accounts yet, to prevent an infinite loop when there
166 are no accounts. Document that one must be called before the other.
168 2007-05-24 Murray Cumming <murrayc@murrayc.com>
170 * src/modest-account-mgr-helpers.c:
171 (modest_account_mgr_get_default_account): Make sure that at least
172 one account is always the default, if there are any enabled accounts.
173 This is just a sanity check that shouldn't be necessary.
175 * src/modest-account-mgr-priv.c:
176 (_modest_account_mgr_account_from_key): Unescape the conf key to
177 get the real account name. For instance, this is an issue if a space
178 was in the account name, which can happen because the account name
179 is generated from the display name.
180 (_modest_account_mgr_get_account_keyname): Always escape the
182 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
183 Unescape the conf keys to get the real account names.
185 For instance, previously the is-default radio button in the accounts
186 list was not checked for any accounts at first. This fixes that,
187 and might fix several similar bugs.
189 2007-05-23 Murray Cumming <murrayc@murrayc.com>
191 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
192 Removed some debug printfs.
194 2007-05-23 Murray Cumming <murrayc@murrayc.com>
196 Modest on-disk outbox directories are now here, for instance:
197 $HOME/.modest/outboxes/<account-id-1>/outbox
198 $HOME/.modest/outboxes/<account-id-2>/outbox
200 $HOME/.modest/local-folders/outbox
201 so we can have a separate outbox for each account.
202 But they are shown as one outbox in the GtkTreeView, by using a
203 TnyMergeFolder in a ModestTnySimpleFolderStore.
206 * src/modest-tny-simple-folder-store.c:
207 * src/modest-tny-simple-folder-store.h:
208 Added ModestTnySimpleFolderStore, used to contain folders from
209 other folder stores, such as other accounts.
211 * src/modest-tny-outbox-account.h:
212 * src/modest-tny-outbox-account.c:
213 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
214 used for the per-account local outbox folders.
216 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
217 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
218 only use this (internally) now for the non-outbox local folders.
221 * src/modest-init.c: Added modest_init_one_local_folder(), for
222 setting up the directory structure for each local folder.
224 * src/modest-local-folder-info.c:
225 (modest_per_account_local_outbox_folder_info_get_maildir_path),
226 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
228 * src/modest-local-folder-info.h:
229 * src/modest-tny-account-store.c: (on_account_removed),
230 (on_account_changed), (create_per_account_local_outbox_folders),
231 (get_server_accounts), (modest_tny_account_store_get_accounts),
232 (modest_tny_account_store_get_tny_account_by_account),
233 (modest_tny_folder_store_is_virtual_local_folders):
235 * src/modest-tny-account.h:
236 * src/modest-tny-account.c:
237 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
238 to create an on-disk per-account local outbox folder for each
240 (create_per_account_local_outbox_folders): Create a local outbox folder
241 for each transport account.
242 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
243 for all local folders.
245 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
246 instead of using g_object_get/set() directly. It is clearer.
248 (modest_tny_folder_store_get_message_count),
249 (modest_tny_folder_store_get_local_size
250 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
251 because we now use these with non-acount folder stores.
253 (modest_tny_account_get_special_folder),
254 (modest_tny_account_new_from_server_account),
255 (modest_tny_account_new_from_account):
256 (recurse_folders): Adjust to the new outbox system.
258 * src/modest-tny-folder.h:
259 * src/modest-tny-folder.c:
260 (modest_tny_folder_is_local_folder),
261 (modest_tny_folder_get_local_folder_type),
262 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
264 * src/widgets/modest-main-window.h:
265 * src/maemo/modest-main-window.c: (create_details_widget),
266 (modest_main_window_set_contents_style): Show details for any folder store,
269 (modest_tny_folder_get_rules):
270 Remove the const. C does not support constness enough for this.
272 * src/modest-ui-actions.c:
273 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
274 make all outboxes appear as one, in the usual local-folders tree node.
276 (set_active_account_from_tny_account),
277 (modest_ui_actions_on_folder_selection_changed):
278 * src/widgets/modest-folder-view.c: (text_cell_data),
279 (icon_cell_data), (filter_row),
280 (add_account_folders_to_merged_folder),
281 (add_account_folders_to_simple_folder_store), (),
282 (get_cmp_rows_type_pos), (cmp_rows),
283 (modest_folder_view_set_account_id_of_visible_server_account):
284 Adjust to the new outbox system, using generic folder stores and folders
287 2007-05-23 Christian Kellner <ckellner@openismus.com>
289 * src/modest-mail-operation.c:
290 (modest_mail_operation_update_account):
291 Use info->max_size instead of unintialized local var [small
292 build fix]. (Added TODO to review that change since I don't
295 2007-05-23 Marcus Bauer <marcusb@openismus.com>
297 * libmodest-dbus-client/libmodest-dbus-client.c:
298 (libmodest_dbus_client_compose_mail): function added
299 * src/dbus_api/modest-dbus-api.h:
300 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
301 (on_compose_mail): Implementation of the SendAsMail functionality
303 2007-05-22 Murray Cumming <murrayc@murrayc.com>
305 * src/modest-account-mgr.c:
306 (modest_account_mgr_add_server_account): Set the secure-connection
307 conf key for transport accounts as well as store accounts. I don't know
308 why the if was there. For instance, this makes sure that we use SSL
309 for the gmail preset from the easysetup wizard.
311 2007-05-22 Murray Cumming <murrayc@murrayc.com>
313 * src/gnome/modest-main-window.c:
314 (on_account_store_connecting_finished), (connect_signals):
315 * src/maemo/modest-main-window.c:
316 (on_account_store_connecting_finished), (connect_signals),
317 (modest_main_window_new):
318 Handle TnyAccountStore::connecting-finished instead of
319 TnyDevice::connection-changed, because we cannot actually perform
320 operations on accounts until TnyAccountStore has itself responded to
321 the TnyDevice::connection-changed signal. This prevents a GError from
323 Do not try to update at startup, because we (at least on scratchbox)
324 already do an update at startup when the device goes online.
325 This prevents a GError from tinymail.
326 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
327 Added TODO about stopping simultaneous operations.
329 2007-05-21 Murray Cumming <murrayc@murrayc.com>
331 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
332 * src/modest-mail-operation-queue.c:
333 (modest_mail_operation_queue_remove):
334 * src/modest-tny-account-store.c: When GErrors happen, give more clues
335 about where they happened.
337 2007-05-21 Murray Cumming <murrayc@murrayc.com>
339 * src/modest-ui-actions.c:
340 (modest_ui_actions_on_password_requested): Make sure that the remember
341 output parameter is always TRUE.
343 2007-05-21 Murray Cumming <murrayc@murrayc.com>
345 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
346 Show a OK/Cancel dialog if the error is a question, though we still do not
347 know anything more about what we are asking the user.
348 * src/widgets/modest-folder-view.c: (on_drag_data_received):
349 Fix an uninitialized variable (helper). This is a logic error, however.
351 2007-05-21 Christian Kellner <ckellner@openismus.com>
353 * src/modest-search.h:
354 Correct bit shifting in the ModestSearchFlags enum.
356 2007-05-21 Murray Cumming <murrayc@murrayc.com>
358 * src/modest-tny-account.c:
359 (modest_tny_account_new_from_server_account): Do not use the lsub and
360 check-all hard-coded IMAP options when using POP.
362 2007-05-21 Murray Cumming <murrayc@murrayc.com>
364 * src/modest-tny-account.c:
365 (modest_tny_account_new_from_server_account):
366 Use NULL for the secure-auth method for POP when Password auth has been
367 specified by the user, as we already do for IMAP. "auth=Login" causes
368 an error from camel or the server.
370 2007-05-17 Murray Cumming <murrayc@murrayc.com>
372 * src/maemo/modest-account-settings-dialog.c:
373 (create_page_account_details),
374 (modest_account_settings_dialog_set_account_name):
375 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
376 for the leave-on-server checkbox, rathr than just the checkbox, when
377 the protocol is not POP.
379 2007-05-17 Murray Cumming <murrayc@murrayc.com>
381 * src/widgets/modest-account-view.c:
382 * src/widgets/modest-account-view.h:
383 Added modest_account_view_select_account() which will be useful later
384 to asynchronously re-select the edited account.
386 2007-05-17 Murray Cumming <murrayc@murrayc.com>
388 * src/maemo/modest-account-settings-dialog.c:
389 (modest_account_settings_dialog_set_account_name):
390 Automatically choose the port numbers based on the secure authentication
391 methods, if they have not been chosen before.
392 This fixes projects.maemo.org bug NB#56273 .
394 2007-05-17 Murray Cumming <murrayc@murrayc.com>
396 * src/maemo/modest-main-window-ui.h:
397 * src/modest-ui-actions.c:
398 * src/modest-ui-actions.h:
399 Connect the Tools/SMTP Servers menu item to
400 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
401 SMTP servers dialog, as in the UI specification and saves changes when it
402 is closed. This fixed projects.maemo.org bug NB#56305 .
404 2007-05-17 Murray Cumming <murrayc@murrayc.com>
406 * src/maemo/modest-connection-specific-smtp-window.c:
407 (modest_connection_specific_smtp_window_init):
408 Use gtk_window_set_default_size() to make this window big enough, so
409 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
411 2007-05-17 Murray Cumming <murrayc@murrayc.com>
413 * src/maemo/modest-connection-specific-smtp-edit-window.h:
414 * src/maemo/modest-connection-specific-smtp-edit-window.c:
415 (modest_connection_specific_smtp_edit_window_init),
416 Do not try to connect to a combobox signal before the combobox exists.
417 This fixes the cras in projects.maemo.org bug NB#56288 .
418 (modest_connection_specific_smtp_edit_window_get_settings):
419 Remove the server_account_name parameter which was being checked for NULL
420 though it was not used.
422 * src/maemo/modest-connection-specific-smtp-window.c:
423 (modest_connection_specific_smtp_window_fill_with_connections),
424 (on_button_edit), (modest_connection_specific_smtp_window_init):
425 Correct the number of treemodel columns to prevent a warning.
426 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
427 libconic does not work.
429 2007-05-16 Murray Cumming <murrayc@murrayc.com>
431 * src/modest-tny-account.c:
432 (modest_tny_account_new_from_server_account):
433 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
434 SMTP when "None" was chosen by the user. However, with my SMTP server that
435 does not support ANONYMOUS, the emails do not leave the Outbox and I see
438 2007-05-16 Murray Cumming <murrayc@murrayc.com>
440 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
441 to explain the memory management issue with the ID in the ModestPair.
443 * src/gnome/modest-account-assistant.c: (add_receiving_page),
444 (add_sending_page), (modest_account_assistant_finalize):
445 * src/gnome/modest-gnome-global-settings-dialog.c:
446 (create_updating_page), (create_composing_page):
447 * src/gnome/modest-msg-edit-window.c: (get_transports),
448 (init_window), (modest_msg_edit_window_finalize),
449 (modest_msg_edit_window_get_msg_data):
450 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
451 * src/gnome/modest-transport-widget.c:
452 (modest_transport_widget_finalize), (smtp_configuration):
453 * src/maemo/modest-maemo-global-settings-dialog.c:
454 (create_updating_page), (create_composing_page):
455 * src/maemo/modest-msg-edit-window.c: (get_transports),
456 (init_window), (modest_msg_edit_window_finalize),
457 (modest_msg_edit_window_get_msg_data),
458 (modest_msg_edit_window_free_msg_data):
459 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
460 (modest_store_widget_finalize):
461 * src/maemo/modest-transport-widget.c:
462 (modest_transport_widget_finalize), (smtp_configuration):
463 * src/modest-main.c: (send_mail):
464 * src/widgets/modest-combo-box.h:
465 * src/widgets/modest-global-settings-dialog-priv.h:
466 * src/widgets/modest-global-settings-dialog.c:
467 (modest_global_settings_dialog_finalize):
468 * src/widgets/modest-msg-edit-window.h:
469 Whenever using modest_combo_box_new(), keep the ModestPairList alive
470 as long as the combo box, to prevent use of freed memory for the ID.
472 2007-05-15 Murray Cumming <murrayc@murrayc.com>
474 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
475 get_accounts(), to make this clearer. Do not check for the enabled gconf
476 key, because we do not use this for server accounts (at least, not yet).
477 This allows us to send email again.
479 2007-05-15 Murray Cumming <murrayc@murrayc.com>
481 * src/maemo/modest-platform.c:
482 (on_modest_conf_update_interval_changed), (modest_platform_init):
483 Only respond to this particular key change. All these strcmp()s cannot be
486 2007-05-15 Murray Cumming <murrayc@murrayc.com>
488 * src/maemo/modest-maemo-global-settings-dialog.c:
489 (current_connection): Prevent a crash in scratchbox when
490 ny_maemo_conic_device_get_current_iap_id() returns NULL.
491 * src/maemo/modest-platform.c:
492 (on_modest_conf_update_interval_changed), (modest_platform_init):
493 Get the update interval from gconf and reset it when the gconf key changes.
495 2007-05-15 Murray Cumming <murrayc@murrayc.com>
497 * src/modest-protocol-info.c:
498 * src/modest-protocol-info.h: Adde enum-specific get functions,
499 instead of using a ModestProtocolType enum parameter.
501 * src/gnome/modest-account-assistant.c:
502 * src/gnome/modest-store-widget.c:
503 * src/gnome/modest-store-widget.h:
504 * src/gnome/modest-transport-widget.c:
505 * src/gnome/modest-transport-widget.h:
506 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
507 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
508 * src/maemo/easysetup/modest-easysetup-wizard.c:
509 * src/maemo/modest-account-settings-dialog.c:
510 * src/maemo/modest-account-settings-dialog.h:
511 * src/maemo/modest-store-widget.c:
512 * src/maemo/modest-store-widget.h:
513 * src/maemo/modest-transport-widget.c:
514 * src/maemo/modest-transport-widget.h:
515 * src/modest-account-mgr-helpers.c:
516 * src/modest-account-mgr-helpers.h:
517 * src/modest-account-mgr.c:
518 * src/modest-account-mgr.h:
519 * src/modest-tny-account.c:
520 * src/modest-tny-folder.c:
521 * src/widgets/modest-account-view.c:
522 * src/widgets/modest-retrieve-combo-box.c:
523 * src/widgets/modest-retrieve-combo-box.h:
524 * src/widgets/modest-secureauth-combo-box.c:
525 * src/widgets/modest-serversecurity-combo-box.c:
526 * src/widgets/modest-serversecurity-combo-box.h:
527 * tests/check_account-mgr.c:
528 Use the specific functions, and use the re-renamed enum values for GNOME too.
530 2007-05-15 Murray Cumming <murrayc@murrayc.com>
533 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
534 so we can get the second based on the first.
536 * src/maemo/modest-account-settings-dialog.h:
537 * src/maemo/modest-account-settings-dialog.c:
538 Added get_supported_secure_authentication_methods(), though it is mostly
539 commented-out for now until the necessary API is committed to tinymail.
540 (modest_account_settings_dialog_set_account_name),
541 (save_configuration): Request the supported authentication methods from the
542 server, so we can choose a working method.
544 * src/modest-tny-account-store.h:
545 * src/modest-tny-account-store.c:
546 (modest_tny_account_store_get_session): Rename from
547 tny_account_store_get_session().
549 2007-05-14 Murray Cumming <murrayc@murrayc.com>
551 * src/modest-protocol-info.h: Split the ModestProtocol enum
552 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
553 There was no need to have these unrelated values in one enum.
555 * src/: many files: Adapted to changed enum. This makes the code a bit
556 clearer, and the compiler could catch some errors.
558 2007-05-14 Murray Cumming <murrayc@murrayc.com>
560 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
561 Show the detailed internal camel error message when an error happens
562 during the configuration, so that our testers can give us more clues.
563 For instance, in projects.maemo.org bug NB#56910 .
565 2007-05-14 Murray Cumming <murrayc@murrayc.com>
567 * src/modest-tny-account.c:
568 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
569 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
571 2007-05-14 Murray Cumming <murrayc@murrayc.com>
573 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
574 * src/maemo/modest-account-settings-dialog.c:
575 (modest_account_settings_dialog_set_account_name),
576 (save_configuration): For the incoming secure authentication checkbox,
577 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
578 the UI specification. PLAIN does not seem to be supported for most IMAP
579 servers anyway, and I am not sure what it would mean.
580 However, we probably need to discover which of the secure-authentication
581 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
582 * src/modest-account-mgr-helpers.c:
583 (modest_account_mgr_get_server_account_data):
585 * src/modest-tny-account.c:
586 (modest_tny_account_new_from_server_account):
587 Use tny_account_set_mech() to set secure-authentication methods,
588 with some special-casing for IMAP, based on my observations of how
591 * src/modest-account-mgr-helpers.h:
592 * src/modest-account-mgr.c:
593 * src/modest-defs.h: Comment that the URI is only used for local folders.
595 2007-05-11 Murray Cumming <murrayc@murrayc.com>
597 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
598 parameter const, just to be neat.
599 * src/modest-text-utils.c: (modest_text_utils_inline):
600 End g_strconcat() with NULL, as its documentation says. This is almost
601 certainly the cause of my crash at startup on the device. Interestingly,
602 valgrind doesn't tell us about these errors.
604 2007-05-11 Murray Cumming <murrayc@murrayc.com>
606 * scripts/build-packages: Added more precise comments about how to use
607 this script, though I still get this error:
608 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
609 error building tinymail
611 2007-05-11 Murray Cumming <murrayc@murrayc.com>
613 * src/maemo/modest-main-window.c: (on_account_update):
614 Very slight cleanup, hoping to make it simpler to discover what causes
615 a crash here sometimes.
617 * src/modest-tny-account.c:
618 (modest_tny_account_new_from_server_account): Set the port. Added
619 comments about the options and a TODO comment because I need to find out
620 how to specify the secure authentication method.
622 2007-05-11 Marcus Bauer <marcusb@openismus.com>
624 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
625 changed CFlags paths form modest to libmodest
627 2007-05-10 Murray Cumming <murrayc@murrayc.com>
629 * src/modest-account-mgr-helpers.c:
630 (modest_account_mgr_get_server_account_data),
631 (modest_account_mgr_free_server_account_data):
632 * src/modest-account-mgr-helpers.h:
633 * src/modest-account-mgr.c:
634 (modest_account_mgr_add_server_account):
636 * src/modest-tny-account.c:
637 (modest_tny_account_new_from_server_account):
638 Determine the options for tny_camel_account_add_option() here,
639 based on the settings, rather than storing them directly in gconf.
641 2007-05-10 Murray Cumming <murrayc@murrayc.com>
643 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
644 Show a more friendly error dialog now that we expect (from the tinymail
645 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
647 2007-05-10 Murray Cumming <murrayc@murrayc.com>
649 * src/maemo/modest-main-window.c: (on_account_update): Check that
650 account_name is not NULL, to prevent a crash at startup that I am
651 seeing on the N800. I do wonder why it is NULL.
653 * src/maemo/easysetup/modest-easysetup-wizard.c:
654 (create_page_user_details):
655 * src/maemo/modest-account-settings-dialog.c:
656 (create_page_user_details), (create_page_outgoing):
657 * src/maemo/modest-connection-specific-smtp-edit-window.c:
658 (modest_connection_specific_smtp_edit_window_init):
659 * src/modest-ui-actions.c:
660 (modest_ui_actions_on_password_requested):
661 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
662 might do something useful with the on-screen keyboard.
664 2007-05-10 Murray Cumming <murrayc@murrayc.com>
666 * src/maemo/modest-main-window.c: (on_account_update):
667 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
668 NULL, to avoid lots of warnings. However, it probably should not be NULL.
670 2007-05-09 Murray Cumming <murrayc@murrayc.com>
672 * src/modest-tny-account-store.c: (on_account_changed):
673 Correct the signature of this signal handler.
675 2007-05-09 Murray Cumming <murrayc@murrayc.com>
677 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
678 Show a HildonNote instead of a GtkDialog for Maemo.
680 2007-05-09 Murray Cumming <murrayc@murrayc.com>
682 * src/widgets/modest-account-view.h:
683 * src/widgets/modest-account-view.c: (on_account_changed),
684 (on_account_removed). Added a boolean flag, set/unset by
685 modest_account_view_block_conf_updates(),
686 modest_account_view_unblock_conf_updates() to prevent unnecessary
687 updates, but this is not very useful because the gconf notifications are
688 so delays (maybe only on Maemo Bora).
689 So auto-updating is turned off, and these functions do an explicit
690 update when necessary.
691 However, something else is still doing too much work when adding/removing
692 accounts, probably in another part of the application.
694 * src/maemo/modest-account-view-window.c:
695 (on_delete_button_clicked), (on_edit_button_clicked),
696 (on_new_button_clicked): Use the new functions.
698 2007-05-09 Murray Cumming <murrayc@murrayc.com>
700 * src/modest-account-mgr-helpers.c:
701 (modest_account_mgr_set_first_account_as_default):
702 Sort the list of names alphabetically-by-title, so we choose the first one
704 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
705 alphabetically by the title.
707 This fixes projects.maemo.org bug NB#56418 .
709 * src/modest-account-mgr-priv.c:
710 (_modest_account_mgr_account_from_key):
711 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
712 avoid a valgrind error, and possible random behaviour.
714 2007-05-09 Murray Cumming <murrayc@murrayc.com>
716 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
717 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
718 tinymail documentation to say that this can be expected.
719 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
720 pretty, and should not happen, but I would prefer to know when it does.
722 2007-05-09 Murray Cumming <murrayc@murrayc.com>
724 * configure.ac: When using the older hildon version, probably on Bora,
725 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
727 * src/widgets/modest-attachment-view.c:
728 (modest_attachment_view_set_part_default): Initialize variables, to fix the
731 2007-05-09 Marcus Bauer <marcusb@openismus.com>
733 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
734 Implemented the prototype. Can be tested with
735 tests/dbus_api/test_open_message:
737 2007-05-08 Murray Cumming <murrayc@murrayc.com>
739 * src/modest-tny-account-store.c:
740 (modest_tny_account_store_instance_init), (get_password):
741 * src/modest-ui-actions.c:
742 (modest_ui_actions_on_password_requested):
743 Do not store the password in gconf, because this function is called
744 for non-remembered passwords. Actually use the cached (in the hash map)
745 password instead of releasing it.
746 The password will now not be remembered if it is asked via the protected
747 password dialog, as per the UI spec.
749 2007-05-08 Murray Cumming <murrayc@murrayc.com>
752 * src/modest-account-mgr-helpers.h:
753 * src/modest-account-mgr-helpers.c:
754 Added modest_server_account_get_username_has_succeeded(),
755 modest_server_account_set_username_has_succeeded().
756 (modest_server_account_set_username),
757 Reset the has-succeeded flag if the username changes.
759 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
760 * src/maemo/modest-connection-specific-smtp-window.c:
761 (modest_connection_specific_smtp_window_save_server_accounts):
762 Use modest_server_account_set_username() instead of using
763 modest_conf_set_string() directly, so that the has-succeeded flag is always
766 * src/modest-ui-actions.c:
767 (modest_ui_actions_on_password_requested): Dim the username entry if
768 the username has ever worked, as per the UI spec.
770 2007-05-08 Murray Cumming <murrayc@murrayc.com>
772 * src/modest-tny-account-store.c: (get_password):
773 * src/modest-ui-actions.c:
774 (modest_ui_actions_on_password_requested):
775 Allow the username to be changed too, though there is more work to
776 be done on exactly how this behaves.
778 2007-05-08 Murray Cumming <murrayc@murrayc.com>
780 * src/modest-account-mgr-helpers.h:
781 * src/modest-account-mgr-helpers.c:
782 Added modest_account_mgr_get_display_name(),
783 modest_server_account_get_username(),
784 modest_server_account_set_username(),
785 modest_server_account_set_password(),
786 modest_server_account_get_hostname() functions so we do not need to
787 use the conf API directly.
789 * src/maemo/modest-main-window.c: (connect_signals):
790 Actually connect ot the ModestAccountStore::request-password signal,
791 so that we show the dialog when the password is requested by Tinymail,
792 for isntance if it is empty.
794 * src/modest-marshal.list:
795 * src/modest-tny-account-store.c:
796 (modest_tny_account_store_class_init), (get_password),
797 (modest_tny_account_store_alert):
798 * src/modest-tny-account-store.h:
799 * src/modest-ui-actions.h:
800 * src/modest-ui-actions.c:
801 (modest_ui_actions_on_password_requested):
802 Change the signal parameters, so it is obvious that we are providing
803 the non human-readable server name, and receiving both the username
804 and password, though changing of the username is not yet implemented.
805 Change the dialog UI to match the Maemo UI specifications, with #idfefing
806 for the GNOME version.
808 This should fix the projects.maemo.org bug NB#56209, though it does not
809 work on Bora, because the gconf_client_get() for the password fails
810 immediately after we save it with gconf_client_set().
812 2007-05-08 Murray Cumming <murrayc@murrayc.com>
815 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
816 caused an undefined symbol error:
817 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
819 2007-05-08 Murray Cumming <murrayc@murrayc.com>
821 * src/modest-tny-account-store.c:
822 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
823 using a GError instead of a string message, so we can translate it in
826 2007-05-08 Murray Cumming <murrayc@murrayc.com>
828 * src/maemo/modest-address-book.c:
829 (modest_address_book_check_names):
830 * src/maemo/modest-msg-view-window.c:
831 (modest_msg_view_window_clipboard_owner_change):
832 * src/modest-init.c: (modest_init_init_ui):
833 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
834 (update_folders_cb), (modest_mail_operation_update_account):
835 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
836 (modest_ui_actions_on_msg_attachment_clicked),
837 (modest_ui_actions_on_msg_recpt_activated):
838 * src/widgets/modest-header-view.c: (drag_data_get_cb):
839 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
840 (modest_msg_view_search_next):
841 * src/widgets/modest-recpt-editor.c:
842 (modest_recpt_editor_on_button_release_event),
843 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
844 g_message(). At this point we should only be seeing interesting errors on
845 stdout. Debugging messages could be #ifdefed-out if they are still useful.
847 2007-05-07 Murray Cumming <murrayc@murrayc.com>
849 (modest_wizard_dialog_force_title_update):
850 * src/maemo/easysetup/modest-wizard-dialog.h:
851 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
852 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
853 can update the title when appropriate. Otherwise the title is wrong if the
854 pages are added after adding the notebook to the dialog.
855 This must be a problem in HildonWizardDialog too.
856 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
858 * src/maemo/easysetup/modest-easysetup-wizard.c:
859 (create_subsequent_customsetup_pages),
860 (create_subsequent_easysetup_pages):
861 Call modest_wizard_dialog_force_title_update() so that the title is
862 correct even with GTK+ < 2.10.
863 This fixes projects.maemo.org bug NB#56145 .
865 2007-05-07 Murray Cumming <murrayc@murrayc.com>
867 * src/maemo/modest-platform.c:
868 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
869 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
872 2007-05-07 Murray Cumming <murrayc@murrayc.com>
874 * src/widgets/modest-window.h:
875 * src/widgets/modest-window.c: Added a save_state_func vfunc,
876 and modest_window_save_state(), which invokes it.
878 * src/widgets/modest-window-mgr.h:
879 * src/widgets/modest-window-mgr.c:
880 Added modest_window_mgr_save_state_for_all_windows(), which calls
881 the save_state vfunc on all registered windows, if implemented.
883 * src/gnome/modest-msg-edit-window.c:
884 * src/gnome/modest-msg-view-window.c:
885 * src/maemo/modest-msg-edit-window.c:
886 * src/maemo/modest-msg-view-window.c:
887 * src/maemo/modest-main-window.c:
888 Specify the existing save_settings functions as implementations of
889 ModestWindow::save_state_func().
891 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
892 Call modest_window_mgr_save_state_for_all_windows(). This happens before
893 enabling hibernation, for instance.
895 We may need to do the same thing for restoring settings.
898 2007-05-07 Murray Cumming <murrayc@murrayc.com>
900 * src/widgets/modest-window-mgr.c:
901 * src/widgets/modest-window-mgr.h:
902 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
903 modest_window_mgr_get_hibernation_is_prevented().
905 * src/maemo/modest-main-window.c:
906 (on_hildon_program_is_topmost_notify): Prevent hibernation
907 (possible when the application goes to the background in the WM),
908 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
910 * src/maemo/easysetup/modest-easysetup-wizard.c:
911 (modest_easysetup_wizard_dialog_init):
912 * src/maemo/modest-account-settings-dialog.c:
913 (modest_account_settings_dialog_init):
914 * src/maemo/modest-connection-specific-smtp-edit-window.c:
915 (modest_connection_specific_smtp_edit_window_init):
916 * src/maemo/modest-connection-specific-smtp-window.c:
917 (modest_connection_specific_smtp_window_init):
918 * src/maemo/modest-signature-editor-dialog.c:
919 (modest_signature_editor_dialog_init):
920 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
921 prevent hibernation while any of these account settings dialogs are open.
923 2007-05-04 Murray Cumming <murrayc@murrayc.com>
925 * src/maemo/Makefile.am:
926 * src/maemo/modest-osso-state-saving.c:
927 * src/maemo/modest-osso-state-saving.h: Added
928 modest_osso_load_state() and modest_osso_save_state() though they do
929 nothing now. They should iterate through all the open windows and load/save
931 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
932 save state when closing.
934 * src/maemo/modest-main-window.c:
935 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
936 Add a notification handler for the HildonProgram::is-topmost property,
937 so we can allow hibernation when the application goes into the background.
938 But we still need to detect when the accounts setup windows are open so
939 we can stop hibernation when they are open.
940 To do this, I also added the main window the HildonProgram. This might have
941 other side-effects/benefits, and should maybe be done for other windows.
943 * src/maemo/modest-osso-autosave-callbacks.h:
944 * src/maemo/modest-osso-autosave-callbacks.c:
945 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
946 though it does not do anything yet, and we might never need this to do
947 anything. For instance, we already save drafts.
949 * src/maemo/modest-platform.c: (modest_platform_init):
950 Specify the libosso auto-save callback.
952 2007-05-03 Murray Cumming <murrayc@murrayc.com>
954 * src/maemo/modest-platform.c:
955 (modest_platform_set_update_interval):
956 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
957 aparently stays valid between application instances, so we can use this
958 to remove and reset it later. According to a maemo-developers email from
961 2007-05-03 Murray Cumming <murrayc@murrayc.com>
963 * configure.ac: Depend on libalarm for Maemo.
965 * src/dbus_api/modest-dbus-api.h:
966 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
967 (on_send_receive), (modest_dbus_req_handler):
968 Handle a SEND_RECEIVE D-Bus method.
970 * libmodest-dbus-client/libmodest-dbus-client.c:
971 (libmodest_dbus_client_send_and_receive):
972 * libmodest-dbus-client/libmodest-dbus-client.h:
973 Add C convenience functions for calling the new D-Bus method.
975 * src/modest-platform.h:
976 * src/gnome/modest-platform.c:
977 * src/maemo/modest-platform.c:
978 Added modest_platform_set_update_interval(), which uses the
980 (modest_platform_init),
981 Call modest_platform_set_update_interval(), using a hard-coded
982 interval for now (until the global settings dialog is implemented),
983 though I am not sure that this makes sense yet.
985 2007-05-02 Murray Cumming <murrayc@murrayc.com>
987 * src/dbus_api/modest-dbus-callbacks.c:
988 (modest_osso_cb_hw_state_handler):
989 * src/dbus_api/modest-dbus-callbacks.h:
990 * src/maemo/modest-platform.c: (modest_platform_init):
991 Registered (empty) callbacks for the osso hardware state D-Bus signals,
992 in case this has some effect on the ability for Maemo to ping the
995 2007-05-02 Murray Cumming <murrayc@murrayc.com>
997 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
998 Comment out an if() that checks a gchar for < 0, causing a build-breaking
999 warning. It is probably a logic error, but I need to fix the build.
1001 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1003 * src/modest-account-mgr.h:
1004 * src/modest-account-mgr.c:
1005 (modest_account_mgr_account_names): Add a gboolean enabled_only
1006 parameter, so we can get lists of onlt the enabled accounts.
1008 (modest_account_mgr_add_account),,
1009 (modest_account_mgr_account_with_display_name_exists):
1010 * src/maemo/modest-msg-edit-window.c: (get_transports):
1011 * src/modest-account-mgr-helpers.c:
1012 (modest_account_mgr_set_first_account_as_default):
1013 * src/modest-init.c: (init_default_account_maybe):
1014 * src/modest-tny-account-store.c: (get_accounts):
1015 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1016 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1017 * tests/check_account-mgr.c: (START_TEST):
1018 Provide the extra parameter, as appropriate.
1020 * src/widgets/modest-account-view.c: (update_account_view):
1021 Do not show disabled accounts (meaning that there is no way to
1022 enable/disable accounts in the UI (the feature is not in our UI
1023 specification), so we can use this internally only to mark unfinished
1024 or temporary account data.
1026 * src/maemo/easysetup/modest-easysetup-wizard.c:
1027 (create_account): Add boolean enable parameter, so we can specify FALSE
1028 to create the temporary account.
1029 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1030 (on_before_next): When finishing, when there is a temporary account, just
1032 Also, use a timeout to delay the showing of the dialog until gconf is likely
1033 to return correct information, due to a maemo gconf bug that is fixed in
1034 osso 1.1, but not yet in Bora.
1035 However, the dialog stays on screen after it is destroyed.
1037 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1038 for invalid data when cancelling. Use a hildon note instead of a dialog
1039 to complain about invalid data. Do not show the account-saved note if the
1040 account is disabled (a temporary account that will not really be saved for use
1043 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1045 * src/modest-account-mgr-helpers.h:
1046 * src/modest-account-mgr-helpers.c:
1047 Added modest_account_mgr_unset_default_account(),
1048 Added modest_account_mgr_set_first_account_as_default().
1050 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1051 If it was the default account, unset the default account name.
1053 * src/maemo/modest-account-view-window.c:
1054 (on_delete_button_clicked): If it was the default account,
1055 set the first remaining account as the default instead.
1057 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1058 a NULL account or a NULL default account, to prevent a crash. This should
1059 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1062 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1064 * src/widgets/modest-recpt-editor.c:
1065 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1066 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1067 TODO comment for this. This fixes the build.
1069 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1070 be the best place for it. This will in future update all auto-update accounts,
1071 rather than just the current/default account, when that gconf key exists.
1072 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1073 if there are no accounts, before calling do_send_receive().
1074 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1076 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1077 * src/maemo/modest-main-window-ui.h:
1078 * src/maemo/modest-main-window.c: (on_connection_changed),
1079 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1080 directly, becaue the signal handler does more.
1082 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1084 * src/modest-account-mgr-helpers.c:
1085 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1086 for the case that the account does not exist.
1088 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1089 (equivalent to the modest account name) rather than the tinymail account name
1090 (equivalent to the modest account title - human readable) to get the account data.
1091 Check for null account data to prevent the crash, and add a TODO comment saying that
1092 this needs fixing because it is using the server account name instead of the account name.
1094 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1096 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1097 * src/maemo/modest-account-settings-dialog.c: (show_error),
1099 Use hildon_note_new_information() for informative and error messages,
1100 which seems to be expected for Maemo applications (no documentation that I know of
1101 says this). I am surprised that there is no distinction between info and error
1104 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1106 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1107 it is easy to find where this is used.
1109 * src/maemo/easysetup/modest-easysetup-wizard.c:
1110 (create_page_welcome), (create_page_account_details),
1111 (create_page_user_details), (create_page_complete_easysetup),
1112 (create_page_custom_incoming), (create_page_custom_outgoing),
1113 (create_page_complete_custom):
1114 * src/maemo/modest-account-settings-dialog.c:
1115 (create_page_account_details), (create_page_user_details),
1116 (create_page_incoming), (create_page_outgoing):
1117 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1118 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1119 (modest_connection_specific_smtp_edit_window_init):
1120 * src/maemo/modest-connection-specific-smtp-window.c:
1121 (modest_connection_specific_smtp_window_init):
1122 * src/maemo/modest-signature-editor-dialog.c:
1123 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1124 and scrolling policy as per the Email Application Layout Guide, if I have
1127 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1129 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1130 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1131 which were empty, because these vfuncs have been removed from TnyAccountStore.
1132 This fixes the build.
1134 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1136 * src/maemo/modest-main-window.c:
1137 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1138 showing/hiding it. Added TODO because it probably should not be NULL.
1139 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1140 because unnecessary g_warnings() make degugging difficult.
1142 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1144 * src/maemo/modest-msg-edit-window.c:
1145 (modest_msg_edit_window_select_color),
1146 (modest_msg_edit_window_select_background_color): 2 const corrections and
1147 moving 2 #endifs before closing brackets, to fix the build.
1149 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1151 * src/maemo/easysetup/modest-easysetup-wizard.h:
1152 * src/maemo/easysetup/modest-easysetup-wizard.c:
1153 (modest_easysetup_wizard_dialog_finalize),
1154 (on_button_edit_advanced_settings), (create_page_complete_custom),
1155 (on_response), (create_account):
1156 Implement the Advanced Settings edit button, by saving the account information,
1157 for the Advanded Settings dialog to use directly from gconf, and removing it
1158 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1159 Bug #5533 in the projects.maemo.org bugzilla.
1161 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1163 * src/maemo/modest-msg-view-window.c:
1164 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1165 when opening a message window.
1167 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1169 * src/maemo/easysetup/modest-easysetup-wizard.c:
1170 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1173 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1174 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1175 gconf settings. I probably added more checks than necessary, but that is safer.
1177 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1178 variable to fix the build, but this seems to be used when it is still NULL.
1180 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1182 * src/modest-platform.h:
1183 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1184 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1185 * src/modest-main.c: Implement this function so we can avoid using
1186 maemo-specific API from cross-platform code.
1188 * src/modest-tny-account-store.c:
1189 (get_smtp_specific_transport_account_for_open_connection):
1190 * src/modest-ui-actions.c: (check_for_connection),
1191 (modest_ui_actions_on_item_not_found):
1192 Use modest_platform_connect_and_wait() and put #idefs around other
1193 maemo-specific code, because only maemo currently has a way to
1194 identify connection names.
1196 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1198 * src/modest-tny-account-store.h:
1199 * src/modest-tny-account-store.c:
1200 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1201 the connection-specific SMTP server settings in the configuration.
1203 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1205 * src/maemo/modest-main-window.c: (on_connection_changed),
1207 * src/modest-main.c: (main), (start_ui), (send_mail):
1208 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1209 that is what is intended.
1211 * src/modest-ui-actions.c: (action_send), (action_receive),
1212 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1213 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1214 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1215 SMTP server is used when it is specified.
1217 (modest_ui_actions_on_send_receive):
1218 Check that a connection is open before proceeding.
1219 Receive and then send, instead of vice-versa, as per the specification.
1221 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1223 * src/modest-mail-operation.c:
1224 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1225 though I guess it should be something other than NULL.
1227 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1229 * src/maemo/easysetup/modest-easysetup-wizard.c:
1230 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1231 combo twice, to avoid an g_warning and to make it visible again.
1232 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1233 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1234 (already intended) dereference when detaching, because we then recreate the menu.
1235 But I am not sure why the warning was happening, and it is possible that this is a memory
1238 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1240 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1241 and uri_parse_mailto() utility functions.
1242 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1244 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1246 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1248 * src/dbus_api/modest-dbus-api.h:
1249 * src/dbus_api/modest-dbus-callbacks.c:
1250 Use an idle callback to execute the modest code in the application's own thread.
1251 Remove the helloworld example method.
1252 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1253 parsed, and the open-message method is not implemented because this is not yet implemented in
1255 * libmodest-dbus-client/libmodest-dbus-client.c:
1256 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1257 (libmodest_dbus_client_open_message):
1258 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1260 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1261 body without crashing.
1263 * tests/dbus_api/Makefile.am:
1264 * tests/dbus_api/test_mail_to.c:
1265 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1267 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1269 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1270 Added file to fix the build. Sorry.
1272 * src/dbus_api/Makefile.am:
1273 * src/dbus_api/modest-dbus-api.h:
1274 * src/dbus_api/modest-dbus-callbacks.h:
1275 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1276 (modest_dbus_req_handler):
1277 Put constants in a separate header so it can be reused by the
1278 client library, without duplication
1280 * libmodest-dbus-client/Makefile.am:
1281 * libmodest-dbus-client/libmodest-dbus-client.c:
1282 (libmodest_dbus_client_call_helloworld),
1283 (libmodfest_dbus_client_send_mail),
1284 (libmodfest_dbus_client_mailto),
1285 (libmodfest_dbus_client_open_message):
1286 * libmodest-dbus-client/libmodest-dbus-client.h:
1287 (Partly) Implement a send_mail D-Bus method.
1289 * tests/dbus_api/Makefile.am:
1290 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1291 the send_email D-Bus method.
1293 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1297 * libmodest-dbus-client/Makefile.am:
1298 * libmodest-dbus-client/libmodest-dbus-client.c:
1299 * libmodest-dbus-client/libmodest-dbus-client.h:
1300 * tests/dbus_api/Makefile.am:
1301 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1302 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1304 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1306 * src/maemo/easysetup/modest-easysetup-wizard.c:
1307 (create_page_account_details):
1308 * src/maemo/modest-account-settings-dialog.c:
1309 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1310 widgets, because this might not be the default in future versions of the Maemo GTK+.
1311 However, I can not not get capitalization to work even in a simple test case.
1313 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1315 * src/maemo/easysetup/modest-easysetup-wizard.c:
1316 (create_page_custom_incoming), (create_page_custom_outgoing):
1317 * src/maemo/modest-account-settings-dialog.c:
1318 (create_page_account_details), (create_page_incoming),
1319 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1320 instead of using gtk_check_button_with_label(), so they are aligned like the other
1321 widgets, as per the UI spec.
1323 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1325 * src/maemo/easysetup/modest-easysetup-wizard.c:
1326 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1327 * src/widgets/modest-validating-entry.c:
1328 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1329 Modest prefix instead of an EasySetup prefix.
1331 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1333 * src/widgets/modest-validating-entry.h:
1334 * src/widgets/modest-validating-entry.c: (on_insert_text),
1335 Added easysetup_validating_entry_set_max_func(), used to set a callback
1336 to call when the max number of characters is reached. GtkEntry has a max-length
1337 already but is silent about it.
1339 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1340 (create_page_account_details), (create_page_user_details),
1342 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1343 (create_page_account_details), (create_page_user_details),
1344 (create_page_outgoing):
1345 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1346 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1347 the UI spec, when the user tries to enter more than the max number of characters.
1349 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1351 * src/maemo/easysetup/modest-easysetup-wizard.c:
1352 (create_page_user_details), (create_page_custom_incoming),
1353 (create_page_custom_outgoing):
1354 * src/maemo/modest-account-settings-dialog.c:
1355 (create_page_user_details), (create_page_incoming),
1356 (create_page_outgoing):
1357 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1358 (modest_connection_specific_smtp_edit_window_init):
1359 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1360 not appropriate. Bad Maemo-specific defaults!.
1362 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1364 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1365 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1366 (modest_signature_editor_dialog_set_settings):
1367 Disable the label and textview when the checkbox is disabled, and use the
1368 specified (UI spec) default signature text.
1370 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1372 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1373 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1375 * src/modest-defs.h:
1376 * src/modest-account-mgr-helpers.h:
1377 * src/modest-account-mgr-helpers.c:
1378 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1380 * src/maemo/Makefile.am:
1381 * src/maemo/modest-signature-editor-dialog.c:
1382 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1385 * src/maemo/modest-account-settings-dialog.h:
1386 * src/maemo/modest-account-settings-dialog.c:
1387 (modest_account_settings_dialog_finalize), (on_button_signature),
1388 (save_configuration): Use the new dialog when the Edit button is pressed, and
1389 save the changes if necessary, as per the UI spec.
1391 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1393 * src/maemo/Makefile.am:
1394 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1395 based on maemo-develoers email from Dirk.
1397 * src/maemo/easysetup/modest-easysetup-wizard.c:
1398 (create_page_welcome), (create_page_account_details),
1399 (create_page_user_details), (create_page_complete_easysetup),
1400 (create_page_custom_incoming), (create_page_custom_outgoing),
1401 (create_page_complete_custom),
1402 (modest_easysetup_wizard_dialog_init):
1403 * src/maemo/modest-account-settings-dialog.c:
1404 (create_page_account_details), (create_page_user_details),
1405 (create_page_incoming), (create_page_outgoing),
1406 (modest_account_settings_dialog_init):
1407 * src/maemo/modest-connection-specific-smtp-window.c:
1408 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1410 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1412 * src/maemo/easysetup/modest-easysetup-wizard.c:
1413 (create_page_account_details), (create_page_custom_outgoing),
1414 (create_page_complete_custom):
1415 * src/maemo/modest-account-settings-dialog.c:
1416 (create_page_user_details), (create_page_incoming),
1417 (create_page_outgoing):
1418 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1419 (modest_connection_specific_smtp_edit_window_init):
1420 Use the correct (UI spec) port min/max, and use horizontal separators,
1423 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1425 * src/maemo/easysetup/modest-easysetup-wizard.c:
1426 (set_default_custom_servernames):
1427 * src/maemo/modest-account-settings-dialog.c:
1428 (create_page_incoming), (on_combo_outgoing_security_changed),
1429 (on_combo_incoming_security_changed), (create_page_outgoing),
1430 (modest_account_settings_dialog_set_account_name),
1431 (save_configuration):
1432 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1433 (on_combo_security_changed),
1434 (modest_connection_specific_smtp_edit_window_init),
1435 (modest_connection_specific_smtp_edit_window_set_connection),
1436 (modest_connection_specific_smtp_edit_window_get_settings):
1437 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1440 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1443 * src/maemo/easysetup/modest-easysetup-wizard.c:
1444 (create_page_custom_outgoing), (create_page_complete_custom):
1445 * src/maemo/modest-account-settings-dialog.c:
1446 (create_page_user_details), (create_page_outgoing):
1447 * src/maemo/modest-account-view-window.c: (button_box_new):
1448 Use changed logical IDs as per the most recent UI spec:
1449 mcen_bd_emailsetup_edit -> mcen_bd_edit
1450 mcen_bd_emailsetup_delete -> mcen_bd_delete
1451 mcen_bd_emailsetup_close -> mcen_bd_close
1453 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1457 * src/dbus_api/Makefile.am:
1458 * src/dbus_api/modest-dbus-callbacks.c:
1459 * src/dbus_api/modest-dbus-callbacks.h:
1460 * src/maemo/modest-platform.c: (modest_platform_init):
1461 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1463 * tests/Makefile.am:
1464 * tests/dbus_api/Makefile.am:
1465 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1467 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1469 * src/maemo/modest-account-settings-dialog.c:
1470 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1471 Removed unnecessary includes.
1473 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1475 * src/maemo/easysetup/modest-easysetup-wizard.c:
1476 * src/maemo/modest-account-settings-dialog.c:
1477 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1478 * src/widgets/Makefile.am:
1479 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1480 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1481 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1482 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1483 * src/widgets/modest-secureauth-combo-box.c:
1484 * src/widgets/modest-secureauth-combo-box.h:
1485 * src/widgets/modest-serversecurity-combo-box.c:
1486 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1487 made the GObject names more consistent with the rest of the Modest code.
1489 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1491 * src/maemo/easysetup/Makefile.am:
1492 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1493 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1494 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1495 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1496 * src/maemo/easysetup/modest-easysetup-wizard.c:
1497 * src/maemo/easysetup/modest-validating-entry.c:
1498 * src/maemo/easysetup/modest-validating-entry.h:
1499 * src/maemo/modest-account-settings-dialog.c:
1500 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1501 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1502 widgets/ because they are used outside of easysetup too. After checking in,
1503 svn will allow me to rename them too.
1505 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1507 * src/gnome/modest-msg-edit-window.c:
1508 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1509 linker error, to fix the build on the GNOME platform.
1510 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1511 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1512 ifdefed out to avoid a warning.
1514 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1516 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1517 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1518 some alternative for GTK+ 2.6.
1520 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1522 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1524 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1525 specified for EmailAccountsDialog in UI spec.
1527 * src/maemo/easysetup/modest-easysetup-wizard.c:
1528 * src/maemo/easysetup/modest-easysetup-wizard.h:
1529 * src/maemo/modest-account-settings-dialog.c:
1530 * src/maemo/modest-account-settings-dialog.h:
1531 Reuse a member window widget for the connection-specific SMTP server accounts,
1532 so we can tell it to create/save the accounts only if we actually save changes.
1534 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1535 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1536 (modest_connection_specific_smtp_edit_window_get_settings):
1537 Return a struct instance for temporarily remembering the entered data.
1539 * src/maemo/modest-connection-specific-smtp-window.h:
1540 * src/maemo/modest-connection-specific-smtp-window.c:
1541 (modest_connection_specific_smtp_window_finalize),
1542 (modest_connection_specific_smtp_window_fill_with_connections),
1544 (modest_connection_specific_smtp_window_save_server_accounts),
1545 (update_model_server_names): Do not actually save data until asked,
1546 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1548 (on_selection_changed),
1549 (modest_connection_specific_smtp_window_init): Disable the edit
1550 button when nothing is selected.
1552 * src/modest-account-mgr-helpers.c:
1553 * src/modest-account-mgr-helpers.h:
1554 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1557 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1559 * src/modest-account-mgr-helpers.h:
1560 * src/modest-account-mgr-helpers.c:
1561 (modest_account_mgr_get_unused_account_name),
1562 (modest_account_mgr_get_unused_account_display_name): Added these
1563 utility functions, to avoid code duplication.
1565 * src/maemo/easysetup/modest-easysetup-wizard.c:
1566 (create_page_account_details), (create_account):
1567 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1568 (on_combo_security_changed),
1569 (modest_connection_specific_smtp_edit_window_init),
1570 (modest_connection_specific_smtp_edit_window_save_settings):
1571 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1572 * src/maemo/modest-connection-specific-smtp-window.c:
1573 (modest_connection_specific_smtp_window_finalize),
1574 (modest_connection_specific_smtp_window_fill_with_connections),
1575 (on_button_edit), (modest_connection_specific_smtp_window_init):
1576 * src/maemo/modest-connection-specific-smtp-window.h:
1577 Implementing saving of connection-specific server accounts.
1579 But I need to refactor this so we can save the data for each
1580 possible connection-specific account and only actually create the server accounts
1581 when the easysetup finished, or the OK button is pressed on the account settings
1584 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1586 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1587 (on_combo_security_changed):
1588 (modest_connection_specific_smtp_edit_window_init):
1589 Auto-fill the port number as in the account settings.
1591 (modest_connection_specific_smtp_edit_window_set_connection):
1592 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1593 * src/maemo/modest-connection-specific-smtp-window.c:
1594 (fill_with_connections), (on_button_edit),
1595 (modest_connection_specific_smtp_window_init):
1596 Turn the edit window into a dialog to simplify the code, and
1597 set a WM hint as in a GtkDialog, because only a popup can be on top of
1598 another window in Maemo, and popups usually have no WM decoration.
1600 * src/modest-defs.h:
1601 * src/modest-account-mgr-helpers.c:
1602 (modest_account_mgr_set_connection_specific_smtp),
1603 (modest_account_mgr_remove_connection_specific_smtp),
1604 (modest_account_mgr_get_connection_specific_smtp):
1605 * src/modest-account-mgr-helpers.h: Some functions to write the
1606 connection-specific SMTP server information. Not yet used.
1609 * src/widgets/modest-folder-view.c: (text_cell_data):
1610 Fix a warning about an uninitialized variable.
1611 (on_configuration_key_changed): Put an #ifdef around the use
1612 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1614 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1616 * src/maemo/modest-account-settings-dialog.h:
1617 * src/maemo/modest-account-settings-dialog.c:
1618 Added connect_for_modified() utility function to mark the new modified boolean.
1620 (create_page_account_details), (create_page_user_details),
1621 (create_page_incoming), (create_page_outgoing), (on_response),
1622 (modest_account_settings_dialog_init),
1623 (modest_account_settings_dialog_set_account_name):
1624 Only warn about unsaved changes when there are actually unsaved changes.
1626 * src/modest-account-mgr-helpers.c:
1627 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1628 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1629 to get the data from there in future.
1631 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1633 * src/modest-defs.h:
1635 * src/modest-account-mgr-helpers.h:
1636 * src/modest-account-mgr-helpers.c:
1637 Store the security account setting in a single conf key instead of using
1638 the options list, so that the list is left for just the to-be-removed camel hack,
1639 and because gconf_client_set_list() is failing for some reason.
1641 * src/modest-account-mgr.c:
1642 (modest_account_mgr_add_server_account):
1643 * src/maemo/modest-account-settings-dialog.c:
1644 (modest_account_settings_dialog_set_account_name),
1645 (save_configuration): Use the renamed functions.
1648 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1650 * src/widgets/Makefile.am:
1651 * src/widgets/modest-limit-retrieve-combo-box.c:
1652 * src/widgets/modest-limit-retrieve-combo-box.h:
1653 * src/widgets/modest-retrieve-combo-box.c:
1654 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1655 the account settings dialog.
1657 * src/modest-defs.h:
1658 * src/modest-account-mgr-helpers.h:
1659 * src/modest-account-mgr-helpers.c:
1660 (modest_server_account_get_option_secure_auth),
1661 (modest_server_account_set_option_secure_auth):
1662 * src/modest-account-mgr.c:
1663 (modest_account_mgr_add_server_account):
1664 Use the existing AUTH_MECH conf key for the secure-auth setting,
1665 instead of putting it in the list options, because this was actually used already.
1667 * src/maemo/modest-account-settings-dialog.c:
1668 (create_page_account_details),
1669 (modest_account_settings_dialog_set_account_name),
1670 (save_configuration):
1671 * src/maemo/modest-account-settings-dialog.h:
1672 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1673 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1675 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1677 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1678 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1679 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1681 * src/modest-defs.h:
1682 * src/maemo/modest-account-settings-dialog.c:
1683 (create_page_incoming), (on_combo_outgoing_security_changed),
1684 (on_combo_incoming_security_changed), (create_page_outgoing),
1685 (modest_account_settings_dialog_set_account_name),
1686 (save_configuration): Load/Save the port number, and change it when the
1687 security combo changes, to suitable defaults.
1689 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1691 * src/modest-account-mgr.c:
1692 (modest_account_mgr_add_server_account): Set the security and secure-auth
1693 options, and add a comment saying that the other camel-specific options should be
1696 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1698 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1700 * src/modest-tny-account-store.c: (account_list_free),
1701 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1702 cursor->data after unreffing it. But there is some strange stuff there so it might not be
1705 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1707 * src/modest-protocol-info.c:
1708 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1709 is required by our UI spec. Maybe something in our implementation will use this eventually.
1710 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1711 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1712 instead of the previous 0 placeholder.
1714 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1715 secure-auth settings.
1716 * src/modest-account-mgr-helpers.h:
1717 * src/modest-account-mgr-helpers.c:
1718 (modest_server_account_data_get_option_secure_auth),
1719 (modest_server_account_set_option_secure_auth),
1720 (modest_server_account_data_get_option_security),
1721 (modest_server_account_set_option_security): Added this API for getting and setting the security
1722 and secure-auth settings.
1724 * src/maemo/modest-account-settings-dialog.h:
1725 * src/maemo/modest-account-settings-dialog.c:
1726 (modest_account_settings_dialog_finalize), (check_data),
1727 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1728 about changing titles.
1729 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1730 (save_configuration): Save the security and secure-auth settings.
1732 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1733 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1735 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1737 * src/modest-defs.h:
1738 * src/modest-account-mgr.c:
1739 (modest_account_mgr_add_server_account):
1740 Added and used defines for the options key and value pair strings,
1741 that are used so far, though they do not seem to correspond to anything in our
1742 UI specs or ModestProtocol enum.
1744 * src/modest-account-mgr-helpers.h:
1745 * src/modest-account-mgr-helpers.c:
1746 (compare_option_strings_for_name),
1747 (modest_server_account_data_get_option_value),
1748 (modest_server_account_data_get_option_bool),
1749 (modest_account_mgr_get_server_account_option):
1750 Added helper functions for parsing the options GSList.
1752 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1754 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1755 display name is based on the supplied account name.
1756 * src/modest-account-mgr.c:
1757 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1758 with an inefficient, but good-enough, implementation.
1760 * src/maemo/easysetup/modest-easysetup-wizard.c:
1761 (create_page_account_details), (on_before_next), (create_account):
1762 Check for existing display names rather than (non-user-visible) account names, and just
1763 create and set a unique account name at the end.
1765 * src/maemo/modest-account-settings-dialog.c:
1766 (modest_account_settings_dialog_init),
1767 (modest_account_settings_dialog_set_account_name),
1768 (create_page_incoming): Show the display name, instead of the account name.
1769 (on_response): Do some (not all) extra checks, as in the UI spec.
1770 (save_configuration): Save the display name if it was changed.
1772 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1774 * po/en_GB.po: Added needed logical ID and translation.
1775 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1776 (init_view): Made the is-default column clicking work.
1778 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1781 * src/maemo/easysetup/Makefile.am:
1782 * src/maemo/easysetup/modest-easysetup-wizard.c:
1783 (modest_easysetup_wizard_dialog_init):
1784 * src/maemo/easysetup/provider-data-test.keyfile:
1785 * src/maemo/easysetup/provider-data.keyfile:
1786 Moved the provider data file to the new modest-providers-data package and used it from there.
1788 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1790 * src/modest-local-folder-info.c:
1791 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1792 N_() was already used on the static strings, but this just marks it for translation without
1793 using the translation.
1795 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1797 * src/maemo/modest-account-settings-dialog.c:
1798 (create_page_incoming),
1799 (modest_account_settings_dialog_set_account_name):
1800 Added comments about the need for new API in ModestAccountMgr to handle the authentication
1801 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1802 I will do this if nobody else gets there first.
1804 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1806 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1807 Saved much of the incoming and outgoing data too, though I cannot yet see how to
1808 save the security stuff.
1810 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1812 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1813 Set the email address and user fullname, which I now see must be
1816 * src/maemo/modest-account-settings-dialog.h:
1817 * src/maemo/modest-account-settings-dialog.c:
1819 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1820 leave-on-server and authentication.
1821 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1824 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1827 * src/maemo/modest-account-settings-dialog.c:
1828 * src/maemo/modest-account-settings-dialog.h:
1829 Most (but not all) of the widgets are now present as specified by the UI spec.
1830 No changes are yet saved, and some details are not properly shown yet.
1832 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1834 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1836 * src/maemo/Makefile.am:
1837 * src/maemo/modest-account-settings-dialog.c:
1838 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1839 an existing account. Doesn't do much yet.
1841 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1842 Open the accounts settings dialog when Edit is clicked.
1844 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1846 * src/maemo/easysetup/Makefile.am:
1847 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1849 * src/maemo/easysetup/modest-easysetup-wizard.c:
1850 (modest_easysetup_wizard_dialog_init):
1851 Try to get the source directory from the build system,
1852 instead of hard-coding "./" into the source code, when opening our local
1853 copies of the configuration files.
1854 But this still fails when opening the wizard from the Accounts window,
1855 maybe because the working directory seems to change at runtime.
1856 So the wizard will fail the second time unless you copy the files into their
1857 proper locations - see the stdout warnings for the paths.
1859 (create_page_account_details),(on_before_next):
1860 Check for existing non-server accounts instead of server accounts,
1861 so the default account name is useful again, and to prevent trying to
1864 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1865 Show the wizard when New is clicked.
1867 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1868 (init_view): Show the column headers, and show the columns that are
1869 specified in the UI specs. However, something in Maemo's GTK+ prevents
1870 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1871 change the default account. This is despite unsetting the special properties.
1873 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1875 * docs/reference/modest-design.sgml: Corrected spelling mistake.
1876 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1877 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1878 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1879 to make that clearer.
1880 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1882 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1884 * src/maemo/modest-account-view-window.c:
1885 (modest_account_view_window_init),
1886 (modest_account_view_window_new):
1887 Use the same buttons as specified in the
1888 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1889 the existing widgets, which never had a chance of working.
1890 Put the ModestAccountView treeview in a scrolled window.
1891 Do not repeat the initialization in both _init() and _new().
1893 * src/widgets/modest-account-view.c: (update_account_view):
1894 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1895 this widget and window shows no accounts.
1897 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1899 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1901 * src/maemo/easysetup/modest-easysetup-wizard.c:
1902 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1903 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1904 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1907 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1908 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1909 accounts exist yet, as in the UI spec.
1911 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
1913 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1915 * src/maemo/Makefile.am:
1916 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1917 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1918 New window for editing connection-specific smtp details.
1919 Not fully implemented.
1921 * src/maemo/modest-connection-specific-smtp-window.c:
1922 (modest_connection_specific_smtp_window_finalize) :
1923 unref the tree model.
1924 (on_button_edit): Show the edit window.
1926 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1928 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
1931 * src/maemo/Makefile.am:
1932 * src/maemo/modest-connection-specific-smtp-window.c:
1933 * src/maemo/modest-connection-specific-smtp-window.h:
1934 New window for showing the list of connections, for connection-specific
1935 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
1936 * src/maemo/easysetup/modest-easysetup-wizard.c:
1937 (create_page_custom_outgoing): Show the new window when the button is clicked.
1939 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1941 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1942 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1943 * src/maemo/modest-msg-edit-window.c:
1944 (modest_msg_edit_window_insert_image):
1945 * src/modest-conf.c: (modest_conf_key_escape):
1946 * src/modest-mail-operation.c:
1947 (modest_mail_operation_send_new_mail):
1948 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1949 (modest_ui_actions_on_new_account):
1950 * src/widgets/modest-attachment-view.c: (update_filename_request):
1951 * src/widgets/modest-mail-header-view.c:
1952 Corrected warnings that were breaking the build, by commenting out unused variables,
1953 and a function, and by including a header.
1955 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1957 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
1958 so we can #ifdef around platform-specific code when necessary.
1959 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
1960 to allow this to build for the GNOME platform too.
1962 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1964 * src/maemo/easysetup/modest-easysetup-wizard.c:
1965 Added util_increment_name() and used it in create_page_account_details()
1966 to make sure that the default account name is always a new name.
1968 (modest_easysetup_wizard_dialog_init),
1969 (set_default_custom_servernames): Some minor memory management fixes.
1971 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1975 * src/modest-runtime.c: (init_i18n): Restored the translation
1976 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
1977 are defined in config.h, and the translations are installed.
1979 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
1980 is defined for translation.
1982 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1984 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1986 * src/maemo/easysetup/modest-easysetup-wizard.c:
1987 (modest_easysetup_wizard_dialog_init):
1988 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1989 Use realistic paths (though they should use $prefix generically) to the
1990 mcc_mapping and provider-data.keyfile files which might work when they
1991 are installed by the future version of the operator-wizard package,
1992 and then fallback to paths in our source code, with an explanatory
1995 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1999 * src/maemo/Makefile.am:
2000 * src/maemo/easysetup/: Added files from the previously-exernal
2001 osso-modest-easysetup.
2002 * src/maemo/modest-main-window-ui.h:
2003 * src/modest-ui-actions.c:
2004 * src/modest-ui-actions.h:
2005 Added modest_ui_actions_on_new_account() as a signal handler for the
2006 New Account menu item. It shows the easysetup wizard.
2007 * po/en_GB.po: Added additional needed logical IDs and translations.
2009 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2010 Apparently ChangeLog is not used for some vague Nokia legal reasons.