1 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/modest-main-window.c: (on_account_update):
4 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
5 NULL, to avoid lots of warnings. However, it probably should not be NULL.
7 2007-05-09 Murray Cumming <murrayc@murrayc.com>
9 * src/modest-tny-account-store.c: (on_account_changed):
10 Correct the signature of this signal handler.
12 2007-05-09 Murray Cumming <murrayc@murrayc.com>
14 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
15 Show a HildonNote instead of a GtkDialog for Maemo.
17 2007-05-09 Murray Cumming <murrayc@murrayc.com>
19 * src/widgets/modest-account-view.h:
20 * src/widgets/modest-account-view.c: (on_account_changed),
21 (on_account_removed). Added a boolean flag, set/unset by
22 modest_account_view_block_conf_updates(),
23 modest_account_view_unblock_conf_updates() to prevent unnecessary
24 updates, but this is not very useful because the gconf notifications are
25 so delays (maybe only on Maemo Bora).
26 So auto-updating is turned off, and these functions do an explicit
27 update when necessary.
28 However, something else is still doing too much work when adding/removing
29 accounts, probably in another part of the application.
31 * src/maemo/modest-account-view-window.c:
32 (on_delete_button_clicked), (on_edit_button_clicked),
33 (on_new_button_clicked): Use the new functions.
35 2007-05-09 Murray Cumming <murrayc@murrayc.com>
37 * src/modest-account-mgr-helpers.c:
38 (modest_account_mgr_set_first_account_as_default):
39 Sort the list of names alphabetically-by-title, so we choose the first one
41 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
42 alphabetically by the title.
44 This fixes projects.maemo.org bug NB#56418 .
46 * src/modest-account-mgr-priv.c:
47 (_modest_account_mgr_account_from_key):
48 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
49 avoid a valgrind error, and possible random behaviour.
51 2007-05-09 Murray Cumming <murrayc@murrayc.com>
53 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
54 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
55 tinymail documentation to say that this can be expected.
56 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
57 pretty, and should not happen, but I would prefer to know when it does.
59 2007-05-09 Murray Cumming <murrayc@murrayc.com>
61 * configure.ac: When using the older hildon version, probably on Bora,
62 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
64 * src/widgets/modest-attachment-view.c:
65 (modest_attachment_view_set_part_default): Initialize variables, to fix the
68 2007-05-09 Marcus Bauer <marcusb@openismus.com>
70 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
71 Implemented the prototype. Can be tested with
72 tests/dbus_api/test_open_message:
74 2007-05-08 Murray Cumming <murrayc@murrayc.com>
76 * src/modest-tny-account-store.c:
77 (modest_tny_account_store_instance_init), (get_password):
78 * src/modest-ui-actions.c:
79 (modest_ui_actions_on_password_requested):
80 Do not store the password in gconf, because this function is called
81 for non-remembered passwords. Actually use the cached (in the hash map)
82 password instead of releasing it.
83 The password will now not be remembered if it is asked via the protected
84 password dialog, as per the UI spec.
86 2007-05-08 Murray Cumming <murrayc@murrayc.com>
89 * src/modest-account-mgr-helpers.h:
90 * src/modest-account-mgr-helpers.c:
91 Added modest_server_account_get_username_has_succeeded(),
92 modest_server_account_set_username_has_succeeded().
93 (modest_server_account_set_username),
94 Reset the has-succeeded flag if the username changes.
96 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
97 * src/maemo/modest-connection-specific-smtp-window.c:
98 (modest_connection_specific_smtp_window_save_server_accounts):
99 Use modest_server_account_set_username() instead of using
100 modest_conf_set_string() directly, so that the has-succeeded flag is always
103 * src/modest-ui-actions.c:
104 (modest_ui_actions_on_password_requested): Dim the username entry if
105 the username has ever worked, as per the UI spec.
107 2007-05-08 Murray Cumming <murrayc@murrayc.com>
109 * src/modest-tny-account-store.c: (get_password):
110 * src/modest-ui-actions.c:
111 (modest_ui_actions_on_password_requested):
112 Allow the username to be changed too, though there is more work to
113 be done on exactly how this behaves.
115 2007-05-08 Murray Cumming <murrayc@murrayc.com>
117 * src/modest-account-mgr-helpers.h:
118 * src/modest-account-mgr-helpers.c:
119 Added modest_account_mgr_get_display_name(),
120 modest_server_account_get_username(),
121 modest_server_account_set_username(),
122 modest_server_account_set_password(),
123 modest_server_account_get_hostname() functions so we do not need to
124 use the conf API directly.
126 * src/maemo/modest-main-window.c: (connect_signals):
127 Actually connect ot the ModestAccountStore::request-password signal,
128 so that we show the dialog when the password is requested by Tinymail,
129 for isntance if it is empty.
131 * src/modest-marshal.list:
132 * src/modest-tny-account-store.c:
133 (modest_tny_account_store_class_init), (get_password),
134 (modest_tny_account_store_alert):
135 * src/modest-tny-account-store.h:
136 * src/modest-ui-actions.h:
137 * src/modest-ui-actions.c:
138 (modest_ui_actions_on_password_requested):
139 Change the signal parameters, so it is obvious that we are providing
140 the non human-readable server name, and receiving both the username
141 and password, though changing of the username is not yet implemented.
142 Change the dialog UI to match the Maemo UI specifications, with #idfefing
143 for the GNOME version.
145 This should fix the projects.maemo.org bug NB#56209, though it does not
146 work on Bora, because the gconf_client_get() for the password fails
147 immediately after we save it with gconf_client_set().
149 2007-05-08 Murray Cumming <murrayc@murrayc.com>
152 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
153 caused an undefined symbol error:
154 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
156 2007-05-08 Murray Cumming <murrayc@murrayc.com>
158 * src/modest-tny-account-store.c:
159 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
160 using a GError instead of a string message, so we can translate it in
163 2007-05-08 Murray Cumming <murrayc@murrayc.com>
165 * src/maemo/modest-address-book.c:
166 (modest_address_book_check_names):
167 * src/maemo/modest-msg-view-window.c:
168 (modest_msg_view_window_clipboard_owner_change):
169 * src/modest-init.c: (modest_init_init_ui):
170 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
171 (update_folders_cb), (modest_mail_operation_update_account):
172 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
173 (modest_ui_actions_on_msg_attachment_clicked),
174 (modest_ui_actions_on_msg_recpt_activated):
175 * src/widgets/modest-header-view.c: (drag_data_get_cb):
176 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
177 (modest_msg_view_search_next):
178 * src/widgets/modest-recpt-editor.c:
179 (modest_recpt_editor_on_button_release_event),
180 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
181 g_message(). At this point we should only be seeing interesting errors on
182 stdout. Debugging messages could be #ifdefed-out if they are still useful.
184 2007-05-07 Murray Cumming <murrayc@murrayc.com>
186 (modest_wizard_dialog_force_title_update):
187 * src/maemo/easysetup/modest-wizard-dialog.h:
188 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
189 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
190 can update the title when appropriate. Otherwise the title is wrong if the
191 pages are added after adding the notebook to the dialog.
192 This must be a problem in HildonWizardDialog too.
193 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
195 * src/maemo/easysetup/modest-easysetup-wizard.c:
196 (create_subsequent_customsetup_pages),
197 (create_subsequent_easysetup_pages):
198 Call modest_wizard_dialog_force_title_update() so that the title is
199 correct even with GTK+ < 2.10.
200 This fixes projects.maemo.org bug NB#56145 .
202 2007-05-07 Murray Cumming <murrayc@murrayc.com>
204 * src/maemo/modest-platform.c:
205 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
206 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
209 2007-05-07 Murray Cumming <murrayc@murrayc.com>
211 * src/widgets/modest-window.h:
212 * src/widgets/modest-window.c: Added a save_state_func vfunc,
213 and modest_window_save_state(), which invokes it.
215 * src/widgets/modest-window-mgr.h:
216 * src/widgets/modest-window-mgr.c:
217 Added modest_window_mgr_save_state_for_all_windows(), which calls
218 the save_state vfunc on all registered windows, if implemented.
220 * src/gnome/modest-msg-edit-window.c:
221 * src/gnome/modest-msg-view-window.c:
222 * src/maemo/modest-msg-edit-window.c:
223 * src/maemo/modest-msg-view-window.c:
224 * src/maemo/modest-main-window.c:
225 Specify the existing save_settings functions as implementations of
226 ModestWindow::save_state_func().
228 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
229 Call modest_window_mgr_save_state_for_all_windows(). This happens before
230 enabling hibernation, for instance.
232 We may need to do the same thing for restoring settings.
235 2007-05-07 Murray Cumming <murrayc@murrayc.com>
237 * src/widgets/modest-window-mgr.c:
238 * src/widgets/modest-window-mgr.h:
239 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
240 modest_window_mgr_get_hibernation_is_prevented().
242 * src/maemo/modest-main-window.c:
243 (on_hildon_program_is_topmost_notify): Prevent hibernation
244 (possible when the application goes to the background in the WM),
245 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
247 * src/maemo/easysetup/modest-easysetup-wizard.c:
248 (modest_easysetup_wizard_dialog_init):
249 * src/maemo/modest-account-settings-dialog.c:
250 (modest_account_settings_dialog_init):
251 * src/maemo/modest-connection-specific-smtp-edit-window.c:
252 (modest_connection_specific_smtp_edit_window_init):
253 * src/maemo/modest-connection-specific-smtp-window.c:
254 (modest_connection_specific_smtp_window_init):
255 * src/maemo/modest-signature-editor-dialog.c:
256 (modest_signature_editor_dialog_init):
257 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
258 prevent hibernation while any of these account settings dialogs are open.
260 2007-05-04 Murray Cumming <murrayc@murrayc.com>
262 * src/maemo/Makefile.am:
263 * src/maemo/modest-osso-state-saving.c:
264 * src/maemo/modest-osso-state-saving.h: Added
265 modest_osso_load_state() and modest_osso_save_state() though they do
266 nothing now. They should iterate through all the open windows and load/save
268 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
269 save state when closing.
271 * src/maemo/modest-main-window.c:
272 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
273 Add a notification handler for the HildonProgram::is-topmost property,
274 so we can allow hibernation when the application goes into the background.
275 But we still need to detect when the accounts setup windows are open so
276 we can stop hibernation when they are open.
277 To do this, I also added the main window the HildonProgram. This might have
278 other side-effects/benefits, and should maybe be done for other windows.
280 * src/maemo/modest-osso-autosave-callbacks.h:
281 * src/maemo/modest-osso-autosave-callbacks.c:
282 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
283 though it does not do anything yet, and we might never need this to do
284 anything. For instance, we already save drafts.
286 * src/maemo/modest-platform.c: (modest_platform_init):
287 Specify the libosso auto-save callback.
289 2007-05-03 Murray Cumming <murrayc@murrayc.com>
291 * src/maemo/modest-platform.c:
292 (modest_platform_set_update_interval):
293 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
294 aparently stays valid between application instances, so we can use this
295 to remove and reset it later. According to a maemo-developers email from
298 2007-05-03 Murray Cumming <murrayc@murrayc.com>
300 * configure.ac: Depend on libalarm for Maemo.
302 * src/dbus_api/modest-dbus-api.h:
303 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
304 (on_send_receive), (modest_dbus_req_handler):
305 Handle a SEND_RECEIVE D-Bus method.
307 * libmodest-dbus-client/libmodest-dbus-client.c:
308 (libmodest_dbus_client_send_and_receive):
309 * libmodest-dbus-client/libmodest-dbus-client.h:
310 Add C convenience functions for calling the new D-Bus method.
312 * src/modest-platform.h:
313 * src/gnome/modest-platform.c:
314 * src/maemo/modest-platform.c:
315 Added modest_platform_set_update_interval(), which uses the
317 (modest_platform_init),
318 Call modest_platform_set_update_interval(), using a hard-coded
319 interval for now (until the global settings dialog is implemented),
320 though I am not sure that this makes sense yet.
322 2007-05-02 Murray Cumming <murrayc@murrayc.com>
324 * src/dbus_api/modest-dbus-callbacks.c:
325 (modest_osso_cb_hw_state_handler):
326 * src/dbus_api/modest-dbus-callbacks.h:
327 * src/maemo/modest-platform.c: (modest_platform_init):
328 Registered (empty) callbacks for the osso hardware state D-Bus signals,
329 in case this has some effect on the ability for Maemo to ping the
332 2007-05-02 Murray Cumming <murrayc@murrayc.com>
334 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
335 Comment out an if() that checks a gchar for < 0, causing a build-breaking
336 warning. It is probably a logic error, but I need to fix the build.
338 2007-05-02 Murray Cumming <murrayc@murrayc.com>
340 * src/modest-account-mgr.h:
341 * src/modest-account-mgr.c:
342 (modest_account_mgr_account_names): Add a gboolean enabled_only
343 parameter, so we can get lists of onlt the enabled accounts.
345 (modest_account_mgr_add_account),,
346 (modest_account_mgr_account_with_display_name_exists):
347 * src/maemo/modest-msg-edit-window.c: (get_transports):
348 * src/modest-account-mgr-helpers.c:
349 (modest_account_mgr_set_first_account_as_default):
350 * src/modest-init.c: (init_default_account_maybe):
351 * src/modest-tny-account-store.c: (get_accounts):
352 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
353 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
354 * tests/check_account-mgr.c: (START_TEST):
355 Provide the extra parameter, as appropriate.
357 * src/widgets/modest-account-view.c: (update_account_view):
358 Do not show disabled accounts (meaning that there is no way to
359 enable/disable accounts in the UI (the feature is not in our UI
360 specification), so we can use this internally only to mark unfinished
361 or temporary account data.
363 * src/maemo/easysetup/modest-easysetup-wizard.c:
364 (create_account): Add boolean enable parameter, so we can specify FALSE
365 to create the temporary account.
366 (on_button_edit_advanced_settings): Create the temporary account as disabled.
367 (on_before_next): When finishing, when there is a temporary account, just
369 Also, use a timeout to delay the showing of the dialog until gconf is likely
370 to return correct information, due to a maemo gconf bug that is fixed in
371 osso 1.1, but not yet in Bora.
372 However, the dialog stays on screen after it is destroyed.
374 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
375 for invalid data when cancelling. Use a hildon note instead of a dialog
376 to complain about invalid data. Do not show the account-saved note if the
377 account is disabled (a temporary account that will not really be saved for use
380 2007-04-30 Murray Cumming <murrayc@murrayc.com>
382 * src/modest-account-mgr-helpers.h:
383 * src/modest-account-mgr-helpers.c:
384 Added modest_account_mgr_unset_default_account(),
385 Added modest_account_mgr_set_first_account_as_default().
387 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
388 If it was the default account, unset the default account name.
390 * src/maemo/modest-account-view-window.c:
391 (on_delete_button_clicked): If it was the default account,
392 set the first remaining account as the default instead.
394 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
395 a NULL account or a NULL default account, to prevent a crash. This should
396 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
399 2007-04-30 Murray Cumming <murrayc@murrayc.com>
401 * src/widgets/modest-recpt-editor.c:
402 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
403 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
404 TODO comment for this. This fixes the build.
406 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
407 be the best place for it. This will in future update all auto-update accounts,
408 rather than just the current/default account, when that gconf key exists.
409 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
410 if there are no accounts, before calling do_send_receive().
411 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
413 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
414 * src/maemo/modest-main-window-ui.h:
415 * src/maemo/modest-main-window.c: (on_connection_changed),
416 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
417 directly, becaue the signal handler does more.
419 2007-04-30 Murray Cumming <murrayc@murrayc.com>
421 * src/modest-account-mgr-helpers.c:
422 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
423 for the case that the account does not exist.
425 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
426 (equivalent to the modest account name) rather than the tinymail account name
427 (equivalent to the modest account title - human readable) to get the account data.
428 Check for null account data to prevent the crash, and add a TODO comment saying that
429 this needs fixing because it is using the server account name instead of the account name.
431 2007-04-29 Murray Cumming <murrayc@murrayc.com>
433 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
434 * src/maemo/modest-account-settings-dialog.c: (show_error),
436 Use hildon_note_new_information() for informative and error messages,
437 which seems to be expected for Maemo applications (no documentation that I know of
438 says this). I am surprised that there is no distinction between info and error
441 2007-04-29 Murray Cumming <murrayc@murrayc.com>
443 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
444 it is easy to find where this is used.
446 * src/maemo/easysetup/modest-easysetup-wizard.c:
447 (create_page_welcome), (create_page_account_details),
448 (create_page_user_details), (create_page_complete_easysetup),
449 (create_page_custom_incoming), (create_page_custom_outgoing),
450 (create_page_complete_custom):
451 * src/maemo/modest-account-settings-dialog.c:
452 (create_page_account_details), (create_page_user_details),
453 (create_page_incoming), (create_page_outgoing):
454 * src/maemo/modest-account-view-window.c: (window_vbox_new):
455 * src/maemo/modest-connection-specific-smtp-edit-window.c:
456 (modest_connection_specific_smtp_edit_window_init):
457 * src/maemo/modest-connection-specific-smtp-window.c:
458 (modest_connection_specific_smtp_window_init):
459 * src/maemo/modest-signature-editor-dialog.c:
460 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
461 and scrolling policy as per the Email Application Layout Guide, if I have
464 2007-04-27 Murray Cumming <murrayc@murrayc.com>
466 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
467 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
468 which were empty, because these vfuncs have been removed from TnyAccountStore.
469 This fixes the build.
471 2007-04-27 Murray Cumming <murrayc@murrayc.com>
473 * src/maemo/modest-main-window.c:
474 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
475 showing/hiding it. Added TODO because it probably should not be NULL.
476 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
477 because unnecessary g_warnings() make degugging difficult.
479 2007-04-27 Murray Cumming <murrayc@murrayc.com>
481 * src/maemo/modest-msg-edit-window.c:
482 (modest_msg_edit_window_select_color),
483 (modest_msg_edit_window_select_background_color): 2 const corrections and
484 moving 2 #endifs before closing brackets, to fix the build.
486 2007-04-27 Murray Cumming <murrayc@murrayc.com>
488 * src/maemo/easysetup/modest-easysetup-wizard.h:
489 * src/maemo/easysetup/modest-easysetup-wizard.c:
490 (modest_easysetup_wizard_dialog_finalize),
491 (on_button_edit_advanced_settings), (create_page_complete_custom),
492 (on_response), (create_account):
493 Implement the Advanced Settings edit button, by saving the account information,
494 for the Advanded Settings dialog to use directly from gconf, and removing it
495 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
496 Bug #5533 in the projects.maemo.org bugzilla.
498 2007-04-27 Murray Cumming <murrayc@murrayc.com>
500 * src/maemo/modest-msg-view-window.c:
501 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
502 when opening a message window.
504 2007-04-27 Murray Cumming <murrayc@murrayc.com>
506 * src/maemo/easysetup/modest-easysetup-wizard.c:
507 (create_page_custom_outgoing): Correct the position of the horizontal separator to
510 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
511 before showing/hiding them, to avoid a crash when clicking on folders when there are no
512 gconf settings. I probably added more checks than necessary, but that is safer.
514 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
515 variable to fix the build, but this seems to be used when it is still NULL.
517 2007-04-27 Murray Cumming <murrayc@murrayc.com>
519 * src/modest-platform.h:
520 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
521 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
522 * src/modest-main.c: Implement this function so we can avoid using
523 maemo-specific API from cross-platform code.
525 * src/modest-tny-account-store.c:
526 (get_smtp_specific_transport_account_for_open_connection):
527 * src/modest-ui-actions.c: (check_for_connection),
528 (modest_ui_actions_on_item_not_found):
529 Use modest_platform_connect_and_wait() and put #idefs around other
530 maemo-specific code, because only maemo currently has a way to
531 identify connection names.
533 2007-04-27 Murray Cumming <murrayc@murrayc.com>
535 * src/modest-tny-account-store.h:
536 * src/modest-tny-account-store.c:
537 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
538 the connection-specific SMTP server settings in the configuration.
540 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
542 * src/maemo/modest-main-window.c: (on_connection_changed),
544 * src/modest-main.c: (main), (start_ui), (send_mail):
545 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
546 that is what is intended.
548 * src/modest-ui-actions.c: (action_send), (action_receive),
549 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
550 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
551 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
552 SMTP server is used when it is specified.
554 (modest_ui_actions_on_send_receive):
555 Check that a connection is open before proceeding.
556 Receive and then send, instead of vice-versa, as per the specification.
558 2007-04-26 Murray Cumming <murrayc@murrayc.com>
560 * src/modest-mail-operation.c:
561 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
562 though I guess it should be something other than NULL.
564 2007-04-26 Murray Cumming <murrayc@murrayc.com>
566 * src/maemo/easysetup/modest-easysetup-wizard.c:
567 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
568 combo twice, to avoid an g_warning and to make it visible again.
569 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
570 attached before detaching it, to avoid a g_warning, and add comment about the implicit
571 (already intended) dereference when detaching, because we then recreate the menu.
572 But I am not sure why the warning was happening, and it is possible that this is a memory
575 2007-04-25 Murray Cumming <murrayc@murrayc.com>
577 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
578 and uri_parse_mailto() utility functions.
579 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
581 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
583 2007-04-24 Murray Cumming <murrayc@murrayc.com>
585 * src/dbus_api/modest-dbus-api.h:
586 * src/dbus_api/modest-dbus-callbacks.c:
587 Use an idle callback to execute the modest code in the application's own thread.
588 Remove the helloworld example method.
589 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
590 parsed, and the open-message method is not implemented because this is not yet implemented in
592 * libmodest-dbus-client/libmodest-dbus-client.c:
593 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
594 (libmodest_dbus_client_open_message):
595 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
597 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
598 body without crashing.
600 * tests/dbus_api/Makefile.am:
601 * tests/dbus_api/test_mail_to.c:
602 * tests/dbus_api/test_open_message.c: New tests for the new methods.
604 2007-04-24 Murray Cumming <murrayc@murrayc.com>
606 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
607 Added file to fix the build. Sorry.
609 * src/dbus_api/Makefile.am:
610 * src/dbus_api/modest-dbus-api.h:
611 * src/dbus_api/modest-dbus-callbacks.h:
612 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
613 (modest_dbus_req_handler):
614 Put constants in a separate header so it can be reused by the
615 client library, without duplication
617 * libmodest-dbus-client/Makefile.am:
618 * libmodest-dbus-client/libmodest-dbus-client.c:
619 (libmodest_dbus_client_call_helloworld),
620 (libmodfest_dbus_client_send_mail),
621 (libmodfest_dbus_client_mailto),
622 (libmodfest_dbus_client_open_message):
623 * libmodest-dbus-client/libmodest-dbus-client.h:
624 (Partly) Implement a send_mail D-Bus method.
626 * tests/dbus_api/Makefile.am:
627 * tests/dbus_api/test_send_mail.c: (main): Added a test for
628 the send_email D-Bus method.
630 2007-04-24 Murray Cumming <murrayc@murrayc.com>
634 * libmodest-dbus-client/Makefile.am:
635 * libmodest-dbus-client/libmodest-dbus-client.c:
636 * libmodest-dbus-client/libmodest-dbus-client.h:
637 * tests/dbus_api/Makefile.am:
638 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
639 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
641 2007-04-24 Murray Cumming <murrayc@murrayc.com>
643 * src/maemo/easysetup/modest-easysetup-wizard.c:
644 (create_page_account_details):
645 * src/maemo/modest-account-settings-dialog.c:
646 (create_page_account_details): Explicitly set auto-capitalization mode for the title
647 widgets, because this might not be the default in future versions of the Maemo GTK+.
648 However, I can not not get capitalization to work even in a simple test case.
650 2007-04-24 Murray Cumming <murrayc@murrayc.com>
652 * src/maemo/easysetup/modest-easysetup-wizard.c:
653 (create_page_custom_incoming), (create_page_custom_outgoing):
654 * src/maemo/modest-account-settings-dialog.c:
655 (create_page_account_details), (create_page_incoming),
656 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
657 instead of using gtk_check_button_with_label(), so they are aligned like the other
658 widgets, as per the UI spec.
660 2007-04-24 Murray Cumming <murrayc@murrayc.com>
662 * src/maemo/easysetup/modest-easysetup-wizard.c:
663 * src/maemo/modest-connection-specific-smtp-edit-window.c:
664 * src/widgets/modest-validating-entry.c:
665 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
666 Modest prefix instead of an EasySetup prefix.
668 2007-04-23 Murray Cumming <murrayc@murrayc.com>
670 * src/widgets/modest-validating-entry.h:
671 * src/widgets/modest-validating-entry.c: (on_insert_text),
672 Added easysetup_validating_entry_set_max_func(), used to set a callback
673 to call when the max number of characters is reached. GtkEntry has a max-length
674 already but is silent about it.
676 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
677 (create_page_account_details), (create_page_user_details),
679 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
680 (create_page_account_details), (create_page_user_details),
681 (create_page_outgoing):
682 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
683 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
684 the UI spec, when the user tries to enter more than the max number of characters.
686 2007-04-23 Murray Cumming <murrayc@murrayc.com>
688 * src/maemo/easysetup/modest-easysetup-wizard.c:
689 (create_page_user_details), (create_page_custom_incoming),
690 (create_page_custom_outgoing):
691 * src/maemo/modest-account-settings-dialog.c:
692 (create_page_user_details), (create_page_incoming),
693 (create_page_outgoing):
694 * src/maemo/modest-connection-specific-smtp-edit-window.c:
695 (modest_connection_specific_smtp_edit_window_init):
696 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
697 not appropriate. Bad Maemo-specific defaults!.
699 2007-04-23 Murray Cumming <murrayc@murrayc.com>
701 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
702 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
703 (modest_signature_editor_dialog_set_settings):
704 Disable the label and textview when the checkbox is disabled, and use the
705 specified (UI spec) default signature text.
707 2007-04-23 Murray Cumming <murrayc@murrayc.com>
709 * src/maemo/modest-connection-specific-smtp-edit-window.c:
710 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
713 * src/modest-account-mgr-helpers.h:
714 * src/modest-account-mgr-helpers.c:
715 Added modest_account_mgr_get/set_signature(), using new gconf keys.
717 * src/maemo/Makefile.am:
718 * src/maemo/modest-signature-editor-dialog.c:
719 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
722 * src/maemo/modest-account-settings-dialog.h:
723 * src/maemo/modest-account-settings-dialog.c:
724 (modest_account_settings_dialog_finalize), (on_button_signature),
725 (save_configuration): Use the new dialog when the Edit button is pressed, and
726 save the changes if necessary, as per the UI spec.
728 2007-04-23 Murray Cumming <murrayc@murrayc.com>
730 * src/maemo/Makefile.am:
731 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
732 based on maemo-develoers email from Dirk.
734 * src/maemo/easysetup/modest-easysetup-wizard.c:
735 (create_page_welcome), (create_page_account_details),
736 (create_page_user_details), (create_page_complete_easysetup),
737 (create_page_custom_incoming), (create_page_custom_outgoing),
738 (create_page_complete_custom),
739 (modest_easysetup_wizard_dialog_init):
740 * src/maemo/modest-account-settings-dialog.c:
741 (create_page_account_details), (create_page_user_details),
742 (create_page_incoming), (create_page_outgoing),
743 (modest_account_settings_dialog_init):
744 * src/maemo/modest-connection-specific-smtp-window.c:
745 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
747 2007-04-23 Murray Cumming <murrayc@murrayc.com>
749 * src/maemo/easysetup/modest-easysetup-wizard.c:
750 (create_page_account_details), (create_page_custom_outgoing),
751 (create_page_complete_custom):
752 * src/maemo/modest-account-settings-dialog.c:
753 (create_page_user_details), (create_page_incoming),
754 (create_page_outgoing):
755 * src/maemo/modest-connection-specific-smtp-edit-window.c:
756 (modest_connection_specific_smtp_edit_window_init):
757 Use the correct (UI spec) port min/max, and use horizontal separators,
760 2007-04-23 Murray Cumming <murrayc@murrayc.com>
762 * src/maemo/easysetup/modest-easysetup-wizard.c:
763 (set_default_custom_servernames):
764 * src/maemo/modest-account-settings-dialog.c:
765 (create_page_incoming), (on_combo_outgoing_security_changed),
766 (on_combo_incoming_security_changed), (create_page_outgoing),
767 (modest_account_settings_dialog_set_account_name),
768 (save_configuration):
769 * src/maemo/modest-connection-specific-smtp-edit-window.c:
770 (on_combo_security_changed),
771 (modest_connection_specific_smtp_edit_window_init),
772 (modest_connection_specific_smtp_edit_window_set_connection),
773 (modest_connection_specific_smtp_edit_window_get_settings):
774 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
777 2007-04-20 Murray Cumming <murrayc@murrayc.com>
780 * src/maemo/easysetup/modest-easysetup-wizard.c:
781 (create_page_custom_outgoing), (create_page_complete_custom):
782 * src/maemo/modest-account-settings-dialog.c:
783 (create_page_user_details), (create_page_outgoing):
784 * src/maemo/modest-account-view-window.c: (button_box_new):
785 Use changed logical IDs as per the most recent UI spec:
786 mcen_bd_emailsetup_edit -> mcen_bd_edit
787 mcen_bd_emailsetup_delete -> mcen_bd_delete
788 mcen_bd_emailsetup_close -> mcen_bd_close
790 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
794 * src/dbus_api/Makefile.am:
795 * src/dbus_api/modest-dbus-callbacks.c:
796 * src/dbus_api/modest-dbus-callbacks.h:
797 * src/maemo/modest-platform.c: (modest_platform_init):
798 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
801 * tests/dbus_api/Makefile.am:
802 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
804 2007-04-20 Murray Cumming <murrayc@murrayc.com>
806 * src/maemo/modest-account-settings-dialog.c:
807 * src/maemo/modest-connection-specific-smtp-edit-window.c:
808 Removed unnecessary includes.
810 2007-04-20 Murray Cumming <murrayc@murrayc.com>
812 * src/maemo/easysetup/modest-easysetup-wizard.c:
813 * src/maemo/modest-account-settings-dialog.c:
814 * src/maemo/modest-connection-specific-smtp-edit-window.c:
815 * src/widgets/Makefile.am:
816 * src/widgets/modest-easysetup-secureauth-combo-box.c:
817 * src/widgets/modest-easysetup-secureauth-combo-box.h:
818 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
819 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
820 * src/widgets/modest-secureauth-combo-box.c:
821 * src/widgets/modest-secureauth-combo-box.h:
822 * src/widgets/modest-serversecurity-combo-box.c:
823 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
824 made the GObject names more consistent with the rest of the Modest code.
826 2007-04-20 Murray Cumming <murrayc@murrayc.com>
828 * src/maemo/easysetup/Makefile.am:
829 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
830 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
831 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
832 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
833 * src/maemo/easysetup/modest-easysetup-wizard.c:
834 * src/maemo/easysetup/modest-validating-entry.c:
835 * src/maemo/easysetup/modest-validating-entry.h:
836 * src/maemo/modest-account-settings-dialog.c:
837 * src/maemo/modest-connection-specific-smtp-edit-window.c:
838 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
839 widgets/ because they are used outside of easysetup too. After checking in,
840 svn will allow me to rename them too.
842 2007-04-20 Murray Cumming <murrayc@murrayc.com>
844 * src/gnome/modest-msg-edit-window.c:
845 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
846 linker error, to fix the build on the GNOME platform.
847 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
848 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
849 ifdefed out to avoid a warning.
851 2007-04-20 Murray Cumming <murrayc@murrayc.com>
853 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
854 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
855 some alternative for GTK+ 2.6.
857 2007-04-19 Murray Cumming <murrayc@murrayc.com>
859 * src/maemo/modest-address-book.c: Added include to avoid a warning.
861 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
862 specified for EmailAccountsDialog in UI spec.
864 * src/maemo/easysetup/modest-easysetup-wizard.c:
865 * src/maemo/easysetup/modest-easysetup-wizard.h:
866 * src/maemo/modest-account-settings-dialog.c:
867 * src/maemo/modest-account-settings-dialog.h:
868 Reuse a member window widget for the connection-specific SMTP server accounts,
869 so we can tell it to create/save the accounts only if we actually save changes.
871 * src/maemo/modest-connection-specific-smtp-edit-window.h:
872 * src/maemo/modest-connection-specific-smtp-edit-window.c:
873 (modest_connection_specific_smtp_edit_window_get_settings):
874 Return a struct instance for temporarily remembering the entered data.
876 * src/maemo/modest-connection-specific-smtp-window.h:
877 * src/maemo/modest-connection-specific-smtp-window.c:
878 (modest_connection_specific_smtp_window_finalize),
879 (modest_connection_specific_smtp_window_fill_with_connections),
881 (modest_connection_specific_smtp_window_save_server_accounts),
882 (update_model_server_names): Do not actually save data until asked,
883 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
885 (on_selection_changed),
886 (modest_connection_specific_smtp_window_init): Disable the edit
887 button when nothing is selected.
889 * src/modest-account-mgr-helpers.c:
890 * src/modest-account-mgr-helpers.h:
891 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
894 2007-04-19 Murray Cumming <murrayc@murrayc.com>
896 * src/modest-account-mgr-helpers.h:
897 * src/modest-account-mgr-helpers.c:
898 (modest_account_mgr_get_unused_account_name),
899 (modest_account_mgr_get_unused_account_display_name): Added these
900 utility functions, to avoid code duplication.
902 * src/maemo/easysetup/modest-easysetup-wizard.c:
903 (create_page_account_details), (create_account):
904 * src/maemo/modest-connection-specific-smtp-edit-window.c:
905 (on_combo_security_changed),
906 (modest_connection_specific_smtp_edit_window_init),
907 (modest_connection_specific_smtp_edit_window_save_settings):
908 * src/maemo/modest-connection-specific-smtp-edit-window.h:
909 * src/maemo/modest-connection-specific-smtp-window.c:
910 (modest_connection_specific_smtp_window_finalize),
911 (modest_connection_specific_smtp_window_fill_with_connections),
912 (on_button_edit), (modest_connection_specific_smtp_window_init):
913 * src/maemo/modest-connection-specific-smtp-window.h:
914 Implementing saving of connection-specific server accounts.
916 But I need to refactor this so we can save the data for each
917 possible connection-specific account and only actually create the server accounts
918 when the easysetup finished, or the OK button is pressed on the account settings
921 2007-04-18 Murray Cumming <murrayc@murrayc.com>
923 * src/maemo/modest-connection-specific-smtp-edit-window.c:
924 (on_combo_security_changed):
925 (modest_connection_specific_smtp_edit_window_init):
926 Auto-fill the port number as in the account settings.
928 (modest_connection_specific_smtp_edit_window_set_connection):
929 * src/maemo/modest-connection-specific-smtp-edit-window.h:
930 * src/maemo/modest-connection-specific-smtp-window.c:
931 (fill_with_connections), (on_button_edit),
932 (modest_connection_specific_smtp_window_init):
933 Turn the edit window into a dialog to simplify the code, and
934 set a WM hint as in a GtkDialog, because only a popup can be on top of
935 another window in Maemo, and popups usually have no WM decoration.
938 * src/modest-account-mgr-helpers.c:
939 (modest_account_mgr_set_connection_specific_smtp),
940 (modest_account_mgr_remove_connection_specific_smtp),
941 (modest_account_mgr_get_connection_specific_smtp):
942 * src/modest-account-mgr-helpers.h: Some functions to write the
943 connection-specific SMTP server information. Not yet used.
946 * src/widgets/modest-folder-view.c: (text_cell_data):
947 Fix a warning about an uninitialized variable.
948 (on_configuration_key_changed): Put an #ifdef around the use
949 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
951 2007-04-18 Murray Cumming <murrayc@murrayc.com>
953 * src/maemo/modest-account-settings-dialog.h:
954 * src/maemo/modest-account-settings-dialog.c:
955 Added connect_for_modified() utility function to mark the new modified boolean.
957 (create_page_account_details), (create_page_user_details),
958 (create_page_incoming), (create_page_outgoing), (on_response),
959 (modest_account_settings_dialog_init),
960 (modest_account_settings_dialog_set_account_name):
961 Only warn about unsaved changes when there are actually unsaved changes.
963 * src/modest-account-mgr-helpers.c:
964 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
965 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
966 to get the data from there in future.
968 2007-04-18 Murray Cumming <murrayc@murrayc.com>
972 * src/modest-account-mgr-helpers.h:
973 * src/modest-account-mgr-helpers.c:
974 Store the security account setting in a single conf key instead of using
975 the options list, so that the list is left for just the to-be-removed camel hack,
976 and because gconf_client_set_list() is failing for some reason.
978 * src/modest-account-mgr.c:
979 (modest_account_mgr_add_server_account):
980 * src/maemo/modest-account-settings-dialog.c:
981 (modest_account_settings_dialog_set_account_name),
982 (save_configuration): Use the renamed functions.
985 2007-04-18 Murray Cumming <murrayc@murrayc.com>
987 * src/widgets/Makefile.am:
988 * src/widgets/modest-limit-retrieve-combo-box.c:
989 * src/widgets/modest-limit-retrieve-combo-box.h:
990 * src/widgets/modest-retrieve-combo-box.c:
991 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
992 the account settings dialog.
995 * src/modest-account-mgr-helpers.h:
996 * src/modest-account-mgr-helpers.c:
997 (modest_server_account_get_option_secure_auth),
998 (modest_server_account_set_option_secure_auth):
999 * src/modest-account-mgr.c:
1000 (modest_account_mgr_add_server_account):
1001 Use the existing AUTH_MECH conf key for the secure-auth setting,
1002 instead of putting it in the list options, because this was actually used already.
1004 * src/maemo/modest-account-settings-dialog.c:
1005 (create_page_account_details),
1006 (modest_account_settings_dialog_set_account_name),
1007 (save_configuration):
1008 * src/maemo/modest-account-settings-dialog.h:
1009 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1010 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1012 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1014 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1015 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1016 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1018 * src/modest-defs.h:
1019 * src/maemo/modest-account-settings-dialog.c:
1020 (create_page_incoming), (on_combo_outgoing_security_changed),
1021 (on_combo_incoming_security_changed), (create_page_outgoing),
1022 (modest_account_settings_dialog_set_account_name),
1023 (save_configuration): Load/Save the port number, and change it when the
1024 security combo changes, to suitable defaults.
1026 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1028 * src/modest-account-mgr.c:
1029 (modest_account_mgr_add_server_account): Set the security and secure-auth
1030 options, and add a comment saying that the other camel-specific options should be
1033 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1035 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1037 * src/modest-tny-account-store.c: (account_list_free),
1038 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1039 cursor->data after unreffing it. But there is some strange stuff there so it might not be
1042 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1044 * src/modest-protocol-info.c:
1045 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1046 is required by our UI spec. Maybe something in our implementation will use this eventually.
1047 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1048 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1049 instead of the previous 0 placeholder.
1051 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1052 secure-auth settings.
1053 * src/modest-account-mgr-helpers.h:
1054 * src/modest-account-mgr-helpers.c:
1055 (modest_server_account_data_get_option_secure_auth),
1056 (modest_server_account_set_option_secure_auth),
1057 (modest_server_account_data_get_option_security),
1058 (modest_server_account_set_option_security): Added this API for getting and setting the security
1059 and secure-auth settings.
1061 * src/maemo/modest-account-settings-dialog.h:
1062 * src/maemo/modest-account-settings-dialog.c:
1063 (modest_account_settings_dialog_finalize), (check_data),
1064 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1065 about changing titles.
1066 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1067 (save_configuration): Save the security and secure-auth settings.
1069 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1070 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1072 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1074 * src/modest-defs.h:
1075 * src/modest-account-mgr.c:
1076 (modest_account_mgr_add_server_account):
1077 Added and used defines for the options key and value pair strings,
1078 that are used so far, though they do not seem to correspond to anything in our
1079 UI specs or ModestProtocol enum.
1081 * src/modest-account-mgr-helpers.h:
1082 * src/modest-account-mgr-helpers.c:
1083 (compare_option_strings_for_name),
1084 (modest_server_account_data_get_option_value),
1085 (modest_server_account_data_get_option_bool),
1086 (modest_account_mgr_get_server_account_option):
1087 Added helper functions for parsing the options GSList.
1089 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1091 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1092 display name is based on the supplied account name.
1093 * src/modest-account-mgr.c:
1094 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1095 with an inefficient, but good-enough, implementation.
1097 * src/maemo/easysetup/modest-easysetup-wizard.c:
1098 (create_page_account_details), (on_before_next), (create_account):
1099 Check for existing display names rather than (non-user-visible) account names, and just
1100 create and set a unique account name at the end.
1102 * src/maemo/modest-account-settings-dialog.c:
1103 (modest_account_settings_dialog_init),
1104 (modest_account_settings_dialog_set_account_name),
1105 (create_page_incoming): Show the display name, instead of the account name.
1106 (on_response): Do some (not all) extra checks, as in the UI spec.
1107 (save_configuration): Save the display name if it was changed.
1109 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1111 * po/en_GB.po: Added needed logical ID and translation.
1112 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1113 (init_view): Made the is-default column clicking work.
1115 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1118 * src/maemo/easysetup/Makefile.am:
1119 * src/maemo/easysetup/modest-easysetup-wizard.c:
1120 (modest_easysetup_wizard_dialog_init):
1121 * src/maemo/easysetup/provider-data-test.keyfile:
1122 * src/maemo/easysetup/provider-data.keyfile:
1123 Moved the provider data file to the new modest-providers-data package and used it from there.
1125 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1127 * src/modest-local-folder-info.c:
1128 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1129 N_() was already used on the static strings, but this just marks it for translation without
1130 using the translation.
1132 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1134 * src/maemo/modest-account-settings-dialog.c:
1135 (create_page_incoming),
1136 (modest_account_settings_dialog_set_account_name):
1137 Added comments about the need for new API in ModestAccountMgr to handle the authentication
1138 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1139 I will do this if nobody else gets there first.
1141 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1143 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1144 Saved much of the incoming and outgoing data too, though I cannot yet see how to
1145 save the security stuff.
1147 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1149 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1150 Set the email address and user fullname, which I now see must be
1153 * src/maemo/modest-account-settings-dialog.h:
1154 * src/maemo/modest-account-settings-dialog.c:
1156 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1157 leave-on-server and authentication.
1158 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1161 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1164 * src/maemo/modest-account-settings-dialog.c:
1165 * src/maemo/modest-account-settings-dialog.h:
1166 Most (but not all) of the widgets are now present as specified by the UI spec.
1167 No changes are yet saved, and some details are not properly shown yet.
1169 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1171 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1173 * src/maemo/Makefile.am:
1174 * src/maemo/modest-account-settings-dialog.c:
1175 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1176 an existing account. Doesn't do much yet.
1178 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1179 Open the accounts settings dialog when Edit is clicked.
1181 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1183 * src/maemo/easysetup/Makefile.am:
1184 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1186 * src/maemo/easysetup/modest-easysetup-wizard.c:
1187 (modest_easysetup_wizard_dialog_init):
1188 Try to get the source directory from the build system,
1189 instead of hard-coding "./" into the source code, when opening our local
1190 copies of the configuration files.
1191 But this still fails when opening the wizard from the Accounts window,
1192 maybe because the working directory seems to change at runtime.
1193 So the wizard will fail the second time unless you copy the files into their
1194 proper locations - see the stdout warnings for the paths.
1196 (create_page_account_details),(on_before_next):
1197 Check for existing non-server accounts instead of server accounts,
1198 so the default account name is useful again, and to prevent trying to
1201 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1202 Show the wizard when New is clicked.
1204 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1205 (init_view): Show the column headers, and show the columns that are
1206 specified in the UI specs. However, something in Maemo's GTK+ prevents
1207 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1208 change the default account. This is despite unsetting the special properties.
1210 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1212 * docs/reference/modest-design.sgml: Corrected spelling mistake.
1213 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1214 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1215 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1216 to make that clearer.
1217 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1219 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1221 * src/maemo/modest-account-view-window.c:
1222 (modest_account_view_window_init),
1223 (modest_account_view_window_new):
1224 Use the same buttons as specified in the
1225 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1226 the existing widgets, which never had a chance of working.
1227 Put the ModestAccountView treeview in a scrolled window.
1228 Do not repeat the initialization in both _init() and _new().
1230 * src/widgets/modest-account-view.c: (update_account_view):
1231 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1232 this widget and window shows no accounts.
1234 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1236 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1238 * src/maemo/easysetup/modest-easysetup-wizard.c:
1239 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1240 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1241 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1244 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1245 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1246 accounts exist yet, as in the UI spec.
1248 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
1250 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1252 * src/maemo/Makefile.am:
1253 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1254 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1255 New window for editing connection-specific smtp details.
1256 Not fully implemented.
1258 * src/maemo/modest-connection-specific-smtp-window.c:
1259 (modest_connection_specific_smtp_window_finalize) :
1260 unref the tree model.
1261 (on_button_edit): Show the edit window.
1263 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1265 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
1268 * src/maemo/Makefile.am:
1269 * src/maemo/modest-connection-specific-smtp-window.c:
1270 * src/maemo/modest-connection-specific-smtp-window.h:
1271 New window for showing the list of connections, for connection-specific
1272 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
1273 * src/maemo/easysetup/modest-easysetup-wizard.c:
1274 (create_page_custom_outgoing): Show the new window when the button is clicked.
1276 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1278 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1279 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1280 * src/maemo/modest-msg-edit-window.c:
1281 (modest_msg_edit_window_insert_image):
1282 * src/modest-conf.c: (modest_conf_key_escape):
1283 * src/modest-mail-operation.c:
1284 (modest_mail_operation_send_new_mail):
1285 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1286 (modest_ui_actions_on_new_account):
1287 * src/widgets/modest-attachment-view.c: (update_filename_request):
1288 * src/widgets/modest-mail-header-view.c:
1289 Corrected warnings that were breaking the build, by commenting out unused variables,
1290 and a function, and by including a header.
1292 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1294 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
1295 so we can #ifdef around platform-specific code when necessary.
1296 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
1297 to allow this to build for the GNOME platform too.
1299 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1301 * src/maemo/easysetup/modest-easysetup-wizard.c:
1302 Added util_increment_name() and used it in create_page_account_details()
1303 to make sure that the default account name is always a new name.
1305 (modest_easysetup_wizard_dialog_init),
1306 (set_default_custom_servernames): Some minor memory management fixes.
1308 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1312 * src/modest-runtime.c: (init_i18n): Restored the translation
1313 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
1314 are defined in config.h, and the translations are installed.
1316 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
1317 is defined for translation.
1319 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1321 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1323 * src/maemo/easysetup/modest-easysetup-wizard.c:
1324 (modest_easysetup_wizard_dialog_init):
1325 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1326 Use realistic paths (though they should use $prefix generically) to the
1327 mcc_mapping and provider-data.keyfile files which might work when they
1328 are installed by the future version of the operator-wizard package,
1329 and then fallback to paths in our source code, with an explanatory
1332 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1336 * src/maemo/Makefile.am:
1337 * src/maemo/easysetup/: Added files from the previously-exernal
1338 osso-modest-easysetup.
1339 * src/maemo/modest-main-window-ui.h:
1340 * src/modest-ui-actions.c:
1341 * src/modest-ui-actions.h:
1342 Added modest_ui_actions_on_new_account() as a signal handler for the
1343 New Account menu item. It shows the easysetup wizard.
1344 * po/en_GB.po: Added additional needed logical IDs and translations.
1346 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
1347 Apparently ChangeLog is not used for some vague Nokia legal reasons.