1 2007-07-26 Murray Cumming <murrayc@murrayc.com>
3 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
4 printf more details when we get unhandled D-Bus methods, because
7 * src/modest-mail-operation.c: (update_account_thread):
8 Comment out the tny_camel_pop_store_account_reconnect(), because this
9 is apparently no longer needed, and it did not work before anyway.
10 See the comment in the code.
12 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
13 by checking the header flags. This fixes projects.maemo.org bug
16 2007-07-25 Murray Cumming <murrayc@murrayc.com>
18 * src/maemo/modest-maemo-utils.h:
19 * src/maemo/modest-maemo-utils.c: Added
20 modest_maemo_show_information_note_in_main_context_and_forget().
21 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
22 Use the new function to show simple error dialogs in the main
23 context, though question dialogs are still in the current context,
24 which is unfortunately usually not the main context. This should
27 2007-07-25 Murray Cumming <murrayc@murrayc.com>
29 * src/modest-tny-account-store.c: (get_password):
30 Never save the entered username and password in gconf,
31 because the UI spec says we should not. This helps
32 slightly with projects.maemo.org bug NB#63671.
34 2007-07-25 Murray Cumming <murrayc@murrayc.com>
36 * src/widgets/modest-msg-edit-window.h:
37 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
38 Moved some code here to make it simpler.
39 (modest_msg_edit_window_attach_file_one): Renamed from
40 modest_msg_edit_window_attach_file_interactive().
41 (modest_msg_edit_window_offer_attach_file): Renamed from
42 modest_msg_edit_window_attach_file() and used
43 modest_msg_edit_window_attach_file_one() instead of
44 copy/pasting the code. The old code for one was not using
45 GnomeVFS. This allows use of smb:// URLs when using send-as
46 from external applications, fixing bug NB#63741.
48 (modest_msg_edit_window_insert_image),
49 (modest_msg_edit_window_add_attachment_clicked):
50 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
51 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
52 Adapted to the new function names.
54 2007-07-25 Murray Cumming <murrayc@murrayc.com>
56 (modest_platform_set_update_interval): Set the alarm recurrence
57 fields so that auto-update does not just happen the first time.
58 This should have fixed projects.maemo.org bug NB#63938.
60 When this happens you can see a printf when the D-Bus method is
62 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
64 However, I do not actually seem to get new POP messages even when
65 clicking the refresh button manually. A restart gets them.
66 This might be a problem in today's tinymail only.
68 2007-07-24 Murray Cumming <murrayc@murrayc.com>
70 * src/maemo/modest-maemo-global-settings-dialog.c:
72 Avoid a crash (probably only in scratchbox) when strcmp()ing a
73 NULL when closing the dialog.
75 2007-07-24 Murray Cumming <murrayc@murrayc.com>
77 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
78 Remove the hacky send/receive that didn't work, and instead
79 refilter the treemodel to make the deleted email really vanish from
80 the UI (though the delete-from-menu code does has commented out
81 the code that does that). This fixes projects.maemo.org bug
84 2007-07-24 Murray Cumming <murrayc@murrayc.com>
86 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
87 Try a couple of tricks to force the treeview to update (
88 poke the folder, and do a send/receive refresh), but the deleted
89 email still appears with a strike-through instead of really being
92 2007-07-23 Murray Cumming <murrayc@murrayc.com>
94 * src/dbus_api/modest-dbus-callbacks.c:
95 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
96 because their ID is not human-readable (see the comment about
97 improvements needed to the osso-email-interface API) and
98 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
100 2007-07-23 Murray Cumming <murrayc@murrayc.com>
102 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
103 (add_folders_to_list), (on_dbus_method_get_folders),
104 (modest_dbus_req_filter):
105 * src/maemo/modest-maemo-utils.c:
106 (on_camel_account_get_supported_secure_authentication):
107 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
108 (on_header_view_focus_in):
109 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
110 * src/modest-formatter.c: (modest_formatter_create_body_part):
111 * src/modest-mail-operation.c: (recurse_folders),
112 (update_account_thread), (get_msgs_full_thread),
113 (modest_mail_operation_get_msgs_full),
114 (modest_mail_operation_xfer_msgs):
115 * src/modest-search.c: (search_mime_part_and_child_parts),
116 (modest_search_account), (modest_search_all_accounts):
117 * src/modest-tny-account.c:
118 (modest_tny_account_get_special_folder), (recurse_folders):
119 * src/modest-tny-local-folders-account.c:
120 (modest_tny_local_folders_account_query_passes):
121 * src/modest-tny-msg.c: (copy_mime_part),
122 (modest_tny_msg_find_body_part_from_mime_part):
123 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
124 (modest_tny_send_queue_try_to_send):
125 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
126 (_modest_ui_actions_open), (download_uncached_messages),
127 (reply_forward), (modest_ui_actions_on_copy),
128 (modest_ui_actions_on_details), (has_retrieved_msgs),
129 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
131 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
132 (_selected_msg_marked_as), (_msg_download_completed),
133 (_selected_msg_sent_in_progress):
134 * src/widgets/modest-attachments-view.c:
135 (modest_attachments_view_set_message):
136 * src/widgets/modest-msg-view.c: (find_cid_image):
137 * tests/check_folder-transfer.c: (find_folders):
138 * tests/check_update-account.c: (func):
139 * tests/dbus_api/test_get_folders.c: (main):
140 Checked all uses of tny_iterator_get_current(), making sure
141 that the object is unreferenced (3 or 4 places did not),
142 and adding checks for NULL.
144 2007-07-23 Murray Cumming <murrayc@murrayc.com>
146 * src/dbus_api/modest-dbus-callbacks.c:
147 (on_idle_open_default_inbox): Make sure that the application UI is
149 * src/maemo/easysetup/modest-easysetup-wizard.c:
150 (on_entry_invalid_character): Show the word whitespace instead
151 of (null) in the banner when whitespace was entered.
152 (show_error): Add a comment that this does not work in
153 Maemo Bora, though we do not know why.
155 2007-07-23 Murray Cumming <murrayc@murrayc.com>
157 * src/modest-tny-account.c:
158 (modest_tny_account_get_special_folder): Use an if instead of
159 an assert for when the parent account name is NULL, because this
160 might be causing a crash in projects.maemo.org bug 63192.
161 * src/modest-mail-operation.c:
162 (modest_mail_operation_send_new_mail_cb),
163 (modest_mail_operation_remove_folder): unref the folder that is
164 returned from modest_tny_account_get_special_folder().
166 2007-07-23 Murray Cumming <murrayc@murrayc.com>
168 * src/modest-ui-actions.c:
169 (modest_ui_actions_on_password_requested):
170 Show mail_ib_login_cancelled info banner when the user cancels
171 the protected password dialog, to fix projects.maemo.org
174 2007-07-23 Murray Cumming <murrayc@murrayc.com>
176 * src/maemo/modest-account-settings-dialog.c:
177 (create_page_outgoing): Put this page in a GtkScrolledWindow,
178 matching the UI mock-up in the UI spec, and allowing access
179 to all widgets even when the on-screen keyboard is active.
181 2007-07-23 Murray Cumming <murrayc@murrayc.com>
183 Reverted this previous commit from Johannes,
184 because the scrollbars are always visible and because
185 I think we only need it on onepage of the account
186 settings, not the account wizard.
187 (I wrote the wrong instructions in the bug.)
189 * src/maemo/easysetup/modest-easysetup-wizard.c:
190 Added scrollbars to account wizard dialog.
191 Fixed projects.maemo.org NB #62744
193 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
195 * src/maemo/easysetup/modest-easysetup-wizard.c:
196 (create_page_user_details):
197 Use auto-cap for name (projects.maemo.org NB#63716)
198 * src/widgets/modest-account-view.c: (on_account_busy_changed):
200 2007-07-22 Armin Burgmeier <armin@openismus.com>
202 * src/maemo/modest-ui-actions.c: Use current account instead of
203 default account for creating viewer windows, so that the viewer
204 window knows to which account the viewed message belongs.
206 * src/maemo/modest-msg-view-window.c: Destroy the window when the
207 corresponding account is deleted. This fixes projects.maemo.org bug
210 2007-07-18 Armin Burgmeier <armin@openismus.com>
212 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
213 the dialog close after entering an invalid port number and clicking
214 OK. This fixes projects.maemo.org bug NB#63602.
216 2007-07-18 Armin Burgmeier <armin@openismus.com>
218 * src/modest-tny-account-store.c:
219 (get_server_accounts): Set parent modest account name for each
220 connection-specific transport account so that special folders of such
221 an account can be looked up. This fixes a crash when changing account
222 settings. This might also be related to projects.maemo.org bug
225 2007-07-16 Armin Burgmeier <armin@openismus.com>
227 * src/modest-ui-actions.c: Added a button to create a folder to the
228 move-to dialog. This fixes projects.maemo.org bug NB#.
230 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
232 * src/maemo/easysetup/modest-easysetup-wizard.c:
233 Added scrollbars to account wizard dialog.
234 Fixed projects.maemo.org NB #62744
236 2007-07-16 Murray Cumming <murrayc@murrayc.com>
238 * src/widgets/modest-msg-view.h:
239 * src/widgets/modest-msg-view.c:
240 Added modest_msg_view_get_message_is_empty() but this needs
242 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
243 Check if there is any text in the message yet.
244 But this needs to be implemented properly.
245 (modest_msg_edit_window_toggle_find_toolbar):
246 * src/maemo/modest-msg-view-window.c:
247 (modest_msg_view_window_toggle_find_toolbar):
248 Show a banner warning if there is no text to search, when
249 trying to start a search. This partially fixes
250 projects.maemo.org bug NB#62350.
252 2007-07-13 Murray Cumming <murrayc@murrayc.com>
254 * src/modest-mail-operation.c: (update_account_thread):
255 Initialized num_new_headers to fix the build.
257 2007-07-13 Murray Cumming <murrayc@murrayc.com>
259 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
260 Ignore modest accounts whose server accounts don't exist in gconf.
261 This prevents us trying to create TnyAccount instances for those
262 server accounts when the server account has been removed from gconf,
263 but the parent modest account has not yet been removed from modest.
264 I don't know why this is only noticeable now. It was probably just
265 a harmeless g_warning() anyway.
267 2007-07-13 Murray Cumming <murrayc@murrayc.com>
269 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
270 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
272 2007-07-12 Armin Burgmeier <armin@openismus.com>
274 * src/maemo/modest-main-window.c: Make default account appear bold
275 in view, tools/send & receive and toolbar/send & receive SCM menus.
276 This fixes projects.maemo.org bug NB#59010.
278 2007-07-12 Murray Cumming <murrayc@murrayc.com>
280 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
281 Add a short-cut, by checking if the folder store is an account.
282 This ensures that the Sort menu item and toolbar is dimmed for
283 the local-folders account root item, fixing
284 projects.maemo.org bug NB#62545.
286 2007-07-12 Murray Cumming <murrayc@murrayc.com>
288 * src/modest-tny-account-store.c: (get_password):
289 Show the password dialog (via the signal) only in the mainloop, via
290 an idle handler that we wait for. This could theoretically prevent
291 hangs, though I worry that it could introduce some too.
293 2007-07-12 Murray Cumming <murrayc@murrayc.com>
295 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
296 * src/maemo/modest-platform.c:
297 (modest_platform_connect_and_wait):
298 Take a TnyAccount* parameter and try to set it to online
299 (a TnyCamel-only API), because tinymail sets accounts to offline
300 when the user cancels a password dialog, and doesn't ask again until
301 it has been set to online.
302 However, this is commented out because it causes a hang now.
304 (modest_platform_connect_and_wait_if_network_account):
305 * src/modest-mail-operation.c:
306 (modest_mail_operation_update_account):
307 * src/modest-platform.h:
308 * src/modest-ui-actions.c: (_modest_ui_actions_open),
309 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
311 2007-07-12 Armin Burgmeier <armin@openismus.com>
313 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
315 * src/modest-mail-operation.c:
316 * src/modest-ui-actions.c: Check for already existing folder before
317 querying the server, show error message from camel if the request
318 still fails. This fixes projects.maemo.org bug NB#58701.
320 2007-07-12 Murray Cumming <murrayc@murrayc.com>
322 * src/modest-tny-account-store.h:
323 * src/modest-tny-account-store.c:
324 Added modest_tny_account_store_forget_password_in_memory(),
325 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
326 when creating a new account, so that new passwords will be used, instead of
327 us thinking that it's a second request as a result of a failed password again.
329 2007-07-12 Murray Cumming <murrayc@murrayc.com>
331 * src/dbus_api/modest-dbus-callbacks.c:
332 (on_idle_open_message): If the message is in drafts then open it
333 in an edit window instead of a view window. This fixes
334 projects.maemo.org bug NB#63005.
336 2007-07-12 Murray Cumming <murrayc@murrayc.com>
338 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
339 Avoided a harmless g_warning().
341 2007-07-12 Murray Cumming <murrayc@murrayc.com>
343 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
344 Pass the modest account name, not the TnyAccount display name to
345 modest_msg_view_window_new() so that the reply feature works,
346 fixing projects.maemo.org bug NB#62892.
348 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
349 (modest_msg_view_window_new_with_header_model):
350 * src/maemo/modest-msg-view-window.c:
351 (modest_msg_view_window_new_with_header_model),
352 (modest_msg_view_window_new):
353 * src/modest-ui-actions.c: (reply_forward):
354 * src/widgets/modest-msg-view-window.h:
355 * src/widgets/modest-window.c: (modest_window_set_active_account):
356 Rename an account parameter to modest_account_name to make this clearer.
358 2007-07-11 Murray Cumming <murrayc@murrayc.com>
360 * src/modest-ui-actions.h:
361 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
362 modest_do_message_delete().
363 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
364 Call modest_do_message_delete(), hoping that this would cause messages
365 to be really deleted from search instead of just marked with strike through.
366 Does not seem to help.
368 2007-07-11 Armin Burgmeier <armin@openismus.com>
370 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
371 priv->reselect to FALSE prior to calling
372 modest_folder_view_select_first_inbox_or_local() to prevent endless
373 recursion and thus a crash on startup.
375 2007-07-11 Armin Burgmeier <armin@openismus.com>
377 * src/maemo/modest-account-settings-dialog.h: Include
378 <gtk/gtknotebook.h> to fix the build (at least for me).
380 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
381 Use "New FolderN" as default suggested name if "New folder" already
382 exists, with N being the first free number, though never exceed "New
383 folder99" in which case we just fall back to "New Folder" even though
384 it already exists. This fixes projects.maemo.org bug NB#58663.
386 2007-07-11 Murray Cumming <murrayc@murrayc.com>
388 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
389 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
390 projects.maemo.org bug NB#62778.
392 2007-07-11 Murray Cumming <murrayc@murrayc.com>
394 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
395 Ignore the wrong (for now) secure-smtp setting in the presets -
396 just default to requiring secure authentication for SMTP, because
399 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
401 * src/widgets/modest-folder-view.c: (filter_row)
402 Do not show drafts folder (see UI specs)
404 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
406 * src/modest-ui-actions.c:
407 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
408 place and also not necessary.
410 * src/widgets/modest-folder-view.c: (filter_row)
411 Guess folder type and hide Sent & Outbox if necessary.
412 Fixed project.maemo.org NB#57328
414 2007-07-11 Murray Cumming <murrayc@murrayc.com>
416 * src/modest-ui-actions.h:
417 * src/modest-ui-actions.c:
418 (modest_ui_actions_on_delete_message):
419 Move some code into a new
420 modest_ui_actions_refresh_message_window_after_delete()
421 function so we can use it from elsewhere.
423 * src/dbus_api/modest-dbus-callbacks.c:
424 (on_idle_delete_message), (on_delete_message): Used an idle
425 handler, as we do for the other D-Bus method handlers.
426 Call modest_ui_actions_refresh_message_window_after_delete()
427 if the deleted message was open in a window. This fixed
428 projects.maemo.org bug NB#62862.
430 2007-07-11 Murray Cumming <murrayc@murrayc.com>
432 * src/modest-main.c: (main): Only show the UI at the start if
433 the showui command line option was given. For instance,
434 run-standalone src/modest showui
435 Otherwise, we wait for the top_application D-Bus method to
436 be sent by hildon-desktop when the application is selected
438 This allows us to run without a UI when osso-global-search
439 uses our D-Bus methods.
441 2007-07-11 Murray Cumming <murrayc@murrayc.com>
443 * src/dbus_api/modest-dbus-api.h: Added a define for a
444 top-application D-Bus method.
445 * src/dbus_api/modest-dbus-callbacks.c:
446 (on_top_application),
447 (modest_dbus_req_handler): Handle the top-application D-Bus
448 method, which might be an undocumented D-Bus signal sent by
449 hildon-desktop when it starts the application from the menu.
450 But I am not sure and I need to test it on the device, because
451 my scratchbox does not have the application in the menu now.
452 This method shows the main window, so that it can be invisible
453 when started, for instance, just for email searching from
456 * src/maemo/modest-main-window.c: (restore_settings),
457 (modest_main_window_new): Do not show the window immediately
458 upon creation. We show it later.
459 * src/modest-widget-memory.c: (save_settings_paned):
460 Try (unsuccessfully) to avoid saving the paned position when
461 it is not even visible.
462 (restore_settings_paned): Do not allow a silly paned position.
463 This seems necessary when not showing the window at first.
465 * tests/dbus_api/Makefile.am:
466 * tests/dbus_api/test_top_application.c: (main): Test for the
469 2007-07-10 Murray Cumming <murrayc@murrayc.com>
471 * src/modest-ui-dimming-rules.c:
472 (modest_ui_dimming_rules_on_new_msg),
473 (modest_ui_dimming_rules_on_reply_msg),
474 (modest_ui_dimming_rules_on_delete_msg),
475 (modest_ui_dimming_rules_on_details),
476 (modest_ui_dimming_rules_on_view_window_move_to),
477 (modest_ui_dimming_rules_on_view_previous),
478 (modest_ui_dimming_rules_on_view_next),
479 (_invalid_folder_for_purge): Added checks before
480 casting the window. This looks like an actual
481 logic error in _invalid_folder_for_purge(), because it
482 tries to use a ModestMainWindow as a message window.
484 2007-07-10 Murray Cumming <murrayc@murrayc.com>
486 * src/maemo/modest-account-settings-dialog.c:
487 (show_error): Use the same implementation as in
488 modest-easysetup-wizard.c:
489 (on_entry_invalid_character): The logical ID contains a %s.
490 Guessed what it should be.
491 (on_entry_max), (check_data), (on_response): Adapt to
492 changed show_error().
493 (create_page_account_details): Really call
494 modest_validating_entry_set_func() on the correct widgets.
495 * src/maemo/easysetup/modest-easysetup-wizard.c:
496 (on_entry_invalid_character): Fix the logical ID here too.
497 (create_page_account_details),
498 (create_page_user_details):
500 modest_validating_entry_set_func() on the correct widgets.
502 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
503 Do not try to use the account if it is NULL.
505 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
507 * src/modest-ui-actions.c: (create_move_to_dialog),
508 (modest_ui_actions_on_main_window_move_to),
509 (modest_ui_actions_on_msg_view_window_move_to):
510 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
511 (filter_row), (modest_folder_view_show_non_move_folders):
512 * src/widgets/modest-folder-view.h:
514 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
515 the Sent folder yet as it does not report the correct folder type.
517 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
519 * src/maemo/modest-msg-edit-window.c: (init_window):
522 2007-07-10 Murray Cumming <murrayc@murrayc.com>
524 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
525 Take a parent widget instead of a parent window, and
526 implement this with hildon_banner_show_information() instead.
527 Non-Maemo builds can just ifdef that there.
528 This fixed projects.maemo.org bug NB#62766.
530 (on_entry_invalid_character): Use show_error() again instead
531 of using hildon directly, and use the _CS() macro to use the correct
533 (create_account), (check_for_supported_auth_methods), (on_entry_max):
534 Pass a widget instead od a window to show_error().
536 2007-07-10 Murray Cumming <murrayc@murrayc.com>
538 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
539 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
540 This allows us to show the server name in the error message, fixing
541 projects.maemo.org bug NB#62904.
542 Also, use the appropriate logical ID message for the account protocol.
544 2007-07-10 Murray Cumming <murrayc@murrayc.com>
546 * src/modest-tny-account-store.c: (on_idle_wrong_password):
547 A compilation fix, though the build wasn't broken for me.
549 2007-07-09 Murray Cumming <murrayc@murrayc.com>
551 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
552 Do not try to unref a NULL folder store, to avoid a runtime warning.
553 This seems to happen sometimes when changing accounts settings.
555 2007-07-09 Murray Cumming <murrayc@murrayc.com>
557 * src/modest-tny-account-store.c:
558 (modest_tny_account_store_instance_init),
559 (modest_tny_account_store_finalize),
560 (on_account_settings_hide), (on_idle_wrong_password):
561 Use a GHashTable to ensure that we only show one account settings
562 dialog per modest account. This avoids us having a dialog open for
563 both the store and transport accounts, or due to repeated get_password()
564 calls that shouldn't happen anyway.
566 2007-07-09 Murray Cumming <murrayc@murrayc.com>
568 * src/maemo/modest-maemo-utils.c: (on_hide),
569 (modest_maemo_show_dialog_and_forget): Handle the response, because
570 the window is not even hidden by default.
572 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
573 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
574 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
575 which seems to prevent some modality problems.
577 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
578 Ignore user cancellation errors.
580 * src/modest-account-mgr-helpers.h:
581 * src/modest-account-mgr-helpers.c:
582 Added modest_server_account_get_password() and
583 modest_server_account_get_has_password() to avoid direct use of
586 * src/maemo/modest-account-settings-dialog.h:
587 * src/maemo/modest-account-settings-dialog.c:
588 (modest_account_settings_dialog_init): Store the notebook so we can
590 Added modest_account_settings_dialog_switch_to_user_info().
592 * src/modest-tny-account-store.c:
593 (get_password): When the password in the account settings is wrong (we think),
594 show the relevant page of the account settings dialog, in the mainloop.
595 However, we currently get many of these at once because cancel does not
597 (forget_password): Do not forget the password
598 from the account settings, because this causes side-effects when
599 tinymail seems to call it at strange time, maybe because of how we
600 are cancelling get_password().
601 (modest_tny_account_store_alert): Ignore user cancellations.
603 2007-07-09 Murray Cumming <murrayc@murrayc.com>
605 * src/maemo/modest-maemo-utils.h:
606 * src/maemo/modest-maemo-utils.c:
607 Added modest_maemo_show_information_note_and_forget() for use instead of
608 gtk_dialog_run() when the response is not needed, to avoid an extra
609 mainloop which could cause a hang.
611 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
612 Use the logical IDs for the error message, though they are not
613 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
614 because gtk_dialog_run() caused a hang here (the window did not close).
615 This fixes projects.maemo.org bug NB#62646.
617 2007-07-09 Murray Cumming <murrayc@murrayc.com>
619 * src/modest-account-mgr-helpers.h:
620 * src/modest-account-mgr-helpers.c:
621 Added modest_account_mgr_get_store_protocol().
623 * src/maemo/modest-account-view-window.c:
624 (on_delete_button_clicked): Show different warning text depending on
625 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
626 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
629 2007-07-09 Murray Cumming <murrayc@murrayc.com>
631 * src/maemo/modest-msg-edit-window.c:
632 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
633 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
635 2007-07-07 Armin Burgmeier <armin@openismus.com>
637 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
638 ckdg_ib_maximum_characters_reached from correct package.
640 * src/modest-ui-actions.c: Show an error message when a folder could
641 not be created. Tinymail does not give us specific error codes about
642 what has gone wrong, so we assume that a folder with that name
643 already exists, though there might be other reasons.
645 2007-07-06 Murray Cumming <murrayc@murrayc.com>
647 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
648 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
649 give a more exact error message that can be partly translated.
651 2007-07-05 Murray Cumming <murrayc@murrayc.com>
653 * src/maemo/modest-address-book.c:
654 (select_email_addrs_for_contact): Specify a default window size for the
655 select-email-address dialog, so that it is probably big enough for the
656 title. This should fix projects.maemo.org bug NB#62277.
658 2007-07-05 Murray Cumming <murrayc@murrayc.com>
660 * src/maemo/easysetup/modest-easysetup-wizard.c:
661 (create_page_complete_easysetup): Use
662 gtk_widget_set_size() request to ensure that the text wraps
665 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
667 * src/maemo/easysetup/modest-easysetup-wizard.c:
668 (on_entry_invalid_character), (create_page_account_details),
669 (create_page_user_details):
670 Use new API of ModestValidatingEntry. But for some reason the banner is
671 not shown. I will have to investigate that further.
673 * src/widgets/modest-validating-entry.c: (on_insert_text),
674 (modest_validating_entry_set_func):
675 * src/widgets/modest-validating-entry.h:
676 Added a new callback function to be able to react to prevented
677 characters whitespaces to e.g show a banner.
679 2007-07-05 Armin Burgmeier <armin@openismus.com>
681 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
682 notification of HildonNumberEditor instead of remembering the port
683 number. Thanks to Johannes for pointing this out.
685 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
687 * src/maemo/easysetup/modest-easysetup-wizard.c:
688 Check if there are any user changes before showing a confirmation
689 dialog (projects.maemo.org NB#60946)
691 2007-07-05 Armin Burgmeier <armin@openismus.com>
693 * src/maemo/modest-account-settings-dialog.c: Remember custom port
694 number at the beginning of the dialog and set the modified flag at the
695 end if the port number has changed. This is necessary because
696 HildonNumberEditor does not support notification when the value has
699 2007-07-05 Murray Cumming <murrayc@murrayc.com>
701 * src/modest-ui-actions.c:
702 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
703 a connection before asking anything else. Correct the check for the destination
704 folder so that it succeeds when online.
705 This fixed projects.maemo.org bug NB#61645.
707 2007-07-05 Murray Cumming <murrayc@murrayc.com>
709 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
710 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
711 to fix projects.maemo.org bug NB#62439.
713 2007-07-05 Murray Cumming <murrayc@murrayc.com>
715 * src/modest-tny-account.c: (on_connection_status_changed):
716 Really do not use tny_device_force_offline() here. See the previous comment.
718 2007-07-04 Murray Cumming <murrayc@murrayc.com>
720 * src/modest-tny-account.c: (on_connection_status_changed):
721 Do not use tny_device_force_offline() when tinymail says that something
722 went wrong with the connection. It seems to report this unnecessarily.
724 2007-07-04 Murray Cumming <murrayc@murrayc.com>
726 * src/maemo/modest-connection-specific-smtp-window.c:
727 (modest_connection_specific_smtp_window_init):
728 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
729 does not seem to have any effect in osso 1.1 (though it works in
730 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
732 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
734 * src/maemo/modest-connection-specific-smtp-window.c:
735 Fix UI specification problems with projects.meamo.org NB#60479
737 2007-07-04 Murray Cumming <murrayc@murrayc.com>
739 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
740 clue when this has failed, because the error dialog is not always shown
741 (at least in earlier version).
743 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
744 GError message, because the generic error dialog is not helpful.
746 'This message is not currently available (can't let a new connection go online)'
747 when trying to open an IMAP message.
749 (_modest_ui_actions_open): Offer a connection when some messages would
750 have to be downloaded and we are offline.
752 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
754 * src/widgets/modest-folder-view.c:
755 Don't check for MERGE type anymore as we use the correct type
757 NOTE: For the last two changes you need to update your tinymail copy
758 because of API changes!
760 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
762 * src/modest-tny-local-folders-account.c:
763 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
764 (see projects.maemo.org NB#61580)
766 2007-07-04 Murray Cumming <murrayc@murrayc.com>
768 * src/modest-tny-account.c: (on_connection_status_changed):
769 Commented out the call to modest_platform_connect_and_wait() because this
770 seems to always hang, and I would like to know if this is the only thing
771 that causes a hang when showing the connection dialog.
772 It is not very useful anyway.
774 2007-07-04 Murray Cumming <murrayc@murrayc.com>
776 * src/maemo/modest-msg-view-window.c:
777 (modest_msg_view_window_select_next_message):
779 * src/modest-platform.h:
780 * src/maemo/modest-platform.c:
781 Added modest_platform_connect_and_wait(), which calls
782 tny_maemo_conic_device_connect() always in the main thread, by calling it
783 in an idle handler and waiting for the idle handler to run. It should be
784 in the main thread because it uses GTK+ UI code. It just returns TRUE
785 if the device is already online.
787 There is some nasty code to ensure that subsequent calls to
788 modest_platform_connect_and_wait() just wait for the first one to finish,
789 by checking repeatedly in another idle handler. This is necessary,
790 because other threads (or even the main thread, via another idle handler)
791 can call modest_platform_connect_and_wait() while
792 modest_platform_connect_and_wait() is running.
794 (modest_platform_connect_and_wait_if_network_account),
795 (modest_platform_connect_and_wait_if_network_folderstore):
796 Convenience functions that calls modest_platform_connect_and_wait() if
797 the account or folder might want network access.
799 * src/modest-mail-operation.c:
800 (modest_mail_operation_update_account):
801 * src/modest-ui-actions.c: (download_uncached_messages),
802 (modest_ui_actions_on_rename_folder), (delete_folder),
803 (modest_ui_actions_on_main_window_move_to),
804 (modest_ui_actions_on_msg_view_window_move_to):
805 * src/widgets/modest-folder-view.c:
806 (drag_and_drop_from_folder_view):
807 Offer a connection if we are offline.
809 * src/modest-tny-account.c: (on_connection_status_changed):
810 Document this as only handling errors during network operations in progress,
811 and replace the idle code with a simple call to
812 modest_platform_connect_and_wait(), which does this instead.
814 2007-07-03 Murray Cumming <murrayc@murrayc.com>
816 * src/modest-tny-account.c:
817 (modest_tny_account_get_special_folder): (util_on_idle),
818 Handle the GError so we can see when tny_folder_store_get_folders()
819 fails, as it currently does while something else is connecting.
821 Added util_run_in_main_thread_and_wait()
822 which uses an idlen handler and mainloop to ensure that the function
823 is called in the main thread.
824 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
825 to make sure that we call attempt the connection in the mainloop only,
826 which might solve some hangs.
828 2007-07-03 Murray Cumming <murrayc@murrayc.com>
830 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
831 be found by their display name. This is never useful.
832 * src/modest-tny-account-store.c: (on_account_removed): Find the account
833 by its ID, instead of trying to use its ID as its display name.
835 * src/modest-tny-account-store.h:
836 * src/modest-tny-account.c:
837 (modest_tny_account_get_special_folder): Add a g_warning() when
838 tny_folder_store_get_folders() returns an empty list for the maildir.
840 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
841 Add a g_warning() when this returns NULL, because that it not allowed
844 2007-07-02 Armin Burgmeier <armin@openismus.com>
846 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
847 note when trying to cancel the wizard. This fixes projects.maemo.org
850 2007-07-02 Murray Cumming <murrayc@murrayc.com>
852 * src/modest-tny-account.h:
853 * src/modest-tny-account.c:
854 (modest_tny_account_new_from_server_account),
855 (modest_tny_account_new_from_server_account_name),
856 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
857 because this must now be set before setting the proto. This is usd in
858 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
859 warning in camel_session_get_service() caused by
860 tny_camel_transport_account_prepare().
862 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
865 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
867 * src/maemo/modest-connection-specific-smtp-edit-window.c:
869 (modest_connection_specific_smtp_edit_window_init):
871 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
874 2007-06-29 Murray Cumming <murrayc@murrayc.com>
876 * src/modest-tny-account.c:
877 (modest_tny_account_new_from_server_account):
878 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
879 now uses to request a connection when it needs one, and which it uses
880 to tell us that something is wrong with the connection, so we can force
881 the accounts offline to prevent further problems.
884 * src/modest-init.c: (init_default_settings):
885 * src/modest-mail-operation.c:
886 (modest_mail_operation_update_account):
887 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
888 This should not be necessary anymore. Do not set the conf key that
889 determined this (it was always TRUE and not set anywhere else).
891 * src/modest-ui-actions.h: Remove unused and unimplemented
892 modest_ui_actions_on_online_toggle_toggled().
894 2007-06-29 Murray Cumming <murrayc@murrayc.com
896 * src/maemo/modest-main-window.c: (connect_signals):
897 Don't connect to delete_event twice. Maybe this was harmless.
899 2007-06-29 Murray Cumming <murrayc@murrayc.com
901 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
902 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
903 Debug output to give some more clue when a folder move is not allowed.
905 2007-06-28 Murray Cumming <murrayc@murrayc.com
907 * src/modest-tny-account.c: (on_modest_file_system_info),
908 (modest_tny_account_get_mmc_account_name):
909 Always call the callback, without checking whether the name has changed.
910 * src/widgets/modest-folder-view.c: (strings_are_equal),
911 (on_model_foreach_set_name), (on_get_mmc_account_name),
912 (text_cell_data): Compare the name here, and use the name from
913 the account rather than from the
914 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
915 if the name was changed after the account was added to the model.
916 That's a tinymail bug but not one that I want to fix now.
918 This finally fixes projects.maemo.org bug NB#59301.
920 2007-06-27 Armin Burgmeier <armin@openismus.com>
922 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
925 2007-06-27 Murray Cumming <murrayc@murrayc.com
927 * src/modest-tny-account.h:
928 * src/modest-tny-account.c:
929 Added modest_tny_account_get_mmc_account_name(), to set the memory
930 card name asynchronously for the given account and then notify.
931 (modest_tny_account_new_for_local_folders): Use this new function instead
932 of using hildon_file_system_info_async_new() directly.
934 * src/widgets/modest-folder-view.c: (text_cell_data):
935 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
936 gtk_tree_model_row_changed() when it is available.
938 This should fix projects.maemo.org bug NB#59301.
940 2007-06-27 Murray Cumming <murrayc@murrayc.com
942 * src/modest-mail-operation.c: (update_account_thread),
943 (get_msgs_full_thread): Fix typo failures in the revert
946 2007-06-27 Murray Cumming <murrayc@murrayc.com
948 * src/maemo/modest-maemo-global-settings-dialog.c:
949 (idle_select_default_focus):
950 * src/modest-mail-operation.c: (idle_notify_progress),
951 (idle_notify_progress_once), (set_last_updated_idle),
952 (update_account_thread), (get_msgs_full_thread):
953 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
954 * src/widgets/modest-header-view.c:
955 (idle_notify_headers_count_changed_destroy),
956 (idle_notify_headers_count_changed):
957 Reverted the additions of gdk_threads_enter/leave(), in case this
958 helps with a startup hang on the device.
960 2007-06-26 Armin Burgmeier <armin@openismus.com>
962 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
963 for supported secure authentication methods from server by
964 gtk_dialog_run(), saving CPU time and a potential race condition.
966 2007-06-26 Armin Burgmeier <armin@openismus.com>
968 * src/maemo/modest-maemo-utils.h:
969 * src/maemo/modest-maemo-utils.c: Added a
970 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
971 only error code to tell the calling code when the user canceled the
974 * src/maemo/modest-account-settings-dialog.h:
975 * src/maemo/modest-account-settings-dialog.c:
976 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
977 message if the retrieval of secure authentication methods was canceled
978 by the user. Perform the check before saving anything to configuration
979 to not end up with half-committed configuration changes, do not show
980 a "Saving to configuration failed" note when authentication methods
981 could not be retrieved.
983 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
986 2007-06-26 Murray Cumming <murrayc@murrayc.com>
988 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
989 Only return the first level of folders under accounts, because the
990 osso-global-search UI spec doesn't want the rest.
991 This fixed projects.maemo.org bug NB#61811.
993 2007-06-26 Murray Cumming <murrayc@murrayc.com>
995 * src/modest-tny-account-store.c:
996 * src/modest-tny-account-store.h:
997 Added modest_tny_account_is_memory_card_account().
998 * src/maemo/modest-main-window.c: (create_details_widget):
999 Show the same information items for the memory card as we show for the
1000 local-folders, to fix projects.maemo.org bug NB#59307.
1002 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1004 * src/modest-tny-account-store.c: (get_password):
1005 Added some checks for NULL to maybe prevent crashes, though I think
1006 it was Philip's last commit that actually prevented the crash here
1007 when creating a first new account.
1008 But the new account is still not usable (no messages are shown)
1009 until a restart of the application.
1011 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1013 * src/maemo/modest-maemo-global-settings-dialog.c:
1014 (idle_select_default_focus):
1015 * src/modest-mail-operation.c: (idle_notify_progress),
1016 (idle_notify_progress_once), (idle_notify_update_account_queue),
1017 (set_last_updated_idle), (update_account_thread),
1018 (notify_get_msgs_full), (get_msgs_full_destroyer),
1019 (get_msgs_full_thread):
1020 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1021 * src/widgets/modest-header-view.c:
1022 (idle_notify_headers_count_changed_destroy),
1023 (idle_notify_headers_count_changed):
1024 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1025 all idle handlers, because some other thread could be blocking
1026 the GDK lock, so that it can do GUI stuff.
1028 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1030 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1031 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1032 (on_idle_send_receive), (on_idle_open_default_inbox):
1033 * src/maemo/modest-msg-edit-window.c:
1034 (modest_msg_edit_window_attach_file_noninteractive):
1035 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1036 to prevent a hang. I don't quite understand why these are necessary,
1037 beause we should already be in the main loop. I guess something outside
1038 of the main loop is taking the lock.
1040 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1041 we are really using URIs, and use files that are more likely to exist.
1043 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1045 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1046 necessary because configure.ac now defines different variables.
1048 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1050 * libmodest-dbus-client/libmodest-dbus-client.c:
1051 * libmodest-dbus-client/libmodest-dbus-client.h:
1052 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1053 libmodest_dbus_client_compose_mail() is what things actually use.
1055 * src/dbus_api/modest-dbus-api.h:
1056 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1057 * tests/dbus_api/Makefile.am:
1058 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1061 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1063 * src/modest-init.c: (modest_init_local_folders):
1064 For memory-card (or other non local-folders) maildir accounts,
1065 always create an Archive folder, so that there is somewhere to put
1066 messages. This should be less confusing, because the user does not need
1067 to guess that the need to create a folder.
1069 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1071 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1072 Fixed icon size by using (50, 50) which is the same as defined by
1075 2007-06-25 Armin Burgmeier <armin@openismus.com>
1077 * src/widgets/modest-window-mgr.c:
1078 * src/modest-init.c:
1079 * configure.ac: Correctly recognize hildon-notify presence and fixed
1080 the build without it being installed.
1082 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1084 * libmodest-dbus-client/libmodest-dbus-client.c:
1085 (libmodest_dbus_client_search): Fix the build. Sorry.
1086 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1087 (reply_forward_cb): Initialize variables to fix the build.
1089 * src/modest-tny-account-store.c:
1090 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1091 comparison (a silly typo) so that email search results can be opened
1092 when there are more than one account.
1094 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1096 * libmodest-dbus-client/libmodest-dbus-client.c:
1097 (libmodest_dbus_client_search),
1098 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1099 instead of 1 second, because the search gets folders and messages from
1100 the server, which can take a long time. When it times out,
1101 osso-global-search will report no results.
1103 We need to specify whether we should search only cached information
1104 (maybe with a user preference), and the osso-email-search-plugin
1105 API should really be improved to allow that option, and to allow results
1106 to be delivered asynchronously in batches.
1108 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1110 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1111 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1112 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1114 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1116 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1117 that is an empty string. D-Bus seems to give us these instead of NULL.
1119 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1121 * src/dbus_api/modest-dbus-callbacks.c:
1122 * src/maemo/easysetup/modest-easysetup-wizard.h:
1123 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1124 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1125 (modest_connection_specific_smtp_edit_window_init):
1126 * src/maemo/modest-maemo-global-settings-dialog.c:
1128 * src/maemo/modest-maemo-utils.c:
1129 (modest_maemo_utils_setup_images_filechooser):
1130 * src/maemo/modest-main-window.c: (create_details_widget):
1131 * src/maemo/modest-msg-edit-window.c:
1132 (modest_msg_edit_window_attach_file_noninteractive),
1133 (modest_msg_edit_window_color_button_change),
1134 (modest_msg_edit_window_set_zoom):
1135 * src/modest-mail-operation.c: (update_account_thread):
1136 * src/modest-tny-account-store.c:
1137 * src/modest-tny-account.c:
1138 * src/widgets/modest-global-settings-dialog.c:
1139 * src/widgets/modest-window.h:
1141 Fixed build on bora!
1143 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1145 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1146 * src/modest-search.c: (modest_search_folder),
1147 (modest_search_all_accounts): Actually search only in the specified folder,
1148 doing a simple match on the folder ID.
1149 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1150 and added some documentation.
1152 2007-06-22 Armin Burgmeier <armin@openismus.com>
1154 * src/maemo/modest-maemo-utils.h:
1155 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1156 modest_maemo_utils_get_supported_secure_authentication_methods.
1158 * src/maemo/easysetup/modest-easysetup-wizard.c:
1159 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1160 one occured, not just "Server does not support secure authentication".
1162 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1164 * src/modest-tny-account-store.c: (get_password):
1165 Restored the call to tny_account_set_user() because Philip seems to have
1166 stopped this from crashing (by not using the freed string). It still does
1167 not work, but now we can test it.
1169 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1171 * src/maemo/modest-msg-edit-window.c: (init_window):
1172 Comment out use of an uninitialzed GtkScrolledWindow variable,
1173 to fix the build and stop a crash. Yet again.
1175 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1177 * src/modest-tny-account-store.c: (get_password):
1178 Remove the call to tny_account_set_user() because this actually crashes.
1179 As mentioned in the last commit, it is known to not work anyway.
1181 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1183 * src/modest-tny-account-store.c: (get_password):
1184 Use tny_account_set_username() to tell tinymail that the username might
1185 have changed too. But tinymail ignores this: see projects.maemo.org
1187 * src/modest-ui-actions.c:
1188 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1189 reset the connection when changing the username, and improve the comments.
1190 Save the changed username to gconf at least, so it is used when Modest is
1193 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1195 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1196 Do not use a query, so that we get all folders, including for POP and
1197 local-folders. They work as search criteria too.
1198 This fixes projects.maemo.org bug NB#57740.
1200 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1202 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1203 Comment out the use of hildon_notification_set_sound() because it is
1204 not declared, to fix the build. Warnings are serious, people.
1206 2007-06-21 Armin Burgmeier <armin@openismus.com>
1208 * src/maemo/modest-maemo-utils.h:
1209 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1210 modest_maemo_utils_get_supported_secure_authentication_methods()
1211 to query authentication methods for a specific user. This should fix
1212 projects.maemo.org bug NB#61369.
1214 * src/maemo/easysetup/modest-easysetup-wizard.c:
1215 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1218 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1220 * libmodest-dbus-client/libmodest-dbus-client.h:
1221 * libmodest-dbus-client/libmodest-dbus-client.c:
1222 (modest_dbus_message_iter_get_search_hit),
1223 (libmodest_dbus_client_search):
1224 Reorganised and commented this.
1225 Removed modest_search_hit_free() from the public API because it
1228 Added libmodest_dbus_client_get_folders() and
1229 modest_folder_result_list_free().
1231 * src/dbus_api/modest-dbus-api.h:
1232 * src/dbus_api/modest-dbus-callbacks.c:
1233 (modest_dbus_req_filter): Commented. Moved most code to
1234 on_dbus_method_search() and added on_dbus_method_get_folders().
1236 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1237 of the extra D-Bus handler.
1239 * tests/dbus_api/Makefile.am:
1240 * tests/dbus_api/test_get_folders.c: New test for
1241 libmodest_dbus_client_get_folders(). This seems to return an empty list
1242 at the moment. That could be the same error that causes the message list
1243 to be empty sometimes.
1244 This should help with projects.maemo.org bug NB#57740.
1246 2007-06-21 Armin Burgmeier <armin@openismus.com>
1248 * src/modest-mail-operation.c: Do not call
1249 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1250 notify the operation's end after having set the status to CANCELED for
1251 the operation queue to listen on. This fixes a deadlock when there
1252 were mail operations in the queue during its finalization.
1254 * src/modest-singletons.c: Reordered uninitialization of the account
1255 manager to happen after the mail operation queue was uninitialized
1256 because the mail operation's in the queue might still try to access
1257 the account manager (see modest_mail_operation_notify_end()). This
1258 fixes a potential crash when terminating the application.
1260 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1262 * src/modest-search.c:
1263 (search_mime_part_and_child_parts): Moved some code here so we
1264 can search recursively in child folders.
1265 (modest_search_folder): Search in the message as a mime part, instead
1266 of just its child mime parts.
1267 (read_chunk), (search_mime_part_ogs):
1268 Check how many bytes were read, to prevent an endless loop.
1269 Searching in message bodies now works. This finishes the fix for
1270 projects.maemo.org bug NB#61007.
1272 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1274 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1275 Add a g_warning when the item is not a folder.
1277 * src/modest-ui-dimming-rules.c:
1278 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1279 when selected item is not a folder (for instance, an account), because
1280 the UI spec only talks about folders.
1281 I am not sure what the UI spec wants, so this might not totally fix
1282 projects.maemo.org bug NB#60794.
1284 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1286 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1287 (load_from_file): Sort the list. The unsorted list would be more noticeable
1288 in non-English locales.
1290 * src/maemo/modest-msg-edit-window.c:
1291 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1292 warning and fix the build.
1294 * src/maemo/modest-progress-bar-widget.c:
1295 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1296 avoid a g_warning, and probably to avoid a crash.
1298 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1300 * src/modest-search.c: (modest_search_folder): Check for a GError
1301 when calling tny_folder_get_headers(), to show that this is not the cause
1304 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1306 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1307 Actually set the body query instead of the subject query.
1309 * src/modest-search.c: (search_mime_part_ogs),
1310 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1311 which would probably cause it to fail if we got this far.
1313 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1314 to simplify the code.
1315 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1316 be causing search-in-body to fail.
1318 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1320 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1322 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1323 Better debug message when the folder cannot be found.
1324 This should help with fixing projects.maemo.org bug #61287.
1325 * src/modest-search.c: (add_hit): Do not leak the furl string.
1327 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1329 * src/modest-ui-actions.c:
1330 (modest_ui_actions_on_folder_selection_changed):
1331 Do not special-case TNY_MERGE_FOLDER here, because
1332 modest_tny_folder_get_account() already does that. This fixes
1333 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1334 shown when the Outbox was selected).
1336 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1338 * libmodest-dbus-client/libmodest-dbus-client.c:
1339 (_dbus_iter_get_string_or_null): Initialize the string variable in
1340 case this helps with Dirk's crash.
1342 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1344 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1345 though it is not implemented yet (this function is maybe not even used),
1346 to avoid breaking ABI in future.
1347 * libmodest-dbus-client/libmodest-dbus-client.c:
1348 (get_attachments_string): Moved some code into this generic function.
1349 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1350 sends email. It is maybe not used.
1351 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1352 (on_send_mail): Use attachments.
1354 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1355 * src/maemo/modest-msg-edit-window.c:
1356 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1357 a filename before using it, to fix projects.maemo.org bug NB#58233.
1359 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1361 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1362 Initialize the continue_download variable to fix the build, and probably
1363 to fix randome behaviour.
1365 2007-06-18 Armin Burgmeier <armin@openismus.com>
1367 * src/modest-tny-send-queue.h:
1368 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1369 the queue so we can later show it in the UI. Replaced
1370 modest_tny_send_queue_msg_is_being_sent() by
1371 modest_tny_send_queue_get_msg_status().
1373 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1375 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1376 gpointer. This probably was not harmful, but just to be sure.
1378 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1380 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1381 Fix the build, but leave the function broken on Bora, because
1382 hildon_uri_action_get_service() does not exist.
1383 osso_uri_action_get_service() does not exist either, it seems.
1385 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1387 * src/modest-tny-account.c:
1388 (modest_tny_account_new_from_server_account):
1389 Uncommented the url debug output again, because it is useful for
1390 debugging, as I said in the comment.
1392 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1394 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1396 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1397 for Mameo Bora, to fix the build.
1399 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1402 Fixed build with hildon < 0.99
1404 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1405 Check if the selected account is busy instead of checking all accounts
1407 * src/modest-account-mgr-priv.h:
1408 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1409 (modest_account_mgr_init), (compare_account_name),
1410 (modest_account_mgr_set_account_busy),
1411 (modest_account_mgr_account_is_busy):
1412 * src/modest-account-mgr.h:
1413 Added busy information to the account manager. It possible to
1414 set an account to busy or not busy now.
1416 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1417 (modest_mail_operation_update_account),
1418 (modest_mail_operation_notify_end):
1419 Set the account to busy/not busy depending on the operation state.
1421 * src/widgets/modest-account-view.c:
1422 (modest_account_view_finalize), (get_last_updated_string),
1423 (update_account_view), (on_account_busy_changed), (init_view):
1424 Show string "Refreshing..." if the account is currently busy.
1426 All this fixes projects.maemo.org bug NB#59711
1428 2007-06-14 Armin Burgmeier <armin@openismus.com>
1430 * src/widgets/modest-attachments-view.h:
1431 * src/widgets/modest-attachments-view.c: Added
1432 modest_attachments_view_has_attachments() and fixed coordinate
1433 transformation in get_att_view_at_coords(). This fixes attachment
1436 * src/widgets/modest-msg-view.c: Make use of
1437 modest_attachments_view_has_attachments() to decide whether to show
1438 attachments in the header.
1440 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1442 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1443 (on_change), (on_combo_security_changed),
1444 (modest_connection_specific_smtp_edit_window_init),
1445 (modest_connection_specific_smtp_edit_window_set_connection),
1446 (modest_connection_specific_smtp_edit_window_is_dirty):
1447 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1448 * src/maemo/modest-connection-specific-smtp-window.c:
1451 Show an comfirmation dialog for the smpt-edit-window if there are
1452 unsaved changes and the user hits cancel.
1453 (projects.maemo.org bug NB#60479)
1455 2007-06-14 Armin Burgmeier <armin@openismus.com>
1457 * src/maemo/easysetup/modest-easysetup-wizard.c:
1458 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1459 address" info in banner instead of node, and select all the text as
1460 per UI spec. This fixes projects.maemo.org bug NB#60550.
1462 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1464 reviewed by: <delete if not using a buddy>
1466 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1467 * src/modest-ui-actions.c: (folder_refreshed_cb):
1469 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1471 * src/widgets/modest-folder-view.c: (filter_row):
1472 Explictly filter out the per-account outbox accounts. I don't know why
1473 these only sometimes show up, but now they should never show up in the UI.
1474 This should fix projects.maemo.org bug NB#60160.
1476 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1478 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1479 when the toolbar does not exist yet.
1480 * src/modest-widget-memory.c: (save_settings_header_view):
1481 Added g_warnings() to help us to discover when we are trying to set
1482 an empty columns list in gconf.
1484 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1486 * src/modest-init.h:
1487 * src/modest-init.c:
1488 Added modest_init_get_default_header_view_column_ids().
1490 * src/modest-widget-memory.c: (restore_settings_header_view):
1491 Use the new function to get defaults, if the gconf key is empty,
1492 instead of not creating any columns. This seems to fix the
1493 empty right-hand pane problems.
1495 * src/widgets/modest-header-view.h: Improved documentation.
1497 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1499 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1500 Revert the use of the display name as the account name, because this
1501 is generally wrong and would break the code that follows.
1503 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1505 * src/maemo/easysetup/modest-easysetup-wizard.c:
1506 (check_for_supported_auth_methods), (on_before_next),
1509 More correct fix for projects.maemo.org bug NB# 58991
1510 Do not longer accept AUTH_PASSWORD as secure method and choose
1511 correct method when creating the account.
1513 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1515 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1516 Fixed projects.maemo.org bug NB# 58991
1518 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1520 * src/modest-init.c: (modest_init_init_core),
1521 (modest_init_local_folders): Fixed compilation errors.
1523 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1525 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1526 Remove unnecessary lib/include, though it is good in principle when needed.
1528 * src/modest-init.c: (modest_init_one_local_folder),
1529 (modest_init_local_folders):
1530 * src/modest-init.h: Initialize the .modest library for memory cards,
1531 instead of just doing nothing for them. This should allow us to create
1532 folders there, fixing projects.maemo.org bug NB#59297.
1534 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1536 * libmodest-dbus-client/libmodest-dbus-client.c:
1537 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1538 (libmodest_dbus_client_compose_mail),
1539 (libmodest_dbus_client_open_message),
1540 (libmodest_dbus_client_send_and_receive),
1541 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1543 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1544 (on_idle_open_message), (modest_dbus_req_handler),
1545 (search_result_to_message), (modest_dbus_req_filter):
1546 * src/modest-search.c: (add_hit), (modest_search_folder),
1547 (modest_search_all_accounts): Improved debug messages.
1549 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1551 * src/modest-tny-account-store.c:
1552 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1555 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1558 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1560 * src/modest-tny-account-store.c: (get_server_accounts):
1561 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1562 even when there are no accounts, so that the Outbox folder is always
1563 visible. This fixes projects.maemo.org bug NB#60158.
1565 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1567 * src/maemo/modest-main-window.c: (create_details_widget):
1568 Use the mcen_va_never logical ID.
1570 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1572 * src/dbus_api/modest-dbus-api.h:
1573 * src/dbus_api/modest-dbus-callbacks.c:
1574 (on_idle_open_default_inbox), (on_open_default_inbox),
1575 (modest_dbus_req_handler):
1576 Added a new OpenDefaultInbox method.
1578 * libmodest-dbus-client/libmodest-dbus-client.h:
1579 * libmodest-dbus-client/libmodest-dbus-client.c:
1580 Added libmodest_dbus_client_open_default_inbox() to call the new
1581 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1582 though it should maybe be used by a new osso-email-interface function.
1584 * tests/dbus_api/Makefile.am:
1585 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1588 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1590 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1591 NULL, so that the signals get all the keys. This should not actually
1592 change any behaviour because we currently update everything when anything
1595 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1597 * src/widgets/modest-folder-view.c: (text_cell_data),
1598 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1599 (find_inbox_iter): If tinymail tells us that the folder is
1600 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1601 This causes the inbox to be selected at startup, fixing part of
1602 projects.maemo.org bug NB#56305.
1604 * src/modest-ui-dimming-rules.c:
1605 (modest_ui_dimming_rules_on_tools_smtp_servers):
1606 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1607 the SMTP servers menu item.
1608 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1609 that the SMTP Servers menu item is dimmed when there are no accounts,
1610 as a future version of the UI spec will require. This fixes
1611 projects.maemo.org bug NB#56305.
1613 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1615 * src/maemo/modest-maemo-utils.c:
1616 (modest_maemo_utils_get_supported_secure_authentication_methods):
1617 Added label to dialog instead of unreadable title
1619 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1620 (modest_main_window_new):
1621 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1624 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1625 * src/modest-account-mgr.h:
1626 Added method to avoid code duplication
1628 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1629 (modest_ui_actions_on_send_receive):
1630 Use modest_account_mgr_has_accounts
1632 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1634 * src/maemo/easysetup/modest-presets.c:
1635 (modest_presets_get_info_server_security): Do not report secure auth
1637 * src/modest-protocol-info.c: Use the defines for the gconf key names
1638 for secure authentication. This was not working because we were writing
1639 Password and reading password, and the check was case sensitive.
1640 With this, gmail now works for receiving and sending when created via
1643 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1645 * src/maemo/easysetup/modest-presets.c:
1646 (modest_presets_get_info_server_security): Correct the key name for
1647 SecureSmtp, because it seems to be case-sensitive.
1648 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1649 Do not try to get the 0th notebook page if there are 0 pages, to
1650 avoid a g_warning().
1652 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1654 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1655 Prevent use of the new notification feature for now, because it currently
1656 shows one dialog for each new email, which is annoying.
1658 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1660 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1661 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1662 when no country was selected, so that we show the global ones.
1663 * src/maemo/easysetup/modest-presets.c:
1664 (modest_presets_get_providers): Return only the global providers, not
1665 all providers when mmc=0 was requested.
1667 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1669 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1670 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1671 provider ID in the combo.
1673 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1674 Do not show the page numbers, because it would be confusing when we add
1675 the 2 extra pages for the custom setup, when the user chooses the "Other"
1676 provider. This fixes projects.maemo.org bug NB#59028
1678 * src/modest-init.c: (modest_init_init_core),
1679 (modest_init_local_folders):
1680 * src/modest-init.h:
1681 * src/modest-tny-account.c:
1682 (modest_tny_account_new_for_local_folders): Do not create default folders
1683 for the memory card. This should fix projects.maemo.org bug NB#59328.
1685 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1687 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1688 Free the changed_conf_keys string items. They are already freed in the
1689 idle handler if that runs first.
1691 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1693 * src/modest-ui-actions.c:
1694 (modest_ui_actions_on_password_requested): Check that the server name
1695 is not NULL, because I just saw a password dialog with (null) as the
1698 * src/modest-tny-folder.[h|c]: Added
1699 modest_tny_folder_is_memory_card_folder().
1700 * src/modest-ui-dimming-rules.c:
1701 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1702 menu item for memory cards, as per the UI spec (section 7.4). This should
1703 fix projects.maemo.org bug NB#59297.
1705 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1707 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1708 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1709 is another problem with the code, see Murray's comment at line 772)
1711 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1713 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1714 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1715 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1716 (load_from_file), (easysetup_country_combo_box_init),
1717 (easysetup_country_combo_box_get_active_country_ids),
1718 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1719 instead of just one ID, to avoid duplicate country names in the UI.
1721 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1722 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1723 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1724 a single ID, avoiding duplicate providers.
1725 * src/maemo/easysetup/modest-easysetup-wizard.c:
1726 (on_combo_account_country): Adapt to use a list.
1728 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1730 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1731 keys changed in the last X seconds.
1733 * src/modest-account-mgr.h:
1734 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1735 (on_key_change), (modest_account_mgr_class_init),
1736 (modest_account_mgr_init), (modest_account_mgr_finalize):
1737 As the keys are changed, save them in a GSList* and signal that GSList*
1738 further every X seconds, to batch changes, to allow us to do just one
1739 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1740 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1742 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1743 changed signal signature.
1745 * src/modest-conf.c: (modest_conf_set_list),
1746 (modest_conf_on_change): Reenable notification.
1748 (modest_conf_maemo_fake_on_change): Comment out the hack that
1749 notified immediately instead of asynchronously.
1751 * src/widgets/modest-account-view.h:
1752 * src/widgets/modest-account-view.c:
1753 (update_account_view): Select the previously-selected account ID,
1754 if possible. This fixes projects.maemo.org bug NB#56933.
1756 (on_account_changed), (on_account_removed),
1757 (modest_account_view_select_account):
1759 Remove the block/unblock functions
1760 because they were not useful.
1762 * src/maemo/modest-account-view-window.c:
1763 (on_delete_button_clicked), (on_edit_button_clicked),
1764 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1766 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1768 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1769 Improve the error dialog to show Incorrect Account Settings, which seems
1770 clearer, and say that the internal error message (to be removed from the
1771 dialog later) is often misleading.
1772 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1774 * src/modest-tny-account.c:
1775 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1776 URL because this is so useful for debugging on the device.
1778 * src/widgets/modest-serversecurity-combo-box.c:
1779 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1781 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1783 * src/modest-mail-operation.c:
1784 (modest_mail_operation_send_new_mail):
1785 Added a comment about a nasty but apparently harmless message. Details
1786 added to the wiki g_warnings() page.
1788 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1790 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1791 (modest_tny_send_queue_class_init):
1792 Do not use the priv struct because it is empty, to avoid g_warnings
1793 about a non-existant priv struct.
1795 * src/modest-tny-account-store.c:
1796 (modest_tny_account_store_get_server_account),
1797 (modest_tny_account_store_get_transport_account_for_open_connection
1798 ): Do not try to get transport server accounts for local folders,
1799 because they don't have any. This avoids a g_warning().
1801 * src/maemo/modest-main-window.c:
1802 (modest_main_window_notify_send_receive_initied),
1803 (on_configuration_key_changed):
1804 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1805 * src/modest-defs.h:
1806 * src/modest-mail-operation.c:
1807 (modest_mail_operation_update_account):
1808 * src/modest-tny-account-store.h:
1809 * src/modest-tny-account.c:
1810 (modest_tny_account_get_special_folder),
1811 (modest_tny_account_new_for_local_folders),
1812 (modest_tny_account_new_for_per_account_local_outbox_folder):
1813 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1814 * src/modest-tny-local-folders-account.c:
1815 (add_account_folders_to_merged_folder):
1816 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1817 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1818 (modest_ui_actions_on_send):
1819 * src/widgets/modest-folder-view.c: (update_model):
1820 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1821 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1822 modest_tny_account_store_get_tny_account_by_account() to
1823 modest_tny_account_store_get_server_account() to make the code clearer.
1825 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1827 * src/dbus_api/modest-dbus-api.h:
1828 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1829 * src/maemo/modest-msg-edit-window.c:
1830 (modest_msg_edit_window_attach_file_noninteractive):
1831 added g_warning in case the file to be attached does not exist
1832 * tests/dbus_api/test_compose_mail.c: (main):
1833 removed obsolete comment, added generic files as test case
1835 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1837 * src/modest-tny-account-store.c: (get_server_accounts):
1838 Create the local folders account only once, not once for each outbox, and
1839 not only when there are some outboxes.
1841 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1843 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1844 code that is causing a crash at startup. Sergio says that he is fixing this.
1846 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1848 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1849 * src/maemo/modest-account-settings-dialog.c:
1850 (create_page_outgoing),
1851 (modest_account_settings_dialog_set_account_name),
1852 (save_configuration):
1853 - Fixed handling of the "Use secure authentication" toggle to comply with
1854 the ui specification. See also projects.maemo.org bug NB#58400
1856 - Restore the Secure connection setting combo correctly when loading
1859 * src/maemo/modest-maemo-utils.c:
1860 (on_camel_account_get_supported_secure_authentication),
1861 (modest_maemo_utils_get_supported_secure_authentication_methods):
1862 Fixed a crasher if operation is canceled
1864 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1865 (modest_protocol_info_auth_is_secure):
1866 * src/modest-protocol-info.h:
1868 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1869 the sense of the "Use secure authentication" toggle.
1871 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1873 * src/modest-tny-account-store.h:
1874 * src/modest-tny-account-store.c:
1875 Added modest_tny_account_store_get_local_folders_account().
1877 * src/modest-tny-folder.h:
1878 * src/modest-tny-folder.c:
1879 (modest_tny_folder_get_account):
1880 Added this replacement for tny_folder_get_account() which returns
1881 the local-folders account for TnyMergeFolders, to avoid the
1882 warning about the unimplemented get_account_func() vfunc().
1884 (modest_tny_folder_get_rules),
1885 * src/modest-ui-actions.c:
1886 (modest_ui_actions_on_folder_selection_changed):
1887 * src/modest-mail-operation.c:
1888 (modest_mail_operation_remove_folder),
1889 (modest_mail_operation_xfer_folder),
1890 (modest_mail_operation_rename_folder),
1891 (modest_mail_operation_get_msg),
1892 (modest_mail_operation_get_msgs_full),
1893 (modest_mail_operation_remove_msg),
1894 (modest_mail_operation_xfer_msgs),
1895 (modest_mail_operation_refresh_folder):
1896 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1898 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1900 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1901 (modest_server_account_set_security):
1902 * src/modest-defs.h: Add comments explaining that our
1903 UI spec means TLS when it says Normal, so these do not look like errors.
1905 * src/modest-tny-account.c:
1906 (modest_tny_account_new_from_server_account): Use the new tinymail
1907 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1908 for TLS. This should fix projects.maemo.org bug NB#58460.
1910 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1912 * src/maemo/easysetup/modest-easysetup-wizard.c:
1913 (create_account): Correct the position of the gconf sanity check warning.
1914 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1915 of using the g_idle_add() hack, because this does not seem to be necessary
1916 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1917 caused by something other than maemo's gconf.
1918 This fixes projects.maemo.org bug #59022.
1920 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1922 * src/modest-account-mgr-helpers.c:
1923 (modest_account_mgr_get_default_account): Do not check that the account
1924 exists if there is no default account (NULL), to fix a runtime warning.
1926 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1928 * src/widgets/modest-folder-view.c: (update_model):
1929 Do not unref the treemodel before we have finished with it.
1930 This prevents a valgrind warning and an occasional crash at startup.
1932 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1934 * libmodest-dbus-client/libmodest-dbus-client.h:
1935 added libmodest_dbus_client_compose_mail()
1936 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1938 added functions needed for SendAsMail() functionality
1939 * src/maemo/modest-msg-edit-window.c:
1940 (modest_msg_edit_window_attach_file_noninteractive):
1941 non interactively attaching files to message edit window
1942 * src/widgets/modest-msg-edit-window.h:
1943 * tests/dbus_api/Makefile.am:
1944 added test_compose_mail.c
1945 * tests/dbus_api/test_compose_mail.c: (main):
1947 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1949 * src/modest-account-view.c:
1950 Fixed bug projects.maemo.org bug NB#59307
1952 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1954 * src/maemo/easysetup/modest-easysetup-wizard.c:
1955 (get_serverport_incoming), (on_before_next), (create_account):
1956 * src/maemo/modest-account-settings-dialog.c:
1957 (modest_account_settings_dialog_set_account_name):
1958 * src/maemo/modest-maemo-utils.c:
1959 (on_camel_account_get_supported_secure_authentication_status),
1960 (on_camel_account_get_supported_secure_authentication),
1961 (on_secure_auth_cancel),
1962 (modest_maemo_utils_get_supported_secure_authentication_methods):
1964 Implemented security authentication for settings and easysetup.
1966 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1968 * src/maemo/modest-main-window.c: (create_details_widget):
1969 Show the total size for memory card accounts too, instead of showing
1970 the name again. Fixes bug projects.maemo.org bug NB#59307.
1972 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1975 * src/modest-tny-simple-folder-store.c:
1976 * src/modest-tny-simple-folder-store.h: Removed.
1978 * src/modest-tny-local-folders-account.h
1979 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1980 for the local-folders maildir, with an extra TnyMergedFolder containing
1981 the folders of the per-account outbox store accounts.
1982 * src/modest-tny-account-store.c: (get_server_accounts):
1983 Add the outboxes to the special local folders account after creating it.
1985 * src/modest-tny-account.c:
1986 (modest_tny_account_new_for_local_folders): Create the derived
1987 account when creating the main local-folders account.
1989 * src/maemo/modest-main-window.c: (create_details_widget),
1990 (modest_main_window_set_contents_style):
1991 Adapted to the use of the derived account instead of the folder store.
1993 * src/modest-ui-actions.c:
1994 (modest_ui_actions_on_folder_selection_changed):
1995 * src/modest-ui-dimming-rules.c:
1996 (modest_ui_dimming_rules_on_new_folder):
1997 * src/widgets/modest-folder-view.c: (text_cell_data),
1998 (icon_cell_data), (filter_row), (update_model),
1999 (get_cmp_rows_type_pos):
2002 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2003 Do not get the priv struct, because no priv struct has been set,
2004 to avoid a runtime warning.
2006 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2007 #ifelse with #else, to fix a warning, to fix the build.
2010 2007-06-05 Christian Kellner <ckellner@openismus.com>
2012 * libmodest-dbus-client/libmodest-dbus-client.c:
2013 Fix small typo in doc (why do you always see them
2014 AFTER committing stuff?)
2017 2007-06-05 Christian Kellner <ckellner@openismus.com>
2019 * libmodest-dbus-client/libmodest-dbus-client.c:
2020 (libmodest_dbus_client_search):
2021 Initialize hit list with NULL. Also set folder list
2022 to "" if NULL was supplied.
2025 2007-06-03 Christian Kellner <ckellner@openismus.com>
2027 * libmodest-dbus-client/libmodest-dbus-client.c:
2028 (modest_search_hit_list_free):
2029 Make it save to call it with NULL.
2031 * src/dbus_api/modest-dbus-callbacks.c:
2032 * src/modest-search.c:
2033 Return full ModestSearchHits as the search result list not TnyHeader
2034 since can't be around withouth the correspoding TnyFolder.
2036 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2038 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2039 Added currently commented code to check for secure auth
2041 * src/maemo/modest-account-settings-dialog.c: (on_response),
2042 (save_configuration), (show_ok):
2043 Fixed projects.maemo.org bugs NB #59248 and #59251
2045 * src/maemo/modest-maemo-utils.c:
2046 (on_camel_account_get_supported_secure_authentication_status),
2047 (on_camel_account_get_supported_secure_authentication),
2048 (modest_maemo_utils_get_supported_secure_authentication_methods):
2049 * src/maemo/modest-maemo-utils.h:
2050 Moved get_supported_secure_authentication() method here to be able
2051 to use it from easysetup wizard.
2053 * src/modest-pair.c: (on_pair_compare_as_string):
2054 Should compare string with first part of pair and not
2055 strcmp pairs which will crash.
2057 * src/modest-protocol-info.c:
2058 (modest_protocol_info_protocol_is_store):
2059 * src/modest-protocol-info.h:
2060 Added modest_protocol_info_get_auth_protocol_name()
2062 2007-06-03 Armin Burgmeier <armin@openismus.com>
2064 * src/modest-mail-operation.c:
2065 (modest_mail_operation_get_msgs_full): Set priv->account also when
2066 only retrieving a single message. This avoids a crash when canceling
2069 (modest_mail_operation_notify_end): Do not explicitely remove the
2070 operation from the queue but only emit the progress_changed signal.
2071 The queue itself listens to that signal to remove the operation when
2072 it is finished. This reduces coupling and removes a potential deadlock
2073 when modest_mail_operation_notify_end() is called from the queue
2074 itself. If that is a problem performance-wise, I would suggest to
2075 implement a status-changed signal or something.
2077 * src/modest-mail-operation-queue.c: Make sure to never call a
2078 function from another file while the queue is locked. This (hopefully)
2079 fixes another deadlock when exiting the application while retrieving
2082 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2084 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2085 Fixed build if libogs is not available
2087 2007-06-03 Christian Kellner <ckellner@openismus.com>
2089 * libmodest-dbus-client/libmodest-dbus-client.h:
2090 * libmodest-dbus-client/libmodest-dbus-client.c:
2091 (libmodest_dbus_client_delete_message):
2092 Implement deletion of messages (Client side).
2094 (modest_search_hit_free),
2095 (modest_search_hit_list_free):
2096 Utility functions to free the result hits.
2098 * src/dbus_api/modest-dbus-api.h:
2099 * src/dbus_api/modest-dbus-callbacks.c:
2100 (on_delete_message),
2101 (modest_dbus_req_handler):
2102 Implement deletion of messages (Server side).
2104 * tests/dbus_api/test_search.c: (main):
2107 * tests/dbus_api/Makefile.am:
2108 * tests/dbus_api/test_delete_message:
2109 Add little test for the message deletion logic
2111 2007-06-03 Armin Burgmeier <armin@openismus.com>
2113 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2114 when the operation queue was not empty. projects.maemo.org bug
2117 2007-06-03 Armin Burgmeier <armin@openismus.com>
2119 * src/widgets/modest-account-view.c
2120 (on_account_default_toggled): Toggle default account column
2121 explicitely instead of waiting for gconf notification (which is
2122 currently ignored). This should fix projects.maemo.org bug NB#56910
2123 for now. It should probably be removed when gconf notifications are
2126 2007-06-03 Christian Kellner <ckellner@openismus.com>
2128 * libmodest-dbus-client/libmodest-dbus-client.c:
2129 Removed debugging spew.
2131 * src/dbus_api/modest-dbus-callbacks.c:
2132 Added debugging info.
2134 * src/modest-search.c:
2135 (modest_search_all_accounts):
2136 Use tny_account_store_get_accounts () on the account store
2137 to get all accounts which is the way to get all accounts.
2139 * tests/dbus_api/test_search.c: (main):
2140 Make it possible to supply the search term on the command line.
2142 2007-06-03 Christian Kellner <ckellner@openismus.com>
2144 * libmodest-dbus-client/libmodest-dbus-client.c:
2145 * libmodest-dbus-client/libmodest-dbus-client.h:
2146 Implement searching for mesages over raw dbus. (Client side)
2148 * src/dbus_api/Makefile.am:
2149 * src/dbus_api/modest-dbus-api.h:
2150 * src/dbus_api/modest-dbus-callbacks.c:
2151 * src/dbus_api/modest-dbus-callbacks.h:
2152 Search framework (Server side). Also implement on_idle_open_message().
2154 * src/maemo/modest-platform.c: (modest_platform_init):
2155 Prepare for raw dbus/osso rpc interaction.
2157 * src/modest-search.h:
2158 Changed minsize from unspecific guint to guint32.
2160 * src/modest-search.c:
2162 Added strange hack which magically made tnymail work.
2164 (modest_search_folder),
2165 (modest_search_account),
2166 (modest_search_all_accounts):
2167 Implement helper functions to search all accounts, specific account
2170 * tests/dbus_api/Makefile.am:
2171 * tests/dbus_api/test_open_message.c:
2172 Read url to open from commandline.
2174 * tests/dbus_api/test_search.c:
2175 Implement small test for dbus search stuff
2177 2007-06-02 Armin Burgmeier <armin@openismus.com>
2179 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2180 include account type and account title. This fixes projects.maemo.org
2183 * src/maemo/modest-account-view-window.c: Set a title for the window.
2185 2007-06-02 Armin Burgmeier <armin@openismus.com>
2187 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2188 incoming and outgoing server name based on email address and server
2189 types as long as the names have not been edited manually. This fixes
2190 projects.maemo.org bug NB#58671.
2192 2007-06-02 Armin Burgmeier <armin@openismus.com>
2194 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2195 server type cannot be changed in future to the incoming details page
2196 when creating an account. This fixes projects.maemo.org bug NB#59029.
2198 2007-06-02 Armin Burgmeier <armin@openismus.com>
2200 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2201 and assigned max width chars so that they wrap instead of being
2202 truncated. Fixes projects.maemo.org bug NB#56126.
2204 2007-06-02 Armin Burgmeier <armin@openismus.com>
2206 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2207 introductory note to the connection specific smtp servers dialog, as
2208 section 8.12 of the email UI specification requires. This fixes
2209 projects.maemo.org bug NB#59212.
2211 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2213 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2214 Check for running mail operations, and offer to cancel them, as per the UI
2215 spec. This fixes projects.maemo.org bug NB#59041 .
2216 However, I suspect that tinymail may still use the network connection
2217 in ways that we cannot detect or cancel. But it should at least adapt to
2218 changes fairly well.
2220 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2222 * src/modest-tny-account-store.c: (recreate_all_accounts),
2223 (get_cached_accounts), (get_server_accounts): Do more sensible
2224 ref-counting of the temporarily-cached outbox accounts list. This seems
2225 to fix a crash when entering the password when the password was wrong.
2227 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2229 * src/gnome/modest-main-window.c: (connect_signals):
2230 * src/modest-tny-account-store.c: (get_password),
2231 (modest_tny_account_store_alert): Added comments and clues and
2232 commented-out code about how we currently fail to deal with connection
2233 errors and wrong passwords, and how we should.
2235 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2237 * src/widgets/modest-retrieve-combo-box.c:
2238 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2239 This fixes projects.maemo.org bug NB#58472 .
2241 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2243 * src/maemo/easysetup/modest-easysetup-wizard.c:
2244 (create_page_complete_easysetup):
2245 (create_page_complete_custom): Correct the last commit,
2246 putting the correct sentences in the correct pages.
2248 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2250 * src/maemo/easysetup/modest-easysetup-wizard.c:
2251 (create_page_complete_custom): Show the second sentence of text
2252 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2255 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2257 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2258 Set the leave-on-server conf key by default. This fixes
2259 projects.maemo.org bug NB#59258 .
2261 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2263 * src/maemo/modest-account-view-window.c:
2264 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2265 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2268 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2270 * src/maemo/easysetup/modest-easysetup-wizard.c:
2271 (create_caption_new_with_asterisk):
2272 * src/maemo/modest-account-settings-dialog.c:
2273 (create_caption_new_with_asterisk):
2274 Uncomment the code to add the asterisk, because they are no longer in the
2275 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2276 (update_incoming_server_title): Add an asterisk here too.
2278 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2280 * src/maemo/modest-maemo-global-settings-dialog.c:
2281 (current_connection): Check that we are even connected before trying to
2282 get the current connection name, to prevent a warning.
2284 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2285 Change the comments because tny_maemo_conic_device_connect() is now meant to
2287 * src/modest-mail-operation.c:
2288 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2289 make sure we have a connection and fail if we can't connect.
2291 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2293 * src/maemo/modest-main-window.c:
2294 (on_account_store_connecting_finished): Do not try to get the
2295 connection ID if we are not really connected. I am surprised that
2296 this signal handler is called when we are not connected.
2298 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2300 * src/modest-error.h:
2301 * src/modest-ui-actions.c:
2302 (modest_ui_actions_get_msgs_full_error_handler):
2303 Renamed an enum, added comments, added an enum
2304 for retrieve-limit errors.
2306 * src/modest-mail-operation.c: (foreach_add_item),
2307 (internal_folder_observer_update), (update_account_thread),
2308 (modest_mail_operation_get_msgs_full):
2309 (modest_mail_operation_update_account),
2310 Added comments about how this works, and some code that should
2311 (but does not) check the retrieve-limit. See the TODO comment.
2313 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2315 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2316 Initialize help_id to fix the build. Warnings are good.
2318 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2320 * src/widgets/modest-hbox-cell-renderer.c:
2321 (modest_hbox_cell_renderer_append):
2322 * src/widgets/modest-vbox-cell-renderer.c:
2323 (modest_vbox_cell_renderer_append):
2324 Fix the last commit by doing an extra ref.
2326 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2328 * src/widgets/modest-hbox-cell-renderer.c:
2329 (modest_hbox_cell_renderer_append):
2330 * src/widgets/modest-vbox-cell-renderer.c:
2331 (modest_vbox_cell_renderer_append):
2332 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2333 to fix the build with Maemo Bora.
2334 However, there seems to be a remaining crash, probably due to reference
2337 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2339 * src/modest-tny-account.c:
2340 (modest_tny_account_new_for_local_folders):
2341 Use hildon_file_system_info_async_new() to get a better name for
2342 the memory card account, setting it as the account name.
2343 The timing seems to work, but this is probably
2344 not the best place to do this. See the TODO comment.
2345 * src/maemo/modest-main-window.c: (create_details_widget):
2346 * src/widgets/modest-folder-view.c: (text_cell_data):
2347 Use the tny account name instead of hardcoding a name.
2349 2007-05-30 Christian Kellner <ckellner@openismus.com>
2351 * src/modest-search.c: (modest_search):
2352 Correctly set part_search_func even if we have already parsed
2353 the query and thus a valid OgsTextSearcher object.
2355 2007-05-30 Christian Kellner <ckellner@openismus.com>
2358 Search and check for libogs.
2361 Incooparte the ogs build env.
2363 * src/modest-mime-part-search-stream.c:
2364 * src/modest-mime-part-search-stream.h:
2365 Removed since we do the real searching now in modest-search.c.
2367 * src/modest-search.c:
2368 * src/modest-search.h:
2369 Implement support for ogs. We use that if available and requested
2370 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2371 should now handle the corner case when the search term is spread
2372 across multiple reads.
2373 Also the logic in modest_search () was corrected to search all
2374 requested fields until one is found.
2376 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2378 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2380 * src/modest-init.h:
2381 * src/modest-init.c: Made modest_init_local_folders() take a
2382 path and be public so we can iniitialize maildir folders on
2385 * src/modest-local-folder-info.h:
2386 * src/modest-local-folder-info.c:
2387 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2389 * src/modest-tny-account.c:
2390 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2391 still means the standard local-folders path on the local volume.
2393 * src/modest-tny-account-store.c:
2394 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2395 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2396 all accounts when that happens.
2397 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2398 this too, so it shows up in the treeview.
2400 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2402 * src/maemo/modest-maemo-global-settings-dialog.c:
2403 (current_connection):
2404 * src/widgets/modest-global-settings-dialog.c:
2405 (current_connection_default):
2406 Use the enum values instead of 0, 1 and -1,
2407 to make the code clearer.
2409 * src/modest-account-mgr-helpers.c:
2410 (modest_account_mgr_get_connection_specific_smtp): Make this code
2413 * src/modest-runtime.h:
2414 * src/modest-runtime.c:
2415 Added modest_runtime_remove_all_send_queues().
2416 * src/maemo/modest-main-window.c:
2417 (on_account_store_connecting_finished): Recreate the send queues,
2418 using the appropriate transport accounts for this new connection.
2419 Some futher adapting might be needed if the old send queues are not
2420 automatically stopped at this point.
2422 * src/modest-tny-account-store.c: (get_server_accounts):
2423 Create the connection-specific transport accounts, so that they can
2424 be found later by their ID.
2426 * src/modest-tny-account.h:
2427 * src/modest-tny-account.c:
2428 Added modest_tny_account_new_from_server_account_name().
2429 modest_tny_account_new_from_server_account(): Do not create the
2430 send queues here, because they will be
2431 recreated anyway when the connection changes for the first time.
2433 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2435 * src/modest-local-folder-info.h:
2436 * src/modest-local-folder-info.c:
2437 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2438 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2439 tbox_folder): Take a modest account name instead of a server TnyAccount,
2440 so we can have per-modest-account rather than per-transport-account
2442 We must make sure that we change or recreate the exisitng send queues
2443 when the connection changes for connection-specific transport accounts.
2445 * src/modest-tny-account-store.c:
2446 (create_per_account_local_outbox_folders): Create outboxed per modest
2447 account, not per transport account.
2449 * src/modest-tny-account.h:
2450 * src/modest-tny-account.c:
2451 (modest_tny_account_get_special_folder): For outboxes, get the
2452 parent modest account name. The account is ignored for other folders.
2453 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2454 modest account name rather than a server TnyAccount.
2456 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2458 * src/modest-tny-account.c:
2459 (modest_tny_account_new_from_server_account):
2460 Call modest_runtime_get_send_queue() immediately after creating transport
2461 accounts, so that they start trying to send email from the outbox as soon
2462 as possible at startup. This is probably what we want.
2464 * src/modest-mail-operation.c: (update_account_thread):
2465 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2466 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2467 * src/modest-tny-send-queue.h:
2468 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2469 (modest_ui_actions_on_send):
2470 Added comments about how sending works, though it needs some more work.
2472 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2474 * src/modest-tny-account.c:
2475 (modest_tny_account_get_special_folder): Add TODO because this fails when
2476 the network is busy.
2477 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2478 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2479 Do not try to show this window when there is no active account. The UI
2480 specs does not tell us what to do in this case.
2482 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2486 * src/maemo/Makefile.am:
2487 * src/widgets/Makefile.am: Some dist fixes.
2489 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2491 * src/maemo/modest-connection-specific-smtp-window.c:
2492 (on_button_edit): Make the code clearer, to prevent a double free.
2494 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2496 * src/maemo/modest-account-settings-dialog.c:
2497 (modest_account_settings_dialog_set_account_name),
2498 Check the connection-specific smtp servers checkbox if there are any.
2500 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2501 (modest_connection_specific_smtp_edit_window_init):
2502 Start with a suitable port number.
2504 * src/modest-account-mgr-helpers.h:
2505 * src/modest-account-mgr-helpers.c: Added
2506 modest_account_mgr_get_has_connection_specific_smtp().
2508 (modest_account_mgr_set_connection_specific_smtp),
2509 (modest_account_mgr_remove_connection_specific_smtp),
2510 (modest_account_mgr_get_has_connection_specific_smtp),
2511 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2512 connection-specific smtp server accounts in the account, rather than
2513 the server account conf dir.
2515 This fixes bug projects.maemo.org bug NB#58263 .
2517 * src/modest-tny-account-store.c:
2518 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2519 if there are no server accounts yet, to prevent an infinite loop when there
2520 are no accounts. Document that one must be called before the other.
2522 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2524 * src/modest-account-mgr-helpers.c:
2525 (modest_account_mgr_get_default_account): Make sure that at least
2526 one account is always the default, if there are any enabled accounts.
2527 This is just a sanity check that shouldn't be necessary.
2529 * src/modest-account-mgr-priv.c:
2530 (_modest_account_mgr_account_from_key): Unescape the conf key to
2531 get the real account name. For instance, this is an issue if a space
2532 was in the account name, which can happen because the account name
2533 is generated from the display name.
2534 (_modest_account_mgr_get_account_keyname): Always escape the
2536 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2537 Unescape the conf keys to get the real account names.
2539 For instance, previously the is-default radio button in the accounts
2540 list was not checked for any accounts at first. This fixes that,
2541 and might fix several similar bugs.
2543 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2545 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2546 Removed some debug printfs.
2548 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2550 Modest on-disk outbox directories are now here, for instance:
2551 $HOME/.modest/outboxes/<account-id-1>/outbox
2552 $HOME/.modest/outboxes/<account-id-2>/outbox
2554 $HOME/.modest/local-folders/outbox
2555 so we can have a separate outbox for each account.
2556 But they are shown as one outbox in the GtkTreeView, by using a
2557 TnyMergeFolder in a ModestTnySimpleFolderStore.
2560 * src/modest-tny-simple-folder-store.c:
2561 * src/modest-tny-simple-folder-store.h:
2562 Added ModestTnySimpleFolderStore, used to contain folders from
2563 other folder stores, such as other accounts.
2565 * src/modest-tny-outbox-account.h:
2566 * src/modest-tny-outbox-account.c:
2567 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2568 used for the per-account local outbox folders.
2570 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2571 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2572 only use this (internally) now for the non-outbox local folders.
2574 * src/modest-init.h:
2575 * src/modest-init.c: Added modest_init_one_local_folder(), for
2576 setting up the directory structure for each local folder.
2578 * src/modest-local-folder-info.c:
2579 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2580 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2582 * src/modest-local-folder-info.h:
2583 * src/modest-tny-account-store.c: (on_account_removed),
2584 (on_account_changed), (create_per_account_local_outbox_folders),
2585 (get_server_accounts), (modest_tny_account_store_get_accounts),
2586 (modest_tny_account_store_get_tny_account_by_account),
2587 (modest_tny_folder_store_is_virtual_local_folders):
2589 * src/modest-tny-account.h:
2590 * src/modest-tny-account.c:
2591 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2592 to create an on-disk per-account local outbox folder for each
2594 (create_per_account_local_outbox_folders): Create a local outbox folder
2595 for each transport account.
2596 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2597 for all local folders.
2599 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2600 instead of using g_object_get/set() directly. It is clearer.
2602 (modest_tny_folder_store_get_message_count),
2603 (modest_tny_folder_store_get_local_size
2604 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2605 because we now use these with non-acount folder stores.
2607 (modest_tny_account_get_special_folder),
2608 (modest_tny_account_new_from_server_account),
2609 (modest_tny_account_new_from_account):
2610 (recurse_folders): Adjust to the new outbox system.
2612 * src/modest-tny-folder.h:
2613 * src/modest-tny-folder.c:
2614 (modest_tny_folder_is_local_folder),
2615 (modest_tny_folder_get_local_folder_type),
2616 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2618 * src/widgets/modest-main-window.h:
2619 * src/maemo/modest-main-window.c: (create_details_widget),
2620 (modest_main_window_set_contents_style): Show details for any folder store,
2623 (modest_tny_folder_get_rules):
2624 Remove the const. C does not support constness enough for this.
2626 * src/modest-ui-actions.c:
2627 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2628 make all outboxes appear as one, in the usual local-folders tree node.
2630 (set_active_account_from_tny_account),
2631 (modest_ui_actions_on_folder_selection_changed):
2632 * src/widgets/modest-folder-view.c: (text_cell_data),
2633 (icon_cell_data), (filter_row),
2634 (add_account_folders_to_merged_folder),
2635 (add_account_folders_to_simple_folder_store), (),
2636 (get_cmp_rows_type_pos), (cmp_rows),
2637 (modest_folder_view_set_account_id_of_visible_server_account):
2638 Adjust to the new outbox system, using generic folder stores and folders
2639 in the GtkTreeModel.
2641 2007-05-23 Christian Kellner <ckellner@openismus.com>
2643 * src/modest-mail-operation.c:
2644 (modest_mail_operation_update_account):
2645 Use info->max_size instead of unintialized local var [small
2646 build fix]. (Added TODO to review that change since I don't
2649 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2651 * libmodest-dbus-client/libmodest-dbus-client.c:
2652 (libmodest_dbus_client_compose_mail): function added
2653 * src/dbus_api/modest-dbus-api.h:
2654 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2655 (on_compose_mail): Implementation of the SendAsMail functionality
2657 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2659 * src/modest-account-mgr.c:
2660 (modest_account_mgr_add_server_account): Set the secure-connection
2661 conf key for transport accounts as well as store accounts. I don't know
2662 why the if was there. For instance, this makes sure that we use SSL
2663 for the gmail preset from the easysetup wizard.
2665 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2667 * src/gnome/modest-main-window.c:
2668 (on_account_store_connecting_finished), (connect_signals):
2669 * src/maemo/modest-main-window.c:
2670 (on_account_store_connecting_finished), (connect_signals),
2671 (modest_main_window_new):
2672 Handle TnyAccountStore::connecting-finished instead of
2673 TnyDevice::connection-changed, because we cannot actually perform
2674 operations on accounts until TnyAccountStore has itself responded to
2675 the TnyDevice::connection-changed signal. This prevents a GError from
2677 Do not try to update at startup, because we (at least on scratchbox)
2678 already do an update at startup when the device goes online.
2679 This prevents a GError from tinymail.
2680 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2681 Added TODO about stopping simultaneous operations.
2683 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2685 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2686 * src/modest-mail-operation-queue.c:
2687 (modest_mail_operation_queue_remove):
2688 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2689 about where they happened.
2691 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2693 * src/modest-ui-actions.c:
2694 (modest_ui_actions_on_password_requested): Make sure that the remember
2695 output parameter is always TRUE.
2697 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2699 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2700 Show a OK/Cancel dialog if the error is a question, though we still do not
2701 know anything more about what we are asking the user.
2702 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2703 Fix an uninitialized variable (helper). This is a logic error, however.
2705 2007-05-21 Christian Kellner <ckellner@openismus.com>
2707 * src/modest-search.h:
2708 Correct bit shifting in the ModestSearchFlags enum.
2710 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2712 * src/modest-tny-account.c:
2713 (modest_tny_account_new_from_server_account): Do not use the lsub and
2714 check-all hard-coded IMAP options when using POP.
2716 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2718 * src/modest-tny-account.c:
2719 (modest_tny_account_new_from_server_account):
2720 Use NULL for the secure-auth method for POP when Password auth has been
2721 specified by the user, as we already do for IMAP. "auth=Login" causes
2722 an error from camel or the server.
2724 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2726 * src/maemo/modest-account-settings-dialog.c:
2727 (create_page_account_details),
2728 (modest_account_settings_dialog_set_account_name):
2729 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2730 for the leave-on-server checkbox, rathr than just the checkbox, when
2731 the protocol is not POP.
2733 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2735 * src/widgets/modest-account-view.c:
2736 * src/widgets/modest-account-view.h:
2737 Added modest_account_view_select_account() which will be useful later
2738 to asynchronously re-select the edited account.
2740 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2742 * src/maemo/modest-account-settings-dialog.c:
2743 (modest_account_settings_dialog_set_account_name):
2744 Automatically choose the port numbers based on the secure authentication
2745 methods, if they have not been chosen before.
2746 This fixes projects.maemo.org bug NB#56273 .
2748 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2750 * src/maemo/modest-main-window-ui.h:
2751 * src/modest-ui-actions.c:
2752 * src/modest-ui-actions.h:
2753 Connect the Tools/SMTP Servers menu item to
2754 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2755 SMTP servers dialog, as in the UI specification and saves changes when it
2756 is closed. This fixed projects.maemo.org bug NB#56305 .
2758 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2760 * src/maemo/modest-connection-specific-smtp-window.c:
2761 (modest_connection_specific_smtp_window_init):
2762 Use gtk_window_set_default_size() to make this window big enough, so
2763 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2765 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2767 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2768 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2769 (modest_connection_specific_smtp_edit_window_init),
2770 Do not try to connect to a combobox signal before the combobox exists.
2771 This fixes the cras in projects.maemo.org bug NB#56288 .
2772 (modest_connection_specific_smtp_edit_window_get_settings):
2773 Remove the server_account_name parameter which was being checked for NULL
2774 though it was not used.
2776 * src/maemo/modest-connection-specific-smtp-window.c:
2777 (modest_connection_specific_smtp_window_fill_with_connections),
2778 (on_button_edit), (modest_connection_specific_smtp_window_init):
2779 Correct the number of treemodel columns to prevent a warning.
2780 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2781 libconic does not work.
2783 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2785 * src/modest-tny-account.c:
2786 (modest_tny_account_new_from_server_account):
2787 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2788 SMTP when "None" was chosen by the user. However, with my SMTP server that
2789 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2792 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2794 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2795 to explain the memory management issue with the ID in the ModestPair.
2797 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2798 (add_sending_page), (modest_account_assistant_finalize):
2799 * src/gnome/modest-gnome-global-settings-dialog.c:
2800 (create_updating_page), (create_composing_page):
2801 * src/gnome/modest-msg-edit-window.c: (get_transports),
2802 (init_window), (modest_msg_edit_window_finalize),
2803 (modest_msg_edit_window_get_msg_data):
2804 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2805 * src/gnome/modest-transport-widget.c:
2806 (modest_transport_widget_finalize), (smtp_configuration):
2807 * src/maemo/modest-maemo-global-settings-dialog.c:
2808 (create_updating_page), (create_composing_page):
2809 * src/maemo/modest-msg-edit-window.c: (get_transports),
2810 (init_window), (modest_msg_edit_window_finalize),
2811 (modest_msg_edit_window_get_msg_data),
2812 (modest_msg_edit_window_free_msg_data):
2813 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2814 (modest_store_widget_finalize):
2815 * src/maemo/modest-transport-widget.c:
2816 (modest_transport_widget_finalize), (smtp_configuration):
2817 * src/modest-main.c: (send_mail):
2818 * src/widgets/modest-combo-box.h:
2819 * src/widgets/modest-global-settings-dialog-priv.h:
2820 * src/widgets/modest-global-settings-dialog.c:
2821 (modest_global_settings_dialog_finalize):
2822 * src/widgets/modest-msg-edit-window.h:
2823 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2824 as long as the combo box, to prevent use of freed memory for the ID.
2826 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2828 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2829 get_accounts(), to make this clearer. Do not check for the enabled gconf
2830 key, because we do not use this for server accounts (at least, not yet).
2831 This allows us to send email again.
2833 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2835 * src/maemo/modest-platform.c:
2836 (on_modest_conf_update_interval_changed), (modest_platform_init):
2837 Only respond to this particular key change. All these strcmp()s cannot be
2840 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2842 * src/maemo/modest-maemo-global-settings-dialog.c:
2843 (current_connection): Prevent a crash in scratchbox when
2844 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2845 * src/maemo/modest-platform.c:
2846 (on_modest_conf_update_interval_changed), (modest_platform_init):
2847 Get the update interval from gconf and reset it when the gconf key changes.
2849 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2851 * src/modest-protocol-info.c:
2852 * src/modest-protocol-info.h: Adde enum-specific get functions,
2853 instead of using a ModestProtocolType enum parameter.
2855 * src/gnome/modest-account-assistant.c:
2856 * src/gnome/modest-store-widget.c:
2857 * src/gnome/modest-store-widget.h:
2858 * src/gnome/modest-transport-widget.c:
2859 * src/gnome/modest-transport-widget.h:
2860 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2861 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2862 * src/maemo/easysetup/modest-easysetup-wizard.c:
2863 * src/maemo/modest-account-settings-dialog.c:
2864 * src/maemo/modest-account-settings-dialog.h:
2865 * src/maemo/modest-store-widget.c:
2866 * src/maemo/modest-store-widget.h:
2867 * src/maemo/modest-transport-widget.c:
2868 * src/maemo/modest-transport-widget.h:
2869 * src/modest-account-mgr-helpers.c:
2870 * src/modest-account-mgr-helpers.h:
2871 * src/modest-account-mgr.c:
2872 * src/modest-account-mgr.h:
2873 * src/modest-tny-account.c:
2874 * src/modest-tny-folder.c:
2875 * src/widgets/modest-account-view.c:
2876 * src/widgets/modest-retrieve-combo-box.c:
2877 * src/widgets/modest-retrieve-combo-box.h:
2878 * src/widgets/modest-secureauth-combo-box.c:
2879 * src/widgets/modest-serversecurity-combo-box.c:
2880 * src/widgets/modest-serversecurity-combo-box.h:
2881 * tests/check_account-mgr.c:
2882 Use the specific functions, and use the re-renamed enum values for GNOME too.
2884 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2886 * src/modest-pair.h:
2887 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2888 so we can get the second based on the first.
2890 * src/maemo/modest-account-settings-dialog.h:
2891 * src/maemo/modest-account-settings-dialog.c:
2892 Added get_supported_secure_authentication_methods(), though it is mostly
2893 commented-out for now until the necessary API is committed to tinymail.
2894 (modest_account_settings_dialog_set_account_name),
2895 (save_configuration): Request the supported authentication methods from the
2896 server, so we can choose a working method.
2898 * src/modest-tny-account-store.h:
2899 * src/modest-tny-account-store.c:
2900 (modest_tny_account_store_get_session): Rename from
2901 tny_account_store_get_session().
2903 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2905 * src/modest-protocol-info.h: Split the ModestProtocol enum
2906 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2907 There was no need to have these unrelated values in one enum.
2909 * src/: many files: Adapted to changed enum. This makes the code a bit
2910 clearer, and the compiler could catch some errors.
2912 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2914 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2915 Show the detailed internal camel error message when an error happens
2916 during the configuration, so that our testers can give us more clues.
2917 For instance, in projects.maemo.org bug NB#56910 .
2919 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2921 * src/modest-tny-account.c:
2922 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2923 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2925 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2927 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2928 * src/maemo/modest-account-settings-dialog.c:
2929 (modest_account_settings_dialog_set_account_name),
2930 (save_configuration): For the incoming secure authentication checkbox,
2931 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2932 the UI specification. PLAIN does not seem to be supported for most IMAP
2933 servers anyway, and I am not sure what it would mean.
2934 However, we probably need to discover which of the secure-authentication
2935 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2936 * src/modest-account-mgr-helpers.c:
2937 (modest_account_mgr_get_server_account_data):
2939 * src/modest-tny-account.c:
2940 (modest_tny_account_new_from_server_account):
2941 Use tny_account_set_mech() to set secure-authentication methods,
2942 with some special-casing for IMAP, based on my observations of how
2945 * src/modest-account-mgr-helpers.h:
2946 * src/modest-account-mgr.c:
2947 * src/modest-defs.h: Comment that the URI is only used for local folders.
2949 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2951 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2952 parameter const, just to be neat.
2953 * src/modest-text-utils.c: (modest_text_utils_inline):
2954 End g_strconcat() with NULL, as its documentation says. This is almost
2955 certainly the cause of my crash at startup on the device. Interestingly,
2956 valgrind doesn't tell us about these errors.
2958 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2960 * scripts/build-packages: Added more precise comments about how to use
2961 this script, though I still get this error:
2962 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2963 error building tinymail
2965 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2967 * src/maemo/modest-main-window.c: (on_account_update):
2968 Very slight cleanup, hoping to make it simpler to discover what causes
2969 a crash here sometimes.
2971 * src/modest-tny-account.c:
2972 (modest_tny_account_new_from_server_account): Set the port. Added
2973 comments about the options and a TODO comment because I need to find out
2974 how to specify the secure authentication method.
2976 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2978 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2979 changed CFlags paths form modest to libmodest
2981 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2983 * src/modest-account-mgr-helpers.c:
2984 (modest_account_mgr_get_server_account_data),
2985 (modest_account_mgr_free_server_account_data):
2986 * src/modest-account-mgr-helpers.h:
2987 * src/modest-account-mgr.c:
2988 (modest_account_mgr_add_server_account):
2989 * src/modest-defs.h:
2990 * src/modest-tny-account.c:
2991 (modest_tny_account_new_from_server_account):
2992 Determine the options for tny_camel_account_add_option() here,
2993 based on the settings, rather than storing them directly in gconf.
2995 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2997 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2998 Show a more friendly error dialog now that we expect (from the tinymail
2999 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3001 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3003 * src/maemo/modest-main-window.c: (on_account_update): Check that
3004 account_name is not NULL, to prevent a crash at startup that I am
3005 seeing on the N800. I do wonder why it is NULL.
3007 * src/maemo/easysetup/modest-easysetup-wizard.c:
3008 (create_page_user_details):
3009 * src/maemo/modest-account-settings-dialog.c:
3010 (create_page_user_details), (create_page_outgoing):
3011 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3012 (modest_connection_specific_smtp_edit_window_init):
3013 * src/modest-ui-actions.c:
3014 (modest_ui_actions_on_password_requested):
3015 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3016 might do something useful with the on-screen keyboard.
3018 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3020 * src/maemo/modest-main-window.c: (on_account_update):
3021 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3022 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3024 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3026 * src/modest-tny-account-store.c: (on_account_changed):
3027 Correct the signature of this signal handler.
3029 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3031 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3032 Show a HildonNote instead of a GtkDialog for Maemo.
3034 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3036 * src/widgets/modest-account-view.h:
3037 * src/widgets/modest-account-view.c: (on_account_changed),
3038 (on_account_removed). Added a boolean flag, set/unset by
3039 modest_account_view_block_conf_updates(),
3040 modest_account_view_unblock_conf_updates() to prevent unnecessary
3041 updates, but this is not very useful because the gconf notifications are
3042 so delays (maybe only on Maemo Bora).
3043 So auto-updating is turned off, and these functions do an explicit
3044 update when necessary.
3045 However, something else is still doing too much work when adding/removing
3046 accounts, probably in another part of the application.
3048 * src/maemo/modest-account-view-window.c:
3049 (on_delete_button_clicked), (on_edit_button_clicked),
3050 (on_new_button_clicked): Use the new functions.
3052 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3054 * src/modest-account-mgr-helpers.c:
3055 (modest_account_mgr_set_first_account_as_default):
3056 Sort the list of names alphabetically-by-title, so we choose the first one
3058 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3059 alphabetically by the title.
3061 This fixes projects.maemo.org bug NB#56418 .
3063 * src/modest-account-mgr-priv.c:
3064 (_modest_account_mgr_account_from_key):
3065 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3066 avoid a valgrind error, and possible random behaviour.
3068 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3070 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3071 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3072 tinymail documentation to say that this can be expected.
3073 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3074 pretty, and should not happen, but I would prefer to know when it does.
3076 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3078 * configure.ac: When using the older hildon version, probably on Bora,
3079 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3081 * src/widgets/modest-attachment-view.c:
3082 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3085 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3087 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3088 Implemented the prototype. Can be tested with
3089 tests/dbus_api/test_open_message:
3091 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3093 * src/modest-tny-account-store.c:
3094 (modest_tny_account_store_instance_init), (get_password):
3095 * src/modest-ui-actions.c:
3096 (modest_ui_actions_on_password_requested):
3097 Do not store the password in gconf, because this function is called
3098 for non-remembered passwords. Actually use the cached (in the hash map)
3099 password instead of releasing it.
3100 The password will now not be remembered if it is asked via the protected
3101 password dialog, as per the UI spec.
3103 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3105 * src/modest-defs.h:
3106 * src/modest-account-mgr-helpers.h:
3107 * src/modest-account-mgr-helpers.c:
3108 Added modest_server_account_get_username_has_succeeded(),
3109 modest_server_account_set_username_has_succeeded().
3110 (modest_server_account_set_username),
3111 Reset the has-succeeded flag if the username changes.
3113 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3114 * src/maemo/modest-connection-specific-smtp-window.c:
3115 (modest_connection_specific_smtp_window_save_server_accounts):
3116 Use modest_server_account_set_username() instead of using
3117 modest_conf_set_string() directly, so that the has-succeeded flag is always
3120 * src/modest-ui-actions.c:
3121 (modest_ui_actions_on_password_requested): Dim the username entry if
3122 the username has ever worked, as per the UI spec.
3124 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3126 * src/modest-tny-account-store.c: (get_password):
3127 * src/modest-ui-actions.c:
3128 (modest_ui_actions_on_password_requested):
3129 Allow the username to be changed too, though there is more work to
3130 be done on exactly how this behaves.
3132 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3134 * src/modest-account-mgr-helpers.h:
3135 * src/modest-account-mgr-helpers.c:
3136 Added modest_account_mgr_get_display_name(),
3137 modest_server_account_get_username(),
3138 modest_server_account_set_username(),
3139 modest_server_account_set_password(),
3140 modest_server_account_get_hostname() functions so we do not need to
3141 use the conf API directly.
3143 * src/maemo/modest-main-window.c: (connect_signals):
3144 Actually connect ot the ModestAccountStore::request-password signal,
3145 so that we show the dialog when the password is requested by Tinymail,
3146 for isntance if it is empty.
3148 * src/modest-marshal.list:
3149 * src/modest-tny-account-store.c:
3150 (modest_tny_account_store_class_init), (get_password),
3151 (modest_tny_account_store_alert):
3152 * src/modest-tny-account-store.h:
3153 * src/modest-ui-actions.h:
3154 * src/modest-ui-actions.c:
3155 (modest_ui_actions_on_password_requested):
3156 Change the signal parameters, so it is obvious that we are providing
3157 the non human-readable server name, and receiving both the username
3158 and password, though changing of the username is not yet implemented.
3159 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3160 for the GNOME version.
3162 This should fix the projects.maemo.org bug NB#56209, though it does not
3163 work on Bora, because the gconf_client_get() for the password fails
3164 immediately after we save it with gconf_client_set().
3166 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3169 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3170 caused an undefined symbol error:
3171 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3173 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3175 * src/modest-tny-account-store.c:
3176 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3177 using a GError instead of a string message, so we can translate it in
3180 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3182 * src/maemo/modest-address-book.c:
3183 (modest_address_book_check_names):
3184 * src/maemo/modest-msg-view-window.c:
3185 (modest_msg_view_window_clipboard_owner_change):
3186 * src/modest-init.c: (modest_init_init_ui):
3187 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3188 (update_folders_cb), (modest_mail_operation_update_account):
3189 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3190 (modest_ui_actions_on_msg_attachment_clicked),
3191 (modest_ui_actions_on_msg_recpt_activated):
3192 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3193 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3194 (modest_msg_view_search_next):
3195 * src/widgets/modest-recpt-editor.c:
3196 (modest_recpt_editor_on_button_release_event),
3197 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3198 g_message(). At this point we should only be seeing interesting errors on
3199 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3201 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3203 (modest_wizard_dialog_force_title_update):
3204 * src/maemo/easysetup/modest-wizard-dialog.h:
3205 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3206 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3207 can update the title when appropriate. Otherwise the title is wrong if the
3208 pages are added after adding the notebook to the dialog.
3209 This must be a problem in HildonWizardDialog too.
3210 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3212 * src/maemo/easysetup/modest-easysetup-wizard.c:
3213 (create_subsequent_customsetup_pages),
3214 (create_subsequent_easysetup_pages):
3215 Call modest_wizard_dialog_force_title_update() so that the title is
3216 correct even with GTK+ < 2.10.
3217 This fixes projects.maemo.org bug NB#56145 .
3219 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3221 * src/maemo/modest-platform.c:
3222 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3223 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3226 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3228 * src/widgets/modest-window.h:
3229 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3230 and modest_window_save_state(), which invokes it.
3232 * src/widgets/modest-window-mgr.h:
3233 * src/widgets/modest-window-mgr.c:
3234 Added modest_window_mgr_save_state_for_all_windows(), which calls
3235 the save_state vfunc on all registered windows, if implemented.
3237 * src/gnome/modest-msg-edit-window.c:
3238 * src/gnome/modest-msg-view-window.c:
3239 * src/maemo/modest-msg-edit-window.c:
3240 * src/maemo/modest-msg-view-window.c:
3241 * src/maemo/modest-main-window.c:
3242 Specify the existing save_settings functions as implementations of
3243 ModestWindow::save_state_func().
3245 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3246 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3247 enabling hibernation, for instance.
3249 We may need to do the same thing for restoring settings.
3252 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3254 * src/widgets/modest-window-mgr.c:
3255 * src/widgets/modest-window-mgr.h:
3256 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3257 modest_window_mgr_get_hibernation_is_prevented().
3259 * src/maemo/modest-main-window.c:
3260 (on_hildon_program_is_topmost_notify): Prevent hibernation
3261 (possible when the application goes to the background in the WM),
3262 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3264 * src/maemo/easysetup/modest-easysetup-wizard.c:
3265 (modest_easysetup_wizard_dialog_init):
3266 * src/maemo/modest-account-settings-dialog.c:
3267 (modest_account_settings_dialog_init):
3268 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3269 (modest_connection_specific_smtp_edit_window_init):
3270 * src/maemo/modest-connection-specific-smtp-window.c:
3271 (modest_connection_specific_smtp_window_init):
3272 * src/maemo/modest-signature-editor-dialog.c:
3273 (modest_signature_editor_dialog_init):
3274 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3275 prevent hibernation while any of these account settings dialogs are open.
3277 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3279 * src/maemo/Makefile.am:
3280 * src/maemo/modest-osso-state-saving.c:
3281 * src/maemo/modest-osso-state-saving.h: Added
3282 modest_osso_load_state() and modest_osso_save_state() though they do
3283 nothing now. They should iterate through all the open windows and load/save
3285 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3286 save state when closing.
3288 * src/maemo/modest-main-window.c:
3289 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3290 Add a notification handler for the HildonProgram::is-topmost property,
3291 so we can allow hibernation when the application goes into the background.
3292 But we still need to detect when the accounts setup windows are open so
3293 we can stop hibernation when they are open.
3294 To do this, I also added the main window the HildonProgram. This might have
3295 other side-effects/benefits, and should maybe be done for other windows.
3297 * src/maemo/modest-osso-autosave-callbacks.h:
3298 * src/maemo/modest-osso-autosave-callbacks.c:
3299 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3300 though it does not do anything yet, and we might never need this to do
3301 anything. For instance, we already save drafts.
3303 * src/maemo/modest-platform.c: (modest_platform_init):
3304 Specify the libosso auto-save callback.
3306 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3308 * src/maemo/modest-platform.c:
3309 (modest_platform_set_update_interval):
3310 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3311 aparently stays valid between application instances, so we can use this
3312 to remove and reset it later. According to a maemo-developers email from
3315 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3317 * configure.ac: Depend on libalarm for Maemo.
3319 * src/dbus_api/modest-dbus-api.h:
3320 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3321 (on_send_receive), (modest_dbus_req_handler):
3322 Handle a SEND_RECEIVE D-Bus method.
3324 * libmodest-dbus-client/libmodest-dbus-client.c:
3325 (libmodest_dbus_client_send_and_receive):
3326 * libmodest-dbus-client/libmodest-dbus-client.h:
3327 Add C convenience functions for calling the new D-Bus method.
3329 * src/modest-platform.h:
3330 * src/gnome/modest-platform.c:
3331 * src/maemo/modest-platform.c:
3332 Added modest_platform_set_update_interval(), which uses the
3333 alarmd API on Maemo.
3334 (modest_platform_init),
3335 Call modest_platform_set_update_interval(), using a hard-coded
3336 interval for now (until the global settings dialog is implemented),
3337 though I am not sure that this makes sense yet.
3339 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3341 * src/dbus_api/modest-dbus-callbacks.c:
3342 (modest_osso_cb_hw_state_handler):
3343 * src/dbus_api/modest-dbus-callbacks.h:
3344 * src/maemo/modest-platform.c: (modest_platform_init):
3345 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3346 in case this has some effect on the ability for Maemo to ping the
3349 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3351 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3352 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3353 warning. It is probably a logic error, but I need to fix the build.
3355 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3357 * src/modest-account-mgr.h:
3358 * src/modest-account-mgr.c:
3359 (modest_account_mgr_account_names): Add a gboolean enabled_only
3360 parameter, so we can get lists of onlt the enabled accounts.
3362 (modest_account_mgr_add_account),,
3363 (modest_account_mgr_account_with_display_name_exists):
3364 * src/maemo/modest-msg-edit-window.c: (get_transports):
3365 * src/modest-account-mgr-helpers.c:
3366 (modest_account_mgr_set_first_account_as_default):
3367 * src/modest-init.c: (init_default_account_maybe):
3368 * src/modest-tny-account-store.c: (get_accounts):
3369 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3370 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3371 * tests/check_account-mgr.c: (START_TEST):
3372 Provide the extra parameter, as appropriate.
3374 * src/widgets/modest-account-view.c: (update_account_view):
3375 Do not show disabled accounts (meaning that there is no way to
3376 enable/disable accounts in the UI (the feature is not in our UI
3377 specification), so we can use this internally only to mark unfinished
3378 or temporary account data.
3380 * src/maemo/easysetup/modest-easysetup-wizard.c:
3381 (create_account): Add boolean enable parameter, so we can specify FALSE
3382 to create the temporary account.
3383 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3384 (on_before_next): When finishing, when there is a temporary account, just
3386 Also, use a timeout to delay the showing of the dialog until gconf is likely
3387 to return correct information, due to a maemo gconf bug that is fixed in
3388 osso 1.1, but not yet in Bora.
3389 However, the dialog stays on screen after it is destroyed.
3391 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3392 for invalid data when cancelling. Use a hildon note instead of a dialog
3393 to complain about invalid data. Do not show the account-saved note if the
3394 account is disabled (a temporary account that will not really be saved for use
3397 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3399 * src/modest-account-mgr-helpers.h:
3400 * src/modest-account-mgr-helpers.c:
3401 Added modest_account_mgr_unset_default_account(),
3402 Added modest_account_mgr_set_first_account_as_default().
3404 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3405 If it was the default account, unset the default account name.
3407 * src/maemo/modest-account-view-window.c:
3408 (on_delete_button_clicked): If it was the default account,
3409 set the first remaining account as the default instead.
3411 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3412 a NULL account or a NULL default account, to prevent a crash. This should
3413 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3416 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3418 * src/widgets/modest-recpt-editor.c:
3419 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3420 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3421 TODO comment for this. This fixes the build.
3423 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3424 be the best place for it. This will in future update all auto-update accounts,
3425 rather than just the current/default account, when that gconf key exists.
3426 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3427 if there are no accounts, before calling do_send_receive().
3428 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3430 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3431 * src/maemo/modest-main-window-ui.h:
3432 * src/maemo/modest-main-window.c: (on_connection_changed),
3433 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3434 directly, becaue the signal handler does more.
3436 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3438 * src/modest-account-mgr-helpers.c:
3439 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3440 for the case that the account does not exist.
3442 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3443 (equivalent to the modest account name) rather than the tinymail account name
3444 (equivalent to the modest account title - human readable) to get the account data.
3445 Check for null account data to prevent the crash, and add a TODO comment saying that
3446 this needs fixing because it is using the server account name instead of the account name.
3448 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3450 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3451 * src/maemo/modest-account-settings-dialog.c: (show_error),
3453 Use hildon_note_new_information() for informative and error messages,
3454 which seems to be expected for Maemo applications (no documentation that I know of
3455 says this). I am surprised that there is no distinction between info and error
3458 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3460 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3461 it is easy to find where this is used.
3463 * src/maemo/easysetup/modest-easysetup-wizard.c:
3464 (create_page_welcome), (create_page_account_details),
3465 (create_page_user_details), (create_page_complete_easysetup),
3466 (create_page_custom_incoming), (create_page_custom_outgoing),
3467 (create_page_complete_custom):
3468 * src/maemo/modest-account-settings-dialog.c:
3469 (create_page_account_details), (create_page_user_details),
3470 (create_page_incoming), (create_page_outgoing):
3471 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3472 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3473 (modest_connection_specific_smtp_edit_window_init):
3474 * src/maemo/modest-connection-specific-smtp-window.c:
3475 (modest_connection_specific_smtp_window_init):
3476 * src/maemo/modest-signature-editor-dialog.c:
3477 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3478 and scrolling policy as per the Email Application Layout Guide, if I have
3481 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3483 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3484 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3485 which were empty, because these vfuncs have been removed from TnyAccountStore.
3486 This fixes the build.
3488 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3490 * src/maemo/modest-main-window.c:
3491 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3492 showing/hiding it. Added TODO because it probably should not be NULL.
3493 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3494 because unnecessary g_warnings() make degugging difficult.
3496 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3498 * src/maemo/modest-msg-edit-window.c:
3499 (modest_msg_edit_window_select_color),
3500 (modest_msg_edit_window_select_background_color): 2 const corrections and
3501 moving 2 #endifs before closing brackets, to fix the build.
3503 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3505 * src/maemo/easysetup/modest-easysetup-wizard.h:
3506 * src/maemo/easysetup/modest-easysetup-wizard.c:
3507 (modest_easysetup_wizard_dialog_finalize),
3508 (on_button_edit_advanced_settings), (create_page_complete_custom),
3509 (on_response), (create_account):
3510 Implement the Advanced Settings edit button, by saving the account information,
3511 for the Advanded Settings dialog to use directly from gconf, and removing it
3512 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3513 Bug #5533 in the projects.maemo.org bugzilla.
3515 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3517 * src/maemo/modest-msg-view-window.c:
3518 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3519 when opening a message window.
3521 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3523 * src/maemo/easysetup/modest-easysetup-wizard.c:
3524 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3527 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3528 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3529 gconf settings. I probably added more checks than necessary, but that is safer.
3531 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3532 variable to fix the build, but this seems to be used when it is still NULL.
3534 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3536 * src/modest-platform.h:
3537 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3538 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3539 * src/modest-main.c: Implement this function so we can avoid using
3540 maemo-specific API from cross-platform code.
3542 * src/modest-tny-account-store.c:
3543 (get_smtp_specific_transport_account_for_open_connection):
3544 * src/modest-ui-actions.c: (check_for_connection),
3545 (modest_ui_actions_on_item_not_found):
3546 Use modest_platform_connect_and_wait() and put #idefs around other
3547 maemo-specific code, because only maemo currently has a way to
3548 identify connection names.
3550 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3552 * src/modest-tny-account-store.h:
3553 * src/modest-tny-account-store.c:
3554 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3555 the connection-specific SMTP server settings in the configuration.
3557 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3559 * src/maemo/modest-main-window.c: (on_connection_changed),
3561 * src/modest-main.c: (main), (start_ui), (send_mail):
3562 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3563 that is what is intended.
3565 * src/modest-ui-actions.c: (action_send), (action_receive),
3566 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3567 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3568 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3569 SMTP server is used when it is specified.
3571 (modest_ui_actions_on_send_receive):
3572 Check that a connection is open before proceeding.
3573 Receive and then send, instead of vice-versa, as per the specification.
3575 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3577 * src/modest-mail-operation.c:
3578 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3579 though I guess it should be something other than NULL.
3581 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3583 * src/maemo/easysetup/modest-easysetup-wizard.c:
3584 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3585 combo twice, to avoid an g_warning and to make it visible again.
3586 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3587 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3588 (already intended) dereference when detaching, because we then recreate the menu.
3589 But I am not sure why the warning was happening, and it is possible that this is a memory
3592 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3594 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3595 and uri_parse_mailto() utility functions.
3596 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3598 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3600 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3602 * src/dbus_api/modest-dbus-api.h:
3603 * src/dbus_api/modest-dbus-callbacks.c:
3604 Use an idle callback to execute the modest code in the application's own thread.
3605 Remove the helloworld example method.
3606 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3607 parsed, and the open-message method is not implemented because this is not yet implemented in
3609 * libmodest-dbus-client/libmodest-dbus-client.c:
3610 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3611 (libmodest_dbus_client_open_message):
3612 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3614 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3615 body without crashing.
3617 * tests/dbus_api/Makefile.am:
3618 * tests/dbus_api/test_mail_to.c:
3619 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3621 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3623 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3624 Added file to fix the build. Sorry.
3626 * src/dbus_api/Makefile.am:
3627 * src/dbus_api/modest-dbus-api.h:
3628 * src/dbus_api/modest-dbus-callbacks.h:
3629 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3630 (modest_dbus_req_handler):
3631 Put constants in a separate header so it can be reused by the
3632 client library, without duplication
3634 * libmodest-dbus-client/Makefile.am:
3635 * libmodest-dbus-client/libmodest-dbus-client.c:
3636 (libmodest_dbus_client_call_helloworld),
3637 (libmodfest_dbus_client_send_mail),
3638 (libmodfest_dbus_client_mailto),
3639 (libmodfest_dbus_client_open_message):
3640 * libmodest-dbus-client/libmodest-dbus-client.h:
3641 (Partly) Implement a send_mail D-Bus method.
3643 * tests/dbus_api/Makefile.am:
3644 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3645 the send_email D-Bus method.
3647 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3651 * libmodest-dbus-client/Makefile.am:
3652 * libmodest-dbus-client/libmodest-dbus-client.c:
3653 * libmodest-dbus-client/libmodest-dbus-client.h:
3654 * tests/dbus_api/Makefile.am:
3655 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3656 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3658 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3660 * src/maemo/easysetup/modest-easysetup-wizard.c:
3661 (create_page_account_details):
3662 * src/maemo/modest-account-settings-dialog.c:
3663 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3664 widgets, because this might not be the default in future versions of the Maemo GTK+.
3665 However, I can not not get capitalization to work even in a simple test case.
3667 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3669 * src/maemo/easysetup/modest-easysetup-wizard.c:
3670 (create_page_custom_incoming), (create_page_custom_outgoing):
3671 * src/maemo/modest-account-settings-dialog.c:
3672 (create_page_account_details), (create_page_incoming),
3673 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3674 instead of using gtk_check_button_with_label(), so they are aligned like the other
3675 widgets, as per the UI spec.
3677 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3679 * src/maemo/easysetup/modest-easysetup-wizard.c:
3680 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3681 * src/widgets/modest-validating-entry.c:
3682 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3683 Modest prefix instead of an EasySetup prefix.
3685 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3687 * src/widgets/modest-validating-entry.h:
3688 * src/widgets/modest-validating-entry.c: (on_insert_text),
3689 Added easysetup_validating_entry_set_max_func(), used to set a callback
3690 to call when the max number of characters is reached. GtkEntry has a max-length
3691 already but is silent about it.
3693 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3694 (create_page_account_details), (create_page_user_details),
3696 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3697 (create_page_account_details), (create_page_user_details),
3698 (create_page_outgoing):
3699 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3700 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3701 the UI spec, when the user tries to enter more than the max number of characters.
3703 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3705 * src/maemo/easysetup/modest-easysetup-wizard.c:
3706 (create_page_user_details), (create_page_custom_incoming),
3707 (create_page_custom_outgoing):
3708 * src/maemo/modest-account-settings-dialog.c:
3709 (create_page_user_details), (create_page_incoming),
3710 (create_page_outgoing):
3711 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3712 (modest_connection_specific_smtp_edit_window_init):
3713 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3714 not appropriate. Bad Maemo-specific defaults!.
3716 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3718 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3719 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3720 (modest_signature_editor_dialog_set_settings):
3721 Disable the label and textview when the checkbox is disabled, and use the
3722 specified (UI spec) default signature text.
3724 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3726 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3727 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3729 * src/modest-defs.h:
3730 * src/modest-account-mgr-helpers.h:
3731 * src/modest-account-mgr-helpers.c:
3732 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3734 * src/maemo/Makefile.am:
3735 * src/maemo/modest-signature-editor-dialog.c:
3736 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3739 * src/maemo/modest-account-settings-dialog.h:
3740 * src/maemo/modest-account-settings-dialog.c:
3741 (modest_account_settings_dialog_finalize), (on_button_signature),
3742 (save_configuration): Use the new dialog when the Edit button is pressed, and
3743 save the changes if necessary, as per the UI spec.
3745 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3747 * src/maemo/Makefile.am:
3748 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3749 based on maemo-develoers email from Dirk.
3751 * src/maemo/easysetup/modest-easysetup-wizard.c:
3752 (create_page_welcome), (create_page_account_details),
3753 (create_page_user_details), (create_page_complete_easysetup),
3754 (create_page_custom_incoming), (create_page_custom_outgoing),
3755 (create_page_complete_custom),
3756 (modest_easysetup_wizard_dialog_init):
3757 * src/maemo/modest-account-settings-dialog.c:
3758 (create_page_account_details), (create_page_user_details),
3759 (create_page_incoming), (create_page_outgoing),
3760 (modest_account_settings_dialog_init):
3761 * src/maemo/modest-connection-specific-smtp-window.c:
3762 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3764 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3766 * src/maemo/easysetup/modest-easysetup-wizard.c:
3767 (create_page_account_details), (create_page_custom_outgoing),
3768 (create_page_complete_custom):
3769 * src/maemo/modest-account-settings-dialog.c:
3770 (create_page_user_details), (create_page_incoming),
3771 (create_page_outgoing):
3772 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3773 (modest_connection_specific_smtp_edit_window_init):
3774 Use the correct (UI spec) port min/max, and use horizontal separators,
3777 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3779 * src/maemo/easysetup/modest-easysetup-wizard.c:
3780 (set_default_custom_servernames):
3781 * src/maemo/modest-account-settings-dialog.c:
3782 (create_page_incoming), (on_combo_outgoing_security_changed),
3783 (on_combo_incoming_security_changed), (create_page_outgoing),
3784 (modest_account_settings_dialog_set_account_name),
3785 (save_configuration):
3786 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3787 (on_combo_security_changed),
3788 (modest_connection_specific_smtp_edit_window_init),
3789 (modest_connection_specific_smtp_edit_window_set_connection),
3790 (modest_connection_specific_smtp_edit_window_get_settings):
3791 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3794 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3797 * src/maemo/easysetup/modest-easysetup-wizard.c:
3798 (create_page_custom_outgoing), (create_page_complete_custom):
3799 * src/maemo/modest-account-settings-dialog.c:
3800 (create_page_user_details), (create_page_outgoing):
3801 * src/maemo/modest-account-view-window.c: (button_box_new):
3802 Use changed logical IDs as per the most recent UI spec:
3803 mcen_bd_emailsetup_edit -> mcen_bd_edit
3804 mcen_bd_emailsetup_delete -> mcen_bd_delete
3805 mcen_bd_emailsetup_close -> mcen_bd_close
3807 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3811 * src/dbus_api/Makefile.am:
3812 * src/dbus_api/modest-dbus-callbacks.c:
3813 * src/dbus_api/modest-dbus-callbacks.h:
3814 * src/maemo/modest-platform.c: (modest_platform_init):
3815 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3817 * tests/Makefile.am:
3818 * tests/dbus_api/Makefile.am:
3819 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3821 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3823 * src/maemo/modest-account-settings-dialog.c:
3824 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3825 Removed unnecessary includes.
3827 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3829 * src/maemo/easysetup/modest-easysetup-wizard.c:
3830 * src/maemo/modest-account-settings-dialog.c:
3831 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3832 * src/widgets/Makefile.am:
3833 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3834 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3835 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3836 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3837 * src/widgets/modest-secureauth-combo-box.c:
3838 * src/widgets/modest-secureauth-combo-box.h:
3839 * src/widgets/modest-serversecurity-combo-box.c:
3840 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3841 made the GObject names more consistent with the rest of the Modest code.
3843 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3845 * src/maemo/easysetup/Makefile.am:
3846 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3847 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3848 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3849 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3850 * src/maemo/easysetup/modest-easysetup-wizard.c:
3851 * src/maemo/easysetup/modest-validating-entry.c:
3852 * src/maemo/easysetup/modest-validating-entry.h:
3853 * src/maemo/modest-account-settings-dialog.c:
3854 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3855 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3856 widgets/ because they are used outside of easysetup too. After checking in,
3857 svn will allow me to rename them too.
3859 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3861 * src/gnome/modest-msg-edit-window.c:
3862 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3863 linker error, to fix the build on the GNOME platform.
3864 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3865 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3866 ifdefed out to avoid a warning.
3868 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3870 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3871 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3872 some alternative for GTK+ 2.6.
3874 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3876 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3878 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3879 specified for EmailAccountsDialog in UI spec.
3881 * src/maemo/easysetup/modest-easysetup-wizard.c:
3882 * src/maemo/easysetup/modest-easysetup-wizard.h:
3883 * src/maemo/modest-account-settings-dialog.c:
3884 * src/maemo/modest-account-settings-dialog.h:
3885 Reuse a member window widget for the connection-specific SMTP server accounts,
3886 so we can tell it to create/save the accounts only if we actually save changes.
3888 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3889 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3890 (modest_connection_specific_smtp_edit_window_get_settings):
3891 Return a struct instance for temporarily remembering the entered data.
3893 * src/maemo/modest-connection-specific-smtp-window.h:
3894 * src/maemo/modest-connection-specific-smtp-window.c:
3895 (modest_connection_specific_smtp_window_finalize),
3896 (modest_connection_specific_smtp_window_fill_with_connections),
3898 (modest_connection_specific_smtp_window_save_server_accounts),
3899 (update_model_server_names): Do not actually save data until asked,
3900 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3902 (on_selection_changed),
3903 (modest_connection_specific_smtp_window_init): Disable the edit
3904 button when nothing is selected.
3906 * src/modest-account-mgr-helpers.c:
3907 * src/modest-account-mgr-helpers.h:
3908 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3911 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3913 * src/modest-account-mgr-helpers.h:
3914 * src/modest-account-mgr-helpers.c:
3915 (modest_account_mgr_get_unused_account_name),
3916 (modest_account_mgr_get_unused_account_display_name): Added these
3917 utility functions, to avoid code duplication.
3919 * src/maemo/easysetup/modest-easysetup-wizard.c:
3920 (create_page_account_details), (create_account):
3921 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3922 (on_combo_security_changed),
3923 (modest_connection_specific_smtp_edit_window_init),
3924 (modest_connection_specific_smtp_edit_window_save_settings):
3925 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3926 * src/maemo/modest-connection-specific-smtp-window.c:
3927 (modest_connection_specific_smtp_window_finalize),
3928 (modest_connection_specific_smtp_window_fill_with_connections),
3929 (on_button_edit), (modest_connection_specific_smtp_window_init):
3930 * src/maemo/modest-connection-specific-smtp-window.h:
3931 Implementing saving of connection-specific server accounts.
3933 But I need to refactor this so we can save the data for each
3934 possible connection-specific account and only actually create the server accounts
3935 when the easysetup finished, or the OK button is pressed on the account settings
3938 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3940 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3941 (on_combo_security_changed):
3942 (modest_connection_specific_smtp_edit_window_init):
3943 Auto-fill the port number as in the account settings.
3945 (modest_connection_specific_smtp_edit_window_set_connection):
3946 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3947 * src/maemo/modest-connection-specific-smtp-window.c:
3948 (fill_with_connections), (on_button_edit),
3949 (modest_connection_specific_smtp_window_init):
3950 Turn the edit window into a dialog to simplify the code, and
3951 set a WM hint as in a GtkDialog, because only a popup can be on top of
3952 another window in Maemo, and popups usually have no WM decoration.
3954 * src/modest-defs.h:
3955 * src/modest-account-mgr-helpers.c:
3956 (modest_account_mgr_set_connection_specific_smtp),
3957 (modest_account_mgr_remove_connection_specific_smtp),
3958 (modest_account_mgr_get_connection_specific_smtp):
3959 * src/modest-account-mgr-helpers.h: Some functions to write the
3960 connection-specific SMTP server information. Not yet used.
3963 * src/widgets/modest-folder-view.c: (text_cell_data):
3964 Fix a warning about an uninitialized variable.
3965 (on_configuration_key_changed): Put an #ifdef around the use
3966 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3968 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3970 * src/maemo/modest-account-settings-dialog.h:
3971 * src/maemo/modest-account-settings-dialog.c:
3972 Added connect_for_modified() utility function to mark the new modified boolean.
3974 (create_page_account_details), (create_page_user_details),
3975 (create_page_incoming), (create_page_outgoing), (on_response),
3976 (modest_account_settings_dialog_init),
3977 (modest_account_settings_dialog_set_account_name):
3978 Only warn about unsaved changes when there are actually unsaved changes.
3980 * src/modest-account-mgr-helpers.c:
3981 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3982 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3983 to get the data from there in future.
3985 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3987 * src/modest-defs.h:
3989 * src/modest-account-mgr-helpers.h:
3990 * src/modest-account-mgr-helpers.c:
3991 Store the security account setting in a single conf key instead of using
3992 the options list, so that the list is left for just the to-be-removed camel hack,
3993 and because gconf_client_set_list() is failing for some reason.
3995 * src/modest-account-mgr.c:
3996 (modest_account_mgr_add_server_account):
3997 * src/maemo/modest-account-settings-dialog.c:
3998 (modest_account_settings_dialog_set_account_name),
3999 (save_configuration): Use the renamed functions.
4002 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4004 * src/widgets/Makefile.am:
4005 * src/widgets/modest-limit-retrieve-combo-box.c:
4006 * src/widgets/modest-limit-retrieve-combo-box.h:
4007 * src/widgets/modest-retrieve-combo-box.c:
4008 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4009 the account settings dialog.
4011 * src/modest-defs.h:
4012 * src/modest-account-mgr-helpers.h:
4013 * src/modest-account-mgr-helpers.c:
4014 (modest_server_account_get_option_secure_auth),
4015 (modest_server_account_set_option_secure_auth):
4016 * src/modest-account-mgr.c:
4017 (modest_account_mgr_add_server_account):
4018 Use the existing AUTH_MECH conf key for the secure-auth setting,
4019 instead of putting it in the list options, because this was actually used already.
4021 * src/maemo/modest-account-settings-dialog.c:
4022 (create_page_account_details),
4023 (modest_account_settings_dialog_set_account_name),
4024 (save_configuration):
4025 * src/maemo/modest-account-settings-dialog.h:
4026 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4027 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4029 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4031 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4032 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4033 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4035 * src/modest-defs.h:
4036 * src/maemo/modest-account-settings-dialog.c:
4037 (create_page_incoming), (on_combo_outgoing_security_changed),
4038 (on_combo_incoming_security_changed), (create_page_outgoing),
4039 (modest_account_settings_dialog_set_account_name),
4040 (save_configuration): Load/Save the port number, and change it when the
4041 security combo changes, to suitable defaults.
4043 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4045 * src/modest-account-mgr.c:
4046 (modest_account_mgr_add_server_account): Set the security and secure-auth
4047 options, and add a comment saying that the other camel-specific options should be
4050 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4052 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4054 * src/modest-tny-account-store.c: (account_list_free),
4055 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4056 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4059 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4061 * src/modest-protocol-info.c:
4062 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4063 is required by our UI spec. Maybe something in our implementation will use this eventually.
4064 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4065 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4066 instead of the previous 0 placeholder.
4068 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4069 secure-auth settings.
4070 * src/modest-account-mgr-helpers.h:
4071 * src/modest-account-mgr-helpers.c:
4072 (modest_server_account_data_get_option_secure_auth),
4073 (modest_server_account_set_option_secure_auth),
4074 (modest_server_account_data_get_option_security),
4075 (modest_server_account_set_option_security): Added this API for getting and setting the security
4076 and secure-auth settings.
4078 * src/maemo/modest-account-settings-dialog.h:
4079 * src/maemo/modest-account-settings-dialog.c:
4080 (modest_account_settings_dialog_finalize), (check_data),
4081 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4082 about changing titles.
4083 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4084 (save_configuration): Save the security and secure-auth settings.
4086 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4087 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4089 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4091 * src/modest-defs.h:
4092 * src/modest-account-mgr.c:
4093 (modest_account_mgr_add_server_account):
4094 Added and used defines for the options key and value pair strings,
4095 that are used so far, though they do not seem to correspond to anything in our
4096 UI specs or ModestProtocol enum.
4098 * src/modest-account-mgr-helpers.h:
4099 * src/modest-account-mgr-helpers.c:
4100 (compare_option_strings_for_name),
4101 (modest_server_account_data_get_option_value),
4102 (modest_server_account_data_get_option_bool),
4103 (modest_account_mgr_get_server_account_option):
4104 Added helper functions for parsing the options GSList.
4106 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4108 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4109 display name is based on the supplied account name.
4110 * src/modest-account-mgr.c:
4111 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4112 with an inefficient, but good-enough, implementation.
4114 * src/maemo/easysetup/modest-easysetup-wizard.c:
4115 (create_page_account_details), (on_before_next), (create_account):
4116 Check for existing display names rather than (non-user-visible) account names, and just
4117 create and set a unique account name at the end.
4119 * src/maemo/modest-account-settings-dialog.c:
4120 (modest_account_settings_dialog_init),
4121 (modest_account_settings_dialog_set_account_name),
4122 (create_page_incoming): Show the display name, instead of the account name.
4123 (on_response): Do some (not all) extra checks, as in the UI spec.
4124 (save_configuration): Save the display name if it was changed.
4126 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4128 * po/en_GB.po: Added needed logical ID and translation.
4129 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4130 (init_view): Made the is-default column clicking work.
4132 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4135 * src/maemo/easysetup/Makefile.am:
4136 * src/maemo/easysetup/modest-easysetup-wizard.c:
4137 (modest_easysetup_wizard_dialog_init):
4138 * src/maemo/easysetup/provider-data-test.keyfile:
4139 * src/maemo/easysetup/provider-data.keyfile:
4140 Moved the provider data file to the new modest-providers-data package and used it from there.
4142 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4144 * src/modest-local-folder-info.c:
4145 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4146 N_() was already used on the static strings, but this just marks it for translation without
4147 using the translation.
4149 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4151 * src/maemo/modest-account-settings-dialog.c:
4152 (create_page_incoming),
4153 (modest_account_settings_dialog_set_account_name):
4154 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4155 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4156 I will do this if nobody else gets there first.
4158 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4160 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4161 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4162 save the security stuff.
4164 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4166 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4167 Set the email address and user fullname, which I now see must be
4170 * src/maemo/modest-account-settings-dialog.h:
4171 * src/maemo/modest-account-settings-dialog.c:
4173 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4174 leave-on-server and authentication.
4175 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4178 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4181 * src/maemo/modest-account-settings-dialog.c:
4182 * src/maemo/modest-account-settings-dialog.h:
4183 Most (but not all) of the widgets are now present as specified by the UI spec.
4184 No changes are yet saved, and some details are not properly shown yet.
4186 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4188 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4190 * src/maemo/Makefile.am:
4191 * src/maemo/modest-account-settings-dialog.c:
4192 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4193 an existing account. Doesn't do much yet.
4195 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4196 Open the accounts settings dialog when Edit is clicked.
4198 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4200 * src/maemo/easysetup/Makefile.am:
4201 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4203 * src/maemo/easysetup/modest-easysetup-wizard.c:
4204 (modest_easysetup_wizard_dialog_init):
4205 Try to get the source directory from the build system,
4206 instead of hard-coding "./" into the source code, when opening our local
4207 copies of the configuration files.
4208 But this still fails when opening the wizard from the Accounts window,
4209 maybe because the working directory seems to change at runtime.
4210 So the wizard will fail the second time unless you copy the files into their
4211 proper locations - see the stdout warnings for the paths.
4213 (create_page_account_details),(on_before_next):
4214 Check for existing non-server accounts instead of server accounts,
4215 so the default account name is useful again, and to prevent trying to
4218 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4219 Show the wizard when New is clicked.
4221 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4222 (init_view): Show the column headers, and show the columns that are
4223 specified in the UI specs. However, something in Maemo's GTK+ prevents
4224 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4225 change the default account. This is despite unsetting the special properties.
4227 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4229 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4230 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4231 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4232 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4233 to make that clearer.
4234 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4236 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4238 * src/maemo/modest-account-view-window.c:
4239 (modest_account_view_window_init),
4240 (modest_account_view_window_new):
4241 Use the same buttons as specified in the
4242 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4243 the existing widgets, which never had a chance of working.
4244 Put the ModestAccountView treeview in a scrolled window.
4245 Do not repeat the initialization in both _init() and _new().
4247 * src/widgets/modest-account-view.c: (update_account_view):
4248 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4249 this widget and window shows no accounts.
4251 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4253 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4255 * src/maemo/easysetup/modest-easysetup-wizard.c:
4256 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4257 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4258 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4261 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4262 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4263 accounts exist yet, as in the UI spec.
4265 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4267 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4269 * src/maemo/Makefile.am:
4270 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4271 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4272 New window for editing connection-specific smtp details.
4273 Not fully implemented.
4275 * src/maemo/modest-connection-specific-smtp-window.c:
4276 (modest_connection_specific_smtp_window_finalize) :
4277 unref the tree model.
4278 (on_button_edit): Show the edit window.
4280 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4282 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4285 * src/maemo/Makefile.am:
4286 * src/maemo/modest-connection-specific-smtp-window.c:
4287 * src/maemo/modest-connection-specific-smtp-window.h:
4288 New window for showing the list of connections, for connection-specific
4289 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4290 * src/maemo/easysetup/modest-easysetup-wizard.c:
4291 (create_page_custom_outgoing): Show the new window when the button is clicked.
4293 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4295 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4296 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4297 * src/maemo/modest-msg-edit-window.c:
4298 (modest_msg_edit_window_insert_image):
4299 * src/modest-conf.c: (modest_conf_key_escape):
4300 * src/modest-mail-operation.c:
4301 (modest_mail_operation_send_new_mail):
4302 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4303 (modest_ui_actions_on_new_account):
4304 * src/widgets/modest-attachment-view.c: (update_filename_request):
4305 * src/widgets/modest-mail-header-view.c:
4306 Corrected warnings that were breaking the build, by commenting out unused variables,
4307 and a function, and by including a header.
4309 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4311 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4312 so we can #ifdef around platform-specific code when necessary.
4313 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4314 to allow this to build for the GNOME platform too.
4316 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4318 * src/maemo/easysetup/modest-easysetup-wizard.c:
4319 Added util_increment_name() and used it in create_page_account_details()
4320 to make sure that the default account name is always a new name.
4322 (modest_easysetup_wizard_dialog_init),
4323 (set_default_custom_servernames): Some minor memory management fixes.
4325 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4329 * src/modest-runtime.c: (init_i18n): Restored the translation
4330 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4331 are defined in config.h, and the translations are installed.
4333 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4334 is defined for translation.
4336 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4338 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4340 * src/maemo/easysetup/modest-easysetup-wizard.c:
4341 (modest_easysetup_wizard_dialog_init):
4342 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4343 Use realistic paths (though they should use $prefix generically) to the
4344 mcc_mapping and provider-data.keyfile files which might work when they
4345 are installed by the future version of the operator-wizard package,
4346 and then fallback to paths in our source code, with an explanatory
4349 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4353 * src/maemo/Makefile.am:
4354 * src/maemo/easysetup/: Added files from the previously-exernal
4355 osso-modest-easysetup.
4356 * src/maemo/modest-main-window-ui.h:
4357 * src/modest-ui-actions.c:
4358 * src/modest-ui-actions.h:
4359 Added modest_ui_actions_on_new_account() as a signal handler for the
4360 New Account menu item. It shows the easysetup wizard.
4361 * po/en_GB.po: Added additional needed logical IDs and translations.