1 2007-07-27 Murray Cumming <murrayc@murrayc.com>
3 * src/widgets/modest-header-view-render.c:
4 (_modest_header_view_compact_header_cell_data):
5 Some checks and initialization to try to deal with a crash,
8 2007-07-27 Murray Cumming <murrayc@murrayc.com>
10 * src/maemo/modest-maemo-utils.c:
11 (modest_maemo_utils_get_supported_secure_authentication_methods):
12 Make sure that we have a connection, asking the user for one
14 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
15 Check for a connection before showing the wizard, because
16 the wizard needs a connection to check for server capabilities.
18 2007-07-27 Murray Cumming <murrayc@murrayc.com>
20 * src/maemo/modest-account-view-window.c:
21 (on_new_button_clicked): Remember the wizard dialog instance,
22 so we can just present it again if necessary. This prevents
23 multiple windows from appearing if you click again quickly on the
24 New button before the dialog appears, fixing projects.maemo.org
27 2007-07-27 Murray Cumming <murrayc@murrayc.com>
29 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
30 Offer a connection dialog if there is no connection when
31 starting modest. This should fix projects.maemo.org bug NB#61134.
33 2007-07-27 Murray Cumming <murrayc@murrayc.com>
35 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
36 Reverted my last commit. I was able to fix the build by doing
37 apt-get install wpeditor0 (replacing other wpeditor packages) and
38 an explicit apt-get install wpeditor-dev to upgrade the -dev
41 2007-07-27 Murray Cumming <murrayc@murrayc.com>
43 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
44 Commented out the use of wp_text_buffer_replace_image()
45 because it does not exist, to break the build. Added a TODO for it.
47 2007-07-26 Murray Cumming <murrayc@murrayc.com>
49 * src/modest-tny-account-store.c: (recreate_all_accounts):
50 Recreate them even if they were NULL before. I guess something
51 else was already creating them before, or this would never
53 (modest_tny_account_store_get_server_account): Make sure that
54 the tny accounts have been created before trying to find one.
55 This allows libmodest_dbus_client_compose_mail() to work
56 when the UI is not yet visible.
57 This is probably useful in other cases too.
59 (get_password): When the password is wrong after it is entered
60 in the protected password dialog, show an info banner (in an
61 idle handler) before showing the protected password dialog
64 2007-07-26 Murray Cumming <murrayc@murrayc.com>
66 * src/modest-ui-actions.h:
67 * src/modest-ui-actions.c: Added
68 modest_do_refresh_current_folder() containing some code from
69 modest_ui_actions_on_send_receive().
70 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
71 Call modest_do_refresh_current_folder() before refreshing the
72 requested account, as in modest_ui_actions_on_send_receive().
73 This is strange, but seems to be necessary to show new mails.
74 Now new emails are finally visible in the UI when downloaded
75 via the automatic update interval, fixing bug NB#57458.
76 This also works because bug NB#57458 has been fixed somehow.
78 2007-07-26 Murray Cumming <murrayc@murrayc.com>
80 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
81 printf more details when we get unhandled D-Bus methods, because
84 * src/modest-mail-operation.c: (update_account_thread):
85 Comment out the tny_camel_pop_store_account_reconnect(), because this
86 is apparently no longer needed, and it did not work before anyway.
87 See the comment in the code.
89 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
90 by checking the header flags. This fixes projects.maemo.org bug
93 2007-07-25 Murray Cumming <murrayc@murrayc.com>
95 * src/maemo/modest-maemo-utils.h:
96 * src/maemo/modest-maemo-utils.c: Added
97 modest_maemo_show_information_note_in_main_context_and_forget().
98 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
99 Use the new function to show simple error dialogs in the main
100 context, though question dialogs are still in the current context,
101 which is unfortunately usually not the main context. This should
104 2007-07-25 Murray Cumming <murrayc@murrayc.com>
106 * src/modest-tny-account-store.c: (get_password):
107 Never save the entered username and password in gconf,
108 because the UI spec says we should not. This helps
109 slightly with projects.maemo.org bug NB#63671.
111 2007-07-25 Murray Cumming <murrayc@murrayc.com>
113 * src/widgets/modest-msg-edit-window.h:
114 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
115 Moved some code here to make it simpler.
116 (modest_msg_edit_window_attach_file_one): Renamed from
117 modest_msg_edit_window_attach_file_interactive().
118 (modest_msg_edit_window_offer_attach_file): Renamed from
119 modest_msg_edit_window_attach_file() and used
120 modest_msg_edit_window_attach_file_one() instead of
121 copy/pasting the code. The old code for one was not using
122 GnomeVFS. This allows use of smb:// URLs when using send-as
123 from external applications, fixing bug NB#63741.
125 (modest_msg_edit_window_insert_image),
126 (modest_msg_edit_window_add_attachment_clicked):
127 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
128 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
129 Adapted to the new function names.
131 2007-07-25 Murray Cumming <murrayc@murrayc.com>
133 (modest_platform_set_update_interval): Set the alarm recurrence
134 fields so that auto-update does not just happen the first time.
135 This should have fixed projects.maemo.org bug NB#63938.
137 When this happens you can see a printf when the D-Bus method is
139 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
141 However, I do not actually seem to get new POP messages even when
142 clicking the refresh button manually. A restart gets them.
143 This might be a problem in today's tinymail only.
145 2007-07-24 Murray Cumming <murrayc@murrayc.com>
147 * src/maemo/modest-maemo-global-settings-dialog.c:
148 (current_connection):
149 Avoid a crash (probably only in scratchbox) when strcmp()ing a
150 NULL when closing the dialog.
152 2007-07-24 Murray Cumming <murrayc@murrayc.com>
154 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
155 Remove the hacky send/receive that didn't work, and instead
156 refilter the treemodel to make the deleted email really vanish from
157 the UI (though the delete-from-menu code does has commented out
158 the code that does that). This fixes projects.maemo.org bug
161 2007-07-24 Murray Cumming <murrayc@murrayc.com>
163 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
164 Try a couple of tricks to force the treeview to update (
165 poke the folder, and do a send/receive refresh), but the deleted
166 email still appears with a strike-through instead of really being
169 2007-07-23 Murray Cumming <murrayc@murrayc.com>
171 * src/dbus_api/modest-dbus-callbacks.c:
172 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
173 because their ID is not human-readable (see the comment about
174 improvements needed to the osso-email-interface API) and
175 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
177 2007-07-23 Murray Cumming <murrayc@murrayc.com>
179 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
180 (add_folders_to_list), (on_dbus_method_get_folders),
181 (modest_dbus_req_filter):
182 * src/maemo/modest-maemo-utils.c:
183 (on_camel_account_get_supported_secure_authentication):
184 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
185 (on_header_view_focus_in):
186 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
187 * src/modest-formatter.c: (modest_formatter_create_body_part):
188 * src/modest-mail-operation.c: (recurse_folders),
189 (update_account_thread), (get_msgs_full_thread),
190 (modest_mail_operation_get_msgs_full),
191 (modest_mail_operation_xfer_msgs):
192 * src/modest-search.c: (search_mime_part_and_child_parts),
193 (modest_search_account), (modest_search_all_accounts):
194 * src/modest-tny-account.c:
195 (modest_tny_account_get_special_folder), (recurse_folders):
196 * src/modest-tny-local-folders-account.c:
197 (modest_tny_local_folders_account_query_passes):
198 * src/modest-tny-msg.c: (copy_mime_part),
199 (modest_tny_msg_find_body_part_from_mime_part):
200 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
201 (modest_tny_send_queue_try_to_send):
202 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
203 (_modest_ui_actions_open), (download_uncached_messages),
204 (reply_forward), (modest_ui_actions_on_copy),
205 (modest_ui_actions_on_details), (has_retrieved_msgs),
206 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
208 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
209 (_selected_msg_marked_as), (_msg_download_completed),
210 (_selected_msg_sent_in_progress):
211 * src/widgets/modest-attachments-view.c:
212 (modest_attachments_view_set_message):
213 * src/widgets/modest-msg-view.c: (find_cid_image):
214 * tests/check_folder-transfer.c: (find_folders):
215 * tests/check_update-account.c: (func):
216 * tests/dbus_api/test_get_folders.c: (main):
217 Checked all uses of tny_iterator_get_current(), making sure
218 that the object is unreferenced (3 or 4 places did not),
219 and adding checks for NULL.
221 2007-07-23 Murray Cumming <murrayc@murrayc.com>
223 * src/dbus_api/modest-dbus-callbacks.c:
224 (on_idle_open_default_inbox): Make sure that the application UI is
226 * src/maemo/easysetup/modest-easysetup-wizard.c:
227 (on_entry_invalid_character): Show the word whitespace instead
228 of (null) in the banner when whitespace was entered.
229 (show_error): Add a comment that this does not work in
230 Maemo Bora, though we do not know why.
232 2007-07-23 Murray Cumming <murrayc@murrayc.com>
234 * src/modest-tny-account.c:
235 (modest_tny_account_get_special_folder): Use an if instead of
236 an assert for when the parent account name is NULL, because this
237 might be causing a crash in projects.maemo.org bug 63192.
238 * src/modest-mail-operation.c:
239 (modest_mail_operation_send_new_mail_cb),
240 (modest_mail_operation_remove_folder): unref the folder that is
241 returned from modest_tny_account_get_special_folder().
243 2007-07-23 Murray Cumming <murrayc@murrayc.com>
245 * src/modest-ui-actions.c:
246 (modest_ui_actions_on_password_requested):
247 Show mail_ib_login_cancelled info banner when the user cancels
248 the protected password dialog, to fix projects.maemo.org
251 2007-07-23 Murray Cumming <murrayc@murrayc.com>
253 * src/maemo/modest-account-settings-dialog.c:
254 (create_page_outgoing): Put this page in a GtkScrolledWindow,
255 matching the UI mock-up in the UI spec, and allowing access
256 to all widgets even when the on-screen keyboard is active.
258 2007-07-23 Murray Cumming <murrayc@murrayc.com>
260 Reverted this previous commit from Johannes,
261 because the scrollbars are always visible and because
262 I think we only need it on onepage of the account
263 settings, not the account wizard.
264 (I wrote the wrong instructions in the bug.)
266 * src/maemo/easysetup/modest-easysetup-wizard.c:
267 Added scrollbars to account wizard dialog.
268 Fixed projects.maemo.org NB #62744
270 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
272 * src/maemo/easysetup/modest-easysetup-wizard.c:
273 (create_page_user_details):
274 Use auto-cap for name (projects.maemo.org NB#63716)
275 * src/widgets/modest-account-view.c: (on_account_busy_changed):
277 2007-07-22 Armin Burgmeier <armin@openismus.com>
279 * src/maemo/modest-ui-actions.c: Use current account instead of
280 default account for creating viewer windows, so that the viewer
281 window knows to which account the viewed message belongs.
283 * src/maemo/modest-msg-view-window.c: Destroy the window when the
284 corresponding account is deleted. This fixes projects.maemo.org bug
287 2007-07-18 Armin Burgmeier <armin@openismus.com>
289 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
290 the dialog close after entering an invalid port number and clicking
291 OK. This fixes projects.maemo.org bug NB#63602.
293 2007-07-18 Armin Burgmeier <armin@openismus.com>
295 * src/modest-tny-account-store.c:
296 (get_server_accounts): Set parent modest account name for each
297 connection-specific transport account so that special folders of such
298 an account can be looked up. This fixes a crash when changing account
299 settings. This might also be related to projects.maemo.org bug
302 2007-07-16 Armin Burgmeier <armin@openismus.com>
304 * src/modest-ui-actions.c: Added a button to create a folder to the
305 move-to dialog. This fixes projects.maemo.org bug NB#.
307 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
309 * src/maemo/easysetup/modest-easysetup-wizard.c:
310 Added scrollbars to account wizard dialog.
311 Fixed projects.maemo.org NB #62744
313 2007-07-16 Murray Cumming <murrayc@murrayc.com>
315 * src/widgets/modest-msg-view.h:
316 * src/widgets/modest-msg-view.c:
317 Added modest_msg_view_get_message_is_empty() but this needs
319 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
320 Check if there is any text in the message yet.
321 But this needs to be implemented properly.
322 (modest_msg_edit_window_toggle_find_toolbar):
323 * src/maemo/modest-msg-view-window.c:
324 (modest_msg_view_window_toggle_find_toolbar):
325 Show a banner warning if there is no text to search, when
326 trying to start a search. This partially fixes
327 projects.maemo.org bug NB#62350.
329 2007-07-13 Murray Cumming <murrayc@murrayc.com>
331 * src/modest-mail-operation.c: (update_account_thread):
332 Initialized num_new_headers to fix the build.
334 2007-07-13 Murray Cumming <murrayc@murrayc.com>
336 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
337 Ignore modest accounts whose server accounts don't exist in gconf.
338 This prevents us trying to create TnyAccount instances for those
339 server accounts when the server account has been removed from gconf,
340 but the parent modest account has not yet been removed from modest.
341 I don't know why this is only noticeable now. It was probably just
342 a harmeless g_warning() anyway.
344 2007-07-13 Murray Cumming <murrayc@murrayc.com>
346 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
347 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
349 2007-07-12 Armin Burgmeier <armin@openismus.com>
351 * src/maemo/modest-main-window.c: Make default account appear bold
352 in view, tools/send & receive and toolbar/send & receive SCM menus.
353 This fixes projects.maemo.org bug NB#59010.
355 2007-07-12 Murray Cumming <murrayc@murrayc.com>
357 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
358 Add a short-cut, by checking if the folder store is an account.
359 This ensures that the Sort menu item and toolbar is dimmed for
360 the local-folders account root item, fixing
361 projects.maemo.org bug NB#62545.
363 2007-07-12 Murray Cumming <murrayc@murrayc.com>
365 * src/modest-tny-account-store.c: (get_password):
366 Show the password dialog (via the signal) only in the mainloop, via
367 an idle handler that we wait for. This could theoretically prevent
368 hangs, though I worry that it could introduce some too.
370 2007-07-12 Murray Cumming <murrayc@murrayc.com>
372 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
373 * src/maemo/modest-platform.c:
374 (modest_platform_connect_and_wait):
375 Take a TnyAccount* parameter and try to set it to online
376 (a TnyCamel-only API), because tinymail sets accounts to offline
377 when the user cancels a password dialog, and doesn't ask again until
378 it has been set to online.
379 However, this is commented out because it causes a hang now.
381 (modest_platform_connect_and_wait_if_network_account):
382 * src/modest-mail-operation.c:
383 (modest_mail_operation_update_account):
384 * src/modest-platform.h:
385 * src/modest-ui-actions.c: (_modest_ui_actions_open),
386 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
388 2007-07-12 Armin Burgmeier <armin@openismus.com>
390 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
392 * src/modest-mail-operation.c:
393 * src/modest-ui-actions.c: Check for already existing folder before
394 querying the server, show error message from camel if the request
395 still fails. This fixes projects.maemo.org bug NB#58701.
397 2007-07-12 Murray Cumming <murrayc@murrayc.com>
399 * src/modest-tny-account-store.h:
400 * src/modest-tny-account-store.c:
401 Added modest_tny_account_store_forget_password_in_memory(),
402 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
403 when creating a new account, so that new passwords will be used, instead of
404 us thinking that it's a second request as a result of a failed password again.
406 2007-07-12 Murray Cumming <murrayc@murrayc.com>
408 * src/dbus_api/modest-dbus-callbacks.c:
409 (on_idle_open_message): If the message is in drafts then open it
410 in an edit window instead of a view window. This fixes
411 projects.maemo.org bug NB#63005.
413 2007-07-12 Murray Cumming <murrayc@murrayc.com>
415 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
416 Avoided a harmless g_warning().
418 2007-07-12 Murray Cumming <murrayc@murrayc.com>
420 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
421 Pass the modest account name, not the TnyAccount display name to
422 modest_msg_view_window_new() so that the reply feature works,
423 fixing projects.maemo.org bug NB#62892.
425 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
426 (modest_msg_view_window_new_with_header_model):
427 * src/maemo/modest-msg-view-window.c:
428 (modest_msg_view_window_new_with_header_model),
429 (modest_msg_view_window_new):
430 * src/modest-ui-actions.c: (reply_forward):
431 * src/widgets/modest-msg-view-window.h:
432 * src/widgets/modest-window.c: (modest_window_set_active_account):
433 Rename an account parameter to modest_account_name to make this clearer.
435 2007-07-11 Murray Cumming <murrayc@murrayc.com>
437 * src/modest-ui-actions.h:
438 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
439 modest_do_message_delete().
440 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
441 Call modest_do_message_delete(), hoping that this would cause messages
442 to be really deleted from search instead of just marked with strike through.
443 Does not seem to help.
445 2007-07-11 Armin Burgmeier <armin@openismus.com>
447 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
448 priv->reselect to FALSE prior to calling
449 modest_folder_view_select_first_inbox_or_local() to prevent endless
450 recursion and thus a crash on startup.
452 2007-07-11 Armin Burgmeier <armin@openismus.com>
454 * src/maemo/modest-account-settings-dialog.h: Include
455 <gtk/gtknotebook.h> to fix the build (at least for me).
457 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
458 Use "New FolderN" as default suggested name if "New folder" already
459 exists, with N being the first free number, though never exceed "New
460 folder99" in which case we just fall back to "New Folder" even though
461 it already exists. This fixes projects.maemo.org bug NB#58663.
463 2007-07-11 Murray Cumming <murrayc@murrayc.com>
465 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
466 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
467 projects.maemo.org bug NB#62778.
469 2007-07-11 Murray Cumming <murrayc@murrayc.com>
471 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
472 Ignore the wrong (for now) secure-smtp setting in the presets -
473 just default to requiring secure authentication for SMTP, because
476 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
478 * src/widgets/modest-folder-view.c: (filter_row)
479 Do not show drafts folder (see UI specs)
481 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
483 * src/modest-ui-actions.c:
484 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
485 place and also not necessary.
487 * src/widgets/modest-folder-view.c: (filter_row)
488 Guess folder type and hide Sent & Outbox if necessary.
489 Fixed project.maemo.org NB#57328
491 2007-07-11 Murray Cumming <murrayc@murrayc.com>
493 * src/modest-ui-actions.h:
494 * src/modest-ui-actions.c:
495 (modest_ui_actions_on_delete_message):
496 Move some code into a new
497 modest_ui_actions_refresh_message_window_after_delete()
498 function so we can use it from elsewhere.
500 * src/dbus_api/modest-dbus-callbacks.c:
501 (on_idle_delete_message), (on_delete_message): Used an idle
502 handler, as we do for the other D-Bus method handlers.
503 Call modest_ui_actions_refresh_message_window_after_delete()
504 if the deleted message was open in a window. This fixed
505 projects.maemo.org bug NB#62862.
507 2007-07-11 Murray Cumming <murrayc@murrayc.com>
509 * src/modest-main.c: (main): Only show the UI at the start if
510 the showui command line option was given. For instance,
511 run-standalone src/modest showui
512 Otherwise, we wait for the top_application D-Bus method to
513 be sent by hildon-desktop when the application is selected
515 This allows us to run without a UI when osso-global-search
516 uses our D-Bus methods.
518 2007-07-11 Murray Cumming <murrayc@murrayc.com>
520 * src/dbus_api/modest-dbus-api.h: Added a define for a
521 top-application D-Bus method.
522 * src/dbus_api/modest-dbus-callbacks.c:
523 (on_top_application),
524 (modest_dbus_req_handler): Handle the top-application D-Bus
525 method, which might be an undocumented D-Bus signal sent by
526 hildon-desktop when it starts the application from the menu.
527 But I am not sure and I need to test it on the device, because
528 my scratchbox does not have the application in the menu now.
529 This method shows the main window, so that it can be invisible
530 when started, for instance, just for email searching from
533 * src/maemo/modest-main-window.c: (restore_settings),
534 (modest_main_window_new): Do not show the window immediately
535 upon creation. We show it later.
536 * src/modest-widget-memory.c: (save_settings_paned):
537 Try (unsuccessfully) to avoid saving the paned position when
538 it is not even visible.
539 (restore_settings_paned): Do not allow a silly paned position.
540 This seems necessary when not showing the window at first.
542 * tests/dbus_api/Makefile.am:
543 * tests/dbus_api/test_top_application.c: (main): Test for the
546 2007-07-10 Murray Cumming <murrayc@murrayc.com>
548 * src/modest-ui-dimming-rules.c:
549 (modest_ui_dimming_rules_on_new_msg),
550 (modest_ui_dimming_rules_on_reply_msg),
551 (modest_ui_dimming_rules_on_delete_msg),
552 (modest_ui_dimming_rules_on_details),
553 (modest_ui_dimming_rules_on_view_window_move_to),
554 (modest_ui_dimming_rules_on_view_previous),
555 (modest_ui_dimming_rules_on_view_next),
556 (_invalid_folder_for_purge): Added checks before
557 casting the window. This looks like an actual
558 logic error in _invalid_folder_for_purge(), because it
559 tries to use a ModestMainWindow as a message window.
561 2007-07-10 Murray Cumming <murrayc@murrayc.com>
563 * src/maemo/modest-account-settings-dialog.c:
564 (show_error): Use the same implementation as in
565 modest-easysetup-wizard.c:
566 (on_entry_invalid_character): The logical ID contains a %s.
567 Guessed what it should be.
568 (on_entry_max), (check_data), (on_response): Adapt to
569 changed show_error().
570 (create_page_account_details): Really call
571 modest_validating_entry_set_func() on the correct widgets.
572 * src/maemo/easysetup/modest-easysetup-wizard.c:
573 (on_entry_invalid_character): Fix the logical ID here too.
574 (create_page_account_details),
575 (create_page_user_details):
577 modest_validating_entry_set_func() on the correct widgets.
579 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
580 Do not try to use the account if it is NULL.
582 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
584 * src/modest-ui-actions.c: (create_move_to_dialog),
585 (modest_ui_actions_on_main_window_move_to),
586 (modest_ui_actions_on_msg_view_window_move_to):
587 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
588 (filter_row), (modest_folder_view_show_non_move_folders):
589 * src/widgets/modest-folder-view.h:
591 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
592 the Sent folder yet as it does not report the correct folder type.
594 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
596 * src/maemo/modest-msg-edit-window.c: (init_window):
599 2007-07-10 Murray Cumming <murrayc@murrayc.com>
601 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
602 Take a parent widget instead of a parent window, and
603 implement this with hildon_banner_show_information() instead.
604 Non-Maemo builds can just ifdef that there.
605 This fixed projects.maemo.org bug NB#62766.
607 (on_entry_invalid_character): Use show_error() again instead
608 of using hildon directly, and use the _CS() macro to use the correct
610 (create_account), (check_for_supported_auth_methods), (on_entry_max):
611 Pass a widget instead od a window to show_error().
613 2007-07-10 Murray Cumming <murrayc@murrayc.com>
615 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
616 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
617 This allows us to show the server name in the error message, fixing
618 projects.maemo.org bug NB#62904.
619 Also, use the appropriate logical ID message for the account protocol.
621 2007-07-10 Murray Cumming <murrayc@murrayc.com>
623 * src/modest-tny-account-store.c: (on_idle_wrong_password):
624 A compilation fix, though the build wasn't broken for me.
626 2007-07-09 Murray Cumming <murrayc@murrayc.com>
628 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
629 Do not try to unref a NULL folder store, to avoid a runtime warning.
630 This seems to happen sometimes when changing accounts settings.
632 2007-07-09 Murray Cumming <murrayc@murrayc.com>
634 * src/modest-tny-account-store.c:
635 (modest_tny_account_store_instance_init),
636 (modest_tny_account_store_finalize),
637 (on_account_settings_hide), (on_idle_wrong_password):
638 Use a GHashTable to ensure that we only show one account settings
639 dialog per modest account. This avoids us having a dialog open for
640 both the store and transport accounts, or due to repeated get_password()
641 calls that shouldn't happen anyway.
643 2007-07-09 Murray Cumming <murrayc@murrayc.com>
645 * src/maemo/modest-maemo-utils.c: (on_hide),
646 (modest_maemo_show_dialog_and_forget): Handle the response, because
647 the window is not even hidden by default.
649 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
650 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
651 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
652 which seems to prevent some modality problems.
654 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
655 Ignore user cancellation errors.
657 * src/modest-account-mgr-helpers.h:
658 * src/modest-account-mgr-helpers.c:
659 Added modest_server_account_get_password() and
660 modest_server_account_get_has_password() to avoid direct use of
663 * src/maemo/modest-account-settings-dialog.h:
664 * src/maemo/modest-account-settings-dialog.c:
665 (modest_account_settings_dialog_init): Store the notebook so we can
667 Added modest_account_settings_dialog_switch_to_user_info().
669 * src/modest-tny-account-store.c:
670 (get_password): When the password in the account settings is wrong (we think),
671 show the relevant page of the account settings dialog, in the mainloop.
672 However, we currently get many of these at once because cancel does not
674 (forget_password): Do not forget the password
675 from the account settings, because this causes side-effects when
676 tinymail seems to call it at strange time, maybe because of how we
677 are cancelling get_password().
678 (modest_tny_account_store_alert): Ignore user cancellations.
680 2007-07-09 Murray Cumming <murrayc@murrayc.com>
682 * src/maemo/modest-maemo-utils.h:
683 * src/maemo/modest-maemo-utils.c:
684 Added modest_maemo_show_information_note_and_forget() for use instead of
685 gtk_dialog_run() when the response is not needed, to avoid an extra
686 mainloop which could cause a hang.
688 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
689 Use the logical IDs for the error message, though they are not
690 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
691 because gtk_dialog_run() caused a hang here (the window did not close).
692 This fixes projects.maemo.org bug NB#62646.
694 2007-07-09 Murray Cumming <murrayc@murrayc.com>
696 * src/modest-account-mgr-helpers.h:
697 * src/modest-account-mgr-helpers.c:
698 Added modest_account_mgr_get_store_protocol().
700 * src/maemo/modest-account-view-window.c:
701 (on_delete_button_clicked): Show different warning text depending on
702 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
703 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
706 2007-07-09 Murray Cumming <murrayc@murrayc.com>
708 * src/maemo/modest-msg-edit-window.c:
709 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
710 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
712 2007-07-07 Armin Burgmeier <armin@openismus.com>
714 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
715 ckdg_ib_maximum_characters_reached from correct package.
717 * src/modest-ui-actions.c: Show an error message when a folder could
718 not be created. Tinymail does not give us specific error codes about
719 what has gone wrong, so we assume that a folder with that name
720 already exists, though there might be other reasons.
722 2007-07-06 Murray Cumming <murrayc@murrayc.com>
724 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
725 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
726 give a more exact error message that can be partly translated.
728 2007-07-05 Murray Cumming <murrayc@murrayc.com>
730 * src/maemo/modest-address-book.c:
731 (select_email_addrs_for_contact): Specify a default window size for the
732 select-email-address dialog, so that it is probably big enough for the
733 title. This should fix projects.maemo.org bug NB#62277.
735 2007-07-05 Murray Cumming <murrayc@murrayc.com>
737 * src/maemo/easysetup/modest-easysetup-wizard.c:
738 (create_page_complete_easysetup): Use
739 gtk_widget_set_size() request to ensure that the text wraps
742 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
744 * src/maemo/easysetup/modest-easysetup-wizard.c:
745 (on_entry_invalid_character), (create_page_account_details),
746 (create_page_user_details):
747 Use new API of ModestValidatingEntry. But for some reason the banner is
748 not shown. I will have to investigate that further.
750 * src/widgets/modest-validating-entry.c: (on_insert_text),
751 (modest_validating_entry_set_func):
752 * src/widgets/modest-validating-entry.h:
753 Added a new callback function to be able to react to prevented
754 characters whitespaces to e.g show a banner.
756 2007-07-05 Armin Burgmeier <armin@openismus.com>
758 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
759 notification of HildonNumberEditor instead of remembering the port
760 number. Thanks to Johannes for pointing this out.
762 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
764 * src/maemo/easysetup/modest-easysetup-wizard.c:
765 Check if there are any user changes before showing a confirmation
766 dialog (projects.maemo.org NB#60946)
768 2007-07-05 Armin Burgmeier <armin@openismus.com>
770 * src/maemo/modest-account-settings-dialog.c: Remember custom port
771 number at the beginning of the dialog and set the modified flag at the
772 end if the port number has changed. This is necessary because
773 HildonNumberEditor does not support notification when the value has
776 2007-07-05 Murray Cumming <murrayc@murrayc.com>
778 * src/modest-ui-actions.c:
779 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
780 a connection before asking anything else. Correct the check for the destination
781 folder so that it succeeds when online.
782 This fixed projects.maemo.org bug NB#61645.
784 2007-07-05 Murray Cumming <murrayc@murrayc.com>
786 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
787 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
788 to fix projects.maemo.org bug NB#62439.
790 2007-07-05 Murray Cumming <murrayc@murrayc.com>
792 * src/modest-tny-account.c: (on_connection_status_changed):
793 Really do not use tny_device_force_offline() here. See the previous comment.
795 2007-07-04 Murray Cumming <murrayc@murrayc.com>
797 * src/modest-tny-account.c: (on_connection_status_changed):
798 Do not use tny_device_force_offline() when tinymail says that something
799 went wrong with the connection. It seems to report this unnecessarily.
801 2007-07-04 Murray Cumming <murrayc@murrayc.com>
803 * src/maemo/modest-connection-specific-smtp-window.c:
804 (modest_connection_specific_smtp_window_init):
805 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
806 does not seem to have any effect in osso 1.1 (though it works in
807 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
809 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
811 * src/maemo/modest-connection-specific-smtp-window.c:
812 Fix UI specification problems with projects.meamo.org NB#60479
814 2007-07-04 Murray Cumming <murrayc@murrayc.com>
816 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
817 clue when this has failed, because the error dialog is not always shown
818 (at least in earlier version).
820 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
821 GError message, because the generic error dialog is not helpful.
823 'This message is not currently available (can't let a new connection go online)'
824 when trying to open an IMAP message.
826 (_modest_ui_actions_open): Offer a connection when some messages would
827 have to be downloaded and we are offline.
829 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
831 * src/widgets/modest-folder-view.c:
832 Don't check for MERGE type anymore as we use the correct type
834 NOTE: For the last two changes you need to update your tinymail copy
835 because of API changes!
837 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
839 * src/modest-tny-local-folders-account.c:
840 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
841 (see projects.maemo.org NB#61580)
843 2007-07-04 Murray Cumming <murrayc@murrayc.com>
845 * src/modest-tny-account.c: (on_connection_status_changed):
846 Commented out the call to modest_platform_connect_and_wait() because this
847 seems to always hang, and I would like to know if this is the only thing
848 that causes a hang when showing the connection dialog.
849 It is not very useful anyway.
851 2007-07-04 Murray Cumming <murrayc@murrayc.com>
853 * src/maemo/modest-msg-view-window.c:
854 (modest_msg_view_window_select_next_message):
856 * src/modest-platform.h:
857 * src/maemo/modest-platform.c:
858 Added modest_platform_connect_and_wait(), which calls
859 tny_maemo_conic_device_connect() always in the main thread, by calling it
860 in an idle handler and waiting for the idle handler to run. It should be
861 in the main thread because it uses GTK+ UI code. It just returns TRUE
862 if the device is already online.
864 There is some nasty code to ensure that subsequent calls to
865 modest_platform_connect_and_wait() just wait for the first one to finish,
866 by checking repeatedly in another idle handler. This is necessary,
867 because other threads (or even the main thread, via another idle handler)
868 can call modest_platform_connect_and_wait() while
869 modest_platform_connect_and_wait() is running.
871 (modest_platform_connect_and_wait_if_network_account),
872 (modest_platform_connect_and_wait_if_network_folderstore):
873 Convenience functions that calls modest_platform_connect_and_wait() if
874 the account or folder might want network access.
876 * src/modest-mail-operation.c:
877 (modest_mail_operation_update_account):
878 * src/modest-ui-actions.c: (download_uncached_messages),
879 (modest_ui_actions_on_rename_folder), (delete_folder),
880 (modest_ui_actions_on_main_window_move_to),
881 (modest_ui_actions_on_msg_view_window_move_to):
882 * src/widgets/modest-folder-view.c:
883 (drag_and_drop_from_folder_view):
884 Offer a connection if we are offline.
886 * src/modest-tny-account.c: (on_connection_status_changed):
887 Document this as only handling errors during network operations in progress,
888 and replace the idle code with a simple call to
889 modest_platform_connect_and_wait(), which does this instead.
891 2007-07-03 Murray Cumming <murrayc@murrayc.com>
893 * src/modest-tny-account.c:
894 (modest_tny_account_get_special_folder): (util_on_idle),
895 Handle the GError so we can see when tny_folder_store_get_folders()
896 fails, as it currently does while something else is connecting.
898 Added util_run_in_main_thread_and_wait()
899 which uses an idlen handler and mainloop to ensure that the function
900 is called in the main thread.
901 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
902 to make sure that we call attempt the connection in the mainloop only,
903 which might solve some hangs.
905 2007-07-03 Murray Cumming <murrayc@murrayc.com>
907 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
908 be found by their display name. This is never useful.
909 * src/modest-tny-account-store.c: (on_account_removed): Find the account
910 by its ID, instead of trying to use its ID as its display name.
912 * src/modest-tny-account-store.h:
913 * src/modest-tny-account.c:
914 (modest_tny_account_get_special_folder): Add a g_warning() when
915 tny_folder_store_get_folders() returns an empty list for the maildir.
917 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
918 Add a g_warning() when this returns NULL, because that it not allowed
921 2007-07-02 Armin Burgmeier <armin@openismus.com>
923 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
924 note when trying to cancel the wizard. This fixes projects.maemo.org
927 2007-07-02 Murray Cumming <murrayc@murrayc.com>
929 * src/modest-tny-account.h:
930 * src/modest-tny-account.c:
931 (modest_tny_account_new_from_server_account),
932 (modest_tny_account_new_from_server_account_name),
933 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
934 because this must now be set before setting the proto. This is usd in
935 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
936 warning in camel_session_get_service() caused by
937 tny_camel_transport_account_prepare().
939 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
942 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
944 * src/maemo/modest-connection-specific-smtp-edit-window.c:
946 (modest_connection_specific_smtp_edit_window_init):
948 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
951 2007-06-29 Murray Cumming <murrayc@murrayc.com>
953 * src/modest-tny-account.c:
954 (modest_tny_account_new_from_server_account):
955 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
956 now uses to request a connection when it needs one, and which it uses
957 to tell us that something is wrong with the connection, so we can force
958 the accounts offline to prevent further problems.
961 * src/modest-init.c: (init_default_settings):
962 * src/modest-mail-operation.c:
963 (modest_mail_operation_update_account):
964 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
965 This should not be necessary anymore. Do not set the conf key that
966 determined this (it was always TRUE and not set anywhere else).
968 * src/modest-ui-actions.h: Remove unused and unimplemented
969 modest_ui_actions_on_online_toggle_toggled().
971 2007-06-29 Murray Cumming <murrayc@murrayc.com
973 * src/maemo/modest-main-window.c: (connect_signals):
974 Don't connect to delete_event twice. Maybe this was harmless.
976 2007-06-29 Murray Cumming <murrayc@murrayc.com
978 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
979 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
980 Debug output to give some more clue when a folder move is not allowed.
982 2007-06-28 Murray Cumming <murrayc@murrayc.com
984 * src/modest-tny-account.c: (on_modest_file_system_info),
985 (modest_tny_account_get_mmc_account_name):
986 Always call the callback, without checking whether the name has changed.
987 * src/widgets/modest-folder-view.c: (strings_are_equal),
988 (on_model_foreach_set_name), (on_get_mmc_account_name),
989 (text_cell_data): Compare the name here, and use the name from
990 the account rather than from the
991 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
992 if the name was changed after the account was added to the model.
993 That's a tinymail bug but not one that I want to fix now.
995 This finally fixes projects.maemo.org bug NB#59301.
997 2007-06-27 Armin Burgmeier <armin@openismus.com>
999 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
1002 2007-06-27 Murray Cumming <murrayc@murrayc.com
1004 * src/modest-tny-account.h:
1005 * src/modest-tny-account.c:
1006 Added modest_tny_account_get_mmc_account_name(), to set the memory
1007 card name asynchronously for the given account and then notify.
1008 (modest_tny_account_new_for_local_folders): Use this new function instead
1009 of using hildon_file_system_info_async_new() directly.
1011 * src/widgets/modest-folder-view.c: (text_cell_data):
1012 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
1013 gtk_tree_model_row_changed() when it is available.
1015 This should fix projects.maemo.org bug NB#59301.
1017 2007-06-27 Murray Cumming <murrayc@murrayc.com
1019 * src/modest-mail-operation.c: (update_account_thread),
1020 (get_msgs_full_thread): Fix typo failures in the revert
1023 2007-06-27 Murray Cumming <murrayc@murrayc.com
1025 * src/maemo/modest-maemo-global-settings-dialog.c:
1026 (idle_select_default_focus):
1027 * src/modest-mail-operation.c: (idle_notify_progress),
1028 (idle_notify_progress_once), (set_last_updated_idle),
1029 (update_account_thread), (get_msgs_full_thread):
1030 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1031 * src/widgets/modest-header-view.c:
1032 (idle_notify_headers_count_changed_destroy),
1033 (idle_notify_headers_count_changed):
1034 Reverted the additions of gdk_threads_enter/leave(), in case this
1035 helps with a startup hang on the device.
1037 2007-06-26 Armin Burgmeier <armin@openismus.com>
1039 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
1040 for supported secure authentication methods from server by
1041 gtk_dialog_run(), saving CPU time and a potential race condition.
1043 2007-06-26 Armin Burgmeier <armin@openismus.com>
1045 * src/maemo/modest-maemo-utils.h:
1046 * src/maemo/modest-maemo-utils.c: Added a
1047 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
1048 only error code to tell the calling code when the user canceled the
1051 * src/maemo/modest-account-settings-dialog.h:
1052 * src/maemo/modest-account-settings-dialog.c:
1053 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
1054 message if the retrieval of secure authentication methods was canceled
1055 by the user. Perform the check before saving anything to configuration
1056 to not end up with half-committed configuration changes, do not show
1057 a "Saving to configuration failed" note when authentication methods
1058 could not be retrieved.
1060 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
1063 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1065 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1066 Only return the first level of folders under accounts, because the
1067 osso-global-search UI spec doesn't want the rest.
1068 This fixed projects.maemo.org bug NB#61811.
1070 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1072 * src/modest-tny-account-store.c:
1073 * src/modest-tny-account-store.h:
1074 Added modest_tny_account_is_memory_card_account().
1075 * src/maemo/modest-main-window.c: (create_details_widget):
1076 Show the same information items for the memory card as we show for the
1077 local-folders, to fix projects.maemo.org bug NB#59307.
1079 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1081 * src/modest-tny-account-store.c: (get_password):
1082 Added some checks for NULL to maybe prevent crashes, though I think
1083 it was Philip's last commit that actually prevented the crash here
1084 when creating a first new account.
1085 But the new account is still not usable (no messages are shown)
1086 until a restart of the application.
1088 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1090 * src/maemo/modest-maemo-global-settings-dialog.c:
1091 (idle_select_default_focus):
1092 * src/modest-mail-operation.c: (idle_notify_progress),
1093 (idle_notify_progress_once), (idle_notify_update_account_queue),
1094 (set_last_updated_idle), (update_account_thread),
1095 (notify_get_msgs_full), (get_msgs_full_destroyer),
1096 (get_msgs_full_thread):
1097 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1098 * src/widgets/modest-header-view.c:
1099 (idle_notify_headers_count_changed_destroy),
1100 (idle_notify_headers_count_changed):
1101 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1102 all idle handlers, because some other thread could be blocking
1103 the GDK lock, so that it can do GUI stuff.
1105 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1107 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1108 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1109 (on_idle_send_receive), (on_idle_open_default_inbox):
1110 * src/maemo/modest-msg-edit-window.c:
1111 (modest_msg_edit_window_attach_file_noninteractive):
1112 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1113 to prevent a hang. I don't quite understand why these are necessary,
1114 beause we should already be in the main loop. I guess something outside
1115 of the main loop is taking the lock.
1117 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1118 we are really using URIs, and use files that are more likely to exist.
1120 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1122 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1123 necessary because configure.ac now defines different variables.
1125 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1127 * libmodest-dbus-client/libmodest-dbus-client.c:
1128 * libmodest-dbus-client/libmodest-dbus-client.h:
1129 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1130 libmodest_dbus_client_compose_mail() is what things actually use.
1132 * src/dbus_api/modest-dbus-api.h:
1133 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1134 * tests/dbus_api/Makefile.am:
1135 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1138 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1140 * src/modest-init.c: (modest_init_local_folders):
1141 For memory-card (or other non local-folders) maildir accounts,
1142 always create an Archive folder, so that there is somewhere to put
1143 messages. This should be less confusing, because the user does not need
1144 to guess that the need to create a folder.
1146 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1148 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1149 Fixed icon size by using (50, 50) which is the same as defined by
1152 2007-06-25 Armin Burgmeier <armin@openismus.com>
1154 * src/widgets/modest-window-mgr.c:
1155 * src/modest-init.c:
1156 * configure.ac: Correctly recognize hildon-notify presence and fixed
1157 the build without it being installed.
1159 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1161 * libmodest-dbus-client/libmodest-dbus-client.c:
1162 (libmodest_dbus_client_search): Fix the build. Sorry.
1163 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1164 (reply_forward_cb): Initialize variables to fix the build.
1166 * src/modest-tny-account-store.c:
1167 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1168 comparison (a silly typo) so that email search results can be opened
1169 when there are more than one account.
1171 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1173 * libmodest-dbus-client/libmodest-dbus-client.c:
1174 (libmodest_dbus_client_search),
1175 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1176 instead of 1 second, because the search gets folders and messages from
1177 the server, which can take a long time. When it times out,
1178 osso-global-search will report no results.
1180 We need to specify whether we should search only cached information
1181 (maybe with a user preference), and the osso-email-search-plugin
1182 API should really be improved to allow that option, and to allow results
1183 to be delivered asynchronously in batches.
1185 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1187 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1188 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1189 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1191 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1193 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1194 that is an empty string. D-Bus seems to give us these instead of NULL.
1196 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1198 * src/dbus_api/modest-dbus-callbacks.c:
1199 * src/maemo/easysetup/modest-easysetup-wizard.h:
1200 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1201 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1202 (modest_connection_specific_smtp_edit_window_init):
1203 * src/maemo/modest-maemo-global-settings-dialog.c:
1205 * src/maemo/modest-maemo-utils.c:
1206 (modest_maemo_utils_setup_images_filechooser):
1207 * src/maemo/modest-main-window.c: (create_details_widget):
1208 * src/maemo/modest-msg-edit-window.c:
1209 (modest_msg_edit_window_attach_file_noninteractive),
1210 (modest_msg_edit_window_color_button_change),
1211 (modest_msg_edit_window_set_zoom):
1212 * src/modest-mail-operation.c: (update_account_thread):
1213 * src/modest-tny-account-store.c:
1214 * src/modest-tny-account.c:
1215 * src/widgets/modest-global-settings-dialog.c:
1216 * src/widgets/modest-window.h:
1218 Fixed build on bora!
1220 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1222 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1223 * src/modest-search.c: (modest_search_folder),
1224 (modest_search_all_accounts): Actually search only in the specified folder,
1225 doing a simple match on the folder ID.
1226 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1227 and added some documentation.
1229 2007-06-22 Armin Burgmeier <armin@openismus.com>
1231 * src/maemo/modest-maemo-utils.h:
1232 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1233 modest_maemo_utils_get_supported_secure_authentication_methods.
1235 * src/maemo/easysetup/modest-easysetup-wizard.c:
1236 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1237 one occured, not just "Server does not support secure authentication".
1239 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1241 * src/modest-tny-account-store.c: (get_password):
1242 Restored the call to tny_account_set_user() because Philip seems to have
1243 stopped this from crashing (by not using the freed string). It still does
1244 not work, but now we can test it.
1246 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1248 * src/maemo/modest-msg-edit-window.c: (init_window):
1249 Comment out use of an uninitialzed GtkScrolledWindow variable,
1250 to fix the build and stop a crash. Yet again.
1252 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1254 * src/modest-tny-account-store.c: (get_password):
1255 Remove the call to tny_account_set_user() because this actually crashes.
1256 As mentioned in the last commit, it is known to not work anyway.
1258 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1260 * src/modest-tny-account-store.c: (get_password):
1261 Use tny_account_set_username() to tell tinymail that the username might
1262 have changed too. But tinymail ignores this: see projects.maemo.org
1264 * src/modest-ui-actions.c:
1265 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1266 reset the connection when changing the username, and improve the comments.
1267 Save the changed username to gconf at least, so it is used when Modest is
1270 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1272 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1273 Do not use a query, so that we get all folders, including for POP and
1274 local-folders. They work as search criteria too.
1275 This fixes projects.maemo.org bug NB#57740.
1277 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1279 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1280 Comment out the use of hildon_notification_set_sound() because it is
1281 not declared, to fix the build. Warnings are serious, people.
1283 2007-06-21 Armin Burgmeier <armin@openismus.com>
1285 * src/maemo/modest-maemo-utils.h:
1286 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1287 modest_maemo_utils_get_supported_secure_authentication_methods()
1288 to query authentication methods for a specific user. This should fix
1289 projects.maemo.org bug NB#61369.
1291 * src/maemo/easysetup/modest-easysetup-wizard.c:
1292 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1295 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1297 * libmodest-dbus-client/libmodest-dbus-client.h:
1298 * libmodest-dbus-client/libmodest-dbus-client.c:
1299 (modest_dbus_message_iter_get_search_hit),
1300 (libmodest_dbus_client_search):
1301 Reorganised and commented this.
1302 Removed modest_search_hit_free() from the public API because it
1305 Added libmodest_dbus_client_get_folders() and
1306 modest_folder_result_list_free().
1308 * src/dbus_api/modest-dbus-api.h:
1309 * src/dbus_api/modest-dbus-callbacks.c:
1310 (modest_dbus_req_filter): Commented. Moved most code to
1311 on_dbus_method_search() and added on_dbus_method_get_folders().
1313 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1314 of the extra D-Bus handler.
1316 * tests/dbus_api/Makefile.am:
1317 * tests/dbus_api/test_get_folders.c: New test for
1318 libmodest_dbus_client_get_folders(). This seems to return an empty list
1319 at the moment. That could be the same error that causes the message list
1320 to be empty sometimes.
1321 This should help with projects.maemo.org bug NB#57740.
1323 2007-06-21 Armin Burgmeier <armin@openismus.com>
1325 * src/modest-mail-operation.c: Do not call
1326 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1327 notify the operation's end after having set the status to CANCELED for
1328 the operation queue to listen on. This fixes a deadlock when there
1329 were mail operations in the queue during its finalization.
1331 * src/modest-singletons.c: Reordered uninitialization of the account
1332 manager to happen after the mail operation queue was uninitialized
1333 because the mail operation's in the queue might still try to access
1334 the account manager (see modest_mail_operation_notify_end()). This
1335 fixes a potential crash when terminating the application.
1337 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1339 * src/modest-search.c:
1340 (search_mime_part_and_child_parts): Moved some code here so we
1341 can search recursively in child folders.
1342 (modest_search_folder): Search in the message as a mime part, instead
1343 of just its child mime parts.
1344 (read_chunk), (search_mime_part_ogs):
1345 Check how many bytes were read, to prevent an endless loop.
1346 Searching in message bodies now works. This finishes the fix for
1347 projects.maemo.org bug NB#61007.
1349 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1351 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1352 Add a g_warning when the item is not a folder.
1354 * src/modest-ui-dimming-rules.c:
1355 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1356 when selected item is not a folder (for instance, an account), because
1357 the UI spec only talks about folders.
1358 I am not sure what the UI spec wants, so this might not totally fix
1359 projects.maemo.org bug NB#60794.
1361 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1363 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1364 (load_from_file): Sort the list. The unsorted list would be more noticeable
1365 in non-English locales.
1367 * src/maemo/modest-msg-edit-window.c:
1368 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1369 warning and fix the build.
1371 * src/maemo/modest-progress-bar-widget.c:
1372 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1373 avoid a g_warning, and probably to avoid a crash.
1375 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1377 * src/modest-search.c: (modest_search_folder): Check for a GError
1378 when calling tny_folder_get_headers(), to show that this is not the cause
1381 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1383 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1384 Actually set the body query instead of the subject query.
1386 * src/modest-search.c: (search_mime_part_ogs),
1387 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1388 which would probably cause it to fail if we got this far.
1390 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1391 to simplify the code.
1392 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1393 be causing search-in-body to fail.
1395 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1397 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1399 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1400 Better debug message when the folder cannot be found.
1401 This should help with fixing projects.maemo.org bug #61287.
1402 * src/modest-search.c: (add_hit): Do not leak the furl string.
1404 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1406 * src/modest-ui-actions.c:
1407 (modest_ui_actions_on_folder_selection_changed):
1408 Do not special-case TNY_MERGE_FOLDER here, because
1409 modest_tny_folder_get_account() already does that. This fixes
1410 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1411 shown when the Outbox was selected).
1413 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1415 * libmodest-dbus-client/libmodest-dbus-client.c:
1416 (_dbus_iter_get_string_or_null): Initialize the string variable in
1417 case this helps with Dirk's crash.
1419 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1421 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1422 though it is not implemented yet (this function is maybe not even used),
1423 to avoid breaking ABI in future.
1424 * libmodest-dbus-client/libmodest-dbus-client.c:
1425 (get_attachments_string): Moved some code into this generic function.
1426 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1427 sends email. It is maybe not used.
1428 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1429 (on_send_mail): Use attachments.
1431 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1432 * src/maemo/modest-msg-edit-window.c:
1433 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1434 a filename before using it, to fix projects.maemo.org bug NB#58233.
1436 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1438 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1439 Initialize the continue_download variable to fix the build, and probably
1440 to fix randome behaviour.
1442 2007-06-18 Armin Burgmeier <armin@openismus.com>
1444 * src/modest-tny-send-queue.h:
1445 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1446 the queue so we can later show it in the UI. Replaced
1447 modest_tny_send_queue_msg_is_being_sent() by
1448 modest_tny_send_queue_get_msg_status().
1450 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1452 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1453 gpointer. This probably was not harmful, but just to be sure.
1455 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1457 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1458 Fix the build, but leave the function broken on Bora, because
1459 hildon_uri_action_get_service() does not exist.
1460 osso_uri_action_get_service() does not exist either, it seems.
1462 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1464 * src/modest-tny-account.c:
1465 (modest_tny_account_new_from_server_account):
1466 Uncommented the url debug output again, because it is useful for
1467 debugging, as I said in the comment.
1469 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1471 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1473 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1474 for Mameo Bora, to fix the build.
1476 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1479 Fixed build with hildon < 0.99
1481 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1482 Check if the selected account is busy instead of checking all accounts
1484 * src/modest-account-mgr-priv.h:
1485 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1486 (modest_account_mgr_init), (compare_account_name),
1487 (modest_account_mgr_set_account_busy),
1488 (modest_account_mgr_account_is_busy):
1489 * src/modest-account-mgr.h:
1490 Added busy information to the account manager. It possible to
1491 set an account to busy or not busy now.
1493 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1494 (modest_mail_operation_update_account),
1495 (modest_mail_operation_notify_end):
1496 Set the account to busy/not busy depending on the operation state.
1498 * src/widgets/modest-account-view.c:
1499 (modest_account_view_finalize), (get_last_updated_string),
1500 (update_account_view), (on_account_busy_changed), (init_view):
1501 Show string "Refreshing..." if the account is currently busy.
1503 All this fixes projects.maemo.org bug NB#59711
1505 2007-06-14 Armin Burgmeier <armin@openismus.com>
1507 * src/widgets/modest-attachments-view.h:
1508 * src/widgets/modest-attachments-view.c: Added
1509 modest_attachments_view_has_attachments() and fixed coordinate
1510 transformation in get_att_view_at_coords(). This fixes attachment
1513 * src/widgets/modest-msg-view.c: Make use of
1514 modest_attachments_view_has_attachments() to decide whether to show
1515 attachments in the header.
1517 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1519 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1520 (on_change), (on_combo_security_changed),
1521 (modest_connection_specific_smtp_edit_window_init),
1522 (modest_connection_specific_smtp_edit_window_set_connection),
1523 (modest_connection_specific_smtp_edit_window_is_dirty):
1524 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1525 * src/maemo/modest-connection-specific-smtp-window.c:
1528 Show an comfirmation dialog for the smpt-edit-window if there are
1529 unsaved changes and the user hits cancel.
1530 (projects.maemo.org bug NB#60479)
1532 2007-06-14 Armin Burgmeier <armin@openismus.com>
1534 * src/maemo/easysetup/modest-easysetup-wizard.c:
1535 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1536 address" info in banner instead of node, and select all the text as
1537 per UI spec. This fixes projects.maemo.org bug NB#60550.
1539 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1541 reviewed by: <delete if not using a buddy>
1543 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1544 * src/modest-ui-actions.c: (folder_refreshed_cb):
1546 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1548 * src/widgets/modest-folder-view.c: (filter_row):
1549 Explictly filter out the per-account outbox accounts. I don't know why
1550 these only sometimes show up, but now they should never show up in the UI.
1551 This should fix projects.maemo.org bug NB#60160.
1553 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1555 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1556 when the toolbar does not exist yet.
1557 * src/modest-widget-memory.c: (save_settings_header_view):
1558 Added g_warnings() to help us to discover when we are trying to set
1559 an empty columns list in gconf.
1561 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1563 * src/modest-init.h:
1564 * src/modest-init.c:
1565 Added modest_init_get_default_header_view_column_ids().
1567 * src/modest-widget-memory.c: (restore_settings_header_view):
1568 Use the new function to get defaults, if the gconf key is empty,
1569 instead of not creating any columns. This seems to fix the
1570 empty right-hand pane problems.
1572 * src/widgets/modest-header-view.h: Improved documentation.
1574 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1576 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1577 Revert the use of the display name as the account name, because this
1578 is generally wrong and would break the code that follows.
1580 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1582 * src/maemo/easysetup/modest-easysetup-wizard.c:
1583 (check_for_supported_auth_methods), (on_before_next),
1586 More correct fix for projects.maemo.org bug NB# 58991
1587 Do not longer accept AUTH_PASSWORD as secure method and choose
1588 correct method when creating the account.
1590 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1592 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1593 Fixed projects.maemo.org bug NB# 58991
1595 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1597 * src/modest-init.c: (modest_init_init_core),
1598 (modest_init_local_folders): Fixed compilation errors.
1600 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1602 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1603 Remove unnecessary lib/include, though it is good in principle when needed.
1605 * src/modest-init.c: (modest_init_one_local_folder),
1606 (modest_init_local_folders):
1607 * src/modest-init.h: Initialize the .modest library for memory cards,
1608 instead of just doing nothing for them. This should allow us to create
1609 folders there, fixing projects.maemo.org bug NB#59297.
1611 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1613 * libmodest-dbus-client/libmodest-dbus-client.c:
1614 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1615 (libmodest_dbus_client_compose_mail),
1616 (libmodest_dbus_client_open_message),
1617 (libmodest_dbus_client_send_and_receive),
1618 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1620 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1621 (on_idle_open_message), (modest_dbus_req_handler),
1622 (search_result_to_message), (modest_dbus_req_filter):
1623 * src/modest-search.c: (add_hit), (modest_search_folder),
1624 (modest_search_all_accounts): Improved debug messages.
1626 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1628 * src/modest-tny-account-store.c:
1629 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1632 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1635 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1637 * src/modest-tny-account-store.c: (get_server_accounts):
1638 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1639 even when there are no accounts, so that the Outbox folder is always
1640 visible. This fixes projects.maemo.org bug NB#60158.
1642 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1644 * src/maemo/modest-main-window.c: (create_details_widget):
1645 Use the mcen_va_never logical ID.
1647 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1649 * src/dbus_api/modest-dbus-api.h:
1650 * src/dbus_api/modest-dbus-callbacks.c:
1651 (on_idle_open_default_inbox), (on_open_default_inbox),
1652 (modest_dbus_req_handler):
1653 Added a new OpenDefaultInbox method.
1655 * libmodest-dbus-client/libmodest-dbus-client.h:
1656 * libmodest-dbus-client/libmodest-dbus-client.c:
1657 Added libmodest_dbus_client_open_default_inbox() to call the new
1658 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1659 though it should maybe be used by a new osso-email-interface function.
1661 * tests/dbus_api/Makefile.am:
1662 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1665 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1667 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1668 NULL, so that the signals get all the keys. This should not actually
1669 change any behaviour because we currently update everything when anything
1672 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1674 * src/widgets/modest-folder-view.c: (text_cell_data),
1675 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1676 (find_inbox_iter): If tinymail tells us that the folder is
1677 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1678 This causes the inbox to be selected at startup, fixing part of
1679 projects.maemo.org bug NB#56305.
1681 * src/modest-ui-dimming-rules.c:
1682 (modest_ui_dimming_rules_on_tools_smtp_servers):
1683 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1684 the SMTP servers menu item.
1685 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1686 that the SMTP Servers menu item is dimmed when there are no accounts,
1687 as a future version of the UI spec will require. This fixes
1688 projects.maemo.org bug NB#56305.
1690 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1692 * src/maemo/modest-maemo-utils.c:
1693 (modest_maemo_utils_get_supported_secure_authentication_methods):
1694 Added label to dialog instead of unreadable title
1696 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1697 (modest_main_window_new):
1698 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1701 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1702 * src/modest-account-mgr.h:
1703 Added method to avoid code duplication
1705 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1706 (modest_ui_actions_on_send_receive):
1707 Use modest_account_mgr_has_accounts
1709 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1711 * src/maemo/easysetup/modest-presets.c:
1712 (modest_presets_get_info_server_security): Do not report secure auth
1714 * src/modest-protocol-info.c: Use the defines for the gconf key names
1715 for secure authentication. This was not working because we were writing
1716 Password and reading password, and the check was case sensitive.
1717 With this, gmail now works for receiving and sending when created via
1720 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1722 * src/maemo/easysetup/modest-presets.c:
1723 (modest_presets_get_info_server_security): Correct the key name for
1724 SecureSmtp, because it seems to be case-sensitive.
1725 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1726 Do not try to get the 0th notebook page if there are 0 pages, to
1727 avoid a g_warning().
1729 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1731 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1732 Prevent use of the new notification feature for now, because it currently
1733 shows one dialog for each new email, which is annoying.
1735 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1737 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1738 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1739 when no country was selected, so that we show the global ones.
1740 * src/maemo/easysetup/modest-presets.c:
1741 (modest_presets_get_providers): Return only the global providers, not
1742 all providers when mmc=0 was requested.
1744 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1746 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1747 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1748 provider ID in the combo.
1750 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1751 Do not show the page numbers, because it would be confusing when we add
1752 the 2 extra pages for the custom setup, when the user chooses the "Other"
1753 provider. This fixes projects.maemo.org bug NB#59028
1755 * src/modest-init.c: (modest_init_init_core),
1756 (modest_init_local_folders):
1757 * src/modest-init.h:
1758 * src/modest-tny-account.c:
1759 (modest_tny_account_new_for_local_folders): Do not create default folders
1760 for the memory card. This should fix projects.maemo.org bug NB#59328.
1762 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1764 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1765 Free the changed_conf_keys string items. They are already freed in the
1766 idle handler if that runs first.
1768 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1770 * src/modest-ui-actions.c:
1771 (modest_ui_actions_on_password_requested): Check that the server name
1772 is not NULL, because I just saw a password dialog with (null) as the
1775 * src/modest-tny-folder.[h|c]: Added
1776 modest_tny_folder_is_memory_card_folder().
1777 * src/modest-ui-dimming-rules.c:
1778 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1779 menu item for memory cards, as per the UI spec (section 7.4). This should
1780 fix projects.maemo.org bug NB#59297.
1782 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1784 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1785 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1786 is another problem with the code, see Murray's comment at line 772)
1788 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1790 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1791 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1792 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1793 (load_from_file), (easysetup_country_combo_box_init),
1794 (easysetup_country_combo_box_get_active_country_ids),
1795 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1796 instead of just one ID, to avoid duplicate country names in the UI.
1798 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1799 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1800 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1801 a single ID, avoiding duplicate providers.
1802 * src/maemo/easysetup/modest-easysetup-wizard.c:
1803 (on_combo_account_country): Adapt to use a list.
1805 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1807 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1808 keys changed in the last X seconds.
1810 * src/modest-account-mgr.h:
1811 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1812 (on_key_change), (modest_account_mgr_class_init),
1813 (modest_account_mgr_init), (modest_account_mgr_finalize):
1814 As the keys are changed, save them in a GSList* and signal that GSList*
1815 further every X seconds, to batch changes, to allow us to do just one
1816 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1817 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1819 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1820 changed signal signature.
1822 * src/modest-conf.c: (modest_conf_set_list),
1823 (modest_conf_on_change): Reenable notification.
1825 (modest_conf_maemo_fake_on_change): Comment out the hack that
1826 notified immediately instead of asynchronously.
1828 * src/widgets/modest-account-view.h:
1829 * src/widgets/modest-account-view.c:
1830 (update_account_view): Select the previously-selected account ID,
1831 if possible. This fixes projects.maemo.org bug NB#56933.
1833 (on_account_changed), (on_account_removed),
1834 (modest_account_view_select_account):
1836 Remove the block/unblock functions
1837 because they were not useful.
1839 * src/maemo/modest-account-view-window.c:
1840 (on_delete_button_clicked), (on_edit_button_clicked),
1841 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1843 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1845 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1846 Improve the error dialog to show Incorrect Account Settings, which seems
1847 clearer, and say that the internal error message (to be removed from the
1848 dialog later) is often misleading.
1849 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1851 * src/modest-tny-account.c:
1852 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1853 URL because this is so useful for debugging on the device.
1855 * src/widgets/modest-serversecurity-combo-box.c:
1856 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1858 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1860 * src/modest-mail-operation.c:
1861 (modest_mail_operation_send_new_mail):
1862 Added a comment about a nasty but apparently harmless message. Details
1863 added to the wiki g_warnings() page.
1865 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1867 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1868 (modest_tny_send_queue_class_init):
1869 Do not use the priv struct because it is empty, to avoid g_warnings
1870 about a non-existant priv struct.
1872 * src/modest-tny-account-store.c:
1873 (modest_tny_account_store_get_server_account),
1874 (modest_tny_account_store_get_transport_account_for_open_connection
1875 ): Do not try to get transport server accounts for local folders,
1876 because they don't have any. This avoids a g_warning().
1878 * src/maemo/modest-main-window.c:
1879 (modest_main_window_notify_send_receive_initied),
1880 (on_configuration_key_changed):
1881 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1882 * src/modest-defs.h:
1883 * src/modest-mail-operation.c:
1884 (modest_mail_operation_update_account):
1885 * src/modest-tny-account-store.h:
1886 * src/modest-tny-account.c:
1887 (modest_tny_account_get_special_folder),
1888 (modest_tny_account_new_for_local_folders),
1889 (modest_tny_account_new_for_per_account_local_outbox_folder):
1890 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1891 * src/modest-tny-local-folders-account.c:
1892 (add_account_folders_to_merged_folder):
1893 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1894 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1895 (modest_ui_actions_on_send):
1896 * src/widgets/modest-folder-view.c: (update_model):
1897 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1898 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1899 modest_tny_account_store_get_tny_account_by_account() to
1900 modest_tny_account_store_get_server_account() to make the code clearer.
1902 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1904 * src/dbus_api/modest-dbus-api.h:
1905 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1906 * src/maemo/modest-msg-edit-window.c:
1907 (modest_msg_edit_window_attach_file_noninteractive):
1908 added g_warning in case the file to be attached does not exist
1909 * tests/dbus_api/test_compose_mail.c: (main):
1910 removed obsolete comment, added generic files as test case
1912 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1914 * src/modest-tny-account-store.c: (get_server_accounts):
1915 Create the local folders account only once, not once for each outbox, and
1916 not only when there are some outboxes.
1918 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1920 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1921 code that is causing a crash at startup. Sergio says that he is fixing this.
1923 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1925 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1926 * src/maemo/modest-account-settings-dialog.c:
1927 (create_page_outgoing),
1928 (modest_account_settings_dialog_set_account_name),
1929 (save_configuration):
1930 - Fixed handling of the "Use secure authentication" toggle to comply with
1931 the ui specification. See also projects.maemo.org bug NB#58400
1933 - Restore the Secure connection setting combo correctly when loading
1936 * src/maemo/modest-maemo-utils.c:
1937 (on_camel_account_get_supported_secure_authentication),
1938 (modest_maemo_utils_get_supported_secure_authentication_methods):
1939 Fixed a crasher if operation is canceled
1941 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1942 (modest_protocol_info_auth_is_secure):
1943 * src/modest-protocol-info.h:
1945 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1946 the sense of the "Use secure authentication" toggle.
1948 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1950 * src/modest-tny-account-store.h:
1951 * src/modest-tny-account-store.c:
1952 Added modest_tny_account_store_get_local_folders_account().
1954 * src/modest-tny-folder.h:
1955 * src/modest-tny-folder.c:
1956 (modest_tny_folder_get_account):
1957 Added this replacement for tny_folder_get_account() which returns
1958 the local-folders account for TnyMergeFolders, to avoid the
1959 warning about the unimplemented get_account_func() vfunc().
1961 (modest_tny_folder_get_rules),
1962 * src/modest-ui-actions.c:
1963 (modest_ui_actions_on_folder_selection_changed):
1964 * src/modest-mail-operation.c:
1965 (modest_mail_operation_remove_folder),
1966 (modest_mail_operation_xfer_folder),
1967 (modest_mail_operation_rename_folder),
1968 (modest_mail_operation_get_msg),
1969 (modest_mail_operation_get_msgs_full),
1970 (modest_mail_operation_remove_msg),
1971 (modest_mail_operation_xfer_msgs),
1972 (modest_mail_operation_refresh_folder):
1973 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1975 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1977 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1978 (modest_server_account_set_security):
1979 * src/modest-defs.h: Add comments explaining that our
1980 UI spec means TLS when it says Normal, so these do not look like errors.
1982 * src/modest-tny-account.c:
1983 (modest_tny_account_new_from_server_account): Use the new tinymail
1984 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1985 for TLS. This should fix projects.maemo.org bug NB#58460.
1987 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1989 * src/maemo/easysetup/modest-easysetup-wizard.c:
1990 (create_account): Correct the position of the gconf sanity check warning.
1991 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1992 of using the g_idle_add() hack, because this does not seem to be necessary
1993 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1994 caused by something other than maemo's gconf.
1995 This fixes projects.maemo.org bug #59022.
1997 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1999 * src/modest-account-mgr-helpers.c:
2000 (modest_account_mgr_get_default_account): Do not check that the account
2001 exists if there is no default account (NULL), to fix a runtime warning.
2003 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2005 * src/widgets/modest-folder-view.c: (update_model):
2006 Do not unref the treemodel before we have finished with it.
2007 This prevents a valgrind warning and an occasional crash at startup.
2009 2007-06-06 Marcus Bauer <marcusb@openismus.com>
2011 * libmodest-dbus-client/libmodest-dbus-client.h:
2012 added libmodest_dbus_client_compose_mail()
2013 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2015 added functions needed for SendAsMail() functionality
2016 * src/maemo/modest-msg-edit-window.c:
2017 (modest_msg_edit_window_attach_file_noninteractive):
2018 non interactively attaching files to message edit window
2019 * src/widgets/modest-msg-edit-window.h:
2020 * tests/dbus_api/Makefile.am:
2021 added test_compose_mail.c
2022 * tests/dbus_api/test_compose_mail.c: (main):
2024 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2026 * src/modest-account-view.c:
2027 Fixed bug projects.maemo.org bug NB#59307
2029 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2031 * src/maemo/easysetup/modest-easysetup-wizard.c:
2032 (get_serverport_incoming), (on_before_next), (create_account):
2033 * src/maemo/modest-account-settings-dialog.c:
2034 (modest_account_settings_dialog_set_account_name):
2035 * src/maemo/modest-maemo-utils.c:
2036 (on_camel_account_get_supported_secure_authentication_status),
2037 (on_camel_account_get_supported_secure_authentication),
2038 (on_secure_auth_cancel),
2039 (modest_maemo_utils_get_supported_secure_authentication_methods):
2041 Implemented security authentication for settings and easysetup.
2043 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2045 * src/maemo/modest-main-window.c: (create_details_widget):
2046 Show the total size for memory card accounts too, instead of showing
2047 the name again. Fixes bug projects.maemo.org bug NB#59307.
2049 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2052 * src/modest-tny-simple-folder-store.c:
2053 * src/modest-tny-simple-folder-store.h: Removed.
2055 * src/modest-tny-local-folders-account.h
2056 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
2057 for the local-folders maildir, with an extra TnyMergedFolder containing
2058 the folders of the per-account outbox store accounts.
2059 * src/modest-tny-account-store.c: (get_server_accounts):
2060 Add the outboxes to the special local folders account after creating it.
2062 * src/modest-tny-account.c:
2063 (modest_tny_account_new_for_local_folders): Create the derived
2064 account when creating the main local-folders account.
2066 * src/maemo/modest-main-window.c: (create_details_widget),
2067 (modest_main_window_set_contents_style):
2068 Adapted to the use of the derived account instead of the folder store.
2070 * src/modest-ui-actions.c:
2071 (modest_ui_actions_on_folder_selection_changed):
2072 * src/modest-ui-dimming-rules.c:
2073 (modest_ui_dimming_rules_on_new_folder):
2074 * src/widgets/modest-folder-view.c: (text_cell_data),
2075 (icon_cell_data), (filter_row), (update_model),
2076 (get_cmp_rows_type_pos):
2079 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2080 Do not get the priv struct, because no priv struct has been set,
2081 to avoid a runtime warning.
2083 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2084 #ifelse with #else, to fix a warning, to fix the build.
2087 2007-06-05 Christian Kellner <ckellner@openismus.com>
2089 * libmodest-dbus-client/libmodest-dbus-client.c:
2090 Fix small typo in doc (why do you always see them
2091 AFTER committing stuff?)
2094 2007-06-05 Christian Kellner <ckellner@openismus.com>
2096 * libmodest-dbus-client/libmodest-dbus-client.c:
2097 (libmodest_dbus_client_search):
2098 Initialize hit list with NULL. Also set folder list
2099 to "" if NULL was supplied.
2102 2007-06-03 Christian Kellner <ckellner@openismus.com>
2104 * libmodest-dbus-client/libmodest-dbus-client.c:
2105 (modest_search_hit_list_free):
2106 Make it save to call it with NULL.
2108 * src/dbus_api/modest-dbus-callbacks.c:
2109 * src/modest-search.c:
2110 Return full ModestSearchHits as the search result list not TnyHeader
2111 since can't be around withouth the correspoding TnyFolder.
2113 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2115 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2116 Added currently commented code to check for secure auth
2118 * src/maemo/modest-account-settings-dialog.c: (on_response),
2119 (save_configuration), (show_ok):
2120 Fixed projects.maemo.org bugs NB #59248 and #59251
2122 * src/maemo/modest-maemo-utils.c:
2123 (on_camel_account_get_supported_secure_authentication_status),
2124 (on_camel_account_get_supported_secure_authentication),
2125 (modest_maemo_utils_get_supported_secure_authentication_methods):
2126 * src/maemo/modest-maemo-utils.h:
2127 Moved get_supported_secure_authentication() method here to be able
2128 to use it from easysetup wizard.
2130 * src/modest-pair.c: (on_pair_compare_as_string):
2131 Should compare string with first part of pair and not
2132 strcmp pairs which will crash.
2134 * src/modest-protocol-info.c:
2135 (modest_protocol_info_protocol_is_store):
2136 * src/modest-protocol-info.h:
2137 Added modest_protocol_info_get_auth_protocol_name()
2139 2007-06-03 Armin Burgmeier <armin@openismus.com>
2141 * src/modest-mail-operation.c:
2142 (modest_mail_operation_get_msgs_full): Set priv->account also when
2143 only retrieving a single message. This avoids a crash when canceling
2146 (modest_mail_operation_notify_end): Do not explicitely remove the
2147 operation from the queue but only emit the progress_changed signal.
2148 The queue itself listens to that signal to remove the operation when
2149 it is finished. This reduces coupling and removes a potential deadlock
2150 when modest_mail_operation_notify_end() is called from the queue
2151 itself. If that is a problem performance-wise, I would suggest to
2152 implement a status-changed signal or something.
2154 * src/modest-mail-operation-queue.c: Make sure to never call a
2155 function from another file while the queue is locked. This (hopefully)
2156 fixes another deadlock when exiting the application while retrieving
2159 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2161 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2162 Fixed build if libogs is not available
2164 2007-06-03 Christian Kellner <ckellner@openismus.com>
2166 * libmodest-dbus-client/libmodest-dbus-client.h:
2167 * libmodest-dbus-client/libmodest-dbus-client.c:
2168 (libmodest_dbus_client_delete_message):
2169 Implement deletion of messages (Client side).
2171 (modest_search_hit_free),
2172 (modest_search_hit_list_free):
2173 Utility functions to free the result hits.
2175 * src/dbus_api/modest-dbus-api.h:
2176 * src/dbus_api/modest-dbus-callbacks.c:
2177 (on_delete_message),
2178 (modest_dbus_req_handler):
2179 Implement deletion of messages (Server side).
2181 * tests/dbus_api/test_search.c: (main):
2184 * tests/dbus_api/Makefile.am:
2185 * tests/dbus_api/test_delete_message:
2186 Add little test for the message deletion logic
2188 2007-06-03 Armin Burgmeier <armin@openismus.com>
2190 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2191 when the operation queue was not empty. projects.maemo.org bug
2194 2007-06-03 Armin Burgmeier <armin@openismus.com>
2196 * src/widgets/modest-account-view.c
2197 (on_account_default_toggled): Toggle default account column
2198 explicitely instead of waiting for gconf notification (which is
2199 currently ignored). This should fix projects.maemo.org bug NB#56910
2200 for now. It should probably be removed when gconf notifications are
2203 2007-06-03 Christian Kellner <ckellner@openismus.com>
2205 * libmodest-dbus-client/libmodest-dbus-client.c:
2206 Removed debugging spew.
2208 * src/dbus_api/modest-dbus-callbacks.c:
2209 Added debugging info.
2211 * src/modest-search.c:
2212 (modest_search_all_accounts):
2213 Use tny_account_store_get_accounts () on the account store
2214 to get all accounts which is the way to get all accounts.
2216 * tests/dbus_api/test_search.c: (main):
2217 Make it possible to supply the search term on the command line.
2219 2007-06-03 Christian Kellner <ckellner@openismus.com>
2221 * libmodest-dbus-client/libmodest-dbus-client.c:
2222 * libmodest-dbus-client/libmodest-dbus-client.h:
2223 Implement searching for mesages over raw dbus. (Client side)
2225 * src/dbus_api/Makefile.am:
2226 * src/dbus_api/modest-dbus-api.h:
2227 * src/dbus_api/modest-dbus-callbacks.c:
2228 * src/dbus_api/modest-dbus-callbacks.h:
2229 Search framework (Server side). Also implement on_idle_open_message().
2231 * src/maemo/modest-platform.c: (modest_platform_init):
2232 Prepare for raw dbus/osso rpc interaction.
2234 * src/modest-search.h:
2235 Changed minsize from unspecific guint to guint32.
2237 * src/modest-search.c:
2239 Added strange hack which magically made tnymail work.
2241 (modest_search_folder),
2242 (modest_search_account),
2243 (modest_search_all_accounts):
2244 Implement helper functions to search all accounts, specific account
2247 * tests/dbus_api/Makefile.am:
2248 * tests/dbus_api/test_open_message.c:
2249 Read url to open from commandline.
2251 * tests/dbus_api/test_search.c:
2252 Implement small test for dbus search stuff
2254 2007-06-02 Armin Burgmeier <armin@openismus.com>
2256 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2257 include account type and account title. This fixes projects.maemo.org
2260 * src/maemo/modest-account-view-window.c: Set a title for the window.
2262 2007-06-02 Armin Burgmeier <armin@openismus.com>
2264 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2265 incoming and outgoing server name based on email address and server
2266 types as long as the names have not been edited manually. This fixes
2267 projects.maemo.org bug NB#58671.
2269 2007-06-02 Armin Burgmeier <armin@openismus.com>
2271 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2272 server type cannot be changed in future to the incoming details page
2273 when creating an account. This fixes projects.maemo.org bug NB#59029.
2275 2007-06-02 Armin Burgmeier <armin@openismus.com>
2277 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2278 and assigned max width chars so that they wrap instead of being
2279 truncated. Fixes projects.maemo.org bug NB#56126.
2281 2007-06-02 Armin Burgmeier <armin@openismus.com>
2283 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2284 introductory note to the connection specific smtp servers dialog, as
2285 section 8.12 of the email UI specification requires. This fixes
2286 projects.maemo.org bug NB#59212.
2288 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2290 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2291 Check for running mail operations, and offer to cancel them, as per the UI
2292 spec. This fixes projects.maemo.org bug NB#59041 .
2293 However, I suspect that tinymail may still use the network connection
2294 in ways that we cannot detect or cancel. But it should at least adapt to
2295 changes fairly well.
2297 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2299 * src/modest-tny-account-store.c: (recreate_all_accounts),
2300 (get_cached_accounts), (get_server_accounts): Do more sensible
2301 ref-counting of the temporarily-cached outbox accounts list. This seems
2302 to fix a crash when entering the password when the password was wrong.
2304 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2306 * src/gnome/modest-main-window.c: (connect_signals):
2307 * src/modest-tny-account-store.c: (get_password),
2308 (modest_tny_account_store_alert): Added comments and clues and
2309 commented-out code about how we currently fail to deal with connection
2310 errors and wrong passwords, and how we should.
2312 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2314 * src/widgets/modest-retrieve-combo-box.c:
2315 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2316 This fixes projects.maemo.org bug NB#58472 .
2318 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2320 * src/maemo/easysetup/modest-easysetup-wizard.c:
2321 (create_page_complete_easysetup):
2322 (create_page_complete_custom): Correct the last commit,
2323 putting the correct sentences in the correct pages.
2325 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2327 * src/maemo/easysetup/modest-easysetup-wizard.c:
2328 (create_page_complete_custom): Show the second sentence of text
2329 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2332 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2334 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2335 Set the leave-on-server conf key by default. This fixes
2336 projects.maemo.org bug NB#59258 .
2338 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2340 * src/maemo/modest-account-view-window.c:
2341 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2342 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2345 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2347 * src/maemo/easysetup/modest-easysetup-wizard.c:
2348 (create_caption_new_with_asterisk):
2349 * src/maemo/modest-account-settings-dialog.c:
2350 (create_caption_new_with_asterisk):
2351 Uncomment the code to add the asterisk, because they are no longer in the
2352 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2353 (update_incoming_server_title): Add an asterisk here too.
2355 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2357 * src/maemo/modest-maemo-global-settings-dialog.c:
2358 (current_connection): Check that we are even connected before trying to
2359 get the current connection name, to prevent a warning.
2361 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2362 Change the comments because tny_maemo_conic_device_connect() is now meant to
2364 * src/modest-mail-operation.c:
2365 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2366 make sure we have a connection and fail if we can't connect.
2368 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2370 * src/maemo/modest-main-window.c:
2371 (on_account_store_connecting_finished): Do not try to get the
2372 connection ID if we are not really connected. I am surprised that
2373 this signal handler is called when we are not connected.
2375 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2377 * src/modest-error.h:
2378 * src/modest-ui-actions.c:
2379 (modest_ui_actions_get_msgs_full_error_handler):
2380 Renamed an enum, added comments, added an enum
2381 for retrieve-limit errors.
2383 * src/modest-mail-operation.c: (foreach_add_item),
2384 (internal_folder_observer_update), (update_account_thread),
2385 (modest_mail_operation_get_msgs_full):
2386 (modest_mail_operation_update_account),
2387 Added comments about how this works, and some code that should
2388 (but does not) check the retrieve-limit. See the TODO comment.
2390 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2392 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2393 Initialize help_id to fix the build. Warnings are good.
2395 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2397 * src/widgets/modest-hbox-cell-renderer.c:
2398 (modest_hbox_cell_renderer_append):
2399 * src/widgets/modest-vbox-cell-renderer.c:
2400 (modest_vbox_cell_renderer_append):
2401 Fix the last commit by doing an extra ref.
2403 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2405 * src/widgets/modest-hbox-cell-renderer.c:
2406 (modest_hbox_cell_renderer_append):
2407 * src/widgets/modest-vbox-cell-renderer.c:
2408 (modest_vbox_cell_renderer_append):
2409 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2410 to fix the build with Maemo Bora.
2411 However, there seems to be a remaining crash, probably due to reference
2414 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2416 * src/modest-tny-account.c:
2417 (modest_tny_account_new_for_local_folders):
2418 Use hildon_file_system_info_async_new() to get a better name for
2419 the memory card account, setting it as the account name.
2420 The timing seems to work, but this is probably
2421 not the best place to do this. See the TODO comment.
2422 * src/maemo/modest-main-window.c: (create_details_widget):
2423 * src/widgets/modest-folder-view.c: (text_cell_data):
2424 Use the tny account name instead of hardcoding a name.
2426 2007-05-30 Christian Kellner <ckellner@openismus.com>
2428 * src/modest-search.c: (modest_search):
2429 Correctly set part_search_func even if we have already parsed
2430 the query and thus a valid OgsTextSearcher object.
2432 2007-05-30 Christian Kellner <ckellner@openismus.com>
2435 Search and check for libogs.
2438 Incooparte the ogs build env.
2440 * src/modest-mime-part-search-stream.c:
2441 * src/modest-mime-part-search-stream.h:
2442 Removed since we do the real searching now in modest-search.c.
2444 * src/modest-search.c:
2445 * src/modest-search.h:
2446 Implement support for ogs. We use that if available and requested
2447 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2448 should now handle the corner case when the search term is spread
2449 across multiple reads.
2450 Also the logic in modest_search () was corrected to search all
2451 requested fields until one is found.
2453 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2455 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2457 * src/modest-init.h:
2458 * src/modest-init.c: Made modest_init_local_folders() take a
2459 path and be public so we can iniitialize maildir folders on
2462 * src/modest-local-folder-info.h:
2463 * src/modest-local-folder-info.c:
2464 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2466 * src/modest-tny-account.c:
2467 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2468 still means the standard local-folders path on the local volume.
2470 * src/modest-tny-account-store.c:
2471 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2472 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2473 all accounts when that happens.
2474 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2475 this too, so it shows up in the treeview.
2477 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2479 * src/maemo/modest-maemo-global-settings-dialog.c:
2480 (current_connection):
2481 * src/widgets/modest-global-settings-dialog.c:
2482 (current_connection_default):
2483 Use the enum values instead of 0, 1 and -1,
2484 to make the code clearer.
2486 * src/modest-account-mgr-helpers.c:
2487 (modest_account_mgr_get_connection_specific_smtp): Make this code
2490 * src/modest-runtime.h:
2491 * src/modest-runtime.c:
2492 Added modest_runtime_remove_all_send_queues().
2493 * src/maemo/modest-main-window.c:
2494 (on_account_store_connecting_finished): Recreate the send queues,
2495 using the appropriate transport accounts for this new connection.
2496 Some futher adapting might be needed if the old send queues are not
2497 automatically stopped at this point.
2499 * src/modest-tny-account-store.c: (get_server_accounts):
2500 Create the connection-specific transport accounts, so that they can
2501 be found later by their ID.
2503 * src/modest-tny-account.h:
2504 * src/modest-tny-account.c:
2505 Added modest_tny_account_new_from_server_account_name().
2506 modest_tny_account_new_from_server_account(): Do not create the
2507 send queues here, because they will be
2508 recreated anyway when the connection changes for the first time.
2510 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2512 * src/modest-local-folder-info.h:
2513 * src/modest-local-folder-info.c:
2514 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2515 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2516 tbox_folder): Take a modest account name instead of a server TnyAccount,
2517 so we can have per-modest-account rather than per-transport-account
2519 We must make sure that we change or recreate the exisitng send queues
2520 when the connection changes for connection-specific transport accounts.
2522 * src/modest-tny-account-store.c:
2523 (create_per_account_local_outbox_folders): Create outboxed per modest
2524 account, not per transport account.
2526 * src/modest-tny-account.h:
2527 * src/modest-tny-account.c:
2528 (modest_tny_account_get_special_folder): For outboxes, get the
2529 parent modest account name. The account is ignored for other folders.
2530 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2531 modest account name rather than a server TnyAccount.
2533 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2535 * src/modest-tny-account.c:
2536 (modest_tny_account_new_from_server_account):
2537 Call modest_runtime_get_send_queue() immediately after creating transport
2538 accounts, so that they start trying to send email from the outbox as soon
2539 as possible at startup. This is probably what we want.
2541 * src/modest-mail-operation.c: (update_account_thread):
2542 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2543 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2544 * src/modest-tny-send-queue.h:
2545 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2546 (modest_ui_actions_on_send):
2547 Added comments about how sending works, though it needs some more work.
2549 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2551 * src/modest-tny-account.c:
2552 (modest_tny_account_get_special_folder): Add TODO because this fails when
2553 the network is busy.
2554 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2555 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2556 Do not try to show this window when there is no active account. The UI
2557 specs does not tell us what to do in this case.
2559 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2563 * src/maemo/Makefile.am:
2564 * src/widgets/Makefile.am: Some dist fixes.
2566 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2568 * src/maemo/modest-connection-specific-smtp-window.c:
2569 (on_button_edit): Make the code clearer, to prevent a double free.
2571 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2573 * src/maemo/modest-account-settings-dialog.c:
2574 (modest_account_settings_dialog_set_account_name),
2575 Check the connection-specific smtp servers checkbox if there are any.
2577 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2578 (modest_connection_specific_smtp_edit_window_init):
2579 Start with a suitable port number.
2581 * src/modest-account-mgr-helpers.h:
2582 * src/modest-account-mgr-helpers.c: Added
2583 modest_account_mgr_get_has_connection_specific_smtp().
2585 (modest_account_mgr_set_connection_specific_smtp),
2586 (modest_account_mgr_remove_connection_specific_smtp),
2587 (modest_account_mgr_get_has_connection_specific_smtp),
2588 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2589 connection-specific smtp server accounts in the account, rather than
2590 the server account conf dir.
2592 This fixes bug projects.maemo.org bug NB#58263 .
2594 * src/modest-tny-account-store.c:
2595 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2596 if there are no server accounts yet, to prevent an infinite loop when there
2597 are no accounts. Document that one must be called before the other.
2599 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2601 * src/modest-account-mgr-helpers.c:
2602 (modest_account_mgr_get_default_account): Make sure that at least
2603 one account is always the default, if there are any enabled accounts.
2604 This is just a sanity check that shouldn't be necessary.
2606 * src/modest-account-mgr-priv.c:
2607 (_modest_account_mgr_account_from_key): Unescape the conf key to
2608 get the real account name. For instance, this is an issue if a space
2609 was in the account name, which can happen because the account name
2610 is generated from the display name.
2611 (_modest_account_mgr_get_account_keyname): Always escape the
2613 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2614 Unescape the conf keys to get the real account names.
2616 For instance, previously the is-default radio button in the accounts
2617 list was not checked for any accounts at first. This fixes that,
2618 and might fix several similar bugs.
2620 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2622 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2623 Removed some debug printfs.
2625 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2627 Modest on-disk outbox directories are now here, for instance:
2628 $HOME/.modest/outboxes/<account-id-1>/outbox
2629 $HOME/.modest/outboxes/<account-id-2>/outbox
2631 $HOME/.modest/local-folders/outbox
2632 so we can have a separate outbox for each account.
2633 But they are shown as one outbox in the GtkTreeView, by using a
2634 TnyMergeFolder in a ModestTnySimpleFolderStore.
2637 * src/modest-tny-simple-folder-store.c:
2638 * src/modest-tny-simple-folder-store.h:
2639 Added ModestTnySimpleFolderStore, used to contain folders from
2640 other folder stores, such as other accounts.
2642 * src/modest-tny-outbox-account.h:
2643 * src/modest-tny-outbox-account.c:
2644 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2645 used for the per-account local outbox folders.
2647 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2648 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2649 only use this (internally) now for the non-outbox local folders.
2651 * src/modest-init.h:
2652 * src/modest-init.c: Added modest_init_one_local_folder(), for
2653 setting up the directory structure for each local folder.
2655 * src/modest-local-folder-info.c:
2656 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2657 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2659 * src/modest-local-folder-info.h:
2660 * src/modest-tny-account-store.c: (on_account_removed),
2661 (on_account_changed), (create_per_account_local_outbox_folders),
2662 (get_server_accounts), (modest_tny_account_store_get_accounts),
2663 (modest_tny_account_store_get_tny_account_by_account),
2664 (modest_tny_folder_store_is_virtual_local_folders):
2666 * src/modest-tny-account.h:
2667 * src/modest-tny-account.c:
2668 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2669 to create an on-disk per-account local outbox folder for each
2671 (create_per_account_local_outbox_folders): Create a local outbox folder
2672 for each transport account.
2673 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2674 for all local folders.
2676 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2677 instead of using g_object_get/set() directly. It is clearer.
2679 (modest_tny_folder_store_get_message_count),
2680 (modest_tny_folder_store_get_local_size
2681 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2682 because we now use these with non-acount folder stores.
2684 (modest_tny_account_get_special_folder),
2685 (modest_tny_account_new_from_server_account),
2686 (modest_tny_account_new_from_account):
2687 (recurse_folders): Adjust to the new outbox system.
2689 * src/modest-tny-folder.h:
2690 * src/modest-tny-folder.c:
2691 (modest_tny_folder_is_local_folder),
2692 (modest_tny_folder_get_local_folder_type),
2693 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2695 * src/widgets/modest-main-window.h:
2696 * src/maemo/modest-main-window.c: (create_details_widget),
2697 (modest_main_window_set_contents_style): Show details for any folder store,
2700 (modest_tny_folder_get_rules):
2701 Remove the const. C does not support constness enough for this.
2703 * src/modest-ui-actions.c:
2704 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2705 make all outboxes appear as one, in the usual local-folders tree node.
2707 (set_active_account_from_tny_account),
2708 (modest_ui_actions_on_folder_selection_changed):
2709 * src/widgets/modest-folder-view.c: (text_cell_data),
2710 (icon_cell_data), (filter_row),
2711 (add_account_folders_to_merged_folder),
2712 (add_account_folders_to_simple_folder_store), (),
2713 (get_cmp_rows_type_pos), (cmp_rows),
2714 (modest_folder_view_set_account_id_of_visible_server_account):
2715 Adjust to the new outbox system, using generic folder stores and folders
2716 in the GtkTreeModel.
2718 2007-05-23 Christian Kellner <ckellner@openismus.com>
2720 * src/modest-mail-operation.c:
2721 (modest_mail_operation_update_account):
2722 Use info->max_size instead of unintialized local var [small
2723 build fix]. (Added TODO to review that change since I don't
2726 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2728 * libmodest-dbus-client/libmodest-dbus-client.c:
2729 (libmodest_dbus_client_compose_mail): function added
2730 * src/dbus_api/modest-dbus-api.h:
2731 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2732 (on_compose_mail): Implementation of the SendAsMail functionality
2734 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2736 * src/modest-account-mgr.c:
2737 (modest_account_mgr_add_server_account): Set the secure-connection
2738 conf key for transport accounts as well as store accounts. I don't know
2739 why the if was there. For instance, this makes sure that we use SSL
2740 for the gmail preset from the easysetup wizard.
2742 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2744 * src/gnome/modest-main-window.c:
2745 (on_account_store_connecting_finished), (connect_signals):
2746 * src/maemo/modest-main-window.c:
2747 (on_account_store_connecting_finished), (connect_signals),
2748 (modest_main_window_new):
2749 Handle TnyAccountStore::connecting-finished instead of
2750 TnyDevice::connection-changed, because we cannot actually perform
2751 operations on accounts until TnyAccountStore has itself responded to
2752 the TnyDevice::connection-changed signal. This prevents a GError from
2754 Do not try to update at startup, because we (at least on scratchbox)
2755 already do an update at startup when the device goes online.
2756 This prevents a GError from tinymail.
2757 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2758 Added TODO about stopping simultaneous operations.
2760 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2762 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2763 * src/modest-mail-operation-queue.c:
2764 (modest_mail_operation_queue_remove):
2765 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2766 about where they happened.
2768 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2770 * src/modest-ui-actions.c:
2771 (modest_ui_actions_on_password_requested): Make sure that the remember
2772 output parameter is always TRUE.
2774 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2776 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2777 Show a OK/Cancel dialog if the error is a question, though we still do not
2778 know anything more about what we are asking the user.
2779 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2780 Fix an uninitialized variable (helper). This is a logic error, however.
2782 2007-05-21 Christian Kellner <ckellner@openismus.com>
2784 * src/modest-search.h:
2785 Correct bit shifting in the ModestSearchFlags enum.
2787 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2789 * src/modest-tny-account.c:
2790 (modest_tny_account_new_from_server_account): Do not use the lsub and
2791 check-all hard-coded IMAP options when using POP.
2793 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2795 * src/modest-tny-account.c:
2796 (modest_tny_account_new_from_server_account):
2797 Use NULL for the secure-auth method for POP when Password auth has been
2798 specified by the user, as we already do for IMAP. "auth=Login" causes
2799 an error from camel or the server.
2801 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2803 * src/maemo/modest-account-settings-dialog.c:
2804 (create_page_account_details),
2805 (modest_account_settings_dialog_set_account_name):
2806 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2807 for the leave-on-server checkbox, rathr than just the checkbox, when
2808 the protocol is not POP.
2810 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2812 * src/widgets/modest-account-view.c:
2813 * src/widgets/modest-account-view.h:
2814 Added modest_account_view_select_account() which will be useful later
2815 to asynchronously re-select the edited account.
2817 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2819 * src/maemo/modest-account-settings-dialog.c:
2820 (modest_account_settings_dialog_set_account_name):
2821 Automatically choose the port numbers based on the secure authentication
2822 methods, if they have not been chosen before.
2823 This fixes projects.maemo.org bug NB#56273 .
2825 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2827 * src/maemo/modest-main-window-ui.h:
2828 * src/modest-ui-actions.c:
2829 * src/modest-ui-actions.h:
2830 Connect the Tools/SMTP Servers menu item to
2831 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2832 SMTP servers dialog, as in the UI specification and saves changes when it
2833 is closed. This fixed projects.maemo.org bug NB#56305 .
2835 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2837 * src/maemo/modest-connection-specific-smtp-window.c:
2838 (modest_connection_specific_smtp_window_init):
2839 Use gtk_window_set_default_size() to make this window big enough, so
2840 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2842 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2844 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2845 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2846 (modest_connection_specific_smtp_edit_window_init),
2847 Do not try to connect to a combobox signal before the combobox exists.
2848 This fixes the cras in projects.maemo.org bug NB#56288 .
2849 (modest_connection_specific_smtp_edit_window_get_settings):
2850 Remove the server_account_name parameter which was being checked for NULL
2851 though it was not used.
2853 * src/maemo/modest-connection-specific-smtp-window.c:
2854 (modest_connection_specific_smtp_window_fill_with_connections),
2855 (on_button_edit), (modest_connection_specific_smtp_window_init):
2856 Correct the number of treemodel columns to prevent a warning.
2857 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2858 libconic does not work.
2860 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2862 * src/modest-tny-account.c:
2863 (modest_tny_account_new_from_server_account):
2864 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2865 SMTP when "None" was chosen by the user. However, with my SMTP server that
2866 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2869 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2871 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2872 to explain the memory management issue with the ID in the ModestPair.
2874 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2875 (add_sending_page), (modest_account_assistant_finalize):
2876 * src/gnome/modest-gnome-global-settings-dialog.c:
2877 (create_updating_page), (create_composing_page):
2878 * src/gnome/modest-msg-edit-window.c: (get_transports),
2879 (init_window), (modest_msg_edit_window_finalize),
2880 (modest_msg_edit_window_get_msg_data):
2881 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2882 * src/gnome/modest-transport-widget.c:
2883 (modest_transport_widget_finalize), (smtp_configuration):
2884 * src/maemo/modest-maemo-global-settings-dialog.c:
2885 (create_updating_page), (create_composing_page):
2886 * src/maemo/modest-msg-edit-window.c: (get_transports),
2887 (init_window), (modest_msg_edit_window_finalize),
2888 (modest_msg_edit_window_get_msg_data),
2889 (modest_msg_edit_window_free_msg_data):
2890 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2891 (modest_store_widget_finalize):
2892 * src/maemo/modest-transport-widget.c:
2893 (modest_transport_widget_finalize), (smtp_configuration):
2894 * src/modest-main.c: (send_mail):
2895 * src/widgets/modest-combo-box.h:
2896 * src/widgets/modest-global-settings-dialog-priv.h:
2897 * src/widgets/modest-global-settings-dialog.c:
2898 (modest_global_settings_dialog_finalize):
2899 * src/widgets/modest-msg-edit-window.h:
2900 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2901 as long as the combo box, to prevent use of freed memory for the ID.
2903 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2905 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2906 get_accounts(), to make this clearer. Do not check for the enabled gconf
2907 key, because we do not use this for server accounts (at least, not yet).
2908 This allows us to send email again.
2910 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2912 * src/maemo/modest-platform.c:
2913 (on_modest_conf_update_interval_changed), (modest_platform_init):
2914 Only respond to this particular key change. All these strcmp()s cannot be
2917 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2919 * src/maemo/modest-maemo-global-settings-dialog.c:
2920 (current_connection): Prevent a crash in scratchbox when
2921 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2922 * src/maemo/modest-platform.c:
2923 (on_modest_conf_update_interval_changed), (modest_platform_init):
2924 Get the update interval from gconf and reset it when the gconf key changes.
2926 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2928 * src/modest-protocol-info.c:
2929 * src/modest-protocol-info.h: Adde enum-specific get functions,
2930 instead of using a ModestProtocolType enum parameter.
2932 * src/gnome/modest-account-assistant.c:
2933 * src/gnome/modest-store-widget.c:
2934 * src/gnome/modest-store-widget.h:
2935 * src/gnome/modest-transport-widget.c:
2936 * src/gnome/modest-transport-widget.h:
2937 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2938 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2939 * src/maemo/easysetup/modest-easysetup-wizard.c:
2940 * src/maemo/modest-account-settings-dialog.c:
2941 * src/maemo/modest-account-settings-dialog.h:
2942 * src/maemo/modest-store-widget.c:
2943 * src/maemo/modest-store-widget.h:
2944 * src/maemo/modest-transport-widget.c:
2945 * src/maemo/modest-transport-widget.h:
2946 * src/modest-account-mgr-helpers.c:
2947 * src/modest-account-mgr-helpers.h:
2948 * src/modest-account-mgr.c:
2949 * src/modest-account-mgr.h:
2950 * src/modest-tny-account.c:
2951 * src/modest-tny-folder.c:
2952 * src/widgets/modest-account-view.c:
2953 * src/widgets/modest-retrieve-combo-box.c:
2954 * src/widgets/modest-retrieve-combo-box.h:
2955 * src/widgets/modest-secureauth-combo-box.c:
2956 * src/widgets/modest-serversecurity-combo-box.c:
2957 * src/widgets/modest-serversecurity-combo-box.h:
2958 * tests/check_account-mgr.c:
2959 Use the specific functions, and use the re-renamed enum values for GNOME too.
2961 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2963 * src/modest-pair.h:
2964 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2965 so we can get the second based on the first.
2967 * src/maemo/modest-account-settings-dialog.h:
2968 * src/maemo/modest-account-settings-dialog.c:
2969 Added get_supported_secure_authentication_methods(), though it is mostly
2970 commented-out for now until the necessary API is committed to tinymail.
2971 (modest_account_settings_dialog_set_account_name),
2972 (save_configuration): Request the supported authentication methods from the
2973 server, so we can choose a working method.
2975 * src/modest-tny-account-store.h:
2976 * src/modest-tny-account-store.c:
2977 (modest_tny_account_store_get_session): Rename from
2978 tny_account_store_get_session().
2980 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2982 * src/modest-protocol-info.h: Split the ModestProtocol enum
2983 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2984 There was no need to have these unrelated values in one enum.
2986 * src/: many files: Adapted to changed enum. This makes the code a bit
2987 clearer, and the compiler could catch some errors.
2989 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2991 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2992 Show the detailed internal camel error message when an error happens
2993 during the configuration, so that our testers can give us more clues.
2994 For instance, in projects.maemo.org bug NB#56910 .
2996 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2998 * src/modest-tny-account.c:
2999 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
3000 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
3002 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3004 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3005 * src/maemo/modest-account-settings-dialog.c:
3006 (modest_account_settings_dialog_set_account_name),
3007 (save_configuration): For the incoming secure authentication checkbox,
3008 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
3009 the UI specification. PLAIN does not seem to be supported for most IMAP
3010 servers anyway, and I am not sure what it would mean.
3011 However, we probably need to discover which of the secure-authentication
3012 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
3013 * src/modest-account-mgr-helpers.c:
3014 (modest_account_mgr_get_server_account_data):
3016 * src/modest-tny-account.c:
3017 (modest_tny_account_new_from_server_account):
3018 Use tny_account_set_mech() to set secure-authentication methods,
3019 with some special-casing for IMAP, based on my observations of how
3022 * src/modest-account-mgr-helpers.h:
3023 * src/modest-account-mgr.c:
3024 * src/modest-defs.h: Comment that the URI is only used for local folders.
3026 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3028 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
3029 parameter const, just to be neat.
3030 * src/modest-text-utils.c: (modest_text_utils_inline):
3031 End g_strconcat() with NULL, as its documentation says. This is almost
3032 certainly the cause of my crash at startup on the device. Interestingly,
3033 valgrind doesn't tell us about these errors.
3035 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3037 * scripts/build-packages: Added more precise comments about how to use
3038 this script, though I still get this error:
3039 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
3040 error building tinymail
3042 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3044 * src/maemo/modest-main-window.c: (on_account_update):
3045 Very slight cleanup, hoping to make it simpler to discover what causes
3046 a crash here sometimes.
3048 * src/modest-tny-account.c:
3049 (modest_tny_account_new_from_server_account): Set the port. Added
3050 comments about the options and a TODO comment because I need to find out
3051 how to specify the secure authentication method.
3053 2007-05-11 Marcus Bauer <marcusb@openismus.com>
3055 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3056 changed CFlags paths form modest to libmodest
3058 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3060 * src/modest-account-mgr-helpers.c:
3061 (modest_account_mgr_get_server_account_data),
3062 (modest_account_mgr_free_server_account_data):
3063 * src/modest-account-mgr-helpers.h:
3064 * src/modest-account-mgr.c:
3065 (modest_account_mgr_add_server_account):
3066 * src/modest-defs.h:
3067 * src/modest-tny-account.c:
3068 (modest_tny_account_new_from_server_account):
3069 Determine the options for tny_camel_account_add_option() here,
3070 based on the settings, rather than storing them directly in gconf.
3072 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3074 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3075 Show a more friendly error dialog now that we expect (from the tinymail
3076 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3078 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3080 * src/maemo/modest-main-window.c: (on_account_update): Check that
3081 account_name is not NULL, to prevent a crash at startup that I am
3082 seeing on the N800. I do wonder why it is NULL.
3084 * src/maemo/easysetup/modest-easysetup-wizard.c:
3085 (create_page_user_details):
3086 * src/maemo/modest-account-settings-dialog.c:
3087 (create_page_user_details), (create_page_outgoing):
3088 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3089 (modest_connection_specific_smtp_edit_window_init):
3090 * src/modest-ui-actions.c:
3091 (modest_ui_actions_on_password_requested):
3092 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3093 might do something useful with the on-screen keyboard.
3095 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3097 * src/maemo/modest-main-window.c: (on_account_update):
3098 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3099 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3101 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3103 * src/modest-tny-account-store.c: (on_account_changed):
3104 Correct the signature of this signal handler.
3106 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3108 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3109 Show a HildonNote instead of a GtkDialog for Maemo.
3111 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3113 * src/widgets/modest-account-view.h:
3114 * src/widgets/modest-account-view.c: (on_account_changed),
3115 (on_account_removed). Added a boolean flag, set/unset by
3116 modest_account_view_block_conf_updates(),
3117 modest_account_view_unblock_conf_updates() to prevent unnecessary
3118 updates, but this is not very useful because the gconf notifications are
3119 so delays (maybe only on Maemo Bora).
3120 So auto-updating is turned off, and these functions do an explicit
3121 update when necessary.
3122 However, something else is still doing too much work when adding/removing
3123 accounts, probably in another part of the application.
3125 * src/maemo/modest-account-view-window.c:
3126 (on_delete_button_clicked), (on_edit_button_clicked),
3127 (on_new_button_clicked): Use the new functions.
3129 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3131 * src/modest-account-mgr-helpers.c:
3132 (modest_account_mgr_set_first_account_as_default):
3133 Sort the list of names alphabetically-by-title, so we choose the first one
3135 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3136 alphabetically by the title.
3138 This fixes projects.maemo.org bug NB#56418 .
3140 * src/modest-account-mgr-priv.c:
3141 (_modest_account_mgr_account_from_key):
3142 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3143 avoid a valgrind error, and possible random behaviour.
3145 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3147 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3148 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3149 tinymail documentation to say that this can be expected.
3150 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3151 pretty, and should not happen, but I would prefer to know when it does.
3153 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3155 * configure.ac: When using the older hildon version, probably on Bora,
3156 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3158 * src/widgets/modest-attachment-view.c:
3159 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3162 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3164 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3165 Implemented the prototype. Can be tested with
3166 tests/dbus_api/test_open_message:
3168 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3170 * src/modest-tny-account-store.c:
3171 (modest_tny_account_store_instance_init), (get_password):
3172 * src/modest-ui-actions.c:
3173 (modest_ui_actions_on_password_requested):
3174 Do not store the password in gconf, because this function is called
3175 for non-remembered passwords. Actually use the cached (in the hash map)
3176 password instead of releasing it.
3177 The password will now not be remembered if it is asked via the protected
3178 password dialog, as per the UI spec.
3180 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3182 * src/modest-defs.h:
3183 * src/modest-account-mgr-helpers.h:
3184 * src/modest-account-mgr-helpers.c:
3185 Added modest_server_account_get_username_has_succeeded(),
3186 modest_server_account_set_username_has_succeeded().
3187 (modest_server_account_set_username),
3188 Reset the has-succeeded flag if the username changes.
3190 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3191 * src/maemo/modest-connection-specific-smtp-window.c:
3192 (modest_connection_specific_smtp_window_save_server_accounts):
3193 Use modest_server_account_set_username() instead of using
3194 modest_conf_set_string() directly, so that the has-succeeded flag is always
3197 * src/modest-ui-actions.c:
3198 (modest_ui_actions_on_password_requested): Dim the username entry if
3199 the username has ever worked, as per the UI spec.
3201 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3203 * src/modest-tny-account-store.c: (get_password):
3204 * src/modest-ui-actions.c:
3205 (modest_ui_actions_on_password_requested):
3206 Allow the username to be changed too, though there is more work to
3207 be done on exactly how this behaves.
3209 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3211 * src/modest-account-mgr-helpers.h:
3212 * src/modest-account-mgr-helpers.c:
3213 Added modest_account_mgr_get_display_name(),
3214 modest_server_account_get_username(),
3215 modest_server_account_set_username(),
3216 modest_server_account_set_password(),
3217 modest_server_account_get_hostname() functions so we do not need to
3218 use the conf API directly.
3220 * src/maemo/modest-main-window.c: (connect_signals):
3221 Actually connect ot the ModestAccountStore::request-password signal,
3222 so that we show the dialog when the password is requested by Tinymail,
3223 for isntance if it is empty.
3225 * src/modest-marshal.list:
3226 * src/modest-tny-account-store.c:
3227 (modest_tny_account_store_class_init), (get_password),
3228 (modest_tny_account_store_alert):
3229 * src/modest-tny-account-store.h:
3230 * src/modest-ui-actions.h:
3231 * src/modest-ui-actions.c:
3232 (modest_ui_actions_on_password_requested):
3233 Change the signal parameters, so it is obvious that we are providing
3234 the non human-readable server name, and receiving both the username
3235 and password, though changing of the username is not yet implemented.
3236 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3237 for the GNOME version.
3239 This should fix the projects.maemo.org bug NB#56209, though it does not
3240 work on Bora, because the gconf_client_get() for the password fails
3241 immediately after we save it with gconf_client_set().
3243 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3246 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3247 caused an undefined symbol error:
3248 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3250 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3252 * src/modest-tny-account-store.c:
3253 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3254 using a GError instead of a string message, so we can translate it in
3257 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3259 * src/maemo/modest-address-book.c:
3260 (modest_address_book_check_names):
3261 * src/maemo/modest-msg-view-window.c:
3262 (modest_msg_view_window_clipboard_owner_change):
3263 * src/modest-init.c: (modest_init_init_ui):
3264 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3265 (update_folders_cb), (modest_mail_operation_update_account):
3266 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3267 (modest_ui_actions_on_msg_attachment_clicked),
3268 (modest_ui_actions_on_msg_recpt_activated):
3269 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3270 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3271 (modest_msg_view_search_next):
3272 * src/widgets/modest-recpt-editor.c:
3273 (modest_recpt_editor_on_button_release_event),
3274 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3275 g_message(). At this point we should only be seeing interesting errors on
3276 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3278 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3280 (modest_wizard_dialog_force_title_update):
3281 * src/maemo/easysetup/modest-wizard-dialog.h:
3282 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3283 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3284 can update the title when appropriate. Otherwise the title is wrong if the
3285 pages are added after adding the notebook to the dialog.
3286 This must be a problem in HildonWizardDialog too.
3287 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3289 * src/maemo/easysetup/modest-easysetup-wizard.c:
3290 (create_subsequent_customsetup_pages),
3291 (create_subsequent_easysetup_pages):
3292 Call modest_wizard_dialog_force_title_update() so that the title is
3293 correct even with GTK+ < 2.10.
3294 This fixes projects.maemo.org bug NB#56145 .
3296 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3298 * src/maemo/modest-platform.c:
3299 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3300 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3303 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3305 * src/widgets/modest-window.h:
3306 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3307 and modest_window_save_state(), which invokes it.
3309 * src/widgets/modest-window-mgr.h:
3310 * src/widgets/modest-window-mgr.c:
3311 Added modest_window_mgr_save_state_for_all_windows(), which calls
3312 the save_state vfunc on all registered windows, if implemented.
3314 * src/gnome/modest-msg-edit-window.c:
3315 * src/gnome/modest-msg-view-window.c:
3316 * src/maemo/modest-msg-edit-window.c:
3317 * src/maemo/modest-msg-view-window.c:
3318 * src/maemo/modest-main-window.c:
3319 Specify the existing save_settings functions as implementations of
3320 ModestWindow::save_state_func().
3322 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3323 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3324 enabling hibernation, for instance.
3326 We may need to do the same thing for restoring settings.
3329 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3331 * src/widgets/modest-window-mgr.c:
3332 * src/widgets/modest-window-mgr.h:
3333 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3334 modest_window_mgr_get_hibernation_is_prevented().
3336 * src/maemo/modest-main-window.c:
3337 (on_hildon_program_is_topmost_notify): Prevent hibernation
3338 (possible when the application goes to the background in the WM),
3339 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3341 * src/maemo/easysetup/modest-easysetup-wizard.c:
3342 (modest_easysetup_wizard_dialog_init):
3343 * src/maemo/modest-account-settings-dialog.c:
3344 (modest_account_settings_dialog_init):
3345 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3346 (modest_connection_specific_smtp_edit_window_init):
3347 * src/maemo/modest-connection-specific-smtp-window.c:
3348 (modest_connection_specific_smtp_window_init):
3349 * src/maemo/modest-signature-editor-dialog.c:
3350 (modest_signature_editor_dialog_init):
3351 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3352 prevent hibernation while any of these account settings dialogs are open.
3354 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3356 * src/maemo/Makefile.am:
3357 * src/maemo/modest-osso-state-saving.c:
3358 * src/maemo/modest-osso-state-saving.h: Added
3359 modest_osso_load_state() and modest_osso_save_state() though they do
3360 nothing now. They should iterate through all the open windows and load/save
3362 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3363 save state when closing.
3365 * src/maemo/modest-main-window.c:
3366 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3367 Add a notification handler for the HildonProgram::is-topmost property,
3368 so we can allow hibernation when the application goes into the background.
3369 But we still need to detect when the accounts setup windows are open so
3370 we can stop hibernation when they are open.
3371 To do this, I also added the main window the HildonProgram. This might have
3372 other side-effects/benefits, and should maybe be done for other windows.
3374 * src/maemo/modest-osso-autosave-callbacks.h:
3375 * src/maemo/modest-osso-autosave-callbacks.c:
3376 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3377 though it does not do anything yet, and we might never need this to do
3378 anything. For instance, we already save drafts.
3380 * src/maemo/modest-platform.c: (modest_platform_init):
3381 Specify the libosso auto-save callback.
3383 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3385 * src/maemo/modest-platform.c:
3386 (modest_platform_set_update_interval):
3387 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3388 aparently stays valid between application instances, so we can use this
3389 to remove and reset it later. According to a maemo-developers email from
3392 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3394 * configure.ac: Depend on libalarm for Maemo.
3396 * src/dbus_api/modest-dbus-api.h:
3397 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3398 (on_send_receive), (modest_dbus_req_handler):
3399 Handle a SEND_RECEIVE D-Bus method.
3401 * libmodest-dbus-client/libmodest-dbus-client.c:
3402 (libmodest_dbus_client_send_and_receive):
3403 * libmodest-dbus-client/libmodest-dbus-client.h:
3404 Add C convenience functions for calling the new D-Bus method.
3406 * src/modest-platform.h:
3407 * src/gnome/modest-platform.c:
3408 * src/maemo/modest-platform.c:
3409 Added modest_platform_set_update_interval(), which uses the
3410 alarmd API on Maemo.
3411 (modest_platform_init),
3412 Call modest_platform_set_update_interval(), using a hard-coded
3413 interval for now (until the global settings dialog is implemented),
3414 though I am not sure that this makes sense yet.
3416 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3418 * src/dbus_api/modest-dbus-callbacks.c:
3419 (modest_osso_cb_hw_state_handler):
3420 * src/dbus_api/modest-dbus-callbacks.h:
3421 * src/maemo/modest-platform.c: (modest_platform_init):
3422 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3423 in case this has some effect on the ability for Maemo to ping the
3426 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3428 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3429 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3430 warning. It is probably a logic error, but I need to fix the build.
3432 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3434 * src/modest-account-mgr.h:
3435 * src/modest-account-mgr.c:
3436 (modest_account_mgr_account_names): Add a gboolean enabled_only
3437 parameter, so we can get lists of onlt the enabled accounts.
3439 (modest_account_mgr_add_account),,
3440 (modest_account_mgr_account_with_display_name_exists):
3441 * src/maemo/modest-msg-edit-window.c: (get_transports):
3442 * src/modest-account-mgr-helpers.c:
3443 (modest_account_mgr_set_first_account_as_default):
3444 * src/modest-init.c: (init_default_account_maybe):
3445 * src/modest-tny-account-store.c: (get_accounts):
3446 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3447 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3448 * tests/check_account-mgr.c: (START_TEST):
3449 Provide the extra parameter, as appropriate.
3451 * src/widgets/modest-account-view.c: (update_account_view):
3452 Do not show disabled accounts (meaning that there is no way to
3453 enable/disable accounts in the UI (the feature is not in our UI
3454 specification), so we can use this internally only to mark unfinished
3455 or temporary account data.
3457 * src/maemo/easysetup/modest-easysetup-wizard.c:
3458 (create_account): Add boolean enable parameter, so we can specify FALSE
3459 to create the temporary account.
3460 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3461 (on_before_next): When finishing, when there is a temporary account, just
3463 Also, use a timeout to delay the showing of the dialog until gconf is likely
3464 to return correct information, due to a maemo gconf bug that is fixed in
3465 osso 1.1, but not yet in Bora.
3466 However, the dialog stays on screen after it is destroyed.
3468 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3469 for invalid data when cancelling. Use a hildon note instead of a dialog
3470 to complain about invalid data. Do not show the account-saved note if the
3471 account is disabled (a temporary account that will not really be saved for use
3474 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3476 * src/modest-account-mgr-helpers.h:
3477 * src/modest-account-mgr-helpers.c:
3478 Added modest_account_mgr_unset_default_account(),
3479 Added modest_account_mgr_set_first_account_as_default().
3481 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3482 If it was the default account, unset the default account name.
3484 * src/maemo/modest-account-view-window.c:
3485 (on_delete_button_clicked): If it was the default account,
3486 set the first remaining account as the default instead.
3488 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3489 a NULL account or a NULL default account, to prevent a crash. This should
3490 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3493 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3495 * src/widgets/modest-recpt-editor.c:
3496 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3497 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3498 TODO comment for this. This fixes the build.
3500 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3501 be the best place for it. This will in future update all auto-update accounts,
3502 rather than just the current/default account, when that gconf key exists.
3503 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3504 if there are no accounts, before calling do_send_receive().
3505 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3507 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3508 * src/maemo/modest-main-window-ui.h:
3509 * src/maemo/modest-main-window.c: (on_connection_changed),
3510 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3511 directly, becaue the signal handler does more.
3513 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3515 * src/modest-account-mgr-helpers.c:
3516 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3517 for the case that the account does not exist.
3519 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3520 (equivalent to the modest account name) rather than the tinymail account name
3521 (equivalent to the modest account title - human readable) to get the account data.
3522 Check for null account data to prevent the crash, and add a TODO comment saying that
3523 this needs fixing because it is using the server account name instead of the account name.
3525 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3527 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3528 * src/maemo/modest-account-settings-dialog.c: (show_error),
3530 Use hildon_note_new_information() for informative and error messages,
3531 which seems to be expected for Maemo applications (no documentation that I know of
3532 says this). I am surprised that there is no distinction between info and error
3535 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3537 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3538 it is easy to find where this is used.
3540 * src/maemo/easysetup/modest-easysetup-wizard.c:
3541 (create_page_welcome), (create_page_account_details),
3542 (create_page_user_details), (create_page_complete_easysetup),
3543 (create_page_custom_incoming), (create_page_custom_outgoing),
3544 (create_page_complete_custom):
3545 * src/maemo/modest-account-settings-dialog.c:
3546 (create_page_account_details), (create_page_user_details),
3547 (create_page_incoming), (create_page_outgoing):
3548 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3549 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3550 (modest_connection_specific_smtp_edit_window_init):
3551 * src/maemo/modest-connection-specific-smtp-window.c:
3552 (modest_connection_specific_smtp_window_init):
3553 * src/maemo/modest-signature-editor-dialog.c:
3554 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3555 and scrolling policy as per the Email Application Layout Guide, if I have
3558 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3560 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3561 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3562 which were empty, because these vfuncs have been removed from TnyAccountStore.
3563 This fixes the build.
3565 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3567 * src/maemo/modest-main-window.c:
3568 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3569 showing/hiding it. Added TODO because it probably should not be NULL.
3570 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3571 because unnecessary g_warnings() make degugging difficult.
3573 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3575 * src/maemo/modest-msg-edit-window.c:
3576 (modest_msg_edit_window_select_color),
3577 (modest_msg_edit_window_select_background_color): 2 const corrections and
3578 moving 2 #endifs before closing brackets, to fix the build.
3580 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3582 * src/maemo/easysetup/modest-easysetup-wizard.h:
3583 * src/maemo/easysetup/modest-easysetup-wizard.c:
3584 (modest_easysetup_wizard_dialog_finalize),
3585 (on_button_edit_advanced_settings), (create_page_complete_custom),
3586 (on_response), (create_account):
3587 Implement the Advanced Settings edit button, by saving the account information,
3588 for the Advanded Settings dialog to use directly from gconf, and removing it
3589 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3590 Bug #5533 in the projects.maemo.org bugzilla.
3592 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3594 * src/maemo/modest-msg-view-window.c:
3595 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3596 when opening a message window.
3598 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3600 * src/maemo/easysetup/modest-easysetup-wizard.c:
3601 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3604 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3605 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3606 gconf settings. I probably added more checks than necessary, but that is safer.
3608 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3609 variable to fix the build, but this seems to be used when it is still NULL.
3611 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3613 * src/modest-platform.h:
3614 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3615 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3616 * src/modest-main.c: Implement this function so we can avoid using
3617 maemo-specific API from cross-platform code.
3619 * src/modest-tny-account-store.c:
3620 (get_smtp_specific_transport_account_for_open_connection):
3621 * src/modest-ui-actions.c: (check_for_connection),
3622 (modest_ui_actions_on_item_not_found):
3623 Use modest_platform_connect_and_wait() and put #idefs around other
3624 maemo-specific code, because only maemo currently has a way to
3625 identify connection names.
3627 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3629 * src/modest-tny-account-store.h:
3630 * src/modest-tny-account-store.c:
3631 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3632 the connection-specific SMTP server settings in the configuration.
3634 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3636 * src/maemo/modest-main-window.c: (on_connection_changed),
3638 * src/modest-main.c: (main), (start_ui), (send_mail):
3639 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3640 that is what is intended.
3642 * src/modest-ui-actions.c: (action_send), (action_receive),
3643 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3644 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3645 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3646 SMTP server is used when it is specified.
3648 (modest_ui_actions_on_send_receive):
3649 Check that a connection is open before proceeding.
3650 Receive and then send, instead of vice-versa, as per the specification.
3652 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3654 * src/modest-mail-operation.c:
3655 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3656 though I guess it should be something other than NULL.
3658 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3660 * src/maemo/easysetup/modest-easysetup-wizard.c:
3661 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3662 combo twice, to avoid an g_warning and to make it visible again.
3663 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3664 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3665 (already intended) dereference when detaching, because we then recreate the menu.
3666 But I am not sure why the warning was happening, and it is possible that this is a memory
3669 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3671 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3672 and uri_parse_mailto() utility functions.
3673 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3675 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3677 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3679 * src/dbus_api/modest-dbus-api.h:
3680 * src/dbus_api/modest-dbus-callbacks.c:
3681 Use an idle callback to execute the modest code in the application's own thread.
3682 Remove the helloworld example method.
3683 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3684 parsed, and the open-message method is not implemented because this is not yet implemented in
3686 * libmodest-dbus-client/libmodest-dbus-client.c:
3687 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3688 (libmodest_dbus_client_open_message):
3689 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3691 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3692 body without crashing.
3694 * tests/dbus_api/Makefile.am:
3695 * tests/dbus_api/test_mail_to.c:
3696 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3698 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3700 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3701 Added file to fix the build. Sorry.
3703 * src/dbus_api/Makefile.am:
3704 * src/dbus_api/modest-dbus-api.h:
3705 * src/dbus_api/modest-dbus-callbacks.h:
3706 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3707 (modest_dbus_req_handler):
3708 Put constants in a separate header so it can be reused by the
3709 client library, without duplication
3711 * libmodest-dbus-client/Makefile.am:
3712 * libmodest-dbus-client/libmodest-dbus-client.c:
3713 (libmodest_dbus_client_call_helloworld),
3714 (libmodfest_dbus_client_send_mail),
3715 (libmodfest_dbus_client_mailto),
3716 (libmodfest_dbus_client_open_message):
3717 * libmodest-dbus-client/libmodest-dbus-client.h:
3718 (Partly) Implement a send_mail D-Bus method.
3720 * tests/dbus_api/Makefile.am:
3721 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3722 the send_email D-Bus method.
3724 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3728 * libmodest-dbus-client/Makefile.am:
3729 * libmodest-dbus-client/libmodest-dbus-client.c:
3730 * libmodest-dbus-client/libmodest-dbus-client.h:
3731 * tests/dbus_api/Makefile.am:
3732 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3733 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3735 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3737 * src/maemo/easysetup/modest-easysetup-wizard.c:
3738 (create_page_account_details):
3739 * src/maemo/modest-account-settings-dialog.c:
3740 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3741 widgets, because this might not be the default in future versions of the Maemo GTK+.
3742 However, I can not not get capitalization to work even in a simple test case.
3744 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3746 * src/maemo/easysetup/modest-easysetup-wizard.c:
3747 (create_page_custom_incoming), (create_page_custom_outgoing):
3748 * src/maemo/modest-account-settings-dialog.c:
3749 (create_page_account_details), (create_page_incoming),
3750 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3751 instead of using gtk_check_button_with_label(), so they are aligned like the other
3752 widgets, as per the UI spec.
3754 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3756 * src/maemo/easysetup/modest-easysetup-wizard.c:
3757 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3758 * src/widgets/modest-validating-entry.c:
3759 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3760 Modest prefix instead of an EasySetup prefix.
3762 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3764 * src/widgets/modest-validating-entry.h:
3765 * src/widgets/modest-validating-entry.c: (on_insert_text),
3766 Added easysetup_validating_entry_set_max_func(), used to set a callback
3767 to call when the max number of characters is reached. GtkEntry has a max-length
3768 already but is silent about it.
3770 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3771 (create_page_account_details), (create_page_user_details),
3773 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3774 (create_page_account_details), (create_page_user_details),
3775 (create_page_outgoing):
3776 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3777 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3778 the UI spec, when the user tries to enter more than the max number of characters.
3780 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3782 * src/maemo/easysetup/modest-easysetup-wizard.c:
3783 (create_page_user_details), (create_page_custom_incoming),
3784 (create_page_custom_outgoing):
3785 * src/maemo/modest-account-settings-dialog.c:
3786 (create_page_user_details), (create_page_incoming),
3787 (create_page_outgoing):
3788 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3789 (modest_connection_specific_smtp_edit_window_init):
3790 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3791 not appropriate. Bad Maemo-specific defaults!.
3793 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3795 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3796 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3797 (modest_signature_editor_dialog_set_settings):
3798 Disable the label and textview when the checkbox is disabled, and use the
3799 specified (UI spec) default signature text.
3801 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3803 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3804 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3806 * src/modest-defs.h:
3807 * src/modest-account-mgr-helpers.h:
3808 * src/modest-account-mgr-helpers.c:
3809 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3811 * src/maemo/Makefile.am:
3812 * src/maemo/modest-signature-editor-dialog.c:
3813 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3816 * src/maemo/modest-account-settings-dialog.h:
3817 * src/maemo/modest-account-settings-dialog.c:
3818 (modest_account_settings_dialog_finalize), (on_button_signature),
3819 (save_configuration): Use the new dialog when the Edit button is pressed, and
3820 save the changes if necessary, as per the UI spec.
3822 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3824 * src/maemo/Makefile.am:
3825 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3826 based on maemo-develoers email from Dirk.
3828 * src/maemo/easysetup/modest-easysetup-wizard.c:
3829 (create_page_welcome), (create_page_account_details),
3830 (create_page_user_details), (create_page_complete_easysetup),
3831 (create_page_custom_incoming), (create_page_custom_outgoing),
3832 (create_page_complete_custom),
3833 (modest_easysetup_wizard_dialog_init):
3834 * src/maemo/modest-account-settings-dialog.c:
3835 (create_page_account_details), (create_page_user_details),
3836 (create_page_incoming), (create_page_outgoing),
3837 (modest_account_settings_dialog_init):
3838 * src/maemo/modest-connection-specific-smtp-window.c:
3839 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3841 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3843 * src/maemo/easysetup/modest-easysetup-wizard.c:
3844 (create_page_account_details), (create_page_custom_outgoing),
3845 (create_page_complete_custom):
3846 * src/maemo/modest-account-settings-dialog.c:
3847 (create_page_user_details), (create_page_incoming),
3848 (create_page_outgoing):
3849 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3850 (modest_connection_specific_smtp_edit_window_init):
3851 Use the correct (UI spec) port min/max, and use horizontal separators,
3854 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3856 * src/maemo/easysetup/modest-easysetup-wizard.c:
3857 (set_default_custom_servernames):
3858 * src/maemo/modest-account-settings-dialog.c:
3859 (create_page_incoming), (on_combo_outgoing_security_changed),
3860 (on_combo_incoming_security_changed), (create_page_outgoing),
3861 (modest_account_settings_dialog_set_account_name),
3862 (save_configuration):
3863 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3864 (on_combo_security_changed),
3865 (modest_connection_specific_smtp_edit_window_init),
3866 (modest_connection_specific_smtp_edit_window_set_connection),
3867 (modest_connection_specific_smtp_edit_window_get_settings):
3868 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3871 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3874 * src/maemo/easysetup/modest-easysetup-wizard.c:
3875 (create_page_custom_outgoing), (create_page_complete_custom):
3876 * src/maemo/modest-account-settings-dialog.c:
3877 (create_page_user_details), (create_page_outgoing):
3878 * src/maemo/modest-account-view-window.c: (button_box_new):
3879 Use changed logical IDs as per the most recent UI spec:
3880 mcen_bd_emailsetup_edit -> mcen_bd_edit
3881 mcen_bd_emailsetup_delete -> mcen_bd_delete
3882 mcen_bd_emailsetup_close -> mcen_bd_close
3884 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3888 * src/dbus_api/Makefile.am:
3889 * src/dbus_api/modest-dbus-callbacks.c:
3890 * src/dbus_api/modest-dbus-callbacks.h:
3891 * src/maemo/modest-platform.c: (modest_platform_init):
3892 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3894 * tests/Makefile.am:
3895 * tests/dbus_api/Makefile.am:
3896 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3898 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3900 * src/maemo/modest-account-settings-dialog.c:
3901 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3902 Removed unnecessary includes.
3904 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3906 * src/maemo/easysetup/modest-easysetup-wizard.c:
3907 * src/maemo/modest-account-settings-dialog.c:
3908 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3909 * src/widgets/Makefile.am:
3910 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3911 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3912 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3913 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3914 * src/widgets/modest-secureauth-combo-box.c:
3915 * src/widgets/modest-secureauth-combo-box.h:
3916 * src/widgets/modest-serversecurity-combo-box.c:
3917 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3918 made the GObject names more consistent with the rest of the Modest code.
3920 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3922 * src/maemo/easysetup/Makefile.am:
3923 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3924 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3925 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3926 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3927 * src/maemo/easysetup/modest-easysetup-wizard.c:
3928 * src/maemo/easysetup/modest-validating-entry.c:
3929 * src/maemo/easysetup/modest-validating-entry.h:
3930 * src/maemo/modest-account-settings-dialog.c:
3931 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3932 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3933 widgets/ because they are used outside of easysetup too. After checking in,
3934 svn will allow me to rename them too.
3936 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3938 * src/gnome/modest-msg-edit-window.c:
3939 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3940 linker error, to fix the build on the GNOME platform.
3941 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3942 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3943 ifdefed out to avoid a warning.
3945 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3947 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3948 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3949 some alternative for GTK+ 2.6.
3951 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3953 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3955 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3956 specified for EmailAccountsDialog in UI spec.
3958 * src/maemo/easysetup/modest-easysetup-wizard.c:
3959 * src/maemo/easysetup/modest-easysetup-wizard.h:
3960 * src/maemo/modest-account-settings-dialog.c:
3961 * src/maemo/modest-account-settings-dialog.h:
3962 Reuse a member window widget for the connection-specific SMTP server accounts,
3963 so we can tell it to create/save the accounts only if we actually save changes.
3965 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3966 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3967 (modest_connection_specific_smtp_edit_window_get_settings):
3968 Return a struct instance for temporarily remembering the entered data.
3970 * src/maemo/modest-connection-specific-smtp-window.h:
3971 * src/maemo/modest-connection-specific-smtp-window.c:
3972 (modest_connection_specific_smtp_window_finalize),
3973 (modest_connection_specific_smtp_window_fill_with_connections),
3975 (modest_connection_specific_smtp_window_save_server_accounts),
3976 (update_model_server_names): Do not actually save data until asked,
3977 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3979 (on_selection_changed),
3980 (modest_connection_specific_smtp_window_init): Disable the edit
3981 button when nothing is selected.
3983 * src/modest-account-mgr-helpers.c:
3984 * src/modest-account-mgr-helpers.h:
3985 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3988 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3990 * src/modest-account-mgr-helpers.h:
3991 * src/modest-account-mgr-helpers.c:
3992 (modest_account_mgr_get_unused_account_name),
3993 (modest_account_mgr_get_unused_account_display_name): Added these
3994 utility functions, to avoid code duplication.
3996 * src/maemo/easysetup/modest-easysetup-wizard.c:
3997 (create_page_account_details), (create_account):
3998 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3999 (on_combo_security_changed),
4000 (modest_connection_specific_smtp_edit_window_init),
4001 (modest_connection_specific_smtp_edit_window_save_settings):
4002 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4003 * src/maemo/modest-connection-specific-smtp-window.c:
4004 (modest_connection_specific_smtp_window_finalize),
4005 (modest_connection_specific_smtp_window_fill_with_connections),
4006 (on_button_edit), (modest_connection_specific_smtp_window_init):
4007 * src/maemo/modest-connection-specific-smtp-window.h:
4008 Implementing saving of connection-specific server accounts.
4010 But I need to refactor this so we can save the data for each
4011 possible connection-specific account and only actually create the server accounts
4012 when the easysetup finished, or the OK button is pressed on the account settings
4015 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4017 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4018 (on_combo_security_changed):
4019 (modest_connection_specific_smtp_edit_window_init):
4020 Auto-fill the port number as in the account settings.
4022 (modest_connection_specific_smtp_edit_window_set_connection):
4023 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4024 * src/maemo/modest-connection-specific-smtp-window.c:
4025 (fill_with_connections), (on_button_edit),
4026 (modest_connection_specific_smtp_window_init):
4027 Turn the edit window into a dialog to simplify the code, and
4028 set a WM hint as in a GtkDialog, because only a popup can be on top of
4029 another window in Maemo, and popups usually have no WM decoration.
4031 * src/modest-defs.h:
4032 * src/modest-account-mgr-helpers.c:
4033 (modest_account_mgr_set_connection_specific_smtp),
4034 (modest_account_mgr_remove_connection_specific_smtp),
4035 (modest_account_mgr_get_connection_specific_smtp):
4036 * src/modest-account-mgr-helpers.h: Some functions to write the
4037 connection-specific SMTP server information. Not yet used.
4040 * src/widgets/modest-folder-view.c: (text_cell_data):
4041 Fix a warning about an uninitialized variable.
4042 (on_configuration_key_changed): Put an #ifdef around the use
4043 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
4045 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4047 * src/maemo/modest-account-settings-dialog.h:
4048 * src/maemo/modest-account-settings-dialog.c:
4049 Added connect_for_modified() utility function to mark the new modified boolean.
4051 (create_page_account_details), (create_page_user_details),
4052 (create_page_incoming), (create_page_outgoing), (on_response),
4053 (modest_account_settings_dialog_init),
4054 (modest_account_settings_dialog_set_account_name):
4055 Only warn about unsaved changes when there are actually unsaved changes.
4057 * src/modest-account-mgr-helpers.c:
4058 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
4059 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
4060 to get the data from there in future.
4062 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4064 * src/modest-defs.h:
4066 * src/modest-account-mgr-helpers.h:
4067 * src/modest-account-mgr-helpers.c:
4068 Store the security account setting in a single conf key instead of using
4069 the options list, so that the list is left for just the to-be-removed camel hack,
4070 and because gconf_client_set_list() is failing for some reason.
4072 * src/modest-account-mgr.c:
4073 (modest_account_mgr_add_server_account):
4074 * src/maemo/modest-account-settings-dialog.c:
4075 (modest_account_settings_dialog_set_account_name),
4076 (save_configuration): Use the renamed functions.
4079 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4081 * src/widgets/Makefile.am:
4082 * src/widgets/modest-limit-retrieve-combo-box.c:
4083 * src/widgets/modest-limit-retrieve-combo-box.h:
4084 * src/widgets/modest-retrieve-combo-box.c:
4085 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4086 the account settings dialog.
4088 * src/modest-defs.h:
4089 * src/modest-account-mgr-helpers.h:
4090 * src/modest-account-mgr-helpers.c:
4091 (modest_server_account_get_option_secure_auth),
4092 (modest_server_account_set_option_secure_auth):
4093 * src/modest-account-mgr.c:
4094 (modest_account_mgr_add_server_account):
4095 Use the existing AUTH_MECH conf key for the secure-auth setting,
4096 instead of putting it in the list options, because this was actually used already.
4098 * src/maemo/modest-account-settings-dialog.c:
4099 (create_page_account_details),
4100 (modest_account_settings_dialog_set_account_name),
4101 (save_configuration):
4102 * src/maemo/modest-account-settings-dialog.h:
4103 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4104 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4106 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4108 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4109 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4110 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4112 * src/modest-defs.h:
4113 * src/maemo/modest-account-settings-dialog.c:
4114 (create_page_incoming), (on_combo_outgoing_security_changed),
4115 (on_combo_incoming_security_changed), (create_page_outgoing),
4116 (modest_account_settings_dialog_set_account_name),
4117 (save_configuration): Load/Save the port number, and change it when the
4118 security combo changes, to suitable defaults.
4120 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4122 * src/modest-account-mgr.c:
4123 (modest_account_mgr_add_server_account): Set the security and secure-auth
4124 options, and add a comment saying that the other camel-specific options should be
4127 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4129 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4131 * src/modest-tny-account-store.c: (account_list_free),
4132 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4133 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4136 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4138 * src/modest-protocol-info.c:
4139 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4140 is required by our UI spec. Maybe something in our implementation will use this eventually.
4141 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4142 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4143 instead of the previous 0 placeholder.
4145 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4146 secure-auth settings.
4147 * src/modest-account-mgr-helpers.h:
4148 * src/modest-account-mgr-helpers.c:
4149 (modest_server_account_data_get_option_secure_auth),
4150 (modest_server_account_set_option_secure_auth),
4151 (modest_server_account_data_get_option_security),
4152 (modest_server_account_set_option_security): Added this API for getting and setting the security
4153 and secure-auth settings.
4155 * src/maemo/modest-account-settings-dialog.h:
4156 * src/maemo/modest-account-settings-dialog.c:
4157 (modest_account_settings_dialog_finalize), (check_data),
4158 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4159 about changing titles.
4160 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4161 (save_configuration): Save the security and secure-auth settings.
4163 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4164 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4166 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4168 * src/modest-defs.h:
4169 * src/modest-account-mgr.c:
4170 (modest_account_mgr_add_server_account):
4171 Added and used defines for the options key and value pair strings,
4172 that are used so far, though they do not seem to correspond to anything in our
4173 UI specs or ModestProtocol enum.
4175 * src/modest-account-mgr-helpers.h:
4176 * src/modest-account-mgr-helpers.c:
4177 (compare_option_strings_for_name),
4178 (modest_server_account_data_get_option_value),
4179 (modest_server_account_data_get_option_bool),
4180 (modest_account_mgr_get_server_account_option):
4181 Added helper functions for parsing the options GSList.
4183 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4185 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4186 display name is based on the supplied account name.
4187 * src/modest-account-mgr.c:
4188 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4189 with an inefficient, but good-enough, implementation.
4191 * src/maemo/easysetup/modest-easysetup-wizard.c:
4192 (create_page_account_details), (on_before_next), (create_account):
4193 Check for existing display names rather than (non-user-visible) account names, and just
4194 create and set a unique account name at the end.
4196 * src/maemo/modest-account-settings-dialog.c:
4197 (modest_account_settings_dialog_init),
4198 (modest_account_settings_dialog_set_account_name),
4199 (create_page_incoming): Show the display name, instead of the account name.
4200 (on_response): Do some (not all) extra checks, as in the UI spec.
4201 (save_configuration): Save the display name if it was changed.
4203 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4205 * po/en_GB.po: Added needed logical ID and translation.
4206 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4207 (init_view): Made the is-default column clicking work.
4209 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4212 * src/maemo/easysetup/Makefile.am:
4213 * src/maemo/easysetup/modest-easysetup-wizard.c:
4214 (modest_easysetup_wizard_dialog_init):
4215 * src/maemo/easysetup/provider-data-test.keyfile:
4216 * src/maemo/easysetup/provider-data.keyfile:
4217 Moved the provider data file to the new modest-providers-data package and used it from there.
4219 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4221 * src/modest-local-folder-info.c:
4222 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4223 N_() was already used on the static strings, but this just marks it for translation without
4224 using the translation.
4226 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4228 * src/maemo/modest-account-settings-dialog.c:
4229 (create_page_incoming),
4230 (modest_account_settings_dialog_set_account_name):
4231 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4232 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4233 I will do this if nobody else gets there first.
4235 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4237 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4238 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4239 save the security stuff.
4241 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4243 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4244 Set the email address and user fullname, which I now see must be
4247 * src/maemo/modest-account-settings-dialog.h:
4248 * src/maemo/modest-account-settings-dialog.c:
4250 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4251 leave-on-server and authentication.
4252 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4255 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4258 * src/maemo/modest-account-settings-dialog.c:
4259 * src/maemo/modest-account-settings-dialog.h:
4260 Most (but not all) of the widgets are now present as specified by the UI spec.
4261 No changes are yet saved, and some details are not properly shown yet.
4263 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4265 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4267 * src/maemo/Makefile.am:
4268 * src/maemo/modest-account-settings-dialog.c:
4269 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4270 an existing account. Doesn't do much yet.
4272 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4273 Open the accounts settings dialog when Edit is clicked.
4275 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4277 * src/maemo/easysetup/Makefile.am:
4278 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4280 * src/maemo/easysetup/modest-easysetup-wizard.c:
4281 (modest_easysetup_wizard_dialog_init):
4282 Try to get the source directory from the build system,
4283 instead of hard-coding "./" into the source code, when opening our local
4284 copies of the configuration files.
4285 But this still fails when opening the wizard from the Accounts window,
4286 maybe because the working directory seems to change at runtime.
4287 So the wizard will fail the second time unless you copy the files into their
4288 proper locations - see the stdout warnings for the paths.
4290 (create_page_account_details),(on_before_next):
4291 Check for existing non-server accounts instead of server accounts,
4292 so the default account name is useful again, and to prevent trying to
4295 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4296 Show the wizard when New is clicked.
4298 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4299 (init_view): Show the column headers, and show the columns that are
4300 specified in the UI specs. However, something in Maemo's GTK+ prevents
4301 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4302 change the default account. This is despite unsetting the special properties.
4304 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4306 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4307 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4308 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4309 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4310 to make that clearer.
4311 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4313 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4315 * src/maemo/modest-account-view-window.c:
4316 (modest_account_view_window_init),
4317 (modest_account_view_window_new):
4318 Use the same buttons as specified in the
4319 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4320 the existing widgets, which never had a chance of working.
4321 Put the ModestAccountView treeview in a scrolled window.
4322 Do not repeat the initialization in both _init() and _new().
4324 * src/widgets/modest-account-view.c: (update_account_view):
4325 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4326 this widget and window shows no accounts.
4328 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4330 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4332 * src/maemo/easysetup/modest-easysetup-wizard.c:
4333 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4334 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4335 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4338 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4339 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4340 accounts exist yet, as in the UI spec.
4342 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4344 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4346 * src/maemo/Makefile.am:
4347 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4348 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4349 New window for editing connection-specific smtp details.
4350 Not fully implemented.
4352 * src/maemo/modest-connection-specific-smtp-window.c:
4353 (modest_connection_specific_smtp_window_finalize) :
4354 unref the tree model.
4355 (on_button_edit): Show the edit window.
4357 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4359 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4362 * src/maemo/Makefile.am:
4363 * src/maemo/modest-connection-specific-smtp-window.c:
4364 * src/maemo/modest-connection-specific-smtp-window.h:
4365 New window for showing the list of connections, for connection-specific
4366 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4367 * src/maemo/easysetup/modest-easysetup-wizard.c:
4368 (create_page_custom_outgoing): Show the new window when the button is clicked.
4370 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4372 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4373 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4374 * src/maemo/modest-msg-edit-window.c:
4375 (modest_msg_edit_window_insert_image):
4376 * src/modest-conf.c: (modest_conf_key_escape):
4377 * src/modest-mail-operation.c:
4378 (modest_mail_operation_send_new_mail):
4379 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4380 (modest_ui_actions_on_new_account):
4381 * src/widgets/modest-attachment-view.c: (update_filename_request):
4382 * src/widgets/modest-mail-header-view.c:
4383 Corrected warnings that were breaking the build, by commenting out unused variables,
4384 and a function, and by including a header.
4386 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4388 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4389 so we can #ifdef around platform-specific code when necessary.
4390 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4391 to allow this to build for the GNOME platform too.
4393 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4395 * src/maemo/easysetup/modest-easysetup-wizard.c:
4396 Added util_increment_name() and used it in create_page_account_details()
4397 to make sure that the default account name is always a new name.
4399 (modest_easysetup_wizard_dialog_init),
4400 (set_default_custom_servernames): Some minor memory management fixes.
4402 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4406 * src/modest-runtime.c: (init_i18n): Restored the translation
4407 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4408 are defined in config.h, and the translations are installed.
4410 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4411 is defined for translation.
4413 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4415 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4417 * src/maemo/easysetup/modest-easysetup-wizard.c:
4418 (modest_easysetup_wizard_dialog_init):
4419 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4420 Use realistic paths (though they should use $prefix generically) to the
4421 mcc_mapping and provider-data.keyfile files which might work when they
4422 are installed by the future version of the operator-wizard package,
4423 and then fallback to paths in our source code, with an explanatory
4426 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4430 * src/maemo/Makefile.am:
4431 * src/maemo/easysetup/: Added files from the previously-exernal
4432 osso-modest-easysetup.
4433 * src/maemo/modest-main-window-ui.h:
4434 * src/modest-ui-actions.c:
4435 * src/modest-ui-actions.h:
4436 Added modest_ui_actions_on_new_account() as a signal handler for the
4437 New Account menu item. It shows the easysetup wizard.
4438 * po/en_GB.po: Added additional needed logical IDs and translations.