1 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
5 * src/modest-tny-account-store.c: (account_list_free),
6 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
7 cursor->data after unreffing it. But there is some strange stuff there so it might not be
10 2007-04-17 Murray Cumming <murrayc@murrayc.com>
12 * src/modest-protocol-info.c:
13 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
14 is required by our UI spec. Maybe something in our implementation will use this eventually.
15 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
16 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
17 instead of the previous 0 placeholder.
19 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
21 * src/modest-account-mgr-helpers.h:
22 * src/modest-account-mgr-helpers.c:
23 (modest_server_account_data_get_option_secure_auth),
24 (modest_server_account_set_option_secure_auth),
25 (modest_server_account_data_get_option_security),
26 (modest_server_account_set_option_security): Added this API for getting and setting the security
27 and secure-auth settings.
29 * src/maemo/modest-account-settings-dialog.h:
30 * src/maemo/modest-account-settings-dialog.c:
31 (modest_account_settings_dialog_finalize), (check_data),
32 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
33 about changing titles.
34 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
35 (save_configuration): Save the security and secure-auth settings.
37 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
38 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
40 2007-04-17 Murray Cumming <murrayc@murrayc.com>
43 * src/modest-account-mgr.c:
44 (modest_account_mgr_add_server_account):
45 Added and used defines for the options key and value pair strings,
46 that are used so far, though they do not seem to correspond to anything in our
47 UI specs or ModestProtocol enum.
49 * src/modest-account-mgr-helpers.h:
50 * src/modest-account-mgr-helpers.c:
51 (compare_option_strings_for_name),
52 (modest_server_account_data_get_option_value),
53 (modest_server_account_data_get_option_bool),
54 (modest_account_mgr_get_server_account_option):
55 Added helper functions for parsing the options GSList.
57 2007-04-16 Murray Cumming <murrayc@murrayc.com>
59 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
60 display name is based on the supplied account name.
61 * src/modest-account-mgr.c:
62 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
63 with an inefficient, but good-enough, implementation.
65 * src/maemo/easysetup/modest-easysetup-wizard.c:
66 (create_page_account_details), (on_before_next), (create_account):
67 Check for existing display names rather than (non-user-visible) account names, and just
68 create and set a unique account name at the end.
70 * src/maemo/modest-account-settings-dialog.c:
71 (modest_account_settings_dialog_init),
72 (modest_account_settings_dialog_set_account_name),
73 (create_page_incoming): Show the display name, instead of the account name.
74 (on_response): Do some (not all) extra checks, as in the UI spec.
75 (save_configuration): Save the display name if it was changed.
77 2007-04-16 Murray Cumming <murrayc@murrayc.com>
79 * po/en_GB.po: Added needed logical ID and translation.
80 * src/widgets/modest-account-view.c: (on_account_default_toggled),
81 (init_view): Made the is-default column clicking work.
83 2007-04-16 Murray Cumming <murrayc@murrayc.com>
86 * src/maemo/easysetup/Makefile.am:
87 * src/maemo/easysetup/modest-easysetup-wizard.c:
88 (modest_easysetup_wizard_dialog_init):
89 * src/maemo/easysetup/provider-data-test.keyfile:
90 * src/maemo/easysetup/provider-data.keyfile:
91 Moved the provider data file to the new modest-providers-data package and used it from there.
93 2007-04-16 Murray Cumming <murrayc@murrayc.com>
95 * src/modest-local-folder-info.c:
96 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
97 N_() was already used on the static strings, but this just marks it for translation without
98 using the translation.
100 2007-04-06 Murray Cumming <murrayc@murrayc.com>
102 * src/maemo/modest-account-settings-dialog.c:
103 (create_page_incoming),
104 (modest_account_settings_dialog_set_account_name):
105 Added comments about the need for new API in ModestAccountMgr to handle the authentication
106 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
107 I will do this if nobody else gets there first.
109 2007-04-06 Murray Cumming <murrayc@murrayc.com>
111 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
112 Saved much of the incoming and outgoing data too, though I cannot yet see how to
113 save the security stuff.
115 2007-04-06 Murray Cumming <murrayc@murrayc.com>
117 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
118 Set the email address and user fullname, which I now see must be
121 * src/maemo/modest-account-settings-dialog.h:
122 * src/maemo/modest-account-settings-dialog.c:
124 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
125 leave-on-server and authentication.
126 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
129 2007-04-06 Murray Cumming <murrayc@murrayc.com>
132 * src/maemo/modest-account-settings-dialog.c:
133 * src/maemo/modest-account-settings-dialog.h:
134 Most (but not all) of the widgets are now present as specified by the UI spec.
135 No changes are yet saved, and some details are not properly shown yet.
137 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
139 2007-04-06 Murray Cumming <murrayc@murrayc.com>
141 * src/maemo/Makefile.am:
142 * src/maemo/modest-account-settings-dialog.c:
143 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
144 an existing account. Doesn't do much yet.
146 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
147 Open the accounts settings dialog when Edit is clicked.
149 2007-04-05 Murray Cumming <murrayc@murrayc.com>
151 * src/maemo/easysetup/Makefile.am:
152 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
154 * src/maemo/easysetup/modest-easysetup-wizard.c:
155 (modest_easysetup_wizard_dialog_init):
156 Try to get the source directory from the build system,
157 instead of hard-coding "./" into the source code, when opening our local
158 copies of the configuration files.
159 But this still fails when opening the wizard from the Accounts window,
160 maybe because the working directory seems to change at runtime.
161 So the wizard will fail the second time unless you copy the files into their
162 proper locations - see the stdout warnings for the paths.
164 (create_page_account_details),(on_before_next):
165 Check for existing non-server accounts instead of server accounts,
166 so the default account name is useful again, and to prevent trying to
169 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
170 Show the wizard when New is clicked.
172 * src/widgets/modest-account-view.c: (on_account_default_toggled),
173 (init_view): Show the column headers, and show the columns that are
174 specified in the UI specs. However, something in Maemo's GTK+ prevents
175 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
176 change the default account. This is despite unsetting the special properties.
178 2007-04-05 Murray Cumming <murrayc@murrayc.com>
180 * docs/reference/modest-design.sgml: Corrected spelling mistake.
181 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
182 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
183 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
184 to make that clearer.
185 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
187 2007-04-05 Murray Cumming <murrayc@murrayc.com>
189 * src/maemo/modest-account-view-window.c:
190 (modest_account_view_window_init),
191 (modest_account_view_window_new):
192 Use the same buttons as specified in the
193 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
194 the existing widgets, which never had a chance of working.
195 Put the ModestAccountView treeview in a scrolled window.
196 Do not repeat the initialization in both _init() and _new().
198 * src/widgets/modest-account-view.c: (update_account_view):
199 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
200 this widget and window shows no accounts.
202 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
204 2007-04-05 Murray Cumming <murrayc@murrayc.com>
206 * src/maemo/easysetup/modest-easysetup-wizard.c:
207 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
208 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
209 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
212 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
213 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
214 accounts exist yet, as in the UI spec.
216 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
218 2007-04-05 Murray Cumming <murrayc@murrayc.com>
220 * src/maemo/Makefile.am:
221 * src/maemo/modest-connection-specific-smtp-edit-window.c:
222 * src/maemo/modest-connection-specific-smtp-edit-window.h:
223 New window for editing connection-specific smtp details.
224 Not fully implemented.
226 * src/maemo/modest-connection-specific-smtp-window.c:
227 (modest_connection_specific_smtp_window_finalize) :
228 unref the tree model.
229 (on_button_edit): Show the edit window.
231 2007-04-05 Murray Cumming <murrayc@murrayc.com>
233 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
236 * src/maemo/Makefile.am:
237 * src/maemo/modest-connection-specific-smtp-window.c:
238 * src/maemo/modest-connection-specific-smtp-window.h:
239 New window for showing the list of connections, for connection-specific
240 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
241 * src/maemo/easysetup/modest-easysetup-wizard.c:
242 (create_page_custom_outgoing): Show the new window when the button is clicked.
244 2007-04-04 Murray Cumming <murrayc@murrayc.com>
246 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
247 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
248 * src/maemo/modest-msg-edit-window.c:
249 (modest_msg_edit_window_insert_image):
250 * src/modest-conf.c: (modest_conf_key_escape):
251 * src/modest-mail-operation.c:
252 (modest_mail_operation_send_new_mail):
253 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
254 (modest_ui_actions_on_new_account):
255 * src/widgets/modest-attachment-view.c: (update_filename_request):
256 * src/widgets/modest-mail-header-view.c:
257 Corrected warnings that were breaking the build, by commenting out unused variables,
258 and a function, and by including a header.
260 2007-04-04 Murray Cumming <murrayc@murrayc.com>
262 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
263 so we can #ifdef around platform-specific code when necessary.
264 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
265 to allow this to build for the GNOME platform too.
267 2007-04-04 Murray Cumming <murrayc@murrayc.com>
269 * src/maemo/easysetup/modest-easysetup-wizard.c:
270 Added util_increment_name() and used it in create_page_account_details()
271 to make sure that the default account name is always a new name.
273 (modest_easysetup_wizard_dialog_init),
274 (set_default_custom_servernames): Some minor memory management fixes.
276 2007-04-04 Murray Cumming <murrayc@murrayc.com>
280 * src/modest-runtime.c: (init_i18n): Restored the translation
281 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
282 are defined in config.h, and the translations are installed.
284 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
285 is defined for translation.
287 2007-04-03 Murray Cumming <murrayc@murrayc.com>
289 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
291 * src/maemo/easysetup/modest-easysetup-wizard.c:
292 (modest_easysetup_wizard_dialog_init):
293 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
294 Use realistic paths (though they should use $prefix generically) to the
295 mcc_mapping and provider-data.keyfile files which might work when they
296 are installed by the future version of the operator-wizard package,
297 and then fallback to paths in our source code, with an explanatory
300 2007-04-03 Murray Cumming <murrayc@murrayc.com>
304 * src/maemo/Makefile.am:
305 * src/maemo/easysetup/: Added files from the previously-exernal
306 osso-modest-easysetup.
307 * src/maemo/modest-main-window-ui.h:
308 * src/modest-ui-actions.c:
309 * src/modest-ui-actions.h:
310 Added modest_ui_actions_on_new_account() as a signal handler for the
311 New Account menu item. It shows the easysetup wizard.
312 * po/en_GB.po: Added additional needed logical IDs and translations.
314 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
315 Apparently ChangeLog is not used for some vague Nokia legal reasons.