git.maemo.org Git - modest/blob - ChangeLog2

   1 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
   2
   3         * src/dbus_api/modest-dbus-api.h:
   4         * src/dbus_api/modest-dbus-callbacks.c:
   5         Use an idle callback to execute the modest code in the application's own thread.
   6         Remove the helloworld example method.
   7         Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
   8         parsed, and the open-message method is not implemented because this is not yet implemented in
   9         modest itself.
  10         * libmodest-dbus-client/libmodest-dbus-client.c:
  11         (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
  12         (libmodest_dbus_client_open_message):
  13         * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
  14
  15         * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
  16         body without crashing.
  17
  18         * tests/dbus_api/Makefile.am:
  19         * tests/dbus_api/test_mail_to.c:
  20         * tests/dbus_api/test_open_message.c: New tests for the new methods.
  21
  22 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
  23
  24         * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
  25         Added file to fix the build. Sorry.
  26
  27         * src/dbus_api/Makefile.am:
  28         * src/dbus_api/modest-dbus-api.h:
  29         * src/dbus_api/modest-dbus-callbacks.h:
  30         * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
  31         (modest_dbus_req_handler):
  32         Put constants in a separate header so it can be reused by the
  33         client library, without duplication
  34
  35         * libmodest-dbus-client/Makefile.am:
  36         * libmodest-dbus-client/libmodest-dbus-client.c:
  37         (libmodest_dbus_client_call_helloworld),
  38         (libmodfest_dbus_client_send_mail),
  39         (libmodfest_dbus_client_mailto),
  40         (libmodfest_dbus_client_open_message):
  41         * libmodest-dbus-client/libmodest-dbus-client.h:
  42         (Partly) Implement a send_mail D-Bus method.
  43
  44         * tests/dbus_api/Makefile.am:
  45         * tests/dbus_api/test_send_mail.c: (main): Added a test for
  46         the send_email D-Bus method.
  47
  48 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
  49
  50         * Makefile.am:
  51         * configure.ac:
  52         * libmodest-dbus-client/Makefile.am:
  53         * libmodest-dbus-client/libmodest-dbus-client.c:
  54         * libmodest-dbus-client/libmodest-dbus-client.h:
  55         * tests/dbus_api/Makefile.am:
  56         * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
  57         for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
  58
  59 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
  60
  61         * src/maemo/easysetup/modest-easysetup-wizard.c:
  62         (create_page_account_details):
  63         * src/maemo/modest-account-settings-dialog.c:
  64         (create_page_account_details): Explicitly set auto-capitalization mode for the title
  65         widgets, because this might not be the default in future versions of the Maemo GTK+.
  66         However, I can not not get capitalization to work even in a simple test case.
  67
  68 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
  69
  70         * src/maemo/easysetup/modest-easysetup-wizard.c:
  71         (create_page_custom_incoming), (create_page_custom_outgoing):
  72         * src/maemo/modest-account-settings-dialog.c:
  73         (create_page_account_details), (create_page_incoming),
  74         (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
  75         instead of using gtk_check_button_with_label(), so they are aligned like the other
  76         widgets, as per the UI spec.
  77
  78 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
  79
  80         * src/maemo/easysetup/modest-easysetup-wizard.c:
  81         * src/maemo/modest-connection-specific-smtp-edit-window.c:
  82         * src/widgets/modest-validating-entry.c:
  83         * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
  84         Modest prefix instead of an EasySetup prefix.
  85
  86 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
  87
  88         * src/widgets/modest-validating-entry.h:
  89         * src/widgets/modest-validating-entry.c: (on_insert_text),
  90         Added easysetup_validating_entry_set_max_func(), used to set a callback
  91         to call when the max number of characters is reached. GtkEntry has a max-length
  92         already but is silent about it.
  93
  94         * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
  95         (create_page_account_details), (create_page_user_details),
  96         (create_account):
  97         * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
  98         (create_page_account_details), (create_page_user_details),
  99         (create_page_outgoing):
 100         * src/modest-ui-actions.c: (modest_ui_actions_on_details):
 101         Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
 102         the UI spec, when the user tries to enter more than the max number of characters.
 103
 104 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 105
 106         * src/maemo/easysetup/modest-easysetup-wizard.c:
 107         (create_page_user_details), (create_page_custom_incoming),
 108         (create_page_custom_outgoing):
 109         * src/maemo/modest-account-settings-dialog.c:
 110         (create_page_user_details), (create_page_incoming),
 111         (create_page_outgoing):
 112         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 113         (modest_connection_specific_smtp_edit_window_init):
 114         Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
 115         not appropriate. Bad Maemo-specific defaults!.
 116
 117 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 118
 119         * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
 120         (on_toggle_button_changed), (modest_signature_editor_dialog_init),
 121         (modest_signature_editor_dialog_set_settings):
 122         Disable the label and textview when the checkbox is disabled, and use the
 123         specified (UI spec) default signature text.
 124
 125 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 126
 127         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 128         (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
 129
 130         * src/modest-defs.h:
 131         * src/modest-account-mgr-helpers.h:
 132         * src/modest-account-mgr-helpers.c:
 133         Added modest_account_mgr_get/set_signature(), using new gconf keys.
 134
 135         * src/maemo/Makefile.am:
 136         * src/maemo/modest-signature-editor-dialog.c:
 137         * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
 138         as per the UI spec.
 139
 140         * src/maemo/modest-account-settings-dialog.h:
 141         * src/maemo/modest-account-settings-dialog.c:
 142         (modest_account_settings_dialog_finalize), (on_button_signature),
 143         (save_configuration): Use the new dialog when the Edit button is pressed, and
 144         save the changes if necessary, as per the UI spec.
 145
 146 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 147
 148         * src/maemo/Makefile.am:
 149         * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
 150         based on maemo-develoers email from Dirk.
 151
 152         * src/maemo/easysetup/modest-easysetup-wizard.c:
 153         (create_page_welcome), (create_page_account_details),
 154         (create_page_user_details), (create_page_complete_easysetup),
 155         (create_page_custom_incoming), (create_page_custom_outgoing),
 156         (create_page_complete_custom),
 157         (modest_easysetup_wizard_dialog_init):
 158         * src/maemo/modest-account-settings-dialog.c:
 159         (create_page_account_details), (create_page_user_details),
 160         (create_page_incoming), (create_page_outgoing),
 161         (modest_account_settings_dialog_init):
 162         * src/maemo/modest-connection-specific-smtp-window.c:
 163         (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
 164
 165 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 166
 167         * src/maemo/easysetup/modest-easysetup-wizard.c:
 168         (create_page_account_details), (create_page_custom_outgoing),
 169         (create_page_complete_custom):
 170         * src/maemo/modest-account-settings-dialog.c:
 171         (create_page_user_details), (create_page_incoming),
 172         (create_page_outgoing):
 173         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 174         (modest_connection_specific_smtp_edit_window_init):
 175         Use the correct (UI spec) port min/max, and use horizontal separators,
 176         as per the UI spec.
 177
 178 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 179
 180         * src/maemo/easysetup/modest-easysetup-wizard.c:
 181         (set_default_custom_servernames):
 182         * src/maemo/modest-account-settings-dialog.c:
 183         (create_page_incoming), (on_combo_outgoing_security_changed),
 184         (on_combo_incoming_security_changed), (create_page_outgoing),
 185         (modest_account_settings_dialog_set_account_name),
 186         (save_configuration):
 187         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 188         (on_combo_security_changed),
 189         (modest_connection_specific_smtp_edit_window_init),
 190         (modest_connection_specific_smtp_edit_window_set_connection),
 191         (modest_connection_specific_smtp_edit_window_get_settings):
 192         Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
 193         as per the UI spec.
 194
 195 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 196
 197         * po/en_GB.po:
 198         * src/maemo/easysetup/modest-easysetup-wizard.c:
 199         (create_page_custom_outgoing), (create_page_complete_custom):
 200         * src/maemo/modest-account-settings-dialog.c:
 201         (create_page_user_details), (create_page_outgoing):
 202         * src/maemo/modest-account-view-window.c: (button_box_new):
 203         Use changed logical IDs as per the most recent UI spec:
 204         mcen_bd_emailsetup_edit -> mcen_bd_edit
 205         mcen_bd_emailsetup_delete -> mcen_bd_delete
 206         mcen_bd_emailsetup_close -> mcen_bd_close
 207
 208 2007-04-20  2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 209
 210         * configure.ac:
 211         * src/Makefile.am:
 212         * src/dbus_api/Makefile.am:
 213         * src/dbus_api/modest-dbus-callbacks.c:
 214         * src/dbus_api/modest-dbus-callbacks.h:
 215         * src/maemo/modest-platform.c: (modest_platform_init):
 216         Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
 217         method.
 218         * tests/Makefile.am:
 219         * tests/dbus_api/Makefile.am:
 220         * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
 221
 222 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 223
 224         * src/maemo/modest-account-settings-dialog.c:
 225         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 226         Removed unnecessary includes.
 227
 228 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 229
 230         * src/maemo/easysetup/modest-easysetup-wizard.c:
 231         * src/maemo/modest-account-settings-dialog.c:
 232         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 233         * src/widgets/Makefile.am:
 234         * src/widgets/modest-easysetup-secureauth-combo-box.c:
 235         * src/widgets/modest-easysetup-secureauth-combo-box.h:
 236         * src/widgets/modest-easysetup-serversecurity-combo-box.c:
 237         * src/widgets/modest-easysetup-serversecurity-combo-box.h:
 238         * src/widgets/modest-secureauth-combo-box.c:
 239         * src/widgets/modest-secureauth-combo-box.h:
 240         * src/widgets/modest-serversecurity-combo-box.c:
 241         * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
 242         made the GObject names more consistent with the rest of the Modest code.
 243
 244 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 245
 246         * src/maemo/easysetup/Makefile.am:
 247         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 248         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
 249         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 250         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 251         * src/maemo/easysetup/modest-easysetup-wizard.c:
 252         * src/maemo/easysetup/modest-validating-entry.c:
 253         * src/maemo/easysetup/modest-validating-entry.h:
 254         * src/maemo/modest-account-settings-dialog.c:
 255         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 256         * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
 257         widgets/ because they are used outside of easysetup too. After checking in,
 258         svn will allow me to rename them too.
 259
 260 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 261
 262         * src/gnome/modest-msg-edit-window.c:
 263         (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
 264         linker error, to fix the build on the GNOME platform.
 265         modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
 266         modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
 267         ifdefed out to avoid a warning.
 268
 269 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 270
 271         * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
 272         use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
 273         some alternative for GTK+ 2.6.
 274
 275 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 276
 277         * src/maemo/modest-address-book.c: Added include to avoid a warning.
 278
 279         * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
 280         specified for EmailAccountsDialog in UI spec.
 281
 282         * src/maemo/easysetup/modest-easysetup-wizard.c:
 283         * src/maemo/easysetup/modest-easysetup-wizard.h:
 284         * src/maemo/modest-account-settings-dialog.c:
 285         * src/maemo/modest-account-settings-dialog.h:
 286         Reuse a member window widget for the connection-specific SMTP server accounts,
 287         so we can tell it to create/save the accounts only if we actually save changes.
 288
 289         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 290         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 291         (modest_connection_specific_smtp_edit_window_get_settings):
 292         Return a struct instance for temporarily remembering the entered data.
 293
 294         * src/maemo/modest-connection-specific-smtp-window.h:
 295         * src/maemo/modest-connection-specific-smtp-window.c:
 296         (modest_connection_specific_smtp_window_finalize),
 297         (modest_connection_specific_smtp_window_fill_with_connections),
 298         (on_button_edit),
 299         (modest_connection_specific_smtp_window_save_server_accounts),
 300         (update_model_server_names): Do not actually save data until asked,
 301         when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
 302
 303         (on_selection_changed),
 304         (modest_connection_specific_smtp_window_init): Disable the edit
 305         button when nothing is selected.
 306
 307         * src/modest-account-mgr-helpers.c:
 308         * src/modest-account-mgr-helpers.h:
 309         Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
 310         elsewhere.
 311
 312 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 313
 314         * src/modest-account-mgr-helpers.h:
 315         * src/modest-account-mgr-helpers.c:
 316         (modest_account_mgr_get_unused_account_name),
 317         (modest_account_mgr_get_unused_account_display_name): Added these
 318         utility functions, to avoid code duplication.
 319
 320         * src/maemo/easysetup/modest-easysetup-wizard.c:
 321         (create_page_account_details), (create_account):
 322         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 323         (on_combo_security_changed),
 324         (modest_connection_specific_smtp_edit_window_init),
 325         (modest_connection_specific_smtp_edit_window_save_settings):
 326         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 327         * src/maemo/modest-connection-specific-smtp-window.c:
 328         (modest_connection_specific_smtp_window_finalize),
 329         (modest_connection_specific_smtp_window_fill_with_connections),
 330         (on_button_edit), (modest_connection_specific_smtp_window_init):
 331         * src/maemo/modest-connection-specific-smtp-window.h:
 332         Implementing saving of connection-specific server accounts.
 333
 334         But I need to refactor this so we can save the data for each
 335         possible connection-specific account and only actually create the server accounts
 336         when the easysetup finished, or the OK button is pressed on the account settings
 337         dialog.
 338
 339 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 340
 341         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 342         (on_combo_security_changed):
 343         (modest_connection_specific_smtp_edit_window_init):
 344         Auto-fill the port number as in the account settings.
 345
 346         (modest_connection_specific_smtp_edit_window_set_connection):
 347         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 348         * src/maemo/modest-connection-specific-smtp-window.c:
 349         (fill_with_connections), (on_button_edit),
 350         (modest_connection_specific_smtp_window_init):
 351         Turn the edit window into a dialog to simplify the code, and
 352         set a WM hint as in a GtkDialog, because only a popup can be on top of
 353         another window in Maemo, and popups usually have no WM decoration.
 354
 355         * src/modest-defs.h:
 356         * src/modest-account-mgr-helpers.c:
 357         (modest_account_mgr_set_connection_specific_smtp),
 358         (modest_account_mgr_remove_connection_specific_smtp),
 359         (modest_account_mgr_get_connection_specific_smtp):
 360         * src/modest-account-mgr-helpers.h: Some functions to write the
 361         connection-specific SMTP server information. Not yet used.
 362
 363
 364         * src/widgets/modest-folder-view.c: (text_cell_data):
 365         Fix a warning about an uninitialized variable.
 366         (on_configuration_key_changed): Put an #ifdef around the use
 367         of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
 368
 369 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 370
 371         * src/maemo/modest-account-settings-dialog.h:
 372         * src/maemo/modest-account-settings-dialog.c:
 373         Added connect_for_modified() utility function to mark the new modified boolean.
 374
 375         (create_page_account_details), (create_page_user_details),
 376         (create_page_incoming), (create_page_outgoing), (on_response),
 377         (modest_account_settings_dialog_init),
 378         (modest_account_settings_dialog_set_account_name):
 379         Only warn about unsaved changes when there are actually unsaved changes.
 380
 381         * src/modest-account-mgr-helpers.c:
 382         * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
 383         into the ModestServerAccountData struct. I do not use it yet, but someone might expect
 384         to get the data from there in future.
 385
 386 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 387
 388         * src/modest-defs.h:
 389
 390         * src/modest-account-mgr-helpers.h:
 391         * src/modest-account-mgr-helpers.c:
 392         Store the security account setting in a single conf key instead of using
 393         the options list, so that the list is left for just the to-be-removed camel hack,
 394         and because gconf_client_set_list() is failing for some reason.
 395
 396         * src/modest-account-mgr.c:
 397         (modest_account_mgr_add_server_account):
 398         * src/maemo/modest-account-settings-dialog.c:
 399         (modest_account_settings_dialog_set_account_name),
 400         (save_configuration): Use the renamed functions.
 401
 402
 403 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 404
 405         * src/widgets/Makefile.am:
 406         * src/widgets/modest-limit-retrieve-combo-box.c:
 407         * src/widgets/modest-limit-retrieve-combo-box.h:
 408         * src/widgets/modest-retrieve-combo-box.c:
 409         * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
 410         the account settings dialog.
 411
 412         * src/modest-defs.h:
 413         * src/modest-account-mgr-helpers.h:
 414         * src/modest-account-mgr-helpers.c:
 415         (modest_server_account_get_option_secure_auth),
 416         (modest_server_account_set_option_secure_auth):
 417         * src/modest-account-mgr.c:
 418         (modest_account_mgr_add_server_account):
 419         Use the existing AUTH_MECH conf key for the secure-auth setting,
 420         instead of putting it in the list options, because this was actually used already.
 421
 422         * src/maemo/modest-account-settings-dialog.c:
 423         (create_page_account_details),
 424         (modest_account_settings_dialog_set_account_name),
 425         (save_configuration):
 426         * src/maemo/modest-account-settings-dialog.h:
 427         Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
 428         Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
 429
 430 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 431
 432         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 433         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 434         Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
 435
 436         * src/modest-defs.h:
 437         * src/maemo/modest-account-settings-dialog.c:
 438         (create_page_incoming), (on_combo_outgoing_security_changed),
 439         (on_combo_incoming_security_changed), (create_page_outgoing),
 440         (modest_account_settings_dialog_set_account_name),
 441         (save_configuration): Load/Save the port number, and change it when the
 442         security combo changes, to suitable defaults.
 443
 444 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 445
 446         * src/modest-account-mgr.c:
 447         (modest_account_mgr_add_server_account): Set the security and secure-auth
 448         options, and add a comment saying that the other camel-specific options should be
 449         removed in future.
 450
 451 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 452
 453         * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
 454         found by valgrind.
 455         * src/modest-tny-account-store.c: (account_list_free),
 456         (on_account_changed): Add a TODO comment about a valgrind error, caused by using
 457         cursor->data after unreffing it. But there is some strange stuff there so it might not be
 458         easy to fix.
 459
 460 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 461
 462         * src/modest-protocol-info.c:
 463         * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
 464         is required by our UI spec. Maybe something in our implementation will use this eventually.
 465         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 466         (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
 467         instead of the previous 0 placeholder.
 468
 469         * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
 470         secure-auth settings.
 471         * src/modest-account-mgr-helpers.h:
 472         * src/modest-account-mgr-helpers.c:
 473         (modest_server_account_data_get_option_secure_auth),
 474         (modest_server_account_set_option_secure_auth),
 475         (modest_server_account_data_get_option_security),
 476         (modest_server_account_set_option_security): Added this API for getting and setting the security
 477         and secure-auth settings.
 478
 479         * src/maemo/modest-account-settings-dialog.h:
 480         * src/maemo/modest-account-settings-dialog.c:
 481         (modest_account_settings_dialog_finalize), (check_data),
 482         (on_response): Store the original title as well as the name, to avoid unnececessary warnings
 483         about changing titles.
 484         (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
 485         (save_configuration): Save the security and secure-auth settings.
 486
 487         * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
 488         is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
 489
 490 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 491
 492         * src/modest-defs.h:
 493         * src/modest-account-mgr.c:
 494         (modest_account_mgr_add_server_account):
 495         Added and used defines for the options key and value pair strings,
 496         that are used so far, though they do not seem to correspond to anything in our
 497         UI specs or ModestProtocol enum.
 498
 499         * src/modest-account-mgr-helpers.h:
 500         * src/modest-account-mgr-helpers.c:
 501         (compare_option_strings_for_name),
 502         (modest_server_account_data_get_option_value),
 503         (modest_server_account_data_get_option_bool),
 504         (modest_account_mgr_get_server_account_option):
 505         Added helper functions for parsing the options GSList.
 506
 507 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 508
 509         * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
 510         display name is based on the supplied account name.
 511         * src/modest-account-mgr.c:
 512         * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
 513         with an inefficient, but good-enough, implementation.
 514
 515         * src/maemo/easysetup/modest-easysetup-wizard.c:
 516         (create_page_account_details), (on_before_next), (create_account):
 517         Check for existing display names rather than (non-user-visible) account names, and just
 518         create and set a unique account name at the end.
 519
 520         * src/maemo/modest-account-settings-dialog.c:
 521         (modest_account_settings_dialog_init),
 522         (modest_account_settings_dialog_set_account_name),
 523         (create_page_incoming): Show the display name, instead of the account name.
 524         (on_response): Do some (not all) extra checks, as in the UI spec.
 525         (save_configuration): Save the display name if it was changed.
 526
 527 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 528
 529         * po/en_GB.po: Added needed logical ID and translation.
 530         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 531         (init_view): Made the is-default column clicking work.
 532
 533 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 534
 535         * configure.ac:
 536         * src/maemo/easysetup/Makefile.am:
 537         * src/maemo/easysetup/modest-easysetup-wizard.c:
 538         (modest_easysetup_wizard_dialog_init):
 539         * src/maemo/easysetup/provider-data-test.keyfile:
 540         * src/maemo/easysetup/provider-data.keyfile:
 541         Moved the provider data file to the new modest-providers-data package and used it from there.
 542
 543 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 544
 545         * src/modest-local-folder-info.c:
 546         (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
 547         N_() was already used on the static strings, but this just marks it for translation without
 548         using the translation.
 549
 550 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 551
 552         * src/maemo/modest-account-settings-dialog.c:
 553         (create_page_incoming),
 554         (modest_account_settings_dialog_set_account_name):
 555         Added comments about the need for new API in ModestAccountMgr to handle the authentication
 556         and secure-connection stuff that is stored in the options GSList* with hard-coded names.
 557         I will do this if nobody else gets there first.
 558
 559 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 560
 561         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
 562         Saved much of the incoming and outgoing data too, though I cannot yet see how to
 563         save the security stuff.
 564
 565 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 566
 567         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 568         Set the email address and user fullname, which I now see must be
 569         done separately.
 570
 571         * src/maemo/modest-account-settings-dialog.h:
 572         * src/maemo/modest-account-settings-dialog.c:
 573          (on_response),
 574         (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
 575         leave-on-server and authentication.
 576         (save_configuration): Save most of the non-server-account specific stuff, but I don't see
 577         how to do the rest.
 578
 579 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 580
 581
 582         * src/maemo/modest-account-settings-dialog.c:
 583         * src/maemo/modest-account-settings-dialog.h:
 584         Most (but not all) of the widgets are now present as specified by the UI spec.
 585         No changes are yet saved, and some details are not properly shown yet.
 586
 587         * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
 588
 589 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 590
 591         * src/maemo/Makefile.am:
 592         * src/maemo/modest-account-settings-dialog.c:
 593         * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
 594         an existing account. Doesn't do much yet.
 595
 596         * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
 597         Open the accounts settings dialog when Edit is clicked.
 598
 599 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 600
 601         * src/maemo/easysetup/Makefile.am:
 602         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
 603         (load_from_file):
 604         * src/maemo/easysetup/modest-easysetup-wizard.c:
 605         (modest_easysetup_wizard_dialog_init):
 606         Try to get the source directory from the build system,
 607         instead of hard-coding "./" into the source code, when opening our local
 608         copies of the configuration files.
 609         But this still fails when opening the wizard from the Accounts window,
 610         maybe because the working directory seems to change at runtime.
 611         So the wizard will fail the second time unless you copy the files into their
 612         proper locations - see the stdout warnings for the paths.
 613
 614         (create_page_account_details),(on_before_next):
 615         Check for existing non-server accounts instead of server accounts,
 616         so the default account name is useful again, and to prevent trying to
 617         recreate accounts.
 618
 619         * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
 620         Show the wizard when New is clicked.
 621
 622         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 623         (init_view): Show the column headers, and show the columns that are
 624         specified in the UI specs. However, something in Maemo's GTK+ prevents
 625         us from handling the GtkCellRendererToggle::toggled signal, so we cannot
 626         change the default account. This is despite unsetting the special properties.
 627
 628 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 629
 630         * docs/reference/modest-design.sgml: Corrected spelling mistake.
 631         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 632         Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
 633         This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
 634         to make that clearer.
 635         * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
 636
 637 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 638
 639         * src/maemo/modest-account-view-window.c:
 640         (modest_account_view_window_init),
 641         (modest_account_view_window_new):
 642         Use the same buttons as specified in the
 643         UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
 644         the existing widgets, which never had a chance of working.
 645         Put the ModestAccountView treeview in a scrolled window.
 646         Do not repeat the initialization in both _init() and _new().
 647
 648         * src/widgets/modest-account-view.c: (update_account_view):
 649         Add a warning about modest_account_mgr_account_names() returning NULL, which is why
 650         this widget and window shows no accounts.
 651
 652         * po/en_GB.po: Added translations needed for the dialog button logical IDs.
 653
 654 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 655
 656         * src/maemo/easysetup/modest-easysetup-wizard.c:
 657         (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
 658         (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
 659         returns NULL after modest_account_mgr_add_server_account() returned TRUE,
 660         which seems wrong.
 661
 662         * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
 663         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
 664         accounts exist yet, as in the UI spec.
 665
 666         * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
 667
 668 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 669
 670         * src/maemo/Makefile.am:
 671         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 672         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 673         New window for editing connection-specific smtp details.
 674         Not fully implemented.
 675
 676         * src/maemo/modest-connection-specific-smtp-window.c:
 677         (modest_connection_specific_smtp_window_finalize) :
 678         unref the tree model.
 679         (on_button_edit): Show the edit window.
 680
 681 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 682
 683         * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
 684         error for me.
 685
 686         * src/maemo/Makefile.am:
 687         * src/maemo/modest-connection-specific-smtp-window.c:
 688         * src/maemo/modest-connection-specific-smtp-window.h:
 689         New window for showing the list of connections, for connection-specific
 690         SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
 691         * src/maemo/easysetup/modest-easysetup-wizard.c:
 692         (create_page_custom_outgoing): Show the new window when the button is clicked.
 693
 694 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 695
 696         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 697         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
 698         * src/maemo/modest-msg-edit-window.c:
 699         (modest_msg_edit_window_insert_image):
 700         * src/modest-conf.c: (modest_conf_key_escape):
 701         * src/modest-mail-operation.c:
 702         (modest_mail_operation_send_new_mail):
 703         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
 704         (modest_ui_actions_on_new_account):
 705         * src/widgets/modest-attachment-view.c: (update_filename_request):
 706         * src/widgets/modest-mail-header-view.c:
 707         Corrected warnings that were breaking the build, by commenting out unused variables,
 708         and a function, and by including a header.
 709
 710 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 711
 712         * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
 713         so we can #ifdef around platform-specific code when necessary.
 714         * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
 715         to allow this to build for the GNOME platform too.
 716
 717 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 718
 719         * src/maemo/easysetup/modest-easysetup-wizard.c:
 720         Added util_increment_name() and used it in create_page_account_details()
 721         to make sure that the default account name is always a new name.
 722
 723         (modest_easysetup_wizard_dialog_init),
 724         (set_default_custom_servernames): Some minor memory management fixes.
 725
 726 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 727
 728         * Makefile.am:
 729         * configure.ac:
 730         * src/modest-runtime.c: (init_i18n): Restored the translation
 731         infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
 732         are defined in config.h, and the translations are installed.
 733
 734         * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
 735         is defined for translation.
 736
 737 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
 738
 739         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
 740         (load_from_file):
 741         * src/maemo/easysetup/modest-easysetup-wizard.c:
 742         (modest_easysetup_wizard_dialog_init):
 743         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
 744         Use realistic paths (though they should use $prefix generically) to the
 745         mcc_mapping and provider-data.keyfile files which might work when they
 746         are installed by the future version of the operator-wizard package,
 747         and then fallback to paths in our source code, with an explanatory
 748         warning.
 749
 750 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
 751
 752         * configure.ac:
 753         * src/Makefile.am:
 754         * src/maemo/Makefile.am:
 755         * src/maemo/easysetup/: Added files from the previously-exernal
 756         osso-modest-easysetup.
 757         * src/maemo/modest-main-window-ui.h:
 758         * src/modest-ui-actions.c:
 759         * src/modest-ui-actions.h:
 760         Added modest_ui_actions_on_new_account() as a signal handler for the
 761         New Account menu item. It shows the easysetup wizard.
 762         * po/en_GB.po: Added additional needed logical IDs and translations.
 763
 764 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
 765 Apparently ChangeLog is not used for some vague Nokia legal reasons.
 766