1 2007-05-31 Murray Cumming <murrayc@murrayc.com>
3 * src/widgets/modest-hbox-cell-renderer.c:
4 (modest_hbox_cell_renderer_append):
5 * src/widgets/modest-vbox-cell-renderer.c:
6 (modest_vbox_cell_renderer_append):
7 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
8 to fix the build with Maemo Bora.
9 However, there seems to be a remaining crash, probably due to reference
12 2007-05-30 Murray Cumming <murrayc@murrayc.com>
14 * src/modest-tny-account.c:
15 (modest_tny_account_new_for_local_folders):
16 Use hildon_file_system_info_async_new() to get a better name for
17 the memory card account, setting it as the account name.
18 The timing seems to work, but this is probably
19 not the best place to do this. See the TODO comment.
20 * src/maemo/modest-main-window.c: (create_details_widget):
21 * src/widgets/modest-folder-view.c: (text_cell_data):
22 Use the tny account name instead of hardcoding a name.
24 2007-05-30 Christian Kellner <ckellner@openismus.com>
26 * src/modest-search.c: (modest_search):
27 Correctly set part_search_func even if we have already parsed
28 the query and thus a valid OgsTextSearcher object.
30 2007-05-30 Christian Kellner <ckellner@openismus.com>
33 Search and check for libogs.
36 Incooparte the ogs build env.
38 * src/modest-mime-part-search-stream.c:
39 * src/modest-mime-part-search-stream.h:
40 Removed since we do the real searching now in modest-search.c.
42 * src/modest-search.c:
43 * src/modest-search.h:
44 Implement support for ogs. We use that if available and requested
45 and fall back to modest_text_utils_utf8_strcmp (). The search logic
46 should now handle the corner case when the search term is spread
47 across multiple reads.
48 Also the logic in modest_search () was corrected to search all
49 requested fields until one is found.
51 2007-05-30 Murray Cumming <murrayc@murrayc.com>
53 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
56 * src/modest-init.c: Made modest_init_local_folders() take a
57 path and be public so we can iniitialize maildir folders on
60 * src/modest-local-folder-info.h:
61 * src/modest-local-folder-info.c:
62 (modest_local_folder_info_get_maildir_path): Add a path parameter.
64 * src/modest-tny-account.c:
65 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
66 still means the standard local-folders path on the local volume.
68 * src/modest-tny-account-store.c:
69 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
70 signal so we can detect mount/unmount of the MMC1 card, and do an update of
71 all accounts when that happens.
72 (get_server_accounts): If the MMC1 card is mounted, create a store account for
73 this too, so it shows up in the treeview.
75 2007-05-28 Murray Cumming <murrayc@murrayc.com>
77 * src/maemo/modest-maemo-global-settings-dialog.c:
79 * src/widgets/modest-global-settings-dialog.c:
80 (current_connection_default):
81 Use the enum values instead of 0, 1 and -1,
82 to make the code clearer.
84 * src/modest-account-mgr-helpers.c:
85 (modest_account_mgr_get_connection_specific_smtp): Make this code
88 * src/modest-runtime.h:
89 * src/modest-runtime.c:
90 Added modest_runtime_remove_all_send_queues().
91 * src/maemo/modest-main-window.c:
92 (on_account_store_connecting_finished): Recreate the send queues,
93 using the appropriate transport accounts for this new connection.
94 Some futher adapting might be needed if the old send queues are not
95 automatically stopped at this point.
97 * src/modest-tny-account-store.c: (get_server_accounts):
98 Create the connection-specific transport accounts, so that they can
99 be found later by their ID.
101 * src/modest-tny-account.h:
102 * src/modest-tny-account.c:
103 Added modest_tny_account_new_from_server_account_name().
104 modest_tny_account_new_from_server_account(): Do not create the
105 send queues here, because they will be
106 recreated anyway when the connection changes for the first time.
108 2007-05-28 Murray Cumming <murrayc@murrayc.com>
110 * src/modest-local-folder-info.h:
111 * src/modest-local-folder-info.c:
112 (modest_per_account_local_outbox_folder_info_get_maildir_path),
113 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
114 tbox_folder): Take a modest account name instead of a server TnyAccount,
115 so we can have per-modest-account rather than per-transport-account
117 We must make sure that we change or recreate the exisitng send queues
118 when the connection changes for connection-specific transport accounts.
120 * src/modest-tny-account-store.c:
121 (create_per_account_local_outbox_folders): Create outboxed per modest
122 account, not per transport account.
124 * src/modest-tny-account.h:
125 * src/modest-tny-account.c:
126 (modest_tny_account_get_special_folder): For outboxes, get the
127 parent modest account name. The account is ignored for other folders.
128 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
129 modest account name rather than a server TnyAccount.
131 2007-05-25 Murray Cumming <murrayc@murrayc.com>
133 * src/modest-tny-account.c:
134 (modest_tny_account_new_from_server_account):
135 Call modest_runtime_get_send_queue() immediately after creating transport
136 accounts, so that they start trying to send email from the outbox as soon
137 as possible at startup. This is probably what we want.
139 * src/modest-mail-operation.c: (update_account_thread):
140 * src/modest-runtime.c: (modest_runtime_get_send_queue):
141 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
142 * src/modest-tny-send-queue.h:
143 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
144 (modest_ui_actions_on_send):
145 Added comments about how sending works, though it needs some more work.
147 2007-05-25 Murray Cumming <murrayc@murrayc.com>
149 * src/modest-tny-account.c:
150 (modest_tny_account_get_special_folder): Add TODO because this fails when
152 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
153 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
154 Do not try to show this window when there is no active account. The UI
155 specs does not tell us what to do in this case.
157 2007-05-24 Murray Cumming <murrayc@murrayc.com>
161 * src/maemo/Makefile.am:
162 * src/widgets/Makefile.am: Some dist fixes.
164 2007-05-24 Murray Cumming <murrayc@murrayc.com>
166 * src/maemo/modest-connection-specific-smtp-window.c:
167 (on_button_edit): Make the code clearer, to prevent a double free.
169 2007-05-24 Murray Cumming <murrayc@murrayc.com>
171 * src/maemo/modest-account-settings-dialog.c:
172 (modest_account_settings_dialog_set_account_name),
173 Check the connection-specific smtp servers checkbox if there are any.
175 * src/maemo/modest-connection-specific-smtp-edit-window.c:
176 (modest_connection_specific_smtp_edit_window_init):
177 Start with a suitable port number.
179 * src/modest-account-mgr-helpers.h:
180 * src/modest-account-mgr-helpers.c: Added
181 modest_account_mgr_get_has_connection_specific_smtp().
183 (modest_account_mgr_set_connection_specific_smtp),
184 (modest_account_mgr_remove_connection_specific_smtp),
185 (modest_account_mgr_get_has_connection_specific_smtp),
186 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
187 connection-specific smtp server accounts in the account, rather than
188 the server account conf dir.
190 This fixes bug projects.maemo.org bug NB#58263 .
192 * src/modest-tny-account-store.c:
193 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
194 if there are no server accounts yet, to prevent an infinite loop when there
195 are no accounts. Document that one must be called before the other.
197 2007-05-24 Murray Cumming <murrayc@murrayc.com>
199 * src/modest-account-mgr-helpers.c:
200 (modest_account_mgr_get_default_account): Make sure that at least
201 one account is always the default, if there are any enabled accounts.
202 This is just a sanity check that shouldn't be necessary.
204 * src/modest-account-mgr-priv.c:
205 (_modest_account_mgr_account_from_key): Unescape the conf key to
206 get the real account name. For instance, this is an issue if a space
207 was in the account name, which can happen because the account name
208 is generated from the display name.
209 (_modest_account_mgr_get_account_keyname): Always escape the
211 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
212 Unescape the conf keys to get the real account names.
214 For instance, previously the is-default radio button in the accounts
215 list was not checked for any accounts at first. This fixes that,
216 and might fix several similar bugs.
218 2007-05-23 Murray Cumming <murrayc@murrayc.com>
220 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
221 Removed some debug printfs.
223 2007-05-23 Murray Cumming <murrayc@murrayc.com>
225 Modest on-disk outbox directories are now here, for instance:
226 $HOME/.modest/outboxes/<account-id-1>/outbox
227 $HOME/.modest/outboxes/<account-id-2>/outbox
229 $HOME/.modest/local-folders/outbox
230 so we can have a separate outbox for each account.
231 But they are shown as one outbox in the GtkTreeView, by using a
232 TnyMergeFolder in a ModestTnySimpleFolderStore.
235 * src/modest-tny-simple-folder-store.c:
236 * src/modest-tny-simple-folder-store.h:
237 Added ModestTnySimpleFolderStore, used to contain folders from
238 other folder stores, such as other accounts.
240 * src/modest-tny-outbox-account.h:
241 * src/modest-tny-outbox-account.c:
242 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
243 used for the per-account local outbox folders.
245 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
246 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
247 only use this (internally) now for the non-outbox local folders.
250 * src/modest-init.c: Added modest_init_one_local_folder(), for
251 setting up the directory structure for each local folder.
253 * src/modest-local-folder-info.c:
254 (modest_per_account_local_outbox_folder_info_get_maildir_path),
255 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
257 * src/modest-local-folder-info.h:
258 * src/modest-tny-account-store.c: (on_account_removed),
259 (on_account_changed), (create_per_account_local_outbox_folders),
260 (get_server_accounts), (modest_tny_account_store_get_accounts),
261 (modest_tny_account_store_get_tny_account_by_account),
262 (modest_tny_folder_store_is_virtual_local_folders):
264 * src/modest-tny-account.h:
265 * src/modest-tny-account.c:
266 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
267 to create an on-disk per-account local outbox folder for each
269 (create_per_account_local_outbox_folders): Create a local outbox folder
270 for each transport account.
271 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
272 for all local folders.
274 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
275 instead of using g_object_get/set() directly. It is clearer.
277 (modest_tny_folder_store_get_message_count),
278 (modest_tny_folder_store_get_local_size
279 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
280 because we now use these with non-acount folder stores.
282 (modest_tny_account_get_special_folder),
283 (modest_tny_account_new_from_server_account),
284 (modest_tny_account_new_from_account):
285 (recurse_folders): Adjust to the new outbox system.
287 * src/modest-tny-folder.h:
288 * src/modest-tny-folder.c:
289 (modest_tny_folder_is_local_folder),
290 (modest_tny_folder_get_local_folder_type),
291 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
293 * src/widgets/modest-main-window.h:
294 * src/maemo/modest-main-window.c: (create_details_widget),
295 (modest_main_window_set_contents_style): Show details for any folder store,
298 (modest_tny_folder_get_rules):
299 Remove the const. C does not support constness enough for this.
301 * src/modest-ui-actions.c:
302 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
303 make all outboxes appear as one, in the usual local-folders tree node.
305 (set_active_account_from_tny_account),
306 (modest_ui_actions_on_folder_selection_changed):
307 * src/widgets/modest-folder-view.c: (text_cell_data),
308 (icon_cell_data), (filter_row),
309 (add_account_folders_to_merged_folder),
310 (add_account_folders_to_simple_folder_store), (),
311 (get_cmp_rows_type_pos), (cmp_rows),
312 (modest_folder_view_set_account_id_of_visible_server_account):
313 Adjust to the new outbox system, using generic folder stores and folders
316 2007-05-23 Christian Kellner <ckellner@openismus.com>
318 * src/modest-mail-operation.c:
319 (modest_mail_operation_update_account):
320 Use info->max_size instead of unintialized local var [small
321 build fix]. (Added TODO to review that change since I don't
324 2007-05-23 Marcus Bauer <marcusb@openismus.com>
326 * libmodest-dbus-client/libmodest-dbus-client.c:
327 (libmodest_dbus_client_compose_mail): function added
328 * src/dbus_api/modest-dbus-api.h:
329 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
330 (on_compose_mail): Implementation of the SendAsMail functionality
332 2007-05-22 Murray Cumming <murrayc@murrayc.com>
334 * src/modest-account-mgr.c:
335 (modest_account_mgr_add_server_account): Set the secure-connection
336 conf key for transport accounts as well as store accounts. I don't know
337 why the if was there. For instance, this makes sure that we use SSL
338 for the gmail preset from the easysetup wizard.
340 2007-05-22 Murray Cumming <murrayc@murrayc.com>
342 * src/gnome/modest-main-window.c:
343 (on_account_store_connecting_finished), (connect_signals):
344 * src/maemo/modest-main-window.c:
345 (on_account_store_connecting_finished), (connect_signals),
346 (modest_main_window_new):
347 Handle TnyAccountStore::connecting-finished instead of
348 TnyDevice::connection-changed, because we cannot actually perform
349 operations on accounts until TnyAccountStore has itself responded to
350 the TnyDevice::connection-changed signal. This prevents a GError from
352 Do not try to update at startup, because we (at least on scratchbox)
353 already do an update at startup when the device goes online.
354 This prevents a GError from tinymail.
355 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
356 Added TODO about stopping simultaneous operations.
358 2007-05-21 Murray Cumming <murrayc@murrayc.com>
360 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
361 * src/modest-mail-operation-queue.c:
362 (modest_mail_operation_queue_remove):
363 * src/modest-tny-account-store.c: When GErrors happen, give more clues
364 about where they happened.
366 2007-05-21 Murray Cumming <murrayc@murrayc.com>
368 * src/modest-ui-actions.c:
369 (modest_ui_actions_on_password_requested): Make sure that the remember
370 output parameter is always TRUE.
372 2007-05-21 Murray Cumming <murrayc@murrayc.com>
374 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
375 Show a OK/Cancel dialog if the error is a question, though we still do not
376 know anything more about what we are asking the user.
377 * src/widgets/modest-folder-view.c: (on_drag_data_received):
378 Fix an uninitialized variable (helper). This is a logic error, however.
380 2007-05-21 Christian Kellner <ckellner@openismus.com>
382 * src/modest-search.h:
383 Correct bit shifting in the ModestSearchFlags enum.
385 2007-05-21 Murray Cumming <murrayc@murrayc.com>
387 * src/modest-tny-account.c:
388 (modest_tny_account_new_from_server_account): Do not use the lsub and
389 check-all hard-coded IMAP options when using POP.
391 2007-05-21 Murray Cumming <murrayc@murrayc.com>
393 * src/modest-tny-account.c:
394 (modest_tny_account_new_from_server_account):
395 Use NULL for the secure-auth method for POP when Password auth has been
396 specified by the user, as we already do for IMAP. "auth=Login" causes
397 an error from camel or the server.
399 2007-05-17 Murray Cumming <murrayc@murrayc.com>
401 * src/maemo/modest-account-settings-dialog.c:
402 (create_page_account_details),
403 (modest_account_settings_dialog_set_account_name):
404 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
405 for the leave-on-server checkbox, rathr than just the checkbox, when
406 the protocol is not POP.
408 2007-05-17 Murray Cumming <murrayc@murrayc.com>
410 * src/widgets/modest-account-view.c:
411 * src/widgets/modest-account-view.h:
412 Added modest_account_view_select_account() which will be useful later
413 to asynchronously re-select the edited account.
415 2007-05-17 Murray Cumming <murrayc@murrayc.com>
417 * src/maemo/modest-account-settings-dialog.c:
418 (modest_account_settings_dialog_set_account_name):
419 Automatically choose the port numbers based on the secure authentication
420 methods, if they have not been chosen before.
421 This fixes projects.maemo.org bug NB#56273 .
423 2007-05-17 Murray Cumming <murrayc@murrayc.com>
425 * src/maemo/modest-main-window-ui.h:
426 * src/modest-ui-actions.c:
427 * src/modest-ui-actions.h:
428 Connect the Tools/SMTP Servers menu item to
429 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
430 SMTP servers dialog, as in the UI specification and saves changes when it
431 is closed. This fixed projects.maemo.org bug NB#56305 .
433 2007-05-17 Murray Cumming <murrayc@murrayc.com>
435 * src/maemo/modest-connection-specific-smtp-window.c:
436 (modest_connection_specific_smtp_window_init):
437 Use gtk_window_set_default_size() to make this window big enough, so
438 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
440 2007-05-17 Murray Cumming <murrayc@murrayc.com>
442 * src/maemo/modest-connection-specific-smtp-edit-window.h:
443 * src/maemo/modest-connection-specific-smtp-edit-window.c:
444 (modest_connection_specific_smtp_edit_window_init),
445 Do not try to connect to a combobox signal before the combobox exists.
446 This fixes the cras in projects.maemo.org bug NB#56288 .
447 (modest_connection_specific_smtp_edit_window_get_settings):
448 Remove the server_account_name parameter which was being checked for NULL
449 though it was not used.
451 * src/maemo/modest-connection-specific-smtp-window.c:
452 (modest_connection_specific_smtp_window_fill_with_connections),
453 (on_button_edit), (modest_connection_specific_smtp_window_init):
454 Correct the number of treemodel columns to prevent a warning.
455 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
456 libconic does not work.
458 2007-05-16 Murray Cumming <murrayc@murrayc.com>
460 * src/modest-tny-account.c:
461 (modest_tny_account_new_from_server_account):
462 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
463 SMTP when "None" was chosen by the user. However, with my SMTP server that
464 does not support ANONYMOUS, the emails do not leave the Outbox and I see
467 2007-05-16 Murray Cumming <murrayc@murrayc.com>
469 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
470 to explain the memory management issue with the ID in the ModestPair.
472 * src/gnome/modest-account-assistant.c: (add_receiving_page),
473 (add_sending_page), (modest_account_assistant_finalize):
474 * src/gnome/modest-gnome-global-settings-dialog.c:
475 (create_updating_page), (create_composing_page):
476 * src/gnome/modest-msg-edit-window.c: (get_transports),
477 (init_window), (modest_msg_edit_window_finalize),
478 (modest_msg_edit_window_get_msg_data):
479 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
480 * src/gnome/modest-transport-widget.c:
481 (modest_transport_widget_finalize), (smtp_configuration):
482 * src/maemo/modest-maemo-global-settings-dialog.c:
483 (create_updating_page), (create_composing_page):
484 * src/maemo/modest-msg-edit-window.c: (get_transports),
485 (init_window), (modest_msg_edit_window_finalize),
486 (modest_msg_edit_window_get_msg_data),
487 (modest_msg_edit_window_free_msg_data):
488 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
489 (modest_store_widget_finalize):
490 * src/maemo/modest-transport-widget.c:
491 (modest_transport_widget_finalize), (smtp_configuration):
492 * src/modest-main.c: (send_mail):
493 * src/widgets/modest-combo-box.h:
494 * src/widgets/modest-global-settings-dialog-priv.h:
495 * src/widgets/modest-global-settings-dialog.c:
496 (modest_global_settings_dialog_finalize):
497 * src/widgets/modest-msg-edit-window.h:
498 Whenever using modest_combo_box_new(), keep the ModestPairList alive
499 as long as the combo box, to prevent use of freed memory for the ID.
501 2007-05-15 Murray Cumming <murrayc@murrayc.com>
503 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
504 get_accounts(), to make this clearer. Do not check for the enabled gconf
505 key, because we do not use this for server accounts (at least, not yet).
506 This allows us to send email again.
508 2007-05-15 Murray Cumming <murrayc@murrayc.com>
510 * src/maemo/modest-platform.c:
511 (on_modest_conf_update_interval_changed), (modest_platform_init):
512 Only respond to this particular key change. All these strcmp()s cannot be
515 2007-05-15 Murray Cumming <murrayc@murrayc.com>
517 * src/maemo/modest-maemo-global-settings-dialog.c:
518 (current_connection): Prevent a crash in scratchbox when
519 ny_maemo_conic_device_get_current_iap_id() returns NULL.
520 * src/maemo/modest-platform.c:
521 (on_modest_conf_update_interval_changed), (modest_platform_init):
522 Get the update interval from gconf and reset it when the gconf key changes.
524 2007-05-15 Murray Cumming <murrayc@murrayc.com>
526 * src/modest-protocol-info.c:
527 * src/modest-protocol-info.h: Adde enum-specific get functions,
528 instead of using a ModestProtocolType enum parameter.
530 * src/gnome/modest-account-assistant.c:
531 * src/gnome/modest-store-widget.c:
532 * src/gnome/modest-store-widget.h:
533 * src/gnome/modest-transport-widget.c:
534 * src/gnome/modest-transport-widget.h:
535 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
536 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
537 * src/maemo/easysetup/modest-easysetup-wizard.c:
538 * src/maemo/modest-account-settings-dialog.c:
539 * src/maemo/modest-account-settings-dialog.h:
540 * src/maemo/modest-store-widget.c:
541 * src/maemo/modest-store-widget.h:
542 * src/maemo/modest-transport-widget.c:
543 * src/maemo/modest-transport-widget.h:
544 * src/modest-account-mgr-helpers.c:
545 * src/modest-account-mgr-helpers.h:
546 * src/modest-account-mgr.c:
547 * src/modest-account-mgr.h:
548 * src/modest-tny-account.c:
549 * src/modest-tny-folder.c:
550 * src/widgets/modest-account-view.c:
551 * src/widgets/modest-retrieve-combo-box.c:
552 * src/widgets/modest-retrieve-combo-box.h:
553 * src/widgets/modest-secureauth-combo-box.c:
554 * src/widgets/modest-serversecurity-combo-box.c:
555 * src/widgets/modest-serversecurity-combo-box.h:
556 * tests/check_account-mgr.c:
557 Use the specific functions, and use the re-renamed enum values for GNOME too.
559 2007-05-15 Murray Cumming <murrayc@murrayc.com>
562 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
563 so we can get the second based on the first.
565 * src/maemo/modest-account-settings-dialog.h:
566 * src/maemo/modest-account-settings-dialog.c:
567 Added get_supported_secure_authentication_methods(), though it is mostly
568 commented-out for now until the necessary API is committed to tinymail.
569 (modest_account_settings_dialog_set_account_name),
570 (save_configuration): Request the supported authentication methods from the
571 server, so we can choose a working method.
573 * src/modest-tny-account-store.h:
574 * src/modest-tny-account-store.c:
575 (modest_tny_account_store_get_session): Rename from
576 tny_account_store_get_session().
578 2007-05-14 Murray Cumming <murrayc@murrayc.com>
580 * src/modest-protocol-info.h: Split the ModestProtocol enum
581 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
582 There was no need to have these unrelated values in one enum.
584 * src/: many files: Adapted to changed enum. This makes the code a bit
585 clearer, and the compiler could catch some errors.
587 2007-05-14 Murray Cumming <murrayc@murrayc.com>
589 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
590 Show the detailed internal camel error message when an error happens
591 during the configuration, so that our testers can give us more clues.
592 For instance, in projects.maemo.org bug NB#56910 .
594 2007-05-14 Murray Cumming <murrayc@murrayc.com>
596 * src/modest-tny-account.c:
597 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
598 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
600 2007-05-14 Murray Cumming <murrayc@murrayc.com>
602 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
603 * src/maemo/modest-account-settings-dialog.c:
604 (modest_account_settings_dialog_set_account_name),
605 (save_configuration): For the incoming secure authentication checkbox,
606 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
607 the UI specification. PLAIN does not seem to be supported for most IMAP
608 servers anyway, and I am not sure what it would mean.
609 However, we probably need to discover which of the secure-authentication
610 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
611 * src/modest-account-mgr-helpers.c:
612 (modest_account_mgr_get_server_account_data):
614 * src/modest-tny-account.c:
615 (modest_tny_account_new_from_server_account):
616 Use tny_account_set_mech() to set secure-authentication methods,
617 with some special-casing for IMAP, based on my observations of how
620 * src/modest-account-mgr-helpers.h:
621 * src/modest-account-mgr.c:
622 * src/modest-defs.h: Comment that the URI is only used for local folders.
624 2007-05-11 Murray Cumming <murrayc@murrayc.com>
626 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
627 parameter const, just to be neat.
628 * src/modest-text-utils.c: (modest_text_utils_inline):
629 End g_strconcat() with NULL, as its documentation says. This is almost
630 certainly the cause of my crash at startup on the device. Interestingly,
631 valgrind doesn't tell us about these errors.
633 2007-05-11 Murray Cumming <murrayc@murrayc.com>
635 * scripts/build-packages: Added more precise comments about how to use
636 this script, though I still get this error:
637 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
638 error building tinymail
640 2007-05-11 Murray Cumming <murrayc@murrayc.com>
642 * src/maemo/modest-main-window.c: (on_account_update):
643 Very slight cleanup, hoping to make it simpler to discover what causes
644 a crash here sometimes.
646 * src/modest-tny-account.c:
647 (modest_tny_account_new_from_server_account): Set the port. Added
648 comments about the options and a TODO comment because I need to find out
649 how to specify the secure authentication method.
651 2007-05-11 Marcus Bauer <marcusb@openismus.com>
653 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
654 changed CFlags paths form modest to libmodest
656 2007-05-10 Murray Cumming <murrayc@murrayc.com>
658 * src/modest-account-mgr-helpers.c:
659 (modest_account_mgr_get_server_account_data),
660 (modest_account_mgr_free_server_account_data):
661 * src/modest-account-mgr-helpers.h:
662 * src/modest-account-mgr.c:
663 (modest_account_mgr_add_server_account):
665 * src/modest-tny-account.c:
666 (modest_tny_account_new_from_server_account):
667 Determine the options for tny_camel_account_add_option() here,
668 based on the settings, rather than storing them directly in gconf.
670 2007-05-10 Murray Cumming <murrayc@murrayc.com>
672 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
673 Show a more friendly error dialog now that we expect (from the tinymail
674 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
676 2007-05-10 Murray Cumming <murrayc@murrayc.com>
678 * src/maemo/modest-main-window.c: (on_account_update): Check that
679 account_name is not NULL, to prevent a crash at startup that I am
680 seeing on the N800. I do wonder why it is NULL.
682 * src/maemo/easysetup/modest-easysetup-wizard.c:
683 (create_page_user_details):
684 * src/maemo/modest-account-settings-dialog.c:
685 (create_page_user_details), (create_page_outgoing):
686 * src/maemo/modest-connection-specific-smtp-edit-window.c:
687 (modest_connection_specific_smtp_edit_window_init):
688 * src/modest-ui-actions.c:
689 (modest_ui_actions_on_password_requested):
690 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
691 might do something useful with the on-screen keyboard.
693 2007-05-10 Murray Cumming <murrayc@murrayc.com>
695 * src/maemo/modest-main-window.c: (on_account_update):
696 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
697 NULL, to avoid lots of warnings. However, it probably should not be NULL.
699 2007-05-09 Murray Cumming <murrayc@murrayc.com>
701 * src/modest-tny-account-store.c: (on_account_changed):
702 Correct the signature of this signal handler.
704 2007-05-09 Murray Cumming <murrayc@murrayc.com>
706 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
707 Show a HildonNote instead of a GtkDialog for Maemo.
709 2007-05-09 Murray Cumming <murrayc@murrayc.com>
711 * src/widgets/modest-account-view.h:
712 * src/widgets/modest-account-view.c: (on_account_changed),
713 (on_account_removed). Added a boolean flag, set/unset by
714 modest_account_view_block_conf_updates(),
715 modest_account_view_unblock_conf_updates() to prevent unnecessary
716 updates, but this is not very useful because the gconf notifications are
717 so delays (maybe only on Maemo Bora).
718 So auto-updating is turned off, and these functions do an explicit
719 update when necessary.
720 However, something else is still doing too much work when adding/removing
721 accounts, probably in another part of the application.
723 * src/maemo/modest-account-view-window.c:
724 (on_delete_button_clicked), (on_edit_button_clicked),
725 (on_new_button_clicked): Use the new functions.
727 2007-05-09 Murray Cumming <murrayc@murrayc.com>
729 * src/modest-account-mgr-helpers.c:
730 (modest_account_mgr_set_first_account_as_default):
731 Sort the list of names alphabetically-by-title, so we choose the first one
733 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
734 alphabetically by the title.
736 This fixes projects.maemo.org bug NB#56418 .
738 * src/modest-account-mgr-priv.c:
739 (_modest_account_mgr_account_from_key):
740 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
741 avoid a valgrind error, and possible random behaviour.
743 2007-05-09 Murray Cumming <murrayc@murrayc.com>
745 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
746 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
747 tinymail documentation to say that this can be expected.
748 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
749 pretty, and should not happen, but I would prefer to know when it does.
751 2007-05-09 Murray Cumming <murrayc@murrayc.com>
753 * configure.ac: When using the older hildon version, probably on Bora,
754 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
756 * src/widgets/modest-attachment-view.c:
757 (modest_attachment_view_set_part_default): Initialize variables, to fix the
760 2007-05-09 Marcus Bauer <marcusb@openismus.com>
762 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
763 Implemented the prototype. Can be tested with
764 tests/dbus_api/test_open_message:
766 2007-05-08 Murray Cumming <murrayc@murrayc.com>
768 * src/modest-tny-account-store.c:
769 (modest_tny_account_store_instance_init), (get_password):
770 * src/modest-ui-actions.c:
771 (modest_ui_actions_on_password_requested):
772 Do not store the password in gconf, because this function is called
773 for non-remembered passwords. Actually use the cached (in the hash map)
774 password instead of releasing it.
775 The password will now not be remembered if it is asked via the protected
776 password dialog, as per the UI spec.
778 2007-05-08 Murray Cumming <murrayc@murrayc.com>
781 * src/modest-account-mgr-helpers.h:
782 * src/modest-account-mgr-helpers.c:
783 Added modest_server_account_get_username_has_succeeded(),
784 modest_server_account_set_username_has_succeeded().
785 (modest_server_account_set_username),
786 Reset the has-succeeded flag if the username changes.
788 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
789 * src/maemo/modest-connection-specific-smtp-window.c:
790 (modest_connection_specific_smtp_window_save_server_accounts):
791 Use modest_server_account_set_username() instead of using
792 modest_conf_set_string() directly, so that the has-succeeded flag is always
795 * src/modest-ui-actions.c:
796 (modest_ui_actions_on_password_requested): Dim the username entry if
797 the username has ever worked, as per the UI spec.
799 2007-05-08 Murray Cumming <murrayc@murrayc.com>
801 * src/modest-tny-account-store.c: (get_password):
802 * src/modest-ui-actions.c:
803 (modest_ui_actions_on_password_requested):
804 Allow the username to be changed too, though there is more work to
805 be done on exactly how this behaves.
807 2007-05-08 Murray Cumming <murrayc@murrayc.com>
809 * src/modest-account-mgr-helpers.h:
810 * src/modest-account-mgr-helpers.c:
811 Added modest_account_mgr_get_display_name(),
812 modest_server_account_get_username(),
813 modest_server_account_set_username(),
814 modest_server_account_set_password(),
815 modest_server_account_get_hostname() functions so we do not need to
816 use the conf API directly.
818 * src/maemo/modest-main-window.c: (connect_signals):
819 Actually connect ot the ModestAccountStore::request-password signal,
820 so that we show the dialog when the password is requested by Tinymail,
821 for isntance if it is empty.
823 * src/modest-marshal.list:
824 * src/modest-tny-account-store.c:
825 (modest_tny_account_store_class_init), (get_password),
826 (modest_tny_account_store_alert):
827 * src/modest-tny-account-store.h:
828 * src/modest-ui-actions.h:
829 * src/modest-ui-actions.c:
830 (modest_ui_actions_on_password_requested):
831 Change the signal parameters, so it is obvious that we are providing
832 the non human-readable server name, and receiving both the username
833 and password, though changing of the username is not yet implemented.
834 Change the dialog UI to match the Maemo UI specifications, with #idfefing
835 for the GNOME version.
837 This should fix the projects.maemo.org bug NB#56209, though it does not
838 work on Bora, because the gconf_client_get() for the password fails
839 immediately after we save it with gconf_client_set().
841 2007-05-08 Murray Cumming <murrayc@murrayc.com>
844 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
845 caused an undefined symbol error:
846 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
848 2007-05-08 Murray Cumming <murrayc@murrayc.com>
850 * src/modest-tny-account-store.c:
851 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
852 using a GError instead of a string message, so we can translate it in
855 2007-05-08 Murray Cumming <murrayc@murrayc.com>
857 * src/maemo/modest-address-book.c:
858 (modest_address_book_check_names):
859 * src/maemo/modest-msg-view-window.c:
860 (modest_msg_view_window_clipboard_owner_change):
861 * src/modest-init.c: (modest_init_init_ui):
862 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
863 (update_folders_cb), (modest_mail_operation_update_account):
864 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
865 (modest_ui_actions_on_msg_attachment_clicked),
866 (modest_ui_actions_on_msg_recpt_activated):
867 * src/widgets/modest-header-view.c: (drag_data_get_cb):
868 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
869 (modest_msg_view_search_next):
870 * src/widgets/modest-recpt-editor.c:
871 (modest_recpt_editor_on_button_release_event),
872 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
873 g_message(). At this point we should only be seeing interesting errors on
874 stdout. Debugging messages could be #ifdefed-out if they are still useful.
876 2007-05-07 Murray Cumming <murrayc@murrayc.com>
878 (modest_wizard_dialog_force_title_update):
879 * src/maemo/easysetup/modest-wizard-dialog.h:
880 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
881 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
882 can update the title when appropriate. Otherwise the title is wrong if the
883 pages are added after adding the notebook to the dialog.
884 This must be a problem in HildonWizardDialog too.
885 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
887 * src/maemo/easysetup/modest-easysetup-wizard.c:
888 (create_subsequent_customsetup_pages),
889 (create_subsequent_easysetup_pages):
890 Call modest_wizard_dialog_force_title_update() so that the title is
891 correct even with GTK+ < 2.10.
892 This fixes projects.maemo.org bug NB#56145 .
894 2007-05-07 Murray Cumming <murrayc@murrayc.com>
896 * src/maemo/modest-platform.c:
897 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
898 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
901 2007-05-07 Murray Cumming <murrayc@murrayc.com>
903 * src/widgets/modest-window.h:
904 * src/widgets/modest-window.c: Added a save_state_func vfunc,
905 and modest_window_save_state(), which invokes it.
907 * src/widgets/modest-window-mgr.h:
908 * src/widgets/modest-window-mgr.c:
909 Added modest_window_mgr_save_state_for_all_windows(), which calls
910 the save_state vfunc on all registered windows, if implemented.
912 * src/gnome/modest-msg-edit-window.c:
913 * src/gnome/modest-msg-view-window.c:
914 * src/maemo/modest-msg-edit-window.c:
915 * src/maemo/modest-msg-view-window.c:
916 * src/maemo/modest-main-window.c:
917 Specify the existing save_settings functions as implementations of
918 ModestWindow::save_state_func().
920 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
921 Call modest_window_mgr_save_state_for_all_windows(). This happens before
922 enabling hibernation, for instance.
924 We may need to do the same thing for restoring settings.
927 2007-05-07 Murray Cumming <murrayc@murrayc.com>
929 * src/widgets/modest-window-mgr.c:
930 * src/widgets/modest-window-mgr.h:
931 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
932 modest_window_mgr_get_hibernation_is_prevented().
934 * src/maemo/modest-main-window.c:
935 (on_hildon_program_is_topmost_notify): Prevent hibernation
936 (possible when the application goes to the background in the WM),
937 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
939 * src/maemo/easysetup/modest-easysetup-wizard.c:
940 (modest_easysetup_wizard_dialog_init):
941 * src/maemo/modest-account-settings-dialog.c:
942 (modest_account_settings_dialog_init):
943 * src/maemo/modest-connection-specific-smtp-edit-window.c:
944 (modest_connection_specific_smtp_edit_window_init):
945 * src/maemo/modest-connection-specific-smtp-window.c:
946 (modest_connection_specific_smtp_window_init):
947 * src/maemo/modest-signature-editor-dialog.c:
948 (modest_signature_editor_dialog_init):
949 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
950 prevent hibernation while any of these account settings dialogs are open.
952 2007-05-04 Murray Cumming <murrayc@murrayc.com>
954 * src/maemo/Makefile.am:
955 * src/maemo/modest-osso-state-saving.c:
956 * src/maemo/modest-osso-state-saving.h: Added
957 modest_osso_load_state() and modest_osso_save_state() though they do
958 nothing now. They should iterate through all the open windows and load/save
960 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
961 save state when closing.
963 * src/maemo/modest-main-window.c:
964 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
965 Add a notification handler for the HildonProgram::is-topmost property,
966 so we can allow hibernation when the application goes into the background.
967 But we still need to detect when the accounts setup windows are open so
968 we can stop hibernation when they are open.
969 To do this, I also added the main window the HildonProgram. This might have
970 other side-effects/benefits, and should maybe be done for other windows.
972 * src/maemo/modest-osso-autosave-callbacks.h:
973 * src/maemo/modest-osso-autosave-callbacks.c:
974 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
975 though it does not do anything yet, and we might never need this to do
976 anything. For instance, we already save drafts.
978 * src/maemo/modest-platform.c: (modest_platform_init):
979 Specify the libosso auto-save callback.
981 2007-05-03 Murray Cumming <murrayc@murrayc.com>
983 * src/maemo/modest-platform.c:
984 (modest_platform_set_update_interval):
985 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
986 aparently stays valid between application instances, so we can use this
987 to remove and reset it later. According to a maemo-developers email from
990 2007-05-03 Murray Cumming <murrayc@murrayc.com>
992 * configure.ac: Depend on libalarm for Maemo.
994 * src/dbus_api/modest-dbus-api.h:
995 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
996 (on_send_receive), (modest_dbus_req_handler):
997 Handle a SEND_RECEIVE D-Bus method.
999 * libmodest-dbus-client/libmodest-dbus-client.c:
1000 (libmodest_dbus_client_send_and_receive):
1001 * libmodest-dbus-client/libmodest-dbus-client.h:
1002 Add C convenience functions for calling the new D-Bus method.
1004 * src/modest-platform.h:
1005 * src/gnome/modest-platform.c:
1006 * src/maemo/modest-platform.c:
1007 Added modest_platform_set_update_interval(), which uses the
1008 alarmd API on Maemo.
1009 (modest_platform_init),
1010 Call modest_platform_set_update_interval(), using a hard-coded
1011 interval for now (until the global settings dialog is implemented),
1012 though I am not sure that this makes sense yet.
1014 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1016 * src/dbus_api/modest-dbus-callbacks.c:
1017 (modest_osso_cb_hw_state_handler):
1018 * src/dbus_api/modest-dbus-callbacks.h:
1019 * src/maemo/modest-platform.c: (modest_platform_init):
1020 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1021 in case this has some effect on the ability for Maemo to ping the
1024 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1026 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1027 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1028 warning. It is probably a logic error, but I need to fix the build.
1030 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1032 * src/modest-account-mgr.h:
1033 * src/modest-account-mgr.c:
1034 (modest_account_mgr_account_names): Add a gboolean enabled_only
1035 parameter, so we can get lists of onlt the enabled accounts.
1037 (modest_account_mgr_add_account),,
1038 (modest_account_mgr_account_with_display_name_exists):
1039 * src/maemo/modest-msg-edit-window.c: (get_transports):
1040 * src/modest-account-mgr-helpers.c:
1041 (modest_account_mgr_set_first_account_as_default):
1042 * src/modest-init.c: (init_default_account_maybe):
1043 * src/modest-tny-account-store.c: (get_accounts):
1044 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1045 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1046 * tests/check_account-mgr.c: (START_TEST):
1047 Provide the extra parameter, as appropriate.
1049 * src/widgets/modest-account-view.c: (update_account_view):
1050 Do not show disabled accounts (meaning that there is no way to
1051 enable/disable accounts in the UI (the feature is not in our UI
1052 specification), so we can use this internally only to mark unfinished
1053 or temporary account data.
1055 * src/maemo/easysetup/modest-easysetup-wizard.c:
1056 (create_account): Add boolean enable parameter, so we can specify FALSE
1057 to create the temporary account.
1058 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1059 (on_before_next): When finishing, when there is a temporary account, just
1061 Also, use a timeout to delay the showing of the dialog until gconf is likely
1062 to return correct information, due to a maemo gconf bug that is fixed in
1063 osso 1.1, but not yet in Bora.
1064 However, the dialog stays on screen after it is destroyed.
1066 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1067 for invalid data when cancelling. Use a hildon note instead of a dialog
1068 to complain about invalid data. Do not show the account-saved note if the
1069 account is disabled (a temporary account that will not really be saved for use
1072 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1074 * src/modest-account-mgr-helpers.h:
1075 * src/modest-account-mgr-helpers.c:
1076 Added modest_account_mgr_unset_default_account(),
1077 Added modest_account_mgr_set_first_account_as_default().
1079 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1080 If it was the default account, unset the default account name.
1082 * src/maemo/modest-account-view-window.c:
1083 (on_delete_button_clicked): If it was the default account,
1084 set the first remaining account as the default instead.
1086 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1087 a NULL account or a NULL default account, to prevent a crash. This should
1088 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1091 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1093 * src/widgets/modest-recpt-editor.c:
1094 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1095 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1096 TODO comment for this. This fixes the build.
1098 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1099 be the best place for it. This will in future update all auto-update accounts,
1100 rather than just the current/default account, when that gconf key exists.
1101 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1102 if there are no accounts, before calling do_send_receive().
1103 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1105 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1106 * src/maemo/modest-main-window-ui.h:
1107 * src/maemo/modest-main-window.c: (on_connection_changed),
1108 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1109 directly, becaue the signal handler does more.
1111 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1113 * src/modest-account-mgr-helpers.c:
1114 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1115 for the case that the account does not exist.
1117 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1118 (equivalent to the modest account name) rather than the tinymail account name
1119 (equivalent to the modest account title - human readable) to get the account data.
1120 Check for null account data to prevent the crash, and add a TODO comment saying that
1121 this needs fixing because it is using the server account name instead of the account name.
1123 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1125 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1126 * src/maemo/modest-account-settings-dialog.c: (show_error),
1128 Use hildon_note_new_information() for informative and error messages,
1129 which seems to be expected for Maemo applications (no documentation that I know of
1130 says this). I am surprised that there is no distinction between info and error
1133 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1135 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1136 it is easy to find where this is used.
1138 * src/maemo/easysetup/modest-easysetup-wizard.c:
1139 (create_page_welcome), (create_page_account_details),
1140 (create_page_user_details), (create_page_complete_easysetup),
1141 (create_page_custom_incoming), (create_page_custom_outgoing),
1142 (create_page_complete_custom):
1143 * src/maemo/modest-account-settings-dialog.c:
1144 (create_page_account_details), (create_page_user_details),
1145 (create_page_incoming), (create_page_outgoing):
1146 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1147 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1148 (modest_connection_specific_smtp_edit_window_init):
1149 * src/maemo/modest-connection-specific-smtp-window.c:
1150 (modest_connection_specific_smtp_window_init):
1151 * src/maemo/modest-signature-editor-dialog.c:
1152 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1153 and scrolling policy as per the Email Application Layout Guide, if I have
1156 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1158 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1159 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1160 which were empty, because these vfuncs have been removed from TnyAccountStore.
1161 This fixes the build.
1163 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1165 * src/maemo/modest-main-window.c:
1166 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1167 showing/hiding it. Added TODO because it probably should not be NULL.
1168 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1169 because unnecessary g_warnings() make degugging difficult.
1171 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1173 * src/maemo/modest-msg-edit-window.c:
1174 (modest_msg_edit_window_select_color),
1175 (modest_msg_edit_window_select_background_color): 2 const corrections and
1176 moving 2 #endifs before closing brackets, to fix the build.
1178 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1180 * src/maemo/easysetup/modest-easysetup-wizard.h:
1181 * src/maemo/easysetup/modest-easysetup-wizard.c:
1182 (modest_easysetup_wizard_dialog_finalize),
1183 (on_button_edit_advanced_settings), (create_page_complete_custom),
1184 (on_response), (create_account):
1185 Implement the Advanced Settings edit button, by saving the account information,
1186 for the Advanded Settings dialog to use directly from gconf, and removing it
1187 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1188 Bug #5533 in the projects.maemo.org bugzilla.
1190 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1192 * src/maemo/modest-msg-view-window.c:
1193 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1194 when opening a message window.
1196 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1198 * src/maemo/easysetup/modest-easysetup-wizard.c:
1199 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1202 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1203 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1204 gconf settings. I probably added more checks than necessary, but that is safer.
1206 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1207 variable to fix the build, but this seems to be used when it is still NULL.
1209 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1211 * src/modest-platform.h:
1212 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1213 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1214 * src/modest-main.c: Implement this function so we can avoid using
1215 maemo-specific API from cross-platform code.
1217 * src/modest-tny-account-store.c:
1218 (get_smtp_specific_transport_account_for_open_connection):
1219 * src/modest-ui-actions.c: (check_for_connection),
1220 (modest_ui_actions_on_item_not_found):
1221 Use modest_platform_connect_and_wait() and put #idefs around other
1222 maemo-specific code, because only maemo currently has a way to
1223 identify connection names.
1225 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1227 * src/modest-tny-account-store.h:
1228 * src/modest-tny-account-store.c:
1229 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1230 the connection-specific SMTP server settings in the configuration.
1232 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1234 * src/maemo/modest-main-window.c: (on_connection_changed),
1236 * src/modest-main.c: (main), (start_ui), (send_mail):
1237 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1238 that is what is intended.
1240 * src/modest-ui-actions.c: (action_send), (action_receive),
1241 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1242 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1243 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1244 SMTP server is used when it is specified.
1246 (modest_ui_actions_on_send_receive):
1247 Check that a connection is open before proceeding.
1248 Receive and then send, instead of vice-versa, as per the specification.
1250 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1252 * src/modest-mail-operation.c:
1253 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1254 though I guess it should be something other than NULL.
1256 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1258 * src/maemo/easysetup/modest-easysetup-wizard.c:
1259 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1260 combo twice, to avoid an g_warning and to make it visible again.
1261 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1262 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1263 (already intended) dereference when detaching, because we then recreate the menu.
1264 But I am not sure why the warning was happening, and it is possible that this is a memory
1267 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1269 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1270 and uri_parse_mailto() utility functions.
1271 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1273 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1275 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1277 * src/dbus_api/modest-dbus-api.h:
1278 * src/dbus_api/modest-dbus-callbacks.c:
1279 Use an idle callback to execute the modest code in the application's own thread.
1280 Remove the helloworld example method.
1281 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1282 parsed, and the open-message method is not implemented because this is not yet implemented in
1284 * libmodest-dbus-client/libmodest-dbus-client.c:
1285 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1286 (libmodest_dbus_client_open_message):
1287 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1289 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1290 body without crashing.
1292 * tests/dbus_api/Makefile.am:
1293 * tests/dbus_api/test_mail_to.c:
1294 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1296 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1298 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1299 Added file to fix the build. Sorry.
1301 * src/dbus_api/Makefile.am:
1302 * src/dbus_api/modest-dbus-api.h:
1303 * src/dbus_api/modest-dbus-callbacks.h:
1304 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1305 (modest_dbus_req_handler):
1306 Put constants in a separate header so it can be reused by the
1307 client library, without duplication
1309 * libmodest-dbus-client/Makefile.am:
1310 * libmodest-dbus-client/libmodest-dbus-client.c:
1311 (libmodest_dbus_client_call_helloworld),
1312 (libmodfest_dbus_client_send_mail),
1313 (libmodfest_dbus_client_mailto),
1314 (libmodfest_dbus_client_open_message):
1315 * libmodest-dbus-client/libmodest-dbus-client.h:
1316 (Partly) Implement a send_mail D-Bus method.
1318 * tests/dbus_api/Makefile.am:
1319 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1320 the send_email D-Bus method.
1322 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1326 * libmodest-dbus-client/Makefile.am:
1327 * libmodest-dbus-client/libmodest-dbus-client.c:
1328 * libmodest-dbus-client/libmodest-dbus-client.h:
1329 * tests/dbus_api/Makefile.am:
1330 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1331 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1333 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1335 * src/maemo/easysetup/modest-easysetup-wizard.c:
1336 (create_page_account_details):
1337 * src/maemo/modest-account-settings-dialog.c:
1338 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1339 widgets, because this might not be the default in future versions of the Maemo GTK+.
1340 However, I can not not get capitalization to work even in a simple test case.
1342 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1344 * src/maemo/easysetup/modest-easysetup-wizard.c:
1345 (create_page_custom_incoming), (create_page_custom_outgoing):
1346 * src/maemo/modest-account-settings-dialog.c:
1347 (create_page_account_details), (create_page_incoming),
1348 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1349 instead of using gtk_check_button_with_label(), so they are aligned like the other
1350 widgets, as per the UI spec.
1352 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1354 * src/maemo/easysetup/modest-easysetup-wizard.c:
1355 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1356 * src/widgets/modest-validating-entry.c:
1357 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1358 Modest prefix instead of an EasySetup prefix.
1360 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1362 * src/widgets/modest-validating-entry.h:
1363 * src/widgets/modest-validating-entry.c: (on_insert_text),
1364 Added easysetup_validating_entry_set_max_func(), used to set a callback
1365 to call when the max number of characters is reached. GtkEntry has a max-length
1366 already but is silent about it.
1368 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1369 (create_page_account_details), (create_page_user_details),
1371 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1372 (create_page_account_details), (create_page_user_details),
1373 (create_page_outgoing):
1374 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1375 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1376 the UI spec, when the user tries to enter more than the max number of characters.
1378 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1380 * src/maemo/easysetup/modest-easysetup-wizard.c:
1381 (create_page_user_details), (create_page_custom_incoming),
1382 (create_page_custom_outgoing):
1383 * src/maemo/modest-account-settings-dialog.c:
1384 (create_page_user_details), (create_page_incoming),
1385 (create_page_outgoing):
1386 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1387 (modest_connection_specific_smtp_edit_window_init):
1388 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1389 not appropriate. Bad Maemo-specific defaults!.
1391 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1393 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1394 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1395 (modest_signature_editor_dialog_set_settings):
1396 Disable the label and textview when the checkbox is disabled, and use the
1397 specified (UI spec) default signature text.
1399 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1401 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1402 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1404 * src/modest-defs.h:
1405 * src/modest-account-mgr-helpers.h:
1406 * src/modest-account-mgr-helpers.c:
1407 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1409 * src/maemo/Makefile.am:
1410 * src/maemo/modest-signature-editor-dialog.c:
1411 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1414 * src/maemo/modest-account-settings-dialog.h:
1415 * src/maemo/modest-account-settings-dialog.c:
1416 (modest_account_settings_dialog_finalize), (on_button_signature),
1417 (save_configuration): Use the new dialog when the Edit button is pressed, and
1418 save the changes if necessary, as per the UI spec.
1420 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1422 * src/maemo/Makefile.am:
1423 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1424 based on maemo-develoers email from Dirk.
1426 * src/maemo/easysetup/modest-easysetup-wizard.c:
1427 (create_page_welcome), (create_page_account_details),
1428 (create_page_user_details), (create_page_complete_easysetup),
1429 (create_page_custom_incoming), (create_page_custom_outgoing),
1430 (create_page_complete_custom),
1431 (modest_easysetup_wizard_dialog_init):
1432 * src/maemo/modest-account-settings-dialog.c:
1433 (create_page_account_details), (create_page_user_details),
1434 (create_page_incoming), (create_page_outgoing),
1435 (modest_account_settings_dialog_init):
1436 * src/maemo/modest-connection-specific-smtp-window.c:
1437 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1439 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1441 * src/maemo/easysetup/modest-easysetup-wizard.c:
1442 (create_page_account_details), (create_page_custom_outgoing),
1443 (create_page_complete_custom):
1444 * src/maemo/modest-account-settings-dialog.c:
1445 (create_page_user_details), (create_page_incoming),
1446 (create_page_outgoing):
1447 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1448 (modest_connection_specific_smtp_edit_window_init):
1449 Use the correct (UI spec) port min/max, and use horizontal separators,
1452 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1454 * src/maemo/easysetup/modest-easysetup-wizard.c:
1455 (set_default_custom_servernames):
1456 * src/maemo/modest-account-settings-dialog.c:
1457 (create_page_incoming), (on_combo_outgoing_security_changed),
1458 (on_combo_incoming_security_changed), (create_page_outgoing),
1459 (modest_account_settings_dialog_set_account_name),
1460 (save_configuration):
1461 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1462 (on_combo_security_changed),
1463 (modest_connection_specific_smtp_edit_window_init),
1464 (modest_connection_specific_smtp_edit_window_set_connection),
1465 (modest_connection_specific_smtp_edit_window_get_settings):
1466 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1469 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1472 * src/maemo/easysetup/modest-easysetup-wizard.c:
1473 (create_page_custom_outgoing), (create_page_complete_custom):
1474 * src/maemo/modest-account-settings-dialog.c:
1475 (create_page_user_details), (create_page_outgoing):
1476 * src/maemo/modest-account-view-window.c: (button_box_new):
1477 Use changed logical IDs as per the most recent UI spec:
1478 mcen_bd_emailsetup_edit -> mcen_bd_edit
1479 mcen_bd_emailsetup_delete -> mcen_bd_delete
1480 mcen_bd_emailsetup_close -> mcen_bd_close
1482 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1486 * src/dbus_api/Makefile.am:
1487 * src/dbus_api/modest-dbus-callbacks.c:
1488 * src/dbus_api/modest-dbus-callbacks.h:
1489 * src/maemo/modest-platform.c: (modest_platform_init):
1490 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1492 * tests/Makefile.am:
1493 * tests/dbus_api/Makefile.am:
1494 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1496 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1498 * src/maemo/modest-account-settings-dialog.c:
1499 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1500 Removed unnecessary includes.
1502 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1504 * src/maemo/easysetup/modest-easysetup-wizard.c:
1505 * src/maemo/modest-account-settings-dialog.c:
1506 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1507 * src/widgets/Makefile.am:
1508 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1509 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1510 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1511 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1512 * src/widgets/modest-secureauth-combo-box.c:
1513 * src/widgets/modest-secureauth-combo-box.h:
1514 * src/widgets/modest-serversecurity-combo-box.c:
1515 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1516 made the GObject names more consistent with the rest of the Modest code.
1518 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1520 * src/maemo/easysetup/Makefile.am:
1521 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1522 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1523 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1524 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1525 * src/maemo/easysetup/modest-easysetup-wizard.c:
1526 * src/maemo/easysetup/modest-validating-entry.c:
1527 * src/maemo/easysetup/modest-validating-entry.h:
1528 * src/maemo/modest-account-settings-dialog.c:
1529 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1530 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1531 widgets/ because they are used outside of easysetup too. After checking in,
1532 svn will allow me to rename them too.
1534 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1536 * src/gnome/modest-msg-edit-window.c:
1537 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1538 linker error, to fix the build on the GNOME platform.
1539 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1540 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1541 ifdefed out to avoid a warning.
1543 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1545 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1546 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1547 some alternative for GTK+ 2.6.
1549 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1551 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1553 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1554 specified for EmailAccountsDialog in UI spec.
1556 * src/maemo/easysetup/modest-easysetup-wizard.c:
1557 * src/maemo/easysetup/modest-easysetup-wizard.h:
1558 * src/maemo/modest-account-settings-dialog.c:
1559 * src/maemo/modest-account-settings-dialog.h:
1560 Reuse a member window widget for the connection-specific SMTP server accounts,
1561 so we can tell it to create/save the accounts only if we actually save changes.
1563 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1564 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1565 (modest_connection_specific_smtp_edit_window_get_settings):
1566 Return a struct instance for temporarily remembering the entered data.
1568 * src/maemo/modest-connection-specific-smtp-window.h:
1569 * src/maemo/modest-connection-specific-smtp-window.c:
1570 (modest_connection_specific_smtp_window_finalize),
1571 (modest_connection_specific_smtp_window_fill_with_connections),
1573 (modest_connection_specific_smtp_window_save_server_accounts),
1574 (update_model_server_names): Do not actually save data until asked,
1575 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1577 (on_selection_changed),
1578 (modest_connection_specific_smtp_window_init): Disable the edit
1579 button when nothing is selected.
1581 * src/modest-account-mgr-helpers.c:
1582 * src/modest-account-mgr-helpers.h:
1583 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1586 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1588 * src/modest-account-mgr-helpers.h:
1589 * src/modest-account-mgr-helpers.c:
1590 (modest_account_mgr_get_unused_account_name),
1591 (modest_account_mgr_get_unused_account_display_name): Added these
1592 utility functions, to avoid code duplication.
1594 * src/maemo/easysetup/modest-easysetup-wizard.c:
1595 (create_page_account_details), (create_account):
1596 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1597 (on_combo_security_changed),
1598 (modest_connection_specific_smtp_edit_window_init),
1599 (modest_connection_specific_smtp_edit_window_save_settings):
1600 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1601 * src/maemo/modest-connection-specific-smtp-window.c:
1602 (modest_connection_specific_smtp_window_finalize),
1603 (modest_connection_specific_smtp_window_fill_with_connections),
1604 (on_button_edit), (modest_connection_specific_smtp_window_init):
1605 * src/maemo/modest-connection-specific-smtp-window.h:
1606 Implementing saving of connection-specific server accounts.
1608 But I need to refactor this so we can save the data for each
1609 possible connection-specific account and only actually create the server accounts
1610 when the easysetup finished, or the OK button is pressed on the account settings
1613 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1615 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1616 (on_combo_security_changed):
1617 (modest_connection_specific_smtp_edit_window_init):
1618 Auto-fill the port number as in the account settings.
1620 (modest_connection_specific_smtp_edit_window_set_connection):
1621 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1622 * src/maemo/modest-connection-specific-smtp-window.c:
1623 (fill_with_connections), (on_button_edit),
1624 (modest_connection_specific_smtp_window_init):
1625 Turn the edit window into a dialog to simplify the code, and
1626 set a WM hint as in a GtkDialog, because only a popup can be on top of
1627 another window in Maemo, and popups usually have no WM decoration.
1629 * src/modest-defs.h:
1630 * src/modest-account-mgr-helpers.c:
1631 (modest_account_mgr_set_connection_specific_smtp),
1632 (modest_account_mgr_remove_connection_specific_smtp),
1633 (modest_account_mgr_get_connection_specific_smtp):
1634 * src/modest-account-mgr-helpers.h: Some functions to write the
1635 connection-specific SMTP server information. Not yet used.
1638 * src/widgets/modest-folder-view.c: (text_cell_data):
1639 Fix a warning about an uninitialized variable.
1640 (on_configuration_key_changed): Put an #ifdef around the use
1641 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1643 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1645 * src/maemo/modest-account-settings-dialog.h:
1646 * src/maemo/modest-account-settings-dialog.c:
1647 Added connect_for_modified() utility function to mark the new modified boolean.
1649 (create_page_account_details), (create_page_user_details),
1650 (create_page_incoming), (create_page_outgoing), (on_response),
1651 (modest_account_settings_dialog_init),
1652 (modest_account_settings_dialog_set_account_name):
1653 Only warn about unsaved changes when there are actually unsaved changes.
1655 * src/modest-account-mgr-helpers.c:
1656 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1657 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1658 to get the data from there in future.
1660 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1662 * src/modest-defs.h:
1664 * src/modest-account-mgr-helpers.h:
1665 * src/modest-account-mgr-helpers.c:
1666 Store the security account setting in a single conf key instead of using
1667 the options list, so that the list is left for just the to-be-removed camel hack,
1668 and because gconf_client_set_list() is failing for some reason.
1670 * src/modest-account-mgr.c:
1671 (modest_account_mgr_add_server_account):
1672 * src/maemo/modest-account-settings-dialog.c:
1673 (modest_account_settings_dialog_set_account_name),
1674 (save_configuration): Use the renamed functions.
1677 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1679 * src/widgets/Makefile.am:
1680 * src/widgets/modest-limit-retrieve-combo-box.c:
1681 * src/widgets/modest-limit-retrieve-combo-box.h:
1682 * src/widgets/modest-retrieve-combo-box.c:
1683 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1684 the account settings dialog.
1686 * src/modest-defs.h:
1687 * src/modest-account-mgr-helpers.h:
1688 * src/modest-account-mgr-helpers.c:
1689 (modest_server_account_get_option_secure_auth),
1690 (modest_server_account_set_option_secure_auth):
1691 * src/modest-account-mgr.c:
1692 (modest_account_mgr_add_server_account):
1693 Use the existing AUTH_MECH conf key for the secure-auth setting,
1694 instead of putting it in the list options, because this was actually used already.
1696 * src/maemo/modest-account-settings-dialog.c:
1697 (create_page_account_details),
1698 (modest_account_settings_dialog_set_account_name),
1699 (save_configuration):
1700 * src/maemo/modest-account-settings-dialog.h:
1701 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1702 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1704 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1706 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1707 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1708 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1710 * src/modest-defs.h:
1711 * src/maemo/modest-account-settings-dialog.c:
1712 (create_page_incoming), (on_combo_outgoing_security_changed),
1713 (on_combo_incoming_security_changed), (create_page_outgoing),
1714 (modest_account_settings_dialog_set_account_name),
1715 (save_configuration): Load/Save the port number, and change it when the
1716 security combo changes, to suitable defaults.
1718 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1720 * src/modest-account-mgr.c:
1721 (modest_account_mgr_add_server_account): Set the security and secure-auth
1722 options, and add a comment saying that the other camel-specific options should be
1725 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1727 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1729 * src/modest-tny-account-store.c: (account_list_free),
1730 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1731 cursor->data after unreffing it. But there is some strange stuff there so it might not be
1734 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1736 * src/modest-protocol-info.c:
1737 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1738 is required by our UI spec. Maybe something in our implementation will use this eventually.
1739 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1740 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1741 instead of the previous 0 placeholder.
1743 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1744 secure-auth settings.
1745 * src/modest-account-mgr-helpers.h:
1746 * src/modest-account-mgr-helpers.c:
1747 (modest_server_account_data_get_option_secure_auth),
1748 (modest_server_account_set_option_secure_auth),
1749 (modest_server_account_data_get_option_security),
1750 (modest_server_account_set_option_security): Added this API for getting and setting the security
1751 and secure-auth settings.
1753 * src/maemo/modest-account-settings-dialog.h:
1754 * src/maemo/modest-account-settings-dialog.c:
1755 (modest_account_settings_dialog_finalize), (check_data),
1756 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1757 about changing titles.
1758 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1759 (save_configuration): Save the security and secure-auth settings.
1761 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1762 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1764 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1766 * src/modest-defs.h:
1767 * src/modest-account-mgr.c:
1768 (modest_account_mgr_add_server_account):
1769 Added and used defines for the options key and value pair strings,
1770 that are used so far, though they do not seem to correspond to anything in our
1771 UI specs or ModestProtocol enum.
1773 * src/modest-account-mgr-helpers.h:
1774 * src/modest-account-mgr-helpers.c:
1775 (compare_option_strings_for_name),
1776 (modest_server_account_data_get_option_value),
1777 (modest_server_account_data_get_option_bool),
1778 (modest_account_mgr_get_server_account_option):
1779 Added helper functions for parsing the options GSList.
1781 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1783 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1784 display name is based on the supplied account name.
1785 * src/modest-account-mgr.c:
1786 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1787 with an inefficient, but good-enough, implementation.
1789 * src/maemo/easysetup/modest-easysetup-wizard.c:
1790 (create_page_account_details), (on_before_next), (create_account):
1791 Check for existing display names rather than (non-user-visible) account names, and just
1792 create and set a unique account name at the end.
1794 * src/maemo/modest-account-settings-dialog.c:
1795 (modest_account_settings_dialog_init),
1796 (modest_account_settings_dialog_set_account_name),
1797 (create_page_incoming): Show the display name, instead of the account name.
1798 (on_response): Do some (not all) extra checks, as in the UI spec.
1799 (save_configuration): Save the display name if it was changed.
1801 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1803 * po/en_GB.po: Added needed logical ID and translation.
1804 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1805 (init_view): Made the is-default column clicking work.
1807 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1810 * src/maemo/easysetup/Makefile.am:
1811 * src/maemo/easysetup/modest-easysetup-wizard.c:
1812 (modest_easysetup_wizard_dialog_init):
1813 * src/maemo/easysetup/provider-data-test.keyfile:
1814 * src/maemo/easysetup/provider-data.keyfile:
1815 Moved the provider data file to the new modest-providers-data package and used it from there.
1817 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1819 * src/modest-local-folder-info.c:
1820 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1821 N_() was already used on the static strings, but this just marks it for translation without
1822 using the translation.
1824 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1826 * src/maemo/modest-account-settings-dialog.c:
1827 (create_page_incoming),
1828 (modest_account_settings_dialog_set_account_name):
1829 Added comments about the need for new API in ModestAccountMgr to handle the authentication
1830 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1831 I will do this if nobody else gets there first.
1833 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1835 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1836 Saved much of the incoming and outgoing data too, though I cannot yet see how to
1837 save the security stuff.
1839 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1841 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1842 Set the email address and user fullname, which I now see must be
1845 * src/maemo/modest-account-settings-dialog.h:
1846 * src/maemo/modest-account-settings-dialog.c:
1848 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1849 leave-on-server and authentication.
1850 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1853 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1856 * src/maemo/modest-account-settings-dialog.c:
1857 * src/maemo/modest-account-settings-dialog.h:
1858 Most (but not all) of the widgets are now present as specified by the UI spec.
1859 No changes are yet saved, and some details are not properly shown yet.
1861 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1863 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1865 * src/maemo/Makefile.am:
1866 * src/maemo/modest-account-settings-dialog.c:
1867 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1868 an existing account. Doesn't do much yet.
1870 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1871 Open the accounts settings dialog when Edit is clicked.
1873 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1875 * src/maemo/easysetup/Makefile.am:
1876 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1878 * src/maemo/easysetup/modest-easysetup-wizard.c:
1879 (modest_easysetup_wizard_dialog_init):
1880 Try to get the source directory from the build system,
1881 instead of hard-coding "./" into the source code, when opening our local
1882 copies of the configuration files.
1883 But this still fails when opening the wizard from the Accounts window,
1884 maybe because the working directory seems to change at runtime.
1885 So the wizard will fail the second time unless you copy the files into their
1886 proper locations - see the stdout warnings for the paths.
1888 (create_page_account_details),(on_before_next):
1889 Check for existing non-server accounts instead of server accounts,
1890 so the default account name is useful again, and to prevent trying to
1893 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1894 Show the wizard when New is clicked.
1896 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1897 (init_view): Show the column headers, and show the columns that are
1898 specified in the UI specs. However, something in Maemo's GTK+ prevents
1899 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1900 change the default account. This is despite unsetting the special properties.
1902 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1904 * docs/reference/modest-design.sgml: Corrected spelling mistake.
1905 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1906 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1907 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1908 to make that clearer.
1909 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1911 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1913 * src/maemo/modest-account-view-window.c:
1914 (modest_account_view_window_init),
1915 (modest_account_view_window_new):
1916 Use the same buttons as specified in the
1917 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1918 the existing widgets, which never had a chance of working.
1919 Put the ModestAccountView treeview in a scrolled window.
1920 Do not repeat the initialization in both _init() and _new().
1922 * src/widgets/modest-account-view.c: (update_account_view):
1923 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1924 this widget and window shows no accounts.
1926 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1928 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1930 * src/maemo/easysetup/modest-easysetup-wizard.c:
1931 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1932 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1933 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1936 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1937 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1938 accounts exist yet, as in the UI spec.
1940 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
1942 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1944 * src/maemo/Makefile.am:
1945 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1946 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1947 New window for editing connection-specific smtp details.
1948 Not fully implemented.
1950 * src/maemo/modest-connection-specific-smtp-window.c:
1951 (modest_connection_specific_smtp_window_finalize) :
1952 unref the tree model.
1953 (on_button_edit): Show the edit window.
1955 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1957 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
1960 * src/maemo/Makefile.am:
1961 * src/maemo/modest-connection-specific-smtp-window.c:
1962 * src/maemo/modest-connection-specific-smtp-window.h:
1963 New window for showing the list of connections, for connection-specific
1964 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
1965 * src/maemo/easysetup/modest-easysetup-wizard.c:
1966 (create_page_custom_outgoing): Show the new window when the button is clicked.
1968 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1970 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1971 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1972 * src/maemo/modest-msg-edit-window.c:
1973 (modest_msg_edit_window_insert_image):
1974 * src/modest-conf.c: (modest_conf_key_escape):
1975 * src/modest-mail-operation.c:
1976 (modest_mail_operation_send_new_mail):
1977 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1978 (modest_ui_actions_on_new_account):
1979 * src/widgets/modest-attachment-view.c: (update_filename_request):
1980 * src/widgets/modest-mail-header-view.c:
1981 Corrected warnings that were breaking the build, by commenting out unused variables,
1982 and a function, and by including a header.
1984 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1986 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
1987 so we can #ifdef around platform-specific code when necessary.
1988 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
1989 to allow this to build for the GNOME platform too.
1991 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1993 * src/maemo/easysetup/modest-easysetup-wizard.c:
1994 Added util_increment_name() and used it in create_page_account_details()
1995 to make sure that the default account name is always a new name.
1997 (modest_easysetup_wizard_dialog_init),
1998 (set_default_custom_servernames): Some minor memory management fixes.
2000 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2004 * src/modest-runtime.c: (init_i18n): Restored the translation
2005 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2006 are defined in config.h, and the translations are installed.
2008 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2009 is defined for translation.
2011 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2013 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2015 * src/maemo/easysetup/modest-easysetup-wizard.c:
2016 (modest_easysetup_wizard_dialog_init):
2017 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2018 Use realistic paths (though they should use $prefix generically) to the
2019 mcc_mapping and provider-data.keyfile files which might work when they
2020 are installed by the future version of the operator-wizard package,
2021 and then fallback to paths in our source code, with an explanatory
2024 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2028 * src/maemo/Makefile.am:
2029 * src/maemo/easysetup/: Added files from the previously-exernal
2030 osso-modest-easysetup.
2031 * src/maemo/modest-main-window-ui.h:
2032 * src/modest-ui-actions.c:
2033 * src/modest-ui-actions.h:
2034 Added modest_ui_actions_on_new_account() as a signal handler for the
2035 New Account menu item. It shows the easysetup wizard.
2036 * po/en_GB.po: Added additional needed logical IDs and translations.
2038 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2039 Apparently ChangeLog is not used for some vague Nokia legal reasons.