git.maemo.org Git - modest/blob - ChangeLog2

   1 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
   2
   3         * src/maemo/modest-connection-specific-smtp-edit-window.c:
   4         (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
   5
   6         * src/modest-defs.h:
   7         * src/modest-account-mgr-helpers.h:
   8         * src/modest-account-mgr-helpers.c:
   9         Added modest_account_mgr_get/set_signature(), using new gconf keys.
  10
  11         * src/maemo/Makefile.am:
  12         * src/maemo/modest-signature-editor-dialog.c:
  13         * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
  14         as per the UI spec.
  15
  16         * src/maemo/modest-account-settings-dialog.h:
  17         * src/maemo/modest-account-settings-dialog.c:
  18         (modest_account_settings_dialog_finalize), (on_button_signature),
  19         (save_configuration): Use the new dialog when the Edit button is pressed, and
  20         save the changes if necessary, as per the UI spec.
  21
  22 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
  23
  24         * src/maemo/Makefile.am:
  25         * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
  26         based on maemo-develoers email from Dirk.
  27
  28         * src/maemo/easysetup/modest-easysetup-wizard.c:
  29         (create_page_welcome), (create_page_account_details),
  30         (create_page_user_details), (create_page_complete_easysetup),
  31         (create_page_custom_incoming), (create_page_custom_outgoing),
  32         (create_page_complete_custom),
  33         (modest_easysetup_wizard_dialog_init):
  34         * src/maemo/modest-account-settings-dialog.c:
  35         (create_page_account_details), (create_page_user_details),
  36         (create_page_incoming), (create_page_outgoing),
  37         (modest_account_settings_dialog_init):
  38         * src/maemo/modest-connection-specific-smtp-window.c:
  39         (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
  40
  41 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
  42
  43         * src/maemo/easysetup/modest-easysetup-wizard.c:
  44         (create_page_account_details), (create_page_custom_outgoing),
  45         (create_page_complete_custom):
  46         * src/maemo/modest-account-settings-dialog.c:
  47         (create_page_user_details), (create_page_incoming),
  48         (create_page_outgoing):
  49         * src/maemo/modest-connection-specific-smtp-edit-window.c:
  50         (modest_connection_specific_smtp_edit_window_init):
  51         Use the correct (UI spec) port min/max, and use horizontal separators,
  52         as per the UI spec.
  53
  54 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
  55
  56         * src/maemo/easysetup/modest-easysetup-wizard.c:
  57         (set_default_custom_servernames):
  58         * src/maemo/modest-account-settings-dialog.c:
  59         (create_page_incoming), (on_combo_outgoing_security_changed),
  60         (on_combo_incoming_security_changed), (create_page_outgoing),
  61         (modest_account_settings_dialog_set_account_name),
  62         (save_configuration):
  63         * src/maemo/modest-connection-specific-smtp-edit-window.c:
  64         (on_combo_security_changed),
  65         (modest_connection_specific_smtp_edit_window_init),
  66         (modest_connection_specific_smtp_edit_window_set_connection),
  67         (modest_connection_specific_smtp_edit_window_get_settings):
  68         Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
  69         as per the UI spec.
  70
  71 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
  72
  73         * po/en_GB.po:
  74         * src/maemo/easysetup/modest-easysetup-wizard.c:
  75         (create_page_custom_outgoing), (create_page_complete_custom):
  76         * src/maemo/modest-account-settings-dialog.c:
  77         (create_page_user_details), (create_page_outgoing):
  78         * src/maemo/modest-account-view-window.c: (button_box_new):
  79         Use changed logical IDs as per the most recent UI spec:
  80         mcen_bd_emailsetup_edit -> mcen_bd_edit
  81         mcen_bd_emailsetup_delete -> mcen_bd_delete
  82         mcen_bd_emailsetup_close -> mcen_bd_close
  83
  84 2007-04-20  2007-04-20  Murray Cumming  <murrayc@murrayc.com>
  85
  86         * configure.ac:
  87         * src/Makefile.am:
  88         * src/dbus_api/Makefile.am:
  89         * src/dbus_api/modest-dbus-callbacks.c:
  90         * src/dbus_api/modest-dbus-callbacks.h:
  91         * src/maemo/modest-platform.c: (modest_platform_init):
  92         Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
  93         method.
  94         * tests/Makefile.am:
  95         * tests/dbus_api/Makefile.am:
  96         * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
  97
  98 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
  99
 100         * src/maemo/modest-account-settings-dialog.c:
 101         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 102         Removed unnecessary includes.
 103
 104 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 105
 106         * src/maemo/easysetup/modest-easysetup-wizard.c:
 107         * src/maemo/modest-account-settings-dialog.c:
 108         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 109         * src/widgets/Makefile.am:
 110         * src/widgets/modest-easysetup-secureauth-combo-box.c:
 111         * src/widgets/modest-easysetup-secureauth-combo-box.h:
 112         * src/widgets/modest-easysetup-serversecurity-combo-box.c:
 113         * src/widgets/modest-easysetup-serversecurity-combo-box.h:
 114         * src/widgets/modest-secureauth-combo-box.c:
 115         * src/widgets/modest-secureauth-combo-box.h:
 116         * src/widgets/modest-serversecurity-combo-box.c:
 117         * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
 118         made the GObject names more consistent with the rest of the Modest code.
 119
 120 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 121
 122         * src/maemo/easysetup/Makefile.am:
 123         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 124         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
 125         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 126         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 127         * src/maemo/easysetup/modest-easysetup-wizard.c:
 128         * src/maemo/easysetup/modest-validating-entry.c:
 129         * src/maemo/easysetup/modest-validating-entry.h:
 130         * src/maemo/modest-account-settings-dialog.c:
 131         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 132         * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
 133         widgets/ because they are used outside of easysetup too. After checking in,
 134         svn will allow me to rename them too.
 135
 136 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 137
 138         * src/gnome/modest-msg-edit-window.c:
 139         (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
 140         linker error, to fix the build on the GNOME platform.
 141         modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
 142         modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
 143         ifdefed out to avoid a warning.
 144
 145 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 146
 147         * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
 148         use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
 149         some alternative for GTK+ 2.6.
 150
 151 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 152
 153         * src/maemo/modest-address-book.c: Added include to avoid a warning.
 154
 155         * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
 156         specified for EmailAccountsDialog in UI spec.
 157
 158         * src/maemo/easysetup/modest-easysetup-wizard.c:
 159         * src/maemo/easysetup/modest-easysetup-wizard.h:
 160         * src/maemo/modest-account-settings-dialog.c:
 161         * src/maemo/modest-account-settings-dialog.h:
 162         Reuse a member window widget for the connection-specific SMTP server accounts,
 163         so we can tell it to create/save the accounts only if we actually save changes.
 164
 165         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 166         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 167         (modest_connection_specific_smtp_edit_window_get_settings):
 168         Return a struct instance for temporarily remembering the entered data.
 169
 170         * src/maemo/modest-connection-specific-smtp-window.h:
 171         * src/maemo/modest-connection-specific-smtp-window.c:
 172         (modest_connection_specific_smtp_window_finalize),
 173         (modest_connection_specific_smtp_window_fill_with_connections),
 174         (on_button_edit),
 175         (modest_connection_specific_smtp_window_save_server_accounts),
 176         (update_model_server_names): Do not actually save data until asked,
 177         when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
 178
 179         (on_selection_changed),
 180         (modest_connection_specific_smtp_window_init): Disable the edit
 181         button when nothing is selected.
 182
 183         * src/modest-account-mgr-helpers.c:
 184         * src/modest-account-mgr-helpers.h:
 185         Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
 186         elsewhere.
 187
 188 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 189
 190         * src/modest-account-mgr-helpers.h:
 191         * src/modest-account-mgr-helpers.c:
 192         (modest_account_mgr_get_unused_account_name),
 193         (modest_account_mgr_get_unused_account_display_name): Added these
 194         utility functions, to avoid code duplication.
 195
 196         * src/maemo/easysetup/modest-easysetup-wizard.c:
 197         (create_page_account_details), (create_account):
 198         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 199         (on_combo_security_changed),
 200         (modest_connection_specific_smtp_edit_window_init),
 201         (modest_connection_specific_smtp_edit_window_save_settings):
 202         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 203         * src/maemo/modest-connection-specific-smtp-window.c:
 204         (modest_connection_specific_smtp_window_finalize),
 205         (modest_connection_specific_smtp_window_fill_with_connections),
 206         (on_button_edit), (modest_connection_specific_smtp_window_init):
 207         * src/maemo/modest-connection-specific-smtp-window.h:
 208         Implementing saving of connection-specific server accounts.
 209
 210         But I need to refactor this so we can save the data for each
 211         possible connection-specific account and only actually create the server accounts
 212         when the easysetup finished, or the OK button is pressed on the account settings
 213         dialog.
 214
 215 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 216
 217         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 218         (on_combo_security_changed):
 219         (modest_connection_specific_smtp_edit_window_init):
 220         Auto-fill the port number as in the account settings.
 221
 222         (modest_connection_specific_smtp_edit_window_set_connection):
 223         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 224         * src/maemo/modest-connection-specific-smtp-window.c:
 225         (fill_with_connections), (on_button_edit),
 226         (modest_connection_specific_smtp_window_init):
 227         Turn the edit window into a dialog to simplify the code, and
 228         set a WM hint as in a GtkDialog, because only a popup can be on top of
 229         another window in Maemo, and popups usually have no WM decoration.
 230
 231         * src/modest-defs.h:
 232         * src/modest-account-mgr-helpers.c:
 233         (modest_account_mgr_set_connection_specific_smtp),
 234         (modest_account_mgr_remove_connection_specific_smtp),
 235         (modest_account_mgr_get_connection_specific_smtp):
 236         * src/modest-account-mgr-helpers.h: Some functions to write the
 237         connection-specific SMTP server information. Not yet used.
 238
 239
 240         * src/widgets/modest-folder-view.c: (text_cell_data):
 241         Fix a warning about an uninitialized variable.
 242         (on_configuration_key_changed): Put an #ifdef around the use
 243         of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
 244
 245 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 246
 247         * src/maemo/modest-account-settings-dialog.h:
 248         * src/maemo/modest-account-settings-dialog.c:
 249         Added connect_for_modified() utility function to mark the new modified boolean.
 250
 251         (create_page_account_details), (create_page_user_details),
 252         (create_page_incoming), (create_page_outgoing), (on_response),
 253         (modest_account_settings_dialog_init),
 254         (modest_account_settings_dialog_set_account_name):
 255         Only warn about unsaved changes when there are actually unsaved changes.
 256
 257         * src/modest-account-mgr-helpers.c:
 258         * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
 259         into the ModestServerAccountData struct. I do not use it yet, but someone might expect
 260         to get the data from there in future.
 261
 262 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 263
 264         * src/modest-defs.h:
 265
 266         * src/modest-account-mgr-helpers.h:
 267         * src/modest-account-mgr-helpers.c:
 268         Store the security account setting in a single conf key instead of using
 269         the options list, so that the list is left for just the to-be-removed camel hack,
 270         and because gconf_client_set_list() is failing for some reason.
 271
 272         * src/modest-account-mgr.c:
 273         (modest_account_mgr_add_server_account):
 274         * src/maemo/modest-account-settings-dialog.c:
 275         (modest_account_settings_dialog_set_account_name),
 276         (save_configuration): Use the renamed functions.
 277
 278
 279 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 280
 281         * src/widgets/Makefile.am:
 282         * src/widgets/modest-limit-retrieve-combo-box.c:
 283         * src/widgets/modest-limit-retrieve-combo-box.h:
 284         * src/widgets/modest-retrieve-combo-box.c:
 285         * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
 286         the account settings dialog.
 287
 288         * src/modest-defs.h:
 289         * src/modest-account-mgr-helpers.h:
 290         * src/modest-account-mgr-helpers.c:
 291         (modest_server_account_get_option_secure_auth),
 292         (modest_server_account_set_option_secure_auth):
 293         * src/modest-account-mgr.c:
 294         (modest_account_mgr_add_server_account):
 295         Use the existing AUTH_MECH conf key for the secure-auth setting,
 296         instead of putting it in the list options, because this was actually used already.
 297
 298         * src/maemo/modest-account-settings-dialog.c:
 299         (create_page_account_details),
 300         (modest_account_settings_dialog_set_account_name),
 301         (save_configuration):
 302         * src/maemo/modest-account-settings-dialog.h:
 303         Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
 304         Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
 305
 306 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 307
 308         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 309         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 310         Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
 311
 312         * src/modest-defs.h:
 313         * src/maemo/modest-account-settings-dialog.c:
 314         (create_page_incoming), (on_combo_outgoing_security_changed),
 315         (on_combo_incoming_security_changed), (create_page_outgoing),
 316         (modest_account_settings_dialog_set_account_name),
 317         (save_configuration): Load/Save the port number, and change it when the
 318         security combo changes, to suitable defaults.
 319
 320 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 321
 322         * src/modest-account-mgr.c:
 323         (modest_account_mgr_add_server_account): Set the security and secure-auth
 324         options, and add a comment saying that the other camel-specific options should be
 325         removed in future.
 326
 327 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 328
 329         * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
 330         found by valgrind.
 331         * src/modest-tny-account-store.c: (account_list_free),
 332         (on_account_changed): Add a TODO comment about a valgrind error, caused by using
 333         cursor->data after unreffing it. But there is some strange stuff there so it might not be
 334         easy to fix.
 335
 336 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 337
 338         * src/modest-protocol-info.c:
 339         * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
 340         is required by our UI spec. Maybe something in our implementation will use this eventually.
 341         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 342         (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
 343         instead of the previous 0 placeholder.
 344
 345         * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
 346         secure-auth settings.
 347         * src/modest-account-mgr-helpers.h:
 348         * src/modest-account-mgr-helpers.c:
 349         (modest_server_account_data_get_option_secure_auth),
 350         (modest_server_account_set_option_secure_auth),
 351         (modest_server_account_data_get_option_security),
 352         (modest_server_account_set_option_security): Added this API for getting and setting the security
 353         and secure-auth settings.
 354
 355         * src/maemo/modest-account-settings-dialog.h:
 356         * src/maemo/modest-account-settings-dialog.c:
 357         (modest_account_settings_dialog_finalize), (check_data),
 358         (on_response): Store the original title as well as the name, to avoid unnececessary warnings
 359         about changing titles.
 360         (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
 361         (save_configuration): Save the security and secure-auth settings.
 362
 363         * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
 364         is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
 365
 366 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 367
 368         * src/modest-defs.h:
 369         * src/modest-account-mgr.c:
 370         (modest_account_mgr_add_server_account):
 371         Added and used defines for the options key and value pair strings,
 372         that are used so far, though they do not seem to correspond to anything in our
 373         UI specs or ModestProtocol enum.
 374
 375         * src/modest-account-mgr-helpers.h:
 376         * src/modest-account-mgr-helpers.c:
 377         (compare_option_strings_for_name),
 378         (modest_server_account_data_get_option_value),
 379         (modest_server_account_data_get_option_bool),
 380         (modest_account_mgr_get_server_account_option):
 381         Added helper functions for parsing the options GSList.
 382
 383 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 384
 385         * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
 386         display name is based on the supplied account name.
 387         * src/modest-account-mgr.c:
 388         * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
 389         with an inefficient, but good-enough, implementation.
 390
 391         * src/maemo/easysetup/modest-easysetup-wizard.c:
 392         (create_page_account_details), (on_before_next), (create_account):
 393         Check for existing display names rather than (non-user-visible) account names, and just
 394         create and set a unique account name at the end.
 395
 396         * src/maemo/modest-account-settings-dialog.c:
 397         (modest_account_settings_dialog_init),
 398         (modest_account_settings_dialog_set_account_name),
 399         (create_page_incoming): Show the display name, instead of the account name.
 400         (on_response): Do some (not all) extra checks, as in the UI spec.
 401         (save_configuration): Save the display name if it was changed.
 402
 403 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 404
 405         * po/en_GB.po: Added needed logical ID and translation.
 406         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 407         (init_view): Made the is-default column clicking work.
 408
 409 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 410
 411         * configure.ac:
 412         * src/maemo/easysetup/Makefile.am:
 413         * src/maemo/easysetup/modest-easysetup-wizard.c:
 414         (modest_easysetup_wizard_dialog_init):
 415         * src/maemo/easysetup/provider-data-test.keyfile:
 416         * src/maemo/easysetup/provider-data.keyfile:
 417         Moved the provider data file to the new modest-providers-data package and used it from there.
 418
 419 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 420
 421         * src/modest-local-folder-info.c:
 422         (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
 423         N_() was already used on the static strings, but this just marks it for translation without
 424         using the translation.
 425
 426 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 427
 428         * src/maemo/modest-account-settings-dialog.c:
 429         (create_page_incoming),
 430         (modest_account_settings_dialog_set_account_name):
 431         Added comments about the need for new API in ModestAccountMgr to handle the authentication
 432         and secure-connection stuff that is stored in the options GSList* with hard-coded names.
 433         I will do this if nobody else gets there first.
 434
 435 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 436
 437         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
 438         Saved much of the incoming and outgoing data too, though I cannot yet see how to
 439         save the security stuff.
 440
 441 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 442
 443         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 444         Set the email address and user fullname, which I now see must be
 445         done separately.
 446
 447         * src/maemo/modest-account-settings-dialog.h:
 448         * src/maemo/modest-account-settings-dialog.c:
 449          (on_response),
 450         (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
 451         leave-on-server and authentication.
 452         (save_configuration): Save most of the non-server-account specific stuff, but I don't see
 453         how to do the rest.
 454
 455 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 456
 457
 458         * src/maemo/modest-account-settings-dialog.c:
 459         * src/maemo/modest-account-settings-dialog.h:
 460         Most (but not all) of the widgets are now present as specified by the UI spec.
 461         No changes are yet saved, and some details are not properly shown yet.
 462
 463         * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
 464
 465 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 466
 467         * src/maemo/Makefile.am:
 468         * src/maemo/modest-account-settings-dialog.c:
 469         * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
 470         an existing account. Doesn't do much yet.
 471
 472         * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
 473         Open the accounts settings dialog when Edit is clicked.
 474
 475 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 476
 477         * src/maemo/easysetup/Makefile.am:
 478         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
 479         (load_from_file):
 480         * src/maemo/easysetup/modest-easysetup-wizard.c:
 481         (modest_easysetup_wizard_dialog_init):
 482         Try to get the source directory from the build system,
 483         instead of hard-coding "./" into the source code, when opening our local
 484         copies of the configuration files.
 485         But this still fails when opening the wizard from the Accounts window,
 486         maybe because the working directory seems to change at runtime.
 487         So the wizard will fail the second time unless you copy the files into their
 488         proper locations - see the stdout warnings for the paths.
 489
 490         (create_page_account_details),(on_before_next):
 491         Check for existing non-server accounts instead of server accounts,
 492         so the default account name is useful again, and to prevent trying to
 493         recreate accounts.
 494
 495         * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
 496         Show the wizard when New is clicked.
 497
 498         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 499         (init_view): Show the column headers, and show the columns that are
 500         specified in the UI specs. However, something in Maemo's GTK+ prevents
 501         us from handling the GtkCellRendererToggle::toggled signal, so we cannot
 502         change the default account. This is despite unsetting the special properties.
 503
 504 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 505
 506         * docs/reference/modest-design.sgml: Corrected spelling mistake.
 507         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 508         Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
 509         This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
 510         to make that clearer.
 511         * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
 512
 513 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 514
 515         * src/maemo/modest-account-view-window.c:
 516         (modest_account_view_window_init),
 517         (modest_account_view_window_new):
 518         Use the same buttons as specified in the
 519         UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
 520         the existing widgets, which never had a chance of working.
 521         Put the ModestAccountView treeview in a scrolled window.
 522         Do not repeat the initialization in both _init() and _new().
 523
 524         * src/widgets/modest-account-view.c: (update_account_view):
 525         Add a warning about modest_account_mgr_account_names() returning NULL, which is why
 526         this widget and window shows no accounts.
 527
 528         * po/en_GB.po: Added translations needed for the dialog button logical IDs.
 529
 530 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 531
 532         * src/maemo/easysetup/modest-easysetup-wizard.c:
 533         (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
 534         (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
 535         returns NULL after modest_account_mgr_add_server_account() returned TRUE,
 536         which seems wrong.
 537
 538         * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
 539         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
 540         accounts exist yet, as in the UI spec.
 541
 542         * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
 543
 544 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 545
 546         * src/maemo/Makefile.am:
 547         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 548         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 549         New window for editing connection-specific smtp details.
 550         Not fully implemented.
 551
 552         * src/maemo/modest-connection-specific-smtp-window.c:
 553         (modest_connection_specific_smtp_window_finalize) :
 554         unref the tree model.
 555         (on_button_edit): Show the edit window.
 556
 557 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 558
 559         * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
 560         error for me.
 561
 562         * src/maemo/Makefile.am:
 563         * src/maemo/modest-connection-specific-smtp-window.c:
 564         * src/maemo/modest-connection-specific-smtp-window.h:
 565         New window for showing the list of connections, for connection-specific
 566         SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
 567         * src/maemo/easysetup/modest-easysetup-wizard.c:
 568         (create_page_custom_outgoing): Show the new window when the button is clicked.
 569
 570 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 571
 572         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 573         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
 574         * src/maemo/modest-msg-edit-window.c:
 575         (modest_msg_edit_window_insert_image):
 576         * src/modest-conf.c: (modest_conf_key_escape):
 577         * src/modest-mail-operation.c:
 578         (modest_mail_operation_send_new_mail):
 579         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
 580         (modest_ui_actions_on_new_account):
 581         * src/widgets/modest-attachment-view.c: (update_filename_request):
 582         * src/widgets/modest-mail-header-view.c:
 583         Corrected warnings that were breaking the build, by commenting out unused variables,
 584         and a function, and by including a header.
 585
 586 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 587
 588         * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
 589         so we can #ifdef around platform-specific code when necessary.
 590         * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
 591         to allow this to build for the GNOME platform too.
 592
 593 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 594
 595         * src/maemo/easysetup/modest-easysetup-wizard.c:
 596         Added util_increment_name() and used it in create_page_account_details()
 597         to make sure that the default account name is always a new name.
 598
 599         (modest_easysetup_wizard_dialog_init),
 600         (set_default_custom_servernames): Some minor memory management fixes.
 601
 602 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 603
 604         * Makefile.am:
 605         * configure.ac:
 606         * src/modest-runtime.c: (init_i18n): Restored the translation
 607         infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
 608         are defined in config.h, and the translations are installed.
 609
 610         * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
 611         is defined for translation.
 612
 613 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
 614
 615         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
 616         (load_from_file):
 617         * src/maemo/easysetup/modest-easysetup-wizard.c:
 618         (modest_easysetup_wizard_dialog_init):
 619         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
 620         Use realistic paths (though they should use $prefix generically) to the
 621         mcc_mapping and provider-data.keyfile files which might work when they
 622         are installed by the future version of the operator-wizard package,
 623         and then fallback to paths in our source code, with an explanatory
 624         warning.
 625
 626 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
 627
 628         * configure.ac:
 629         * src/Makefile.am:
 630         * src/maemo/Makefile.am:
 631         * src/maemo/easysetup/: Added files from the previously-exernal
 632         osso-modest-easysetup.
 633         * src/maemo/modest-main-window-ui.h:
 634         * src/modest-ui-actions.c:
 635         * src/modest-ui-actions.h:
 636         Added modest_ui_actions_on_new_account() as a signal handler for the
 637         New Account menu item. It shows the easysetup wizard.
 638         * po/en_GB.po: Added additional needed logical IDs and translations.
 639
 640 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
 641 Apparently ChangeLog is not used for some vague Nokia legal reasons.
 642