1 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-protocol-info.c:
4 * src/modest-protocol-info.h: Adde enum-specific get functions,
5 instead of using a ModestProtocolType enum parameter.
7 * src/gnome/modest-account-assistant.c:
8 * src/gnome/modest-store-widget.c:
9 * src/gnome/modest-store-widget.h:
10 * src/gnome/modest-transport-widget.c:
11 * src/gnome/modest-transport-widget.h:
12 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
13 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
14 * src/maemo/easysetup/modest-easysetup-wizard.c:
15 * src/maemo/modest-account-settings-dialog.c:
16 * src/maemo/modest-account-settings-dialog.h:
17 * src/maemo/modest-store-widget.c:
18 * src/maemo/modest-store-widget.h:
19 * src/maemo/modest-transport-widget.c:
20 * src/maemo/modest-transport-widget.h:
21 * src/modest-account-mgr-helpers.c:
22 * src/modest-account-mgr-helpers.h:
23 * src/modest-account-mgr.c:
24 * src/modest-account-mgr.h:
25 * src/modest-tny-account.c:
26 * src/modest-tny-folder.c:
27 * src/widgets/modest-account-view.c:
28 * src/widgets/modest-retrieve-combo-box.c:
29 * src/widgets/modest-retrieve-combo-box.h:
30 * src/widgets/modest-secureauth-combo-box.c:
31 * src/widgets/modest-serversecurity-combo-box.c:
32 * src/widgets/modest-serversecurity-combo-box.h:
33 * tests/check_account-mgr.c:
34 Use the specific functions, and use the re-renamed enum values for GNOME too.
36 2007-05-15 Murray Cumming <murrayc@murrayc.com>
39 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
40 so we can get the second based on the first.
42 * src/maemo/modest-account-settings-dialog.h:
43 * src/maemo/modest-account-settings-dialog.c:
44 Added get_supported_secure_authentication_methods(), though it is mostly
45 commented-out for now until the necessary API is committed to tinymail.
46 (modest_account_settings_dialog_set_account_name),
47 (save_configuration): Request the supported authentication methods from the
48 server, so we can choose a working method.
50 * src/modest-tny-account-store.h:
51 * src/modest-tny-account-store.c:
52 (modest_tny_account_store_get_session): Rename from
53 tny_account_store_get_session().
55 2007-05-14 Murray Cumming <murrayc@murrayc.com>
57 * src/modest-protocol-info.h: Split the ModestProtocol enum
58 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
59 There was no need to have these unrelated values in one enum.
61 * src/: many files: Adapted to changed enum. This makes the code a bit
62 clearer, and the compiler could catch some errors.
64 2007-05-14 Murray Cumming <murrayc@murrayc.com>
66 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
67 Show the detailed internal camel error message when an error happens
68 during the configuration, so that our testers can give us more clues.
69 For instance, in projects.maemo.org bug NB#56910 .
71 2007-05-14 Murray Cumming <murrayc@murrayc.com>
73 * src/modest-tny-account.c:
74 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
75 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
77 2007-05-14 Murray Cumming <murrayc@murrayc.com>
79 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
80 * src/maemo/modest-account-settings-dialog.c:
81 (modest_account_settings_dialog_set_account_name),
82 (save_configuration): For the incoming secure authentication checkbox,
83 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
84 the UI specification. PLAIN does not seem to be supported for most IMAP
85 servers anyway, and I am not sure what it would mean.
86 However, we probably need to discover which of the secure-authentication
87 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
88 * src/modest-account-mgr-helpers.c:
89 (modest_account_mgr_get_server_account_data):
91 * src/modest-tny-account.c:
92 (modest_tny_account_new_from_server_account):
93 Use tny_account_set_mech() to set secure-authentication methods,
94 with some special-casing for IMAP, based on my observations of how
97 * src/modest-account-mgr-helpers.h:
98 * src/modest-account-mgr.c:
99 * src/modest-defs.h: Comment that the URI is only used for local folders.
101 2007-05-11 Murray Cumming <murrayc@murrayc.com>
103 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
104 parameter const, just to be neat.
105 * src/modest-text-utils.c: (modest_text_utils_inline):
106 End g_strconcat() with NULL, as its documentation says. This is almost
107 certainly the cause of my crash at startup on the device. Interestingly,
108 valgrind doesn't tell us about these errors.
110 2007-05-11 Murray Cumming <murrayc@murrayc.com>
112 * scripts/build-packages: Added more precise comments about how to use
113 this script, though I still get this error:
114 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
115 error building tinymail
117 2007-05-11 Murray Cumming <murrayc@murrayc.com>
119 * src/maemo/modest-main-window.c: (on_account_update):
120 Very slight cleanup, hoping to make it simpler to discover what causes
121 a crash here sometimes.
123 * src/modest-tny-account.c:
124 (modest_tny_account_new_from_server_account): Set the port. Added
125 comments about the options and a TODO comment because I need to find out
126 how to specify the secure authentication method.
128 2007-05-11 Marcus Bauer <marcusb@openismus.com>
130 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
131 changed CFlags paths form modest to libmodest
133 2007-05-10 Murray Cumming <murrayc@murrayc.com>
135 * src/modest-account-mgr-helpers.c:
136 (modest_account_mgr_get_server_account_data),
137 (modest_account_mgr_free_server_account_data):
138 * src/modest-account-mgr-helpers.h:
139 * src/modest-account-mgr.c:
140 (modest_account_mgr_add_server_account):
142 * src/modest-tny-account.c:
143 (modest_tny_account_new_from_server_account):
144 Determine the options for tny_camel_account_add_option() here,
145 based on the settings, rather than storing them directly in gconf.
147 2007-05-10 Murray Cumming <murrayc@murrayc.com>
149 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
150 Show a more friendly error dialog now that we expect (from the tinymail
151 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
153 2007-05-10 Murray Cumming <murrayc@murrayc.com>
155 * src/maemo/modest-main-window.c: (on_account_update): Check that
156 account_name is not NULL, to prevent a crash at startup that I am
157 seeing on the N800. I do wonder why it is NULL.
159 * src/maemo/easysetup/modest-easysetup-wizard.c:
160 (create_page_user_details):
161 * src/maemo/modest-account-settings-dialog.c:
162 (create_page_user_details), (create_page_outgoing):
163 * src/maemo/modest-connection-specific-smtp-edit-window.c:
164 (modest_connection_specific_smtp_edit_window_init):
165 * src/modest-ui-actions.c:
166 (modest_ui_actions_on_password_requested):
167 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
168 might do something useful with the on-screen keyboard.
170 2007-05-10 Murray Cumming <murrayc@murrayc.com>
172 * src/maemo/modest-main-window.c: (on_account_update):
173 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
174 NULL, to avoid lots of warnings. However, it probably should not be NULL.
176 2007-05-09 Murray Cumming <murrayc@murrayc.com>
178 * src/modest-tny-account-store.c: (on_account_changed):
179 Correct the signature of this signal handler.
181 2007-05-09 Murray Cumming <murrayc@murrayc.com>
183 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
184 Show a HildonNote instead of a GtkDialog for Maemo.
186 2007-05-09 Murray Cumming <murrayc@murrayc.com>
188 * src/widgets/modest-account-view.h:
189 * src/widgets/modest-account-view.c: (on_account_changed),
190 (on_account_removed). Added a boolean flag, set/unset by
191 modest_account_view_block_conf_updates(),
192 modest_account_view_unblock_conf_updates() to prevent unnecessary
193 updates, but this is not very useful because the gconf notifications are
194 so delays (maybe only on Maemo Bora).
195 So auto-updating is turned off, and these functions do an explicit
196 update when necessary.
197 However, something else is still doing too much work when adding/removing
198 accounts, probably in another part of the application.
200 * src/maemo/modest-account-view-window.c:
201 (on_delete_button_clicked), (on_edit_button_clicked),
202 (on_new_button_clicked): Use the new functions.
204 2007-05-09 Murray Cumming <murrayc@murrayc.com>
206 * src/modest-account-mgr-helpers.c:
207 (modest_account_mgr_set_first_account_as_default):
208 Sort the list of names alphabetically-by-title, so we choose the first one
210 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
211 alphabetically by the title.
213 This fixes projects.maemo.org bug NB#56418 .
215 * src/modest-account-mgr-priv.c:
216 (_modest_account_mgr_account_from_key):
217 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
218 avoid a valgrind error, and possible random behaviour.
220 2007-05-09 Murray Cumming <murrayc@murrayc.com>
222 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
223 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
224 tinymail documentation to say that this can be expected.
225 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
226 pretty, and should not happen, but I would prefer to know when it does.
228 2007-05-09 Murray Cumming <murrayc@murrayc.com>
230 * configure.ac: When using the older hildon version, probably on Bora,
231 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
233 * src/widgets/modest-attachment-view.c:
234 (modest_attachment_view_set_part_default): Initialize variables, to fix the
237 2007-05-09 Marcus Bauer <marcusb@openismus.com>
239 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
240 Implemented the prototype. Can be tested with
241 tests/dbus_api/test_open_message:
243 2007-05-08 Murray Cumming <murrayc@murrayc.com>
245 * src/modest-tny-account-store.c:
246 (modest_tny_account_store_instance_init), (get_password):
247 * src/modest-ui-actions.c:
248 (modest_ui_actions_on_password_requested):
249 Do not store the password in gconf, because this function is called
250 for non-remembered passwords. Actually use the cached (in the hash map)
251 password instead of releasing it.
252 The password will now not be remembered if it is asked via the protected
253 password dialog, as per the UI spec.
255 2007-05-08 Murray Cumming <murrayc@murrayc.com>
258 * src/modest-account-mgr-helpers.h:
259 * src/modest-account-mgr-helpers.c:
260 Added modest_server_account_get_username_has_succeeded(),
261 modest_server_account_set_username_has_succeeded().
262 (modest_server_account_set_username),
263 Reset the has-succeeded flag if the username changes.
265 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
266 * src/maemo/modest-connection-specific-smtp-window.c:
267 (modest_connection_specific_smtp_window_save_server_accounts):
268 Use modest_server_account_set_username() instead of using
269 modest_conf_set_string() directly, so that the has-succeeded flag is always
272 * src/modest-ui-actions.c:
273 (modest_ui_actions_on_password_requested): Dim the username entry if
274 the username has ever worked, as per the UI spec.
276 2007-05-08 Murray Cumming <murrayc@murrayc.com>
278 * src/modest-tny-account-store.c: (get_password):
279 * src/modest-ui-actions.c:
280 (modest_ui_actions_on_password_requested):
281 Allow the username to be changed too, though there is more work to
282 be done on exactly how this behaves.
284 2007-05-08 Murray Cumming <murrayc@murrayc.com>
286 * src/modest-account-mgr-helpers.h:
287 * src/modest-account-mgr-helpers.c:
288 Added modest_account_mgr_get_display_name(),
289 modest_server_account_get_username(),
290 modest_server_account_set_username(),
291 modest_server_account_set_password(),
292 modest_server_account_get_hostname() functions so we do not need to
293 use the conf API directly.
295 * src/maemo/modest-main-window.c: (connect_signals):
296 Actually connect ot the ModestAccountStore::request-password signal,
297 so that we show the dialog when the password is requested by Tinymail,
298 for isntance if it is empty.
300 * src/modest-marshal.list:
301 * src/modest-tny-account-store.c:
302 (modest_tny_account_store_class_init), (get_password),
303 (modest_tny_account_store_alert):
304 * src/modest-tny-account-store.h:
305 * src/modest-ui-actions.h:
306 * src/modest-ui-actions.c:
307 (modest_ui_actions_on_password_requested):
308 Change the signal parameters, so it is obvious that we are providing
309 the non human-readable server name, and receiving both the username
310 and password, though changing of the username is not yet implemented.
311 Change the dialog UI to match the Maemo UI specifications, with #idfefing
312 for the GNOME version.
314 This should fix the projects.maemo.org bug NB#56209, though it does not
315 work on Bora, because the gconf_client_get() for the password fails
316 immediately after we save it with gconf_client_set().
318 2007-05-08 Murray Cumming <murrayc@murrayc.com>
321 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
322 caused an undefined symbol error:
323 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
325 2007-05-08 Murray Cumming <murrayc@murrayc.com>
327 * src/modest-tny-account-store.c:
328 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
329 using a GError instead of a string message, so we can translate it in
332 2007-05-08 Murray Cumming <murrayc@murrayc.com>
334 * src/maemo/modest-address-book.c:
335 (modest_address_book_check_names):
336 * src/maemo/modest-msg-view-window.c:
337 (modest_msg_view_window_clipboard_owner_change):
338 * src/modest-init.c: (modest_init_init_ui):
339 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
340 (update_folders_cb), (modest_mail_operation_update_account):
341 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
342 (modest_ui_actions_on_msg_attachment_clicked),
343 (modest_ui_actions_on_msg_recpt_activated):
344 * src/widgets/modest-header-view.c: (drag_data_get_cb):
345 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
346 (modest_msg_view_search_next):
347 * src/widgets/modest-recpt-editor.c:
348 (modest_recpt_editor_on_button_release_event),
349 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
350 g_message(). At this point we should only be seeing interesting errors on
351 stdout. Debugging messages could be #ifdefed-out if they are still useful.
353 2007-05-07 Murray Cumming <murrayc@murrayc.com>
355 (modest_wizard_dialog_force_title_update):
356 * src/maemo/easysetup/modest-wizard-dialog.h:
357 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
358 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
359 can update the title when appropriate. Otherwise the title is wrong if the
360 pages are added after adding the notebook to the dialog.
361 This must be a problem in HildonWizardDialog too.
362 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
364 * src/maemo/easysetup/modest-easysetup-wizard.c:
365 (create_subsequent_customsetup_pages),
366 (create_subsequent_easysetup_pages):
367 Call modest_wizard_dialog_force_title_update() so that the title is
368 correct even with GTK+ < 2.10.
369 This fixes projects.maemo.org bug NB#56145 .
371 2007-05-07 Murray Cumming <murrayc@murrayc.com>
373 * src/maemo/modest-platform.c:
374 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
375 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
378 2007-05-07 Murray Cumming <murrayc@murrayc.com>
380 * src/widgets/modest-window.h:
381 * src/widgets/modest-window.c: Added a save_state_func vfunc,
382 and modest_window_save_state(), which invokes it.
384 * src/widgets/modest-window-mgr.h:
385 * src/widgets/modest-window-mgr.c:
386 Added modest_window_mgr_save_state_for_all_windows(), which calls
387 the save_state vfunc on all registered windows, if implemented.
389 * src/gnome/modest-msg-edit-window.c:
390 * src/gnome/modest-msg-view-window.c:
391 * src/maemo/modest-msg-edit-window.c:
392 * src/maemo/modest-msg-view-window.c:
393 * src/maemo/modest-main-window.c:
394 Specify the existing save_settings functions as implementations of
395 ModestWindow::save_state_func().
397 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
398 Call modest_window_mgr_save_state_for_all_windows(). This happens before
399 enabling hibernation, for instance.
401 We may need to do the same thing for restoring settings.
404 2007-05-07 Murray Cumming <murrayc@murrayc.com>
406 * src/widgets/modest-window-mgr.c:
407 * src/widgets/modest-window-mgr.h:
408 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
409 modest_window_mgr_get_hibernation_is_prevented().
411 * src/maemo/modest-main-window.c:
412 (on_hildon_program_is_topmost_notify): Prevent hibernation
413 (possible when the application goes to the background in the WM),
414 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
416 * src/maemo/easysetup/modest-easysetup-wizard.c:
417 (modest_easysetup_wizard_dialog_init):
418 * src/maemo/modest-account-settings-dialog.c:
419 (modest_account_settings_dialog_init):
420 * src/maemo/modest-connection-specific-smtp-edit-window.c:
421 (modest_connection_specific_smtp_edit_window_init):
422 * src/maemo/modest-connection-specific-smtp-window.c:
423 (modest_connection_specific_smtp_window_init):
424 * src/maemo/modest-signature-editor-dialog.c:
425 (modest_signature_editor_dialog_init):
426 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
427 prevent hibernation while any of these account settings dialogs are open.
429 2007-05-04 Murray Cumming <murrayc@murrayc.com>
431 * src/maemo/Makefile.am:
432 * src/maemo/modest-osso-state-saving.c:
433 * src/maemo/modest-osso-state-saving.h: Added
434 modest_osso_load_state() and modest_osso_save_state() though they do
435 nothing now. They should iterate through all the open windows and load/save
437 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
438 save state when closing.
440 * src/maemo/modest-main-window.c:
441 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
442 Add a notification handler for the HildonProgram::is-topmost property,
443 so we can allow hibernation when the application goes into the background.
444 But we still need to detect when the accounts setup windows are open so
445 we can stop hibernation when they are open.
446 To do this, I also added the main window the HildonProgram. This might have
447 other side-effects/benefits, and should maybe be done for other windows.
449 * src/maemo/modest-osso-autosave-callbacks.h:
450 * src/maemo/modest-osso-autosave-callbacks.c:
451 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
452 though it does not do anything yet, and we might never need this to do
453 anything. For instance, we already save drafts.
455 * src/maemo/modest-platform.c: (modest_platform_init):
456 Specify the libosso auto-save callback.
458 2007-05-03 Murray Cumming <murrayc@murrayc.com>
460 * src/maemo/modest-platform.c:
461 (modest_platform_set_update_interval):
462 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
463 aparently stays valid between application instances, so we can use this
464 to remove and reset it later. According to a maemo-developers email from
467 2007-05-03 Murray Cumming <murrayc@murrayc.com>
469 * configure.ac: Depend on libalarm for Maemo.
471 * src/dbus_api/modest-dbus-api.h:
472 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
473 (on_send_receive), (modest_dbus_req_handler):
474 Handle a SEND_RECEIVE D-Bus method.
476 * libmodest-dbus-client/libmodest-dbus-client.c:
477 (libmodest_dbus_client_send_and_receive):
478 * libmodest-dbus-client/libmodest-dbus-client.h:
479 Add C convenience functions for calling the new D-Bus method.
481 * src/modest-platform.h:
482 * src/gnome/modest-platform.c:
483 * src/maemo/modest-platform.c:
484 Added modest_platform_set_update_interval(), which uses the
486 (modest_platform_init),
487 Call modest_platform_set_update_interval(), using a hard-coded
488 interval for now (until the global settings dialog is implemented),
489 though I am not sure that this makes sense yet.
491 2007-05-02 Murray Cumming <murrayc@murrayc.com>
493 * src/dbus_api/modest-dbus-callbacks.c:
494 (modest_osso_cb_hw_state_handler):
495 * src/dbus_api/modest-dbus-callbacks.h:
496 * src/maemo/modest-platform.c: (modest_platform_init):
497 Registered (empty) callbacks for the osso hardware state D-Bus signals,
498 in case this has some effect on the ability for Maemo to ping the
501 2007-05-02 Murray Cumming <murrayc@murrayc.com>
503 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
504 Comment out an if() that checks a gchar for < 0, causing a build-breaking
505 warning. It is probably a logic error, but I need to fix the build.
507 2007-05-02 Murray Cumming <murrayc@murrayc.com>
509 * src/modest-account-mgr.h:
510 * src/modest-account-mgr.c:
511 (modest_account_mgr_account_names): Add a gboolean enabled_only
512 parameter, so we can get lists of onlt the enabled accounts.
514 (modest_account_mgr_add_account),,
515 (modest_account_mgr_account_with_display_name_exists):
516 * src/maemo/modest-msg-edit-window.c: (get_transports):
517 * src/modest-account-mgr-helpers.c:
518 (modest_account_mgr_set_first_account_as_default):
519 * src/modest-init.c: (init_default_account_maybe):
520 * src/modest-tny-account-store.c: (get_accounts):
521 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
522 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
523 * tests/check_account-mgr.c: (START_TEST):
524 Provide the extra parameter, as appropriate.
526 * src/widgets/modest-account-view.c: (update_account_view):
527 Do not show disabled accounts (meaning that there is no way to
528 enable/disable accounts in the UI (the feature is not in our UI
529 specification), so we can use this internally only to mark unfinished
530 or temporary account data.
532 * src/maemo/easysetup/modest-easysetup-wizard.c:
533 (create_account): Add boolean enable parameter, so we can specify FALSE
534 to create the temporary account.
535 (on_button_edit_advanced_settings): Create the temporary account as disabled.
536 (on_before_next): When finishing, when there is a temporary account, just
538 Also, use a timeout to delay the showing of the dialog until gconf is likely
539 to return correct information, due to a maemo gconf bug that is fixed in
540 osso 1.1, but not yet in Bora.
541 However, the dialog stays on screen after it is destroyed.
543 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
544 for invalid data when cancelling. Use a hildon note instead of a dialog
545 to complain about invalid data. Do not show the account-saved note if the
546 account is disabled (a temporary account that will not really be saved for use
549 2007-04-30 Murray Cumming <murrayc@murrayc.com>
551 * src/modest-account-mgr-helpers.h:
552 * src/modest-account-mgr-helpers.c:
553 Added modest_account_mgr_unset_default_account(),
554 Added modest_account_mgr_set_first_account_as_default().
556 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
557 If it was the default account, unset the default account name.
559 * src/maemo/modest-account-view-window.c:
560 (on_delete_button_clicked): If it was the default account,
561 set the first remaining account as the default instead.
563 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
564 a NULL account or a NULL default account, to prevent a crash. This should
565 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
568 2007-04-30 Murray Cumming <murrayc@murrayc.com>
570 * src/widgets/modest-recpt-editor.c:
571 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
572 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
573 TODO comment for this. This fixes the build.
575 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
576 be the best place for it. This will in future update all auto-update accounts,
577 rather than just the current/default account, when that gconf key exists.
578 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
579 if there are no accounts, before calling do_send_receive().
580 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
582 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
583 * src/maemo/modest-main-window-ui.h:
584 * src/maemo/modest-main-window.c: (on_connection_changed),
585 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
586 directly, becaue the signal handler does more.
588 2007-04-30 Murray Cumming <murrayc@murrayc.com>
590 * src/modest-account-mgr-helpers.c:
591 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
592 for the case that the account does not exist.
594 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
595 (equivalent to the modest account name) rather than the tinymail account name
596 (equivalent to the modest account title - human readable) to get the account data.
597 Check for null account data to prevent the crash, and add a TODO comment saying that
598 this needs fixing because it is using the server account name instead of the account name.
600 2007-04-29 Murray Cumming <murrayc@murrayc.com>
602 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
603 * src/maemo/modest-account-settings-dialog.c: (show_error),
605 Use hildon_note_new_information() for informative and error messages,
606 which seems to be expected for Maemo applications (no documentation that I know of
607 says this). I am surprised that there is no distinction between info and error
610 2007-04-29 Murray Cumming <murrayc@murrayc.com>
612 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
613 it is easy to find where this is used.
615 * src/maemo/easysetup/modest-easysetup-wizard.c:
616 (create_page_welcome), (create_page_account_details),
617 (create_page_user_details), (create_page_complete_easysetup),
618 (create_page_custom_incoming), (create_page_custom_outgoing),
619 (create_page_complete_custom):
620 * src/maemo/modest-account-settings-dialog.c:
621 (create_page_account_details), (create_page_user_details),
622 (create_page_incoming), (create_page_outgoing):
623 * src/maemo/modest-account-view-window.c: (window_vbox_new):
624 * src/maemo/modest-connection-specific-smtp-edit-window.c:
625 (modest_connection_specific_smtp_edit_window_init):
626 * src/maemo/modest-connection-specific-smtp-window.c:
627 (modest_connection_specific_smtp_window_init):
628 * src/maemo/modest-signature-editor-dialog.c:
629 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
630 and scrolling policy as per the Email Application Layout Guide, if I have
633 2007-04-27 Murray Cumming <murrayc@murrayc.com>
635 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
636 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
637 which were empty, because these vfuncs have been removed from TnyAccountStore.
638 This fixes the build.
640 2007-04-27 Murray Cumming <murrayc@murrayc.com>
642 * src/maemo/modest-main-window.c:
643 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
644 showing/hiding it. Added TODO because it probably should not be NULL.
645 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
646 because unnecessary g_warnings() make degugging difficult.
648 2007-04-27 Murray Cumming <murrayc@murrayc.com>
650 * src/maemo/modest-msg-edit-window.c:
651 (modest_msg_edit_window_select_color),
652 (modest_msg_edit_window_select_background_color): 2 const corrections and
653 moving 2 #endifs before closing brackets, to fix the build.
655 2007-04-27 Murray Cumming <murrayc@murrayc.com>
657 * src/maemo/easysetup/modest-easysetup-wizard.h:
658 * src/maemo/easysetup/modest-easysetup-wizard.c:
659 (modest_easysetup_wizard_dialog_finalize),
660 (on_button_edit_advanced_settings), (create_page_complete_custom),
661 (on_response), (create_account):
662 Implement the Advanced Settings edit button, by saving the account information,
663 for the Advanded Settings dialog to use directly from gconf, and removing it
664 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
665 Bug #5533 in the projects.maemo.org bugzilla.
667 2007-04-27 Murray Cumming <murrayc@murrayc.com>
669 * src/maemo/modest-msg-view-window.c:
670 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
671 when opening a message window.
673 2007-04-27 Murray Cumming <murrayc@murrayc.com>
675 * src/maemo/easysetup/modest-easysetup-wizard.c:
676 (create_page_custom_outgoing): Correct the position of the horizontal separator to
679 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
680 before showing/hiding them, to avoid a crash when clicking on folders when there are no
681 gconf settings. I probably added more checks than necessary, but that is safer.
683 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
684 variable to fix the build, but this seems to be used when it is still NULL.
686 2007-04-27 Murray Cumming <murrayc@murrayc.com>
688 * src/modest-platform.h:
689 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
690 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
691 * src/modest-main.c: Implement this function so we can avoid using
692 maemo-specific API from cross-platform code.
694 * src/modest-tny-account-store.c:
695 (get_smtp_specific_transport_account_for_open_connection):
696 * src/modest-ui-actions.c: (check_for_connection),
697 (modest_ui_actions_on_item_not_found):
698 Use modest_platform_connect_and_wait() and put #idefs around other
699 maemo-specific code, because only maemo currently has a way to
700 identify connection names.
702 2007-04-27 Murray Cumming <murrayc@murrayc.com>
704 * src/modest-tny-account-store.h:
705 * src/modest-tny-account-store.c:
706 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
707 the connection-specific SMTP server settings in the configuration.
709 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
711 * src/maemo/modest-main-window.c: (on_connection_changed),
713 * src/modest-main.c: (main), (start_ui), (send_mail):
714 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
715 that is what is intended.
717 * src/modest-ui-actions.c: (action_send), (action_receive),
718 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
719 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
720 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
721 SMTP server is used when it is specified.
723 (modest_ui_actions_on_send_receive):
724 Check that a connection is open before proceeding.
725 Receive and then send, instead of vice-versa, as per the specification.
727 2007-04-26 Murray Cumming <murrayc@murrayc.com>
729 * src/modest-mail-operation.c:
730 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
731 though I guess it should be something other than NULL.
733 2007-04-26 Murray Cumming <murrayc@murrayc.com>
735 * src/maemo/easysetup/modest-easysetup-wizard.c:
736 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
737 combo twice, to avoid an g_warning and to make it visible again.
738 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
739 attached before detaching it, to avoid a g_warning, and add comment about the implicit
740 (already intended) dereference when detaching, because we then recreate the menu.
741 But I am not sure why the warning was happening, and it is possible that this is a memory
744 2007-04-25 Murray Cumming <murrayc@murrayc.com>
746 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
747 and uri_parse_mailto() utility functions.
748 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
750 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
752 2007-04-24 Murray Cumming <murrayc@murrayc.com>
754 * src/dbus_api/modest-dbus-api.h:
755 * src/dbus_api/modest-dbus-callbacks.c:
756 Use an idle callback to execute the modest code in the application's own thread.
757 Remove the helloworld example method.
758 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
759 parsed, and the open-message method is not implemented because this is not yet implemented in
761 * libmodest-dbus-client/libmodest-dbus-client.c:
762 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
763 (libmodest_dbus_client_open_message):
764 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
766 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
767 body without crashing.
769 * tests/dbus_api/Makefile.am:
770 * tests/dbus_api/test_mail_to.c:
771 * tests/dbus_api/test_open_message.c: New tests for the new methods.
773 2007-04-24 Murray Cumming <murrayc@murrayc.com>
775 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
776 Added file to fix the build. Sorry.
778 * src/dbus_api/Makefile.am:
779 * src/dbus_api/modest-dbus-api.h:
780 * src/dbus_api/modest-dbus-callbacks.h:
781 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
782 (modest_dbus_req_handler):
783 Put constants in a separate header so it can be reused by the
784 client library, without duplication
786 * libmodest-dbus-client/Makefile.am:
787 * libmodest-dbus-client/libmodest-dbus-client.c:
788 (libmodest_dbus_client_call_helloworld),
789 (libmodfest_dbus_client_send_mail),
790 (libmodfest_dbus_client_mailto),
791 (libmodfest_dbus_client_open_message):
792 * libmodest-dbus-client/libmodest-dbus-client.h:
793 (Partly) Implement a send_mail D-Bus method.
795 * tests/dbus_api/Makefile.am:
796 * tests/dbus_api/test_send_mail.c: (main): Added a test for
797 the send_email D-Bus method.
799 2007-04-24 Murray Cumming <murrayc@murrayc.com>
803 * libmodest-dbus-client/Makefile.am:
804 * libmodest-dbus-client/libmodest-dbus-client.c:
805 * libmodest-dbus-client/libmodest-dbus-client.h:
806 * tests/dbus_api/Makefile.am:
807 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
808 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
810 2007-04-24 Murray Cumming <murrayc@murrayc.com>
812 * src/maemo/easysetup/modest-easysetup-wizard.c:
813 (create_page_account_details):
814 * src/maemo/modest-account-settings-dialog.c:
815 (create_page_account_details): Explicitly set auto-capitalization mode for the title
816 widgets, because this might not be the default in future versions of the Maemo GTK+.
817 However, I can not not get capitalization to work even in a simple test case.
819 2007-04-24 Murray Cumming <murrayc@murrayc.com>
821 * src/maemo/easysetup/modest-easysetup-wizard.c:
822 (create_page_custom_incoming), (create_page_custom_outgoing):
823 * src/maemo/modest-account-settings-dialog.c:
824 (create_page_account_details), (create_page_incoming),
825 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
826 instead of using gtk_check_button_with_label(), so they are aligned like the other
827 widgets, as per the UI spec.
829 2007-04-24 Murray Cumming <murrayc@murrayc.com>
831 * src/maemo/easysetup/modest-easysetup-wizard.c:
832 * src/maemo/modest-connection-specific-smtp-edit-window.c:
833 * src/widgets/modest-validating-entry.c:
834 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
835 Modest prefix instead of an EasySetup prefix.
837 2007-04-23 Murray Cumming <murrayc@murrayc.com>
839 * src/widgets/modest-validating-entry.h:
840 * src/widgets/modest-validating-entry.c: (on_insert_text),
841 Added easysetup_validating_entry_set_max_func(), used to set a callback
842 to call when the max number of characters is reached. GtkEntry has a max-length
843 already but is silent about it.
845 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
846 (create_page_account_details), (create_page_user_details),
848 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
849 (create_page_account_details), (create_page_user_details),
850 (create_page_outgoing):
851 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
852 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
853 the UI spec, when the user tries to enter more than the max number of characters.
855 2007-04-23 Murray Cumming <murrayc@murrayc.com>
857 * src/maemo/easysetup/modest-easysetup-wizard.c:
858 (create_page_user_details), (create_page_custom_incoming),
859 (create_page_custom_outgoing):
860 * src/maemo/modest-account-settings-dialog.c:
861 (create_page_user_details), (create_page_incoming),
862 (create_page_outgoing):
863 * src/maemo/modest-connection-specific-smtp-edit-window.c:
864 (modest_connection_specific_smtp_edit_window_init):
865 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
866 not appropriate. Bad Maemo-specific defaults!.
868 2007-04-23 Murray Cumming <murrayc@murrayc.com>
870 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
871 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
872 (modest_signature_editor_dialog_set_settings):
873 Disable the label and textview when the checkbox is disabled, and use the
874 specified (UI spec) default signature text.
876 2007-04-23 Murray Cumming <murrayc@murrayc.com>
878 * src/maemo/modest-connection-specific-smtp-edit-window.c:
879 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
882 * src/modest-account-mgr-helpers.h:
883 * src/modest-account-mgr-helpers.c:
884 Added modest_account_mgr_get/set_signature(), using new gconf keys.
886 * src/maemo/Makefile.am:
887 * src/maemo/modest-signature-editor-dialog.c:
888 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
891 * src/maemo/modest-account-settings-dialog.h:
892 * src/maemo/modest-account-settings-dialog.c:
893 (modest_account_settings_dialog_finalize), (on_button_signature),
894 (save_configuration): Use the new dialog when the Edit button is pressed, and
895 save the changes if necessary, as per the UI spec.
897 2007-04-23 Murray Cumming <murrayc@murrayc.com>
899 * src/maemo/Makefile.am:
900 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
901 based on maemo-develoers email from Dirk.
903 * src/maemo/easysetup/modest-easysetup-wizard.c:
904 (create_page_welcome), (create_page_account_details),
905 (create_page_user_details), (create_page_complete_easysetup),
906 (create_page_custom_incoming), (create_page_custom_outgoing),
907 (create_page_complete_custom),
908 (modest_easysetup_wizard_dialog_init):
909 * src/maemo/modest-account-settings-dialog.c:
910 (create_page_account_details), (create_page_user_details),
911 (create_page_incoming), (create_page_outgoing),
912 (modest_account_settings_dialog_init):
913 * src/maemo/modest-connection-specific-smtp-window.c:
914 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
916 2007-04-23 Murray Cumming <murrayc@murrayc.com>
918 * src/maemo/easysetup/modest-easysetup-wizard.c:
919 (create_page_account_details), (create_page_custom_outgoing),
920 (create_page_complete_custom):
921 * src/maemo/modest-account-settings-dialog.c:
922 (create_page_user_details), (create_page_incoming),
923 (create_page_outgoing):
924 * src/maemo/modest-connection-specific-smtp-edit-window.c:
925 (modest_connection_specific_smtp_edit_window_init):
926 Use the correct (UI spec) port min/max, and use horizontal separators,
929 2007-04-23 Murray Cumming <murrayc@murrayc.com>
931 * src/maemo/easysetup/modest-easysetup-wizard.c:
932 (set_default_custom_servernames):
933 * src/maemo/modest-account-settings-dialog.c:
934 (create_page_incoming), (on_combo_outgoing_security_changed),
935 (on_combo_incoming_security_changed), (create_page_outgoing),
936 (modest_account_settings_dialog_set_account_name),
937 (save_configuration):
938 * src/maemo/modest-connection-specific-smtp-edit-window.c:
939 (on_combo_security_changed),
940 (modest_connection_specific_smtp_edit_window_init),
941 (modest_connection_specific_smtp_edit_window_set_connection),
942 (modest_connection_specific_smtp_edit_window_get_settings):
943 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
946 2007-04-20 Murray Cumming <murrayc@murrayc.com>
949 * src/maemo/easysetup/modest-easysetup-wizard.c:
950 (create_page_custom_outgoing), (create_page_complete_custom):
951 * src/maemo/modest-account-settings-dialog.c:
952 (create_page_user_details), (create_page_outgoing):
953 * src/maemo/modest-account-view-window.c: (button_box_new):
954 Use changed logical IDs as per the most recent UI spec:
955 mcen_bd_emailsetup_edit -> mcen_bd_edit
956 mcen_bd_emailsetup_delete -> mcen_bd_delete
957 mcen_bd_emailsetup_close -> mcen_bd_close
959 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
963 * src/dbus_api/Makefile.am:
964 * src/dbus_api/modest-dbus-callbacks.c:
965 * src/dbus_api/modest-dbus-callbacks.h:
966 * src/maemo/modest-platform.c: (modest_platform_init):
967 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
970 * tests/dbus_api/Makefile.am:
971 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
973 2007-04-20 Murray Cumming <murrayc@murrayc.com>
975 * src/maemo/modest-account-settings-dialog.c:
976 * src/maemo/modest-connection-specific-smtp-edit-window.c:
977 Removed unnecessary includes.
979 2007-04-20 Murray Cumming <murrayc@murrayc.com>
981 * src/maemo/easysetup/modest-easysetup-wizard.c:
982 * src/maemo/modest-account-settings-dialog.c:
983 * src/maemo/modest-connection-specific-smtp-edit-window.c:
984 * src/widgets/Makefile.am:
985 * src/widgets/modest-easysetup-secureauth-combo-box.c:
986 * src/widgets/modest-easysetup-secureauth-combo-box.h:
987 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
988 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
989 * src/widgets/modest-secureauth-combo-box.c:
990 * src/widgets/modest-secureauth-combo-box.h:
991 * src/widgets/modest-serversecurity-combo-box.c:
992 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
993 made the GObject names more consistent with the rest of the Modest code.
995 2007-04-20 Murray Cumming <murrayc@murrayc.com>
997 * src/maemo/easysetup/Makefile.am:
998 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
999 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1000 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1001 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1002 * src/maemo/easysetup/modest-easysetup-wizard.c:
1003 * src/maemo/easysetup/modest-validating-entry.c:
1004 * src/maemo/easysetup/modest-validating-entry.h:
1005 * src/maemo/modest-account-settings-dialog.c:
1006 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1007 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1008 widgets/ because they are used outside of easysetup too. After checking in,
1009 svn will allow me to rename them too.
1011 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1013 * src/gnome/modest-msg-edit-window.c:
1014 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1015 linker error, to fix the build on the GNOME platform.
1016 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1017 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1018 ifdefed out to avoid a warning.
1020 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1022 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1023 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1024 some alternative for GTK+ 2.6.
1026 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1028 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1030 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1031 specified for EmailAccountsDialog in UI spec.
1033 * src/maemo/easysetup/modest-easysetup-wizard.c:
1034 * src/maemo/easysetup/modest-easysetup-wizard.h:
1035 * src/maemo/modest-account-settings-dialog.c:
1036 * src/maemo/modest-account-settings-dialog.h:
1037 Reuse a member window widget for the connection-specific SMTP server accounts,
1038 so we can tell it to create/save the accounts only if we actually save changes.
1040 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1041 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1042 (modest_connection_specific_smtp_edit_window_get_settings):
1043 Return a struct instance for temporarily remembering the entered data.
1045 * src/maemo/modest-connection-specific-smtp-window.h:
1046 * src/maemo/modest-connection-specific-smtp-window.c:
1047 (modest_connection_specific_smtp_window_finalize),
1048 (modest_connection_specific_smtp_window_fill_with_connections),
1050 (modest_connection_specific_smtp_window_save_server_accounts),
1051 (update_model_server_names): Do not actually save data until asked,
1052 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1054 (on_selection_changed),
1055 (modest_connection_specific_smtp_window_init): Disable the edit
1056 button when nothing is selected.
1058 * src/modest-account-mgr-helpers.c:
1059 * src/modest-account-mgr-helpers.h:
1060 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1063 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1065 * src/modest-account-mgr-helpers.h:
1066 * src/modest-account-mgr-helpers.c:
1067 (modest_account_mgr_get_unused_account_name),
1068 (modest_account_mgr_get_unused_account_display_name): Added these
1069 utility functions, to avoid code duplication.
1071 * src/maemo/easysetup/modest-easysetup-wizard.c:
1072 (create_page_account_details), (create_account):
1073 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1074 (on_combo_security_changed),
1075 (modest_connection_specific_smtp_edit_window_init),
1076 (modest_connection_specific_smtp_edit_window_save_settings):
1077 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1078 * src/maemo/modest-connection-specific-smtp-window.c:
1079 (modest_connection_specific_smtp_window_finalize),
1080 (modest_connection_specific_smtp_window_fill_with_connections),
1081 (on_button_edit), (modest_connection_specific_smtp_window_init):
1082 * src/maemo/modest-connection-specific-smtp-window.h:
1083 Implementing saving of connection-specific server accounts.
1085 But I need to refactor this so we can save the data for each
1086 possible connection-specific account and only actually create the server accounts
1087 when the easysetup finished, or the OK button is pressed on the account settings
1090 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1092 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1093 (on_combo_security_changed):
1094 (modest_connection_specific_smtp_edit_window_init):
1095 Auto-fill the port number as in the account settings.
1097 (modest_connection_specific_smtp_edit_window_set_connection):
1098 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1099 * src/maemo/modest-connection-specific-smtp-window.c:
1100 (fill_with_connections), (on_button_edit),
1101 (modest_connection_specific_smtp_window_init):
1102 Turn the edit window into a dialog to simplify the code, and
1103 set a WM hint as in a GtkDialog, because only a popup can be on top of
1104 another window in Maemo, and popups usually have no WM decoration.
1106 * src/modest-defs.h:
1107 * src/modest-account-mgr-helpers.c:
1108 (modest_account_mgr_set_connection_specific_smtp),
1109 (modest_account_mgr_remove_connection_specific_smtp),
1110 (modest_account_mgr_get_connection_specific_smtp):
1111 * src/modest-account-mgr-helpers.h: Some functions to write the
1112 connection-specific SMTP server information. Not yet used.
1115 * src/widgets/modest-folder-view.c: (text_cell_data):
1116 Fix a warning about an uninitialized variable.
1117 (on_configuration_key_changed): Put an #ifdef around the use
1118 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1120 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1122 * src/maemo/modest-account-settings-dialog.h:
1123 * src/maemo/modest-account-settings-dialog.c:
1124 Added connect_for_modified() utility function to mark the new modified boolean.
1126 (create_page_account_details), (create_page_user_details),
1127 (create_page_incoming), (create_page_outgoing), (on_response),
1128 (modest_account_settings_dialog_init),
1129 (modest_account_settings_dialog_set_account_name):
1130 Only warn about unsaved changes when there are actually unsaved changes.
1132 * src/modest-account-mgr-helpers.c:
1133 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1134 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1135 to get the data from there in future.
1137 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1139 * src/modest-defs.h:
1141 * src/modest-account-mgr-helpers.h:
1142 * src/modest-account-mgr-helpers.c:
1143 Store the security account setting in a single conf key instead of using
1144 the options list, so that the list is left for just the to-be-removed camel hack,
1145 and because gconf_client_set_list() is failing for some reason.
1147 * src/modest-account-mgr.c:
1148 (modest_account_mgr_add_server_account):
1149 * src/maemo/modest-account-settings-dialog.c:
1150 (modest_account_settings_dialog_set_account_name),
1151 (save_configuration): Use the renamed functions.
1154 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1156 * src/widgets/Makefile.am:
1157 * src/widgets/modest-limit-retrieve-combo-box.c:
1158 * src/widgets/modest-limit-retrieve-combo-box.h:
1159 * src/widgets/modest-retrieve-combo-box.c:
1160 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1161 the account settings dialog.
1163 * src/modest-defs.h:
1164 * src/modest-account-mgr-helpers.h:
1165 * src/modest-account-mgr-helpers.c:
1166 (modest_server_account_get_option_secure_auth),
1167 (modest_server_account_set_option_secure_auth):
1168 * src/modest-account-mgr.c:
1169 (modest_account_mgr_add_server_account):
1170 Use the existing AUTH_MECH conf key for the secure-auth setting,
1171 instead of putting it in the list options, because this was actually used already.
1173 * src/maemo/modest-account-settings-dialog.c:
1174 (create_page_account_details),
1175 (modest_account_settings_dialog_set_account_name),
1176 (save_configuration):
1177 * src/maemo/modest-account-settings-dialog.h:
1178 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1179 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1181 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1183 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1184 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1185 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1187 * src/modest-defs.h:
1188 * src/maemo/modest-account-settings-dialog.c:
1189 (create_page_incoming), (on_combo_outgoing_security_changed),
1190 (on_combo_incoming_security_changed), (create_page_outgoing),
1191 (modest_account_settings_dialog_set_account_name),
1192 (save_configuration): Load/Save the port number, and change it when the
1193 security combo changes, to suitable defaults.
1195 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1197 * src/modest-account-mgr.c:
1198 (modest_account_mgr_add_server_account): Set the security and secure-auth
1199 options, and add a comment saying that the other camel-specific options should be
1202 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1204 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1206 * src/modest-tny-account-store.c: (account_list_free),
1207 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1208 cursor->data after unreffing it. But there is some strange stuff there so it might not be
1211 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1213 * src/modest-protocol-info.c:
1214 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1215 is required by our UI spec. Maybe something in our implementation will use this eventually.
1216 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1217 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1218 instead of the previous 0 placeholder.
1220 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1221 secure-auth settings.
1222 * src/modest-account-mgr-helpers.h:
1223 * src/modest-account-mgr-helpers.c:
1224 (modest_server_account_data_get_option_secure_auth),
1225 (modest_server_account_set_option_secure_auth),
1226 (modest_server_account_data_get_option_security),
1227 (modest_server_account_set_option_security): Added this API for getting and setting the security
1228 and secure-auth settings.
1230 * src/maemo/modest-account-settings-dialog.h:
1231 * src/maemo/modest-account-settings-dialog.c:
1232 (modest_account_settings_dialog_finalize), (check_data),
1233 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1234 about changing titles.
1235 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1236 (save_configuration): Save the security and secure-auth settings.
1238 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1239 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1241 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1243 * src/modest-defs.h:
1244 * src/modest-account-mgr.c:
1245 (modest_account_mgr_add_server_account):
1246 Added and used defines for the options key and value pair strings,
1247 that are used so far, though they do not seem to correspond to anything in our
1248 UI specs or ModestProtocol enum.
1250 * src/modest-account-mgr-helpers.h:
1251 * src/modest-account-mgr-helpers.c:
1252 (compare_option_strings_for_name),
1253 (modest_server_account_data_get_option_value),
1254 (modest_server_account_data_get_option_bool),
1255 (modest_account_mgr_get_server_account_option):
1256 Added helper functions for parsing the options GSList.
1258 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1260 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1261 display name is based on the supplied account name.
1262 * src/modest-account-mgr.c:
1263 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1264 with an inefficient, but good-enough, implementation.
1266 * src/maemo/easysetup/modest-easysetup-wizard.c:
1267 (create_page_account_details), (on_before_next), (create_account):
1268 Check for existing display names rather than (non-user-visible) account names, and just
1269 create and set a unique account name at the end.
1271 * src/maemo/modest-account-settings-dialog.c:
1272 (modest_account_settings_dialog_init),
1273 (modest_account_settings_dialog_set_account_name),
1274 (create_page_incoming): Show the display name, instead of the account name.
1275 (on_response): Do some (not all) extra checks, as in the UI spec.
1276 (save_configuration): Save the display name if it was changed.
1278 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1280 * po/en_GB.po: Added needed logical ID and translation.
1281 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1282 (init_view): Made the is-default column clicking work.
1284 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1287 * src/maemo/easysetup/Makefile.am:
1288 * src/maemo/easysetup/modest-easysetup-wizard.c:
1289 (modest_easysetup_wizard_dialog_init):
1290 * src/maemo/easysetup/provider-data-test.keyfile:
1291 * src/maemo/easysetup/provider-data.keyfile:
1292 Moved the provider data file to the new modest-providers-data package and used it from there.
1294 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1296 * src/modest-local-folder-info.c:
1297 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1298 N_() was already used on the static strings, but this just marks it for translation without
1299 using the translation.
1301 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1303 * src/maemo/modest-account-settings-dialog.c:
1304 (create_page_incoming),
1305 (modest_account_settings_dialog_set_account_name):
1306 Added comments about the need for new API in ModestAccountMgr to handle the authentication
1307 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1308 I will do this if nobody else gets there first.
1310 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1312 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1313 Saved much of the incoming and outgoing data too, though I cannot yet see how to
1314 save the security stuff.
1316 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1318 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1319 Set the email address and user fullname, which I now see must be
1322 * src/maemo/modest-account-settings-dialog.h:
1323 * src/maemo/modest-account-settings-dialog.c:
1325 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1326 leave-on-server and authentication.
1327 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1330 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1333 * src/maemo/modest-account-settings-dialog.c:
1334 * src/maemo/modest-account-settings-dialog.h:
1335 Most (but not all) of the widgets are now present as specified by the UI spec.
1336 No changes are yet saved, and some details are not properly shown yet.
1338 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1340 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1342 * src/maemo/Makefile.am:
1343 * src/maemo/modest-account-settings-dialog.c:
1344 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1345 an existing account. Doesn't do much yet.
1347 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1348 Open the accounts settings dialog when Edit is clicked.
1350 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1352 * src/maemo/easysetup/Makefile.am:
1353 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1355 * src/maemo/easysetup/modest-easysetup-wizard.c:
1356 (modest_easysetup_wizard_dialog_init):
1357 Try to get the source directory from the build system,
1358 instead of hard-coding "./" into the source code, when opening our local
1359 copies of the configuration files.
1360 But this still fails when opening the wizard from the Accounts window,
1361 maybe because the working directory seems to change at runtime.
1362 So the wizard will fail the second time unless you copy the files into their
1363 proper locations - see the stdout warnings for the paths.
1365 (create_page_account_details),(on_before_next):
1366 Check for existing non-server accounts instead of server accounts,
1367 so the default account name is useful again, and to prevent trying to
1370 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1371 Show the wizard when New is clicked.
1373 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1374 (init_view): Show the column headers, and show the columns that are
1375 specified in the UI specs. However, something in Maemo's GTK+ prevents
1376 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1377 change the default account. This is despite unsetting the special properties.
1379 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1381 * docs/reference/modest-design.sgml: Corrected spelling mistake.
1382 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1383 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1384 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1385 to make that clearer.
1386 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1388 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1390 * src/maemo/modest-account-view-window.c:
1391 (modest_account_view_window_init),
1392 (modest_account_view_window_new):
1393 Use the same buttons as specified in the
1394 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1395 the existing widgets, which never had a chance of working.
1396 Put the ModestAccountView treeview in a scrolled window.
1397 Do not repeat the initialization in both _init() and _new().
1399 * src/widgets/modest-account-view.c: (update_account_view):
1400 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1401 this widget and window shows no accounts.
1403 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1405 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1407 * src/maemo/easysetup/modest-easysetup-wizard.c:
1408 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1409 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1410 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1413 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1414 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1415 accounts exist yet, as in the UI spec.
1417 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
1419 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1421 * src/maemo/Makefile.am:
1422 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1423 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1424 New window for editing connection-specific smtp details.
1425 Not fully implemented.
1427 * src/maemo/modest-connection-specific-smtp-window.c:
1428 (modest_connection_specific_smtp_window_finalize) :
1429 unref the tree model.
1430 (on_button_edit): Show the edit window.
1432 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1434 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
1437 * src/maemo/Makefile.am:
1438 * src/maemo/modest-connection-specific-smtp-window.c:
1439 * src/maemo/modest-connection-specific-smtp-window.h:
1440 New window for showing the list of connections, for connection-specific
1441 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
1442 * src/maemo/easysetup/modest-easysetup-wizard.c:
1443 (create_page_custom_outgoing): Show the new window when the button is clicked.
1445 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1447 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1448 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1449 * src/maemo/modest-msg-edit-window.c:
1450 (modest_msg_edit_window_insert_image):
1451 * src/modest-conf.c: (modest_conf_key_escape):
1452 * src/modest-mail-operation.c:
1453 (modest_mail_operation_send_new_mail):
1454 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1455 (modest_ui_actions_on_new_account):
1456 * src/widgets/modest-attachment-view.c: (update_filename_request):
1457 * src/widgets/modest-mail-header-view.c:
1458 Corrected warnings that were breaking the build, by commenting out unused variables,
1459 and a function, and by including a header.
1461 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1463 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
1464 so we can #ifdef around platform-specific code when necessary.
1465 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
1466 to allow this to build for the GNOME platform too.
1468 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1470 * src/maemo/easysetup/modest-easysetup-wizard.c:
1471 Added util_increment_name() and used it in create_page_account_details()
1472 to make sure that the default account name is always a new name.
1474 (modest_easysetup_wizard_dialog_init),
1475 (set_default_custom_servernames): Some minor memory management fixes.
1477 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1481 * src/modest-runtime.c: (init_i18n): Restored the translation
1482 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
1483 are defined in config.h, and the translations are installed.
1485 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
1486 is defined for translation.
1488 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1490 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1492 * src/maemo/easysetup/modest-easysetup-wizard.c:
1493 (modest_easysetup_wizard_dialog_init):
1494 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1495 Use realistic paths (though they should use $prefix generically) to the
1496 mcc_mapping and provider-data.keyfile files which might work when they
1497 are installed by the future version of the operator-wizard package,
1498 and then fallback to paths in our source code, with an explanatory
1501 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1505 * src/maemo/Makefile.am:
1506 * src/maemo/easysetup/: Added files from the previously-exernal
1507 osso-modest-easysetup.
1508 * src/maemo/modest-main-window-ui.h:
1509 * src/modest-ui-actions.c:
1510 * src/modest-ui-actions.h:
1511 Added modest_ui_actions_on_new_account() as a signal handler for the
1512 New Account menu item. It shows the easysetup wizard.
1513 * po/en_GB.po: Added additional needed logical IDs and translations.
1515 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
1516 Apparently ChangeLog is not used for some vague Nokia legal reasons.