1 2007-06-01 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/modest-account-view-window.c:
4 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
5 logical ID for the confirmation messages. Fixed projects.maemo.org bug
8 2007-06-01 Murray Cumming <murrayc@murrayc.com>
10 * src/maemo/easysetup/modest-easysetup-wizard.c:
11 (create_caption_new_with_asterisk):
12 * src/maemo/modest-account-settings-dialog.c:
13 (create_caption_new_with_asterisk):
14 Uncomment the code to add the asterisk, because they are no longer in the
15 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
16 (update_incoming_server_title): Add an asterisk here too.
18 2007-06-01 Murray Cumming <murrayc@murrayc.com>
20 * src/maemo/modest-maemo-global-settings-dialog.c:
21 (current_connection): Check that we are even connected before trying to
22 get the current connection name, to prevent a warning.
24 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
25 Change the comments because tny_maemo_conic_device_connect() is now meant to
27 * src/modest-mail-operation.c:
28 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
29 make sure we have a connection and fail if we can't connect.
31 2007-05-31 Murray Cumming <murrayc@murrayc.com>
33 * src/maemo/modest-main-window.c:
34 (on_account_store_connecting_finished): Do not try to get the
35 connection ID if we are not really connected. I am surprised that
36 this signal handler is called when we are not connected.
38 2007-05-31 Murray Cumming <murrayc@murrayc.com>
41 * src/modest-ui-actions.c:
42 (modest_ui_actions_get_msgs_full_error_handler):
43 Renamed an enum, added comments, added an enum
44 for retrieve-limit errors.
46 * src/modest-mail-operation.c: (foreach_add_item),
47 (internal_folder_observer_update), (update_account_thread),
48 (modest_mail_operation_get_msgs_full):
49 (modest_mail_operation_update_account),
50 Added comments about how this works, and some code that should
51 (but does not) check the retrieve-limit. See the TODO comment.
53 2007-05-31 Murray Cumming <murrayc@murrayc.com>
55 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
56 Initialize help_id to fix the build. Warnings are good.
58 2007-05-31 Murray Cumming <murrayc@murrayc.com>
60 * src/widgets/modest-hbox-cell-renderer.c:
61 (modest_hbox_cell_renderer_append):
62 * src/widgets/modest-vbox-cell-renderer.c:
63 (modest_vbox_cell_renderer_append):
64 Fix the last commit by doing an extra ref.
66 2007-05-31 Murray Cumming <murrayc@murrayc.com>
68 * src/widgets/modest-hbox-cell-renderer.c:
69 (modest_hbox_cell_renderer_append):
70 * src/widgets/modest-vbox-cell-renderer.c:
71 (modest_vbox_cell_renderer_append):
72 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
73 to fix the build with Maemo Bora.
74 However, there seems to be a remaining crash, probably due to reference
77 2007-05-30 Murray Cumming <murrayc@murrayc.com>
79 * src/modest-tny-account.c:
80 (modest_tny_account_new_for_local_folders):
81 Use hildon_file_system_info_async_new() to get a better name for
82 the memory card account, setting it as the account name.
83 The timing seems to work, but this is probably
84 not the best place to do this. See the TODO comment.
85 * src/maemo/modest-main-window.c: (create_details_widget):
86 * src/widgets/modest-folder-view.c: (text_cell_data):
87 Use the tny account name instead of hardcoding a name.
89 2007-05-30 Christian Kellner <ckellner@openismus.com>
91 * src/modest-search.c: (modest_search):
92 Correctly set part_search_func even if we have already parsed
93 the query and thus a valid OgsTextSearcher object.
95 2007-05-30 Christian Kellner <ckellner@openismus.com>
98 Search and check for libogs.
101 Incooparte the ogs build env.
103 * src/modest-mime-part-search-stream.c:
104 * src/modest-mime-part-search-stream.h:
105 Removed since we do the real searching now in modest-search.c.
107 * src/modest-search.c:
108 * src/modest-search.h:
109 Implement support for ogs. We use that if available and requested
110 and fall back to modest_text_utils_utf8_strcmp (). The search logic
111 should now handle the corner case when the search term is spread
112 across multiple reads.
113 Also the logic in modest_search () was corrected to search all
114 requested fields until one is found.
116 2007-05-30 Murray Cumming <murrayc@murrayc.com>
118 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
121 * src/modest-init.c: Made modest_init_local_folders() take a
122 path and be public so we can iniitialize maildir folders on
125 * src/modest-local-folder-info.h:
126 * src/modest-local-folder-info.c:
127 (modest_local_folder_info_get_maildir_path): Add a path parameter.
129 * src/modest-tny-account.c:
130 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
131 still means the standard local-folders path on the local volume.
133 * src/modest-tny-account-store.c:
134 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
135 signal so we can detect mount/unmount of the MMC1 card, and do an update of
136 all accounts when that happens.
137 (get_server_accounts): If the MMC1 card is mounted, create a store account for
138 this too, so it shows up in the treeview.
140 2007-05-28 Murray Cumming <murrayc@murrayc.com>
142 * src/maemo/modest-maemo-global-settings-dialog.c:
143 (current_connection):
144 * src/widgets/modest-global-settings-dialog.c:
145 (current_connection_default):
146 Use the enum values instead of 0, 1 and -1,
147 to make the code clearer.
149 * src/modest-account-mgr-helpers.c:
150 (modest_account_mgr_get_connection_specific_smtp): Make this code
153 * src/modest-runtime.h:
154 * src/modest-runtime.c:
155 Added modest_runtime_remove_all_send_queues().
156 * src/maemo/modest-main-window.c:
157 (on_account_store_connecting_finished): Recreate the send queues,
158 using the appropriate transport accounts for this new connection.
159 Some futher adapting might be needed if the old send queues are not
160 automatically stopped at this point.
162 * src/modest-tny-account-store.c: (get_server_accounts):
163 Create the connection-specific transport accounts, so that they can
164 be found later by their ID.
166 * src/modest-tny-account.h:
167 * src/modest-tny-account.c:
168 Added modest_tny_account_new_from_server_account_name().
169 modest_tny_account_new_from_server_account(): Do not create the
170 send queues here, because they will be
171 recreated anyway when the connection changes for the first time.
173 2007-05-28 Murray Cumming <murrayc@murrayc.com>
175 * src/modest-local-folder-info.h:
176 * src/modest-local-folder-info.c:
177 (modest_per_account_local_outbox_folder_info_get_maildir_path),
178 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
179 tbox_folder): Take a modest account name instead of a server TnyAccount,
180 so we can have per-modest-account rather than per-transport-account
182 We must make sure that we change or recreate the exisitng send queues
183 when the connection changes for connection-specific transport accounts.
185 * src/modest-tny-account-store.c:
186 (create_per_account_local_outbox_folders): Create outboxed per modest
187 account, not per transport account.
189 * src/modest-tny-account.h:
190 * src/modest-tny-account.c:
191 (modest_tny_account_get_special_folder): For outboxes, get the
192 parent modest account name. The account is ignored for other folders.
193 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
194 modest account name rather than a server TnyAccount.
196 2007-05-25 Murray Cumming <murrayc@murrayc.com>
198 * src/modest-tny-account.c:
199 (modest_tny_account_new_from_server_account):
200 Call modest_runtime_get_send_queue() immediately after creating transport
201 accounts, so that they start trying to send email from the outbox as soon
202 as possible at startup. This is probably what we want.
204 * src/modest-mail-operation.c: (update_account_thread):
205 * src/modest-runtime.c: (modest_runtime_get_send_queue):
206 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
207 * src/modest-tny-send-queue.h:
208 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
209 (modest_ui_actions_on_send):
210 Added comments about how sending works, though it needs some more work.
212 2007-05-25 Murray Cumming <murrayc@murrayc.com>
214 * src/modest-tny-account.c:
215 (modest_tny_account_get_special_folder): Add TODO because this fails when
217 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
218 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
219 Do not try to show this window when there is no active account. The UI
220 specs does not tell us what to do in this case.
222 2007-05-24 Murray Cumming <murrayc@murrayc.com>
226 * src/maemo/Makefile.am:
227 * src/widgets/Makefile.am: Some dist fixes.
229 2007-05-24 Murray Cumming <murrayc@murrayc.com>
231 * src/maemo/modest-connection-specific-smtp-window.c:
232 (on_button_edit): Make the code clearer, to prevent a double free.
234 2007-05-24 Murray Cumming <murrayc@murrayc.com>
236 * src/maemo/modest-account-settings-dialog.c:
237 (modest_account_settings_dialog_set_account_name),
238 Check the connection-specific smtp servers checkbox if there are any.
240 * src/maemo/modest-connection-specific-smtp-edit-window.c:
241 (modest_connection_specific_smtp_edit_window_init):
242 Start with a suitable port number.
244 * src/modest-account-mgr-helpers.h:
245 * src/modest-account-mgr-helpers.c: Added
246 modest_account_mgr_get_has_connection_specific_smtp().
248 (modest_account_mgr_set_connection_specific_smtp),
249 (modest_account_mgr_remove_connection_specific_smtp),
250 (modest_account_mgr_get_has_connection_specific_smtp),
251 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
252 connection-specific smtp server accounts in the account, rather than
253 the server account conf dir.
255 This fixes bug projects.maemo.org bug NB#58263 .
257 * src/modest-tny-account-store.c:
258 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
259 if there are no server accounts yet, to prevent an infinite loop when there
260 are no accounts. Document that one must be called before the other.
262 2007-05-24 Murray Cumming <murrayc@murrayc.com>
264 * src/modest-account-mgr-helpers.c:
265 (modest_account_mgr_get_default_account): Make sure that at least
266 one account is always the default, if there are any enabled accounts.
267 This is just a sanity check that shouldn't be necessary.
269 * src/modest-account-mgr-priv.c:
270 (_modest_account_mgr_account_from_key): Unescape the conf key to
271 get the real account name. For instance, this is an issue if a space
272 was in the account name, which can happen because the account name
273 is generated from the display name.
274 (_modest_account_mgr_get_account_keyname): Always escape the
276 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
277 Unescape the conf keys to get the real account names.
279 For instance, previously the is-default radio button in the accounts
280 list was not checked for any accounts at first. This fixes that,
281 and might fix several similar bugs.
283 2007-05-23 Murray Cumming <murrayc@murrayc.com>
285 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
286 Removed some debug printfs.
288 2007-05-23 Murray Cumming <murrayc@murrayc.com>
290 Modest on-disk outbox directories are now here, for instance:
291 $HOME/.modest/outboxes/<account-id-1>/outbox
292 $HOME/.modest/outboxes/<account-id-2>/outbox
294 $HOME/.modest/local-folders/outbox
295 so we can have a separate outbox for each account.
296 But they are shown as one outbox in the GtkTreeView, by using a
297 TnyMergeFolder in a ModestTnySimpleFolderStore.
300 * src/modest-tny-simple-folder-store.c:
301 * src/modest-tny-simple-folder-store.h:
302 Added ModestTnySimpleFolderStore, used to contain folders from
303 other folder stores, such as other accounts.
305 * src/modest-tny-outbox-account.h:
306 * src/modest-tny-outbox-account.c:
307 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
308 used for the per-account local outbox folders.
310 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
311 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
312 only use this (internally) now for the non-outbox local folders.
315 * src/modest-init.c: Added modest_init_one_local_folder(), for
316 setting up the directory structure for each local folder.
318 * src/modest-local-folder-info.c:
319 (modest_per_account_local_outbox_folder_info_get_maildir_path),
320 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
322 * src/modest-local-folder-info.h:
323 * src/modest-tny-account-store.c: (on_account_removed),
324 (on_account_changed), (create_per_account_local_outbox_folders),
325 (get_server_accounts), (modest_tny_account_store_get_accounts),
326 (modest_tny_account_store_get_tny_account_by_account),
327 (modest_tny_folder_store_is_virtual_local_folders):
329 * src/modest-tny-account.h:
330 * src/modest-tny-account.c:
331 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
332 to create an on-disk per-account local outbox folder for each
334 (create_per_account_local_outbox_folders): Create a local outbox folder
335 for each transport account.
336 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
337 for all local folders.
339 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
340 instead of using g_object_get/set() directly. It is clearer.
342 (modest_tny_folder_store_get_message_count),
343 (modest_tny_folder_store_get_local_size
344 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
345 because we now use these with non-acount folder stores.
347 (modest_tny_account_get_special_folder),
348 (modest_tny_account_new_from_server_account),
349 (modest_tny_account_new_from_account):
350 (recurse_folders): Adjust to the new outbox system.
352 * src/modest-tny-folder.h:
353 * src/modest-tny-folder.c:
354 (modest_tny_folder_is_local_folder),
355 (modest_tny_folder_get_local_folder_type),
356 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
358 * src/widgets/modest-main-window.h:
359 * src/maemo/modest-main-window.c: (create_details_widget),
360 (modest_main_window_set_contents_style): Show details for any folder store,
363 (modest_tny_folder_get_rules):
364 Remove the const. C does not support constness enough for this.
366 * src/modest-ui-actions.c:
367 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
368 make all outboxes appear as one, in the usual local-folders tree node.
370 (set_active_account_from_tny_account),
371 (modest_ui_actions_on_folder_selection_changed):
372 * src/widgets/modest-folder-view.c: (text_cell_data),
373 (icon_cell_data), (filter_row),
374 (add_account_folders_to_merged_folder),
375 (add_account_folders_to_simple_folder_store), (),
376 (get_cmp_rows_type_pos), (cmp_rows),
377 (modest_folder_view_set_account_id_of_visible_server_account):
378 Adjust to the new outbox system, using generic folder stores and folders
381 2007-05-23 Christian Kellner <ckellner@openismus.com>
383 * src/modest-mail-operation.c:
384 (modest_mail_operation_update_account):
385 Use info->max_size instead of unintialized local var [small
386 build fix]. (Added TODO to review that change since I don't
389 2007-05-23 Marcus Bauer <marcusb@openismus.com>
391 * libmodest-dbus-client/libmodest-dbus-client.c:
392 (libmodest_dbus_client_compose_mail): function added
393 * src/dbus_api/modest-dbus-api.h:
394 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
395 (on_compose_mail): Implementation of the SendAsMail functionality
397 2007-05-22 Murray Cumming <murrayc@murrayc.com>
399 * src/modest-account-mgr.c:
400 (modest_account_mgr_add_server_account): Set the secure-connection
401 conf key for transport accounts as well as store accounts. I don't know
402 why the if was there. For instance, this makes sure that we use SSL
403 for the gmail preset from the easysetup wizard.
405 2007-05-22 Murray Cumming <murrayc@murrayc.com>
407 * src/gnome/modest-main-window.c:
408 (on_account_store_connecting_finished), (connect_signals):
409 * src/maemo/modest-main-window.c:
410 (on_account_store_connecting_finished), (connect_signals),
411 (modest_main_window_new):
412 Handle TnyAccountStore::connecting-finished instead of
413 TnyDevice::connection-changed, because we cannot actually perform
414 operations on accounts until TnyAccountStore has itself responded to
415 the TnyDevice::connection-changed signal. This prevents a GError from
417 Do not try to update at startup, because we (at least on scratchbox)
418 already do an update at startup when the device goes online.
419 This prevents a GError from tinymail.
420 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
421 Added TODO about stopping simultaneous operations.
423 2007-05-21 Murray Cumming <murrayc@murrayc.com>
425 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
426 * src/modest-mail-operation-queue.c:
427 (modest_mail_operation_queue_remove):
428 * src/modest-tny-account-store.c: When GErrors happen, give more clues
429 about where they happened.
431 2007-05-21 Murray Cumming <murrayc@murrayc.com>
433 * src/modest-ui-actions.c:
434 (modest_ui_actions_on_password_requested): Make sure that the remember
435 output parameter is always TRUE.
437 2007-05-21 Murray Cumming <murrayc@murrayc.com>
439 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
440 Show a OK/Cancel dialog if the error is a question, though we still do not
441 know anything more about what we are asking the user.
442 * src/widgets/modest-folder-view.c: (on_drag_data_received):
443 Fix an uninitialized variable (helper). This is a logic error, however.
445 2007-05-21 Christian Kellner <ckellner@openismus.com>
447 * src/modest-search.h:
448 Correct bit shifting in the ModestSearchFlags enum.
450 2007-05-21 Murray Cumming <murrayc@murrayc.com>
452 * src/modest-tny-account.c:
453 (modest_tny_account_new_from_server_account): Do not use the lsub and
454 check-all hard-coded IMAP options when using POP.
456 2007-05-21 Murray Cumming <murrayc@murrayc.com>
458 * src/modest-tny-account.c:
459 (modest_tny_account_new_from_server_account):
460 Use NULL for the secure-auth method for POP when Password auth has been
461 specified by the user, as we already do for IMAP. "auth=Login" causes
462 an error from camel or the server.
464 2007-05-17 Murray Cumming <murrayc@murrayc.com>
466 * src/maemo/modest-account-settings-dialog.c:
467 (create_page_account_details),
468 (modest_account_settings_dialog_set_account_name):
469 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
470 for the leave-on-server checkbox, rathr than just the checkbox, when
471 the protocol is not POP.
473 2007-05-17 Murray Cumming <murrayc@murrayc.com>
475 * src/widgets/modest-account-view.c:
476 * src/widgets/modest-account-view.h:
477 Added modest_account_view_select_account() which will be useful later
478 to asynchronously re-select the edited account.
480 2007-05-17 Murray Cumming <murrayc@murrayc.com>
482 * src/maemo/modest-account-settings-dialog.c:
483 (modest_account_settings_dialog_set_account_name):
484 Automatically choose the port numbers based on the secure authentication
485 methods, if they have not been chosen before.
486 This fixes projects.maemo.org bug NB#56273 .
488 2007-05-17 Murray Cumming <murrayc@murrayc.com>
490 * src/maemo/modest-main-window-ui.h:
491 * src/modest-ui-actions.c:
492 * src/modest-ui-actions.h:
493 Connect the Tools/SMTP Servers menu item to
494 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
495 SMTP servers dialog, as in the UI specification and saves changes when it
496 is closed. This fixed projects.maemo.org bug NB#56305 .
498 2007-05-17 Murray Cumming <murrayc@murrayc.com>
500 * src/maemo/modest-connection-specific-smtp-window.c:
501 (modest_connection_specific_smtp_window_init):
502 Use gtk_window_set_default_size() to make this window big enough, so
503 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
505 2007-05-17 Murray Cumming <murrayc@murrayc.com>
507 * src/maemo/modest-connection-specific-smtp-edit-window.h:
508 * src/maemo/modest-connection-specific-smtp-edit-window.c:
509 (modest_connection_specific_smtp_edit_window_init),
510 Do not try to connect to a combobox signal before the combobox exists.
511 This fixes the cras in projects.maemo.org bug NB#56288 .
512 (modest_connection_specific_smtp_edit_window_get_settings):
513 Remove the server_account_name parameter which was being checked for NULL
514 though it was not used.
516 * src/maemo/modest-connection-specific-smtp-window.c:
517 (modest_connection_specific_smtp_window_fill_with_connections),
518 (on_button_edit), (modest_connection_specific_smtp_window_init):
519 Correct the number of treemodel columns to prevent a warning.
520 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
521 libconic does not work.
523 2007-05-16 Murray Cumming <murrayc@murrayc.com>
525 * src/modest-tny-account.c:
526 (modest_tny_account_new_from_server_account):
527 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
528 SMTP when "None" was chosen by the user. However, with my SMTP server that
529 does not support ANONYMOUS, the emails do not leave the Outbox and I see
532 2007-05-16 Murray Cumming <murrayc@murrayc.com>
534 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
535 to explain the memory management issue with the ID in the ModestPair.
537 * src/gnome/modest-account-assistant.c: (add_receiving_page),
538 (add_sending_page), (modest_account_assistant_finalize):
539 * src/gnome/modest-gnome-global-settings-dialog.c:
540 (create_updating_page), (create_composing_page):
541 * src/gnome/modest-msg-edit-window.c: (get_transports),
542 (init_window), (modest_msg_edit_window_finalize),
543 (modest_msg_edit_window_get_msg_data):
544 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
545 * src/gnome/modest-transport-widget.c:
546 (modest_transport_widget_finalize), (smtp_configuration):
547 * src/maemo/modest-maemo-global-settings-dialog.c:
548 (create_updating_page), (create_composing_page):
549 * src/maemo/modest-msg-edit-window.c: (get_transports),
550 (init_window), (modest_msg_edit_window_finalize),
551 (modest_msg_edit_window_get_msg_data),
552 (modest_msg_edit_window_free_msg_data):
553 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
554 (modest_store_widget_finalize):
555 * src/maemo/modest-transport-widget.c:
556 (modest_transport_widget_finalize), (smtp_configuration):
557 * src/modest-main.c: (send_mail):
558 * src/widgets/modest-combo-box.h:
559 * src/widgets/modest-global-settings-dialog-priv.h:
560 * src/widgets/modest-global-settings-dialog.c:
561 (modest_global_settings_dialog_finalize):
562 * src/widgets/modest-msg-edit-window.h:
563 Whenever using modest_combo_box_new(), keep the ModestPairList alive
564 as long as the combo box, to prevent use of freed memory for the ID.
566 2007-05-15 Murray Cumming <murrayc@murrayc.com>
568 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
569 get_accounts(), to make this clearer. Do not check for the enabled gconf
570 key, because we do not use this for server accounts (at least, not yet).
571 This allows us to send email again.
573 2007-05-15 Murray Cumming <murrayc@murrayc.com>
575 * src/maemo/modest-platform.c:
576 (on_modest_conf_update_interval_changed), (modest_platform_init):
577 Only respond to this particular key change. All these strcmp()s cannot be
580 2007-05-15 Murray Cumming <murrayc@murrayc.com>
582 * src/maemo/modest-maemo-global-settings-dialog.c:
583 (current_connection): Prevent a crash in scratchbox when
584 ny_maemo_conic_device_get_current_iap_id() returns NULL.
585 * src/maemo/modest-platform.c:
586 (on_modest_conf_update_interval_changed), (modest_platform_init):
587 Get the update interval from gconf and reset it when the gconf key changes.
589 2007-05-15 Murray Cumming <murrayc@murrayc.com>
591 * src/modest-protocol-info.c:
592 * src/modest-protocol-info.h: Adde enum-specific get functions,
593 instead of using a ModestProtocolType enum parameter.
595 * src/gnome/modest-account-assistant.c:
596 * src/gnome/modest-store-widget.c:
597 * src/gnome/modest-store-widget.h:
598 * src/gnome/modest-transport-widget.c:
599 * src/gnome/modest-transport-widget.h:
600 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
601 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
602 * src/maemo/easysetup/modest-easysetup-wizard.c:
603 * src/maemo/modest-account-settings-dialog.c:
604 * src/maemo/modest-account-settings-dialog.h:
605 * src/maemo/modest-store-widget.c:
606 * src/maemo/modest-store-widget.h:
607 * src/maemo/modest-transport-widget.c:
608 * src/maemo/modest-transport-widget.h:
609 * src/modest-account-mgr-helpers.c:
610 * src/modest-account-mgr-helpers.h:
611 * src/modest-account-mgr.c:
612 * src/modest-account-mgr.h:
613 * src/modest-tny-account.c:
614 * src/modest-tny-folder.c:
615 * src/widgets/modest-account-view.c:
616 * src/widgets/modest-retrieve-combo-box.c:
617 * src/widgets/modest-retrieve-combo-box.h:
618 * src/widgets/modest-secureauth-combo-box.c:
619 * src/widgets/modest-serversecurity-combo-box.c:
620 * src/widgets/modest-serversecurity-combo-box.h:
621 * tests/check_account-mgr.c:
622 Use the specific functions, and use the re-renamed enum values for GNOME too.
624 2007-05-15 Murray Cumming <murrayc@murrayc.com>
627 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
628 so we can get the second based on the first.
630 * src/maemo/modest-account-settings-dialog.h:
631 * src/maemo/modest-account-settings-dialog.c:
632 Added get_supported_secure_authentication_methods(), though it is mostly
633 commented-out for now until the necessary API is committed to tinymail.
634 (modest_account_settings_dialog_set_account_name),
635 (save_configuration): Request the supported authentication methods from the
636 server, so we can choose a working method.
638 * src/modest-tny-account-store.h:
639 * src/modest-tny-account-store.c:
640 (modest_tny_account_store_get_session): Rename from
641 tny_account_store_get_session().
643 2007-05-14 Murray Cumming <murrayc@murrayc.com>
645 * src/modest-protocol-info.h: Split the ModestProtocol enum
646 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
647 There was no need to have these unrelated values in one enum.
649 * src/: many files: Adapted to changed enum. This makes the code a bit
650 clearer, and the compiler could catch some errors.
652 2007-05-14 Murray Cumming <murrayc@murrayc.com>
654 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
655 Show the detailed internal camel error message when an error happens
656 during the configuration, so that our testers can give us more clues.
657 For instance, in projects.maemo.org bug NB#56910 .
659 2007-05-14 Murray Cumming <murrayc@murrayc.com>
661 * src/modest-tny-account.c:
662 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
663 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
665 2007-05-14 Murray Cumming <murrayc@murrayc.com>
667 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
668 * src/maemo/modest-account-settings-dialog.c:
669 (modest_account_settings_dialog_set_account_name),
670 (save_configuration): For the incoming secure authentication checkbox,
671 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
672 the UI specification. PLAIN does not seem to be supported for most IMAP
673 servers anyway, and I am not sure what it would mean.
674 However, we probably need to discover which of the secure-authentication
675 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
676 * src/modest-account-mgr-helpers.c:
677 (modest_account_mgr_get_server_account_data):
679 * src/modest-tny-account.c:
680 (modest_tny_account_new_from_server_account):
681 Use tny_account_set_mech() to set secure-authentication methods,
682 with some special-casing for IMAP, based on my observations of how
685 * src/modest-account-mgr-helpers.h:
686 * src/modest-account-mgr.c:
687 * src/modest-defs.h: Comment that the URI is only used for local folders.
689 2007-05-11 Murray Cumming <murrayc@murrayc.com>
691 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
692 parameter const, just to be neat.
693 * src/modest-text-utils.c: (modest_text_utils_inline):
694 End g_strconcat() with NULL, as its documentation says. This is almost
695 certainly the cause of my crash at startup on the device. Interestingly,
696 valgrind doesn't tell us about these errors.
698 2007-05-11 Murray Cumming <murrayc@murrayc.com>
700 * scripts/build-packages: Added more precise comments about how to use
701 this script, though I still get this error:
702 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
703 error building tinymail
705 2007-05-11 Murray Cumming <murrayc@murrayc.com>
707 * src/maemo/modest-main-window.c: (on_account_update):
708 Very slight cleanup, hoping to make it simpler to discover what causes
709 a crash here sometimes.
711 * src/modest-tny-account.c:
712 (modest_tny_account_new_from_server_account): Set the port. Added
713 comments about the options and a TODO comment because I need to find out
714 how to specify the secure authentication method.
716 2007-05-11 Marcus Bauer <marcusb@openismus.com>
718 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
719 changed CFlags paths form modest to libmodest
721 2007-05-10 Murray Cumming <murrayc@murrayc.com>
723 * src/modest-account-mgr-helpers.c:
724 (modest_account_mgr_get_server_account_data),
725 (modest_account_mgr_free_server_account_data):
726 * src/modest-account-mgr-helpers.h:
727 * src/modest-account-mgr.c:
728 (modest_account_mgr_add_server_account):
730 * src/modest-tny-account.c:
731 (modest_tny_account_new_from_server_account):
732 Determine the options for tny_camel_account_add_option() here,
733 based on the settings, rather than storing them directly in gconf.
735 2007-05-10 Murray Cumming <murrayc@murrayc.com>
737 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
738 Show a more friendly error dialog now that we expect (from the tinymail
739 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
741 2007-05-10 Murray Cumming <murrayc@murrayc.com>
743 * src/maemo/modest-main-window.c: (on_account_update): Check that
744 account_name is not NULL, to prevent a crash at startup that I am
745 seeing on the N800. I do wonder why it is NULL.
747 * src/maemo/easysetup/modest-easysetup-wizard.c:
748 (create_page_user_details):
749 * src/maemo/modest-account-settings-dialog.c:
750 (create_page_user_details), (create_page_outgoing):
751 * src/maemo/modest-connection-specific-smtp-edit-window.c:
752 (modest_connection_specific_smtp_edit_window_init):
753 * src/modest-ui-actions.c:
754 (modest_ui_actions_on_password_requested):
755 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
756 might do something useful with the on-screen keyboard.
758 2007-05-10 Murray Cumming <murrayc@murrayc.com>
760 * src/maemo/modest-main-window.c: (on_account_update):
761 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
762 NULL, to avoid lots of warnings. However, it probably should not be NULL.
764 2007-05-09 Murray Cumming <murrayc@murrayc.com>
766 * src/modest-tny-account-store.c: (on_account_changed):
767 Correct the signature of this signal handler.
769 2007-05-09 Murray Cumming <murrayc@murrayc.com>
771 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
772 Show a HildonNote instead of a GtkDialog for Maemo.
774 2007-05-09 Murray Cumming <murrayc@murrayc.com>
776 * src/widgets/modest-account-view.h:
777 * src/widgets/modest-account-view.c: (on_account_changed),
778 (on_account_removed). Added a boolean flag, set/unset by
779 modest_account_view_block_conf_updates(),
780 modest_account_view_unblock_conf_updates() to prevent unnecessary
781 updates, but this is not very useful because the gconf notifications are
782 so delays (maybe only on Maemo Bora).
783 So auto-updating is turned off, and these functions do an explicit
784 update when necessary.
785 However, something else is still doing too much work when adding/removing
786 accounts, probably in another part of the application.
788 * src/maemo/modest-account-view-window.c:
789 (on_delete_button_clicked), (on_edit_button_clicked),
790 (on_new_button_clicked): Use the new functions.
792 2007-05-09 Murray Cumming <murrayc@murrayc.com>
794 * src/modest-account-mgr-helpers.c:
795 (modest_account_mgr_set_first_account_as_default):
796 Sort the list of names alphabetically-by-title, so we choose the first one
798 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
799 alphabetically by the title.
801 This fixes projects.maemo.org bug NB#56418 .
803 * src/modest-account-mgr-priv.c:
804 (_modest_account_mgr_account_from_key):
805 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
806 avoid a valgrind error, and possible random behaviour.
808 2007-05-09 Murray Cumming <murrayc@murrayc.com>
810 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
811 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
812 tinymail documentation to say that this can be expected.
813 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
814 pretty, and should not happen, but I would prefer to know when it does.
816 2007-05-09 Murray Cumming <murrayc@murrayc.com>
818 * configure.ac: When using the older hildon version, probably on Bora,
819 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
821 * src/widgets/modest-attachment-view.c:
822 (modest_attachment_view_set_part_default): Initialize variables, to fix the
825 2007-05-09 Marcus Bauer <marcusb@openismus.com>
827 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
828 Implemented the prototype. Can be tested with
829 tests/dbus_api/test_open_message:
831 2007-05-08 Murray Cumming <murrayc@murrayc.com>
833 * src/modest-tny-account-store.c:
834 (modest_tny_account_store_instance_init), (get_password):
835 * src/modest-ui-actions.c:
836 (modest_ui_actions_on_password_requested):
837 Do not store the password in gconf, because this function is called
838 for non-remembered passwords. Actually use the cached (in the hash map)
839 password instead of releasing it.
840 The password will now not be remembered if it is asked via the protected
841 password dialog, as per the UI spec.
843 2007-05-08 Murray Cumming <murrayc@murrayc.com>
846 * src/modest-account-mgr-helpers.h:
847 * src/modest-account-mgr-helpers.c:
848 Added modest_server_account_get_username_has_succeeded(),
849 modest_server_account_set_username_has_succeeded().
850 (modest_server_account_set_username),
851 Reset the has-succeeded flag if the username changes.
853 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
854 * src/maemo/modest-connection-specific-smtp-window.c:
855 (modest_connection_specific_smtp_window_save_server_accounts):
856 Use modest_server_account_set_username() instead of using
857 modest_conf_set_string() directly, so that the has-succeeded flag is always
860 * src/modest-ui-actions.c:
861 (modest_ui_actions_on_password_requested): Dim the username entry if
862 the username has ever worked, as per the UI spec.
864 2007-05-08 Murray Cumming <murrayc@murrayc.com>
866 * src/modest-tny-account-store.c: (get_password):
867 * src/modest-ui-actions.c:
868 (modest_ui_actions_on_password_requested):
869 Allow the username to be changed too, though there is more work to
870 be done on exactly how this behaves.
872 2007-05-08 Murray Cumming <murrayc@murrayc.com>
874 * src/modest-account-mgr-helpers.h:
875 * src/modest-account-mgr-helpers.c:
876 Added modest_account_mgr_get_display_name(),
877 modest_server_account_get_username(),
878 modest_server_account_set_username(),
879 modest_server_account_set_password(),
880 modest_server_account_get_hostname() functions so we do not need to
881 use the conf API directly.
883 * src/maemo/modest-main-window.c: (connect_signals):
884 Actually connect ot the ModestAccountStore::request-password signal,
885 so that we show the dialog when the password is requested by Tinymail,
886 for isntance if it is empty.
888 * src/modest-marshal.list:
889 * src/modest-tny-account-store.c:
890 (modest_tny_account_store_class_init), (get_password),
891 (modest_tny_account_store_alert):
892 * src/modest-tny-account-store.h:
893 * src/modest-ui-actions.h:
894 * src/modest-ui-actions.c:
895 (modest_ui_actions_on_password_requested):
896 Change the signal parameters, so it is obvious that we are providing
897 the non human-readable server name, and receiving both the username
898 and password, though changing of the username is not yet implemented.
899 Change the dialog UI to match the Maemo UI specifications, with #idfefing
900 for the GNOME version.
902 This should fix the projects.maemo.org bug NB#56209, though it does not
903 work on Bora, because the gconf_client_get() for the password fails
904 immediately after we save it with gconf_client_set().
906 2007-05-08 Murray Cumming <murrayc@murrayc.com>
909 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
910 caused an undefined symbol error:
911 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
913 2007-05-08 Murray Cumming <murrayc@murrayc.com>
915 * src/modest-tny-account-store.c:
916 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
917 using a GError instead of a string message, so we can translate it in
920 2007-05-08 Murray Cumming <murrayc@murrayc.com>
922 * src/maemo/modest-address-book.c:
923 (modest_address_book_check_names):
924 * src/maemo/modest-msg-view-window.c:
925 (modest_msg_view_window_clipboard_owner_change):
926 * src/modest-init.c: (modest_init_init_ui):
927 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
928 (update_folders_cb), (modest_mail_operation_update_account):
929 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
930 (modest_ui_actions_on_msg_attachment_clicked),
931 (modest_ui_actions_on_msg_recpt_activated):
932 * src/widgets/modest-header-view.c: (drag_data_get_cb):
933 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
934 (modest_msg_view_search_next):
935 * src/widgets/modest-recpt-editor.c:
936 (modest_recpt_editor_on_button_release_event),
937 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
938 g_message(). At this point we should only be seeing interesting errors on
939 stdout. Debugging messages could be #ifdefed-out if they are still useful.
941 2007-05-07 Murray Cumming <murrayc@murrayc.com>
943 (modest_wizard_dialog_force_title_update):
944 * src/maemo/easysetup/modest-wizard-dialog.h:
945 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
946 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
947 can update the title when appropriate. Otherwise the title is wrong if the
948 pages are added after adding the notebook to the dialog.
949 This must be a problem in HildonWizardDialog too.
950 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
952 * src/maemo/easysetup/modest-easysetup-wizard.c:
953 (create_subsequent_customsetup_pages),
954 (create_subsequent_easysetup_pages):
955 Call modest_wizard_dialog_force_title_update() so that the title is
956 correct even with GTK+ < 2.10.
957 This fixes projects.maemo.org bug NB#56145 .
959 2007-05-07 Murray Cumming <murrayc@murrayc.com>
961 * src/maemo/modest-platform.c:
962 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
963 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
966 2007-05-07 Murray Cumming <murrayc@murrayc.com>
968 * src/widgets/modest-window.h:
969 * src/widgets/modest-window.c: Added a save_state_func vfunc,
970 and modest_window_save_state(), which invokes it.
972 * src/widgets/modest-window-mgr.h:
973 * src/widgets/modest-window-mgr.c:
974 Added modest_window_mgr_save_state_for_all_windows(), which calls
975 the save_state vfunc on all registered windows, if implemented.
977 * src/gnome/modest-msg-edit-window.c:
978 * src/gnome/modest-msg-view-window.c:
979 * src/maemo/modest-msg-edit-window.c:
980 * src/maemo/modest-msg-view-window.c:
981 * src/maemo/modest-main-window.c:
982 Specify the existing save_settings functions as implementations of
983 ModestWindow::save_state_func().
985 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
986 Call modest_window_mgr_save_state_for_all_windows(). This happens before
987 enabling hibernation, for instance.
989 We may need to do the same thing for restoring settings.
992 2007-05-07 Murray Cumming <murrayc@murrayc.com>
994 * src/widgets/modest-window-mgr.c:
995 * src/widgets/modest-window-mgr.h:
996 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
997 modest_window_mgr_get_hibernation_is_prevented().
999 * src/maemo/modest-main-window.c:
1000 (on_hildon_program_is_topmost_notify): Prevent hibernation
1001 (possible when the application goes to the background in the WM),
1002 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1004 * src/maemo/easysetup/modest-easysetup-wizard.c:
1005 (modest_easysetup_wizard_dialog_init):
1006 * src/maemo/modest-account-settings-dialog.c:
1007 (modest_account_settings_dialog_init):
1008 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1009 (modest_connection_specific_smtp_edit_window_init):
1010 * src/maemo/modest-connection-specific-smtp-window.c:
1011 (modest_connection_specific_smtp_window_init):
1012 * src/maemo/modest-signature-editor-dialog.c:
1013 (modest_signature_editor_dialog_init):
1014 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1015 prevent hibernation while any of these account settings dialogs are open.
1017 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1019 * src/maemo/Makefile.am:
1020 * src/maemo/modest-osso-state-saving.c:
1021 * src/maemo/modest-osso-state-saving.h: Added
1022 modest_osso_load_state() and modest_osso_save_state() though they do
1023 nothing now. They should iterate through all the open windows and load/save
1025 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1026 save state when closing.
1028 * src/maemo/modest-main-window.c:
1029 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1030 Add a notification handler for the HildonProgram::is-topmost property,
1031 so we can allow hibernation when the application goes into the background.
1032 But we still need to detect when the accounts setup windows are open so
1033 we can stop hibernation when they are open.
1034 To do this, I also added the main window the HildonProgram. This might have
1035 other side-effects/benefits, and should maybe be done for other windows.
1037 * src/maemo/modest-osso-autosave-callbacks.h:
1038 * src/maemo/modest-osso-autosave-callbacks.c:
1039 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1040 though it does not do anything yet, and we might never need this to do
1041 anything. For instance, we already save drafts.
1043 * src/maemo/modest-platform.c: (modest_platform_init):
1044 Specify the libosso auto-save callback.
1046 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1048 * src/maemo/modest-platform.c:
1049 (modest_platform_set_update_interval):
1050 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1051 aparently stays valid between application instances, so we can use this
1052 to remove and reset it later. According to a maemo-developers email from
1055 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1057 * configure.ac: Depend on libalarm for Maemo.
1059 * src/dbus_api/modest-dbus-api.h:
1060 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1061 (on_send_receive), (modest_dbus_req_handler):
1062 Handle a SEND_RECEIVE D-Bus method.
1064 * libmodest-dbus-client/libmodest-dbus-client.c:
1065 (libmodest_dbus_client_send_and_receive):
1066 * libmodest-dbus-client/libmodest-dbus-client.h:
1067 Add C convenience functions for calling the new D-Bus method.
1069 * src/modest-platform.h:
1070 * src/gnome/modest-platform.c:
1071 * src/maemo/modest-platform.c:
1072 Added modest_platform_set_update_interval(), which uses the
1073 alarmd API on Maemo.
1074 (modest_platform_init),
1075 Call modest_platform_set_update_interval(), using a hard-coded
1076 interval for now (until the global settings dialog is implemented),
1077 though I am not sure that this makes sense yet.
1079 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1081 * src/dbus_api/modest-dbus-callbacks.c:
1082 (modest_osso_cb_hw_state_handler):
1083 * src/dbus_api/modest-dbus-callbacks.h:
1084 * src/maemo/modest-platform.c: (modest_platform_init):
1085 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1086 in case this has some effect on the ability for Maemo to ping the
1089 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1091 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1092 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1093 warning. It is probably a logic error, but I need to fix the build.
1095 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1097 * src/modest-account-mgr.h:
1098 * src/modest-account-mgr.c:
1099 (modest_account_mgr_account_names): Add a gboolean enabled_only
1100 parameter, so we can get lists of onlt the enabled accounts.
1102 (modest_account_mgr_add_account),,
1103 (modest_account_mgr_account_with_display_name_exists):
1104 * src/maemo/modest-msg-edit-window.c: (get_transports):
1105 * src/modest-account-mgr-helpers.c:
1106 (modest_account_mgr_set_first_account_as_default):
1107 * src/modest-init.c: (init_default_account_maybe):
1108 * src/modest-tny-account-store.c: (get_accounts):
1109 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1110 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1111 * tests/check_account-mgr.c: (START_TEST):
1112 Provide the extra parameter, as appropriate.
1114 * src/widgets/modest-account-view.c: (update_account_view):
1115 Do not show disabled accounts (meaning that there is no way to
1116 enable/disable accounts in the UI (the feature is not in our UI
1117 specification), so we can use this internally only to mark unfinished
1118 or temporary account data.
1120 * src/maemo/easysetup/modest-easysetup-wizard.c:
1121 (create_account): Add boolean enable parameter, so we can specify FALSE
1122 to create the temporary account.
1123 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1124 (on_before_next): When finishing, when there is a temporary account, just
1126 Also, use a timeout to delay the showing of the dialog until gconf is likely
1127 to return correct information, due to a maemo gconf bug that is fixed in
1128 osso 1.1, but not yet in Bora.
1129 However, the dialog stays on screen after it is destroyed.
1131 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1132 for invalid data when cancelling. Use a hildon note instead of a dialog
1133 to complain about invalid data. Do not show the account-saved note if the
1134 account is disabled (a temporary account that will not really be saved for use
1137 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1139 * src/modest-account-mgr-helpers.h:
1140 * src/modest-account-mgr-helpers.c:
1141 Added modest_account_mgr_unset_default_account(),
1142 Added modest_account_mgr_set_first_account_as_default().
1144 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1145 If it was the default account, unset the default account name.
1147 * src/maemo/modest-account-view-window.c:
1148 (on_delete_button_clicked): If it was the default account,
1149 set the first remaining account as the default instead.
1151 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1152 a NULL account or a NULL default account, to prevent a crash. This should
1153 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1156 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1158 * src/widgets/modest-recpt-editor.c:
1159 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1160 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1161 TODO comment for this. This fixes the build.
1163 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1164 be the best place for it. This will in future update all auto-update accounts,
1165 rather than just the current/default account, when that gconf key exists.
1166 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1167 if there are no accounts, before calling do_send_receive().
1168 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1170 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1171 * src/maemo/modest-main-window-ui.h:
1172 * src/maemo/modest-main-window.c: (on_connection_changed),
1173 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1174 directly, becaue the signal handler does more.
1176 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1178 * src/modest-account-mgr-helpers.c:
1179 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1180 for the case that the account does not exist.
1182 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1183 (equivalent to the modest account name) rather than the tinymail account name
1184 (equivalent to the modest account title - human readable) to get the account data.
1185 Check for null account data to prevent the crash, and add a TODO comment saying that
1186 this needs fixing because it is using the server account name instead of the account name.
1188 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1190 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1191 * src/maemo/modest-account-settings-dialog.c: (show_error),
1193 Use hildon_note_new_information() for informative and error messages,
1194 which seems to be expected for Maemo applications (no documentation that I know of
1195 says this). I am surprised that there is no distinction between info and error
1198 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1200 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1201 it is easy to find where this is used.
1203 * src/maemo/easysetup/modest-easysetup-wizard.c:
1204 (create_page_welcome), (create_page_account_details),
1205 (create_page_user_details), (create_page_complete_easysetup),
1206 (create_page_custom_incoming), (create_page_custom_outgoing),
1207 (create_page_complete_custom):
1208 * src/maemo/modest-account-settings-dialog.c:
1209 (create_page_account_details), (create_page_user_details),
1210 (create_page_incoming), (create_page_outgoing):
1211 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1212 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1213 (modest_connection_specific_smtp_edit_window_init):
1214 * src/maemo/modest-connection-specific-smtp-window.c:
1215 (modest_connection_specific_smtp_window_init):
1216 * src/maemo/modest-signature-editor-dialog.c:
1217 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1218 and scrolling policy as per the Email Application Layout Guide, if I have
1221 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1223 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1224 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1225 which were empty, because these vfuncs have been removed from TnyAccountStore.
1226 This fixes the build.
1228 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1230 * src/maemo/modest-main-window.c:
1231 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1232 showing/hiding it. Added TODO because it probably should not be NULL.
1233 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1234 because unnecessary g_warnings() make degugging difficult.
1236 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1238 * src/maemo/modest-msg-edit-window.c:
1239 (modest_msg_edit_window_select_color),
1240 (modest_msg_edit_window_select_background_color): 2 const corrections and
1241 moving 2 #endifs before closing brackets, to fix the build.
1243 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1245 * src/maemo/easysetup/modest-easysetup-wizard.h:
1246 * src/maemo/easysetup/modest-easysetup-wizard.c:
1247 (modest_easysetup_wizard_dialog_finalize),
1248 (on_button_edit_advanced_settings), (create_page_complete_custom),
1249 (on_response), (create_account):
1250 Implement the Advanced Settings edit button, by saving the account information,
1251 for the Advanded Settings dialog to use directly from gconf, and removing it
1252 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1253 Bug #5533 in the projects.maemo.org bugzilla.
1255 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1257 * src/maemo/modest-msg-view-window.c:
1258 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1259 when opening a message window.
1261 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1263 * src/maemo/easysetup/modest-easysetup-wizard.c:
1264 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1267 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1268 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1269 gconf settings. I probably added more checks than necessary, but that is safer.
1271 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1272 variable to fix the build, but this seems to be used when it is still NULL.
1274 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1276 * src/modest-platform.h:
1277 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1278 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1279 * src/modest-main.c: Implement this function so we can avoid using
1280 maemo-specific API from cross-platform code.
1282 * src/modest-tny-account-store.c:
1283 (get_smtp_specific_transport_account_for_open_connection):
1284 * src/modest-ui-actions.c: (check_for_connection),
1285 (modest_ui_actions_on_item_not_found):
1286 Use modest_platform_connect_and_wait() and put #idefs around other
1287 maemo-specific code, because only maemo currently has a way to
1288 identify connection names.
1290 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1292 * src/modest-tny-account-store.h:
1293 * src/modest-tny-account-store.c:
1294 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1295 the connection-specific SMTP server settings in the configuration.
1297 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1299 * src/maemo/modest-main-window.c: (on_connection_changed),
1301 * src/modest-main.c: (main), (start_ui), (send_mail):
1302 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1303 that is what is intended.
1305 * src/modest-ui-actions.c: (action_send), (action_receive),
1306 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1307 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1308 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1309 SMTP server is used when it is specified.
1311 (modest_ui_actions_on_send_receive):
1312 Check that a connection is open before proceeding.
1313 Receive and then send, instead of vice-versa, as per the specification.
1315 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1317 * src/modest-mail-operation.c:
1318 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1319 though I guess it should be something other than NULL.
1321 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1323 * src/maemo/easysetup/modest-easysetup-wizard.c:
1324 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1325 combo twice, to avoid an g_warning and to make it visible again.
1326 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1327 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1328 (already intended) dereference when detaching, because we then recreate the menu.
1329 But I am not sure why the warning was happening, and it is possible that this is a memory
1332 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1334 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1335 and uri_parse_mailto() utility functions.
1336 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1338 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1340 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1342 * src/dbus_api/modest-dbus-api.h:
1343 * src/dbus_api/modest-dbus-callbacks.c:
1344 Use an idle callback to execute the modest code in the application's own thread.
1345 Remove the helloworld example method.
1346 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1347 parsed, and the open-message method is not implemented because this is not yet implemented in
1349 * libmodest-dbus-client/libmodest-dbus-client.c:
1350 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1351 (libmodest_dbus_client_open_message):
1352 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1354 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1355 body without crashing.
1357 * tests/dbus_api/Makefile.am:
1358 * tests/dbus_api/test_mail_to.c:
1359 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1361 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1363 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1364 Added file to fix the build. Sorry.
1366 * src/dbus_api/Makefile.am:
1367 * src/dbus_api/modest-dbus-api.h:
1368 * src/dbus_api/modest-dbus-callbacks.h:
1369 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1370 (modest_dbus_req_handler):
1371 Put constants in a separate header so it can be reused by the
1372 client library, without duplication
1374 * libmodest-dbus-client/Makefile.am:
1375 * libmodest-dbus-client/libmodest-dbus-client.c:
1376 (libmodest_dbus_client_call_helloworld),
1377 (libmodfest_dbus_client_send_mail),
1378 (libmodfest_dbus_client_mailto),
1379 (libmodfest_dbus_client_open_message):
1380 * libmodest-dbus-client/libmodest-dbus-client.h:
1381 (Partly) Implement a send_mail D-Bus method.
1383 * tests/dbus_api/Makefile.am:
1384 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1385 the send_email D-Bus method.
1387 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1391 * libmodest-dbus-client/Makefile.am:
1392 * libmodest-dbus-client/libmodest-dbus-client.c:
1393 * libmodest-dbus-client/libmodest-dbus-client.h:
1394 * tests/dbus_api/Makefile.am:
1395 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1396 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1398 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1400 * src/maemo/easysetup/modest-easysetup-wizard.c:
1401 (create_page_account_details):
1402 * src/maemo/modest-account-settings-dialog.c:
1403 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1404 widgets, because this might not be the default in future versions of the Maemo GTK+.
1405 However, I can not not get capitalization to work even in a simple test case.
1407 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1409 * src/maemo/easysetup/modest-easysetup-wizard.c:
1410 (create_page_custom_incoming), (create_page_custom_outgoing):
1411 * src/maemo/modest-account-settings-dialog.c:
1412 (create_page_account_details), (create_page_incoming),
1413 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1414 instead of using gtk_check_button_with_label(), so they are aligned like the other
1415 widgets, as per the UI spec.
1417 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1419 * src/maemo/easysetup/modest-easysetup-wizard.c:
1420 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1421 * src/widgets/modest-validating-entry.c:
1422 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1423 Modest prefix instead of an EasySetup prefix.
1425 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1427 * src/widgets/modest-validating-entry.h:
1428 * src/widgets/modest-validating-entry.c: (on_insert_text),
1429 Added easysetup_validating_entry_set_max_func(), used to set a callback
1430 to call when the max number of characters is reached. GtkEntry has a max-length
1431 already but is silent about it.
1433 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1434 (create_page_account_details), (create_page_user_details),
1436 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1437 (create_page_account_details), (create_page_user_details),
1438 (create_page_outgoing):
1439 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1440 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1441 the UI spec, when the user tries to enter more than the max number of characters.
1443 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1445 * src/maemo/easysetup/modest-easysetup-wizard.c:
1446 (create_page_user_details), (create_page_custom_incoming),
1447 (create_page_custom_outgoing):
1448 * src/maemo/modest-account-settings-dialog.c:
1449 (create_page_user_details), (create_page_incoming),
1450 (create_page_outgoing):
1451 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1452 (modest_connection_specific_smtp_edit_window_init):
1453 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1454 not appropriate. Bad Maemo-specific defaults!.
1456 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1458 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1459 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1460 (modest_signature_editor_dialog_set_settings):
1461 Disable the label and textview when the checkbox is disabled, and use the
1462 specified (UI spec) default signature text.
1464 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1466 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1467 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1469 * src/modest-defs.h:
1470 * src/modest-account-mgr-helpers.h:
1471 * src/modest-account-mgr-helpers.c:
1472 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1474 * src/maemo/Makefile.am:
1475 * src/maemo/modest-signature-editor-dialog.c:
1476 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1479 * src/maemo/modest-account-settings-dialog.h:
1480 * src/maemo/modest-account-settings-dialog.c:
1481 (modest_account_settings_dialog_finalize), (on_button_signature),
1482 (save_configuration): Use the new dialog when the Edit button is pressed, and
1483 save the changes if necessary, as per the UI spec.
1485 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1487 * src/maemo/Makefile.am:
1488 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1489 based on maemo-develoers email from Dirk.
1491 * src/maemo/easysetup/modest-easysetup-wizard.c:
1492 (create_page_welcome), (create_page_account_details),
1493 (create_page_user_details), (create_page_complete_easysetup),
1494 (create_page_custom_incoming), (create_page_custom_outgoing),
1495 (create_page_complete_custom),
1496 (modest_easysetup_wizard_dialog_init):
1497 * src/maemo/modest-account-settings-dialog.c:
1498 (create_page_account_details), (create_page_user_details),
1499 (create_page_incoming), (create_page_outgoing),
1500 (modest_account_settings_dialog_init):
1501 * src/maemo/modest-connection-specific-smtp-window.c:
1502 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1504 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1506 * src/maemo/easysetup/modest-easysetup-wizard.c:
1507 (create_page_account_details), (create_page_custom_outgoing),
1508 (create_page_complete_custom):
1509 * src/maemo/modest-account-settings-dialog.c:
1510 (create_page_user_details), (create_page_incoming),
1511 (create_page_outgoing):
1512 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1513 (modest_connection_specific_smtp_edit_window_init):
1514 Use the correct (UI spec) port min/max, and use horizontal separators,
1517 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1519 * src/maemo/easysetup/modest-easysetup-wizard.c:
1520 (set_default_custom_servernames):
1521 * src/maemo/modest-account-settings-dialog.c:
1522 (create_page_incoming), (on_combo_outgoing_security_changed),
1523 (on_combo_incoming_security_changed), (create_page_outgoing),
1524 (modest_account_settings_dialog_set_account_name),
1525 (save_configuration):
1526 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1527 (on_combo_security_changed),
1528 (modest_connection_specific_smtp_edit_window_init),
1529 (modest_connection_specific_smtp_edit_window_set_connection),
1530 (modest_connection_specific_smtp_edit_window_get_settings):
1531 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1534 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1537 * src/maemo/easysetup/modest-easysetup-wizard.c:
1538 (create_page_custom_outgoing), (create_page_complete_custom):
1539 * src/maemo/modest-account-settings-dialog.c:
1540 (create_page_user_details), (create_page_outgoing):
1541 * src/maemo/modest-account-view-window.c: (button_box_new):
1542 Use changed logical IDs as per the most recent UI spec:
1543 mcen_bd_emailsetup_edit -> mcen_bd_edit
1544 mcen_bd_emailsetup_delete -> mcen_bd_delete
1545 mcen_bd_emailsetup_close -> mcen_bd_close
1547 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1551 * src/dbus_api/Makefile.am:
1552 * src/dbus_api/modest-dbus-callbacks.c:
1553 * src/dbus_api/modest-dbus-callbacks.h:
1554 * src/maemo/modest-platform.c: (modest_platform_init):
1555 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1557 * tests/Makefile.am:
1558 * tests/dbus_api/Makefile.am:
1559 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1561 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1563 * src/maemo/modest-account-settings-dialog.c:
1564 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1565 Removed unnecessary includes.
1567 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1569 * src/maemo/easysetup/modest-easysetup-wizard.c:
1570 * src/maemo/modest-account-settings-dialog.c:
1571 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1572 * src/widgets/Makefile.am:
1573 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1574 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1575 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1576 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1577 * src/widgets/modest-secureauth-combo-box.c:
1578 * src/widgets/modest-secureauth-combo-box.h:
1579 * src/widgets/modest-serversecurity-combo-box.c:
1580 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1581 made the GObject names more consistent with the rest of the Modest code.
1583 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1585 * src/maemo/easysetup/Makefile.am:
1586 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1587 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1588 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1589 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1590 * src/maemo/easysetup/modest-easysetup-wizard.c:
1591 * src/maemo/easysetup/modest-validating-entry.c:
1592 * src/maemo/easysetup/modest-validating-entry.h:
1593 * src/maemo/modest-account-settings-dialog.c:
1594 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1595 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1596 widgets/ because they are used outside of easysetup too. After checking in,
1597 svn will allow me to rename them too.
1599 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1601 * src/gnome/modest-msg-edit-window.c:
1602 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1603 linker error, to fix the build on the GNOME platform.
1604 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1605 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1606 ifdefed out to avoid a warning.
1608 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1610 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1611 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1612 some alternative for GTK+ 2.6.
1614 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1616 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1618 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1619 specified for EmailAccountsDialog in UI spec.
1621 * src/maemo/easysetup/modest-easysetup-wizard.c:
1622 * src/maemo/easysetup/modest-easysetup-wizard.h:
1623 * src/maemo/modest-account-settings-dialog.c:
1624 * src/maemo/modest-account-settings-dialog.h:
1625 Reuse a member window widget for the connection-specific SMTP server accounts,
1626 so we can tell it to create/save the accounts only if we actually save changes.
1628 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1629 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1630 (modest_connection_specific_smtp_edit_window_get_settings):
1631 Return a struct instance for temporarily remembering the entered data.
1633 * src/maemo/modest-connection-specific-smtp-window.h:
1634 * src/maemo/modest-connection-specific-smtp-window.c:
1635 (modest_connection_specific_smtp_window_finalize),
1636 (modest_connection_specific_smtp_window_fill_with_connections),
1638 (modest_connection_specific_smtp_window_save_server_accounts),
1639 (update_model_server_names): Do not actually save data until asked,
1640 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1642 (on_selection_changed),
1643 (modest_connection_specific_smtp_window_init): Disable the edit
1644 button when nothing is selected.
1646 * src/modest-account-mgr-helpers.c:
1647 * src/modest-account-mgr-helpers.h:
1648 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1651 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1653 * src/modest-account-mgr-helpers.h:
1654 * src/modest-account-mgr-helpers.c:
1655 (modest_account_mgr_get_unused_account_name),
1656 (modest_account_mgr_get_unused_account_display_name): Added these
1657 utility functions, to avoid code duplication.
1659 * src/maemo/easysetup/modest-easysetup-wizard.c:
1660 (create_page_account_details), (create_account):
1661 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1662 (on_combo_security_changed),
1663 (modest_connection_specific_smtp_edit_window_init),
1664 (modest_connection_specific_smtp_edit_window_save_settings):
1665 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1666 * src/maemo/modest-connection-specific-smtp-window.c:
1667 (modest_connection_specific_smtp_window_finalize),
1668 (modest_connection_specific_smtp_window_fill_with_connections),
1669 (on_button_edit), (modest_connection_specific_smtp_window_init):
1670 * src/maemo/modest-connection-specific-smtp-window.h:
1671 Implementing saving of connection-specific server accounts.
1673 But I need to refactor this so we can save the data for each
1674 possible connection-specific account and only actually create the server accounts
1675 when the easysetup finished, or the OK button is pressed on the account settings
1678 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1680 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1681 (on_combo_security_changed):
1682 (modest_connection_specific_smtp_edit_window_init):
1683 Auto-fill the port number as in the account settings.
1685 (modest_connection_specific_smtp_edit_window_set_connection):
1686 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1687 * src/maemo/modest-connection-specific-smtp-window.c:
1688 (fill_with_connections), (on_button_edit),
1689 (modest_connection_specific_smtp_window_init):
1690 Turn the edit window into a dialog to simplify the code, and
1691 set a WM hint as in a GtkDialog, because only a popup can be on top of
1692 another window in Maemo, and popups usually have no WM decoration.
1694 * src/modest-defs.h:
1695 * src/modest-account-mgr-helpers.c:
1696 (modest_account_mgr_set_connection_specific_smtp),
1697 (modest_account_mgr_remove_connection_specific_smtp),
1698 (modest_account_mgr_get_connection_specific_smtp):
1699 * src/modest-account-mgr-helpers.h: Some functions to write the
1700 connection-specific SMTP server information. Not yet used.
1703 * src/widgets/modest-folder-view.c: (text_cell_data):
1704 Fix a warning about an uninitialized variable.
1705 (on_configuration_key_changed): Put an #ifdef around the use
1706 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1708 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1710 * src/maemo/modest-account-settings-dialog.h:
1711 * src/maemo/modest-account-settings-dialog.c:
1712 Added connect_for_modified() utility function to mark the new modified boolean.
1714 (create_page_account_details), (create_page_user_details),
1715 (create_page_incoming), (create_page_outgoing), (on_response),
1716 (modest_account_settings_dialog_init),
1717 (modest_account_settings_dialog_set_account_name):
1718 Only warn about unsaved changes when there are actually unsaved changes.
1720 * src/modest-account-mgr-helpers.c:
1721 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1722 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1723 to get the data from there in future.
1725 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1727 * src/modest-defs.h:
1729 * src/modest-account-mgr-helpers.h:
1730 * src/modest-account-mgr-helpers.c:
1731 Store the security account setting in a single conf key instead of using
1732 the options list, so that the list is left for just the to-be-removed camel hack,
1733 and because gconf_client_set_list() is failing for some reason.
1735 * src/modest-account-mgr.c:
1736 (modest_account_mgr_add_server_account):
1737 * src/maemo/modest-account-settings-dialog.c:
1738 (modest_account_settings_dialog_set_account_name),
1739 (save_configuration): Use the renamed functions.
1742 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1744 * src/widgets/Makefile.am:
1745 * src/widgets/modest-limit-retrieve-combo-box.c:
1746 * src/widgets/modest-limit-retrieve-combo-box.h:
1747 * src/widgets/modest-retrieve-combo-box.c:
1748 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1749 the account settings dialog.
1751 * src/modest-defs.h:
1752 * src/modest-account-mgr-helpers.h:
1753 * src/modest-account-mgr-helpers.c:
1754 (modest_server_account_get_option_secure_auth),
1755 (modest_server_account_set_option_secure_auth):
1756 * src/modest-account-mgr.c:
1757 (modest_account_mgr_add_server_account):
1758 Use the existing AUTH_MECH conf key for the secure-auth setting,
1759 instead of putting it in the list options, because this was actually used already.
1761 * src/maemo/modest-account-settings-dialog.c:
1762 (create_page_account_details),
1763 (modest_account_settings_dialog_set_account_name),
1764 (save_configuration):
1765 * src/maemo/modest-account-settings-dialog.h:
1766 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1767 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1769 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1771 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1772 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1773 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1775 * src/modest-defs.h:
1776 * src/maemo/modest-account-settings-dialog.c:
1777 (create_page_incoming), (on_combo_outgoing_security_changed),
1778 (on_combo_incoming_security_changed), (create_page_outgoing),
1779 (modest_account_settings_dialog_set_account_name),
1780 (save_configuration): Load/Save the port number, and change it when the
1781 security combo changes, to suitable defaults.
1783 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1785 * src/modest-account-mgr.c:
1786 (modest_account_mgr_add_server_account): Set the security and secure-auth
1787 options, and add a comment saying that the other camel-specific options should be
1790 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1792 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1794 * src/modest-tny-account-store.c: (account_list_free),
1795 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1796 cursor->data after unreffing it. But there is some strange stuff there so it might not be
1799 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1801 * src/modest-protocol-info.c:
1802 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1803 is required by our UI spec. Maybe something in our implementation will use this eventually.
1804 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1805 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1806 instead of the previous 0 placeholder.
1808 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1809 secure-auth settings.
1810 * src/modest-account-mgr-helpers.h:
1811 * src/modest-account-mgr-helpers.c:
1812 (modest_server_account_data_get_option_secure_auth),
1813 (modest_server_account_set_option_secure_auth),
1814 (modest_server_account_data_get_option_security),
1815 (modest_server_account_set_option_security): Added this API for getting and setting the security
1816 and secure-auth settings.
1818 * src/maemo/modest-account-settings-dialog.h:
1819 * src/maemo/modest-account-settings-dialog.c:
1820 (modest_account_settings_dialog_finalize), (check_data),
1821 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1822 about changing titles.
1823 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1824 (save_configuration): Save the security and secure-auth settings.
1826 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1827 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1829 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1831 * src/modest-defs.h:
1832 * src/modest-account-mgr.c:
1833 (modest_account_mgr_add_server_account):
1834 Added and used defines for the options key and value pair strings,
1835 that are used so far, though they do not seem to correspond to anything in our
1836 UI specs or ModestProtocol enum.
1838 * src/modest-account-mgr-helpers.h:
1839 * src/modest-account-mgr-helpers.c:
1840 (compare_option_strings_for_name),
1841 (modest_server_account_data_get_option_value),
1842 (modest_server_account_data_get_option_bool),
1843 (modest_account_mgr_get_server_account_option):
1844 Added helper functions for parsing the options GSList.
1846 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1848 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1849 display name is based on the supplied account name.
1850 * src/modest-account-mgr.c:
1851 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1852 with an inefficient, but good-enough, implementation.
1854 * src/maemo/easysetup/modest-easysetup-wizard.c:
1855 (create_page_account_details), (on_before_next), (create_account):
1856 Check for existing display names rather than (non-user-visible) account names, and just
1857 create and set a unique account name at the end.
1859 * src/maemo/modest-account-settings-dialog.c:
1860 (modest_account_settings_dialog_init),
1861 (modest_account_settings_dialog_set_account_name),
1862 (create_page_incoming): Show the display name, instead of the account name.
1863 (on_response): Do some (not all) extra checks, as in the UI spec.
1864 (save_configuration): Save the display name if it was changed.
1866 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1868 * po/en_GB.po: Added needed logical ID and translation.
1869 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1870 (init_view): Made the is-default column clicking work.
1872 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1875 * src/maemo/easysetup/Makefile.am:
1876 * src/maemo/easysetup/modest-easysetup-wizard.c:
1877 (modest_easysetup_wizard_dialog_init):
1878 * src/maemo/easysetup/provider-data-test.keyfile:
1879 * src/maemo/easysetup/provider-data.keyfile:
1880 Moved the provider data file to the new modest-providers-data package and used it from there.
1882 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1884 * src/modest-local-folder-info.c:
1885 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1886 N_() was already used on the static strings, but this just marks it for translation without
1887 using the translation.
1889 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1891 * src/maemo/modest-account-settings-dialog.c:
1892 (create_page_incoming),
1893 (modest_account_settings_dialog_set_account_name):
1894 Added comments about the need for new API in ModestAccountMgr to handle the authentication
1895 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1896 I will do this if nobody else gets there first.
1898 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1900 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1901 Saved much of the incoming and outgoing data too, though I cannot yet see how to
1902 save the security stuff.
1904 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1906 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1907 Set the email address and user fullname, which I now see must be
1910 * src/maemo/modest-account-settings-dialog.h:
1911 * src/maemo/modest-account-settings-dialog.c:
1913 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1914 leave-on-server and authentication.
1915 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1918 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1921 * src/maemo/modest-account-settings-dialog.c:
1922 * src/maemo/modest-account-settings-dialog.h:
1923 Most (but not all) of the widgets are now present as specified by the UI spec.
1924 No changes are yet saved, and some details are not properly shown yet.
1926 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1928 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1930 * src/maemo/Makefile.am:
1931 * src/maemo/modest-account-settings-dialog.c:
1932 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1933 an existing account. Doesn't do much yet.
1935 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1936 Open the accounts settings dialog when Edit is clicked.
1938 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1940 * src/maemo/easysetup/Makefile.am:
1941 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1943 * src/maemo/easysetup/modest-easysetup-wizard.c:
1944 (modest_easysetup_wizard_dialog_init):
1945 Try to get the source directory from the build system,
1946 instead of hard-coding "./" into the source code, when opening our local
1947 copies of the configuration files.
1948 But this still fails when opening the wizard from the Accounts window,
1949 maybe because the working directory seems to change at runtime.
1950 So the wizard will fail the second time unless you copy the files into their
1951 proper locations - see the stdout warnings for the paths.
1953 (create_page_account_details),(on_before_next):
1954 Check for existing non-server accounts instead of server accounts,
1955 so the default account name is useful again, and to prevent trying to
1958 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1959 Show the wizard when New is clicked.
1961 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1962 (init_view): Show the column headers, and show the columns that are
1963 specified in the UI specs. However, something in Maemo's GTK+ prevents
1964 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1965 change the default account. This is despite unsetting the special properties.
1967 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1969 * docs/reference/modest-design.sgml: Corrected spelling mistake.
1970 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1971 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1972 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1973 to make that clearer.
1974 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1976 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1978 * src/maemo/modest-account-view-window.c:
1979 (modest_account_view_window_init),
1980 (modest_account_view_window_new):
1981 Use the same buttons as specified in the
1982 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1983 the existing widgets, which never had a chance of working.
1984 Put the ModestAccountView treeview in a scrolled window.
1985 Do not repeat the initialization in both _init() and _new().
1987 * src/widgets/modest-account-view.c: (update_account_view):
1988 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1989 this widget and window shows no accounts.
1991 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1993 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1995 * src/maemo/easysetup/modest-easysetup-wizard.c:
1996 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1997 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1998 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2001 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2002 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2003 accounts exist yet, as in the UI spec.
2005 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2007 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2009 * src/maemo/Makefile.am:
2010 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2011 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2012 New window for editing connection-specific smtp details.
2013 Not fully implemented.
2015 * src/maemo/modest-connection-specific-smtp-window.c:
2016 (modest_connection_specific_smtp_window_finalize) :
2017 unref the tree model.
2018 (on_button_edit): Show the edit window.
2020 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2022 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2025 * src/maemo/Makefile.am:
2026 * src/maemo/modest-connection-specific-smtp-window.c:
2027 * src/maemo/modest-connection-specific-smtp-window.h:
2028 New window for showing the list of connections, for connection-specific
2029 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2030 * src/maemo/easysetup/modest-easysetup-wizard.c:
2031 (create_page_custom_outgoing): Show the new window when the button is clicked.
2033 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2035 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2036 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2037 * src/maemo/modest-msg-edit-window.c:
2038 (modest_msg_edit_window_insert_image):
2039 * src/modest-conf.c: (modest_conf_key_escape):
2040 * src/modest-mail-operation.c:
2041 (modest_mail_operation_send_new_mail):
2042 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2043 (modest_ui_actions_on_new_account):
2044 * src/widgets/modest-attachment-view.c: (update_filename_request):
2045 * src/widgets/modest-mail-header-view.c:
2046 Corrected warnings that were breaking the build, by commenting out unused variables,
2047 and a function, and by including a header.
2049 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2051 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2052 so we can #ifdef around platform-specific code when necessary.
2053 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2054 to allow this to build for the GNOME platform too.
2056 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2058 * src/maemo/easysetup/modest-easysetup-wizard.c:
2059 Added util_increment_name() and used it in create_page_account_details()
2060 to make sure that the default account name is always a new name.
2062 (modest_easysetup_wizard_dialog_init),
2063 (set_default_custom_servernames): Some minor memory management fixes.
2065 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2069 * src/modest-runtime.c: (init_i18n): Restored the translation
2070 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2071 are defined in config.h, and the translations are installed.
2073 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2074 is defined for translation.
2076 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2078 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2080 * src/maemo/easysetup/modest-easysetup-wizard.c:
2081 (modest_easysetup_wizard_dialog_init):
2082 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2083 Use realistic paths (though they should use $prefix generically) to the
2084 mcc_mapping and provider-data.keyfile files which might work when they
2085 are installed by the future version of the operator-wizard package,
2086 and then fallback to paths in our source code, with an explanatory
2089 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2093 * src/maemo/Makefile.am:
2094 * src/maemo/easysetup/: Added files from the previously-exernal
2095 osso-modest-easysetup.
2096 * src/maemo/modest-main-window-ui.h:
2097 * src/modest-ui-actions.c:
2098 * src/modest-ui-actions.h:
2099 Added modest_ui_actions_on_new_account() as a signal handler for the
2100 New Account menu item. It shows the easysetup wizard.
2101 * po/en_GB.po: Added additional needed logical IDs and translations.
2103 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2104 Apparently ChangeLog is not used for some vague Nokia legal reasons.