1 2007-06-02 Armin Burgmeier <armin@openismus.com>
3 * src/maemo/modest-account-settings-dialog.c: Changed window title to
4 include account type and account title. This fixes projects.maemo.org
7 * src/maemo/modest-account-view-window.c: Set a title for the window.
9 2007-06-02 Armin Burgmeier <armin@openismus.com>
11 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
12 incoming and outgoing server name based on email address and server
13 types as long as the names have not been edited manually. This fixes
14 projects.maemo.org bug NB#58671.
16 2007-06-02 Armin Burgmeier <armin@openismus.com>
18 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
19 server type cannot be changed in future to the incoming details page
20 when creating an account. This fixes projects.maemo.org bug NB#59029.
22 2007-06-02 Armin Burgmeier <armin@openismus.com>
24 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
25 and assigned max width chars so that they wrap instead of being
26 truncated. Fixes projects.maemo.org bug NB#56126.
28 2007-06-02 Armin Burgmeier <armin@openismus.com>
30 * src/maemo/modest-connection-specific-smtp-window.c: Add an
31 introductory note to the connection specific smtp servers dialog, as
32 section 8.12 of the email UI specification requires. This fixes
33 projects.maemo.org bug NB#59212.
35 2007-06-01 Murray Cumming <murrayc@murrayc.com>
37 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
38 Check for running mail operations, and offer to cancel them, as per the UI
39 spec. This fixes projects.maemo.org bug NB#59041 .
40 However, I suspect that tinymail may still use the network connection
41 in ways that we cannot detect or cancel. But it should at least adapt to
44 2007-06-01 Murray Cumming <murrayc@murrayc.com>
46 * src/modest-tny-account-store.c: (recreate_all_accounts),
47 (get_cached_accounts), (get_server_accounts): Do more sensible
48 ref-counting of the temporarily-cached outbox accounts list. This seems
49 to fix a crash when entering the password when the password was wrong.
51 2007-06-01 Murray Cumming <murrayc@murrayc.com>
53 * src/gnome/modest-main-window.c: (connect_signals):
54 * src/modest-tny-account-store.c: (get_password),
55 (modest_tny_account_store_alert): Added comments and clues and
56 commented-out code about how we currently fail to deal with connection
57 errors and wrong passwords, and how we should.
59 2007-06-01 Murray Cumming <murrayc@murrayc.com>
61 * src/widgets/modest-retrieve-combo-box.c:
62 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
63 This fixes projects.maemo.org bug NB#58472 .
65 2007-06-01 Murray Cumming <murrayc@murrayc.com>
67 * src/maemo/easysetup/modest-easysetup-wizard.c:
68 (create_page_complete_easysetup):
69 (create_page_complete_custom): Correct the last commit,
70 putting the correct sentences in the correct pages.
72 2007-06-01 Murray Cumming <murrayc@murrayc.com>
74 * src/maemo/easysetup/modest-easysetup-wizard.c:
75 (create_page_complete_custom): Show the second sentence of text
76 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
79 2007-06-01 Murray Cumming <murrayc@murrayc.com>
81 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
82 Set the leave-on-server conf key by default. This fixes
83 projects.maemo.org bug NB#59258 .
85 2007-06-01 Murray Cumming <murrayc@murrayc.com>
87 * src/maemo/modest-account-view-window.c:
88 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
89 logical ID for the confirmation messages. Fixed projects.maemo.org bug
92 2007-06-01 Murray Cumming <murrayc@murrayc.com>
94 * src/maemo/easysetup/modest-easysetup-wizard.c:
95 (create_caption_new_with_asterisk):
96 * src/maemo/modest-account-settings-dialog.c:
97 (create_caption_new_with_asterisk):
98 Uncomment the code to add the asterisk, because they are no longer in the
99 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
100 (update_incoming_server_title): Add an asterisk here too.
102 2007-06-01 Murray Cumming <murrayc@murrayc.com>
104 * src/maemo/modest-maemo-global-settings-dialog.c:
105 (current_connection): Check that we are even connected before trying to
106 get the current connection name, to prevent a warning.
108 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
109 Change the comments because tny_maemo_conic_device_connect() is now meant to
111 * src/modest-mail-operation.c:
112 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
113 make sure we have a connection and fail if we can't connect.
115 2007-05-31 Murray Cumming <murrayc@murrayc.com>
117 * src/maemo/modest-main-window.c:
118 (on_account_store_connecting_finished): Do not try to get the
119 connection ID if we are not really connected. I am surprised that
120 this signal handler is called when we are not connected.
122 2007-05-31 Murray Cumming <murrayc@murrayc.com>
124 * src/modest-error.h:
125 * src/modest-ui-actions.c:
126 (modest_ui_actions_get_msgs_full_error_handler):
127 Renamed an enum, added comments, added an enum
128 for retrieve-limit errors.
130 * src/modest-mail-operation.c: (foreach_add_item),
131 (internal_folder_observer_update), (update_account_thread),
132 (modest_mail_operation_get_msgs_full):
133 (modest_mail_operation_update_account),
134 Added comments about how this works, and some code that should
135 (but does not) check the retrieve-limit. See the TODO comment.
137 2007-05-31 Murray Cumming <murrayc@murrayc.com>
139 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
140 Initialize help_id to fix the build. Warnings are good.
142 2007-05-31 Murray Cumming <murrayc@murrayc.com>
144 * src/widgets/modest-hbox-cell-renderer.c:
145 (modest_hbox_cell_renderer_append):
146 * src/widgets/modest-vbox-cell-renderer.c:
147 (modest_vbox_cell_renderer_append):
148 Fix the last commit by doing an extra ref.
150 2007-05-31 Murray Cumming <murrayc@murrayc.com>
152 * src/widgets/modest-hbox-cell-renderer.c:
153 (modest_hbox_cell_renderer_append):
154 * src/widgets/modest-vbox-cell-renderer.c:
155 (modest_vbox_cell_renderer_append):
156 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
157 to fix the build with Maemo Bora.
158 However, there seems to be a remaining crash, probably due to reference
161 2007-05-30 Murray Cumming <murrayc@murrayc.com>
163 * src/modest-tny-account.c:
164 (modest_tny_account_new_for_local_folders):
165 Use hildon_file_system_info_async_new() to get a better name for
166 the memory card account, setting it as the account name.
167 The timing seems to work, but this is probably
168 not the best place to do this. See the TODO comment.
169 * src/maemo/modest-main-window.c: (create_details_widget):
170 * src/widgets/modest-folder-view.c: (text_cell_data):
171 Use the tny account name instead of hardcoding a name.
173 2007-05-30 Christian Kellner <ckellner@openismus.com>
175 * src/modest-search.c: (modest_search):
176 Correctly set part_search_func even if we have already parsed
177 the query and thus a valid OgsTextSearcher object.
179 2007-05-30 Christian Kellner <ckellner@openismus.com>
182 Search and check for libogs.
185 Incooparte the ogs build env.
187 * src/modest-mime-part-search-stream.c:
188 * src/modest-mime-part-search-stream.h:
189 Removed since we do the real searching now in modest-search.c.
191 * src/modest-search.c:
192 * src/modest-search.h:
193 Implement support for ogs. We use that if available and requested
194 and fall back to modest_text_utils_utf8_strcmp (). The search logic
195 should now handle the corner case when the search term is spread
196 across multiple reads.
197 Also the logic in modest_search () was corrected to search all
198 requested fields until one is found.
200 2007-05-30 Murray Cumming <murrayc@murrayc.com>
202 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
205 * src/modest-init.c: Made modest_init_local_folders() take a
206 path and be public so we can iniitialize maildir folders on
209 * src/modest-local-folder-info.h:
210 * src/modest-local-folder-info.c:
211 (modest_local_folder_info_get_maildir_path): Add a path parameter.
213 * src/modest-tny-account.c:
214 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
215 still means the standard local-folders path on the local volume.
217 * src/modest-tny-account-store.c:
218 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
219 signal so we can detect mount/unmount of the MMC1 card, and do an update of
220 all accounts when that happens.
221 (get_server_accounts): If the MMC1 card is mounted, create a store account for
222 this too, so it shows up in the treeview.
224 2007-05-28 Murray Cumming <murrayc@murrayc.com>
226 * src/maemo/modest-maemo-global-settings-dialog.c:
227 (current_connection):
228 * src/widgets/modest-global-settings-dialog.c:
229 (current_connection_default):
230 Use the enum values instead of 0, 1 and -1,
231 to make the code clearer.
233 * src/modest-account-mgr-helpers.c:
234 (modest_account_mgr_get_connection_specific_smtp): Make this code
237 * src/modest-runtime.h:
238 * src/modest-runtime.c:
239 Added modest_runtime_remove_all_send_queues().
240 * src/maemo/modest-main-window.c:
241 (on_account_store_connecting_finished): Recreate the send queues,
242 using the appropriate transport accounts for this new connection.
243 Some futher adapting might be needed if the old send queues are not
244 automatically stopped at this point.
246 * src/modest-tny-account-store.c: (get_server_accounts):
247 Create the connection-specific transport accounts, so that they can
248 be found later by their ID.
250 * src/modest-tny-account.h:
251 * src/modest-tny-account.c:
252 Added modest_tny_account_new_from_server_account_name().
253 modest_tny_account_new_from_server_account(): Do not create the
254 send queues here, because they will be
255 recreated anyway when the connection changes for the first time.
257 2007-05-28 Murray Cumming <murrayc@murrayc.com>
259 * src/modest-local-folder-info.h:
260 * src/modest-local-folder-info.c:
261 (modest_per_account_local_outbox_folder_info_get_maildir_path),
262 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
263 tbox_folder): Take a modest account name instead of a server TnyAccount,
264 so we can have per-modest-account rather than per-transport-account
266 We must make sure that we change or recreate the exisitng send queues
267 when the connection changes for connection-specific transport accounts.
269 * src/modest-tny-account-store.c:
270 (create_per_account_local_outbox_folders): Create outboxed per modest
271 account, not per transport account.
273 * src/modest-tny-account.h:
274 * src/modest-tny-account.c:
275 (modest_tny_account_get_special_folder): For outboxes, get the
276 parent modest account name. The account is ignored for other folders.
277 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
278 modest account name rather than a server TnyAccount.
280 2007-05-25 Murray Cumming <murrayc@murrayc.com>
282 * src/modest-tny-account.c:
283 (modest_tny_account_new_from_server_account):
284 Call modest_runtime_get_send_queue() immediately after creating transport
285 accounts, so that they start trying to send email from the outbox as soon
286 as possible at startup. This is probably what we want.
288 * src/modest-mail-operation.c: (update_account_thread):
289 * src/modest-runtime.c: (modest_runtime_get_send_queue):
290 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
291 * src/modest-tny-send-queue.h:
292 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
293 (modest_ui_actions_on_send):
294 Added comments about how sending works, though it needs some more work.
296 2007-05-25 Murray Cumming <murrayc@murrayc.com>
298 * src/modest-tny-account.c:
299 (modest_tny_account_get_special_folder): Add TODO because this fails when
301 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
302 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
303 Do not try to show this window when there is no active account. The UI
304 specs does not tell us what to do in this case.
306 2007-05-24 Murray Cumming <murrayc@murrayc.com>
310 * src/maemo/Makefile.am:
311 * src/widgets/Makefile.am: Some dist fixes.
313 2007-05-24 Murray Cumming <murrayc@murrayc.com>
315 * src/maemo/modest-connection-specific-smtp-window.c:
316 (on_button_edit): Make the code clearer, to prevent a double free.
318 2007-05-24 Murray Cumming <murrayc@murrayc.com>
320 * src/maemo/modest-account-settings-dialog.c:
321 (modest_account_settings_dialog_set_account_name),
322 Check the connection-specific smtp servers checkbox if there are any.
324 * src/maemo/modest-connection-specific-smtp-edit-window.c:
325 (modest_connection_specific_smtp_edit_window_init):
326 Start with a suitable port number.
328 * src/modest-account-mgr-helpers.h:
329 * src/modest-account-mgr-helpers.c: Added
330 modest_account_mgr_get_has_connection_specific_smtp().
332 (modest_account_mgr_set_connection_specific_smtp),
333 (modest_account_mgr_remove_connection_specific_smtp),
334 (modest_account_mgr_get_has_connection_specific_smtp),
335 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
336 connection-specific smtp server accounts in the account, rather than
337 the server account conf dir.
339 This fixes bug projects.maemo.org bug NB#58263 .
341 * src/modest-tny-account-store.c:
342 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
343 if there are no server accounts yet, to prevent an infinite loop when there
344 are no accounts. Document that one must be called before the other.
346 2007-05-24 Murray Cumming <murrayc@murrayc.com>
348 * src/modest-account-mgr-helpers.c:
349 (modest_account_mgr_get_default_account): Make sure that at least
350 one account is always the default, if there are any enabled accounts.
351 This is just a sanity check that shouldn't be necessary.
353 * src/modest-account-mgr-priv.c:
354 (_modest_account_mgr_account_from_key): Unescape the conf key to
355 get the real account name. For instance, this is an issue if a space
356 was in the account name, which can happen because the account name
357 is generated from the display name.
358 (_modest_account_mgr_get_account_keyname): Always escape the
360 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
361 Unescape the conf keys to get the real account names.
363 For instance, previously the is-default radio button in the accounts
364 list was not checked for any accounts at first. This fixes that,
365 and might fix several similar bugs.
367 2007-05-23 Murray Cumming <murrayc@murrayc.com>
369 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
370 Removed some debug printfs.
372 2007-05-23 Murray Cumming <murrayc@murrayc.com>
374 Modest on-disk outbox directories are now here, for instance:
375 $HOME/.modest/outboxes/<account-id-1>/outbox
376 $HOME/.modest/outboxes/<account-id-2>/outbox
378 $HOME/.modest/local-folders/outbox
379 so we can have a separate outbox for each account.
380 But they are shown as one outbox in the GtkTreeView, by using a
381 TnyMergeFolder in a ModestTnySimpleFolderStore.
384 * src/modest-tny-simple-folder-store.c:
385 * src/modest-tny-simple-folder-store.h:
386 Added ModestTnySimpleFolderStore, used to contain folders from
387 other folder stores, such as other accounts.
389 * src/modest-tny-outbox-account.h:
390 * src/modest-tny-outbox-account.c:
391 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
392 used for the per-account local outbox folders.
394 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
395 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
396 only use this (internally) now for the non-outbox local folders.
399 * src/modest-init.c: Added modest_init_one_local_folder(), for
400 setting up the directory structure for each local folder.
402 * src/modest-local-folder-info.c:
403 (modest_per_account_local_outbox_folder_info_get_maildir_path),
404 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
406 * src/modest-local-folder-info.h:
407 * src/modest-tny-account-store.c: (on_account_removed),
408 (on_account_changed), (create_per_account_local_outbox_folders),
409 (get_server_accounts), (modest_tny_account_store_get_accounts),
410 (modest_tny_account_store_get_tny_account_by_account),
411 (modest_tny_folder_store_is_virtual_local_folders):
413 * src/modest-tny-account.h:
414 * src/modest-tny-account.c:
415 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
416 to create an on-disk per-account local outbox folder for each
418 (create_per_account_local_outbox_folders): Create a local outbox folder
419 for each transport account.
420 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
421 for all local folders.
423 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
424 instead of using g_object_get/set() directly. It is clearer.
426 (modest_tny_folder_store_get_message_count),
427 (modest_tny_folder_store_get_local_size
428 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
429 because we now use these with non-acount folder stores.
431 (modest_tny_account_get_special_folder),
432 (modest_tny_account_new_from_server_account),
433 (modest_tny_account_new_from_account):
434 (recurse_folders): Adjust to the new outbox system.
436 * src/modest-tny-folder.h:
437 * src/modest-tny-folder.c:
438 (modest_tny_folder_is_local_folder),
439 (modest_tny_folder_get_local_folder_type),
440 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
442 * src/widgets/modest-main-window.h:
443 * src/maemo/modest-main-window.c: (create_details_widget),
444 (modest_main_window_set_contents_style): Show details for any folder store,
447 (modest_tny_folder_get_rules):
448 Remove the const. C does not support constness enough for this.
450 * src/modest-ui-actions.c:
451 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
452 make all outboxes appear as one, in the usual local-folders tree node.
454 (set_active_account_from_tny_account),
455 (modest_ui_actions_on_folder_selection_changed):
456 * src/widgets/modest-folder-view.c: (text_cell_data),
457 (icon_cell_data), (filter_row),
458 (add_account_folders_to_merged_folder),
459 (add_account_folders_to_simple_folder_store), (),
460 (get_cmp_rows_type_pos), (cmp_rows),
461 (modest_folder_view_set_account_id_of_visible_server_account):
462 Adjust to the new outbox system, using generic folder stores and folders
465 2007-05-23 Christian Kellner <ckellner@openismus.com>
467 * src/modest-mail-operation.c:
468 (modest_mail_operation_update_account):
469 Use info->max_size instead of unintialized local var [small
470 build fix]. (Added TODO to review that change since I don't
473 2007-05-23 Marcus Bauer <marcusb@openismus.com>
475 * libmodest-dbus-client/libmodest-dbus-client.c:
476 (libmodest_dbus_client_compose_mail): function added
477 * src/dbus_api/modest-dbus-api.h:
478 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
479 (on_compose_mail): Implementation of the SendAsMail functionality
481 2007-05-22 Murray Cumming <murrayc@murrayc.com>
483 * src/modest-account-mgr.c:
484 (modest_account_mgr_add_server_account): Set the secure-connection
485 conf key for transport accounts as well as store accounts. I don't know
486 why the if was there. For instance, this makes sure that we use SSL
487 for the gmail preset from the easysetup wizard.
489 2007-05-22 Murray Cumming <murrayc@murrayc.com>
491 * src/gnome/modest-main-window.c:
492 (on_account_store_connecting_finished), (connect_signals):
493 * src/maemo/modest-main-window.c:
494 (on_account_store_connecting_finished), (connect_signals),
495 (modest_main_window_new):
496 Handle TnyAccountStore::connecting-finished instead of
497 TnyDevice::connection-changed, because we cannot actually perform
498 operations on accounts until TnyAccountStore has itself responded to
499 the TnyDevice::connection-changed signal. This prevents a GError from
501 Do not try to update at startup, because we (at least on scratchbox)
502 already do an update at startup when the device goes online.
503 This prevents a GError from tinymail.
504 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
505 Added TODO about stopping simultaneous operations.
507 2007-05-21 Murray Cumming <murrayc@murrayc.com>
509 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
510 * src/modest-mail-operation-queue.c:
511 (modest_mail_operation_queue_remove):
512 * src/modest-tny-account-store.c: When GErrors happen, give more clues
513 about where they happened.
515 2007-05-21 Murray Cumming <murrayc@murrayc.com>
517 * src/modest-ui-actions.c:
518 (modest_ui_actions_on_password_requested): Make sure that the remember
519 output parameter is always TRUE.
521 2007-05-21 Murray Cumming <murrayc@murrayc.com>
523 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
524 Show a OK/Cancel dialog if the error is a question, though we still do not
525 know anything more about what we are asking the user.
526 * src/widgets/modest-folder-view.c: (on_drag_data_received):
527 Fix an uninitialized variable (helper). This is a logic error, however.
529 2007-05-21 Christian Kellner <ckellner@openismus.com>
531 * src/modest-search.h:
532 Correct bit shifting in the ModestSearchFlags enum.
534 2007-05-21 Murray Cumming <murrayc@murrayc.com>
536 * src/modest-tny-account.c:
537 (modest_tny_account_new_from_server_account): Do not use the lsub and
538 check-all hard-coded IMAP options when using POP.
540 2007-05-21 Murray Cumming <murrayc@murrayc.com>
542 * src/modest-tny-account.c:
543 (modest_tny_account_new_from_server_account):
544 Use NULL for the secure-auth method for POP when Password auth has been
545 specified by the user, as we already do for IMAP. "auth=Login" causes
546 an error from camel or the server.
548 2007-05-17 Murray Cumming <murrayc@murrayc.com>
550 * src/maemo/modest-account-settings-dialog.c:
551 (create_page_account_details),
552 (modest_account_settings_dialog_set_account_name):
553 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
554 for the leave-on-server checkbox, rathr than just the checkbox, when
555 the protocol is not POP.
557 2007-05-17 Murray Cumming <murrayc@murrayc.com>
559 * src/widgets/modest-account-view.c:
560 * src/widgets/modest-account-view.h:
561 Added modest_account_view_select_account() which will be useful later
562 to asynchronously re-select the edited account.
564 2007-05-17 Murray Cumming <murrayc@murrayc.com>
566 * src/maemo/modest-account-settings-dialog.c:
567 (modest_account_settings_dialog_set_account_name):
568 Automatically choose the port numbers based on the secure authentication
569 methods, if they have not been chosen before.
570 This fixes projects.maemo.org bug NB#56273 .
572 2007-05-17 Murray Cumming <murrayc@murrayc.com>
574 * src/maemo/modest-main-window-ui.h:
575 * src/modest-ui-actions.c:
576 * src/modest-ui-actions.h:
577 Connect the Tools/SMTP Servers menu item to
578 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
579 SMTP servers dialog, as in the UI specification and saves changes when it
580 is closed. This fixed projects.maemo.org bug NB#56305 .
582 2007-05-17 Murray Cumming <murrayc@murrayc.com>
584 * src/maemo/modest-connection-specific-smtp-window.c:
585 (modest_connection_specific_smtp_window_init):
586 Use gtk_window_set_default_size() to make this window big enough, so
587 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
589 2007-05-17 Murray Cumming <murrayc@murrayc.com>
591 * src/maemo/modest-connection-specific-smtp-edit-window.h:
592 * src/maemo/modest-connection-specific-smtp-edit-window.c:
593 (modest_connection_specific_smtp_edit_window_init),
594 Do not try to connect to a combobox signal before the combobox exists.
595 This fixes the cras in projects.maemo.org bug NB#56288 .
596 (modest_connection_specific_smtp_edit_window_get_settings):
597 Remove the server_account_name parameter which was being checked for NULL
598 though it was not used.
600 * src/maemo/modest-connection-specific-smtp-window.c:
601 (modest_connection_specific_smtp_window_fill_with_connections),
602 (on_button_edit), (modest_connection_specific_smtp_window_init):
603 Correct the number of treemodel columns to prevent a warning.
604 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
605 libconic does not work.
607 2007-05-16 Murray Cumming <murrayc@murrayc.com>
609 * src/modest-tny-account.c:
610 (modest_tny_account_new_from_server_account):
611 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
612 SMTP when "None" was chosen by the user. However, with my SMTP server that
613 does not support ANONYMOUS, the emails do not leave the Outbox and I see
616 2007-05-16 Murray Cumming <murrayc@murrayc.com>
618 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
619 to explain the memory management issue with the ID in the ModestPair.
621 * src/gnome/modest-account-assistant.c: (add_receiving_page),
622 (add_sending_page), (modest_account_assistant_finalize):
623 * src/gnome/modest-gnome-global-settings-dialog.c:
624 (create_updating_page), (create_composing_page):
625 * src/gnome/modest-msg-edit-window.c: (get_transports),
626 (init_window), (modest_msg_edit_window_finalize),
627 (modest_msg_edit_window_get_msg_data):
628 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
629 * src/gnome/modest-transport-widget.c:
630 (modest_transport_widget_finalize), (smtp_configuration):
631 * src/maemo/modest-maemo-global-settings-dialog.c:
632 (create_updating_page), (create_composing_page):
633 * src/maemo/modest-msg-edit-window.c: (get_transports),
634 (init_window), (modest_msg_edit_window_finalize),
635 (modest_msg_edit_window_get_msg_data),
636 (modest_msg_edit_window_free_msg_data):
637 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
638 (modest_store_widget_finalize):
639 * src/maemo/modest-transport-widget.c:
640 (modest_transport_widget_finalize), (smtp_configuration):
641 * src/modest-main.c: (send_mail):
642 * src/widgets/modest-combo-box.h:
643 * src/widgets/modest-global-settings-dialog-priv.h:
644 * src/widgets/modest-global-settings-dialog.c:
645 (modest_global_settings_dialog_finalize):
646 * src/widgets/modest-msg-edit-window.h:
647 Whenever using modest_combo_box_new(), keep the ModestPairList alive
648 as long as the combo box, to prevent use of freed memory for the ID.
650 2007-05-15 Murray Cumming <murrayc@murrayc.com>
652 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
653 get_accounts(), to make this clearer. Do not check for the enabled gconf
654 key, because we do not use this for server accounts (at least, not yet).
655 This allows us to send email again.
657 2007-05-15 Murray Cumming <murrayc@murrayc.com>
659 * src/maemo/modest-platform.c:
660 (on_modest_conf_update_interval_changed), (modest_platform_init):
661 Only respond to this particular key change. All these strcmp()s cannot be
664 2007-05-15 Murray Cumming <murrayc@murrayc.com>
666 * src/maemo/modest-maemo-global-settings-dialog.c:
667 (current_connection): Prevent a crash in scratchbox when
668 ny_maemo_conic_device_get_current_iap_id() returns NULL.
669 * src/maemo/modest-platform.c:
670 (on_modest_conf_update_interval_changed), (modest_platform_init):
671 Get the update interval from gconf and reset it when the gconf key changes.
673 2007-05-15 Murray Cumming <murrayc@murrayc.com>
675 * src/modest-protocol-info.c:
676 * src/modest-protocol-info.h: Adde enum-specific get functions,
677 instead of using a ModestProtocolType enum parameter.
679 * src/gnome/modest-account-assistant.c:
680 * src/gnome/modest-store-widget.c:
681 * src/gnome/modest-store-widget.h:
682 * src/gnome/modest-transport-widget.c:
683 * src/gnome/modest-transport-widget.h:
684 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
685 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
686 * src/maemo/easysetup/modest-easysetup-wizard.c:
687 * src/maemo/modest-account-settings-dialog.c:
688 * src/maemo/modest-account-settings-dialog.h:
689 * src/maemo/modest-store-widget.c:
690 * src/maemo/modest-store-widget.h:
691 * src/maemo/modest-transport-widget.c:
692 * src/maemo/modest-transport-widget.h:
693 * src/modest-account-mgr-helpers.c:
694 * src/modest-account-mgr-helpers.h:
695 * src/modest-account-mgr.c:
696 * src/modest-account-mgr.h:
697 * src/modest-tny-account.c:
698 * src/modest-tny-folder.c:
699 * src/widgets/modest-account-view.c:
700 * src/widgets/modest-retrieve-combo-box.c:
701 * src/widgets/modest-retrieve-combo-box.h:
702 * src/widgets/modest-secureauth-combo-box.c:
703 * src/widgets/modest-serversecurity-combo-box.c:
704 * src/widgets/modest-serversecurity-combo-box.h:
705 * tests/check_account-mgr.c:
706 Use the specific functions, and use the re-renamed enum values for GNOME too.
708 2007-05-15 Murray Cumming <murrayc@murrayc.com>
711 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
712 so we can get the second based on the first.
714 * src/maemo/modest-account-settings-dialog.h:
715 * src/maemo/modest-account-settings-dialog.c:
716 Added get_supported_secure_authentication_methods(), though it is mostly
717 commented-out for now until the necessary API is committed to tinymail.
718 (modest_account_settings_dialog_set_account_name),
719 (save_configuration): Request the supported authentication methods from the
720 server, so we can choose a working method.
722 * src/modest-tny-account-store.h:
723 * src/modest-tny-account-store.c:
724 (modest_tny_account_store_get_session): Rename from
725 tny_account_store_get_session().
727 2007-05-14 Murray Cumming <murrayc@murrayc.com>
729 * src/modest-protocol-info.h: Split the ModestProtocol enum
730 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
731 There was no need to have these unrelated values in one enum.
733 * src/: many files: Adapted to changed enum. This makes the code a bit
734 clearer, and the compiler could catch some errors.
736 2007-05-14 Murray Cumming <murrayc@murrayc.com>
738 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
739 Show the detailed internal camel error message when an error happens
740 during the configuration, so that our testers can give us more clues.
741 For instance, in projects.maemo.org bug NB#56910 .
743 2007-05-14 Murray Cumming <murrayc@murrayc.com>
745 * src/modest-tny-account.c:
746 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
747 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
749 2007-05-14 Murray Cumming <murrayc@murrayc.com>
751 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
752 * src/maemo/modest-account-settings-dialog.c:
753 (modest_account_settings_dialog_set_account_name),
754 (save_configuration): For the incoming secure authentication checkbox,
755 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
756 the UI specification. PLAIN does not seem to be supported for most IMAP
757 servers anyway, and I am not sure what it would mean.
758 However, we probably need to discover which of the secure-authentication
759 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
760 * src/modest-account-mgr-helpers.c:
761 (modest_account_mgr_get_server_account_data):
763 * src/modest-tny-account.c:
764 (modest_tny_account_new_from_server_account):
765 Use tny_account_set_mech() to set secure-authentication methods,
766 with some special-casing for IMAP, based on my observations of how
769 * src/modest-account-mgr-helpers.h:
770 * src/modest-account-mgr.c:
771 * src/modest-defs.h: Comment that the URI is only used for local folders.
773 2007-05-11 Murray Cumming <murrayc@murrayc.com>
775 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
776 parameter const, just to be neat.
777 * src/modest-text-utils.c: (modest_text_utils_inline):
778 End g_strconcat() with NULL, as its documentation says. This is almost
779 certainly the cause of my crash at startup on the device. Interestingly,
780 valgrind doesn't tell us about these errors.
782 2007-05-11 Murray Cumming <murrayc@murrayc.com>
784 * scripts/build-packages: Added more precise comments about how to use
785 this script, though I still get this error:
786 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
787 error building tinymail
789 2007-05-11 Murray Cumming <murrayc@murrayc.com>
791 * src/maemo/modest-main-window.c: (on_account_update):
792 Very slight cleanup, hoping to make it simpler to discover what causes
793 a crash here sometimes.
795 * src/modest-tny-account.c:
796 (modest_tny_account_new_from_server_account): Set the port. Added
797 comments about the options and a TODO comment because I need to find out
798 how to specify the secure authentication method.
800 2007-05-11 Marcus Bauer <marcusb@openismus.com>
802 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
803 changed CFlags paths form modest to libmodest
805 2007-05-10 Murray Cumming <murrayc@murrayc.com>
807 * src/modest-account-mgr-helpers.c:
808 (modest_account_mgr_get_server_account_data),
809 (modest_account_mgr_free_server_account_data):
810 * src/modest-account-mgr-helpers.h:
811 * src/modest-account-mgr.c:
812 (modest_account_mgr_add_server_account):
814 * src/modest-tny-account.c:
815 (modest_tny_account_new_from_server_account):
816 Determine the options for tny_camel_account_add_option() here,
817 based on the settings, rather than storing them directly in gconf.
819 2007-05-10 Murray Cumming <murrayc@murrayc.com>
821 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
822 Show a more friendly error dialog now that we expect (from the tinymail
823 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
825 2007-05-10 Murray Cumming <murrayc@murrayc.com>
827 * src/maemo/modest-main-window.c: (on_account_update): Check that
828 account_name is not NULL, to prevent a crash at startup that I am
829 seeing on the N800. I do wonder why it is NULL.
831 * src/maemo/easysetup/modest-easysetup-wizard.c:
832 (create_page_user_details):
833 * src/maemo/modest-account-settings-dialog.c:
834 (create_page_user_details), (create_page_outgoing):
835 * src/maemo/modest-connection-specific-smtp-edit-window.c:
836 (modest_connection_specific_smtp_edit_window_init):
837 * src/modest-ui-actions.c:
838 (modest_ui_actions_on_password_requested):
839 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
840 might do something useful with the on-screen keyboard.
842 2007-05-10 Murray Cumming <murrayc@murrayc.com>
844 * src/maemo/modest-main-window.c: (on_account_update):
845 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
846 NULL, to avoid lots of warnings. However, it probably should not be NULL.
848 2007-05-09 Murray Cumming <murrayc@murrayc.com>
850 * src/modest-tny-account-store.c: (on_account_changed):
851 Correct the signature of this signal handler.
853 2007-05-09 Murray Cumming <murrayc@murrayc.com>
855 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
856 Show a HildonNote instead of a GtkDialog for Maemo.
858 2007-05-09 Murray Cumming <murrayc@murrayc.com>
860 * src/widgets/modest-account-view.h:
861 * src/widgets/modest-account-view.c: (on_account_changed),
862 (on_account_removed). Added a boolean flag, set/unset by
863 modest_account_view_block_conf_updates(),
864 modest_account_view_unblock_conf_updates() to prevent unnecessary
865 updates, but this is not very useful because the gconf notifications are
866 so delays (maybe only on Maemo Bora).
867 So auto-updating is turned off, and these functions do an explicit
868 update when necessary.
869 However, something else is still doing too much work when adding/removing
870 accounts, probably in another part of the application.
872 * src/maemo/modest-account-view-window.c:
873 (on_delete_button_clicked), (on_edit_button_clicked),
874 (on_new_button_clicked): Use the new functions.
876 2007-05-09 Murray Cumming <murrayc@murrayc.com>
878 * src/modest-account-mgr-helpers.c:
879 (modest_account_mgr_set_first_account_as_default):
880 Sort the list of names alphabetically-by-title, so we choose the first one
882 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
883 alphabetically by the title.
885 This fixes projects.maemo.org bug NB#56418 .
887 * src/modest-account-mgr-priv.c:
888 (_modest_account_mgr_account_from_key):
889 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
890 avoid a valgrind error, and possible random behaviour.
892 2007-05-09 Murray Cumming <murrayc@murrayc.com>
894 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
895 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
896 tinymail documentation to say that this can be expected.
897 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
898 pretty, and should not happen, but I would prefer to know when it does.
900 2007-05-09 Murray Cumming <murrayc@murrayc.com>
902 * configure.ac: When using the older hildon version, probably on Bora,
903 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
905 * src/widgets/modest-attachment-view.c:
906 (modest_attachment_view_set_part_default): Initialize variables, to fix the
909 2007-05-09 Marcus Bauer <marcusb@openismus.com>
911 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
912 Implemented the prototype. Can be tested with
913 tests/dbus_api/test_open_message:
915 2007-05-08 Murray Cumming <murrayc@murrayc.com>
917 * src/modest-tny-account-store.c:
918 (modest_tny_account_store_instance_init), (get_password):
919 * src/modest-ui-actions.c:
920 (modest_ui_actions_on_password_requested):
921 Do not store the password in gconf, because this function is called
922 for non-remembered passwords. Actually use the cached (in the hash map)
923 password instead of releasing it.
924 The password will now not be remembered if it is asked via the protected
925 password dialog, as per the UI spec.
927 2007-05-08 Murray Cumming <murrayc@murrayc.com>
930 * src/modest-account-mgr-helpers.h:
931 * src/modest-account-mgr-helpers.c:
932 Added modest_server_account_get_username_has_succeeded(),
933 modest_server_account_set_username_has_succeeded().
934 (modest_server_account_set_username),
935 Reset the has-succeeded flag if the username changes.
937 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
938 * src/maemo/modest-connection-specific-smtp-window.c:
939 (modest_connection_specific_smtp_window_save_server_accounts):
940 Use modest_server_account_set_username() instead of using
941 modest_conf_set_string() directly, so that the has-succeeded flag is always
944 * src/modest-ui-actions.c:
945 (modest_ui_actions_on_password_requested): Dim the username entry if
946 the username has ever worked, as per the UI spec.
948 2007-05-08 Murray Cumming <murrayc@murrayc.com>
950 * src/modest-tny-account-store.c: (get_password):
951 * src/modest-ui-actions.c:
952 (modest_ui_actions_on_password_requested):
953 Allow the username to be changed too, though there is more work to
954 be done on exactly how this behaves.
956 2007-05-08 Murray Cumming <murrayc@murrayc.com>
958 * src/modest-account-mgr-helpers.h:
959 * src/modest-account-mgr-helpers.c:
960 Added modest_account_mgr_get_display_name(),
961 modest_server_account_get_username(),
962 modest_server_account_set_username(),
963 modest_server_account_set_password(),
964 modest_server_account_get_hostname() functions so we do not need to
965 use the conf API directly.
967 * src/maemo/modest-main-window.c: (connect_signals):
968 Actually connect ot the ModestAccountStore::request-password signal,
969 so that we show the dialog when the password is requested by Tinymail,
970 for isntance if it is empty.
972 * src/modest-marshal.list:
973 * src/modest-tny-account-store.c:
974 (modest_tny_account_store_class_init), (get_password),
975 (modest_tny_account_store_alert):
976 * src/modest-tny-account-store.h:
977 * src/modest-ui-actions.h:
978 * src/modest-ui-actions.c:
979 (modest_ui_actions_on_password_requested):
980 Change the signal parameters, so it is obvious that we are providing
981 the non human-readable server name, and receiving both the username
982 and password, though changing of the username is not yet implemented.
983 Change the dialog UI to match the Maemo UI specifications, with #idfefing
984 for the GNOME version.
986 This should fix the projects.maemo.org bug NB#56209, though it does not
987 work on Bora, because the gconf_client_get() for the password fails
988 immediately after we save it with gconf_client_set().
990 2007-05-08 Murray Cumming <murrayc@murrayc.com>
993 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
994 caused an undefined symbol error:
995 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
997 2007-05-08 Murray Cumming <murrayc@murrayc.com>
999 * src/modest-tny-account-store.c:
1000 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1001 using a GError instead of a string message, so we can translate it in
1004 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1006 * src/maemo/modest-address-book.c:
1007 (modest_address_book_check_names):
1008 * src/maemo/modest-msg-view-window.c:
1009 (modest_msg_view_window_clipboard_owner_change):
1010 * src/modest-init.c: (modest_init_init_ui):
1011 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1012 (update_folders_cb), (modest_mail_operation_update_account):
1013 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1014 (modest_ui_actions_on_msg_attachment_clicked),
1015 (modest_ui_actions_on_msg_recpt_activated):
1016 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1017 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1018 (modest_msg_view_search_next):
1019 * src/widgets/modest-recpt-editor.c:
1020 (modest_recpt_editor_on_button_release_event),
1021 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1022 g_message(). At this point we should only be seeing interesting errors on
1023 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1025 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1027 (modest_wizard_dialog_force_title_update):
1028 * src/maemo/easysetup/modest-wizard-dialog.h:
1029 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1030 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1031 can update the title when appropriate. Otherwise the title is wrong if the
1032 pages are added after adding the notebook to the dialog.
1033 This must be a problem in HildonWizardDialog too.
1034 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1036 * src/maemo/easysetup/modest-easysetup-wizard.c:
1037 (create_subsequent_customsetup_pages),
1038 (create_subsequent_easysetup_pages):
1039 Call modest_wizard_dialog_force_title_update() so that the title is
1040 correct even with GTK+ < 2.10.
1041 This fixes projects.maemo.org bug NB#56145 .
1043 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1045 * src/maemo/modest-platform.c:
1046 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1047 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1050 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1052 * src/widgets/modest-window.h:
1053 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1054 and modest_window_save_state(), which invokes it.
1056 * src/widgets/modest-window-mgr.h:
1057 * src/widgets/modest-window-mgr.c:
1058 Added modest_window_mgr_save_state_for_all_windows(), which calls
1059 the save_state vfunc on all registered windows, if implemented.
1061 * src/gnome/modest-msg-edit-window.c:
1062 * src/gnome/modest-msg-view-window.c:
1063 * src/maemo/modest-msg-edit-window.c:
1064 * src/maemo/modest-msg-view-window.c:
1065 * src/maemo/modest-main-window.c:
1066 Specify the existing save_settings functions as implementations of
1067 ModestWindow::save_state_func().
1069 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1070 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1071 enabling hibernation, for instance.
1073 We may need to do the same thing for restoring settings.
1076 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1078 * src/widgets/modest-window-mgr.c:
1079 * src/widgets/modest-window-mgr.h:
1080 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1081 modest_window_mgr_get_hibernation_is_prevented().
1083 * src/maemo/modest-main-window.c:
1084 (on_hildon_program_is_topmost_notify): Prevent hibernation
1085 (possible when the application goes to the background in the WM),
1086 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1088 * src/maemo/easysetup/modest-easysetup-wizard.c:
1089 (modest_easysetup_wizard_dialog_init):
1090 * src/maemo/modest-account-settings-dialog.c:
1091 (modest_account_settings_dialog_init):
1092 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1093 (modest_connection_specific_smtp_edit_window_init):
1094 * src/maemo/modest-connection-specific-smtp-window.c:
1095 (modest_connection_specific_smtp_window_init):
1096 * src/maemo/modest-signature-editor-dialog.c:
1097 (modest_signature_editor_dialog_init):
1098 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1099 prevent hibernation while any of these account settings dialogs are open.
1101 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1103 * src/maemo/Makefile.am:
1104 * src/maemo/modest-osso-state-saving.c:
1105 * src/maemo/modest-osso-state-saving.h: Added
1106 modest_osso_load_state() and modest_osso_save_state() though they do
1107 nothing now. They should iterate through all the open windows and load/save
1109 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1110 save state when closing.
1112 * src/maemo/modest-main-window.c:
1113 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1114 Add a notification handler for the HildonProgram::is-topmost property,
1115 so we can allow hibernation when the application goes into the background.
1116 But we still need to detect when the accounts setup windows are open so
1117 we can stop hibernation when they are open.
1118 To do this, I also added the main window the HildonProgram. This might have
1119 other side-effects/benefits, and should maybe be done for other windows.
1121 * src/maemo/modest-osso-autosave-callbacks.h:
1122 * src/maemo/modest-osso-autosave-callbacks.c:
1123 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1124 though it does not do anything yet, and we might never need this to do
1125 anything. For instance, we already save drafts.
1127 * src/maemo/modest-platform.c: (modest_platform_init):
1128 Specify the libosso auto-save callback.
1130 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1132 * src/maemo/modest-platform.c:
1133 (modest_platform_set_update_interval):
1134 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1135 aparently stays valid between application instances, so we can use this
1136 to remove and reset it later. According to a maemo-developers email from
1139 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1141 * configure.ac: Depend on libalarm for Maemo.
1143 * src/dbus_api/modest-dbus-api.h:
1144 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1145 (on_send_receive), (modest_dbus_req_handler):
1146 Handle a SEND_RECEIVE D-Bus method.
1148 * libmodest-dbus-client/libmodest-dbus-client.c:
1149 (libmodest_dbus_client_send_and_receive):
1150 * libmodest-dbus-client/libmodest-dbus-client.h:
1151 Add C convenience functions for calling the new D-Bus method.
1153 * src/modest-platform.h:
1154 * src/gnome/modest-platform.c:
1155 * src/maemo/modest-platform.c:
1156 Added modest_platform_set_update_interval(), which uses the
1157 alarmd API on Maemo.
1158 (modest_platform_init),
1159 Call modest_platform_set_update_interval(), using a hard-coded
1160 interval for now (until the global settings dialog is implemented),
1161 though I am not sure that this makes sense yet.
1163 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1165 * src/dbus_api/modest-dbus-callbacks.c:
1166 (modest_osso_cb_hw_state_handler):
1167 * src/dbus_api/modest-dbus-callbacks.h:
1168 * src/maemo/modest-platform.c: (modest_platform_init):
1169 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1170 in case this has some effect on the ability for Maemo to ping the
1173 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1175 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1176 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1177 warning. It is probably a logic error, but I need to fix the build.
1179 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1181 * src/modest-account-mgr.h:
1182 * src/modest-account-mgr.c:
1183 (modest_account_mgr_account_names): Add a gboolean enabled_only
1184 parameter, so we can get lists of onlt the enabled accounts.
1186 (modest_account_mgr_add_account),,
1187 (modest_account_mgr_account_with_display_name_exists):
1188 * src/maemo/modest-msg-edit-window.c: (get_transports):
1189 * src/modest-account-mgr-helpers.c:
1190 (modest_account_mgr_set_first_account_as_default):
1191 * src/modest-init.c: (init_default_account_maybe):
1192 * src/modest-tny-account-store.c: (get_accounts):
1193 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1194 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1195 * tests/check_account-mgr.c: (START_TEST):
1196 Provide the extra parameter, as appropriate.
1198 * src/widgets/modest-account-view.c: (update_account_view):
1199 Do not show disabled accounts (meaning that there is no way to
1200 enable/disable accounts in the UI (the feature is not in our UI
1201 specification), so we can use this internally only to mark unfinished
1202 or temporary account data.
1204 * src/maemo/easysetup/modest-easysetup-wizard.c:
1205 (create_account): Add boolean enable parameter, so we can specify FALSE
1206 to create the temporary account.
1207 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1208 (on_before_next): When finishing, when there is a temporary account, just
1210 Also, use a timeout to delay the showing of the dialog until gconf is likely
1211 to return correct information, due to a maemo gconf bug that is fixed in
1212 osso 1.1, but not yet in Bora.
1213 However, the dialog stays on screen after it is destroyed.
1215 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1216 for invalid data when cancelling. Use a hildon note instead of a dialog
1217 to complain about invalid data. Do not show the account-saved note if the
1218 account is disabled (a temporary account that will not really be saved for use
1221 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1223 * src/modest-account-mgr-helpers.h:
1224 * src/modest-account-mgr-helpers.c:
1225 Added modest_account_mgr_unset_default_account(),
1226 Added modest_account_mgr_set_first_account_as_default().
1228 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1229 If it was the default account, unset the default account name.
1231 * src/maemo/modest-account-view-window.c:
1232 (on_delete_button_clicked): If it was the default account,
1233 set the first remaining account as the default instead.
1235 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1236 a NULL account or a NULL default account, to prevent a crash. This should
1237 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1240 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1242 * src/widgets/modest-recpt-editor.c:
1243 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1244 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1245 TODO comment for this. This fixes the build.
1247 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1248 be the best place for it. This will in future update all auto-update accounts,
1249 rather than just the current/default account, when that gconf key exists.
1250 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1251 if there are no accounts, before calling do_send_receive().
1252 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1254 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1255 * src/maemo/modest-main-window-ui.h:
1256 * src/maemo/modest-main-window.c: (on_connection_changed),
1257 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1258 directly, becaue the signal handler does more.
1260 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1262 * src/modest-account-mgr-helpers.c:
1263 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1264 for the case that the account does not exist.
1266 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1267 (equivalent to the modest account name) rather than the tinymail account name
1268 (equivalent to the modest account title - human readable) to get the account data.
1269 Check for null account data to prevent the crash, and add a TODO comment saying that
1270 this needs fixing because it is using the server account name instead of the account name.
1272 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1274 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1275 * src/maemo/modest-account-settings-dialog.c: (show_error),
1277 Use hildon_note_new_information() for informative and error messages,
1278 which seems to be expected for Maemo applications (no documentation that I know of
1279 says this). I am surprised that there is no distinction between info and error
1282 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1284 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1285 it is easy to find where this is used.
1287 * src/maemo/easysetup/modest-easysetup-wizard.c:
1288 (create_page_welcome), (create_page_account_details),
1289 (create_page_user_details), (create_page_complete_easysetup),
1290 (create_page_custom_incoming), (create_page_custom_outgoing),
1291 (create_page_complete_custom):
1292 * src/maemo/modest-account-settings-dialog.c:
1293 (create_page_account_details), (create_page_user_details),
1294 (create_page_incoming), (create_page_outgoing):
1295 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1296 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1297 (modest_connection_specific_smtp_edit_window_init):
1298 * src/maemo/modest-connection-specific-smtp-window.c:
1299 (modest_connection_specific_smtp_window_init):
1300 * src/maemo/modest-signature-editor-dialog.c:
1301 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1302 and scrolling policy as per the Email Application Layout Guide, if I have
1305 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1307 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1308 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1309 which were empty, because these vfuncs have been removed from TnyAccountStore.
1310 This fixes the build.
1312 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1314 * src/maemo/modest-main-window.c:
1315 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1316 showing/hiding it. Added TODO because it probably should not be NULL.
1317 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1318 because unnecessary g_warnings() make degugging difficult.
1320 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1322 * src/maemo/modest-msg-edit-window.c:
1323 (modest_msg_edit_window_select_color),
1324 (modest_msg_edit_window_select_background_color): 2 const corrections and
1325 moving 2 #endifs before closing brackets, to fix the build.
1327 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1329 * src/maemo/easysetup/modest-easysetup-wizard.h:
1330 * src/maemo/easysetup/modest-easysetup-wizard.c:
1331 (modest_easysetup_wizard_dialog_finalize),
1332 (on_button_edit_advanced_settings), (create_page_complete_custom),
1333 (on_response), (create_account):
1334 Implement the Advanced Settings edit button, by saving the account information,
1335 for the Advanded Settings dialog to use directly from gconf, and removing it
1336 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1337 Bug #5533 in the projects.maemo.org bugzilla.
1339 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1341 * src/maemo/modest-msg-view-window.c:
1342 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1343 when opening a message window.
1345 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1347 * src/maemo/easysetup/modest-easysetup-wizard.c:
1348 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1351 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1352 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1353 gconf settings. I probably added more checks than necessary, but that is safer.
1355 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1356 variable to fix the build, but this seems to be used when it is still NULL.
1358 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1360 * src/modest-platform.h:
1361 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1362 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1363 * src/modest-main.c: Implement this function so we can avoid using
1364 maemo-specific API from cross-platform code.
1366 * src/modest-tny-account-store.c:
1367 (get_smtp_specific_transport_account_for_open_connection):
1368 * src/modest-ui-actions.c: (check_for_connection),
1369 (modest_ui_actions_on_item_not_found):
1370 Use modest_platform_connect_and_wait() and put #idefs around other
1371 maemo-specific code, because only maemo currently has a way to
1372 identify connection names.
1374 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1376 * src/modest-tny-account-store.h:
1377 * src/modest-tny-account-store.c:
1378 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1379 the connection-specific SMTP server settings in the configuration.
1381 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1383 * src/maemo/modest-main-window.c: (on_connection_changed),
1385 * src/modest-main.c: (main), (start_ui), (send_mail):
1386 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1387 that is what is intended.
1389 * src/modest-ui-actions.c: (action_send), (action_receive),
1390 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1391 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1392 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1393 SMTP server is used when it is specified.
1395 (modest_ui_actions_on_send_receive):
1396 Check that a connection is open before proceeding.
1397 Receive and then send, instead of vice-versa, as per the specification.
1399 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1401 * src/modest-mail-operation.c:
1402 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1403 though I guess it should be something other than NULL.
1405 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1407 * src/maemo/easysetup/modest-easysetup-wizard.c:
1408 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1409 combo twice, to avoid an g_warning and to make it visible again.
1410 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1411 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1412 (already intended) dereference when detaching, because we then recreate the menu.
1413 But I am not sure why the warning was happening, and it is possible that this is a memory
1416 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1418 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1419 and uri_parse_mailto() utility functions.
1420 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1422 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1424 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1426 * src/dbus_api/modest-dbus-api.h:
1427 * src/dbus_api/modest-dbus-callbacks.c:
1428 Use an idle callback to execute the modest code in the application's own thread.
1429 Remove the helloworld example method.
1430 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1431 parsed, and the open-message method is not implemented because this is not yet implemented in
1433 * libmodest-dbus-client/libmodest-dbus-client.c:
1434 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1435 (libmodest_dbus_client_open_message):
1436 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1438 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1439 body without crashing.
1441 * tests/dbus_api/Makefile.am:
1442 * tests/dbus_api/test_mail_to.c:
1443 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1445 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1447 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1448 Added file to fix the build. Sorry.
1450 * src/dbus_api/Makefile.am:
1451 * src/dbus_api/modest-dbus-api.h:
1452 * src/dbus_api/modest-dbus-callbacks.h:
1453 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1454 (modest_dbus_req_handler):
1455 Put constants in a separate header so it can be reused by the
1456 client library, without duplication
1458 * libmodest-dbus-client/Makefile.am:
1459 * libmodest-dbus-client/libmodest-dbus-client.c:
1460 (libmodest_dbus_client_call_helloworld),
1461 (libmodfest_dbus_client_send_mail),
1462 (libmodfest_dbus_client_mailto),
1463 (libmodfest_dbus_client_open_message):
1464 * libmodest-dbus-client/libmodest-dbus-client.h:
1465 (Partly) Implement a send_mail D-Bus method.
1467 * tests/dbus_api/Makefile.am:
1468 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1469 the send_email D-Bus method.
1471 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1475 * libmodest-dbus-client/Makefile.am:
1476 * libmodest-dbus-client/libmodest-dbus-client.c:
1477 * libmodest-dbus-client/libmodest-dbus-client.h:
1478 * tests/dbus_api/Makefile.am:
1479 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1480 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1482 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1484 * src/maemo/easysetup/modest-easysetup-wizard.c:
1485 (create_page_account_details):
1486 * src/maemo/modest-account-settings-dialog.c:
1487 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1488 widgets, because this might not be the default in future versions of the Maemo GTK+.
1489 However, I can not not get capitalization to work even in a simple test case.
1491 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1493 * src/maemo/easysetup/modest-easysetup-wizard.c:
1494 (create_page_custom_incoming), (create_page_custom_outgoing):
1495 * src/maemo/modest-account-settings-dialog.c:
1496 (create_page_account_details), (create_page_incoming),
1497 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1498 instead of using gtk_check_button_with_label(), so they are aligned like the other
1499 widgets, as per the UI spec.
1501 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1503 * src/maemo/easysetup/modest-easysetup-wizard.c:
1504 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1505 * src/widgets/modest-validating-entry.c:
1506 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1507 Modest prefix instead of an EasySetup prefix.
1509 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1511 * src/widgets/modest-validating-entry.h:
1512 * src/widgets/modest-validating-entry.c: (on_insert_text),
1513 Added easysetup_validating_entry_set_max_func(), used to set a callback
1514 to call when the max number of characters is reached. GtkEntry has a max-length
1515 already but is silent about it.
1517 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1518 (create_page_account_details), (create_page_user_details),
1520 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1521 (create_page_account_details), (create_page_user_details),
1522 (create_page_outgoing):
1523 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1524 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1525 the UI spec, when the user tries to enter more than the max number of characters.
1527 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1529 * src/maemo/easysetup/modest-easysetup-wizard.c:
1530 (create_page_user_details), (create_page_custom_incoming),
1531 (create_page_custom_outgoing):
1532 * src/maemo/modest-account-settings-dialog.c:
1533 (create_page_user_details), (create_page_incoming),
1534 (create_page_outgoing):
1535 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1536 (modest_connection_specific_smtp_edit_window_init):
1537 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1538 not appropriate. Bad Maemo-specific defaults!.
1540 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1542 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1543 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1544 (modest_signature_editor_dialog_set_settings):
1545 Disable the label and textview when the checkbox is disabled, and use the
1546 specified (UI spec) default signature text.
1548 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1550 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1551 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1553 * src/modest-defs.h:
1554 * src/modest-account-mgr-helpers.h:
1555 * src/modest-account-mgr-helpers.c:
1556 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1558 * src/maemo/Makefile.am:
1559 * src/maemo/modest-signature-editor-dialog.c:
1560 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1563 * src/maemo/modest-account-settings-dialog.h:
1564 * src/maemo/modest-account-settings-dialog.c:
1565 (modest_account_settings_dialog_finalize), (on_button_signature),
1566 (save_configuration): Use the new dialog when the Edit button is pressed, and
1567 save the changes if necessary, as per the UI spec.
1569 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1571 * src/maemo/Makefile.am:
1572 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1573 based on maemo-develoers email from Dirk.
1575 * src/maemo/easysetup/modest-easysetup-wizard.c:
1576 (create_page_welcome), (create_page_account_details),
1577 (create_page_user_details), (create_page_complete_easysetup),
1578 (create_page_custom_incoming), (create_page_custom_outgoing),
1579 (create_page_complete_custom),
1580 (modest_easysetup_wizard_dialog_init):
1581 * src/maemo/modest-account-settings-dialog.c:
1582 (create_page_account_details), (create_page_user_details),
1583 (create_page_incoming), (create_page_outgoing),
1584 (modest_account_settings_dialog_init):
1585 * src/maemo/modest-connection-specific-smtp-window.c:
1586 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1588 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1590 * src/maemo/easysetup/modest-easysetup-wizard.c:
1591 (create_page_account_details), (create_page_custom_outgoing),
1592 (create_page_complete_custom):
1593 * src/maemo/modest-account-settings-dialog.c:
1594 (create_page_user_details), (create_page_incoming),
1595 (create_page_outgoing):
1596 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1597 (modest_connection_specific_smtp_edit_window_init):
1598 Use the correct (UI spec) port min/max, and use horizontal separators,
1601 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1603 * src/maemo/easysetup/modest-easysetup-wizard.c:
1604 (set_default_custom_servernames):
1605 * src/maemo/modest-account-settings-dialog.c:
1606 (create_page_incoming), (on_combo_outgoing_security_changed),
1607 (on_combo_incoming_security_changed), (create_page_outgoing),
1608 (modest_account_settings_dialog_set_account_name),
1609 (save_configuration):
1610 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1611 (on_combo_security_changed),
1612 (modest_connection_specific_smtp_edit_window_init),
1613 (modest_connection_specific_smtp_edit_window_set_connection),
1614 (modest_connection_specific_smtp_edit_window_get_settings):
1615 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1618 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1621 * src/maemo/easysetup/modest-easysetup-wizard.c:
1622 (create_page_custom_outgoing), (create_page_complete_custom):
1623 * src/maemo/modest-account-settings-dialog.c:
1624 (create_page_user_details), (create_page_outgoing):
1625 * src/maemo/modest-account-view-window.c: (button_box_new):
1626 Use changed logical IDs as per the most recent UI spec:
1627 mcen_bd_emailsetup_edit -> mcen_bd_edit
1628 mcen_bd_emailsetup_delete -> mcen_bd_delete
1629 mcen_bd_emailsetup_close -> mcen_bd_close
1631 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1635 * src/dbus_api/Makefile.am:
1636 * src/dbus_api/modest-dbus-callbacks.c:
1637 * src/dbus_api/modest-dbus-callbacks.h:
1638 * src/maemo/modest-platform.c: (modest_platform_init):
1639 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1641 * tests/Makefile.am:
1642 * tests/dbus_api/Makefile.am:
1643 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1645 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1647 * src/maemo/modest-account-settings-dialog.c:
1648 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1649 Removed unnecessary includes.
1651 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1653 * src/maemo/easysetup/modest-easysetup-wizard.c:
1654 * src/maemo/modest-account-settings-dialog.c:
1655 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1656 * src/widgets/Makefile.am:
1657 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1658 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1659 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1660 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1661 * src/widgets/modest-secureauth-combo-box.c:
1662 * src/widgets/modest-secureauth-combo-box.h:
1663 * src/widgets/modest-serversecurity-combo-box.c:
1664 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1665 made the GObject names more consistent with the rest of the Modest code.
1667 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1669 * src/maemo/easysetup/Makefile.am:
1670 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1671 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1672 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1673 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1674 * src/maemo/easysetup/modest-easysetup-wizard.c:
1675 * src/maemo/easysetup/modest-validating-entry.c:
1676 * src/maemo/easysetup/modest-validating-entry.h:
1677 * src/maemo/modest-account-settings-dialog.c:
1678 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1679 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1680 widgets/ because they are used outside of easysetup too. After checking in,
1681 svn will allow me to rename them too.
1683 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1685 * src/gnome/modest-msg-edit-window.c:
1686 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1687 linker error, to fix the build on the GNOME platform.
1688 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1689 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1690 ifdefed out to avoid a warning.
1692 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1694 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1695 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1696 some alternative for GTK+ 2.6.
1698 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1700 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1702 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1703 specified for EmailAccountsDialog in UI spec.
1705 * src/maemo/easysetup/modest-easysetup-wizard.c:
1706 * src/maemo/easysetup/modest-easysetup-wizard.h:
1707 * src/maemo/modest-account-settings-dialog.c:
1708 * src/maemo/modest-account-settings-dialog.h:
1709 Reuse a member window widget for the connection-specific SMTP server accounts,
1710 so we can tell it to create/save the accounts only if we actually save changes.
1712 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1713 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1714 (modest_connection_specific_smtp_edit_window_get_settings):
1715 Return a struct instance for temporarily remembering the entered data.
1717 * src/maemo/modest-connection-specific-smtp-window.h:
1718 * src/maemo/modest-connection-specific-smtp-window.c:
1719 (modest_connection_specific_smtp_window_finalize),
1720 (modest_connection_specific_smtp_window_fill_with_connections),
1722 (modest_connection_specific_smtp_window_save_server_accounts),
1723 (update_model_server_names): Do not actually save data until asked,
1724 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1726 (on_selection_changed),
1727 (modest_connection_specific_smtp_window_init): Disable the edit
1728 button when nothing is selected.
1730 * src/modest-account-mgr-helpers.c:
1731 * src/modest-account-mgr-helpers.h:
1732 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1735 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1737 * src/modest-account-mgr-helpers.h:
1738 * src/modest-account-mgr-helpers.c:
1739 (modest_account_mgr_get_unused_account_name),
1740 (modest_account_mgr_get_unused_account_display_name): Added these
1741 utility functions, to avoid code duplication.
1743 * src/maemo/easysetup/modest-easysetup-wizard.c:
1744 (create_page_account_details), (create_account):
1745 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1746 (on_combo_security_changed),
1747 (modest_connection_specific_smtp_edit_window_init),
1748 (modest_connection_specific_smtp_edit_window_save_settings):
1749 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1750 * src/maemo/modest-connection-specific-smtp-window.c:
1751 (modest_connection_specific_smtp_window_finalize),
1752 (modest_connection_specific_smtp_window_fill_with_connections),
1753 (on_button_edit), (modest_connection_specific_smtp_window_init):
1754 * src/maemo/modest-connection-specific-smtp-window.h:
1755 Implementing saving of connection-specific server accounts.
1757 But I need to refactor this so we can save the data for each
1758 possible connection-specific account and only actually create the server accounts
1759 when the easysetup finished, or the OK button is pressed on the account settings
1762 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1764 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1765 (on_combo_security_changed):
1766 (modest_connection_specific_smtp_edit_window_init):
1767 Auto-fill the port number as in the account settings.
1769 (modest_connection_specific_smtp_edit_window_set_connection):
1770 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1771 * src/maemo/modest-connection-specific-smtp-window.c:
1772 (fill_with_connections), (on_button_edit),
1773 (modest_connection_specific_smtp_window_init):
1774 Turn the edit window into a dialog to simplify the code, and
1775 set a WM hint as in a GtkDialog, because only a popup can be on top of
1776 another window in Maemo, and popups usually have no WM decoration.
1778 * src/modest-defs.h:
1779 * src/modest-account-mgr-helpers.c:
1780 (modest_account_mgr_set_connection_specific_smtp),
1781 (modest_account_mgr_remove_connection_specific_smtp),
1782 (modest_account_mgr_get_connection_specific_smtp):
1783 * src/modest-account-mgr-helpers.h: Some functions to write the
1784 connection-specific SMTP server information. Not yet used.
1787 * src/widgets/modest-folder-view.c: (text_cell_data):
1788 Fix a warning about an uninitialized variable.
1789 (on_configuration_key_changed): Put an #ifdef around the use
1790 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1792 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1794 * src/maemo/modest-account-settings-dialog.h:
1795 * src/maemo/modest-account-settings-dialog.c:
1796 Added connect_for_modified() utility function to mark the new modified boolean.
1798 (create_page_account_details), (create_page_user_details),
1799 (create_page_incoming), (create_page_outgoing), (on_response),
1800 (modest_account_settings_dialog_init),
1801 (modest_account_settings_dialog_set_account_name):
1802 Only warn about unsaved changes when there are actually unsaved changes.
1804 * src/modest-account-mgr-helpers.c:
1805 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1806 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1807 to get the data from there in future.
1809 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1811 * src/modest-defs.h:
1813 * src/modest-account-mgr-helpers.h:
1814 * src/modest-account-mgr-helpers.c:
1815 Store the security account setting in a single conf key instead of using
1816 the options list, so that the list is left for just the to-be-removed camel hack,
1817 and because gconf_client_set_list() is failing for some reason.
1819 * src/modest-account-mgr.c:
1820 (modest_account_mgr_add_server_account):
1821 * src/maemo/modest-account-settings-dialog.c:
1822 (modest_account_settings_dialog_set_account_name),
1823 (save_configuration): Use the renamed functions.
1826 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1828 * src/widgets/Makefile.am:
1829 * src/widgets/modest-limit-retrieve-combo-box.c:
1830 * src/widgets/modest-limit-retrieve-combo-box.h:
1831 * src/widgets/modest-retrieve-combo-box.c:
1832 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1833 the account settings dialog.
1835 * src/modest-defs.h:
1836 * src/modest-account-mgr-helpers.h:
1837 * src/modest-account-mgr-helpers.c:
1838 (modest_server_account_get_option_secure_auth),
1839 (modest_server_account_set_option_secure_auth):
1840 * src/modest-account-mgr.c:
1841 (modest_account_mgr_add_server_account):
1842 Use the existing AUTH_MECH conf key for the secure-auth setting,
1843 instead of putting it in the list options, because this was actually used already.
1845 * src/maemo/modest-account-settings-dialog.c:
1846 (create_page_account_details),
1847 (modest_account_settings_dialog_set_account_name),
1848 (save_configuration):
1849 * src/maemo/modest-account-settings-dialog.h:
1850 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1851 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1853 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1855 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1856 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1857 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1859 * src/modest-defs.h:
1860 * src/maemo/modest-account-settings-dialog.c:
1861 (create_page_incoming), (on_combo_outgoing_security_changed),
1862 (on_combo_incoming_security_changed), (create_page_outgoing),
1863 (modest_account_settings_dialog_set_account_name),
1864 (save_configuration): Load/Save the port number, and change it when the
1865 security combo changes, to suitable defaults.
1867 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1869 * src/modest-account-mgr.c:
1870 (modest_account_mgr_add_server_account): Set the security and secure-auth
1871 options, and add a comment saying that the other camel-specific options should be
1874 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1876 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1878 * src/modest-tny-account-store.c: (account_list_free),
1879 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1880 cursor->data after unreffing it. But there is some strange stuff there so it might not be
1883 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1885 * src/modest-protocol-info.c:
1886 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1887 is required by our UI spec. Maybe something in our implementation will use this eventually.
1888 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1889 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1890 instead of the previous 0 placeholder.
1892 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1893 secure-auth settings.
1894 * src/modest-account-mgr-helpers.h:
1895 * src/modest-account-mgr-helpers.c:
1896 (modest_server_account_data_get_option_secure_auth),
1897 (modest_server_account_set_option_secure_auth),
1898 (modest_server_account_data_get_option_security),
1899 (modest_server_account_set_option_security): Added this API for getting and setting the security
1900 and secure-auth settings.
1902 * src/maemo/modest-account-settings-dialog.h:
1903 * src/maemo/modest-account-settings-dialog.c:
1904 (modest_account_settings_dialog_finalize), (check_data),
1905 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1906 about changing titles.
1907 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1908 (save_configuration): Save the security and secure-auth settings.
1910 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1911 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1913 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1915 * src/modest-defs.h:
1916 * src/modest-account-mgr.c:
1917 (modest_account_mgr_add_server_account):
1918 Added and used defines for the options key and value pair strings,
1919 that are used so far, though they do not seem to correspond to anything in our
1920 UI specs or ModestProtocol enum.
1922 * src/modest-account-mgr-helpers.h:
1923 * src/modest-account-mgr-helpers.c:
1924 (compare_option_strings_for_name),
1925 (modest_server_account_data_get_option_value),
1926 (modest_server_account_data_get_option_bool),
1927 (modest_account_mgr_get_server_account_option):
1928 Added helper functions for parsing the options GSList.
1930 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1932 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1933 display name is based on the supplied account name.
1934 * src/modest-account-mgr.c:
1935 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1936 with an inefficient, but good-enough, implementation.
1938 * src/maemo/easysetup/modest-easysetup-wizard.c:
1939 (create_page_account_details), (on_before_next), (create_account):
1940 Check for existing display names rather than (non-user-visible) account names, and just
1941 create and set a unique account name at the end.
1943 * src/maemo/modest-account-settings-dialog.c:
1944 (modest_account_settings_dialog_init),
1945 (modest_account_settings_dialog_set_account_name),
1946 (create_page_incoming): Show the display name, instead of the account name.
1947 (on_response): Do some (not all) extra checks, as in the UI spec.
1948 (save_configuration): Save the display name if it was changed.
1950 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1952 * po/en_GB.po: Added needed logical ID and translation.
1953 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1954 (init_view): Made the is-default column clicking work.
1956 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1959 * src/maemo/easysetup/Makefile.am:
1960 * src/maemo/easysetup/modest-easysetup-wizard.c:
1961 (modest_easysetup_wizard_dialog_init):
1962 * src/maemo/easysetup/provider-data-test.keyfile:
1963 * src/maemo/easysetup/provider-data.keyfile:
1964 Moved the provider data file to the new modest-providers-data package and used it from there.
1966 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1968 * src/modest-local-folder-info.c:
1969 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1970 N_() was already used on the static strings, but this just marks it for translation without
1971 using the translation.
1973 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1975 * src/maemo/modest-account-settings-dialog.c:
1976 (create_page_incoming),
1977 (modest_account_settings_dialog_set_account_name):
1978 Added comments about the need for new API in ModestAccountMgr to handle the authentication
1979 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1980 I will do this if nobody else gets there first.
1982 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1984 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1985 Saved much of the incoming and outgoing data too, though I cannot yet see how to
1986 save the security stuff.
1988 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1990 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1991 Set the email address and user fullname, which I now see must be
1994 * src/maemo/modest-account-settings-dialog.h:
1995 * src/maemo/modest-account-settings-dialog.c:
1997 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1998 leave-on-server and authentication.
1999 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2002 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2005 * src/maemo/modest-account-settings-dialog.c:
2006 * src/maemo/modest-account-settings-dialog.h:
2007 Most (but not all) of the widgets are now present as specified by the UI spec.
2008 No changes are yet saved, and some details are not properly shown yet.
2010 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2012 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2014 * src/maemo/Makefile.am:
2015 * src/maemo/modest-account-settings-dialog.c:
2016 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2017 an existing account. Doesn't do much yet.
2019 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2020 Open the accounts settings dialog when Edit is clicked.
2022 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2024 * src/maemo/easysetup/Makefile.am:
2025 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2027 * src/maemo/easysetup/modest-easysetup-wizard.c:
2028 (modest_easysetup_wizard_dialog_init):
2029 Try to get the source directory from the build system,
2030 instead of hard-coding "./" into the source code, when opening our local
2031 copies of the configuration files.
2032 But this still fails when opening the wizard from the Accounts window,
2033 maybe because the working directory seems to change at runtime.
2034 So the wizard will fail the second time unless you copy the files into their
2035 proper locations - see the stdout warnings for the paths.
2037 (create_page_account_details),(on_before_next):
2038 Check for existing non-server accounts instead of server accounts,
2039 so the default account name is useful again, and to prevent trying to
2042 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2043 Show the wizard when New is clicked.
2045 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2046 (init_view): Show the column headers, and show the columns that are
2047 specified in the UI specs. However, something in Maemo's GTK+ prevents
2048 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2049 change the default account. This is despite unsetting the special properties.
2051 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2053 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2054 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2055 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2056 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2057 to make that clearer.
2058 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2060 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2062 * src/maemo/modest-account-view-window.c:
2063 (modest_account_view_window_init),
2064 (modest_account_view_window_new):
2065 Use the same buttons as specified in the
2066 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2067 the existing widgets, which never had a chance of working.
2068 Put the ModestAccountView treeview in a scrolled window.
2069 Do not repeat the initialization in both _init() and _new().
2071 * src/widgets/modest-account-view.c: (update_account_view):
2072 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2073 this widget and window shows no accounts.
2075 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2077 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2079 * src/maemo/easysetup/modest-easysetup-wizard.c:
2080 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2081 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2082 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2085 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2086 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2087 accounts exist yet, as in the UI spec.
2089 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2091 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2093 * src/maemo/Makefile.am:
2094 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2095 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2096 New window for editing connection-specific smtp details.
2097 Not fully implemented.
2099 * src/maemo/modest-connection-specific-smtp-window.c:
2100 (modest_connection_specific_smtp_window_finalize) :
2101 unref the tree model.
2102 (on_button_edit): Show the edit window.
2104 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2106 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2109 * src/maemo/Makefile.am:
2110 * src/maemo/modest-connection-specific-smtp-window.c:
2111 * src/maemo/modest-connection-specific-smtp-window.h:
2112 New window for showing the list of connections, for connection-specific
2113 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2114 * src/maemo/easysetup/modest-easysetup-wizard.c:
2115 (create_page_custom_outgoing): Show the new window when the button is clicked.
2117 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2119 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2120 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2121 * src/maemo/modest-msg-edit-window.c:
2122 (modest_msg_edit_window_insert_image):
2123 * src/modest-conf.c: (modest_conf_key_escape):
2124 * src/modest-mail-operation.c:
2125 (modest_mail_operation_send_new_mail):
2126 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2127 (modest_ui_actions_on_new_account):
2128 * src/widgets/modest-attachment-view.c: (update_filename_request):
2129 * src/widgets/modest-mail-header-view.c:
2130 Corrected warnings that were breaking the build, by commenting out unused variables,
2131 and a function, and by including a header.
2133 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2135 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2136 so we can #ifdef around platform-specific code when necessary.
2137 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2138 to allow this to build for the GNOME platform too.
2140 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2142 * src/maemo/easysetup/modest-easysetup-wizard.c:
2143 Added util_increment_name() and used it in create_page_account_details()
2144 to make sure that the default account name is always a new name.
2146 (modest_easysetup_wizard_dialog_init),
2147 (set_default_custom_servernames): Some minor memory management fixes.
2149 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2153 * src/modest-runtime.c: (init_i18n): Restored the translation
2154 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2155 are defined in config.h, and the translations are installed.
2157 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2158 is defined for translation.
2160 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2162 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2164 * src/maemo/easysetup/modest-easysetup-wizard.c:
2165 (modest_easysetup_wizard_dialog_init):
2166 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2167 Use realistic paths (though they should use $prefix generically) to the
2168 mcc_mapping and provider-data.keyfile files which might work when they
2169 are installed by the future version of the operator-wizard package,
2170 and then fallback to paths in our source code, with an explanatory
2173 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2177 * src/maemo/Makefile.am:
2178 * src/maemo/easysetup/: Added files from the previously-exernal
2179 osso-modest-easysetup.
2180 * src/maemo/modest-main-window-ui.h:
2181 * src/modest-ui-actions.c:
2182 * src/modest-ui-actions.h:
2183 Added modest_ui_actions_on_new_account() as a signal handler for the
2184 New Account menu item. It shows the easysetup wizard.
2185 * po/en_GB.po: Added additional needed logical IDs and translations.
2187 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2188 Apparently ChangeLog is not used for some vague Nokia legal reasons.