1 2007-07-09 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
4 Do not try to unref a NULL folder store, to avoid a runtime warning.
5 This seems to happen sometimes when changing accounts settings.
7 2007-07-09 Murray Cumming <murrayc@murrayc.com>
9 * src/modest-tny-account-store.c:
10 (modest_tny_account_store_instance_init),
11 (modest_tny_account_store_finalize),
12 (on_account_settings_hide), (on_idle_wrong_password):
13 Use a GHashTable to ensure that we only show one account settings
14 dialog per modest account. This avoids us having a dialog open for
15 both the store and transport accounts, or due to repeated get_password()
16 calls that shouldn't happen anyway.
18 2007-07-09 Murray Cumming <murrayc@murrayc.com>
20 * src/maemo/modest-maemo-utils.c: (on_hide),
21 (modest_maemo_show_dialog_and_forget): Handle the response, because
22 the window is not even hidden by default.
24 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
25 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
26 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
27 which seems to prevent some modality problems.
29 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
30 Ignore user cancellation errors.
32 * src/modest-account-mgr-helpers.h:
33 * src/modest-account-mgr-helpers.c:
34 Added modest_server_account_get_password() and
35 modest_server_account_get_has_password() to avoid direct use of
38 * src/maemo/modest-account-settings-dialog.h:
39 * src/maemo/modest-account-settings-dialog.c:
40 (modest_account_settings_dialog_init): Store the notebook so we can
42 Added modest_account_settings_dialog_switch_to_user_info().
44 * src/modest-tny-account-store.c:
45 (get_password): When the password in the account settings is wrong (we think),
46 show the relevant page of the account settings dialog, in the mainloop.
47 However, we currently get many of these at once because cancel does not
49 (forget_password): Do not forget the password
50 from the account settings, because this causes side-effects when
51 tinymail seems to call it at strange time, maybe because of how we
52 are cancelling get_password().
53 (modest_tny_account_store_alert): Ignore user cancellations.
55 2007-07-09 Murray Cumming <murrayc@murrayc.com>
57 * src/maemo/modest-maemo-utils.h:
58 * src/maemo/modest-maemo-utils.c:
59 Added modest_maemo_show_information_note_and_forget() for use instead of
60 gtk_dialog_run() when the response is not needed, to avoid an extra
61 mainloop which could cause a hang.
63 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
64 Use the logical IDs for the error message, though they are not
65 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
66 because gtk_dialog_run() caused a hang here (the window did not close).
67 This fixes projects.maemo.org bug NB#62646.
69 2007-07-09 Murray Cumming <murrayc@murrayc.com>
71 * src/modest-account-mgr-helpers.h:
72 * src/modest-account-mgr-helpers.c:
73 Added modest_account_mgr_get_store_protocol().
75 * src/maemo/modest-account-view-window.c:
76 (on_delete_button_clicked): Show different warning text depending on
77 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
78 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
81 2007-07-09 Murray Cumming <murrayc@murrayc.com>
83 * src/maemo/modest-msg-edit-window.c:
84 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
85 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
87 2007-07-07 Armin Burgmeier <armin@openismus.com>
89 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
90 ckdg_ib_maximum_characters_reached from correct package.
92 * src/modest-ui-actions.c: Show an error message when a folder could
93 not be created. Tinymail does not give us specific error codes about
94 what has gone wrong, so we assume that a folder with that name
95 already exists, though there might be other reasons.
97 2007-07-06 Murray Cumming <murrayc@murrayc.com>
99 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
100 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
101 give a more exact error message that can be partly translated.
103 2007-07-05 Murray Cumming <murrayc@murrayc.com>
105 * src/maemo/modest-address-book.c:
106 (select_email_addrs_for_contact): Specify a default window size for the
107 select-email-address dialog, so that it is probably big enough for the
108 title. This should fix projects.maemo.org bug NB#62277.
110 2007-07-05 Murray Cumming <murrayc@murrayc.com>
112 * src/maemo/easysetup/modest-easysetup-wizard.c:
113 (create_page_complete_easysetup): Use
114 gtk_widget_set_size() request to ensure that the text wraps
117 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
119 * src/maemo/easysetup/modest-easysetup-wizard.c:
120 (on_entry_invalid_character), (create_page_account_details),
121 (create_page_user_details):
122 Use new API of ModestValidatingEntry. But for some reason the banner is
123 not shown. I will have to investigate that further.
125 * src/widgets/modest-validating-entry.c: (on_insert_text),
126 (modest_validating_entry_set_func):
127 * src/widgets/modest-validating-entry.h:
128 Added a new callback function to be able to react to prevented
129 characters whitespaces to e.g show a banner.
131 2007-07-05 Armin Burgmeier <armin@openismus.com>
133 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
134 notification of HildonNumberEditor instead of remembering the port
135 number. Thanks to Johannes for pointing this out.
137 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
139 * src/maemo/easysetup/modest-easysetup-wizard.c:
140 Check if there are any user changes before showing a confirmation
141 dialog (projects.maemo.org NB#60946)
143 2007-07-05 Armin Burgmeier <armin@openismus.com>
145 * src/maemo/modest-account-settings-dialog.c: Remember custom port
146 number at the beginning of the dialog and set the modified flag at the
147 end if the port number has changed. This is necessary because
148 HildonNumberEditor does not support notification when the value has
151 2007-07-05 Murray Cumming <murrayc@murrayc.com>
153 * src/modest-ui-actions.c:
154 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
155 a connection before asking anything else. Correct the check for the destination
156 folder so that it succeeds when online.
157 This fixed projects.maemo.org bug NB#61645.
159 2007-07-05 Murray Cumming <murrayc@murrayc.com>
161 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
162 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
163 to fix projects.maemo.org bug NB#62439.
165 2007-07-05 Murray Cumming <murrayc@murrayc.com>
167 * src/modest-tny-account.c: (on_connection_status_changed):
168 Really do not use tny_device_force_offline() here. See the previous comment.
170 2007-07-04 Murray Cumming <murrayc@murrayc.com>
172 * src/modest-tny-account.c: (on_connection_status_changed):
173 Do not use tny_device_force_offline() when tinymail says that something
174 went wrong with the connection. It seems to report this unnecessarily.
176 2007-07-04 Murray Cumming <murrayc@murrayc.com>
178 * src/maemo/modest-connection-specific-smtp-window.c:
179 (modest_connection_specific_smtp_window_init):
180 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
181 does not seem to have any effect in osso 1.1 (though it works in
182 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
184 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
186 * src/maemo/modest-connection-specific-smtp-window.c:
187 Fix UI specification problems with projects.meamo.org NB#60479
189 2007-07-04 Murray Cumming <murrayc@murrayc.com>
191 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
192 clue when this has failed, because the error dialog is not always shown
193 (at least in earlier version).
195 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
196 GError message, because the generic error dialog is not helpful.
198 'This message is not currently available (can't let a new connection go online)'
199 when trying to open an IMAP message.
201 (_modest_ui_actions_open): Offer a connection when some messages would
202 have to be downloaded and we are offline.
204 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
206 * src/widgets/modest-folder-view.c:
207 Don't check for MERGE type anymore as we use the correct type
209 NOTE: For the last two changes you need to update your tinymail copy
210 because of API changes!
212 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
214 * src/modest-tny-local-folders-account.c:
215 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
216 (see projects.maemo.org NB#61580)
218 2007-07-04 Murray Cumming <murrayc@murrayc.com>
220 * src/modest-tny-account.c: (on_connection_status_changed):
221 Commented out the call to modest_platform_connect_and_wait() because this
222 seems to always hang, and I would like to know if this is the only thing
223 that causes a hang when showing the connection dialog.
224 It is not very useful anyway.
226 2007-07-04 Murray Cumming <murrayc@murrayc.com>
228 * src/maemo/modest-msg-view-window.c:
229 (modest_msg_view_window_select_next_message):
231 * src/modest-platform.h:
232 * src/maemo/modest-platform.c:
233 Added modest_platform_connect_and_wait(), which calls
234 tny_maemo_conic_device_connect() always in the main thread, by calling it
235 in an idle handler and waiting for the idle handler to run. It should be
236 in the main thread because it uses GTK+ UI code. It just returns TRUE
237 if the device is already online.
239 There is some nasty code to ensure that subsequent calls to
240 modest_platform_connect_and_wait() just wait for the first one to finish,
241 by checking repeatedly in another idle handler. This is necessary,
242 because other threads (or even the main thread, via another idle handler)
243 can call modest_platform_connect_and_wait() while
244 modest_platform_connect_and_wait() is running.
246 (modest_platform_connect_and_wait_if_network_account),
247 (modest_platform_connect_and_wait_if_network_folderstore):
248 Convenience functions that calls modest_platform_connect_and_wait() if
249 the account or folder might want network access.
251 * src/modest-mail-operation.c:
252 (modest_mail_operation_update_account):
253 * src/modest-ui-actions.c: (download_uncached_messages),
254 (modest_ui_actions_on_rename_folder), (delete_folder),
255 (modest_ui_actions_on_main_window_move_to),
256 (modest_ui_actions_on_msg_view_window_move_to):
257 * src/widgets/modest-folder-view.c:
258 (drag_and_drop_from_folder_view):
259 Offer a connection if we are offline.
261 * src/modest-tny-account.c: (on_connection_status_changed):
262 Document this as only handling errors during network operations in progress,
263 and replace the idle code with a simple call to
264 modest_platform_connect_and_wait(), which does this instead.
266 2007-07-03 Murray Cumming <murrayc@murrayc.com>
268 * src/modest-tny-account.c:
269 (modest_tny_account_get_special_folder): (util_on_idle),
270 Handle the GError so we can see when tny_folder_store_get_folders()
271 fails, as it currently does while something else is connecting.
273 Added util_run_in_main_thread_and_wait()
274 which uses an idlen handler and mainloop to ensure that the function
275 is called in the main thread.
276 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
277 to make sure that we call attempt the connection in the mainloop only,
278 which might solve some hangs.
280 2007-07-03 Murray Cumming <murrayc@murrayc.com>
282 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
283 be found by their display name. This is never useful.
284 * src/modest-tny-account-store.c: (on_account_removed): Find the account
285 by its ID, instead of trying to use its ID as its display name.
287 * src/modest-tny-account-store.h:
288 * src/modest-tny-account.c:
289 (modest_tny_account_get_special_folder): Add a g_warning() when
290 tny_folder_store_get_folders() returns an empty list for the maildir.
292 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
293 Add a g_warning() when this returns NULL, because that it not allowed
296 2007-07-02 Armin Burgmeier <armin@openismus.com>
298 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
299 note when trying to cancel the wizard. This fixes projects.maemo.org
302 2007-07-02 Murray Cumming <murrayc@murrayc.com>
304 * src/modest-tny-account.h:
305 * src/modest-tny-account.c:
306 (modest_tny_account_new_from_server_account),
307 (modest_tny_account_new_from_server_account_name),
308 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
309 because this must now be set before setting the proto. This is usd in
310 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
311 warning in camel_session_get_service() caused by
312 tny_camel_transport_account_prepare().
314 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
317 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
319 * src/maemo/modest-connection-specific-smtp-edit-window.c:
321 (modest_connection_specific_smtp_edit_window_init):
323 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
326 2007-06-29 Murray Cumming <murrayc@murrayc.com>
328 * src/modest-tny-account.c:
329 (modest_tny_account_new_from_server_account):
330 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
331 now uses to request a connection when it needs one, and which it uses
332 to tell us that something is wrong with the connection, so we can force
333 the accounts offline to prevent further problems.
336 * src/modest-init.c: (init_default_settings):
337 * src/modest-mail-operation.c:
338 (modest_mail_operation_update_account):
339 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
340 This should not be necessary anymore. Do not set the conf key that
341 determined this (it was always TRUE and not set anywhere else).
343 * src/modest-ui-actions.h: Remove unused and unimplemented
344 modest_ui_actions_on_online_toggle_toggled().
346 2007-06-29 Murray Cumming <murrayc@murrayc.com
348 * src/maemo/modest-main-window.c: (connect_signals):
349 Don't connect to delete_event twice. Maybe this was harmless.
351 2007-06-29 Murray Cumming <murrayc@murrayc.com
353 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
354 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
355 Debug output to give some more clue when a folder move is not allowed.
357 2007-06-28 Murray Cumming <murrayc@murrayc.com
359 * src/modest-tny-account.c: (on_modest_file_system_info),
360 (modest_tny_account_get_mmc_account_name):
361 Always call the callback, without checking whether the name has changed.
362 * src/widgets/modest-folder-view.c: (strings_are_equal),
363 (on_model_foreach_set_name), (on_get_mmc_account_name),
364 (text_cell_data): Compare the name here, and use the name from
365 the account rather than from the
366 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
367 if the name was changed after the account was added to the model.
368 That's a tinymail bug but not one that I want to fix now.
370 This finally fixes projects.maemo.org bug NB#59301.
372 2007-06-27 Armin Burgmeier <armin@openismus.com>
374 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
377 2007-06-27 Murray Cumming <murrayc@murrayc.com
379 * src/modest-tny-account.h:
380 * src/modest-tny-account.c:
381 Added modest_tny_account_get_mmc_account_name(), to set the memory
382 card name asynchronously for the given account and then notify.
383 (modest_tny_account_new_for_local_folders): Use this new function instead
384 of using hildon_file_system_info_async_new() directly.
386 * src/widgets/modest-folder-view.c: (text_cell_data):
387 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
388 gtk_tree_model_row_changed() when it is available.
390 This should fix projects.maemo.org bug NB#59301.
392 2007-06-27 Murray Cumming <murrayc@murrayc.com
394 * src/modest-mail-operation.c: (update_account_thread),
395 (get_msgs_full_thread): Fix typo failures in the revert
398 2007-06-27 Murray Cumming <murrayc@murrayc.com
400 * src/maemo/modest-maemo-global-settings-dialog.c:
401 (idle_select_default_focus):
402 * src/modest-mail-operation.c: (idle_notify_progress),
403 (idle_notify_progress_once), (set_last_updated_idle),
404 (update_account_thread), (get_msgs_full_thread):
405 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
406 * src/widgets/modest-header-view.c:
407 (idle_notify_headers_count_changed_destroy),
408 (idle_notify_headers_count_changed):
409 Reverted the additions of gdk_threads_enter/leave(), in case this
410 helps with a startup hang on the device.
412 2007-06-26 Armin Burgmeier <armin@openismus.com>
414 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
415 for supported secure authentication methods from server by
416 gtk_dialog_run(), saving CPU time and a potential race condition.
418 2007-06-26 Armin Burgmeier <armin@openismus.com>
420 * src/maemo/modest-maemo-utils.h:
421 * src/maemo/modest-maemo-utils.c: Added a
422 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
423 only error code to tell the calling code when the user canceled the
426 * src/maemo/modest-account-settings-dialog.h:
427 * src/maemo/modest-account-settings-dialog.c:
428 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
429 message if the retrieval of secure authentication methods was canceled
430 by the user. Perform the check before saving anything to configuration
431 to not end up with half-committed configuration changes, do not show
432 a "Saving to configuration failed" note when authentication methods
433 could not be retrieved.
435 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
438 2007-06-26 Murray Cumming <murrayc@murrayc.com>
440 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
441 Only return the first level of folders under accounts, because the
442 osso-global-search UI spec doesn't want the rest.
443 This fixed projects.maemo.org bug NB#61811.
445 2007-06-26 Murray Cumming <murrayc@murrayc.com>
447 * src/modest-tny-account-store.c:
448 * src/modest-tny-account-store.h:
449 Added modest_tny_account_is_memory_card_account().
450 * src/maemo/modest-main-window.c: (create_details_widget):
451 Show the same information items for the memory card as we show for the
452 local-folders, to fix projects.maemo.org bug NB#59307.
454 2007-06-26 Murray Cumming <murrayc@murrayc.com>
456 * src/modest-tny-account-store.c: (get_password):
457 Added some checks for NULL to maybe prevent crashes, though I think
458 it was Philip's last commit that actually prevented the crash here
459 when creating a first new account.
460 But the new account is still not usable (no messages are shown)
461 until a restart of the application.
463 2007-06-26 Murray Cumming <murrayc@murrayc.com>
465 * src/maemo/modest-maemo-global-settings-dialog.c:
466 (idle_select_default_focus):
467 * src/modest-mail-operation.c: (idle_notify_progress),
468 (idle_notify_progress_once), (idle_notify_update_account_queue),
469 (set_last_updated_idle), (update_account_thread),
470 (notify_get_msgs_full), (get_msgs_full_destroyer),
471 (get_msgs_full_thread):
472 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
473 * src/widgets/modest-header-view.c:
474 (idle_notify_headers_count_changed_destroy),
475 (idle_notify_headers_count_changed):
476 Use gdk_threads_enter() and gdk_threads_enter_leave() in
477 all idle handlers, because some other thread could be blocking
478 the GDK lock, so that it can do GUI stuff.
480 2007-06-26 Murray Cumming <murrayc@murrayc.com>
482 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
483 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
484 (on_idle_send_receive), (on_idle_open_default_inbox):
485 * src/maemo/modest-msg-edit-window.c:
486 (modest_msg_edit_window_attach_file_noninteractive):
487 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
488 to prevent a hang. I don't quite understand why these are necessary,
489 beause we should already be in the main loop. I guess something outside
490 of the main loop is taking the lock.
492 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
493 we are really using URIs, and use files that are more likely to exist.
495 2007-06-26 Murray Cumming <murrayc@murrayc.com>
497 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
498 necessary because configure.ac now defines different variables.
500 2007-06-26 Murray Cumming <murrayc@murrayc.com>
502 * libmodest-dbus-client/libmodest-dbus-client.c:
503 * libmodest-dbus-client/libmodest-dbus-client.h:
504 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
505 libmodest_dbus_client_compose_mail() is what things actually use.
507 * src/dbus_api/modest-dbus-api.h:
508 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
509 * tests/dbus_api/Makefile.am:
510 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
513 2007-06-26 Murray Cumming <murrayc@murrayc.com>
515 * src/modest-init.c: (modest_init_local_folders):
516 For memory-card (or other non local-folders) maildir accounts,
517 always create an Archive folder, so that there is somewhere to put
518 messages. This should be less confusing, because the user does not need
519 to guess that the need to create a folder.
521 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
523 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
524 Fixed icon size by using (50, 50) which is the same as defined by
527 2007-06-25 Armin Burgmeier <armin@openismus.com>
529 * src/widgets/modest-window-mgr.c:
531 * configure.ac: Correctly recognize hildon-notify presence and fixed
532 the build without it being installed.
534 2007-06-25 Murray Cumming <murrayc@murrayc.com>
536 * libmodest-dbus-client/libmodest-dbus-client.c:
537 (libmodest_dbus_client_search): Fix the build. Sorry.
538 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
539 (reply_forward_cb): Initialize variables to fix the build.
541 * src/modest-tny-account-store.c:
542 (modest_tny_account_store_get_tny_account_by): Fix the account URI
543 comparison (a silly typo) so that email search results can be opened
544 when there are more than one account.
546 2007-06-25 Murray Cumming <murrayc@murrayc.com>
548 * libmodest-dbus-client/libmodest-dbus-client.c:
549 (libmodest_dbus_client_search),
550 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
551 instead of 1 second, because the search gets folders and messages from
552 the server, which can take a long time. When it times out,
553 osso-global-search will report no results.
555 We need to specify whether we should search only cached information
556 (maybe with a user preference), and the osso-email-search-plugin
557 API should really be improved to allow that option, and to allow results
558 to be delivered asynchronously in batches.
560 2007-06-25 Murray Cumming <murrayc@murrayc.com>
562 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
563 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
564 GTK_ICON_SIZE_DIALOG is probably the wrong size.
566 2007-06-25 Murray Cumming <murrayc@murrayc.com>
568 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
569 that is an empty string. D-Bus seems to give us these instead of NULL.
571 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
573 * src/dbus_api/modest-dbus-callbacks.c:
574 * src/maemo/easysetup/modest-easysetup-wizard.h:
575 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
576 * src/maemo/modest-connection-specific-smtp-edit-window.c:
577 (modest_connection_specific_smtp_edit_window_init):
578 * src/maemo/modest-maemo-global-settings-dialog.c:
580 * src/maemo/modest-maemo-utils.c:
581 (modest_maemo_utils_setup_images_filechooser):
582 * src/maemo/modest-main-window.c: (create_details_widget):
583 * src/maemo/modest-msg-edit-window.c:
584 (modest_msg_edit_window_attach_file_noninteractive),
585 (modest_msg_edit_window_color_button_change),
586 (modest_msg_edit_window_set_zoom):
587 * src/modest-mail-operation.c: (update_account_thread):
588 * src/modest-tny-account-store.c:
589 * src/modest-tny-account.c:
590 * src/widgets/modest-global-settings-dialog.c:
591 * src/widgets/modest-window.h:
595 2007-06-25 Murray Cumming <murrayc@murrayc.com>
597 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
598 * src/modest-search.c: (modest_search_folder),
599 (modest_search_all_accounts): Actually search only in the specified folder,
600 doing a simple match on the folder ID.
601 * src/modest-search.h: Added a folder field to the ModestSearch struct,
602 and added some documentation.
604 2007-06-22 Armin Burgmeier <armin@openismus.com>
606 * src/maemo/modest-maemo-utils.h:
607 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
608 modest_maemo_utils_get_supported_secure_authentication_methods.
610 * src/maemo/easysetup/modest-easysetup-wizard.c:
611 * src/maemo/modest-account-settings-dialog.c: Show correct error if
612 one occured, not just "Server does not support secure authentication".
614 2007-06-22 Murray Cumming <murrayc@murrayc.com>
616 * src/modest-tny-account-store.c: (get_password):
617 Restored the call to tny_account_set_user() because Philip seems to have
618 stopped this from crashing (by not using the freed string). It still does
619 not work, but now we can test it.
621 2007-06-22 Murray Cumming <murrayc@murrayc.com>
623 * src/maemo/modest-msg-edit-window.c: (init_window):
624 Comment out use of an uninitialzed GtkScrolledWindow variable,
625 to fix the build and stop a crash. Yet again.
627 2007-06-22 Murray Cumming <murrayc@murrayc.com>
629 * src/modest-tny-account-store.c: (get_password):
630 Remove the call to tny_account_set_user() because this actually crashes.
631 As mentioned in the last commit, it is known to not work anyway.
633 2007-06-22 Murray Cumming <murrayc@murrayc.com>
635 * src/modest-tny-account-store.c: (get_password):
636 Use tny_account_set_username() to tell tinymail that the username might
637 have changed too. But tinymail ignores this: see projects.maemo.org
639 * src/modest-ui-actions.c:
640 (modest_ui_actions_on_password_requested): Remove the useless attempt to
641 reset the connection when changing the username, and improve the comments.
642 Save the changed username to gconf at least, so it is used when Modest is
645 2007-06-21 Murray Cumming <murrayc@murrayc.com>
647 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
648 Do not use a query, so that we get all folders, including for POP and
649 local-folders. They work as search criteria too.
650 This fixes projects.maemo.org bug NB#57740.
652 2007-06-21 Murray Cumming <murrayc@murrayc.com>
654 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
655 Comment out the use of hildon_notification_set_sound() because it is
656 not declared, to fix the build. Warnings are serious, people.
658 2007-06-21 Armin Burgmeier <armin@openismus.com>
660 * src/maemo/modest-maemo-utils.h:
661 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
662 modest_maemo_utils_get_supported_secure_authentication_methods()
663 to query authentication methods for a specific user. This should fix
664 projects.maemo.org bug NB#61369.
666 * src/maemo/easysetup/modest-easysetup-wizard.c:
667 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
670 2007-06-21 Murray Cumming <murrayc@murrayc.com>
672 * libmodest-dbus-client/libmodest-dbus-client.h:
673 * libmodest-dbus-client/libmodest-dbus-client.c:
674 (modest_dbus_message_iter_get_search_hit),
675 (libmodest_dbus_client_search):
676 Reorganised and commented this.
677 Removed modest_search_hit_free() from the public API because it
680 Added libmodest_dbus_client_get_folders() and
681 modest_folder_result_list_free().
683 * src/dbus_api/modest-dbus-api.h:
684 * src/dbus_api/modest-dbus-callbacks.c:
685 (modest_dbus_req_filter): Commented. Moved most code to
686 on_dbus_method_search() and added on_dbus_method_get_folders().
688 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
689 of the extra D-Bus handler.
691 * tests/dbus_api/Makefile.am:
692 * tests/dbus_api/test_get_folders.c: New test for
693 libmodest_dbus_client_get_folders(). This seems to return an empty list
694 at the moment. That could be the same error that causes the message list
695 to be empty sometimes.
696 This should help with projects.maemo.org bug NB#57740.
698 2007-06-21 Armin Burgmeier <armin@openismus.com>
700 * src/modest-mail-operation.c: Do not call
701 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
702 notify the operation's end after having set the status to CANCELED for
703 the operation queue to listen on. This fixes a deadlock when there
704 were mail operations in the queue during its finalization.
706 * src/modest-singletons.c: Reordered uninitialization of the account
707 manager to happen after the mail operation queue was uninitialized
708 because the mail operation's in the queue might still try to access
709 the account manager (see modest_mail_operation_notify_end()). This
710 fixes a potential crash when terminating the application.
712 2007-06-21 Murray Cumming <murrayc@murrayc.com>
714 * src/modest-search.c:
715 (search_mime_part_and_child_parts): Moved some code here so we
716 can search recursively in child folders.
717 (modest_search_folder): Search in the message as a mime part, instead
718 of just its child mime parts.
719 (read_chunk), (search_mime_part_ogs):
720 Check how many bytes were read, to prevent an endless loop.
721 Searching in message bodies now works. This finishes the fix for
722 projects.maemo.org bug NB#61007.
724 2007-06-20 Murray Cumming <murrayc@murrayc.com>
726 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
727 Add a g_warning when the item is not a folder.
729 * src/modest-ui-dimming-rules.c:
730 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
731 when selected item is not a folder (for instance, an account), because
732 the UI spec only talks about folders.
733 I am not sure what the UI spec wants, so this might not totally fix
734 projects.maemo.org bug NB#60794.
736 2007-06-20 Murray Cumming <murrayc@murrayc.com>
738 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
739 (load_from_file): Sort the list. The unsorted list would be more noticeable
740 in non-English locales.
742 * src/maemo/modest-msg-edit-window.c:
743 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
744 warning and fix the build.
746 * src/maemo/modest-progress-bar-widget.c:
747 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
748 avoid a g_warning, and probably to avoid a crash.
750 2007-06-20 Murray Cumming <murrayc@murrayc.com>
752 * src/modest-search.c: (modest_search_folder): Check for a GError
753 when calling tny_folder_get_headers(), to show that this is not the cause
756 2007-06-20 Murray Cumming <murrayc@murrayc.com>
758 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
759 Actually set the body query instead of the subject query.
761 * src/modest-search.c: (search_mime_part_ogs),
762 (search_mime_part_strcmp): Remove extra space from the text/* regex,
763 which would probably cause it to fail if we got this far.
765 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
766 to simplify the code.
767 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
768 be causing search-in-body to fail.
770 2007-06-20 Murray Cumming <murrayc@murrayc.com>
772 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
774 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
775 Better debug message when the folder cannot be found.
776 This should help with fixing projects.maemo.org bug #61287.
777 * src/modest-search.c: (add_hit): Do not leak the furl string.
779 2007-06-20 Murray Cumming <murrayc@murrayc.com>
781 * src/modest-ui-actions.c:
782 (modest_ui_actions_on_folder_selection_changed):
783 Do not special-case TNY_MERGE_FOLDER here, because
784 modest_tny_folder_get_account() already does that. This fixes
785 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
786 shown when the Outbox was selected).
788 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
790 * libmodest-dbus-client/libmodest-dbus-client.c:
791 (_dbus_iter_get_string_or_null): Initialize the string variable in
792 case this helps with Dirk's crash.
794 2007-06-19 Murray Cumming <murrayc@murrayc.com>
796 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
797 though it is not implemented yet (this function is maybe not even used),
798 to avoid breaking ABI in future.
799 * libmodest-dbus-client/libmodest-dbus-client.c:
800 (get_attachments_string): Moved some code into this generic function.
801 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
802 sends email. It is maybe not used.
803 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
804 (on_send_mail): Use attachments.
806 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
807 * src/maemo/modest-msg-edit-window.c:
808 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
809 a filename before using it, to fix projects.maemo.org bug NB#58233.
811 2007-06-19 Murray Cumming <murrayc@murrayc.com>
813 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
814 Initialize the continue_download variable to fix the build, and probably
815 to fix randome behaviour.
817 2007-06-18 Armin Burgmeier <armin@openismus.com>
819 * src/modest-tny-send-queue.h:
820 * src/modest-tny-send-queue.c: Keep track of the status of messages in
821 the queue so we can later show it in the UI. Replaced
822 modest_tny_send_queue_msg_is_being_sent() by
823 modest_tny_send_queue_get_msg_status().
825 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
827 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
828 gpointer. This probably was not harmful, but just to be sure.
830 2007-06-18 Murray Cumming <murrayc@murrayc.com>
832 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
833 Fix the build, but leave the function broken on Bora, because
834 hildon_uri_action_get_service() does not exist.
835 osso_uri_action_get_service() does not exist either, it seems.
837 2007-06-18 Murray Cumming <murrayc@murrayc.com>
839 * src/modest-tny-account.c:
840 (modest_tny_account_new_from_server_account):
841 Uncommented the url debug output again, because it is useful for
842 debugging, as I said in the comment.
844 2007-06-18 Murray Cumming <murrayc@murrayc.com>
846 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
848 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
849 for Mameo Bora, to fix the build.
851 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
854 Fixed build with hildon < 0.99
856 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
857 Check if the selected account is busy instead of checking all accounts
859 * src/modest-account-mgr-priv.h:
860 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
861 (modest_account_mgr_init), (compare_account_name),
862 (modest_account_mgr_set_account_busy),
863 (modest_account_mgr_account_is_busy):
864 * src/modest-account-mgr.h:
865 Added busy information to the account manager. It possible to
866 set an account to busy or not busy now.
868 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
869 (modest_mail_operation_update_account),
870 (modest_mail_operation_notify_end):
871 Set the account to busy/not busy depending on the operation state.
873 * src/widgets/modest-account-view.c:
874 (modest_account_view_finalize), (get_last_updated_string),
875 (update_account_view), (on_account_busy_changed), (init_view):
876 Show string "Refreshing..." if the account is currently busy.
878 All this fixes projects.maemo.org bug NB#59711
880 2007-06-14 Armin Burgmeier <armin@openismus.com>
882 * src/widgets/modest-attachments-view.h:
883 * src/widgets/modest-attachments-view.c: Added
884 modest_attachments_view_has_attachments() and fixed coordinate
885 transformation in get_att_view_at_coords(). This fixes attachment
888 * src/widgets/modest-msg-view.c: Make use of
889 modest_attachments_view_has_attachments() to decide whether to show
890 attachments in the header.
892 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
894 * src/maemo/modest-connection-specific-smtp-edit-window.c:
895 (on_change), (on_combo_security_changed),
896 (modest_connection_specific_smtp_edit_window_init),
897 (modest_connection_specific_smtp_edit_window_set_connection),
898 (modest_connection_specific_smtp_edit_window_is_dirty):
899 * src/maemo/modest-connection-specific-smtp-edit-window.h:
900 * src/maemo/modest-connection-specific-smtp-window.c:
903 Show an comfirmation dialog for the smpt-edit-window if there are
904 unsaved changes and the user hits cancel.
905 (projects.maemo.org bug NB#60479)
907 2007-06-14 Armin Burgmeier <armin@openismus.com>
909 * src/maemo/easysetup/modest-easysetup-wizard.c:
910 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
911 address" info in banner instead of node, and select all the text as
912 per UI spec. This fixes projects.maemo.org bug NB#60550.
914 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
916 reviewed by: <delete if not using a buddy>
918 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
919 * src/modest-ui-actions.c: (folder_refreshed_cb):
921 2007-06-14 Murray Cumming <murrayc@murrayc.com>
923 * src/widgets/modest-folder-view.c: (filter_row):
924 Explictly filter out the per-account outbox accounts. I don't know why
925 these only sometimes show up, but now they should never show up in the UI.
926 This should fix projects.maemo.org bug NB#60160.
928 2007-06-14 Murray Cumming <murrayc@murrayc.com>
930 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
931 when the toolbar does not exist yet.
932 * src/modest-widget-memory.c: (save_settings_header_view):
933 Added g_warnings() to help us to discover when we are trying to set
934 an empty columns list in gconf.
936 2007-06-14 Murray Cumming <murrayc@murrayc.com>
940 Added modest_init_get_default_header_view_column_ids().
942 * src/modest-widget-memory.c: (restore_settings_header_view):
943 Use the new function to get defaults, if the gconf key is empty,
944 instead of not creating any columns. This seems to fix the
945 empty right-hand pane problems.
947 * src/widgets/modest-header-view.h: Improved documentation.
949 2007-06-13 Murray Cumming <murrayc@murrayc.com>
951 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
952 Revert the use of the display name as the account name, because this
953 is generally wrong and would break the code that follows.
955 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
957 * src/maemo/easysetup/modest-easysetup-wizard.c:
958 (check_for_supported_auth_methods), (on_before_next),
961 More correct fix for projects.maemo.org bug NB# 58991
962 Do not longer accept AUTH_PASSWORD as secure method and choose
963 correct method when creating the account.
965 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
967 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
968 Fixed projects.maemo.org bug NB# 58991
970 2007-06-13 Murray Cumming <murrayc@murrayc.com>
972 * src/modest-init.c: (modest_init_init_core),
973 (modest_init_local_folders): Fixed compilation errors.
975 2007-06-13 Murray Cumming <murrayc@murrayc.com>
977 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
978 Remove unnecessary lib/include, though it is good in principle when needed.
980 * src/modest-init.c: (modest_init_one_local_folder),
981 (modest_init_local_folders):
982 * src/modest-init.h: Initialize the .modest library for memory cards,
983 instead of just doing nothing for them. This should allow us to create
984 folders there, fixing projects.maemo.org bug NB#59297.
986 2007-06-13 Murray Cumming <murrayc@murrayc.com>
988 * libmodest-dbus-client/libmodest-dbus-client.c:
989 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
990 (libmodest_dbus_client_compose_mail),
991 (libmodest_dbus_client_open_message),
992 (libmodest_dbus_client_send_and_receive),
993 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
995 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
996 (on_idle_open_message), (modest_dbus_req_handler),
997 (search_result_to_message), (modest_dbus_req_filter):
998 * src/modest-search.c: (add_hit), (modest_search_folder),
999 (modest_search_all_accounts): Improved debug messages.
1001 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1003 * src/modest-tny-account-store.c:
1004 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1007 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1010 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1012 * src/modest-tny-account-store.c: (get_server_accounts):
1013 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1014 even when there are no accounts, so that the Outbox folder is always
1015 visible. This fixes projects.maemo.org bug NB#60158.
1017 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1019 * src/maemo/modest-main-window.c: (create_details_widget):
1020 Use the mcen_va_never logical ID.
1022 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1024 * src/dbus_api/modest-dbus-api.h:
1025 * src/dbus_api/modest-dbus-callbacks.c:
1026 (on_idle_open_default_inbox), (on_open_default_inbox),
1027 (modest_dbus_req_handler):
1028 Added a new OpenDefaultInbox method.
1030 * libmodest-dbus-client/libmodest-dbus-client.h:
1031 * libmodest-dbus-client/libmodest-dbus-client.c:
1032 Added libmodest_dbus_client_open_default_inbox() to call the new
1033 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1034 though it should maybe be used by a new osso-email-interface function.
1036 * tests/dbus_api/Makefile.am:
1037 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1040 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1042 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1043 NULL, so that the signals get all the keys. This should not actually
1044 change any behaviour because we currently update everything when anything
1047 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1049 * src/widgets/modest-folder-view.c: (text_cell_data),
1050 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1051 (find_inbox_iter): If tinymail tells us that the folder is
1052 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1053 This causes the inbox to be selected at startup, fixing part of
1054 projects.maemo.org bug NB#56305.
1056 * src/modest-ui-dimming-rules.c:
1057 (modest_ui_dimming_rules_on_tools_smtp_servers):
1058 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1059 the SMTP servers menu item.
1060 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1061 that the SMTP Servers menu item is dimmed when there are no accounts,
1062 as a future version of the UI spec will require. This fixes
1063 projects.maemo.org bug NB#56305.
1065 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1067 * src/maemo/modest-maemo-utils.c:
1068 (modest_maemo_utils_get_supported_secure_authentication_methods):
1069 Added label to dialog instead of unreadable title
1071 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1072 (modest_main_window_new):
1073 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1076 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1077 * src/modest-account-mgr.h:
1078 Added method to avoid code duplication
1080 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1081 (modest_ui_actions_on_send_receive):
1082 Use modest_account_mgr_has_accounts
1084 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1086 * src/maemo/easysetup/modest-presets.c:
1087 (modest_presets_get_info_server_security): Do not report secure auth
1089 * src/modest-protocol-info.c: Use the defines for the gconf key names
1090 for secure authentication. This was not working because we were writing
1091 Password and reading password, and the check was case sensitive.
1092 With this, gmail now works for receiving and sending when created via
1095 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1097 * src/maemo/easysetup/modest-presets.c:
1098 (modest_presets_get_info_server_security): Correct the key name for
1099 SecureSmtp, because it seems to be case-sensitive.
1100 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1101 Do not try to get the 0th notebook page if there are 0 pages, to
1102 avoid a g_warning().
1104 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1106 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1107 Prevent use of the new notification feature for now, because it currently
1108 shows one dialog for each new email, which is annoying.
1110 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1112 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1113 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1114 when no country was selected, so that we show the global ones.
1115 * src/maemo/easysetup/modest-presets.c:
1116 (modest_presets_get_providers): Return only the global providers, not
1117 all providers when mmc=0 was requested.
1119 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1121 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1122 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1123 provider ID in the combo.
1125 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1126 Do not show the page numbers, because it would be confusing when we add
1127 the 2 extra pages for the custom setup, when the user chooses the "Other"
1128 provider. This fixes projects.maemo.org bug NB#59028
1130 * src/modest-init.c: (modest_init_init_core),
1131 (modest_init_local_folders):
1132 * src/modest-init.h:
1133 * src/modest-tny-account.c:
1134 (modest_tny_account_new_for_local_folders): Do not create default folders
1135 for the memory card. This should fix projects.maemo.org bug NB#59328.
1137 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1139 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1140 Free the changed_conf_keys string items. They are already freed in the
1141 idle handler if that runs first.
1143 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1145 * src/modest-ui-actions.c:
1146 (modest_ui_actions_on_password_requested): Check that the server name
1147 is not NULL, because I just saw a password dialog with (null) as the
1150 * src/modest-tny-folder.[h|c]: Added
1151 modest_tny_folder_is_memory_card_folder().
1152 * src/modest-ui-dimming-rules.c:
1153 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1154 menu item for memory cards, as per the UI spec (section 7.4). This should
1155 fix projects.maemo.org bug NB#59297.
1157 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1159 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1160 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1161 is another problem with the code, see Murray's comment at line 772)
1163 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1165 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1166 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1167 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1168 (load_from_file), (easysetup_country_combo_box_init),
1169 (easysetup_country_combo_box_get_active_country_ids),
1170 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1171 instead of just one ID, to avoid duplicate country names in the UI.
1173 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1174 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1175 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1176 a single ID, avoiding duplicate providers.
1177 * src/maemo/easysetup/modest-easysetup-wizard.c:
1178 (on_combo_account_country): Adapt to use a list.
1180 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1182 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1183 keys changed in the last X seconds.
1185 * src/modest-account-mgr.h:
1186 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1187 (on_key_change), (modest_account_mgr_class_init),
1188 (modest_account_mgr_init), (modest_account_mgr_finalize):
1189 As the keys are changed, save them in a GSList* and signal that GSList*
1190 further every X seconds, to batch changes, to allow us to do just one
1191 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1192 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1194 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1195 changed signal signature.
1197 * src/modest-conf.c: (modest_conf_set_list),
1198 (modest_conf_on_change): Reenable notification.
1200 (modest_conf_maemo_fake_on_change): Comment out the hack that
1201 notified immediately instead of asynchronously.
1203 * src/widgets/modest-account-view.h:
1204 * src/widgets/modest-account-view.c:
1205 (update_account_view): Select the previously-selected account ID,
1206 if possible. This fixes projects.maemo.org bug NB#56933.
1208 (on_account_changed), (on_account_removed),
1209 (modest_account_view_select_account):
1211 Remove the block/unblock functions
1212 because they were not useful.
1214 * src/maemo/modest-account-view-window.c:
1215 (on_delete_button_clicked), (on_edit_button_clicked),
1216 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1218 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1220 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1221 Improve the error dialog to show Incorrect Account Settings, which seems
1222 clearer, and say that the internal error message (to be removed from the
1223 dialog later) is often misleading.
1224 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1226 * src/modest-tny-account.c:
1227 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1228 URL because this is so useful for debugging on the device.
1230 * src/widgets/modest-serversecurity-combo-box.c:
1231 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1233 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1235 * src/modest-mail-operation.c:
1236 (modest_mail_operation_send_new_mail):
1237 Added a comment about a nasty but apparently harmless message. Details
1238 added to the wiki g_warnings() page.
1240 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1242 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1243 (modest_tny_send_queue_class_init):
1244 Do not use the priv struct because it is empty, to avoid g_warnings
1245 about a non-existant priv struct.
1247 * src/modest-tny-account-store.c:
1248 (modest_tny_account_store_get_server_account),
1249 (modest_tny_account_store_get_transport_account_for_open_connection
1250 ): Do not try to get transport server accounts for local folders,
1251 because they don't have any. This avoids a g_warning().
1253 * src/maemo/modest-main-window.c:
1254 (modest_main_window_notify_send_receive_initied),
1255 (on_configuration_key_changed):
1256 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1257 * src/modest-defs.h:
1258 * src/modest-mail-operation.c:
1259 (modest_mail_operation_update_account):
1260 * src/modest-tny-account-store.h:
1261 * src/modest-tny-account.c:
1262 (modest_tny_account_get_special_folder),
1263 (modest_tny_account_new_for_local_folders),
1264 (modest_tny_account_new_for_per_account_local_outbox_folder):
1265 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1266 * src/modest-tny-local-folders-account.c:
1267 (add_account_folders_to_merged_folder):
1268 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1269 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1270 (modest_ui_actions_on_send):
1271 * src/widgets/modest-folder-view.c: (update_model):
1272 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1273 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1274 modest_tny_account_store_get_tny_account_by_account() to
1275 modest_tny_account_store_get_server_account() to make the code clearer.
1277 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1279 * src/dbus_api/modest-dbus-api.h:
1280 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1281 * src/maemo/modest-msg-edit-window.c:
1282 (modest_msg_edit_window_attach_file_noninteractive):
1283 added g_warning in case the file to be attached does not exist
1284 * tests/dbus_api/test_compose_mail.c: (main):
1285 removed obsolete comment, added generic files as test case
1287 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1289 * src/modest-tny-account-store.c: (get_server_accounts):
1290 Create the local folders account only once, not once for each outbox, and
1291 not only when there are some outboxes.
1293 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1295 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1296 code that is causing a crash at startup. Sergio says that he is fixing this.
1298 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1300 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1301 * src/maemo/modest-account-settings-dialog.c:
1302 (create_page_outgoing),
1303 (modest_account_settings_dialog_set_account_name),
1304 (save_configuration):
1305 - Fixed handling of the "Use secure authentication" toggle to comply with
1306 the ui specification. See also projects.maemo.org bug NB#58400
1308 - Restore the Secure connection setting combo correctly when loading
1311 * src/maemo/modest-maemo-utils.c:
1312 (on_camel_account_get_supported_secure_authentication),
1313 (modest_maemo_utils_get_supported_secure_authentication_methods):
1314 Fixed a crasher if operation is canceled
1316 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1317 (modest_protocol_info_auth_is_secure):
1318 * src/modest-protocol-info.h:
1320 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1321 the sense of the "Use secure authentication" toggle.
1323 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1325 * src/modest-tny-account-store.h:
1326 * src/modest-tny-account-store.c:
1327 Added modest_tny_account_store_get_local_folders_account().
1329 * src/modest-tny-folder.h:
1330 * src/modest-tny-folder.c:
1331 (modest_tny_folder_get_account):
1332 Added this replacement for tny_folder_get_account() which returns
1333 the local-folders account for TnyMergeFolders, to avoid the
1334 warning about the unimplemented get_account_func() vfunc().
1336 (modest_tny_folder_get_rules),
1337 * src/modest-ui-actions.c:
1338 (modest_ui_actions_on_folder_selection_changed):
1339 * src/modest-mail-operation.c:
1340 (modest_mail_operation_remove_folder),
1341 (modest_mail_operation_xfer_folder),
1342 (modest_mail_operation_rename_folder),
1343 (modest_mail_operation_get_msg),
1344 (modest_mail_operation_get_msgs_full),
1345 (modest_mail_operation_remove_msg),
1346 (modest_mail_operation_xfer_msgs),
1347 (modest_mail_operation_refresh_folder):
1348 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1350 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1352 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1353 (modest_server_account_set_security):
1354 * src/modest-defs.h: Add comments explaining that our
1355 UI spec means TLS when it says Normal, so these do not look like errors.
1357 * src/modest-tny-account.c:
1358 (modest_tny_account_new_from_server_account): Use the new tinymail
1359 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1360 for TLS. This should fix projects.maemo.org bug NB#58460.
1362 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1364 * src/maemo/easysetup/modest-easysetup-wizard.c:
1365 (create_account): Correct the position of the gconf sanity check warning.
1366 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1367 of using the g_idle_add() hack, because this does not seem to be necessary
1368 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1369 caused by something other than maemo's gconf.
1370 This fixes projects.maemo.org bug #59022.
1372 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1374 * src/modest-account-mgr-helpers.c:
1375 (modest_account_mgr_get_default_account): Do not check that the account
1376 exists if there is no default account (NULL), to fix a runtime warning.
1378 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1380 * src/widgets/modest-folder-view.c: (update_model):
1381 Do not unref the treemodel before we have finished with it.
1382 This prevents a valgrind warning and an occasional crash at startup.
1384 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1386 * libmodest-dbus-client/libmodest-dbus-client.h:
1387 added libmodest_dbus_client_compose_mail()
1388 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1390 added functions needed for SendAsMail() functionality
1391 * src/maemo/modest-msg-edit-window.c:
1392 (modest_msg_edit_window_attach_file_noninteractive):
1393 non interactively attaching files to message edit window
1394 * src/widgets/modest-msg-edit-window.h:
1395 * tests/dbus_api/Makefile.am:
1396 added test_compose_mail.c
1397 * tests/dbus_api/test_compose_mail.c: (main):
1399 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1401 * src/modest-account-view.c:
1402 Fixed bug projects.maemo.org bug NB#59307
1404 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1406 * src/maemo/easysetup/modest-easysetup-wizard.c:
1407 (get_serverport_incoming), (on_before_next), (create_account):
1408 * src/maemo/modest-account-settings-dialog.c:
1409 (modest_account_settings_dialog_set_account_name):
1410 * src/maemo/modest-maemo-utils.c:
1411 (on_camel_account_get_supported_secure_authentication_status),
1412 (on_camel_account_get_supported_secure_authentication),
1413 (on_secure_auth_cancel),
1414 (modest_maemo_utils_get_supported_secure_authentication_methods):
1416 Implemented security authentication for settings and easysetup.
1418 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1420 * src/maemo/modest-main-window.c: (create_details_widget):
1421 Show the total size for memory card accounts too, instead of showing
1422 the name again. Fixes bug projects.maemo.org bug NB#59307.
1424 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1427 * src/modest-tny-simple-folder-store.c:
1428 * src/modest-tny-simple-folder-store.h: Removed.
1430 * src/modest-tny-local-folders-account.h
1431 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1432 for the local-folders maildir, with an extra TnyMergedFolder containing
1433 the folders of the per-account outbox store accounts.
1434 * src/modest-tny-account-store.c: (get_server_accounts):
1435 Add the outboxes to the special local folders account after creating it.
1437 * src/modest-tny-account.c:
1438 (modest_tny_account_new_for_local_folders): Create the derived
1439 account when creating the main local-folders account.
1441 * src/maemo/modest-main-window.c: (create_details_widget),
1442 (modest_main_window_set_contents_style):
1443 Adapted to the use of the derived account instead of the folder store.
1445 * src/modest-ui-actions.c:
1446 (modest_ui_actions_on_folder_selection_changed):
1447 * src/modest-ui-dimming-rules.c:
1448 (modest_ui_dimming_rules_on_new_folder):
1449 * src/widgets/modest-folder-view.c: (text_cell_data),
1450 (icon_cell_data), (filter_row), (update_model),
1451 (get_cmp_rows_type_pos):
1454 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1455 Do not get the priv struct, because no priv struct has been set,
1456 to avoid a runtime warning.
1458 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1459 #ifelse with #else, to fix a warning, to fix the build.
1462 2007-06-05 Christian Kellner <ckellner@openismus.com>
1464 * libmodest-dbus-client/libmodest-dbus-client.c:
1465 Fix small typo in doc (why do you always see them
1466 AFTER committing stuff?)
1469 2007-06-05 Christian Kellner <ckellner@openismus.com>
1471 * libmodest-dbus-client/libmodest-dbus-client.c:
1472 (libmodest_dbus_client_search):
1473 Initialize hit list with NULL. Also set folder list
1474 to "" if NULL was supplied.
1477 2007-06-03 Christian Kellner <ckellner@openismus.com>
1479 * libmodest-dbus-client/libmodest-dbus-client.c:
1480 (modest_search_hit_list_free):
1481 Make it save to call it with NULL.
1483 * src/dbus_api/modest-dbus-callbacks.c:
1484 * src/modest-search.c:
1485 Return full ModestSearchHits as the search result list not TnyHeader
1486 since can't be around withouth the correspoding TnyFolder.
1488 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1490 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1491 Added currently commented code to check for secure auth
1493 * src/maemo/modest-account-settings-dialog.c: (on_response),
1494 (save_configuration), (show_ok):
1495 Fixed projects.maemo.org bugs NB #59248 and #59251
1497 * src/maemo/modest-maemo-utils.c:
1498 (on_camel_account_get_supported_secure_authentication_status),
1499 (on_camel_account_get_supported_secure_authentication),
1500 (modest_maemo_utils_get_supported_secure_authentication_methods):
1501 * src/maemo/modest-maemo-utils.h:
1502 Moved get_supported_secure_authentication() method here to be able
1503 to use it from easysetup wizard.
1505 * src/modest-pair.c: (on_pair_compare_as_string):
1506 Should compare string with first part of pair and not
1507 strcmp pairs which will crash.
1509 * src/modest-protocol-info.c:
1510 (modest_protocol_info_protocol_is_store):
1511 * src/modest-protocol-info.h:
1512 Added modest_protocol_info_get_auth_protocol_name()
1514 2007-06-03 Armin Burgmeier <armin@openismus.com>
1516 * src/modest-mail-operation.c:
1517 (modest_mail_operation_get_msgs_full): Set priv->account also when
1518 only retrieving a single message. This avoids a crash when canceling
1521 (modest_mail_operation_notify_end): Do not explicitely remove the
1522 operation from the queue but only emit the progress_changed signal.
1523 The queue itself listens to that signal to remove the operation when
1524 it is finished. This reduces coupling and removes a potential deadlock
1525 when modest_mail_operation_notify_end() is called from the queue
1526 itself. If that is a problem performance-wise, I would suggest to
1527 implement a status-changed signal or something.
1529 * src/modest-mail-operation-queue.c: Make sure to never call a
1530 function from another file while the queue is locked. This (hopefully)
1531 fixes another deadlock when exiting the application while retrieving
1534 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1536 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1537 Fixed build if libogs is not available
1539 2007-06-03 Christian Kellner <ckellner@openismus.com>
1541 * libmodest-dbus-client/libmodest-dbus-client.h:
1542 * libmodest-dbus-client/libmodest-dbus-client.c:
1543 (libmodest_dbus_client_delete_message):
1544 Implement deletion of messages (Client side).
1546 (modest_search_hit_free),
1547 (modest_search_hit_list_free):
1548 Utility functions to free the result hits.
1550 * src/dbus_api/modest-dbus-api.h:
1551 * src/dbus_api/modest-dbus-callbacks.c:
1552 (on_delete_message),
1553 (modest_dbus_req_handler):
1554 Implement deletion of messages (Server side).
1556 * tests/dbus_api/test_search.c: (main):
1559 * tests/dbus_api/Makefile.am:
1560 * tests/dbus_api/test_delete_message:
1561 Add little test for the message deletion logic
1563 2007-06-03 Armin Burgmeier <armin@openismus.com>
1565 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1566 when the operation queue was not empty. projects.maemo.org bug
1569 2007-06-03 Armin Burgmeier <armin@openismus.com>
1571 * src/widgets/modest-account-view.c
1572 (on_account_default_toggled): Toggle default account column
1573 explicitely instead of waiting for gconf notification (which is
1574 currently ignored). This should fix projects.maemo.org bug NB#56910
1575 for now. It should probably be removed when gconf notifications are
1578 2007-06-03 Christian Kellner <ckellner@openismus.com>
1580 * libmodest-dbus-client/libmodest-dbus-client.c:
1581 Removed debugging spew.
1583 * src/dbus_api/modest-dbus-callbacks.c:
1584 Added debugging info.
1586 * src/modest-search.c:
1587 (modest_search_all_accounts):
1588 Use tny_account_store_get_accounts () on the account store
1589 to get all accounts which is the way to get all accounts.
1591 * tests/dbus_api/test_search.c: (main):
1592 Make it possible to supply the search term on the command line.
1594 2007-06-03 Christian Kellner <ckellner@openismus.com>
1596 * libmodest-dbus-client/libmodest-dbus-client.c:
1597 * libmodest-dbus-client/libmodest-dbus-client.h:
1598 Implement searching for mesages over raw dbus. (Client side)
1600 * src/dbus_api/Makefile.am:
1601 * src/dbus_api/modest-dbus-api.h:
1602 * src/dbus_api/modest-dbus-callbacks.c:
1603 * src/dbus_api/modest-dbus-callbacks.h:
1604 Search framework (Server side). Also implement on_idle_open_message().
1606 * src/maemo/modest-platform.c: (modest_platform_init):
1607 Prepare for raw dbus/osso rpc interaction.
1609 * src/modest-search.h:
1610 Changed minsize from unspecific guint to guint32.
1612 * src/modest-search.c:
1614 Added strange hack which magically made tnymail work.
1616 (modest_search_folder),
1617 (modest_search_account),
1618 (modest_search_all_accounts):
1619 Implement helper functions to search all accounts, specific account
1622 * tests/dbus_api/Makefile.am:
1623 * tests/dbus_api/test_open_message.c:
1624 Read url to open from commandline.
1626 * tests/dbus_api/test_search.c:
1627 Implement small test for dbus search stuff
1629 2007-06-02 Armin Burgmeier <armin@openismus.com>
1631 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1632 include account type and account title. This fixes projects.maemo.org
1635 * src/maemo/modest-account-view-window.c: Set a title for the window.
1637 2007-06-02 Armin Burgmeier <armin@openismus.com>
1639 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1640 incoming and outgoing server name based on email address and server
1641 types as long as the names have not been edited manually. This fixes
1642 projects.maemo.org bug NB#58671.
1644 2007-06-02 Armin Burgmeier <armin@openismus.com>
1646 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1647 server type cannot be changed in future to the incoming details page
1648 when creating an account. This fixes projects.maemo.org bug NB#59029.
1650 2007-06-02 Armin Burgmeier <armin@openismus.com>
1652 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1653 and assigned max width chars so that they wrap instead of being
1654 truncated. Fixes projects.maemo.org bug NB#56126.
1656 2007-06-02 Armin Burgmeier <armin@openismus.com>
1658 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1659 introductory note to the connection specific smtp servers dialog, as
1660 section 8.12 of the email UI specification requires. This fixes
1661 projects.maemo.org bug NB#59212.
1663 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1665 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1666 Check for running mail operations, and offer to cancel them, as per the UI
1667 spec. This fixes projects.maemo.org bug NB#59041 .
1668 However, I suspect that tinymail may still use the network connection
1669 in ways that we cannot detect or cancel. But it should at least adapt to
1670 changes fairly well.
1672 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1674 * src/modest-tny-account-store.c: (recreate_all_accounts),
1675 (get_cached_accounts), (get_server_accounts): Do more sensible
1676 ref-counting of the temporarily-cached outbox accounts list. This seems
1677 to fix a crash when entering the password when the password was wrong.
1679 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1681 * src/gnome/modest-main-window.c: (connect_signals):
1682 * src/modest-tny-account-store.c: (get_password),
1683 (modest_tny_account_store_alert): Added comments and clues and
1684 commented-out code about how we currently fail to deal with connection
1685 errors and wrong passwords, and how we should.
1687 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1689 * src/widgets/modest-retrieve-combo-box.c:
1690 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1691 This fixes projects.maemo.org bug NB#58472 .
1693 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1695 * src/maemo/easysetup/modest-easysetup-wizard.c:
1696 (create_page_complete_easysetup):
1697 (create_page_complete_custom): Correct the last commit,
1698 putting the correct sentences in the correct pages.
1700 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1702 * src/maemo/easysetup/modest-easysetup-wizard.c:
1703 (create_page_complete_custom): Show the second sentence of text
1704 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1707 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1709 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1710 Set the leave-on-server conf key by default. This fixes
1711 projects.maemo.org bug NB#59258 .
1713 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1715 * src/maemo/modest-account-view-window.c:
1716 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1717 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1720 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1722 * src/maemo/easysetup/modest-easysetup-wizard.c:
1723 (create_caption_new_with_asterisk):
1724 * src/maemo/modest-account-settings-dialog.c:
1725 (create_caption_new_with_asterisk):
1726 Uncomment the code to add the asterisk, because they are no longer in the
1727 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1728 (update_incoming_server_title): Add an asterisk here too.
1730 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1732 * src/maemo/modest-maemo-global-settings-dialog.c:
1733 (current_connection): Check that we are even connected before trying to
1734 get the current connection name, to prevent a warning.
1736 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1737 Change the comments because tny_maemo_conic_device_connect() is now meant to
1739 * src/modest-mail-operation.c:
1740 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1741 make sure we have a connection and fail if we can't connect.
1743 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1745 * src/maemo/modest-main-window.c:
1746 (on_account_store_connecting_finished): Do not try to get the
1747 connection ID if we are not really connected. I am surprised that
1748 this signal handler is called when we are not connected.
1750 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1752 * src/modest-error.h:
1753 * src/modest-ui-actions.c:
1754 (modest_ui_actions_get_msgs_full_error_handler):
1755 Renamed an enum, added comments, added an enum
1756 for retrieve-limit errors.
1758 * src/modest-mail-operation.c: (foreach_add_item),
1759 (internal_folder_observer_update), (update_account_thread),
1760 (modest_mail_operation_get_msgs_full):
1761 (modest_mail_operation_update_account),
1762 Added comments about how this works, and some code that should
1763 (but does not) check the retrieve-limit. See the TODO comment.
1765 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1767 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1768 Initialize help_id to fix the build. Warnings are good.
1770 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1772 * src/widgets/modest-hbox-cell-renderer.c:
1773 (modest_hbox_cell_renderer_append):
1774 * src/widgets/modest-vbox-cell-renderer.c:
1775 (modest_vbox_cell_renderer_append):
1776 Fix the last commit by doing an extra ref.
1778 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1780 * src/widgets/modest-hbox-cell-renderer.c:
1781 (modest_hbox_cell_renderer_append):
1782 * src/widgets/modest-vbox-cell-renderer.c:
1783 (modest_vbox_cell_renderer_append):
1784 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1785 to fix the build with Maemo Bora.
1786 However, there seems to be a remaining crash, probably due to reference
1789 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1791 * src/modest-tny-account.c:
1792 (modest_tny_account_new_for_local_folders):
1793 Use hildon_file_system_info_async_new() to get a better name for
1794 the memory card account, setting it as the account name.
1795 The timing seems to work, but this is probably
1796 not the best place to do this. See the TODO comment.
1797 * src/maemo/modest-main-window.c: (create_details_widget):
1798 * src/widgets/modest-folder-view.c: (text_cell_data):
1799 Use the tny account name instead of hardcoding a name.
1801 2007-05-30 Christian Kellner <ckellner@openismus.com>
1803 * src/modest-search.c: (modest_search):
1804 Correctly set part_search_func even if we have already parsed
1805 the query and thus a valid OgsTextSearcher object.
1807 2007-05-30 Christian Kellner <ckellner@openismus.com>
1810 Search and check for libogs.
1813 Incooparte the ogs build env.
1815 * src/modest-mime-part-search-stream.c:
1816 * src/modest-mime-part-search-stream.h:
1817 Removed since we do the real searching now in modest-search.c.
1819 * src/modest-search.c:
1820 * src/modest-search.h:
1821 Implement support for ogs. We use that if available and requested
1822 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1823 should now handle the corner case when the search term is spread
1824 across multiple reads.
1825 Also the logic in modest_search () was corrected to search all
1826 requested fields until one is found.
1828 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1830 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1832 * src/modest-init.h:
1833 * src/modest-init.c: Made modest_init_local_folders() take a
1834 path and be public so we can iniitialize maildir folders on
1837 * src/modest-local-folder-info.h:
1838 * src/modest-local-folder-info.c:
1839 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1841 * src/modest-tny-account.c:
1842 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1843 still means the standard local-folders path on the local volume.
1845 * src/modest-tny-account-store.c:
1846 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1847 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1848 all accounts when that happens.
1849 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1850 this too, so it shows up in the treeview.
1852 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1854 * src/maemo/modest-maemo-global-settings-dialog.c:
1855 (current_connection):
1856 * src/widgets/modest-global-settings-dialog.c:
1857 (current_connection_default):
1858 Use the enum values instead of 0, 1 and -1,
1859 to make the code clearer.
1861 * src/modest-account-mgr-helpers.c:
1862 (modest_account_mgr_get_connection_specific_smtp): Make this code
1865 * src/modest-runtime.h:
1866 * src/modest-runtime.c:
1867 Added modest_runtime_remove_all_send_queues().
1868 * src/maemo/modest-main-window.c:
1869 (on_account_store_connecting_finished): Recreate the send queues,
1870 using the appropriate transport accounts for this new connection.
1871 Some futher adapting might be needed if the old send queues are not
1872 automatically stopped at this point.
1874 * src/modest-tny-account-store.c: (get_server_accounts):
1875 Create the connection-specific transport accounts, so that they can
1876 be found later by their ID.
1878 * src/modest-tny-account.h:
1879 * src/modest-tny-account.c:
1880 Added modest_tny_account_new_from_server_account_name().
1881 modest_tny_account_new_from_server_account(): Do not create the
1882 send queues here, because they will be
1883 recreated anyway when the connection changes for the first time.
1885 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1887 * src/modest-local-folder-info.h:
1888 * src/modest-local-folder-info.c:
1889 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1890 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1891 tbox_folder): Take a modest account name instead of a server TnyAccount,
1892 so we can have per-modest-account rather than per-transport-account
1894 We must make sure that we change or recreate the exisitng send queues
1895 when the connection changes for connection-specific transport accounts.
1897 * src/modest-tny-account-store.c:
1898 (create_per_account_local_outbox_folders): Create outboxed per modest
1899 account, not per transport account.
1901 * src/modest-tny-account.h:
1902 * src/modest-tny-account.c:
1903 (modest_tny_account_get_special_folder): For outboxes, get the
1904 parent modest account name. The account is ignored for other folders.
1905 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1906 modest account name rather than a server TnyAccount.
1908 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1910 * src/modest-tny-account.c:
1911 (modest_tny_account_new_from_server_account):
1912 Call modest_runtime_get_send_queue() immediately after creating transport
1913 accounts, so that they start trying to send email from the outbox as soon
1914 as possible at startup. This is probably what we want.
1916 * src/modest-mail-operation.c: (update_account_thread):
1917 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1918 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1919 * src/modest-tny-send-queue.h:
1920 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1921 (modest_ui_actions_on_send):
1922 Added comments about how sending works, though it needs some more work.
1924 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1926 * src/modest-tny-account.c:
1927 (modest_tny_account_get_special_folder): Add TODO because this fails when
1928 the network is busy.
1929 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1930 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1931 Do not try to show this window when there is no active account. The UI
1932 specs does not tell us what to do in this case.
1934 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1938 * src/maemo/Makefile.am:
1939 * src/widgets/Makefile.am: Some dist fixes.
1941 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1943 * src/maemo/modest-connection-specific-smtp-window.c:
1944 (on_button_edit): Make the code clearer, to prevent a double free.
1946 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1948 * src/maemo/modest-account-settings-dialog.c:
1949 (modest_account_settings_dialog_set_account_name),
1950 Check the connection-specific smtp servers checkbox if there are any.
1952 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1953 (modest_connection_specific_smtp_edit_window_init):
1954 Start with a suitable port number.
1956 * src/modest-account-mgr-helpers.h:
1957 * src/modest-account-mgr-helpers.c: Added
1958 modest_account_mgr_get_has_connection_specific_smtp().
1960 (modest_account_mgr_set_connection_specific_smtp),
1961 (modest_account_mgr_remove_connection_specific_smtp),
1962 (modest_account_mgr_get_has_connection_specific_smtp),
1963 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1964 connection-specific smtp server accounts in the account, rather than
1965 the server account conf dir.
1967 This fixes bug projects.maemo.org bug NB#58263 .
1969 * src/modest-tny-account-store.c:
1970 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1971 if there are no server accounts yet, to prevent an infinite loop when there
1972 are no accounts. Document that one must be called before the other.
1974 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1976 * src/modest-account-mgr-helpers.c:
1977 (modest_account_mgr_get_default_account): Make sure that at least
1978 one account is always the default, if there are any enabled accounts.
1979 This is just a sanity check that shouldn't be necessary.
1981 * src/modest-account-mgr-priv.c:
1982 (_modest_account_mgr_account_from_key): Unescape the conf key to
1983 get the real account name. For instance, this is an issue if a space
1984 was in the account name, which can happen because the account name
1985 is generated from the display name.
1986 (_modest_account_mgr_get_account_keyname): Always escape the
1988 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1989 Unescape the conf keys to get the real account names.
1991 For instance, previously the is-default radio button in the accounts
1992 list was not checked for any accounts at first. This fixes that,
1993 and might fix several similar bugs.
1995 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1997 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1998 Removed some debug printfs.
2000 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2002 Modest on-disk outbox directories are now here, for instance:
2003 $HOME/.modest/outboxes/<account-id-1>/outbox
2004 $HOME/.modest/outboxes/<account-id-2>/outbox
2006 $HOME/.modest/local-folders/outbox
2007 so we can have a separate outbox for each account.
2008 But they are shown as one outbox in the GtkTreeView, by using a
2009 TnyMergeFolder in a ModestTnySimpleFolderStore.
2012 * src/modest-tny-simple-folder-store.c:
2013 * src/modest-tny-simple-folder-store.h:
2014 Added ModestTnySimpleFolderStore, used to contain folders from
2015 other folder stores, such as other accounts.
2017 * src/modest-tny-outbox-account.h:
2018 * src/modest-tny-outbox-account.c:
2019 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2020 used for the per-account local outbox folders.
2022 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2023 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2024 only use this (internally) now for the non-outbox local folders.
2026 * src/modest-init.h:
2027 * src/modest-init.c: Added modest_init_one_local_folder(), for
2028 setting up the directory structure for each local folder.
2030 * src/modest-local-folder-info.c:
2031 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2032 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2034 * src/modest-local-folder-info.h:
2035 * src/modest-tny-account-store.c: (on_account_removed),
2036 (on_account_changed), (create_per_account_local_outbox_folders),
2037 (get_server_accounts), (modest_tny_account_store_get_accounts),
2038 (modest_tny_account_store_get_tny_account_by_account),
2039 (modest_tny_folder_store_is_virtual_local_folders):
2041 * src/modest-tny-account.h:
2042 * src/modest-tny-account.c:
2043 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2044 to create an on-disk per-account local outbox folder for each
2046 (create_per_account_local_outbox_folders): Create a local outbox folder
2047 for each transport account.
2048 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2049 for all local folders.
2051 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2052 instead of using g_object_get/set() directly. It is clearer.
2054 (modest_tny_folder_store_get_message_count),
2055 (modest_tny_folder_store_get_local_size
2056 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2057 because we now use these with non-acount folder stores.
2059 (modest_tny_account_get_special_folder),
2060 (modest_tny_account_new_from_server_account),
2061 (modest_tny_account_new_from_account):
2062 (recurse_folders): Adjust to the new outbox system.
2064 * src/modest-tny-folder.h:
2065 * src/modest-tny-folder.c:
2066 (modest_tny_folder_is_local_folder),
2067 (modest_tny_folder_get_local_folder_type),
2068 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2070 * src/widgets/modest-main-window.h:
2071 * src/maemo/modest-main-window.c: (create_details_widget),
2072 (modest_main_window_set_contents_style): Show details for any folder store,
2075 (modest_tny_folder_get_rules):
2076 Remove the const. C does not support constness enough for this.
2078 * src/modest-ui-actions.c:
2079 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2080 make all outboxes appear as one, in the usual local-folders tree node.
2082 (set_active_account_from_tny_account),
2083 (modest_ui_actions_on_folder_selection_changed):
2084 * src/widgets/modest-folder-view.c: (text_cell_data),
2085 (icon_cell_data), (filter_row),
2086 (add_account_folders_to_merged_folder),
2087 (add_account_folders_to_simple_folder_store), (),
2088 (get_cmp_rows_type_pos), (cmp_rows),
2089 (modest_folder_view_set_account_id_of_visible_server_account):
2090 Adjust to the new outbox system, using generic folder stores and folders
2091 in the GtkTreeModel.
2093 2007-05-23 Christian Kellner <ckellner@openismus.com>
2095 * src/modest-mail-operation.c:
2096 (modest_mail_operation_update_account):
2097 Use info->max_size instead of unintialized local var [small
2098 build fix]. (Added TODO to review that change since I don't
2101 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2103 * libmodest-dbus-client/libmodest-dbus-client.c:
2104 (libmodest_dbus_client_compose_mail): function added
2105 * src/dbus_api/modest-dbus-api.h:
2106 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2107 (on_compose_mail): Implementation of the SendAsMail functionality
2109 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2111 * src/modest-account-mgr.c:
2112 (modest_account_mgr_add_server_account): Set the secure-connection
2113 conf key for transport accounts as well as store accounts. I don't know
2114 why the if was there. For instance, this makes sure that we use SSL
2115 for the gmail preset from the easysetup wizard.
2117 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2119 * src/gnome/modest-main-window.c:
2120 (on_account_store_connecting_finished), (connect_signals):
2121 * src/maemo/modest-main-window.c:
2122 (on_account_store_connecting_finished), (connect_signals),
2123 (modest_main_window_new):
2124 Handle TnyAccountStore::connecting-finished instead of
2125 TnyDevice::connection-changed, because we cannot actually perform
2126 operations on accounts until TnyAccountStore has itself responded to
2127 the TnyDevice::connection-changed signal. This prevents a GError from
2129 Do not try to update at startup, because we (at least on scratchbox)
2130 already do an update at startup when the device goes online.
2131 This prevents a GError from tinymail.
2132 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2133 Added TODO about stopping simultaneous operations.
2135 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2137 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2138 * src/modest-mail-operation-queue.c:
2139 (modest_mail_operation_queue_remove):
2140 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2141 about where they happened.
2143 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2145 * src/modest-ui-actions.c:
2146 (modest_ui_actions_on_password_requested): Make sure that the remember
2147 output parameter is always TRUE.
2149 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2151 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2152 Show a OK/Cancel dialog if the error is a question, though we still do not
2153 know anything more about what we are asking the user.
2154 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2155 Fix an uninitialized variable (helper). This is a logic error, however.
2157 2007-05-21 Christian Kellner <ckellner@openismus.com>
2159 * src/modest-search.h:
2160 Correct bit shifting in the ModestSearchFlags enum.
2162 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2164 * src/modest-tny-account.c:
2165 (modest_tny_account_new_from_server_account): Do not use the lsub and
2166 check-all hard-coded IMAP options when using POP.
2168 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2170 * src/modest-tny-account.c:
2171 (modest_tny_account_new_from_server_account):
2172 Use NULL for the secure-auth method for POP when Password auth has been
2173 specified by the user, as we already do for IMAP. "auth=Login" causes
2174 an error from camel or the server.
2176 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2178 * src/maemo/modest-account-settings-dialog.c:
2179 (create_page_account_details),
2180 (modest_account_settings_dialog_set_account_name):
2181 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2182 for the leave-on-server checkbox, rathr than just the checkbox, when
2183 the protocol is not POP.
2185 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2187 * src/widgets/modest-account-view.c:
2188 * src/widgets/modest-account-view.h:
2189 Added modest_account_view_select_account() which will be useful later
2190 to asynchronously re-select the edited account.
2192 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2194 * src/maemo/modest-account-settings-dialog.c:
2195 (modest_account_settings_dialog_set_account_name):
2196 Automatically choose the port numbers based on the secure authentication
2197 methods, if they have not been chosen before.
2198 This fixes projects.maemo.org bug NB#56273 .
2200 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2202 * src/maemo/modest-main-window-ui.h:
2203 * src/modest-ui-actions.c:
2204 * src/modest-ui-actions.h:
2205 Connect the Tools/SMTP Servers menu item to
2206 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2207 SMTP servers dialog, as in the UI specification and saves changes when it
2208 is closed. This fixed projects.maemo.org bug NB#56305 .
2210 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2212 * src/maemo/modest-connection-specific-smtp-window.c:
2213 (modest_connection_specific_smtp_window_init):
2214 Use gtk_window_set_default_size() to make this window big enough, so
2215 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2217 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2219 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2220 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2221 (modest_connection_specific_smtp_edit_window_init),
2222 Do not try to connect to a combobox signal before the combobox exists.
2223 This fixes the cras in projects.maemo.org bug NB#56288 .
2224 (modest_connection_specific_smtp_edit_window_get_settings):
2225 Remove the server_account_name parameter which was being checked for NULL
2226 though it was not used.
2228 * src/maemo/modest-connection-specific-smtp-window.c:
2229 (modest_connection_specific_smtp_window_fill_with_connections),
2230 (on_button_edit), (modest_connection_specific_smtp_window_init):
2231 Correct the number of treemodel columns to prevent a warning.
2232 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2233 libconic does not work.
2235 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2237 * src/modest-tny-account.c:
2238 (modest_tny_account_new_from_server_account):
2239 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2240 SMTP when "None" was chosen by the user. However, with my SMTP server that
2241 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2244 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2246 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2247 to explain the memory management issue with the ID in the ModestPair.
2249 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2250 (add_sending_page), (modest_account_assistant_finalize):
2251 * src/gnome/modest-gnome-global-settings-dialog.c:
2252 (create_updating_page), (create_composing_page):
2253 * src/gnome/modest-msg-edit-window.c: (get_transports),
2254 (init_window), (modest_msg_edit_window_finalize),
2255 (modest_msg_edit_window_get_msg_data):
2256 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2257 * src/gnome/modest-transport-widget.c:
2258 (modest_transport_widget_finalize), (smtp_configuration):
2259 * src/maemo/modest-maemo-global-settings-dialog.c:
2260 (create_updating_page), (create_composing_page):
2261 * src/maemo/modest-msg-edit-window.c: (get_transports),
2262 (init_window), (modest_msg_edit_window_finalize),
2263 (modest_msg_edit_window_get_msg_data),
2264 (modest_msg_edit_window_free_msg_data):
2265 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2266 (modest_store_widget_finalize):
2267 * src/maemo/modest-transport-widget.c:
2268 (modest_transport_widget_finalize), (smtp_configuration):
2269 * src/modest-main.c: (send_mail):
2270 * src/widgets/modest-combo-box.h:
2271 * src/widgets/modest-global-settings-dialog-priv.h:
2272 * src/widgets/modest-global-settings-dialog.c:
2273 (modest_global_settings_dialog_finalize):
2274 * src/widgets/modest-msg-edit-window.h:
2275 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2276 as long as the combo box, to prevent use of freed memory for the ID.
2278 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2280 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2281 get_accounts(), to make this clearer. Do not check for the enabled gconf
2282 key, because we do not use this for server accounts (at least, not yet).
2283 This allows us to send email again.
2285 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2287 * src/maemo/modest-platform.c:
2288 (on_modest_conf_update_interval_changed), (modest_platform_init):
2289 Only respond to this particular key change. All these strcmp()s cannot be
2292 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2294 * src/maemo/modest-maemo-global-settings-dialog.c:
2295 (current_connection): Prevent a crash in scratchbox when
2296 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2297 * src/maemo/modest-platform.c:
2298 (on_modest_conf_update_interval_changed), (modest_platform_init):
2299 Get the update interval from gconf and reset it when the gconf key changes.
2301 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2303 * src/modest-protocol-info.c:
2304 * src/modest-protocol-info.h: Adde enum-specific get functions,
2305 instead of using a ModestProtocolType enum parameter.
2307 * src/gnome/modest-account-assistant.c:
2308 * src/gnome/modest-store-widget.c:
2309 * src/gnome/modest-store-widget.h:
2310 * src/gnome/modest-transport-widget.c:
2311 * src/gnome/modest-transport-widget.h:
2312 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2313 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2314 * src/maemo/easysetup/modest-easysetup-wizard.c:
2315 * src/maemo/modest-account-settings-dialog.c:
2316 * src/maemo/modest-account-settings-dialog.h:
2317 * src/maemo/modest-store-widget.c:
2318 * src/maemo/modest-store-widget.h:
2319 * src/maemo/modest-transport-widget.c:
2320 * src/maemo/modest-transport-widget.h:
2321 * src/modest-account-mgr-helpers.c:
2322 * src/modest-account-mgr-helpers.h:
2323 * src/modest-account-mgr.c:
2324 * src/modest-account-mgr.h:
2325 * src/modest-tny-account.c:
2326 * src/modest-tny-folder.c:
2327 * src/widgets/modest-account-view.c:
2328 * src/widgets/modest-retrieve-combo-box.c:
2329 * src/widgets/modest-retrieve-combo-box.h:
2330 * src/widgets/modest-secureauth-combo-box.c:
2331 * src/widgets/modest-serversecurity-combo-box.c:
2332 * src/widgets/modest-serversecurity-combo-box.h:
2333 * tests/check_account-mgr.c:
2334 Use the specific functions, and use the re-renamed enum values for GNOME too.
2336 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2338 * src/modest-pair.h:
2339 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2340 so we can get the second based on the first.
2342 * src/maemo/modest-account-settings-dialog.h:
2343 * src/maemo/modest-account-settings-dialog.c:
2344 Added get_supported_secure_authentication_methods(), though it is mostly
2345 commented-out for now until the necessary API is committed to tinymail.
2346 (modest_account_settings_dialog_set_account_name),
2347 (save_configuration): Request the supported authentication methods from the
2348 server, so we can choose a working method.
2350 * src/modest-tny-account-store.h:
2351 * src/modest-tny-account-store.c:
2352 (modest_tny_account_store_get_session): Rename from
2353 tny_account_store_get_session().
2355 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2357 * src/modest-protocol-info.h: Split the ModestProtocol enum
2358 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2359 There was no need to have these unrelated values in one enum.
2361 * src/: many files: Adapted to changed enum. This makes the code a bit
2362 clearer, and the compiler could catch some errors.
2364 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2366 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2367 Show the detailed internal camel error message when an error happens
2368 during the configuration, so that our testers can give us more clues.
2369 For instance, in projects.maemo.org bug NB#56910 .
2371 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2373 * src/modest-tny-account.c:
2374 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2375 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2377 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2379 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2380 * src/maemo/modest-account-settings-dialog.c:
2381 (modest_account_settings_dialog_set_account_name),
2382 (save_configuration): For the incoming secure authentication checkbox,
2383 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2384 the UI specification. PLAIN does not seem to be supported for most IMAP
2385 servers anyway, and I am not sure what it would mean.
2386 However, we probably need to discover which of the secure-authentication
2387 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2388 * src/modest-account-mgr-helpers.c:
2389 (modest_account_mgr_get_server_account_data):
2391 * src/modest-tny-account.c:
2392 (modest_tny_account_new_from_server_account):
2393 Use tny_account_set_mech() to set secure-authentication methods,
2394 with some special-casing for IMAP, based on my observations of how
2397 * src/modest-account-mgr-helpers.h:
2398 * src/modest-account-mgr.c:
2399 * src/modest-defs.h: Comment that the URI is only used for local folders.
2401 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2403 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2404 parameter const, just to be neat.
2405 * src/modest-text-utils.c: (modest_text_utils_inline):
2406 End g_strconcat() with NULL, as its documentation says. This is almost
2407 certainly the cause of my crash at startup on the device. Interestingly,
2408 valgrind doesn't tell us about these errors.
2410 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2412 * scripts/build-packages: Added more precise comments about how to use
2413 this script, though I still get this error:
2414 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2415 error building tinymail
2417 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2419 * src/maemo/modest-main-window.c: (on_account_update):
2420 Very slight cleanup, hoping to make it simpler to discover what causes
2421 a crash here sometimes.
2423 * src/modest-tny-account.c:
2424 (modest_tny_account_new_from_server_account): Set the port. Added
2425 comments about the options and a TODO comment because I need to find out
2426 how to specify the secure authentication method.
2428 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2430 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2431 changed CFlags paths form modest to libmodest
2433 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2435 * src/modest-account-mgr-helpers.c:
2436 (modest_account_mgr_get_server_account_data),
2437 (modest_account_mgr_free_server_account_data):
2438 * src/modest-account-mgr-helpers.h:
2439 * src/modest-account-mgr.c:
2440 (modest_account_mgr_add_server_account):
2441 * src/modest-defs.h:
2442 * src/modest-tny-account.c:
2443 (modest_tny_account_new_from_server_account):
2444 Determine the options for tny_camel_account_add_option() here,
2445 based on the settings, rather than storing them directly in gconf.
2447 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2449 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2450 Show a more friendly error dialog now that we expect (from the tinymail
2451 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2453 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2455 * src/maemo/modest-main-window.c: (on_account_update): Check that
2456 account_name is not NULL, to prevent a crash at startup that I am
2457 seeing on the N800. I do wonder why it is NULL.
2459 * src/maemo/easysetup/modest-easysetup-wizard.c:
2460 (create_page_user_details):
2461 * src/maemo/modest-account-settings-dialog.c:
2462 (create_page_user_details), (create_page_outgoing):
2463 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2464 (modest_connection_specific_smtp_edit_window_init):
2465 * src/modest-ui-actions.c:
2466 (modest_ui_actions_on_password_requested):
2467 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2468 might do something useful with the on-screen keyboard.
2470 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2472 * src/maemo/modest-main-window.c: (on_account_update):
2473 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2474 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2476 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2478 * src/modest-tny-account-store.c: (on_account_changed):
2479 Correct the signature of this signal handler.
2481 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2483 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2484 Show a HildonNote instead of a GtkDialog for Maemo.
2486 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2488 * src/widgets/modest-account-view.h:
2489 * src/widgets/modest-account-view.c: (on_account_changed),
2490 (on_account_removed). Added a boolean flag, set/unset by
2491 modest_account_view_block_conf_updates(),
2492 modest_account_view_unblock_conf_updates() to prevent unnecessary
2493 updates, but this is not very useful because the gconf notifications are
2494 so delays (maybe only on Maemo Bora).
2495 So auto-updating is turned off, and these functions do an explicit
2496 update when necessary.
2497 However, something else is still doing too much work when adding/removing
2498 accounts, probably in another part of the application.
2500 * src/maemo/modest-account-view-window.c:
2501 (on_delete_button_clicked), (on_edit_button_clicked),
2502 (on_new_button_clicked): Use the new functions.
2504 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2506 * src/modest-account-mgr-helpers.c:
2507 (modest_account_mgr_set_first_account_as_default):
2508 Sort the list of names alphabetically-by-title, so we choose the first one
2510 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2511 alphabetically by the title.
2513 This fixes projects.maemo.org bug NB#56418 .
2515 * src/modest-account-mgr-priv.c:
2516 (_modest_account_mgr_account_from_key):
2517 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2518 avoid a valgrind error, and possible random behaviour.
2520 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2522 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2523 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2524 tinymail documentation to say that this can be expected.
2525 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2526 pretty, and should not happen, but I would prefer to know when it does.
2528 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2530 * configure.ac: When using the older hildon version, probably on Bora,
2531 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2533 * src/widgets/modest-attachment-view.c:
2534 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2537 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2539 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2540 Implemented the prototype. Can be tested with
2541 tests/dbus_api/test_open_message:
2543 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2545 * src/modest-tny-account-store.c:
2546 (modest_tny_account_store_instance_init), (get_password):
2547 * src/modest-ui-actions.c:
2548 (modest_ui_actions_on_password_requested):
2549 Do not store the password in gconf, because this function is called
2550 for non-remembered passwords. Actually use the cached (in the hash map)
2551 password instead of releasing it.
2552 The password will now not be remembered if it is asked via the protected
2553 password dialog, as per the UI spec.
2555 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2557 * src/modest-defs.h:
2558 * src/modest-account-mgr-helpers.h:
2559 * src/modest-account-mgr-helpers.c:
2560 Added modest_server_account_get_username_has_succeeded(),
2561 modest_server_account_set_username_has_succeeded().
2562 (modest_server_account_set_username),
2563 Reset the has-succeeded flag if the username changes.
2565 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2566 * src/maemo/modest-connection-specific-smtp-window.c:
2567 (modest_connection_specific_smtp_window_save_server_accounts):
2568 Use modest_server_account_set_username() instead of using
2569 modest_conf_set_string() directly, so that the has-succeeded flag is always
2572 * src/modest-ui-actions.c:
2573 (modest_ui_actions_on_password_requested): Dim the username entry if
2574 the username has ever worked, as per the UI spec.
2576 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2578 * src/modest-tny-account-store.c: (get_password):
2579 * src/modest-ui-actions.c:
2580 (modest_ui_actions_on_password_requested):
2581 Allow the username to be changed too, though there is more work to
2582 be done on exactly how this behaves.
2584 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2586 * src/modest-account-mgr-helpers.h:
2587 * src/modest-account-mgr-helpers.c:
2588 Added modest_account_mgr_get_display_name(),
2589 modest_server_account_get_username(),
2590 modest_server_account_set_username(),
2591 modest_server_account_set_password(),
2592 modest_server_account_get_hostname() functions so we do not need to
2593 use the conf API directly.
2595 * src/maemo/modest-main-window.c: (connect_signals):
2596 Actually connect ot the ModestAccountStore::request-password signal,
2597 so that we show the dialog when the password is requested by Tinymail,
2598 for isntance if it is empty.
2600 * src/modest-marshal.list:
2601 * src/modest-tny-account-store.c:
2602 (modest_tny_account_store_class_init), (get_password),
2603 (modest_tny_account_store_alert):
2604 * src/modest-tny-account-store.h:
2605 * src/modest-ui-actions.h:
2606 * src/modest-ui-actions.c:
2607 (modest_ui_actions_on_password_requested):
2608 Change the signal parameters, so it is obvious that we are providing
2609 the non human-readable server name, and receiving both the username
2610 and password, though changing of the username is not yet implemented.
2611 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2612 for the GNOME version.
2614 This should fix the projects.maemo.org bug NB#56209, though it does not
2615 work on Bora, because the gconf_client_get() for the password fails
2616 immediately after we save it with gconf_client_set().
2618 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2621 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2622 caused an undefined symbol error:
2623 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2625 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2627 * src/modest-tny-account-store.c:
2628 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2629 using a GError instead of a string message, so we can translate it in
2632 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2634 * src/maemo/modest-address-book.c:
2635 (modest_address_book_check_names):
2636 * src/maemo/modest-msg-view-window.c:
2637 (modest_msg_view_window_clipboard_owner_change):
2638 * src/modest-init.c: (modest_init_init_ui):
2639 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2640 (update_folders_cb), (modest_mail_operation_update_account):
2641 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2642 (modest_ui_actions_on_msg_attachment_clicked),
2643 (modest_ui_actions_on_msg_recpt_activated):
2644 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2645 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2646 (modest_msg_view_search_next):
2647 * src/widgets/modest-recpt-editor.c:
2648 (modest_recpt_editor_on_button_release_event),
2649 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2650 g_message(). At this point we should only be seeing interesting errors on
2651 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2653 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2655 (modest_wizard_dialog_force_title_update):
2656 * src/maemo/easysetup/modest-wizard-dialog.h:
2657 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2658 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2659 can update the title when appropriate. Otherwise the title is wrong if the
2660 pages are added after adding the notebook to the dialog.
2661 This must be a problem in HildonWizardDialog too.
2662 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2664 * src/maemo/easysetup/modest-easysetup-wizard.c:
2665 (create_subsequent_customsetup_pages),
2666 (create_subsequent_easysetup_pages):
2667 Call modest_wizard_dialog_force_title_update() so that the title is
2668 correct even with GTK+ < 2.10.
2669 This fixes projects.maemo.org bug NB#56145 .
2671 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2673 * src/maemo/modest-platform.c:
2674 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2675 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2678 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2680 * src/widgets/modest-window.h:
2681 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2682 and modest_window_save_state(), which invokes it.
2684 * src/widgets/modest-window-mgr.h:
2685 * src/widgets/modest-window-mgr.c:
2686 Added modest_window_mgr_save_state_for_all_windows(), which calls
2687 the save_state vfunc on all registered windows, if implemented.
2689 * src/gnome/modest-msg-edit-window.c:
2690 * src/gnome/modest-msg-view-window.c:
2691 * src/maemo/modest-msg-edit-window.c:
2692 * src/maemo/modest-msg-view-window.c:
2693 * src/maemo/modest-main-window.c:
2694 Specify the existing save_settings functions as implementations of
2695 ModestWindow::save_state_func().
2697 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2698 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2699 enabling hibernation, for instance.
2701 We may need to do the same thing for restoring settings.
2704 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2706 * src/widgets/modest-window-mgr.c:
2707 * src/widgets/modest-window-mgr.h:
2708 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2709 modest_window_mgr_get_hibernation_is_prevented().
2711 * src/maemo/modest-main-window.c:
2712 (on_hildon_program_is_topmost_notify): Prevent hibernation
2713 (possible when the application goes to the background in the WM),
2714 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2716 * src/maemo/easysetup/modest-easysetup-wizard.c:
2717 (modest_easysetup_wizard_dialog_init):
2718 * src/maemo/modest-account-settings-dialog.c:
2719 (modest_account_settings_dialog_init):
2720 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2721 (modest_connection_specific_smtp_edit_window_init):
2722 * src/maemo/modest-connection-specific-smtp-window.c:
2723 (modest_connection_specific_smtp_window_init):
2724 * src/maemo/modest-signature-editor-dialog.c:
2725 (modest_signature_editor_dialog_init):
2726 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2727 prevent hibernation while any of these account settings dialogs are open.
2729 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2731 * src/maemo/Makefile.am:
2732 * src/maemo/modest-osso-state-saving.c:
2733 * src/maemo/modest-osso-state-saving.h: Added
2734 modest_osso_load_state() and modest_osso_save_state() though they do
2735 nothing now. They should iterate through all the open windows and load/save
2737 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2738 save state when closing.
2740 * src/maemo/modest-main-window.c:
2741 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2742 Add a notification handler for the HildonProgram::is-topmost property,
2743 so we can allow hibernation when the application goes into the background.
2744 But we still need to detect when the accounts setup windows are open so
2745 we can stop hibernation when they are open.
2746 To do this, I also added the main window the HildonProgram. This might have
2747 other side-effects/benefits, and should maybe be done for other windows.
2749 * src/maemo/modest-osso-autosave-callbacks.h:
2750 * src/maemo/modest-osso-autosave-callbacks.c:
2751 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2752 though it does not do anything yet, and we might never need this to do
2753 anything. For instance, we already save drafts.
2755 * src/maemo/modest-platform.c: (modest_platform_init):
2756 Specify the libosso auto-save callback.
2758 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2760 * src/maemo/modest-platform.c:
2761 (modest_platform_set_update_interval):
2762 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2763 aparently stays valid between application instances, so we can use this
2764 to remove and reset it later. According to a maemo-developers email from
2767 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2769 * configure.ac: Depend on libalarm for Maemo.
2771 * src/dbus_api/modest-dbus-api.h:
2772 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2773 (on_send_receive), (modest_dbus_req_handler):
2774 Handle a SEND_RECEIVE D-Bus method.
2776 * libmodest-dbus-client/libmodest-dbus-client.c:
2777 (libmodest_dbus_client_send_and_receive):
2778 * libmodest-dbus-client/libmodest-dbus-client.h:
2779 Add C convenience functions for calling the new D-Bus method.
2781 * src/modest-platform.h:
2782 * src/gnome/modest-platform.c:
2783 * src/maemo/modest-platform.c:
2784 Added modest_platform_set_update_interval(), which uses the
2785 alarmd API on Maemo.
2786 (modest_platform_init),
2787 Call modest_platform_set_update_interval(), using a hard-coded
2788 interval for now (until the global settings dialog is implemented),
2789 though I am not sure that this makes sense yet.
2791 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2793 * src/dbus_api/modest-dbus-callbacks.c:
2794 (modest_osso_cb_hw_state_handler):
2795 * src/dbus_api/modest-dbus-callbacks.h:
2796 * src/maemo/modest-platform.c: (modest_platform_init):
2797 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2798 in case this has some effect on the ability for Maemo to ping the
2801 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2803 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2804 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2805 warning. It is probably a logic error, but I need to fix the build.
2807 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2809 * src/modest-account-mgr.h:
2810 * src/modest-account-mgr.c:
2811 (modest_account_mgr_account_names): Add a gboolean enabled_only
2812 parameter, so we can get lists of onlt the enabled accounts.
2814 (modest_account_mgr_add_account),,
2815 (modest_account_mgr_account_with_display_name_exists):
2816 * src/maemo/modest-msg-edit-window.c: (get_transports):
2817 * src/modest-account-mgr-helpers.c:
2818 (modest_account_mgr_set_first_account_as_default):
2819 * src/modest-init.c: (init_default_account_maybe):
2820 * src/modest-tny-account-store.c: (get_accounts):
2821 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2822 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2823 * tests/check_account-mgr.c: (START_TEST):
2824 Provide the extra parameter, as appropriate.
2826 * src/widgets/modest-account-view.c: (update_account_view):
2827 Do not show disabled accounts (meaning that there is no way to
2828 enable/disable accounts in the UI (the feature is not in our UI
2829 specification), so we can use this internally only to mark unfinished
2830 or temporary account data.
2832 * src/maemo/easysetup/modest-easysetup-wizard.c:
2833 (create_account): Add boolean enable parameter, so we can specify FALSE
2834 to create the temporary account.
2835 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2836 (on_before_next): When finishing, when there is a temporary account, just
2838 Also, use a timeout to delay the showing of the dialog until gconf is likely
2839 to return correct information, due to a maemo gconf bug that is fixed in
2840 osso 1.1, but not yet in Bora.
2841 However, the dialog stays on screen after it is destroyed.
2843 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2844 for invalid data when cancelling. Use a hildon note instead of a dialog
2845 to complain about invalid data. Do not show the account-saved note if the
2846 account is disabled (a temporary account that will not really be saved for use
2849 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2851 * src/modest-account-mgr-helpers.h:
2852 * src/modest-account-mgr-helpers.c:
2853 Added modest_account_mgr_unset_default_account(),
2854 Added modest_account_mgr_set_first_account_as_default().
2856 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2857 If it was the default account, unset the default account name.
2859 * src/maemo/modest-account-view-window.c:
2860 (on_delete_button_clicked): If it was the default account,
2861 set the first remaining account as the default instead.
2863 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2864 a NULL account or a NULL default account, to prevent a crash. This should
2865 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2868 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2870 * src/widgets/modest-recpt-editor.c:
2871 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2872 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2873 TODO comment for this. This fixes the build.
2875 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2876 be the best place for it. This will in future update all auto-update accounts,
2877 rather than just the current/default account, when that gconf key exists.
2878 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2879 if there are no accounts, before calling do_send_receive().
2880 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2882 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2883 * src/maemo/modest-main-window-ui.h:
2884 * src/maemo/modest-main-window.c: (on_connection_changed),
2885 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2886 directly, becaue the signal handler does more.
2888 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2890 * src/modest-account-mgr-helpers.c:
2891 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2892 for the case that the account does not exist.
2894 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2895 (equivalent to the modest account name) rather than the tinymail account name
2896 (equivalent to the modest account title - human readable) to get the account data.
2897 Check for null account data to prevent the crash, and add a TODO comment saying that
2898 this needs fixing because it is using the server account name instead of the account name.
2900 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2902 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2903 * src/maemo/modest-account-settings-dialog.c: (show_error),
2905 Use hildon_note_new_information() for informative and error messages,
2906 which seems to be expected for Maemo applications (no documentation that I know of
2907 says this). I am surprised that there is no distinction between info and error
2910 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2912 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2913 it is easy to find where this is used.
2915 * src/maemo/easysetup/modest-easysetup-wizard.c:
2916 (create_page_welcome), (create_page_account_details),
2917 (create_page_user_details), (create_page_complete_easysetup),
2918 (create_page_custom_incoming), (create_page_custom_outgoing),
2919 (create_page_complete_custom):
2920 * src/maemo/modest-account-settings-dialog.c:
2921 (create_page_account_details), (create_page_user_details),
2922 (create_page_incoming), (create_page_outgoing):
2923 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2924 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2925 (modest_connection_specific_smtp_edit_window_init):
2926 * src/maemo/modest-connection-specific-smtp-window.c:
2927 (modest_connection_specific_smtp_window_init):
2928 * src/maemo/modest-signature-editor-dialog.c:
2929 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2930 and scrolling policy as per the Email Application Layout Guide, if I have
2933 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2935 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2936 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2937 which were empty, because these vfuncs have been removed from TnyAccountStore.
2938 This fixes the build.
2940 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2942 * src/maemo/modest-main-window.c:
2943 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2944 showing/hiding it. Added TODO because it probably should not be NULL.
2945 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2946 because unnecessary g_warnings() make degugging difficult.
2948 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2950 * src/maemo/modest-msg-edit-window.c:
2951 (modest_msg_edit_window_select_color),
2952 (modest_msg_edit_window_select_background_color): 2 const corrections and
2953 moving 2 #endifs before closing brackets, to fix the build.
2955 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2957 * src/maemo/easysetup/modest-easysetup-wizard.h:
2958 * src/maemo/easysetup/modest-easysetup-wizard.c:
2959 (modest_easysetup_wizard_dialog_finalize),
2960 (on_button_edit_advanced_settings), (create_page_complete_custom),
2961 (on_response), (create_account):
2962 Implement the Advanced Settings edit button, by saving the account information,
2963 for the Advanded Settings dialog to use directly from gconf, and removing it
2964 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2965 Bug #5533 in the projects.maemo.org bugzilla.
2967 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2969 * src/maemo/modest-msg-view-window.c:
2970 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2971 when opening a message window.
2973 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2975 * src/maemo/easysetup/modest-easysetup-wizard.c:
2976 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2979 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2980 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2981 gconf settings. I probably added more checks than necessary, but that is safer.
2983 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2984 variable to fix the build, but this seems to be used when it is still NULL.
2986 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2988 * src/modest-platform.h:
2989 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2990 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2991 * src/modest-main.c: Implement this function so we can avoid using
2992 maemo-specific API from cross-platform code.
2994 * src/modest-tny-account-store.c:
2995 (get_smtp_specific_transport_account_for_open_connection):
2996 * src/modest-ui-actions.c: (check_for_connection),
2997 (modest_ui_actions_on_item_not_found):
2998 Use modest_platform_connect_and_wait() and put #idefs around other
2999 maemo-specific code, because only maemo currently has a way to
3000 identify connection names.
3002 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3004 * src/modest-tny-account-store.h:
3005 * src/modest-tny-account-store.c:
3006 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3007 the connection-specific SMTP server settings in the configuration.
3009 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3011 * src/maemo/modest-main-window.c: (on_connection_changed),
3013 * src/modest-main.c: (main), (start_ui), (send_mail):
3014 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3015 that is what is intended.
3017 * src/modest-ui-actions.c: (action_send), (action_receive),
3018 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3019 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3020 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3021 SMTP server is used when it is specified.
3023 (modest_ui_actions_on_send_receive):
3024 Check that a connection is open before proceeding.
3025 Receive and then send, instead of vice-versa, as per the specification.
3027 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3029 * src/modest-mail-operation.c:
3030 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3031 though I guess it should be something other than NULL.
3033 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3035 * src/maemo/easysetup/modest-easysetup-wizard.c:
3036 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3037 combo twice, to avoid an g_warning and to make it visible again.
3038 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3039 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3040 (already intended) dereference when detaching, because we then recreate the menu.
3041 But I am not sure why the warning was happening, and it is possible that this is a memory
3044 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3046 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3047 and uri_parse_mailto() utility functions.
3048 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3050 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3052 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3054 * src/dbus_api/modest-dbus-api.h:
3055 * src/dbus_api/modest-dbus-callbacks.c:
3056 Use an idle callback to execute the modest code in the application's own thread.
3057 Remove the helloworld example method.
3058 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3059 parsed, and the open-message method is not implemented because this is not yet implemented in
3061 * libmodest-dbus-client/libmodest-dbus-client.c:
3062 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3063 (libmodest_dbus_client_open_message):
3064 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3066 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3067 body without crashing.
3069 * tests/dbus_api/Makefile.am:
3070 * tests/dbus_api/test_mail_to.c:
3071 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3073 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3075 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3076 Added file to fix the build. Sorry.
3078 * src/dbus_api/Makefile.am:
3079 * src/dbus_api/modest-dbus-api.h:
3080 * src/dbus_api/modest-dbus-callbacks.h:
3081 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3082 (modest_dbus_req_handler):
3083 Put constants in a separate header so it can be reused by the
3084 client library, without duplication
3086 * libmodest-dbus-client/Makefile.am:
3087 * libmodest-dbus-client/libmodest-dbus-client.c:
3088 (libmodest_dbus_client_call_helloworld),
3089 (libmodfest_dbus_client_send_mail),
3090 (libmodfest_dbus_client_mailto),
3091 (libmodfest_dbus_client_open_message):
3092 * libmodest-dbus-client/libmodest-dbus-client.h:
3093 (Partly) Implement a send_mail D-Bus method.
3095 * tests/dbus_api/Makefile.am:
3096 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3097 the send_email D-Bus method.
3099 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3103 * libmodest-dbus-client/Makefile.am:
3104 * libmodest-dbus-client/libmodest-dbus-client.c:
3105 * libmodest-dbus-client/libmodest-dbus-client.h:
3106 * tests/dbus_api/Makefile.am:
3107 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3108 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3110 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3112 * src/maemo/easysetup/modest-easysetup-wizard.c:
3113 (create_page_account_details):
3114 * src/maemo/modest-account-settings-dialog.c:
3115 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3116 widgets, because this might not be the default in future versions of the Maemo GTK+.
3117 However, I can not not get capitalization to work even in a simple test case.
3119 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3121 * src/maemo/easysetup/modest-easysetup-wizard.c:
3122 (create_page_custom_incoming), (create_page_custom_outgoing):
3123 * src/maemo/modest-account-settings-dialog.c:
3124 (create_page_account_details), (create_page_incoming),
3125 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3126 instead of using gtk_check_button_with_label(), so they are aligned like the other
3127 widgets, as per the UI spec.
3129 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3131 * src/maemo/easysetup/modest-easysetup-wizard.c:
3132 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3133 * src/widgets/modest-validating-entry.c:
3134 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3135 Modest prefix instead of an EasySetup prefix.
3137 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3139 * src/widgets/modest-validating-entry.h:
3140 * src/widgets/modest-validating-entry.c: (on_insert_text),
3141 Added easysetup_validating_entry_set_max_func(), used to set a callback
3142 to call when the max number of characters is reached. GtkEntry has a max-length
3143 already but is silent about it.
3145 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3146 (create_page_account_details), (create_page_user_details),
3148 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3149 (create_page_account_details), (create_page_user_details),
3150 (create_page_outgoing):
3151 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3152 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3153 the UI spec, when the user tries to enter more than the max number of characters.
3155 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3157 * src/maemo/easysetup/modest-easysetup-wizard.c:
3158 (create_page_user_details), (create_page_custom_incoming),
3159 (create_page_custom_outgoing):
3160 * src/maemo/modest-account-settings-dialog.c:
3161 (create_page_user_details), (create_page_incoming),
3162 (create_page_outgoing):
3163 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3164 (modest_connection_specific_smtp_edit_window_init):
3165 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3166 not appropriate. Bad Maemo-specific defaults!.
3168 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3170 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3171 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3172 (modest_signature_editor_dialog_set_settings):
3173 Disable the label and textview when the checkbox is disabled, and use the
3174 specified (UI spec) default signature text.
3176 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3178 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3179 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3181 * src/modest-defs.h:
3182 * src/modest-account-mgr-helpers.h:
3183 * src/modest-account-mgr-helpers.c:
3184 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3186 * src/maemo/Makefile.am:
3187 * src/maemo/modest-signature-editor-dialog.c:
3188 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3191 * src/maemo/modest-account-settings-dialog.h:
3192 * src/maemo/modest-account-settings-dialog.c:
3193 (modest_account_settings_dialog_finalize), (on_button_signature),
3194 (save_configuration): Use the new dialog when the Edit button is pressed, and
3195 save the changes if necessary, as per the UI spec.
3197 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3199 * src/maemo/Makefile.am:
3200 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3201 based on maemo-develoers email from Dirk.
3203 * src/maemo/easysetup/modest-easysetup-wizard.c:
3204 (create_page_welcome), (create_page_account_details),
3205 (create_page_user_details), (create_page_complete_easysetup),
3206 (create_page_custom_incoming), (create_page_custom_outgoing),
3207 (create_page_complete_custom),
3208 (modest_easysetup_wizard_dialog_init):
3209 * src/maemo/modest-account-settings-dialog.c:
3210 (create_page_account_details), (create_page_user_details),
3211 (create_page_incoming), (create_page_outgoing),
3212 (modest_account_settings_dialog_init):
3213 * src/maemo/modest-connection-specific-smtp-window.c:
3214 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3216 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3218 * src/maemo/easysetup/modest-easysetup-wizard.c:
3219 (create_page_account_details), (create_page_custom_outgoing),
3220 (create_page_complete_custom):
3221 * src/maemo/modest-account-settings-dialog.c:
3222 (create_page_user_details), (create_page_incoming),
3223 (create_page_outgoing):
3224 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3225 (modest_connection_specific_smtp_edit_window_init):
3226 Use the correct (UI spec) port min/max, and use horizontal separators,
3229 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3231 * src/maemo/easysetup/modest-easysetup-wizard.c:
3232 (set_default_custom_servernames):
3233 * src/maemo/modest-account-settings-dialog.c:
3234 (create_page_incoming), (on_combo_outgoing_security_changed),
3235 (on_combo_incoming_security_changed), (create_page_outgoing),
3236 (modest_account_settings_dialog_set_account_name),
3237 (save_configuration):
3238 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3239 (on_combo_security_changed),
3240 (modest_connection_specific_smtp_edit_window_init),
3241 (modest_connection_specific_smtp_edit_window_set_connection),
3242 (modest_connection_specific_smtp_edit_window_get_settings):
3243 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3246 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3249 * src/maemo/easysetup/modest-easysetup-wizard.c:
3250 (create_page_custom_outgoing), (create_page_complete_custom):
3251 * src/maemo/modest-account-settings-dialog.c:
3252 (create_page_user_details), (create_page_outgoing):
3253 * src/maemo/modest-account-view-window.c: (button_box_new):
3254 Use changed logical IDs as per the most recent UI spec:
3255 mcen_bd_emailsetup_edit -> mcen_bd_edit
3256 mcen_bd_emailsetup_delete -> mcen_bd_delete
3257 mcen_bd_emailsetup_close -> mcen_bd_close
3259 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3263 * src/dbus_api/Makefile.am:
3264 * src/dbus_api/modest-dbus-callbacks.c:
3265 * src/dbus_api/modest-dbus-callbacks.h:
3266 * src/maemo/modest-platform.c: (modest_platform_init):
3267 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3269 * tests/Makefile.am:
3270 * tests/dbus_api/Makefile.am:
3271 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3273 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3275 * src/maemo/modest-account-settings-dialog.c:
3276 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3277 Removed unnecessary includes.
3279 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3281 * src/maemo/easysetup/modest-easysetup-wizard.c:
3282 * src/maemo/modest-account-settings-dialog.c:
3283 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3284 * src/widgets/Makefile.am:
3285 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3286 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3287 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3288 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3289 * src/widgets/modest-secureauth-combo-box.c:
3290 * src/widgets/modest-secureauth-combo-box.h:
3291 * src/widgets/modest-serversecurity-combo-box.c:
3292 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3293 made the GObject names more consistent with the rest of the Modest code.
3295 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3297 * src/maemo/easysetup/Makefile.am:
3298 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3299 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3300 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3301 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3302 * src/maemo/easysetup/modest-easysetup-wizard.c:
3303 * src/maemo/easysetup/modest-validating-entry.c:
3304 * src/maemo/easysetup/modest-validating-entry.h:
3305 * src/maemo/modest-account-settings-dialog.c:
3306 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3307 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3308 widgets/ because they are used outside of easysetup too. After checking in,
3309 svn will allow me to rename them too.
3311 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3313 * src/gnome/modest-msg-edit-window.c:
3314 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3315 linker error, to fix the build on the GNOME platform.
3316 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3317 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3318 ifdefed out to avoid a warning.
3320 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3322 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3323 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3324 some alternative for GTK+ 2.6.
3326 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3328 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3330 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3331 specified for EmailAccountsDialog in UI spec.
3333 * src/maemo/easysetup/modest-easysetup-wizard.c:
3334 * src/maemo/easysetup/modest-easysetup-wizard.h:
3335 * src/maemo/modest-account-settings-dialog.c:
3336 * src/maemo/modest-account-settings-dialog.h:
3337 Reuse a member window widget for the connection-specific SMTP server accounts,
3338 so we can tell it to create/save the accounts only if we actually save changes.
3340 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3341 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3342 (modest_connection_specific_smtp_edit_window_get_settings):
3343 Return a struct instance for temporarily remembering the entered data.
3345 * src/maemo/modest-connection-specific-smtp-window.h:
3346 * src/maemo/modest-connection-specific-smtp-window.c:
3347 (modest_connection_specific_smtp_window_finalize),
3348 (modest_connection_specific_smtp_window_fill_with_connections),
3350 (modest_connection_specific_smtp_window_save_server_accounts),
3351 (update_model_server_names): Do not actually save data until asked,
3352 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3354 (on_selection_changed),
3355 (modest_connection_specific_smtp_window_init): Disable the edit
3356 button when nothing is selected.
3358 * src/modest-account-mgr-helpers.c:
3359 * src/modest-account-mgr-helpers.h:
3360 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3363 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3365 * src/modest-account-mgr-helpers.h:
3366 * src/modest-account-mgr-helpers.c:
3367 (modest_account_mgr_get_unused_account_name),
3368 (modest_account_mgr_get_unused_account_display_name): Added these
3369 utility functions, to avoid code duplication.
3371 * src/maemo/easysetup/modest-easysetup-wizard.c:
3372 (create_page_account_details), (create_account):
3373 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3374 (on_combo_security_changed),
3375 (modest_connection_specific_smtp_edit_window_init),
3376 (modest_connection_specific_smtp_edit_window_save_settings):
3377 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3378 * src/maemo/modest-connection-specific-smtp-window.c:
3379 (modest_connection_specific_smtp_window_finalize),
3380 (modest_connection_specific_smtp_window_fill_with_connections),
3381 (on_button_edit), (modest_connection_specific_smtp_window_init):
3382 * src/maemo/modest-connection-specific-smtp-window.h:
3383 Implementing saving of connection-specific server accounts.
3385 But I need to refactor this so we can save the data for each
3386 possible connection-specific account and only actually create the server accounts
3387 when the easysetup finished, or the OK button is pressed on the account settings
3390 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3392 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3393 (on_combo_security_changed):
3394 (modest_connection_specific_smtp_edit_window_init):
3395 Auto-fill the port number as in the account settings.
3397 (modest_connection_specific_smtp_edit_window_set_connection):
3398 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3399 * src/maemo/modest-connection-specific-smtp-window.c:
3400 (fill_with_connections), (on_button_edit),
3401 (modest_connection_specific_smtp_window_init):
3402 Turn the edit window into a dialog to simplify the code, and
3403 set a WM hint as in a GtkDialog, because only a popup can be on top of
3404 another window in Maemo, and popups usually have no WM decoration.
3406 * src/modest-defs.h:
3407 * src/modest-account-mgr-helpers.c:
3408 (modest_account_mgr_set_connection_specific_smtp),
3409 (modest_account_mgr_remove_connection_specific_smtp),
3410 (modest_account_mgr_get_connection_specific_smtp):
3411 * src/modest-account-mgr-helpers.h: Some functions to write the
3412 connection-specific SMTP server information. Not yet used.
3415 * src/widgets/modest-folder-view.c: (text_cell_data):
3416 Fix a warning about an uninitialized variable.
3417 (on_configuration_key_changed): Put an #ifdef around the use
3418 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3420 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3422 * src/maemo/modest-account-settings-dialog.h:
3423 * src/maemo/modest-account-settings-dialog.c:
3424 Added connect_for_modified() utility function to mark the new modified boolean.
3426 (create_page_account_details), (create_page_user_details),
3427 (create_page_incoming), (create_page_outgoing), (on_response),
3428 (modest_account_settings_dialog_init),
3429 (modest_account_settings_dialog_set_account_name):
3430 Only warn about unsaved changes when there are actually unsaved changes.
3432 * src/modest-account-mgr-helpers.c:
3433 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3434 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3435 to get the data from there in future.
3437 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3439 * src/modest-defs.h:
3441 * src/modest-account-mgr-helpers.h:
3442 * src/modest-account-mgr-helpers.c:
3443 Store the security account setting in a single conf key instead of using
3444 the options list, so that the list is left for just the to-be-removed camel hack,
3445 and because gconf_client_set_list() is failing for some reason.
3447 * src/modest-account-mgr.c:
3448 (modest_account_mgr_add_server_account):
3449 * src/maemo/modest-account-settings-dialog.c:
3450 (modest_account_settings_dialog_set_account_name),
3451 (save_configuration): Use the renamed functions.
3454 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3456 * src/widgets/Makefile.am:
3457 * src/widgets/modest-limit-retrieve-combo-box.c:
3458 * src/widgets/modest-limit-retrieve-combo-box.h:
3459 * src/widgets/modest-retrieve-combo-box.c:
3460 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3461 the account settings dialog.
3463 * src/modest-defs.h:
3464 * src/modest-account-mgr-helpers.h:
3465 * src/modest-account-mgr-helpers.c:
3466 (modest_server_account_get_option_secure_auth),
3467 (modest_server_account_set_option_secure_auth):
3468 * src/modest-account-mgr.c:
3469 (modest_account_mgr_add_server_account):
3470 Use the existing AUTH_MECH conf key for the secure-auth setting,
3471 instead of putting it in the list options, because this was actually used already.
3473 * src/maemo/modest-account-settings-dialog.c:
3474 (create_page_account_details),
3475 (modest_account_settings_dialog_set_account_name),
3476 (save_configuration):
3477 * src/maemo/modest-account-settings-dialog.h:
3478 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3479 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3481 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3483 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3484 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3485 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3487 * src/modest-defs.h:
3488 * src/maemo/modest-account-settings-dialog.c:
3489 (create_page_incoming), (on_combo_outgoing_security_changed),
3490 (on_combo_incoming_security_changed), (create_page_outgoing),
3491 (modest_account_settings_dialog_set_account_name),
3492 (save_configuration): Load/Save the port number, and change it when the
3493 security combo changes, to suitable defaults.
3495 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3497 * src/modest-account-mgr.c:
3498 (modest_account_mgr_add_server_account): Set the security and secure-auth
3499 options, and add a comment saying that the other camel-specific options should be
3502 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3504 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3506 * src/modest-tny-account-store.c: (account_list_free),
3507 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3508 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3511 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3513 * src/modest-protocol-info.c:
3514 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3515 is required by our UI spec. Maybe something in our implementation will use this eventually.
3516 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3517 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3518 instead of the previous 0 placeholder.
3520 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3521 secure-auth settings.
3522 * src/modest-account-mgr-helpers.h:
3523 * src/modest-account-mgr-helpers.c:
3524 (modest_server_account_data_get_option_secure_auth),
3525 (modest_server_account_set_option_secure_auth),
3526 (modest_server_account_data_get_option_security),
3527 (modest_server_account_set_option_security): Added this API for getting and setting the security
3528 and secure-auth settings.
3530 * src/maemo/modest-account-settings-dialog.h:
3531 * src/maemo/modest-account-settings-dialog.c:
3532 (modest_account_settings_dialog_finalize), (check_data),
3533 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3534 about changing titles.
3535 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3536 (save_configuration): Save the security and secure-auth settings.
3538 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3539 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3541 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3543 * src/modest-defs.h:
3544 * src/modest-account-mgr.c:
3545 (modest_account_mgr_add_server_account):
3546 Added and used defines for the options key and value pair strings,
3547 that are used so far, though they do not seem to correspond to anything in our
3548 UI specs or ModestProtocol enum.
3550 * src/modest-account-mgr-helpers.h:
3551 * src/modest-account-mgr-helpers.c:
3552 (compare_option_strings_for_name),
3553 (modest_server_account_data_get_option_value),
3554 (modest_server_account_data_get_option_bool),
3555 (modest_account_mgr_get_server_account_option):
3556 Added helper functions for parsing the options GSList.
3558 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3560 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3561 display name is based on the supplied account name.
3562 * src/modest-account-mgr.c:
3563 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3564 with an inefficient, but good-enough, implementation.
3566 * src/maemo/easysetup/modest-easysetup-wizard.c:
3567 (create_page_account_details), (on_before_next), (create_account):
3568 Check for existing display names rather than (non-user-visible) account names, and just
3569 create and set a unique account name at the end.
3571 * src/maemo/modest-account-settings-dialog.c:
3572 (modest_account_settings_dialog_init),
3573 (modest_account_settings_dialog_set_account_name),
3574 (create_page_incoming): Show the display name, instead of the account name.
3575 (on_response): Do some (not all) extra checks, as in the UI spec.
3576 (save_configuration): Save the display name if it was changed.
3578 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3580 * po/en_GB.po: Added needed logical ID and translation.
3581 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3582 (init_view): Made the is-default column clicking work.
3584 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3587 * src/maemo/easysetup/Makefile.am:
3588 * src/maemo/easysetup/modest-easysetup-wizard.c:
3589 (modest_easysetup_wizard_dialog_init):
3590 * src/maemo/easysetup/provider-data-test.keyfile:
3591 * src/maemo/easysetup/provider-data.keyfile:
3592 Moved the provider data file to the new modest-providers-data package and used it from there.
3594 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3596 * src/modest-local-folder-info.c:
3597 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3598 N_() was already used on the static strings, but this just marks it for translation without
3599 using the translation.
3601 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3603 * src/maemo/modest-account-settings-dialog.c:
3604 (create_page_incoming),
3605 (modest_account_settings_dialog_set_account_name):
3606 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3607 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3608 I will do this if nobody else gets there first.
3610 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3612 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3613 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3614 save the security stuff.
3616 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3618 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3619 Set the email address and user fullname, which I now see must be
3622 * src/maemo/modest-account-settings-dialog.h:
3623 * src/maemo/modest-account-settings-dialog.c:
3625 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3626 leave-on-server and authentication.
3627 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3630 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3633 * src/maemo/modest-account-settings-dialog.c:
3634 * src/maemo/modest-account-settings-dialog.h:
3635 Most (but not all) of the widgets are now present as specified by the UI spec.
3636 No changes are yet saved, and some details are not properly shown yet.
3638 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3640 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3642 * src/maemo/Makefile.am:
3643 * src/maemo/modest-account-settings-dialog.c:
3644 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3645 an existing account. Doesn't do much yet.
3647 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3648 Open the accounts settings dialog when Edit is clicked.
3650 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3652 * src/maemo/easysetup/Makefile.am:
3653 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3655 * src/maemo/easysetup/modest-easysetup-wizard.c:
3656 (modest_easysetup_wizard_dialog_init):
3657 Try to get the source directory from the build system,
3658 instead of hard-coding "./" into the source code, when opening our local
3659 copies of the configuration files.
3660 But this still fails when opening the wizard from the Accounts window,
3661 maybe because the working directory seems to change at runtime.
3662 So the wizard will fail the second time unless you copy the files into their
3663 proper locations - see the stdout warnings for the paths.
3665 (create_page_account_details),(on_before_next):
3666 Check for existing non-server accounts instead of server accounts,
3667 so the default account name is useful again, and to prevent trying to
3670 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3671 Show the wizard when New is clicked.
3673 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3674 (init_view): Show the column headers, and show the columns that are
3675 specified in the UI specs. However, something in Maemo's GTK+ prevents
3676 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3677 change the default account. This is despite unsetting the special properties.
3679 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3681 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3682 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3683 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3684 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3685 to make that clearer.
3686 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3688 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3690 * src/maemo/modest-account-view-window.c:
3691 (modest_account_view_window_init),
3692 (modest_account_view_window_new):
3693 Use the same buttons as specified in the
3694 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3695 the existing widgets, which never had a chance of working.
3696 Put the ModestAccountView treeview in a scrolled window.
3697 Do not repeat the initialization in both _init() and _new().
3699 * src/widgets/modest-account-view.c: (update_account_view):
3700 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3701 this widget and window shows no accounts.
3703 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3705 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3707 * src/maemo/easysetup/modest-easysetup-wizard.c:
3708 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3709 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3710 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3713 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3714 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3715 accounts exist yet, as in the UI spec.
3717 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3719 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3721 * src/maemo/Makefile.am:
3722 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3723 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3724 New window for editing connection-specific smtp details.
3725 Not fully implemented.
3727 * src/maemo/modest-connection-specific-smtp-window.c:
3728 (modest_connection_specific_smtp_window_finalize) :
3729 unref the tree model.
3730 (on_button_edit): Show the edit window.
3732 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3734 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3737 * src/maemo/Makefile.am:
3738 * src/maemo/modest-connection-specific-smtp-window.c:
3739 * src/maemo/modest-connection-specific-smtp-window.h:
3740 New window for showing the list of connections, for connection-specific
3741 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3742 * src/maemo/easysetup/modest-easysetup-wizard.c:
3743 (create_page_custom_outgoing): Show the new window when the button is clicked.
3745 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3747 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3748 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3749 * src/maemo/modest-msg-edit-window.c:
3750 (modest_msg_edit_window_insert_image):
3751 * src/modest-conf.c: (modest_conf_key_escape):
3752 * src/modest-mail-operation.c:
3753 (modest_mail_operation_send_new_mail):
3754 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3755 (modest_ui_actions_on_new_account):
3756 * src/widgets/modest-attachment-view.c: (update_filename_request):
3757 * src/widgets/modest-mail-header-view.c:
3758 Corrected warnings that were breaking the build, by commenting out unused variables,
3759 and a function, and by including a header.
3761 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3763 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3764 so we can #ifdef around platform-specific code when necessary.
3765 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3766 to allow this to build for the GNOME platform too.
3768 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3770 * src/maemo/easysetup/modest-easysetup-wizard.c:
3771 Added util_increment_name() and used it in create_page_account_details()
3772 to make sure that the default account name is always a new name.
3774 (modest_easysetup_wizard_dialog_init),
3775 (set_default_custom_servernames): Some minor memory management fixes.
3777 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3781 * src/modest-runtime.c: (init_i18n): Restored the translation
3782 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3783 are defined in config.h, and the translations are installed.
3785 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3786 is defined for translation.
3788 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3790 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3792 * src/maemo/easysetup/modest-easysetup-wizard.c:
3793 (modest_easysetup_wizard_dialog_init):
3794 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3795 Use realistic paths (though they should use $prefix generically) to the
3796 mcc_mapping and provider-data.keyfile files which might work when they
3797 are installed by the future version of the operator-wizard package,
3798 and then fallback to paths in our source code, with an explanatory
3801 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3805 * src/maemo/Makefile.am:
3806 * src/maemo/easysetup/: Added files from the previously-exernal
3807 osso-modest-easysetup.
3808 * src/maemo/modest-main-window-ui.h:
3809 * src/modest-ui-actions.c:
3810 * src/modest-ui-actions.h:
3811 Added modest_ui_actions_on_new_account() as a signal handler for the
3812 New Account menu item. It shows the easysetup wizard.
3813 * po/en_GB.po: Added additional needed logical IDs and translations.