1 2007-05-31 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/modest-main-window.c:
4 (on_account_store_connecting_finished): Do not try to get the
5 connection ID if we are not really connected. I am surprised that
6 this signal handler is called when we are not connected.
8 2007-05-31 Murray Cumming <murrayc@murrayc.com>
11 * src/modest-ui-actions.c:
12 (modest_ui_actions_get_msgs_full_error_handler):
13 Renamed an enum, added comments, added an enum
14 for retrieve-limit errors.
16 * src/modest-mail-operation.c: (foreach_add_item),
17 (internal_folder_observer_update), (update_account_thread),
18 (modest_mail_operation_get_msgs_full):
19 (modest_mail_operation_update_account),
20 Added comments about how this works, and some code that should
21 (but does not) check the retrieve-limit. See the TODO comment.
23 2007-05-31 Murray Cumming <murrayc@murrayc.com>
25 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
26 Initialize help_id to fix the build. Warnings are good.
28 2007-05-31 Murray Cumming <murrayc@murrayc.com>
30 * src/widgets/modest-hbox-cell-renderer.c:
31 (modest_hbox_cell_renderer_append):
32 * src/widgets/modest-vbox-cell-renderer.c:
33 (modest_vbox_cell_renderer_append):
34 Fix the last commit by doing an extra ref.
36 2007-05-31 Murray Cumming <murrayc@murrayc.com>
38 * src/widgets/modest-hbox-cell-renderer.c:
39 (modest_hbox_cell_renderer_append):
40 * src/widgets/modest-vbox-cell-renderer.c:
41 (modest_vbox_cell_renderer_append):
42 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
43 to fix the build with Maemo Bora.
44 However, there seems to be a remaining crash, probably due to reference
47 2007-05-30 Murray Cumming <murrayc@murrayc.com>
49 * src/modest-tny-account.c:
50 (modest_tny_account_new_for_local_folders):
51 Use hildon_file_system_info_async_new() to get a better name for
52 the memory card account, setting it as the account name.
53 The timing seems to work, but this is probably
54 not the best place to do this. See the TODO comment.
55 * src/maemo/modest-main-window.c: (create_details_widget):
56 * src/widgets/modest-folder-view.c: (text_cell_data):
57 Use the tny account name instead of hardcoding a name.
59 2007-05-30 Christian Kellner <ckellner@openismus.com>
61 * src/modest-search.c: (modest_search):
62 Correctly set part_search_func even if we have already parsed
63 the query and thus a valid OgsTextSearcher object.
65 2007-05-30 Christian Kellner <ckellner@openismus.com>
68 Search and check for libogs.
71 Incooparte the ogs build env.
73 * src/modest-mime-part-search-stream.c:
74 * src/modest-mime-part-search-stream.h:
75 Removed since we do the real searching now in modest-search.c.
77 * src/modest-search.c:
78 * src/modest-search.h:
79 Implement support for ogs. We use that if available and requested
80 and fall back to modest_text_utils_utf8_strcmp (). The search logic
81 should now handle the corner case when the search term is spread
82 across multiple reads.
83 Also the logic in modest_search () was corrected to search all
84 requested fields until one is found.
86 2007-05-30 Murray Cumming <murrayc@murrayc.com>
88 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
91 * src/modest-init.c: Made modest_init_local_folders() take a
92 path and be public so we can iniitialize maildir folders on
95 * src/modest-local-folder-info.h:
96 * src/modest-local-folder-info.c:
97 (modest_local_folder_info_get_maildir_path): Add a path parameter.
99 * src/modest-tny-account.c:
100 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
101 still means the standard local-folders path on the local volume.
103 * src/modest-tny-account-store.c:
104 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
105 signal so we can detect mount/unmount of the MMC1 card, and do an update of
106 all accounts when that happens.
107 (get_server_accounts): If the MMC1 card is mounted, create a store account for
108 this too, so it shows up in the treeview.
110 2007-05-28 Murray Cumming <murrayc@murrayc.com>
112 * src/maemo/modest-maemo-global-settings-dialog.c:
113 (current_connection):
114 * src/widgets/modest-global-settings-dialog.c:
115 (current_connection_default):
116 Use the enum values instead of 0, 1 and -1,
117 to make the code clearer.
119 * src/modest-account-mgr-helpers.c:
120 (modest_account_mgr_get_connection_specific_smtp): Make this code
123 * src/modest-runtime.h:
124 * src/modest-runtime.c:
125 Added modest_runtime_remove_all_send_queues().
126 * src/maemo/modest-main-window.c:
127 (on_account_store_connecting_finished): Recreate the send queues,
128 using the appropriate transport accounts for this new connection.
129 Some futher adapting might be needed if the old send queues are not
130 automatically stopped at this point.
132 * src/modest-tny-account-store.c: (get_server_accounts):
133 Create the connection-specific transport accounts, so that they can
134 be found later by their ID.
136 * src/modest-tny-account.h:
137 * src/modest-tny-account.c:
138 Added modest_tny_account_new_from_server_account_name().
139 modest_tny_account_new_from_server_account(): Do not create the
140 send queues here, because they will be
141 recreated anyway when the connection changes for the first time.
143 2007-05-28 Murray Cumming <murrayc@murrayc.com>
145 * src/modest-local-folder-info.h:
146 * src/modest-local-folder-info.c:
147 (modest_per_account_local_outbox_folder_info_get_maildir_path),
148 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
149 tbox_folder): Take a modest account name instead of a server TnyAccount,
150 so we can have per-modest-account rather than per-transport-account
152 We must make sure that we change or recreate the exisitng send queues
153 when the connection changes for connection-specific transport accounts.
155 * src/modest-tny-account-store.c:
156 (create_per_account_local_outbox_folders): Create outboxed per modest
157 account, not per transport account.
159 * src/modest-tny-account.h:
160 * src/modest-tny-account.c:
161 (modest_tny_account_get_special_folder): For outboxes, get the
162 parent modest account name. The account is ignored for other folders.
163 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
164 modest account name rather than a server TnyAccount.
166 2007-05-25 Murray Cumming <murrayc@murrayc.com>
168 * src/modest-tny-account.c:
169 (modest_tny_account_new_from_server_account):
170 Call modest_runtime_get_send_queue() immediately after creating transport
171 accounts, so that they start trying to send email from the outbox as soon
172 as possible at startup. This is probably what we want.
174 * src/modest-mail-operation.c: (update_account_thread):
175 * src/modest-runtime.c: (modest_runtime_get_send_queue):
176 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
177 * src/modest-tny-send-queue.h:
178 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
179 (modest_ui_actions_on_send):
180 Added comments about how sending works, though it needs some more work.
182 2007-05-25 Murray Cumming <murrayc@murrayc.com>
184 * src/modest-tny-account.c:
185 (modest_tny_account_get_special_folder): Add TODO because this fails when
187 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
188 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
189 Do not try to show this window when there is no active account. The UI
190 specs does not tell us what to do in this case.
192 2007-05-24 Murray Cumming <murrayc@murrayc.com>
196 * src/maemo/Makefile.am:
197 * src/widgets/Makefile.am: Some dist fixes.
199 2007-05-24 Murray Cumming <murrayc@murrayc.com>
201 * src/maemo/modest-connection-specific-smtp-window.c:
202 (on_button_edit): Make the code clearer, to prevent a double free.
204 2007-05-24 Murray Cumming <murrayc@murrayc.com>
206 * src/maemo/modest-account-settings-dialog.c:
207 (modest_account_settings_dialog_set_account_name),
208 Check the connection-specific smtp servers checkbox if there are any.
210 * src/maemo/modest-connection-specific-smtp-edit-window.c:
211 (modest_connection_specific_smtp_edit_window_init):
212 Start with a suitable port number.
214 * src/modest-account-mgr-helpers.h:
215 * src/modest-account-mgr-helpers.c: Added
216 modest_account_mgr_get_has_connection_specific_smtp().
218 (modest_account_mgr_set_connection_specific_smtp),
219 (modest_account_mgr_remove_connection_specific_smtp),
220 (modest_account_mgr_get_has_connection_specific_smtp),
221 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
222 connection-specific smtp server accounts in the account, rather than
223 the server account conf dir.
225 This fixes bug projects.maemo.org bug NB#58263 .
227 * src/modest-tny-account-store.c:
228 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
229 if there are no server accounts yet, to prevent an infinite loop when there
230 are no accounts. Document that one must be called before the other.
232 2007-05-24 Murray Cumming <murrayc@murrayc.com>
234 * src/modest-account-mgr-helpers.c:
235 (modest_account_mgr_get_default_account): Make sure that at least
236 one account is always the default, if there are any enabled accounts.
237 This is just a sanity check that shouldn't be necessary.
239 * src/modest-account-mgr-priv.c:
240 (_modest_account_mgr_account_from_key): Unescape the conf key to
241 get the real account name. For instance, this is an issue if a space
242 was in the account name, which can happen because the account name
243 is generated from the display name.
244 (_modest_account_mgr_get_account_keyname): Always escape the
246 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
247 Unescape the conf keys to get the real account names.
249 For instance, previously the is-default radio button in the accounts
250 list was not checked for any accounts at first. This fixes that,
251 and might fix several similar bugs.
253 2007-05-23 Murray Cumming <murrayc@murrayc.com>
255 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
256 Removed some debug printfs.
258 2007-05-23 Murray Cumming <murrayc@murrayc.com>
260 Modest on-disk outbox directories are now here, for instance:
261 $HOME/.modest/outboxes/<account-id-1>/outbox
262 $HOME/.modest/outboxes/<account-id-2>/outbox
264 $HOME/.modest/local-folders/outbox
265 so we can have a separate outbox for each account.
266 But they are shown as one outbox in the GtkTreeView, by using a
267 TnyMergeFolder in a ModestTnySimpleFolderStore.
270 * src/modest-tny-simple-folder-store.c:
271 * src/modest-tny-simple-folder-store.h:
272 Added ModestTnySimpleFolderStore, used to contain folders from
273 other folder stores, such as other accounts.
275 * src/modest-tny-outbox-account.h:
276 * src/modest-tny-outbox-account.c:
277 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
278 used for the per-account local outbox folders.
280 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
281 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
282 only use this (internally) now for the non-outbox local folders.
285 * src/modest-init.c: Added modest_init_one_local_folder(), for
286 setting up the directory structure for each local folder.
288 * src/modest-local-folder-info.c:
289 (modest_per_account_local_outbox_folder_info_get_maildir_path),
290 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
292 * src/modest-local-folder-info.h:
293 * src/modest-tny-account-store.c: (on_account_removed),
294 (on_account_changed), (create_per_account_local_outbox_folders),
295 (get_server_accounts), (modest_tny_account_store_get_accounts),
296 (modest_tny_account_store_get_tny_account_by_account),
297 (modest_tny_folder_store_is_virtual_local_folders):
299 * src/modest-tny-account.h:
300 * src/modest-tny-account.c:
301 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
302 to create an on-disk per-account local outbox folder for each
304 (create_per_account_local_outbox_folders): Create a local outbox folder
305 for each transport account.
306 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
307 for all local folders.
309 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
310 instead of using g_object_get/set() directly. It is clearer.
312 (modest_tny_folder_store_get_message_count),
313 (modest_tny_folder_store_get_local_size
314 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
315 because we now use these with non-acount folder stores.
317 (modest_tny_account_get_special_folder),
318 (modest_tny_account_new_from_server_account),
319 (modest_tny_account_new_from_account):
320 (recurse_folders): Adjust to the new outbox system.
322 * src/modest-tny-folder.h:
323 * src/modest-tny-folder.c:
324 (modest_tny_folder_is_local_folder),
325 (modest_tny_folder_get_local_folder_type),
326 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
328 * src/widgets/modest-main-window.h:
329 * src/maemo/modest-main-window.c: (create_details_widget),
330 (modest_main_window_set_contents_style): Show details for any folder store,
333 (modest_tny_folder_get_rules):
334 Remove the const. C does not support constness enough for this.
336 * src/modest-ui-actions.c:
337 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
338 make all outboxes appear as one, in the usual local-folders tree node.
340 (set_active_account_from_tny_account),
341 (modest_ui_actions_on_folder_selection_changed):
342 * src/widgets/modest-folder-view.c: (text_cell_data),
343 (icon_cell_data), (filter_row),
344 (add_account_folders_to_merged_folder),
345 (add_account_folders_to_simple_folder_store), (),
346 (get_cmp_rows_type_pos), (cmp_rows),
347 (modest_folder_view_set_account_id_of_visible_server_account):
348 Adjust to the new outbox system, using generic folder stores and folders
351 2007-05-23 Christian Kellner <ckellner@openismus.com>
353 * src/modest-mail-operation.c:
354 (modest_mail_operation_update_account):
355 Use info->max_size instead of unintialized local var [small
356 build fix]. (Added TODO to review that change since I don't
359 2007-05-23 Marcus Bauer <marcusb@openismus.com>
361 * libmodest-dbus-client/libmodest-dbus-client.c:
362 (libmodest_dbus_client_compose_mail): function added
363 * src/dbus_api/modest-dbus-api.h:
364 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
365 (on_compose_mail): Implementation of the SendAsMail functionality
367 2007-05-22 Murray Cumming <murrayc@murrayc.com>
369 * src/modest-account-mgr.c:
370 (modest_account_mgr_add_server_account): Set the secure-connection
371 conf key for transport accounts as well as store accounts. I don't know
372 why the if was there. For instance, this makes sure that we use SSL
373 for the gmail preset from the easysetup wizard.
375 2007-05-22 Murray Cumming <murrayc@murrayc.com>
377 * src/gnome/modest-main-window.c:
378 (on_account_store_connecting_finished), (connect_signals):
379 * src/maemo/modest-main-window.c:
380 (on_account_store_connecting_finished), (connect_signals),
381 (modest_main_window_new):
382 Handle TnyAccountStore::connecting-finished instead of
383 TnyDevice::connection-changed, because we cannot actually perform
384 operations on accounts until TnyAccountStore has itself responded to
385 the TnyDevice::connection-changed signal. This prevents a GError from
387 Do not try to update at startup, because we (at least on scratchbox)
388 already do an update at startup when the device goes online.
389 This prevents a GError from tinymail.
390 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
391 Added TODO about stopping simultaneous operations.
393 2007-05-21 Murray Cumming <murrayc@murrayc.com>
395 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
396 * src/modest-mail-operation-queue.c:
397 (modest_mail_operation_queue_remove):
398 * src/modest-tny-account-store.c: When GErrors happen, give more clues
399 about where they happened.
401 2007-05-21 Murray Cumming <murrayc@murrayc.com>
403 * src/modest-ui-actions.c:
404 (modest_ui_actions_on_password_requested): Make sure that the remember
405 output parameter is always TRUE.
407 2007-05-21 Murray Cumming <murrayc@murrayc.com>
409 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
410 Show a OK/Cancel dialog if the error is a question, though we still do not
411 know anything more about what we are asking the user.
412 * src/widgets/modest-folder-view.c: (on_drag_data_received):
413 Fix an uninitialized variable (helper). This is a logic error, however.
415 2007-05-21 Christian Kellner <ckellner@openismus.com>
417 * src/modest-search.h:
418 Correct bit shifting in the ModestSearchFlags enum.
420 2007-05-21 Murray Cumming <murrayc@murrayc.com>
422 * src/modest-tny-account.c:
423 (modest_tny_account_new_from_server_account): Do not use the lsub and
424 check-all hard-coded IMAP options when using POP.
426 2007-05-21 Murray Cumming <murrayc@murrayc.com>
428 * src/modest-tny-account.c:
429 (modest_tny_account_new_from_server_account):
430 Use NULL for the secure-auth method for POP when Password auth has been
431 specified by the user, as we already do for IMAP. "auth=Login" causes
432 an error from camel or the server.
434 2007-05-17 Murray Cumming <murrayc@murrayc.com>
436 * src/maemo/modest-account-settings-dialog.c:
437 (create_page_account_details),
438 (modest_account_settings_dialog_set_account_name):
439 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
440 for the leave-on-server checkbox, rathr than just the checkbox, when
441 the protocol is not POP.
443 2007-05-17 Murray Cumming <murrayc@murrayc.com>
445 * src/widgets/modest-account-view.c:
446 * src/widgets/modest-account-view.h:
447 Added modest_account_view_select_account() which will be useful later
448 to asynchronously re-select the edited account.
450 2007-05-17 Murray Cumming <murrayc@murrayc.com>
452 * src/maemo/modest-account-settings-dialog.c:
453 (modest_account_settings_dialog_set_account_name):
454 Automatically choose the port numbers based on the secure authentication
455 methods, if they have not been chosen before.
456 This fixes projects.maemo.org bug NB#56273 .
458 2007-05-17 Murray Cumming <murrayc@murrayc.com>
460 * src/maemo/modest-main-window-ui.h:
461 * src/modest-ui-actions.c:
462 * src/modest-ui-actions.h:
463 Connect the Tools/SMTP Servers menu item to
464 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
465 SMTP servers dialog, as in the UI specification and saves changes when it
466 is closed. This fixed projects.maemo.org bug NB#56305 .
468 2007-05-17 Murray Cumming <murrayc@murrayc.com>
470 * src/maemo/modest-connection-specific-smtp-window.c:
471 (modest_connection_specific_smtp_window_init):
472 Use gtk_window_set_default_size() to make this window big enough, so
473 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
475 2007-05-17 Murray Cumming <murrayc@murrayc.com>
477 * src/maemo/modest-connection-specific-smtp-edit-window.h:
478 * src/maemo/modest-connection-specific-smtp-edit-window.c:
479 (modest_connection_specific_smtp_edit_window_init),
480 Do not try to connect to a combobox signal before the combobox exists.
481 This fixes the cras in projects.maemo.org bug NB#56288 .
482 (modest_connection_specific_smtp_edit_window_get_settings):
483 Remove the server_account_name parameter which was being checked for NULL
484 though it was not used.
486 * src/maemo/modest-connection-specific-smtp-window.c:
487 (modest_connection_specific_smtp_window_fill_with_connections),
488 (on_button_edit), (modest_connection_specific_smtp_window_init):
489 Correct the number of treemodel columns to prevent a warning.
490 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
491 libconic does not work.
493 2007-05-16 Murray Cumming <murrayc@murrayc.com>
495 * src/modest-tny-account.c:
496 (modest_tny_account_new_from_server_account):
497 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
498 SMTP when "None" was chosen by the user. However, with my SMTP server that
499 does not support ANONYMOUS, the emails do not leave the Outbox and I see
502 2007-05-16 Murray Cumming <murrayc@murrayc.com>
504 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
505 to explain the memory management issue with the ID in the ModestPair.
507 * src/gnome/modest-account-assistant.c: (add_receiving_page),
508 (add_sending_page), (modest_account_assistant_finalize):
509 * src/gnome/modest-gnome-global-settings-dialog.c:
510 (create_updating_page), (create_composing_page):
511 * src/gnome/modest-msg-edit-window.c: (get_transports),
512 (init_window), (modest_msg_edit_window_finalize),
513 (modest_msg_edit_window_get_msg_data):
514 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
515 * src/gnome/modest-transport-widget.c:
516 (modest_transport_widget_finalize), (smtp_configuration):
517 * src/maemo/modest-maemo-global-settings-dialog.c:
518 (create_updating_page), (create_composing_page):
519 * src/maemo/modest-msg-edit-window.c: (get_transports),
520 (init_window), (modest_msg_edit_window_finalize),
521 (modest_msg_edit_window_get_msg_data),
522 (modest_msg_edit_window_free_msg_data):
523 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
524 (modest_store_widget_finalize):
525 * src/maemo/modest-transport-widget.c:
526 (modest_transport_widget_finalize), (smtp_configuration):
527 * src/modest-main.c: (send_mail):
528 * src/widgets/modest-combo-box.h:
529 * src/widgets/modest-global-settings-dialog-priv.h:
530 * src/widgets/modest-global-settings-dialog.c:
531 (modest_global_settings_dialog_finalize):
532 * src/widgets/modest-msg-edit-window.h:
533 Whenever using modest_combo_box_new(), keep the ModestPairList alive
534 as long as the combo box, to prevent use of freed memory for the ID.
536 2007-05-15 Murray Cumming <murrayc@murrayc.com>
538 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
539 get_accounts(), to make this clearer. Do not check for the enabled gconf
540 key, because we do not use this for server accounts (at least, not yet).
541 This allows us to send email again.
543 2007-05-15 Murray Cumming <murrayc@murrayc.com>
545 * src/maemo/modest-platform.c:
546 (on_modest_conf_update_interval_changed), (modest_platform_init):
547 Only respond to this particular key change. All these strcmp()s cannot be
550 2007-05-15 Murray Cumming <murrayc@murrayc.com>
552 * src/maemo/modest-maemo-global-settings-dialog.c:
553 (current_connection): Prevent a crash in scratchbox when
554 ny_maemo_conic_device_get_current_iap_id() returns NULL.
555 * src/maemo/modest-platform.c:
556 (on_modest_conf_update_interval_changed), (modest_platform_init):
557 Get the update interval from gconf and reset it when the gconf key changes.
559 2007-05-15 Murray Cumming <murrayc@murrayc.com>
561 * src/modest-protocol-info.c:
562 * src/modest-protocol-info.h: Adde enum-specific get functions,
563 instead of using a ModestProtocolType enum parameter.
565 * src/gnome/modest-account-assistant.c:
566 * src/gnome/modest-store-widget.c:
567 * src/gnome/modest-store-widget.h:
568 * src/gnome/modest-transport-widget.c:
569 * src/gnome/modest-transport-widget.h:
570 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
571 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
572 * src/maemo/easysetup/modest-easysetup-wizard.c:
573 * src/maemo/modest-account-settings-dialog.c:
574 * src/maemo/modest-account-settings-dialog.h:
575 * src/maemo/modest-store-widget.c:
576 * src/maemo/modest-store-widget.h:
577 * src/maemo/modest-transport-widget.c:
578 * src/maemo/modest-transport-widget.h:
579 * src/modest-account-mgr-helpers.c:
580 * src/modest-account-mgr-helpers.h:
581 * src/modest-account-mgr.c:
582 * src/modest-account-mgr.h:
583 * src/modest-tny-account.c:
584 * src/modest-tny-folder.c:
585 * src/widgets/modest-account-view.c:
586 * src/widgets/modest-retrieve-combo-box.c:
587 * src/widgets/modest-retrieve-combo-box.h:
588 * src/widgets/modest-secureauth-combo-box.c:
589 * src/widgets/modest-serversecurity-combo-box.c:
590 * src/widgets/modest-serversecurity-combo-box.h:
591 * tests/check_account-mgr.c:
592 Use the specific functions, and use the re-renamed enum values for GNOME too.
594 2007-05-15 Murray Cumming <murrayc@murrayc.com>
597 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
598 so we can get the second based on the first.
600 * src/maemo/modest-account-settings-dialog.h:
601 * src/maemo/modest-account-settings-dialog.c:
602 Added get_supported_secure_authentication_methods(), though it is mostly
603 commented-out for now until the necessary API is committed to tinymail.
604 (modest_account_settings_dialog_set_account_name),
605 (save_configuration): Request the supported authentication methods from the
606 server, so we can choose a working method.
608 * src/modest-tny-account-store.h:
609 * src/modest-tny-account-store.c:
610 (modest_tny_account_store_get_session): Rename from
611 tny_account_store_get_session().
613 2007-05-14 Murray Cumming <murrayc@murrayc.com>
615 * src/modest-protocol-info.h: Split the ModestProtocol enum
616 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
617 There was no need to have these unrelated values in one enum.
619 * src/: many files: Adapted to changed enum. This makes the code a bit
620 clearer, and the compiler could catch some errors.
622 2007-05-14 Murray Cumming <murrayc@murrayc.com>
624 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
625 Show the detailed internal camel error message when an error happens
626 during the configuration, so that our testers can give us more clues.
627 For instance, in projects.maemo.org bug NB#56910 .
629 2007-05-14 Murray Cumming <murrayc@murrayc.com>
631 * src/modest-tny-account.c:
632 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
633 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
635 2007-05-14 Murray Cumming <murrayc@murrayc.com>
637 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
638 * src/maemo/modest-account-settings-dialog.c:
639 (modest_account_settings_dialog_set_account_name),
640 (save_configuration): For the incoming secure authentication checkbox,
641 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
642 the UI specification. PLAIN does not seem to be supported for most IMAP
643 servers anyway, and I am not sure what it would mean.
644 However, we probably need to discover which of the secure-authentication
645 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
646 * src/modest-account-mgr-helpers.c:
647 (modest_account_mgr_get_server_account_data):
649 * src/modest-tny-account.c:
650 (modest_tny_account_new_from_server_account):
651 Use tny_account_set_mech() to set secure-authentication methods,
652 with some special-casing for IMAP, based on my observations of how
655 * src/modest-account-mgr-helpers.h:
656 * src/modest-account-mgr.c:
657 * src/modest-defs.h: Comment that the URI is only used for local folders.
659 2007-05-11 Murray Cumming <murrayc@murrayc.com>
661 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
662 parameter const, just to be neat.
663 * src/modest-text-utils.c: (modest_text_utils_inline):
664 End g_strconcat() with NULL, as its documentation says. This is almost
665 certainly the cause of my crash at startup on the device. Interestingly,
666 valgrind doesn't tell us about these errors.
668 2007-05-11 Murray Cumming <murrayc@murrayc.com>
670 * scripts/build-packages: Added more precise comments about how to use
671 this script, though I still get this error:
672 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
673 error building tinymail
675 2007-05-11 Murray Cumming <murrayc@murrayc.com>
677 * src/maemo/modest-main-window.c: (on_account_update):
678 Very slight cleanup, hoping to make it simpler to discover what causes
679 a crash here sometimes.
681 * src/modest-tny-account.c:
682 (modest_tny_account_new_from_server_account): Set the port. Added
683 comments about the options and a TODO comment because I need to find out
684 how to specify the secure authentication method.
686 2007-05-11 Marcus Bauer <marcusb@openismus.com>
688 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
689 changed CFlags paths form modest to libmodest
691 2007-05-10 Murray Cumming <murrayc@murrayc.com>
693 * src/modest-account-mgr-helpers.c:
694 (modest_account_mgr_get_server_account_data),
695 (modest_account_mgr_free_server_account_data):
696 * src/modest-account-mgr-helpers.h:
697 * src/modest-account-mgr.c:
698 (modest_account_mgr_add_server_account):
700 * src/modest-tny-account.c:
701 (modest_tny_account_new_from_server_account):
702 Determine the options for tny_camel_account_add_option() here,
703 based on the settings, rather than storing them directly in gconf.
705 2007-05-10 Murray Cumming <murrayc@murrayc.com>
707 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
708 Show a more friendly error dialog now that we expect (from the tinymail
709 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
711 2007-05-10 Murray Cumming <murrayc@murrayc.com>
713 * src/maemo/modest-main-window.c: (on_account_update): Check that
714 account_name is not NULL, to prevent a crash at startup that I am
715 seeing on the N800. I do wonder why it is NULL.
717 * src/maemo/easysetup/modest-easysetup-wizard.c:
718 (create_page_user_details):
719 * src/maemo/modest-account-settings-dialog.c:
720 (create_page_user_details), (create_page_outgoing):
721 * src/maemo/modest-connection-specific-smtp-edit-window.c:
722 (modest_connection_specific_smtp_edit_window_init):
723 * src/modest-ui-actions.c:
724 (modest_ui_actions_on_password_requested):
725 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
726 might do something useful with the on-screen keyboard.
728 2007-05-10 Murray Cumming <murrayc@murrayc.com>
730 * src/maemo/modest-main-window.c: (on_account_update):
731 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
732 NULL, to avoid lots of warnings. However, it probably should not be NULL.
734 2007-05-09 Murray Cumming <murrayc@murrayc.com>
736 * src/modest-tny-account-store.c: (on_account_changed):
737 Correct the signature of this signal handler.
739 2007-05-09 Murray Cumming <murrayc@murrayc.com>
741 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
742 Show a HildonNote instead of a GtkDialog for Maemo.
744 2007-05-09 Murray Cumming <murrayc@murrayc.com>
746 * src/widgets/modest-account-view.h:
747 * src/widgets/modest-account-view.c: (on_account_changed),
748 (on_account_removed). Added a boolean flag, set/unset by
749 modest_account_view_block_conf_updates(),
750 modest_account_view_unblock_conf_updates() to prevent unnecessary
751 updates, but this is not very useful because the gconf notifications are
752 so delays (maybe only on Maemo Bora).
753 So auto-updating is turned off, and these functions do an explicit
754 update when necessary.
755 However, something else is still doing too much work when adding/removing
756 accounts, probably in another part of the application.
758 * src/maemo/modest-account-view-window.c:
759 (on_delete_button_clicked), (on_edit_button_clicked),
760 (on_new_button_clicked): Use the new functions.
762 2007-05-09 Murray Cumming <murrayc@murrayc.com>
764 * src/modest-account-mgr-helpers.c:
765 (modest_account_mgr_set_first_account_as_default):
766 Sort the list of names alphabetically-by-title, so we choose the first one
768 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
769 alphabetically by the title.
771 This fixes projects.maemo.org bug NB#56418 .
773 * src/modest-account-mgr-priv.c:
774 (_modest_account_mgr_account_from_key):
775 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
776 avoid a valgrind error, and possible random behaviour.
778 2007-05-09 Murray Cumming <murrayc@murrayc.com>
780 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
781 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
782 tinymail documentation to say that this can be expected.
783 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
784 pretty, and should not happen, but I would prefer to know when it does.
786 2007-05-09 Murray Cumming <murrayc@murrayc.com>
788 * configure.ac: When using the older hildon version, probably on Bora,
789 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
791 * src/widgets/modest-attachment-view.c:
792 (modest_attachment_view_set_part_default): Initialize variables, to fix the
795 2007-05-09 Marcus Bauer <marcusb@openismus.com>
797 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
798 Implemented the prototype. Can be tested with
799 tests/dbus_api/test_open_message:
801 2007-05-08 Murray Cumming <murrayc@murrayc.com>
803 * src/modest-tny-account-store.c:
804 (modest_tny_account_store_instance_init), (get_password):
805 * src/modest-ui-actions.c:
806 (modest_ui_actions_on_password_requested):
807 Do not store the password in gconf, because this function is called
808 for non-remembered passwords. Actually use the cached (in the hash map)
809 password instead of releasing it.
810 The password will now not be remembered if it is asked via the protected
811 password dialog, as per the UI spec.
813 2007-05-08 Murray Cumming <murrayc@murrayc.com>
816 * src/modest-account-mgr-helpers.h:
817 * src/modest-account-mgr-helpers.c:
818 Added modest_server_account_get_username_has_succeeded(),
819 modest_server_account_set_username_has_succeeded().
820 (modest_server_account_set_username),
821 Reset the has-succeeded flag if the username changes.
823 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
824 * src/maemo/modest-connection-specific-smtp-window.c:
825 (modest_connection_specific_smtp_window_save_server_accounts):
826 Use modest_server_account_set_username() instead of using
827 modest_conf_set_string() directly, so that the has-succeeded flag is always
830 * src/modest-ui-actions.c:
831 (modest_ui_actions_on_password_requested): Dim the username entry if
832 the username has ever worked, as per the UI spec.
834 2007-05-08 Murray Cumming <murrayc@murrayc.com>
836 * src/modest-tny-account-store.c: (get_password):
837 * src/modest-ui-actions.c:
838 (modest_ui_actions_on_password_requested):
839 Allow the username to be changed too, though there is more work to
840 be done on exactly how this behaves.
842 2007-05-08 Murray Cumming <murrayc@murrayc.com>
844 * src/modest-account-mgr-helpers.h:
845 * src/modest-account-mgr-helpers.c:
846 Added modest_account_mgr_get_display_name(),
847 modest_server_account_get_username(),
848 modest_server_account_set_username(),
849 modest_server_account_set_password(),
850 modest_server_account_get_hostname() functions so we do not need to
851 use the conf API directly.
853 * src/maemo/modest-main-window.c: (connect_signals):
854 Actually connect ot the ModestAccountStore::request-password signal,
855 so that we show the dialog when the password is requested by Tinymail,
856 for isntance if it is empty.
858 * src/modest-marshal.list:
859 * src/modest-tny-account-store.c:
860 (modest_tny_account_store_class_init), (get_password),
861 (modest_tny_account_store_alert):
862 * src/modest-tny-account-store.h:
863 * src/modest-ui-actions.h:
864 * src/modest-ui-actions.c:
865 (modest_ui_actions_on_password_requested):
866 Change the signal parameters, so it is obvious that we are providing
867 the non human-readable server name, and receiving both the username
868 and password, though changing of the username is not yet implemented.
869 Change the dialog UI to match the Maemo UI specifications, with #idfefing
870 for the GNOME version.
872 This should fix the projects.maemo.org bug NB#56209, though it does not
873 work on Bora, because the gconf_client_get() for the password fails
874 immediately after we save it with gconf_client_set().
876 2007-05-08 Murray Cumming <murrayc@murrayc.com>
879 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
880 caused an undefined symbol error:
881 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
883 2007-05-08 Murray Cumming <murrayc@murrayc.com>
885 * src/modest-tny-account-store.c:
886 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
887 using a GError instead of a string message, so we can translate it in
890 2007-05-08 Murray Cumming <murrayc@murrayc.com>
892 * src/maemo/modest-address-book.c:
893 (modest_address_book_check_names):
894 * src/maemo/modest-msg-view-window.c:
895 (modest_msg_view_window_clipboard_owner_change):
896 * src/modest-init.c: (modest_init_init_ui):
897 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
898 (update_folders_cb), (modest_mail_operation_update_account):
899 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
900 (modest_ui_actions_on_msg_attachment_clicked),
901 (modest_ui_actions_on_msg_recpt_activated):
902 * src/widgets/modest-header-view.c: (drag_data_get_cb):
903 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
904 (modest_msg_view_search_next):
905 * src/widgets/modest-recpt-editor.c:
906 (modest_recpt_editor_on_button_release_event),
907 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
908 g_message(). At this point we should only be seeing interesting errors on
909 stdout. Debugging messages could be #ifdefed-out if they are still useful.
911 2007-05-07 Murray Cumming <murrayc@murrayc.com>
913 (modest_wizard_dialog_force_title_update):
914 * src/maemo/easysetup/modest-wizard-dialog.h:
915 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
916 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
917 can update the title when appropriate. Otherwise the title is wrong if the
918 pages are added after adding the notebook to the dialog.
919 This must be a problem in HildonWizardDialog too.
920 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
922 * src/maemo/easysetup/modest-easysetup-wizard.c:
923 (create_subsequent_customsetup_pages),
924 (create_subsequent_easysetup_pages):
925 Call modest_wizard_dialog_force_title_update() so that the title is
926 correct even with GTK+ < 2.10.
927 This fixes projects.maemo.org bug NB#56145 .
929 2007-05-07 Murray Cumming <murrayc@murrayc.com>
931 * src/maemo/modest-platform.c:
932 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
933 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
936 2007-05-07 Murray Cumming <murrayc@murrayc.com>
938 * src/widgets/modest-window.h:
939 * src/widgets/modest-window.c: Added a save_state_func vfunc,
940 and modest_window_save_state(), which invokes it.
942 * src/widgets/modest-window-mgr.h:
943 * src/widgets/modest-window-mgr.c:
944 Added modest_window_mgr_save_state_for_all_windows(), which calls
945 the save_state vfunc on all registered windows, if implemented.
947 * src/gnome/modest-msg-edit-window.c:
948 * src/gnome/modest-msg-view-window.c:
949 * src/maemo/modest-msg-edit-window.c:
950 * src/maemo/modest-msg-view-window.c:
951 * src/maemo/modest-main-window.c:
952 Specify the existing save_settings functions as implementations of
953 ModestWindow::save_state_func().
955 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
956 Call modest_window_mgr_save_state_for_all_windows(). This happens before
957 enabling hibernation, for instance.
959 We may need to do the same thing for restoring settings.
962 2007-05-07 Murray Cumming <murrayc@murrayc.com>
964 * src/widgets/modest-window-mgr.c:
965 * src/widgets/modest-window-mgr.h:
966 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
967 modest_window_mgr_get_hibernation_is_prevented().
969 * src/maemo/modest-main-window.c:
970 (on_hildon_program_is_topmost_notify): Prevent hibernation
971 (possible when the application goes to the background in the WM),
972 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
974 * src/maemo/easysetup/modest-easysetup-wizard.c:
975 (modest_easysetup_wizard_dialog_init):
976 * src/maemo/modest-account-settings-dialog.c:
977 (modest_account_settings_dialog_init):
978 * src/maemo/modest-connection-specific-smtp-edit-window.c:
979 (modest_connection_specific_smtp_edit_window_init):
980 * src/maemo/modest-connection-specific-smtp-window.c:
981 (modest_connection_specific_smtp_window_init):
982 * src/maemo/modest-signature-editor-dialog.c:
983 (modest_signature_editor_dialog_init):
984 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
985 prevent hibernation while any of these account settings dialogs are open.
987 2007-05-04 Murray Cumming <murrayc@murrayc.com>
989 * src/maemo/Makefile.am:
990 * src/maemo/modest-osso-state-saving.c:
991 * src/maemo/modest-osso-state-saving.h: Added
992 modest_osso_load_state() and modest_osso_save_state() though they do
993 nothing now. They should iterate through all the open windows and load/save
995 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
996 save state when closing.
998 * src/maemo/modest-main-window.c:
999 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1000 Add a notification handler for the HildonProgram::is-topmost property,
1001 so we can allow hibernation when the application goes into the background.
1002 But we still need to detect when the accounts setup windows are open so
1003 we can stop hibernation when they are open.
1004 To do this, I also added the main window the HildonProgram. This might have
1005 other side-effects/benefits, and should maybe be done for other windows.
1007 * src/maemo/modest-osso-autosave-callbacks.h:
1008 * src/maemo/modest-osso-autosave-callbacks.c:
1009 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1010 though it does not do anything yet, and we might never need this to do
1011 anything. For instance, we already save drafts.
1013 * src/maemo/modest-platform.c: (modest_platform_init):
1014 Specify the libosso auto-save callback.
1016 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1018 * src/maemo/modest-platform.c:
1019 (modest_platform_set_update_interval):
1020 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1021 aparently stays valid between application instances, so we can use this
1022 to remove and reset it later. According to a maemo-developers email from
1025 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1027 * configure.ac: Depend on libalarm for Maemo.
1029 * src/dbus_api/modest-dbus-api.h:
1030 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1031 (on_send_receive), (modest_dbus_req_handler):
1032 Handle a SEND_RECEIVE D-Bus method.
1034 * libmodest-dbus-client/libmodest-dbus-client.c:
1035 (libmodest_dbus_client_send_and_receive):
1036 * libmodest-dbus-client/libmodest-dbus-client.h:
1037 Add C convenience functions for calling the new D-Bus method.
1039 * src/modest-platform.h:
1040 * src/gnome/modest-platform.c:
1041 * src/maemo/modest-platform.c:
1042 Added modest_platform_set_update_interval(), which uses the
1043 alarmd API on Maemo.
1044 (modest_platform_init),
1045 Call modest_platform_set_update_interval(), using a hard-coded
1046 interval for now (until the global settings dialog is implemented),
1047 though I am not sure that this makes sense yet.
1049 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1051 * src/dbus_api/modest-dbus-callbacks.c:
1052 (modest_osso_cb_hw_state_handler):
1053 * src/dbus_api/modest-dbus-callbacks.h:
1054 * src/maemo/modest-platform.c: (modest_platform_init):
1055 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1056 in case this has some effect on the ability for Maemo to ping the
1059 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1061 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1062 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1063 warning. It is probably a logic error, but I need to fix the build.
1065 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1067 * src/modest-account-mgr.h:
1068 * src/modest-account-mgr.c:
1069 (modest_account_mgr_account_names): Add a gboolean enabled_only
1070 parameter, so we can get lists of onlt the enabled accounts.
1072 (modest_account_mgr_add_account),,
1073 (modest_account_mgr_account_with_display_name_exists):
1074 * src/maemo/modest-msg-edit-window.c: (get_transports):
1075 * src/modest-account-mgr-helpers.c:
1076 (modest_account_mgr_set_first_account_as_default):
1077 * src/modest-init.c: (init_default_account_maybe):
1078 * src/modest-tny-account-store.c: (get_accounts):
1079 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1080 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1081 * tests/check_account-mgr.c: (START_TEST):
1082 Provide the extra parameter, as appropriate.
1084 * src/widgets/modest-account-view.c: (update_account_view):
1085 Do not show disabled accounts (meaning that there is no way to
1086 enable/disable accounts in the UI (the feature is not in our UI
1087 specification), so we can use this internally only to mark unfinished
1088 or temporary account data.
1090 * src/maemo/easysetup/modest-easysetup-wizard.c:
1091 (create_account): Add boolean enable parameter, so we can specify FALSE
1092 to create the temporary account.
1093 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1094 (on_before_next): When finishing, when there is a temporary account, just
1096 Also, use a timeout to delay the showing of the dialog until gconf is likely
1097 to return correct information, due to a maemo gconf bug that is fixed in
1098 osso 1.1, but not yet in Bora.
1099 However, the dialog stays on screen after it is destroyed.
1101 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1102 for invalid data when cancelling. Use a hildon note instead of a dialog
1103 to complain about invalid data. Do not show the account-saved note if the
1104 account is disabled (a temporary account that will not really be saved for use
1107 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1109 * src/modest-account-mgr-helpers.h:
1110 * src/modest-account-mgr-helpers.c:
1111 Added modest_account_mgr_unset_default_account(),
1112 Added modest_account_mgr_set_first_account_as_default().
1114 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1115 If it was the default account, unset the default account name.
1117 * src/maemo/modest-account-view-window.c:
1118 (on_delete_button_clicked): If it was the default account,
1119 set the first remaining account as the default instead.
1121 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1122 a NULL account or a NULL default account, to prevent a crash. This should
1123 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1126 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1128 * src/widgets/modest-recpt-editor.c:
1129 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1130 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1131 TODO comment for this. This fixes the build.
1133 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1134 be the best place for it. This will in future update all auto-update accounts,
1135 rather than just the current/default account, when that gconf key exists.
1136 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1137 if there are no accounts, before calling do_send_receive().
1138 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1140 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1141 * src/maemo/modest-main-window-ui.h:
1142 * src/maemo/modest-main-window.c: (on_connection_changed),
1143 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1144 directly, becaue the signal handler does more.
1146 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1148 * src/modest-account-mgr-helpers.c:
1149 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1150 for the case that the account does not exist.
1152 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1153 (equivalent to the modest account name) rather than the tinymail account name
1154 (equivalent to the modest account title - human readable) to get the account data.
1155 Check for null account data to prevent the crash, and add a TODO comment saying that
1156 this needs fixing because it is using the server account name instead of the account name.
1158 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1160 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1161 * src/maemo/modest-account-settings-dialog.c: (show_error),
1163 Use hildon_note_new_information() for informative and error messages,
1164 which seems to be expected for Maemo applications (no documentation that I know of
1165 says this). I am surprised that there is no distinction between info and error
1168 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1170 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1171 it is easy to find where this is used.
1173 * src/maemo/easysetup/modest-easysetup-wizard.c:
1174 (create_page_welcome), (create_page_account_details),
1175 (create_page_user_details), (create_page_complete_easysetup),
1176 (create_page_custom_incoming), (create_page_custom_outgoing),
1177 (create_page_complete_custom):
1178 * src/maemo/modest-account-settings-dialog.c:
1179 (create_page_account_details), (create_page_user_details),
1180 (create_page_incoming), (create_page_outgoing):
1181 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1182 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1183 (modest_connection_specific_smtp_edit_window_init):
1184 * src/maemo/modest-connection-specific-smtp-window.c:
1185 (modest_connection_specific_smtp_window_init):
1186 * src/maemo/modest-signature-editor-dialog.c:
1187 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1188 and scrolling policy as per the Email Application Layout Guide, if I have
1191 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1193 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1194 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1195 which were empty, because these vfuncs have been removed from TnyAccountStore.
1196 This fixes the build.
1198 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1200 * src/maemo/modest-main-window.c:
1201 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1202 showing/hiding it. Added TODO because it probably should not be NULL.
1203 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1204 because unnecessary g_warnings() make degugging difficult.
1206 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1208 * src/maemo/modest-msg-edit-window.c:
1209 (modest_msg_edit_window_select_color),
1210 (modest_msg_edit_window_select_background_color): 2 const corrections and
1211 moving 2 #endifs before closing brackets, to fix the build.
1213 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1215 * src/maemo/easysetup/modest-easysetup-wizard.h:
1216 * src/maemo/easysetup/modest-easysetup-wizard.c:
1217 (modest_easysetup_wizard_dialog_finalize),
1218 (on_button_edit_advanced_settings), (create_page_complete_custom),
1219 (on_response), (create_account):
1220 Implement the Advanced Settings edit button, by saving the account information,
1221 for the Advanded Settings dialog to use directly from gconf, and removing it
1222 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1223 Bug #5533 in the projects.maemo.org bugzilla.
1225 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1227 * src/maemo/modest-msg-view-window.c:
1228 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1229 when opening a message window.
1231 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1233 * src/maemo/easysetup/modest-easysetup-wizard.c:
1234 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1237 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1238 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1239 gconf settings. I probably added more checks than necessary, but that is safer.
1241 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1242 variable to fix the build, but this seems to be used when it is still NULL.
1244 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1246 * src/modest-platform.h:
1247 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1248 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1249 * src/modest-main.c: Implement this function so we can avoid using
1250 maemo-specific API from cross-platform code.
1252 * src/modest-tny-account-store.c:
1253 (get_smtp_specific_transport_account_for_open_connection):
1254 * src/modest-ui-actions.c: (check_for_connection),
1255 (modest_ui_actions_on_item_not_found):
1256 Use modest_platform_connect_and_wait() and put #idefs around other
1257 maemo-specific code, because only maemo currently has a way to
1258 identify connection names.
1260 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1262 * src/modest-tny-account-store.h:
1263 * src/modest-tny-account-store.c:
1264 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1265 the connection-specific SMTP server settings in the configuration.
1267 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1269 * src/maemo/modest-main-window.c: (on_connection_changed),
1271 * src/modest-main.c: (main), (start_ui), (send_mail):
1272 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1273 that is what is intended.
1275 * src/modest-ui-actions.c: (action_send), (action_receive),
1276 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1277 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1278 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1279 SMTP server is used when it is specified.
1281 (modest_ui_actions_on_send_receive):
1282 Check that a connection is open before proceeding.
1283 Receive and then send, instead of vice-versa, as per the specification.
1285 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1287 * src/modest-mail-operation.c:
1288 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1289 though I guess it should be something other than NULL.
1291 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1293 * src/maemo/easysetup/modest-easysetup-wizard.c:
1294 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1295 combo twice, to avoid an g_warning and to make it visible again.
1296 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1297 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1298 (already intended) dereference when detaching, because we then recreate the menu.
1299 But I am not sure why the warning was happening, and it is possible that this is a memory
1302 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1304 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1305 and uri_parse_mailto() utility functions.
1306 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1308 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1310 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1312 * src/dbus_api/modest-dbus-api.h:
1313 * src/dbus_api/modest-dbus-callbacks.c:
1314 Use an idle callback to execute the modest code in the application's own thread.
1315 Remove the helloworld example method.
1316 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1317 parsed, and the open-message method is not implemented because this is not yet implemented in
1319 * libmodest-dbus-client/libmodest-dbus-client.c:
1320 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1321 (libmodest_dbus_client_open_message):
1322 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1324 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1325 body without crashing.
1327 * tests/dbus_api/Makefile.am:
1328 * tests/dbus_api/test_mail_to.c:
1329 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1331 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1333 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1334 Added file to fix the build. Sorry.
1336 * src/dbus_api/Makefile.am:
1337 * src/dbus_api/modest-dbus-api.h:
1338 * src/dbus_api/modest-dbus-callbacks.h:
1339 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1340 (modest_dbus_req_handler):
1341 Put constants in a separate header so it can be reused by the
1342 client library, without duplication
1344 * libmodest-dbus-client/Makefile.am:
1345 * libmodest-dbus-client/libmodest-dbus-client.c:
1346 (libmodest_dbus_client_call_helloworld),
1347 (libmodfest_dbus_client_send_mail),
1348 (libmodfest_dbus_client_mailto),
1349 (libmodfest_dbus_client_open_message):
1350 * libmodest-dbus-client/libmodest-dbus-client.h:
1351 (Partly) Implement a send_mail D-Bus method.
1353 * tests/dbus_api/Makefile.am:
1354 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1355 the send_email D-Bus method.
1357 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1361 * libmodest-dbus-client/Makefile.am:
1362 * libmodest-dbus-client/libmodest-dbus-client.c:
1363 * libmodest-dbus-client/libmodest-dbus-client.h:
1364 * tests/dbus_api/Makefile.am:
1365 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1366 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1368 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1370 * src/maemo/easysetup/modest-easysetup-wizard.c:
1371 (create_page_account_details):
1372 * src/maemo/modest-account-settings-dialog.c:
1373 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1374 widgets, because this might not be the default in future versions of the Maemo GTK+.
1375 However, I can not not get capitalization to work even in a simple test case.
1377 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1379 * src/maemo/easysetup/modest-easysetup-wizard.c:
1380 (create_page_custom_incoming), (create_page_custom_outgoing):
1381 * src/maemo/modest-account-settings-dialog.c:
1382 (create_page_account_details), (create_page_incoming),
1383 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1384 instead of using gtk_check_button_with_label(), so they are aligned like the other
1385 widgets, as per the UI spec.
1387 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1389 * src/maemo/easysetup/modest-easysetup-wizard.c:
1390 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1391 * src/widgets/modest-validating-entry.c:
1392 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1393 Modest prefix instead of an EasySetup prefix.
1395 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1397 * src/widgets/modest-validating-entry.h:
1398 * src/widgets/modest-validating-entry.c: (on_insert_text),
1399 Added easysetup_validating_entry_set_max_func(), used to set a callback
1400 to call when the max number of characters is reached. GtkEntry has a max-length
1401 already but is silent about it.
1403 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1404 (create_page_account_details), (create_page_user_details),
1406 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1407 (create_page_account_details), (create_page_user_details),
1408 (create_page_outgoing):
1409 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1410 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1411 the UI spec, when the user tries to enter more than the max number of characters.
1413 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1415 * src/maemo/easysetup/modest-easysetup-wizard.c:
1416 (create_page_user_details), (create_page_custom_incoming),
1417 (create_page_custom_outgoing):
1418 * src/maemo/modest-account-settings-dialog.c:
1419 (create_page_user_details), (create_page_incoming),
1420 (create_page_outgoing):
1421 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1422 (modest_connection_specific_smtp_edit_window_init):
1423 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1424 not appropriate. Bad Maemo-specific defaults!.
1426 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1428 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1429 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1430 (modest_signature_editor_dialog_set_settings):
1431 Disable the label and textview when the checkbox is disabled, and use the
1432 specified (UI spec) default signature text.
1434 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1436 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1437 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1439 * src/modest-defs.h:
1440 * src/modest-account-mgr-helpers.h:
1441 * src/modest-account-mgr-helpers.c:
1442 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1444 * src/maemo/Makefile.am:
1445 * src/maemo/modest-signature-editor-dialog.c:
1446 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1449 * src/maemo/modest-account-settings-dialog.h:
1450 * src/maemo/modest-account-settings-dialog.c:
1451 (modest_account_settings_dialog_finalize), (on_button_signature),
1452 (save_configuration): Use the new dialog when the Edit button is pressed, and
1453 save the changes if necessary, as per the UI spec.
1455 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1457 * src/maemo/Makefile.am:
1458 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1459 based on maemo-develoers email from Dirk.
1461 * src/maemo/easysetup/modest-easysetup-wizard.c:
1462 (create_page_welcome), (create_page_account_details),
1463 (create_page_user_details), (create_page_complete_easysetup),
1464 (create_page_custom_incoming), (create_page_custom_outgoing),
1465 (create_page_complete_custom),
1466 (modest_easysetup_wizard_dialog_init):
1467 * src/maemo/modest-account-settings-dialog.c:
1468 (create_page_account_details), (create_page_user_details),
1469 (create_page_incoming), (create_page_outgoing),
1470 (modest_account_settings_dialog_init):
1471 * src/maemo/modest-connection-specific-smtp-window.c:
1472 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1474 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1476 * src/maemo/easysetup/modest-easysetup-wizard.c:
1477 (create_page_account_details), (create_page_custom_outgoing),
1478 (create_page_complete_custom):
1479 * src/maemo/modest-account-settings-dialog.c:
1480 (create_page_user_details), (create_page_incoming),
1481 (create_page_outgoing):
1482 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1483 (modest_connection_specific_smtp_edit_window_init):
1484 Use the correct (UI spec) port min/max, and use horizontal separators,
1487 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1489 * src/maemo/easysetup/modest-easysetup-wizard.c:
1490 (set_default_custom_servernames):
1491 * src/maemo/modest-account-settings-dialog.c:
1492 (create_page_incoming), (on_combo_outgoing_security_changed),
1493 (on_combo_incoming_security_changed), (create_page_outgoing),
1494 (modest_account_settings_dialog_set_account_name),
1495 (save_configuration):
1496 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1497 (on_combo_security_changed),
1498 (modest_connection_specific_smtp_edit_window_init),
1499 (modest_connection_specific_smtp_edit_window_set_connection),
1500 (modest_connection_specific_smtp_edit_window_get_settings):
1501 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1504 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1507 * src/maemo/easysetup/modest-easysetup-wizard.c:
1508 (create_page_custom_outgoing), (create_page_complete_custom):
1509 * src/maemo/modest-account-settings-dialog.c:
1510 (create_page_user_details), (create_page_outgoing):
1511 * src/maemo/modest-account-view-window.c: (button_box_new):
1512 Use changed logical IDs as per the most recent UI spec:
1513 mcen_bd_emailsetup_edit -> mcen_bd_edit
1514 mcen_bd_emailsetup_delete -> mcen_bd_delete
1515 mcen_bd_emailsetup_close -> mcen_bd_close
1517 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1521 * src/dbus_api/Makefile.am:
1522 * src/dbus_api/modest-dbus-callbacks.c:
1523 * src/dbus_api/modest-dbus-callbacks.h:
1524 * src/maemo/modest-platform.c: (modest_platform_init):
1525 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1527 * tests/Makefile.am:
1528 * tests/dbus_api/Makefile.am:
1529 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1531 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1533 * src/maemo/modest-account-settings-dialog.c:
1534 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1535 Removed unnecessary includes.
1537 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1539 * src/maemo/easysetup/modest-easysetup-wizard.c:
1540 * src/maemo/modest-account-settings-dialog.c:
1541 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1542 * src/widgets/Makefile.am:
1543 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1544 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1545 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1546 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1547 * src/widgets/modest-secureauth-combo-box.c:
1548 * src/widgets/modest-secureauth-combo-box.h:
1549 * src/widgets/modest-serversecurity-combo-box.c:
1550 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1551 made the GObject names more consistent with the rest of the Modest code.
1553 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1555 * src/maemo/easysetup/Makefile.am:
1556 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1557 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1558 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1559 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1560 * src/maemo/easysetup/modest-easysetup-wizard.c:
1561 * src/maemo/easysetup/modest-validating-entry.c:
1562 * src/maemo/easysetup/modest-validating-entry.h:
1563 * src/maemo/modest-account-settings-dialog.c:
1564 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1565 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1566 widgets/ because they are used outside of easysetup too. After checking in,
1567 svn will allow me to rename them too.
1569 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1571 * src/gnome/modest-msg-edit-window.c:
1572 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1573 linker error, to fix the build on the GNOME platform.
1574 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1575 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1576 ifdefed out to avoid a warning.
1578 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1580 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1581 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1582 some alternative for GTK+ 2.6.
1584 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1586 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1588 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1589 specified for EmailAccountsDialog in UI spec.
1591 * src/maemo/easysetup/modest-easysetup-wizard.c:
1592 * src/maemo/easysetup/modest-easysetup-wizard.h:
1593 * src/maemo/modest-account-settings-dialog.c:
1594 * src/maemo/modest-account-settings-dialog.h:
1595 Reuse a member window widget for the connection-specific SMTP server accounts,
1596 so we can tell it to create/save the accounts only if we actually save changes.
1598 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1599 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1600 (modest_connection_specific_smtp_edit_window_get_settings):
1601 Return a struct instance for temporarily remembering the entered data.
1603 * src/maemo/modest-connection-specific-smtp-window.h:
1604 * src/maemo/modest-connection-specific-smtp-window.c:
1605 (modest_connection_specific_smtp_window_finalize),
1606 (modest_connection_specific_smtp_window_fill_with_connections),
1608 (modest_connection_specific_smtp_window_save_server_accounts),
1609 (update_model_server_names): Do not actually save data until asked,
1610 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1612 (on_selection_changed),
1613 (modest_connection_specific_smtp_window_init): Disable the edit
1614 button when nothing is selected.
1616 * src/modest-account-mgr-helpers.c:
1617 * src/modest-account-mgr-helpers.h:
1618 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1621 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1623 * src/modest-account-mgr-helpers.h:
1624 * src/modest-account-mgr-helpers.c:
1625 (modest_account_mgr_get_unused_account_name),
1626 (modest_account_mgr_get_unused_account_display_name): Added these
1627 utility functions, to avoid code duplication.
1629 * src/maemo/easysetup/modest-easysetup-wizard.c:
1630 (create_page_account_details), (create_account):
1631 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1632 (on_combo_security_changed),
1633 (modest_connection_specific_smtp_edit_window_init),
1634 (modest_connection_specific_smtp_edit_window_save_settings):
1635 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1636 * src/maemo/modest-connection-specific-smtp-window.c:
1637 (modest_connection_specific_smtp_window_finalize),
1638 (modest_connection_specific_smtp_window_fill_with_connections),
1639 (on_button_edit), (modest_connection_specific_smtp_window_init):
1640 * src/maemo/modest-connection-specific-smtp-window.h:
1641 Implementing saving of connection-specific server accounts.
1643 But I need to refactor this so we can save the data for each
1644 possible connection-specific account and only actually create the server accounts
1645 when the easysetup finished, or the OK button is pressed on the account settings
1648 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1650 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1651 (on_combo_security_changed):
1652 (modest_connection_specific_smtp_edit_window_init):
1653 Auto-fill the port number as in the account settings.
1655 (modest_connection_specific_smtp_edit_window_set_connection):
1656 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1657 * src/maemo/modest-connection-specific-smtp-window.c:
1658 (fill_with_connections), (on_button_edit),
1659 (modest_connection_specific_smtp_window_init):
1660 Turn the edit window into a dialog to simplify the code, and
1661 set a WM hint as in a GtkDialog, because only a popup can be on top of
1662 another window in Maemo, and popups usually have no WM decoration.
1664 * src/modest-defs.h:
1665 * src/modest-account-mgr-helpers.c:
1666 (modest_account_mgr_set_connection_specific_smtp),
1667 (modest_account_mgr_remove_connection_specific_smtp),
1668 (modest_account_mgr_get_connection_specific_smtp):
1669 * src/modest-account-mgr-helpers.h: Some functions to write the
1670 connection-specific SMTP server information. Not yet used.
1673 * src/widgets/modest-folder-view.c: (text_cell_data):
1674 Fix a warning about an uninitialized variable.
1675 (on_configuration_key_changed): Put an #ifdef around the use
1676 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1678 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1680 * src/maemo/modest-account-settings-dialog.h:
1681 * src/maemo/modest-account-settings-dialog.c:
1682 Added connect_for_modified() utility function to mark the new modified boolean.
1684 (create_page_account_details), (create_page_user_details),
1685 (create_page_incoming), (create_page_outgoing), (on_response),
1686 (modest_account_settings_dialog_init),
1687 (modest_account_settings_dialog_set_account_name):
1688 Only warn about unsaved changes when there are actually unsaved changes.
1690 * src/modest-account-mgr-helpers.c:
1691 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1692 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1693 to get the data from there in future.
1695 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1697 * src/modest-defs.h:
1699 * src/modest-account-mgr-helpers.h:
1700 * src/modest-account-mgr-helpers.c:
1701 Store the security account setting in a single conf key instead of using
1702 the options list, so that the list is left for just the to-be-removed camel hack,
1703 and because gconf_client_set_list() is failing for some reason.
1705 * src/modest-account-mgr.c:
1706 (modest_account_mgr_add_server_account):
1707 * src/maemo/modest-account-settings-dialog.c:
1708 (modest_account_settings_dialog_set_account_name),
1709 (save_configuration): Use the renamed functions.
1712 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1714 * src/widgets/Makefile.am:
1715 * src/widgets/modest-limit-retrieve-combo-box.c:
1716 * src/widgets/modest-limit-retrieve-combo-box.h:
1717 * src/widgets/modest-retrieve-combo-box.c:
1718 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1719 the account settings dialog.
1721 * src/modest-defs.h:
1722 * src/modest-account-mgr-helpers.h:
1723 * src/modest-account-mgr-helpers.c:
1724 (modest_server_account_get_option_secure_auth),
1725 (modest_server_account_set_option_secure_auth):
1726 * src/modest-account-mgr.c:
1727 (modest_account_mgr_add_server_account):
1728 Use the existing AUTH_MECH conf key for the secure-auth setting,
1729 instead of putting it in the list options, because this was actually used already.
1731 * src/maemo/modest-account-settings-dialog.c:
1732 (create_page_account_details),
1733 (modest_account_settings_dialog_set_account_name),
1734 (save_configuration):
1735 * src/maemo/modest-account-settings-dialog.h:
1736 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1737 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1739 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1741 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1742 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1743 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1745 * src/modest-defs.h:
1746 * src/maemo/modest-account-settings-dialog.c:
1747 (create_page_incoming), (on_combo_outgoing_security_changed),
1748 (on_combo_incoming_security_changed), (create_page_outgoing),
1749 (modest_account_settings_dialog_set_account_name),
1750 (save_configuration): Load/Save the port number, and change it when the
1751 security combo changes, to suitable defaults.
1753 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1755 * src/modest-account-mgr.c:
1756 (modest_account_mgr_add_server_account): Set the security and secure-auth
1757 options, and add a comment saying that the other camel-specific options should be
1760 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1762 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1764 * src/modest-tny-account-store.c: (account_list_free),
1765 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1766 cursor->data after unreffing it. But there is some strange stuff there so it might not be
1769 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1771 * src/modest-protocol-info.c:
1772 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1773 is required by our UI spec. Maybe something in our implementation will use this eventually.
1774 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1775 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1776 instead of the previous 0 placeholder.
1778 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1779 secure-auth settings.
1780 * src/modest-account-mgr-helpers.h:
1781 * src/modest-account-mgr-helpers.c:
1782 (modest_server_account_data_get_option_secure_auth),
1783 (modest_server_account_set_option_secure_auth),
1784 (modest_server_account_data_get_option_security),
1785 (modest_server_account_set_option_security): Added this API for getting and setting the security
1786 and secure-auth settings.
1788 * src/maemo/modest-account-settings-dialog.h:
1789 * src/maemo/modest-account-settings-dialog.c:
1790 (modest_account_settings_dialog_finalize), (check_data),
1791 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1792 about changing titles.
1793 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1794 (save_configuration): Save the security and secure-auth settings.
1796 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1797 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1799 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1801 * src/modest-defs.h:
1802 * src/modest-account-mgr.c:
1803 (modest_account_mgr_add_server_account):
1804 Added and used defines for the options key and value pair strings,
1805 that are used so far, though they do not seem to correspond to anything in our
1806 UI specs or ModestProtocol enum.
1808 * src/modest-account-mgr-helpers.h:
1809 * src/modest-account-mgr-helpers.c:
1810 (compare_option_strings_for_name),
1811 (modest_server_account_data_get_option_value),
1812 (modest_server_account_data_get_option_bool),
1813 (modest_account_mgr_get_server_account_option):
1814 Added helper functions for parsing the options GSList.
1816 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1818 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1819 display name is based on the supplied account name.
1820 * src/modest-account-mgr.c:
1821 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1822 with an inefficient, but good-enough, implementation.
1824 * src/maemo/easysetup/modest-easysetup-wizard.c:
1825 (create_page_account_details), (on_before_next), (create_account):
1826 Check for existing display names rather than (non-user-visible) account names, and just
1827 create and set a unique account name at the end.
1829 * src/maemo/modest-account-settings-dialog.c:
1830 (modest_account_settings_dialog_init),
1831 (modest_account_settings_dialog_set_account_name),
1832 (create_page_incoming): Show the display name, instead of the account name.
1833 (on_response): Do some (not all) extra checks, as in the UI spec.
1834 (save_configuration): Save the display name if it was changed.
1836 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1838 * po/en_GB.po: Added needed logical ID and translation.
1839 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1840 (init_view): Made the is-default column clicking work.
1842 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1845 * src/maemo/easysetup/Makefile.am:
1846 * src/maemo/easysetup/modest-easysetup-wizard.c:
1847 (modest_easysetup_wizard_dialog_init):
1848 * src/maemo/easysetup/provider-data-test.keyfile:
1849 * src/maemo/easysetup/provider-data.keyfile:
1850 Moved the provider data file to the new modest-providers-data package and used it from there.
1852 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1854 * src/modest-local-folder-info.c:
1855 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1856 N_() was already used on the static strings, but this just marks it for translation without
1857 using the translation.
1859 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1861 * src/maemo/modest-account-settings-dialog.c:
1862 (create_page_incoming),
1863 (modest_account_settings_dialog_set_account_name):
1864 Added comments about the need for new API in ModestAccountMgr to handle the authentication
1865 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1866 I will do this if nobody else gets there first.
1868 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1870 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1871 Saved much of the incoming and outgoing data too, though I cannot yet see how to
1872 save the security stuff.
1874 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1876 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1877 Set the email address and user fullname, which I now see must be
1880 * src/maemo/modest-account-settings-dialog.h:
1881 * src/maemo/modest-account-settings-dialog.c:
1883 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1884 leave-on-server and authentication.
1885 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1888 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1891 * src/maemo/modest-account-settings-dialog.c:
1892 * src/maemo/modest-account-settings-dialog.h:
1893 Most (but not all) of the widgets are now present as specified by the UI spec.
1894 No changes are yet saved, and some details are not properly shown yet.
1896 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1898 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1900 * src/maemo/Makefile.am:
1901 * src/maemo/modest-account-settings-dialog.c:
1902 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1903 an existing account. Doesn't do much yet.
1905 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1906 Open the accounts settings dialog when Edit is clicked.
1908 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1910 * src/maemo/easysetup/Makefile.am:
1911 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1913 * src/maemo/easysetup/modest-easysetup-wizard.c:
1914 (modest_easysetup_wizard_dialog_init):
1915 Try to get the source directory from the build system,
1916 instead of hard-coding "./" into the source code, when opening our local
1917 copies of the configuration files.
1918 But this still fails when opening the wizard from the Accounts window,
1919 maybe because the working directory seems to change at runtime.
1920 So the wizard will fail the second time unless you copy the files into their
1921 proper locations - see the stdout warnings for the paths.
1923 (create_page_account_details),(on_before_next):
1924 Check for existing non-server accounts instead of server accounts,
1925 so the default account name is useful again, and to prevent trying to
1928 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1929 Show the wizard when New is clicked.
1931 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1932 (init_view): Show the column headers, and show the columns that are
1933 specified in the UI specs. However, something in Maemo's GTK+ prevents
1934 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1935 change the default account. This is despite unsetting the special properties.
1937 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1939 * docs/reference/modest-design.sgml: Corrected spelling mistake.
1940 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1941 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1942 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1943 to make that clearer.
1944 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1946 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1948 * src/maemo/modest-account-view-window.c:
1949 (modest_account_view_window_init),
1950 (modest_account_view_window_new):
1951 Use the same buttons as specified in the
1952 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1953 the existing widgets, which never had a chance of working.
1954 Put the ModestAccountView treeview in a scrolled window.
1955 Do not repeat the initialization in both _init() and _new().
1957 * src/widgets/modest-account-view.c: (update_account_view):
1958 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1959 this widget and window shows no accounts.
1961 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1963 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1965 * src/maemo/easysetup/modest-easysetup-wizard.c:
1966 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1967 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1968 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1971 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1972 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1973 accounts exist yet, as in the UI spec.
1975 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
1977 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1979 * src/maemo/Makefile.am:
1980 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1981 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1982 New window for editing connection-specific smtp details.
1983 Not fully implemented.
1985 * src/maemo/modest-connection-specific-smtp-window.c:
1986 (modest_connection_specific_smtp_window_finalize) :
1987 unref the tree model.
1988 (on_button_edit): Show the edit window.
1990 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1992 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
1995 * src/maemo/Makefile.am:
1996 * src/maemo/modest-connection-specific-smtp-window.c:
1997 * src/maemo/modest-connection-specific-smtp-window.h:
1998 New window for showing the list of connections, for connection-specific
1999 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2000 * src/maemo/easysetup/modest-easysetup-wizard.c:
2001 (create_page_custom_outgoing): Show the new window when the button is clicked.
2003 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2005 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2006 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2007 * src/maemo/modest-msg-edit-window.c:
2008 (modest_msg_edit_window_insert_image):
2009 * src/modest-conf.c: (modest_conf_key_escape):
2010 * src/modest-mail-operation.c:
2011 (modest_mail_operation_send_new_mail):
2012 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2013 (modest_ui_actions_on_new_account):
2014 * src/widgets/modest-attachment-view.c: (update_filename_request):
2015 * src/widgets/modest-mail-header-view.c:
2016 Corrected warnings that were breaking the build, by commenting out unused variables,
2017 and a function, and by including a header.
2019 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2021 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2022 so we can #ifdef around platform-specific code when necessary.
2023 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2024 to allow this to build for the GNOME platform too.
2026 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2028 * src/maemo/easysetup/modest-easysetup-wizard.c:
2029 Added util_increment_name() and used it in create_page_account_details()
2030 to make sure that the default account name is always a new name.
2032 (modest_easysetup_wizard_dialog_init),
2033 (set_default_custom_servernames): Some minor memory management fixes.
2035 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2039 * src/modest-runtime.c: (init_i18n): Restored the translation
2040 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2041 are defined in config.h, and the translations are installed.
2043 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2044 is defined for translation.
2046 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2048 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2050 * src/maemo/easysetup/modest-easysetup-wizard.c:
2051 (modest_easysetup_wizard_dialog_init):
2052 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2053 Use realistic paths (though they should use $prefix generically) to the
2054 mcc_mapping and provider-data.keyfile files which might work when they
2055 are installed by the future version of the operator-wizard package,
2056 and then fallback to paths in our source code, with an explanatory
2059 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2063 * src/maemo/Makefile.am:
2064 * src/maemo/easysetup/: Added files from the previously-exernal
2065 osso-modest-easysetup.
2066 * src/maemo/modest-main-window-ui.h:
2067 * src/modest-ui-actions.c:
2068 * src/modest-ui-actions.h:
2069 Added modest_ui_actions_on_new_account() as a signal handler for the
2070 New Account menu item. It shows the easysetup wizard.
2071 * po/en_GB.po: Added additional needed logical IDs and translations.
2073 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2074 Apparently ChangeLog is not used for some vague Nokia legal reasons.