1 2007-07-12 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-tny-account-store.h:
4 * src/modest-tny-account-store.c:
5 Added modest_tny_account_store_forget_password_in_memory(),
6 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
7 when creating a new account, so that new passwords will be used, instead of
8 us thinking that it's a second request as a result of a failed password again.
10 2007-07-12 Murray Cumming <murrayc@murrayc.com>
12 * src/dbus_api/modest-dbus-callbacks.c:
13 (on_idle_open_message): If the message is in drafts then open it
14 in an edit window instead of a view window. This fixes
15 projects.maemo.org bug NB#63005.
17 2007-07-12 Murray Cumming <murrayc@murrayc.com>
19 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
20 Avoided a harmless g_warning().
22 2007-07-12 Murray Cumming <murrayc@murrayc.com>
24 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
25 Pass the modest account name, not the TnyAccount display name to
26 modest_msg_view_window_new() so that the reply feature works,
27 fixing projects.maemo.org bug NB#62892.
29 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
30 (modest_msg_view_window_new_with_header_model):
31 * src/maemo/modest-msg-view-window.c:
32 (modest_msg_view_window_new_with_header_model),
33 (modest_msg_view_window_new):
34 * src/modest-ui-actions.c: (reply_forward):
35 * src/widgets/modest-msg-view-window.h:
36 * src/widgets/modest-window.c: (modest_window_set_active_account):
37 Rename an account parameter to modest_account_name to make this clearer.
39 2007-07-11 Murray Cumming <murrayc@murrayc.com>
41 * src/modest-ui-actions.h:
42 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
43 modest_do_message_delete().
44 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
45 Call modest_do_message_delete(), hoping that this would cause messages
46 to be really deleted from search instead of just marked with strike through.
47 Does not seem to help.
49 2007-07-11 Armin Burgmeier <armin@openismus.com>
51 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
52 priv->reselect to FALSE prior to calling
53 modest_folder_view_select_first_inbox_or_local() to prevent endless
54 recursion and thus a crash on startup.
56 2007-07-11 Armin Burgmeier <armin@openismus.com>
58 * src/maemo/modest-account-settings-dialog.h: Include
59 <gtk/gtknotebook.h> to fix the build (at least for me).
61 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
62 Use "New FolderN" as default suggested name if "New folder" already
63 exists, with N being the first free number, though never exceed "New
64 folder99" in which case we just fall back to "New Folder" even though
65 it already exists. This fixes projects.maemo.org bug NB#58663.
67 2007-07-11 Murray Cumming <murrayc@murrayc.com>
69 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
70 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
71 projects.maemo.org bug NB#62778.
73 2007-07-11 Murray Cumming <murrayc@murrayc.com>
75 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
76 Ignore the wrong (for now) secure-smtp setting in the presets -
77 just default to requiring secure authentication for SMTP, because
80 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
82 * src/widgets/modest-folder-view.c: (filter_row)
83 Do not show drafts folder (see UI specs)
85 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
87 * src/modest-ui-actions.c:
88 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
89 place and also not necessary.
91 * src/widgets/modest-folder-view.c: (filter_row)
92 Guess folder type and hide Sent & Outbox if necessary.
93 Fixed project.maemo.org NB#57328
95 2007-07-11 Murray Cumming <murrayc@murrayc.com>
97 * src/modest-ui-actions.h:
98 * src/modest-ui-actions.c:
99 (modest_ui_actions_on_delete_message):
100 Move some code into a new
101 modest_ui_actions_refresh_message_window_after_delete()
102 function so we can use it from elsewhere.
104 * src/dbus_api/modest-dbus-callbacks.c:
105 (on_idle_delete_message), (on_delete_message): Used an idle
106 handler, as we do for the other D-Bus method handlers.
107 Call modest_ui_actions_refresh_message_window_after_delete()
108 if the deleted message was open in a window. This fixed
109 projects.maemo.org bug NB#62862.
111 2007-07-11 Murray Cumming <murrayc@murrayc.com>
113 * src/modest-main.c: (main): Only show the UI at the start if
114 the showui command line option was given. For instance,
115 run-standalone src/modest showui
116 Otherwise, we wait for the top_application D-Bus method to
117 be sent by hildon-desktop when the application is selected
119 This allows us to run without a UI when osso-global-search
120 uses our D-Bus methods.
122 2007-07-11 Murray Cumming <murrayc@murrayc.com>
124 * src/dbus_api/modest-dbus-api.h: Added a define for a
125 top-application D-Bus method.
126 * src/dbus_api/modest-dbus-callbacks.c:
127 (on_top_application),
128 (modest_dbus_req_handler): Handle the top-application D-Bus
129 method, which might be an undocumented D-Bus signal sent by
130 hildon-desktop when it starts the application from the menu.
131 But I am not sure and I need to test it on the device, because
132 my scratchbox does not have the application in the menu now.
133 This method shows the main window, so that it can be invisible
134 when started, for instance, just for email searching from
137 * src/maemo/modest-main-window.c: (restore_settings),
138 (modest_main_window_new): Do not show the window immediately
139 upon creation. We show it later.
140 * src/modest-widget-memory.c: (save_settings_paned):
141 Try (unsuccessfully) to avoid saving the paned position when
142 it is not even visible.
143 (restore_settings_paned): Do not allow a silly paned position.
144 This seems necessary when not showing the window at first.
146 * tests/dbus_api/Makefile.am:
147 * tests/dbus_api/test_top_application.c: (main): Test for the
150 2007-07-10 Murray Cumming <murrayc@murrayc.com>
152 * src/modest-ui-dimming-rules.c:
153 (modest_ui_dimming_rules_on_new_msg),
154 (modest_ui_dimming_rules_on_reply_msg),
155 (modest_ui_dimming_rules_on_delete_msg),
156 (modest_ui_dimming_rules_on_details),
157 (modest_ui_dimming_rules_on_view_window_move_to),
158 (modest_ui_dimming_rules_on_view_previous),
159 (modest_ui_dimming_rules_on_view_next),
160 (_invalid_folder_for_purge): Added checks before
161 casting the window. This looks like an actual
162 logic error in _invalid_folder_for_purge(), because it
163 tries to use a ModestMainWindow as a message window.
165 2007-07-10 Murray Cumming <murrayc@murrayc.com>
167 * src/maemo/modest-account-settings-dialog.c:
168 (show_error): Use the same implementation as in
169 modest-easysetup-wizard.c:
170 (on_entry_invalid_character): The logical ID contains a %s.
171 Guessed what it should be.
172 (on_entry_max), (check_data), (on_response): Adapt to
173 changed show_error().
174 (create_page_account_details): Really call
175 modest_validating_entry_set_func() on the correct widgets.
176 * src/maemo/easysetup/modest-easysetup-wizard.c:
177 (on_entry_invalid_character): Fix the logical ID here too.
178 (create_page_account_details),
179 (create_page_user_details):
181 modest_validating_entry_set_func() on the correct widgets.
183 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
184 Do not try to use the account if it is NULL.
186 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
188 * src/modest-ui-actions.c: (create_move_to_dialog),
189 (modest_ui_actions_on_main_window_move_to),
190 (modest_ui_actions_on_msg_view_window_move_to):
191 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
192 (filter_row), (modest_folder_view_show_non_move_folders):
193 * src/widgets/modest-folder-view.h:
195 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
196 the Sent folder yet as it does not report the correct folder type.
198 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
200 * src/maemo/modest-msg-edit-window.c: (init_window):
203 2007-07-10 Murray Cumming <murrayc@murrayc.com>
205 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
206 Take a parent widget instead of a parent window, and
207 implement this with hildon_banner_show_information() instead.
208 Non-Maemo builds can just ifdef that there.
209 This fixed projects.maemo.org bug NB#62766.
211 (on_entry_invalid_character): Use show_error() again instead
212 of using hildon directly, and use the _CS() macro to use the correct
214 (create_account), (check_for_supported_auth_methods), (on_entry_max):
215 Pass a widget instead od a window to show_error().
217 2007-07-10 Murray Cumming <murrayc@murrayc.com>
219 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
220 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
221 This allows us to show the server name in the error message, fixing
222 projects.maemo.org bug NB#62904.
223 Also, use the appropriate logical ID message for the account protocol.
225 2007-07-10 Murray Cumming <murrayc@murrayc.com>
227 * src/modest-tny-account-store.c: (on_idle_wrong_password):
228 A compilation fix, though the build wasn't broken for me.
230 2007-07-09 Murray Cumming <murrayc@murrayc.com>
232 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
233 Do not try to unref a NULL folder store, to avoid a runtime warning.
234 This seems to happen sometimes when changing accounts settings.
236 2007-07-09 Murray Cumming <murrayc@murrayc.com>
238 * src/modest-tny-account-store.c:
239 (modest_tny_account_store_instance_init),
240 (modest_tny_account_store_finalize),
241 (on_account_settings_hide), (on_idle_wrong_password):
242 Use a GHashTable to ensure that we only show one account settings
243 dialog per modest account. This avoids us having a dialog open for
244 both the store and transport accounts, or due to repeated get_password()
245 calls that shouldn't happen anyway.
247 2007-07-09 Murray Cumming <murrayc@murrayc.com>
249 * src/maemo/modest-maemo-utils.c: (on_hide),
250 (modest_maemo_show_dialog_and_forget): Handle the response, because
251 the window is not even hidden by default.
253 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
254 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
255 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
256 which seems to prevent some modality problems.
258 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
259 Ignore user cancellation errors.
261 * src/modest-account-mgr-helpers.h:
262 * src/modest-account-mgr-helpers.c:
263 Added modest_server_account_get_password() and
264 modest_server_account_get_has_password() to avoid direct use of
267 * src/maemo/modest-account-settings-dialog.h:
268 * src/maemo/modest-account-settings-dialog.c:
269 (modest_account_settings_dialog_init): Store the notebook so we can
271 Added modest_account_settings_dialog_switch_to_user_info().
273 * src/modest-tny-account-store.c:
274 (get_password): When the password in the account settings is wrong (we think),
275 show the relevant page of the account settings dialog, in the mainloop.
276 However, we currently get many of these at once because cancel does not
278 (forget_password): Do not forget the password
279 from the account settings, because this causes side-effects when
280 tinymail seems to call it at strange time, maybe because of how we
281 are cancelling get_password().
282 (modest_tny_account_store_alert): Ignore user cancellations.
284 2007-07-09 Murray Cumming <murrayc@murrayc.com>
286 * src/maemo/modest-maemo-utils.h:
287 * src/maemo/modest-maemo-utils.c:
288 Added modest_maemo_show_information_note_and_forget() for use instead of
289 gtk_dialog_run() when the response is not needed, to avoid an extra
290 mainloop which could cause a hang.
292 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
293 Use the logical IDs for the error message, though they are not
294 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
295 because gtk_dialog_run() caused a hang here (the window did not close).
296 This fixes projects.maemo.org bug NB#62646.
298 2007-07-09 Murray Cumming <murrayc@murrayc.com>
300 * src/modest-account-mgr-helpers.h:
301 * src/modest-account-mgr-helpers.c:
302 Added modest_account_mgr_get_store_protocol().
304 * src/maemo/modest-account-view-window.c:
305 (on_delete_button_clicked): Show different warning text depending on
306 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
307 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
310 2007-07-09 Murray Cumming <murrayc@murrayc.com>
312 * src/maemo/modest-msg-edit-window.c:
313 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
314 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
316 2007-07-07 Armin Burgmeier <armin@openismus.com>
318 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
319 ckdg_ib_maximum_characters_reached from correct package.
321 * src/modest-ui-actions.c: Show an error message when a folder could
322 not be created. Tinymail does not give us specific error codes about
323 what has gone wrong, so we assume that a folder with that name
324 already exists, though there might be other reasons.
326 2007-07-06 Murray Cumming <murrayc@murrayc.com>
328 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
329 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
330 give a more exact error message that can be partly translated.
332 2007-07-05 Murray Cumming <murrayc@murrayc.com>
334 * src/maemo/modest-address-book.c:
335 (select_email_addrs_for_contact): Specify a default window size for the
336 select-email-address dialog, so that it is probably big enough for the
337 title. This should fix projects.maemo.org bug NB#62277.
339 2007-07-05 Murray Cumming <murrayc@murrayc.com>
341 * src/maemo/easysetup/modest-easysetup-wizard.c:
342 (create_page_complete_easysetup): Use
343 gtk_widget_set_size() request to ensure that the text wraps
346 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
348 * src/maemo/easysetup/modest-easysetup-wizard.c:
349 (on_entry_invalid_character), (create_page_account_details),
350 (create_page_user_details):
351 Use new API of ModestValidatingEntry. But for some reason the banner is
352 not shown. I will have to investigate that further.
354 * src/widgets/modest-validating-entry.c: (on_insert_text),
355 (modest_validating_entry_set_func):
356 * src/widgets/modest-validating-entry.h:
357 Added a new callback function to be able to react to prevented
358 characters whitespaces to e.g show a banner.
360 2007-07-05 Armin Burgmeier <armin@openismus.com>
362 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
363 notification of HildonNumberEditor instead of remembering the port
364 number. Thanks to Johannes for pointing this out.
366 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
368 * src/maemo/easysetup/modest-easysetup-wizard.c:
369 Check if there are any user changes before showing a confirmation
370 dialog (projects.maemo.org NB#60946)
372 2007-07-05 Armin Burgmeier <armin@openismus.com>
374 * src/maemo/modest-account-settings-dialog.c: Remember custom port
375 number at the beginning of the dialog and set the modified flag at the
376 end if the port number has changed. This is necessary because
377 HildonNumberEditor does not support notification when the value has
380 2007-07-05 Murray Cumming <murrayc@murrayc.com>
382 * src/modest-ui-actions.c:
383 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
384 a connection before asking anything else. Correct the check for the destination
385 folder so that it succeeds when online.
386 This fixed projects.maemo.org bug NB#61645.
388 2007-07-05 Murray Cumming <murrayc@murrayc.com>
390 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
391 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
392 to fix projects.maemo.org bug NB#62439.
394 2007-07-05 Murray Cumming <murrayc@murrayc.com>
396 * src/modest-tny-account.c: (on_connection_status_changed):
397 Really do not use tny_device_force_offline() here. See the previous comment.
399 2007-07-04 Murray Cumming <murrayc@murrayc.com>
401 * src/modest-tny-account.c: (on_connection_status_changed):
402 Do not use tny_device_force_offline() when tinymail says that something
403 went wrong with the connection. It seems to report this unnecessarily.
405 2007-07-04 Murray Cumming <murrayc@murrayc.com>
407 * src/maemo/modest-connection-specific-smtp-window.c:
408 (modest_connection_specific_smtp_window_init):
409 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
410 does not seem to have any effect in osso 1.1 (though it works in
411 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
413 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
415 * src/maemo/modest-connection-specific-smtp-window.c:
416 Fix UI specification problems with projects.meamo.org NB#60479
418 2007-07-04 Murray Cumming <murrayc@murrayc.com>
420 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
421 clue when this has failed, because the error dialog is not always shown
422 (at least in earlier version).
424 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
425 GError message, because the generic error dialog is not helpful.
427 'This message is not currently available (can't let a new connection go online)'
428 when trying to open an IMAP message.
430 (_modest_ui_actions_open): Offer a connection when some messages would
431 have to be downloaded and we are offline.
433 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
435 * src/widgets/modest-folder-view.c:
436 Don't check for MERGE type anymore as we use the correct type
438 NOTE: For the last two changes you need to update your tinymail copy
439 because of API changes!
441 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
443 * src/modest-tny-local-folders-account.c:
444 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
445 (see projects.maemo.org NB#61580)
447 2007-07-04 Murray Cumming <murrayc@murrayc.com>
449 * src/modest-tny-account.c: (on_connection_status_changed):
450 Commented out the call to modest_platform_connect_and_wait() because this
451 seems to always hang, and I would like to know if this is the only thing
452 that causes a hang when showing the connection dialog.
453 It is not very useful anyway.
455 2007-07-04 Murray Cumming <murrayc@murrayc.com>
457 * src/maemo/modest-msg-view-window.c:
458 (modest_msg_view_window_select_next_message):
460 * src/modest-platform.h:
461 * src/maemo/modest-platform.c:
462 Added modest_platform_connect_and_wait(), which calls
463 tny_maemo_conic_device_connect() always in the main thread, by calling it
464 in an idle handler and waiting for the idle handler to run. It should be
465 in the main thread because it uses GTK+ UI code. It just returns TRUE
466 if the device is already online.
468 There is some nasty code to ensure that subsequent calls to
469 modest_platform_connect_and_wait() just wait for the first one to finish,
470 by checking repeatedly in another idle handler. This is necessary,
471 because other threads (or even the main thread, via another idle handler)
472 can call modest_platform_connect_and_wait() while
473 modest_platform_connect_and_wait() is running.
475 (modest_platform_connect_and_wait_if_network_account),
476 (modest_platform_connect_and_wait_if_network_folderstore):
477 Convenience functions that calls modest_platform_connect_and_wait() if
478 the account or folder might want network access.
480 * src/modest-mail-operation.c:
481 (modest_mail_operation_update_account):
482 * src/modest-ui-actions.c: (download_uncached_messages),
483 (modest_ui_actions_on_rename_folder), (delete_folder),
484 (modest_ui_actions_on_main_window_move_to),
485 (modest_ui_actions_on_msg_view_window_move_to):
486 * src/widgets/modest-folder-view.c:
487 (drag_and_drop_from_folder_view):
488 Offer a connection if we are offline.
490 * src/modest-tny-account.c: (on_connection_status_changed):
491 Document this as only handling errors during network operations in progress,
492 and replace the idle code with a simple call to
493 modest_platform_connect_and_wait(), which does this instead.
495 2007-07-03 Murray Cumming <murrayc@murrayc.com>
497 * src/modest-tny-account.c:
498 (modest_tny_account_get_special_folder): (util_on_idle),
499 Handle the GError so we can see when tny_folder_store_get_folders()
500 fails, as it currently does while something else is connecting.
502 Added util_run_in_main_thread_and_wait()
503 which uses an idlen handler and mainloop to ensure that the function
504 is called in the main thread.
505 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
506 to make sure that we call attempt the connection in the mainloop only,
507 which might solve some hangs.
509 2007-07-03 Murray Cumming <murrayc@murrayc.com>
511 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
512 be found by their display name. This is never useful.
513 * src/modest-tny-account-store.c: (on_account_removed): Find the account
514 by its ID, instead of trying to use its ID as its display name.
516 * src/modest-tny-account-store.h:
517 * src/modest-tny-account.c:
518 (modest_tny_account_get_special_folder): Add a g_warning() when
519 tny_folder_store_get_folders() returns an empty list for the maildir.
521 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
522 Add a g_warning() when this returns NULL, because that it not allowed
525 2007-07-02 Armin Burgmeier <armin@openismus.com>
527 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
528 note when trying to cancel the wizard. This fixes projects.maemo.org
531 2007-07-02 Murray Cumming <murrayc@murrayc.com>
533 * src/modest-tny-account.h:
534 * src/modest-tny-account.c:
535 (modest_tny_account_new_from_server_account),
536 (modest_tny_account_new_from_server_account_name),
537 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
538 because this must now be set before setting the proto. This is usd in
539 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
540 warning in camel_session_get_service() caused by
541 tny_camel_transport_account_prepare().
543 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
546 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
548 * src/maemo/modest-connection-specific-smtp-edit-window.c:
550 (modest_connection_specific_smtp_edit_window_init):
552 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
555 2007-06-29 Murray Cumming <murrayc@murrayc.com>
557 * src/modest-tny-account.c:
558 (modest_tny_account_new_from_server_account):
559 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
560 now uses to request a connection when it needs one, and which it uses
561 to tell us that something is wrong with the connection, so we can force
562 the accounts offline to prevent further problems.
565 * src/modest-init.c: (init_default_settings):
566 * src/modest-mail-operation.c:
567 (modest_mail_operation_update_account):
568 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
569 This should not be necessary anymore. Do not set the conf key that
570 determined this (it was always TRUE and not set anywhere else).
572 * src/modest-ui-actions.h: Remove unused and unimplemented
573 modest_ui_actions_on_online_toggle_toggled().
575 2007-06-29 Murray Cumming <murrayc@murrayc.com
577 * src/maemo/modest-main-window.c: (connect_signals):
578 Don't connect to delete_event twice. Maybe this was harmless.
580 2007-06-29 Murray Cumming <murrayc@murrayc.com
582 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
583 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
584 Debug output to give some more clue when a folder move is not allowed.
586 2007-06-28 Murray Cumming <murrayc@murrayc.com
588 * src/modest-tny-account.c: (on_modest_file_system_info),
589 (modest_tny_account_get_mmc_account_name):
590 Always call the callback, without checking whether the name has changed.
591 * src/widgets/modest-folder-view.c: (strings_are_equal),
592 (on_model_foreach_set_name), (on_get_mmc_account_name),
593 (text_cell_data): Compare the name here, and use the name from
594 the account rather than from the
595 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
596 if the name was changed after the account was added to the model.
597 That's a tinymail bug but not one that I want to fix now.
599 This finally fixes projects.maemo.org bug NB#59301.
601 2007-06-27 Armin Burgmeier <armin@openismus.com>
603 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
606 2007-06-27 Murray Cumming <murrayc@murrayc.com
608 * src/modest-tny-account.h:
609 * src/modest-tny-account.c:
610 Added modest_tny_account_get_mmc_account_name(), to set the memory
611 card name asynchronously for the given account and then notify.
612 (modest_tny_account_new_for_local_folders): Use this new function instead
613 of using hildon_file_system_info_async_new() directly.
615 * src/widgets/modest-folder-view.c: (text_cell_data):
616 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
617 gtk_tree_model_row_changed() when it is available.
619 This should fix projects.maemo.org bug NB#59301.
621 2007-06-27 Murray Cumming <murrayc@murrayc.com
623 * src/modest-mail-operation.c: (update_account_thread),
624 (get_msgs_full_thread): Fix typo failures in the revert
627 2007-06-27 Murray Cumming <murrayc@murrayc.com
629 * src/maemo/modest-maemo-global-settings-dialog.c:
630 (idle_select_default_focus):
631 * src/modest-mail-operation.c: (idle_notify_progress),
632 (idle_notify_progress_once), (set_last_updated_idle),
633 (update_account_thread), (get_msgs_full_thread):
634 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
635 * src/widgets/modest-header-view.c:
636 (idle_notify_headers_count_changed_destroy),
637 (idle_notify_headers_count_changed):
638 Reverted the additions of gdk_threads_enter/leave(), in case this
639 helps with a startup hang on the device.
641 2007-06-26 Armin Burgmeier <armin@openismus.com>
643 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
644 for supported secure authentication methods from server by
645 gtk_dialog_run(), saving CPU time and a potential race condition.
647 2007-06-26 Armin Burgmeier <armin@openismus.com>
649 * src/maemo/modest-maemo-utils.h:
650 * src/maemo/modest-maemo-utils.c: Added a
651 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
652 only error code to tell the calling code when the user canceled the
655 * src/maemo/modest-account-settings-dialog.h:
656 * src/maemo/modest-account-settings-dialog.c:
657 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
658 message if the retrieval of secure authentication methods was canceled
659 by the user. Perform the check before saving anything to configuration
660 to not end up with half-committed configuration changes, do not show
661 a "Saving to configuration failed" note when authentication methods
662 could not be retrieved.
664 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
667 2007-06-26 Murray Cumming <murrayc@murrayc.com>
669 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
670 Only return the first level of folders under accounts, because the
671 osso-global-search UI spec doesn't want the rest.
672 This fixed projects.maemo.org bug NB#61811.
674 2007-06-26 Murray Cumming <murrayc@murrayc.com>
676 * src/modest-tny-account-store.c:
677 * src/modest-tny-account-store.h:
678 Added modest_tny_account_is_memory_card_account().
679 * src/maemo/modest-main-window.c: (create_details_widget):
680 Show the same information items for the memory card as we show for the
681 local-folders, to fix projects.maemo.org bug NB#59307.
683 2007-06-26 Murray Cumming <murrayc@murrayc.com>
685 * src/modest-tny-account-store.c: (get_password):
686 Added some checks for NULL to maybe prevent crashes, though I think
687 it was Philip's last commit that actually prevented the crash here
688 when creating a first new account.
689 But the new account is still not usable (no messages are shown)
690 until a restart of the application.
692 2007-06-26 Murray Cumming <murrayc@murrayc.com>
694 * src/maemo/modest-maemo-global-settings-dialog.c:
695 (idle_select_default_focus):
696 * src/modest-mail-operation.c: (idle_notify_progress),
697 (idle_notify_progress_once), (idle_notify_update_account_queue),
698 (set_last_updated_idle), (update_account_thread),
699 (notify_get_msgs_full), (get_msgs_full_destroyer),
700 (get_msgs_full_thread):
701 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
702 * src/widgets/modest-header-view.c:
703 (idle_notify_headers_count_changed_destroy),
704 (idle_notify_headers_count_changed):
705 Use gdk_threads_enter() and gdk_threads_enter_leave() in
706 all idle handlers, because some other thread could be blocking
707 the GDK lock, so that it can do GUI stuff.
709 2007-06-26 Murray Cumming <murrayc@murrayc.com>
711 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
712 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
713 (on_idle_send_receive), (on_idle_open_default_inbox):
714 * src/maemo/modest-msg-edit-window.c:
715 (modest_msg_edit_window_attach_file_noninteractive):
716 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
717 to prevent a hang. I don't quite understand why these are necessary,
718 beause we should already be in the main loop. I guess something outside
719 of the main loop is taking the lock.
721 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
722 we are really using URIs, and use files that are more likely to exist.
724 2007-06-26 Murray Cumming <murrayc@murrayc.com>
726 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
727 necessary because configure.ac now defines different variables.
729 2007-06-26 Murray Cumming <murrayc@murrayc.com>
731 * libmodest-dbus-client/libmodest-dbus-client.c:
732 * libmodest-dbus-client/libmodest-dbus-client.h:
733 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
734 libmodest_dbus_client_compose_mail() is what things actually use.
736 * src/dbus_api/modest-dbus-api.h:
737 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
738 * tests/dbus_api/Makefile.am:
739 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
742 2007-06-26 Murray Cumming <murrayc@murrayc.com>
744 * src/modest-init.c: (modest_init_local_folders):
745 For memory-card (or other non local-folders) maildir accounts,
746 always create an Archive folder, so that there is somewhere to put
747 messages. This should be less confusing, because the user does not need
748 to guess that the need to create a folder.
750 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
752 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
753 Fixed icon size by using (50, 50) which is the same as defined by
756 2007-06-25 Armin Burgmeier <armin@openismus.com>
758 * src/widgets/modest-window-mgr.c:
760 * configure.ac: Correctly recognize hildon-notify presence and fixed
761 the build without it being installed.
763 2007-06-25 Murray Cumming <murrayc@murrayc.com>
765 * libmodest-dbus-client/libmodest-dbus-client.c:
766 (libmodest_dbus_client_search): Fix the build. Sorry.
767 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
768 (reply_forward_cb): Initialize variables to fix the build.
770 * src/modest-tny-account-store.c:
771 (modest_tny_account_store_get_tny_account_by): Fix the account URI
772 comparison (a silly typo) so that email search results can be opened
773 when there are more than one account.
775 2007-06-25 Murray Cumming <murrayc@murrayc.com>
777 * libmodest-dbus-client/libmodest-dbus-client.c:
778 (libmodest_dbus_client_search),
779 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
780 instead of 1 second, because the search gets folders and messages from
781 the server, which can take a long time. When it times out,
782 osso-global-search will report no results.
784 We need to specify whether we should search only cached information
785 (maybe with a user preference), and the osso-email-search-plugin
786 API should really be improved to allow that option, and to allow results
787 to be delivered asynchronously in batches.
789 2007-06-25 Murray Cumming <murrayc@murrayc.com>
791 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
792 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
793 GTK_ICON_SIZE_DIALOG is probably the wrong size.
795 2007-06-25 Murray Cumming <murrayc@murrayc.com>
797 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
798 that is an empty string. D-Bus seems to give us these instead of NULL.
800 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
802 * src/dbus_api/modest-dbus-callbacks.c:
803 * src/maemo/easysetup/modest-easysetup-wizard.h:
804 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
805 * src/maemo/modest-connection-specific-smtp-edit-window.c:
806 (modest_connection_specific_smtp_edit_window_init):
807 * src/maemo/modest-maemo-global-settings-dialog.c:
809 * src/maemo/modest-maemo-utils.c:
810 (modest_maemo_utils_setup_images_filechooser):
811 * src/maemo/modest-main-window.c: (create_details_widget):
812 * src/maemo/modest-msg-edit-window.c:
813 (modest_msg_edit_window_attach_file_noninteractive),
814 (modest_msg_edit_window_color_button_change),
815 (modest_msg_edit_window_set_zoom):
816 * src/modest-mail-operation.c: (update_account_thread):
817 * src/modest-tny-account-store.c:
818 * src/modest-tny-account.c:
819 * src/widgets/modest-global-settings-dialog.c:
820 * src/widgets/modest-window.h:
824 2007-06-25 Murray Cumming <murrayc@murrayc.com>
826 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
827 * src/modest-search.c: (modest_search_folder),
828 (modest_search_all_accounts): Actually search only in the specified folder,
829 doing a simple match on the folder ID.
830 * src/modest-search.h: Added a folder field to the ModestSearch struct,
831 and added some documentation.
833 2007-06-22 Armin Burgmeier <armin@openismus.com>
835 * src/maemo/modest-maemo-utils.h:
836 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
837 modest_maemo_utils_get_supported_secure_authentication_methods.
839 * src/maemo/easysetup/modest-easysetup-wizard.c:
840 * src/maemo/modest-account-settings-dialog.c: Show correct error if
841 one occured, not just "Server does not support secure authentication".
843 2007-06-22 Murray Cumming <murrayc@murrayc.com>
845 * src/modest-tny-account-store.c: (get_password):
846 Restored the call to tny_account_set_user() because Philip seems to have
847 stopped this from crashing (by not using the freed string). It still does
848 not work, but now we can test it.
850 2007-06-22 Murray Cumming <murrayc@murrayc.com>
852 * src/maemo/modest-msg-edit-window.c: (init_window):
853 Comment out use of an uninitialzed GtkScrolledWindow variable,
854 to fix the build and stop a crash. Yet again.
856 2007-06-22 Murray Cumming <murrayc@murrayc.com>
858 * src/modest-tny-account-store.c: (get_password):
859 Remove the call to tny_account_set_user() because this actually crashes.
860 As mentioned in the last commit, it is known to not work anyway.
862 2007-06-22 Murray Cumming <murrayc@murrayc.com>
864 * src/modest-tny-account-store.c: (get_password):
865 Use tny_account_set_username() to tell tinymail that the username might
866 have changed too. But tinymail ignores this: see projects.maemo.org
868 * src/modest-ui-actions.c:
869 (modest_ui_actions_on_password_requested): Remove the useless attempt to
870 reset the connection when changing the username, and improve the comments.
871 Save the changed username to gconf at least, so it is used when Modest is
874 2007-06-21 Murray Cumming <murrayc@murrayc.com>
876 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
877 Do not use a query, so that we get all folders, including for POP and
878 local-folders. They work as search criteria too.
879 This fixes projects.maemo.org bug NB#57740.
881 2007-06-21 Murray Cumming <murrayc@murrayc.com>
883 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
884 Comment out the use of hildon_notification_set_sound() because it is
885 not declared, to fix the build. Warnings are serious, people.
887 2007-06-21 Armin Burgmeier <armin@openismus.com>
889 * src/maemo/modest-maemo-utils.h:
890 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
891 modest_maemo_utils_get_supported_secure_authentication_methods()
892 to query authentication methods for a specific user. This should fix
893 projects.maemo.org bug NB#61369.
895 * src/maemo/easysetup/modest-easysetup-wizard.c:
896 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
899 2007-06-21 Murray Cumming <murrayc@murrayc.com>
901 * libmodest-dbus-client/libmodest-dbus-client.h:
902 * libmodest-dbus-client/libmodest-dbus-client.c:
903 (modest_dbus_message_iter_get_search_hit),
904 (libmodest_dbus_client_search):
905 Reorganised and commented this.
906 Removed modest_search_hit_free() from the public API because it
909 Added libmodest_dbus_client_get_folders() and
910 modest_folder_result_list_free().
912 * src/dbus_api/modest-dbus-api.h:
913 * src/dbus_api/modest-dbus-callbacks.c:
914 (modest_dbus_req_filter): Commented. Moved most code to
915 on_dbus_method_search() and added on_dbus_method_get_folders().
917 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
918 of the extra D-Bus handler.
920 * tests/dbus_api/Makefile.am:
921 * tests/dbus_api/test_get_folders.c: New test for
922 libmodest_dbus_client_get_folders(). This seems to return an empty list
923 at the moment. That could be the same error that causes the message list
924 to be empty sometimes.
925 This should help with projects.maemo.org bug NB#57740.
927 2007-06-21 Armin Burgmeier <armin@openismus.com>
929 * src/modest-mail-operation.c: Do not call
930 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
931 notify the operation's end after having set the status to CANCELED for
932 the operation queue to listen on. This fixes a deadlock when there
933 were mail operations in the queue during its finalization.
935 * src/modest-singletons.c: Reordered uninitialization of the account
936 manager to happen after the mail operation queue was uninitialized
937 because the mail operation's in the queue might still try to access
938 the account manager (see modest_mail_operation_notify_end()). This
939 fixes a potential crash when terminating the application.
941 2007-06-21 Murray Cumming <murrayc@murrayc.com>
943 * src/modest-search.c:
944 (search_mime_part_and_child_parts): Moved some code here so we
945 can search recursively in child folders.
946 (modest_search_folder): Search in the message as a mime part, instead
947 of just its child mime parts.
948 (read_chunk), (search_mime_part_ogs):
949 Check how many bytes were read, to prevent an endless loop.
950 Searching in message bodies now works. This finishes the fix for
951 projects.maemo.org bug NB#61007.
953 2007-06-20 Murray Cumming <murrayc@murrayc.com>
955 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
956 Add a g_warning when the item is not a folder.
958 * src/modest-ui-dimming-rules.c:
959 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
960 when selected item is not a folder (for instance, an account), because
961 the UI spec only talks about folders.
962 I am not sure what the UI spec wants, so this might not totally fix
963 projects.maemo.org bug NB#60794.
965 2007-06-20 Murray Cumming <murrayc@murrayc.com>
967 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
968 (load_from_file): Sort the list. The unsorted list would be more noticeable
969 in non-English locales.
971 * src/maemo/modest-msg-edit-window.c:
972 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
973 warning and fix the build.
975 * src/maemo/modest-progress-bar-widget.c:
976 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
977 avoid a g_warning, and probably to avoid a crash.
979 2007-06-20 Murray Cumming <murrayc@murrayc.com>
981 * src/modest-search.c: (modest_search_folder): Check for a GError
982 when calling tny_folder_get_headers(), to show that this is not the cause
985 2007-06-20 Murray Cumming <murrayc@murrayc.com>
987 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
988 Actually set the body query instead of the subject query.
990 * src/modest-search.c: (search_mime_part_ogs),
991 (search_mime_part_strcmp): Remove extra space from the text/* regex,
992 which would probably cause it to fail if we got this far.
994 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
995 to simplify the code.
996 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
997 be causing search-in-body to fail.
999 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1001 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1003 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1004 Better debug message when the folder cannot be found.
1005 This should help with fixing projects.maemo.org bug #61287.
1006 * src/modest-search.c: (add_hit): Do not leak the furl string.
1008 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1010 * src/modest-ui-actions.c:
1011 (modest_ui_actions_on_folder_selection_changed):
1012 Do not special-case TNY_MERGE_FOLDER here, because
1013 modest_tny_folder_get_account() already does that. This fixes
1014 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1015 shown when the Outbox was selected).
1017 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1019 * libmodest-dbus-client/libmodest-dbus-client.c:
1020 (_dbus_iter_get_string_or_null): Initialize the string variable in
1021 case this helps with Dirk's crash.
1023 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1025 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1026 though it is not implemented yet (this function is maybe not even used),
1027 to avoid breaking ABI in future.
1028 * libmodest-dbus-client/libmodest-dbus-client.c:
1029 (get_attachments_string): Moved some code into this generic function.
1030 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1031 sends email. It is maybe not used.
1032 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1033 (on_send_mail): Use attachments.
1035 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1036 * src/maemo/modest-msg-edit-window.c:
1037 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1038 a filename before using it, to fix projects.maemo.org bug NB#58233.
1040 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1042 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1043 Initialize the continue_download variable to fix the build, and probably
1044 to fix randome behaviour.
1046 2007-06-18 Armin Burgmeier <armin@openismus.com>
1048 * src/modest-tny-send-queue.h:
1049 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1050 the queue so we can later show it in the UI. Replaced
1051 modest_tny_send_queue_msg_is_being_sent() by
1052 modest_tny_send_queue_get_msg_status().
1054 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1056 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1057 gpointer. This probably was not harmful, but just to be sure.
1059 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1061 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1062 Fix the build, but leave the function broken on Bora, because
1063 hildon_uri_action_get_service() does not exist.
1064 osso_uri_action_get_service() does not exist either, it seems.
1066 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1068 * src/modest-tny-account.c:
1069 (modest_tny_account_new_from_server_account):
1070 Uncommented the url debug output again, because it is useful for
1071 debugging, as I said in the comment.
1073 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1075 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1077 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1078 for Mameo Bora, to fix the build.
1080 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1083 Fixed build with hildon < 0.99
1085 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1086 Check if the selected account is busy instead of checking all accounts
1088 * src/modest-account-mgr-priv.h:
1089 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1090 (modest_account_mgr_init), (compare_account_name),
1091 (modest_account_mgr_set_account_busy),
1092 (modest_account_mgr_account_is_busy):
1093 * src/modest-account-mgr.h:
1094 Added busy information to the account manager. It possible to
1095 set an account to busy or not busy now.
1097 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1098 (modest_mail_operation_update_account),
1099 (modest_mail_operation_notify_end):
1100 Set the account to busy/not busy depending on the operation state.
1102 * src/widgets/modest-account-view.c:
1103 (modest_account_view_finalize), (get_last_updated_string),
1104 (update_account_view), (on_account_busy_changed), (init_view):
1105 Show string "Refreshing..." if the account is currently busy.
1107 All this fixes projects.maemo.org bug NB#59711
1109 2007-06-14 Armin Burgmeier <armin@openismus.com>
1111 * src/widgets/modest-attachments-view.h:
1112 * src/widgets/modest-attachments-view.c: Added
1113 modest_attachments_view_has_attachments() and fixed coordinate
1114 transformation in get_att_view_at_coords(). This fixes attachment
1117 * src/widgets/modest-msg-view.c: Make use of
1118 modest_attachments_view_has_attachments() to decide whether to show
1119 attachments in the header.
1121 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1123 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1124 (on_change), (on_combo_security_changed),
1125 (modest_connection_specific_smtp_edit_window_init),
1126 (modest_connection_specific_smtp_edit_window_set_connection),
1127 (modest_connection_specific_smtp_edit_window_is_dirty):
1128 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1129 * src/maemo/modest-connection-specific-smtp-window.c:
1132 Show an comfirmation dialog for the smpt-edit-window if there are
1133 unsaved changes and the user hits cancel.
1134 (projects.maemo.org bug NB#60479)
1136 2007-06-14 Armin Burgmeier <armin@openismus.com>
1138 * src/maemo/easysetup/modest-easysetup-wizard.c:
1139 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1140 address" info in banner instead of node, and select all the text as
1141 per UI spec. This fixes projects.maemo.org bug NB#60550.
1143 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1145 reviewed by: <delete if not using a buddy>
1147 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1148 * src/modest-ui-actions.c: (folder_refreshed_cb):
1150 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1152 * src/widgets/modest-folder-view.c: (filter_row):
1153 Explictly filter out the per-account outbox accounts. I don't know why
1154 these only sometimes show up, but now they should never show up in the UI.
1155 This should fix projects.maemo.org bug NB#60160.
1157 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1159 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1160 when the toolbar does not exist yet.
1161 * src/modest-widget-memory.c: (save_settings_header_view):
1162 Added g_warnings() to help us to discover when we are trying to set
1163 an empty columns list in gconf.
1165 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1167 * src/modest-init.h:
1168 * src/modest-init.c:
1169 Added modest_init_get_default_header_view_column_ids().
1171 * src/modest-widget-memory.c: (restore_settings_header_view):
1172 Use the new function to get defaults, if the gconf key is empty,
1173 instead of not creating any columns. This seems to fix the
1174 empty right-hand pane problems.
1176 * src/widgets/modest-header-view.h: Improved documentation.
1178 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1180 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1181 Revert the use of the display name as the account name, because this
1182 is generally wrong and would break the code that follows.
1184 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1186 * src/maemo/easysetup/modest-easysetup-wizard.c:
1187 (check_for_supported_auth_methods), (on_before_next),
1190 More correct fix for projects.maemo.org bug NB# 58991
1191 Do not longer accept AUTH_PASSWORD as secure method and choose
1192 correct method when creating the account.
1194 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1196 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1197 Fixed projects.maemo.org bug NB# 58991
1199 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1201 * src/modest-init.c: (modest_init_init_core),
1202 (modest_init_local_folders): Fixed compilation errors.
1204 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1206 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1207 Remove unnecessary lib/include, though it is good in principle when needed.
1209 * src/modest-init.c: (modest_init_one_local_folder),
1210 (modest_init_local_folders):
1211 * src/modest-init.h: Initialize the .modest library for memory cards,
1212 instead of just doing nothing for them. This should allow us to create
1213 folders there, fixing projects.maemo.org bug NB#59297.
1215 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1217 * libmodest-dbus-client/libmodest-dbus-client.c:
1218 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1219 (libmodest_dbus_client_compose_mail),
1220 (libmodest_dbus_client_open_message),
1221 (libmodest_dbus_client_send_and_receive),
1222 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1224 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1225 (on_idle_open_message), (modest_dbus_req_handler),
1226 (search_result_to_message), (modest_dbus_req_filter):
1227 * src/modest-search.c: (add_hit), (modest_search_folder),
1228 (modest_search_all_accounts): Improved debug messages.
1230 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1232 * src/modest-tny-account-store.c:
1233 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1236 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1239 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1241 * src/modest-tny-account-store.c: (get_server_accounts):
1242 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1243 even when there are no accounts, so that the Outbox folder is always
1244 visible. This fixes projects.maemo.org bug NB#60158.
1246 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1248 * src/maemo/modest-main-window.c: (create_details_widget):
1249 Use the mcen_va_never logical ID.
1251 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1253 * src/dbus_api/modest-dbus-api.h:
1254 * src/dbus_api/modest-dbus-callbacks.c:
1255 (on_idle_open_default_inbox), (on_open_default_inbox),
1256 (modest_dbus_req_handler):
1257 Added a new OpenDefaultInbox method.
1259 * libmodest-dbus-client/libmodest-dbus-client.h:
1260 * libmodest-dbus-client/libmodest-dbus-client.c:
1261 Added libmodest_dbus_client_open_default_inbox() to call the new
1262 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1263 though it should maybe be used by a new osso-email-interface function.
1265 * tests/dbus_api/Makefile.am:
1266 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1269 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1271 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1272 NULL, so that the signals get all the keys. This should not actually
1273 change any behaviour because we currently update everything when anything
1276 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1278 * src/widgets/modest-folder-view.c: (text_cell_data),
1279 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1280 (find_inbox_iter): If tinymail tells us that the folder is
1281 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1282 This causes the inbox to be selected at startup, fixing part of
1283 projects.maemo.org bug NB#56305.
1285 * src/modest-ui-dimming-rules.c:
1286 (modest_ui_dimming_rules_on_tools_smtp_servers):
1287 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1288 the SMTP servers menu item.
1289 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1290 that the SMTP Servers menu item is dimmed when there are no accounts,
1291 as a future version of the UI spec will require. This fixes
1292 projects.maemo.org bug NB#56305.
1294 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1296 * src/maemo/modest-maemo-utils.c:
1297 (modest_maemo_utils_get_supported_secure_authentication_methods):
1298 Added label to dialog instead of unreadable title
1300 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1301 (modest_main_window_new):
1302 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1305 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1306 * src/modest-account-mgr.h:
1307 Added method to avoid code duplication
1309 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1310 (modest_ui_actions_on_send_receive):
1311 Use modest_account_mgr_has_accounts
1313 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1315 * src/maemo/easysetup/modest-presets.c:
1316 (modest_presets_get_info_server_security): Do not report secure auth
1318 * src/modest-protocol-info.c: Use the defines for the gconf key names
1319 for secure authentication. This was not working because we were writing
1320 Password and reading password, and the check was case sensitive.
1321 With this, gmail now works for receiving and sending when created via
1324 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1326 * src/maemo/easysetup/modest-presets.c:
1327 (modest_presets_get_info_server_security): Correct the key name for
1328 SecureSmtp, because it seems to be case-sensitive.
1329 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1330 Do not try to get the 0th notebook page if there are 0 pages, to
1331 avoid a g_warning().
1333 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1335 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1336 Prevent use of the new notification feature for now, because it currently
1337 shows one dialog for each new email, which is annoying.
1339 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1341 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1342 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1343 when no country was selected, so that we show the global ones.
1344 * src/maemo/easysetup/modest-presets.c:
1345 (modest_presets_get_providers): Return only the global providers, not
1346 all providers when mmc=0 was requested.
1348 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1350 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1351 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1352 provider ID in the combo.
1354 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1355 Do not show the page numbers, because it would be confusing when we add
1356 the 2 extra pages for the custom setup, when the user chooses the "Other"
1357 provider. This fixes projects.maemo.org bug NB#59028
1359 * src/modest-init.c: (modest_init_init_core),
1360 (modest_init_local_folders):
1361 * src/modest-init.h:
1362 * src/modest-tny-account.c:
1363 (modest_tny_account_new_for_local_folders): Do not create default folders
1364 for the memory card. This should fix projects.maemo.org bug NB#59328.
1366 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1368 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1369 Free the changed_conf_keys string items. They are already freed in the
1370 idle handler if that runs first.
1372 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1374 * src/modest-ui-actions.c:
1375 (modest_ui_actions_on_password_requested): Check that the server name
1376 is not NULL, because I just saw a password dialog with (null) as the
1379 * src/modest-tny-folder.[h|c]: Added
1380 modest_tny_folder_is_memory_card_folder().
1381 * src/modest-ui-dimming-rules.c:
1382 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1383 menu item for memory cards, as per the UI spec (section 7.4). This should
1384 fix projects.maemo.org bug NB#59297.
1386 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1388 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1389 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1390 is another problem with the code, see Murray's comment at line 772)
1392 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1394 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1395 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1396 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1397 (load_from_file), (easysetup_country_combo_box_init),
1398 (easysetup_country_combo_box_get_active_country_ids),
1399 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1400 instead of just one ID, to avoid duplicate country names in the UI.
1402 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1403 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1404 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1405 a single ID, avoiding duplicate providers.
1406 * src/maemo/easysetup/modest-easysetup-wizard.c:
1407 (on_combo_account_country): Adapt to use a list.
1409 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1411 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1412 keys changed in the last X seconds.
1414 * src/modest-account-mgr.h:
1415 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1416 (on_key_change), (modest_account_mgr_class_init),
1417 (modest_account_mgr_init), (modest_account_mgr_finalize):
1418 As the keys are changed, save them in a GSList* and signal that GSList*
1419 further every X seconds, to batch changes, to allow us to do just one
1420 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1421 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1423 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1424 changed signal signature.
1426 * src/modest-conf.c: (modest_conf_set_list),
1427 (modest_conf_on_change): Reenable notification.
1429 (modest_conf_maemo_fake_on_change): Comment out the hack that
1430 notified immediately instead of asynchronously.
1432 * src/widgets/modest-account-view.h:
1433 * src/widgets/modest-account-view.c:
1434 (update_account_view): Select the previously-selected account ID,
1435 if possible. This fixes projects.maemo.org bug NB#56933.
1437 (on_account_changed), (on_account_removed),
1438 (modest_account_view_select_account):
1440 Remove the block/unblock functions
1441 because they were not useful.
1443 * src/maemo/modest-account-view-window.c:
1444 (on_delete_button_clicked), (on_edit_button_clicked),
1445 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1447 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1449 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1450 Improve the error dialog to show Incorrect Account Settings, which seems
1451 clearer, and say that the internal error message (to be removed from the
1452 dialog later) is often misleading.
1453 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1455 * src/modest-tny-account.c:
1456 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1457 URL because this is so useful for debugging on the device.
1459 * src/widgets/modest-serversecurity-combo-box.c:
1460 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1462 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1464 * src/modest-mail-operation.c:
1465 (modest_mail_operation_send_new_mail):
1466 Added a comment about a nasty but apparently harmless message. Details
1467 added to the wiki g_warnings() page.
1469 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1471 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1472 (modest_tny_send_queue_class_init):
1473 Do not use the priv struct because it is empty, to avoid g_warnings
1474 about a non-existant priv struct.
1476 * src/modest-tny-account-store.c:
1477 (modest_tny_account_store_get_server_account),
1478 (modest_tny_account_store_get_transport_account_for_open_connection
1479 ): Do not try to get transport server accounts for local folders,
1480 because they don't have any. This avoids a g_warning().
1482 * src/maemo/modest-main-window.c:
1483 (modest_main_window_notify_send_receive_initied),
1484 (on_configuration_key_changed):
1485 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1486 * src/modest-defs.h:
1487 * src/modest-mail-operation.c:
1488 (modest_mail_operation_update_account):
1489 * src/modest-tny-account-store.h:
1490 * src/modest-tny-account.c:
1491 (modest_tny_account_get_special_folder),
1492 (modest_tny_account_new_for_local_folders),
1493 (modest_tny_account_new_for_per_account_local_outbox_folder):
1494 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1495 * src/modest-tny-local-folders-account.c:
1496 (add_account_folders_to_merged_folder):
1497 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1498 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1499 (modest_ui_actions_on_send):
1500 * src/widgets/modest-folder-view.c: (update_model):
1501 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1502 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1503 modest_tny_account_store_get_tny_account_by_account() to
1504 modest_tny_account_store_get_server_account() to make the code clearer.
1506 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1508 * src/dbus_api/modest-dbus-api.h:
1509 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1510 * src/maemo/modest-msg-edit-window.c:
1511 (modest_msg_edit_window_attach_file_noninteractive):
1512 added g_warning in case the file to be attached does not exist
1513 * tests/dbus_api/test_compose_mail.c: (main):
1514 removed obsolete comment, added generic files as test case
1516 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1518 * src/modest-tny-account-store.c: (get_server_accounts):
1519 Create the local folders account only once, not once for each outbox, and
1520 not only when there are some outboxes.
1522 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1524 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1525 code that is causing a crash at startup. Sergio says that he is fixing this.
1527 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1529 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1530 * src/maemo/modest-account-settings-dialog.c:
1531 (create_page_outgoing),
1532 (modest_account_settings_dialog_set_account_name),
1533 (save_configuration):
1534 - Fixed handling of the "Use secure authentication" toggle to comply with
1535 the ui specification. See also projects.maemo.org bug NB#58400
1537 - Restore the Secure connection setting combo correctly when loading
1540 * src/maemo/modest-maemo-utils.c:
1541 (on_camel_account_get_supported_secure_authentication),
1542 (modest_maemo_utils_get_supported_secure_authentication_methods):
1543 Fixed a crasher if operation is canceled
1545 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1546 (modest_protocol_info_auth_is_secure):
1547 * src/modest-protocol-info.h:
1549 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1550 the sense of the "Use secure authentication" toggle.
1552 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1554 * src/modest-tny-account-store.h:
1555 * src/modest-tny-account-store.c:
1556 Added modest_tny_account_store_get_local_folders_account().
1558 * src/modest-tny-folder.h:
1559 * src/modest-tny-folder.c:
1560 (modest_tny_folder_get_account):
1561 Added this replacement for tny_folder_get_account() which returns
1562 the local-folders account for TnyMergeFolders, to avoid the
1563 warning about the unimplemented get_account_func() vfunc().
1565 (modest_tny_folder_get_rules),
1566 * src/modest-ui-actions.c:
1567 (modest_ui_actions_on_folder_selection_changed):
1568 * src/modest-mail-operation.c:
1569 (modest_mail_operation_remove_folder),
1570 (modest_mail_operation_xfer_folder),
1571 (modest_mail_operation_rename_folder),
1572 (modest_mail_operation_get_msg),
1573 (modest_mail_operation_get_msgs_full),
1574 (modest_mail_operation_remove_msg),
1575 (modest_mail_operation_xfer_msgs),
1576 (modest_mail_operation_refresh_folder):
1577 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1579 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1581 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1582 (modest_server_account_set_security):
1583 * src/modest-defs.h: Add comments explaining that our
1584 UI spec means TLS when it says Normal, so these do not look like errors.
1586 * src/modest-tny-account.c:
1587 (modest_tny_account_new_from_server_account): Use the new tinymail
1588 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1589 for TLS. This should fix projects.maemo.org bug NB#58460.
1591 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1593 * src/maemo/easysetup/modest-easysetup-wizard.c:
1594 (create_account): Correct the position of the gconf sanity check warning.
1595 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1596 of using the g_idle_add() hack, because this does not seem to be necessary
1597 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1598 caused by something other than maemo's gconf.
1599 This fixes projects.maemo.org bug #59022.
1601 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1603 * src/modest-account-mgr-helpers.c:
1604 (modest_account_mgr_get_default_account): Do not check that the account
1605 exists if there is no default account (NULL), to fix a runtime warning.
1607 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1609 * src/widgets/modest-folder-view.c: (update_model):
1610 Do not unref the treemodel before we have finished with it.
1611 This prevents a valgrind warning and an occasional crash at startup.
1613 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1615 * libmodest-dbus-client/libmodest-dbus-client.h:
1616 added libmodest_dbus_client_compose_mail()
1617 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1619 added functions needed for SendAsMail() functionality
1620 * src/maemo/modest-msg-edit-window.c:
1621 (modest_msg_edit_window_attach_file_noninteractive):
1622 non interactively attaching files to message edit window
1623 * src/widgets/modest-msg-edit-window.h:
1624 * tests/dbus_api/Makefile.am:
1625 added test_compose_mail.c
1626 * tests/dbus_api/test_compose_mail.c: (main):
1628 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1630 * src/modest-account-view.c:
1631 Fixed bug projects.maemo.org bug NB#59307
1633 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1635 * src/maemo/easysetup/modest-easysetup-wizard.c:
1636 (get_serverport_incoming), (on_before_next), (create_account):
1637 * src/maemo/modest-account-settings-dialog.c:
1638 (modest_account_settings_dialog_set_account_name):
1639 * src/maemo/modest-maemo-utils.c:
1640 (on_camel_account_get_supported_secure_authentication_status),
1641 (on_camel_account_get_supported_secure_authentication),
1642 (on_secure_auth_cancel),
1643 (modest_maemo_utils_get_supported_secure_authentication_methods):
1645 Implemented security authentication for settings and easysetup.
1647 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1649 * src/maemo/modest-main-window.c: (create_details_widget):
1650 Show the total size for memory card accounts too, instead of showing
1651 the name again. Fixes bug projects.maemo.org bug NB#59307.
1653 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1656 * src/modest-tny-simple-folder-store.c:
1657 * src/modest-tny-simple-folder-store.h: Removed.
1659 * src/modest-tny-local-folders-account.h
1660 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1661 for the local-folders maildir, with an extra TnyMergedFolder containing
1662 the folders of the per-account outbox store accounts.
1663 * src/modest-tny-account-store.c: (get_server_accounts):
1664 Add the outboxes to the special local folders account after creating it.
1666 * src/modest-tny-account.c:
1667 (modest_tny_account_new_for_local_folders): Create the derived
1668 account when creating the main local-folders account.
1670 * src/maemo/modest-main-window.c: (create_details_widget),
1671 (modest_main_window_set_contents_style):
1672 Adapted to the use of the derived account instead of the folder store.
1674 * src/modest-ui-actions.c:
1675 (modest_ui_actions_on_folder_selection_changed):
1676 * src/modest-ui-dimming-rules.c:
1677 (modest_ui_dimming_rules_on_new_folder):
1678 * src/widgets/modest-folder-view.c: (text_cell_data),
1679 (icon_cell_data), (filter_row), (update_model),
1680 (get_cmp_rows_type_pos):
1683 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1684 Do not get the priv struct, because no priv struct has been set,
1685 to avoid a runtime warning.
1687 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1688 #ifelse with #else, to fix a warning, to fix the build.
1691 2007-06-05 Christian Kellner <ckellner@openismus.com>
1693 * libmodest-dbus-client/libmodest-dbus-client.c:
1694 Fix small typo in doc (why do you always see them
1695 AFTER committing stuff?)
1698 2007-06-05 Christian Kellner <ckellner@openismus.com>
1700 * libmodest-dbus-client/libmodest-dbus-client.c:
1701 (libmodest_dbus_client_search):
1702 Initialize hit list with NULL. Also set folder list
1703 to "" if NULL was supplied.
1706 2007-06-03 Christian Kellner <ckellner@openismus.com>
1708 * libmodest-dbus-client/libmodest-dbus-client.c:
1709 (modest_search_hit_list_free):
1710 Make it save to call it with NULL.
1712 * src/dbus_api/modest-dbus-callbacks.c:
1713 * src/modest-search.c:
1714 Return full ModestSearchHits as the search result list not TnyHeader
1715 since can't be around withouth the correspoding TnyFolder.
1717 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1719 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1720 Added currently commented code to check for secure auth
1722 * src/maemo/modest-account-settings-dialog.c: (on_response),
1723 (save_configuration), (show_ok):
1724 Fixed projects.maemo.org bugs NB #59248 and #59251
1726 * src/maemo/modest-maemo-utils.c:
1727 (on_camel_account_get_supported_secure_authentication_status),
1728 (on_camel_account_get_supported_secure_authentication),
1729 (modest_maemo_utils_get_supported_secure_authentication_methods):
1730 * src/maemo/modest-maemo-utils.h:
1731 Moved get_supported_secure_authentication() method here to be able
1732 to use it from easysetup wizard.
1734 * src/modest-pair.c: (on_pair_compare_as_string):
1735 Should compare string with first part of pair and not
1736 strcmp pairs which will crash.
1738 * src/modest-protocol-info.c:
1739 (modest_protocol_info_protocol_is_store):
1740 * src/modest-protocol-info.h:
1741 Added modest_protocol_info_get_auth_protocol_name()
1743 2007-06-03 Armin Burgmeier <armin@openismus.com>
1745 * src/modest-mail-operation.c:
1746 (modest_mail_operation_get_msgs_full): Set priv->account also when
1747 only retrieving a single message. This avoids a crash when canceling
1750 (modest_mail_operation_notify_end): Do not explicitely remove the
1751 operation from the queue but only emit the progress_changed signal.
1752 The queue itself listens to that signal to remove the operation when
1753 it is finished. This reduces coupling and removes a potential deadlock
1754 when modest_mail_operation_notify_end() is called from the queue
1755 itself. If that is a problem performance-wise, I would suggest to
1756 implement a status-changed signal or something.
1758 * src/modest-mail-operation-queue.c: Make sure to never call a
1759 function from another file while the queue is locked. This (hopefully)
1760 fixes another deadlock when exiting the application while retrieving
1763 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1765 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1766 Fixed build if libogs is not available
1768 2007-06-03 Christian Kellner <ckellner@openismus.com>
1770 * libmodest-dbus-client/libmodest-dbus-client.h:
1771 * libmodest-dbus-client/libmodest-dbus-client.c:
1772 (libmodest_dbus_client_delete_message):
1773 Implement deletion of messages (Client side).
1775 (modest_search_hit_free),
1776 (modest_search_hit_list_free):
1777 Utility functions to free the result hits.
1779 * src/dbus_api/modest-dbus-api.h:
1780 * src/dbus_api/modest-dbus-callbacks.c:
1781 (on_delete_message),
1782 (modest_dbus_req_handler):
1783 Implement deletion of messages (Server side).
1785 * tests/dbus_api/test_search.c: (main):
1788 * tests/dbus_api/Makefile.am:
1789 * tests/dbus_api/test_delete_message:
1790 Add little test for the message deletion logic
1792 2007-06-03 Armin Burgmeier <armin@openismus.com>
1794 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1795 when the operation queue was not empty. projects.maemo.org bug
1798 2007-06-03 Armin Burgmeier <armin@openismus.com>
1800 * src/widgets/modest-account-view.c
1801 (on_account_default_toggled): Toggle default account column
1802 explicitely instead of waiting for gconf notification (which is
1803 currently ignored). This should fix projects.maemo.org bug NB#56910
1804 for now. It should probably be removed when gconf notifications are
1807 2007-06-03 Christian Kellner <ckellner@openismus.com>
1809 * libmodest-dbus-client/libmodest-dbus-client.c:
1810 Removed debugging spew.
1812 * src/dbus_api/modest-dbus-callbacks.c:
1813 Added debugging info.
1815 * src/modest-search.c:
1816 (modest_search_all_accounts):
1817 Use tny_account_store_get_accounts () on the account store
1818 to get all accounts which is the way to get all accounts.
1820 * tests/dbus_api/test_search.c: (main):
1821 Make it possible to supply the search term on the command line.
1823 2007-06-03 Christian Kellner <ckellner@openismus.com>
1825 * libmodest-dbus-client/libmodest-dbus-client.c:
1826 * libmodest-dbus-client/libmodest-dbus-client.h:
1827 Implement searching for mesages over raw dbus. (Client side)
1829 * src/dbus_api/Makefile.am:
1830 * src/dbus_api/modest-dbus-api.h:
1831 * src/dbus_api/modest-dbus-callbacks.c:
1832 * src/dbus_api/modest-dbus-callbacks.h:
1833 Search framework (Server side). Also implement on_idle_open_message().
1835 * src/maemo/modest-platform.c: (modest_platform_init):
1836 Prepare for raw dbus/osso rpc interaction.
1838 * src/modest-search.h:
1839 Changed minsize from unspecific guint to guint32.
1841 * src/modest-search.c:
1843 Added strange hack which magically made tnymail work.
1845 (modest_search_folder),
1846 (modest_search_account),
1847 (modest_search_all_accounts):
1848 Implement helper functions to search all accounts, specific account
1851 * tests/dbus_api/Makefile.am:
1852 * tests/dbus_api/test_open_message.c:
1853 Read url to open from commandline.
1855 * tests/dbus_api/test_search.c:
1856 Implement small test for dbus search stuff
1858 2007-06-02 Armin Burgmeier <armin@openismus.com>
1860 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1861 include account type and account title. This fixes projects.maemo.org
1864 * src/maemo/modest-account-view-window.c: Set a title for the window.
1866 2007-06-02 Armin Burgmeier <armin@openismus.com>
1868 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1869 incoming and outgoing server name based on email address and server
1870 types as long as the names have not been edited manually. This fixes
1871 projects.maemo.org bug NB#58671.
1873 2007-06-02 Armin Burgmeier <armin@openismus.com>
1875 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1876 server type cannot be changed in future to the incoming details page
1877 when creating an account. This fixes projects.maemo.org bug NB#59029.
1879 2007-06-02 Armin Burgmeier <armin@openismus.com>
1881 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1882 and assigned max width chars so that they wrap instead of being
1883 truncated. Fixes projects.maemo.org bug NB#56126.
1885 2007-06-02 Armin Burgmeier <armin@openismus.com>
1887 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1888 introductory note to the connection specific smtp servers dialog, as
1889 section 8.12 of the email UI specification requires. This fixes
1890 projects.maemo.org bug NB#59212.
1892 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1894 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1895 Check for running mail operations, and offer to cancel them, as per the UI
1896 spec. This fixes projects.maemo.org bug NB#59041 .
1897 However, I suspect that tinymail may still use the network connection
1898 in ways that we cannot detect or cancel. But it should at least adapt to
1899 changes fairly well.
1901 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1903 * src/modest-tny-account-store.c: (recreate_all_accounts),
1904 (get_cached_accounts), (get_server_accounts): Do more sensible
1905 ref-counting of the temporarily-cached outbox accounts list. This seems
1906 to fix a crash when entering the password when the password was wrong.
1908 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1910 * src/gnome/modest-main-window.c: (connect_signals):
1911 * src/modest-tny-account-store.c: (get_password),
1912 (modest_tny_account_store_alert): Added comments and clues and
1913 commented-out code about how we currently fail to deal with connection
1914 errors and wrong passwords, and how we should.
1916 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1918 * src/widgets/modest-retrieve-combo-box.c:
1919 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1920 This fixes projects.maemo.org bug NB#58472 .
1922 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1924 * src/maemo/easysetup/modest-easysetup-wizard.c:
1925 (create_page_complete_easysetup):
1926 (create_page_complete_custom): Correct the last commit,
1927 putting the correct sentences in the correct pages.
1929 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1931 * src/maemo/easysetup/modest-easysetup-wizard.c:
1932 (create_page_complete_custom): Show the second sentence of text
1933 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1936 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1938 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1939 Set the leave-on-server conf key by default. This fixes
1940 projects.maemo.org bug NB#59258 .
1942 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1944 * src/maemo/modest-account-view-window.c:
1945 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1946 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1949 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1951 * src/maemo/easysetup/modest-easysetup-wizard.c:
1952 (create_caption_new_with_asterisk):
1953 * src/maemo/modest-account-settings-dialog.c:
1954 (create_caption_new_with_asterisk):
1955 Uncomment the code to add the asterisk, because they are no longer in the
1956 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1957 (update_incoming_server_title): Add an asterisk here too.
1959 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1961 * src/maemo/modest-maemo-global-settings-dialog.c:
1962 (current_connection): Check that we are even connected before trying to
1963 get the current connection name, to prevent a warning.
1965 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1966 Change the comments because tny_maemo_conic_device_connect() is now meant to
1968 * src/modest-mail-operation.c:
1969 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1970 make sure we have a connection and fail if we can't connect.
1972 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1974 * src/maemo/modest-main-window.c:
1975 (on_account_store_connecting_finished): Do not try to get the
1976 connection ID if we are not really connected. I am surprised that
1977 this signal handler is called when we are not connected.
1979 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1981 * src/modest-error.h:
1982 * src/modest-ui-actions.c:
1983 (modest_ui_actions_get_msgs_full_error_handler):
1984 Renamed an enum, added comments, added an enum
1985 for retrieve-limit errors.
1987 * src/modest-mail-operation.c: (foreach_add_item),
1988 (internal_folder_observer_update), (update_account_thread),
1989 (modest_mail_operation_get_msgs_full):
1990 (modest_mail_operation_update_account),
1991 Added comments about how this works, and some code that should
1992 (but does not) check the retrieve-limit. See the TODO comment.
1994 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1996 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1997 Initialize help_id to fix the build. Warnings are good.
1999 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2001 * src/widgets/modest-hbox-cell-renderer.c:
2002 (modest_hbox_cell_renderer_append):
2003 * src/widgets/modest-vbox-cell-renderer.c:
2004 (modest_vbox_cell_renderer_append):
2005 Fix the last commit by doing an extra ref.
2007 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2009 * src/widgets/modest-hbox-cell-renderer.c:
2010 (modest_hbox_cell_renderer_append):
2011 * src/widgets/modest-vbox-cell-renderer.c:
2012 (modest_vbox_cell_renderer_append):
2013 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2014 to fix the build with Maemo Bora.
2015 However, there seems to be a remaining crash, probably due to reference
2018 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2020 * src/modest-tny-account.c:
2021 (modest_tny_account_new_for_local_folders):
2022 Use hildon_file_system_info_async_new() to get a better name for
2023 the memory card account, setting it as the account name.
2024 The timing seems to work, but this is probably
2025 not the best place to do this. See the TODO comment.
2026 * src/maemo/modest-main-window.c: (create_details_widget):
2027 * src/widgets/modest-folder-view.c: (text_cell_data):
2028 Use the tny account name instead of hardcoding a name.
2030 2007-05-30 Christian Kellner <ckellner@openismus.com>
2032 * src/modest-search.c: (modest_search):
2033 Correctly set part_search_func even if we have already parsed
2034 the query and thus a valid OgsTextSearcher object.
2036 2007-05-30 Christian Kellner <ckellner@openismus.com>
2039 Search and check for libogs.
2042 Incooparte the ogs build env.
2044 * src/modest-mime-part-search-stream.c:
2045 * src/modest-mime-part-search-stream.h:
2046 Removed since we do the real searching now in modest-search.c.
2048 * src/modest-search.c:
2049 * src/modest-search.h:
2050 Implement support for ogs. We use that if available and requested
2051 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2052 should now handle the corner case when the search term is spread
2053 across multiple reads.
2054 Also the logic in modest_search () was corrected to search all
2055 requested fields until one is found.
2057 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2059 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2061 * src/modest-init.h:
2062 * src/modest-init.c: Made modest_init_local_folders() take a
2063 path and be public so we can iniitialize maildir folders on
2066 * src/modest-local-folder-info.h:
2067 * src/modest-local-folder-info.c:
2068 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2070 * src/modest-tny-account.c:
2071 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2072 still means the standard local-folders path on the local volume.
2074 * src/modest-tny-account-store.c:
2075 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2076 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2077 all accounts when that happens.
2078 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2079 this too, so it shows up in the treeview.
2081 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2083 * src/maemo/modest-maemo-global-settings-dialog.c:
2084 (current_connection):
2085 * src/widgets/modest-global-settings-dialog.c:
2086 (current_connection_default):
2087 Use the enum values instead of 0, 1 and -1,
2088 to make the code clearer.
2090 * src/modest-account-mgr-helpers.c:
2091 (modest_account_mgr_get_connection_specific_smtp): Make this code
2094 * src/modest-runtime.h:
2095 * src/modest-runtime.c:
2096 Added modest_runtime_remove_all_send_queues().
2097 * src/maemo/modest-main-window.c:
2098 (on_account_store_connecting_finished): Recreate the send queues,
2099 using the appropriate transport accounts for this new connection.
2100 Some futher adapting might be needed if the old send queues are not
2101 automatically stopped at this point.
2103 * src/modest-tny-account-store.c: (get_server_accounts):
2104 Create the connection-specific transport accounts, so that they can
2105 be found later by their ID.
2107 * src/modest-tny-account.h:
2108 * src/modest-tny-account.c:
2109 Added modest_tny_account_new_from_server_account_name().
2110 modest_tny_account_new_from_server_account(): Do not create the
2111 send queues here, because they will be
2112 recreated anyway when the connection changes for the first time.
2114 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2116 * src/modest-local-folder-info.h:
2117 * src/modest-local-folder-info.c:
2118 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2119 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2120 tbox_folder): Take a modest account name instead of a server TnyAccount,
2121 so we can have per-modest-account rather than per-transport-account
2123 We must make sure that we change or recreate the exisitng send queues
2124 when the connection changes for connection-specific transport accounts.
2126 * src/modest-tny-account-store.c:
2127 (create_per_account_local_outbox_folders): Create outboxed per modest
2128 account, not per transport account.
2130 * src/modest-tny-account.h:
2131 * src/modest-tny-account.c:
2132 (modest_tny_account_get_special_folder): For outboxes, get the
2133 parent modest account name. The account is ignored for other folders.
2134 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2135 modest account name rather than a server TnyAccount.
2137 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2139 * src/modest-tny-account.c:
2140 (modest_tny_account_new_from_server_account):
2141 Call modest_runtime_get_send_queue() immediately after creating transport
2142 accounts, so that they start trying to send email from the outbox as soon
2143 as possible at startup. This is probably what we want.
2145 * src/modest-mail-operation.c: (update_account_thread):
2146 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2147 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2148 * src/modest-tny-send-queue.h:
2149 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2150 (modest_ui_actions_on_send):
2151 Added comments about how sending works, though it needs some more work.
2153 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2155 * src/modest-tny-account.c:
2156 (modest_tny_account_get_special_folder): Add TODO because this fails when
2157 the network is busy.
2158 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2159 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2160 Do not try to show this window when there is no active account. The UI
2161 specs does not tell us what to do in this case.
2163 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2167 * src/maemo/Makefile.am:
2168 * src/widgets/Makefile.am: Some dist fixes.
2170 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2172 * src/maemo/modest-connection-specific-smtp-window.c:
2173 (on_button_edit): Make the code clearer, to prevent a double free.
2175 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2177 * src/maemo/modest-account-settings-dialog.c:
2178 (modest_account_settings_dialog_set_account_name),
2179 Check the connection-specific smtp servers checkbox if there are any.
2181 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2182 (modest_connection_specific_smtp_edit_window_init):
2183 Start with a suitable port number.
2185 * src/modest-account-mgr-helpers.h:
2186 * src/modest-account-mgr-helpers.c: Added
2187 modest_account_mgr_get_has_connection_specific_smtp().
2189 (modest_account_mgr_set_connection_specific_smtp),
2190 (modest_account_mgr_remove_connection_specific_smtp),
2191 (modest_account_mgr_get_has_connection_specific_smtp),
2192 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2193 connection-specific smtp server accounts in the account, rather than
2194 the server account conf dir.
2196 This fixes bug projects.maemo.org bug NB#58263 .
2198 * src/modest-tny-account-store.c:
2199 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2200 if there are no server accounts yet, to prevent an infinite loop when there
2201 are no accounts. Document that one must be called before the other.
2203 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2205 * src/modest-account-mgr-helpers.c:
2206 (modest_account_mgr_get_default_account): Make sure that at least
2207 one account is always the default, if there are any enabled accounts.
2208 This is just a sanity check that shouldn't be necessary.
2210 * src/modest-account-mgr-priv.c:
2211 (_modest_account_mgr_account_from_key): Unescape the conf key to
2212 get the real account name. For instance, this is an issue if a space
2213 was in the account name, which can happen because the account name
2214 is generated from the display name.
2215 (_modest_account_mgr_get_account_keyname): Always escape the
2217 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2218 Unescape the conf keys to get the real account names.
2220 For instance, previously the is-default radio button in the accounts
2221 list was not checked for any accounts at first. This fixes that,
2222 and might fix several similar bugs.
2224 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2226 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2227 Removed some debug printfs.
2229 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2231 Modest on-disk outbox directories are now here, for instance:
2232 $HOME/.modest/outboxes/<account-id-1>/outbox
2233 $HOME/.modest/outboxes/<account-id-2>/outbox
2235 $HOME/.modest/local-folders/outbox
2236 so we can have a separate outbox for each account.
2237 But they are shown as one outbox in the GtkTreeView, by using a
2238 TnyMergeFolder in a ModestTnySimpleFolderStore.
2241 * src/modest-tny-simple-folder-store.c:
2242 * src/modest-tny-simple-folder-store.h:
2243 Added ModestTnySimpleFolderStore, used to contain folders from
2244 other folder stores, such as other accounts.
2246 * src/modest-tny-outbox-account.h:
2247 * src/modest-tny-outbox-account.c:
2248 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2249 used for the per-account local outbox folders.
2251 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2252 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2253 only use this (internally) now for the non-outbox local folders.
2255 * src/modest-init.h:
2256 * src/modest-init.c: Added modest_init_one_local_folder(), for
2257 setting up the directory structure for each local folder.
2259 * src/modest-local-folder-info.c:
2260 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2261 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2263 * src/modest-local-folder-info.h:
2264 * src/modest-tny-account-store.c: (on_account_removed),
2265 (on_account_changed), (create_per_account_local_outbox_folders),
2266 (get_server_accounts), (modest_tny_account_store_get_accounts),
2267 (modest_tny_account_store_get_tny_account_by_account),
2268 (modest_tny_folder_store_is_virtual_local_folders):
2270 * src/modest-tny-account.h:
2271 * src/modest-tny-account.c:
2272 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2273 to create an on-disk per-account local outbox folder for each
2275 (create_per_account_local_outbox_folders): Create a local outbox folder
2276 for each transport account.
2277 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2278 for all local folders.
2280 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2281 instead of using g_object_get/set() directly. It is clearer.
2283 (modest_tny_folder_store_get_message_count),
2284 (modest_tny_folder_store_get_local_size
2285 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2286 because we now use these with non-acount folder stores.
2288 (modest_tny_account_get_special_folder),
2289 (modest_tny_account_new_from_server_account),
2290 (modest_tny_account_new_from_account):
2291 (recurse_folders): Adjust to the new outbox system.
2293 * src/modest-tny-folder.h:
2294 * src/modest-tny-folder.c:
2295 (modest_tny_folder_is_local_folder),
2296 (modest_tny_folder_get_local_folder_type),
2297 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2299 * src/widgets/modest-main-window.h:
2300 * src/maemo/modest-main-window.c: (create_details_widget),
2301 (modest_main_window_set_contents_style): Show details for any folder store,
2304 (modest_tny_folder_get_rules):
2305 Remove the const. C does not support constness enough for this.
2307 * src/modest-ui-actions.c:
2308 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2309 make all outboxes appear as one, in the usual local-folders tree node.
2311 (set_active_account_from_tny_account),
2312 (modest_ui_actions_on_folder_selection_changed):
2313 * src/widgets/modest-folder-view.c: (text_cell_data),
2314 (icon_cell_data), (filter_row),
2315 (add_account_folders_to_merged_folder),
2316 (add_account_folders_to_simple_folder_store), (),
2317 (get_cmp_rows_type_pos), (cmp_rows),
2318 (modest_folder_view_set_account_id_of_visible_server_account):
2319 Adjust to the new outbox system, using generic folder stores and folders
2320 in the GtkTreeModel.
2322 2007-05-23 Christian Kellner <ckellner@openismus.com>
2324 * src/modest-mail-operation.c:
2325 (modest_mail_operation_update_account):
2326 Use info->max_size instead of unintialized local var [small
2327 build fix]. (Added TODO to review that change since I don't
2330 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2332 * libmodest-dbus-client/libmodest-dbus-client.c:
2333 (libmodest_dbus_client_compose_mail): function added
2334 * src/dbus_api/modest-dbus-api.h:
2335 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2336 (on_compose_mail): Implementation of the SendAsMail functionality
2338 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2340 * src/modest-account-mgr.c:
2341 (modest_account_mgr_add_server_account): Set the secure-connection
2342 conf key for transport accounts as well as store accounts. I don't know
2343 why the if was there. For instance, this makes sure that we use SSL
2344 for the gmail preset from the easysetup wizard.
2346 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2348 * src/gnome/modest-main-window.c:
2349 (on_account_store_connecting_finished), (connect_signals):
2350 * src/maemo/modest-main-window.c:
2351 (on_account_store_connecting_finished), (connect_signals),
2352 (modest_main_window_new):
2353 Handle TnyAccountStore::connecting-finished instead of
2354 TnyDevice::connection-changed, because we cannot actually perform
2355 operations on accounts until TnyAccountStore has itself responded to
2356 the TnyDevice::connection-changed signal. This prevents a GError from
2358 Do not try to update at startup, because we (at least on scratchbox)
2359 already do an update at startup when the device goes online.
2360 This prevents a GError from tinymail.
2361 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2362 Added TODO about stopping simultaneous operations.
2364 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2366 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2367 * src/modest-mail-operation-queue.c:
2368 (modest_mail_operation_queue_remove):
2369 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2370 about where they happened.
2372 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2374 * src/modest-ui-actions.c:
2375 (modest_ui_actions_on_password_requested): Make sure that the remember
2376 output parameter is always TRUE.
2378 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2380 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2381 Show a OK/Cancel dialog if the error is a question, though we still do not
2382 know anything more about what we are asking the user.
2383 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2384 Fix an uninitialized variable (helper). This is a logic error, however.
2386 2007-05-21 Christian Kellner <ckellner@openismus.com>
2388 * src/modest-search.h:
2389 Correct bit shifting in the ModestSearchFlags enum.
2391 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2393 * src/modest-tny-account.c:
2394 (modest_tny_account_new_from_server_account): Do not use the lsub and
2395 check-all hard-coded IMAP options when using POP.
2397 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2399 * src/modest-tny-account.c:
2400 (modest_tny_account_new_from_server_account):
2401 Use NULL for the secure-auth method for POP when Password auth has been
2402 specified by the user, as we already do for IMAP. "auth=Login" causes
2403 an error from camel or the server.
2405 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2407 * src/maemo/modest-account-settings-dialog.c:
2408 (create_page_account_details),
2409 (modest_account_settings_dialog_set_account_name):
2410 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2411 for the leave-on-server checkbox, rathr than just the checkbox, when
2412 the protocol is not POP.
2414 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2416 * src/widgets/modest-account-view.c:
2417 * src/widgets/modest-account-view.h:
2418 Added modest_account_view_select_account() which will be useful later
2419 to asynchronously re-select the edited account.
2421 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2423 * src/maemo/modest-account-settings-dialog.c:
2424 (modest_account_settings_dialog_set_account_name):
2425 Automatically choose the port numbers based on the secure authentication
2426 methods, if they have not been chosen before.
2427 This fixes projects.maemo.org bug NB#56273 .
2429 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2431 * src/maemo/modest-main-window-ui.h:
2432 * src/modest-ui-actions.c:
2433 * src/modest-ui-actions.h:
2434 Connect the Tools/SMTP Servers menu item to
2435 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2436 SMTP servers dialog, as in the UI specification and saves changes when it
2437 is closed. This fixed projects.maemo.org bug NB#56305 .
2439 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2441 * src/maemo/modest-connection-specific-smtp-window.c:
2442 (modest_connection_specific_smtp_window_init):
2443 Use gtk_window_set_default_size() to make this window big enough, so
2444 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2446 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2448 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2449 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2450 (modest_connection_specific_smtp_edit_window_init),
2451 Do not try to connect to a combobox signal before the combobox exists.
2452 This fixes the cras in projects.maemo.org bug NB#56288 .
2453 (modest_connection_specific_smtp_edit_window_get_settings):
2454 Remove the server_account_name parameter which was being checked for NULL
2455 though it was not used.
2457 * src/maemo/modest-connection-specific-smtp-window.c:
2458 (modest_connection_specific_smtp_window_fill_with_connections),
2459 (on_button_edit), (modest_connection_specific_smtp_window_init):
2460 Correct the number of treemodel columns to prevent a warning.
2461 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2462 libconic does not work.
2464 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2466 * src/modest-tny-account.c:
2467 (modest_tny_account_new_from_server_account):
2468 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2469 SMTP when "None" was chosen by the user. However, with my SMTP server that
2470 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2473 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2475 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2476 to explain the memory management issue with the ID in the ModestPair.
2478 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2479 (add_sending_page), (modest_account_assistant_finalize):
2480 * src/gnome/modest-gnome-global-settings-dialog.c:
2481 (create_updating_page), (create_composing_page):
2482 * src/gnome/modest-msg-edit-window.c: (get_transports),
2483 (init_window), (modest_msg_edit_window_finalize),
2484 (modest_msg_edit_window_get_msg_data):
2485 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2486 * src/gnome/modest-transport-widget.c:
2487 (modest_transport_widget_finalize), (smtp_configuration):
2488 * src/maemo/modest-maemo-global-settings-dialog.c:
2489 (create_updating_page), (create_composing_page):
2490 * src/maemo/modest-msg-edit-window.c: (get_transports),
2491 (init_window), (modest_msg_edit_window_finalize),
2492 (modest_msg_edit_window_get_msg_data),
2493 (modest_msg_edit_window_free_msg_data):
2494 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2495 (modest_store_widget_finalize):
2496 * src/maemo/modest-transport-widget.c:
2497 (modest_transport_widget_finalize), (smtp_configuration):
2498 * src/modest-main.c: (send_mail):
2499 * src/widgets/modest-combo-box.h:
2500 * src/widgets/modest-global-settings-dialog-priv.h:
2501 * src/widgets/modest-global-settings-dialog.c:
2502 (modest_global_settings_dialog_finalize):
2503 * src/widgets/modest-msg-edit-window.h:
2504 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2505 as long as the combo box, to prevent use of freed memory for the ID.
2507 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2509 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2510 get_accounts(), to make this clearer. Do not check for the enabled gconf
2511 key, because we do not use this for server accounts (at least, not yet).
2512 This allows us to send email again.
2514 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2516 * src/maemo/modest-platform.c:
2517 (on_modest_conf_update_interval_changed), (modest_platform_init):
2518 Only respond to this particular key change. All these strcmp()s cannot be
2521 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2523 * src/maemo/modest-maemo-global-settings-dialog.c:
2524 (current_connection): Prevent a crash in scratchbox when
2525 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2526 * src/maemo/modest-platform.c:
2527 (on_modest_conf_update_interval_changed), (modest_platform_init):
2528 Get the update interval from gconf and reset it when the gconf key changes.
2530 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2532 * src/modest-protocol-info.c:
2533 * src/modest-protocol-info.h: Adde enum-specific get functions,
2534 instead of using a ModestProtocolType enum parameter.
2536 * src/gnome/modest-account-assistant.c:
2537 * src/gnome/modest-store-widget.c:
2538 * src/gnome/modest-store-widget.h:
2539 * src/gnome/modest-transport-widget.c:
2540 * src/gnome/modest-transport-widget.h:
2541 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2542 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2543 * src/maemo/easysetup/modest-easysetup-wizard.c:
2544 * src/maemo/modest-account-settings-dialog.c:
2545 * src/maemo/modest-account-settings-dialog.h:
2546 * src/maemo/modest-store-widget.c:
2547 * src/maemo/modest-store-widget.h:
2548 * src/maemo/modest-transport-widget.c:
2549 * src/maemo/modest-transport-widget.h:
2550 * src/modest-account-mgr-helpers.c:
2551 * src/modest-account-mgr-helpers.h:
2552 * src/modest-account-mgr.c:
2553 * src/modest-account-mgr.h:
2554 * src/modest-tny-account.c:
2555 * src/modest-tny-folder.c:
2556 * src/widgets/modest-account-view.c:
2557 * src/widgets/modest-retrieve-combo-box.c:
2558 * src/widgets/modest-retrieve-combo-box.h:
2559 * src/widgets/modest-secureauth-combo-box.c:
2560 * src/widgets/modest-serversecurity-combo-box.c:
2561 * src/widgets/modest-serversecurity-combo-box.h:
2562 * tests/check_account-mgr.c:
2563 Use the specific functions, and use the re-renamed enum values for GNOME too.
2565 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2567 * src/modest-pair.h:
2568 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2569 so we can get the second based on the first.
2571 * src/maemo/modest-account-settings-dialog.h:
2572 * src/maemo/modest-account-settings-dialog.c:
2573 Added get_supported_secure_authentication_methods(), though it is mostly
2574 commented-out for now until the necessary API is committed to tinymail.
2575 (modest_account_settings_dialog_set_account_name),
2576 (save_configuration): Request the supported authentication methods from the
2577 server, so we can choose a working method.
2579 * src/modest-tny-account-store.h:
2580 * src/modest-tny-account-store.c:
2581 (modest_tny_account_store_get_session): Rename from
2582 tny_account_store_get_session().
2584 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2586 * src/modest-protocol-info.h: Split the ModestProtocol enum
2587 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2588 There was no need to have these unrelated values in one enum.
2590 * src/: many files: Adapted to changed enum. This makes the code a bit
2591 clearer, and the compiler could catch some errors.
2593 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2595 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2596 Show the detailed internal camel error message when an error happens
2597 during the configuration, so that our testers can give us more clues.
2598 For instance, in projects.maemo.org bug NB#56910 .
2600 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2602 * src/modest-tny-account.c:
2603 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2604 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2606 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2608 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2609 * src/maemo/modest-account-settings-dialog.c:
2610 (modest_account_settings_dialog_set_account_name),
2611 (save_configuration): For the incoming secure authentication checkbox,
2612 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2613 the UI specification. PLAIN does not seem to be supported for most IMAP
2614 servers anyway, and I am not sure what it would mean.
2615 However, we probably need to discover which of the secure-authentication
2616 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2617 * src/modest-account-mgr-helpers.c:
2618 (modest_account_mgr_get_server_account_data):
2620 * src/modest-tny-account.c:
2621 (modest_tny_account_new_from_server_account):
2622 Use tny_account_set_mech() to set secure-authentication methods,
2623 with some special-casing for IMAP, based on my observations of how
2626 * src/modest-account-mgr-helpers.h:
2627 * src/modest-account-mgr.c:
2628 * src/modest-defs.h: Comment that the URI is only used for local folders.
2630 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2632 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2633 parameter const, just to be neat.
2634 * src/modest-text-utils.c: (modest_text_utils_inline):
2635 End g_strconcat() with NULL, as its documentation says. This is almost
2636 certainly the cause of my crash at startup on the device. Interestingly,
2637 valgrind doesn't tell us about these errors.
2639 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2641 * scripts/build-packages: Added more precise comments about how to use
2642 this script, though I still get this error:
2643 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2644 error building tinymail
2646 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2648 * src/maemo/modest-main-window.c: (on_account_update):
2649 Very slight cleanup, hoping to make it simpler to discover what causes
2650 a crash here sometimes.
2652 * src/modest-tny-account.c:
2653 (modest_tny_account_new_from_server_account): Set the port. Added
2654 comments about the options and a TODO comment because I need to find out
2655 how to specify the secure authentication method.
2657 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2659 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2660 changed CFlags paths form modest to libmodest
2662 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2664 * src/modest-account-mgr-helpers.c:
2665 (modest_account_mgr_get_server_account_data),
2666 (modest_account_mgr_free_server_account_data):
2667 * src/modest-account-mgr-helpers.h:
2668 * src/modest-account-mgr.c:
2669 (modest_account_mgr_add_server_account):
2670 * src/modest-defs.h:
2671 * src/modest-tny-account.c:
2672 (modest_tny_account_new_from_server_account):
2673 Determine the options for tny_camel_account_add_option() here,
2674 based on the settings, rather than storing them directly in gconf.
2676 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2678 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2679 Show a more friendly error dialog now that we expect (from the tinymail
2680 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2682 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2684 * src/maemo/modest-main-window.c: (on_account_update): Check that
2685 account_name is not NULL, to prevent a crash at startup that I am
2686 seeing on the N800. I do wonder why it is NULL.
2688 * src/maemo/easysetup/modest-easysetup-wizard.c:
2689 (create_page_user_details):
2690 * src/maemo/modest-account-settings-dialog.c:
2691 (create_page_user_details), (create_page_outgoing):
2692 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2693 (modest_connection_specific_smtp_edit_window_init):
2694 * src/modest-ui-actions.c:
2695 (modest_ui_actions_on_password_requested):
2696 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2697 might do something useful with the on-screen keyboard.
2699 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2701 * src/maemo/modest-main-window.c: (on_account_update):
2702 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2703 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2705 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2707 * src/modest-tny-account-store.c: (on_account_changed):
2708 Correct the signature of this signal handler.
2710 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2712 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2713 Show a HildonNote instead of a GtkDialog for Maemo.
2715 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2717 * src/widgets/modest-account-view.h:
2718 * src/widgets/modest-account-view.c: (on_account_changed),
2719 (on_account_removed). Added a boolean flag, set/unset by
2720 modest_account_view_block_conf_updates(),
2721 modest_account_view_unblock_conf_updates() to prevent unnecessary
2722 updates, but this is not very useful because the gconf notifications are
2723 so delays (maybe only on Maemo Bora).
2724 So auto-updating is turned off, and these functions do an explicit
2725 update when necessary.
2726 However, something else is still doing too much work when adding/removing
2727 accounts, probably in another part of the application.
2729 * src/maemo/modest-account-view-window.c:
2730 (on_delete_button_clicked), (on_edit_button_clicked),
2731 (on_new_button_clicked): Use the new functions.
2733 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2735 * src/modest-account-mgr-helpers.c:
2736 (modest_account_mgr_set_first_account_as_default):
2737 Sort the list of names alphabetically-by-title, so we choose the first one
2739 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2740 alphabetically by the title.
2742 This fixes projects.maemo.org bug NB#56418 .
2744 * src/modest-account-mgr-priv.c:
2745 (_modest_account_mgr_account_from_key):
2746 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2747 avoid a valgrind error, and possible random behaviour.
2749 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2751 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2752 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2753 tinymail documentation to say that this can be expected.
2754 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2755 pretty, and should not happen, but I would prefer to know when it does.
2757 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2759 * configure.ac: When using the older hildon version, probably on Bora,
2760 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2762 * src/widgets/modest-attachment-view.c:
2763 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2766 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2768 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2769 Implemented the prototype. Can be tested with
2770 tests/dbus_api/test_open_message:
2772 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2774 * src/modest-tny-account-store.c:
2775 (modest_tny_account_store_instance_init), (get_password):
2776 * src/modest-ui-actions.c:
2777 (modest_ui_actions_on_password_requested):
2778 Do not store the password in gconf, because this function is called
2779 for non-remembered passwords. Actually use the cached (in the hash map)
2780 password instead of releasing it.
2781 The password will now not be remembered if it is asked via the protected
2782 password dialog, as per the UI spec.
2784 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2786 * src/modest-defs.h:
2787 * src/modest-account-mgr-helpers.h:
2788 * src/modest-account-mgr-helpers.c:
2789 Added modest_server_account_get_username_has_succeeded(),
2790 modest_server_account_set_username_has_succeeded().
2791 (modest_server_account_set_username),
2792 Reset the has-succeeded flag if the username changes.
2794 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2795 * src/maemo/modest-connection-specific-smtp-window.c:
2796 (modest_connection_specific_smtp_window_save_server_accounts):
2797 Use modest_server_account_set_username() instead of using
2798 modest_conf_set_string() directly, so that the has-succeeded flag is always
2801 * src/modest-ui-actions.c:
2802 (modest_ui_actions_on_password_requested): Dim the username entry if
2803 the username has ever worked, as per the UI spec.
2805 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2807 * src/modest-tny-account-store.c: (get_password):
2808 * src/modest-ui-actions.c:
2809 (modest_ui_actions_on_password_requested):
2810 Allow the username to be changed too, though there is more work to
2811 be done on exactly how this behaves.
2813 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2815 * src/modest-account-mgr-helpers.h:
2816 * src/modest-account-mgr-helpers.c:
2817 Added modest_account_mgr_get_display_name(),
2818 modest_server_account_get_username(),
2819 modest_server_account_set_username(),
2820 modest_server_account_set_password(),
2821 modest_server_account_get_hostname() functions so we do not need to
2822 use the conf API directly.
2824 * src/maemo/modest-main-window.c: (connect_signals):
2825 Actually connect ot the ModestAccountStore::request-password signal,
2826 so that we show the dialog when the password is requested by Tinymail,
2827 for isntance if it is empty.
2829 * src/modest-marshal.list:
2830 * src/modest-tny-account-store.c:
2831 (modest_tny_account_store_class_init), (get_password),
2832 (modest_tny_account_store_alert):
2833 * src/modest-tny-account-store.h:
2834 * src/modest-ui-actions.h:
2835 * src/modest-ui-actions.c:
2836 (modest_ui_actions_on_password_requested):
2837 Change the signal parameters, so it is obvious that we are providing
2838 the non human-readable server name, and receiving both the username
2839 and password, though changing of the username is not yet implemented.
2840 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2841 for the GNOME version.
2843 This should fix the projects.maemo.org bug NB#56209, though it does not
2844 work on Bora, because the gconf_client_get() for the password fails
2845 immediately after we save it with gconf_client_set().
2847 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2850 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2851 caused an undefined symbol error:
2852 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2854 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2856 * src/modest-tny-account-store.c:
2857 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2858 using a GError instead of a string message, so we can translate it in
2861 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2863 * src/maemo/modest-address-book.c:
2864 (modest_address_book_check_names):
2865 * src/maemo/modest-msg-view-window.c:
2866 (modest_msg_view_window_clipboard_owner_change):
2867 * src/modest-init.c: (modest_init_init_ui):
2868 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2869 (update_folders_cb), (modest_mail_operation_update_account):
2870 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2871 (modest_ui_actions_on_msg_attachment_clicked),
2872 (modest_ui_actions_on_msg_recpt_activated):
2873 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2874 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2875 (modest_msg_view_search_next):
2876 * src/widgets/modest-recpt-editor.c:
2877 (modest_recpt_editor_on_button_release_event),
2878 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2879 g_message(). At this point we should only be seeing interesting errors on
2880 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2882 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2884 (modest_wizard_dialog_force_title_update):
2885 * src/maemo/easysetup/modest-wizard-dialog.h:
2886 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2887 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2888 can update the title when appropriate. Otherwise the title is wrong if the
2889 pages are added after adding the notebook to the dialog.
2890 This must be a problem in HildonWizardDialog too.
2891 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2893 * src/maemo/easysetup/modest-easysetup-wizard.c:
2894 (create_subsequent_customsetup_pages),
2895 (create_subsequent_easysetup_pages):
2896 Call modest_wizard_dialog_force_title_update() so that the title is
2897 correct even with GTK+ < 2.10.
2898 This fixes projects.maemo.org bug NB#56145 .
2900 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2902 * src/maemo/modest-platform.c:
2903 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2904 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2907 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2909 * src/widgets/modest-window.h:
2910 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2911 and modest_window_save_state(), which invokes it.
2913 * src/widgets/modest-window-mgr.h:
2914 * src/widgets/modest-window-mgr.c:
2915 Added modest_window_mgr_save_state_for_all_windows(), which calls
2916 the save_state vfunc on all registered windows, if implemented.
2918 * src/gnome/modest-msg-edit-window.c:
2919 * src/gnome/modest-msg-view-window.c:
2920 * src/maemo/modest-msg-edit-window.c:
2921 * src/maemo/modest-msg-view-window.c:
2922 * src/maemo/modest-main-window.c:
2923 Specify the existing save_settings functions as implementations of
2924 ModestWindow::save_state_func().
2926 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2927 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2928 enabling hibernation, for instance.
2930 We may need to do the same thing for restoring settings.
2933 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2935 * src/widgets/modest-window-mgr.c:
2936 * src/widgets/modest-window-mgr.h:
2937 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2938 modest_window_mgr_get_hibernation_is_prevented().
2940 * src/maemo/modest-main-window.c:
2941 (on_hildon_program_is_topmost_notify): Prevent hibernation
2942 (possible when the application goes to the background in the WM),
2943 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2945 * src/maemo/easysetup/modest-easysetup-wizard.c:
2946 (modest_easysetup_wizard_dialog_init):
2947 * src/maemo/modest-account-settings-dialog.c:
2948 (modest_account_settings_dialog_init):
2949 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2950 (modest_connection_specific_smtp_edit_window_init):
2951 * src/maemo/modest-connection-specific-smtp-window.c:
2952 (modest_connection_specific_smtp_window_init):
2953 * src/maemo/modest-signature-editor-dialog.c:
2954 (modest_signature_editor_dialog_init):
2955 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2956 prevent hibernation while any of these account settings dialogs are open.
2958 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2960 * src/maemo/Makefile.am:
2961 * src/maemo/modest-osso-state-saving.c:
2962 * src/maemo/modest-osso-state-saving.h: Added
2963 modest_osso_load_state() and modest_osso_save_state() though they do
2964 nothing now. They should iterate through all the open windows and load/save
2966 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2967 save state when closing.
2969 * src/maemo/modest-main-window.c:
2970 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2971 Add a notification handler for the HildonProgram::is-topmost property,
2972 so we can allow hibernation when the application goes into the background.
2973 But we still need to detect when the accounts setup windows are open so
2974 we can stop hibernation when they are open.
2975 To do this, I also added the main window the HildonProgram. This might have
2976 other side-effects/benefits, and should maybe be done for other windows.
2978 * src/maemo/modest-osso-autosave-callbacks.h:
2979 * src/maemo/modest-osso-autosave-callbacks.c:
2980 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2981 though it does not do anything yet, and we might never need this to do
2982 anything. For instance, we already save drafts.
2984 * src/maemo/modest-platform.c: (modest_platform_init):
2985 Specify the libosso auto-save callback.
2987 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2989 * src/maemo/modest-platform.c:
2990 (modest_platform_set_update_interval):
2991 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2992 aparently stays valid between application instances, so we can use this
2993 to remove and reset it later. According to a maemo-developers email from
2996 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2998 * configure.ac: Depend on libalarm for Maemo.
3000 * src/dbus_api/modest-dbus-api.h:
3001 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3002 (on_send_receive), (modest_dbus_req_handler):
3003 Handle a SEND_RECEIVE D-Bus method.
3005 * libmodest-dbus-client/libmodest-dbus-client.c:
3006 (libmodest_dbus_client_send_and_receive):
3007 * libmodest-dbus-client/libmodest-dbus-client.h:
3008 Add C convenience functions for calling the new D-Bus method.
3010 * src/modest-platform.h:
3011 * src/gnome/modest-platform.c:
3012 * src/maemo/modest-platform.c:
3013 Added modest_platform_set_update_interval(), which uses the
3014 alarmd API on Maemo.
3015 (modest_platform_init),
3016 Call modest_platform_set_update_interval(), using a hard-coded
3017 interval for now (until the global settings dialog is implemented),
3018 though I am not sure that this makes sense yet.
3020 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3022 * src/dbus_api/modest-dbus-callbacks.c:
3023 (modest_osso_cb_hw_state_handler):
3024 * src/dbus_api/modest-dbus-callbacks.h:
3025 * src/maemo/modest-platform.c: (modest_platform_init):
3026 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3027 in case this has some effect on the ability for Maemo to ping the
3030 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3032 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3033 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3034 warning. It is probably a logic error, but I need to fix the build.
3036 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3038 * src/modest-account-mgr.h:
3039 * src/modest-account-mgr.c:
3040 (modest_account_mgr_account_names): Add a gboolean enabled_only
3041 parameter, so we can get lists of onlt the enabled accounts.
3043 (modest_account_mgr_add_account),,
3044 (modest_account_mgr_account_with_display_name_exists):
3045 * src/maemo/modest-msg-edit-window.c: (get_transports):
3046 * src/modest-account-mgr-helpers.c:
3047 (modest_account_mgr_set_first_account_as_default):
3048 * src/modest-init.c: (init_default_account_maybe):
3049 * src/modest-tny-account-store.c: (get_accounts):
3050 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3051 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3052 * tests/check_account-mgr.c: (START_TEST):
3053 Provide the extra parameter, as appropriate.
3055 * src/widgets/modest-account-view.c: (update_account_view):
3056 Do not show disabled accounts (meaning that there is no way to
3057 enable/disable accounts in the UI (the feature is not in our UI
3058 specification), so we can use this internally only to mark unfinished
3059 or temporary account data.
3061 * src/maemo/easysetup/modest-easysetup-wizard.c:
3062 (create_account): Add boolean enable parameter, so we can specify FALSE
3063 to create the temporary account.
3064 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3065 (on_before_next): When finishing, when there is a temporary account, just
3067 Also, use a timeout to delay the showing of the dialog until gconf is likely
3068 to return correct information, due to a maemo gconf bug that is fixed in
3069 osso 1.1, but not yet in Bora.
3070 However, the dialog stays on screen after it is destroyed.
3072 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3073 for invalid data when cancelling. Use a hildon note instead of a dialog
3074 to complain about invalid data. Do not show the account-saved note if the
3075 account is disabled (a temporary account that will not really be saved for use
3078 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3080 * src/modest-account-mgr-helpers.h:
3081 * src/modest-account-mgr-helpers.c:
3082 Added modest_account_mgr_unset_default_account(),
3083 Added modest_account_mgr_set_first_account_as_default().
3085 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3086 If it was the default account, unset the default account name.
3088 * src/maemo/modest-account-view-window.c:
3089 (on_delete_button_clicked): If it was the default account,
3090 set the first remaining account as the default instead.
3092 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3093 a NULL account or a NULL default account, to prevent a crash. This should
3094 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3097 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3099 * src/widgets/modest-recpt-editor.c:
3100 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3101 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3102 TODO comment for this. This fixes the build.
3104 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3105 be the best place for it. This will in future update all auto-update accounts,
3106 rather than just the current/default account, when that gconf key exists.
3107 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3108 if there are no accounts, before calling do_send_receive().
3109 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3111 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3112 * src/maemo/modest-main-window-ui.h:
3113 * src/maemo/modest-main-window.c: (on_connection_changed),
3114 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3115 directly, becaue the signal handler does more.
3117 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3119 * src/modest-account-mgr-helpers.c:
3120 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3121 for the case that the account does not exist.
3123 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3124 (equivalent to the modest account name) rather than the tinymail account name
3125 (equivalent to the modest account title - human readable) to get the account data.
3126 Check for null account data to prevent the crash, and add a TODO comment saying that
3127 this needs fixing because it is using the server account name instead of the account name.
3129 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3131 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3132 * src/maemo/modest-account-settings-dialog.c: (show_error),
3134 Use hildon_note_new_information() for informative and error messages,
3135 which seems to be expected for Maemo applications (no documentation that I know of
3136 says this). I am surprised that there is no distinction between info and error
3139 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3141 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3142 it is easy to find where this is used.
3144 * src/maemo/easysetup/modest-easysetup-wizard.c:
3145 (create_page_welcome), (create_page_account_details),
3146 (create_page_user_details), (create_page_complete_easysetup),
3147 (create_page_custom_incoming), (create_page_custom_outgoing),
3148 (create_page_complete_custom):
3149 * src/maemo/modest-account-settings-dialog.c:
3150 (create_page_account_details), (create_page_user_details),
3151 (create_page_incoming), (create_page_outgoing):
3152 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3153 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3154 (modest_connection_specific_smtp_edit_window_init):
3155 * src/maemo/modest-connection-specific-smtp-window.c:
3156 (modest_connection_specific_smtp_window_init):
3157 * src/maemo/modest-signature-editor-dialog.c:
3158 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3159 and scrolling policy as per the Email Application Layout Guide, if I have
3162 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3164 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3165 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3166 which were empty, because these vfuncs have been removed from TnyAccountStore.
3167 This fixes the build.
3169 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3171 * src/maemo/modest-main-window.c:
3172 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3173 showing/hiding it. Added TODO because it probably should not be NULL.
3174 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3175 because unnecessary g_warnings() make degugging difficult.
3177 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3179 * src/maemo/modest-msg-edit-window.c:
3180 (modest_msg_edit_window_select_color),
3181 (modest_msg_edit_window_select_background_color): 2 const corrections and
3182 moving 2 #endifs before closing brackets, to fix the build.
3184 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3186 * src/maemo/easysetup/modest-easysetup-wizard.h:
3187 * src/maemo/easysetup/modest-easysetup-wizard.c:
3188 (modest_easysetup_wizard_dialog_finalize),
3189 (on_button_edit_advanced_settings), (create_page_complete_custom),
3190 (on_response), (create_account):
3191 Implement the Advanced Settings edit button, by saving the account information,
3192 for the Advanded Settings dialog to use directly from gconf, and removing it
3193 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3194 Bug #5533 in the projects.maemo.org bugzilla.
3196 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3198 * src/maemo/modest-msg-view-window.c:
3199 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3200 when opening a message window.
3202 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3204 * src/maemo/easysetup/modest-easysetup-wizard.c:
3205 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3208 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3209 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3210 gconf settings. I probably added more checks than necessary, but that is safer.
3212 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3213 variable to fix the build, but this seems to be used when it is still NULL.
3215 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3217 * src/modest-platform.h:
3218 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3219 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3220 * src/modest-main.c: Implement this function so we can avoid using
3221 maemo-specific API from cross-platform code.
3223 * src/modest-tny-account-store.c:
3224 (get_smtp_specific_transport_account_for_open_connection):
3225 * src/modest-ui-actions.c: (check_for_connection),
3226 (modest_ui_actions_on_item_not_found):
3227 Use modest_platform_connect_and_wait() and put #idefs around other
3228 maemo-specific code, because only maemo currently has a way to
3229 identify connection names.
3231 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3233 * src/modest-tny-account-store.h:
3234 * src/modest-tny-account-store.c:
3235 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3236 the connection-specific SMTP server settings in the configuration.
3238 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3240 * src/maemo/modest-main-window.c: (on_connection_changed),
3242 * src/modest-main.c: (main), (start_ui), (send_mail):
3243 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3244 that is what is intended.
3246 * src/modest-ui-actions.c: (action_send), (action_receive),
3247 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3248 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3249 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3250 SMTP server is used when it is specified.
3252 (modest_ui_actions_on_send_receive):
3253 Check that a connection is open before proceeding.
3254 Receive and then send, instead of vice-versa, as per the specification.
3256 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3258 * src/modest-mail-operation.c:
3259 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3260 though I guess it should be something other than NULL.
3262 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3264 * src/maemo/easysetup/modest-easysetup-wizard.c:
3265 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3266 combo twice, to avoid an g_warning and to make it visible again.
3267 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3268 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3269 (already intended) dereference when detaching, because we then recreate the menu.
3270 But I am not sure why the warning was happening, and it is possible that this is a memory
3273 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3275 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3276 and uri_parse_mailto() utility functions.
3277 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3279 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3281 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3283 * src/dbus_api/modest-dbus-api.h:
3284 * src/dbus_api/modest-dbus-callbacks.c:
3285 Use an idle callback to execute the modest code in the application's own thread.
3286 Remove the helloworld example method.
3287 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3288 parsed, and the open-message method is not implemented because this is not yet implemented in
3290 * libmodest-dbus-client/libmodest-dbus-client.c:
3291 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3292 (libmodest_dbus_client_open_message):
3293 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3295 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3296 body without crashing.
3298 * tests/dbus_api/Makefile.am:
3299 * tests/dbus_api/test_mail_to.c:
3300 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3302 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3304 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3305 Added file to fix the build. Sorry.
3307 * src/dbus_api/Makefile.am:
3308 * src/dbus_api/modest-dbus-api.h:
3309 * src/dbus_api/modest-dbus-callbacks.h:
3310 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3311 (modest_dbus_req_handler):
3312 Put constants in a separate header so it can be reused by the
3313 client library, without duplication
3315 * libmodest-dbus-client/Makefile.am:
3316 * libmodest-dbus-client/libmodest-dbus-client.c:
3317 (libmodest_dbus_client_call_helloworld),
3318 (libmodfest_dbus_client_send_mail),
3319 (libmodfest_dbus_client_mailto),
3320 (libmodfest_dbus_client_open_message):
3321 * libmodest-dbus-client/libmodest-dbus-client.h:
3322 (Partly) Implement a send_mail D-Bus method.
3324 * tests/dbus_api/Makefile.am:
3325 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3326 the send_email D-Bus method.
3328 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3332 * libmodest-dbus-client/Makefile.am:
3333 * libmodest-dbus-client/libmodest-dbus-client.c:
3334 * libmodest-dbus-client/libmodest-dbus-client.h:
3335 * tests/dbus_api/Makefile.am:
3336 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3337 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3339 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3341 * src/maemo/easysetup/modest-easysetup-wizard.c:
3342 (create_page_account_details):
3343 * src/maemo/modest-account-settings-dialog.c:
3344 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3345 widgets, because this might not be the default in future versions of the Maemo GTK+.
3346 However, I can not not get capitalization to work even in a simple test case.
3348 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3350 * src/maemo/easysetup/modest-easysetup-wizard.c:
3351 (create_page_custom_incoming), (create_page_custom_outgoing):
3352 * src/maemo/modest-account-settings-dialog.c:
3353 (create_page_account_details), (create_page_incoming),
3354 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3355 instead of using gtk_check_button_with_label(), so they are aligned like the other
3356 widgets, as per the UI spec.
3358 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3360 * src/maemo/easysetup/modest-easysetup-wizard.c:
3361 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3362 * src/widgets/modest-validating-entry.c:
3363 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3364 Modest prefix instead of an EasySetup prefix.
3366 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3368 * src/widgets/modest-validating-entry.h:
3369 * src/widgets/modest-validating-entry.c: (on_insert_text),
3370 Added easysetup_validating_entry_set_max_func(), used to set a callback
3371 to call when the max number of characters is reached. GtkEntry has a max-length
3372 already but is silent about it.
3374 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3375 (create_page_account_details), (create_page_user_details),
3377 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3378 (create_page_account_details), (create_page_user_details),
3379 (create_page_outgoing):
3380 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3381 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3382 the UI spec, when the user tries to enter more than the max number of characters.
3384 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3386 * src/maemo/easysetup/modest-easysetup-wizard.c:
3387 (create_page_user_details), (create_page_custom_incoming),
3388 (create_page_custom_outgoing):
3389 * src/maemo/modest-account-settings-dialog.c:
3390 (create_page_user_details), (create_page_incoming),
3391 (create_page_outgoing):
3392 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3393 (modest_connection_specific_smtp_edit_window_init):
3394 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3395 not appropriate. Bad Maemo-specific defaults!.
3397 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3399 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3400 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3401 (modest_signature_editor_dialog_set_settings):
3402 Disable the label and textview when the checkbox is disabled, and use the
3403 specified (UI spec) default signature text.
3405 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3407 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3408 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3410 * src/modest-defs.h:
3411 * src/modest-account-mgr-helpers.h:
3412 * src/modest-account-mgr-helpers.c:
3413 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3415 * src/maemo/Makefile.am:
3416 * src/maemo/modest-signature-editor-dialog.c:
3417 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3420 * src/maemo/modest-account-settings-dialog.h:
3421 * src/maemo/modest-account-settings-dialog.c:
3422 (modest_account_settings_dialog_finalize), (on_button_signature),
3423 (save_configuration): Use the new dialog when the Edit button is pressed, and
3424 save the changes if necessary, as per the UI spec.
3426 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3428 * src/maemo/Makefile.am:
3429 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3430 based on maemo-develoers email from Dirk.
3432 * src/maemo/easysetup/modest-easysetup-wizard.c:
3433 (create_page_welcome), (create_page_account_details),
3434 (create_page_user_details), (create_page_complete_easysetup),
3435 (create_page_custom_incoming), (create_page_custom_outgoing),
3436 (create_page_complete_custom),
3437 (modest_easysetup_wizard_dialog_init):
3438 * src/maemo/modest-account-settings-dialog.c:
3439 (create_page_account_details), (create_page_user_details),
3440 (create_page_incoming), (create_page_outgoing),
3441 (modest_account_settings_dialog_init):
3442 * src/maemo/modest-connection-specific-smtp-window.c:
3443 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3445 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3447 * src/maemo/easysetup/modest-easysetup-wizard.c:
3448 (create_page_account_details), (create_page_custom_outgoing),
3449 (create_page_complete_custom):
3450 * src/maemo/modest-account-settings-dialog.c:
3451 (create_page_user_details), (create_page_incoming),
3452 (create_page_outgoing):
3453 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3454 (modest_connection_specific_smtp_edit_window_init):
3455 Use the correct (UI spec) port min/max, and use horizontal separators,
3458 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3460 * src/maemo/easysetup/modest-easysetup-wizard.c:
3461 (set_default_custom_servernames):
3462 * src/maemo/modest-account-settings-dialog.c:
3463 (create_page_incoming), (on_combo_outgoing_security_changed),
3464 (on_combo_incoming_security_changed), (create_page_outgoing),
3465 (modest_account_settings_dialog_set_account_name),
3466 (save_configuration):
3467 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3468 (on_combo_security_changed),
3469 (modest_connection_specific_smtp_edit_window_init),
3470 (modest_connection_specific_smtp_edit_window_set_connection),
3471 (modest_connection_specific_smtp_edit_window_get_settings):
3472 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3475 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3478 * src/maemo/easysetup/modest-easysetup-wizard.c:
3479 (create_page_custom_outgoing), (create_page_complete_custom):
3480 * src/maemo/modest-account-settings-dialog.c:
3481 (create_page_user_details), (create_page_outgoing):
3482 * src/maemo/modest-account-view-window.c: (button_box_new):
3483 Use changed logical IDs as per the most recent UI spec:
3484 mcen_bd_emailsetup_edit -> mcen_bd_edit
3485 mcen_bd_emailsetup_delete -> mcen_bd_delete
3486 mcen_bd_emailsetup_close -> mcen_bd_close
3488 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3492 * src/dbus_api/Makefile.am:
3493 * src/dbus_api/modest-dbus-callbacks.c:
3494 * src/dbus_api/modest-dbus-callbacks.h:
3495 * src/maemo/modest-platform.c: (modest_platform_init):
3496 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3498 * tests/Makefile.am:
3499 * tests/dbus_api/Makefile.am:
3500 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3502 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3504 * src/maemo/modest-account-settings-dialog.c:
3505 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3506 Removed unnecessary includes.
3508 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3510 * src/maemo/easysetup/modest-easysetup-wizard.c:
3511 * src/maemo/modest-account-settings-dialog.c:
3512 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3513 * src/widgets/Makefile.am:
3514 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3515 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3516 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3517 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3518 * src/widgets/modest-secureauth-combo-box.c:
3519 * src/widgets/modest-secureauth-combo-box.h:
3520 * src/widgets/modest-serversecurity-combo-box.c:
3521 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3522 made the GObject names more consistent with the rest of the Modest code.
3524 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3526 * src/maemo/easysetup/Makefile.am:
3527 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3528 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3529 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3530 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3531 * src/maemo/easysetup/modest-easysetup-wizard.c:
3532 * src/maemo/easysetup/modest-validating-entry.c:
3533 * src/maemo/easysetup/modest-validating-entry.h:
3534 * src/maemo/modest-account-settings-dialog.c:
3535 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3536 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3537 widgets/ because they are used outside of easysetup too. After checking in,
3538 svn will allow me to rename them too.
3540 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3542 * src/gnome/modest-msg-edit-window.c:
3543 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3544 linker error, to fix the build on the GNOME platform.
3545 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3546 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3547 ifdefed out to avoid a warning.
3549 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3551 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3552 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3553 some alternative for GTK+ 2.6.
3555 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3557 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3559 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3560 specified for EmailAccountsDialog in UI spec.
3562 * src/maemo/easysetup/modest-easysetup-wizard.c:
3563 * src/maemo/easysetup/modest-easysetup-wizard.h:
3564 * src/maemo/modest-account-settings-dialog.c:
3565 * src/maemo/modest-account-settings-dialog.h:
3566 Reuse a member window widget for the connection-specific SMTP server accounts,
3567 so we can tell it to create/save the accounts only if we actually save changes.
3569 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3570 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3571 (modest_connection_specific_smtp_edit_window_get_settings):
3572 Return a struct instance for temporarily remembering the entered data.
3574 * src/maemo/modest-connection-specific-smtp-window.h:
3575 * src/maemo/modest-connection-specific-smtp-window.c:
3576 (modest_connection_specific_smtp_window_finalize),
3577 (modest_connection_specific_smtp_window_fill_with_connections),
3579 (modest_connection_specific_smtp_window_save_server_accounts),
3580 (update_model_server_names): Do not actually save data until asked,
3581 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3583 (on_selection_changed),
3584 (modest_connection_specific_smtp_window_init): Disable the edit
3585 button when nothing is selected.
3587 * src/modest-account-mgr-helpers.c:
3588 * src/modest-account-mgr-helpers.h:
3589 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3592 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3594 * src/modest-account-mgr-helpers.h:
3595 * src/modest-account-mgr-helpers.c:
3596 (modest_account_mgr_get_unused_account_name),
3597 (modest_account_mgr_get_unused_account_display_name): Added these
3598 utility functions, to avoid code duplication.
3600 * src/maemo/easysetup/modest-easysetup-wizard.c:
3601 (create_page_account_details), (create_account):
3602 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3603 (on_combo_security_changed),
3604 (modest_connection_specific_smtp_edit_window_init),
3605 (modest_connection_specific_smtp_edit_window_save_settings):
3606 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3607 * src/maemo/modest-connection-specific-smtp-window.c:
3608 (modest_connection_specific_smtp_window_finalize),
3609 (modest_connection_specific_smtp_window_fill_with_connections),
3610 (on_button_edit), (modest_connection_specific_smtp_window_init):
3611 * src/maemo/modest-connection-specific-smtp-window.h:
3612 Implementing saving of connection-specific server accounts.
3614 But I need to refactor this so we can save the data for each
3615 possible connection-specific account and only actually create the server accounts
3616 when the easysetup finished, or the OK button is pressed on the account settings
3619 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3621 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3622 (on_combo_security_changed):
3623 (modest_connection_specific_smtp_edit_window_init):
3624 Auto-fill the port number as in the account settings.
3626 (modest_connection_specific_smtp_edit_window_set_connection):
3627 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3628 * src/maemo/modest-connection-specific-smtp-window.c:
3629 (fill_with_connections), (on_button_edit),
3630 (modest_connection_specific_smtp_window_init):
3631 Turn the edit window into a dialog to simplify the code, and
3632 set a WM hint as in a GtkDialog, because only a popup can be on top of
3633 another window in Maemo, and popups usually have no WM decoration.
3635 * src/modest-defs.h:
3636 * src/modest-account-mgr-helpers.c:
3637 (modest_account_mgr_set_connection_specific_smtp),
3638 (modest_account_mgr_remove_connection_specific_smtp),
3639 (modest_account_mgr_get_connection_specific_smtp):
3640 * src/modest-account-mgr-helpers.h: Some functions to write the
3641 connection-specific SMTP server information. Not yet used.
3644 * src/widgets/modest-folder-view.c: (text_cell_data):
3645 Fix a warning about an uninitialized variable.
3646 (on_configuration_key_changed): Put an #ifdef around the use
3647 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3649 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3651 * src/maemo/modest-account-settings-dialog.h:
3652 * src/maemo/modest-account-settings-dialog.c:
3653 Added connect_for_modified() utility function to mark the new modified boolean.
3655 (create_page_account_details), (create_page_user_details),
3656 (create_page_incoming), (create_page_outgoing), (on_response),
3657 (modest_account_settings_dialog_init),
3658 (modest_account_settings_dialog_set_account_name):
3659 Only warn about unsaved changes when there are actually unsaved changes.
3661 * src/modest-account-mgr-helpers.c:
3662 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3663 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3664 to get the data from there in future.
3666 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3668 * src/modest-defs.h:
3670 * src/modest-account-mgr-helpers.h:
3671 * src/modest-account-mgr-helpers.c:
3672 Store the security account setting in a single conf key instead of using
3673 the options list, so that the list is left for just the to-be-removed camel hack,
3674 and because gconf_client_set_list() is failing for some reason.
3676 * src/modest-account-mgr.c:
3677 (modest_account_mgr_add_server_account):
3678 * src/maemo/modest-account-settings-dialog.c:
3679 (modest_account_settings_dialog_set_account_name),
3680 (save_configuration): Use the renamed functions.
3683 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3685 * src/widgets/Makefile.am:
3686 * src/widgets/modest-limit-retrieve-combo-box.c:
3687 * src/widgets/modest-limit-retrieve-combo-box.h:
3688 * src/widgets/modest-retrieve-combo-box.c:
3689 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3690 the account settings dialog.
3692 * src/modest-defs.h:
3693 * src/modest-account-mgr-helpers.h:
3694 * src/modest-account-mgr-helpers.c:
3695 (modest_server_account_get_option_secure_auth),
3696 (modest_server_account_set_option_secure_auth):
3697 * src/modest-account-mgr.c:
3698 (modest_account_mgr_add_server_account):
3699 Use the existing AUTH_MECH conf key for the secure-auth setting,
3700 instead of putting it in the list options, because this was actually used already.
3702 * src/maemo/modest-account-settings-dialog.c:
3703 (create_page_account_details),
3704 (modest_account_settings_dialog_set_account_name),
3705 (save_configuration):
3706 * src/maemo/modest-account-settings-dialog.h:
3707 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3708 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3710 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3712 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3713 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3714 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3716 * src/modest-defs.h:
3717 * src/maemo/modest-account-settings-dialog.c:
3718 (create_page_incoming), (on_combo_outgoing_security_changed),
3719 (on_combo_incoming_security_changed), (create_page_outgoing),
3720 (modest_account_settings_dialog_set_account_name),
3721 (save_configuration): Load/Save the port number, and change it when the
3722 security combo changes, to suitable defaults.
3724 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3726 * src/modest-account-mgr.c:
3727 (modest_account_mgr_add_server_account): Set the security and secure-auth
3728 options, and add a comment saying that the other camel-specific options should be
3731 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3733 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3735 * src/modest-tny-account-store.c: (account_list_free),
3736 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3737 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3740 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3742 * src/modest-protocol-info.c:
3743 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3744 is required by our UI spec. Maybe something in our implementation will use this eventually.
3745 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3746 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3747 instead of the previous 0 placeholder.
3749 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3750 secure-auth settings.
3751 * src/modest-account-mgr-helpers.h:
3752 * src/modest-account-mgr-helpers.c:
3753 (modest_server_account_data_get_option_secure_auth),
3754 (modest_server_account_set_option_secure_auth),
3755 (modest_server_account_data_get_option_security),
3756 (modest_server_account_set_option_security): Added this API for getting and setting the security
3757 and secure-auth settings.
3759 * src/maemo/modest-account-settings-dialog.h:
3760 * src/maemo/modest-account-settings-dialog.c:
3761 (modest_account_settings_dialog_finalize), (check_data),
3762 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3763 about changing titles.
3764 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3765 (save_configuration): Save the security and secure-auth settings.
3767 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3768 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3770 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3772 * src/modest-defs.h:
3773 * src/modest-account-mgr.c:
3774 (modest_account_mgr_add_server_account):
3775 Added and used defines for the options key and value pair strings,
3776 that are used so far, though they do not seem to correspond to anything in our
3777 UI specs or ModestProtocol enum.
3779 * src/modest-account-mgr-helpers.h:
3780 * src/modest-account-mgr-helpers.c:
3781 (compare_option_strings_for_name),
3782 (modest_server_account_data_get_option_value),
3783 (modest_server_account_data_get_option_bool),
3784 (modest_account_mgr_get_server_account_option):
3785 Added helper functions for parsing the options GSList.
3787 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3789 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3790 display name is based on the supplied account name.
3791 * src/modest-account-mgr.c:
3792 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3793 with an inefficient, but good-enough, implementation.
3795 * src/maemo/easysetup/modest-easysetup-wizard.c:
3796 (create_page_account_details), (on_before_next), (create_account):
3797 Check for existing display names rather than (non-user-visible) account names, and just
3798 create and set a unique account name at the end.
3800 * src/maemo/modest-account-settings-dialog.c:
3801 (modest_account_settings_dialog_init),
3802 (modest_account_settings_dialog_set_account_name),
3803 (create_page_incoming): Show the display name, instead of the account name.
3804 (on_response): Do some (not all) extra checks, as in the UI spec.
3805 (save_configuration): Save the display name if it was changed.
3807 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3809 * po/en_GB.po: Added needed logical ID and translation.
3810 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3811 (init_view): Made the is-default column clicking work.
3813 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3816 * src/maemo/easysetup/Makefile.am:
3817 * src/maemo/easysetup/modest-easysetup-wizard.c:
3818 (modest_easysetup_wizard_dialog_init):
3819 * src/maemo/easysetup/provider-data-test.keyfile:
3820 * src/maemo/easysetup/provider-data.keyfile:
3821 Moved the provider data file to the new modest-providers-data package and used it from there.
3823 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3825 * src/modest-local-folder-info.c:
3826 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3827 N_() was already used on the static strings, but this just marks it for translation without
3828 using the translation.
3830 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3832 * src/maemo/modest-account-settings-dialog.c:
3833 (create_page_incoming),
3834 (modest_account_settings_dialog_set_account_name):
3835 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3836 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3837 I will do this if nobody else gets there first.
3839 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3841 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3842 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3843 save the security stuff.
3845 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3847 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3848 Set the email address and user fullname, which I now see must be
3851 * src/maemo/modest-account-settings-dialog.h:
3852 * src/maemo/modest-account-settings-dialog.c:
3854 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3855 leave-on-server and authentication.
3856 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3859 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3862 * src/maemo/modest-account-settings-dialog.c:
3863 * src/maemo/modest-account-settings-dialog.h:
3864 Most (but not all) of the widgets are now present as specified by the UI spec.
3865 No changes are yet saved, and some details are not properly shown yet.
3867 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3869 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3871 * src/maemo/Makefile.am:
3872 * src/maemo/modest-account-settings-dialog.c:
3873 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3874 an existing account. Doesn't do much yet.
3876 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3877 Open the accounts settings dialog when Edit is clicked.
3879 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3881 * src/maemo/easysetup/Makefile.am:
3882 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3884 * src/maemo/easysetup/modest-easysetup-wizard.c:
3885 (modest_easysetup_wizard_dialog_init):
3886 Try to get the source directory from the build system,
3887 instead of hard-coding "./" into the source code, when opening our local
3888 copies of the configuration files.
3889 But this still fails when opening the wizard from the Accounts window,
3890 maybe because the working directory seems to change at runtime.
3891 So the wizard will fail the second time unless you copy the files into their
3892 proper locations - see the stdout warnings for the paths.
3894 (create_page_account_details),(on_before_next):
3895 Check for existing non-server accounts instead of server accounts,
3896 so the default account name is useful again, and to prevent trying to
3899 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3900 Show the wizard when New is clicked.
3902 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3903 (init_view): Show the column headers, and show the columns that are
3904 specified in the UI specs. However, something in Maemo's GTK+ prevents
3905 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3906 change the default account. This is despite unsetting the special properties.
3908 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3910 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3911 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3912 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3913 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3914 to make that clearer.
3915 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3917 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3919 * src/maemo/modest-account-view-window.c:
3920 (modest_account_view_window_init),
3921 (modest_account_view_window_new):
3922 Use the same buttons as specified in the
3923 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3924 the existing widgets, which never had a chance of working.
3925 Put the ModestAccountView treeview in a scrolled window.
3926 Do not repeat the initialization in both _init() and _new().
3928 * src/widgets/modest-account-view.c: (update_account_view):
3929 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3930 this widget and window shows no accounts.
3932 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3934 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3936 * src/maemo/easysetup/modest-easysetup-wizard.c:
3937 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3938 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3939 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3942 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3943 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3944 accounts exist yet, as in the UI spec.
3946 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3948 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3950 * src/maemo/Makefile.am:
3951 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3952 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3953 New window for editing connection-specific smtp details.
3954 Not fully implemented.
3956 * src/maemo/modest-connection-specific-smtp-window.c:
3957 (modest_connection_specific_smtp_window_finalize) :
3958 unref the tree model.
3959 (on_button_edit): Show the edit window.
3961 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3963 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3966 * src/maemo/Makefile.am:
3967 * src/maemo/modest-connection-specific-smtp-window.c:
3968 * src/maemo/modest-connection-specific-smtp-window.h:
3969 New window for showing the list of connections, for connection-specific
3970 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3971 * src/maemo/easysetup/modest-easysetup-wizard.c:
3972 (create_page_custom_outgoing): Show the new window when the button is clicked.
3974 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3976 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3977 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3978 * src/maemo/modest-msg-edit-window.c:
3979 (modest_msg_edit_window_insert_image):
3980 * src/modest-conf.c: (modest_conf_key_escape):
3981 * src/modest-mail-operation.c:
3982 (modest_mail_operation_send_new_mail):
3983 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3984 (modest_ui_actions_on_new_account):
3985 * src/widgets/modest-attachment-view.c: (update_filename_request):
3986 * src/widgets/modest-mail-header-view.c:
3987 Corrected warnings that were breaking the build, by commenting out unused variables,
3988 and a function, and by including a header.
3990 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3992 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3993 so we can #ifdef around platform-specific code when necessary.
3994 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3995 to allow this to build for the GNOME platform too.
3997 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3999 * src/maemo/easysetup/modest-easysetup-wizard.c:
4000 Added util_increment_name() and used it in create_page_account_details()
4001 to make sure that the default account name is always a new name.
4003 (modest_easysetup_wizard_dialog_init),
4004 (set_default_custom_servernames): Some minor memory management fixes.
4006 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4010 * src/modest-runtime.c: (init_i18n): Restored the translation
4011 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4012 are defined in config.h, and the translations are installed.
4014 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4015 is defined for translation.
4017 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4019 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4021 * src/maemo/easysetup/modest-easysetup-wizard.c:
4022 (modest_easysetup_wizard_dialog_init):
4023 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4024 Use realistic paths (though they should use $prefix generically) to the
4025 mcc_mapping and provider-data.keyfile files which might work when they
4026 are installed by the future version of the operator-wizard package,
4027 and then fallback to paths in our source code, with an explanatory
4030 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4034 * src/maemo/Makefile.am:
4035 * src/maemo/easysetup/: Added files from the previously-exernal
4036 osso-modest-easysetup.
4037 * src/maemo/modest-main-window-ui.h:
4038 * src/modest-ui-actions.c:
4039 * src/modest-ui-actions.h:
4040 Added modest_ui_actions_on_new_account() as a signal handler for the
4041 New Account menu item. It shows the easysetup wizard.
4042 * po/en_GB.po: Added additional needed logical IDs and translations.