1 2007-06-02 Armin Burgmeier <armin@openismus.com>
3 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
4 and assigned max width chars so that they wrap instead of being
5 truncated. Fixes projects.maemo.org bug NB#56126.
7 2007-06-02 Armin Burgmeier <armin@openismus.com>
9 * src/maemo/modest-connection-specific-smtp-window.c: Add an
10 introductory note to the connection specific smtp servers dialog, as
11 section 8.12 of the email UI specification requires. This fixes
12 projects.maemo.org bug NB#59212.
14 2007-06-01 Murray Cumming <murrayc@murrayc.com>
16 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
17 Check for running mail operations, and offer to cancel them, as per the UI
18 spec. This fixes projects.maemo.org bug NB#59041 .
19 However, I suspect that tinymail may still use the network connection
20 in ways that we cannot detect or cancel. But it should at least adapt to
23 2007-06-01 Murray Cumming <murrayc@murrayc.com>
25 * src/modest-tny-account-store.c: (recreate_all_accounts),
26 (get_cached_accounts), (get_server_accounts): Do more sensible
27 ref-counting of the temporarily-cached outbox accounts list. This seems
28 to fix a crash when entering the password when the password was wrong.
30 2007-06-01 Murray Cumming <murrayc@murrayc.com>
32 * src/gnome/modest-main-window.c: (connect_signals):
33 * src/modest-tny-account-store.c: (get_password),
34 (modest_tny_account_store_alert): Added comments and clues and
35 commented-out code about how we currently fail to deal with connection
36 errors and wrong passwords, and how we should.
38 2007-06-01 Murray Cumming <murrayc@murrayc.com>
40 * src/widgets/modest-retrieve-combo-box.c:
41 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
42 This fixes projects.maemo.org bug NB#58472 .
44 2007-06-01 Murray Cumming <murrayc@murrayc.com>
46 * src/maemo/easysetup/modest-easysetup-wizard.c:
47 (create_page_complete_easysetup):
48 (create_page_complete_custom): Correct the last commit,
49 putting the correct sentences in the correct pages.
51 2007-06-01 Murray Cumming <murrayc@murrayc.com>
53 * src/maemo/easysetup/modest-easysetup-wizard.c:
54 (create_page_complete_custom): Show the second sentence of text
55 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
58 2007-06-01 Murray Cumming <murrayc@murrayc.com>
60 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
61 Set the leave-on-server conf key by default. This fixes
62 projects.maemo.org bug NB#59258 .
64 2007-06-01 Murray Cumming <murrayc@murrayc.com>
66 * src/maemo/modest-account-view-window.c:
67 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
68 logical ID for the confirmation messages. Fixed projects.maemo.org bug
71 2007-06-01 Murray Cumming <murrayc@murrayc.com>
73 * src/maemo/easysetup/modest-easysetup-wizard.c:
74 (create_caption_new_with_asterisk):
75 * src/maemo/modest-account-settings-dialog.c:
76 (create_caption_new_with_asterisk):
77 Uncomment the code to add the asterisk, because they are no longer in the
78 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
79 (update_incoming_server_title): Add an asterisk here too.
81 2007-06-01 Murray Cumming <murrayc@murrayc.com>
83 * src/maemo/modest-maemo-global-settings-dialog.c:
84 (current_connection): Check that we are even connected before trying to
85 get the current connection name, to prevent a warning.
87 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
88 Change the comments because tny_maemo_conic_device_connect() is now meant to
90 * src/modest-mail-operation.c:
91 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
92 make sure we have a connection and fail if we can't connect.
94 2007-05-31 Murray Cumming <murrayc@murrayc.com>
96 * src/maemo/modest-main-window.c:
97 (on_account_store_connecting_finished): Do not try to get the
98 connection ID if we are not really connected. I am surprised that
99 this signal handler is called when we are not connected.
101 2007-05-31 Murray Cumming <murrayc@murrayc.com>
103 * src/modest-error.h:
104 * src/modest-ui-actions.c:
105 (modest_ui_actions_get_msgs_full_error_handler):
106 Renamed an enum, added comments, added an enum
107 for retrieve-limit errors.
109 * src/modest-mail-operation.c: (foreach_add_item),
110 (internal_folder_observer_update), (update_account_thread),
111 (modest_mail_operation_get_msgs_full):
112 (modest_mail_operation_update_account),
113 Added comments about how this works, and some code that should
114 (but does not) check the retrieve-limit. See the TODO comment.
116 2007-05-31 Murray Cumming <murrayc@murrayc.com>
118 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
119 Initialize help_id to fix the build. Warnings are good.
121 2007-05-31 Murray Cumming <murrayc@murrayc.com>
123 * src/widgets/modest-hbox-cell-renderer.c:
124 (modest_hbox_cell_renderer_append):
125 * src/widgets/modest-vbox-cell-renderer.c:
126 (modest_vbox_cell_renderer_append):
127 Fix the last commit by doing an extra ref.
129 2007-05-31 Murray Cumming <murrayc@murrayc.com>
131 * src/widgets/modest-hbox-cell-renderer.c:
132 (modest_hbox_cell_renderer_append):
133 * src/widgets/modest-vbox-cell-renderer.c:
134 (modest_vbox_cell_renderer_append):
135 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
136 to fix the build with Maemo Bora.
137 However, there seems to be a remaining crash, probably due to reference
140 2007-05-30 Murray Cumming <murrayc@murrayc.com>
142 * src/modest-tny-account.c:
143 (modest_tny_account_new_for_local_folders):
144 Use hildon_file_system_info_async_new() to get a better name for
145 the memory card account, setting it as the account name.
146 The timing seems to work, but this is probably
147 not the best place to do this. See the TODO comment.
148 * src/maemo/modest-main-window.c: (create_details_widget):
149 * src/widgets/modest-folder-view.c: (text_cell_data):
150 Use the tny account name instead of hardcoding a name.
152 2007-05-30 Christian Kellner <ckellner@openismus.com>
154 * src/modest-search.c: (modest_search):
155 Correctly set part_search_func even if we have already parsed
156 the query and thus a valid OgsTextSearcher object.
158 2007-05-30 Christian Kellner <ckellner@openismus.com>
161 Search and check for libogs.
164 Incooparte the ogs build env.
166 * src/modest-mime-part-search-stream.c:
167 * src/modest-mime-part-search-stream.h:
168 Removed since we do the real searching now in modest-search.c.
170 * src/modest-search.c:
171 * src/modest-search.h:
172 Implement support for ogs. We use that if available and requested
173 and fall back to modest_text_utils_utf8_strcmp (). The search logic
174 should now handle the corner case when the search term is spread
175 across multiple reads.
176 Also the logic in modest_search () was corrected to search all
177 requested fields until one is found.
179 2007-05-30 Murray Cumming <murrayc@murrayc.com>
181 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
184 * src/modest-init.c: Made modest_init_local_folders() take a
185 path and be public so we can iniitialize maildir folders on
188 * src/modest-local-folder-info.h:
189 * src/modest-local-folder-info.c:
190 (modest_local_folder_info_get_maildir_path): Add a path parameter.
192 * src/modest-tny-account.c:
193 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
194 still means the standard local-folders path on the local volume.
196 * src/modest-tny-account-store.c:
197 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
198 signal so we can detect mount/unmount of the MMC1 card, and do an update of
199 all accounts when that happens.
200 (get_server_accounts): If the MMC1 card is mounted, create a store account for
201 this too, so it shows up in the treeview.
203 2007-05-28 Murray Cumming <murrayc@murrayc.com>
205 * src/maemo/modest-maemo-global-settings-dialog.c:
206 (current_connection):
207 * src/widgets/modest-global-settings-dialog.c:
208 (current_connection_default):
209 Use the enum values instead of 0, 1 and -1,
210 to make the code clearer.
212 * src/modest-account-mgr-helpers.c:
213 (modest_account_mgr_get_connection_specific_smtp): Make this code
216 * src/modest-runtime.h:
217 * src/modest-runtime.c:
218 Added modest_runtime_remove_all_send_queues().
219 * src/maemo/modest-main-window.c:
220 (on_account_store_connecting_finished): Recreate the send queues,
221 using the appropriate transport accounts for this new connection.
222 Some futher adapting might be needed if the old send queues are not
223 automatically stopped at this point.
225 * src/modest-tny-account-store.c: (get_server_accounts):
226 Create the connection-specific transport accounts, so that they can
227 be found later by their ID.
229 * src/modest-tny-account.h:
230 * src/modest-tny-account.c:
231 Added modest_tny_account_new_from_server_account_name().
232 modest_tny_account_new_from_server_account(): Do not create the
233 send queues here, because they will be
234 recreated anyway when the connection changes for the first time.
236 2007-05-28 Murray Cumming <murrayc@murrayc.com>
238 * src/modest-local-folder-info.h:
239 * src/modest-local-folder-info.c:
240 (modest_per_account_local_outbox_folder_info_get_maildir_path),
241 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
242 tbox_folder): Take a modest account name instead of a server TnyAccount,
243 so we can have per-modest-account rather than per-transport-account
245 We must make sure that we change or recreate the exisitng send queues
246 when the connection changes for connection-specific transport accounts.
248 * src/modest-tny-account-store.c:
249 (create_per_account_local_outbox_folders): Create outboxed per modest
250 account, not per transport account.
252 * src/modest-tny-account.h:
253 * src/modest-tny-account.c:
254 (modest_tny_account_get_special_folder): For outboxes, get the
255 parent modest account name. The account is ignored for other folders.
256 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
257 modest account name rather than a server TnyAccount.
259 2007-05-25 Murray Cumming <murrayc@murrayc.com>
261 * src/modest-tny-account.c:
262 (modest_tny_account_new_from_server_account):
263 Call modest_runtime_get_send_queue() immediately after creating transport
264 accounts, so that they start trying to send email from the outbox as soon
265 as possible at startup. This is probably what we want.
267 * src/modest-mail-operation.c: (update_account_thread):
268 * src/modest-runtime.c: (modest_runtime_get_send_queue):
269 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
270 * src/modest-tny-send-queue.h:
271 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
272 (modest_ui_actions_on_send):
273 Added comments about how sending works, though it needs some more work.
275 2007-05-25 Murray Cumming <murrayc@murrayc.com>
277 * src/modest-tny-account.c:
278 (modest_tny_account_get_special_folder): Add TODO because this fails when
280 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
281 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
282 Do not try to show this window when there is no active account. The UI
283 specs does not tell us what to do in this case.
285 2007-05-24 Murray Cumming <murrayc@murrayc.com>
289 * src/maemo/Makefile.am:
290 * src/widgets/Makefile.am: Some dist fixes.
292 2007-05-24 Murray Cumming <murrayc@murrayc.com>
294 * src/maemo/modest-connection-specific-smtp-window.c:
295 (on_button_edit): Make the code clearer, to prevent a double free.
297 2007-05-24 Murray Cumming <murrayc@murrayc.com>
299 * src/maemo/modest-account-settings-dialog.c:
300 (modest_account_settings_dialog_set_account_name),
301 Check the connection-specific smtp servers checkbox if there are any.
303 * src/maemo/modest-connection-specific-smtp-edit-window.c:
304 (modest_connection_specific_smtp_edit_window_init):
305 Start with a suitable port number.
307 * src/modest-account-mgr-helpers.h:
308 * src/modest-account-mgr-helpers.c: Added
309 modest_account_mgr_get_has_connection_specific_smtp().
311 (modest_account_mgr_set_connection_specific_smtp),
312 (modest_account_mgr_remove_connection_specific_smtp),
313 (modest_account_mgr_get_has_connection_specific_smtp),
314 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
315 connection-specific smtp server accounts in the account, rather than
316 the server account conf dir.
318 This fixes bug projects.maemo.org bug NB#58263 .
320 * src/modest-tny-account-store.c:
321 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
322 if there are no server accounts yet, to prevent an infinite loop when there
323 are no accounts. Document that one must be called before the other.
325 2007-05-24 Murray Cumming <murrayc@murrayc.com>
327 * src/modest-account-mgr-helpers.c:
328 (modest_account_mgr_get_default_account): Make sure that at least
329 one account is always the default, if there are any enabled accounts.
330 This is just a sanity check that shouldn't be necessary.
332 * src/modest-account-mgr-priv.c:
333 (_modest_account_mgr_account_from_key): Unescape the conf key to
334 get the real account name. For instance, this is an issue if a space
335 was in the account name, which can happen because the account name
336 is generated from the display name.
337 (_modest_account_mgr_get_account_keyname): Always escape the
339 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
340 Unescape the conf keys to get the real account names.
342 For instance, previously the is-default radio button in the accounts
343 list was not checked for any accounts at first. This fixes that,
344 and might fix several similar bugs.
346 2007-05-23 Murray Cumming <murrayc@murrayc.com>
348 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
349 Removed some debug printfs.
351 2007-05-23 Murray Cumming <murrayc@murrayc.com>
353 Modest on-disk outbox directories are now here, for instance:
354 $HOME/.modest/outboxes/<account-id-1>/outbox
355 $HOME/.modest/outboxes/<account-id-2>/outbox
357 $HOME/.modest/local-folders/outbox
358 so we can have a separate outbox for each account.
359 But they are shown as one outbox in the GtkTreeView, by using a
360 TnyMergeFolder in a ModestTnySimpleFolderStore.
363 * src/modest-tny-simple-folder-store.c:
364 * src/modest-tny-simple-folder-store.h:
365 Added ModestTnySimpleFolderStore, used to contain folders from
366 other folder stores, such as other accounts.
368 * src/modest-tny-outbox-account.h:
369 * src/modest-tny-outbox-account.c:
370 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
371 used for the per-account local outbox folders.
373 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
374 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
375 only use this (internally) now for the non-outbox local folders.
378 * src/modest-init.c: Added modest_init_one_local_folder(), for
379 setting up the directory structure for each local folder.
381 * src/modest-local-folder-info.c:
382 (modest_per_account_local_outbox_folder_info_get_maildir_path),
383 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
385 * src/modest-local-folder-info.h:
386 * src/modest-tny-account-store.c: (on_account_removed),
387 (on_account_changed), (create_per_account_local_outbox_folders),
388 (get_server_accounts), (modest_tny_account_store_get_accounts),
389 (modest_tny_account_store_get_tny_account_by_account),
390 (modest_tny_folder_store_is_virtual_local_folders):
392 * src/modest-tny-account.h:
393 * src/modest-tny-account.c:
394 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
395 to create an on-disk per-account local outbox folder for each
397 (create_per_account_local_outbox_folders): Create a local outbox folder
398 for each transport account.
399 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
400 for all local folders.
402 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
403 instead of using g_object_get/set() directly. It is clearer.
405 (modest_tny_folder_store_get_message_count),
406 (modest_tny_folder_store_get_local_size
407 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
408 because we now use these with non-acount folder stores.
410 (modest_tny_account_get_special_folder),
411 (modest_tny_account_new_from_server_account),
412 (modest_tny_account_new_from_account):
413 (recurse_folders): Adjust to the new outbox system.
415 * src/modest-tny-folder.h:
416 * src/modest-tny-folder.c:
417 (modest_tny_folder_is_local_folder),
418 (modest_tny_folder_get_local_folder_type),
419 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
421 * src/widgets/modest-main-window.h:
422 * src/maemo/modest-main-window.c: (create_details_widget),
423 (modest_main_window_set_contents_style): Show details for any folder store,
426 (modest_tny_folder_get_rules):
427 Remove the const. C does not support constness enough for this.
429 * src/modest-ui-actions.c:
430 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
431 make all outboxes appear as one, in the usual local-folders tree node.
433 (set_active_account_from_tny_account),
434 (modest_ui_actions_on_folder_selection_changed):
435 * src/widgets/modest-folder-view.c: (text_cell_data),
436 (icon_cell_data), (filter_row),
437 (add_account_folders_to_merged_folder),
438 (add_account_folders_to_simple_folder_store), (),
439 (get_cmp_rows_type_pos), (cmp_rows),
440 (modest_folder_view_set_account_id_of_visible_server_account):
441 Adjust to the new outbox system, using generic folder stores and folders
444 2007-05-23 Christian Kellner <ckellner@openismus.com>
446 * src/modest-mail-operation.c:
447 (modest_mail_operation_update_account):
448 Use info->max_size instead of unintialized local var [small
449 build fix]. (Added TODO to review that change since I don't
452 2007-05-23 Marcus Bauer <marcusb@openismus.com>
454 * libmodest-dbus-client/libmodest-dbus-client.c:
455 (libmodest_dbus_client_compose_mail): function added
456 * src/dbus_api/modest-dbus-api.h:
457 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
458 (on_compose_mail): Implementation of the SendAsMail functionality
460 2007-05-22 Murray Cumming <murrayc@murrayc.com>
462 * src/modest-account-mgr.c:
463 (modest_account_mgr_add_server_account): Set the secure-connection
464 conf key for transport accounts as well as store accounts. I don't know
465 why the if was there. For instance, this makes sure that we use SSL
466 for the gmail preset from the easysetup wizard.
468 2007-05-22 Murray Cumming <murrayc@murrayc.com>
470 * src/gnome/modest-main-window.c:
471 (on_account_store_connecting_finished), (connect_signals):
472 * src/maemo/modest-main-window.c:
473 (on_account_store_connecting_finished), (connect_signals),
474 (modest_main_window_new):
475 Handle TnyAccountStore::connecting-finished instead of
476 TnyDevice::connection-changed, because we cannot actually perform
477 operations on accounts until TnyAccountStore has itself responded to
478 the TnyDevice::connection-changed signal. This prevents a GError from
480 Do not try to update at startup, because we (at least on scratchbox)
481 already do an update at startup when the device goes online.
482 This prevents a GError from tinymail.
483 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
484 Added TODO about stopping simultaneous operations.
486 2007-05-21 Murray Cumming <murrayc@murrayc.com>
488 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
489 * src/modest-mail-operation-queue.c:
490 (modest_mail_operation_queue_remove):
491 * src/modest-tny-account-store.c: When GErrors happen, give more clues
492 about where they happened.
494 2007-05-21 Murray Cumming <murrayc@murrayc.com>
496 * src/modest-ui-actions.c:
497 (modest_ui_actions_on_password_requested): Make sure that the remember
498 output parameter is always TRUE.
500 2007-05-21 Murray Cumming <murrayc@murrayc.com>
502 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
503 Show a OK/Cancel dialog if the error is a question, though we still do not
504 know anything more about what we are asking the user.
505 * src/widgets/modest-folder-view.c: (on_drag_data_received):
506 Fix an uninitialized variable (helper). This is a logic error, however.
508 2007-05-21 Christian Kellner <ckellner@openismus.com>
510 * src/modest-search.h:
511 Correct bit shifting in the ModestSearchFlags enum.
513 2007-05-21 Murray Cumming <murrayc@murrayc.com>
515 * src/modest-tny-account.c:
516 (modest_tny_account_new_from_server_account): Do not use the lsub and
517 check-all hard-coded IMAP options when using POP.
519 2007-05-21 Murray Cumming <murrayc@murrayc.com>
521 * src/modest-tny-account.c:
522 (modest_tny_account_new_from_server_account):
523 Use NULL for the secure-auth method for POP when Password auth has been
524 specified by the user, as we already do for IMAP. "auth=Login" causes
525 an error from camel or the server.
527 2007-05-17 Murray Cumming <murrayc@murrayc.com>
529 * src/maemo/modest-account-settings-dialog.c:
530 (create_page_account_details),
531 (modest_account_settings_dialog_set_account_name):
532 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
533 for the leave-on-server checkbox, rathr than just the checkbox, when
534 the protocol is not POP.
536 2007-05-17 Murray Cumming <murrayc@murrayc.com>
538 * src/widgets/modest-account-view.c:
539 * src/widgets/modest-account-view.h:
540 Added modest_account_view_select_account() which will be useful later
541 to asynchronously re-select the edited account.
543 2007-05-17 Murray Cumming <murrayc@murrayc.com>
545 * src/maemo/modest-account-settings-dialog.c:
546 (modest_account_settings_dialog_set_account_name):
547 Automatically choose the port numbers based on the secure authentication
548 methods, if they have not been chosen before.
549 This fixes projects.maemo.org bug NB#56273 .
551 2007-05-17 Murray Cumming <murrayc@murrayc.com>
553 * src/maemo/modest-main-window-ui.h:
554 * src/modest-ui-actions.c:
555 * src/modest-ui-actions.h:
556 Connect the Tools/SMTP Servers menu item to
557 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
558 SMTP servers dialog, as in the UI specification and saves changes when it
559 is closed. This fixed projects.maemo.org bug NB#56305 .
561 2007-05-17 Murray Cumming <murrayc@murrayc.com>
563 * src/maemo/modest-connection-specific-smtp-window.c:
564 (modest_connection_specific_smtp_window_init):
565 Use gtk_window_set_default_size() to make this window big enough, so
566 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
568 2007-05-17 Murray Cumming <murrayc@murrayc.com>
570 * src/maemo/modest-connection-specific-smtp-edit-window.h:
571 * src/maemo/modest-connection-specific-smtp-edit-window.c:
572 (modest_connection_specific_smtp_edit_window_init),
573 Do not try to connect to a combobox signal before the combobox exists.
574 This fixes the cras in projects.maemo.org bug NB#56288 .
575 (modest_connection_specific_smtp_edit_window_get_settings):
576 Remove the server_account_name parameter which was being checked for NULL
577 though it was not used.
579 * src/maemo/modest-connection-specific-smtp-window.c:
580 (modest_connection_specific_smtp_window_fill_with_connections),
581 (on_button_edit), (modest_connection_specific_smtp_window_init):
582 Correct the number of treemodel columns to prevent a warning.
583 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
584 libconic does not work.
586 2007-05-16 Murray Cumming <murrayc@murrayc.com>
588 * src/modest-tny-account.c:
589 (modest_tny_account_new_from_server_account):
590 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
591 SMTP when "None" was chosen by the user. However, with my SMTP server that
592 does not support ANONYMOUS, the emails do not leave the Outbox and I see
595 2007-05-16 Murray Cumming <murrayc@murrayc.com>
597 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
598 to explain the memory management issue with the ID in the ModestPair.
600 * src/gnome/modest-account-assistant.c: (add_receiving_page),
601 (add_sending_page), (modest_account_assistant_finalize):
602 * src/gnome/modest-gnome-global-settings-dialog.c:
603 (create_updating_page), (create_composing_page):
604 * src/gnome/modest-msg-edit-window.c: (get_transports),
605 (init_window), (modest_msg_edit_window_finalize),
606 (modest_msg_edit_window_get_msg_data):
607 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
608 * src/gnome/modest-transport-widget.c:
609 (modest_transport_widget_finalize), (smtp_configuration):
610 * src/maemo/modest-maemo-global-settings-dialog.c:
611 (create_updating_page), (create_composing_page):
612 * src/maemo/modest-msg-edit-window.c: (get_transports),
613 (init_window), (modest_msg_edit_window_finalize),
614 (modest_msg_edit_window_get_msg_data),
615 (modest_msg_edit_window_free_msg_data):
616 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
617 (modest_store_widget_finalize):
618 * src/maemo/modest-transport-widget.c:
619 (modest_transport_widget_finalize), (smtp_configuration):
620 * src/modest-main.c: (send_mail):
621 * src/widgets/modest-combo-box.h:
622 * src/widgets/modest-global-settings-dialog-priv.h:
623 * src/widgets/modest-global-settings-dialog.c:
624 (modest_global_settings_dialog_finalize):
625 * src/widgets/modest-msg-edit-window.h:
626 Whenever using modest_combo_box_new(), keep the ModestPairList alive
627 as long as the combo box, to prevent use of freed memory for the ID.
629 2007-05-15 Murray Cumming <murrayc@murrayc.com>
631 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
632 get_accounts(), to make this clearer. Do not check for the enabled gconf
633 key, because we do not use this for server accounts (at least, not yet).
634 This allows us to send email again.
636 2007-05-15 Murray Cumming <murrayc@murrayc.com>
638 * src/maemo/modest-platform.c:
639 (on_modest_conf_update_interval_changed), (modest_platform_init):
640 Only respond to this particular key change. All these strcmp()s cannot be
643 2007-05-15 Murray Cumming <murrayc@murrayc.com>
645 * src/maemo/modest-maemo-global-settings-dialog.c:
646 (current_connection): Prevent a crash in scratchbox when
647 ny_maemo_conic_device_get_current_iap_id() returns NULL.
648 * src/maemo/modest-platform.c:
649 (on_modest_conf_update_interval_changed), (modest_platform_init):
650 Get the update interval from gconf and reset it when the gconf key changes.
652 2007-05-15 Murray Cumming <murrayc@murrayc.com>
654 * src/modest-protocol-info.c:
655 * src/modest-protocol-info.h: Adde enum-specific get functions,
656 instead of using a ModestProtocolType enum parameter.
658 * src/gnome/modest-account-assistant.c:
659 * src/gnome/modest-store-widget.c:
660 * src/gnome/modest-store-widget.h:
661 * src/gnome/modest-transport-widget.c:
662 * src/gnome/modest-transport-widget.h:
663 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
664 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
665 * src/maemo/easysetup/modest-easysetup-wizard.c:
666 * src/maemo/modest-account-settings-dialog.c:
667 * src/maemo/modest-account-settings-dialog.h:
668 * src/maemo/modest-store-widget.c:
669 * src/maemo/modest-store-widget.h:
670 * src/maemo/modest-transport-widget.c:
671 * src/maemo/modest-transport-widget.h:
672 * src/modest-account-mgr-helpers.c:
673 * src/modest-account-mgr-helpers.h:
674 * src/modest-account-mgr.c:
675 * src/modest-account-mgr.h:
676 * src/modest-tny-account.c:
677 * src/modest-tny-folder.c:
678 * src/widgets/modest-account-view.c:
679 * src/widgets/modest-retrieve-combo-box.c:
680 * src/widgets/modest-retrieve-combo-box.h:
681 * src/widgets/modest-secureauth-combo-box.c:
682 * src/widgets/modest-serversecurity-combo-box.c:
683 * src/widgets/modest-serversecurity-combo-box.h:
684 * tests/check_account-mgr.c:
685 Use the specific functions, and use the re-renamed enum values for GNOME too.
687 2007-05-15 Murray Cumming <murrayc@murrayc.com>
690 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
691 so we can get the second based on the first.
693 * src/maemo/modest-account-settings-dialog.h:
694 * src/maemo/modest-account-settings-dialog.c:
695 Added get_supported_secure_authentication_methods(), though it is mostly
696 commented-out for now until the necessary API is committed to tinymail.
697 (modest_account_settings_dialog_set_account_name),
698 (save_configuration): Request the supported authentication methods from the
699 server, so we can choose a working method.
701 * src/modest-tny-account-store.h:
702 * src/modest-tny-account-store.c:
703 (modest_tny_account_store_get_session): Rename from
704 tny_account_store_get_session().
706 2007-05-14 Murray Cumming <murrayc@murrayc.com>
708 * src/modest-protocol-info.h: Split the ModestProtocol enum
709 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
710 There was no need to have these unrelated values in one enum.
712 * src/: many files: Adapted to changed enum. This makes the code a bit
713 clearer, and the compiler could catch some errors.
715 2007-05-14 Murray Cumming <murrayc@murrayc.com>
717 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
718 Show the detailed internal camel error message when an error happens
719 during the configuration, so that our testers can give us more clues.
720 For instance, in projects.maemo.org bug NB#56910 .
722 2007-05-14 Murray Cumming <murrayc@murrayc.com>
724 * src/modest-tny-account.c:
725 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
726 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
728 2007-05-14 Murray Cumming <murrayc@murrayc.com>
730 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
731 * src/maemo/modest-account-settings-dialog.c:
732 (modest_account_settings_dialog_set_account_name),
733 (save_configuration): For the incoming secure authentication checkbox,
734 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
735 the UI specification. PLAIN does not seem to be supported for most IMAP
736 servers anyway, and I am not sure what it would mean.
737 However, we probably need to discover which of the secure-authentication
738 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
739 * src/modest-account-mgr-helpers.c:
740 (modest_account_mgr_get_server_account_data):
742 * src/modest-tny-account.c:
743 (modest_tny_account_new_from_server_account):
744 Use tny_account_set_mech() to set secure-authentication methods,
745 with some special-casing for IMAP, based on my observations of how
748 * src/modest-account-mgr-helpers.h:
749 * src/modest-account-mgr.c:
750 * src/modest-defs.h: Comment that the URI is only used for local folders.
752 2007-05-11 Murray Cumming <murrayc@murrayc.com>
754 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
755 parameter const, just to be neat.
756 * src/modest-text-utils.c: (modest_text_utils_inline):
757 End g_strconcat() with NULL, as its documentation says. This is almost
758 certainly the cause of my crash at startup on the device. Interestingly,
759 valgrind doesn't tell us about these errors.
761 2007-05-11 Murray Cumming <murrayc@murrayc.com>
763 * scripts/build-packages: Added more precise comments about how to use
764 this script, though I still get this error:
765 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
766 error building tinymail
768 2007-05-11 Murray Cumming <murrayc@murrayc.com>
770 * src/maemo/modest-main-window.c: (on_account_update):
771 Very slight cleanup, hoping to make it simpler to discover what causes
772 a crash here sometimes.
774 * src/modest-tny-account.c:
775 (modest_tny_account_new_from_server_account): Set the port. Added
776 comments about the options and a TODO comment because I need to find out
777 how to specify the secure authentication method.
779 2007-05-11 Marcus Bauer <marcusb@openismus.com>
781 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
782 changed CFlags paths form modest to libmodest
784 2007-05-10 Murray Cumming <murrayc@murrayc.com>
786 * src/modest-account-mgr-helpers.c:
787 (modest_account_mgr_get_server_account_data),
788 (modest_account_mgr_free_server_account_data):
789 * src/modest-account-mgr-helpers.h:
790 * src/modest-account-mgr.c:
791 (modest_account_mgr_add_server_account):
793 * src/modest-tny-account.c:
794 (modest_tny_account_new_from_server_account):
795 Determine the options for tny_camel_account_add_option() here,
796 based on the settings, rather than storing them directly in gconf.
798 2007-05-10 Murray Cumming <murrayc@murrayc.com>
800 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
801 Show a more friendly error dialog now that we expect (from the tinymail
802 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
804 2007-05-10 Murray Cumming <murrayc@murrayc.com>
806 * src/maemo/modest-main-window.c: (on_account_update): Check that
807 account_name is not NULL, to prevent a crash at startup that I am
808 seeing on the N800. I do wonder why it is NULL.
810 * src/maemo/easysetup/modest-easysetup-wizard.c:
811 (create_page_user_details):
812 * src/maemo/modest-account-settings-dialog.c:
813 (create_page_user_details), (create_page_outgoing):
814 * src/maemo/modest-connection-specific-smtp-edit-window.c:
815 (modest_connection_specific_smtp_edit_window_init):
816 * src/modest-ui-actions.c:
817 (modest_ui_actions_on_password_requested):
818 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
819 might do something useful with the on-screen keyboard.
821 2007-05-10 Murray Cumming <murrayc@murrayc.com>
823 * src/maemo/modest-main-window.c: (on_account_update):
824 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
825 NULL, to avoid lots of warnings. However, it probably should not be NULL.
827 2007-05-09 Murray Cumming <murrayc@murrayc.com>
829 * src/modest-tny-account-store.c: (on_account_changed):
830 Correct the signature of this signal handler.
832 2007-05-09 Murray Cumming <murrayc@murrayc.com>
834 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
835 Show a HildonNote instead of a GtkDialog for Maemo.
837 2007-05-09 Murray Cumming <murrayc@murrayc.com>
839 * src/widgets/modest-account-view.h:
840 * src/widgets/modest-account-view.c: (on_account_changed),
841 (on_account_removed). Added a boolean flag, set/unset by
842 modest_account_view_block_conf_updates(),
843 modest_account_view_unblock_conf_updates() to prevent unnecessary
844 updates, but this is not very useful because the gconf notifications are
845 so delays (maybe only on Maemo Bora).
846 So auto-updating is turned off, and these functions do an explicit
847 update when necessary.
848 However, something else is still doing too much work when adding/removing
849 accounts, probably in another part of the application.
851 * src/maemo/modest-account-view-window.c:
852 (on_delete_button_clicked), (on_edit_button_clicked),
853 (on_new_button_clicked): Use the new functions.
855 2007-05-09 Murray Cumming <murrayc@murrayc.com>
857 * src/modest-account-mgr-helpers.c:
858 (modest_account_mgr_set_first_account_as_default):
859 Sort the list of names alphabetically-by-title, so we choose the first one
861 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
862 alphabetically by the title.
864 This fixes projects.maemo.org bug NB#56418 .
866 * src/modest-account-mgr-priv.c:
867 (_modest_account_mgr_account_from_key):
868 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
869 avoid a valgrind error, and possible random behaviour.
871 2007-05-09 Murray Cumming <murrayc@murrayc.com>
873 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
874 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
875 tinymail documentation to say that this can be expected.
876 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
877 pretty, and should not happen, but I would prefer to know when it does.
879 2007-05-09 Murray Cumming <murrayc@murrayc.com>
881 * configure.ac: When using the older hildon version, probably on Bora,
882 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
884 * src/widgets/modest-attachment-view.c:
885 (modest_attachment_view_set_part_default): Initialize variables, to fix the
888 2007-05-09 Marcus Bauer <marcusb@openismus.com>
890 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
891 Implemented the prototype. Can be tested with
892 tests/dbus_api/test_open_message:
894 2007-05-08 Murray Cumming <murrayc@murrayc.com>
896 * src/modest-tny-account-store.c:
897 (modest_tny_account_store_instance_init), (get_password):
898 * src/modest-ui-actions.c:
899 (modest_ui_actions_on_password_requested):
900 Do not store the password in gconf, because this function is called
901 for non-remembered passwords. Actually use the cached (in the hash map)
902 password instead of releasing it.
903 The password will now not be remembered if it is asked via the protected
904 password dialog, as per the UI spec.
906 2007-05-08 Murray Cumming <murrayc@murrayc.com>
909 * src/modest-account-mgr-helpers.h:
910 * src/modest-account-mgr-helpers.c:
911 Added modest_server_account_get_username_has_succeeded(),
912 modest_server_account_set_username_has_succeeded().
913 (modest_server_account_set_username),
914 Reset the has-succeeded flag if the username changes.
916 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
917 * src/maemo/modest-connection-specific-smtp-window.c:
918 (modest_connection_specific_smtp_window_save_server_accounts):
919 Use modest_server_account_set_username() instead of using
920 modest_conf_set_string() directly, so that the has-succeeded flag is always
923 * src/modest-ui-actions.c:
924 (modest_ui_actions_on_password_requested): Dim the username entry if
925 the username has ever worked, as per the UI spec.
927 2007-05-08 Murray Cumming <murrayc@murrayc.com>
929 * src/modest-tny-account-store.c: (get_password):
930 * src/modest-ui-actions.c:
931 (modest_ui_actions_on_password_requested):
932 Allow the username to be changed too, though there is more work to
933 be done on exactly how this behaves.
935 2007-05-08 Murray Cumming <murrayc@murrayc.com>
937 * src/modest-account-mgr-helpers.h:
938 * src/modest-account-mgr-helpers.c:
939 Added modest_account_mgr_get_display_name(),
940 modest_server_account_get_username(),
941 modest_server_account_set_username(),
942 modest_server_account_set_password(),
943 modest_server_account_get_hostname() functions so we do not need to
944 use the conf API directly.
946 * src/maemo/modest-main-window.c: (connect_signals):
947 Actually connect ot the ModestAccountStore::request-password signal,
948 so that we show the dialog when the password is requested by Tinymail,
949 for isntance if it is empty.
951 * src/modest-marshal.list:
952 * src/modest-tny-account-store.c:
953 (modest_tny_account_store_class_init), (get_password),
954 (modest_tny_account_store_alert):
955 * src/modest-tny-account-store.h:
956 * src/modest-ui-actions.h:
957 * src/modest-ui-actions.c:
958 (modest_ui_actions_on_password_requested):
959 Change the signal parameters, so it is obvious that we are providing
960 the non human-readable server name, and receiving both the username
961 and password, though changing of the username is not yet implemented.
962 Change the dialog UI to match the Maemo UI specifications, with #idfefing
963 for the GNOME version.
965 This should fix the projects.maemo.org bug NB#56209, though it does not
966 work on Bora, because the gconf_client_get() for the password fails
967 immediately after we save it with gconf_client_set().
969 2007-05-08 Murray Cumming <murrayc@murrayc.com>
972 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
973 caused an undefined symbol error:
974 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
976 2007-05-08 Murray Cumming <murrayc@murrayc.com>
978 * src/modest-tny-account-store.c:
979 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
980 using a GError instead of a string message, so we can translate it in
983 2007-05-08 Murray Cumming <murrayc@murrayc.com>
985 * src/maemo/modest-address-book.c:
986 (modest_address_book_check_names):
987 * src/maemo/modest-msg-view-window.c:
988 (modest_msg_view_window_clipboard_owner_change):
989 * src/modest-init.c: (modest_init_init_ui):
990 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
991 (update_folders_cb), (modest_mail_operation_update_account):
992 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
993 (modest_ui_actions_on_msg_attachment_clicked),
994 (modest_ui_actions_on_msg_recpt_activated):
995 * src/widgets/modest-header-view.c: (drag_data_get_cb):
996 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
997 (modest_msg_view_search_next):
998 * src/widgets/modest-recpt-editor.c:
999 (modest_recpt_editor_on_button_release_event),
1000 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1001 g_message(). At this point we should only be seeing interesting errors on
1002 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1004 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1006 (modest_wizard_dialog_force_title_update):
1007 * src/maemo/easysetup/modest-wizard-dialog.h:
1008 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1009 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1010 can update the title when appropriate. Otherwise the title is wrong if the
1011 pages are added after adding the notebook to the dialog.
1012 This must be a problem in HildonWizardDialog too.
1013 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1015 * src/maemo/easysetup/modest-easysetup-wizard.c:
1016 (create_subsequent_customsetup_pages),
1017 (create_subsequent_easysetup_pages):
1018 Call modest_wizard_dialog_force_title_update() so that the title is
1019 correct even with GTK+ < 2.10.
1020 This fixes projects.maemo.org bug NB#56145 .
1022 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1024 * src/maemo/modest-platform.c:
1025 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1026 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1029 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1031 * src/widgets/modest-window.h:
1032 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1033 and modest_window_save_state(), which invokes it.
1035 * src/widgets/modest-window-mgr.h:
1036 * src/widgets/modest-window-mgr.c:
1037 Added modest_window_mgr_save_state_for_all_windows(), which calls
1038 the save_state vfunc on all registered windows, if implemented.
1040 * src/gnome/modest-msg-edit-window.c:
1041 * src/gnome/modest-msg-view-window.c:
1042 * src/maemo/modest-msg-edit-window.c:
1043 * src/maemo/modest-msg-view-window.c:
1044 * src/maemo/modest-main-window.c:
1045 Specify the existing save_settings functions as implementations of
1046 ModestWindow::save_state_func().
1048 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1049 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1050 enabling hibernation, for instance.
1052 We may need to do the same thing for restoring settings.
1055 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1057 * src/widgets/modest-window-mgr.c:
1058 * src/widgets/modest-window-mgr.h:
1059 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1060 modest_window_mgr_get_hibernation_is_prevented().
1062 * src/maemo/modest-main-window.c:
1063 (on_hildon_program_is_topmost_notify): Prevent hibernation
1064 (possible when the application goes to the background in the WM),
1065 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1067 * src/maemo/easysetup/modest-easysetup-wizard.c:
1068 (modest_easysetup_wizard_dialog_init):
1069 * src/maemo/modest-account-settings-dialog.c:
1070 (modest_account_settings_dialog_init):
1071 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1072 (modest_connection_specific_smtp_edit_window_init):
1073 * src/maemo/modest-connection-specific-smtp-window.c:
1074 (modest_connection_specific_smtp_window_init):
1075 * src/maemo/modest-signature-editor-dialog.c:
1076 (modest_signature_editor_dialog_init):
1077 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1078 prevent hibernation while any of these account settings dialogs are open.
1080 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1082 * src/maemo/Makefile.am:
1083 * src/maemo/modest-osso-state-saving.c:
1084 * src/maemo/modest-osso-state-saving.h: Added
1085 modest_osso_load_state() and modest_osso_save_state() though they do
1086 nothing now. They should iterate through all the open windows and load/save
1088 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1089 save state when closing.
1091 * src/maemo/modest-main-window.c:
1092 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1093 Add a notification handler for the HildonProgram::is-topmost property,
1094 so we can allow hibernation when the application goes into the background.
1095 But we still need to detect when the accounts setup windows are open so
1096 we can stop hibernation when they are open.
1097 To do this, I also added the main window the HildonProgram. This might have
1098 other side-effects/benefits, and should maybe be done for other windows.
1100 * src/maemo/modest-osso-autosave-callbacks.h:
1101 * src/maemo/modest-osso-autosave-callbacks.c:
1102 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1103 though it does not do anything yet, and we might never need this to do
1104 anything. For instance, we already save drafts.
1106 * src/maemo/modest-platform.c: (modest_platform_init):
1107 Specify the libosso auto-save callback.
1109 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1111 * src/maemo/modest-platform.c:
1112 (modest_platform_set_update_interval):
1113 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1114 aparently stays valid between application instances, so we can use this
1115 to remove and reset it later. According to a maemo-developers email from
1118 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1120 * configure.ac: Depend on libalarm for Maemo.
1122 * src/dbus_api/modest-dbus-api.h:
1123 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1124 (on_send_receive), (modest_dbus_req_handler):
1125 Handle a SEND_RECEIVE D-Bus method.
1127 * libmodest-dbus-client/libmodest-dbus-client.c:
1128 (libmodest_dbus_client_send_and_receive):
1129 * libmodest-dbus-client/libmodest-dbus-client.h:
1130 Add C convenience functions for calling the new D-Bus method.
1132 * src/modest-platform.h:
1133 * src/gnome/modest-platform.c:
1134 * src/maemo/modest-platform.c:
1135 Added modest_platform_set_update_interval(), which uses the
1136 alarmd API on Maemo.
1137 (modest_platform_init),
1138 Call modest_platform_set_update_interval(), using a hard-coded
1139 interval for now (until the global settings dialog is implemented),
1140 though I am not sure that this makes sense yet.
1142 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1144 * src/dbus_api/modest-dbus-callbacks.c:
1145 (modest_osso_cb_hw_state_handler):
1146 * src/dbus_api/modest-dbus-callbacks.h:
1147 * src/maemo/modest-platform.c: (modest_platform_init):
1148 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1149 in case this has some effect on the ability for Maemo to ping the
1152 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1154 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1155 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1156 warning. It is probably a logic error, but I need to fix the build.
1158 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1160 * src/modest-account-mgr.h:
1161 * src/modest-account-mgr.c:
1162 (modest_account_mgr_account_names): Add a gboolean enabled_only
1163 parameter, so we can get lists of onlt the enabled accounts.
1165 (modest_account_mgr_add_account),,
1166 (modest_account_mgr_account_with_display_name_exists):
1167 * src/maemo/modest-msg-edit-window.c: (get_transports):
1168 * src/modest-account-mgr-helpers.c:
1169 (modest_account_mgr_set_first_account_as_default):
1170 * src/modest-init.c: (init_default_account_maybe):
1171 * src/modest-tny-account-store.c: (get_accounts):
1172 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1173 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1174 * tests/check_account-mgr.c: (START_TEST):
1175 Provide the extra parameter, as appropriate.
1177 * src/widgets/modest-account-view.c: (update_account_view):
1178 Do not show disabled accounts (meaning that there is no way to
1179 enable/disable accounts in the UI (the feature is not in our UI
1180 specification), so we can use this internally only to mark unfinished
1181 or temporary account data.
1183 * src/maemo/easysetup/modest-easysetup-wizard.c:
1184 (create_account): Add boolean enable parameter, so we can specify FALSE
1185 to create the temporary account.
1186 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1187 (on_before_next): When finishing, when there is a temporary account, just
1189 Also, use a timeout to delay the showing of the dialog until gconf is likely
1190 to return correct information, due to a maemo gconf bug that is fixed in
1191 osso 1.1, but not yet in Bora.
1192 However, the dialog stays on screen after it is destroyed.
1194 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1195 for invalid data when cancelling. Use a hildon note instead of a dialog
1196 to complain about invalid data. Do not show the account-saved note if the
1197 account is disabled (a temporary account that will not really be saved for use
1200 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1202 * src/modest-account-mgr-helpers.h:
1203 * src/modest-account-mgr-helpers.c:
1204 Added modest_account_mgr_unset_default_account(),
1205 Added modest_account_mgr_set_first_account_as_default().
1207 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1208 If it was the default account, unset the default account name.
1210 * src/maemo/modest-account-view-window.c:
1211 (on_delete_button_clicked): If it was the default account,
1212 set the first remaining account as the default instead.
1214 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1215 a NULL account or a NULL default account, to prevent a crash. This should
1216 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1219 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1221 * src/widgets/modest-recpt-editor.c:
1222 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1223 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1224 TODO comment for this. This fixes the build.
1226 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1227 be the best place for it. This will in future update all auto-update accounts,
1228 rather than just the current/default account, when that gconf key exists.
1229 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1230 if there are no accounts, before calling do_send_receive().
1231 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1233 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1234 * src/maemo/modest-main-window-ui.h:
1235 * src/maemo/modest-main-window.c: (on_connection_changed),
1236 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1237 directly, becaue the signal handler does more.
1239 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1241 * src/modest-account-mgr-helpers.c:
1242 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1243 for the case that the account does not exist.
1245 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1246 (equivalent to the modest account name) rather than the tinymail account name
1247 (equivalent to the modest account title - human readable) to get the account data.
1248 Check for null account data to prevent the crash, and add a TODO comment saying that
1249 this needs fixing because it is using the server account name instead of the account name.
1251 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1253 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1254 * src/maemo/modest-account-settings-dialog.c: (show_error),
1256 Use hildon_note_new_information() for informative and error messages,
1257 which seems to be expected for Maemo applications (no documentation that I know of
1258 says this). I am surprised that there is no distinction between info and error
1261 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1263 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1264 it is easy to find where this is used.
1266 * src/maemo/easysetup/modest-easysetup-wizard.c:
1267 (create_page_welcome), (create_page_account_details),
1268 (create_page_user_details), (create_page_complete_easysetup),
1269 (create_page_custom_incoming), (create_page_custom_outgoing),
1270 (create_page_complete_custom):
1271 * src/maemo/modest-account-settings-dialog.c:
1272 (create_page_account_details), (create_page_user_details),
1273 (create_page_incoming), (create_page_outgoing):
1274 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1275 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1276 (modest_connection_specific_smtp_edit_window_init):
1277 * src/maemo/modest-connection-specific-smtp-window.c:
1278 (modest_connection_specific_smtp_window_init):
1279 * src/maemo/modest-signature-editor-dialog.c:
1280 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1281 and scrolling policy as per the Email Application Layout Guide, if I have
1284 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1286 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1287 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1288 which were empty, because these vfuncs have been removed from TnyAccountStore.
1289 This fixes the build.
1291 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1293 * src/maemo/modest-main-window.c:
1294 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1295 showing/hiding it. Added TODO because it probably should not be NULL.
1296 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1297 because unnecessary g_warnings() make degugging difficult.
1299 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1301 * src/maemo/modest-msg-edit-window.c:
1302 (modest_msg_edit_window_select_color),
1303 (modest_msg_edit_window_select_background_color): 2 const corrections and
1304 moving 2 #endifs before closing brackets, to fix the build.
1306 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1308 * src/maemo/easysetup/modest-easysetup-wizard.h:
1309 * src/maemo/easysetup/modest-easysetup-wizard.c:
1310 (modest_easysetup_wizard_dialog_finalize),
1311 (on_button_edit_advanced_settings), (create_page_complete_custom),
1312 (on_response), (create_account):
1313 Implement the Advanced Settings edit button, by saving the account information,
1314 for the Advanded Settings dialog to use directly from gconf, and removing it
1315 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1316 Bug #5533 in the projects.maemo.org bugzilla.
1318 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1320 * src/maemo/modest-msg-view-window.c:
1321 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1322 when opening a message window.
1324 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1326 * src/maemo/easysetup/modest-easysetup-wizard.c:
1327 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1330 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1331 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1332 gconf settings. I probably added more checks than necessary, but that is safer.
1334 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1335 variable to fix the build, but this seems to be used when it is still NULL.
1337 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1339 * src/modest-platform.h:
1340 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1341 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1342 * src/modest-main.c: Implement this function so we can avoid using
1343 maemo-specific API from cross-platform code.
1345 * src/modest-tny-account-store.c:
1346 (get_smtp_specific_transport_account_for_open_connection):
1347 * src/modest-ui-actions.c: (check_for_connection),
1348 (modest_ui_actions_on_item_not_found):
1349 Use modest_platform_connect_and_wait() and put #idefs around other
1350 maemo-specific code, because only maemo currently has a way to
1351 identify connection names.
1353 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1355 * src/modest-tny-account-store.h:
1356 * src/modest-tny-account-store.c:
1357 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1358 the connection-specific SMTP server settings in the configuration.
1360 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1362 * src/maemo/modest-main-window.c: (on_connection_changed),
1364 * src/modest-main.c: (main), (start_ui), (send_mail):
1365 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1366 that is what is intended.
1368 * src/modest-ui-actions.c: (action_send), (action_receive),
1369 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1370 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1371 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1372 SMTP server is used when it is specified.
1374 (modest_ui_actions_on_send_receive):
1375 Check that a connection is open before proceeding.
1376 Receive and then send, instead of vice-versa, as per the specification.
1378 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1380 * src/modest-mail-operation.c:
1381 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1382 though I guess it should be something other than NULL.
1384 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1386 * src/maemo/easysetup/modest-easysetup-wizard.c:
1387 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1388 combo twice, to avoid an g_warning and to make it visible again.
1389 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1390 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1391 (already intended) dereference when detaching, because we then recreate the menu.
1392 But I am not sure why the warning was happening, and it is possible that this is a memory
1395 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1397 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1398 and uri_parse_mailto() utility functions.
1399 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1401 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1403 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1405 * src/dbus_api/modest-dbus-api.h:
1406 * src/dbus_api/modest-dbus-callbacks.c:
1407 Use an idle callback to execute the modest code in the application's own thread.
1408 Remove the helloworld example method.
1409 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1410 parsed, and the open-message method is not implemented because this is not yet implemented in
1412 * libmodest-dbus-client/libmodest-dbus-client.c:
1413 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1414 (libmodest_dbus_client_open_message):
1415 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1417 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1418 body without crashing.
1420 * tests/dbus_api/Makefile.am:
1421 * tests/dbus_api/test_mail_to.c:
1422 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1424 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1426 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1427 Added file to fix the build. Sorry.
1429 * src/dbus_api/Makefile.am:
1430 * src/dbus_api/modest-dbus-api.h:
1431 * src/dbus_api/modest-dbus-callbacks.h:
1432 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1433 (modest_dbus_req_handler):
1434 Put constants in a separate header so it can be reused by the
1435 client library, without duplication
1437 * libmodest-dbus-client/Makefile.am:
1438 * libmodest-dbus-client/libmodest-dbus-client.c:
1439 (libmodest_dbus_client_call_helloworld),
1440 (libmodfest_dbus_client_send_mail),
1441 (libmodfest_dbus_client_mailto),
1442 (libmodfest_dbus_client_open_message):
1443 * libmodest-dbus-client/libmodest-dbus-client.h:
1444 (Partly) Implement a send_mail D-Bus method.
1446 * tests/dbus_api/Makefile.am:
1447 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1448 the send_email D-Bus method.
1450 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1454 * libmodest-dbus-client/Makefile.am:
1455 * libmodest-dbus-client/libmodest-dbus-client.c:
1456 * libmodest-dbus-client/libmodest-dbus-client.h:
1457 * tests/dbus_api/Makefile.am:
1458 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1459 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1461 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1463 * src/maemo/easysetup/modest-easysetup-wizard.c:
1464 (create_page_account_details):
1465 * src/maemo/modest-account-settings-dialog.c:
1466 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1467 widgets, because this might not be the default in future versions of the Maemo GTK+.
1468 However, I can not not get capitalization to work even in a simple test case.
1470 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1472 * src/maemo/easysetup/modest-easysetup-wizard.c:
1473 (create_page_custom_incoming), (create_page_custom_outgoing):
1474 * src/maemo/modest-account-settings-dialog.c:
1475 (create_page_account_details), (create_page_incoming),
1476 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1477 instead of using gtk_check_button_with_label(), so they are aligned like the other
1478 widgets, as per the UI spec.
1480 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1482 * src/maemo/easysetup/modest-easysetup-wizard.c:
1483 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1484 * src/widgets/modest-validating-entry.c:
1485 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1486 Modest prefix instead of an EasySetup prefix.
1488 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1490 * src/widgets/modest-validating-entry.h:
1491 * src/widgets/modest-validating-entry.c: (on_insert_text),
1492 Added easysetup_validating_entry_set_max_func(), used to set a callback
1493 to call when the max number of characters is reached. GtkEntry has a max-length
1494 already but is silent about it.
1496 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1497 (create_page_account_details), (create_page_user_details),
1499 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1500 (create_page_account_details), (create_page_user_details),
1501 (create_page_outgoing):
1502 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1503 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1504 the UI spec, when the user tries to enter more than the max number of characters.
1506 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1508 * src/maemo/easysetup/modest-easysetup-wizard.c:
1509 (create_page_user_details), (create_page_custom_incoming),
1510 (create_page_custom_outgoing):
1511 * src/maemo/modest-account-settings-dialog.c:
1512 (create_page_user_details), (create_page_incoming),
1513 (create_page_outgoing):
1514 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1515 (modest_connection_specific_smtp_edit_window_init):
1516 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1517 not appropriate. Bad Maemo-specific defaults!.
1519 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1521 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1522 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1523 (modest_signature_editor_dialog_set_settings):
1524 Disable the label and textview when the checkbox is disabled, and use the
1525 specified (UI spec) default signature text.
1527 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1529 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1530 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1532 * src/modest-defs.h:
1533 * src/modest-account-mgr-helpers.h:
1534 * src/modest-account-mgr-helpers.c:
1535 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1537 * src/maemo/Makefile.am:
1538 * src/maemo/modest-signature-editor-dialog.c:
1539 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1542 * src/maemo/modest-account-settings-dialog.h:
1543 * src/maemo/modest-account-settings-dialog.c:
1544 (modest_account_settings_dialog_finalize), (on_button_signature),
1545 (save_configuration): Use the new dialog when the Edit button is pressed, and
1546 save the changes if necessary, as per the UI spec.
1548 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1550 * src/maemo/Makefile.am:
1551 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1552 based on maemo-develoers email from Dirk.
1554 * src/maemo/easysetup/modest-easysetup-wizard.c:
1555 (create_page_welcome), (create_page_account_details),
1556 (create_page_user_details), (create_page_complete_easysetup),
1557 (create_page_custom_incoming), (create_page_custom_outgoing),
1558 (create_page_complete_custom),
1559 (modest_easysetup_wizard_dialog_init):
1560 * src/maemo/modest-account-settings-dialog.c:
1561 (create_page_account_details), (create_page_user_details),
1562 (create_page_incoming), (create_page_outgoing),
1563 (modest_account_settings_dialog_init):
1564 * src/maemo/modest-connection-specific-smtp-window.c:
1565 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1567 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1569 * src/maemo/easysetup/modest-easysetup-wizard.c:
1570 (create_page_account_details), (create_page_custom_outgoing),
1571 (create_page_complete_custom):
1572 * src/maemo/modest-account-settings-dialog.c:
1573 (create_page_user_details), (create_page_incoming),
1574 (create_page_outgoing):
1575 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1576 (modest_connection_specific_smtp_edit_window_init):
1577 Use the correct (UI spec) port min/max, and use horizontal separators,
1580 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1582 * src/maemo/easysetup/modest-easysetup-wizard.c:
1583 (set_default_custom_servernames):
1584 * src/maemo/modest-account-settings-dialog.c:
1585 (create_page_incoming), (on_combo_outgoing_security_changed),
1586 (on_combo_incoming_security_changed), (create_page_outgoing),
1587 (modest_account_settings_dialog_set_account_name),
1588 (save_configuration):
1589 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1590 (on_combo_security_changed),
1591 (modest_connection_specific_smtp_edit_window_init),
1592 (modest_connection_specific_smtp_edit_window_set_connection),
1593 (modest_connection_specific_smtp_edit_window_get_settings):
1594 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1597 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1600 * src/maemo/easysetup/modest-easysetup-wizard.c:
1601 (create_page_custom_outgoing), (create_page_complete_custom):
1602 * src/maemo/modest-account-settings-dialog.c:
1603 (create_page_user_details), (create_page_outgoing):
1604 * src/maemo/modest-account-view-window.c: (button_box_new):
1605 Use changed logical IDs as per the most recent UI spec:
1606 mcen_bd_emailsetup_edit -> mcen_bd_edit
1607 mcen_bd_emailsetup_delete -> mcen_bd_delete
1608 mcen_bd_emailsetup_close -> mcen_bd_close
1610 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1614 * src/dbus_api/Makefile.am:
1615 * src/dbus_api/modest-dbus-callbacks.c:
1616 * src/dbus_api/modest-dbus-callbacks.h:
1617 * src/maemo/modest-platform.c: (modest_platform_init):
1618 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1620 * tests/Makefile.am:
1621 * tests/dbus_api/Makefile.am:
1622 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1624 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1626 * src/maemo/modest-account-settings-dialog.c:
1627 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1628 Removed unnecessary includes.
1630 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1632 * src/maemo/easysetup/modest-easysetup-wizard.c:
1633 * src/maemo/modest-account-settings-dialog.c:
1634 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1635 * src/widgets/Makefile.am:
1636 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1637 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1638 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1639 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1640 * src/widgets/modest-secureauth-combo-box.c:
1641 * src/widgets/modest-secureauth-combo-box.h:
1642 * src/widgets/modest-serversecurity-combo-box.c:
1643 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1644 made the GObject names more consistent with the rest of the Modest code.
1646 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1648 * src/maemo/easysetup/Makefile.am:
1649 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1650 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1651 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1652 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1653 * src/maemo/easysetup/modest-easysetup-wizard.c:
1654 * src/maemo/easysetup/modest-validating-entry.c:
1655 * src/maemo/easysetup/modest-validating-entry.h:
1656 * src/maemo/modest-account-settings-dialog.c:
1657 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1658 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1659 widgets/ because they are used outside of easysetup too. After checking in,
1660 svn will allow me to rename them too.
1662 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1664 * src/gnome/modest-msg-edit-window.c:
1665 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1666 linker error, to fix the build on the GNOME platform.
1667 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1668 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1669 ifdefed out to avoid a warning.
1671 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1673 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1674 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1675 some alternative for GTK+ 2.6.
1677 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1679 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1681 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1682 specified for EmailAccountsDialog in UI spec.
1684 * src/maemo/easysetup/modest-easysetup-wizard.c:
1685 * src/maemo/easysetup/modest-easysetup-wizard.h:
1686 * src/maemo/modest-account-settings-dialog.c:
1687 * src/maemo/modest-account-settings-dialog.h:
1688 Reuse a member window widget for the connection-specific SMTP server accounts,
1689 so we can tell it to create/save the accounts only if we actually save changes.
1691 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1692 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1693 (modest_connection_specific_smtp_edit_window_get_settings):
1694 Return a struct instance for temporarily remembering the entered data.
1696 * src/maemo/modest-connection-specific-smtp-window.h:
1697 * src/maemo/modest-connection-specific-smtp-window.c:
1698 (modest_connection_specific_smtp_window_finalize),
1699 (modest_connection_specific_smtp_window_fill_with_connections),
1701 (modest_connection_specific_smtp_window_save_server_accounts),
1702 (update_model_server_names): Do not actually save data until asked,
1703 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1705 (on_selection_changed),
1706 (modest_connection_specific_smtp_window_init): Disable the edit
1707 button when nothing is selected.
1709 * src/modest-account-mgr-helpers.c:
1710 * src/modest-account-mgr-helpers.h:
1711 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1714 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1716 * src/modest-account-mgr-helpers.h:
1717 * src/modest-account-mgr-helpers.c:
1718 (modest_account_mgr_get_unused_account_name),
1719 (modest_account_mgr_get_unused_account_display_name): Added these
1720 utility functions, to avoid code duplication.
1722 * src/maemo/easysetup/modest-easysetup-wizard.c:
1723 (create_page_account_details), (create_account):
1724 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1725 (on_combo_security_changed),
1726 (modest_connection_specific_smtp_edit_window_init),
1727 (modest_connection_specific_smtp_edit_window_save_settings):
1728 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1729 * src/maemo/modest-connection-specific-smtp-window.c:
1730 (modest_connection_specific_smtp_window_finalize),
1731 (modest_connection_specific_smtp_window_fill_with_connections),
1732 (on_button_edit), (modest_connection_specific_smtp_window_init):
1733 * src/maemo/modest-connection-specific-smtp-window.h:
1734 Implementing saving of connection-specific server accounts.
1736 But I need to refactor this so we can save the data for each
1737 possible connection-specific account and only actually create the server accounts
1738 when the easysetup finished, or the OK button is pressed on the account settings
1741 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1743 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1744 (on_combo_security_changed):
1745 (modest_connection_specific_smtp_edit_window_init):
1746 Auto-fill the port number as in the account settings.
1748 (modest_connection_specific_smtp_edit_window_set_connection):
1749 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1750 * src/maemo/modest-connection-specific-smtp-window.c:
1751 (fill_with_connections), (on_button_edit),
1752 (modest_connection_specific_smtp_window_init):
1753 Turn the edit window into a dialog to simplify the code, and
1754 set a WM hint as in a GtkDialog, because only a popup can be on top of
1755 another window in Maemo, and popups usually have no WM decoration.
1757 * src/modest-defs.h:
1758 * src/modest-account-mgr-helpers.c:
1759 (modest_account_mgr_set_connection_specific_smtp),
1760 (modest_account_mgr_remove_connection_specific_smtp),
1761 (modest_account_mgr_get_connection_specific_smtp):
1762 * src/modest-account-mgr-helpers.h: Some functions to write the
1763 connection-specific SMTP server information. Not yet used.
1766 * src/widgets/modest-folder-view.c: (text_cell_data):
1767 Fix a warning about an uninitialized variable.
1768 (on_configuration_key_changed): Put an #ifdef around the use
1769 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1771 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1773 * src/maemo/modest-account-settings-dialog.h:
1774 * src/maemo/modest-account-settings-dialog.c:
1775 Added connect_for_modified() utility function to mark the new modified boolean.
1777 (create_page_account_details), (create_page_user_details),
1778 (create_page_incoming), (create_page_outgoing), (on_response),
1779 (modest_account_settings_dialog_init),
1780 (modest_account_settings_dialog_set_account_name):
1781 Only warn about unsaved changes when there are actually unsaved changes.
1783 * src/modest-account-mgr-helpers.c:
1784 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1785 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1786 to get the data from there in future.
1788 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1790 * src/modest-defs.h:
1792 * src/modest-account-mgr-helpers.h:
1793 * src/modest-account-mgr-helpers.c:
1794 Store the security account setting in a single conf key instead of using
1795 the options list, so that the list is left for just the to-be-removed camel hack,
1796 and because gconf_client_set_list() is failing for some reason.
1798 * src/modest-account-mgr.c:
1799 (modest_account_mgr_add_server_account):
1800 * src/maemo/modest-account-settings-dialog.c:
1801 (modest_account_settings_dialog_set_account_name),
1802 (save_configuration): Use the renamed functions.
1805 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1807 * src/widgets/Makefile.am:
1808 * src/widgets/modest-limit-retrieve-combo-box.c:
1809 * src/widgets/modest-limit-retrieve-combo-box.h:
1810 * src/widgets/modest-retrieve-combo-box.c:
1811 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1812 the account settings dialog.
1814 * src/modest-defs.h:
1815 * src/modest-account-mgr-helpers.h:
1816 * src/modest-account-mgr-helpers.c:
1817 (modest_server_account_get_option_secure_auth),
1818 (modest_server_account_set_option_secure_auth):
1819 * src/modest-account-mgr.c:
1820 (modest_account_mgr_add_server_account):
1821 Use the existing AUTH_MECH conf key for the secure-auth setting,
1822 instead of putting it in the list options, because this was actually used already.
1824 * src/maemo/modest-account-settings-dialog.c:
1825 (create_page_account_details),
1826 (modest_account_settings_dialog_set_account_name),
1827 (save_configuration):
1828 * src/maemo/modest-account-settings-dialog.h:
1829 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1830 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1832 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1834 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1835 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1836 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1838 * src/modest-defs.h:
1839 * src/maemo/modest-account-settings-dialog.c:
1840 (create_page_incoming), (on_combo_outgoing_security_changed),
1841 (on_combo_incoming_security_changed), (create_page_outgoing),
1842 (modest_account_settings_dialog_set_account_name),
1843 (save_configuration): Load/Save the port number, and change it when the
1844 security combo changes, to suitable defaults.
1846 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1848 * src/modest-account-mgr.c:
1849 (modest_account_mgr_add_server_account): Set the security and secure-auth
1850 options, and add a comment saying that the other camel-specific options should be
1853 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1855 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1857 * src/modest-tny-account-store.c: (account_list_free),
1858 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1859 cursor->data after unreffing it. But there is some strange stuff there so it might not be
1862 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1864 * src/modest-protocol-info.c:
1865 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1866 is required by our UI spec. Maybe something in our implementation will use this eventually.
1867 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1868 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1869 instead of the previous 0 placeholder.
1871 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1872 secure-auth settings.
1873 * src/modest-account-mgr-helpers.h:
1874 * src/modest-account-mgr-helpers.c:
1875 (modest_server_account_data_get_option_secure_auth),
1876 (modest_server_account_set_option_secure_auth),
1877 (modest_server_account_data_get_option_security),
1878 (modest_server_account_set_option_security): Added this API for getting and setting the security
1879 and secure-auth settings.
1881 * src/maemo/modest-account-settings-dialog.h:
1882 * src/maemo/modest-account-settings-dialog.c:
1883 (modest_account_settings_dialog_finalize), (check_data),
1884 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1885 about changing titles.
1886 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1887 (save_configuration): Save the security and secure-auth settings.
1889 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1890 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1892 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1894 * src/modest-defs.h:
1895 * src/modest-account-mgr.c:
1896 (modest_account_mgr_add_server_account):
1897 Added and used defines for the options key and value pair strings,
1898 that are used so far, though they do not seem to correspond to anything in our
1899 UI specs or ModestProtocol enum.
1901 * src/modest-account-mgr-helpers.h:
1902 * src/modest-account-mgr-helpers.c:
1903 (compare_option_strings_for_name),
1904 (modest_server_account_data_get_option_value),
1905 (modest_server_account_data_get_option_bool),
1906 (modest_account_mgr_get_server_account_option):
1907 Added helper functions for parsing the options GSList.
1909 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1911 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1912 display name is based on the supplied account name.
1913 * src/modest-account-mgr.c:
1914 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1915 with an inefficient, but good-enough, implementation.
1917 * src/maemo/easysetup/modest-easysetup-wizard.c:
1918 (create_page_account_details), (on_before_next), (create_account):
1919 Check for existing display names rather than (non-user-visible) account names, and just
1920 create and set a unique account name at the end.
1922 * src/maemo/modest-account-settings-dialog.c:
1923 (modest_account_settings_dialog_init),
1924 (modest_account_settings_dialog_set_account_name),
1925 (create_page_incoming): Show the display name, instead of the account name.
1926 (on_response): Do some (not all) extra checks, as in the UI spec.
1927 (save_configuration): Save the display name if it was changed.
1929 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1931 * po/en_GB.po: Added needed logical ID and translation.
1932 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1933 (init_view): Made the is-default column clicking work.
1935 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1938 * src/maemo/easysetup/Makefile.am:
1939 * src/maemo/easysetup/modest-easysetup-wizard.c:
1940 (modest_easysetup_wizard_dialog_init):
1941 * src/maemo/easysetup/provider-data-test.keyfile:
1942 * src/maemo/easysetup/provider-data.keyfile:
1943 Moved the provider data file to the new modest-providers-data package and used it from there.
1945 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1947 * src/modest-local-folder-info.c:
1948 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1949 N_() was already used on the static strings, but this just marks it for translation without
1950 using the translation.
1952 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1954 * src/maemo/modest-account-settings-dialog.c:
1955 (create_page_incoming),
1956 (modest_account_settings_dialog_set_account_name):
1957 Added comments about the need for new API in ModestAccountMgr to handle the authentication
1958 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1959 I will do this if nobody else gets there first.
1961 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1963 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1964 Saved much of the incoming and outgoing data too, though I cannot yet see how to
1965 save the security stuff.
1967 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1969 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1970 Set the email address and user fullname, which I now see must be
1973 * src/maemo/modest-account-settings-dialog.h:
1974 * src/maemo/modest-account-settings-dialog.c:
1976 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1977 leave-on-server and authentication.
1978 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1981 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1984 * src/maemo/modest-account-settings-dialog.c:
1985 * src/maemo/modest-account-settings-dialog.h:
1986 Most (but not all) of the widgets are now present as specified by the UI spec.
1987 No changes are yet saved, and some details are not properly shown yet.
1989 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1991 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1993 * src/maemo/Makefile.am:
1994 * src/maemo/modest-account-settings-dialog.c:
1995 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1996 an existing account. Doesn't do much yet.
1998 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1999 Open the accounts settings dialog when Edit is clicked.
2001 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2003 * src/maemo/easysetup/Makefile.am:
2004 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2006 * src/maemo/easysetup/modest-easysetup-wizard.c:
2007 (modest_easysetup_wizard_dialog_init):
2008 Try to get the source directory from the build system,
2009 instead of hard-coding "./" into the source code, when opening our local
2010 copies of the configuration files.
2011 But this still fails when opening the wizard from the Accounts window,
2012 maybe because the working directory seems to change at runtime.
2013 So the wizard will fail the second time unless you copy the files into their
2014 proper locations - see the stdout warnings for the paths.
2016 (create_page_account_details),(on_before_next):
2017 Check for existing non-server accounts instead of server accounts,
2018 so the default account name is useful again, and to prevent trying to
2021 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2022 Show the wizard when New is clicked.
2024 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2025 (init_view): Show the column headers, and show the columns that are
2026 specified in the UI specs. However, something in Maemo's GTK+ prevents
2027 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2028 change the default account. This is despite unsetting the special properties.
2030 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2032 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2033 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2034 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2035 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2036 to make that clearer.
2037 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2039 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2041 * src/maemo/modest-account-view-window.c:
2042 (modest_account_view_window_init),
2043 (modest_account_view_window_new):
2044 Use the same buttons as specified in the
2045 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2046 the existing widgets, which never had a chance of working.
2047 Put the ModestAccountView treeview in a scrolled window.
2048 Do not repeat the initialization in both _init() and _new().
2050 * src/widgets/modest-account-view.c: (update_account_view):
2051 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2052 this widget and window shows no accounts.
2054 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2056 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2058 * src/maemo/easysetup/modest-easysetup-wizard.c:
2059 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2060 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2061 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2064 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2065 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2066 accounts exist yet, as in the UI spec.
2068 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2070 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2072 * src/maemo/Makefile.am:
2073 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2074 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2075 New window for editing connection-specific smtp details.
2076 Not fully implemented.
2078 * src/maemo/modest-connection-specific-smtp-window.c:
2079 (modest_connection_specific_smtp_window_finalize) :
2080 unref the tree model.
2081 (on_button_edit): Show the edit window.
2083 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2085 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2088 * src/maemo/Makefile.am:
2089 * src/maemo/modest-connection-specific-smtp-window.c:
2090 * src/maemo/modest-connection-specific-smtp-window.h:
2091 New window for showing the list of connections, for connection-specific
2092 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2093 * src/maemo/easysetup/modest-easysetup-wizard.c:
2094 (create_page_custom_outgoing): Show the new window when the button is clicked.
2096 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2098 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2099 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2100 * src/maemo/modest-msg-edit-window.c:
2101 (modest_msg_edit_window_insert_image):
2102 * src/modest-conf.c: (modest_conf_key_escape):
2103 * src/modest-mail-operation.c:
2104 (modest_mail_operation_send_new_mail):
2105 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2106 (modest_ui_actions_on_new_account):
2107 * src/widgets/modest-attachment-view.c: (update_filename_request):
2108 * src/widgets/modest-mail-header-view.c:
2109 Corrected warnings that were breaking the build, by commenting out unused variables,
2110 and a function, and by including a header.
2112 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2114 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2115 so we can #ifdef around platform-specific code when necessary.
2116 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2117 to allow this to build for the GNOME platform too.
2119 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2121 * src/maemo/easysetup/modest-easysetup-wizard.c:
2122 Added util_increment_name() and used it in create_page_account_details()
2123 to make sure that the default account name is always a new name.
2125 (modest_easysetup_wizard_dialog_init),
2126 (set_default_custom_servernames): Some minor memory management fixes.
2128 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2132 * src/modest-runtime.c: (init_i18n): Restored the translation
2133 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2134 are defined in config.h, and the translations are installed.
2136 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2137 is defined for translation.
2139 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2141 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2143 * src/maemo/easysetup/modest-easysetup-wizard.c:
2144 (modest_easysetup_wizard_dialog_init):
2145 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2146 Use realistic paths (though they should use $prefix generically) to the
2147 mcc_mapping and provider-data.keyfile files which might work when they
2148 are installed by the future version of the operator-wizard package,
2149 and then fallback to paths in our source code, with an explanatory
2152 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2156 * src/maemo/Makefile.am:
2157 * src/maemo/easysetup/: Added files from the previously-exernal
2158 osso-modest-easysetup.
2159 * src/maemo/modest-main-window-ui.h:
2160 * src/modest-ui-actions.c:
2161 * src/modest-ui-actions.h:
2162 Added modest_ui_actions_on_new_account() as a signal handler for the
2163 New Account menu item. It shows the easysetup wizard.
2164 * po/en_GB.po: Added additional needed logical IDs and translations.
2166 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2167 Apparently ChangeLog is not used for some vague Nokia legal reasons.