1 2007-05-31 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
4 Initialize help_id to fix the build. Warnings are good.
6 2007-05-31 Murray Cumming <murrayc@murrayc.com>
8 * src/widgets/modest-hbox-cell-renderer.c:
9 (modest_hbox_cell_renderer_append):
10 * src/widgets/modest-vbox-cell-renderer.c:
11 (modest_vbox_cell_renderer_append):
12 Fix the last commit by doing an extra ref.
14 2007-05-31 Murray Cumming <murrayc@murrayc.com>
16 * src/widgets/modest-hbox-cell-renderer.c:
17 (modest_hbox_cell_renderer_append):
18 * src/widgets/modest-vbox-cell-renderer.c:
19 (modest_vbox_cell_renderer_append):
20 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
21 to fix the build with Maemo Bora.
22 However, there seems to be a remaining crash, probably due to reference
25 2007-05-30 Murray Cumming <murrayc@murrayc.com>
27 * src/modest-tny-account.c:
28 (modest_tny_account_new_for_local_folders):
29 Use hildon_file_system_info_async_new() to get a better name for
30 the memory card account, setting it as the account name.
31 The timing seems to work, but this is probably
32 not the best place to do this. See the TODO comment.
33 * src/maemo/modest-main-window.c: (create_details_widget):
34 * src/widgets/modest-folder-view.c: (text_cell_data):
35 Use the tny account name instead of hardcoding a name.
37 2007-05-30 Christian Kellner <ckellner@openismus.com>
39 * src/modest-search.c: (modest_search):
40 Correctly set part_search_func even if we have already parsed
41 the query and thus a valid OgsTextSearcher object.
43 2007-05-30 Christian Kellner <ckellner@openismus.com>
46 Search and check for libogs.
49 Incooparte the ogs build env.
51 * src/modest-mime-part-search-stream.c:
52 * src/modest-mime-part-search-stream.h:
53 Removed since we do the real searching now in modest-search.c.
55 * src/modest-search.c:
56 * src/modest-search.h:
57 Implement support for ogs. We use that if available and requested
58 and fall back to modest_text_utils_utf8_strcmp (). The search logic
59 should now handle the corner case when the search term is spread
60 across multiple reads.
61 Also the logic in modest_search () was corrected to search all
62 requested fields until one is found.
64 2007-05-30 Murray Cumming <murrayc@murrayc.com>
66 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
69 * src/modest-init.c: Made modest_init_local_folders() take a
70 path and be public so we can iniitialize maildir folders on
73 * src/modest-local-folder-info.h:
74 * src/modest-local-folder-info.c:
75 (modest_local_folder_info_get_maildir_path): Add a path parameter.
77 * src/modest-tny-account.c:
78 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
79 still means the standard local-folders path on the local volume.
81 * src/modest-tny-account-store.c:
82 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
83 signal so we can detect mount/unmount of the MMC1 card, and do an update of
84 all accounts when that happens.
85 (get_server_accounts): If the MMC1 card is mounted, create a store account for
86 this too, so it shows up in the treeview.
88 2007-05-28 Murray Cumming <murrayc@murrayc.com>
90 * src/maemo/modest-maemo-global-settings-dialog.c:
92 * src/widgets/modest-global-settings-dialog.c:
93 (current_connection_default):
94 Use the enum values instead of 0, 1 and -1,
95 to make the code clearer.
97 * src/modest-account-mgr-helpers.c:
98 (modest_account_mgr_get_connection_specific_smtp): Make this code
101 * src/modest-runtime.h:
102 * src/modest-runtime.c:
103 Added modest_runtime_remove_all_send_queues().
104 * src/maemo/modest-main-window.c:
105 (on_account_store_connecting_finished): Recreate the send queues,
106 using the appropriate transport accounts for this new connection.
107 Some futher adapting might be needed if the old send queues are not
108 automatically stopped at this point.
110 * src/modest-tny-account-store.c: (get_server_accounts):
111 Create the connection-specific transport accounts, so that they can
112 be found later by their ID.
114 * src/modest-tny-account.h:
115 * src/modest-tny-account.c:
116 Added modest_tny_account_new_from_server_account_name().
117 modest_tny_account_new_from_server_account(): Do not create the
118 send queues here, because they will be
119 recreated anyway when the connection changes for the first time.
121 2007-05-28 Murray Cumming <murrayc@murrayc.com>
123 * src/modest-local-folder-info.h:
124 * src/modest-local-folder-info.c:
125 (modest_per_account_local_outbox_folder_info_get_maildir_path),
126 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
127 tbox_folder): Take a modest account name instead of a server TnyAccount,
128 so we can have per-modest-account rather than per-transport-account
130 We must make sure that we change or recreate the exisitng send queues
131 when the connection changes for connection-specific transport accounts.
133 * src/modest-tny-account-store.c:
134 (create_per_account_local_outbox_folders): Create outboxed per modest
135 account, not per transport account.
137 * src/modest-tny-account.h:
138 * src/modest-tny-account.c:
139 (modest_tny_account_get_special_folder): For outboxes, get the
140 parent modest account name. The account is ignored for other folders.
141 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
142 modest account name rather than a server TnyAccount.
144 2007-05-25 Murray Cumming <murrayc@murrayc.com>
146 * src/modest-tny-account.c:
147 (modest_tny_account_new_from_server_account):
148 Call modest_runtime_get_send_queue() immediately after creating transport
149 accounts, so that they start trying to send email from the outbox as soon
150 as possible at startup. This is probably what we want.
152 * src/modest-mail-operation.c: (update_account_thread):
153 * src/modest-runtime.c: (modest_runtime_get_send_queue):
154 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
155 * src/modest-tny-send-queue.h:
156 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
157 (modest_ui_actions_on_send):
158 Added comments about how sending works, though it needs some more work.
160 2007-05-25 Murray Cumming <murrayc@murrayc.com>
162 * src/modest-tny-account.c:
163 (modest_tny_account_get_special_folder): Add TODO because this fails when
165 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
166 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
167 Do not try to show this window when there is no active account. The UI
168 specs does not tell us what to do in this case.
170 2007-05-24 Murray Cumming <murrayc@murrayc.com>
174 * src/maemo/Makefile.am:
175 * src/widgets/Makefile.am: Some dist fixes.
177 2007-05-24 Murray Cumming <murrayc@murrayc.com>
179 * src/maemo/modest-connection-specific-smtp-window.c:
180 (on_button_edit): Make the code clearer, to prevent a double free.
182 2007-05-24 Murray Cumming <murrayc@murrayc.com>
184 * src/maemo/modest-account-settings-dialog.c:
185 (modest_account_settings_dialog_set_account_name),
186 Check the connection-specific smtp servers checkbox if there are any.
188 * src/maemo/modest-connection-specific-smtp-edit-window.c:
189 (modest_connection_specific_smtp_edit_window_init):
190 Start with a suitable port number.
192 * src/modest-account-mgr-helpers.h:
193 * src/modest-account-mgr-helpers.c: Added
194 modest_account_mgr_get_has_connection_specific_smtp().
196 (modest_account_mgr_set_connection_specific_smtp),
197 (modest_account_mgr_remove_connection_specific_smtp),
198 (modest_account_mgr_get_has_connection_specific_smtp),
199 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
200 connection-specific smtp server accounts in the account, rather than
201 the server account conf dir.
203 This fixes bug projects.maemo.org bug NB#58263 .
205 * src/modest-tny-account-store.c:
206 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
207 if there are no server accounts yet, to prevent an infinite loop when there
208 are no accounts. Document that one must be called before the other.
210 2007-05-24 Murray Cumming <murrayc@murrayc.com>
212 * src/modest-account-mgr-helpers.c:
213 (modest_account_mgr_get_default_account): Make sure that at least
214 one account is always the default, if there are any enabled accounts.
215 This is just a sanity check that shouldn't be necessary.
217 * src/modest-account-mgr-priv.c:
218 (_modest_account_mgr_account_from_key): Unescape the conf key to
219 get the real account name. For instance, this is an issue if a space
220 was in the account name, which can happen because the account name
221 is generated from the display name.
222 (_modest_account_mgr_get_account_keyname): Always escape the
224 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
225 Unescape the conf keys to get the real account names.
227 For instance, previously the is-default radio button in the accounts
228 list was not checked for any accounts at first. This fixes that,
229 and might fix several similar bugs.
231 2007-05-23 Murray Cumming <murrayc@murrayc.com>
233 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
234 Removed some debug printfs.
236 2007-05-23 Murray Cumming <murrayc@murrayc.com>
238 Modest on-disk outbox directories are now here, for instance:
239 $HOME/.modest/outboxes/<account-id-1>/outbox
240 $HOME/.modest/outboxes/<account-id-2>/outbox
242 $HOME/.modest/local-folders/outbox
243 so we can have a separate outbox for each account.
244 But they are shown as one outbox in the GtkTreeView, by using a
245 TnyMergeFolder in a ModestTnySimpleFolderStore.
248 * src/modest-tny-simple-folder-store.c:
249 * src/modest-tny-simple-folder-store.h:
250 Added ModestTnySimpleFolderStore, used to contain folders from
251 other folder stores, such as other accounts.
253 * src/modest-tny-outbox-account.h:
254 * src/modest-tny-outbox-account.c:
255 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
256 used for the per-account local outbox folders.
258 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
259 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
260 only use this (internally) now for the non-outbox local folders.
263 * src/modest-init.c: Added modest_init_one_local_folder(), for
264 setting up the directory structure for each local folder.
266 * src/modest-local-folder-info.c:
267 (modest_per_account_local_outbox_folder_info_get_maildir_path),
268 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
270 * src/modest-local-folder-info.h:
271 * src/modest-tny-account-store.c: (on_account_removed),
272 (on_account_changed), (create_per_account_local_outbox_folders),
273 (get_server_accounts), (modest_tny_account_store_get_accounts),
274 (modest_tny_account_store_get_tny_account_by_account),
275 (modest_tny_folder_store_is_virtual_local_folders):
277 * src/modest-tny-account.h:
278 * src/modest-tny-account.c:
279 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
280 to create an on-disk per-account local outbox folder for each
282 (create_per_account_local_outbox_folders): Create a local outbox folder
283 for each transport account.
284 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
285 for all local folders.
287 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
288 instead of using g_object_get/set() directly. It is clearer.
290 (modest_tny_folder_store_get_message_count),
291 (modest_tny_folder_store_get_local_size
292 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
293 because we now use these with non-acount folder stores.
295 (modest_tny_account_get_special_folder),
296 (modest_tny_account_new_from_server_account),
297 (modest_tny_account_new_from_account):
298 (recurse_folders): Adjust to the new outbox system.
300 * src/modest-tny-folder.h:
301 * src/modest-tny-folder.c:
302 (modest_tny_folder_is_local_folder),
303 (modest_tny_folder_get_local_folder_type),
304 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
306 * src/widgets/modest-main-window.h:
307 * src/maemo/modest-main-window.c: (create_details_widget),
308 (modest_main_window_set_contents_style): Show details for any folder store,
311 (modest_tny_folder_get_rules):
312 Remove the const. C does not support constness enough for this.
314 * src/modest-ui-actions.c:
315 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
316 make all outboxes appear as one, in the usual local-folders tree node.
318 (set_active_account_from_tny_account),
319 (modest_ui_actions_on_folder_selection_changed):
320 * src/widgets/modest-folder-view.c: (text_cell_data),
321 (icon_cell_data), (filter_row),
322 (add_account_folders_to_merged_folder),
323 (add_account_folders_to_simple_folder_store), (),
324 (get_cmp_rows_type_pos), (cmp_rows),
325 (modest_folder_view_set_account_id_of_visible_server_account):
326 Adjust to the new outbox system, using generic folder stores and folders
329 2007-05-23 Christian Kellner <ckellner@openismus.com>
331 * src/modest-mail-operation.c:
332 (modest_mail_operation_update_account):
333 Use info->max_size instead of unintialized local var [small
334 build fix]. (Added TODO to review that change since I don't
337 2007-05-23 Marcus Bauer <marcusb@openismus.com>
339 * libmodest-dbus-client/libmodest-dbus-client.c:
340 (libmodest_dbus_client_compose_mail): function added
341 * src/dbus_api/modest-dbus-api.h:
342 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
343 (on_compose_mail): Implementation of the SendAsMail functionality
345 2007-05-22 Murray Cumming <murrayc@murrayc.com>
347 * src/modest-account-mgr.c:
348 (modest_account_mgr_add_server_account): Set the secure-connection
349 conf key for transport accounts as well as store accounts. I don't know
350 why the if was there. For instance, this makes sure that we use SSL
351 for the gmail preset from the easysetup wizard.
353 2007-05-22 Murray Cumming <murrayc@murrayc.com>
355 * src/gnome/modest-main-window.c:
356 (on_account_store_connecting_finished), (connect_signals):
357 * src/maemo/modest-main-window.c:
358 (on_account_store_connecting_finished), (connect_signals),
359 (modest_main_window_new):
360 Handle TnyAccountStore::connecting-finished instead of
361 TnyDevice::connection-changed, because we cannot actually perform
362 operations on accounts until TnyAccountStore has itself responded to
363 the TnyDevice::connection-changed signal. This prevents a GError from
365 Do not try to update at startup, because we (at least on scratchbox)
366 already do an update at startup when the device goes online.
367 This prevents a GError from tinymail.
368 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
369 Added TODO about stopping simultaneous operations.
371 2007-05-21 Murray Cumming <murrayc@murrayc.com>
373 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
374 * src/modest-mail-operation-queue.c:
375 (modest_mail_operation_queue_remove):
376 * src/modest-tny-account-store.c: When GErrors happen, give more clues
377 about where they happened.
379 2007-05-21 Murray Cumming <murrayc@murrayc.com>
381 * src/modest-ui-actions.c:
382 (modest_ui_actions_on_password_requested): Make sure that the remember
383 output parameter is always TRUE.
385 2007-05-21 Murray Cumming <murrayc@murrayc.com>
387 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
388 Show a OK/Cancel dialog if the error is a question, though we still do not
389 know anything more about what we are asking the user.
390 * src/widgets/modest-folder-view.c: (on_drag_data_received):
391 Fix an uninitialized variable (helper). This is a logic error, however.
393 2007-05-21 Christian Kellner <ckellner@openismus.com>
395 * src/modest-search.h:
396 Correct bit shifting in the ModestSearchFlags enum.
398 2007-05-21 Murray Cumming <murrayc@murrayc.com>
400 * src/modest-tny-account.c:
401 (modest_tny_account_new_from_server_account): Do not use the lsub and
402 check-all hard-coded IMAP options when using POP.
404 2007-05-21 Murray Cumming <murrayc@murrayc.com>
406 * src/modest-tny-account.c:
407 (modest_tny_account_new_from_server_account):
408 Use NULL for the secure-auth method for POP when Password auth has been
409 specified by the user, as we already do for IMAP. "auth=Login" causes
410 an error from camel or the server.
412 2007-05-17 Murray Cumming <murrayc@murrayc.com>
414 * src/maemo/modest-account-settings-dialog.c:
415 (create_page_account_details),
416 (modest_account_settings_dialog_set_account_name):
417 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
418 for the leave-on-server checkbox, rathr than just the checkbox, when
419 the protocol is not POP.
421 2007-05-17 Murray Cumming <murrayc@murrayc.com>
423 * src/widgets/modest-account-view.c:
424 * src/widgets/modest-account-view.h:
425 Added modest_account_view_select_account() which will be useful later
426 to asynchronously re-select the edited account.
428 2007-05-17 Murray Cumming <murrayc@murrayc.com>
430 * src/maemo/modest-account-settings-dialog.c:
431 (modest_account_settings_dialog_set_account_name):
432 Automatically choose the port numbers based on the secure authentication
433 methods, if they have not been chosen before.
434 This fixes projects.maemo.org bug NB#56273 .
436 2007-05-17 Murray Cumming <murrayc@murrayc.com>
438 * src/maemo/modest-main-window-ui.h:
439 * src/modest-ui-actions.c:
440 * src/modest-ui-actions.h:
441 Connect the Tools/SMTP Servers menu item to
442 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
443 SMTP servers dialog, as in the UI specification and saves changes when it
444 is closed. This fixed projects.maemo.org bug NB#56305 .
446 2007-05-17 Murray Cumming <murrayc@murrayc.com>
448 * src/maemo/modest-connection-specific-smtp-window.c:
449 (modest_connection_specific_smtp_window_init):
450 Use gtk_window_set_default_size() to make this window big enough, so
451 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
453 2007-05-17 Murray Cumming <murrayc@murrayc.com>
455 * src/maemo/modest-connection-specific-smtp-edit-window.h:
456 * src/maemo/modest-connection-specific-smtp-edit-window.c:
457 (modest_connection_specific_smtp_edit_window_init),
458 Do not try to connect to a combobox signal before the combobox exists.
459 This fixes the cras in projects.maemo.org bug NB#56288 .
460 (modest_connection_specific_smtp_edit_window_get_settings):
461 Remove the server_account_name parameter which was being checked for NULL
462 though it was not used.
464 * src/maemo/modest-connection-specific-smtp-window.c:
465 (modest_connection_specific_smtp_window_fill_with_connections),
466 (on_button_edit), (modest_connection_specific_smtp_window_init):
467 Correct the number of treemodel columns to prevent a warning.
468 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
469 libconic does not work.
471 2007-05-16 Murray Cumming <murrayc@murrayc.com>
473 * src/modest-tny-account.c:
474 (modest_tny_account_new_from_server_account):
475 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
476 SMTP when "None" was chosen by the user. However, with my SMTP server that
477 does not support ANONYMOUS, the emails do not leave the Outbox and I see
480 2007-05-16 Murray Cumming <murrayc@murrayc.com>
482 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
483 to explain the memory management issue with the ID in the ModestPair.
485 * src/gnome/modest-account-assistant.c: (add_receiving_page),
486 (add_sending_page), (modest_account_assistant_finalize):
487 * src/gnome/modest-gnome-global-settings-dialog.c:
488 (create_updating_page), (create_composing_page):
489 * src/gnome/modest-msg-edit-window.c: (get_transports),
490 (init_window), (modest_msg_edit_window_finalize),
491 (modest_msg_edit_window_get_msg_data):
492 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
493 * src/gnome/modest-transport-widget.c:
494 (modest_transport_widget_finalize), (smtp_configuration):
495 * src/maemo/modest-maemo-global-settings-dialog.c:
496 (create_updating_page), (create_composing_page):
497 * src/maemo/modest-msg-edit-window.c: (get_transports),
498 (init_window), (modest_msg_edit_window_finalize),
499 (modest_msg_edit_window_get_msg_data),
500 (modest_msg_edit_window_free_msg_data):
501 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
502 (modest_store_widget_finalize):
503 * src/maemo/modest-transport-widget.c:
504 (modest_transport_widget_finalize), (smtp_configuration):
505 * src/modest-main.c: (send_mail):
506 * src/widgets/modest-combo-box.h:
507 * src/widgets/modest-global-settings-dialog-priv.h:
508 * src/widgets/modest-global-settings-dialog.c:
509 (modest_global_settings_dialog_finalize):
510 * src/widgets/modest-msg-edit-window.h:
511 Whenever using modest_combo_box_new(), keep the ModestPairList alive
512 as long as the combo box, to prevent use of freed memory for the ID.
514 2007-05-15 Murray Cumming <murrayc@murrayc.com>
516 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
517 get_accounts(), to make this clearer. Do not check for the enabled gconf
518 key, because we do not use this for server accounts (at least, not yet).
519 This allows us to send email again.
521 2007-05-15 Murray Cumming <murrayc@murrayc.com>
523 * src/maemo/modest-platform.c:
524 (on_modest_conf_update_interval_changed), (modest_platform_init):
525 Only respond to this particular key change. All these strcmp()s cannot be
528 2007-05-15 Murray Cumming <murrayc@murrayc.com>
530 * src/maemo/modest-maemo-global-settings-dialog.c:
531 (current_connection): Prevent a crash in scratchbox when
532 ny_maemo_conic_device_get_current_iap_id() returns NULL.
533 * src/maemo/modest-platform.c:
534 (on_modest_conf_update_interval_changed), (modest_platform_init):
535 Get the update interval from gconf and reset it when the gconf key changes.
537 2007-05-15 Murray Cumming <murrayc@murrayc.com>
539 * src/modest-protocol-info.c:
540 * src/modest-protocol-info.h: Adde enum-specific get functions,
541 instead of using a ModestProtocolType enum parameter.
543 * src/gnome/modest-account-assistant.c:
544 * src/gnome/modest-store-widget.c:
545 * src/gnome/modest-store-widget.h:
546 * src/gnome/modest-transport-widget.c:
547 * src/gnome/modest-transport-widget.h:
548 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
549 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
550 * src/maemo/easysetup/modest-easysetup-wizard.c:
551 * src/maemo/modest-account-settings-dialog.c:
552 * src/maemo/modest-account-settings-dialog.h:
553 * src/maemo/modest-store-widget.c:
554 * src/maemo/modest-store-widget.h:
555 * src/maemo/modest-transport-widget.c:
556 * src/maemo/modest-transport-widget.h:
557 * src/modest-account-mgr-helpers.c:
558 * src/modest-account-mgr-helpers.h:
559 * src/modest-account-mgr.c:
560 * src/modest-account-mgr.h:
561 * src/modest-tny-account.c:
562 * src/modest-tny-folder.c:
563 * src/widgets/modest-account-view.c:
564 * src/widgets/modest-retrieve-combo-box.c:
565 * src/widgets/modest-retrieve-combo-box.h:
566 * src/widgets/modest-secureauth-combo-box.c:
567 * src/widgets/modest-serversecurity-combo-box.c:
568 * src/widgets/modest-serversecurity-combo-box.h:
569 * tests/check_account-mgr.c:
570 Use the specific functions, and use the re-renamed enum values for GNOME too.
572 2007-05-15 Murray Cumming <murrayc@murrayc.com>
575 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
576 so we can get the second based on the first.
578 * src/maemo/modest-account-settings-dialog.h:
579 * src/maemo/modest-account-settings-dialog.c:
580 Added get_supported_secure_authentication_methods(), though it is mostly
581 commented-out for now until the necessary API is committed to tinymail.
582 (modest_account_settings_dialog_set_account_name),
583 (save_configuration): Request the supported authentication methods from the
584 server, so we can choose a working method.
586 * src/modest-tny-account-store.h:
587 * src/modest-tny-account-store.c:
588 (modest_tny_account_store_get_session): Rename from
589 tny_account_store_get_session().
591 2007-05-14 Murray Cumming <murrayc@murrayc.com>
593 * src/modest-protocol-info.h: Split the ModestProtocol enum
594 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
595 There was no need to have these unrelated values in one enum.
597 * src/: many files: Adapted to changed enum. This makes the code a bit
598 clearer, and the compiler could catch some errors.
600 2007-05-14 Murray Cumming <murrayc@murrayc.com>
602 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
603 Show the detailed internal camel error message when an error happens
604 during the configuration, so that our testers can give us more clues.
605 For instance, in projects.maemo.org bug NB#56910 .
607 2007-05-14 Murray Cumming <murrayc@murrayc.com>
609 * src/modest-tny-account.c:
610 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
611 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
613 2007-05-14 Murray Cumming <murrayc@murrayc.com>
615 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
616 * src/maemo/modest-account-settings-dialog.c:
617 (modest_account_settings_dialog_set_account_name),
618 (save_configuration): For the incoming secure authentication checkbox,
619 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
620 the UI specification. PLAIN does not seem to be supported for most IMAP
621 servers anyway, and I am not sure what it would mean.
622 However, we probably need to discover which of the secure-authentication
623 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
624 * src/modest-account-mgr-helpers.c:
625 (modest_account_mgr_get_server_account_data):
627 * src/modest-tny-account.c:
628 (modest_tny_account_new_from_server_account):
629 Use tny_account_set_mech() to set secure-authentication methods,
630 with some special-casing for IMAP, based on my observations of how
633 * src/modest-account-mgr-helpers.h:
634 * src/modest-account-mgr.c:
635 * src/modest-defs.h: Comment that the URI is only used for local folders.
637 2007-05-11 Murray Cumming <murrayc@murrayc.com>
639 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
640 parameter const, just to be neat.
641 * src/modest-text-utils.c: (modest_text_utils_inline):
642 End g_strconcat() with NULL, as its documentation says. This is almost
643 certainly the cause of my crash at startup on the device. Interestingly,
644 valgrind doesn't tell us about these errors.
646 2007-05-11 Murray Cumming <murrayc@murrayc.com>
648 * scripts/build-packages: Added more precise comments about how to use
649 this script, though I still get this error:
650 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
651 error building tinymail
653 2007-05-11 Murray Cumming <murrayc@murrayc.com>
655 * src/maemo/modest-main-window.c: (on_account_update):
656 Very slight cleanup, hoping to make it simpler to discover what causes
657 a crash here sometimes.
659 * src/modest-tny-account.c:
660 (modest_tny_account_new_from_server_account): Set the port. Added
661 comments about the options and a TODO comment because I need to find out
662 how to specify the secure authentication method.
664 2007-05-11 Marcus Bauer <marcusb@openismus.com>
666 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
667 changed CFlags paths form modest to libmodest
669 2007-05-10 Murray Cumming <murrayc@murrayc.com>
671 * src/modest-account-mgr-helpers.c:
672 (modest_account_mgr_get_server_account_data),
673 (modest_account_mgr_free_server_account_data):
674 * src/modest-account-mgr-helpers.h:
675 * src/modest-account-mgr.c:
676 (modest_account_mgr_add_server_account):
678 * src/modest-tny-account.c:
679 (modest_tny_account_new_from_server_account):
680 Determine the options for tny_camel_account_add_option() here,
681 based on the settings, rather than storing them directly in gconf.
683 2007-05-10 Murray Cumming <murrayc@murrayc.com>
685 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
686 Show a more friendly error dialog now that we expect (from the tinymail
687 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
689 2007-05-10 Murray Cumming <murrayc@murrayc.com>
691 * src/maemo/modest-main-window.c: (on_account_update): Check that
692 account_name is not NULL, to prevent a crash at startup that I am
693 seeing on the N800. I do wonder why it is NULL.
695 * src/maemo/easysetup/modest-easysetup-wizard.c:
696 (create_page_user_details):
697 * src/maemo/modest-account-settings-dialog.c:
698 (create_page_user_details), (create_page_outgoing):
699 * src/maemo/modest-connection-specific-smtp-edit-window.c:
700 (modest_connection_specific_smtp_edit_window_init):
701 * src/modest-ui-actions.c:
702 (modest_ui_actions_on_password_requested):
703 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
704 might do something useful with the on-screen keyboard.
706 2007-05-10 Murray Cumming <murrayc@murrayc.com>
708 * src/maemo/modest-main-window.c: (on_account_update):
709 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
710 NULL, to avoid lots of warnings. However, it probably should not be NULL.
712 2007-05-09 Murray Cumming <murrayc@murrayc.com>
714 * src/modest-tny-account-store.c: (on_account_changed):
715 Correct the signature of this signal handler.
717 2007-05-09 Murray Cumming <murrayc@murrayc.com>
719 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
720 Show a HildonNote instead of a GtkDialog for Maemo.
722 2007-05-09 Murray Cumming <murrayc@murrayc.com>
724 * src/widgets/modest-account-view.h:
725 * src/widgets/modest-account-view.c: (on_account_changed),
726 (on_account_removed). Added a boolean flag, set/unset by
727 modest_account_view_block_conf_updates(),
728 modest_account_view_unblock_conf_updates() to prevent unnecessary
729 updates, but this is not very useful because the gconf notifications are
730 so delays (maybe only on Maemo Bora).
731 So auto-updating is turned off, and these functions do an explicit
732 update when necessary.
733 However, something else is still doing too much work when adding/removing
734 accounts, probably in another part of the application.
736 * src/maemo/modest-account-view-window.c:
737 (on_delete_button_clicked), (on_edit_button_clicked),
738 (on_new_button_clicked): Use the new functions.
740 2007-05-09 Murray Cumming <murrayc@murrayc.com>
742 * src/modest-account-mgr-helpers.c:
743 (modest_account_mgr_set_first_account_as_default):
744 Sort the list of names alphabetically-by-title, so we choose the first one
746 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
747 alphabetically by the title.
749 This fixes projects.maemo.org bug NB#56418 .
751 * src/modest-account-mgr-priv.c:
752 (_modest_account_mgr_account_from_key):
753 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
754 avoid a valgrind error, and possible random behaviour.
756 2007-05-09 Murray Cumming <murrayc@murrayc.com>
758 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
759 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
760 tinymail documentation to say that this can be expected.
761 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
762 pretty, and should not happen, but I would prefer to know when it does.
764 2007-05-09 Murray Cumming <murrayc@murrayc.com>
766 * configure.ac: When using the older hildon version, probably on Bora,
767 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
769 * src/widgets/modest-attachment-view.c:
770 (modest_attachment_view_set_part_default): Initialize variables, to fix the
773 2007-05-09 Marcus Bauer <marcusb@openismus.com>
775 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
776 Implemented the prototype. Can be tested with
777 tests/dbus_api/test_open_message:
779 2007-05-08 Murray Cumming <murrayc@murrayc.com>
781 * src/modest-tny-account-store.c:
782 (modest_tny_account_store_instance_init), (get_password):
783 * src/modest-ui-actions.c:
784 (modest_ui_actions_on_password_requested):
785 Do not store the password in gconf, because this function is called
786 for non-remembered passwords. Actually use the cached (in the hash map)
787 password instead of releasing it.
788 The password will now not be remembered if it is asked via the protected
789 password dialog, as per the UI spec.
791 2007-05-08 Murray Cumming <murrayc@murrayc.com>
794 * src/modest-account-mgr-helpers.h:
795 * src/modest-account-mgr-helpers.c:
796 Added modest_server_account_get_username_has_succeeded(),
797 modest_server_account_set_username_has_succeeded().
798 (modest_server_account_set_username),
799 Reset the has-succeeded flag if the username changes.
801 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
802 * src/maemo/modest-connection-specific-smtp-window.c:
803 (modest_connection_specific_smtp_window_save_server_accounts):
804 Use modest_server_account_set_username() instead of using
805 modest_conf_set_string() directly, so that the has-succeeded flag is always
808 * src/modest-ui-actions.c:
809 (modest_ui_actions_on_password_requested): Dim the username entry if
810 the username has ever worked, as per the UI spec.
812 2007-05-08 Murray Cumming <murrayc@murrayc.com>
814 * src/modest-tny-account-store.c: (get_password):
815 * src/modest-ui-actions.c:
816 (modest_ui_actions_on_password_requested):
817 Allow the username to be changed too, though there is more work to
818 be done on exactly how this behaves.
820 2007-05-08 Murray Cumming <murrayc@murrayc.com>
822 * src/modest-account-mgr-helpers.h:
823 * src/modest-account-mgr-helpers.c:
824 Added modest_account_mgr_get_display_name(),
825 modest_server_account_get_username(),
826 modest_server_account_set_username(),
827 modest_server_account_set_password(),
828 modest_server_account_get_hostname() functions so we do not need to
829 use the conf API directly.
831 * src/maemo/modest-main-window.c: (connect_signals):
832 Actually connect ot the ModestAccountStore::request-password signal,
833 so that we show the dialog when the password is requested by Tinymail,
834 for isntance if it is empty.
836 * src/modest-marshal.list:
837 * src/modest-tny-account-store.c:
838 (modest_tny_account_store_class_init), (get_password),
839 (modest_tny_account_store_alert):
840 * src/modest-tny-account-store.h:
841 * src/modest-ui-actions.h:
842 * src/modest-ui-actions.c:
843 (modest_ui_actions_on_password_requested):
844 Change the signal parameters, so it is obvious that we are providing
845 the non human-readable server name, and receiving both the username
846 and password, though changing of the username is not yet implemented.
847 Change the dialog UI to match the Maemo UI specifications, with #idfefing
848 for the GNOME version.
850 This should fix the projects.maemo.org bug NB#56209, though it does not
851 work on Bora, because the gconf_client_get() for the password fails
852 immediately after we save it with gconf_client_set().
854 2007-05-08 Murray Cumming <murrayc@murrayc.com>
857 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
858 caused an undefined symbol error:
859 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
861 2007-05-08 Murray Cumming <murrayc@murrayc.com>
863 * src/modest-tny-account-store.c:
864 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
865 using a GError instead of a string message, so we can translate it in
868 2007-05-08 Murray Cumming <murrayc@murrayc.com>
870 * src/maemo/modest-address-book.c:
871 (modest_address_book_check_names):
872 * src/maemo/modest-msg-view-window.c:
873 (modest_msg_view_window_clipboard_owner_change):
874 * src/modest-init.c: (modest_init_init_ui):
875 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
876 (update_folders_cb), (modest_mail_operation_update_account):
877 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
878 (modest_ui_actions_on_msg_attachment_clicked),
879 (modest_ui_actions_on_msg_recpt_activated):
880 * src/widgets/modest-header-view.c: (drag_data_get_cb):
881 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
882 (modest_msg_view_search_next):
883 * src/widgets/modest-recpt-editor.c:
884 (modest_recpt_editor_on_button_release_event),
885 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
886 g_message(). At this point we should only be seeing interesting errors on
887 stdout. Debugging messages could be #ifdefed-out if they are still useful.
889 2007-05-07 Murray Cumming <murrayc@murrayc.com>
891 (modest_wizard_dialog_force_title_update):
892 * src/maemo/easysetup/modest-wizard-dialog.h:
893 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
894 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
895 can update the title when appropriate. Otherwise the title is wrong if the
896 pages are added after adding the notebook to the dialog.
897 This must be a problem in HildonWizardDialog too.
898 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
900 * src/maemo/easysetup/modest-easysetup-wizard.c:
901 (create_subsequent_customsetup_pages),
902 (create_subsequent_easysetup_pages):
903 Call modest_wizard_dialog_force_title_update() so that the title is
904 correct even with GTK+ < 2.10.
905 This fixes projects.maemo.org bug NB#56145 .
907 2007-05-07 Murray Cumming <murrayc@murrayc.com>
909 * src/maemo/modest-platform.c:
910 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
911 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
914 2007-05-07 Murray Cumming <murrayc@murrayc.com>
916 * src/widgets/modest-window.h:
917 * src/widgets/modest-window.c: Added a save_state_func vfunc,
918 and modest_window_save_state(), which invokes it.
920 * src/widgets/modest-window-mgr.h:
921 * src/widgets/modest-window-mgr.c:
922 Added modest_window_mgr_save_state_for_all_windows(), which calls
923 the save_state vfunc on all registered windows, if implemented.
925 * src/gnome/modest-msg-edit-window.c:
926 * src/gnome/modest-msg-view-window.c:
927 * src/maemo/modest-msg-edit-window.c:
928 * src/maemo/modest-msg-view-window.c:
929 * src/maemo/modest-main-window.c:
930 Specify the existing save_settings functions as implementations of
931 ModestWindow::save_state_func().
933 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
934 Call modest_window_mgr_save_state_for_all_windows(). This happens before
935 enabling hibernation, for instance.
937 We may need to do the same thing for restoring settings.
940 2007-05-07 Murray Cumming <murrayc@murrayc.com>
942 * src/widgets/modest-window-mgr.c:
943 * src/widgets/modest-window-mgr.h:
944 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
945 modest_window_mgr_get_hibernation_is_prevented().
947 * src/maemo/modest-main-window.c:
948 (on_hildon_program_is_topmost_notify): Prevent hibernation
949 (possible when the application goes to the background in the WM),
950 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
952 * src/maemo/easysetup/modest-easysetup-wizard.c:
953 (modest_easysetup_wizard_dialog_init):
954 * src/maemo/modest-account-settings-dialog.c:
955 (modest_account_settings_dialog_init):
956 * src/maemo/modest-connection-specific-smtp-edit-window.c:
957 (modest_connection_specific_smtp_edit_window_init):
958 * src/maemo/modest-connection-specific-smtp-window.c:
959 (modest_connection_specific_smtp_window_init):
960 * src/maemo/modest-signature-editor-dialog.c:
961 (modest_signature_editor_dialog_init):
962 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
963 prevent hibernation while any of these account settings dialogs are open.
965 2007-05-04 Murray Cumming <murrayc@murrayc.com>
967 * src/maemo/Makefile.am:
968 * src/maemo/modest-osso-state-saving.c:
969 * src/maemo/modest-osso-state-saving.h: Added
970 modest_osso_load_state() and modest_osso_save_state() though they do
971 nothing now. They should iterate through all the open windows and load/save
973 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
974 save state when closing.
976 * src/maemo/modest-main-window.c:
977 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
978 Add a notification handler for the HildonProgram::is-topmost property,
979 so we can allow hibernation when the application goes into the background.
980 But we still need to detect when the accounts setup windows are open so
981 we can stop hibernation when they are open.
982 To do this, I also added the main window the HildonProgram. This might have
983 other side-effects/benefits, and should maybe be done for other windows.
985 * src/maemo/modest-osso-autosave-callbacks.h:
986 * src/maemo/modest-osso-autosave-callbacks.c:
987 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
988 though it does not do anything yet, and we might never need this to do
989 anything. For instance, we already save drafts.
991 * src/maemo/modest-platform.c: (modest_platform_init):
992 Specify the libosso auto-save callback.
994 2007-05-03 Murray Cumming <murrayc@murrayc.com>
996 * src/maemo/modest-platform.c:
997 (modest_platform_set_update_interval):
998 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
999 aparently stays valid between application instances, so we can use this
1000 to remove and reset it later. According to a maemo-developers email from
1003 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1005 * configure.ac: Depend on libalarm for Maemo.
1007 * src/dbus_api/modest-dbus-api.h:
1008 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1009 (on_send_receive), (modest_dbus_req_handler):
1010 Handle a SEND_RECEIVE D-Bus method.
1012 * libmodest-dbus-client/libmodest-dbus-client.c:
1013 (libmodest_dbus_client_send_and_receive):
1014 * libmodest-dbus-client/libmodest-dbus-client.h:
1015 Add C convenience functions for calling the new D-Bus method.
1017 * src/modest-platform.h:
1018 * src/gnome/modest-platform.c:
1019 * src/maemo/modest-platform.c:
1020 Added modest_platform_set_update_interval(), which uses the
1021 alarmd API on Maemo.
1022 (modest_platform_init),
1023 Call modest_platform_set_update_interval(), using a hard-coded
1024 interval for now (until the global settings dialog is implemented),
1025 though I am not sure that this makes sense yet.
1027 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1029 * src/dbus_api/modest-dbus-callbacks.c:
1030 (modest_osso_cb_hw_state_handler):
1031 * src/dbus_api/modest-dbus-callbacks.h:
1032 * src/maemo/modest-platform.c: (modest_platform_init):
1033 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1034 in case this has some effect on the ability for Maemo to ping the
1037 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1039 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1040 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1041 warning. It is probably a logic error, but I need to fix the build.
1043 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1045 * src/modest-account-mgr.h:
1046 * src/modest-account-mgr.c:
1047 (modest_account_mgr_account_names): Add a gboolean enabled_only
1048 parameter, so we can get lists of onlt the enabled accounts.
1050 (modest_account_mgr_add_account),,
1051 (modest_account_mgr_account_with_display_name_exists):
1052 * src/maemo/modest-msg-edit-window.c: (get_transports):
1053 * src/modest-account-mgr-helpers.c:
1054 (modest_account_mgr_set_first_account_as_default):
1055 * src/modest-init.c: (init_default_account_maybe):
1056 * src/modest-tny-account-store.c: (get_accounts):
1057 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1058 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1059 * tests/check_account-mgr.c: (START_TEST):
1060 Provide the extra parameter, as appropriate.
1062 * src/widgets/modest-account-view.c: (update_account_view):
1063 Do not show disabled accounts (meaning that there is no way to
1064 enable/disable accounts in the UI (the feature is not in our UI
1065 specification), so we can use this internally only to mark unfinished
1066 or temporary account data.
1068 * src/maemo/easysetup/modest-easysetup-wizard.c:
1069 (create_account): Add boolean enable parameter, so we can specify FALSE
1070 to create the temporary account.
1071 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1072 (on_before_next): When finishing, when there is a temporary account, just
1074 Also, use a timeout to delay the showing of the dialog until gconf is likely
1075 to return correct information, due to a maemo gconf bug that is fixed in
1076 osso 1.1, but not yet in Bora.
1077 However, the dialog stays on screen after it is destroyed.
1079 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1080 for invalid data when cancelling. Use a hildon note instead of a dialog
1081 to complain about invalid data. Do not show the account-saved note if the
1082 account is disabled (a temporary account that will not really be saved for use
1085 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1087 * src/modest-account-mgr-helpers.h:
1088 * src/modest-account-mgr-helpers.c:
1089 Added modest_account_mgr_unset_default_account(),
1090 Added modest_account_mgr_set_first_account_as_default().
1092 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1093 If it was the default account, unset the default account name.
1095 * src/maemo/modest-account-view-window.c:
1096 (on_delete_button_clicked): If it was the default account,
1097 set the first remaining account as the default instead.
1099 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1100 a NULL account or a NULL default account, to prevent a crash. This should
1101 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1104 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1106 * src/widgets/modest-recpt-editor.c:
1107 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1108 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1109 TODO comment for this. This fixes the build.
1111 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1112 be the best place for it. This will in future update all auto-update accounts,
1113 rather than just the current/default account, when that gconf key exists.
1114 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1115 if there are no accounts, before calling do_send_receive().
1116 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1118 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1119 * src/maemo/modest-main-window-ui.h:
1120 * src/maemo/modest-main-window.c: (on_connection_changed),
1121 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1122 directly, becaue the signal handler does more.
1124 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1126 * src/modest-account-mgr-helpers.c:
1127 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1128 for the case that the account does not exist.
1130 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1131 (equivalent to the modest account name) rather than the tinymail account name
1132 (equivalent to the modest account title - human readable) to get the account data.
1133 Check for null account data to prevent the crash, and add a TODO comment saying that
1134 this needs fixing because it is using the server account name instead of the account name.
1136 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1138 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1139 * src/maemo/modest-account-settings-dialog.c: (show_error),
1141 Use hildon_note_new_information() for informative and error messages,
1142 which seems to be expected for Maemo applications (no documentation that I know of
1143 says this). I am surprised that there is no distinction between info and error
1146 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1148 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1149 it is easy to find where this is used.
1151 * src/maemo/easysetup/modest-easysetup-wizard.c:
1152 (create_page_welcome), (create_page_account_details),
1153 (create_page_user_details), (create_page_complete_easysetup),
1154 (create_page_custom_incoming), (create_page_custom_outgoing),
1155 (create_page_complete_custom):
1156 * src/maemo/modest-account-settings-dialog.c:
1157 (create_page_account_details), (create_page_user_details),
1158 (create_page_incoming), (create_page_outgoing):
1159 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1160 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1161 (modest_connection_specific_smtp_edit_window_init):
1162 * src/maemo/modest-connection-specific-smtp-window.c:
1163 (modest_connection_specific_smtp_window_init):
1164 * src/maemo/modest-signature-editor-dialog.c:
1165 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1166 and scrolling policy as per the Email Application Layout Guide, if I have
1169 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1171 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1172 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1173 which were empty, because these vfuncs have been removed from TnyAccountStore.
1174 This fixes the build.
1176 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1178 * src/maemo/modest-main-window.c:
1179 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1180 showing/hiding it. Added TODO because it probably should not be NULL.
1181 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1182 because unnecessary g_warnings() make degugging difficult.
1184 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1186 * src/maemo/modest-msg-edit-window.c:
1187 (modest_msg_edit_window_select_color),
1188 (modest_msg_edit_window_select_background_color): 2 const corrections and
1189 moving 2 #endifs before closing brackets, to fix the build.
1191 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1193 * src/maemo/easysetup/modest-easysetup-wizard.h:
1194 * src/maemo/easysetup/modest-easysetup-wizard.c:
1195 (modest_easysetup_wizard_dialog_finalize),
1196 (on_button_edit_advanced_settings), (create_page_complete_custom),
1197 (on_response), (create_account):
1198 Implement the Advanced Settings edit button, by saving the account information,
1199 for the Advanded Settings dialog to use directly from gconf, and removing it
1200 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1201 Bug #5533 in the projects.maemo.org bugzilla.
1203 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1205 * src/maemo/modest-msg-view-window.c:
1206 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1207 when opening a message window.
1209 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1211 * src/maemo/easysetup/modest-easysetup-wizard.c:
1212 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1215 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1216 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1217 gconf settings. I probably added more checks than necessary, but that is safer.
1219 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1220 variable to fix the build, but this seems to be used when it is still NULL.
1222 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1224 * src/modest-platform.h:
1225 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1226 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1227 * src/modest-main.c: Implement this function so we can avoid using
1228 maemo-specific API from cross-platform code.
1230 * src/modest-tny-account-store.c:
1231 (get_smtp_specific_transport_account_for_open_connection):
1232 * src/modest-ui-actions.c: (check_for_connection),
1233 (modest_ui_actions_on_item_not_found):
1234 Use modest_platform_connect_and_wait() and put #idefs around other
1235 maemo-specific code, because only maemo currently has a way to
1236 identify connection names.
1238 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1240 * src/modest-tny-account-store.h:
1241 * src/modest-tny-account-store.c:
1242 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1243 the connection-specific SMTP server settings in the configuration.
1245 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1247 * src/maemo/modest-main-window.c: (on_connection_changed),
1249 * src/modest-main.c: (main), (start_ui), (send_mail):
1250 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1251 that is what is intended.
1253 * src/modest-ui-actions.c: (action_send), (action_receive),
1254 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1255 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1256 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1257 SMTP server is used when it is specified.
1259 (modest_ui_actions_on_send_receive):
1260 Check that a connection is open before proceeding.
1261 Receive and then send, instead of vice-versa, as per the specification.
1263 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1265 * src/modest-mail-operation.c:
1266 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1267 though I guess it should be something other than NULL.
1269 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1271 * src/maemo/easysetup/modest-easysetup-wizard.c:
1272 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1273 combo twice, to avoid an g_warning and to make it visible again.
1274 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1275 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1276 (already intended) dereference when detaching, because we then recreate the menu.
1277 But I am not sure why the warning was happening, and it is possible that this is a memory
1280 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1282 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1283 and uri_parse_mailto() utility functions.
1284 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1286 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1288 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1290 * src/dbus_api/modest-dbus-api.h:
1291 * src/dbus_api/modest-dbus-callbacks.c:
1292 Use an idle callback to execute the modest code in the application's own thread.
1293 Remove the helloworld example method.
1294 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1295 parsed, and the open-message method is not implemented because this is not yet implemented in
1297 * libmodest-dbus-client/libmodest-dbus-client.c:
1298 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1299 (libmodest_dbus_client_open_message):
1300 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1302 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1303 body without crashing.
1305 * tests/dbus_api/Makefile.am:
1306 * tests/dbus_api/test_mail_to.c:
1307 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1309 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1311 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1312 Added file to fix the build. Sorry.
1314 * src/dbus_api/Makefile.am:
1315 * src/dbus_api/modest-dbus-api.h:
1316 * src/dbus_api/modest-dbus-callbacks.h:
1317 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1318 (modest_dbus_req_handler):
1319 Put constants in a separate header so it can be reused by the
1320 client library, without duplication
1322 * libmodest-dbus-client/Makefile.am:
1323 * libmodest-dbus-client/libmodest-dbus-client.c:
1324 (libmodest_dbus_client_call_helloworld),
1325 (libmodfest_dbus_client_send_mail),
1326 (libmodfest_dbus_client_mailto),
1327 (libmodfest_dbus_client_open_message):
1328 * libmodest-dbus-client/libmodest-dbus-client.h:
1329 (Partly) Implement a send_mail D-Bus method.
1331 * tests/dbus_api/Makefile.am:
1332 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1333 the send_email D-Bus method.
1335 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1339 * libmodest-dbus-client/Makefile.am:
1340 * libmodest-dbus-client/libmodest-dbus-client.c:
1341 * libmodest-dbus-client/libmodest-dbus-client.h:
1342 * tests/dbus_api/Makefile.am:
1343 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1344 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1346 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1348 * src/maemo/easysetup/modest-easysetup-wizard.c:
1349 (create_page_account_details):
1350 * src/maemo/modest-account-settings-dialog.c:
1351 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1352 widgets, because this might not be the default in future versions of the Maemo GTK+.
1353 However, I can not not get capitalization to work even in a simple test case.
1355 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1357 * src/maemo/easysetup/modest-easysetup-wizard.c:
1358 (create_page_custom_incoming), (create_page_custom_outgoing):
1359 * src/maemo/modest-account-settings-dialog.c:
1360 (create_page_account_details), (create_page_incoming),
1361 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1362 instead of using gtk_check_button_with_label(), so they are aligned like the other
1363 widgets, as per the UI spec.
1365 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1367 * src/maemo/easysetup/modest-easysetup-wizard.c:
1368 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1369 * src/widgets/modest-validating-entry.c:
1370 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1371 Modest prefix instead of an EasySetup prefix.
1373 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1375 * src/widgets/modest-validating-entry.h:
1376 * src/widgets/modest-validating-entry.c: (on_insert_text),
1377 Added easysetup_validating_entry_set_max_func(), used to set a callback
1378 to call when the max number of characters is reached. GtkEntry has a max-length
1379 already but is silent about it.
1381 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1382 (create_page_account_details), (create_page_user_details),
1384 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1385 (create_page_account_details), (create_page_user_details),
1386 (create_page_outgoing):
1387 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1388 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1389 the UI spec, when the user tries to enter more than the max number of characters.
1391 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1393 * src/maemo/easysetup/modest-easysetup-wizard.c:
1394 (create_page_user_details), (create_page_custom_incoming),
1395 (create_page_custom_outgoing):
1396 * src/maemo/modest-account-settings-dialog.c:
1397 (create_page_user_details), (create_page_incoming),
1398 (create_page_outgoing):
1399 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1400 (modest_connection_specific_smtp_edit_window_init):
1401 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1402 not appropriate. Bad Maemo-specific defaults!.
1404 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1406 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1407 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1408 (modest_signature_editor_dialog_set_settings):
1409 Disable the label and textview when the checkbox is disabled, and use the
1410 specified (UI spec) default signature text.
1412 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1414 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1415 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1417 * src/modest-defs.h:
1418 * src/modest-account-mgr-helpers.h:
1419 * src/modest-account-mgr-helpers.c:
1420 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1422 * src/maemo/Makefile.am:
1423 * src/maemo/modest-signature-editor-dialog.c:
1424 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1427 * src/maemo/modest-account-settings-dialog.h:
1428 * src/maemo/modest-account-settings-dialog.c:
1429 (modest_account_settings_dialog_finalize), (on_button_signature),
1430 (save_configuration): Use the new dialog when the Edit button is pressed, and
1431 save the changes if necessary, as per the UI spec.
1433 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1435 * src/maemo/Makefile.am:
1436 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1437 based on maemo-develoers email from Dirk.
1439 * src/maemo/easysetup/modest-easysetup-wizard.c:
1440 (create_page_welcome), (create_page_account_details),
1441 (create_page_user_details), (create_page_complete_easysetup),
1442 (create_page_custom_incoming), (create_page_custom_outgoing),
1443 (create_page_complete_custom),
1444 (modest_easysetup_wizard_dialog_init):
1445 * src/maemo/modest-account-settings-dialog.c:
1446 (create_page_account_details), (create_page_user_details),
1447 (create_page_incoming), (create_page_outgoing),
1448 (modest_account_settings_dialog_init):
1449 * src/maemo/modest-connection-specific-smtp-window.c:
1450 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1452 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1454 * src/maemo/easysetup/modest-easysetup-wizard.c:
1455 (create_page_account_details), (create_page_custom_outgoing),
1456 (create_page_complete_custom):
1457 * src/maemo/modest-account-settings-dialog.c:
1458 (create_page_user_details), (create_page_incoming),
1459 (create_page_outgoing):
1460 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1461 (modest_connection_specific_smtp_edit_window_init):
1462 Use the correct (UI spec) port min/max, and use horizontal separators,
1465 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1467 * src/maemo/easysetup/modest-easysetup-wizard.c:
1468 (set_default_custom_servernames):
1469 * src/maemo/modest-account-settings-dialog.c:
1470 (create_page_incoming), (on_combo_outgoing_security_changed),
1471 (on_combo_incoming_security_changed), (create_page_outgoing),
1472 (modest_account_settings_dialog_set_account_name),
1473 (save_configuration):
1474 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1475 (on_combo_security_changed),
1476 (modest_connection_specific_smtp_edit_window_init),
1477 (modest_connection_specific_smtp_edit_window_set_connection),
1478 (modest_connection_specific_smtp_edit_window_get_settings):
1479 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1482 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1485 * src/maemo/easysetup/modest-easysetup-wizard.c:
1486 (create_page_custom_outgoing), (create_page_complete_custom):
1487 * src/maemo/modest-account-settings-dialog.c:
1488 (create_page_user_details), (create_page_outgoing):
1489 * src/maemo/modest-account-view-window.c: (button_box_new):
1490 Use changed logical IDs as per the most recent UI spec:
1491 mcen_bd_emailsetup_edit -> mcen_bd_edit
1492 mcen_bd_emailsetup_delete -> mcen_bd_delete
1493 mcen_bd_emailsetup_close -> mcen_bd_close
1495 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1499 * src/dbus_api/Makefile.am:
1500 * src/dbus_api/modest-dbus-callbacks.c:
1501 * src/dbus_api/modest-dbus-callbacks.h:
1502 * src/maemo/modest-platform.c: (modest_platform_init):
1503 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1505 * tests/Makefile.am:
1506 * tests/dbus_api/Makefile.am:
1507 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1509 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1511 * src/maemo/modest-account-settings-dialog.c:
1512 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1513 Removed unnecessary includes.
1515 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1517 * src/maemo/easysetup/modest-easysetup-wizard.c:
1518 * src/maemo/modest-account-settings-dialog.c:
1519 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1520 * src/widgets/Makefile.am:
1521 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1522 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1523 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1524 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1525 * src/widgets/modest-secureauth-combo-box.c:
1526 * src/widgets/modest-secureauth-combo-box.h:
1527 * src/widgets/modest-serversecurity-combo-box.c:
1528 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1529 made the GObject names more consistent with the rest of the Modest code.
1531 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1533 * src/maemo/easysetup/Makefile.am:
1534 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1535 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1536 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1537 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1538 * src/maemo/easysetup/modest-easysetup-wizard.c:
1539 * src/maemo/easysetup/modest-validating-entry.c:
1540 * src/maemo/easysetup/modest-validating-entry.h:
1541 * src/maemo/modest-account-settings-dialog.c:
1542 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1543 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1544 widgets/ because they are used outside of easysetup too. After checking in,
1545 svn will allow me to rename them too.
1547 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1549 * src/gnome/modest-msg-edit-window.c:
1550 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1551 linker error, to fix the build on the GNOME platform.
1552 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1553 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1554 ifdefed out to avoid a warning.
1556 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1558 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1559 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1560 some alternative for GTK+ 2.6.
1562 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1564 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1566 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1567 specified for EmailAccountsDialog in UI spec.
1569 * src/maemo/easysetup/modest-easysetup-wizard.c:
1570 * src/maemo/easysetup/modest-easysetup-wizard.h:
1571 * src/maemo/modest-account-settings-dialog.c:
1572 * src/maemo/modest-account-settings-dialog.h:
1573 Reuse a member window widget for the connection-specific SMTP server accounts,
1574 so we can tell it to create/save the accounts only if we actually save changes.
1576 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1577 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1578 (modest_connection_specific_smtp_edit_window_get_settings):
1579 Return a struct instance for temporarily remembering the entered data.
1581 * src/maemo/modest-connection-specific-smtp-window.h:
1582 * src/maemo/modest-connection-specific-smtp-window.c:
1583 (modest_connection_specific_smtp_window_finalize),
1584 (modest_connection_specific_smtp_window_fill_with_connections),
1586 (modest_connection_specific_smtp_window_save_server_accounts),
1587 (update_model_server_names): Do not actually save data until asked,
1588 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1590 (on_selection_changed),
1591 (modest_connection_specific_smtp_window_init): Disable the edit
1592 button when nothing is selected.
1594 * src/modest-account-mgr-helpers.c:
1595 * src/modest-account-mgr-helpers.h:
1596 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1599 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1601 * src/modest-account-mgr-helpers.h:
1602 * src/modest-account-mgr-helpers.c:
1603 (modest_account_mgr_get_unused_account_name),
1604 (modest_account_mgr_get_unused_account_display_name): Added these
1605 utility functions, to avoid code duplication.
1607 * src/maemo/easysetup/modest-easysetup-wizard.c:
1608 (create_page_account_details), (create_account):
1609 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1610 (on_combo_security_changed),
1611 (modest_connection_specific_smtp_edit_window_init),
1612 (modest_connection_specific_smtp_edit_window_save_settings):
1613 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1614 * src/maemo/modest-connection-specific-smtp-window.c:
1615 (modest_connection_specific_smtp_window_finalize),
1616 (modest_connection_specific_smtp_window_fill_with_connections),
1617 (on_button_edit), (modest_connection_specific_smtp_window_init):
1618 * src/maemo/modest-connection-specific-smtp-window.h:
1619 Implementing saving of connection-specific server accounts.
1621 But I need to refactor this so we can save the data for each
1622 possible connection-specific account and only actually create the server accounts
1623 when the easysetup finished, or the OK button is pressed on the account settings
1626 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1628 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1629 (on_combo_security_changed):
1630 (modest_connection_specific_smtp_edit_window_init):
1631 Auto-fill the port number as in the account settings.
1633 (modest_connection_specific_smtp_edit_window_set_connection):
1634 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1635 * src/maemo/modest-connection-specific-smtp-window.c:
1636 (fill_with_connections), (on_button_edit),
1637 (modest_connection_specific_smtp_window_init):
1638 Turn the edit window into a dialog to simplify the code, and
1639 set a WM hint as in a GtkDialog, because only a popup can be on top of
1640 another window in Maemo, and popups usually have no WM decoration.
1642 * src/modest-defs.h:
1643 * src/modest-account-mgr-helpers.c:
1644 (modest_account_mgr_set_connection_specific_smtp),
1645 (modest_account_mgr_remove_connection_specific_smtp),
1646 (modest_account_mgr_get_connection_specific_smtp):
1647 * src/modest-account-mgr-helpers.h: Some functions to write the
1648 connection-specific SMTP server information. Not yet used.
1651 * src/widgets/modest-folder-view.c: (text_cell_data):
1652 Fix a warning about an uninitialized variable.
1653 (on_configuration_key_changed): Put an #ifdef around the use
1654 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1656 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1658 * src/maemo/modest-account-settings-dialog.h:
1659 * src/maemo/modest-account-settings-dialog.c:
1660 Added connect_for_modified() utility function to mark the new modified boolean.
1662 (create_page_account_details), (create_page_user_details),
1663 (create_page_incoming), (create_page_outgoing), (on_response),
1664 (modest_account_settings_dialog_init),
1665 (modest_account_settings_dialog_set_account_name):
1666 Only warn about unsaved changes when there are actually unsaved changes.
1668 * src/modest-account-mgr-helpers.c:
1669 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1670 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1671 to get the data from there in future.
1673 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1675 * src/modest-defs.h:
1677 * src/modest-account-mgr-helpers.h:
1678 * src/modest-account-mgr-helpers.c:
1679 Store the security account setting in a single conf key instead of using
1680 the options list, so that the list is left for just the to-be-removed camel hack,
1681 and because gconf_client_set_list() is failing for some reason.
1683 * src/modest-account-mgr.c:
1684 (modest_account_mgr_add_server_account):
1685 * src/maemo/modest-account-settings-dialog.c:
1686 (modest_account_settings_dialog_set_account_name),
1687 (save_configuration): Use the renamed functions.
1690 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1692 * src/widgets/Makefile.am:
1693 * src/widgets/modest-limit-retrieve-combo-box.c:
1694 * src/widgets/modest-limit-retrieve-combo-box.h:
1695 * src/widgets/modest-retrieve-combo-box.c:
1696 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1697 the account settings dialog.
1699 * src/modest-defs.h:
1700 * src/modest-account-mgr-helpers.h:
1701 * src/modest-account-mgr-helpers.c:
1702 (modest_server_account_get_option_secure_auth),
1703 (modest_server_account_set_option_secure_auth):
1704 * src/modest-account-mgr.c:
1705 (modest_account_mgr_add_server_account):
1706 Use the existing AUTH_MECH conf key for the secure-auth setting,
1707 instead of putting it in the list options, because this was actually used already.
1709 * src/maemo/modest-account-settings-dialog.c:
1710 (create_page_account_details),
1711 (modest_account_settings_dialog_set_account_name),
1712 (save_configuration):
1713 * src/maemo/modest-account-settings-dialog.h:
1714 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1715 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1717 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1719 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1720 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1721 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1723 * src/modest-defs.h:
1724 * src/maemo/modest-account-settings-dialog.c:
1725 (create_page_incoming), (on_combo_outgoing_security_changed),
1726 (on_combo_incoming_security_changed), (create_page_outgoing),
1727 (modest_account_settings_dialog_set_account_name),
1728 (save_configuration): Load/Save the port number, and change it when the
1729 security combo changes, to suitable defaults.
1731 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1733 * src/modest-account-mgr.c:
1734 (modest_account_mgr_add_server_account): Set the security and secure-auth
1735 options, and add a comment saying that the other camel-specific options should be
1738 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1740 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1742 * src/modest-tny-account-store.c: (account_list_free),
1743 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1744 cursor->data after unreffing it. But there is some strange stuff there so it might not be
1747 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1749 * src/modest-protocol-info.c:
1750 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1751 is required by our UI spec. Maybe something in our implementation will use this eventually.
1752 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1753 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1754 instead of the previous 0 placeholder.
1756 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1757 secure-auth settings.
1758 * src/modest-account-mgr-helpers.h:
1759 * src/modest-account-mgr-helpers.c:
1760 (modest_server_account_data_get_option_secure_auth),
1761 (modest_server_account_set_option_secure_auth),
1762 (modest_server_account_data_get_option_security),
1763 (modest_server_account_set_option_security): Added this API for getting and setting the security
1764 and secure-auth settings.
1766 * src/maemo/modest-account-settings-dialog.h:
1767 * src/maemo/modest-account-settings-dialog.c:
1768 (modest_account_settings_dialog_finalize), (check_data),
1769 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1770 about changing titles.
1771 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1772 (save_configuration): Save the security and secure-auth settings.
1774 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1775 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1777 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1779 * src/modest-defs.h:
1780 * src/modest-account-mgr.c:
1781 (modest_account_mgr_add_server_account):
1782 Added and used defines for the options key and value pair strings,
1783 that are used so far, though they do not seem to correspond to anything in our
1784 UI specs or ModestProtocol enum.
1786 * src/modest-account-mgr-helpers.h:
1787 * src/modest-account-mgr-helpers.c:
1788 (compare_option_strings_for_name),
1789 (modest_server_account_data_get_option_value),
1790 (modest_server_account_data_get_option_bool),
1791 (modest_account_mgr_get_server_account_option):
1792 Added helper functions for parsing the options GSList.
1794 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1796 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1797 display name is based on the supplied account name.
1798 * src/modest-account-mgr.c:
1799 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1800 with an inefficient, but good-enough, implementation.
1802 * src/maemo/easysetup/modest-easysetup-wizard.c:
1803 (create_page_account_details), (on_before_next), (create_account):
1804 Check for existing display names rather than (non-user-visible) account names, and just
1805 create and set a unique account name at the end.
1807 * src/maemo/modest-account-settings-dialog.c:
1808 (modest_account_settings_dialog_init),
1809 (modest_account_settings_dialog_set_account_name),
1810 (create_page_incoming): Show the display name, instead of the account name.
1811 (on_response): Do some (not all) extra checks, as in the UI spec.
1812 (save_configuration): Save the display name if it was changed.
1814 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1816 * po/en_GB.po: Added needed logical ID and translation.
1817 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1818 (init_view): Made the is-default column clicking work.
1820 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1823 * src/maemo/easysetup/Makefile.am:
1824 * src/maemo/easysetup/modest-easysetup-wizard.c:
1825 (modest_easysetup_wizard_dialog_init):
1826 * src/maemo/easysetup/provider-data-test.keyfile:
1827 * src/maemo/easysetup/provider-data.keyfile:
1828 Moved the provider data file to the new modest-providers-data package and used it from there.
1830 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1832 * src/modest-local-folder-info.c:
1833 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1834 N_() was already used on the static strings, but this just marks it for translation without
1835 using the translation.
1837 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1839 * src/maemo/modest-account-settings-dialog.c:
1840 (create_page_incoming),
1841 (modest_account_settings_dialog_set_account_name):
1842 Added comments about the need for new API in ModestAccountMgr to handle the authentication
1843 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1844 I will do this if nobody else gets there first.
1846 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1848 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1849 Saved much of the incoming and outgoing data too, though I cannot yet see how to
1850 save the security stuff.
1852 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1854 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1855 Set the email address and user fullname, which I now see must be
1858 * src/maemo/modest-account-settings-dialog.h:
1859 * src/maemo/modest-account-settings-dialog.c:
1861 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1862 leave-on-server and authentication.
1863 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1866 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1869 * src/maemo/modest-account-settings-dialog.c:
1870 * src/maemo/modest-account-settings-dialog.h:
1871 Most (but not all) of the widgets are now present as specified by the UI spec.
1872 No changes are yet saved, and some details are not properly shown yet.
1874 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1876 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1878 * src/maemo/Makefile.am:
1879 * src/maemo/modest-account-settings-dialog.c:
1880 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1881 an existing account. Doesn't do much yet.
1883 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1884 Open the accounts settings dialog when Edit is clicked.
1886 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1888 * src/maemo/easysetup/Makefile.am:
1889 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1891 * src/maemo/easysetup/modest-easysetup-wizard.c:
1892 (modest_easysetup_wizard_dialog_init):
1893 Try to get the source directory from the build system,
1894 instead of hard-coding "./" into the source code, when opening our local
1895 copies of the configuration files.
1896 But this still fails when opening the wizard from the Accounts window,
1897 maybe because the working directory seems to change at runtime.
1898 So the wizard will fail the second time unless you copy the files into their
1899 proper locations - see the stdout warnings for the paths.
1901 (create_page_account_details),(on_before_next):
1902 Check for existing non-server accounts instead of server accounts,
1903 so the default account name is useful again, and to prevent trying to
1906 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1907 Show the wizard when New is clicked.
1909 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1910 (init_view): Show the column headers, and show the columns that are
1911 specified in the UI specs. However, something in Maemo's GTK+ prevents
1912 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1913 change the default account. This is despite unsetting the special properties.
1915 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1917 * docs/reference/modest-design.sgml: Corrected spelling mistake.
1918 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1919 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1920 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1921 to make that clearer.
1922 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1924 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1926 * src/maemo/modest-account-view-window.c:
1927 (modest_account_view_window_init),
1928 (modest_account_view_window_new):
1929 Use the same buttons as specified in the
1930 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1931 the existing widgets, which never had a chance of working.
1932 Put the ModestAccountView treeview in a scrolled window.
1933 Do not repeat the initialization in both _init() and _new().
1935 * src/widgets/modest-account-view.c: (update_account_view):
1936 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1937 this widget and window shows no accounts.
1939 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1941 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1943 * src/maemo/easysetup/modest-easysetup-wizard.c:
1944 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1945 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1946 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1949 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1950 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1951 accounts exist yet, as in the UI spec.
1953 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
1955 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1957 * src/maemo/Makefile.am:
1958 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1959 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1960 New window for editing connection-specific smtp details.
1961 Not fully implemented.
1963 * src/maemo/modest-connection-specific-smtp-window.c:
1964 (modest_connection_specific_smtp_window_finalize) :
1965 unref the tree model.
1966 (on_button_edit): Show the edit window.
1968 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1970 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
1973 * src/maemo/Makefile.am:
1974 * src/maemo/modest-connection-specific-smtp-window.c:
1975 * src/maemo/modest-connection-specific-smtp-window.h:
1976 New window for showing the list of connections, for connection-specific
1977 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
1978 * src/maemo/easysetup/modest-easysetup-wizard.c:
1979 (create_page_custom_outgoing): Show the new window when the button is clicked.
1981 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1983 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1984 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1985 * src/maemo/modest-msg-edit-window.c:
1986 (modest_msg_edit_window_insert_image):
1987 * src/modest-conf.c: (modest_conf_key_escape):
1988 * src/modest-mail-operation.c:
1989 (modest_mail_operation_send_new_mail):
1990 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1991 (modest_ui_actions_on_new_account):
1992 * src/widgets/modest-attachment-view.c: (update_filename_request):
1993 * src/widgets/modest-mail-header-view.c:
1994 Corrected warnings that were breaking the build, by commenting out unused variables,
1995 and a function, and by including a header.
1997 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1999 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2000 so we can #ifdef around platform-specific code when necessary.
2001 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2002 to allow this to build for the GNOME platform too.
2004 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2006 * src/maemo/easysetup/modest-easysetup-wizard.c:
2007 Added util_increment_name() and used it in create_page_account_details()
2008 to make sure that the default account name is always a new name.
2010 (modest_easysetup_wizard_dialog_init),
2011 (set_default_custom_servernames): Some minor memory management fixes.
2013 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2017 * src/modest-runtime.c: (init_i18n): Restored the translation
2018 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2019 are defined in config.h, and the translations are installed.
2021 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2022 is defined for translation.
2024 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2026 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2028 * src/maemo/easysetup/modest-easysetup-wizard.c:
2029 (modest_easysetup_wizard_dialog_init):
2030 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2031 Use realistic paths (though they should use $prefix generically) to the
2032 mcc_mapping and provider-data.keyfile files which might work when they
2033 are installed by the future version of the operator-wizard package,
2034 and then fallback to paths in our source code, with an explanatory
2037 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2041 * src/maemo/Makefile.am:
2042 * src/maemo/easysetup/: Added files from the previously-exernal
2043 osso-modest-easysetup.
2044 * src/maemo/modest-main-window-ui.h:
2045 * src/modest-ui-actions.c:
2046 * src/modest-ui-actions.h:
2047 Added modest_ui_actions_on_new_account() as a signal handler for the
2048 New Account menu item. It shows the easysetup wizard.
2049 * po/en_GB.po: Added additional needed logical IDs and translations.
2051 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2052 Apparently ChangeLog is not used for some vague Nokia legal reasons.