git.maemo.org Git - modest/blob - ChangeLog2

   1 2007-04-29  Murray Cumming  <murrayc@murrayc.com>
   2
   3         * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
   4         * src/maemo/modest-account-settings-dialog.c: (show_error),
   5         (show_ok):
   6         Use hildon_note_new_information() for informative and error messages,
   7         which seems to be expected for Maemo applications (no documentation that I know of
   8         says this). I am surprised that there is no distinction between info and error
   9         dialogs.
  10
  11 2007-04-29  Murray Cumming  <murrayc@murrayc.com>
  12
  13         * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
  14         it is easy to find where this is used.
  15
  16         * src/maemo/easysetup/modest-easysetup-wizard.c:
  17         (create_page_welcome), (create_page_account_details),
  18         (create_page_user_details), (create_page_complete_easysetup),
  19         (create_page_custom_incoming), (create_page_custom_outgoing),
  20         (create_page_complete_custom):
  21         * src/maemo/modest-account-settings-dialog.c:
  22         (create_page_account_details), (create_page_user_details),
  23         (create_page_incoming), (create_page_outgoing):
  24         * src/maemo/modest-account-view-window.c: (window_vbox_new):
  25         * src/maemo/modest-connection-specific-smtp-edit-window.c:
  26         (modest_connection_specific_smtp_edit_window_init):
  27         * src/maemo/modest-connection-specific-smtp-window.c:
  28         (modest_connection_specific_smtp_window_init):
  29         * src/maemo/modest-signature-editor-dialog.c:
  30         (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
  31         and scrolling policy as per the Email Application Layout Guide, if I have
  32         understood it.
  33
  34 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
  35
  36         * src/modest-tny-account-store.c: (modest_tny_account_store_init):
  37         Remove the add_transport_account_func and add_store_account_func vfunc implementations,
  38         which were empty, because these vfuncs have been removed from TnyAccountStore.
  39         This fixes the build.
  40
  41 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
  42
  43         * src/maemo/modest-main-window.c:
  44         (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
  45         showing/hiding it. Added TODO because it probably should not be NULL.
  46         * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
  47         because unnecessary g_warnings() make degugging difficult.
  48
  49 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
  50
  51         * src/maemo/modest-msg-edit-window.c:
  52         (modest_msg_edit_window_select_color),
  53         (modest_msg_edit_window_select_background_color): 2 const corrections and
  54         moving 2 #endifs before closing brackets, to fix the build.
  55
  56 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
  57
  58         * src/maemo/easysetup/modest-easysetup-wizard.h:
  59         * src/maemo/easysetup/modest-easysetup-wizard.c:
  60         (modest_easysetup_wizard_dialog_finalize),
  61         (on_button_edit_advanced_settings), (create_page_complete_custom),
  62         (on_response), (create_account):
  63         Implement the Advanced Settings edit button, by saving the account information,
  64         for the Advanded Settings dialog to use directly from gconf, and removing it
  65         if Finish is never clicked. There is still some UI strangeness, so this is not finished.
  66         Bug #5533 in the projects.maemo.org bugzilla.
  67
  68 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
  69
  70         * src/maemo/modest-msg-view-window.c:
  71         (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
  72         when opening a message window.
  73
  74 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
  75
  76         * src/maemo/easysetup/modest-easysetup-wizard.c:
  77         (create_page_custom_outgoing): Correct the position of the horizontal separator to
  78         match the UI spec.
  79
  80         * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
  81         before showing/hiding them, to avoid a crash when clicking on folders when there are no
  82         gconf settings. I probably added more checks than necessary, but that is safer.
  83
  84         * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
  85         variable to fix the build, but this seems to be used when it is still NULL.
  86
  87 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
  88
  89         * src/modest-platform.h:
  90         * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
  91         * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
  92         * src/modest-main.c: Implement this function so we can avoid using
  93         maemo-specific API from cross-platform code.
  94         (main):
  95         * src/modest-tny-account-store.c:
  96         (get_smtp_specific_transport_account_for_open_connection):
  97         * src/modest-ui-actions.c: (check_for_connection),
  98         (modest_ui_actions_on_item_not_found):
  99         Use modest_platform_connect_and_wait() and put #idefs around other
 100         maemo-specific code, because only maemo currently has a way to
 101         identify connection names.
 102
 103 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 104
 105         * src/modest-tny-account-store.h:
 106         * src/modest-tny-account-store.c:
 107         Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
 108         the connection-specific SMTP server settings in the configuration.
 109
 110         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
 111         (on_idle_mail_to):
 112         * src/maemo/modest-main-window.c: (on_connection_changed),
 113         (connect_signals):
 114         * src/modest-main.c: (main), (start_ui), (send_mail):
 115         Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
 116         that is what is intended.
 117
 118         * src/modest-ui-actions.c: (action_send), (action_receive),
 119         (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
 120         Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
 121         modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
 122         SMTP server is used when it is specified.
 123
 124         (modest_ui_actions_on_send_receive):
 125         Check that a connection is open before proceeding.
 126         Receive and then send, instead of vice-versa, as per the specification.
 127
 128 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 129
 130         * src/modest-mail-operation.c:
 131         (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
 132         though I guess it should be something other than NULL.
 133
 134 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 135
 136         * src/maemo/easysetup/modest-easysetup-wizard.c:
 137         (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
 138         combo twice, to avoid an g_warning and to make it visible again.
 139         * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
 140         attached before detaching it, to avoid a g_warning, and add comment about the implicit
 141         (already intended) dereference when detaching, because we then recreate the menu.
 142         But I am not sure why the warning was happening, and it is possible that this is a memory
 143         leak.
 144
 145 2007-04-25  Murray Cumming  <murrayc@murrayc.com>
 146
 147         * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
 148         and uri_parse_mailto() utility functions.
 149         (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
 150         the mailto URI.
 151         * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
 152
 153 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 154
 155         * src/dbus_api/modest-dbus-api.h:
 156         * src/dbus_api/modest-dbus-callbacks.c:
 157         Use an idle callback to execute the modest code in the application's own thread.
 158         Remove the helloworld example method.
 159         Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
 160         parsed, and the open-message method is not implemented because this is not yet implemented in
 161         modest itself.
 162         * libmodest-dbus-client/libmodest-dbus-client.c:
 163         (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
 164         (libmodest_dbus_client_open_message):
 165         * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
 166
 167         * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
 168         body without crashing.
 169
 170         * tests/dbus_api/Makefile.am:
 171         * tests/dbus_api/test_mail_to.c:
 172         * tests/dbus_api/test_open_message.c: New tests for the new methods.
 173
 174 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 175
 176         * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
 177         Added file to fix the build. Sorry.
 178
 179         * src/dbus_api/Makefile.am:
 180         * src/dbus_api/modest-dbus-api.h:
 181         * src/dbus_api/modest-dbus-callbacks.h:
 182         * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
 183         (modest_dbus_req_handler):
 184         Put constants in a separate header so it can be reused by the
 185         client library, without duplication
 186
 187         * libmodest-dbus-client/Makefile.am:
 188         * libmodest-dbus-client/libmodest-dbus-client.c:
 189         (libmodest_dbus_client_call_helloworld),
 190         (libmodfest_dbus_client_send_mail),
 191         (libmodfest_dbus_client_mailto),
 192         (libmodfest_dbus_client_open_message):
 193         * libmodest-dbus-client/libmodest-dbus-client.h:
 194         (Partly) Implement a send_mail D-Bus method.
 195
 196         * tests/dbus_api/Makefile.am:
 197         * tests/dbus_api/test_send_mail.c: (main): Added a test for
 198         the send_email D-Bus method.
 199
 200 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 201
 202         * Makefile.am:
 203         * configure.ac:
 204         * libmodest-dbus-client/Makefile.am:
 205         * libmodest-dbus-client/libmodest-dbus-client.c:
 206         * libmodest-dbus-client/libmodest-dbus-client.h:
 207         * tests/dbus_api/Makefile.am:
 208         * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
 209         for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
 210
 211 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 212
 213         * src/maemo/easysetup/modest-easysetup-wizard.c:
 214         (create_page_account_details):
 215         * src/maemo/modest-account-settings-dialog.c:
 216         (create_page_account_details): Explicitly set auto-capitalization mode for the title
 217         widgets, because this might not be the default in future versions of the Maemo GTK+.
 218         However, I can not not get capitalization to work even in a simple test case.
 219
 220 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 221
 222         * src/maemo/easysetup/modest-easysetup-wizard.c:
 223         (create_page_custom_incoming), (create_page_custom_outgoing):
 224         * src/maemo/modest-account-settings-dialog.c:
 225         (create_page_account_details), (create_page_incoming),
 226         (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
 227         instead of using gtk_check_button_with_label(), so they are aligned like the other
 228         widgets, as per the UI spec.
 229
 230 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 231
 232         * src/maemo/easysetup/modest-easysetup-wizard.c:
 233         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 234         * src/widgets/modest-validating-entry.c:
 235         * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
 236         Modest prefix instead of an EasySetup prefix.
 237
 238 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 239
 240         * src/widgets/modest-validating-entry.h:
 241         * src/widgets/modest-validating-entry.c: (on_insert_text),
 242         Added easysetup_validating_entry_set_max_func(), used to set a callback
 243         to call when the max number of characters is reached. GtkEntry has a max-length
 244         already but is silent about it.
 245
 246         * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
 247         (create_page_account_details), (create_page_user_details),
 248         (create_account):
 249         * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
 250         (create_page_account_details), (create_page_user_details),
 251         (create_page_outgoing):
 252         * src/modest-ui-actions.c: (modest_ui_actions_on_details):
 253         Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
 254         the UI spec, when the user tries to enter more than the max number of characters.
 255
 256 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 257
 258         * src/maemo/easysetup/modest-easysetup-wizard.c:
 259         (create_page_user_details), (create_page_custom_incoming),
 260         (create_page_custom_outgoing):
 261         * src/maemo/modest-account-settings-dialog.c:
 262         (create_page_user_details), (create_page_incoming),
 263         (create_page_outgoing):
 264         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 265         (modest_connection_specific_smtp_edit_window_init):
 266         Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
 267         not appropriate. Bad Maemo-specific defaults!.
 268
 269 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 270
 271         * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
 272         (on_toggle_button_changed), (modest_signature_editor_dialog_init),
 273         (modest_signature_editor_dialog_set_settings):
 274         Disable the label and textview when the checkbox is disabled, and use the
 275         specified (UI spec) default signature text.
 276
 277 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 278
 279         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 280         (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
 281
 282         * src/modest-defs.h:
 283         * src/modest-account-mgr-helpers.h:
 284         * src/modest-account-mgr-helpers.c:
 285         Added modest_account_mgr_get/set_signature(), using new gconf keys.
 286
 287         * src/maemo/Makefile.am:
 288         * src/maemo/modest-signature-editor-dialog.c:
 289         * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
 290         as per the UI spec.
 291
 292         * src/maemo/modest-account-settings-dialog.h:
 293         * src/maemo/modest-account-settings-dialog.c:
 294         (modest_account_settings_dialog_finalize), (on_button_signature),
 295         (save_configuration): Use the new dialog when the Edit button is pressed, and
 296         save the changes if necessary, as per the UI spec.
 297
 298 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 299
 300         * src/maemo/Makefile.am:
 301         * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
 302         based on maemo-develoers email from Dirk.
 303
 304         * src/maemo/easysetup/modest-easysetup-wizard.c:
 305         (create_page_welcome), (create_page_account_details),
 306         (create_page_user_details), (create_page_complete_easysetup),
 307         (create_page_custom_incoming), (create_page_custom_outgoing),
 308         (create_page_complete_custom),
 309         (modest_easysetup_wizard_dialog_init):
 310         * src/maemo/modest-account-settings-dialog.c:
 311         (create_page_account_details), (create_page_user_details),
 312         (create_page_incoming), (create_page_outgoing),
 313         (modest_account_settings_dialog_init):
 314         * src/maemo/modest-connection-specific-smtp-window.c:
 315         (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
 316
 317 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 318
 319         * src/maemo/easysetup/modest-easysetup-wizard.c:
 320         (create_page_account_details), (create_page_custom_outgoing),
 321         (create_page_complete_custom):
 322         * src/maemo/modest-account-settings-dialog.c:
 323         (create_page_user_details), (create_page_incoming),
 324         (create_page_outgoing):
 325         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 326         (modest_connection_specific_smtp_edit_window_init):
 327         Use the correct (UI spec) port min/max, and use horizontal separators,
 328         as per the UI spec.
 329
 330 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 331
 332         * src/maemo/easysetup/modest-easysetup-wizard.c:
 333         (set_default_custom_servernames):
 334         * src/maemo/modest-account-settings-dialog.c:
 335         (create_page_incoming), (on_combo_outgoing_security_changed),
 336         (on_combo_incoming_security_changed), (create_page_outgoing),
 337         (modest_account_settings_dialog_set_account_name),
 338         (save_configuration):
 339         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 340         (on_combo_security_changed),
 341         (modest_connection_specific_smtp_edit_window_init),
 342         (modest_connection_specific_smtp_edit_window_set_connection),
 343         (modest_connection_specific_smtp_edit_window_get_settings):
 344         Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
 345         as per the UI spec.
 346
 347 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 348
 349         * po/en_GB.po:
 350         * src/maemo/easysetup/modest-easysetup-wizard.c:
 351         (create_page_custom_outgoing), (create_page_complete_custom):
 352         * src/maemo/modest-account-settings-dialog.c:
 353         (create_page_user_details), (create_page_outgoing):
 354         * src/maemo/modest-account-view-window.c: (button_box_new):
 355         Use changed logical IDs as per the most recent UI spec:
 356         mcen_bd_emailsetup_edit -> mcen_bd_edit
 357         mcen_bd_emailsetup_delete -> mcen_bd_delete
 358         mcen_bd_emailsetup_close -> mcen_bd_close
 359
 360 2007-04-20  2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 361
 362         * configure.ac:
 363         * src/Makefile.am:
 364         * src/dbus_api/Makefile.am:
 365         * src/dbus_api/modest-dbus-callbacks.c:
 366         * src/dbus_api/modest-dbus-callbacks.h:
 367         * src/maemo/modest-platform.c: (modest_platform_init):
 368         Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
 369         method.
 370         * tests/Makefile.am:
 371         * tests/dbus_api/Makefile.am:
 372         * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
 373
 374 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 375
 376         * src/maemo/modest-account-settings-dialog.c:
 377         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 378         Removed unnecessary includes.
 379
 380 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 381
 382         * src/maemo/easysetup/modest-easysetup-wizard.c:
 383         * src/maemo/modest-account-settings-dialog.c:
 384         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 385         * src/widgets/Makefile.am:
 386         * src/widgets/modest-easysetup-secureauth-combo-box.c:
 387         * src/widgets/modest-easysetup-secureauth-combo-box.h:
 388         * src/widgets/modest-easysetup-serversecurity-combo-box.c:
 389         * src/widgets/modest-easysetup-serversecurity-combo-box.h:
 390         * src/widgets/modest-secureauth-combo-box.c:
 391         * src/widgets/modest-secureauth-combo-box.h:
 392         * src/widgets/modest-serversecurity-combo-box.c:
 393         * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
 394         made the GObject names more consistent with the rest of the Modest code.
 395
 396 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 397
 398         * src/maemo/easysetup/Makefile.am:
 399         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 400         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
 401         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 402         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 403         * src/maemo/easysetup/modest-easysetup-wizard.c:
 404         * src/maemo/easysetup/modest-validating-entry.c:
 405         * src/maemo/easysetup/modest-validating-entry.h:
 406         * src/maemo/modest-account-settings-dialog.c:
 407         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 408         * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
 409         widgets/ because they are used outside of easysetup too. After checking in,
 410         svn will allow me to rename them too.
 411
 412 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 413
 414         * src/gnome/modest-msg-edit-window.c:
 415         (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
 416         linker error, to fix the build on the GNOME platform.
 417         modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
 418         modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
 419         ifdefed out to avoid a warning.
 420
 421 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 422
 423         * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
 424         use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
 425         some alternative for GTK+ 2.6.
 426
 427 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 428
 429         * src/maemo/modest-address-book.c: Added include to avoid a warning.
 430
 431         * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
 432         specified for EmailAccountsDialog in UI spec.
 433
 434         * src/maemo/easysetup/modest-easysetup-wizard.c:
 435         * src/maemo/easysetup/modest-easysetup-wizard.h:
 436         * src/maemo/modest-account-settings-dialog.c:
 437         * src/maemo/modest-account-settings-dialog.h:
 438         Reuse a member window widget for the connection-specific SMTP server accounts,
 439         so we can tell it to create/save the accounts only if we actually save changes.
 440
 441         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 442         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 443         (modest_connection_specific_smtp_edit_window_get_settings):
 444         Return a struct instance for temporarily remembering the entered data.
 445
 446         * src/maemo/modest-connection-specific-smtp-window.h:
 447         * src/maemo/modest-connection-specific-smtp-window.c:
 448         (modest_connection_specific_smtp_window_finalize),
 449         (modest_connection_specific_smtp_window_fill_with_connections),
 450         (on_button_edit),
 451         (modest_connection_specific_smtp_window_save_server_accounts),
 452         (update_model_server_names): Do not actually save data until asked,
 453         when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
 454
 455         (on_selection_changed),
 456         (modest_connection_specific_smtp_window_init): Disable the edit
 457         button when nothing is selected.
 458
 459         * src/modest-account-mgr-helpers.c:
 460         * src/modest-account-mgr-helpers.h:
 461         Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
 462         elsewhere.
 463
 464 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 465
 466         * src/modest-account-mgr-helpers.h:
 467         * src/modest-account-mgr-helpers.c:
 468         (modest_account_mgr_get_unused_account_name),
 469         (modest_account_mgr_get_unused_account_display_name): Added these
 470         utility functions, to avoid code duplication.
 471
 472         * src/maemo/easysetup/modest-easysetup-wizard.c:
 473         (create_page_account_details), (create_account):
 474         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 475         (on_combo_security_changed),
 476         (modest_connection_specific_smtp_edit_window_init),
 477         (modest_connection_specific_smtp_edit_window_save_settings):
 478         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 479         * src/maemo/modest-connection-specific-smtp-window.c:
 480         (modest_connection_specific_smtp_window_finalize),
 481         (modest_connection_specific_smtp_window_fill_with_connections),
 482         (on_button_edit), (modest_connection_specific_smtp_window_init):
 483         * src/maemo/modest-connection-specific-smtp-window.h:
 484         Implementing saving of connection-specific server accounts.
 485
 486         But I need to refactor this so we can save the data for each
 487         possible connection-specific account and only actually create the server accounts
 488         when the easysetup finished, or the OK button is pressed on the account settings
 489         dialog.
 490
 491 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 492
 493         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 494         (on_combo_security_changed):
 495         (modest_connection_specific_smtp_edit_window_init):
 496         Auto-fill the port number as in the account settings.
 497
 498         (modest_connection_specific_smtp_edit_window_set_connection):
 499         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 500         * src/maemo/modest-connection-specific-smtp-window.c:
 501         (fill_with_connections), (on_button_edit),
 502         (modest_connection_specific_smtp_window_init):
 503         Turn the edit window into a dialog to simplify the code, and
 504         set a WM hint as in a GtkDialog, because only a popup can be on top of
 505         another window in Maemo, and popups usually have no WM decoration.
 506
 507         * src/modest-defs.h:
 508         * src/modest-account-mgr-helpers.c:
 509         (modest_account_mgr_set_connection_specific_smtp),
 510         (modest_account_mgr_remove_connection_specific_smtp),
 511         (modest_account_mgr_get_connection_specific_smtp):
 512         * src/modest-account-mgr-helpers.h: Some functions to write the
 513         connection-specific SMTP server information. Not yet used.
 514
 515
 516         * src/widgets/modest-folder-view.c: (text_cell_data):
 517         Fix a warning about an uninitialized variable.
 518         (on_configuration_key_changed): Put an #ifdef around the use
 519         of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
 520
 521 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 522
 523         * src/maemo/modest-account-settings-dialog.h:
 524         * src/maemo/modest-account-settings-dialog.c:
 525         Added connect_for_modified() utility function to mark the new modified boolean.
 526
 527         (create_page_account_details), (create_page_user_details),
 528         (create_page_incoming), (create_page_outgoing), (on_response),
 529         (modest_account_settings_dialog_init),
 530         (modest_account_settings_dialog_set_account_name):
 531         Only warn about unsaved changes when there are actually unsaved changes.
 532
 533         * src/modest-account-mgr-helpers.c:
 534         * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
 535         into the ModestServerAccountData struct. I do not use it yet, but someone might expect
 536         to get the data from there in future.
 537
 538 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 539
 540         * src/modest-defs.h:
 541
 542         * src/modest-account-mgr-helpers.h:
 543         * src/modest-account-mgr-helpers.c:
 544         Store the security account setting in a single conf key instead of using
 545         the options list, so that the list is left for just the to-be-removed camel hack,
 546         and because gconf_client_set_list() is failing for some reason.
 547
 548         * src/modest-account-mgr.c:
 549         (modest_account_mgr_add_server_account):
 550         * src/maemo/modest-account-settings-dialog.c:
 551         (modest_account_settings_dialog_set_account_name),
 552         (save_configuration): Use the renamed functions.
 553
 554
 555 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 556
 557         * src/widgets/Makefile.am:
 558         * src/widgets/modest-limit-retrieve-combo-box.c:
 559         * src/widgets/modest-limit-retrieve-combo-box.h:
 560         * src/widgets/modest-retrieve-combo-box.c:
 561         * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
 562         the account settings dialog.
 563
 564         * src/modest-defs.h:
 565         * src/modest-account-mgr-helpers.h:
 566         * src/modest-account-mgr-helpers.c:
 567         (modest_server_account_get_option_secure_auth),
 568         (modest_server_account_set_option_secure_auth):
 569         * src/modest-account-mgr.c:
 570         (modest_account_mgr_add_server_account):
 571         Use the existing AUTH_MECH conf key for the secure-auth setting,
 572         instead of putting it in the list options, because this was actually used already.
 573
 574         * src/maemo/modest-account-settings-dialog.c:
 575         (create_page_account_details),
 576         (modest_account_settings_dialog_set_account_name),
 577         (save_configuration):
 578         * src/maemo/modest-account-settings-dialog.h:
 579         Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
 580         Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
 581
 582 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 583
 584         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 585         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 586         Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
 587
 588         * src/modest-defs.h:
 589         * src/maemo/modest-account-settings-dialog.c:
 590         (create_page_incoming), (on_combo_outgoing_security_changed),
 591         (on_combo_incoming_security_changed), (create_page_outgoing),
 592         (modest_account_settings_dialog_set_account_name),
 593         (save_configuration): Load/Save the port number, and change it when the
 594         security combo changes, to suitable defaults.
 595
 596 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 597
 598         * src/modest-account-mgr.c:
 599         (modest_account_mgr_add_server_account): Set the security and secure-auth
 600         options, and add a comment saying that the other camel-specific options should be
 601         removed in future.
 602
 603 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 604
 605         * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
 606         found by valgrind.
 607         * src/modest-tny-account-store.c: (account_list_free),
 608         (on_account_changed): Add a TODO comment about a valgrind error, caused by using
 609         cursor->data after unreffing it. But there is some strange stuff there so it might not be
 610         easy to fix.
 611
 612 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 613
 614         * src/modest-protocol-info.c:
 615         * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
 616         is required by our UI spec. Maybe something in our implementation will use this eventually.
 617         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 618         (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
 619         instead of the previous 0 placeholder.
 620
 621         * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
 622         secure-auth settings.
 623         * src/modest-account-mgr-helpers.h:
 624         * src/modest-account-mgr-helpers.c:
 625         (modest_server_account_data_get_option_secure_auth),
 626         (modest_server_account_set_option_secure_auth),
 627         (modest_server_account_data_get_option_security),
 628         (modest_server_account_set_option_security): Added this API for getting and setting the security
 629         and secure-auth settings.
 630
 631         * src/maemo/modest-account-settings-dialog.h:
 632         * src/maemo/modest-account-settings-dialog.c:
 633         (modest_account_settings_dialog_finalize), (check_data),
 634         (on_response): Store the original title as well as the name, to avoid unnececessary warnings
 635         about changing titles.
 636         (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
 637         (save_configuration): Save the security and secure-auth settings.
 638
 639         * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
 640         is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
 641
 642 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 643
 644         * src/modest-defs.h:
 645         * src/modest-account-mgr.c:
 646         (modest_account_mgr_add_server_account):
 647         Added and used defines for the options key and value pair strings,
 648         that are used so far, though they do not seem to correspond to anything in our
 649         UI specs or ModestProtocol enum.
 650
 651         * src/modest-account-mgr-helpers.h:
 652         * src/modest-account-mgr-helpers.c:
 653         (compare_option_strings_for_name),
 654         (modest_server_account_data_get_option_value),
 655         (modest_server_account_data_get_option_bool),
 656         (modest_account_mgr_get_server_account_option):
 657         Added helper functions for parsing the options GSList.
 658
 659 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 660
 661         * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
 662         display name is based on the supplied account name.
 663         * src/modest-account-mgr.c:
 664         * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
 665         with an inefficient, but good-enough, implementation.
 666
 667         * src/maemo/easysetup/modest-easysetup-wizard.c:
 668         (create_page_account_details), (on_before_next), (create_account):
 669         Check for existing display names rather than (non-user-visible) account names, and just
 670         create and set a unique account name at the end.
 671
 672         * src/maemo/modest-account-settings-dialog.c:
 673         (modest_account_settings_dialog_init),
 674         (modest_account_settings_dialog_set_account_name),
 675         (create_page_incoming): Show the display name, instead of the account name.
 676         (on_response): Do some (not all) extra checks, as in the UI spec.
 677         (save_configuration): Save the display name if it was changed.
 678
 679 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 680
 681         * po/en_GB.po: Added needed logical ID and translation.
 682         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 683         (init_view): Made the is-default column clicking work.
 684
 685 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 686
 687         * configure.ac:
 688         * src/maemo/easysetup/Makefile.am:
 689         * src/maemo/easysetup/modest-easysetup-wizard.c:
 690         (modest_easysetup_wizard_dialog_init):
 691         * src/maemo/easysetup/provider-data-test.keyfile:
 692         * src/maemo/easysetup/provider-data.keyfile:
 693         Moved the provider data file to the new modest-providers-data package and used it from there.
 694
 695 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 696
 697         * src/modest-local-folder-info.c:
 698         (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
 699         N_() was already used on the static strings, but this just marks it for translation without
 700         using the translation.
 701
 702 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 703
 704         * src/maemo/modest-account-settings-dialog.c:
 705         (create_page_incoming),
 706         (modest_account_settings_dialog_set_account_name):
 707         Added comments about the need for new API in ModestAccountMgr to handle the authentication
 708         and secure-connection stuff that is stored in the options GSList* with hard-coded names.
 709         I will do this if nobody else gets there first.
 710
 711 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 712
 713         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
 714         Saved much of the incoming and outgoing data too, though I cannot yet see how to
 715         save the security stuff.
 716
 717 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 718
 719         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 720         Set the email address and user fullname, which I now see must be
 721         done separately.
 722
 723         * src/maemo/modest-account-settings-dialog.h:
 724         * src/maemo/modest-account-settings-dialog.c:
 725          (on_response),
 726         (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
 727         leave-on-server and authentication.
 728         (save_configuration): Save most of the non-server-account specific stuff, but I don't see
 729         how to do the rest.
 730
 731 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 732
 733
 734         * src/maemo/modest-account-settings-dialog.c:
 735         * src/maemo/modest-account-settings-dialog.h:
 736         Most (but not all) of the widgets are now present as specified by the UI spec.
 737         No changes are yet saved, and some details are not properly shown yet.
 738
 739         * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
 740
 741 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 742
 743         * src/maemo/Makefile.am:
 744         * src/maemo/modest-account-settings-dialog.c:
 745         * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
 746         an existing account. Doesn't do much yet.
 747
 748         * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
 749         Open the accounts settings dialog when Edit is clicked.
 750
 751 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 752
 753         * src/maemo/easysetup/Makefile.am:
 754         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
 755         (load_from_file):
 756         * src/maemo/easysetup/modest-easysetup-wizard.c:
 757         (modest_easysetup_wizard_dialog_init):
 758         Try to get the source directory from the build system,
 759         instead of hard-coding "./" into the source code, when opening our local
 760         copies of the configuration files.
 761         But this still fails when opening the wizard from the Accounts window,
 762         maybe because the working directory seems to change at runtime.
 763         So the wizard will fail the second time unless you copy the files into their
 764         proper locations - see the stdout warnings for the paths.
 765
 766         (create_page_account_details),(on_before_next):
 767         Check for existing non-server accounts instead of server accounts,
 768         so the default account name is useful again, and to prevent trying to
 769         recreate accounts.
 770
 771         * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
 772         Show the wizard when New is clicked.
 773
 774         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 775         (init_view): Show the column headers, and show the columns that are
 776         specified in the UI specs. However, something in Maemo's GTK+ prevents
 777         us from handling the GtkCellRendererToggle::toggled signal, so we cannot
 778         change the default account. This is despite unsetting the special properties.
 779
 780 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 781
 782         * docs/reference/modest-design.sgml: Corrected spelling mistake.
 783         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 784         Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
 785         This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
 786         to make that clearer.
 787         * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
 788
 789 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 790
 791         * src/maemo/modest-account-view-window.c:
 792         (modest_account_view_window_init),
 793         (modest_account_view_window_new):
 794         Use the same buttons as specified in the
 795         UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
 796         the existing widgets, which never had a chance of working.
 797         Put the ModestAccountView treeview in a scrolled window.
 798         Do not repeat the initialization in both _init() and _new().
 799
 800         * src/widgets/modest-account-view.c: (update_account_view):
 801         Add a warning about modest_account_mgr_account_names() returning NULL, which is why
 802         this widget and window shows no accounts.
 803
 804         * po/en_GB.po: Added translations needed for the dialog button logical IDs.
 805
 806 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 807
 808         * src/maemo/easysetup/modest-easysetup-wizard.c:
 809         (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
 810         (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
 811         returns NULL after modest_account_mgr_add_server_account() returned TRUE,
 812         which seems wrong.
 813
 814         * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
 815         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
 816         accounts exist yet, as in the UI spec.
 817
 818         * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
 819
 820 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 821
 822         * src/maemo/Makefile.am:
 823         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 824         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 825         New window for editing connection-specific smtp details.
 826         Not fully implemented.
 827
 828         * src/maemo/modest-connection-specific-smtp-window.c:
 829         (modest_connection_specific_smtp_window_finalize) :
 830         unref the tree model.
 831         (on_button_edit): Show the edit window.
 832
 833 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 834
 835         * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
 836         error for me.
 837
 838         * src/maemo/Makefile.am:
 839         * src/maemo/modest-connection-specific-smtp-window.c:
 840         * src/maemo/modest-connection-specific-smtp-window.h:
 841         New window for showing the list of connections, for connection-specific
 842         SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
 843         * src/maemo/easysetup/modest-easysetup-wizard.c:
 844         (create_page_custom_outgoing): Show the new window when the button is clicked.
 845
 846 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 847
 848         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 849         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
 850         * src/maemo/modest-msg-edit-window.c:
 851         (modest_msg_edit_window_insert_image):
 852         * src/modest-conf.c: (modest_conf_key_escape):
 853         * src/modest-mail-operation.c:
 854         (modest_mail_operation_send_new_mail):
 855         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
 856         (modest_ui_actions_on_new_account):
 857         * src/widgets/modest-attachment-view.c: (update_filename_request):
 858         * src/widgets/modest-mail-header-view.c:
 859         Corrected warnings that were breaking the build, by commenting out unused variables,
 860         and a function, and by including a header.
 861
 862 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 863
 864         * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
 865         so we can #ifdef around platform-specific code when necessary.
 866         * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
 867         to allow this to build for the GNOME platform too.
 868
 869 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 870
 871         * src/maemo/easysetup/modest-easysetup-wizard.c:
 872         Added util_increment_name() and used it in create_page_account_details()
 873         to make sure that the default account name is always a new name.
 874
 875         (modest_easysetup_wizard_dialog_init),
 876         (set_default_custom_servernames): Some minor memory management fixes.
 877
 878 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 879
 880         * Makefile.am:
 881         * configure.ac:
 882         * src/modest-runtime.c: (init_i18n): Restored the translation
 883         infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
 884         are defined in config.h, and the translations are installed.
 885
 886         * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
 887         is defined for translation.
 888
 889 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
 890
 891         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
 892         (load_from_file):
 893         * src/maemo/easysetup/modest-easysetup-wizard.c:
 894         (modest_easysetup_wizard_dialog_init):
 895         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
 896         Use realistic paths (though they should use $prefix generically) to the
 897         mcc_mapping and provider-data.keyfile files which might work when they
 898         are installed by the future version of the operator-wizard package,
 899         and then fallback to paths in our source code, with an explanatory
 900         warning.
 901
 902 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
 903
 904         * configure.ac:
 905         * src/Makefile.am:
 906         * src/maemo/Makefile.am:
 907         * src/maemo/easysetup/: Added files from the previously-exernal
 908         osso-modest-easysetup.
 909         * src/maemo/modest-main-window-ui.h:
 910         * src/modest-ui-actions.c:
 911         * src/modest-ui-actions.h:
 912         Added modest_ui_actions_on_new_account() as a signal handler for the
 913         New Account menu item. It shows the easysetup wizard.
 914         * po/en_GB.po: Added additional needed logical IDs and translations.
 915
 916 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
 917 Apparently ChangeLog is not used for some vague Nokia legal reasons.
 918