git.maemo.org Git - modest/blob - ChangeLog2

   1 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
   2
   3         * src/modest-account-mgr-helpers.c:
   4         (modest_account_mgr_set_first_account_as_default):
   5         Sort the list of names alphabetically-by-title, so we choose the first one
   6         based on that.
   7         * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
   8         alphabetically by the title.
   9
  10         This fixes projects.maemo.org bug NB#56418 .
  11
  12         * src/modest-account-mgr-priv.c:
  13         (_modest_account_mgr_account_from_key):
  14         * src/modest-account-mgr.c: (on_key_change): Initialize variables to
  15         avoid a valgrind error, and possible random behaviour.
  16
  17 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
  18
  19         * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
  20         Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
  21         tinymail documentation to say that this can be expected.
  22         Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
  23         pretty, and should not happen, but I would prefer to know when it does.
  24
  25 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
  26
  27         * configure.ac: When using the older hildon version, probably on Bora,
  28         require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
  29         to fix the build.
  30         * src/widgets/modest-attachment-view.c:
  31         (modest_attachment_view_set_part_default): Initialize variables, to fix the
  32         build.
  33
  34 2007-05-09  Marcus Bauer  <marcusb@openismus.com>
  35
  36         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
  37         Implemented the prototype. Can be tested with
  38         tests/dbus_api/test_open_message:
  39
  40 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
  41
  42         * src/modest-tny-account-store.c:
  43         (modest_tny_account_store_instance_init), (get_password):
  44         * src/modest-ui-actions.c:
  45         (modest_ui_actions_on_password_requested):
  46         Do not store the password in gconf, because this function is called
  47         for non-remembered passwords. Actually use the cached (in the hash map)
  48         password instead of releasing it.
  49         The password will now not be remembered if it is asked via the protected
  50         password dialog, as per the UI spec.
  51
  52 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
  53
  54         * src/modest-defs.h:
  55         * src/modest-account-mgr-helpers.h:
  56         * src/modest-account-mgr-helpers.c:
  57         Added modest_server_account_get_username_has_succeeded(),
  58         modest_server_account_set_username_has_succeeded().
  59         (modest_server_account_set_username),
  60         Reset the has-succeeded flag if the username changes.
  61
  62         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
  63         * src/maemo/modest-connection-specific-smtp-window.c:
  64         (modest_connection_specific_smtp_window_save_server_accounts):
  65         Use modest_server_account_set_username() instead of using
  66         modest_conf_set_string() directly, so that the has-succeeded flag is always
  67         reset.
  68
  69         * src/modest-ui-actions.c:
  70         (modest_ui_actions_on_password_requested): Dim the username entry if
  71         the username has ever worked, as per the UI spec.
  72
  73 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
  74
  75         * src/modest-tny-account-store.c: (get_password):
  76         * src/modest-ui-actions.c:
  77         (modest_ui_actions_on_password_requested):
  78         Allow the username to be changed too, though there is more work to
  79         be done on exactly how this behaves.
  80
  81 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
  82
  83         * src/modest-account-mgr-helpers.h:
  84         * src/modest-account-mgr-helpers.c:
  85         Added modest_account_mgr_get_display_name(),
  86         modest_server_account_get_username(),
  87         modest_server_account_set_username(),
  88         modest_server_account_set_password(),
  89         modest_server_account_get_hostname() functions so we do not need to
  90         use the conf API directly.
  91
  92         * src/maemo/modest-main-window.c: (connect_signals):
  93         Actually connect ot the ModestAccountStore::request-password signal,
  94         so that we show the dialog when the password is requested by Tinymail,
  95         for isntance if it is empty.
  96
  97         * src/modest-marshal.list:
  98         * src/modest-tny-account-store.c:
  99         (modest_tny_account_store_class_init), (get_password),
 100         (modest_tny_account_store_alert):
 101         * src/modest-tny-account-store.h:
 102         * src/modest-ui-actions.h:
 103         * src/modest-ui-actions.c:
 104         (modest_ui_actions_on_password_requested):
 105         Change the signal parameters, so it is obvious that we are providing
 106         the non human-readable server name, and receiving both the username
 107         and password, though changing of the username is not yet implemented.
 108         Change the dialog UI to match the Maemo UI specifications, with #idfefing
 109         for the GNOME version.
 110
 111         This should fix the projects.maemo.org bug NB#56209, though it does not
 112         work on Bora, because the gconf_client_get() for the password fails
 113         immediately after we save it with gconf_client_set().
 114
 115 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 116
 117         * configure.ac:
 118         * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
 119         caused an undefined symbol error:
 120         modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
 121
 122 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 123
 124         * src/modest-tny-account-store.c:
 125         (modest_tny_account_store_alert): Adapt to the changed tinymail API,
 126         using a GError instead of a string message, so we can translate it in
 127         Modest.
 128
 129 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 130
 131         * src/maemo/modest-address-book.c:
 132         (modest_address_book_check_names):
 133         * src/maemo/modest-msg-view-window.c:
 134         (modest_msg_view_window_clipboard_owner_change):
 135         * src/modest-init.c: (modest_init_init_ui):
 136         * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
 137         (update_folders_cb), (modest_mail_operation_update_account):
 138         * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
 139         (modest_ui_actions_on_msg_attachment_clicked),
 140         (modest_ui_actions_on_msg_recpt_activated):
 141         * src/widgets/modest-header-view.c: (drag_data_get_cb):
 142         * src/widgets/modest-msg-view.c: (modest_msg_view_search),
 143         (modest_msg_view_search_next):
 144         * src/widgets/modest-recpt-editor.c:
 145         (modest_recpt_editor_on_button_release_event),
 146         (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
 147         g_message(). At this point we should only be seeing interesting errors on
 148         stdout. Debugging messages could be #ifdefed-out if they are still useful.
 149
 150 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 151
 152         (modest_wizard_dialog_force_title_update):
 153         * src/maemo/easysetup/modest-wizard-dialog.h:
 154         * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
 155         For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
 156         can update the title when appropriate. Otherwise the title is wrong if the
 157         pages are added after adding the notebook to the dialog.
 158         This must be a problem in HildonWizardDialog too.
 159         Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
 160
 161         * src/maemo/easysetup/modest-easysetup-wizard.c:
 162         (create_subsequent_customsetup_pages),
 163         (create_subsequent_easysetup_pages):
 164         Call modest_wizard_dialog_force_title_update() so that the title is
 165         correct even with GTK+ < 2.10.
 166         This fixes projects.maemo.org bug NB#56145 .
 167
 168 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 169
 170         * src/maemo/modest-platform.c:
 171         (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
 172         flag (awful lack of namespacing in this API) to prevent a useless %s dialog
 173         from being shown.
 174
 175 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 176
 177         * src/widgets/modest-window.h:
 178         * src/widgets/modest-window.c: Added a save_state_func vfunc,
 179         and modest_window_save_state(), which invokes it.
 180
 181         * src/widgets/modest-window-mgr.h:
 182         * src/widgets/modest-window-mgr.c:
 183         Added modest_window_mgr_save_state_for_all_windows(), which calls
 184         the save_state vfunc on all registered windows, if implemented.
 185
 186         * src/gnome/modest-msg-edit-window.c:
 187         * src/gnome/modest-msg-view-window.c:
 188         * src/maemo/modest-msg-edit-window.c:
 189         * src/maemo/modest-msg-view-window.c:
 190         * src/maemo/modest-main-window.c:
 191         Specify the existing save_settings functions as implementations of
 192         ModestWindow::save_state_func().
 193
 194         * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
 195         Call modest_window_mgr_save_state_for_all_windows(). This happens before
 196         enabling hibernation, for instance.
 197
 198         We may need to do the same thing for restoring settings.
 199
 200
 201 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 202
 203         * src/widgets/modest-window-mgr.c:
 204         * src/widgets/modest-window-mgr.h:
 205         Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
 206         modest_window_mgr_get_hibernation_is_prevented().
 207
 208         * src/maemo/modest-main-window.c:
 209         (on_hildon_program_is_topmost_notify): Prevent hibernation
 210         (possible when the application goes to the background in the WM),
 211         if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
 212
 213         * src/maemo/easysetup/modest-easysetup-wizard.c:
 214         (modest_easysetup_wizard_dialog_init):
 215         * src/maemo/modest-account-settings-dialog.c:
 216         (modest_account_settings_dialog_init):
 217         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 218         (modest_connection_specific_smtp_edit_window_init):
 219         * src/maemo/modest-connection-specific-smtp-window.c:
 220         (modest_connection_specific_smtp_window_init):
 221         * src/maemo/modest-signature-editor-dialog.c:
 222         (modest_signature_editor_dialog_init):
 223         Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
 224         prevent hibernation while any of these account settings dialogs are open.
 225
 226 2007-05-04  Murray Cumming  <murrayc@murrayc.com>
 227
 228         * src/maemo/Makefile.am:
 229         * src/maemo/modest-osso-state-saving.c:
 230         * src/maemo/modest-osso-state-saving.h: Added
 231         modest_osso_load_state() and modest_osso_save_state() though they do
 232         nothing now. They should iterate through all the open windows and load/save
 233         their state.
 234         * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
 235         save state when closing.
 236
 237         * src/maemo/modest-main-window.c:
 238         (on_hildon_program_is_topmost_notify), (modest_main_window_new):
 239         Add a notification handler for the HildonProgram::is-topmost property,
 240         so we can allow hibernation when the application goes into the background.
 241         But we still need to detect when the accounts setup windows are open so
 242         we can stop hibernation when they are open.
 243         To do this, I also added the main window the HildonProgram. This might have
 244         other side-effects/benefits, and should maybe be done for other windows.
 245
 246         * src/maemo/modest-osso-autosave-callbacks.h:
 247         * src/maemo/modest-osso-autosave-callbacks.c:
 248         (modest_on_osso_application_autosave): Add a libosso auto-save callback,
 249         though it does not do anything yet, and we might never need this to do
 250         anything. For instance, we already save drafts.
 251
 252         * src/maemo/modest-platform.c: (modest_platform_init):
 253         Specify the libosso auto-save callback.
 254
 255 2007-05-03  Murray Cumming  <murrayc@murrayc.com>
 256
 257         * src/maemo/modest-platform.c:
 258         (modest_platform_set_update_interval):
 259         * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
 260         aparently stays valid between application instances, so we can use this
 261         to remove and reset it later. According to a maemo-developers email from
 262         David Weinehall.
 263
 264 2007-05-03  Murray Cumming  <murrayc@murrayc.com>
 265
 266         * configure.ac: Depend on libalarm for Maemo.
 267
 268         * src/dbus_api/modest-dbus-api.h:
 269         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
 270         (on_send_receive), (modest_dbus_req_handler):
 271         Handle a SEND_RECEIVE D-Bus method.
 272
 273         * libmodest-dbus-client/libmodest-dbus-client.c:
 274         (libmodest_dbus_client_send_and_receive):
 275         * libmodest-dbus-client/libmodest-dbus-client.h:
 276         Add C convenience functions for calling the new D-Bus method.
 277
 278         * src/modest-platform.h:
 279         * src/gnome/modest-platform.c:
 280         * src/maemo/modest-platform.c:
 281         Added modest_platform_set_update_interval(), which uses the
 282         alarmd API on Maemo.
 283         (modest_platform_init),
 284         Call modest_platform_set_update_interval(), using a hard-coded
 285         interval for now (until the global settings dialog is implemented),
 286         though I am not sure that this makes sense yet.
 287
 288 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 289
 290         * src/dbus_api/modest-dbus-callbacks.c:
 291         (modest_osso_cb_hw_state_handler):
 292         * src/dbus_api/modest-dbus-callbacks.h:
 293         * src/maemo/modest-platform.c: (modest_platform_init):
 294         Registered (empty) callbacks for the osso hardware state D-Bus signals,
 295         in case this has some effect on the ability for Maemo to ping the
 296         application.
 297
 298 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 299
 300         * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
 301         Comment out an if() that checks a gchar for < 0, causing a build-breaking
 302         warning. It is probably a logic error, but I need to fix the build.
 303
 304 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 305
 306         * src/modest-account-mgr.h:
 307         * src/modest-account-mgr.c:
 308         (modest_account_mgr_account_names): Add a gboolean enabled_only
 309         parameter, so we can get lists of onlt the enabled accounts.
 310
 311         (modest_account_mgr_add_account),,
 312         (modest_account_mgr_account_with_display_name_exists):
 313         * src/maemo/modest-msg-edit-window.c: (get_transports):
 314         * src/modest-account-mgr-helpers.c:
 315         (modest_account_mgr_set_first_account_as_default):
 316         * src/modest-init.c: (init_default_account_maybe):
 317         * src/modest-tny-account-store.c: (get_accounts):
 318         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
 319         (do_send_receive_auto), (modest_ui_actions_on_send_receive):
 320         * tests/check_account-mgr.c: (START_TEST):
 321         Provide the extra parameter, as appropriate.
 322
 323         * src/widgets/modest-account-view.c: (update_account_view):
 324         Do not show disabled accounts (meaning that there is no way to
 325         enable/disable accounts in the UI (the feature is not in our UI
 326         specification), so we can use this internally only to mark unfinished
 327         or temporary account data.
 328
 329         * src/maemo/easysetup/modest-easysetup-wizard.c:
 330         (create_account): Add boolean enable parameter, so we can specify FALSE
 331         to create the temporary account.
 332         (on_button_edit_advanced_settings): Create the temporary account as disabled.
 333         (on_before_next): When finishing, when there is a temporary account, just
 334         set it as enabled.
 335         Also, use a timeout to delay the showing of the dialog until gconf is likely
 336         to return correct information, due to a maemo gconf bug that is fixed in
 337         osso 1.1, but not yet in Bora.
 338         However, the dialog stays on screen after it is destroyed.
 339
 340         * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
 341         for invalid data when cancelling. Use a hildon note instead of a dialog
 342         to complain about invalid data. Do not show the account-saved note if the
 343         account is disabled (a temporary account that will not really be saved for use
 344         until later.)
 345
 346 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 347
 348         * src/modest-account-mgr-helpers.h:
 349         * src/modest-account-mgr-helpers.c:
 350         Added modest_account_mgr_unset_default_account(),
 351         Added modest_account_mgr_set_first_account_as_default().
 352
 353         * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
 354         If it was the default account, unset the default account name.
 355
 356         * src/maemo/modest-account-view-window.c:
 357         (on_delete_button_clicked): If it was the default account,
 358         set the first remaining account as the default instead.
 359
 360         * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
 361         a NULL account or a NULL default account, to prevent a crash. This should
 362         not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
 363
 364
 365 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 366
 367         * src/widgets/modest-recpt-editor.c:
 368         (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
 369         use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
 370         TODO comment for this. This fixes the build.
 371
 372         * src/modest-ui-actions.c: Add do_send_receive(), though it might not
 373         be the best place for it. This will in future update all auto-update accounts,
 374         rather than just the current/default account, when that gconf key exists.
 375         (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
 376         if there are no accounts, before calling do_send_receive().
 377         * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
 378
 379         * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
 380         * src/maemo/modest-main-window-ui.h:
 381         * src/maemo/modest-main-window.c: (on_connection_changed),
 382         (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
 383         directly, becaue the signal handler does more.
 384
 385 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 386
 387         * src/modest-account-mgr-helpers.c:
 388         (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
 389         for the case that the account does not exist.
 390
 391         * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
 392         (equivalent to the modest account name) rather than the tinymail account name
 393         (equivalent to the modest account title - human readable) to get the account data.
 394         Check for null account data to prevent the crash, and add a TODO comment saying that
 395         this needs fixing because it is using the server account name instead of the account name.
 396
 397 2007-04-29  Murray Cumming  <murrayc@murrayc.com>
 398
 399         * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
 400         * src/maemo/modest-account-settings-dialog.c: (show_error),
 401         (show_ok):
 402         Use hildon_note_new_information() for informative and error messages,
 403         which seems to be expected for Maemo applications (no documentation that I know of
 404         says this). I am surprised that there is no distinction between info and error
 405         dialogs.
 406
 407 2007-04-29  Murray Cumming  <murrayc@murrayc.com>
 408
 409         * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
 410         it is easy to find where this is used.
 411
 412         * src/maemo/easysetup/modest-easysetup-wizard.c:
 413         (create_page_welcome), (create_page_account_details),
 414         (create_page_user_details), (create_page_complete_easysetup),
 415         (create_page_custom_incoming), (create_page_custom_outgoing),
 416         (create_page_complete_custom):
 417         * src/maemo/modest-account-settings-dialog.c:
 418         (create_page_account_details), (create_page_user_details),
 419         (create_page_incoming), (create_page_outgoing):
 420         * src/maemo/modest-account-view-window.c: (window_vbox_new):
 421         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 422         (modest_connection_specific_smtp_edit_window_init):
 423         * src/maemo/modest-connection-specific-smtp-window.c:
 424         (modest_connection_specific_smtp_window_init):
 425         * src/maemo/modest-signature-editor-dialog.c:
 426         (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
 427         and scrolling policy as per the Email Application Layout Guide, if I have
 428         understood it.
 429
 430 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 431
 432         * src/modest-tny-account-store.c: (modest_tny_account_store_init):
 433         Remove the add_transport_account_func and add_store_account_func vfunc implementations,
 434         which were empty, because these vfuncs have been removed from TnyAccountStore.
 435         This fixes the build.
 436
 437 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 438
 439         * src/maemo/modest-main-window.c:
 440         (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
 441         showing/hiding it. Added TODO because it probably should not be NULL.
 442         * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
 443         because unnecessary g_warnings() make degugging difficult.
 444
 445 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 446
 447         * src/maemo/modest-msg-edit-window.c:
 448         (modest_msg_edit_window_select_color),
 449         (modest_msg_edit_window_select_background_color): 2 const corrections and
 450         moving 2 #endifs before closing brackets, to fix the build.
 451
 452 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 453
 454         * src/maemo/easysetup/modest-easysetup-wizard.h:
 455         * src/maemo/easysetup/modest-easysetup-wizard.c:
 456         (modest_easysetup_wizard_dialog_finalize),
 457         (on_button_edit_advanced_settings), (create_page_complete_custom),
 458         (on_response), (create_account):
 459         Implement the Advanced Settings edit button, by saving the account information,
 460         for the Advanded Settings dialog to use directly from gconf, and removing it
 461         if Finish is never clicked. There is still some UI strangeness, so this is not finished.
 462         Bug #5533 in the projects.maemo.org bugzilla.
 463
 464 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 465
 466         * src/maemo/modest-msg-view-window.c:
 467         (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
 468         when opening a message window.
 469
 470 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 471
 472         * src/maemo/easysetup/modest-easysetup-wizard.c:
 473         (create_page_custom_outgoing): Correct the position of the horizontal separator to
 474         match the UI spec.
 475
 476         * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
 477         before showing/hiding them, to avoid a crash when clicking on folders when there are no
 478         gconf settings. I probably added more checks than necessary, but that is safer.
 479
 480         * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
 481         variable to fix the build, but this seems to be used when it is still NULL.
 482
 483 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 484
 485         * src/modest-platform.h:
 486         * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
 487         * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
 488         * src/modest-main.c: Implement this function so we can avoid using
 489         maemo-specific API from cross-platform code.
 490         (main):
 491         * src/modest-tny-account-store.c:
 492         (get_smtp_specific_transport_account_for_open_connection):
 493         * src/modest-ui-actions.c: (check_for_connection),
 494         (modest_ui_actions_on_item_not_found):
 495         Use modest_platform_connect_and_wait() and put #idefs around other
 496         maemo-specific code, because only maemo currently has a way to
 497         identify connection names.
 498
 499 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 500
 501         * src/modest-tny-account-store.h:
 502         * src/modest-tny-account-store.c:
 503         Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
 504         the connection-specific SMTP server settings in the configuration.
 505
 506         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
 507         (on_idle_mail_to):
 508         * src/maemo/modest-main-window.c: (on_connection_changed),
 509         (connect_signals):
 510         * src/modest-main.c: (main), (start_ui), (send_mail):
 511         Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
 512         that is what is intended.
 513
 514         * src/modest-ui-actions.c: (action_send), (action_receive),
 515         (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
 516         Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
 517         modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
 518         SMTP server is used when it is specified.
 519
 520         (modest_ui_actions_on_send_receive):
 521         Check that a connection is open before proceeding.
 522         Receive and then send, instead of vice-versa, as per the specification.
 523
 524 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 525
 526         * src/modest-mail-operation.c:
 527         (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
 528         though I guess it should be something other than NULL.
 529
 530 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 531
 532         * src/maemo/easysetup/modest-easysetup-wizard.c:
 533         (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
 534         combo twice, to avoid an g_warning and to make it visible again.
 535         * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
 536         attached before detaching it, to avoid a g_warning, and add comment about the implicit
 537         (already intended) dereference when detaching, because we then recreate the menu.
 538         But I am not sure why the warning was happening, and it is possible that this is a memory
 539         leak.
 540
 541 2007-04-25  Murray Cumming  <murrayc@murrayc.com>
 542
 543         * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
 544         and uri_parse_mailto() utility functions.
 545         (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
 546         the mailto URI.
 547         * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
 548
 549 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 550
 551         * src/dbus_api/modest-dbus-api.h:
 552         * src/dbus_api/modest-dbus-callbacks.c:
 553         Use an idle callback to execute the modest code in the application's own thread.
 554         Remove the helloworld example method.
 555         Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
 556         parsed, and the open-message method is not implemented because this is not yet implemented in
 557         modest itself.
 558         * libmodest-dbus-client/libmodest-dbus-client.c:
 559         (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
 560         (libmodest_dbus_client_open_message):
 561         * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
 562
 563         * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
 564         body without crashing.
 565
 566         * tests/dbus_api/Makefile.am:
 567         * tests/dbus_api/test_mail_to.c:
 568         * tests/dbus_api/test_open_message.c: New tests for the new methods.
 569
 570 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 571
 572         * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
 573         Added file to fix the build. Sorry.
 574
 575         * src/dbus_api/Makefile.am:
 576         * src/dbus_api/modest-dbus-api.h:
 577         * src/dbus_api/modest-dbus-callbacks.h:
 578         * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
 579         (modest_dbus_req_handler):
 580         Put constants in a separate header so it can be reused by the
 581         client library, without duplication
 582
 583         * libmodest-dbus-client/Makefile.am:
 584         * libmodest-dbus-client/libmodest-dbus-client.c:
 585         (libmodest_dbus_client_call_helloworld),
 586         (libmodfest_dbus_client_send_mail),
 587         (libmodfest_dbus_client_mailto),
 588         (libmodfest_dbus_client_open_message):
 589         * libmodest-dbus-client/libmodest-dbus-client.h:
 590         (Partly) Implement a send_mail D-Bus method.
 591
 592         * tests/dbus_api/Makefile.am:
 593         * tests/dbus_api/test_send_mail.c: (main): Added a test for
 594         the send_email D-Bus method.
 595
 596 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 597
 598         * Makefile.am:
 599         * configure.ac:
 600         * libmodest-dbus-client/Makefile.am:
 601         * libmodest-dbus-client/libmodest-dbus-client.c:
 602         * libmodest-dbus-client/libmodest-dbus-client.h:
 603         * tests/dbus_api/Makefile.am:
 604         * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
 605         for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
 606
 607 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 608
 609         * src/maemo/easysetup/modest-easysetup-wizard.c:
 610         (create_page_account_details):
 611         * src/maemo/modest-account-settings-dialog.c:
 612         (create_page_account_details): Explicitly set auto-capitalization mode for the title
 613         widgets, because this might not be the default in future versions of the Maemo GTK+.
 614         However, I can not not get capitalization to work even in a simple test case.
 615
 616 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 617
 618         * src/maemo/easysetup/modest-easysetup-wizard.c:
 619         (create_page_custom_incoming), (create_page_custom_outgoing):
 620         * src/maemo/modest-account-settings-dialog.c:
 621         (create_page_account_details), (create_page_incoming),
 622         (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
 623         instead of using gtk_check_button_with_label(), so they are aligned like the other
 624         widgets, as per the UI spec.
 625
 626 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 627
 628         * src/maemo/easysetup/modest-easysetup-wizard.c:
 629         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 630         * src/widgets/modest-validating-entry.c:
 631         * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
 632         Modest prefix instead of an EasySetup prefix.
 633
 634 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 635
 636         * src/widgets/modest-validating-entry.h:
 637         * src/widgets/modest-validating-entry.c: (on_insert_text),
 638         Added easysetup_validating_entry_set_max_func(), used to set a callback
 639         to call when the max number of characters is reached. GtkEntry has a max-length
 640         already but is silent about it.
 641
 642         * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
 643         (create_page_account_details), (create_page_user_details),
 644         (create_account):
 645         * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
 646         (create_page_account_details), (create_page_user_details),
 647         (create_page_outgoing):
 648         * src/modest-ui-actions.c: (modest_ui_actions_on_details):
 649         Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
 650         the UI spec, when the user tries to enter more than the max number of characters.
 651
 652 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 653
 654         * src/maemo/easysetup/modest-easysetup-wizard.c:
 655         (create_page_user_details), (create_page_custom_incoming),
 656         (create_page_custom_outgoing):
 657         * src/maemo/modest-account-settings-dialog.c:
 658         (create_page_user_details), (create_page_incoming),
 659         (create_page_outgoing):
 660         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 661         (modest_connection_specific_smtp_edit_window_init):
 662         Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
 663         not appropriate. Bad Maemo-specific defaults!.
 664
 665 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 666
 667         * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
 668         (on_toggle_button_changed), (modest_signature_editor_dialog_init),
 669         (modest_signature_editor_dialog_set_settings):
 670         Disable the label and textview when the checkbox is disabled, and use the
 671         specified (UI spec) default signature text.
 672
 673 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 674
 675         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 676         (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
 677
 678         * src/modest-defs.h:
 679         * src/modest-account-mgr-helpers.h:
 680         * src/modest-account-mgr-helpers.c:
 681         Added modest_account_mgr_get/set_signature(), using new gconf keys.
 682
 683         * src/maemo/Makefile.am:
 684         * src/maemo/modest-signature-editor-dialog.c:
 685         * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
 686         as per the UI spec.
 687
 688         * src/maemo/modest-account-settings-dialog.h:
 689         * src/maemo/modest-account-settings-dialog.c:
 690         (modest_account_settings_dialog_finalize), (on_button_signature),
 691         (save_configuration): Use the new dialog when the Edit button is pressed, and
 692         save the changes if necessary, as per the UI spec.
 693
 694 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 695
 696         * src/maemo/Makefile.am:
 697         * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
 698         based on maemo-develoers email from Dirk.
 699
 700         * src/maemo/easysetup/modest-easysetup-wizard.c:
 701         (create_page_welcome), (create_page_account_details),
 702         (create_page_user_details), (create_page_complete_easysetup),
 703         (create_page_custom_incoming), (create_page_custom_outgoing),
 704         (create_page_complete_custom),
 705         (modest_easysetup_wizard_dialog_init):
 706         * src/maemo/modest-account-settings-dialog.c:
 707         (create_page_account_details), (create_page_user_details),
 708         (create_page_incoming), (create_page_outgoing),
 709         (modest_account_settings_dialog_init):
 710         * src/maemo/modest-connection-specific-smtp-window.c:
 711         (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
 712
 713 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 714
 715         * src/maemo/easysetup/modest-easysetup-wizard.c:
 716         (create_page_account_details), (create_page_custom_outgoing),
 717         (create_page_complete_custom):
 718         * src/maemo/modest-account-settings-dialog.c:
 719         (create_page_user_details), (create_page_incoming),
 720         (create_page_outgoing):
 721         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 722         (modest_connection_specific_smtp_edit_window_init):
 723         Use the correct (UI spec) port min/max, and use horizontal separators,
 724         as per the UI spec.
 725
 726 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 727
 728         * src/maemo/easysetup/modest-easysetup-wizard.c:
 729         (set_default_custom_servernames):
 730         * src/maemo/modest-account-settings-dialog.c:
 731         (create_page_incoming), (on_combo_outgoing_security_changed),
 732         (on_combo_incoming_security_changed), (create_page_outgoing),
 733         (modest_account_settings_dialog_set_account_name),
 734         (save_configuration):
 735         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 736         (on_combo_security_changed),
 737         (modest_connection_specific_smtp_edit_window_init),
 738         (modest_connection_specific_smtp_edit_window_set_connection),
 739         (modest_connection_specific_smtp_edit_window_get_settings):
 740         Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
 741         as per the UI spec.
 742
 743 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 744
 745         * po/en_GB.po:
 746         * src/maemo/easysetup/modest-easysetup-wizard.c:
 747         (create_page_custom_outgoing), (create_page_complete_custom):
 748         * src/maemo/modest-account-settings-dialog.c:
 749         (create_page_user_details), (create_page_outgoing):
 750         * src/maemo/modest-account-view-window.c: (button_box_new):
 751         Use changed logical IDs as per the most recent UI spec:
 752         mcen_bd_emailsetup_edit -> mcen_bd_edit
 753         mcen_bd_emailsetup_delete -> mcen_bd_delete
 754         mcen_bd_emailsetup_close -> mcen_bd_close
 755
 756 2007-04-20  2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 757
 758         * configure.ac:
 759         * src/Makefile.am:
 760         * src/dbus_api/Makefile.am:
 761         * src/dbus_api/modest-dbus-callbacks.c:
 762         * src/dbus_api/modest-dbus-callbacks.h:
 763         * src/maemo/modest-platform.c: (modest_platform_init):
 764         Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
 765         method.
 766         * tests/Makefile.am:
 767         * tests/dbus_api/Makefile.am:
 768         * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
 769
 770 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 771
 772         * src/maemo/modest-account-settings-dialog.c:
 773         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 774         Removed unnecessary includes.
 775
 776 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 777
 778         * src/maemo/easysetup/modest-easysetup-wizard.c:
 779         * src/maemo/modest-account-settings-dialog.c:
 780         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 781         * src/widgets/Makefile.am:
 782         * src/widgets/modest-easysetup-secureauth-combo-box.c:
 783         * src/widgets/modest-easysetup-secureauth-combo-box.h:
 784         * src/widgets/modest-easysetup-serversecurity-combo-box.c:
 785         * src/widgets/modest-easysetup-serversecurity-combo-box.h:
 786         * src/widgets/modest-secureauth-combo-box.c:
 787         * src/widgets/modest-secureauth-combo-box.h:
 788         * src/widgets/modest-serversecurity-combo-box.c:
 789         * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
 790         made the GObject names more consistent with the rest of the Modest code.
 791
 792 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 793
 794         * src/maemo/easysetup/Makefile.am:
 795         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 796         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
 797         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 798         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 799         * src/maemo/easysetup/modest-easysetup-wizard.c:
 800         * src/maemo/easysetup/modest-validating-entry.c:
 801         * src/maemo/easysetup/modest-validating-entry.h:
 802         * src/maemo/modest-account-settings-dialog.c:
 803         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 804         * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
 805         widgets/ because they are used outside of easysetup too. After checking in,
 806         svn will allow me to rename them too.
 807
 808 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 809
 810         * src/gnome/modest-msg-edit-window.c:
 811         (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
 812         linker error, to fix the build on the GNOME platform.
 813         modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
 814         modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
 815         ifdefed out to avoid a warning.
 816
 817 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 818
 819         * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
 820         use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
 821         some alternative for GTK+ 2.6.
 822
 823 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 824
 825         * src/maemo/modest-address-book.c: Added include to avoid a warning.
 826
 827         * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
 828         specified for EmailAccountsDialog in UI spec.
 829
 830         * src/maemo/easysetup/modest-easysetup-wizard.c:
 831         * src/maemo/easysetup/modest-easysetup-wizard.h:
 832         * src/maemo/modest-account-settings-dialog.c:
 833         * src/maemo/modest-account-settings-dialog.h:
 834         Reuse a member window widget for the connection-specific SMTP server accounts,
 835         so we can tell it to create/save the accounts only if we actually save changes.
 836
 837         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 838         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 839         (modest_connection_specific_smtp_edit_window_get_settings):
 840         Return a struct instance for temporarily remembering the entered data.
 841
 842         * src/maemo/modest-connection-specific-smtp-window.h:
 843         * src/maemo/modest-connection-specific-smtp-window.c:
 844         (modest_connection_specific_smtp_window_finalize),
 845         (modest_connection_specific_smtp_window_fill_with_connections),
 846         (on_button_edit),
 847         (modest_connection_specific_smtp_window_save_server_accounts),
 848         (update_model_server_names): Do not actually save data until asked,
 849         when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
 850
 851         (on_selection_changed),
 852         (modest_connection_specific_smtp_window_init): Disable the edit
 853         button when nothing is selected.
 854
 855         * src/modest-account-mgr-helpers.c:
 856         * src/modest-account-mgr-helpers.h:
 857         Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
 858         elsewhere.
 859
 860 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 861
 862         * src/modest-account-mgr-helpers.h:
 863         * src/modest-account-mgr-helpers.c:
 864         (modest_account_mgr_get_unused_account_name),
 865         (modest_account_mgr_get_unused_account_display_name): Added these
 866         utility functions, to avoid code duplication.
 867
 868         * src/maemo/easysetup/modest-easysetup-wizard.c:
 869         (create_page_account_details), (create_account):
 870         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 871         (on_combo_security_changed),
 872         (modest_connection_specific_smtp_edit_window_init),
 873         (modest_connection_specific_smtp_edit_window_save_settings):
 874         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 875         * src/maemo/modest-connection-specific-smtp-window.c:
 876         (modest_connection_specific_smtp_window_finalize),
 877         (modest_connection_specific_smtp_window_fill_with_connections),
 878         (on_button_edit), (modest_connection_specific_smtp_window_init):
 879         * src/maemo/modest-connection-specific-smtp-window.h:
 880         Implementing saving of connection-specific server accounts.
 881
 882         But I need to refactor this so we can save the data for each
 883         possible connection-specific account and only actually create the server accounts
 884         when the easysetup finished, or the OK button is pressed on the account settings
 885         dialog.
 886
 887 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 888
 889         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 890         (on_combo_security_changed):
 891         (modest_connection_specific_smtp_edit_window_init):
 892         Auto-fill the port number as in the account settings.
 893
 894         (modest_connection_specific_smtp_edit_window_set_connection):
 895         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 896         * src/maemo/modest-connection-specific-smtp-window.c:
 897         (fill_with_connections), (on_button_edit),
 898         (modest_connection_specific_smtp_window_init):
 899         Turn the edit window into a dialog to simplify the code, and
 900         set a WM hint as in a GtkDialog, because only a popup can be on top of
 901         another window in Maemo, and popups usually have no WM decoration.
 902
 903         * src/modest-defs.h:
 904         * src/modest-account-mgr-helpers.c:
 905         (modest_account_mgr_set_connection_specific_smtp),
 906         (modest_account_mgr_remove_connection_specific_smtp),
 907         (modest_account_mgr_get_connection_specific_smtp):
 908         * src/modest-account-mgr-helpers.h: Some functions to write the
 909         connection-specific SMTP server information. Not yet used.
 910
 911
 912         * src/widgets/modest-folder-view.c: (text_cell_data):
 913         Fix a warning about an uninitialized variable.
 914         (on_configuration_key_changed): Put an #ifdef around the use
 915         of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
 916
 917 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 918
 919         * src/maemo/modest-account-settings-dialog.h:
 920         * src/maemo/modest-account-settings-dialog.c:
 921         Added connect_for_modified() utility function to mark the new modified boolean.
 922
 923         (create_page_account_details), (create_page_user_details),
 924         (create_page_incoming), (create_page_outgoing), (on_response),
 925         (modest_account_settings_dialog_init),
 926         (modest_account_settings_dialog_set_account_name):
 927         Only warn about unsaved changes when there are actually unsaved changes.
 928
 929         * src/modest-account-mgr-helpers.c:
 930         * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
 931         into the ModestServerAccountData struct. I do not use it yet, but someone might expect
 932         to get the data from there in future.
 933
 934 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 935
 936         * src/modest-defs.h:
 937
 938         * src/modest-account-mgr-helpers.h:
 939         * src/modest-account-mgr-helpers.c:
 940         Store the security account setting in a single conf key instead of using
 941         the options list, so that the list is left for just the to-be-removed camel hack,
 942         and because gconf_client_set_list() is failing for some reason.
 943
 944         * src/modest-account-mgr.c:
 945         (modest_account_mgr_add_server_account):
 946         * src/maemo/modest-account-settings-dialog.c:
 947         (modest_account_settings_dialog_set_account_name),
 948         (save_configuration): Use the renamed functions.
 949
 950
 951 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 952
 953         * src/widgets/Makefile.am:
 954         * src/widgets/modest-limit-retrieve-combo-box.c:
 955         * src/widgets/modest-limit-retrieve-combo-box.h:
 956         * src/widgets/modest-retrieve-combo-box.c:
 957         * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
 958         the account settings dialog.
 959
 960         * src/modest-defs.h:
 961         * src/modest-account-mgr-helpers.h:
 962         * src/modest-account-mgr-helpers.c:
 963         (modest_server_account_get_option_secure_auth),
 964         (modest_server_account_set_option_secure_auth):
 965         * src/modest-account-mgr.c:
 966         (modest_account_mgr_add_server_account):
 967         Use the existing AUTH_MECH conf key for the secure-auth setting,
 968         instead of putting it in the list options, because this was actually used already.
 969
 970         * src/maemo/modest-account-settings-dialog.c:
 971         (create_page_account_details),
 972         (modest_account_settings_dialog_set_account_name),
 973         (save_configuration):
 974         * src/maemo/modest-account-settings-dialog.h:
 975         Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
 976         Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
 977
 978 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 979
 980         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 981         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 982         Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
 983
 984         * src/modest-defs.h:
 985         * src/maemo/modest-account-settings-dialog.c:
 986         (create_page_incoming), (on_combo_outgoing_security_changed),
 987         (on_combo_incoming_security_changed), (create_page_outgoing),
 988         (modest_account_settings_dialog_set_account_name),
 989         (save_configuration): Load/Save the port number, and change it when the
 990         security combo changes, to suitable defaults.
 991
 992 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 993
 994         * src/modest-account-mgr.c:
 995         (modest_account_mgr_add_server_account): Set the security and secure-auth
 996         options, and add a comment saying that the other camel-specific options should be
 997         removed in future.
 998
 999 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
1000
1001         * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1002         found by valgrind.
1003         * src/modest-tny-account-store.c: (account_list_free),
1004         (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1005         cursor->data after unreffing it. But there is some strange stuff there so it might not be
1006         easy to fix.
1007
1008 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
1009
1010         * src/modest-protocol-info.c:
1011         * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1012         is required by our UI spec. Maybe something in our implementation will use this eventually.
1013         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1014         (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1015         instead of the previous 0 placeholder.
1016
1017         * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1018         secure-auth settings.
1019         * src/modest-account-mgr-helpers.h:
1020         * src/modest-account-mgr-helpers.c:
1021         (modest_server_account_data_get_option_secure_auth),
1022         (modest_server_account_set_option_secure_auth),
1023         (modest_server_account_data_get_option_security),
1024         (modest_server_account_set_option_security): Added this API for getting and setting the security
1025         and secure-auth settings.
1026
1027         * src/maemo/modest-account-settings-dialog.h:
1028         * src/maemo/modest-account-settings-dialog.c:
1029         (modest_account_settings_dialog_finalize), (check_data),
1030         (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1031         about changing titles.
1032         (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1033         (save_configuration): Save the security and secure-auth settings.
1034
1035         * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1036         is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1037
1038 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
1039
1040         * src/modest-defs.h:
1041         * src/modest-account-mgr.c:
1042         (modest_account_mgr_add_server_account):
1043         Added and used defines for the options key and value pair strings,
1044         that are used so far, though they do not seem to correspond to anything in our
1045         UI specs or ModestProtocol enum.
1046
1047         * src/modest-account-mgr-helpers.h:
1048         * src/modest-account-mgr-helpers.c:
1049         (compare_option_strings_for_name),
1050         (modest_server_account_data_get_option_value),
1051         (modest_server_account_data_get_option_bool),
1052         (modest_account_mgr_get_server_account_option):
1053         Added helper functions for parsing the options GSList.
1054
1055 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1056
1057         * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1058         display name is based on the supplied account name.
1059         * src/modest-account-mgr.c:
1060         * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1061         with an inefficient, but good-enough, implementation.
1062
1063         * src/maemo/easysetup/modest-easysetup-wizard.c:
1064         (create_page_account_details), (on_before_next), (create_account):
1065         Check for existing display names rather than (non-user-visible) account names, and just
1066         create and set a unique account name at the end.
1067
1068         * src/maemo/modest-account-settings-dialog.c:
1069         (modest_account_settings_dialog_init),
1070         (modest_account_settings_dialog_set_account_name),
1071         (create_page_incoming): Show the display name, instead of the account name.
1072         (on_response): Do some (not all) extra checks, as in the UI spec.
1073         (save_configuration): Save the display name if it was changed.
1074
1075 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1076
1077         * po/en_GB.po: Added needed logical ID and translation.
1078         * src/widgets/modest-account-view.c: (on_account_default_toggled),
1079         (init_view): Made the is-default column clicking work.
1080
1081 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1082
1083         * configure.ac:
1084         * src/maemo/easysetup/Makefile.am:
1085         * src/maemo/easysetup/modest-easysetup-wizard.c:
1086         (modest_easysetup_wizard_dialog_init):
1087         * src/maemo/easysetup/provider-data-test.keyfile:
1088         * src/maemo/easysetup/provider-data.keyfile:
1089         Moved the provider data file to the new modest-providers-data package and used it from there.
1090
1091 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1092
1093         * src/modest-local-folder-info.c:
1094         (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1095         N_() was already used on the static strings, but this just marks it for translation without
1096         using the translation.
1097
1098 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1099
1100         * src/maemo/modest-account-settings-dialog.c:
1101         (create_page_incoming),
1102         (modest_account_settings_dialog_set_account_name):
1103         Added comments about the need for new API in ModestAccountMgr to handle the authentication
1104         and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1105         I will do this if nobody else gets there first.
1106
1107 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1108
1109         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1110         Saved much of the incoming and outgoing data too, though I cannot yet see how to
1111         save the security stuff.
1112
1113 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1114
1115         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1116         Set the email address and user fullname, which I now see must be
1117         done separately.
1118
1119         * src/maemo/modest-account-settings-dialog.h:
1120         * src/maemo/modest-account-settings-dialog.c:
1121          (on_response),
1122         (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1123         leave-on-server and authentication.
1124         (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1125         how to do the rest.
1126
1127 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1128
1129
1130         * src/maemo/modest-account-settings-dialog.c:
1131         * src/maemo/modest-account-settings-dialog.h:
1132         Most (but not all) of the widgets are now present as specified by the UI spec.
1133         No changes are yet saved, and some details are not properly shown yet.
1134
1135         * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1136
1137 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1138
1139         * src/maemo/Makefile.am:
1140         * src/maemo/modest-account-settings-dialog.c:
1141         * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1142         an existing account. Doesn't do much yet.
1143
1144         * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1145         Open the accounts settings dialog when Edit is clicked.
1146
1147 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1148
1149         * src/maemo/easysetup/Makefile.am:
1150         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1151         (load_from_file):
1152         * src/maemo/easysetup/modest-easysetup-wizard.c:
1153         (modest_easysetup_wizard_dialog_init):
1154         Try to get the source directory from the build system,
1155         instead of hard-coding "./" into the source code, when opening our local
1156         copies of the configuration files.
1157         But this still fails when opening the wizard from the Accounts window,
1158         maybe because the working directory seems to change at runtime.
1159         So the wizard will fail the second time unless you copy the files into their
1160         proper locations - see the stdout warnings for the paths.
1161
1162         (create_page_account_details),(on_before_next):
1163         Check for existing non-server accounts instead of server accounts,
1164         so the default account name is useful again, and to prevent trying to
1165         recreate accounts.
1166
1167         * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1168         Show the wizard when New is clicked.
1169
1170         * src/widgets/modest-account-view.c: (on_account_default_toggled),
1171         (init_view): Show the column headers, and show the columns that are
1172         specified in the UI specs. However, something in Maemo's GTK+ prevents
1173         us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1174         change the default account. This is despite unsetting the special properties.
1175
1176 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1177
1178         * docs/reference/modest-design.sgml: Corrected spelling mistake.
1179         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1180         Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1181         This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1182         to make that clearer.
1183         * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1184
1185 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1186
1187         * src/maemo/modest-account-view-window.c:
1188         (modest_account_view_window_init),
1189         (modest_account_view_window_new):
1190         Use the same buttons as specified in the
1191         UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1192         the existing widgets, which never had a chance of working.
1193         Put the ModestAccountView treeview in a scrolled window.
1194         Do not repeat the initialization in both _init() and _new().
1195
1196         * src/widgets/modest-account-view.c: (update_account_view):
1197         Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1198         this widget and window shows no accounts.
1199
1200         * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1201
1202 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1203
1204         * src/maemo/easysetup/modest-easysetup-wizard.c:
1205         (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1206         (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1207         returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1208         which seems wrong.
1209
1210         * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1211         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1212         accounts exist yet, as in the UI spec.
1213
1214         * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
1215
1216 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1217
1218         * src/maemo/Makefile.am:
1219         * src/maemo/modest-connection-specific-smtp-edit-window.c:
1220         * src/maemo/modest-connection-specific-smtp-edit-window.h:
1221         New window for editing connection-specific smtp details.
1222         Not fully implemented.
1223
1224         * src/maemo/modest-connection-specific-smtp-window.c:
1225         (modest_connection_specific_smtp_window_finalize) :
1226         unref the tree model.
1227         (on_button_edit): Show the edit window.
1228
1229 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1230
1231         * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
1232         error for me.
1233
1234         * src/maemo/Makefile.am:
1235         * src/maemo/modest-connection-specific-smtp-window.c:
1236         * src/maemo/modest-connection-specific-smtp-window.h:
1237         New window for showing the list of connections, for connection-specific
1238         SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
1239         * src/maemo/easysetup/modest-easysetup-wizard.c:
1240         (create_page_custom_outgoing): Show the new window when the button is clicked.
1241
1242 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1243
1244         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1245         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1246         * src/maemo/modest-msg-edit-window.c:
1247         (modest_msg_edit_window_insert_image):
1248         * src/modest-conf.c: (modest_conf_key_escape):
1249         * src/modest-mail-operation.c:
1250         (modest_mail_operation_send_new_mail):
1251         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1252         (modest_ui_actions_on_new_account):
1253         * src/widgets/modest-attachment-view.c: (update_filename_request):
1254         * src/widgets/modest-mail-header-view.c:
1255         Corrected warnings that were breaking the build, by commenting out unused variables,
1256         and a function, and by including a header.
1257
1258 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1259
1260         * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
1261         so we can #ifdef around platform-specific code when necessary.
1262         * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
1263         to allow this to build for the GNOME platform too.
1264
1265 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1266
1267         * src/maemo/easysetup/modest-easysetup-wizard.c:
1268         Added util_increment_name() and used it in create_page_account_details()
1269         to make sure that the default account name is always a new name.
1270
1271         (modest_easysetup_wizard_dialog_init),
1272         (set_default_custom_servernames): Some minor memory management fixes.
1273
1274 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1275
1276         * Makefile.am:
1277         * configure.ac:
1278         * src/modest-runtime.c: (init_i18n): Restored the translation
1279         infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
1280         are defined in config.h, and the translations are installed.
1281
1282         * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
1283         is defined for translation.
1284
1285 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
1286
1287         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1288         (load_from_file):
1289         * src/maemo/easysetup/modest-easysetup-wizard.c:
1290         (modest_easysetup_wizard_dialog_init):
1291         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1292         Use realistic paths (though they should use $prefix generically) to the
1293         mcc_mapping and provider-data.keyfile files which might work when they
1294         are installed by the future version of the operator-wizard package,
1295         and then fallback to paths in our source code, with an explanatory
1296         warning.
1297
1298 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
1299
1300         * configure.ac:
1301         * src/Makefile.am:
1302         * src/maemo/Makefile.am:
1303         * src/maemo/easysetup/: Added files from the previously-exernal
1304         osso-modest-easysetup.
1305         * src/maemo/modest-main-window-ui.h:
1306         * src/modest-ui-actions.c:
1307         * src/modest-ui-actions.h:
1308         Added modest_ui_actions_on_new_account() as a signal handler for the
1309         New Account menu item. It shows the easysetup wizard.
1310         * po/en_GB.po: Added additional needed logical IDs and translations.
1311
1312 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
1313 Apparently ChangeLog is not used for some vague Nokia legal reasons.
1314