1 2007-07-02 Armin Burgmeier <armin@openismus.com>
3 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
4 note when trying to cancel the wizard. This fixes projects.maemo.org
7 2007-07-02 Murray Cumming <murrayc@murrayc.com>
9 * src/modest-tny-account.h:
10 * src/modest-tny-account.c:
11 (modest_tny_account_new_from_server_account),
12 (modest_tny_account_new_from_server_account_name),
13 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
14 because this must now be set before setting the proto. This is usd in
15 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
16 warning in camel_session_get_service() caused by
17 tny_camel_transport_account_prepare().
19 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
22 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
24 * src/maemo/modest-connection-specific-smtp-edit-window.c:
26 (modest_connection_specific_smtp_edit_window_init):
28 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
31 2007-06-29 Murray Cumming <murrayc@murrayc.com>
33 * src/modest-tny-account.c:
34 (modest_tny_account_new_from_server_account):
35 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
36 now uses to request a connection when it needs one, and which it uses
37 to tell us that something is wrong with the connection, so we can force
38 the accounts offline to prevent further problems.
41 * src/modest-init.c: (init_default_settings):
42 * src/modest-mail-operation.c:
43 (modest_mail_operation_update_account):
44 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
45 This should not be necessary anymore. Do not set the conf key that
46 determined this (it was always TRUE and not set anywhere else).
48 * src/modest-ui-actions.h: Remove unused and unimplemented
49 modest_ui_actions_on_online_toggle_toggled().
51 2007-06-29 Murray Cumming <murrayc@murrayc.com
53 * src/maemo/modest-main-window.c: (connect_signals):
54 Don't connect to delete_event twice. Maybe this was harmless.
56 2007-06-29 Murray Cumming <murrayc@murrayc.com
58 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
59 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
60 Debug output to give some more clue when a folder move is not allowed.
62 2007-06-28 Murray Cumming <murrayc@murrayc.com
64 * src/modest-tny-account.c: (on_modest_file_system_info),
65 (modest_tny_account_get_mmc_account_name):
66 Always call the callback, without checking whether the name has changed.
67 * src/widgets/modest-folder-view.c: (strings_are_equal),
68 (on_model_foreach_set_name), (on_get_mmc_account_name),
69 (text_cell_data): Compare the name here, and use the name from
70 the account rather than from the
71 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
72 if the name was changed after the account was added to the model.
73 That's a tinymail bug but not one that I want to fix now.
75 This finally fixes projects.maemo.org bug NB#59301.
77 2007-06-27 Armin Burgmeier <armin@openismus.com>
79 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
82 2007-06-27 Murray Cumming <murrayc@murrayc.com
84 * src/modest-tny-account.h:
85 * src/modest-tny-account.c:
86 Added modest_tny_account_get_mmc_account_name(), to set the memory
87 card name asynchronously for the given account and then notify.
88 (modest_tny_account_new_for_local_folders): Use this new function instead
89 of using hildon_file_system_info_async_new() directly.
91 * src/widgets/modest-folder-view.c: (text_cell_data):
92 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
93 gtk_tree_model_row_changed() when it is available.
95 This should fix projects.maemo.org bug NB#59301.
97 2007-06-27 Murray Cumming <murrayc@murrayc.com
99 * src/modest-mail-operation.c: (update_account_thread),
100 (get_msgs_full_thread): Fix typo failures in the revert
103 2007-06-27 Murray Cumming <murrayc@murrayc.com
105 * src/maemo/modest-maemo-global-settings-dialog.c:
106 (idle_select_default_focus):
107 * src/modest-mail-operation.c: (idle_notify_progress),
108 (idle_notify_progress_once), (set_last_updated_idle),
109 (update_account_thread), (get_msgs_full_thread):
110 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
111 * src/widgets/modest-header-view.c:
112 (idle_notify_headers_count_changed_destroy),
113 (idle_notify_headers_count_changed):
114 Reverted the additions of gdk_threads_enter/leave(), in case this
115 helps with a startup hang on the device.
117 2007-06-26 Armin Burgmeier <armin@openismus.com>
119 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
120 for supported secure authentication methods from server by
121 gtk_dialog_run(), saving CPU time and a potential race condition.
123 2007-06-26 Armin Burgmeier <armin@openismus.com>
125 * src/maemo/modest-maemo-utils.h:
126 * src/maemo/modest-maemo-utils.c: Added a
127 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
128 only error code to tell the calling code when the user canceled the
131 * src/maemo/modest-account-settings-dialog.h:
132 * src/maemo/modest-account-settings-dialog.c:
133 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
134 message if the retrieval of secure authentication methods was canceled
135 by the user. Perform the check before saving anything to configuration
136 to not end up with half-committed configuration changes, do not show
137 a "Saving to configuration failed" note when authentication methods
138 could not be retrieved.
140 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
143 2007-06-26 Murray Cumming <murrayc@murrayc.com>
145 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
146 Only return the first level of folders under accounts, because the
147 osso-global-search UI spec doesn't want the rest.
148 This fixed projects.maemo.org bug NB#61811.
150 2007-06-26 Murray Cumming <murrayc@murrayc.com>
152 * src/modest-tny-account-store.c:
153 * src/modest-tny-account-store.h:
154 Added modest_tny_account_is_memory_card_account().
155 * src/maemo/modest-main-window.c: (create_details_widget):
156 Show the same information items for the memory card as we show for the
157 local-folders, to fix projects.maemo.org bug NB#59307.
159 2007-06-26 Murray Cumming <murrayc@murrayc.com>
161 * src/modest-tny-account-store.c: (get_password):
162 Added some checks for NULL to maybe prevent crashes, though I think
163 it was Philip's last commit that actually prevented the crash here
164 when creating a first new account.
165 But the new account is still not usable (no messages are shown)
166 until a restart of the application.
168 2007-06-26 Murray Cumming <murrayc@murrayc.com>
170 * src/maemo/modest-maemo-global-settings-dialog.c:
171 (idle_select_default_focus):
172 * src/modest-mail-operation.c: (idle_notify_progress),
173 (idle_notify_progress_once), (idle_notify_update_account_queue),
174 (set_last_updated_idle), (update_account_thread),
175 (notify_get_msgs_full), (get_msgs_full_destroyer),
176 (get_msgs_full_thread):
177 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
178 * src/widgets/modest-header-view.c:
179 (idle_notify_headers_count_changed_destroy),
180 (idle_notify_headers_count_changed):
181 Use gdk_threads_enter() and gdk_threads_enter_leave() in
182 all idle handlers, because some other thread could be blocking
183 the GDK lock, so that it can do GUI stuff.
185 2007-06-26 Murray Cumming <murrayc@murrayc.com>
187 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
188 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
189 (on_idle_send_receive), (on_idle_open_default_inbox):
190 * src/maemo/modest-msg-edit-window.c:
191 (modest_msg_edit_window_attach_file_noninteractive):
192 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
193 to prevent a hang. I don't quite understand why these are necessary,
194 beause we should already be in the main loop. I guess something outside
195 of the main loop is taking the lock.
197 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
198 we are really using URIs, and use files that are more likely to exist.
200 2007-06-26 Murray Cumming <murrayc@murrayc.com>
202 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
203 necessary because configure.ac now defines different variables.
205 2007-06-26 Murray Cumming <murrayc@murrayc.com>
207 * libmodest-dbus-client/libmodest-dbus-client.c:
208 * libmodest-dbus-client/libmodest-dbus-client.h:
209 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
210 libmodest_dbus_client_compose_mail() is what things actually use.
212 * src/dbus_api/modest-dbus-api.h:
213 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
214 * tests/dbus_api/Makefile.am:
215 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
218 2007-06-26 Murray Cumming <murrayc@murrayc.com>
220 * src/modest-init.c: (modest_init_local_folders):
221 For memory-card (or other non local-folders) maildir accounts,
222 always create an Archive folder, so that there is somewhere to put
223 messages. This should be less confusing, because the user does not need
224 to guess that the need to create a folder.
226 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
228 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
229 Fixed icon size by using (50, 50) which is the same as defined by
232 2007-06-25 Armin Burgmeier <armin@openismus.com>
234 * src/widgets/modest-window-mgr.c:
236 * configure.ac: Correctly recognize hildon-notify presence and fixed
237 the build without it being installed.
239 2007-06-25 Murray Cumming <murrayc@murrayc.com>
241 * libmodest-dbus-client/libmodest-dbus-client.c:
242 (libmodest_dbus_client_search): Fix the build. Sorry.
243 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
244 (reply_forward_cb): Initialize variables to fix the build.
246 * src/modest-tny-account-store.c:
247 (modest_tny_account_store_get_tny_account_by): Fix the account URI
248 comparison (a silly typo) so that email search results can be opened
249 when there are more than one account.
251 2007-06-25 Murray Cumming <murrayc@murrayc.com>
253 * libmodest-dbus-client/libmodest-dbus-client.c:
254 (libmodest_dbus_client_search),
255 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
256 instead of 1 second, because the search gets folders and messages from
257 the server, which can take a long time. When it times out,
258 osso-global-search will report no results.
260 We need to specify whether we should search only cached information
261 (maybe with a user preference), and the osso-email-search-plugin
262 API should really be improved to allow that option, and to allow results
263 to be delivered asynchronously in batches.
265 2007-06-25 Murray Cumming <murrayc@murrayc.com>
267 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
268 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
269 GTK_ICON_SIZE_DIALOG is probably the wrong size.
271 2007-06-25 Murray Cumming <murrayc@murrayc.com>
273 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
274 that is an empty string. D-Bus seems to give us these instead of NULL.
276 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
278 * src/dbus_api/modest-dbus-callbacks.c:
279 * src/maemo/easysetup/modest-easysetup-wizard.h:
280 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
281 * src/maemo/modest-connection-specific-smtp-edit-window.c:
282 (modest_connection_specific_smtp_edit_window_init):
283 * src/maemo/modest-maemo-global-settings-dialog.c:
285 * src/maemo/modest-maemo-utils.c:
286 (modest_maemo_utils_setup_images_filechooser):
287 * src/maemo/modest-main-window.c: (create_details_widget):
288 * src/maemo/modest-msg-edit-window.c:
289 (modest_msg_edit_window_attach_file_noninteractive),
290 (modest_msg_edit_window_color_button_change),
291 (modest_msg_edit_window_set_zoom):
292 * src/modest-mail-operation.c: (update_account_thread):
293 * src/modest-tny-account-store.c:
294 * src/modest-tny-account.c:
295 * src/widgets/modest-global-settings-dialog.c:
296 * src/widgets/modest-window.h:
300 2007-06-25 Murray Cumming <murrayc@murrayc.com>
302 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
303 * src/modest-search.c: (modest_search_folder),
304 (modest_search_all_accounts): Actually search only in the specified folder,
305 doing a simple match on the folder ID.
306 * src/modest-search.h: Added a folder field to the ModestSearch struct,
307 and added some documentation.
309 2007-06-22 Armin Burgmeier <armin@openismus.com>
311 * src/maemo/modest-maemo-utils.h:
312 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
313 modest_maemo_utils_get_supported_secure_authentication_methods.
315 * src/maemo/easysetup/modest-easysetup-wizard.c:
316 * src/maemo/modest-account-settings-dialog.c: Show correct error if
317 one occured, not just "Server does not support secure authentication".
319 2007-06-22 Murray Cumming <murrayc@murrayc.com>
321 * src/modest-tny-account-store.c: (get_password):
322 Restored the call to tny_account_set_user() because Philip seems to have
323 stopped this from crashing (by not using the freed string). It still does
324 not work, but now we can test it.
326 2007-06-22 Murray Cumming <murrayc@murrayc.com>
328 * src/maemo/modest-msg-edit-window.c: (init_window):
329 Comment out use of an uninitialzed GtkScrolledWindow variable,
330 to fix the build and stop a crash. Yet again.
332 2007-06-22 Murray Cumming <murrayc@murrayc.com>
334 * src/modest-tny-account-store.c: (get_password):
335 Remove the call to tny_account_set_user() because this actually crashes.
336 As mentioned in the last commit, it is known to not work anyway.
338 2007-06-22 Murray Cumming <murrayc@murrayc.com>
340 * src/modest-tny-account-store.c: (get_password):
341 Use tny_account_set_username() to tell tinymail that the username might
342 have changed too. But tinymail ignores this: see projects.maemo.org
344 * src/modest-ui-actions.c:
345 (modest_ui_actions_on_password_requested): Remove the useless attempt to
346 reset the connection when changing the username, and improve the comments.
347 Save the changed username to gconf at least, so it is used when Modest is
350 2007-06-21 Murray Cumming <murrayc@murrayc.com>
352 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
353 Do not use a query, so that we get all folders, including for POP and
354 local-folders. They work as search criteria too.
355 This fixes projects.maemo.org bug NB#57740.
357 2007-06-21 Murray Cumming <murrayc@murrayc.com>
359 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
360 Comment out the use of hildon_notification_set_sound() because it is
361 not declared, to fix the build. Warnings are serious, people.
363 2007-06-21 Armin Burgmeier <armin@openismus.com>
365 * src/maemo/modest-maemo-utils.h:
366 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
367 modest_maemo_utils_get_supported_secure_authentication_methods()
368 to query authentication methods for a specific user. This should fix
369 projects.maemo.org bug NB#61369.
371 * src/maemo/easysetup/modest-easysetup-wizard.c:
372 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
375 2007-06-21 Murray Cumming <murrayc@murrayc.com>
377 * libmodest-dbus-client/libmodest-dbus-client.h:
378 * libmodest-dbus-client/libmodest-dbus-client.c:
379 (modest_dbus_message_iter_get_search_hit),
380 (libmodest_dbus_client_search):
381 Reorganised and commented this.
382 Removed modest_search_hit_free() from the public API because it
385 Added libmodest_dbus_client_get_folders() and
386 modest_folder_result_list_free().
388 * src/dbus_api/modest-dbus-api.h:
389 * src/dbus_api/modest-dbus-callbacks.c:
390 (modest_dbus_req_filter): Commented. Moved most code to
391 on_dbus_method_search() and added on_dbus_method_get_folders().
393 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
394 of the extra D-Bus handler.
396 * tests/dbus_api/Makefile.am:
397 * tests/dbus_api/test_get_folders.c: New test for
398 libmodest_dbus_client_get_folders(). This seems to return an empty list
399 at the moment. That could be the same error that causes the message list
400 to be empty sometimes.
401 This should help with projects.maemo.org bug NB#57740.
403 2007-06-21 Armin Burgmeier <armin@openismus.com>
405 * src/modest-mail-operation.c: Do not call
406 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
407 notify the operation's end after having set the status to CANCELED for
408 the operation queue to listen on. This fixes a deadlock when there
409 were mail operations in the queue during its finalization.
411 * src/modest-singletons.c: Reordered uninitialization of the account
412 manager to happen after the mail operation queue was uninitialized
413 because the mail operation's in the queue might still try to access
414 the account manager (see modest_mail_operation_notify_end()). This
415 fixes a potential crash when terminating the application.
417 2007-06-21 Murray Cumming <murrayc@murrayc.com>
419 * src/modest-search.c:
420 (search_mime_part_and_child_parts): Moved some code here so we
421 can search recursively in child folders.
422 (modest_search_folder): Search in the message as a mime part, instead
423 of just its child mime parts.
424 (read_chunk), (search_mime_part_ogs):
425 Check how many bytes were read, to prevent an endless loop.
426 Searching in message bodies now works. This finishes the fix for
427 projects.maemo.org bug NB#61007.
429 2007-06-20 Murray Cumming <murrayc@murrayc.com>
431 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
432 Add a g_warning when the item is not a folder.
434 * src/modest-ui-dimming-rules.c:
435 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
436 when selected item is not a folder (for instance, an account), because
437 the UI spec only talks about folders.
438 I am not sure what the UI spec wants, so this might not totally fix
439 projects.maemo.org bug NB#60794.
441 2007-06-20 Murray Cumming <murrayc@murrayc.com>
443 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
444 (load_from_file): Sort the list. The unsorted list would be more noticeable
445 in non-English locales.
447 * src/maemo/modest-msg-edit-window.c:
448 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
449 warning and fix the build.
451 * src/maemo/modest-progress-bar-widget.c:
452 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
453 avoid a g_warning, and probably to avoid a crash.
455 2007-06-20 Murray Cumming <murrayc@murrayc.com>
457 * src/modest-search.c: (modest_search_folder): Check for a GError
458 when calling tny_folder_get_headers(), to show that this is not the cause
461 2007-06-20 Murray Cumming <murrayc@murrayc.com>
463 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
464 Actually set the body query instead of the subject query.
466 * src/modest-search.c: (search_mime_part_ogs),
467 (search_mime_part_strcmp): Remove extra space from the text/* regex,
468 which would probably cause it to fail if we got this far.
470 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
471 to simplify the code.
472 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
473 be causing search-in-body to fail.
475 2007-06-20 Murray Cumming <murrayc@murrayc.com>
477 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
479 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
480 Better debug message when the folder cannot be found.
481 This should help with fixing projects.maemo.org bug #61287.
482 * src/modest-search.c: (add_hit): Do not leak the furl string.
484 2007-06-20 Murray Cumming <murrayc@murrayc.com>
486 * src/modest-ui-actions.c:
487 (modest_ui_actions_on_folder_selection_changed):
488 Do not special-case TNY_MERGE_FOLDER here, because
489 modest_tny_folder_get_account() already does that. This fixes
490 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
491 shown when the Outbox was selected).
493 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
495 * libmodest-dbus-client/libmodest-dbus-client.c:
496 (_dbus_iter_get_string_or_null): Initialize the string variable in
497 case this helps with Dirk's crash.
499 2007-06-19 Murray Cumming <murrayc@murrayc.com>
501 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
502 though it is not implemented yet (this function is maybe not even used),
503 to avoid breaking ABI in future.
504 * libmodest-dbus-client/libmodest-dbus-client.c:
505 (get_attachments_string): Moved some code into this generic function.
506 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
507 sends email. It is maybe not used.
508 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
509 (on_send_mail): Use attachments.
511 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
512 * src/maemo/modest-msg-edit-window.c:
513 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
514 a filename before using it, to fix projects.maemo.org bug NB#58233.
516 2007-06-19 Murray Cumming <murrayc@murrayc.com>
518 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
519 Initialize the continue_download variable to fix the build, and probably
520 to fix randome behaviour.
522 2007-06-18 Armin Burgmeier <armin@openismus.com>
524 * src/modest-tny-send-queue.h:
525 * src/modest-tny-send-queue.c: Keep track of the status of messages in
526 the queue so we can later show it in the UI. Replaced
527 modest_tny_send_queue_msg_is_being_sent() by
528 modest_tny_send_queue_get_msg_status().
530 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
532 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
533 gpointer. This probably was not harmful, but just to be sure.
535 2007-06-18 Murray Cumming <murrayc@murrayc.com>
537 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
538 Fix the build, but leave the function broken on Bora, because
539 hildon_uri_action_get_service() does not exist.
540 osso_uri_action_get_service() does not exist either, it seems.
542 2007-06-18 Murray Cumming <murrayc@murrayc.com>
544 * src/modest-tny-account.c:
545 (modest_tny_account_new_from_server_account):
546 Uncommented the url debug output again, because it is useful for
547 debugging, as I said in the comment.
549 2007-06-18 Murray Cumming <murrayc@murrayc.com>
551 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
553 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
554 for Mameo Bora, to fix the build.
556 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
559 Fixed build with hildon < 0.99
561 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
562 Check if the selected account is busy instead of checking all accounts
564 * src/modest-account-mgr-priv.h:
565 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
566 (modest_account_mgr_init), (compare_account_name),
567 (modest_account_mgr_set_account_busy),
568 (modest_account_mgr_account_is_busy):
569 * src/modest-account-mgr.h:
570 Added busy information to the account manager. It possible to
571 set an account to busy or not busy now.
573 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
574 (modest_mail_operation_update_account),
575 (modest_mail_operation_notify_end):
576 Set the account to busy/not busy depending on the operation state.
578 * src/widgets/modest-account-view.c:
579 (modest_account_view_finalize), (get_last_updated_string),
580 (update_account_view), (on_account_busy_changed), (init_view):
581 Show string "Refreshing..." if the account is currently busy.
583 All this fixes projects.maemo.org bug NB#59711
585 2007-06-14 Armin Burgmeier <armin@openismus.com>
587 * src/widgets/modest-attachments-view.h:
588 * src/widgets/modest-attachments-view.c: Added
589 modest_attachments_view_has_attachments() and fixed coordinate
590 transformation in get_att_view_at_coords(). This fixes attachment
593 * src/widgets/modest-msg-view.c: Make use of
594 modest_attachments_view_has_attachments() to decide whether to show
595 attachments in the header.
597 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
599 * src/maemo/modest-connection-specific-smtp-edit-window.c:
600 (on_change), (on_combo_security_changed),
601 (modest_connection_specific_smtp_edit_window_init),
602 (modest_connection_specific_smtp_edit_window_set_connection),
603 (modest_connection_specific_smtp_edit_window_is_dirty):
604 * src/maemo/modest-connection-specific-smtp-edit-window.h:
605 * src/maemo/modest-connection-specific-smtp-window.c:
608 Show an comfirmation dialog for the smpt-edit-window if there are
609 unsaved changes and the user hits cancel.
610 (projects.maemo.org bug NB#60479)
612 2007-06-14 Armin Burgmeier <armin@openismus.com>
614 * src/maemo/easysetup/modest-easysetup-wizard.c:
615 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
616 address" info in banner instead of node, and select all the text as
617 per UI spec. This fixes projects.maemo.org bug NB#60550.
619 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
621 reviewed by: <delete if not using a buddy>
623 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
624 * src/modest-ui-actions.c: (folder_refreshed_cb):
626 2007-06-14 Murray Cumming <murrayc@murrayc.com>
628 * src/widgets/modest-folder-view.c: (filter_row):
629 Explictly filter out the per-account outbox accounts. I don't know why
630 these only sometimes show up, but now they should never show up in the UI.
631 This should fix projects.maemo.org bug NB#60160.
633 2007-06-14 Murray Cumming <murrayc@murrayc.com>
635 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
636 when the toolbar does not exist yet.
637 * src/modest-widget-memory.c: (save_settings_header_view):
638 Added g_warnings() to help us to discover when we are trying to set
639 an empty columns list in gconf.
641 2007-06-14 Murray Cumming <murrayc@murrayc.com>
645 Added modest_init_get_default_header_view_column_ids().
647 * src/modest-widget-memory.c: (restore_settings_header_view):
648 Use the new function to get defaults, if the gconf key is empty,
649 instead of not creating any columns. This seems to fix the
650 empty right-hand pane problems.
652 * src/widgets/modest-header-view.h: Improved documentation.
654 2007-06-13 Murray Cumming <murrayc@murrayc.com>
656 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
657 Revert the use of the display name as the account name, because this
658 is generally wrong and would break the code that follows.
660 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
662 * src/maemo/easysetup/modest-easysetup-wizard.c:
663 (check_for_supported_auth_methods), (on_before_next),
666 More correct fix for projects.maemo.org bug NB# 58991
667 Do not longer accept AUTH_PASSWORD as secure method and choose
668 correct method when creating the account.
670 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
672 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
673 Fixed projects.maemo.org bug NB# 58991
675 2007-06-13 Murray Cumming <murrayc@murrayc.com>
677 * src/modest-init.c: (modest_init_init_core),
678 (modest_init_local_folders): Fixed compilation errors.
680 2007-06-13 Murray Cumming <murrayc@murrayc.com>
682 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
683 Remove unnecessary lib/include, though it is good in principle when needed.
685 * src/modest-init.c: (modest_init_one_local_folder),
686 (modest_init_local_folders):
687 * src/modest-init.h: Initialize the .modest library for memory cards,
688 instead of just doing nothing for them. This should allow us to create
689 folders there, fixing projects.maemo.org bug NB#59297.
691 2007-06-13 Murray Cumming <murrayc@murrayc.com>
693 * libmodest-dbus-client/libmodest-dbus-client.c:
694 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
695 (libmodest_dbus_client_compose_mail),
696 (libmodest_dbus_client_open_message),
697 (libmodest_dbus_client_send_and_receive),
698 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
700 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
701 (on_idle_open_message), (modest_dbus_req_handler),
702 (search_result_to_message), (modest_dbus_req_filter):
703 * src/modest-search.c: (add_hit), (modest_search_folder),
704 (modest_search_all_accounts): Improved debug messages.
706 * tests/dbus_api/test_open_message.c: (main): Improved comments.
708 * src/modest-tny-account-store.c:
709 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
712 2007-06-13 Murray Cumming <murrayc@murrayc.com>
715 2007-06-12 Murray Cumming <murrayc@murrayc.com>
717 * src/modest-tny-account-store.c: (get_server_accounts):
718 Call modest_tny_local_folders_account_add_merged_outbox_folders()
719 even when there are no accounts, so that the Outbox folder is always
720 visible. This fixes projects.maemo.org bug NB#60158.
722 2007-06-12 Murray Cumming <murrayc@murrayc.com>
724 * src/maemo/modest-main-window.c: (create_details_widget):
725 Use the mcen_va_never logical ID.
727 2007-06-12 Murray Cumming <murrayc@murrayc.com>
729 * src/dbus_api/modest-dbus-api.h:
730 * src/dbus_api/modest-dbus-callbacks.c:
731 (on_idle_open_default_inbox), (on_open_default_inbox),
732 (modest_dbus_req_handler):
733 Added a new OpenDefaultInbox method.
735 * libmodest-dbus-client/libmodest-dbus-client.h:
736 * libmodest-dbus-client/libmodest-dbus-client.c:
737 Added libmodest_dbus_client_open_default_inbox() to call the new
738 dbus method. This should be useful to projects.maemo.org bug NB#57214,
739 though it should maybe be used by a new osso-email-interface function.
741 * tests/dbus_api/Makefile.am:
742 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
745 2007-06-12 Murray Cumming <murrayc@murrayc.com>
747 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
748 NULL, so that the signals get all the keys. This should not actually
749 change any behaviour because we currently update everything when anything
752 2007-06-12 Murray Cumming <murrayc@murrayc.com>
754 * src/widgets/modest-folder-view.c: (text_cell_data),
755 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
756 (find_inbox_iter): If tinymail tells us that the folder is
757 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
758 This causes the inbox to be selected at startup, fixing part of
759 projects.maemo.org bug NB#56305.
761 * src/modest-ui-dimming-rules.c:
762 (modest_ui_dimming_rules_on_tools_smtp_servers):
763 * src/modest-ui-dimming-rules.h: Added a callback function to dim
764 the SMTP servers menu item.
765 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
766 that the SMTP Servers menu item is dimmed when there are no accounts,
767 as a future version of the UI spec will require. This fixes
768 projects.maemo.org bug NB#56305.
770 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
772 * src/maemo/modest-maemo-utils.c:
773 (modest_maemo_utils_get_supported_secure_authentication_methods):
774 Added label to dialog instead of unreadable title
776 * src/maemo/modest-main-window.c: (sync_accounts_cb),
777 (modest_main_window_new):
778 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
781 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
782 * src/modest-account-mgr.h:
783 Added method to avoid code duplication
785 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
786 (modest_ui_actions_on_send_receive):
787 Use modest_account_mgr_has_accounts
789 2007-06-11 Murray Cumming <murrayc@murrayc.com>
791 * src/maemo/easysetup/modest-presets.c:
792 (modest_presets_get_info_server_security): Do not report secure auth
794 * src/modest-protocol-info.c: Use the defines for the gconf key names
795 for secure authentication. This was not working because we were writing
796 Password and reading password, and the check was case sensitive.
797 With this, gmail now works for receiving and sending when created via
800 2007-06-11 Murray Cumming <murrayc@murrayc.com>
802 * src/maemo/easysetup/modest-presets.c:
803 (modest_presets_get_info_server_security): Correct the key name for
804 SecureSmtp, because it seems to be case-sensitive.
805 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
806 Do not try to get the 0th notebook page if there are 0 pages, to
809 2007-06-11 Murray Cumming <murrayc@murrayc.com>
811 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
812 Prevent use of the new notification feature for now, because it currently
813 shows one dialog for each new email, which is annoying.
815 2007-06-11 Murray Cumming <murrayc@murrayc.com>
817 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
818 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
819 when no country was selected, so that we show the global ones.
820 * src/maemo/easysetup/modest-presets.c:
821 (modest_presets_get_providers): Return only the global providers, not
822 all providers when mmc=0 was requested.
824 2007-06-11 Murray Cumming <murrayc@murrayc.com>
826 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
827 (easysetup_provider_combo_box_fill): Remove debug code that showed the
828 provider ID in the combo.
830 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
831 Do not show the page numbers, because it would be confusing when we add
832 the 2 extra pages for the custom setup, when the user chooses the "Other"
833 provider. This fixes projects.maemo.org bug NB#59028
835 * src/modest-init.c: (modest_init_init_core),
836 (modest_init_local_folders):
838 * src/modest-tny-account.c:
839 (modest_tny_account_new_for_local_folders): Do not create default folders
840 for the memory card. This should fix projects.maemo.org bug NB#59328.
842 2007-06-11 Murray Cumming <murrayc@murrayc.com>
844 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
845 Free the changed_conf_keys string items. They are already freed in the
846 idle handler if that runs first.
848 2007-06-11 Murray Cumming <murrayc@murrayc.com>
850 * src/modest-ui-actions.c:
851 (modest_ui_actions_on_password_requested): Check that the server name
852 is not NULL, because I just saw a password dialog with (null) as the
855 * src/modest-tny-folder.[h|c]: Added
856 modest_tny_folder_is_memory_card_folder().
857 * src/modest-ui-dimming-rules.c:
858 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
859 menu item for memory cards, as per the UI spec (section 7.4). This should
860 fix projects.maemo.org bug NB#59297.
862 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
864 * src/maemo/modest-main-window.c: (sync_accounts_cb):
865 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
866 is another problem with the code, see Murray's comment at line 772)
868 2007-06-08 Murray Cumming <murrayc@murrayc.com>
870 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
871 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
872 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
873 (load_from_file), (easysetup_country_combo_box_init),
874 (easysetup_country_combo_box_get_active_country_ids),
875 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
876 instead of just one ID, to avoid duplicate country names in the UI.
878 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
879 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
880 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
881 a single ID, avoiding duplicate providers.
882 * src/maemo/easysetup/modest-easysetup-wizard.c:
883 (on_combo_account_country): Adapt to use a list.
885 2007-06-08 Murray Cumming <murrayc@murrayc.com>
887 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
888 keys changed in the last X seconds.
890 * src/modest-account-mgr.h:
891 * src/modest-account-mgr.c: (on_timeout_notify_changes),
892 (on_key_change), (modest_account_mgr_class_init),
893 (modest_account_mgr_init), (modest_account_mgr_finalize):
894 As the keys are changed, save them in a GSList* and signal that GSList*
895 further every X seconds, to batch changes, to allow us to do just one
896 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
897 bug NB#56941 and other (UI-blocking) delays when changing account settings.
899 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
900 changed signal signature.
902 * src/modest-conf.c: (modest_conf_set_list),
903 (modest_conf_on_change): Reenable notification.
905 (modest_conf_maemo_fake_on_change): Comment out the hack that
906 notified immediately instead of asynchronously.
908 * src/widgets/modest-account-view.h:
909 * src/widgets/modest-account-view.c:
910 (update_account_view): Select the previously-selected account ID,
911 if possible. This fixes projects.maemo.org bug NB#56933.
913 (on_account_changed), (on_account_removed),
914 (modest_account_view_select_account):
916 Remove the block/unblock functions
917 because they were not useful.
919 * src/maemo/modest-account-view-window.c:
920 (on_delete_button_clicked), (on_edit_button_clicked),
921 (on_new_button_clicked): Remove the use of the non-working block/unblock.
923 2007-06-08 Murray Cumming <murrayc@murrayc.com>
925 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
926 Improve the error dialog to show Incorrect Account Settings, which seems
927 clearer, and say that the internal error message (to be removed from the
928 dialog later) is often misleading.
929 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
931 * src/modest-tny-account.c:
932 (modest_tny_account_new_from_server_account): Uncomment the printf of the
933 URL because this is so useful for debugging on the device.
935 * src/widgets/modest-serversecurity-combo-box.c:
936 (modest_serversecurity_combo_box_fill): Correct a logical ID.
938 2007-06-08 Murray Cumming <murrayc@murrayc.com>
940 * src/modest-mail-operation.c:
941 (modest_mail_operation_send_new_mail):
942 Added a comment about a nasty but apparently harmless message. Details
943 added to the wiki g_warnings() page.
945 2007-06-08 Murray Cumming <murrayc@murrayc.com>
947 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
948 (modest_tny_send_queue_class_init):
949 Do not use the priv struct because it is empty, to avoid g_warnings
950 about a non-existant priv struct.
952 * src/modest-tny-account-store.c:
953 (modest_tny_account_store_get_server_account),
954 (modest_tny_account_store_get_transport_account_for_open_connection
955 ): Do not try to get transport server accounts for local folders,
956 because they don't have any. This avoids a g_warning().
958 * src/maemo/modest-main-window.c:
959 (modest_main_window_notify_send_receive_initied),
960 (on_configuration_key_changed):
961 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
963 * src/modest-mail-operation.c:
964 (modest_mail_operation_update_account):
965 * src/modest-tny-account-store.h:
966 * src/modest-tny-account.c:
967 (modest_tny_account_get_special_folder),
968 (modest_tny_account_new_for_local_folders),
969 (modest_tny_account_new_for_per_account_local_outbox_folder):
970 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
971 * src/modest-tny-local-folders-account.c:
972 (add_account_folders_to_merged_folder):
973 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
974 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
975 (modest_ui_actions_on_send):
976 * src/widgets/modest-folder-view.c: (update_model):
977 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
978 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
979 modest_tny_account_store_get_tny_account_by_account() to
980 modest_tny_account_store_get_server_account() to make the code clearer.
982 2007-06-07 Marcus Bauer <marcusb@openismus.com>
984 * src/dbus_api/modest-dbus-api.h:
985 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
986 * src/maemo/modest-msg-edit-window.c:
987 (modest_msg_edit_window_attach_file_noninteractive):
988 added g_warning in case the file to be attached does not exist
989 * tests/dbus_api/test_compose_mail.c: (main):
990 removed obsolete comment, added generic files as test case
992 2007-06-07 Murray Cumming <murrayc@murrayc.com>
994 * src/modest-tny-account-store.c: (get_server_accounts):
995 Create the local folders account only once, not once for each outbox, and
996 not only when there are some outboxes.
998 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1000 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1001 code that is causing a crash at startup. Sergio says that he is fixing this.
1003 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1005 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1006 * src/maemo/modest-account-settings-dialog.c:
1007 (create_page_outgoing),
1008 (modest_account_settings_dialog_set_account_name),
1009 (save_configuration):
1010 - Fixed handling of the "Use secure authentication" toggle to comply with
1011 the ui specification. See also projects.maemo.org bug NB#58400
1013 - Restore the Secure connection setting combo correctly when loading
1016 * src/maemo/modest-maemo-utils.c:
1017 (on_camel_account_get_supported_secure_authentication),
1018 (modest_maemo_utils_get_supported_secure_authentication_methods):
1019 Fixed a crasher if operation is canceled
1021 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1022 (modest_protocol_info_auth_is_secure):
1023 * src/modest-protocol-info.h:
1025 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1026 the sense of the "Use secure authentication" toggle.
1028 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1030 * src/modest-tny-account-store.h:
1031 * src/modest-tny-account-store.c:
1032 Added modest_tny_account_store_get_local_folders_account().
1034 * src/modest-tny-folder.h:
1035 * src/modest-tny-folder.c:
1036 (modest_tny_folder_get_account):
1037 Added this replacement for tny_folder_get_account() which returns
1038 the local-folders account for TnyMergeFolders, to avoid the
1039 warning about the unimplemented get_account_func() vfunc().
1041 (modest_tny_folder_get_rules),
1042 * src/modest-ui-actions.c:
1043 (modest_ui_actions_on_folder_selection_changed):
1044 * src/modest-mail-operation.c:
1045 (modest_mail_operation_remove_folder),
1046 (modest_mail_operation_xfer_folder),
1047 (modest_mail_operation_rename_folder),
1048 (modest_mail_operation_get_msg),
1049 (modest_mail_operation_get_msgs_full),
1050 (modest_mail_operation_remove_msg),
1051 (modest_mail_operation_xfer_msgs),
1052 (modest_mail_operation_refresh_folder):
1053 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1055 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1057 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1058 (modest_server_account_set_security):
1059 * src/modest-defs.h: Add comments explaining that our
1060 UI spec means TLS when it says Normal, so these do not look like errors.
1062 * src/modest-tny-account.c:
1063 (modest_tny_account_new_from_server_account): Use the new tinymail
1064 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1065 for TLS. This should fix projects.maemo.org bug NB#58460.
1067 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1069 * src/maemo/easysetup/modest-easysetup-wizard.c:
1070 (create_account): Correct the position of the gconf sanity check warning.
1071 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1072 of using the g_idle_add() hack, because this does not seem to be necessary
1073 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1074 caused by something other than maemo's gconf.
1075 This fixes projects.maemo.org bug #59022.
1077 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1079 * src/modest-account-mgr-helpers.c:
1080 (modest_account_mgr_get_default_account): Do not check that the account
1081 exists if there is no default account (NULL), to fix a runtime warning.
1083 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1085 * src/widgets/modest-folder-view.c: (update_model):
1086 Do not unref the treemodel before we have finished with it.
1087 This prevents a valgrind warning and an occasional crash at startup.
1089 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1091 * libmodest-dbus-client/libmodest-dbus-client.h:
1092 added libmodest_dbus_client_compose_mail()
1093 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1095 added functions needed for SendAsMail() functionality
1096 * src/maemo/modest-msg-edit-window.c:
1097 (modest_msg_edit_window_attach_file_noninteractive):
1098 non interactively attaching files to message edit window
1099 * src/widgets/modest-msg-edit-window.h:
1100 * tests/dbus_api/Makefile.am:
1101 added test_compose_mail.c
1102 * tests/dbus_api/test_compose_mail.c: (main):
1104 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1106 * src/modest-account-view.c:
1107 Fixed bug projects.maemo.org bug NB#59307
1109 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1111 * src/maemo/easysetup/modest-easysetup-wizard.c:
1112 (get_serverport_incoming), (on_before_next), (create_account):
1113 * src/maemo/modest-account-settings-dialog.c:
1114 (modest_account_settings_dialog_set_account_name):
1115 * src/maemo/modest-maemo-utils.c:
1116 (on_camel_account_get_supported_secure_authentication_status),
1117 (on_camel_account_get_supported_secure_authentication),
1118 (on_secure_auth_cancel),
1119 (modest_maemo_utils_get_supported_secure_authentication_methods):
1121 Implemented security authentication for settings and easysetup.
1123 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1125 * src/maemo/modest-main-window.c: (create_details_widget):
1126 Show the total size for memory card accounts too, instead of showing
1127 the name again. Fixes bug projects.maemo.org bug NB#59307.
1129 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1132 * src/modest-tny-simple-folder-store.c:
1133 * src/modest-tny-simple-folder-store.h: Removed.
1135 * src/modest-tny-local-folders-account.h
1136 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1137 for the local-folders maildir, with an extra TnyMergedFolder containing
1138 the folders of the per-account outbox store accounts.
1139 * src/modest-tny-account-store.c: (get_server_accounts):
1140 Add the outboxes to the special local folders account after creating it.
1142 * src/modest-tny-account.c:
1143 (modest_tny_account_new_for_local_folders): Create the derived
1144 account when creating the main local-folders account.
1146 * src/maemo/modest-main-window.c: (create_details_widget),
1147 (modest_main_window_set_contents_style):
1148 Adapted to the use of the derived account instead of the folder store.
1150 * src/modest-ui-actions.c:
1151 (modest_ui_actions_on_folder_selection_changed):
1152 * src/modest-ui-dimming-rules.c:
1153 (modest_ui_dimming_rules_on_new_folder):
1154 * src/widgets/modest-folder-view.c: (text_cell_data),
1155 (icon_cell_data), (filter_row), (update_model),
1156 (get_cmp_rows_type_pos):
1159 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1160 Do not get the priv struct, because no priv struct has been set,
1161 to avoid a runtime warning.
1163 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1164 #ifelse with #else, to fix a warning, to fix the build.
1167 2007-06-05 Christian Kellner <ckellner@openismus.com>
1169 * libmodest-dbus-client/libmodest-dbus-client.c:
1170 Fix small typo in doc (why do you always see them
1171 AFTER committing stuff?)
1174 2007-06-05 Christian Kellner <ckellner@openismus.com>
1176 * libmodest-dbus-client/libmodest-dbus-client.c:
1177 (libmodest_dbus_client_search):
1178 Initialize hit list with NULL. Also set folder list
1179 to "" if NULL was supplied.
1182 2007-06-03 Christian Kellner <ckellner@openismus.com>
1184 * libmodest-dbus-client/libmodest-dbus-client.c:
1185 (modest_search_hit_list_free):
1186 Make it save to call it with NULL.
1188 * src/dbus_api/modest-dbus-callbacks.c:
1189 * src/modest-search.c:
1190 Return full ModestSearchHits as the search result list not TnyHeader
1191 since can't be around withouth the correspoding TnyFolder.
1193 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1195 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1196 Added currently commented code to check for secure auth
1198 * src/maemo/modest-account-settings-dialog.c: (on_response),
1199 (save_configuration), (show_ok):
1200 Fixed projects.maemo.org bugs NB #59248 and #59251
1202 * src/maemo/modest-maemo-utils.c:
1203 (on_camel_account_get_supported_secure_authentication_status),
1204 (on_camel_account_get_supported_secure_authentication),
1205 (modest_maemo_utils_get_supported_secure_authentication_methods):
1206 * src/maemo/modest-maemo-utils.h:
1207 Moved get_supported_secure_authentication() method here to be able
1208 to use it from easysetup wizard.
1210 * src/modest-pair.c: (on_pair_compare_as_string):
1211 Should compare string with first part of pair and not
1212 strcmp pairs which will crash.
1214 * src/modest-protocol-info.c:
1215 (modest_protocol_info_protocol_is_store):
1216 * src/modest-protocol-info.h:
1217 Added modest_protocol_info_get_auth_protocol_name()
1219 2007-06-03 Armin Burgmeier <armin@openismus.com>
1221 * src/modest-mail-operation.c:
1222 (modest_mail_operation_get_msgs_full): Set priv->account also when
1223 only retrieving a single message. This avoids a crash when canceling
1226 (modest_mail_operation_notify_end): Do not explicitely remove the
1227 operation from the queue but only emit the progress_changed signal.
1228 The queue itself listens to that signal to remove the operation when
1229 it is finished. This reduces coupling and removes a potential deadlock
1230 when modest_mail_operation_notify_end() is called from the queue
1231 itself. If that is a problem performance-wise, I would suggest to
1232 implement a status-changed signal or something.
1234 * src/modest-mail-operation-queue.c: Make sure to never call a
1235 function from another file while the queue is locked. This (hopefully)
1236 fixes another deadlock when exiting the application while retrieving
1239 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1241 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1242 Fixed build if libogs is not available
1244 2007-06-03 Christian Kellner <ckellner@openismus.com>
1246 * libmodest-dbus-client/libmodest-dbus-client.h:
1247 * libmodest-dbus-client/libmodest-dbus-client.c:
1248 (libmodest_dbus_client_delete_message):
1249 Implement deletion of messages (Client side).
1251 (modest_search_hit_free),
1252 (modest_search_hit_list_free):
1253 Utility functions to free the result hits.
1255 * src/dbus_api/modest-dbus-api.h:
1256 * src/dbus_api/modest-dbus-callbacks.c:
1257 (on_delete_message),
1258 (modest_dbus_req_handler):
1259 Implement deletion of messages (Server side).
1261 * tests/dbus_api/test_search.c: (main):
1264 * tests/dbus_api/Makefile.am:
1265 * tests/dbus_api/test_delete_message:
1266 Add little test for the message deletion logic
1268 2007-06-03 Armin Burgmeier <armin@openismus.com>
1270 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1271 when the operation queue was not empty. projects.maemo.org bug
1274 2007-06-03 Armin Burgmeier <armin@openismus.com>
1276 * src/widgets/modest-account-view.c
1277 (on_account_default_toggled): Toggle default account column
1278 explicitely instead of waiting for gconf notification (which is
1279 currently ignored). This should fix projects.maemo.org bug NB#56910
1280 for now. It should probably be removed when gconf notifications are
1283 2007-06-03 Christian Kellner <ckellner@openismus.com>
1285 * libmodest-dbus-client/libmodest-dbus-client.c:
1286 Removed debugging spew.
1288 * src/dbus_api/modest-dbus-callbacks.c:
1289 Added debugging info.
1291 * src/modest-search.c:
1292 (modest_search_all_accounts):
1293 Use tny_account_store_get_accounts () on the account store
1294 to get all accounts which is the way to get all accounts.
1296 * tests/dbus_api/test_search.c: (main):
1297 Make it possible to supply the search term on the command line.
1299 2007-06-03 Christian Kellner <ckellner@openismus.com>
1301 * libmodest-dbus-client/libmodest-dbus-client.c:
1302 * libmodest-dbus-client/libmodest-dbus-client.h:
1303 Implement searching for mesages over raw dbus. (Client side)
1305 * src/dbus_api/Makefile.am:
1306 * src/dbus_api/modest-dbus-api.h:
1307 * src/dbus_api/modest-dbus-callbacks.c:
1308 * src/dbus_api/modest-dbus-callbacks.h:
1309 Search framework (Server side). Also implement on_idle_open_message().
1311 * src/maemo/modest-platform.c: (modest_platform_init):
1312 Prepare for raw dbus/osso rpc interaction.
1314 * src/modest-search.h:
1315 Changed minsize from unspecific guint to guint32.
1317 * src/modest-search.c:
1319 Added strange hack which magically made tnymail work.
1321 (modest_search_folder),
1322 (modest_search_account),
1323 (modest_search_all_accounts):
1324 Implement helper functions to search all accounts, specific account
1327 * tests/dbus_api/Makefile.am:
1328 * tests/dbus_api/test_open_message.c:
1329 Read url to open from commandline.
1331 * tests/dbus_api/test_search.c:
1332 Implement small test for dbus search stuff
1334 2007-06-02 Armin Burgmeier <armin@openismus.com>
1336 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1337 include account type and account title. This fixes projects.maemo.org
1340 * src/maemo/modest-account-view-window.c: Set a title for the window.
1342 2007-06-02 Armin Burgmeier <armin@openismus.com>
1344 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1345 incoming and outgoing server name based on email address and server
1346 types as long as the names have not been edited manually. This fixes
1347 projects.maemo.org bug NB#58671.
1349 2007-06-02 Armin Burgmeier <armin@openismus.com>
1351 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1352 server type cannot be changed in future to the incoming details page
1353 when creating an account. This fixes projects.maemo.org bug NB#59029.
1355 2007-06-02 Armin Burgmeier <armin@openismus.com>
1357 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1358 and assigned max width chars so that they wrap instead of being
1359 truncated. Fixes projects.maemo.org bug NB#56126.
1361 2007-06-02 Armin Burgmeier <armin@openismus.com>
1363 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1364 introductory note to the connection specific smtp servers dialog, as
1365 section 8.12 of the email UI specification requires. This fixes
1366 projects.maemo.org bug NB#59212.
1368 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1370 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1371 Check for running mail operations, and offer to cancel them, as per the UI
1372 spec. This fixes projects.maemo.org bug NB#59041 .
1373 However, I suspect that tinymail may still use the network connection
1374 in ways that we cannot detect or cancel. But it should at least adapt to
1375 changes fairly well.
1377 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1379 * src/modest-tny-account-store.c: (recreate_all_accounts),
1380 (get_cached_accounts), (get_server_accounts): Do more sensible
1381 ref-counting of the temporarily-cached outbox accounts list. This seems
1382 to fix a crash when entering the password when the password was wrong.
1384 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1386 * src/gnome/modest-main-window.c: (connect_signals):
1387 * src/modest-tny-account-store.c: (get_password),
1388 (modest_tny_account_store_alert): Added comments and clues and
1389 commented-out code about how we currently fail to deal with connection
1390 errors and wrong passwords, and how we should.
1392 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1394 * src/widgets/modest-retrieve-combo-box.c:
1395 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1396 This fixes projects.maemo.org bug NB#58472 .
1398 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1400 * src/maemo/easysetup/modest-easysetup-wizard.c:
1401 (create_page_complete_easysetup):
1402 (create_page_complete_custom): Correct the last commit,
1403 putting the correct sentences in the correct pages.
1405 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1407 * src/maemo/easysetup/modest-easysetup-wizard.c:
1408 (create_page_complete_custom): Show the second sentence of text
1409 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1412 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1414 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1415 Set the leave-on-server conf key by default. This fixes
1416 projects.maemo.org bug NB#59258 .
1418 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1420 * src/maemo/modest-account-view-window.c:
1421 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1422 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1425 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1427 * src/maemo/easysetup/modest-easysetup-wizard.c:
1428 (create_caption_new_with_asterisk):
1429 * src/maemo/modest-account-settings-dialog.c:
1430 (create_caption_new_with_asterisk):
1431 Uncomment the code to add the asterisk, because they are no longer in the
1432 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1433 (update_incoming_server_title): Add an asterisk here too.
1435 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1437 * src/maemo/modest-maemo-global-settings-dialog.c:
1438 (current_connection): Check that we are even connected before trying to
1439 get the current connection name, to prevent a warning.
1441 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1442 Change the comments because tny_maemo_conic_device_connect() is now meant to
1444 * src/modest-mail-operation.c:
1445 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1446 make sure we have a connection and fail if we can't connect.
1448 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1450 * src/maemo/modest-main-window.c:
1451 (on_account_store_connecting_finished): Do not try to get the
1452 connection ID if we are not really connected. I am surprised that
1453 this signal handler is called when we are not connected.
1455 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1457 * src/modest-error.h:
1458 * src/modest-ui-actions.c:
1459 (modest_ui_actions_get_msgs_full_error_handler):
1460 Renamed an enum, added comments, added an enum
1461 for retrieve-limit errors.
1463 * src/modest-mail-operation.c: (foreach_add_item),
1464 (internal_folder_observer_update), (update_account_thread),
1465 (modest_mail_operation_get_msgs_full):
1466 (modest_mail_operation_update_account),
1467 Added comments about how this works, and some code that should
1468 (but does not) check the retrieve-limit. See the TODO comment.
1470 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1472 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1473 Initialize help_id to fix the build. Warnings are good.
1475 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1477 * src/widgets/modest-hbox-cell-renderer.c:
1478 (modest_hbox_cell_renderer_append):
1479 * src/widgets/modest-vbox-cell-renderer.c:
1480 (modest_vbox_cell_renderer_append):
1481 Fix the last commit by doing an extra ref.
1483 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1485 * src/widgets/modest-hbox-cell-renderer.c:
1486 (modest_hbox_cell_renderer_append):
1487 * src/widgets/modest-vbox-cell-renderer.c:
1488 (modest_vbox_cell_renderer_append):
1489 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1490 to fix the build with Maemo Bora.
1491 However, there seems to be a remaining crash, probably due to reference
1494 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1496 * src/modest-tny-account.c:
1497 (modest_tny_account_new_for_local_folders):
1498 Use hildon_file_system_info_async_new() to get a better name for
1499 the memory card account, setting it as the account name.
1500 The timing seems to work, but this is probably
1501 not the best place to do this. See the TODO comment.
1502 * src/maemo/modest-main-window.c: (create_details_widget):
1503 * src/widgets/modest-folder-view.c: (text_cell_data):
1504 Use the tny account name instead of hardcoding a name.
1506 2007-05-30 Christian Kellner <ckellner@openismus.com>
1508 * src/modest-search.c: (modest_search):
1509 Correctly set part_search_func even if we have already parsed
1510 the query and thus a valid OgsTextSearcher object.
1512 2007-05-30 Christian Kellner <ckellner@openismus.com>
1515 Search and check for libogs.
1518 Incooparte the ogs build env.
1520 * src/modest-mime-part-search-stream.c:
1521 * src/modest-mime-part-search-stream.h:
1522 Removed since we do the real searching now in modest-search.c.
1524 * src/modest-search.c:
1525 * src/modest-search.h:
1526 Implement support for ogs. We use that if available and requested
1527 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1528 should now handle the corner case when the search term is spread
1529 across multiple reads.
1530 Also the logic in modest_search () was corrected to search all
1531 requested fields until one is found.
1533 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1535 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1537 * src/modest-init.h:
1538 * src/modest-init.c: Made modest_init_local_folders() take a
1539 path and be public so we can iniitialize maildir folders on
1542 * src/modest-local-folder-info.h:
1543 * src/modest-local-folder-info.c:
1544 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1546 * src/modest-tny-account.c:
1547 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1548 still means the standard local-folders path on the local volume.
1550 * src/modest-tny-account-store.c:
1551 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1552 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1553 all accounts when that happens.
1554 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1555 this too, so it shows up in the treeview.
1557 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1559 * src/maemo/modest-maemo-global-settings-dialog.c:
1560 (current_connection):
1561 * src/widgets/modest-global-settings-dialog.c:
1562 (current_connection_default):
1563 Use the enum values instead of 0, 1 and -1,
1564 to make the code clearer.
1566 * src/modest-account-mgr-helpers.c:
1567 (modest_account_mgr_get_connection_specific_smtp): Make this code
1570 * src/modest-runtime.h:
1571 * src/modest-runtime.c:
1572 Added modest_runtime_remove_all_send_queues().
1573 * src/maemo/modest-main-window.c:
1574 (on_account_store_connecting_finished): Recreate the send queues,
1575 using the appropriate transport accounts for this new connection.
1576 Some futher adapting might be needed if the old send queues are not
1577 automatically stopped at this point.
1579 * src/modest-tny-account-store.c: (get_server_accounts):
1580 Create the connection-specific transport accounts, so that they can
1581 be found later by their ID.
1583 * src/modest-tny-account.h:
1584 * src/modest-tny-account.c:
1585 Added modest_tny_account_new_from_server_account_name().
1586 modest_tny_account_new_from_server_account(): Do not create the
1587 send queues here, because they will be
1588 recreated anyway when the connection changes for the first time.
1590 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1592 * src/modest-local-folder-info.h:
1593 * src/modest-local-folder-info.c:
1594 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1595 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1596 tbox_folder): Take a modest account name instead of a server TnyAccount,
1597 so we can have per-modest-account rather than per-transport-account
1599 We must make sure that we change or recreate the exisitng send queues
1600 when the connection changes for connection-specific transport accounts.
1602 * src/modest-tny-account-store.c:
1603 (create_per_account_local_outbox_folders): Create outboxed per modest
1604 account, not per transport account.
1606 * src/modest-tny-account.h:
1607 * src/modest-tny-account.c:
1608 (modest_tny_account_get_special_folder): For outboxes, get the
1609 parent modest account name. The account is ignored for other folders.
1610 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1611 modest account name rather than a server TnyAccount.
1613 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1615 * src/modest-tny-account.c:
1616 (modest_tny_account_new_from_server_account):
1617 Call modest_runtime_get_send_queue() immediately after creating transport
1618 accounts, so that they start trying to send email from the outbox as soon
1619 as possible at startup. This is probably what we want.
1621 * src/modest-mail-operation.c: (update_account_thread):
1622 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1623 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1624 * src/modest-tny-send-queue.h:
1625 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1626 (modest_ui_actions_on_send):
1627 Added comments about how sending works, though it needs some more work.
1629 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1631 * src/modest-tny-account.c:
1632 (modest_tny_account_get_special_folder): Add TODO because this fails when
1633 the network is busy.
1634 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1635 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1636 Do not try to show this window when there is no active account. The UI
1637 specs does not tell us what to do in this case.
1639 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1643 * src/maemo/Makefile.am:
1644 * src/widgets/Makefile.am: Some dist fixes.
1646 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1648 * src/maemo/modest-connection-specific-smtp-window.c:
1649 (on_button_edit): Make the code clearer, to prevent a double free.
1651 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1653 * src/maemo/modest-account-settings-dialog.c:
1654 (modest_account_settings_dialog_set_account_name),
1655 Check the connection-specific smtp servers checkbox if there are any.
1657 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1658 (modest_connection_specific_smtp_edit_window_init):
1659 Start with a suitable port number.
1661 * src/modest-account-mgr-helpers.h:
1662 * src/modest-account-mgr-helpers.c: Added
1663 modest_account_mgr_get_has_connection_specific_smtp().
1665 (modest_account_mgr_set_connection_specific_smtp),
1666 (modest_account_mgr_remove_connection_specific_smtp),
1667 (modest_account_mgr_get_has_connection_specific_smtp),
1668 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1669 connection-specific smtp server accounts in the account, rather than
1670 the server account conf dir.
1672 This fixes bug projects.maemo.org bug NB#58263 .
1674 * src/modest-tny-account-store.c:
1675 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1676 if there are no server accounts yet, to prevent an infinite loop when there
1677 are no accounts. Document that one must be called before the other.
1679 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1681 * src/modest-account-mgr-helpers.c:
1682 (modest_account_mgr_get_default_account): Make sure that at least
1683 one account is always the default, if there are any enabled accounts.
1684 This is just a sanity check that shouldn't be necessary.
1686 * src/modest-account-mgr-priv.c:
1687 (_modest_account_mgr_account_from_key): Unescape the conf key to
1688 get the real account name. For instance, this is an issue if a space
1689 was in the account name, which can happen because the account name
1690 is generated from the display name.
1691 (_modest_account_mgr_get_account_keyname): Always escape the
1693 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1694 Unescape the conf keys to get the real account names.
1696 For instance, previously the is-default radio button in the accounts
1697 list was not checked for any accounts at first. This fixes that,
1698 and might fix several similar bugs.
1700 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1702 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1703 Removed some debug printfs.
1705 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1707 Modest on-disk outbox directories are now here, for instance:
1708 $HOME/.modest/outboxes/<account-id-1>/outbox
1709 $HOME/.modest/outboxes/<account-id-2>/outbox
1711 $HOME/.modest/local-folders/outbox
1712 so we can have a separate outbox for each account.
1713 But they are shown as one outbox in the GtkTreeView, by using a
1714 TnyMergeFolder in a ModestTnySimpleFolderStore.
1717 * src/modest-tny-simple-folder-store.c:
1718 * src/modest-tny-simple-folder-store.h:
1719 Added ModestTnySimpleFolderStore, used to contain folders from
1720 other folder stores, such as other accounts.
1722 * src/modest-tny-outbox-account.h:
1723 * src/modest-tny-outbox-account.c:
1724 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1725 used for the per-account local outbox folders.
1727 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1728 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1729 only use this (internally) now for the non-outbox local folders.
1731 * src/modest-init.h:
1732 * src/modest-init.c: Added modest_init_one_local_folder(), for
1733 setting up the directory structure for each local folder.
1735 * src/modest-local-folder-info.c:
1736 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1737 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1739 * src/modest-local-folder-info.h:
1740 * src/modest-tny-account-store.c: (on_account_removed),
1741 (on_account_changed), (create_per_account_local_outbox_folders),
1742 (get_server_accounts), (modest_tny_account_store_get_accounts),
1743 (modest_tny_account_store_get_tny_account_by_account),
1744 (modest_tny_folder_store_is_virtual_local_folders):
1746 * src/modest-tny-account.h:
1747 * src/modest-tny-account.c:
1748 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1749 to create an on-disk per-account local outbox folder for each
1751 (create_per_account_local_outbox_folders): Create a local outbox folder
1752 for each transport account.
1753 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1754 for all local folders.
1756 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1757 instead of using g_object_get/set() directly. It is clearer.
1759 (modest_tny_folder_store_get_message_count),
1760 (modest_tny_folder_store_get_local_size
1761 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1762 because we now use these with non-acount folder stores.
1764 (modest_tny_account_get_special_folder),
1765 (modest_tny_account_new_from_server_account),
1766 (modest_tny_account_new_from_account):
1767 (recurse_folders): Adjust to the new outbox system.
1769 * src/modest-tny-folder.h:
1770 * src/modest-tny-folder.c:
1771 (modest_tny_folder_is_local_folder),
1772 (modest_tny_folder_get_local_folder_type),
1773 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1775 * src/widgets/modest-main-window.h:
1776 * src/maemo/modest-main-window.c: (create_details_widget),
1777 (modest_main_window_set_contents_style): Show details for any folder store,
1780 (modest_tny_folder_get_rules):
1781 Remove the const. C does not support constness enough for this.
1783 * src/modest-ui-actions.c:
1784 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1785 make all outboxes appear as one, in the usual local-folders tree node.
1787 (set_active_account_from_tny_account),
1788 (modest_ui_actions_on_folder_selection_changed):
1789 * src/widgets/modest-folder-view.c: (text_cell_data),
1790 (icon_cell_data), (filter_row),
1791 (add_account_folders_to_merged_folder),
1792 (add_account_folders_to_simple_folder_store), (),
1793 (get_cmp_rows_type_pos), (cmp_rows),
1794 (modest_folder_view_set_account_id_of_visible_server_account):
1795 Adjust to the new outbox system, using generic folder stores and folders
1796 in the GtkTreeModel.
1798 2007-05-23 Christian Kellner <ckellner@openismus.com>
1800 * src/modest-mail-operation.c:
1801 (modest_mail_operation_update_account):
1802 Use info->max_size instead of unintialized local var [small
1803 build fix]. (Added TODO to review that change since I don't
1806 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1808 * libmodest-dbus-client/libmodest-dbus-client.c:
1809 (libmodest_dbus_client_compose_mail): function added
1810 * src/dbus_api/modest-dbus-api.h:
1811 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1812 (on_compose_mail): Implementation of the SendAsMail functionality
1814 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1816 * src/modest-account-mgr.c:
1817 (modest_account_mgr_add_server_account): Set the secure-connection
1818 conf key for transport accounts as well as store accounts. I don't know
1819 why the if was there. For instance, this makes sure that we use SSL
1820 for the gmail preset from the easysetup wizard.
1822 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1824 * src/gnome/modest-main-window.c:
1825 (on_account_store_connecting_finished), (connect_signals):
1826 * src/maemo/modest-main-window.c:
1827 (on_account_store_connecting_finished), (connect_signals),
1828 (modest_main_window_new):
1829 Handle TnyAccountStore::connecting-finished instead of
1830 TnyDevice::connection-changed, because we cannot actually perform
1831 operations on accounts until TnyAccountStore has itself responded to
1832 the TnyDevice::connection-changed signal. This prevents a GError from
1834 Do not try to update at startup, because we (at least on scratchbox)
1835 already do an update at startup when the device goes online.
1836 This prevents a GError from tinymail.
1837 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1838 Added TODO about stopping simultaneous operations.
1840 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1842 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1843 * src/modest-mail-operation-queue.c:
1844 (modest_mail_operation_queue_remove):
1845 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1846 about where they happened.
1848 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1850 * src/modest-ui-actions.c:
1851 (modest_ui_actions_on_password_requested): Make sure that the remember
1852 output parameter is always TRUE.
1854 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1856 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1857 Show a OK/Cancel dialog if the error is a question, though we still do not
1858 know anything more about what we are asking the user.
1859 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1860 Fix an uninitialized variable (helper). This is a logic error, however.
1862 2007-05-21 Christian Kellner <ckellner@openismus.com>
1864 * src/modest-search.h:
1865 Correct bit shifting in the ModestSearchFlags enum.
1867 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1869 * src/modest-tny-account.c:
1870 (modest_tny_account_new_from_server_account): Do not use the lsub and
1871 check-all hard-coded IMAP options when using POP.
1873 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1875 * src/modest-tny-account.c:
1876 (modest_tny_account_new_from_server_account):
1877 Use NULL for the secure-auth method for POP when Password auth has been
1878 specified by the user, as we already do for IMAP. "auth=Login" causes
1879 an error from camel or the server.
1881 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1883 * src/maemo/modest-account-settings-dialog.c:
1884 (create_page_account_details),
1885 (modest_account_settings_dialog_set_account_name):
1886 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1887 for the leave-on-server checkbox, rathr than just the checkbox, when
1888 the protocol is not POP.
1890 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1892 * src/widgets/modest-account-view.c:
1893 * src/widgets/modest-account-view.h:
1894 Added modest_account_view_select_account() which will be useful later
1895 to asynchronously re-select the edited account.
1897 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1899 * src/maemo/modest-account-settings-dialog.c:
1900 (modest_account_settings_dialog_set_account_name):
1901 Automatically choose the port numbers based on the secure authentication
1902 methods, if they have not been chosen before.
1903 This fixes projects.maemo.org bug NB#56273 .
1905 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1907 * src/maemo/modest-main-window-ui.h:
1908 * src/modest-ui-actions.c:
1909 * src/modest-ui-actions.h:
1910 Connect the Tools/SMTP Servers menu item to
1911 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1912 SMTP servers dialog, as in the UI specification and saves changes when it
1913 is closed. This fixed projects.maemo.org bug NB#56305 .
1915 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1917 * src/maemo/modest-connection-specific-smtp-window.c:
1918 (modest_connection_specific_smtp_window_init):
1919 Use gtk_window_set_default_size() to make this window big enough, so
1920 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1922 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1924 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1925 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1926 (modest_connection_specific_smtp_edit_window_init),
1927 Do not try to connect to a combobox signal before the combobox exists.
1928 This fixes the cras in projects.maemo.org bug NB#56288 .
1929 (modest_connection_specific_smtp_edit_window_get_settings):
1930 Remove the server_account_name parameter which was being checked for NULL
1931 though it was not used.
1933 * src/maemo/modest-connection-specific-smtp-window.c:
1934 (modest_connection_specific_smtp_window_fill_with_connections),
1935 (on_button_edit), (modest_connection_specific_smtp_window_init):
1936 Correct the number of treemodel columns to prevent a warning.
1937 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1938 libconic does not work.
1940 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1942 * src/modest-tny-account.c:
1943 (modest_tny_account_new_from_server_account):
1944 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1945 SMTP when "None" was chosen by the user. However, with my SMTP server that
1946 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1949 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1951 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1952 to explain the memory management issue with the ID in the ModestPair.
1954 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1955 (add_sending_page), (modest_account_assistant_finalize):
1956 * src/gnome/modest-gnome-global-settings-dialog.c:
1957 (create_updating_page), (create_composing_page):
1958 * src/gnome/modest-msg-edit-window.c: (get_transports),
1959 (init_window), (modest_msg_edit_window_finalize),
1960 (modest_msg_edit_window_get_msg_data):
1961 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1962 * src/gnome/modest-transport-widget.c:
1963 (modest_transport_widget_finalize), (smtp_configuration):
1964 * src/maemo/modest-maemo-global-settings-dialog.c:
1965 (create_updating_page), (create_composing_page):
1966 * src/maemo/modest-msg-edit-window.c: (get_transports),
1967 (init_window), (modest_msg_edit_window_finalize),
1968 (modest_msg_edit_window_get_msg_data),
1969 (modest_msg_edit_window_free_msg_data):
1970 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1971 (modest_store_widget_finalize):
1972 * src/maemo/modest-transport-widget.c:
1973 (modest_transport_widget_finalize), (smtp_configuration):
1974 * src/modest-main.c: (send_mail):
1975 * src/widgets/modest-combo-box.h:
1976 * src/widgets/modest-global-settings-dialog-priv.h:
1977 * src/widgets/modest-global-settings-dialog.c:
1978 (modest_global_settings_dialog_finalize):
1979 * src/widgets/modest-msg-edit-window.h:
1980 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1981 as long as the combo box, to prevent use of freed memory for the ID.
1983 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1985 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1986 get_accounts(), to make this clearer. Do not check for the enabled gconf
1987 key, because we do not use this for server accounts (at least, not yet).
1988 This allows us to send email again.
1990 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1992 * src/maemo/modest-platform.c:
1993 (on_modest_conf_update_interval_changed), (modest_platform_init):
1994 Only respond to this particular key change. All these strcmp()s cannot be
1997 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1999 * src/maemo/modest-maemo-global-settings-dialog.c:
2000 (current_connection): Prevent a crash in scratchbox when
2001 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2002 * src/maemo/modest-platform.c:
2003 (on_modest_conf_update_interval_changed), (modest_platform_init):
2004 Get the update interval from gconf and reset it when the gconf key changes.
2006 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2008 * src/modest-protocol-info.c:
2009 * src/modest-protocol-info.h: Adde enum-specific get functions,
2010 instead of using a ModestProtocolType enum parameter.
2012 * src/gnome/modest-account-assistant.c:
2013 * src/gnome/modest-store-widget.c:
2014 * src/gnome/modest-store-widget.h:
2015 * src/gnome/modest-transport-widget.c:
2016 * src/gnome/modest-transport-widget.h:
2017 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2018 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2019 * src/maemo/easysetup/modest-easysetup-wizard.c:
2020 * src/maemo/modest-account-settings-dialog.c:
2021 * src/maemo/modest-account-settings-dialog.h:
2022 * src/maemo/modest-store-widget.c:
2023 * src/maemo/modest-store-widget.h:
2024 * src/maemo/modest-transport-widget.c:
2025 * src/maemo/modest-transport-widget.h:
2026 * src/modest-account-mgr-helpers.c:
2027 * src/modest-account-mgr-helpers.h:
2028 * src/modest-account-mgr.c:
2029 * src/modest-account-mgr.h:
2030 * src/modest-tny-account.c:
2031 * src/modest-tny-folder.c:
2032 * src/widgets/modest-account-view.c:
2033 * src/widgets/modest-retrieve-combo-box.c:
2034 * src/widgets/modest-retrieve-combo-box.h:
2035 * src/widgets/modest-secureauth-combo-box.c:
2036 * src/widgets/modest-serversecurity-combo-box.c:
2037 * src/widgets/modest-serversecurity-combo-box.h:
2038 * tests/check_account-mgr.c:
2039 Use the specific functions, and use the re-renamed enum values for GNOME too.
2041 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2043 * src/modest-pair.h:
2044 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2045 so we can get the second based on the first.
2047 * src/maemo/modest-account-settings-dialog.h:
2048 * src/maemo/modest-account-settings-dialog.c:
2049 Added get_supported_secure_authentication_methods(), though it is mostly
2050 commented-out for now until the necessary API is committed to tinymail.
2051 (modest_account_settings_dialog_set_account_name),
2052 (save_configuration): Request the supported authentication methods from the
2053 server, so we can choose a working method.
2055 * src/modest-tny-account-store.h:
2056 * src/modest-tny-account-store.c:
2057 (modest_tny_account_store_get_session): Rename from
2058 tny_account_store_get_session().
2060 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2062 * src/modest-protocol-info.h: Split the ModestProtocol enum
2063 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2064 There was no need to have these unrelated values in one enum.
2066 * src/: many files: Adapted to changed enum. This makes the code a bit
2067 clearer, and the compiler could catch some errors.
2069 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2071 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2072 Show the detailed internal camel error message when an error happens
2073 during the configuration, so that our testers can give us more clues.
2074 For instance, in projects.maemo.org bug NB#56910 .
2076 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2078 * src/modest-tny-account.c:
2079 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2080 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2082 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2084 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2085 * src/maemo/modest-account-settings-dialog.c:
2086 (modest_account_settings_dialog_set_account_name),
2087 (save_configuration): For the incoming secure authentication checkbox,
2088 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2089 the UI specification. PLAIN does not seem to be supported for most IMAP
2090 servers anyway, and I am not sure what it would mean.
2091 However, we probably need to discover which of the secure-authentication
2092 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2093 * src/modest-account-mgr-helpers.c:
2094 (modest_account_mgr_get_server_account_data):
2096 * src/modest-tny-account.c:
2097 (modest_tny_account_new_from_server_account):
2098 Use tny_account_set_mech() to set secure-authentication methods,
2099 with some special-casing for IMAP, based on my observations of how
2102 * src/modest-account-mgr-helpers.h:
2103 * src/modest-account-mgr.c:
2104 * src/modest-defs.h: Comment that the URI is only used for local folders.
2106 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2108 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2109 parameter const, just to be neat.
2110 * src/modest-text-utils.c: (modest_text_utils_inline):
2111 End g_strconcat() with NULL, as its documentation says. This is almost
2112 certainly the cause of my crash at startup on the device. Interestingly,
2113 valgrind doesn't tell us about these errors.
2115 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2117 * scripts/build-packages: Added more precise comments about how to use
2118 this script, though I still get this error:
2119 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2120 error building tinymail
2122 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2124 * src/maemo/modest-main-window.c: (on_account_update):
2125 Very slight cleanup, hoping to make it simpler to discover what causes
2126 a crash here sometimes.
2128 * src/modest-tny-account.c:
2129 (modest_tny_account_new_from_server_account): Set the port. Added
2130 comments about the options and a TODO comment because I need to find out
2131 how to specify the secure authentication method.
2133 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2135 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2136 changed CFlags paths form modest to libmodest
2138 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2140 * src/modest-account-mgr-helpers.c:
2141 (modest_account_mgr_get_server_account_data),
2142 (modest_account_mgr_free_server_account_data):
2143 * src/modest-account-mgr-helpers.h:
2144 * src/modest-account-mgr.c:
2145 (modest_account_mgr_add_server_account):
2146 * src/modest-defs.h:
2147 * src/modest-tny-account.c:
2148 (modest_tny_account_new_from_server_account):
2149 Determine the options for tny_camel_account_add_option() here,
2150 based on the settings, rather than storing them directly in gconf.
2152 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2154 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2155 Show a more friendly error dialog now that we expect (from the tinymail
2156 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2158 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2160 * src/maemo/modest-main-window.c: (on_account_update): Check that
2161 account_name is not NULL, to prevent a crash at startup that I am
2162 seeing on the N800. I do wonder why it is NULL.
2164 * src/maemo/easysetup/modest-easysetup-wizard.c:
2165 (create_page_user_details):
2166 * src/maemo/modest-account-settings-dialog.c:
2167 (create_page_user_details), (create_page_outgoing):
2168 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2169 (modest_connection_specific_smtp_edit_window_init):
2170 * src/modest-ui-actions.c:
2171 (modest_ui_actions_on_password_requested):
2172 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2173 might do something useful with the on-screen keyboard.
2175 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2177 * src/maemo/modest-main-window.c: (on_account_update):
2178 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2179 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2181 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2183 * src/modest-tny-account-store.c: (on_account_changed):
2184 Correct the signature of this signal handler.
2186 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2188 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2189 Show a HildonNote instead of a GtkDialog for Maemo.
2191 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2193 * src/widgets/modest-account-view.h:
2194 * src/widgets/modest-account-view.c: (on_account_changed),
2195 (on_account_removed). Added a boolean flag, set/unset by
2196 modest_account_view_block_conf_updates(),
2197 modest_account_view_unblock_conf_updates() to prevent unnecessary
2198 updates, but this is not very useful because the gconf notifications are
2199 so delays (maybe only on Maemo Bora).
2200 So auto-updating is turned off, and these functions do an explicit
2201 update when necessary.
2202 However, something else is still doing too much work when adding/removing
2203 accounts, probably in another part of the application.
2205 * src/maemo/modest-account-view-window.c:
2206 (on_delete_button_clicked), (on_edit_button_clicked),
2207 (on_new_button_clicked): Use the new functions.
2209 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2211 * src/modest-account-mgr-helpers.c:
2212 (modest_account_mgr_set_first_account_as_default):
2213 Sort the list of names alphabetically-by-title, so we choose the first one
2215 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2216 alphabetically by the title.
2218 This fixes projects.maemo.org bug NB#56418 .
2220 * src/modest-account-mgr-priv.c:
2221 (_modest_account_mgr_account_from_key):
2222 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2223 avoid a valgrind error, and possible random behaviour.
2225 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2227 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2228 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2229 tinymail documentation to say that this can be expected.
2230 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2231 pretty, and should not happen, but I would prefer to know when it does.
2233 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2235 * configure.ac: When using the older hildon version, probably on Bora,
2236 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2238 * src/widgets/modest-attachment-view.c:
2239 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2242 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2244 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2245 Implemented the prototype. Can be tested with
2246 tests/dbus_api/test_open_message:
2248 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2250 * src/modest-tny-account-store.c:
2251 (modest_tny_account_store_instance_init), (get_password):
2252 * src/modest-ui-actions.c:
2253 (modest_ui_actions_on_password_requested):
2254 Do not store the password in gconf, because this function is called
2255 for non-remembered passwords. Actually use the cached (in the hash map)
2256 password instead of releasing it.
2257 The password will now not be remembered if it is asked via the protected
2258 password dialog, as per the UI spec.
2260 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2262 * src/modest-defs.h:
2263 * src/modest-account-mgr-helpers.h:
2264 * src/modest-account-mgr-helpers.c:
2265 Added modest_server_account_get_username_has_succeeded(),
2266 modest_server_account_set_username_has_succeeded().
2267 (modest_server_account_set_username),
2268 Reset the has-succeeded flag if the username changes.
2270 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2271 * src/maemo/modest-connection-specific-smtp-window.c:
2272 (modest_connection_specific_smtp_window_save_server_accounts):
2273 Use modest_server_account_set_username() instead of using
2274 modest_conf_set_string() directly, so that the has-succeeded flag is always
2277 * src/modest-ui-actions.c:
2278 (modest_ui_actions_on_password_requested): Dim the username entry if
2279 the username has ever worked, as per the UI spec.
2281 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2283 * src/modest-tny-account-store.c: (get_password):
2284 * src/modest-ui-actions.c:
2285 (modest_ui_actions_on_password_requested):
2286 Allow the username to be changed too, though there is more work to
2287 be done on exactly how this behaves.
2289 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2291 * src/modest-account-mgr-helpers.h:
2292 * src/modest-account-mgr-helpers.c:
2293 Added modest_account_mgr_get_display_name(),
2294 modest_server_account_get_username(),
2295 modest_server_account_set_username(),
2296 modest_server_account_set_password(),
2297 modest_server_account_get_hostname() functions so we do not need to
2298 use the conf API directly.
2300 * src/maemo/modest-main-window.c: (connect_signals):
2301 Actually connect ot the ModestAccountStore::request-password signal,
2302 so that we show the dialog when the password is requested by Tinymail,
2303 for isntance if it is empty.
2305 * src/modest-marshal.list:
2306 * src/modest-tny-account-store.c:
2307 (modest_tny_account_store_class_init), (get_password),
2308 (modest_tny_account_store_alert):
2309 * src/modest-tny-account-store.h:
2310 * src/modest-ui-actions.h:
2311 * src/modest-ui-actions.c:
2312 (modest_ui_actions_on_password_requested):
2313 Change the signal parameters, so it is obvious that we are providing
2314 the non human-readable server name, and receiving both the username
2315 and password, though changing of the username is not yet implemented.
2316 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2317 for the GNOME version.
2319 This should fix the projects.maemo.org bug NB#56209, though it does not
2320 work on Bora, because the gconf_client_get() for the password fails
2321 immediately after we save it with gconf_client_set().
2323 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2326 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2327 caused an undefined symbol error:
2328 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2330 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2332 * src/modest-tny-account-store.c:
2333 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2334 using a GError instead of a string message, so we can translate it in
2337 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2339 * src/maemo/modest-address-book.c:
2340 (modest_address_book_check_names):
2341 * src/maemo/modest-msg-view-window.c:
2342 (modest_msg_view_window_clipboard_owner_change):
2343 * src/modest-init.c: (modest_init_init_ui):
2344 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2345 (update_folders_cb), (modest_mail_operation_update_account):
2346 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2347 (modest_ui_actions_on_msg_attachment_clicked),
2348 (modest_ui_actions_on_msg_recpt_activated):
2349 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2350 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2351 (modest_msg_view_search_next):
2352 * src/widgets/modest-recpt-editor.c:
2353 (modest_recpt_editor_on_button_release_event),
2354 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2355 g_message(). At this point we should only be seeing interesting errors on
2356 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2358 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2360 (modest_wizard_dialog_force_title_update):
2361 * src/maemo/easysetup/modest-wizard-dialog.h:
2362 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2363 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2364 can update the title when appropriate. Otherwise the title is wrong if the
2365 pages are added after adding the notebook to the dialog.
2366 This must be a problem in HildonWizardDialog too.
2367 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2369 * src/maemo/easysetup/modest-easysetup-wizard.c:
2370 (create_subsequent_customsetup_pages),
2371 (create_subsequent_easysetup_pages):
2372 Call modest_wizard_dialog_force_title_update() so that the title is
2373 correct even with GTK+ < 2.10.
2374 This fixes projects.maemo.org bug NB#56145 .
2376 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2378 * src/maemo/modest-platform.c:
2379 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2380 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2383 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2385 * src/widgets/modest-window.h:
2386 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2387 and modest_window_save_state(), which invokes it.
2389 * src/widgets/modest-window-mgr.h:
2390 * src/widgets/modest-window-mgr.c:
2391 Added modest_window_mgr_save_state_for_all_windows(), which calls
2392 the save_state vfunc on all registered windows, if implemented.
2394 * src/gnome/modest-msg-edit-window.c:
2395 * src/gnome/modest-msg-view-window.c:
2396 * src/maemo/modest-msg-edit-window.c:
2397 * src/maemo/modest-msg-view-window.c:
2398 * src/maemo/modest-main-window.c:
2399 Specify the existing save_settings functions as implementations of
2400 ModestWindow::save_state_func().
2402 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2403 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2404 enabling hibernation, for instance.
2406 We may need to do the same thing for restoring settings.
2409 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2411 * src/widgets/modest-window-mgr.c:
2412 * src/widgets/modest-window-mgr.h:
2413 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2414 modest_window_mgr_get_hibernation_is_prevented().
2416 * src/maemo/modest-main-window.c:
2417 (on_hildon_program_is_topmost_notify): Prevent hibernation
2418 (possible when the application goes to the background in the WM),
2419 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2421 * src/maemo/easysetup/modest-easysetup-wizard.c:
2422 (modest_easysetup_wizard_dialog_init):
2423 * src/maemo/modest-account-settings-dialog.c:
2424 (modest_account_settings_dialog_init):
2425 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2426 (modest_connection_specific_smtp_edit_window_init):
2427 * src/maemo/modest-connection-specific-smtp-window.c:
2428 (modest_connection_specific_smtp_window_init):
2429 * src/maemo/modest-signature-editor-dialog.c:
2430 (modest_signature_editor_dialog_init):
2431 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2432 prevent hibernation while any of these account settings dialogs are open.
2434 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2436 * src/maemo/Makefile.am:
2437 * src/maemo/modest-osso-state-saving.c:
2438 * src/maemo/modest-osso-state-saving.h: Added
2439 modest_osso_load_state() and modest_osso_save_state() though they do
2440 nothing now. They should iterate through all the open windows and load/save
2442 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2443 save state when closing.
2445 * src/maemo/modest-main-window.c:
2446 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2447 Add a notification handler for the HildonProgram::is-topmost property,
2448 so we can allow hibernation when the application goes into the background.
2449 But we still need to detect when the accounts setup windows are open so
2450 we can stop hibernation when they are open.
2451 To do this, I also added the main window the HildonProgram. This might have
2452 other side-effects/benefits, and should maybe be done for other windows.
2454 * src/maemo/modest-osso-autosave-callbacks.h:
2455 * src/maemo/modest-osso-autosave-callbacks.c:
2456 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2457 though it does not do anything yet, and we might never need this to do
2458 anything. For instance, we already save drafts.
2460 * src/maemo/modest-platform.c: (modest_platform_init):
2461 Specify the libosso auto-save callback.
2463 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2465 * src/maemo/modest-platform.c:
2466 (modest_platform_set_update_interval):
2467 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2468 aparently stays valid between application instances, so we can use this
2469 to remove and reset it later. According to a maemo-developers email from
2472 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2474 * configure.ac: Depend on libalarm for Maemo.
2476 * src/dbus_api/modest-dbus-api.h:
2477 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2478 (on_send_receive), (modest_dbus_req_handler):
2479 Handle a SEND_RECEIVE D-Bus method.
2481 * libmodest-dbus-client/libmodest-dbus-client.c:
2482 (libmodest_dbus_client_send_and_receive):
2483 * libmodest-dbus-client/libmodest-dbus-client.h:
2484 Add C convenience functions for calling the new D-Bus method.
2486 * src/modest-platform.h:
2487 * src/gnome/modest-platform.c:
2488 * src/maemo/modest-platform.c:
2489 Added modest_platform_set_update_interval(), which uses the
2490 alarmd API on Maemo.
2491 (modest_platform_init),
2492 Call modest_platform_set_update_interval(), using a hard-coded
2493 interval for now (until the global settings dialog is implemented),
2494 though I am not sure that this makes sense yet.
2496 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2498 * src/dbus_api/modest-dbus-callbacks.c:
2499 (modest_osso_cb_hw_state_handler):
2500 * src/dbus_api/modest-dbus-callbacks.h:
2501 * src/maemo/modest-platform.c: (modest_platform_init):
2502 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2503 in case this has some effect on the ability for Maemo to ping the
2506 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2508 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2509 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2510 warning. It is probably a logic error, but I need to fix the build.
2512 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2514 * src/modest-account-mgr.h:
2515 * src/modest-account-mgr.c:
2516 (modest_account_mgr_account_names): Add a gboolean enabled_only
2517 parameter, so we can get lists of onlt the enabled accounts.
2519 (modest_account_mgr_add_account),,
2520 (modest_account_mgr_account_with_display_name_exists):
2521 * src/maemo/modest-msg-edit-window.c: (get_transports):
2522 * src/modest-account-mgr-helpers.c:
2523 (modest_account_mgr_set_first_account_as_default):
2524 * src/modest-init.c: (init_default_account_maybe):
2525 * src/modest-tny-account-store.c: (get_accounts):
2526 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2527 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2528 * tests/check_account-mgr.c: (START_TEST):
2529 Provide the extra parameter, as appropriate.
2531 * src/widgets/modest-account-view.c: (update_account_view):
2532 Do not show disabled accounts (meaning that there is no way to
2533 enable/disable accounts in the UI (the feature is not in our UI
2534 specification), so we can use this internally only to mark unfinished
2535 or temporary account data.
2537 * src/maemo/easysetup/modest-easysetup-wizard.c:
2538 (create_account): Add boolean enable parameter, so we can specify FALSE
2539 to create the temporary account.
2540 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2541 (on_before_next): When finishing, when there is a temporary account, just
2543 Also, use a timeout to delay the showing of the dialog until gconf is likely
2544 to return correct information, due to a maemo gconf bug that is fixed in
2545 osso 1.1, but not yet in Bora.
2546 However, the dialog stays on screen after it is destroyed.
2548 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2549 for invalid data when cancelling. Use a hildon note instead of a dialog
2550 to complain about invalid data. Do not show the account-saved note if the
2551 account is disabled (a temporary account that will not really be saved for use
2554 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2556 * src/modest-account-mgr-helpers.h:
2557 * src/modest-account-mgr-helpers.c:
2558 Added modest_account_mgr_unset_default_account(),
2559 Added modest_account_mgr_set_first_account_as_default().
2561 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2562 If it was the default account, unset the default account name.
2564 * src/maemo/modest-account-view-window.c:
2565 (on_delete_button_clicked): If it was the default account,
2566 set the first remaining account as the default instead.
2568 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2569 a NULL account or a NULL default account, to prevent a crash. This should
2570 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2573 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2575 * src/widgets/modest-recpt-editor.c:
2576 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2577 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2578 TODO comment for this. This fixes the build.
2580 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2581 be the best place for it. This will in future update all auto-update accounts,
2582 rather than just the current/default account, when that gconf key exists.
2583 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2584 if there are no accounts, before calling do_send_receive().
2585 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2587 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2588 * src/maemo/modest-main-window-ui.h:
2589 * src/maemo/modest-main-window.c: (on_connection_changed),
2590 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2591 directly, becaue the signal handler does more.
2593 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2595 * src/modest-account-mgr-helpers.c:
2596 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2597 for the case that the account does not exist.
2599 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2600 (equivalent to the modest account name) rather than the tinymail account name
2601 (equivalent to the modest account title - human readable) to get the account data.
2602 Check for null account data to prevent the crash, and add a TODO comment saying that
2603 this needs fixing because it is using the server account name instead of the account name.
2605 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2607 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2608 * src/maemo/modest-account-settings-dialog.c: (show_error),
2610 Use hildon_note_new_information() for informative and error messages,
2611 which seems to be expected for Maemo applications (no documentation that I know of
2612 says this). I am surprised that there is no distinction between info and error
2615 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2617 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2618 it is easy to find where this is used.
2620 * src/maemo/easysetup/modest-easysetup-wizard.c:
2621 (create_page_welcome), (create_page_account_details),
2622 (create_page_user_details), (create_page_complete_easysetup),
2623 (create_page_custom_incoming), (create_page_custom_outgoing),
2624 (create_page_complete_custom):
2625 * src/maemo/modest-account-settings-dialog.c:
2626 (create_page_account_details), (create_page_user_details),
2627 (create_page_incoming), (create_page_outgoing):
2628 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2629 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2630 (modest_connection_specific_smtp_edit_window_init):
2631 * src/maemo/modest-connection-specific-smtp-window.c:
2632 (modest_connection_specific_smtp_window_init):
2633 * src/maemo/modest-signature-editor-dialog.c:
2634 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2635 and scrolling policy as per the Email Application Layout Guide, if I have
2638 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2640 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2641 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2642 which were empty, because these vfuncs have been removed from TnyAccountStore.
2643 This fixes the build.
2645 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2647 * src/maemo/modest-main-window.c:
2648 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2649 showing/hiding it. Added TODO because it probably should not be NULL.
2650 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2651 because unnecessary g_warnings() make degugging difficult.
2653 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2655 * src/maemo/modest-msg-edit-window.c:
2656 (modest_msg_edit_window_select_color),
2657 (modest_msg_edit_window_select_background_color): 2 const corrections and
2658 moving 2 #endifs before closing brackets, to fix the build.
2660 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2662 * src/maemo/easysetup/modest-easysetup-wizard.h:
2663 * src/maemo/easysetup/modest-easysetup-wizard.c:
2664 (modest_easysetup_wizard_dialog_finalize),
2665 (on_button_edit_advanced_settings), (create_page_complete_custom),
2666 (on_response), (create_account):
2667 Implement the Advanced Settings edit button, by saving the account information,
2668 for the Advanded Settings dialog to use directly from gconf, and removing it
2669 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2670 Bug #5533 in the projects.maemo.org bugzilla.
2672 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2674 * src/maemo/modest-msg-view-window.c:
2675 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2676 when opening a message window.
2678 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2680 * src/maemo/easysetup/modest-easysetup-wizard.c:
2681 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2684 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2685 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2686 gconf settings. I probably added more checks than necessary, but that is safer.
2688 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2689 variable to fix the build, but this seems to be used when it is still NULL.
2691 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2693 * src/modest-platform.h:
2694 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2695 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2696 * src/modest-main.c: Implement this function so we can avoid using
2697 maemo-specific API from cross-platform code.
2699 * src/modest-tny-account-store.c:
2700 (get_smtp_specific_transport_account_for_open_connection):
2701 * src/modest-ui-actions.c: (check_for_connection),
2702 (modest_ui_actions_on_item_not_found):
2703 Use modest_platform_connect_and_wait() and put #idefs around other
2704 maemo-specific code, because only maemo currently has a way to
2705 identify connection names.
2707 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2709 * src/modest-tny-account-store.h:
2710 * src/modest-tny-account-store.c:
2711 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2712 the connection-specific SMTP server settings in the configuration.
2714 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2716 * src/maemo/modest-main-window.c: (on_connection_changed),
2718 * src/modest-main.c: (main), (start_ui), (send_mail):
2719 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2720 that is what is intended.
2722 * src/modest-ui-actions.c: (action_send), (action_receive),
2723 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2724 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2725 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2726 SMTP server is used when it is specified.
2728 (modest_ui_actions_on_send_receive):
2729 Check that a connection is open before proceeding.
2730 Receive and then send, instead of vice-versa, as per the specification.
2732 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2734 * src/modest-mail-operation.c:
2735 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2736 though I guess it should be something other than NULL.
2738 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2740 * src/maemo/easysetup/modest-easysetup-wizard.c:
2741 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2742 combo twice, to avoid an g_warning and to make it visible again.
2743 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2744 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2745 (already intended) dereference when detaching, because we then recreate the menu.
2746 But I am not sure why the warning was happening, and it is possible that this is a memory
2749 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2751 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2752 and uri_parse_mailto() utility functions.
2753 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2755 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2757 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2759 * src/dbus_api/modest-dbus-api.h:
2760 * src/dbus_api/modest-dbus-callbacks.c:
2761 Use an idle callback to execute the modest code in the application's own thread.
2762 Remove the helloworld example method.
2763 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2764 parsed, and the open-message method is not implemented because this is not yet implemented in
2766 * libmodest-dbus-client/libmodest-dbus-client.c:
2767 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2768 (libmodest_dbus_client_open_message):
2769 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2771 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2772 body without crashing.
2774 * tests/dbus_api/Makefile.am:
2775 * tests/dbus_api/test_mail_to.c:
2776 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2778 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2780 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2781 Added file to fix the build. Sorry.
2783 * src/dbus_api/Makefile.am:
2784 * src/dbus_api/modest-dbus-api.h:
2785 * src/dbus_api/modest-dbus-callbacks.h:
2786 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2787 (modest_dbus_req_handler):
2788 Put constants in a separate header so it can be reused by the
2789 client library, without duplication
2791 * libmodest-dbus-client/Makefile.am:
2792 * libmodest-dbus-client/libmodest-dbus-client.c:
2793 (libmodest_dbus_client_call_helloworld),
2794 (libmodfest_dbus_client_send_mail),
2795 (libmodfest_dbus_client_mailto),
2796 (libmodfest_dbus_client_open_message):
2797 * libmodest-dbus-client/libmodest-dbus-client.h:
2798 (Partly) Implement a send_mail D-Bus method.
2800 * tests/dbus_api/Makefile.am:
2801 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2802 the send_email D-Bus method.
2804 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2808 * libmodest-dbus-client/Makefile.am:
2809 * libmodest-dbus-client/libmodest-dbus-client.c:
2810 * libmodest-dbus-client/libmodest-dbus-client.h:
2811 * tests/dbus_api/Makefile.am:
2812 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2813 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2815 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2817 * src/maemo/easysetup/modest-easysetup-wizard.c:
2818 (create_page_account_details):
2819 * src/maemo/modest-account-settings-dialog.c:
2820 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2821 widgets, because this might not be the default in future versions of the Maemo GTK+.
2822 However, I can not not get capitalization to work even in a simple test case.
2824 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2826 * src/maemo/easysetup/modest-easysetup-wizard.c:
2827 (create_page_custom_incoming), (create_page_custom_outgoing):
2828 * src/maemo/modest-account-settings-dialog.c:
2829 (create_page_account_details), (create_page_incoming),
2830 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2831 instead of using gtk_check_button_with_label(), so they are aligned like the other
2832 widgets, as per the UI spec.
2834 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2836 * src/maemo/easysetup/modest-easysetup-wizard.c:
2837 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2838 * src/widgets/modest-validating-entry.c:
2839 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2840 Modest prefix instead of an EasySetup prefix.
2842 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2844 * src/widgets/modest-validating-entry.h:
2845 * src/widgets/modest-validating-entry.c: (on_insert_text),
2846 Added easysetup_validating_entry_set_max_func(), used to set a callback
2847 to call when the max number of characters is reached. GtkEntry has a max-length
2848 already but is silent about it.
2850 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2851 (create_page_account_details), (create_page_user_details),
2853 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2854 (create_page_account_details), (create_page_user_details),
2855 (create_page_outgoing):
2856 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2857 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2858 the UI spec, when the user tries to enter more than the max number of characters.
2860 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2862 * src/maemo/easysetup/modest-easysetup-wizard.c:
2863 (create_page_user_details), (create_page_custom_incoming),
2864 (create_page_custom_outgoing):
2865 * src/maemo/modest-account-settings-dialog.c:
2866 (create_page_user_details), (create_page_incoming),
2867 (create_page_outgoing):
2868 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2869 (modest_connection_specific_smtp_edit_window_init):
2870 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2871 not appropriate. Bad Maemo-specific defaults!.
2873 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2875 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2876 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2877 (modest_signature_editor_dialog_set_settings):
2878 Disable the label and textview when the checkbox is disabled, and use the
2879 specified (UI spec) default signature text.
2881 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2883 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2884 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2886 * src/modest-defs.h:
2887 * src/modest-account-mgr-helpers.h:
2888 * src/modest-account-mgr-helpers.c:
2889 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2891 * src/maemo/Makefile.am:
2892 * src/maemo/modest-signature-editor-dialog.c:
2893 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2896 * src/maemo/modest-account-settings-dialog.h:
2897 * src/maemo/modest-account-settings-dialog.c:
2898 (modest_account_settings_dialog_finalize), (on_button_signature),
2899 (save_configuration): Use the new dialog when the Edit button is pressed, and
2900 save the changes if necessary, as per the UI spec.
2902 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2904 * src/maemo/Makefile.am:
2905 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2906 based on maemo-develoers email from Dirk.
2908 * src/maemo/easysetup/modest-easysetup-wizard.c:
2909 (create_page_welcome), (create_page_account_details),
2910 (create_page_user_details), (create_page_complete_easysetup),
2911 (create_page_custom_incoming), (create_page_custom_outgoing),
2912 (create_page_complete_custom),
2913 (modest_easysetup_wizard_dialog_init):
2914 * src/maemo/modest-account-settings-dialog.c:
2915 (create_page_account_details), (create_page_user_details),
2916 (create_page_incoming), (create_page_outgoing),
2917 (modest_account_settings_dialog_init):
2918 * src/maemo/modest-connection-specific-smtp-window.c:
2919 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2921 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2923 * src/maemo/easysetup/modest-easysetup-wizard.c:
2924 (create_page_account_details), (create_page_custom_outgoing),
2925 (create_page_complete_custom):
2926 * src/maemo/modest-account-settings-dialog.c:
2927 (create_page_user_details), (create_page_incoming),
2928 (create_page_outgoing):
2929 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2930 (modest_connection_specific_smtp_edit_window_init):
2931 Use the correct (UI spec) port min/max, and use horizontal separators,
2934 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2936 * src/maemo/easysetup/modest-easysetup-wizard.c:
2937 (set_default_custom_servernames):
2938 * src/maemo/modest-account-settings-dialog.c:
2939 (create_page_incoming), (on_combo_outgoing_security_changed),
2940 (on_combo_incoming_security_changed), (create_page_outgoing),
2941 (modest_account_settings_dialog_set_account_name),
2942 (save_configuration):
2943 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2944 (on_combo_security_changed),
2945 (modest_connection_specific_smtp_edit_window_init),
2946 (modest_connection_specific_smtp_edit_window_set_connection),
2947 (modest_connection_specific_smtp_edit_window_get_settings):
2948 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2951 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2954 * src/maemo/easysetup/modest-easysetup-wizard.c:
2955 (create_page_custom_outgoing), (create_page_complete_custom):
2956 * src/maemo/modest-account-settings-dialog.c:
2957 (create_page_user_details), (create_page_outgoing):
2958 * src/maemo/modest-account-view-window.c: (button_box_new):
2959 Use changed logical IDs as per the most recent UI spec:
2960 mcen_bd_emailsetup_edit -> mcen_bd_edit
2961 mcen_bd_emailsetup_delete -> mcen_bd_delete
2962 mcen_bd_emailsetup_close -> mcen_bd_close
2964 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2968 * src/dbus_api/Makefile.am:
2969 * src/dbus_api/modest-dbus-callbacks.c:
2970 * src/dbus_api/modest-dbus-callbacks.h:
2971 * src/maemo/modest-platform.c: (modest_platform_init):
2972 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2974 * tests/Makefile.am:
2975 * tests/dbus_api/Makefile.am:
2976 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2978 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2980 * src/maemo/modest-account-settings-dialog.c:
2981 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2982 Removed unnecessary includes.
2984 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2986 * src/maemo/easysetup/modest-easysetup-wizard.c:
2987 * src/maemo/modest-account-settings-dialog.c:
2988 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2989 * src/widgets/Makefile.am:
2990 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2991 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2992 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2993 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2994 * src/widgets/modest-secureauth-combo-box.c:
2995 * src/widgets/modest-secureauth-combo-box.h:
2996 * src/widgets/modest-serversecurity-combo-box.c:
2997 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2998 made the GObject names more consistent with the rest of the Modest code.
3000 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3002 * src/maemo/easysetup/Makefile.am:
3003 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3004 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3005 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3006 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3007 * src/maemo/easysetup/modest-easysetup-wizard.c:
3008 * src/maemo/easysetup/modest-validating-entry.c:
3009 * src/maemo/easysetup/modest-validating-entry.h:
3010 * src/maemo/modest-account-settings-dialog.c:
3011 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3012 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3013 widgets/ because they are used outside of easysetup too. After checking in,
3014 svn will allow me to rename them too.
3016 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3018 * src/gnome/modest-msg-edit-window.c:
3019 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3020 linker error, to fix the build on the GNOME platform.
3021 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3022 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3023 ifdefed out to avoid a warning.
3025 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3027 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3028 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3029 some alternative for GTK+ 2.6.
3031 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3033 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3035 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3036 specified for EmailAccountsDialog in UI spec.
3038 * src/maemo/easysetup/modest-easysetup-wizard.c:
3039 * src/maemo/easysetup/modest-easysetup-wizard.h:
3040 * src/maemo/modest-account-settings-dialog.c:
3041 * src/maemo/modest-account-settings-dialog.h:
3042 Reuse a member window widget for the connection-specific SMTP server accounts,
3043 so we can tell it to create/save the accounts only if we actually save changes.
3045 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3046 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3047 (modest_connection_specific_smtp_edit_window_get_settings):
3048 Return a struct instance for temporarily remembering the entered data.
3050 * src/maemo/modest-connection-specific-smtp-window.h:
3051 * src/maemo/modest-connection-specific-smtp-window.c:
3052 (modest_connection_specific_smtp_window_finalize),
3053 (modest_connection_specific_smtp_window_fill_with_connections),
3055 (modest_connection_specific_smtp_window_save_server_accounts),
3056 (update_model_server_names): Do not actually save data until asked,
3057 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3059 (on_selection_changed),
3060 (modest_connection_specific_smtp_window_init): Disable the edit
3061 button when nothing is selected.
3063 * src/modest-account-mgr-helpers.c:
3064 * src/modest-account-mgr-helpers.h:
3065 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3068 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3070 * src/modest-account-mgr-helpers.h:
3071 * src/modest-account-mgr-helpers.c:
3072 (modest_account_mgr_get_unused_account_name),
3073 (modest_account_mgr_get_unused_account_display_name): Added these
3074 utility functions, to avoid code duplication.
3076 * src/maemo/easysetup/modest-easysetup-wizard.c:
3077 (create_page_account_details), (create_account):
3078 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3079 (on_combo_security_changed),
3080 (modest_connection_specific_smtp_edit_window_init),
3081 (modest_connection_specific_smtp_edit_window_save_settings):
3082 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3083 * src/maemo/modest-connection-specific-smtp-window.c:
3084 (modest_connection_specific_smtp_window_finalize),
3085 (modest_connection_specific_smtp_window_fill_with_connections),
3086 (on_button_edit), (modest_connection_specific_smtp_window_init):
3087 * src/maemo/modest-connection-specific-smtp-window.h:
3088 Implementing saving of connection-specific server accounts.
3090 But I need to refactor this so we can save the data for each
3091 possible connection-specific account and only actually create the server accounts
3092 when the easysetup finished, or the OK button is pressed on the account settings
3095 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3097 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3098 (on_combo_security_changed):
3099 (modest_connection_specific_smtp_edit_window_init):
3100 Auto-fill the port number as in the account settings.
3102 (modest_connection_specific_smtp_edit_window_set_connection):
3103 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3104 * src/maemo/modest-connection-specific-smtp-window.c:
3105 (fill_with_connections), (on_button_edit),
3106 (modest_connection_specific_smtp_window_init):
3107 Turn the edit window into a dialog to simplify the code, and
3108 set a WM hint as in a GtkDialog, because only a popup can be on top of
3109 another window in Maemo, and popups usually have no WM decoration.
3111 * src/modest-defs.h:
3112 * src/modest-account-mgr-helpers.c:
3113 (modest_account_mgr_set_connection_specific_smtp),
3114 (modest_account_mgr_remove_connection_specific_smtp),
3115 (modest_account_mgr_get_connection_specific_smtp):
3116 * src/modest-account-mgr-helpers.h: Some functions to write the
3117 connection-specific SMTP server information. Not yet used.
3120 * src/widgets/modest-folder-view.c: (text_cell_data):
3121 Fix a warning about an uninitialized variable.
3122 (on_configuration_key_changed): Put an #ifdef around the use
3123 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3125 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3127 * src/maemo/modest-account-settings-dialog.h:
3128 * src/maemo/modest-account-settings-dialog.c:
3129 Added connect_for_modified() utility function to mark the new modified boolean.
3131 (create_page_account_details), (create_page_user_details),
3132 (create_page_incoming), (create_page_outgoing), (on_response),
3133 (modest_account_settings_dialog_init),
3134 (modest_account_settings_dialog_set_account_name):
3135 Only warn about unsaved changes when there are actually unsaved changes.
3137 * src/modest-account-mgr-helpers.c:
3138 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3139 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3140 to get the data from there in future.
3142 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3144 * src/modest-defs.h:
3146 * src/modest-account-mgr-helpers.h:
3147 * src/modest-account-mgr-helpers.c:
3148 Store the security account setting in a single conf key instead of using
3149 the options list, so that the list is left for just the to-be-removed camel hack,
3150 and because gconf_client_set_list() is failing for some reason.
3152 * src/modest-account-mgr.c:
3153 (modest_account_mgr_add_server_account):
3154 * src/maemo/modest-account-settings-dialog.c:
3155 (modest_account_settings_dialog_set_account_name),
3156 (save_configuration): Use the renamed functions.
3159 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3161 * src/widgets/Makefile.am:
3162 * src/widgets/modest-limit-retrieve-combo-box.c:
3163 * src/widgets/modest-limit-retrieve-combo-box.h:
3164 * src/widgets/modest-retrieve-combo-box.c:
3165 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3166 the account settings dialog.
3168 * src/modest-defs.h:
3169 * src/modest-account-mgr-helpers.h:
3170 * src/modest-account-mgr-helpers.c:
3171 (modest_server_account_get_option_secure_auth),
3172 (modest_server_account_set_option_secure_auth):
3173 * src/modest-account-mgr.c:
3174 (modest_account_mgr_add_server_account):
3175 Use the existing AUTH_MECH conf key for the secure-auth setting,
3176 instead of putting it in the list options, because this was actually used already.
3178 * src/maemo/modest-account-settings-dialog.c:
3179 (create_page_account_details),
3180 (modest_account_settings_dialog_set_account_name),
3181 (save_configuration):
3182 * src/maemo/modest-account-settings-dialog.h:
3183 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3184 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3186 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3188 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3189 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3190 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3192 * src/modest-defs.h:
3193 * src/maemo/modest-account-settings-dialog.c:
3194 (create_page_incoming), (on_combo_outgoing_security_changed),
3195 (on_combo_incoming_security_changed), (create_page_outgoing),
3196 (modest_account_settings_dialog_set_account_name),
3197 (save_configuration): Load/Save the port number, and change it when the
3198 security combo changes, to suitable defaults.
3200 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3202 * src/modest-account-mgr.c:
3203 (modest_account_mgr_add_server_account): Set the security and secure-auth
3204 options, and add a comment saying that the other camel-specific options should be
3207 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3209 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3211 * src/modest-tny-account-store.c: (account_list_free),
3212 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3213 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3216 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3218 * src/modest-protocol-info.c:
3219 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3220 is required by our UI spec. Maybe something in our implementation will use this eventually.
3221 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3222 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3223 instead of the previous 0 placeholder.
3225 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3226 secure-auth settings.
3227 * src/modest-account-mgr-helpers.h:
3228 * src/modest-account-mgr-helpers.c:
3229 (modest_server_account_data_get_option_secure_auth),
3230 (modest_server_account_set_option_secure_auth),
3231 (modest_server_account_data_get_option_security),
3232 (modest_server_account_set_option_security): Added this API for getting and setting the security
3233 and secure-auth settings.
3235 * src/maemo/modest-account-settings-dialog.h:
3236 * src/maemo/modest-account-settings-dialog.c:
3237 (modest_account_settings_dialog_finalize), (check_data),
3238 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3239 about changing titles.
3240 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3241 (save_configuration): Save the security and secure-auth settings.
3243 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3244 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3246 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3248 * src/modest-defs.h:
3249 * src/modest-account-mgr.c:
3250 (modest_account_mgr_add_server_account):
3251 Added and used defines for the options key and value pair strings,
3252 that are used so far, though they do not seem to correspond to anything in our
3253 UI specs or ModestProtocol enum.
3255 * src/modest-account-mgr-helpers.h:
3256 * src/modest-account-mgr-helpers.c:
3257 (compare_option_strings_for_name),
3258 (modest_server_account_data_get_option_value),
3259 (modest_server_account_data_get_option_bool),
3260 (modest_account_mgr_get_server_account_option):
3261 Added helper functions for parsing the options GSList.
3263 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3265 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3266 display name is based on the supplied account name.
3267 * src/modest-account-mgr.c:
3268 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3269 with an inefficient, but good-enough, implementation.
3271 * src/maemo/easysetup/modest-easysetup-wizard.c:
3272 (create_page_account_details), (on_before_next), (create_account):
3273 Check for existing display names rather than (non-user-visible) account names, and just
3274 create and set a unique account name at the end.
3276 * src/maemo/modest-account-settings-dialog.c:
3277 (modest_account_settings_dialog_init),
3278 (modest_account_settings_dialog_set_account_name),
3279 (create_page_incoming): Show the display name, instead of the account name.
3280 (on_response): Do some (not all) extra checks, as in the UI spec.
3281 (save_configuration): Save the display name if it was changed.
3283 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3285 * po/en_GB.po: Added needed logical ID and translation.
3286 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3287 (init_view): Made the is-default column clicking work.
3289 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3292 * src/maemo/easysetup/Makefile.am:
3293 * src/maemo/easysetup/modest-easysetup-wizard.c:
3294 (modest_easysetup_wizard_dialog_init):
3295 * src/maemo/easysetup/provider-data-test.keyfile:
3296 * src/maemo/easysetup/provider-data.keyfile:
3297 Moved the provider data file to the new modest-providers-data package and used it from there.
3299 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3301 * src/modest-local-folder-info.c:
3302 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3303 N_() was already used on the static strings, but this just marks it for translation without
3304 using the translation.
3306 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3308 * src/maemo/modest-account-settings-dialog.c:
3309 (create_page_incoming),
3310 (modest_account_settings_dialog_set_account_name):
3311 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3312 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3313 I will do this if nobody else gets there first.
3315 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3317 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3318 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3319 save the security stuff.
3321 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3323 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3324 Set the email address and user fullname, which I now see must be
3327 * src/maemo/modest-account-settings-dialog.h:
3328 * src/maemo/modest-account-settings-dialog.c:
3330 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3331 leave-on-server and authentication.
3332 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3335 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3338 * src/maemo/modest-account-settings-dialog.c:
3339 * src/maemo/modest-account-settings-dialog.h:
3340 Most (but not all) of the widgets are now present as specified by the UI spec.
3341 No changes are yet saved, and some details are not properly shown yet.
3343 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3345 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3347 * src/maemo/Makefile.am:
3348 * src/maemo/modest-account-settings-dialog.c:
3349 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3350 an existing account. Doesn't do much yet.
3352 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3353 Open the accounts settings dialog when Edit is clicked.
3355 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3357 * src/maemo/easysetup/Makefile.am:
3358 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3360 * src/maemo/easysetup/modest-easysetup-wizard.c:
3361 (modest_easysetup_wizard_dialog_init):
3362 Try to get the source directory from the build system,
3363 instead of hard-coding "./" into the source code, when opening our local
3364 copies of the configuration files.
3365 But this still fails when opening the wizard from the Accounts window,
3366 maybe because the working directory seems to change at runtime.
3367 So the wizard will fail the second time unless you copy the files into their
3368 proper locations - see the stdout warnings for the paths.
3370 (create_page_account_details),(on_before_next):
3371 Check for existing non-server accounts instead of server accounts,
3372 so the default account name is useful again, and to prevent trying to
3375 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3376 Show the wizard when New is clicked.
3378 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3379 (init_view): Show the column headers, and show the columns that are
3380 specified in the UI specs. However, something in Maemo's GTK+ prevents
3381 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3382 change the default account. This is despite unsetting the special properties.
3384 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3386 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3387 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3388 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3389 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3390 to make that clearer.
3391 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3393 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3395 * src/maemo/modest-account-view-window.c:
3396 (modest_account_view_window_init),
3397 (modest_account_view_window_new):
3398 Use the same buttons as specified in the
3399 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3400 the existing widgets, which never had a chance of working.
3401 Put the ModestAccountView treeview in a scrolled window.
3402 Do not repeat the initialization in both _init() and _new().
3404 * src/widgets/modest-account-view.c: (update_account_view):
3405 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3406 this widget and window shows no accounts.
3408 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3410 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3412 * src/maemo/easysetup/modest-easysetup-wizard.c:
3413 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3414 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3415 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3418 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3419 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3420 accounts exist yet, as in the UI spec.
3422 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3424 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3426 * src/maemo/Makefile.am:
3427 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3428 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3429 New window for editing connection-specific smtp details.
3430 Not fully implemented.
3432 * src/maemo/modest-connection-specific-smtp-window.c:
3433 (modest_connection_specific_smtp_window_finalize) :
3434 unref the tree model.
3435 (on_button_edit): Show the edit window.
3437 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3439 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3442 * src/maemo/Makefile.am:
3443 * src/maemo/modest-connection-specific-smtp-window.c:
3444 * src/maemo/modest-connection-specific-smtp-window.h:
3445 New window for showing the list of connections, for connection-specific
3446 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3447 * src/maemo/easysetup/modest-easysetup-wizard.c:
3448 (create_page_custom_outgoing): Show the new window when the button is clicked.
3450 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3452 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3453 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3454 * src/maemo/modest-msg-edit-window.c:
3455 (modest_msg_edit_window_insert_image):
3456 * src/modest-conf.c: (modest_conf_key_escape):
3457 * src/modest-mail-operation.c:
3458 (modest_mail_operation_send_new_mail):
3459 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3460 (modest_ui_actions_on_new_account):
3461 * src/widgets/modest-attachment-view.c: (update_filename_request):
3462 * src/widgets/modest-mail-header-view.c:
3463 Corrected warnings that were breaking the build, by commenting out unused variables,
3464 and a function, and by including a header.
3466 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3468 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3469 so we can #ifdef around platform-specific code when necessary.
3470 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3471 to allow this to build for the GNOME platform too.
3473 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3475 * src/maemo/easysetup/modest-easysetup-wizard.c:
3476 Added util_increment_name() and used it in create_page_account_details()
3477 to make sure that the default account name is always a new name.
3479 (modest_easysetup_wizard_dialog_init),
3480 (set_default_custom_servernames): Some minor memory management fixes.
3482 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3486 * src/modest-runtime.c: (init_i18n): Restored the translation
3487 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3488 are defined in config.h, and the translations are installed.
3490 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3491 is defined for translation.
3493 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3495 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3497 * src/maemo/easysetup/modest-easysetup-wizard.c:
3498 (modest_easysetup_wizard_dialog_init):
3499 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3500 Use realistic paths (though they should use $prefix generically) to the
3501 mcc_mapping and provider-data.keyfile files which might work when they
3502 are installed by the future version of the operator-wizard package,
3503 and then fallback to paths in our source code, with an explanatory
3506 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3510 * src/maemo/Makefile.am:
3511 * src/maemo/easysetup/: Added files from the previously-exernal
3512 osso-modest-easysetup.
3513 * src/maemo/modest-main-window-ui.h:
3514 * src/modest-ui-actions.c:
3515 * src/modest-ui-actions.h:
3516 Added modest_ui_actions_on_new_account() as a signal handler for the
3517 New Account menu item. It shows the easysetup wizard.
3518 * po/en_GB.po: Added additional needed logical IDs and translations.