1 2007-06-21 Armin Burgmeier <armin@openismus.com>
3 * src/modest-mail-operation.c: Do not call
4 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
5 notify the operation's end after having set the status to CANCELED for
6 the operation queue to listen on. This fixes a deadlock when there
7 were mail operations in the queue during its finalization.
9 * src/modest-singletons.c: Reordered uninitialization of the account
10 manager to happen after the mail operation queue was uninitialized
11 because the mail operation's in the queue might still try to access
12 the account manager (see modest_mail_operation_notify_end()). This
13 fixes a potential crash when terminating the application.
15 2007-06-21 Murray Cumming <murrayc@murrayc.com>
17 * src/modest-search.c:
18 (search_mime_part_and_child_parts): Moved some code here so we
19 can search recursively in child folders.
20 (modest_search_folder): Search in the message as a mime part, instead
21 of just its child mime parts.
22 (read_chunk), (search_mime_part_ogs):
23 Check how many bytes were read, to prevent an endless loop.
24 Searching in message bodies now works. This finishes the fix for
25 projects.maemo.org bug NB#61007.
27 2007-06-20 Murray Cumming <murrayc@murrayc.com>
29 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
30 Add a g_warning when the item is not a folder.
32 * src/modest-ui-dimming-rules.c:
33 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
34 when selected item is not a folder (for instance, an account), because
35 the UI spec only talks about folders.
36 I am not sure what the UI spec wants, so this might not totally fix
37 projects.maemo.org bug NB#60794.
39 2007-06-20 Murray Cumming <murrayc@murrayc.com>
41 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
42 (load_from_file): Sort the list. The unsorted list would be more noticeable
43 in non-English locales.
45 * src/maemo/modest-msg-edit-window.c:
46 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
47 warning and fix the build.
49 * src/maemo/modest-progress-bar-widget.c:
50 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
51 avoid a g_warning, and probably to avoid a crash.
53 2007-06-20 Murray Cumming <murrayc@murrayc.com>
55 * src/modest-search.c: (modest_search_folder): Check for a GError
56 when calling tny_folder_get_headers(), to show that this is not the cause
59 2007-06-20 Murray Cumming <murrayc@murrayc.com>
61 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
62 Actually set the body query instead of the subject query.
64 * src/modest-search.c: (search_mime_part_ogs),
65 (search_mime_part_strcmp): Remove extra space from the text/* regex,
66 which would probably cause it to fail if we got this far.
68 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
70 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
71 be causing search-in-body to fail.
73 2007-06-20 Murray Cumming <murrayc@murrayc.com>
75 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
77 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
78 Better debug message when the folder cannot be found.
79 This should help with fixing projects.maemo.org bug #61287.
80 * src/modest-search.c: (add_hit): Do not leak the furl string.
82 2007-06-20 Murray Cumming <murrayc@murrayc.com>
84 * src/modest-ui-actions.c:
85 (modest_ui_actions_on_folder_selection_changed):
86 Do not special-case TNY_MERGE_FOLDER here, because
87 modest_tny_folder_get_account() already does that. This fixes
88 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
89 shown when the Outbox was selected).
91 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
93 * libmodest-dbus-client/libmodest-dbus-client.c:
94 (_dbus_iter_get_string_or_null): Initialize the string variable in
95 case this helps with Dirk's crash.
97 2007-06-19 Murray Cumming <murrayc@murrayc.com>
99 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
100 though it is not implemented yet (this function is maybe not even used),
101 to avoid breaking ABI in future.
102 * libmodest-dbus-client/libmodest-dbus-client.c:
103 (get_attachments_string): Moved some code into this generic function.
104 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
105 sends email. It is maybe not used.
106 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
107 (on_send_mail): Use attachments.
109 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
110 * src/maemo/modest-msg-edit-window.c:
111 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
112 a filename before using it, to fix projects.maemo.org bug NB#58233.
114 2007-06-19 Murray Cumming <murrayc@murrayc.com>
116 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
117 Initialize the continue_download variable to fix the build, and probably
118 to fix randome behaviour.
120 2007-06-18 Armin Burgmeier <armin@openismus.com>
122 * src/modest-tny-send-queue.h:
123 * src/modest-tny-send-queue.c: Keep track of the status of messages in
124 the queue so we can later show it in the UI. Replaced
125 modest_tny_send_queue_msg_is_being_sent() by
126 modest_tny_send_queue_get_msg_status().
128 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
130 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
131 gpointer. This probably was not harmful, but just to be sure.
133 2007-06-18 Murray Cumming <murrayc@murrayc.com>
135 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
136 Fix the build, but leave the function broken on Bora, because
137 hildon_uri_action_get_service() does not exist.
138 osso_uri_action_get_service() does not exist either, it seems.
140 2007-06-18 Murray Cumming <murrayc@murrayc.com>
142 * src/modest-tny-account.c:
143 (modest_tny_account_new_from_server_account):
144 Uncommented the url debug output again, because it is useful for
145 debugging, as I said in the comment.
147 2007-06-18 Murray Cumming <murrayc@murrayc.com>
149 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
151 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
152 for Mameo Bora, to fix the build.
154 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
157 Fixed build with hildon < 0.99
159 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
160 Check if the selected account is busy instead of checking all accounts
162 * src/modest-account-mgr-priv.h:
163 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
164 (modest_account_mgr_init), (compare_account_name),
165 (modest_account_mgr_set_account_busy),
166 (modest_account_mgr_account_is_busy):
167 * src/modest-account-mgr.h:
168 Added busy information to the account manager. It possible to
169 set an account to busy or not busy now.
171 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
172 (modest_mail_operation_update_account),
173 (modest_mail_operation_notify_end):
174 Set the account to busy/not busy depending on the operation state.
176 * src/widgets/modest-account-view.c:
177 (modest_account_view_finalize), (get_last_updated_string),
178 (update_account_view), (on_account_busy_changed), (init_view):
179 Show string "Refreshing..." if the account is currently busy.
181 All this fixes projects.maemo.org bug NB#59711
183 2007-06-14 Armin Burgmeier <armin@openismus.com>
185 * src/widgets/modest-attachments-view.h:
186 * src/widgets/modest-attachments-view.c: Added
187 modest_attachments_view_has_attachments() and fixed coordinate
188 transformation in get_att_view_at_coords(). This fixes attachment
191 * src/widgets/modest-msg-view.c: Make use of
192 modest_attachments_view_has_attachments() to decide whether to show
193 attachments in the header.
195 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
197 * src/maemo/modest-connection-specific-smtp-edit-window.c:
198 (on_change), (on_combo_security_changed),
199 (modest_connection_specific_smtp_edit_window_init),
200 (modest_connection_specific_smtp_edit_window_set_connection),
201 (modest_connection_specific_smtp_edit_window_is_dirty):
202 * src/maemo/modest-connection-specific-smtp-edit-window.h:
203 * src/maemo/modest-connection-specific-smtp-window.c:
206 Show an comfirmation dialog for the smpt-edit-window if there are
207 unsaved changes and the user hits cancel.
208 (projects.maemo.org bug NB#60479)
210 2007-06-14 Armin Burgmeier <armin@openismus.com>
212 * src/maemo/easysetup/modest-easysetup-wizard.c:
213 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
214 address" info in banner instead of node, and select all the text as
215 per UI spec. This fixes projects.maemo.org bug NB#60550.
217 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
219 reviewed by: <delete if not using a buddy>
221 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
222 * src/modest-ui-actions.c: (folder_refreshed_cb):
224 2007-06-14 Murray Cumming <murrayc@murrayc.com>
226 * src/widgets/modest-folder-view.c: (filter_row):
227 Explictly filter out the per-account outbox accounts. I don't know why
228 these only sometimes show up, but now they should never show up in the UI.
229 This should fix projects.maemo.org bug NB#60160.
231 2007-06-14 Murray Cumming <murrayc@murrayc.com>
233 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
234 when the toolbar does not exist yet.
235 * src/modest-widget-memory.c: (save_settings_header_view):
236 Added g_warnings() to help us to discover when we are trying to set
237 an empty columns list in gconf.
239 2007-06-14 Murray Cumming <murrayc@murrayc.com>
243 Added modest_init_get_default_header_view_column_ids().
245 * src/modest-widget-memory.c: (restore_settings_header_view):
246 Use the new function to get defaults, if the gconf key is empty,
247 instead of not creating any columns. This seems to fix the
248 empty right-hand pane problems.
250 * src/widgets/modest-header-view.h: Improved documentation.
252 2007-06-13 Murray Cumming <murrayc@murrayc.com>
254 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
255 Revert the use of the display name as the account name, because this
256 is generally wrong and would break the code that follows.
258 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
260 * src/maemo/easysetup/modest-easysetup-wizard.c:
261 (check_for_supported_auth_methods), (on_before_next),
264 More correct fix for projects.maemo.org bug NB# 58991
265 Do not longer accept AUTH_PASSWORD as secure method and choose
266 correct method when creating the account.
268 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
270 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
271 Fixed projects.maemo.org bug NB# 58991
273 2007-06-13 Murray Cumming <murrayc@murrayc.com>
275 * src/modest-init.c: (modest_init_init_core),
276 (modest_init_local_folders): Fixed compilation errors.
278 2007-06-13 Murray Cumming <murrayc@murrayc.com>
280 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
281 Remove unnecessary lib/include, though it is good in principle when needed.
283 * src/modest-init.c: (modest_init_one_local_folder),
284 (modest_init_local_folders):
285 * src/modest-init.h: Initialize the .modest library for memory cards,
286 instead of just doing nothing for them. This should allow us to create
287 folders there, fixing projects.maemo.org bug NB#59297.
289 2007-06-13 Murray Cumming <murrayc@murrayc.com>
291 * libmodest-dbus-client/libmodest-dbus-client.c:
292 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
293 (libmodest_dbus_client_compose_mail),
294 (libmodest_dbus_client_open_message),
295 (libmodest_dbus_client_send_and_receive),
296 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
298 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
299 (on_idle_open_message), (modest_dbus_req_handler),
300 (search_result_to_message), (modest_dbus_req_filter):
301 * src/modest-search.c: (add_hit), (modest_search_folder),
302 (modest_search_all_accounts): Improved debug messages.
304 * tests/dbus_api/test_open_message.c: (main): Improved comments.
306 * src/modest-tny-account-store.c:
307 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
310 2007-06-13 Murray Cumming <murrayc@murrayc.com>
313 2007-06-12 Murray Cumming <murrayc@murrayc.com>
315 * src/modest-tny-account-store.c: (get_server_accounts):
316 Call modest_tny_local_folders_account_add_merged_outbox_folders()
317 even when there are no accounts, so that the Outbox folder is always
318 visible. This fixes projects.maemo.org bug NB#60158.
320 2007-06-12 Murray Cumming <murrayc@murrayc.com>
322 * src/maemo/modest-main-window.c: (create_details_widget):
323 Use the mcen_va_never logical ID.
325 2007-06-12 Murray Cumming <murrayc@murrayc.com>
327 * src/dbus_api/modest-dbus-api.h:
328 * src/dbus_api/modest-dbus-callbacks.c:
329 (on_idle_open_default_inbox), (on_open_default_inbox),
330 (modest_dbus_req_handler):
331 Added a new OpenDefaultInbox method.
333 * libmodest-dbus-client/libmodest-dbus-client.h:
334 * libmodest-dbus-client/libmodest-dbus-client.c:
335 Added libmodest_dbus_client_open_default_inbox() to call the new
336 dbus method. This should be useful to projects.maemo.org bug NB#57214,
337 though it should maybe be used by a new osso-email-interface function.
339 * tests/dbus_api/Makefile.am:
340 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
343 2007-06-12 Murray Cumming <murrayc@murrayc.com>
345 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
346 NULL, so that the signals get all the keys. This should not actually
347 change any behaviour because we currently update everything when anything
350 2007-06-12 Murray Cumming <murrayc@murrayc.com>
352 * src/widgets/modest-folder-view.c: (text_cell_data),
353 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
354 (find_inbox_iter): If tinymail tells us that the folder is
355 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
356 This causes the inbox to be selected at startup, fixing part of
357 projects.maemo.org bug NB#56305.
359 * src/modest-ui-dimming-rules.c:
360 (modest_ui_dimming_rules_on_tools_smtp_servers):
361 * src/modest-ui-dimming-rules.h: Added a callback function to dim
362 the SMTP servers menu item.
363 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
364 that the SMTP Servers menu item is dimmed when there are no accounts,
365 as a future version of the UI spec will require. This fixes
366 projects.maemo.org bug NB#56305.
368 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
370 * src/maemo/modest-maemo-utils.c:
371 (modest_maemo_utils_get_supported_secure_authentication_methods):
372 Added label to dialog instead of unreadable title
374 * src/maemo/modest-main-window.c: (sync_accounts_cb),
375 (modest_main_window_new):
376 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
379 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
380 * src/modest-account-mgr.h:
381 Added method to avoid code duplication
383 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
384 (modest_ui_actions_on_send_receive):
385 Use modest_account_mgr_has_accounts
387 2007-06-11 Murray Cumming <murrayc@murrayc.com>
389 * src/maemo/easysetup/modest-presets.c:
390 (modest_presets_get_info_server_security): Do not report secure auth
392 * src/modest-protocol-info.c: Use the defines for the gconf key names
393 for secure authentication. This was not working because we were writing
394 Password and reading password, and the check was case sensitive.
395 With this, gmail now works for receiving and sending when created via
398 2007-06-11 Murray Cumming <murrayc@murrayc.com>
400 * src/maemo/easysetup/modest-presets.c:
401 (modest_presets_get_info_server_security): Correct the key name for
402 SecureSmtp, because it seems to be case-sensitive.
403 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
404 Do not try to get the 0th notebook page if there are 0 pages, to
407 2007-06-11 Murray Cumming <murrayc@murrayc.com>
409 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
410 Prevent use of the new notification feature for now, because it currently
411 shows one dialog for each new email, which is annoying.
413 2007-06-11 Murray Cumming <murrayc@murrayc.com>
415 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
416 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
417 when no country was selected, so that we show the global ones.
418 * src/maemo/easysetup/modest-presets.c:
419 (modest_presets_get_providers): Return only the global providers, not
420 all providers when mmc=0 was requested.
422 2007-06-11 Murray Cumming <murrayc@murrayc.com>
424 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
425 (easysetup_provider_combo_box_fill): Remove debug code that showed the
426 provider ID in the combo.
428 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
429 Do not show the page numbers, because it would be confusing when we add
430 the 2 extra pages for the custom setup, when the user chooses the "Other"
431 provider. This fixes projects.maemo.org bug NB#59028
433 * src/modest-init.c: (modest_init_init_core),
434 (modest_init_local_folders):
436 * src/modest-tny-account.c:
437 (modest_tny_account_new_for_local_folders): Do not create default folders
438 for the memory card. This should fix projects.maemo.org bug NB#59328.
440 2007-06-11 Murray Cumming <murrayc@murrayc.com>
442 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
443 Free the changed_conf_keys string items. They are already freed in the
444 idle handler if that runs first.
446 2007-06-11 Murray Cumming <murrayc@murrayc.com>
448 * src/modest-ui-actions.c:
449 (modest_ui_actions_on_password_requested): Check that the server name
450 is not NULL, because I just saw a password dialog with (null) as the
453 * src/modest-tny-folder.[h|c]: Added
454 modest_tny_folder_is_memory_card_folder().
455 * src/modest-ui-dimming-rules.c:
456 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
457 menu item for memory cards, as per the UI spec (section 7.4). This should
458 fix projects.maemo.org bug NB#59297.
460 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
462 * src/maemo/modest-main-window.c: (sync_accounts_cb):
463 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
464 is another problem with the code, see Murray's comment at line 772)
466 2007-06-08 Murray Cumming <murrayc@murrayc.com>
468 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
469 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
470 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
471 (load_from_file), (easysetup_country_combo_box_init),
472 (easysetup_country_combo_box_get_active_country_ids),
473 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
474 instead of just one ID, to avoid duplicate country names in the UI.
476 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
477 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
478 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
479 a single ID, avoiding duplicate providers.
480 * src/maemo/easysetup/modest-easysetup-wizard.c:
481 (on_combo_account_country): Adapt to use a list.
483 2007-06-08 Murray Cumming <murrayc@murrayc.com>
485 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
486 keys changed in the last X seconds.
488 * src/modest-account-mgr.h:
489 * src/modest-account-mgr.c: (on_timeout_notify_changes),
490 (on_key_change), (modest_account_mgr_class_init),
491 (modest_account_mgr_init), (modest_account_mgr_finalize):
492 As the keys are changed, save them in a GSList* and signal that GSList*
493 further every X seconds, to batch changes, to allow us to do just one
494 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
495 bug NB#56941 and other (UI-blocking) delays when changing account settings.
497 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
498 changed signal signature.
500 * src/modest-conf.c: (modest_conf_set_list),
501 (modest_conf_on_change): Reenable notification.
503 (modest_conf_maemo_fake_on_change): Comment out the hack that
504 notified immediately instead of asynchronously.
506 * src/widgets/modest-account-view.h:
507 * src/widgets/modest-account-view.c:
508 (update_account_view): Select the previously-selected account ID,
509 if possible. This fixes projects.maemo.org bug NB#56933.
511 (on_account_changed), (on_account_removed),
512 (modest_account_view_select_account):
514 Remove the block/unblock functions
515 because they were not useful.
517 * src/maemo/modest-account-view-window.c:
518 (on_delete_button_clicked), (on_edit_button_clicked),
519 (on_new_button_clicked): Remove the use of the non-working block/unblock.
521 2007-06-08 Murray Cumming <murrayc@murrayc.com>
523 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
524 Improve the error dialog to show Incorrect Account Settings, which seems
525 clearer, and say that the internal error message (to be removed from the
526 dialog later) is often misleading.
527 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
529 * src/modest-tny-account.c:
530 (modest_tny_account_new_from_server_account): Uncomment the printf of the
531 URL because this is so useful for debugging on the device.
533 * src/widgets/modest-serversecurity-combo-box.c:
534 (modest_serversecurity_combo_box_fill): Correct a logical ID.
536 2007-06-08 Murray Cumming <murrayc@murrayc.com>
538 * src/modest-mail-operation.c:
539 (modest_mail_operation_send_new_mail):
540 Added a comment about a nasty but apparently harmless message. Details
541 added to the wiki g_warnings() page.
543 2007-06-08 Murray Cumming <murrayc@murrayc.com>
545 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
546 (modest_tny_send_queue_class_init):
547 Do not use the priv struct because it is empty, to avoid g_warnings
548 about a non-existant priv struct.
550 * src/modest-tny-account-store.c:
551 (modest_tny_account_store_get_server_account),
552 (modest_tny_account_store_get_transport_account_for_open_connection
553 ): Do not try to get transport server accounts for local folders,
554 because they don't have any. This avoids a g_warning().
556 * src/maemo/modest-main-window.c:
557 (modest_main_window_notify_send_receive_initied),
558 (on_configuration_key_changed):
559 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
561 * src/modest-mail-operation.c:
562 (modest_mail_operation_update_account):
563 * src/modest-tny-account-store.h:
564 * src/modest-tny-account.c:
565 (modest_tny_account_get_special_folder),
566 (modest_tny_account_new_for_local_folders),
567 (modest_tny_account_new_for_per_account_local_outbox_folder):
568 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
569 * src/modest-tny-local-folders-account.c:
570 (add_account_folders_to_merged_folder):
571 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
572 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
573 (modest_ui_actions_on_send):
574 * src/widgets/modest-folder-view.c: (update_model):
575 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
576 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
577 modest_tny_account_store_get_tny_account_by_account() to
578 modest_tny_account_store_get_server_account() to make the code clearer.
580 2007-06-07 Marcus Bauer <marcusb@openismus.com>
582 * src/dbus_api/modest-dbus-api.h:
583 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
584 * src/maemo/modest-msg-edit-window.c:
585 (modest_msg_edit_window_attach_file_noninteractive):
586 added g_warning in case the file to be attached does not exist
587 * tests/dbus_api/test_compose_mail.c: (main):
588 removed obsolete comment, added generic files as test case
590 2007-06-07 Murray Cumming <murrayc@murrayc.com>
592 * src/modest-tny-account-store.c: (get_server_accounts):
593 Create the local folders account only once, not once for each outbox, and
594 not only when there are some outboxes.
596 2007-06-07 Murray Cumming <murrayc@murrayc.com>
598 * src/widgets/modest-folder-view.c: (update_model): Comment out some
599 code that is causing a crash at startup. Sergio says that he is fixing this.
601 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
603 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
604 * src/maemo/modest-account-settings-dialog.c:
605 (create_page_outgoing),
606 (modest_account_settings_dialog_set_account_name),
607 (save_configuration):
608 - Fixed handling of the "Use secure authentication" toggle to comply with
609 the ui specification. See also projects.maemo.org bug NB#58400
611 - Restore the Secure connection setting combo correctly when loading
614 * src/maemo/modest-maemo-utils.c:
615 (on_camel_account_get_supported_secure_authentication),
616 (modest_maemo_utils_get_supported_secure_authentication_methods):
617 Fixed a crasher if operation is canceled
619 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
620 (modest_protocol_info_auth_is_secure):
621 * src/modest-protocol-info.h:
623 Added two new methods to determine if a protocol/auth method is secure/encrypted in
624 the sense of the "Use secure authentication" toggle.
626 2007-06-07 Murray Cumming <murrayc@murrayc.com>
628 * src/modest-tny-account-store.h:
629 * src/modest-tny-account-store.c:
630 Added modest_tny_account_store_get_local_folders_account().
632 * src/modest-tny-folder.h:
633 * src/modest-tny-folder.c:
634 (modest_tny_folder_get_account):
635 Added this replacement for tny_folder_get_account() which returns
636 the local-folders account for TnyMergeFolders, to avoid the
637 warning about the unimplemented get_account_func() vfunc().
639 (modest_tny_folder_get_rules),
640 * src/modest-ui-actions.c:
641 (modest_ui_actions_on_folder_selection_changed):
642 * src/modest-mail-operation.c:
643 (modest_mail_operation_remove_folder),
644 (modest_mail_operation_xfer_folder),
645 (modest_mail_operation_rename_folder),
646 (modest_mail_operation_get_msg),
647 (modest_mail_operation_get_msgs_full),
648 (modest_mail_operation_remove_msg),
649 (modest_mail_operation_xfer_msgs),
650 (modest_mail_operation_refresh_folder):
651 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
653 2007-06-07 Murray Cumming <murrayc@murrayc.com>
655 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
656 (modest_server_account_set_security):
657 * src/modest-defs.h: Add comments explaining that our
658 UI spec means TLS when it says Normal, so these do not look like errors.
660 * src/modest-tny-account.c:
661 (modest_tny_account_new_from_server_account): Use the new tinymail
662 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
663 for TLS. This should fix projects.maemo.org bug NB#58460.
665 2007-06-06 Murray Cumming <murrayc@murrayc.com>
667 * src/maemo/easysetup/modest-easysetup-wizard.c:
668 (create_account): Correct the position of the gconf sanity check warning.
669 (on_button_edit_advanced_settings): Show the dialog immediately, instead
670 of using the g_idle_add() hack, because this does not seem to be necessary
671 on osso 1.1. It might even work on Maemo Bora if the problems were actually
672 caused by something other than maemo's gconf.
673 This fixes projects.maemo.org bug #59022.
675 2007-06-06 Murray Cumming <murrayc@murrayc.com>
677 * src/modest-account-mgr-helpers.c:
678 (modest_account_mgr_get_default_account): Do not check that the account
679 exists if there is no default account (NULL), to fix a runtime warning.
681 2007-06-06 Murray Cumming <murrayc@murrayc.com>
683 * src/widgets/modest-folder-view.c: (update_model):
684 Do not unref the treemodel before we have finished with it.
685 This prevents a valgrind warning and an occasional crash at startup.
687 2007-06-06 Marcus Bauer <marcusb@openismus.com>
689 * libmodest-dbus-client/libmodest-dbus-client.h:
690 added libmodest_dbus_client_compose_mail()
691 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
693 added functions needed for SendAsMail() functionality
694 * src/maemo/modest-msg-edit-window.c:
695 (modest_msg_edit_window_attach_file_noninteractive):
696 non interactively attaching files to message edit window
697 * src/widgets/modest-msg-edit-window.h:
698 * tests/dbus_api/Makefile.am:
699 added test_compose_mail.c
700 * tests/dbus_api/test_compose_mail.c: (main):
702 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
704 * src/modest-account-view.c:
705 Fixed bug projects.maemo.org bug NB#59307
707 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
709 * src/maemo/easysetup/modest-easysetup-wizard.c:
710 (get_serverport_incoming), (on_before_next), (create_account):
711 * src/maemo/modest-account-settings-dialog.c:
712 (modest_account_settings_dialog_set_account_name):
713 * src/maemo/modest-maemo-utils.c:
714 (on_camel_account_get_supported_secure_authentication_status),
715 (on_camel_account_get_supported_secure_authentication),
716 (on_secure_auth_cancel),
717 (modest_maemo_utils_get_supported_secure_authentication_methods):
719 Implemented security authentication for settings and easysetup.
721 2007-06-05 Murray Cumming <murrayc@murrayc.com>
723 * src/maemo/modest-main-window.c: (create_details_widget):
724 Show the total size for memory card accounts too, instead of showing
725 the name again. Fixes bug projects.maemo.org bug NB#59307.
727 2007-06-05 Murray Cumming <murrayc@murrayc.com>
730 * src/modest-tny-simple-folder-store.c:
731 * src/modest-tny-simple-folder-store.h: Removed.
733 * src/modest-tny-local-folders-account.h
734 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
735 for the local-folders maildir, with an extra TnyMergedFolder containing
736 the folders of the per-account outbox store accounts.
737 * src/modest-tny-account-store.c: (get_server_accounts):
738 Add the outboxes to the special local folders account after creating it.
740 * src/modest-tny-account.c:
741 (modest_tny_account_new_for_local_folders): Create the derived
742 account when creating the main local-folders account.
744 * src/maemo/modest-main-window.c: (create_details_widget),
745 (modest_main_window_set_contents_style):
746 Adapted to the use of the derived account instead of the folder store.
748 * src/modest-ui-actions.c:
749 (modest_ui_actions_on_folder_selection_changed):
750 * src/modest-ui-dimming-rules.c:
751 (modest_ui_dimming_rules_on_new_folder):
752 * src/widgets/modest-folder-view.c: (text_cell_data),
753 (icon_cell_data), (filter_row), (update_model),
754 (get_cmp_rows_type_pos):
757 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
758 Do not get the priv struct, because no priv struct has been set,
759 to avoid a runtime warning.
761 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
762 #ifelse with #else, to fix a warning, to fix the build.
765 2007-06-05 Christian Kellner <ckellner@openismus.com>
767 * libmodest-dbus-client/libmodest-dbus-client.c:
768 Fix small typo in doc (why do you always see them
769 AFTER committing stuff?)
772 2007-06-05 Christian Kellner <ckellner@openismus.com>
774 * libmodest-dbus-client/libmodest-dbus-client.c:
775 (libmodest_dbus_client_search):
776 Initialize hit list with NULL. Also set folder list
777 to "" if NULL was supplied.
780 2007-06-03 Christian Kellner <ckellner@openismus.com>
782 * libmodest-dbus-client/libmodest-dbus-client.c:
783 (modest_search_hit_list_free):
784 Make it save to call it with NULL.
786 * src/dbus_api/modest-dbus-callbacks.c:
787 * src/modest-search.c:
788 Return full ModestSearchHits as the search result list not TnyHeader
789 since can't be around withouth the correspoding TnyFolder.
791 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
793 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
794 Added currently commented code to check for secure auth
796 * src/maemo/modest-account-settings-dialog.c: (on_response),
797 (save_configuration), (show_ok):
798 Fixed projects.maemo.org bugs NB #59248 and #59251
800 * src/maemo/modest-maemo-utils.c:
801 (on_camel_account_get_supported_secure_authentication_status),
802 (on_camel_account_get_supported_secure_authentication),
803 (modest_maemo_utils_get_supported_secure_authentication_methods):
804 * src/maemo/modest-maemo-utils.h:
805 Moved get_supported_secure_authentication() method here to be able
806 to use it from easysetup wizard.
808 * src/modest-pair.c: (on_pair_compare_as_string):
809 Should compare string with first part of pair and not
810 strcmp pairs which will crash.
812 * src/modest-protocol-info.c:
813 (modest_protocol_info_protocol_is_store):
814 * src/modest-protocol-info.h:
815 Added modest_protocol_info_get_auth_protocol_name()
817 2007-06-03 Armin Burgmeier <armin@openismus.com>
819 * src/modest-mail-operation.c:
820 (modest_mail_operation_get_msgs_full): Set priv->account also when
821 only retrieving a single message. This avoids a crash when canceling
824 (modest_mail_operation_notify_end): Do not explicitely remove the
825 operation from the queue but only emit the progress_changed signal.
826 The queue itself listens to that signal to remove the operation when
827 it is finished. This reduces coupling and removes a potential deadlock
828 when modest_mail_operation_notify_end() is called from the queue
829 itself. If that is a problem performance-wise, I would suggest to
830 implement a status-changed signal or something.
832 * src/modest-mail-operation-queue.c: Make sure to never call a
833 function from another file while the queue is locked. This (hopefully)
834 fixes another deadlock when exiting the application while retrieving
837 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
839 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
840 Fixed build if libogs is not available
842 2007-06-03 Christian Kellner <ckellner@openismus.com>
844 * libmodest-dbus-client/libmodest-dbus-client.h:
845 * libmodest-dbus-client/libmodest-dbus-client.c:
846 (libmodest_dbus_client_delete_message):
847 Implement deletion of messages (Client side).
849 (modest_search_hit_free),
850 (modest_search_hit_list_free):
851 Utility functions to free the result hits.
853 * src/dbus_api/modest-dbus-api.h:
854 * src/dbus_api/modest-dbus-callbacks.c:
856 (modest_dbus_req_handler):
857 Implement deletion of messages (Server side).
859 * tests/dbus_api/test_search.c: (main):
862 * tests/dbus_api/Makefile.am:
863 * tests/dbus_api/test_delete_message:
864 Add little test for the message deletion logic
866 2007-06-03 Armin Burgmeier <armin@openismus.com>
868 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
869 when the operation queue was not empty. projects.maemo.org bug
872 2007-06-03 Armin Burgmeier <armin@openismus.com>
874 * src/widgets/modest-account-view.c
875 (on_account_default_toggled): Toggle default account column
876 explicitely instead of waiting for gconf notification (which is
877 currently ignored). This should fix projects.maemo.org bug NB#56910
878 for now. It should probably be removed when gconf notifications are
881 2007-06-03 Christian Kellner <ckellner@openismus.com>
883 * libmodest-dbus-client/libmodest-dbus-client.c:
884 Removed debugging spew.
886 * src/dbus_api/modest-dbus-callbacks.c:
887 Added debugging info.
889 * src/modest-search.c:
890 (modest_search_all_accounts):
891 Use tny_account_store_get_accounts () on the account store
892 to get all accounts which is the way to get all accounts.
894 * tests/dbus_api/test_search.c: (main):
895 Make it possible to supply the search term on the command line.
897 2007-06-03 Christian Kellner <ckellner@openismus.com>
899 * libmodest-dbus-client/libmodest-dbus-client.c:
900 * libmodest-dbus-client/libmodest-dbus-client.h:
901 Implement searching for mesages over raw dbus. (Client side)
903 * src/dbus_api/Makefile.am:
904 * src/dbus_api/modest-dbus-api.h:
905 * src/dbus_api/modest-dbus-callbacks.c:
906 * src/dbus_api/modest-dbus-callbacks.h:
907 Search framework (Server side). Also implement on_idle_open_message().
909 * src/maemo/modest-platform.c: (modest_platform_init):
910 Prepare for raw dbus/osso rpc interaction.
912 * src/modest-search.h:
913 Changed minsize from unspecific guint to guint32.
915 * src/modest-search.c:
917 Added strange hack which magically made tnymail work.
919 (modest_search_folder),
920 (modest_search_account),
921 (modest_search_all_accounts):
922 Implement helper functions to search all accounts, specific account
925 * tests/dbus_api/Makefile.am:
926 * tests/dbus_api/test_open_message.c:
927 Read url to open from commandline.
929 * tests/dbus_api/test_search.c:
930 Implement small test for dbus search stuff
932 2007-06-02 Armin Burgmeier <armin@openismus.com>
934 * src/maemo/modest-account-settings-dialog.c: Changed window title to
935 include account type and account title. This fixes projects.maemo.org
938 * src/maemo/modest-account-view-window.c: Set a title for the window.
940 2007-06-02 Armin Burgmeier <armin@openismus.com>
942 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
943 incoming and outgoing server name based on email address and server
944 types as long as the names have not been edited manually. This fixes
945 projects.maemo.org bug NB#58671.
947 2007-06-02 Armin Burgmeier <armin@openismus.com>
949 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
950 server type cannot be changed in future to the incoming details page
951 when creating an account. This fixes projects.maemo.org bug NB#59029.
953 2007-06-02 Armin Burgmeier <armin@openismus.com>
955 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
956 and assigned max width chars so that they wrap instead of being
957 truncated. Fixes projects.maemo.org bug NB#56126.
959 2007-06-02 Armin Burgmeier <armin@openismus.com>
961 * src/maemo/modest-connection-specific-smtp-window.c: Add an
962 introductory note to the connection specific smtp servers dialog, as
963 section 8.12 of the email UI specification requires. This fixes
964 projects.maemo.org bug NB#59212.
966 2007-06-01 Murray Cumming <murrayc@murrayc.com>
968 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
969 Check for running mail operations, and offer to cancel them, as per the UI
970 spec. This fixes projects.maemo.org bug NB#59041 .
971 However, I suspect that tinymail may still use the network connection
972 in ways that we cannot detect or cancel. But it should at least adapt to
975 2007-06-01 Murray Cumming <murrayc@murrayc.com>
977 * src/modest-tny-account-store.c: (recreate_all_accounts),
978 (get_cached_accounts), (get_server_accounts): Do more sensible
979 ref-counting of the temporarily-cached outbox accounts list. This seems
980 to fix a crash when entering the password when the password was wrong.
982 2007-06-01 Murray Cumming <murrayc@murrayc.com>
984 * src/gnome/modest-main-window.c: (connect_signals):
985 * src/modest-tny-account-store.c: (get_password),
986 (modest_tny_account_store_alert): Added comments and clues and
987 commented-out code about how we currently fail to deal with connection
988 errors and wrong passwords, and how we should.
990 2007-06-01 Murray Cumming <murrayc@murrayc.com>
992 * src/widgets/modest-retrieve-combo-box.c:
993 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
994 This fixes projects.maemo.org bug NB#58472 .
996 2007-06-01 Murray Cumming <murrayc@murrayc.com>
998 * src/maemo/easysetup/modest-easysetup-wizard.c:
999 (create_page_complete_easysetup):
1000 (create_page_complete_custom): Correct the last commit,
1001 putting the correct sentences in the correct pages.
1003 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1005 * src/maemo/easysetup/modest-easysetup-wizard.c:
1006 (create_page_complete_custom): Show the second sentence of text
1007 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1010 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1012 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1013 Set the leave-on-server conf key by default. This fixes
1014 projects.maemo.org bug NB#59258 .
1016 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1018 * src/maemo/modest-account-view-window.c:
1019 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1020 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1023 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1025 * src/maemo/easysetup/modest-easysetup-wizard.c:
1026 (create_caption_new_with_asterisk):
1027 * src/maemo/modest-account-settings-dialog.c:
1028 (create_caption_new_with_asterisk):
1029 Uncomment the code to add the asterisk, because they are no longer in the
1030 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1031 (update_incoming_server_title): Add an asterisk here too.
1033 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1035 * src/maemo/modest-maemo-global-settings-dialog.c:
1036 (current_connection): Check that we are even connected before trying to
1037 get the current connection name, to prevent a warning.
1039 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1040 Change the comments because tny_maemo_conic_device_connect() is now meant to
1042 * src/modest-mail-operation.c:
1043 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1044 make sure we have a connection and fail if we can't connect.
1046 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1048 * src/maemo/modest-main-window.c:
1049 (on_account_store_connecting_finished): Do not try to get the
1050 connection ID if we are not really connected. I am surprised that
1051 this signal handler is called when we are not connected.
1053 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1055 * src/modest-error.h:
1056 * src/modest-ui-actions.c:
1057 (modest_ui_actions_get_msgs_full_error_handler):
1058 Renamed an enum, added comments, added an enum
1059 for retrieve-limit errors.
1061 * src/modest-mail-operation.c: (foreach_add_item),
1062 (internal_folder_observer_update), (update_account_thread),
1063 (modest_mail_operation_get_msgs_full):
1064 (modest_mail_operation_update_account),
1065 Added comments about how this works, and some code that should
1066 (but does not) check the retrieve-limit. See the TODO comment.
1068 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1070 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1071 Initialize help_id to fix the build. Warnings are good.
1073 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1075 * src/widgets/modest-hbox-cell-renderer.c:
1076 (modest_hbox_cell_renderer_append):
1077 * src/widgets/modest-vbox-cell-renderer.c:
1078 (modest_vbox_cell_renderer_append):
1079 Fix the last commit by doing an extra ref.
1081 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1083 * src/widgets/modest-hbox-cell-renderer.c:
1084 (modest_hbox_cell_renderer_append):
1085 * src/widgets/modest-vbox-cell-renderer.c:
1086 (modest_vbox_cell_renderer_append):
1087 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1088 to fix the build with Maemo Bora.
1089 However, there seems to be a remaining crash, probably due to reference
1092 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1094 * src/modest-tny-account.c:
1095 (modest_tny_account_new_for_local_folders):
1096 Use hildon_file_system_info_async_new() to get a better name for
1097 the memory card account, setting it as the account name.
1098 The timing seems to work, but this is probably
1099 not the best place to do this. See the TODO comment.
1100 * src/maemo/modest-main-window.c: (create_details_widget):
1101 * src/widgets/modest-folder-view.c: (text_cell_data):
1102 Use the tny account name instead of hardcoding a name.
1104 2007-05-30 Christian Kellner <ckellner@openismus.com>
1106 * src/modest-search.c: (modest_search):
1107 Correctly set part_search_func even if we have already parsed
1108 the query and thus a valid OgsTextSearcher object.
1110 2007-05-30 Christian Kellner <ckellner@openismus.com>
1113 Search and check for libogs.
1116 Incooparte the ogs build env.
1118 * src/modest-mime-part-search-stream.c:
1119 * src/modest-mime-part-search-stream.h:
1120 Removed since we do the real searching now in modest-search.c.
1122 * src/modest-search.c:
1123 * src/modest-search.h:
1124 Implement support for ogs. We use that if available and requested
1125 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1126 should now handle the corner case when the search term is spread
1127 across multiple reads.
1128 Also the logic in modest_search () was corrected to search all
1129 requested fields until one is found.
1131 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1133 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1135 * src/modest-init.h:
1136 * src/modest-init.c: Made modest_init_local_folders() take a
1137 path and be public so we can iniitialize maildir folders on
1140 * src/modest-local-folder-info.h:
1141 * src/modest-local-folder-info.c:
1142 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1144 * src/modest-tny-account.c:
1145 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1146 still means the standard local-folders path on the local volume.
1148 * src/modest-tny-account-store.c:
1149 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1150 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1151 all accounts when that happens.
1152 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1153 this too, so it shows up in the treeview.
1155 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1157 * src/maemo/modest-maemo-global-settings-dialog.c:
1158 (current_connection):
1159 * src/widgets/modest-global-settings-dialog.c:
1160 (current_connection_default):
1161 Use the enum values instead of 0, 1 and -1,
1162 to make the code clearer.
1164 * src/modest-account-mgr-helpers.c:
1165 (modest_account_mgr_get_connection_specific_smtp): Make this code
1168 * src/modest-runtime.h:
1169 * src/modest-runtime.c:
1170 Added modest_runtime_remove_all_send_queues().
1171 * src/maemo/modest-main-window.c:
1172 (on_account_store_connecting_finished): Recreate the send queues,
1173 using the appropriate transport accounts for this new connection.
1174 Some futher adapting might be needed if the old send queues are not
1175 automatically stopped at this point.
1177 * src/modest-tny-account-store.c: (get_server_accounts):
1178 Create the connection-specific transport accounts, so that they can
1179 be found later by their ID.
1181 * src/modest-tny-account.h:
1182 * src/modest-tny-account.c:
1183 Added modest_tny_account_new_from_server_account_name().
1184 modest_tny_account_new_from_server_account(): Do not create the
1185 send queues here, because they will be
1186 recreated anyway when the connection changes for the first time.
1188 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1190 * src/modest-local-folder-info.h:
1191 * src/modest-local-folder-info.c:
1192 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1193 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1194 tbox_folder): Take a modest account name instead of a server TnyAccount,
1195 so we can have per-modest-account rather than per-transport-account
1197 We must make sure that we change or recreate the exisitng send queues
1198 when the connection changes for connection-specific transport accounts.
1200 * src/modest-tny-account-store.c:
1201 (create_per_account_local_outbox_folders): Create outboxed per modest
1202 account, not per transport account.
1204 * src/modest-tny-account.h:
1205 * src/modest-tny-account.c:
1206 (modest_tny_account_get_special_folder): For outboxes, get the
1207 parent modest account name. The account is ignored for other folders.
1208 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1209 modest account name rather than a server TnyAccount.
1211 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1213 * src/modest-tny-account.c:
1214 (modest_tny_account_new_from_server_account):
1215 Call modest_runtime_get_send_queue() immediately after creating transport
1216 accounts, so that they start trying to send email from the outbox as soon
1217 as possible at startup. This is probably what we want.
1219 * src/modest-mail-operation.c: (update_account_thread):
1220 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1221 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1222 * src/modest-tny-send-queue.h:
1223 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1224 (modest_ui_actions_on_send):
1225 Added comments about how sending works, though it needs some more work.
1227 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1229 * src/modest-tny-account.c:
1230 (modest_tny_account_get_special_folder): Add TODO because this fails when
1231 the network is busy.
1232 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1233 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1234 Do not try to show this window when there is no active account. The UI
1235 specs does not tell us what to do in this case.
1237 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1241 * src/maemo/Makefile.am:
1242 * src/widgets/Makefile.am: Some dist fixes.
1244 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1246 * src/maemo/modest-connection-specific-smtp-window.c:
1247 (on_button_edit): Make the code clearer, to prevent a double free.
1249 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1251 * src/maemo/modest-account-settings-dialog.c:
1252 (modest_account_settings_dialog_set_account_name),
1253 Check the connection-specific smtp servers checkbox if there are any.
1255 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1256 (modest_connection_specific_smtp_edit_window_init):
1257 Start with a suitable port number.
1259 * src/modest-account-mgr-helpers.h:
1260 * src/modest-account-mgr-helpers.c: Added
1261 modest_account_mgr_get_has_connection_specific_smtp().
1263 (modest_account_mgr_set_connection_specific_smtp),
1264 (modest_account_mgr_remove_connection_specific_smtp),
1265 (modest_account_mgr_get_has_connection_specific_smtp),
1266 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1267 connection-specific smtp server accounts in the account, rather than
1268 the server account conf dir.
1270 This fixes bug projects.maemo.org bug NB#58263 .
1272 * src/modest-tny-account-store.c:
1273 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1274 if there are no server accounts yet, to prevent an infinite loop when there
1275 are no accounts. Document that one must be called before the other.
1277 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1279 * src/modest-account-mgr-helpers.c:
1280 (modest_account_mgr_get_default_account): Make sure that at least
1281 one account is always the default, if there are any enabled accounts.
1282 This is just a sanity check that shouldn't be necessary.
1284 * src/modest-account-mgr-priv.c:
1285 (_modest_account_mgr_account_from_key): Unescape the conf key to
1286 get the real account name. For instance, this is an issue if a space
1287 was in the account name, which can happen because the account name
1288 is generated from the display name.
1289 (_modest_account_mgr_get_account_keyname): Always escape the
1291 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1292 Unescape the conf keys to get the real account names.
1294 For instance, previously the is-default radio button in the accounts
1295 list was not checked for any accounts at first. This fixes that,
1296 and might fix several similar bugs.
1298 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1300 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1301 Removed some debug printfs.
1303 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1305 Modest on-disk outbox directories are now here, for instance:
1306 $HOME/.modest/outboxes/<account-id-1>/outbox
1307 $HOME/.modest/outboxes/<account-id-2>/outbox
1309 $HOME/.modest/local-folders/outbox
1310 so we can have a separate outbox for each account.
1311 But they are shown as one outbox in the GtkTreeView, by using a
1312 TnyMergeFolder in a ModestTnySimpleFolderStore.
1315 * src/modest-tny-simple-folder-store.c:
1316 * src/modest-tny-simple-folder-store.h:
1317 Added ModestTnySimpleFolderStore, used to contain folders from
1318 other folder stores, such as other accounts.
1320 * src/modest-tny-outbox-account.h:
1321 * src/modest-tny-outbox-account.c:
1322 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1323 used for the per-account local outbox folders.
1325 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1326 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1327 only use this (internally) now for the non-outbox local folders.
1329 * src/modest-init.h:
1330 * src/modest-init.c: Added modest_init_one_local_folder(), for
1331 setting up the directory structure for each local folder.
1333 * src/modest-local-folder-info.c:
1334 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1335 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1337 * src/modest-local-folder-info.h:
1338 * src/modest-tny-account-store.c: (on_account_removed),
1339 (on_account_changed), (create_per_account_local_outbox_folders),
1340 (get_server_accounts), (modest_tny_account_store_get_accounts),
1341 (modest_tny_account_store_get_tny_account_by_account),
1342 (modest_tny_folder_store_is_virtual_local_folders):
1344 * src/modest-tny-account.h:
1345 * src/modest-tny-account.c:
1346 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1347 to create an on-disk per-account local outbox folder for each
1349 (create_per_account_local_outbox_folders): Create a local outbox folder
1350 for each transport account.
1351 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1352 for all local folders.
1354 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1355 instead of using g_object_get/set() directly. It is clearer.
1357 (modest_tny_folder_store_get_message_count),
1358 (modest_tny_folder_store_get_local_size
1359 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1360 because we now use these with non-acount folder stores.
1362 (modest_tny_account_get_special_folder),
1363 (modest_tny_account_new_from_server_account),
1364 (modest_tny_account_new_from_account):
1365 (recurse_folders): Adjust to the new outbox system.
1367 * src/modest-tny-folder.h:
1368 * src/modest-tny-folder.c:
1369 (modest_tny_folder_is_local_folder),
1370 (modest_tny_folder_get_local_folder_type),
1371 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1373 * src/widgets/modest-main-window.h:
1374 * src/maemo/modest-main-window.c: (create_details_widget),
1375 (modest_main_window_set_contents_style): Show details for any folder store,
1378 (modest_tny_folder_get_rules):
1379 Remove the const. C does not support constness enough for this.
1381 * src/modest-ui-actions.c:
1382 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1383 make all outboxes appear as one, in the usual local-folders tree node.
1385 (set_active_account_from_tny_account),
1386 (modest_ui_actions_on_folder_selection_changed):
1387 * src/widgets/modest-folder-view.c: (text_cell_data),
1388 (icon_cell_data), (filter_row),
1389 (add_account_folders_to_merged_folder),
1390 (add_account_folders_to_simple_folder_store), (),
1391 (get_cmp_rows_type_pos), (cmp_rows),
1392 (modest_folder_view_set_account_id_of_visible_server_account):
1393 Adjust to the new outbox system, using generic folder stores and folders
1394 in the GtkTreeModel.
1396 2007-05-23 Christian Kellner <ckellner@openismus.com>
1398 * src/modest-mail-operation.c:
1399 (modest_mail_operation_update_account):
1400 Use info->max_size instead of unintialized local var [small
1401 build fix]. (Added TODO to review that change since I don't
1404 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1406 * libmodest-dbus-client/libmodest-dbus-client.c:
1407 (libmodest_dbus_client_compose_mail): function added
1408 * src/dbus_api/modest-dbus-api.h:
1409 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1410 (on_compose_mail): Implementation of the SendAsMail functionality
1412 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1414 * src/modest-account-mgr.c:
1415 (modest_account_mgr_add_server_account): Set the secure-connection
1416 conf key for transport accounts as well as store accounts. I don't know
1417 why the if was there. For instance, this makes sure that we use SSL
1418 for the gmail preset from the easysetup wizard.
1420 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1422 * src/gnome/modest-main-window.c:
1423 (on_account_store_connecting_finished), (connect_signals):
1424 * src/maemo/modest-main-window.c:
1425 (on_account_store_connecting_finished), (connect_signals),
1426 (modest_main_window_new):
1427 Handle TnyAccountStore::connecting-finished instead of
1428 TnyDevice::connection-changed, because we cannot actually perform
1429 operations on accounts until TnyAccountStore has itself responded to
1430 the TnyDevice::connection-changed signal. This prevents a GError from
1432 Do not try to update at startup, because we (at least on scratchbox)
1433 already do an update at startup when the device goes online.
1434 This prevents a GError from tinymail.
1435 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1436 Added TODO about stopping simultaneous operations.
1438 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1440 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1441 * src/modest-mail-operation-queue.c:
1442 (modest_mail_operation_queue_remove):
1443 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1444 about where they happened.
1446 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1448 * src/modest-ui-actions.c:
1449 (modest_ui_actions_on_password_requested): Make sure that the remember
1450 output parameter is always TRUE.
1452 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1454 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1455 Show a OK/Cancel dialog if the error is a question, though we still do not
1456 know anything more about what we are asking the user.
1457 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1458 Fix an uninitialized variable (helper). This is a logic error, however.
1460 2007-05-21 Christian Kellner <ckellner@openismus.com>
1462 * src/modest-search.h:
1463 Correct bit shifting in the ModestSearchFlags enum.
1465 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1467 * src/modest-tny-account.c:
1468 (modest_tny_account_new_from_server_account): Do not use the lsub and
1469 check-all hard-coded IMAP options when using POP.
1471 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1473 * src/modest-tny-account.c:
1474 (modest_tny_account_new_from_server_account):
1475 Use NULL for the secure-auth method for POP when Password auth has been
1476 specified by the user, as we already do for IMAP. "auth=Login" causes
1477 an error from camel or the server.
1479 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1481 * src/maemo/modest-account-settings-dialog.c:
1482 (create_page_account_details),
1483 (modest_account_settings_dialog_set_account_name):
1484 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1485 for the leave-on-server checkbox, rathr than just the checkbox, when
1486 the protocol is not POP.
1488 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1490 * src/widgets/modest-account-view.c:
1491 * src/widgets/modest-account-view.h:
1492 Added modest_account_view_select_account() which will be useful later
1493 to asynchronously re-select the edited account.
1495 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1497 * src/maemo/modest-account-settings-dialog.c:
1498 (modest_account_settings_dialog_set_account_name):
1499 Automatically choose the port numbers based on the secure authentication
1500 methods, if they have not been chosen before.
1501 This fixes projects.maemo.org bug NB#56273 .
1503 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1505 * src/maemo/modest-main-window-ui.h:
1506 * src/modest-ui-actions.c:
1507 * src/modest-ui-actions.h:
1508 Connect the Tools/SMTP Servers menu item to
1509 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1510 SMTP servers dialog, as in the UI specification and saves changes when it
1511 is closed. This fixed projects.maemo.org bug NB#56305 .
1513 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1515 * src/maemo/modest-connection-specific-smtp-window.c:
1516 (modest_connection_specific_smtp_window_init):
1517 Use gtk_window_set_default_size() to make this window big enough, so
1518 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1520 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1522 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1523 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1524 (modest_connection_specific_smtp_edit_window_init),
1525 Do not try to connect to a combobox signal before the combobox exists.
1526 This fixes the cras in projects.maemo.org bug NB#56288 .
1527 (modest_connection_specific_smtp_edit_window_get_settings):
1528 Remove the server_account_name parameter which was being checked for NULL
1529 though it was not used.
1531 * src/maemo/modest-connection-specific-smtp-window.c:
1532 (modest_connection_specific_smtp_window_fill_with_connections),
1533 (on_button_edit), (modest_connection_specific_smtp_window_init):
1534 Correct the number of treemodel columns to prevent a warning.
1535 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1536 libconic does not work.
1538 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1540 * src/modest-tny-account.c:
1541 (modest_tny_account_new_from_server_account):
1542 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1543 SMTP when "None" was chosen by the user. However, with my SMTP server that
1544 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1547 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1549 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1550 to explain the memory management issue with the ID in the ModestPair.
1552 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1553 (add_sending_page), (modest_account_assistant_finalize):
1554 * src/gnome/modest-gnome-global-settings-dialog.c:
1555 (create_updating_page), (create_composing_page):
1556 * src/gnome/modest-msg-edit-window.c: (get_transports),
1557 (init_window), (modest_msg_edit_window_finalize),
1558 (modest_msg_edit_window_get_msg_data):
1559 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1560 * src/gnome/modest-transport-widget.c:
1561 (modest_transport_widget_finalize), (smtp_configuration):
1562 * src/maemo/modest-maemo-global-settings-dialog.c:
1563 (create_updating_page), (create_composing_page):
1564 * src/maemo/modest-msg-edit-window.c: (get_transports),
1565 (init_window), (modest_msg_edit_window_finalize),
1566 (modest_msg_edit_window_get_msg_data),
1567 (modest_msg_edit_window_free_msg_data):
1568 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1569 (modest_store_widget_finalize):
1570 * src/maemo/modest-transport-widget.c:
1571 (modest_transport_widget_finalize), (smtp_configuration):
1572 * src/modest-main.c: (send_mail):
1573 * src/widgets/modest-combo-box.h:
1574 * src/widgets/modest-global-settings-dialog-priv.h:
1575 * src/widgets/modest-global-settings-dialog.c:
1576 (modest_global_settings_dialog_finalize):
1577 * src/widgets/modest-msg-edit-window.h:
1578 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1579 as long as the combo box, to prevent use of freed memory for the ID.
1581 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1583 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1584 get_accounts(), to make this clearer. Do not check for the enabled gconf
1585 key, because we do not use this for server accounts (at least, not yet).
1586 This allows us to send email again.
1588 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1590 * src/maemo/modest-platform.c:
1591 (on_modest_conf_update_interval_changed), (modest_platform_init):
1592 Only respond to this particular key change. All these strcmp()s cannot be
1595 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1597 * src/maemo/modest-maemo-global-settings-dialog.c:
1598 (current_connection): Prevent a crash in scratchbox when
1599 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1600 * src/maemo/modest-platform.c:
1601 (on_modest_conf_update_interval_changed), (modest_platform_init):
1602 Get the update interval from gconf and reset it when the gconf key changes.
1604 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1606 * src/modest-protocol-info.c:
1607 * src/modest-protocol-info.h: Adde enum-specific get functions,
1608 instead of using a ModestProtocolType enum parameter.
1610 * src/gnome/modest-account-assistant.c:
1611 * src/gnome/modest-store-widget.c:
1612 * src/gnome/modest-store-widget.h:
1613 * src/gnome/modest-transport-widget.c:
1614 * src/gnome/modest-transport-widget.h:
1615 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1616 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1617 * src/maemo/easysetup/modest-easysetup-wizard.c:
1618 * src/maemo/modest-account-settings-dialog.c:
1619 * src/maemo/modest-account-settings-dialog.h:
1620 * src/maemo/modest-store-widget.c:
1621 * src/maemo/modest-store-widget.h:
1622 * src/maemo/modest-transport-widget.c:
1623 * src/maemo/modest-transport-widget.h:
1624 * src/modest-account-mgr-helpers.c:
1625 * src/modest-account-mgr-helpers.h:
1626 * src/modest-account-mgr.c:
1627 * src/modest-account-mgr.h:
1628 * src/modest-tny-account.c:
1629 * src/modest-tny-folder.c:
1630 * src/widgets/modest-account-view.c:
1631 * src/widgets/modest-retrieve-combo-box.c:
1632 * src/widgets/modest-retrieve-combo-box.h:
1633 * src/widgets/modest-secureauth-combo-box.c:
1634 * src/widgets/modest-serversecurity-combo-box.c:
1635 * src/widgets/modest-serversecurity-combo-box.h:
1636 * tests/check_account-mgr.c:
1637 Use the specific functions, and use the re-renamed enum values for GNOME too.
1639 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1641 * src/modest-pair.h:
1642 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1643 so we can get the second based on the first.
1645 * src/maemo/modest-account-settings-dialog.h:
1646 * src/maemo/modest-account-settings-dialog.c:
1647 Added get_supported_secure_authentication_methods(), though it is mostly
1648 commented-out for now until the necessary API is committed to tinymail.
1649 (modest_account_settings_dialog_set_account_name),
1650 (save_configuration): Request the supported authentication methods from the
1651 server, so we can choose a working method.
1653 * src/modest-tny-account-store.h:
1654 * src/modest-tny-account-store.c:
1655 (modest_tny_account_store_get_session): Rename from
1656 tny_account_store_get_session().
1658 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1660 * src/modest-protocol-info.h: Split the ModestProtocol enum
1661 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1662 There was no need to have these unrelated values in one enum.
1664 * src/: many files: Adapted to changed enum. This makes the code a bit
1665 clearer, and the compiler could catch some errors.
1667 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1669 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1670 Show the detailed internal camel error message when an error happens
1671 during the configuration, so that our testers can give us more clues.
1672 For instance, in projects.maemo.org bug NB#56910 .
1674 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1676 * src/modest-tny-account.c:
1677 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1678 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1680 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1682 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1683 * src/maemo/modest-account-settings-dialog.c:
1684 (modest_account_settings_dialog_set_account_name),
1685 (save_configuration): For the incoming secure authentication checkbox,
1686 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1687 the UI specification. PLAIN does not seem to be supported for most IMAP
1688 servers anyway, and I am not sure what it would mean.
1689 However, we probably need to discover which of the secure-authentication
1690 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1691 * src/modest-account-mgr-helpers.c:
1692 (modest_account_mgr_get_server_account_data):
1694 * src/modest-tny-account.c:
1695 (modest_tny_account_new_from_server_account):
1696 Use tny_account_set_mech() to set secure-authentication methods,
1697 with some special-casing for IMAP, based on my observations of how
1700 * src/modest-account-mgr-helpers.h:
1701 * src/modest-account-mgr.c:
1702 * src/modest-defs.h: Comment that the URI is only used for local folders.
1704 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1706 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1707 parameter const, just to be neat.
1708 * src/modest-text-utils.c: (modest_text_utils_inline):
1709 End g_strconcat() with NULL, as its documentation says. This is almost
1710 certainly the cause of my crash at startup on the device. Interestingly,
1711 valgrind doesn't tell us about these errors.
1713 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1715 * scripts/build-packages: Added more precise comments about how to use
1716 this script, though I still get this error:
1717 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1718 error building tinymail
1720 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1722 * src/maemo/modest-main-window.c: (on_account_update):
1723 Very slight cleanup, hoping to make it simpler to discover what causes
1724 a crash here sometimes.
1726 * src/modest-tny-account.c:
1727 (modest_tny_account_new_from_server_account): Set the port. Added
1728 comments about the options and a TODO comment because I need to find out
1729 how to specify the secure authentication method.
1731 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1733 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1734 changed CFlags paths form modest to libmodest
1736 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1738 * src/modest-account-mgr-helpers.c:
1739 (modest_account_mgr_get_server_account_data),
1740 (modest_account_mgr_free_server_account_data):
1741 * src/modest-account-mgr-helpers.h:
1742 * src/modest-account-mgr.c:
1743 (modest_account_mgr_add_server_account):
1744 * src/modest-defs.h:
1745 * src/modest-tny-account.c:
1746 (modest_tny_account_new_from_server_account):
1747 Determine the options for tny_camel_account_add_option() here,
1748 based on the settings, rather than storing them directly in gconf.
1750 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1752 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1753 Show a more friendly error dialog now that we expect (from the tinymail
1754 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1756 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1758 * src/maemo/modest-main-window.c: (on_account_update): Check that
1759 account_name is not NULL, to prevent a crash at startup that I am
1760 seeing on the N800. I do wonder why it is NULL.
1762 * src/maemo/easysetup/modest-easysetup-wizard.c:
1763 (create_page_user_details):
1764 * src/maemo/modest-account-settings-dialog.c:
1765 (create_page_user_details), (create_page_outgoing):
1766 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1767 (modest_connection_specific_smtp_edit_window_init):
1768 * src/modest-ui-actions.c:
1769 (modest_ui_actions_on_password_requested):
1770 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1771 might do something useful with the on-screen keyboard.
1773 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1775 * src/maemo/modest-main-window.c: (on_account_update):
1776 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1777 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1779 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1781 * src/modest-tny-account-store.c: (on_account_changed):
1782 Correct the signature of this signal handler.
1784 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1786 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1787 Show a HildonNote instead of a GtkDialog for Maemo.
1789 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1791 * src/widgets/modest-account-view.h:
1792 * src/widgets/modest-account-view.c: (on_account_changed),
1793 (on_account_removed). Added a boolean flag, set/unset by
1794 modest_account_view_block_conf_updates(),
1795 modest_account_view_unblock_conf_updates() to prevent unnecessary
1796 updates, but this is not very useful because the gconf notifications are
1797 so delays (maybe only on Maemo Bora).
1798 So auto-updating is turned off, and these functions do an explicit
1799 update when necessary.
1800 However, something else is still doing too much work when adding/removing
1801 accounts, probably in another part of the application.
1803 * src/maemo/modest-account-view-window.c:
1804 (on_delete_button_clicked), (on_edit_button_clicked),
1805 (on_new_button_clicked): Use the new functions.
1807 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1809 * src/modest-account-mgr-helpers.c:
1810 (modest_account_mgr_set_first_account_as_default):
1811 Sort the list of names alphabetically-by-title, so we choose the first one
1813 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1814 alphabetically by the title.
1816 This fixes projects.maemo.org bug NB#56418 .
1818 * src/modest-account-mgr-priv.c:
1819 (_modest_account_mgr_account_from_key):
1820 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1821 avoid a valgrind error, and possible random behaviour.
1823 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1825 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1826 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1827 tinymail documentation to say that this can be expected.
1828 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1829 pretty, and should not happen, but I would prefer to know when it does.
1831 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1833 * configure.ac: When using the older hildon version, probably on Bora,
1834 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1836 * src/widgets/modest-attachment-view.c:
1837 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1840 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1842 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1843 Implemented the prototype. Can be tested with
1844 tests/dbus_api/test_open_message:
1846 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1848 * src/modest-tny-account-store.c:
1849 (modest_tny_account_store_instance_init), (get_password):
1850 * src/modest-ui-actions.c:
1851 (modest_ui_actions_on_password_requested):
1852 Do not store the password in gconf, because this function is called
1853 for non-remembered passwords. Actually use the cached (in the hash map)
1854 password instead of releasing it.
1855 The password will now not be remembered if it is asked via the protected
1856 password dialog, as per the UI spec.
1858 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1860 * src/modest-defs.h:
1861 * src/modest-account-mgr-helpers.h:
1862 * src/modest-account-mgr-helpers.c:
1863 Added modest_server_account_get_username_has_succeeded(),
1864 modest_server_account_set_username_has_succeeded().
1865 (modest_server_account_set_username),
1866 Reset the has-succeeded flag if the username changes.
1868 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1869 * src/maemo/modest-connection-specific-smtp-window.c:
1870 (modest_connection_specific_smtp_window_save_server_accounts):
1871 Use modest_server_account_set_username() instead of using
1872 modest_conf_set_string() directly, so that the has-succeeded flag is always
1875 * src/modest-ui-actions.c:
1876 (modest_ui_actions_on_password_requested): Dim the username entry if
1877 the username has ever worked, as per the UI spec.
1879 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1881 * src/modest-tny-account-store.c: (get_password):
1882 * src/modest-ui-actions.c:
1883 (modest_ui_actions_on_password_requested):
1884 Allow the username to be changed too, though there is more work to
1885 be done on exactly how this behaves.
1887 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1889 * src/modest-account-mgr-helpers.h:
1890 * src/modest-account-mgr-helpers.c:
1891 Added modest_account_mgr_get_display_name(),
1892 modest_server_account_get_username(),
1893 modest_server_account_set_username(),
1894 modest_server_account_set_password(),
1895 modest_server_account_get_hostname() functions so we do not need to
1896 use the conf API directly.
1898 * src/maemo/modest-main-window.c: (connect_signals):
1899 Actually connect ot the ModestAccountStore::request-password signal,
1900 so that we show the dialog when the password is requested by Tinymail,
1901 for isntance if it is empty.
1903 * src/modest-marshal.list:
1904 * src/modest-tny-account-store.c:
1905 (modest_tny_account_store_class_init), (get_password),
1906 (modest_tny_account_store_alert):
1907 * src/modest-tny-account-store.h:
1908 * src/modest-ui-actions.h:
1909 * src/modest-ui-actions.c:
1910 (modest_ui_actions_on_password_requested):
1911 Change the signal parameters, so it is obvious that we are providing
1912 the non human-readable server name, and receiving both the username
1913 and password, though changing of the username is not yet implemented.
1914 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1915 for the GNOME version.
1917 This should fix the projects.maemo.org bug NB#56209, though it does not
1918 work on Bora, because the gconf_client_get() for the password fails
1919 immediately after we save it with gconf_client_set().
1921 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1924 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1925 caused an undefined symbol error:
1926 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1928 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1930 * src/modest-tny-account-store.c:
1931 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1932 using a GError instead of a string message, so we can translate it in
1935 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1937 * src/maemo/modest-address-book.c:
1938 (modest_address_book_check_names):
1939 * src/maemo/modest-msg-view-window.c:
1940 (modest_msg_view_window_clipboard_owner_change):
1941 * src/modest-init.c: (modest_init_init_ui):
1942 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1943 (update_folders_cb), (modest_mail_operation_update_account):
1944 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1945 (modest_ui_actions_on_msg_attachment_clicked),
1946 (modest_ui_actions_on_msg_recpt_activated):
1947 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1948 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1949 (modest_msg_view_search_next):
1950 * src/widgets/modest-recpt-editor.c:
1951 (modest_recpt_editor_on_button_release_event),
1952 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1953 g_message(). At this point we should only be seeing interesting errors on
1954 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1956 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1958 (modest_wizard_dialog_force_title_update):
1959 * src/maemo/easysetup/modest-wizard-dialog.h:
1960 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1961 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1962 can update the title when appropriate. Otherwise the title is wrong if the
1963 pages are added after adding the notebook to the dialog.
1964 This must be a problem in HildonWizardDialog too.
1965 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1967 * src/maemo/easysetup/modest-easysetup-wizard.c:
1968 (create_subsequent_customsetup_pages),
1969 (create_subsequent_easysetup_pages):
1970 Call modest_wizard_dialog_force_title_update() so that the title is
1971 correct even with GTK+ < 2.10.
1972 This fixes projects.maemo.org bug NB#56145 .
1974 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1976 * src/maemo/modest-platform.c:
1977 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1978 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1981 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1983 * src/widgets/modest-window.h:
1984 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1985 and modest_window_save_state(), which invokes it.
1987 * src/widgets/modest-window-mgr.h:
1988 * src/widgets/modest-window-mgr.c:
1989 Added modest_window_mgr_save_state_for_all_windows(), which calls
1990 the save_state vfunc on all registered windows, if implemented.
1992 * src/gnome/modest-msg-edit-window.c:
1993 * src/gnome/modest-msg-view-window.c:
1994 * src/maemo/modest-msg-edit-window.c:
1995 * src/maemo/modest-msg-view-window.c:
1996 * src/maemo/modest-main-window.c:
1997 Specify the existing save_settings functions as implementations of
1998 ModestWindow::save_state_func().
2000 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2001 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2002 enabling hibernation, for instance.
2004 We may need to do the same thing for restoring settings.
2007 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2009 * src/widgets/modest-window-mgr.c:
2010 * src/widgets/modest-window-mgr.h:
2011 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2012 modest_window_mgr_get_hibernation_is_prevented().
2014 * src/maemo/modest-main-window.c:
2015 (on_hildon_program_is_topmost_notify): Prevent hibernation
2016 (possible when the application goes to the background in the WM),
2017 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2019 * src/maemo/easysetup/modest-easysetup-wizard.c:
2020 (modest_easysetup_wizard_dialog_init):
2021 * src/maemo/modest-account-settings-dialog.c:
2022 (modest_account_settings_dialog_init):
2023 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2024 (modest_connection_specific_smtp_edit_window_init):
2025 * src/maemo/modest-connection-specific-smtp-window.c:
2026 (modest_connection_specific_smtp_window_init):
2027 * src/maemo/modest-signature-editor-dialog.c:
2028 (modest_signature_editor_dialog_init):
2029 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2030 prevent hibernation while any of these account settings dialogs are open.
2032 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2034 * src/maemo/Makefile.am:
2035 * src/maemo/modest-osso-state-saving.c:
2036 * src/maemo/modest-osso-state-saving.h: Added
2037 modest_osso_load_state() and modest_osso_save_state() though they do
2038 nothing now. They should iterate through all the open windows and load/save
2040 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2041 save state when closing.
2043 * src/maemo/modest-main-window.c:
2044 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2045 Add a notification handler for the HildonProgram::is-topmost property,
2046 so we can allow hibernation when the application goes into the background.
2047 But we still need to detect when the accounts setup windows are open so
2048 we can stop hibernation when they are open.
2049 To do this, I also added the main window the HildonProgram. This might have
2050 other side-effects/benefits, and should maybe be done for other windows.
2052 * src/maemo/modest-osso-autosave-callbacks.h:
2053 * src/maemo/modest-osso-autosave-callbacks.c:
2054 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2055 though it does not do anything yet, and we might never need this to do
2056 anything. For instance, we already save drafts.
2058 * src/maemo/modest-platform.c: (modest_platform_init):
2059 Specify the libosso auto-save callback.
2061 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2063 * src/maemo/modest-platform.c:
2064 (modest_platform_set_update_interval):
2065 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2066 aparently stays valid between application instances, so we can use this
2067 to remove and reset it later. According to a maemo-developers email from
2070 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2072 * configure.ac: Depend on libalarm for Maemo.
2074 * src/dbus_api/modest-dbus-api.h:
2075 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2076 (on_send_receive), (modest_dbus_req_handler):
2077 Handle a SEND_RECEIVE D-Bus method.
2079 * libmodest-dbus-client/libmodest-dbus-client.c:
2080 (libmodest_dbus_client_send_and_receive):
2081 * libmodest-dbus-client/libmodest-dbus-client.h:
2082 Add C convenience functions for calling the new D-Bus method.
2084 * src/modest-platform.h:
2085 * src/gnome/modest-platform.c:
2086 * src/maemo/modest-platform.c:
2087 Added modest_platform_set_update_interval(), which uses the
2088 alarmd API on Maemo.
2089 (modest_platform_init),
2090 Call modest_platform_set_update_interval(), using a hard-coded
2091 interval for now (until the global settings dialog is implemented),
2092 though I am not sure that this makes sense yet.
2094 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2096 * src/dbus_api/modest-dbus-callbacks.c:
2097 (modest_osso_cb_hw_state_handler):
2098 * src/dbus_api/modest-dbus-callbacks.h:
2099 * src/maemo/modest-platform.c: (modest_platform_init):
2100 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2101 in case this has some effect on the ability for Maemo to ping the
2104 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2106 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2107 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2108 warning. It is probably a logic error, but I need to fix the build.
2110 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2112 * src/modest-account-mgr.h:
2113 * src/modest-account-mgr.c:
2114 (modest_account_mgr_account_names): Add a gboolean enabled_only
2115 parameter, so we can get lists of onlt the enabled accounts.
2117 (modest_account_mgr_add_account),,
2118 (modest_account_mgr_account_with_display_name_exists):
2119 * src/maemo/modest-msg-edit-window.c: (get_transports):
2120 * src/modest-account-mgr-helpers.c:
2121 (modest_account_mgr_set_first_account_as_default):
2122 * src/modest-init.c: (init_default_account_maybe):
2123 * src/modest-tny-account-store.c: (get_accounts):
2124 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2125 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2126 * tests/check_account-mgr.c: (START_TEST):
2127 Provide the extra parameter, as appropriate.
2129 * src/widgets/modest-account-view.c: (update_account_view):
2130 Do not show disabled accounts (meaning that there is no way to
2131 enable/disable accounts in the UI (the feature is not in our UI
2132 specification), so we can use this internally only to mark unfinished
2133 or temporary account data.
2135 * src/maemo/easysetup/modest-easysetup-wizard.c:
2136 (create_account): Add boolean enable parameter, so we can specify FALSE
2137 to create the temporary account.
2138 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2139 (on_before_next): When finishing, when there is a temporary account, just
2141 Also, use a timeout to delay the showing of the dialog until gconf is likely
2142 to return correct information, due to a maemo gconf bug that is fixed in
2143 osso 1.1, but not yet in Bora.
2144 However, the dialog stays on screen after it is destroyed.
2146 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2147 for invalid data when cancelling. Use a hildon note instead of a dialog
2148 to complain about invalid data. Do not show the account-saved note if the
2149 account is disabled (a temporary account that will not really be saved for use
2152 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2154 * src/modest-account-mgr-helpers.h:
2155 * src/modest-account-mgr-helpers.c:
2156 Added modest_account_mgr_unset_default_account(),
2157 Added modest_account_mgr_set_first_account_as_default().
2159 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2160 If it was the default account, unset the default account name.
2162 * src/maemo/modest-account-view-window.c:
2163 (on_delete_button_clicked): If it was the default account,
2164 set the first remaining account as the default instead.
2166 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2167 a NULL account or a NULL default account, to prevent a crash. This should
2168 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2171 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2173 * src/widgets/modest-recpt-editor.c:
2174 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2175 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2176 TODO comment for this. This fixes the build.
2178 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2179 be the best place for it. This will in future update all auto-update accounts,
2180 rather than just the current/default account, when that gconf key exists.
2181 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2182 if there are no accounts, before calling do_send_receive().
2183 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2185 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2186 * src/maemo/modest-main-window-ui.h:
2187 * src/maemo/modest-main-window.c: (on_connection_changed),
2188 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2189 directly, becaue the signal handler does more.
2191 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2193 * src/modest-account-mgr-helpers.c:
2194 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2195 for the case that the account does not exist.
2197 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2198 (equivalent to the modest account name) rather than the tinymail account name
2199 (equivalent to the modest account title - human readable) to get the account data.
2200 Check for null account data to prevent the crash, and add a TODO comment saying that
2201 this needs fixing because it is using the server account name instead of the account name.
2203 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2205 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2206 * src/maemo/modest-account-settings-dialog.c: (show_error),
2208 Use hildon_note_new_information() for informative and error messages,
2209 which seems to be expected for Maemo applications (no documentation that I know of
2210 says this). I am surprised that there is no distinction between info and error
2213 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2215 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2216 it is easy to find where this is used.
2218 * src/maemo/easysetup/modest-easysetup-wizard.c:
2219 (create_page_welcome), (create_page_account_details),
2220 (create_page_user_details), (create_page_complete_easysetup),
2221 (create_page_custom_incoming), (create_page_custom_outgoing),
2222 (create_page_complete_custom):
2223 * src/maemo/modest-account-settings-dialog.c:
2224 (create_page_account_details), (create_page_user_details),
2225 (create_page_incoming), (create_page_outgoing):
2226 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2227 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2228 (modest_connection_specific_smtp_edit_window_init):
2229 * src/maemo/modest-connection-specific-smtp-window.c:
2230 (modest_connection_specific_smtp_window_init):
2231 * src/maemo/modest-signature-editor-dialog.c:
2232 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2233 and scrolling policy as per the Email Application Layout Guide, if I have
2236 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2238 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2239 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2240 which were empty, because these vfuncs have been removed from TnyAccountStore.
2241 This fixes the build.
2243 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2245 * src/maemo/modest-main-window.c:
2246 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2247 showing/hiding it. Added TODO because it probably should not be NULL.
2248 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2249 because unnecessary g_warnings() make degugging difficult.
2251 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2253 * src/maemo/modest-msg-edit-window.c:
2254 (modest_msg_edit_window_select_color),
2255 (modest_msg_edit_window_select_background_color): 2 const corrections and
2256 moving 2 #endifs before closing brackets, to fix the build.
2258 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2260 * src/maemo/easysetup/modest-easysetup-wizard.h:
2261 * src/maemo/easysetup/modest-easysetup-wizard.c:
2262 (modest_easysetup_wizard_dialog_finalize),
2263 (on_button_edit_advanced_settings), (create_page_complete_custom),
2264 (on_response), (create_account):
2265 Implement the Advanced Settings edit button, by saving the account information,
2266 for the Advanded Settings dialog to use directly from gconf, and removing it
2267 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2268 Bug #5533 in the projects.maemo.org bugzilla.
2270 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2272 * src/maemo/modest-msg-view-window.c:
2273 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2274 when opening a message window.
2276 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2278 * src/maemo/easysetup/modest-easysetup-wizard.c:
2279 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2282 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2283 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2284 gconf settings. I probably added more checks than necessary, but that is safer.
2286 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2287 variable to fix the build, but this seems to be used when it is still NULL.
2289 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2291 * src/modest-platform.h:
2292 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2293 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2294 * src/modest-main.c: Implement this function so we can avoid using
2295 maemo-specific API from cross-platform code.
2297 * src/modest-tny-account-store.c:
2298 (get_smtp_specific_transport_account_for_open_connection):
2299 * src/modest-ui-actions.c: (check_for_connection),
2300 (modest_ui_actions_on_item_not_found):
2301 Use modest_platform_connect_and_wait() and put #idefs around other
2302 maemo-specific code, because only maemo currently has a way to
2303 identify connection names.
2305 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2307 * src/modest-tny-account-store.h:
2308 * src/modest-tny-account-store.c:
2309 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2310 the connection-specific SMTP server settings in the configuration.
2312 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2314 * src/maemo/modest-main-window.c: (on_connection_changed),
2316 * src/modest-main.c: (main), (start_ui), (send_mail):
2317 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2318 that is what is intended.
2320 * src/modest-ui-actions.c: (action_send), (action_receive),
2321 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2322 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2323 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2324 SMTP server is used when it is specified.
2326 (modest_ui_actions_on_send_receive):
2327 Check that a connection is open before proceeding.
2328 Receive and then send, instead of vice-versa, as per the specification.
2330 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2332 * src/modest-mail-operation.c:
2333 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2334 though I guess it should be something other than NULL.
2336 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2338 * src/maemo/easysetup/modest-easysetup-wizard.c:
2339 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2340 combo twice, to avoid an g_warning and to make it visible again.
2341 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2342 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2343 (already intended) dereference when detaching, because we then recreate the menu.
2344 But I am not sure why the warning was happening, and it is possible that this is a memory
2347 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2349 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2350 and uri_parse_mailto() utility functions.
2351 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2353 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2355 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2357 * src/dbus_api/modest-dbus-api.h:
2358 * src/dbus_api/modest-dbus-callbacks.c:
2359 Use an idle callback to execute the modest code in the application's own thread.
2360 Remove the helloworld example method.
2361 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2362 parsed, and the open-message method is not implemented because this is not yet implemented in
2364 * libmodest-dbus-client/libmodest-dbus-client.c:
2365 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2366 (libmodest_dbus_client_open_message):
2367 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2369 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2370 body without crashing.
2372 * tests/dbus_api/Makefile.am:
2373 * tests/dbus_api/test_mail_to.c:
2374 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2376 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2378 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2379 Added file to fix the build. Sorry.
2381 * src/dbus_api/Makefile.am:
2382 * src/dbus_api/modest-dbus-api.h:
2383 * src/dbus_api/modest-dbus-callbacks.h:
2384 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2385 (modest_dbus_req_handler):
2386 Put constants in a separate header so it can be reused by the
2387 client library, without duplication
2389 * libmodest-dbus-client/Makefile.am:
2390 * libmodest-dbus-client/libmodest-dbus-client.c:
2391 (libmodest_dbus_client_call_helloworld),
2392 (libmodfest_dbus_client_send_mail),
2393 (libmodfest_dbus_client_mailto),
2394 (libmodfest_dbus_client_open_message):
2395 * libmodest-dbus-client/libmodest-dbus-client.h:
2396 (Partly) Implement a send_mail D-Bus method.
2398 * tests/dbus_api/Makefile.am:
2399 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2400 the send_email D-Bus method.
2402 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2406 * libmodest-dbus-client/Makefile.am:
2407 * libmodest-dbus-client/libmodest-dbus-client.c:
2408 * libmodest-dbus-client/libmodest-dbus-client.h:
2409 * tests/dbus_api/Makefile.am:
2410 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2411 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2413 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2415 * src/maemo/easysetup/modest-easysetup-wizard.c:
2416 (create_page_account_details):
2417 * src/maemo/modest-account-settings-dialog.c:
2418 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2419 widgets, because this might not be the default in future versions of the Maemo GTK+.
2420 However, I can not not get capitalization to work even in a simple test case.
2422 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2424 * src/maemo/easysetup/modest-easysetup-wizard.c:
2425 (create_page_custom_incoming), (create_page_custom_outgoing):
2426 * src/maemo/modest-account-settings-dialog.c:
2427 (create_page_account_details), (create_page_incoming),
2428 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2429 instead of using gtk_check_button_with_label(), so they are aligned like the other
2430 widgets, as per the UI spec.
2432 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2434 * src/maemo/easysetup/modest-easysetup-wizard.c:
2435 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2436 * src/widgets/modest-validating-entry.c:
2437 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2438 Modest prefix instead of an EasySetup prefix.
2440 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2442 * src/widgets/modest-validating-entry.h:
2443 * src/widgets/modest-validating-entry.c: (on_insert_text),
2444 Added easysetup_validating_entry_set_max_func(), used to set a callback
2445 to call when the max number of characters is reached. GtkEntry has a max-length
2446 already but is silent about it.
2448 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2449 (create_page_account_details), (create_page_user_details),
2451 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2452 (create_page_account_details), (create_page_user_details),
2453 (create_page_outgoing):
2454 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2455 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2456 the UI spec, when the user tries to enter more than the max number of characters.
2458 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2460 * src/maemo/easysetup/modest-easysetup-wizard.c:
2461 (create_page_user_details), (create_page_custom_incoming),
2462 (create_page_custom_outgoing):
2463 * src/maemo/modest-account-settings-dialog.c:
2464 (create_page_user_details), (create_page_incoming),
2465 (create_page_outgoing):
2466 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2467 (modest_connection_specific_smtp_edit_window_init):
2468 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2469 not appropriate. Bad Maemo-specific defaults!.
2471 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2473 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2474 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2475 (modest_signature_editor_dialog_set_settings):
2476 Disable the label and textview when the checkbox is disabled, and use the
2477 specified (UI spec) default signature text.
2479 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2481 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2482 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2484 * src/modest-defs.h:
2485 * src/modest-account-mgr-helpers.h:
2486 * src/modest-account-mgr-helpers.c:
2487 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2489 * src/maemo/Makefile.am:
2490 * src/maemo/modest-signature-editor-dialog.c:
2491 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2494 * src/maemo/modest-account-settings-dialog.h:
2495 * src/maemo/modest-account-settings-dialog.c:
2496 (modest_account_settings_dialog_finalize), (on_button_signature),
2497 (save_configuration): Use the new dialog when the Edit button is pressed, and
2498 save the changes if necessary, as per the UI spec.
2500 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2502 * src/maemo/Makefile.am:
2503 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2504 based on maemo-develoers email from Dirk.
2506 * src/maemo/easysetup/modest-easysetup-wizard.c:
2507 (create_page_welcome), (create_page_account_details),
2508 (create_page_user_details), (create_page_complete_easysetup),
2509 (create_page_custom_incoming), (create_page_custom_outgoing),
2510 (create_page_complete_custom),
2511 (modest_easysetup_wizard_dialog_init):
2512 * src/maemo/modest-account-settings-dialog.c:
2513 (create_page_account_details), (create_page_user_details),
2514 (create_page_incoming), (create_page_outgoing),
2515 (modest_account_settings_dialog_init):
2516 * src/maemo/modest-connection-specific-smtp-window.c:
2517 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2519 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2521 * src/maemo/easysetup/modest-easysetup-wizard.c:
2522 (create_page_account_details), (create_page_custom_outgoing),
2523 (create_page_complete_custom):
2524 * src/maemo/modest-account-settings-dialog.c:
2525 (create_page_user_details), (create_page_incoming),
2526 (create_page_outgoing):
2527 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2528 (modest_connection_specific_smtp_edit_window_init):
2529 Use the correct (UI spec) port min/max, and use horizontal separators,
2532 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2534 * src/maemo/easysetup/modest-easysetup-wizard.c:
2535 (set_default_custom_servernames):
2536 * src/maemo/modest-account-settings-dialog.c:
2537 (create_page_incoming), (on_combo_outgoing_security_changed),
2538 (on_combo_incoming_security_changed), (create_page_outgoing),
2539 (modest_account_settings_dialog_set_account_name),
2540 (save_configuration):
2541 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2542 (on_combo_security_changed),
2543 (modest_connection_specific_smtp_edit_window_init),
2544 (modest_connection_specific_smtp_edit_window_set_connection),
2545 (modest_connection_specific_smtp_edit_window_get_settings):
2546 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2549 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2552 * src/maemo/easysetup/modest-easysetup-wizard.c:
2553 (create_page_custom_outgoing), (create_page_complete_custom):
2554 * src/maemo/modest-account-settings-dialog.c:
2555 (create_page_user_details), (create_page_outgoing):
2556 * src/maemo/modest-account-view-window.c: (button_box_new):
2557 Use changed logical IDs as per the most recent UI spec:
2558 mcen_bd_emailsetup_edit -> mcen_bd_edit
2559 mcen_bd_emailsetup_delete -> mcen_bd_delete
2560 mcen_bd_emailsetup_close -> mcen_bd_close
2562 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2566 * src/dbus_api/Makefile.am:
2567 * src/dbus_api/modest-dbus-callbacks.c:
2568 * src/dbus_api/modest-dbus-callbacks.h:
2569 * src/maemo/modest-platform.c: (modest_platform_init):
2570 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2572 * tests/Makefile.am:
2573 * tests/dbus_api/Makefile.am:
2574 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2576 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2578 * src/maemo/modest-account-settings-dialog.c:
2579 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2580 Removed unnecessary includes.
2582 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2584 * src/maemo/easysetup/modest-easysetup-wizard.c:
2585 * src/maemo/modest-account-settings-dialog.c:
2586 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2587 * src/widgets/Makefile.am:
2588 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2589 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2590 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2591 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2592 * src/widgets/modest-secureauth-combo-box.c:
2593 * src/widgets/modest-secureauth-combo-box.h:
2594 * src/widgets/modest-serversecurity-combo-box.c:
2595 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2596 made the GObject names more consistent with the rest of the Modest code.
2598 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2600 * src/maemo/easysetup/Makefile.am:
2601 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2602 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2603 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2604 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2605 * src/maemo/easysetup/modest-easysetup-wizard.c:
2606 * src/maemo/easysetup/modest-validating-entry.c:
2607 * src/maemo/easysetup/modest-validating-entry.h:
2608 * src/maemo/modest-account-settings-dialog.c:
2609 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2610 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2611 widgets/ because they are used outside of easysetup too. After checking in,
2612 svn will allow me to rename them too.
2614 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2616 * src/gnome/modest-msg-edit-window.c:
2617 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2618 linker error, to fix the build on the GNOME platform.
2619 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2620 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2621 ifdefed out to avoid a warning.
2623 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2625 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2626 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2627 some alternative for GTK+ 2.6.
2629 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2631 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2633 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2634 specified for EmailAccountsDialog in UI spec.
2636 * src/maemo/easysetup/modest-easysetup-wizard.c:
2637 * src/maemo/easysetup/modest-easysetup-wizard.h:
2638 * src/maemo/modest-account-settings-dialog.c:
2639 * src/maemo/modest-account-settings-dialog.h:
2640 Reuse a member window widget for the connection-specific SMTP server accounts,
2641 so we can tell it to create/save the accounts only if we actually save changes.
2643 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2644 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2645 (modest_connection_specific_smtp_edit_window_get_settings):
2646 Return a struct instance for temporarily remembering the entered data.
2648 * src/maemo/modest-connection-specific-smtp-window.h:
2649 * src/maemo/modest-connection-specific-smtp-window.c:
2650 (modest_connection_specific_smtp_window_finalize),
2651 (modest_connection_specific_smtp_window_fill_with_connections),
2653 (modest_connection_specific_smtp_window_save_server_accounts),
2654 (update_model_server_names): Do not actually save data until asked,
2655 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2657 (on_selection_changed),
2658 (modest_connection_specific_smtp_window_init): Disable the edit
2659 button when nothing is selected.
2661 * src/modest-account-mgr-helpers.c:
2662 * src/modest-account-mgr-helpers.h:
2663 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2666 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2668 * src/modest-account-mgr-helpers.h:
2669 * src/modest-account-mgr-helpers.c:
2670 (modest_account_mgr_get_unused_account_name),
2671 (modest_account_mgr_get_unused_account_display_name): Added these
2672 utility functions, to avoid code duplication.
2674 * src/maemo/easysetup/modest-easysetup-wizard.c:
2675 (create_page_account_details), (create_account):
2676 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2677 (on_combo_security_changed),
2678 (modest_connection_specific_smtp_edit_window_init),
2679 (modest_connection_specific_smtp_edit_window_save_settings):
2680 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2681 * src/maemo/modest-connection-specific-smtp-window.c:
2682 (modest_connection_specific_smtp_window_finalize),
2683 (modest_connection_specific_smtp_window_fill_with_connections),
2684 (on_button_edit), (modest_connection_specific_smtp_window_init):
2685 * src/maemo/modest-connection-specific-smtp-window.h:
2686 Implementing saving of connection-specific server accounts.
2688 But I need to refactor this so we can save the data for each
2689 possible connection-specific account and only actually create the server accounts
2690 when the easysetup finished, or the OK button is pressed on the account settings
2693 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2695 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2696 (on_combo_security_changed):
2697 (modest_connection_specific_smtp_edit_window_init):
2698 Auto-fill the port number as in the account settings.
2700 (modest_connection_specific_smtp_edit_window_set_connection):
2701 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2702 * src/maemo/modest-connection-specific-smtp-window.c:
2703 (fill_with_connections), (on_button_edit),
2704 (modest_connection_specific_smtp_window_init):
2705 Turn the edit window into a dialog to simplify the code, and
2706 set a WM hint as in a GtkDialog, because only a popup can be on top of
2707 another window in Maemo, and popups usually have no WM decoration.
2709 * src/modest-defs.h:
2710 * src/modest-account-mgr-helpers.c:
2711 (modest_account_mgr_set_connection_specific_smtp),
2712 (modest_account_mgr_remove_connection_specific_smtp),
2713 (modest_account_mgr_get_connection_specific_smtp):
2714 * src/modest-account-mgr-helpers.h: Some functions to write the
2715 connection-specific SMTP server information. Not yet used.
2718 * src/widgets/modest-folder-view.c: (text_cell_data):
2719 Fix a warning about an uninitialized variable.
2720 (on_configuration_key_changed): Put an #ifdef around the use
2721 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2723 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2725 * src/maemo/modest-account-settings-dialog.h:
2726 * src/maemo/modest-account-settings-dialog.c:
2727 Added connect_for_modified() utility function to mark the new modified boolean.
2729 (create_page_account_details), (create_page_user_details),
2730 (create_page_incoming), (create_page_outgoing), (on_response),
2731 (modest_account_settings_dialog_init),
2732 (modest_account_settings_dialog_set_account_name):
2733 Only warn about unsaved changes when there are actually unsaved changes.
2735 * src/modest-account-mgr-helpers.c:
2736 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2737 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2738 to get the data from there in future.
2740 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2742 * src/modest-defs.h:
2744 * src/modest-account-mgr-helpers.h:
2745 * src/modest-account-mgr-helpers.c:
2746 Store the security account setting in a single conf key instead of using
2747 the options list, so that the list is left for just the to-be-removed camel hack,
2748 and because gconf_client_set_list() is failing for some reason.
2750 * src/modest-account-mgr.c:
2751 (modest_account_mgr_add_server_account):
2752 * src/maemo/modest-account-settings-dialog.c:
2753 (modest_account_settings_dialog_set_account_name),
2754 (save_configuration): Use the renamed functions.
2757 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2759 * src/widgets/Makefile.am:
2760 * src/widgets/modest-limit-retrieve-combo-box.c:
2761 * src/widgets/modest-limit-retrieve-combo-box.h:
2762 * src/widgets/modest-retrieve-combo-box.c:
2763 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2764 the account settings dialog.
2766 * src/modest-defs.h:
2767 * src/modest-account-mgr-helpers.h:
2768 * src/modest-account-mgr-helpers.c:
2769 (modest_server_account_get_option_secure_auth),
2770 (modest_server_account_set_option_secure_auth):
2771 * src/modest-account-mgr.c:
2772 (modest_account_mgr_add_server_account):
2773 Use the existing AUTH_MECH conf key for the secure-auth setting,
2774 instead of putting it in the list options, because this was actually used already.
2776 * src/maemo/modest-account-settings-dialog.c:
2777 (create_page_account_details),
2778 (modest_account_settings_dialog_set_account_name),
2779 (save_configuration):
2780 * src/maemo/modest-account-settings-dialog.h:
2781 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2782 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2784 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2786 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2787 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2788 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2790 * src/modest-defs.h:
2791 * src/maemo/modest-account-settings-dialog.c:
2792 (create_page_incoming), (on_combo_outgoing_security_changed),
2793 (on_combo_incoming_security_changed), (create_page_outgoing),
2794 (modest_account_settings_dialog_set_account_name),
2795 (save_configuration): Load/Save the port number, and change it when the
2796 security combo changes, to suitable defaults.
2798 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2800 * src/modest-account-mgr.c:
2801 (modest_account_mgr_add_server_account): Set the security and secure-auth
2802 options, and add a comment saying that the other camel-specific options should be
2805 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2807 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2809 * src/modest-tny-account-store.c: (account_list_free),
2810 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2811 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2814 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2816 * src/modest-protocol-info.c:
2817 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2818 is required by our UI spec. Maybe something in our implementation will use this eventually.
2819 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2820 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2821 instead of the previous 0 placeholder.
2823 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2824 secure-auth settings.
2825 * src/modest-account-mgr-helpers.h:
2826 * src/modest-account-mgr-helpers.c:
2827 (modest_server_account_data_get_option_secure_auth),
2828 (modest_server_account_set_option_secure_auth),
2829 (modest_server_account_data_get_option_security),
2830 (modest_server_account_set_option_security): Added this API for getting and setting the security
2831 and secure-auth settings.
2833 * src/maemo/modest-account-settings-dialog.h:
2834 * src/maemo/modest-account-settings-dialog.c:
2835 (modest_account_settings_dialog_finalize), (check_data),
2836 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2837 about changing titles.
2838 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2839 (save_configuration): Save the security and secure-auth settings.
2841 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2842 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2844 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2846 * src/modest-defs.h:
2847 * src/modest-account-mgr.c:
2848 (modest_account_mgr_add_server_account):
2849 Added and used defines for the options key and value pair strings,
2850 that are used so far, though they do not seem to correspond to anything in our
2851 UI specs or ModestProtocol enum.
2853 * src/modest-account-mgr-helpers.h:
2854 * src/modest-account-mgr-helpers.c:
2855 (compare_option_strings_for_name),
2856 (modest_server_account_data_get_option_value),
2857 (modest_server_account_data_get_option_bool),
2858 (modest_account_mgr_get_server_account_option):
2859 Added helper functions for parsing the options GSList.
2861 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2863 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2864 display name is based on the supplied account name.
2865 * src/modest-account-mgr.c:
2866 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2867 with an inefficient, but good-enough, implementation.
2869 * src/maemo/easysetup/modest-easysetup-wizard.c:
2870 (create_page_account_details), (on_before_next), (create_account):
2871 Check for existing display names rather than (non-user-visible) account names, and just
2872 create and set a unique account name at the end.
2874 * src/maemo/modest-account-settings-dialog.c:
2875 (modest_account_settings_dialog_init),
2876 (modest_account_settings_dialog_set_account_name),
2877 (create_page_incoming): Show the display name, instead of the account name.
2878 (on_response): Do some (not all) extra checks, as in the UI spec.
2879 (save_configuration): Save the display name if it was changed.
2881 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2883 * po/en_GB.po: Added needed logical ID and translation.
2884 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2885 (init_view): Made the is-default column clicking work.
2887 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2890 * src/maemo/easysetup/Makefile.am:
2891 * src/maemo/easysetup/modest-easysetup-wizard.c:
2892 (modest_easysetup_wizard_dialog_init):
2893 * src/maemo/easysetup/provider-data-test.keyfile:
2894 * src/maemo/easysetup/provider-data.keyfile:
2895 Moved the provider data file to the new modest-providers-data package and used it from there.
2897 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2899 * src/modest-local-folder-info.c:
2900 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2901 N_() was already used on the static strings, but this just marks it for translation without
2902 using the translation.
2904 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2906 * src/maemo/modest-account-settings-dialog.c:
2907 (create_page_incoming),
2908 (modest_account_settings_dialog_set_account_name):
2909 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2910 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2911 I will do this if nobody else gets there first.
2913 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2915 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2916 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2917 save the security stuff.
2919 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2921 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2922 Set the email address and user fullname, which I now see must be
2925 * src/maemo/modest-account-settings-dialog.h:
2926 * src/maemo/modest-account-settings-dialog.c:
2928 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2929 leave-on-server and authentication.
2930 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2933 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2936 * src/maemo/modest-account-settings-dialog.c:
2937 * src/maemo/modest-account-settings-dialog.h:
2938 Most (but not all) of the widgets are now present as specified by the UI spec.
2939 No changes are yet saved, and some details are not properly shown yet.
2941 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2943 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2945 * src/maemo/Makefile.am:
2946 * src/maemo/modest-account-settings-dialog.c:
2947 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2948 an existing account. Doesn't do much yet.
2950 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2951 Open the accounts settings dialog when Edit is clicked.
2953 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2955 * src/maemo/easysetup/Makefile.am:
2956 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2958 * src/maemo/easysetup/modest-easysetup-wizard.c:
2959 (modest_easysetup_wizard_dialog_init):
2960 Try to get the source directory from the build system,
2961 instead of hard-coding "./" into the source code, when opening our local
2962 copies of the configuration files.
2963 But this still fails when opening the wizard from the Accounts window,
2964 maybe because the working directory seems to change at runtime.
2965 So the wizard will fail the second time unless you copy the files into their
2966 proper locations - see the stdout warnings for the paths.
2968 (create_page_account_details),(on_before_next):
2969 Check for existing non-server accounts instead of server accounts,
2970 so the default account name is useful again, and to prevent trying to
2973 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2974 Show the wizard when New is clicked.
2976 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2977 (init_view): Show the column headers, and show the columns that are
2978 specified in the UI specs. However, something in Maemo's GTK+ prevents
2979 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2980 change the default account. This is despite unsetting the special properties.
2982 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2984 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2985 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2986 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2987 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2988 to make that clearer.
2989 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2991 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2993 * src/maemo/modest-account-view-window.c:
2994 (modest_account_view_window_init),
2995 (modest_account_view_window_new):
2996 Use the same buttons as specified in the
2997 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2998 the existing widgets, which never had a chance of working.
2999 Put the ModestAccountView treeview in a scrolled window.
3000 Do not repeat the initialization in both _init() and _new().
3002 * src/widgets/modest-account-view.c: (update_account_view):
3003 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3004 this widget and window shows no accounts.
3006 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3008 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3010 * src/maemo/easysetup/modest-easysetup-wizard.c:
3011 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3012 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3013 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3016 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3017 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3018 accounts exist yet, as in the UI spec.
3020 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3022 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3024 * src/maemo/Makefile.am:
3025 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3026 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3027 New window for editing connection-specific smtp details.
3028 Not fully implemented.
3030 * src/maemo/modest-connection-specific-smtp-window.c:
3031 (modest_connection_specific_smtp_window_finalize) :
3032 unref the tree model.
3033 (on_button_edit): Show the edit window.
3035 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3037 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3040 * src/maemo/Makefile.am:
3041 * src/maemo/modest-connection-specific-smtp-window.c:
3042 * src/maemo/modest-connection-specific-smtp-window.h:
3043 New window for showing the list of connections, for connection-specific
3044 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3045 * src/maemo/easysetup/modest-easysetup-wizard.c:
3046 (create_page_custom_outgoing): Show the new window when the button is clicked.
3048 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3050 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3051 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3052 * src/maemo/modest-msg-edit-window.c:
3053 (modest_msg_edit_window_insert_image):
3054 * src/modest-conf.c: (modest_conf_key_escape):
3055 * src/modest-mail-operation.c:
3056 (modest_mail_operation_send_new_mail):
3057 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3058 (modest_ui_actions_on_new_account):
3059 * src/widgets/modest-attachment-view.c: (update_filename_request):
3060 * src/widgets/modest-mail-header-view.c:
3061 Corrected warnings that were breaking the build, by commenting out unused variables,
3062 and a function, and by including a header.
3064 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3066 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3067 so we can #ifdef around platform-specific code when necessary.
3068 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3069 to allow this to build for the GNOME platform too.
3071 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3073 * src/maemo/easysetup/modest-easysetup-wizard.c:
3074 Added util_increment_name() and used it in create_page_account_details()
3075 to make sure that the default account name is always a new name.
3077 (modest_easysetup_wizard_dialog_init),
3078 (set_default_custom_servernames): Some minor memory management fixes.
3080 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3084 * src/modest-runtime.c: (init_i18n): Restored the translation
3085 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3086 are defined in config.h, and the translations are installed.
3088 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3089 is defined for translation.
3091 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3093 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3095 * src/maemo/easysetup/modest-easysetup-wizard.c:
3096 (modest_easysetup_wizard_dialog_init):
3097 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3098 Use realistic paths (though they should use $prefix generically) to the
3099 mcc_mapping and provider-data.keyfile files which might work when they
3100 are installed by the future version of the operator-wizard package,
3101 and then fallback to paths in our source code, with an explanatory
3104 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3108 * src/maemo/Makefile.am:
3109 * src/maemo/easysetup/: Added files from the previously-exernal
3110 osso-modest-easysetup.
3111 * src/maemo/modest-main-window-ui.h:
3112 * src/modest-ui-actions.c:
3113 * src/modest-ui-actions.h:
3114 Added modest_ui_actions_on_new_account() as a signal handler for the
3115 New Account menu item. It shows the easysetup wizard.
3116 * po/en_GB.po: Added additional needed logical IDs and translations.