1 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
5 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
8 * src/maemo/modest-account-settings-dialog.c:
9 (create_page_incoming), (on_combo_outgoing_security_changed),
10 (on_combo_incoming_security_changed), (create_page_outgoing),
11 (modest_account_settings_dialog_set_account_name),
12 (save_configuration): Load/Save the port number, and change it when the
13 security combo changes, to suitable defaults.
15 2007-04-17 Murray Cumming <murrayc@murrayc.com>
17 * src/modest-account-mgr.c:
18 (modest_account_mgr_add_server_account): Set the security and secure-auth
19 options, and add a comment saying that the other camel-specific options should be
22 2007-04-17 Murray Cumming <murrayc@murrayc.com>
24 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
26 * src/modest-tny-account-store.c: (account_list_free),
27 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
28 cursor->data after unreffing it. But there is some strange stuff there so it might not be
31 2007-04-17 Murray Cumming <murrayc@murrayc.com>
33 * src/modest-protocol-info.c:
34 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
35 is required by our UI spec. Maybe something in our implementation will use this eventually.
36 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
37 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
38 instead of the previous 0 placeholder.
40 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
42 * src/modest-account-mgr-helpers.h:
43 * src/modest-account-mgr-helpers.c:
44 (modest_server_account_data_get_option_secure_auth),
45 (modest_server_account_set_option_secure_auth),
46 (modest_server_account_data_get_option_security),
47 (modest_server_account_set_option_security): Added this API for getting and setting the security
48 and secure-auth settings.
50 * src/maemo/modest-account-settings-dialog.h:
51 * src/maemo/modest-account-settings-dialog.c:
52 (modest_account_settings_dialog_finalize), (check_data),
53 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
54 about changing titles.
55 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
56 (save_configuration): Save the security and secure-auth settings.
58 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
59 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
61 2007-04-17 Murray Cumming <murrayc@murrayc.com>
64 * src/modest-account-mgr.c:
65 (modest_account_mgr_add_server_account):
66 Added and used defines for the options key and value pair strings,
67 that are used so far, though they do not seem to correspond to anything in our
68 UI specs or ModestProtocol enum.
70 * src/modest-account-mgr-helpers.h:
71 * src/modest-account-mgr-helpers.c:
72 (compare_option_strings_for_name),
73 (modest_server_account_data_get_option_value),
74 (modest_server_account_data_get_option_bool),
75 (modest_account_mgr_get_server_account_option):
76 Added helper functions for parsing the options GSList.
78 2007-04-16 Murray Cumming <murrayc@murrayc.com>
80 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
81 display name is based on the supplied account name.
82 * src/modest-account-mgr.c:
83 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
84 with an inefficient, but good-enough, implementation.
86 * src/maemo/easysetup/modest-easysetup-wizard.c:
87 (create_page_account_details), (on_before_next), (create_account):
88 Check for existing display names rather than (non-user-visible) account names, and just
89 create and set a unique account name at the end.
91 * src/maemo/modest-account-settings-dialog.c:
92 (modest_account_settings_dialog_init),
93 (modest_account_settings_dialog_set_account_name),
94 (create_page_incoming): Show the display name, instead of the account name.
95 (on_response): Do some (not all) extra checks, as in the UI spec.
96 (save_configuration): Save the display name if it was changed.
98 2007-04-16 Murray Cumming <murrayc@murrayc.com>
100 * po/en_GB.po: Added needed logical ID and translation.
101 * src/widgets/modest-account-view.c: (on_account_default_toggled),
102 (init_view): Made the is-default column clicking work.
104 2007-04-16 Murray Cumming <murrayc@murrayc.com>
107 * src/maemo/easysetup/Makefile.am:
108 * src/maemo/easysetup/modest-easysetup-wizard.c:
109 (modest_easysetup_wizard_dialog_init):
110 * src/maemo/easysetup/provider-data-test.keyfile:
111 * src/maemo/easysetup/provider-data.keyfile:
112 Moved the provider data file to the new modest-providers-data package and used it from there.
114 2007-04-16 Murray Cumming <murrayc@murrayc.com>
116 * src/modest-local-folder-info.c:
117 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
118 N_() was already used on the static strings, but this just marks it for translation without
119 using the translation.
121 2007-04-06 Murray Cumming <murrayc@murrayc.com>
123 * src/maemo/modest-account-settings-dialog.c:
124 (create_page_incoming),
125 (modest_account_settings_dialog_set_account_name):
126 Added comments about the need for new API in ModestAccountMgr to handle the authentication
127 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
128 I will do this if nobody else gets there first.
130 2007-04-06 Murray Cumming <murrayc@murrayc.com>
132 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
133 Saved much of the incoming and outgoing data too, though I cannot yet see how to
134 save the security stuff.
136 2007-04-06 Murray Cumming <murrayc@murrayc.com>
138 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
139 Set the email address and user fullname, which I now see must be
142 * src/maemo/modest-account-settings-dialog.h:
143 * src/maemo/modest-account-settings-dialog.c:
145 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
146 leave-on-server and authentication.
147 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
150 2007-04-06 Murray Cumming <murrayc@murrayc.com>
153 * src/maemo/modest-account-settings-dialog.c:
154 * src/maemo/modest-account-settings-dialog.h:
155 Most (but not all) of the widgets are now present as specified by the UI spec.
156 No changes are yet saved, and some details are not properly shown yet.
158 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
160 2007-04-06 Murray Cumming <murrayc@murrayc.com>
162 * src/maemo/Makefile.am:
163 * src/maemo/modest-account-settings-dialog.c:
164 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
165 an existing account. Doesn't do much yet.
167 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
168 Open the accounts settings dialog when Edit is clicked.
170 2007-04-05 Murray Cumming <murrayc@murrayc.com>
172 * src/maemo/easysetup/Makefile.am:
173 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
175 * src/maemo/easysetup/modest-easysetup-wizard.c:
176 (modest_easysetup_wizard_dialog_init):
177 Try to get the source directory from the build system,
178 instead of hard-coding "./" into the source code, when opening our local
179 copies of the configuration files.
180 But this still fails when opening the wizard from the Accounts window,
181 maybe because the working directory seems to change at runtime.
182 So the wizard will fail the second time unless you copy the files into their
183 proper locations - see the stdout warnings for the paths.
185 (create_page_account_details),(on_before_next):
186 Check for existing non-server accounts instead of server accounts,
187 so the default account name is useful again, and to prevent trying to
190 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
191 Show the wizard when New is clicked.
193 * src/widgets/modest-account-view.c: (on_account_default_toggled),
194 (init_view): Show the column headers, and show the columns that are
195 specified in the UI specs. However, something in Maemo's GTK+ prevents
196 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
197 change the default account. This is despite unsetting the special properties.
199 2007-04-05 Murray Cumming <murrayc@murrayc.com>
201 * docs/reference/modest-design.sgml: Corrected spelling mistake.
202 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
203 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
204 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
205 to make that clearer.
206 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
208 2007-04-05 Murray Cumming <murrayc@murrayc.com>
210 * src/maemo/modest-account-view-window.c:
211 (modest_account_view_window_init),
212 (modest_account_view_window_new):
213 Use the same buttons as specified in the
214 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
215 the existing widgets, which never had a chance of working.
216 Put the ModestAccountView treeview in a scrolled window.
217 Do not repeat the initialization in both _init() and _new().
219 * src/widgets/modest-account-view.c: (update_account_view):
220 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
221 this widget and window shows no accounts.
223 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
225 2007-04-05 Murray Cumming <murrayc@murrayc.com>
227 * src/maemo/easysetup/modest-easysetup-wizard.c:
228 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
229 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
230 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
233 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
234 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
235 accounts exist yet, as in the UI spec.
237 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
239 2007-04-05 Murray Cumming <murrayc@murrayc.com>
241 * src/maemo/Makefile.am:
242 * src/maemo/modest-connection-specific-smtp-edit-window.c:
243 * src/maemo/modest-connection-specific-smtp-edit-window.h:
244 New window for editing connection-specific smtp details.
245 Not fully implemented.
247 * src/maemo/modest-connection-specific-smtp-window.c:
248 (modest_connection_specific_smtp_window_finalize) :
249 unref the tree model.
250 (on_button_edit): Show the edit window.
252 2007-04-05 Murray Cumming <murrayc@murrayc.com>
254 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
257 * src/maemo/Makefile.am:
258 * src/maemo/modest-connection-specific-smtp-window.c:
259 * src/maemo/modest-connection-specific-smtp-window.h:
260 New window for showing the list of connections, for connection-specific
261 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
262 * src/maemo/easysetup/modest-easysetup-wizard.c:
263 (create_page_custom_outgoing): Show the new window when the button is clicked.
265 2007-04-04 Murray Cumming <murrayc@murrayc.com>
267 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
268 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
269 * src/maemo/modest-msg-edit-window.c:
270 (modest_msg_edit_window_insert_image):
271 * src/modest-conf.c: (modest_conf_key_escape):
272 * src/modest-mail-operation.c:
273 (modest_mail_operation_send_new_mail):
274 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
275 (modest_ui_actions_on_new_account):
276 * src/widgets/modest-attachment-view.c: (update_filename_request):
277 * src/widgets/modest-mail-header-view.c:
278 Corrected warnings that were breaking the build, by commenting out unused variables,
279 and a function, and by including a header.
281 2007-04-04 Murray Cumming <murrayc@murrayc.com>
283 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
284 so we can #ifdef around platform-specific code when necessary.
285 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
286 to allow this to build for the GNOME platform too.
288 2007-04-04 Murray Cumming <murrayc@murrayc.com>
290 * src/maemo/easysetup/modest-easysetup-wizard.c:
291 Added util_increment_name() and used it in create_page_account_details()
292 to make sure that the default account name is always a new name.
294 (modest_easysetup_wizard_dialog_init),
295 (set_default_custom_servernames): Some minor memory management fixes.
297 2007-04-04 Murray Cumming <murrayc@murrayc.com>
301 * src/modest-runtime.c: (init_i18n): Restored the translation
302 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
303 are defined in config.h, and the translations are installed.
305 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
306 is defined for translation.
308 2007-04-03 Murray Cumming <murrayc@murrayc.com>
310 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
312 * src/maemo/easysetup/modest-easysetup-wizard.c:
313 (modest_easysetup_wizard_dialog_init):
314 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
315 Use realistic paths (though they should use $prefix generically) to the
316 mcc_mapping and provider-data.keyfile files which might work when they
317 are installed by the future version of the operator-wizard package,
318 and then fallback to paths in our source code, with an explanatory
321 2007-04-03 Murray Cumming <murrayc@murrayc.com>
325 * src/maemo/Makefile.am:
326 * src/maemo/easysetup/: Added files from the previously-exernal
327 osso-modest-easysetup.
328 * src/maemo/modest-main-window-ui.h:
329 * src/modest-ui-actions.c:
330 * src/modest-ui-actions.h:
331 Added modest_ui_actions_on_new_account() as a signal handler for the
332 New Account menu item. It shows the easysetup wizard.
333 * po/en_GB.po: Added additional needed logical IDs and translations.
335 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
336 Apparently ChangeLog is not used for some vague Nokia legal reasons.