1 2007-08-16 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-tny-account-store.c: (volume_path_is_mounted):
4 Check the GnomeVFSVolume activation path instead of the device path,
5 so that the memory card is really really shown in the UI.
7 2007-08-16 Murray Cumming <murrayc@murrayc.com>
9 * src/maemo/easysetup/modest-easysetup-wizard.c:
10 (get_entered_account_title), (on_before_next), (entry_is_empty),
12 * src/maemo/modest-account-settings-dialog.c:
13 (get_entered_account_title), (on_button_signature), (check_data),
14 (save_configuration), (entry_is_empty):
15 Strip the account title of whitespace at the start and end before
16 using it or checking it. This means that an all-whitespace title
17 is not allowed, fixing projects.maemo.org bug NB#64977.
19 2007-08-15 Murray Cumming <murrayc@murrayc.com>
21 * src/modest-ui-actions.h:
22 * src/modest-ui-actions.c: Renamed modest_run_account_setup_wizard()
23 to modest_run_account_setup_wizard() and made it public.
24 * src/dbus_api/modest-dbus-callbacks.c:
25 (check_and_offer_account_creation), (on_idle_mail_to),
26 (on_idle_compose_mail), (on_idle_open_default_inbox):
27 Offer account creation if necessary, fixing projects.maemo.org
30 2007-08-15 Murray Cumming <murrayc@murrayc.com>
32 * src/modest-ui-actions.c: (run_account_setup_wizard):
33 Return a gboolean to indicate success.
34 (modest_ui_actions_on_new_msg), (open_msg_cb), (reply_forward),
35 (modest_ui_actions_on_send): When offering account creation, only
36 give up (return) if account creation failed. Otherwise continue
37 with the original request. This fixed projects.maemo.org bug
40 2007-08-15 Murray Cumming <murrayc@murrayc.com>
42 * src/widgets/modest-recpt-editor.c:
43 (modest_recpt_editor_instance_init): Turn off hildon auto-capitalization,
44 to fix projects.maemo.org bug NB#63789.
46 2007-08-15 Murray Cumming <murrayc@murrayc.com>
48 * src/modest-tny-account-store.c: Added volume_path_is_mounted().
49 (modest_tny_account_store_new): Properly detect the memory card at
50 startup, and add an account for it.
52 2007-08-14 Murray Cumming <murrayc@murrayc.com>
54 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
55 Commented out the MMC code again because it mistakenly detects
56 the card even when it isn't inserted.
58 2007-08-14 Murray Cumming <murrayc@murrayc.com>
60 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
61 Renabled the call to add_mmc_account() because I do not believe
62 it could be the cause of the mentioned hang (in scratchbox, where
63 there is no memory card), and because I have tested that it works
66 2007-08-14 Murray Cumming <murrayc@murrayc.com>
68 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
69 Comment out part of the last commit because it apparently causes
72 2007-08-14 Murray Cumming <murrayc@murrayc.com>
74 * src/modest-tny-account-store.c: Added the add_mmc_account()
75 function to save some copy/pasting.
76 (modest_tny_account_store_new): If the memory card is mounted,
77 create an account for it at the start, instead of waiting for the
78 user to unmount it and mount it.
80 2007-08-13 Murray Cumming <murrayc@murrayc.com>
82 * src/widgets/modest-account-view.c: (on_account_changed):
83 Do not try to use the human-readable TnyAccount name instead of the
84 ID of the modest account to get the transport account. And unref
85 the transport account. This prevents a g_warning(), and a possible
88 2007-08-13 Murray Cumming <murrayc@murrayc.com>
90 * src/maemo/modest-platform.c:
91 (modest_platform_set_update_interval): Handle the new
92 alarmd error to warn when alarmd is not running, as is the case in
93 scratchbox for me now because
94 "Module /usr/lib/alarmd/libretu.so initialization failed"
96 2007-08-13 Murray Cumming <murrayc@murrayc.com>
98 * src/widgets/modest-header-view-render.c:
99 (_modest_header_view_compact_header_cell_data):
100 NULL some strings after freeing them, trying to deal with
101 the double deletion found in projects.maemo.org bug 64183,
102 probably having no effect.
104 2007-08-13 Murray Cumming <murrayc@murrayc.com>
106 * src/maemo/modest-account-settings-dialog.c:
107 (create_page_incoming), (create_page_outgoing): Use a define
108 for the min and max port numbers.
110 (check_hildon_number_editor_and_warn_value_not_in_range),
111 (check_data): Do an extra check for an invalid port number, as needed
112 in projects.maemo.org bug #64275, when the number is cleared, but this
113 does not work due to bugs.maemo.org bug #1806.
115 2007-08-13 Murray Cumming <murrayc@murrayc.com>
117 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
118 Comment out the debug warning about the unexpected D-Bus methods.
119 They are just annoying now.
120 * src/maemo/modest-platform.c:
121 (modest_platform_set_update_interval): Correct the D-Bus path, instead
122 of using a file path, though it did not seem to break things before.
123 It might be needed now:
124 Use the ALARM_EVENT_ACTIVATION flag so that emails are updated even when
125 modest is not already running. This is the behaviour of the old client, and
126 Mox says it is what we should do for modest.
127 This closes projects.maemo.org bug NB#64327.
129 2007-08-04 Johannes Schmid <johannes.schmid@openismus.com>
131 * src/modest-text-utils.c:
132 Fixed invalid jump due to incorrect string/pointer
134 (See https://projects.maemo.org/trac/email/wiki/ValgrindErrors
137 2007-08-01 Murray Cumming <murrayc@murrayc.com>
139 * src/modest-account-mgr-helpers.h:
140 * src/modest-account-mgr-helpers.c:
141 Added modest_account_mgr_get_first_account_name(),
142 using code from modest_account_mgr_set_first_account_as_default().
144 * src/maemo/modest-main-window.c: Added set_at_least_one_account_visible().
145 (account_number_changed): Call set_at_least_one_account_visible() so that
146 the first account is visible when first added, without the user having to
148 I do wonder how this worked before.
150 2007-08-01 Murray Cumming <murrayc@murrayc.com>
152 * src/modest-tny-account-store.c: (show_password_warning_only),
153 (show_wrong_password), (request_password_and_wait), (get_password),
154 (modest_tny_account_store_alert): Remove the (incomplete anyway)
155 attempts to show UI only in the main context, which used g_idle_add()
156 and mainloops, because tinymail now guarantees that it only calls these
157 callbacks in the mainloop with the gdk lock. This makes everything much
160 2007-08-01 Murray Cumming <murrayc@murrayc.com>
162 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
163 Handle TNY_ACCOUNT_ERROR_TRY_CONNECT_SERVICE_UNAVAILABLE in the same
164 way as TNY_ACCOUNT_ERROR_TRY_CONNECT_HOST_LOOKUP_FAILED, showing an
165 error dialog, instead of ignoring it.
167 2007-08-01 Murray Cumming <murrayc@murrayc.com>
169 * src/maemo/modest-msg-view-window.c:
170 (modest_msg_view_window_get_header),
171 (modest_msg_view_window_last_message_selected):
172 Added comments to explain the use of priv->header_model.
173 * src/modest-ui-dimming-rules.c:
174 (modest_ui_dimming_rules_on_open_msg),
175 (modest_ui_dimming_rules_on_mark_as_read_msg),
176 (modest_ui_dimming_rules_on_mark_as_unread_msg),
177 (modest_ui_dimming_rules_on_remove_attachments),
178 (_invalid_attach_selected), (_selected_msg_marked_as):
179 Renamed _marked_as_deleted() to _selected_message_is_marked_as_deleted(),
180 and changed the parameter to a ModestMainWindow to make it clearer that
181 it never uses any other kind of window.
182 Added _message_is_marked_as_deleted() for examining a ModestMsgViewWindow
183 instead of the selected message.
184 I notice that much of the dimming code and the ModestMsgViewWindow code
185 hard-codes the assumption that the viewed message is always selected in
186 the header view. This does not seem wise or simple.
188 (modest_ui_dimming_rules_on_delete_msg): For a ModestMsgViewWindow,
189 examine the actual message instead of whatever might be selected
190 in the header view. This stops the delete toolbar button and menu item
191 from being dimmed when opening a message view the search UI,
192 partially fixing projects.maemo.org bug NB#63811.
194 However, when actually deleting, I now get this warning:
195 "tny_header_set_flags: This is a header instance for a new message.
196 Only priority and attachment flags are supported"
198 2007-07-30 Johannes Schmid <johannes.schmid@openismus.com>
200 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
202 Show account wizard if no accounts are defined while sending
203 (automatic sending after the account wizard finished does not
204 work because it takes some time until the account manager
205 synchronizes everything. (projects.maemo.org NB#62792)
207 2007-07-30 Murray Cumming <murrayc@murrayc.com>
209 * src/modest-tny-account-store.c: (on_account_removed),
210 (on_account_changed): Emit the ACCOUNT_UPDATE signal so that the
211 account is removed from the View menu. We have TnyAccountStore
212 and ModestTnyAccountStore signals that seem very similar, but this
213 seems to work for now.
215 * src/maemo/modest-main-window.c:
216 (on_show_account_action_activated): Prevent dereference
217 of a NULL if the accoutn does not really exist, though that
218 should not happen anymore.
220 This fixes projects.maemo.org bug NB#64606.
222 2007-07-30 Murray Cumming <murrayc@murrayc.com>
224 * src/modest-ui-actions.c: (run_account_setup_wizard),
225 (modest_ui_actions_on_accounts): Revert a change that set these
226 to modal dialogs, freezing the UI when they show secondary dialogs.
227 This fixed projects.maemo.org bug NB#64519.
229 2007-07-27 Murray Cumming <murrayc@murrayc.com>
231 * src/widgets/modest-header-view-render.c:
232 (_modest_header_view_compact_header_cell_data):
233 Some checks and initialization to try to deal with a crash,
234 probably ineffective.
236 2007-07-27 Murray Cumming <murrayc@murrayc.com>
238 * src/maemo/modest-maemo-utils.c:
239 (modest_maemo_utils_get_supported_secure_authentication_methods):
240 Make sure that we have a connection, asking the user for one
242 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
243 Check for a connection before showing the wizard, because
244 the wizard needs a connection to check for server capabilities.
246 2007-07-27 Murray Cumming <murrayc@murrayc.com>
248 * src/maemo/modest-account-view-window.c:
249 (on_new_button_clicked): Remember the wizard dialog instance,
250 so we can just present it again if necessary. This prevents
251 multiple windows from appearing if you click again quickly on the
252 New button before the dialog appears, fixing projects.maemo.org
255 2007-07-27 Murray Cumming <murrayc@murrayc.com>
257 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
258 Offer a connection dialog if there is no connection when
259 starting modest. This should fix projects.maemo.org bug NB#61134.
261 2007-07-27 Murray Cumming <murrayc@murrayc.com>
263 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
264 Reverted my last commit. I was able to fix the build by doing
265 apt-get install wpeditor0 (replacing other wpeditor packages) and
266 an explicit apt-get install wpeditor-dev to upgrade the -dev
269 2007-07-27 Murray Cumming <murrayc@murrayc.com>
271 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
272 Commented out the use of wp_text_buffer_replace_image()
273 because it does not exist, to break the build. Added a TODO for it.
275 2007-07-26 Murray Cumming <murrayc@murrayc.com>
277 * src/modest-tny-account-store.c: (recreate_all_accounts):
278 Recreate them even if they were NULL before. I guess something
279 else was already creating them before, or this would never
281 (modest_tny_account_store_get_server_account): Make sure that
282 the tny accounts have been created before trying to find one.
283 This allows libmodest_dbus_client_compose_mail() to work
284 when the UI is not yet visible.
285 This is probably useful in other cases too.
287 (get_password): When the password is wrong after it is entered
288 in the protected password dialog, show an info banner (in an
289 idle handler) before showing the protected password dialog
292 2007-07-26 Murray Cumming <murrayc@murrayc.com>
294 * src/modest-ui-actions.h:
295 * src/modest-ui-actions.c: Added
296 modest_do_refresh_current_folder() containing some code from
297 modest_ui_actions_on_send_receive().
298 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
299 Call modest_do_refresh_current_folder() before refreshing the
300 requested account, as in modest_ui_actions_on_send_receive().
301 This is strange, but seems to be necessary to show new mails.
302 Now new emails are finally visible in the UI when downloaded
303 via the automatic update interval, fixing bug NB#57458.
304 This also works because bug NB#57458 has been fixed somehow.
306 2007-07-26 Murray Cumming <murrayc@murrayc.com>
308 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
309 printf more details when we get unhandled D-Bus methods, because
312 * src/modest-mail-operation.c: (update_account_thread):
313 Comment out the tny_camel_pop_store_account_reconnect(), because this
314 is apparently no longer needed, and it did not work before anyway.
315 See the comment in the code.
317 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
318 by checking the header flags. This fixes projects.maemo.org bug
321 2007-07-25 Murray Cumming <murrayc@murrayc.com>
323 * src/maemo/modest-maemo-utils.h:
324 * src/maemo/modest-maemo-utils.c: Added
325 modest_maemo_show_information_note_in_main_context_and_forget().
326 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
327 Use the new function to show simple error dialogs in the main
328 context, though question dialogs are still in the current context,
329 which is unfortunately usually not the main context. This should
332 2007-07-25 Murray Cumming <murrayc@murrayc.com>
334 * src/modest-tny-account-store.c: (get_password):
335 Never save the entered username and password in gconf,
336 because the UI spec says we should not. This helps
337 slightly with projects.maemo.org bug NB#63671.
339 2007-07-25 Murray Cumming <murrayc@murrayc.com>
341 * src/widgets/modest-msg-edit-window.h:
342 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
343 Moved some code here to make it simpler.
344 (modest_msg_edit_window_attach_file_one): Renamed from
345 modest_msg_edit_window_attach_file_interactive().
346 (modest_msg_edit_window_offer_attach_file): Renamed from
347 modest_msg_edit_window_attach_file() and used
348 modest_msg_edit_window_attach_file_one() instead of
349 copy/pasting the code. The old code for one was not using
350 GnomeVFS. This allows use of smb:// URLs when using send-as
351 from external applications, fixing bug NB#63741.
353 (modest_msg_edit_window_insert_image),
354 (modest_msg_edit_window_add_attachment_clicked):
355 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
356 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
357 Adapted to the new function names.
359 2007-07-25 Murray Cumming <murrayc@murrayc.com>
361 (modest_platform_set_update_interval): Set the alarm recurrence
362 fields so that auto-update does not just happen the first time.
363 This should have fixed projects.maemo.org bug NB#63938.
365 When this happens you can see a printf when the D-Bus method is
367 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
369 However, I do not actually seem to get new POP messages even when
370 clicking the refresh button manually. A restart gets them.
371 This might be a problem in today's tinymail only.
373 2007-07-24 Murray Cumming <murrayc@murrayc.com>
375 * src/maemo/modest-maemo-global-settings-dialog.c:
376 (current_connection):
377 Avoid a crash (probably only in scratchbox) when strcmp()ing a
378 NULL when closing the dialog.
380 2007-07-24 Murray Cumming <murrayc@murrayc.com>
382 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
383 Remove the hacky send/receive that didn't work, and instead
384 refilter the treemodel to make the deleted email really vanish from
385 the UI (though the delete-from-menu code does has commented out
386 the code that does that). This fixes projects.maemo.org bug
389 2007-07-24 Murray Cumming <murrayc@murrayc.com>
391 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
392 Try a couple of tricks to force the treeview to update (
393 poke the folder, and do a send/receive refresh), but the deleted
394 email still appears with a strike-through instead of really being
397 2007-07-23 Murray Cumming <murrayc@murrayc.com>
399 * src/dbus_api/modest-dbus-callbacks.c:
400 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
401 because their ID is not human-readable (see the comment about
402 improvements needed to the osso-email-interface API) and
403 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
405 2007-07-23 Murray Cumming <murrayc@murrayc.com>
407 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
408 (add_folders_to_list), (on_dbus_method_get_folders),
409 (modest_dbus_req_filter):
410 * src/maemo/modest-maemo-utils.c:
411 (on_camel_account_get_supported_secure_authentication):
412 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
413 (on_header_view_focus_in):
414 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
415 * src/modest-formatter.c: (modest_formatter_create_body_part):
416 * src/modest-mail-operation.c: (recurse_folders),
417 (update_account_thread), (get_msgs_full_thread),
418 (modest_mail_operation_get_msgs_full),
419 (modest_mail_operation_xfer_msgs):
420 * src/modest-search.c: (search_mime_part_and_child_parts),
421 (modest_search_account), (modest_search_all_accounts):
422 * src/modest-tny-account.c:
423 (modest_tny_account_get_special_folder), (recurse_folders):
424 * src/modest-tny-local-folders-account.c:
425 (modest_tny_local_folders_account_query_passes):
426 * src/modest-tny-msg.c: (copy_mime_part),
427 (modest_tny_msg_find_body_part_from_mime_part):
428 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
429 (modest_tny_send_queue_try_to_send):
430 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
431 (_modest_ui_actions_open), (download_uncached_messages),
432 (reply_forward), (modest_ui_actions_on_copy),
433 (modest_ui_actions_on_details), (has_retrieved_msgs),
434 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
436 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
437 (_selected_msg_marked_as), (_msg_download_completed),
438 (_selected_msg_sent_in_progress):
439 * src/widgets/modest-attachments-view.c:
440 (modest_attachments_view_set_message):
441 * src/widgets/modest-msg-view.c: (find_cid_image):
442 * tests/check_folder-transfer.c: (find_folders):
443 * tests/check_update-account.c: (func):
444 * tests/dbus_api/test_get_folders.c: (main):
445 Checked all uses of tny_iterator_get_current(), making sure
446 that the object is unreferenced (3 or 4 places did not),
447 and adding checks for NULL.
449 2007-07-23 Murray Cumming <murrayc@murrayc.com>
451 * src/dbus_api/modest-dbus-callbacks.c:
452 (on_idle_open_default_inbox): Make sure that the application UI is
454 * src/maemo/easysetup/modest-easysetup-wizard.c:
455 (on_entry_invalid_character): Show the word whitespace instead
456 of (null) in the banner when whitespace was entered.
457 (show_error): Add a comment that this does not work in
458 Maemo Bora, though we do not know why.
460 2007-07-23 Murray Cumming <murrayc@murrayc.com>
462 * src/modest-tny-account.c:
463 (modest_tny_account_get_special_folder): Use an if instead of
464 an assert for when the parent account name is NULL, because this
465 might be causing a crash in projects.maemo.org bug 63192.
466 * src/modest-mail-operation.c:
467 (modest_mail_operation_send_new_mail_cb),
468 (modest_mail_operation_remove_folder): unref the folder that is
469 returned from modest_tny_account_get_special_folder().
471 2007-07-23 Murray Cumming <murrayc@murrayc.com>
473 * src/modest-ui-actions.c:
474 (modest_ui_actions_on_password_requested):
475 Show mail_ib_login_cancelled info banner when the user cancels
476 the protected password dialog, to fix projects.maemo.org
479 2007-07-23 Murray Cumming <murrayc@murrayc.com>
481 * src/maemo/modest-account-settings-dialog.c:
482 (create_page_outgoing): Put this page in a GtkScrolledWindow,
483 matching the UI mock-up in the UI spec, and allowing access
484 to all widgets even when the on-screen keyboard is active.
486 2007-07-23 Murray Cumming <murrayc@murrayc.com>
488 Reverted this previous commit from Johannes,
489 because the scrollbars are always visible and because
490 I think we only need it on onepage of the account
491 settings, not the account wizard.
492 (I wrote the wrong instructions in the bug.)
494 * src/maemo/easysetup/modest-easysetup-wizard.c:
495 Added scrollbars to account wizard dialog.
496 Fixed projects.maemo.org NB #62744
498 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
500 * src/maemo/easysetup/modest-easysetup-wizard.c:
501 (create_page_user_details):
502 Use auto-cap for name (projects.maemo.org NB#63716)
503 * src/widgets/modest-account-view.c: (on_account_busy_changed):
505 2007-07-22 Armin Burgmeier <armin@openismus.com>
507 * src/maemo/modest-ui-actions.c: Use current account instead of
508 default account for creating viewer windows, so that the viewer
509 window knows to which account the viewed message belongs.
511 * src/maemo/modest-msg-view-window.c: Destroy the window when the
512 corresponding account is deleted. This fixes projects.maemo.org bug
515 2007-07-18 Armin Burgmeier <armin@openismus.com>
517 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
518 the dialog close after entering an invalid port number and clicking
519 OK. This fixes projects.maemo.org bug NB#63602.
521 2007-07-18 Armin Burgmeier <armin@openismus.com>
523 * src/modest-tny-account-store.c:
524 (get_server_accounts): Set parent modest account name for each
525 connection-specific transport account so that special folders of such
526 an account can be looked up. This fixes a crash when changing account
527 settings. This might also be related to projects.maemo.org bug
530 2007-07-16 Armin Burgmeier <armin@openismus.com>
532 * src/modest-ui-actions.c: Added a button to create a folder to the
533 move-to dialog. This fixes projects.maemo.org bug NB#.
535 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
537 * src/maemo/easysetup/modest-easysetup-wizard.c:
538 Added scrollbars to account wizard dialog.
539 Fixed projects.maemo.org NB #62744
541 2007-07-16 Murray Cumming <murrayc@murrayc.com>
543 * src/widgets/modest-msg-view.h:
544 * src/widgets/modest-msg-view.c:
545 Added modest_msg_view_get_message_is_empty() but this needs
547 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
548 Check if there is any text in the message yet.
549 But this needs to be implemented properly.
550 (modest_msg_edit_window_toggle_find_toolbar):
551 * src/maemo/modest-msg-view-window.c:
552 (modest_msg_view_window_toggle_find_toolbar):
553 Show a banner warning if there is no text to search, when
554 trying to start a search. This partially fixes
555 projects.maemo.org bug NB#62350.
557 2007-07-13 Murray Cumming <murrayc@murrayc.com>
559 * src/modest-mail-operation.c: (update_account_thread):
560 Initialized num_new_headers to fix the build.
562 2007-07-13 Murray Cumming <murrayc@murrayc.com>
564 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
565 Ignore modest accounts whose server accounts don't exist in gconf.
566 This prevents us trying to create TnyAccount instances for those
567 server accounts when the server account has been removed from gconf,
568 but the parent modest account has not yet been removed from modest.
569 I don't know why this is only noticeable now. It was probably just
570 a harmeless g_warning() anyway.
572 2007-07-13 Murray Cumming <murrayc@murrayc.com>
574 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
575 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
577 2007-07-12 Armin Burgmeier <armin@openismus.com>
579 * src/maemo/modest-main-window.c: Make default account appear bold
580 in view, tools/send & receive and toolbar/send & receive SCM menus.
581 This fixes projects.maemo.org bug NB#59010.
583 2007-07-12 Murray Cumming <murrayc@murrayc.com>
585 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
586 Add a short-cut, by checking if the folder store is an account.
587 This ensures that the Sort menu item and toolbar is dimmed for
588 the local-folders account root item, fixing
589 projects.maemo.org bug NB#62545.
591 2007-07-12 Murray Cumming <murrayc@murrayc.com>
593 * src/modest-tny-account-store.c: (get_password):
594 Show the password dialog (via the signal) only in the mainloop, via
595 an idle handler that we wait for. This could theoretically prevent
596 hangs, though I worry that it could introduce some too.
598 2007-07-12 Murray Cumming <murrayc@murrayc.com>
600 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
601 * src/maemo/modest-platform.c:
602 (modest_platform_connect_and_wait):
603 Take a TnyAccount* parameter and try to set it to online
604 (a TnyCamel-only API), because tinymail sets accounts to offline
605 when the user cancels a password dialog, and doesn't ask again until
606 it has been set to online.
607 However, this is commented out because it causes a hang now.
609 (modest_platform_connect_and_wait_if_network_account):
610 * src/modest-mail-operation.c:
611 (modest_mail_operation_update_account):
612 * src/modest-platform.h:
613 * src/modest-ui-actions.c: (_modest_ui_actions_open),
614 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
616 2007-07-12 Armin Burgmeier <armin@openismus.com>
618 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
620 * src/modest-mail-operation.c:
621 * src/modest-ui-actions.c: Check for already existing folder before
622 querying the server, show error message from camel if the request
623 still fails. This fixes projects.maemo.org bug NB#58701.
625 2007-07-12 Murray Cumming <murrayc@murrayc.com>
627 * src/modest-tny-account-store.h:
628 * src/modest-tny-account-store.c:
629 Added modest_tny_account_store_forget_password_in_memory(),
630 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
631 when creating a new account, so that new passwords will be used, instead of
632 us thinking that it's a second request as a result of a failed password again.
634 2007-07-12 Murray Cumming <murrayc@murrayc.com>
636 * src/dbus_api/modest-dbus-callbacks.c:
637 (on_idle_open_message): If the message is in drafts then open it
638 in an edit window instead of a view window. This fixes
639 projects.maemo.org bug NB#63005.
641 2007-07-12 Murray Cumming <murrayc@murrayc.com>
643 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
644 Avoided a harmless g_warning().
646 2007-07-12 Murray Cumming <murrayc@murrayc.com>
648 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
649 Pass the modest account name, not the TnyAccount display name to
650 modest_msg_view_window_new() so that the reply feature works,
651 fixing projects.maemo.org bug NB#62892.
653 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
654 (modest_msg_view_window_new_with_header_model):
655 * src/maemo/modest-msg-view-window.c:
656 (modest_msg_view_window_new_with_header_model),
657 (modest_msg_view_window_new):
658 * src/modest-ui-actions.c: (reply_forward):
659 * src/widgets/modest-msg-view-window.h:
660 * src/widgets/modest-window.c: (modest_window_set_active_account):
661 Rename an account parameter to modest_account_name to make this clearer.
663 2007-07-11 Murray Cumming <murrayc@murrayc.com>
665 * src/modest-ui-actions.h:
666 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
667 modest_do_message_delete().
668 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
669 Call modest_do_message_delete(), hoping that this would cause messages
670 to be really deleted from search instead of just marked with strike through.
671 Does not seem to help.
673 2007-07-11 Armin Burgmeier <armin@openismus.com>
675 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
676 priv->reselect to FALSE prior to calling
677 modest_folder_view_select_first_inbox_or_local() to prevent endless
678 recursion and thus a crash on startup.
680 2007-07-11 Armin Burgmeier <armin@openismus.com>
682 * src/maemo/modest-account-settings-dialog.h: Include
683 <gtk/gtknotebook.h> to fix the build (at least for me).
685 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
686 Use "New FolderN" as default suggested name if "New folder" already
687 exists, with N being the first free number, though never exceed "New
688 folder99" in which case we just fall back to "New Folder" even though
689 it already exists. This fixes projects.maemo.org bug NB#58663.
691 2007-07-11 Murray Cumming <murrayc@murrayc.com>
693 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
694 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
695 projects.maemo.org bug NB#62778.
697 2007-07-11 Murray Cumming <murrayc@murrayc.com>
699 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
700 Ignore the wrong (for now) secure-smtp setting in the presets -
701 just default to requiring secure authentication for SMTP, because
704 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
706 * src/widgets/modest-folder-view.c: (filter_row)
707 Do not show drafts folder (see UI specs)
709 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
711 * src/modest-ui-actions.c:
712 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
713 place and also not necessary.
715 * src/widgets/modest-folder-view.c: (filter_row)
716 Guess folder type and hide Sent & Outbox if necessary.
717 Fixed project.maemo.org NB#57328
719 2007-07-11 Murray Cumming <murrayc@murrayc.com>
721 * src/modest-ui-actions.h:
722 * src/modest-ui-actions.c:
723 (modest_ui_actions_on_delete_message):
724 Move some code into a new
725 modest_ui_actions_refresh_message_window_after_delete()
726 function so we can use it from elsewhere.
728 * src/dbus_api/modest-dbus-callbacks.c:
729 (on_idle_delete_message), (on_delete_message): Used an idle
730 handler, as we do for the other D-Bus method handlers.
731 Call modest_ui_actions_refresh_message_window_after_delete()
732 if the deleted message was open in a window. This fixed
733 projects.maemo.org bug NB#62862.
735 2007-07-11 Murray Cumming <murrayc@murrayc.com>
737 * src/modest-main.c: (main): Only show the UI at the start if
738 the showui command line option was given. For instance,
739 run-standalone src/modest showui
740 Otherwise, we wait for the top_application D-Bus method to
741 be sent by hildon-desktop when the application is selected
743 This allows us to run without a UI when osso-global-search
744 uses our D-Bus methods.
746 2007-07-11 Murray Cumming <murrayc@murrayc.com>
748 * src/dbus_api/modest-dbus-api.h: Added a define for a
749 top-application D-Bus method.
750 * src/dbus_api/modest-dbus-callbacks.c:
751 (on_top_application),
752 (modest_dbus_req_handler): Handle the top-application D-Bus
753 method, which might be an undocumented D-Bus signal sent by
754 hildon-desktop when it starts the application from the menu.
755 But I am not sure and I need to test it on the device, because
756 my scratchbox does not have the application in the menu now.
757 This method shows the main window, so that it can be invisible
758 when started, for instance, just for email searching from
761 * src/maemo/modest-main-window.c: (restore_settings),
762 (modest_main_window_new): Do not show the window immediately
763 upon creation. We show it later.
764 * src/modest-widget-memory.c: (save_settings_paned):
765 Try (unsuccessfully) to avoid saving the paned position when
766 it is not even visible.
767 (restore_settings_paned): Do not allow a silly paned position.
768 This seems necessary when not showing the window at first.
770 * tests/dbus_api/Makefile.am:
771 * tests/dbus_api/test_top_application.c: (main): Test for the
774 2007-07-10 Murray Cumming <murrayc@murrayc.com>
776 * src/modest-ui-dimming-rules.c:
777 (modest_ui_dimming_rules_on_new_msg),
778 (modest_ui_dimming_rules_on_reply_msg),
779 (modest_ui_dimming_rules_on_delete_msg),
780 (modest_ui_dimming_rules_on_details),
781 (modest_ui_dimming_rules_on_view_window_move_to),
782 (modest_ui_dimming_rules_on_view_previous),
783 (modest_ui_dimming_rules_on_view_next),
784 (_invalid_folder_for_purge): Added checks before
785 casting the window. This looks like an actual
786 logic error in _invalid_folder_for_purge(), because it
787 tries to use a ModestMainWindow as a message window.
789 2007-07-10 Murray Cumming <murrayc@murrayc.com>
791 * src/maemo/modest-account-settings-dialog.c:
792 (show_error): Use the same implementation as in
793 modest-easysetup-wizard.c:
794 (on_entry_invalid_character): The logical ID contains a %s.
795 Guessed what it should be.
796 (on_entry_max), (check_data), (on_response): Adapt to
797 changed show_error().
798 (create_page_account_details): Really call
799 modest_validating_entry_set_func() on the correct widgets.
800 * src/maemo/easysetup/modest-easysetup-wizard.c:
801 (on_entry_invalid_character): Fix the logical ID here too.
802 (create_page_account_details),
803 (create_page_user_details):
805 modest_validating_entry_set_func() on the correct widgets.
807 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
808 Do not try to use the account if it is NULL.
810 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
812 * src/modest-ui-actions.c: (create_move_to_dialog),
813 (modest_ui_actions_on_main_window_move_to),
814 (modest_ui_actions_on_msg_view_window_move_to):
815 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
816 (filter_row), (modest_folder_view_show_non_move_folders):
817 * src/widgets/modest-folder-view.h:
819 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
820 the Sent folder yet as it does not report the correct folder type.
822 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
824 * src/maemo/modest-msg-edit-window.c: (init_window):
827 2007-07-10 Murray Cumming <murrayc@murrayc.com>
829 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
830 Take a parent widget instead of a parent window, and
831 implement this with hildon_banner_show_information() instead.
832 Non-Maemo builds can just ifdef that there.
833 This fixed projects.maemo.org bug NB#62766.
835 (on_entry_invalid_character): Use show_error() again instead
836 of using hildon directly, and use the _CS() macro to use the correct
838 (create_account), (check_for_supported_auth_methods), (on_entry_max):
839 Pass a widget instead od a window to show_error().
841 2007-07-10 Murray Cumming <murrayc@murrayc.com>
843 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
844 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
845 This allows us to show the server name in the error message, fixing
846 projects.maemo.org bug NB#62904.
847 Also, use the appropriate logical ID message for the account protocol.
849 2007-07-10 Murray Cumming <murrayc@murrayc.com>
851 * src/modest-tny-account-store.c: (on_idle_wrong_password):
852 A compilation fix, though the build wasn't broken for me.
854 2007-07-09 Murray Cumming <murrayc@murrayc.com>
856 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
857 Do not try to unref a NULL folder store, to avoid a runtime warning.
858 This seems to happen sometimes when changing accounts settings.
860 2007-07-09 Murray Cumming <murrayc@murrayc.com>
862 * src/modest-tny-account-store.c:
863 (modest_tny_account_store_instance_init),
864 (modest_tny_account_store_finalize),
865 (on_account_settings_hide), (on_idle_wrong_password):
866 Use a GHashTable to ensure that we only show one account settings
867 dialog per modest account. This avoids us having a dialog open for
868 both the store and transport accounts, or due to repeated get_password()
869 calls that shouldn't happen anyway.
871 2007-07-09 Murray Cumming <murrayc@murrayc.com>
873 * src/maemo/modest-maemo-utils.c: (on_hide),
874 (modest_maemo_show_dialog_and_forget): Handle the response, because
875 the window is not even hidden by default.
877 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
878 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
879 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
880 which seems to prevent some modality problems.
882 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
883 Ignore user cancellation errors.
885 * src/modest-account-mgr-helpers.h:
886 * src/modest-account-mgr-helpers.c:
887 Added modest_server_account_get_password() and
888 modest_server_account_get_has_password() to avoid direct use of
891 * src/maemo/modest-account-settings-dialog.h:
892 * src/maemo/modest-account-settings-dialog.c:
893 (modest_account_settings_dialog_init): Store the notebook so we can
895 Added modest_account_settings_dialog_switch_to_user_info().
897 * src/modest-tny-account-store.c:
898 (get_password): When the password in the account settings is wrong (we think),
899 show the relevant page of the account settings dialog, in the mainloop.
900 However, we currently get many of these at once because cancel does not
902 (forget_password): Do not forget the password
903 from the account settings, because this causes side-effects when
904 tinymail seems to call it at strange time, maybe because of how we
905 are cancelling get_password().
906 (modest_tny_account_store_alert): Ignore user cancellations.
908 2007-07-09 Murray Cumming <murrayc@murrayc.com>
910 * src/maemo/modest-maemo-utils.h:
911 * src/maemo/modest-maemo-utils.c:
912 Added modest_maemo_show_information_note_and_forget() for use instead of
913 gtk_dialog_run() when the response is not needed, to avoid an extra
914 mainloop which could cause a hang.
916 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
917 Use the logical IDs for the error message, though they are not
918 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
919 because gtk_dialog_run() caused a hang here (the window did not close).
920 This fixes projects.maemo.org bug NB#62646.
922 2007-07-09 Murray Cumming <murrayc@murrayc.com>
924 * src/modest-account-mgr-helpers.h:
925 * src/modest-account-mgr-helpers.c:
926 Added modest_account_mgr_get_store_protocol().
928 * src/maemo/modest-account-view-window.c:
929 (on_delete_button_clicked): Show different warning text depending on
930 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
931 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
934 2007-07-09 Murray Cumming <murrayc@murrayc.com>
936 * src/maemo/modest-msg-edit-window.c:
937 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
938 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
940 2007-07-07 Armin Burgmeier <armin@openismus.com>
942 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
943 ckdg_ib_maximum_characters_reached from correct package.
945 * src/modest-ui-actions.c: Show an error message when a folder could
946 not be created. Tinymail does not give us specific error codes about
947 what has gone wrong, so we assume that a folder with that name
948 already exists, though there might be other reasons.
950 2007-07-06 Murray Cumming <murrayc@murrayc.com>
952 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
953 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
954 give a more exact error message that can be partly translated.
956 2007-07-05 Murray Cumming <murrayc@murrayc.com>
958 * src/maemo/modest-address-book.c:
959 (select_email_addrs_for_contact): Specify a default window size for the
960 select-email-address dialog, so that it is probably big enough for the
961 title. This should fix projects.maemo.org bug NB#62277.
963 2007-07-05 Murray Cumming <murrayc@murrayc.com>
965 * src/maemo/easysetup/modest-easysetup-wizard.c:
966 (create_page_complete_easysetup): Use
967 gtk_widget_set_size() request to ensure that the text wraps
970 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
972 * src/maemo/easysetup/modest-easysetup-wizard.c:
973 (on_entry_invalid_character), (create_page_account_details),
974 (create_page_user_details):
975 Use new API of ModestValidatingEntry. But for some reason the banner is
976 not shown. I will have to investigate that further.
978 * src/widgets/modest-validating-entry.c: (on_insert_text),
979 (modest_validating_entry_set_func):
980 * src/widgets/modest-validating-entry.h:
981 Added a new callback function to be able to react to prevented
982 characters whitespaces to e.g show a banner.
984 2007-07-05 Armin Burgmeier <armin@openismus.com>
986 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
987 notification of HildonNumberEditor instead of remembering the port
988 number. Thanks to Johannes for pointing this out.
990 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
992 * src/maemo/easysetup/modest-easysetup-wizard.c:
993 Check if there are any user changes before showing a confirmation
994 dialog (projects.maemo.org NB#60946)
996 2007-07-05 Armin Burgmeier <armin@openismus.com>
998 * src/maemo/modest-account-settings-dialog.c: Remember custom port
999 number at the beginning of the dialog and set the modified flag at the
1000 end if the port number has changed. This is necessary because
1001 HildonNumberEditor does not support notification when the value has
1004 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1006 * src/modest-ui-actions.c:
1007 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
1008 a connection before asking anything else. Correct the check for the destination
1009 folder so that it succeeds when online.
1010 This fixed projects.maemo.org bug NB#61645.
1012 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1014 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
1015 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
1016 to fix projects.maemo.org bug NB#62439.
1018 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1020 * src/modest-tny-account.c: (on_connection_status_changed):
1021 Really do not use tny_device_force_offline() here. See the previous comment.
1023 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1025 * src/modest-tny-account.c: (on_connection_status_changed):
1026 Do not use tny_device_force_offline() when tinymail says that something
1027 went wrong with the connection. It seems to report this unnecessarily.
1029 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1031 * src/maemo/modest-connection-specific-smtp-window.c:
1032 (modest_connection_specific_smtp_window_init):
1033 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
1034 does not seem to have any effect in osso 1.1 (though it works in
1035 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
1037 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1039 * src/maemo/modest-connection-specific-smtp-window.c:
1040 Fix UI specification problems with projects.meamo.org NB#60479
1042 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1044 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
1045 clue when this has failed, because the error dialog is not always shown
1046 (at least in earlier version).
1048 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
1049 GError message, because the generic error dialog is not helpful.
1051 'This message is not currently available (can't let a new connection go online)'
1052 when trying to open an IMAP message.
1054 (_modest_ui_actions_open): Offer a connection when some messages would
1055 have to be downloaded and we are offline.
1057 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1059 * src/widgets/modest-folder-view.c:
1060 Don't check for MERGE type anymore as we use the correct type
1062 NOTE: For the last two changes you need to update your tinymail copy
1063 because of API changes!
1065 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1067 * src/modest-tny-local-folders-account.c:
1068 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
1069 (see projects.maemo.org NB#61580)
1071 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1073 * src/modest-tny-account.c: (on_connection_status_changed):
1074 Commented out the call to modest_platform_connect_and_wait() because this
1075 seems to always hang, and I would like to know if this is the only thing
1076 that causes a hang when showing the connection dialog.
1077 It is not very useful anyway.
1079 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1081 * src/maemo/modest-msg-view-window.c:
1082 (modest_msg_view_window_select_next_message):
1084 * src/modest-platform.h:
1085 * src/maemo/modest-platform.c:
1086 Added modest_platform_connect_and_wait(), which calls
1087 tny_maemo_conic_device_connect() always in the main thread, by calling it
1088 in an idle handler and waiting for the idle handler to run. It should be
1089 in the main thread because it uses GTK+ UI code. It just returns TRUE
1090 if the device is already online.
1092 There is some nasty code to ensure that subsequent calls to
1093 modest_platform_connect_and_wait() just wait for the first one to finish,
1094 by checking repeatedly in another idle handler. This is necessary,
1095 because other threads (or even the main thread, via another idle handler)
1096 can call modest_platform_connect_and_wait() while
1097 modest_platform_connect_and_wait() is running.
1099 (modest_platform_connect_and_wait_if_network_account),
1100 (modest_platform_connect_and_wait_if_network_folderstore):
1101 Convenience functions that calls modest_platform_connect_and_wait() if
1102 the account or folder might want network access.
1104 * src/modest-mail-operation.c:
1105 (modest_mail_operation_update_account):
1106 * src/modest-ui-actions.c: (download_uncached_messages),
1107 (modest_ui_actions_on_rename_folder), (delete_folder),
1108 (modest_ui_actions_on_main_window_move_to),
1109 (modest_ui_actions_on_msg_view_window_move_to):
1110 * src/widgets/modest-folder-view.c:
1111 (drag_and_drop_from_folder_view):
1112 Offer a connection if we are offline.
1114 * src/modest-tny-account.c: (on_connection_status_changed):
1115 Document this as only handling errors during network operations in progress,
1116 and replace the idle code with a simple call to
1117 modest_platform_connect_and_wait(), which does this instead.
1119 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1121 * src/modest-tny-account.c:
1122 (modest_tny_account_get_special_folder): (util_on_idle),
1123 Handle the GError so we can see when tny_folder_store_get_folders()
1124 fails, as it currently does while something else is connecting.
1126 Added util_run_in_main_thread_and_wait()
1127 which uses an idlen handler and mainloop to ensure that the function
1128 is called in the main thread.
1129 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
1130 to make sure that we call attempt the connection in the mainloop only,
1131 which might solve some hangs.
1133 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1135 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
1136 be found by their display name. This is never useful.
1137 * src/modest-tny-account-store.c: (on_account_removed): Find the account
1138 by its ID, instead of trying to use its ID as its display name.
1140 * src/modest-tny-account-store.h:
1141 * src/modest-tny-account.c:
1142 (modest_tny_account_get_special_folder): Add a g_warning() when
1143 tny_folder_store_get_folders() returns an empty list for the maildir.
1145 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
1146 Add a g_warning() when this returns NULL, because that it not allowed
1149 2007-07-02 Armin Burgmeier <armin@openismus.com>
1151 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
1152 note when trying to cancel the wizard. This fixes projects.maemo.org
1155 2007-07-02 Murray Cumming <murrayc@murrayc.com>
1157 * src/modest-tny-account.h:
1158 * src/modest-tny-account.c:
1159 (modest_tny_account_new_from_server_account),
1160 (modest_tny_account_new_from_server_account_name),
1161 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
1162 because this must now be set before setting the proto. This is usd in
1163 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
1164 warning in camel_session_get_service() caused by
1165 tny_camel_transport_account_prepare().
1167 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
1170 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
1172 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1174 (modest_connection_specific_smtp_edit_window_init):
1176 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
1177 of "changed" for now
1179 2007-06-29 Murray Cumming <murrayc@murrayc.com>
1181 * src/modest-tny-account.c:
1182 (modest_tny_account_new_from_server_account):
1183 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
1184 now uses to request a connection when it needs one, and which it uses
1185 to tell us that something is wrong with the connection, so we can force
1186 the accounts offline to prevent further problems.
1188 * src/modest-defs.h:
1189 * src/modest-init.c: (init_default_settings):
1190 * src/modest-mail-operation.c:
1191 (modest_mail_operation_update_account):
1192 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
1193 This should not be necessary anymore. Do not set the conf key that
1194 determined this (it was always TRUE and not set anywhere else).
1196 * src/modest-ui-actions.h: Remove unused and unimplemented
1197 modest_ui_actions_on_online_toggle_toggled().
1199 2007-06-29 Murray Cumming <murrayc@murrayc.com
1201 * src/maemo/modest-main-window.c: (connect_signals):
1202 Don't connect to delete_event twice. Maybe this was harmless.
1204 2007-06-29 Murray Cumming <murrayc@murrayc.com
1206 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
1207 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
1208 Debug output to give some more clue when a folder move is not allowed.
1210 2007-06-28 Murray Cumming <murrayc@murrayc.com
1212 * src/modest-tny-account.c: (on_modest_file_system_info),
1213 (modest_tny_account_get_mmc_account_name):
1214 Always call the callback, without checking whether the name has changed.
1215 * src/widgets/modest-folder-view.c: (strings_are_equal),
1216 (on_model_foreach_set_name), (on_get_mmc_account_name),
1217 (text_cell_data): Compare the name here, and use the name from
1218 the account rather than from the
1219 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
1220 if the name was changed after the account was added to the model.
1221 That's a tinymail bug but not one that I want to fix now.
1223 This finally fixes projects.maemo.org bug NB#59301.
1225 2007-06-27 Armin Burgmeier <armin@openismus.com>
1227 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
1230 2007-06-27 Murray Cumming <murrayc@murrayc.com
1232 * src/modest-tny-account.h:
1233 * src/modest-tny-account.c:
1234 Added modest_tny_account_get_mmc_account_name(), to set the memory
1235 card name asynchronously for the given account and then notify.
1236 (modest_tny_account_new_for_local_folders): Use this new function instead
1237 of using hildon_file_system_info_async_new() directly.
1239 * src/widgets/modest-folder-view.c: (text_cell_data):
1240 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
1241 gtk_tree_model_row_changed() when it is available.
1243 This should fix projects.maemo.org bug NB#59301.
1245 2007-06-27 Murray Cumming <murrayc@murrayc.com
1247 * src/modest-mail-operation.c: (update_account_thread),
1248 (get_msgs_full_thread): Fix typo failures in the revert
1251 2007-06-27 Murray Cumming <murrayc@murrayc.com
1253 * src/maemo/modest-maemo-global-settings-dialog.c:
1254 (idle_select_default_focus):
1255 * src/modest-mail-operation.c: (idle_notify_progress),
1256 (idle_notify_progress_once), (set_last_updated_idle),
1257 (update_account_thread), (get_msgs_full_thread):
1258 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1259 * src/widgets/modest-header-view.c:
1260 (idle_notify_headers_count_changed_destroy),
1261 (idle_notify_headers_count_changed):
1262 Reverted the additions of gdk_threads_enter/leave(), in case this
1263 helps with a startup hang on the device.
1265 2007-06-26 Armin Burgmeier <armin@openismus.com>
1267 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
1268 for supported secure authentication methods from server by
1269 gtk_dialog_run(), saving CPU time and a potential race condition.
1271 2007-06-26 Armin Burgmeier <armin@openismus.com>
1273 * src/maemo/modest-maemo-utils.h:
1274 * src/maemo/modest-maemo-utils.c: Added a
1275 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
1276 only error code to tell the calling code when the user canceled the
1279 * src/maemo/modest-account-settings-dialog.h:
1280 * src/maemo/modest-account-settings-dialog.c:
1281 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
1282 message if the retrieval of secure authentication methods was canceled
1283 by the user. Perform the check before saving anything to configuration
1284 to not end up with half-committed configuration changes, do not show
1285 a "Saving to configuration failed" note when authentication methods
1286 could not be retrieved.
1288 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
1291 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1293 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1294 Only return the first level of folders under accounts, because the
1295 osso-global-search UI spec doesn't want the rest.
1296 This fixed projects.maemo.org bug NB#61811.
1298 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1300 * src/modest-tny-account-store.c:
1301 * src/modest-tny-account-store.h:
1302 Added modest_tny_account_is_memory_card_account().
1303 * src/maemo/modest-main-window.c: (create_details_widget):
1304 Show the same information items for the memory card as we show for the
1305 local-folders, to fix projects.maemo.org bug NB#59307.
1307 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1309 * src/modest-tny-account-store.c: (get_password):
1310 Added some checks for NULL to maybe prevent crashes, though I think
1311 it was Philip's last commit that actually prevented the crash here
1312 when creating a first new account.
1313 But the new account is still not usable (no messages are shown)
1314 until a restart of the application.
1316 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1318 * src/maemo/modest-maemo-global-settings-dialog.c:
1319 (idle_select_default_focus):
1320 * src/modest-mail-operation.c: (idle_notify_progress),
1321 (idle_notify_progress_once), (idle_notify_update_account_queue),
1322 (set_last_updated_idle), (update_account_thread),
1323 (notify_get_msgs_full), (get_msgs_full_destroyer),
1324 (get_msgs_full_thread):
1325 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1326 * src/widgets/modest-header-view.c:
1327 (idle_notify_headers_count_changed_destroy),
1328 (idle_notify_headers_count_changed):
1329 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1330 all idle handlers, because some other thread could be blocking
1331 the GDK lock, so that it can do GUI stuff.
1333 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1335 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1336 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1337 (on_idle_send_receive), (on_idle_open_default_inbox):
1338 * src/maemo/modest-msg-edit-window.c:
1339 (modest_msg_edit_window_attach_file_noninteractive):
1340 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1341 to prevent a hang. I don't quite understand why these are necessary,
1342 beause we should already be in the main loop. I guess something outside
1343 of the main loop is taking the lock.
1345 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1346 we are really using URIs, and use files that are more likely to exist.
1348 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1350 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1351 necessary because configure.ac now defines different variables.
1353 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1355 * libmodest-dbus-client/libmodest-dbus-client.c:
1356 * libmodest-dbus-client/libmodest-dbus-client.h:
1357 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1358 libmodest_dbus_client_compose_mail() is what things actually use.
1360 * src/dbus_api/modest-dbus-api.h:
1361 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1362 * tests/dbus_api/Makefile.am:
1363 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1366 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1368 * src/modest-init.c: (modest_init_local_folders):
1369 For memory-card (or other non local-folders) maildir accounts,
1370 always create an Archive folder, so that there is somewhere to put
1371 messages. This should be less confusing, because the user does not need
1372 to guess that the need to create a folder.
1374 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1376 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1377 Fixed icon size by using (50, 50) which is the same as defined by
1380 2007-06-25 Armin Burgmeier <armin@openismus.com>
1382 * src/widgets/modest-window-mgr.c:
1383 * src/modest-init.c:
1384 * configure.ac: Correctly recognize hildon-notify presence and fixed
1385 the build without it being installed.
1387 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1389 * libmodest-dbus-client/libmodest-dbus-client.c:
1390 (libmodest_dbus_client_search): Fix the build. Sorry.
1391 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1392 (reply_forward_cb): Initialize variables to fix the build.
1394 * src/modest-tny-account-store.c:
1395 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1396 comparison (a silly typo) so that email search results can be opened
1397 when there are more than one account.
1399 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1401 * libmodest-dbus-client/libmodest-dbus-client.c:
1402 (libmodest_dbus_client_search),
1403 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1404 instead of 1 second, because the search gets folders and messages from
1405 the server, which can take a long time. When it times out,
1406 osso-global-search will report no results.
1408 We need to specify whether we should search only cached information
1409 (maybe with a user preference), and the osso-email-search-plugin
1410 API should really be improved to allow that option, and to allow results
1411 to be delivered asynchronously in batches.
1413 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1415 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1416 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1417 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1419 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1421 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1422 that is an empty string. D-Bus seems to give us these instead of NULL.
1424 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1426 * src/dbus_api/modest-dbus-callbacks.c:
1427 * src/maemo/easysetup/modest-easysetup-wizard.h:
1428 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1429 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1430 (modest_connection_specific_smtp_edit_window_init):
1431 * src/maemo/modest-maemo-global-settings-dialog.c:
1433 * src/maemo/modest-maemo-utils.c:
1434 (modest_maemo_utils_setup_images_filechooser):
1435 * src/maemo/modest-main-window.c: (create_details_widget):
1436 * src/maemo/modest-msg-edit-window.c:
1437 (modest_msg_edit_window_attach_file_noninteractive),
1438 (modest_msg_edit_window_color_button_change),
1439 (modest_msg_edit_window_set_zoom):
1440 * src/modest-mail-operation.c: (update_account_thread):
1441 * src/modest-tny-account-store.c:
1442 * src/modest-tny-account.c:
1443 * src/widgets/modest-global-settings-dialog.c:
1444 * src/widgets/modest-window.h:
1446 Fixed build on bora!
1448 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1450 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1451 * src/modest-search.c: (modest_search_folder),
1452 (modest_search_all_accounts): Actually search only in the specified folder,
1453 doing a simple match on the folder ID.
1454 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1455 and added some documentation.
1457 2007-06-22 Armin Burgmeier <armin@openismus.com>
1459 * src/maemo/modest-maemo-utils.h:
1460 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1461 modest_maemo_utils_get_supported_secure_authentication_methods.
1463 * src/maemo/easysetup/modest-easysetup-wizard.c:
1464 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1465 one occured, not just "Server does not support secure authentication".
1467 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1469 * src/modest-tny-account-store.c: (get_password):
1470 Restored the call to tny_account_set_user() because Philip seems to have
1471 stopped this from crashing (by not using the freed string). It still does
1472 not work, but now we can test it.
1474 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1476 * src/maemo/modest-msg-edit-window.c: (init_window):
1477 Comment out use of an uninitialzed GtkScrolledWindow variable,
1478 to fix the build and stop a crash. Yet again.
1480 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1482 * src/modest-tny-account-store.c: (get_password):
1483 Remove the call to tny_account_set_user() because this actually crashes.
1484 As mentioned in the last commit, it is known to not work anyway.
1486 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1488 * src/modest-tny-account-store.c: (get_password):
1489 Use tny_account_set_username() to tell tinymail that the username might
1490 have changed too. But tinymail ignores this: see projects.maemo.org
1492 * src/modest-ui-actions.c:
1493 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1494 reset the connection when changing the username, and improve the comments.
1495 Save the changed username to gconf at least, so it is used when Modest is
1498 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1500 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1501 Do not use a query, so that we get all folders, including for POP and
1502 local-folders. They work as search criteria too.
1503 This fixes projects.maemo.org bug NB#57740.
1505 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1507 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1508 Comment out the use of hildon_notification_set_sound() because it is
1509 not declared, to fix the build. Warnings are serious, people.
1511 2007-06-21 Armin Burgmeier <armin@openismus.com>
1513 * src/maemo/modest-maemo-utils.h:
1514 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1515 modest_maemo_utils_get_supported_secure_authentication_methods()
1516 to query authentication methods for a specific user. This should fix
1517 projects.maemo.org bug NB#61369.
1519 * src/maemo/easysetup/modest-easysetup-wizard.c:
1520 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1523 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1525 * libmodest-dbus-client/libmodest-dbus-client.h:
1526 * libmodest-dbus-client/libmodest-dbus-client.c:
1527 (modest_dbus_message_iter_get_search_hit),
1528 (libmodest_dbus_client_search):
1529 Reorganised and commented this.
1530 Removed modest_search_hit_free() from the public API because it
1533 Added libmodest_dbus_client_get_folders() and
1534 modest_folder_result_list_free().
1536 * src/dbus_api/modest-dbus-api.h:
1537 * src/dbus_api/modest-dbus-callbacks.c:
1538 (modest_dbus_req_filter): Commented. Moved most code to
1539 on_dbus_method_search() and added on_dbus_method_get_folders().
1541 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1542 of the extra D-Bus handler.
1544 * tests/dbus_api/Makefile.am:
1545 * tests/dbus_api/test_get_folders.c: New test for
1546 libmodest_dbus_client_get_folders(). This seems to return an empty list
1547 at the moment. That could be the same error that causes the message list
1548 to be empty sometimes.
1549 This should help with projects.maemo.org bug NB#57740.
1551 2007-06-21 Armin Burgmeier <armin@openismus.com>
1553 * src/modest-mail-operation.c: Do not call
1554 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1555 notify the operation's end after having set the status to CANCELED for
1556 the operation queue to listen on. This fixes a deadlock when there
1557 were mail operations in the queue during its finalization.
1559 * src/modest-singletons.c: Reordered uninitialization of the account
1560 manager to happen after the mail operation queue was uninitialized
1561 because the mail operation's in the queue might still try to access
1562 the account manager (see modest_mail_operation_notify_end()). This
1563 fixes a potential crash when terminating the application.
1565 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1567 * src/modest-search.c:
1568 (search_mime_part_and_child_parts): Moved some code here so we
1569 can search recursively in child folders.
1570 (modest_search_folder): Search in the message as a mime part, instead
1571 of just its child mime parts.
1572 (read_chunk), (search_mime_part_ogs):
1573 Check how many bytes were read, to prevent an endless loop.
1574 Searching in message bodies now works. This finishes the fix for
1575 projects.maemo.org bug NB#61007.
1577 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1579 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1580 Add a g_warning when the item is not a folder.
1582 * src/modest-ui-dimming-rules.c:
1583 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1584 when selected item is not a folder (for instance, an account), because
1585 the UI spec only talks about folders.
1586 I am not sure what the UI spec wants, so this might not totally fix
1587 projects.maemo.org bug NB#60794.
1589 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1591 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1592 (load_from_file): Sort the list. The unsorted list would be more noticeable
1593 in non-English locales.
1595 * src/maemo/modest-msg-edit-window.c:
1596 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1597 warning and fix the build.
1599 * src/maemo/modest-progress-bar-widget.c:
1600 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1601 avoid a g_warning, and probably to avoid a crash.
1603 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1605 * src/modest-search.c: (modest_search_folder): Check for a GError
1606 when calling tny_folder_get_headers(), to show that this is not the cause
1609 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1611 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1612 Actually set the body query instead of the subject query.
1614 * src/modest-search.c: (search_mime_part_ogs),
1615 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1616 which would probably cause it to fail if we got this far.
1618 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1619 to simplify the code.
1620 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1621 be causing search-in-body to fail.
1623 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1625 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1627 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1628 Better debug message when the folder cannot be found.
1629 This should help with fixing projects.maemo.org bug #61287.
1630 * src/modest-search.c: (add_hit): Do not leak the furl string.
1632 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1634 * src/modest-ui-actions.c:
1635 (modest_ui_actions_on_folder_selection_changed):
1636 Do not special-case TNY_MERGE_FOLDER here, because
1637 modest_tny_folder_get_account() already does that. This fixes
1638 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1639 shown when the Outbox was selected).
1641 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1643 * libmodest-dbus-client/libmodest-dbus-client.c:
1644 (_dbus_iter_get_string_or_null): Initialize the string variable in
1645 case this helps with Dirk's crash.
1647 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1649 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1650 though it is not implemented yet (this function is maybe not even used),
1651 to avoid breaking ABI in future.
1652 * libmodest-dbus-client/libmodest-dbus-client.c:
1653 (get_attachments_string): Moved some code into this generic function.
1654 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1655 sends email. It is maybe not used.
1656 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1657 (on_send_mail): Use attachments.
1659 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1660 * src/maemo/modest-msg-edit-window.c:
1661 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1662 a filename before using it, to fix projects.maemo.org bug NB#58233.
1664 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1666 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1667 Initialize the continue_download variable to fix the build, and probably
1668 to fix randome behaviour.
1670 2007-06-18 Armin Burgmeier <armin@openismus.com>
1672 * src/modest-tny-send-queue.h:
1673 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1674 the queue so we can later show it in the UI. Replaced
1675 modest_tny_send_queue_msg_is_being_sent() by
1676 modest_tny_send_queue_get_msg_status().
1678 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1680 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1681 gpointer. This probably was not harmful, but just to be sure.
1683 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1685 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1686 Fix the build, but leave the function broken on Bora, because
1687 hildon_uri_action_get_service() does not exist.
1688 osso_uri_action_get_service() does not exist either, it seems.
1690 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1692 * src/modest-tny-account.c:
1693 (modest_tny_account_new_from_server_account):
1694 Uncommented the url debug output again, because it is useful for
1695 debugging, as I said in the comment.
1697 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1699 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1701 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1702 for Mameo Bora, to fix the build.
1704 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1707 Fixed build with hildon < 0.99
1709 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1710 Check if the selected account is busy instead of checking all accounts
1712 * src/modest-account-mgr-priv.h:
1713 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1714 (modest_account_mgr_init), (compare_account_name),
1715 (modest_account_mgr_set_account_busy),
1716 (modest_account_mgr_account_is_busy):
1717 * src/modest-account-mgr.h:
1718 Added busy information to the account manager. It possible to
1719 set an account to busy or not busy now.
1721 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1722 (modest_mail_operation_update_account),
1723 (modest_mail_operation_notify_end):
1724 Set the account to busy/not busy depending on the operation state.
1726 * src/widgets/modest-account-view.c:
1727 (modest_account_view_finalize), (get_last_updated_string),
1728 (update_account_view), (on_account_busy_changed), (init_view):
1729 Show string "Refreshing..." if the account is currently busy.
1731 All this fixes projects.maemo.org bug NB#59711
1733 2007-06-14 Armin Burgmeier <armin@openismus.com>
1735 * src/widgets/modest-attachments-view.h:
1736 * src/widgets/modest-attachments-view.c: Added
1737 modest_attachments_view_has_attachments() and fixed coordinate
1738 transformation in get_att_view_at_coords(). This fixes attachment
1741 * src/widgets/modest-msg-view.c: Make use of
1742 modest_attachments_view_has_attachments() to decide whether to show
1743 attachments in the header.
1745 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1747 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1748 (on_change), (on_combo_security_changed),
1749 (modest_connection_specific_smtp_edit_window_init),
1750 (modest_connection_specific_smtp_edit_window_set_connection),
1751 (modest_connection_specific_smtp_edit_window_is_dirty):
1752 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1753 * src/maemo/modest-connection-specific-smtp-window.c:
1756 Show an comfirmation dialog for the smpt-edit-window if there are
1757 unsaved changes and the user hits cancel.
1758 (projects.maemo.org bug NB#60479)
1760 2007-06-14 Armin Burgmeier <armin@openismus.com>
1762 * src/maemo/easysetup/modest-easysetup-wizard.c:
1763 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1764 address" info in banner instead of node, and select all the text as
1765 per UI spec. This fixes projects.maemo.org bug NB#60550.
1767 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1769 reviewed by: <delete if not using a buddy>
1771 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1772 * src/modest-ui-actions.c: (folder_refreshed_cb):
1774 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1776 * src/widgets/modest-folder-view.c: (filter_row):
1777 Explictly filter out the per-account outbox accounts. I don't know why
1778 these only sometimes show up, but now they should never show up in the UI.
1779 This should fix projects.maemo.org bug NB#60160.
1781 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1783 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1784 when the toolbar does not exist yet.
1785 * src/modest-widget-memory.c: (save_settings_header_view):
1786 Added g_warnings() to help us to discover when we are trying to set
1787 an empty columns list in gconf.
1789 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1791 * src/modest-init.h:
1792 * src/modest-init.c:
1793 Added modest_init_get_default_header_view_column_ids().
1795 * src/modest-widget-memory.c: (restore_settings_header_view):
1796 Use the new function to get defaults, if the gconf key is empty,
1797 instead of not creating any columns. This seems to fix the
1798 empty right-hand pane problems.
1800 * src/widgets/modest-header-view.h: Improved documentation.
1802 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1804 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1805 Revert the use of the display name as the account name, because this
1806 is generally wrong and would break the code that follows.
1808 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1810 * src/maemo/easysetup/modest-easysetup-wizard.c:
1811 (check_for_supported_auth_methods), (on_before_next),
1814 More correct fix for projects.maemo.org bug NB# 58991
1815 Do not longer accept AUTH_PASSWORD as secure method and choose
1816 correct method when creating the account.
1818 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1820 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1821 Fixed projects.maemo.org bug NB# 58991
1823 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1825 * src/modest-init.c: (modest_init_init_core),
1826 (modest_init_local_folders): Fixed compilation errors.
1828 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1830 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1831 Remove unnecessary lib/include, though it is good in principle when needed.
1833 * src/modest-init.c: (modest_init_one_local_folder),
1834 (modest_init_local_folders):
1835 * src/modest-init.h: Initialize the .modest library for memory cards,
1836 instead of just doing nothing for them. This should allow us to create
1837 folders there, fixing projects.maemo.org bug NB#59297.
1839 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1841 * libmodest-dbus-client/libmodest-dbus-client.c:
1842 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1843 (libmodest_dbus_client_compose_mail),
1844 (libmodest_dbus_client_open_message),
1845 (libmodest_dbus_client_send_and_receive),
1846 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1848 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1849 (on_idle_open_message), (modest_dbus_req_handler),
1850 (search_result_to_message), (modest_dbus_req_filter):
1851 * src/modest-search.c: (add_hit), (modest_search_folder),
1852 (modest_search_all_accounts): Improved debug messages.
1854 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1856 * src/modest-tny-account-store.c:
1857 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1860 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1863 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1865 * src/modest-tny-account-store.c: (get_server_accounts):
1866 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1867 even when there are no accounts, so that the Outbox folder is always
1868 visible. This fixes projects.maemo.org bug NB#60158.
1870 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1872 * src/maemo/modest-main-window.c: (create_details_widget):
1873 Use the mcen_va_never logical ID.
1875 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1877 * src/dbus_api/modest-dbus-api.h:
1878 * src/dbus_api/modest-dbus-callbacks.c:
1879 (on_idle_open_default_inbox), (on_open_default_inbox),
1880 (modest_dbus_req_handler):
1881 Added a new OpenDefaultInbox method.
1883 * libmodest-dbus-client/libmodest-dbus-client.h:
1884 * libmodest-dbus-client/libmodest-dbus-client.c:
1885 Added libmodest_dbus_client_open_default_inbox() to call the new
1886 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1887 though it should maybe be used by a new osso-email-interface function.
1889 * tests/dbus_api/Makefile.am:
1890 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1893 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1895 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1896 NULL, so that the signals get all the keys. This should not actually
1897 change any behaviour because we currently update everything when anything
1900 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1902 * src/widgets/modest-folder-view.c: (text_cell_data),
1903 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1904 (find_inbox_iter): If tinymail tells us that the folder is
1905 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1906 This causes the inbox to be selected at startup, fixing part of
1907 projects.maemo.org bug NB#56305.
1909 * src/modest-ui-dimming-rules.c:
1910 (modest_ui_dimming_rules_on_tools_smtp_servers):
1911 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1912 the SMTP servers menu item.
1913 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1914 that the SMTP Servers menu item is dimmed when there are no accounts,
1915 as a future version of the UI spec will require. This fixes
1916 projects.maemo.org bug NB#56305.
1918 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1920 * src/maemo/modest-maemo-utils.c:
1921 (modest_maemo_utils_get_supported_secure_authentication_methods):
1922 Added label to dialog instead of unreadable title
1924 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1925 (modest_main_window_new):
1926 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1929 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1930 * src/modest-account-mgr.h:
1931 Added method to avoid code duplication
1933 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1934 (modest_ui_actions_on_send_receive):
1935 Use modest_account_mgr_has_accounts
1937 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1939 * src/maemo/easysetup/modest-presets.c:
1940 (modest_presets_get_info_server_security): Do not report secure auth
1942 * src/modest-protocol-info.c: Use the defines for the gconf key names
1943 for secure authentication. This was not working because we were writing
1944 Password and reading password, and the check was case sensitive.
1945 With this, gmail now works for receiving and sending when created via
1948 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1950 * src/maemo/easysetup/modest-presets.c:
1951 (modest_presets_get_info_server_security): Correct the key name for
1952 SecureSmtp, because it seems to be case-sensitive.
1953 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1954 Do not try to get the 0th notebook page if there are 0 pages, to
1955 avoid a g_warning().
1957 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1959 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1960 Prevent use of the new notification feature for now, because it currently
1961 shows one dialog for each new email, which is annoying.
1963 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1965 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1966 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1967 when no country was selected, so that we show the global ones.
1968 * src/maemo/easysetup/modest-presets.c:
1969 (modest_presets_get_providers): Return only the global providers, not
1970 all providers when mmc=0 was requested.
1972 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1974 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1975 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1976 provider ID in the combo.
1978 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1979 Do not show the page numbers, because it would be confusing when we add
1980 the 2 extra pages for the custom setup, when the user chooses the "Other"
1981 provider. This fixes projects.maemo.org bug NB#59028
1983 * src/modest-init.c: (modest_init_init_core),
1984 (modest_init_local_folders):
1985 * src/modest-init.h:
1986 * src/modest-tny-account.c:
1987 (modest_tny_account_new_for_local_folders): Do not create default folders
1988 for the memory card. This should fix projects.maemo.org bug NB#59328.
1990 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1992 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1993 Free the changed_conf_keys string items. They are already freed in the
1994 idle handler if that runs first.
1996 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1998 * src/modest-ui-actions.c:
1999 (modest_ui_actions_on_password_requested): Check that the server name
2000 is not NULL, because I just saw a password dialog with (null) as the
2003 * src/modest-tny-folder.[h|c]: Added
2004 modest_tny_folder_is_memory_card_folder().
2005 * src/modest-ui-dimming-rules.c:
2006 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
2007 menu item for memory cards, as per the UI spec (section 7.4). This should
2008 fix projects.maemo.org bug NB#59297.
2010 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
2012 * src/maemo/modest-main-window.c: (sync_accounts_cb):
2013 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
2014 is another problem with the code, see Murray's comment at line 772)
2016 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2018 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
2019 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2020 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
2021 (load_from_file), (easysetup_country_combo_box_init),
2022 (easysetup_country_combo_box_get_active_country_ids),
2023 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
2024 instead of just one ID, to avoid duplicate country names in the UI.
2026 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
2027 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2028 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
2029 a single ID, avoiding duplicate providers.
2030 * src/maemo/easysetup/modest-easysetup-wizard.c:
2031 (on_combo_account_country): Adapt to use a list.
2033 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2035 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
2036 keys changed in the last X seconds.
2038 * src/modest-account-mgr.h:
2039 * src/modest-account-mgr.c: (on_timeout_notify_changes),
2040 (on_key_change), (modest_account_mgr_class_init),
2041 (modest_account_mgr_init), (modest_account_mgr_finalize):
2042 As the keys are changed, save them in a GSList* and signal that GSList*
2043 further every X seconds, to batch changes, to allow us to do just one
2044 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
2045 bug NB#56941 and other (UI-blocking) delays when changing account settings.
2047 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
2048 changed signal signature.
2050 * src/modest-conf.c: (modest_conf_set_list),
2051 (modest_conf_on_change): Reenable notification.
2053 (modest_conf_maemo_fake_on_change): Comment out the hack that
2054 notified immediately instead of asynchronously.
2056 * src/widgets/modest-account-view.h:
2057 * src/widgets/modest-account-view.c:
2058 (update_account_view): Select the previously-selected account ID,
2059 if possible. This fixes projects.maemo.org bug NB#56933.
2061 (on_account_changed), (on_account_removed),
2062 (modest_account_view_select_account):
2064 Remove the block/unblock functions
2065 because they were not useful.
2067 * src/maemo/modest-account-view-window.c:
2068 (on_delete_button_clicked), (on_edit_button_clicked),
2069 (on_new_button_clicked): Remove the use of the non-working block/unblock.
2071 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2073 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2074 Improve the error dialog to show Incorrect Account Settings, which seems
2075 clearer, and say that the internal error message (to be removed from the
2076 dialog later) is often misleading.
2077 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
2079 * src/modest-tny-account.c:
2080 (modest_tny_account_new_from_server_account): Uncomment the printf of the
2081 URL because this is so useful for debugging on the device.
2083 * src/widgets/modest-serversecurity-combo-box.c:
2084 (modest_serversecurity_combo_box_fill): Correct a logical ID.
2086 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2088 * src/modest-mail-operation.c:
2089 (modest_mail_operation_send_new_mail):
2090 Added a comment about a nasty but apparently harmless message. Details
2091 added to the wiki g_warnings() page.
2093 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2095 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
2096 (modest_tny_send_queue_class_init):
2097 Do not use the priv struct because it is empty, to avoid g_warnings
2098 about a non-existant priv struct.
2100 * src/modest-tny-account-store.c:
2101 (modest_tny_account_store_get_server_account),
2102 (modest_tny_account_store_get_transport_account_for_open_connection
2103 ): Do not try to get transport server accounts for local folders,
2104 because they don't have any. This avoids a g_warning().
2106 * src/maemo/modest-main-window.c:
2107 (modest_main_window_notify_send_receive_initied),
2108 (on_configuration_key_changed):
2109 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
2110 * src/modest-defs.h:
2111 * src/modest-mail-operation.c:
2112 (modest_mail_operation_update_account):
2113 * src/modest-tny-account-store.h:
2114 * src/modest-tny-account.c:
2115 (modest_tny_account_get_special_folder),
2116 (modest_tny_account_new_for_local_folders),
2117 (modest_tny_account_new_for_per_account_local_outbox_folder):
2118 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
2119 * src/modest-tny-local-folders-account.c:
2120 (add_account_folders_to_merged_folder):
2121 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
2122 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
2123 (modest_ui_actions_on_send):
2124 * src/widgets/modest-folder-view.c: (update_model):
2125 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
2126 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
2127 modest_tny_account_store_get_tny_account_by_account() to
2128 modest_tny_account_store_get_server_account() to make the code clearer.
2130 2007-06-07 Marcus Bauer <marcusb@openismus.com>
2132 * src/dbus_api/modest-dbus-api.h:
2133 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
2134 * src/maemo/modest-msg-edit-window.c:
2135 (modest_msg_edit_window_attach_file_noninteractive):
2136 added g_warning in case the file to be attached does not exist
2137 * tests/dbus_api/test_compose_mail.c: (main):
2138 removed obsolete comment, added generic files as test case
2140 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2142 * src/modest-tny-account-store.c: (get_server_accounts):
2143 Create the local folders account only once, not once for each outbox, and
2144 not only when there are some outboxes.
2146 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2148 * src/widgets/modest-folder-view.c: (update_model): Comment out some
2149 code that is causing a crash at startup. Sergio says that he is fixing this.
2151 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
2153 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2154 * src/maemo/modest-account-settings-dialog.c:
2155 (create_page_outgoing),
2156 (modest_account_settings_dialog_set_account_name),
2157 (save_configuration):
2158 - Fixed handling of the "Use secure authentication" toggle to comply with
2159 the ui specification. See also projects.maemo.org bug NB#58400
2161 - Restore the Secure connection setting combo correctly when loading
2164 * src/maemo/modest-maemo-utils.c:
2165 (on_camel_account_get_supported_secure_authentication),
2166 (modest_maemo_utils_get_supported_secure_authentication_methods):
2167 Fixed a crasher if operation is canceled
2169 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
2170 (modest_protocol_info_auth_is_secure):
2171 * src/modest-protocol-info.h:
2173 Added two new methods to determine if a protocol/auth method is secure/encrypted in
2174 the sense of the "Use secure authentication" toggle.
2176 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2178 * src/modest-tny-account-store.h:
2179 * src/modest-tny-account-store.c:
2180 Added modest_tny_account_store_get_local_folders_account().
2182 * src/modest-tny-folder.h:
2183 * src/modest-tny-folder.c:
2184 (modest_tny_folder_get_account):
2185 Added this replacement for tny_folder_get_account() which returns
2186 the local-folders account for TnyMergeFolders, to avoid the
2187 warning about the unimplemented get_account_func() vfunc().
2189 (modest_tny_folder_get_rules),
2190 * src/modest-ui-actions.c:
2191 (modest_ui_actions_on_folder_selection_changed):
2192 * src/modest-mail-operation.c:
2193 (modest_mail_operation_remove_folder),
2194 (modest_mail_operation_xfer_folder),
2195 (modest_mail_operation_rename_folder),
2196 (modest_mail_operation_get_msg),
2197 (modest_mail_operation_get_msgs_full),
2198 (modest_mail_operation_remove_msg),
2199 (modest_mail_operation_xfer_msgs),
2200 (modest_mail_operation_refresh_folder):
2201 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
2203 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2205 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
2206 (modest_server_account_set_security):
2207 * src/modest-defs.h: Add comments explaining that our
2208 UI spec means TLS when it says Normal, so these do not look like errors.
2210 * src/modest-tny-account.c:
2211 (modest_tny_account_new_from_server_account): Use the new tinymail
2212 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
2213 for TLS. This should fix projects.maemo.org bug NB#58460.
2215 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2217 * src/maemo/easysetup/modest-easysetup-wizard.c:
2218 (create_account): Correct the position of the gconf sanity check warning.
2219 (on_button_edit_advanced_settings): Show the dialog immediately, instead
2220 of using the g_idle_add() hack, because this does not seem to be necessary
2221 on osso 1.1. It might even work on Maemo Bora if the problems were actually
2222 caused by something other than maemo's gconf.
2223 This fixes projects.maemo.org bug #59022.
2225 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2227 * src/modest-account-mgr-helpers.c:
2228 (modest_account_mgr_get_default_account): Do not check that the account
2229 exists if there is no default account (NULL), to fix a runtime warning.
2231 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2233 * src/widgets/modest-folder-view.c: (update_model):
2234 Do not unref the treemodel before we have finished with it.
2235 This prevents a valgrind warning and an occasional crash at startup.
2237 2007-06-06 Marcus Bauer <marcusb@openismus.com>
2239 * libmodest-dbus-client/libmodest-dbus-client.h:
2240 added libmodest_dbus_client_compose_mail()
2241 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2243 added functions needed for SendAsMail() functionality
2244 * src/maemo/modest-msg-edit-window.c:
2245 (modest_msg_edit_window_attach_file_noninteractive):
2246 non interactively attaching files to message edit window
2247 * src/widgets/modest-msg-edit-window.h:
2248 * tests/dbus_api/Makefile.am:
2249 added test_compose_mail.c
2250 * tests/dbus_api/test_compose_mail.c: (main):
2252 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2254 * src/modest-account-view.c:
2255 Fixed bug projects.maemo.org bug NB#59307
2257 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2259 * src/maemo/easysetup/modest-easysetup-wizard.c:
2260 (get_serverport_incoming), (on_before_next), (create_account):
2261 * src/maemo/modest-account-settings-dialog.c:
2262 (modest_account_settings_dialog_set_account_name):
2263 * src/maemo/modest-maemo-utils.c:
2264 (on_camel_account_get_supported_secure_authentication_status),
2265 (on_camel_account_get_supported_secure_authentication),
2266 (on_secure_auth_cancel),
2267 (modest_maemo_utils_get_supported_secure_authentication_methods):
2269 Implemented security authentication for settings and easysetup.
2271 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2273 * src/maemo/modest-main-window.c: (create_details_widget):
2274 Show the total size for memory card accounts too, instead of showing
2275 the name again. Fixes bug projects.maemo.org bug NB#59307.
2277 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2280 * src/modest-tny-simple-folder-store.c:
2281 * src/modest-tny-simple-folder-store.h: Removed.
2283 * src/modest-tny-local-folders-account.h
2284 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
2285 for the local-folders maildir, with an extra TnyMergedFolder containing
2286 the folders of the per-account outbox store accounts.
2287 * src/modest-tny-account-store.c: (get_server_accounts):
2288 Add the outboxes to the special local folders account after creating it.
2290 * src/modest-tny-account.c:
2291 (modest_tny_account_new_for_local_folders): Create the derived
2292 account when creating the main local-folders account.
2294 * src/maemo/modest-main-window.c: (create_details_widget),
2295 (modest_main_window_set_contents_style):
2296 Adapted to the use of the derived account instead of the folder store.
2298 * src/modest-ui-actions.c:
2299 (modest_ui_actions_on_folder_selection_changed):
2300 * src/modest-ui-dimming-rules.c:
2301 (modest_ui_dimming_rules_on_new_folder):
2302 * src/widgets/modest-folder-view.c: (text_cell_data),
2303 (icon_cell_data), (filter_row), (update_model),
2304 (get_cmp_rows_type_pos):
2307 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2308 Do not get the priv struct, because no priv struct has been set,
2309 to avoid a runtime warning.
2311 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2312 #ifelse with #else, to fix a warning, to fix the build.
2315 2007-06-05 Christian Kellner <ckellner@openismus.com>
2317 * libmodest-dbus-client/libmodest-dbus-client.c:
2318 Fix small typo in doc (why do you always see them
2319 AFTER committing stuff?)
2322 2007-06-05 Christian Kellner <ckellner@openismus.com>
2324 * libmodest-dbus-client/libmodest-dbus-client.c:
2325 (libmodest_dbus_client_search):
2326 Initialize hit list with NULL. Also set folder list
2327 to "" if NULL was supplied.
2330 2007-06-03 Christian Kellner <ckellner@openismus.com>
2332 * libmodest-dbus-client/libmodest-dbus-client.c:
2333 (modest_search_hit_list_free):
2334 Make it save to call it with NULL.
2336 * src/dbus_api/modest-dbus-callbacks.c:
2337 * src/modest-search.c:
2338 Return full ModestSearchHits as the search result list not TnyHeader
2339 since can't be around withouth the correspoding TnyFolder.
2341 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2343 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2344 Added currently commented code to check for secure auth
2346 * src/maemo/modest-account-settings-dialog.c: (on_response),
2347 (save_configuration), (show_ok):
2348 Fixed projects.maemo.org bugs NB #59248 and #59251
2350 * src/maemo/modest-maemo-utils.c:
2351 (on_camel_account_get_supported_secure_authentication_status),
2352 (on_camel_account_get_supported_secure_authentication),
2353 (modest_maemo_utils_get_supported_secure_authentication_methods):
2354 * src/maemo/modest-maemo-utils.h:
2355 Moved get_supported_secure_authentication() method here to be able
2356 to use it from easysetup wizard.
2358 * src/modest-pair.c: (on_pair_compare_as_string):
2359 Should compare string with first part of pair and not
2360 strcmp pairs which will crash.
2362 * src/modest-protocol-info.c:
2363 (modest_protocol_info_protocol_is_store):
2364 * src/modest-protocol-info.h:
2365 Added modest_protocol_info_get_auth_protocol_name()
2367 2007-06-03 Armin Burgmeier <armin@openismus.com>
2369 * src/modest-mail-operation.c:
2370 (modest_mail_operation_get_msgs_full): Set priv->account also when
2371 only retrieving a single message. This avoids a crash when canceling
2374 (modest_mail_operation_notify_end): Do not explicitely remove the
2375 operation from the queue but only emit the progress_changed signal.
2376 The queue itself listens to that signal to remove the operation when
2377 it is finished. This reduces coupling and removes a potential deadlock
2378 when modest_mail_operation_notify_end() is called from the queue
2379 itself. If that is a problem performance-wise, I would suggest to
2380 implement a status-changed signal or something.
2382 * src/modest-mail-operation-queue.c: Make sure to never call a
2383 function from another file while the queue is locked. This (hopefully)
2384 fixes another deadlock when exiting the application while retrieving
2387 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2389 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2390 Fixed build if libogs is not available
2392 2007-06-03 Christian Kellner <ckellner@openismus.com>
2394 * libmodest-dbus-client/libmodest-dbus-client.h:
2395 * libmodest-dbus-client/libmodest-dbus-client.c:
2396 (libmodest_dbus_client_delete_message):
2397 Implement deletion of messages (Client side).
2399 (modest_search_hit_free),
2400 (modest_search_hit_list_free):
2401 Utility functions to free the result hits.
2403 * src/dbus_api/modest-dbus-api.h:
2404 * src/dbus_api/modest-dbus-callbacks.c:
2405 (on_delete_message),
2406 (modest_dbus_req_handler):
2407 Implement deletion of messages (Server side).
2409 * tests/dbus_api/test_search.c: (main):
2412 * tests/dbus_api/Makefile.am:
2413 * tests/dbus_api/test_delete_message:
2414 Add little test for the message deletion logic
2416 2007-06-03 Armin Burgmeier <armin@openismus.com>
2418 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2419 when the operation queue was not empty. projects.maemo.org bug
2422 2007-06-03 Armin Burgmeier <armin@openismus.com>
2424 * src/widgets/modest-account-view.c
2425 (on_account_default_toggled): Toggle default account column
2426 explicitely instead of waiting for gconf notification (which is
2427 currently ignored). This should fix projects.maemo.org bug NB#56910
2428 for now. It should probably be removed when gconf notifications are
2431 2007-06-03 Christian Kellner <ckellner@openismus.com>
2433 * libmodest-dbus-client/libmodest-dbus-client.c:
2434 Removed debugging spew.
2436 * src/dbus_api/modest-dbus-callbacks.c:
2437 Added debugging info.
2439 * src/modest-search.c:
2440 (modest_search_all_accounts):
2441 Use tny_account_store_get_accounts () on the account store
2442 to get all accounts which is the way to get all accounts.
2444 * tests/dbus_api/test_search.c: (main):
2445 Make it possible to supply the search term on the command line.
2447 2007-06-03 Christian Kellner <ckellner@openismus.com>
2449 * libmodest-dbus-client/libmodest-dbus-client.c:
2450 * libmodest-dbus-client/libmodest-dbus-client.h:
2451 Implement searching for mesages over raw dbus. (Client side)
2453 * src/dbus_api/Makefile.am:
2454 * src/dbus_api/modest-dbus-api.h:
2455 * src/dbus_api/modest-dbus-callbacks.c:
2456 * src/dbus_api/modest-dbus-callbacks.h:
2457 Search framework (Server side). Also implement on_idle_open_message().
2459 * src/maemo/modest-platform.c: (modest_platform_init):
2460 Prepare for raw dbus/osso rpc interaction.
2462 * src/modest-search.h:
2463 Changed minsize from unspecific guint to guint32.
2465 * src/modest-search.c:
2467 Added strange hack which magically made tnymail work.
2469 (modest_search_folder),
2470 (modest_search_account),
2471 (modest_search_all_accounts):
2472 Implement helper functions to search all accounts, specific account
2475 * tests/dbus_api/Makefile.am:
2476 * tests/dbus_api/test_open_message.c:
2477 Read url to open from commandline.
2479 * tests/dbus_api/test_search.c:
2480 Implement small test for dbus search stuff
2482 2007-06-02 Armin Burgmeier <armin@openismus.com>
2484 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2485 include account type and account title. This fixes projects.maemo.org
2488 * src/maemo/modest-account-view-window.c: Set a title for the window.
2490 2007-06-02 Armin Burgmeier <armin@openismus.com>
2492 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2493 incoming and outgoing server name based on email address and server
2494 types as long as the names have not been edited manually. This fixes
2495 projects.maemo.org bug NB#58671.
2497 2007-06-02 Armin Burgmeier <armin@openismus.com>
2499 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2500 server type cannot be changed in future to the incoming details page
2501 when creating an account. This fixes projects.maemo.org bug NB#59029.
2503 2007-06-02 Armin Burgmeier <armin@openismus.com>
2505 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2506 and assigned max width chars so that they wrap instead of being
2507 truncated. Fixes projects.maemo.org bug NB#56126.
2509 2007-06-02 Armin Burgmeier <armin@openismus.com>
2511 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2512 introductory note to the connection specific smtp servers dialog, as
2513 section 8.12 of the email UI specification requires. This fixes
2514 projects.maemo.org bug NB#59212.
2516 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2518 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2519 Check for running mail operations, and offer to cancel them, as per the UI
2520 spec. This fixes projects.maemo.org bug NB#59041 .
2521 However, I suspect that tinymail may still use the network connection
2522 in ways that we cannot detect or cancel. But it should at least adapt to
2523 changes fairly well.
2525 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2527 * src/modest-tny-account-store.c: (recreate_all_accounts),
2528 (get_cached_accounts), (get_server_accounts): Do more sensible
2529 ref-counting of the temporarily-cached outbox accounts list. This seems
2530 to fix a crash when entering the password when the password was wrong.
2532 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2534 * src/gnome/modest-main-window.c: (connect_signals):
2535 * src/modest-tny-account-store.c: (get_password),
2536 (modest_tny_account_store_alert): Added comments and clues and
2537 commented-out code about how we currently fail to deal with connection
2538 errors and wrong passwords, and how we should.
2540 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2542 * src/widgets/modest-retrieve-combo-box.c:
2543 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2544 This fixes projects.maemo.org bug NB#58472 .
2546 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2548 * src/maemo/easysetup/modest-easysetup-wizard.c:
2549 (create_page_complete_easysetup):
2550 (create_page_complete_custom): Correct the last commit,
2551 putting the correct sentences in the correct pages.
2553 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2555 * src/maemo/easysetup/modest-easysetup-wizard.c:
2556 (create_page_complete_custom): Show the second sentence of text
2557 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2560 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2562 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2563 Set the leave-on-server conf key by default. This fixes
2564 projects.maemo.org bug NB#59258 .
2566 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2568 * src/maemo/modest-account-view-window.c:
2569 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2570 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2573 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2575 * src/maemo/easysetup/modest-easysetup-wizard.c:
2576 (create_caption_new_with_asterisk):
2577 * src/maemo/modest-account-settings-dialog.c:
2578 (create_caption_new_with_asterisk):
2579 Uncomment the code to add the asterisk, because they are no longer in the
2580 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2581 (update_incoming_server_title): Add an asterisk here too.
2583 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2585 * src/maemo/modest-maemo-global-settings-dialog.c:
2586 (current_connection): Check that we are even connected before trying to
2587 get the current connection name, to prevent a warning.
2589 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2590 Change the comments because tny_maemo_conic_device_connect() is now meant to
2592 * src/modest-mail-operation.c:
2593 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2594 make sure we have a connection and fail if we can't connect.
2596 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2598 * src/maemo/modest-main-window.c:
2599 (on_account_store_connecting_finished): Do not try to get the
2600 connection ID if we are not really connected. I am surprised that
2601 this signal handler is called when we are not connected.
2603 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2605 * src/modest-error.h:
2606 * src/modest-ui-actions.c:
2607 (modest_ui_actions_get_msgs_full_error_handler):
2608 Renamed an enum, added comments, added an enum
2609 for retrieve-limit errors.
2611 * src/modest-mail-operation.c: (foreach_add_item),
2612 (internal_folder_observer_update), (update_account_thread),
2613 (modest_mail_operation_get_msgs_full):
2614 (modest_mail_operation_update_account),
2615 Added comments about how this works, and some code that should
2616 (but does not) check the retrieve-limit. See the TODO comment.
2618 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2620 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2621 Initialize help_id to fix the build. Warnings are good.
2623 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2625 * src/widgets/modest-hbox-cell-renderer.c:
2626 (modest_hbox_cell_renderer_append):
2627 * src/widgets/modest-vbox-cell-renderer.c:
2628 (modest_vbox_cell_renderer_append):
2629 Fix the last commit by doing an extra ref.
2631 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2633 * src/widgets/modest-hbox-cell-renderer.c:
2634 (modest_hbox_cell_renderer_append):
2635 * src/widgets/modest-vbox-cell-renderer.c:
2636 (modest_vbox_cell_renderer_append):
2637 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2638 to fix the build with Maemo Bora.
2639 However, there seems to be a remaining crash, probably due to reference
2642 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2644 * src/modest-tny-account.c:
2645 (modest_tny_account_new_for_local_folders):
2646 Use hildon_file_system_info_async_new() to get a better name for
2647 the memory card account, setting it as the account name.
2648 The timing seems to work, but this is probably
2649 not the best place to do this. See the TODO comment.
2650 * src/maemo/modest-main-window.c: (create_details_widget):
2651 * src/widgets/modest-folder-view.c: (text_cell_data):
2652 Use the tny account name instead of hardcoding a name.
2654 2007-05-30 Christian Kellner <ckellner@openismus.com>
2656 * src/modest-search.c: (modest_search):
2657 Correctly set part_search_func even if we have already parsed
2658 the query and thus a valid OgsTextSearcher object.
2660 2007-05-30 Christian Kellner <ckellner@openismus.com>
2663 Search and check for libogs.
2666 Incooparte the ogs build env.
2668 * src/modest-mime-part-search-stream.c:
2669 * src/modest-mime-part-search-stream.h:
2670 Removed since we do the real searching now in modest-search.c.
2672 * src/modest-search.c:
2673 * src/modest-search.h:
2674 Implement support for ogs. We use that if available and requested
2675 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2676 should now handle the corner case when the search term is spread
2677 across multiple reads.
2678 Also the logic in modest_search () was corrected to search all
2679 requested fields until one is found.
2681 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2683 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2685 * src/modest-init.h:
2686 * src/modest-init.c: Made modest_init_local_folders() take a
2687 path and be public so we can iniitialize maildir folders on
2690 * src/modest-local-folder-info.h:
2691 * src/modest-local-folder-info.c:
2692 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2694 * src/modest-tny-account.c:
2695 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2696 still means the standard local-folders path on the local volume.
2698 * src/modest-tny-account-store.c:
2699 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2700 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2701 all accounts when that happens.
2702 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2703 this too, so it shows up in the treeview.
2705 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2707 * src/maemo/modest-maemo-global-settings-dialog.c:
2708 (current_connection):
2709 * src/widgets/modest-global-settings-dialog.c:
2710 (current_connection_default):
2711 Use the enum values instead of 0, 1 and -1,
2712 to make the code clearer.
2714 * src/modest-account-mgr-helpers.c:
2715 (modest_account_mgr_get_connection_specific_smtp): Make this code
2718 * src/modest-runtime.h:
2719 * src/modest-runtime.c:
2720 Added modest_runtime_remove_all_send_queues().
2721 * src/maemo/modest-main-window.c:
2722 (on_account_store_connecting_finished): Recreate the send queues,
2723 using the appropriate transport accounts for this new connection.
2724 Some futher adapting might be needed if the old send queues are not
2725 automatically stopped at this point.
2727 * src/modest-tny-account-store.c: (get_server_accounts):
2728 Create the connection-specific transport accounts, so that they can
2729 be found later by their ID.
2731 * src/modest-tny-account.h:
2732 * src/modest-tny-account.c:
2733 Added modest_tny_account_new_from_server_account_name().
2734 modest_tny_account_new_from_server_account(): Do not create the
2735 send queues here, because they will be
2736 recreated anyway when the connection changes for the first time.
2738 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2740 * src/modest-local-folder-info.h:
2741 * src/modest-local-folder-info.c:
2742 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2743 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2744 tbox_folder): Take a modest account name instead of a server TnyAccount,
2745 so we can have per-modest-account rather than per-transport-account
2747 We must make sure that we change or recreate the exisitng send queues
2748 when the connection changes for connection-specific transport accounts.
2750 * src/modest-tny-account-store.c:
2751 (create_per_account_local_outbox_folders): Create outboxed per modest
2752 account, not per transport account.
2754 * src/modest-tny-account.h:
2755 * src/modest-tny-account.c:
2756 (modest_tny_account_get_special_folder): For outboxes, get the
2757 parent modest account name. The account is ignored for other folders.
2758 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2759 modest account name rather than a server TnyAccount.
2761 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2763 * src/modest-tny-account.c:
2764 (modest_tny_account_new_from_server_account):
2765 Call modest_runtime_get_send_queue() immediately after creating transport
2766 accounts, so that they start trying to send email from the outbox as soon
2767 as possible at startup. This is probably what we want.
2769 * src/modest-mail-operation.c: (update_account_thread):
2770 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2771 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2772 * src/modest-tny-send-queue.h:
2773 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2774 (modest_ui_actions_on_send):
2775 Added comments about how sending works, though it needs some more work.
2777 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2779 * src/modest-tny-account.c:
2780 (modest_tny_account_get_special_folder): Add TODO because this fails when
2781 the network is busy.
2782 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2783 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2784 Do not try to show this window when there is no active account. The UI
2785 specs does not tell us what to do in this case.
2787 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2791 * src/maemo/Makefile.am:
2792 * src/widgets/Makefile.am: Some dist fixes.
2794 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2796 * src/maemo/modest-connection-specific-smtp-window.c:
2797 (on_button_edit): Make the code clearer, to prevent a double free.
2799 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2801 * src/maemo/modest-account-settings-dialog.c:
2802 (modest_account_settings_dialog_set_account_name),
2803 Check the connection-specific smtp servers checkbox if there are any.
2805 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2806 (modest_connection_specific_smtp_edit_window_init):
2807 Start with a suitable port number.
2809 * src/modest-account-mgr-helpers.h:
2810 * src/modest-account-mgr-helpers.c: Added
2811 modest_account_mgr_get_has_connection_specific_smtp().
2813 (modest_account_mgr_set_connection_specific_smtp),
2814 (modest_account_mgr_remove_connection_specific_smtp),
2815 (modest_account_mgr_get_has_connection_specific_smtp),
2816 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2817 connection-specific smtp server accounts in the account, rather than
2818 the server account conf dir.
2820 This fixes bug projects.maemo.org bug NB#58263 .
2822 * src/modest-tny-account-store.c:
2823 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2824 if there are no server accounts yet, to prevent an infinite loop when there
2825 are no accounts. Document that one must be called before the other.
2827 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2829 * src/modest-account-mgr-helpers.c:
2830 (modest_account_mgr_get_default_account): Make sure that at least
2831 one account is always the default, if there are any enabled accounts.
2832 This is just a sanity check that shouldn't be necessary.
2834 * src/modest-account-mgr-priv.c:
2835 (_modest_account_mgr_account_from_key): Unescape the conf key to
2836 get the real account name. For instance, this is an issue if a space
2837 was in the account name, which can happen because the account name
2838 is generated from the display name.
2839 (_modest_account_mgr_get_account_keyname): Always escape the
2841 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2842 Unescape the conf keys to get the real account names.
2844 For instance, previously the is-default radio button in the accounts
2845 list was not checked for any accounts at first. This fixes that,
2846 and might fix several similar bugs.
2848 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2850 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2851 Removed some debug printfs.
2853 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2855 Modest on-disk outbox directories are now here, for instance:
2856 $HOME/.modest/outboxes/<account-id-1>/outbox
2857 $HOME/.modest/outboxes/<account-id-2>/outbox
2859 $HOME/.modest/local-folders/outbox
2860 so we can have a separate outbox for each account.
2861 But they are shown as one outbox in the GtkTreeView, by using a
2862 TnyMergeFolder in a ModestTnySimpleFolderStore.
2865 * src/modest-tny-simple-folder-store.c:
2866 * src/modest-tny-simple-folder-store.h:
2867 Added ModestTnySimpleFolderStore, used to contain folders from
2868 other folder stores, such as other accounts.
2870 * src/modest-tny-outbox-account.h:
2871 * src/modest-tny-outbox-account.c:
2872 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2873 used for the per-account local outbox folders.
2875 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2876 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2877 only use this (internally) now for the non-outbox local folders.
2879 * src/modest-init.h:
2880 * src/modest-init.c: Added modest_init_one_local_folder(), for
2881 setting up the directory structure for each local folder.
2883 * src/modest-local-folder-info.c:
2884 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2885 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2887 * src/modest-local-folder-info.h:
2888 * src/modest-tny-account-store.c: (on_account_removed),
2889 (on_account_changed), (create_per_account_local_outbox_folders),
2890 (get_server_accounts), (modest_tny_account_store_get_accounts),
2891 (modest_tny_account_store_get_tny_account_by_account),
2892 (modest_tny_folder_store_is_virtual_local_folders):
2894 * src/modest-tny-account.h:
2895 * src/modest-tny-account.c:
2896 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2897 to create an on-disk per-account local outbox folder for each
2899 (create_per_account_local_outbox_folders): Create a local outbox folder
2900 for each transport account.
2901 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2902 for all local folders.
2904 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2905 instead of using g_object_get/set() directly. It is clearer.
2907 (modest_tny_folder_store_get_message_count),
2908 (modest_tny_folder_store_get_local_size
2909 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2910 because we now use these with non-acount folder stores.
2912 (modest_tny_account_get_special_folder),
2913 (modest_tny_account_new_from_server_account),
2914 (modest_tny_account_new_from_account):
2915 (recurse_folders): Adjust to the new outbox system.
2917 * src/modest-tny-folder.h:
2918 * src/modest-tny-folder.c:
2919 (modest_tny_folder_is_local_folder),
2920 (modest_tny_folder_get_local_folder_type),
2921 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2923 * src/widgets/modest-main-window.h:
2924 * src/maemo/modest-main-window.c: (create_details_widget),
2925 (modest_main_window_set_contents_style): Show details for any folder store,
2928 (modest_tny_folder_get_rules):
2929 Remove the const. C does not support constness enough for this.
2931 * src/modest-ui-actions.c:
2932 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2933 make all outboxes appear as one, in the usual local-folders tree node.
2935 (set_active_account_from_tny_account),
2936 (modest_ui_actions_on_folder_selection_changed):
2937 * src/widgets/modest-folder-view.c: (text_cell_data),
2938 (icon_cell_data), (filter_row),
2939 (add_account_folders_to_merged_folder),
2940 (add_account_folders_to_simple_folder_store), (),
2941 (get_cmp_rows_type_pos), (cmp_rows),
2942 (modest_folder_view_set_account_id_of_visible_server_account):
2943 Adjust to the new outbox system, using generic folder stores and folders
2944 in the GtkTreeModel.
2946 2007-05-23 Christian Kellner <ckellner@openismus.com>
2948 * src/modest-mail-operation.c:
2949 (modest_mail_operation_update_account):
2950 Use info->max_size instead of unintialized local var [small
2951 build fix]. (Added TODO to review that change since I don't
2954 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2956 * libmodest-dbus-client/libmodest-dbus-client.c:
2957 (libmodest_dbus_client_compose_mail): function added
2958 * src/dbus_api/modest-dbus-api.h:
2959 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2960 (on_compose_mail): Implementation of the SendAsMail functionality
2962 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2964 * src/modest-account-mgr.c:
2965 (modest_account_mgr_add_server_account): Set the secure-connection
2966 conf key for transport accounts as well as store accounts. I don't know
2967 why the if was there. For instance, this makes sure that we use SSL
2968 for the gmail preset from the easysetup wizard.
2970 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2972 * src/gnome/modest-main-window.c:
2973 (on_account_store_connecting_finished), (connect_signals):
2974 * src/maemo/modest-main-window.c:
2975 (on_account_store_connecting_finished), (connect_signals),
2976 (modest_main_window_new):
2977 Handle TnyAccountStore::connecting-finished instead of
2978 TnyDevice::connection-changed, because we cannot actually perform
2979 operations on accounts until TnyAccountStore has itself responded to
2980 the TnyDevice::connection-changed signal. This prevents a GError from
2982 Do not try to update at startup, because we (at least on scratchbox)
2983 already do an update at startup when the device goes online.
2984 This prevents a GError from tinymail.
2985 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2986 Added TODO about stopping simultaneous operations.
2988 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2990 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2991 * src/modest-mail-operation-queue.c:
2992 (modest_mail_operation_queue_remove):
2993 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2994 about where they happened.
2996 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2998 * src/modest-ui-actions.c:
2999 (modest_ui_actions_on_password_requested): Make sure that the remember
3000 output parameter is always TRUE.
3002 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3004 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3005 Show a OK/Cancel dialog if the error is a question, though we still do not
3006 know anything more about what we are asking the user.
3007 * src/widgets/modest-folder-view.c: (on_drag_data_received):
3008 Fix an uninitialized variable (helper). This is a logic error, however.
3010 2007-05-21 Christian Kellner <ckellner@openismus.com>
3012 * src/modest-search.h:
3013 Correct bit shifting in the ModestSearchFlags enum.
3015 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3017 * src/modest-tny-account.c:
3018 (modest_tny_account_new_from_server_account): Do not use the lsub and
3019 check-all hard-coded IMAP options when using POP.
3021 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3023 * src/modest-tny-account.c:
3024 (modest_tny_account_new_from_server_account):
3025 Use NULL for the secure-auth method for POP when Password auth has been
3026 specified by the user, as we already do for IMAP. "auth=Login" causes
3027 an error from camel or the server.
3029 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3031 * src/maemo/modest-account-settings-dialog.c:
3032 (create_page_account_details),
3033 (modest_account_settings_dialog_set_account_name):
3034 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
3035 for the leave-on-server checkbox, rathr than just the checkbox, when
3036 the protocol is not POP.
3038 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3040 * src/widgets/modest-account-view.c:
3041 * src/widgets/modest-account-view.h:
3042 Added modest_account_view_select_account() which will be useful later
3043 to asynchronously re-select the edited account.
3045 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3047 * src/maemo/modest-account-settings-dialog.c:
3048 (modest_account_settings_dialog_set_account_name):
3049 Automatically choose the port numbers based on the secure authentication
3050 methods, if they have not been chosen before.
3051 This fixes projects.maemo.org bug NB#56273 .
3053 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3055 * src/maemo/modest-main-window-ui.h:
3056 * src/modest-ui-actions.c:
3057 * src/modest-ui-actions.h:
3058 Connect the Tools/SMTP Servers menu item to
3059 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
3060 SMTP servers dialog, as in the UI specification and saves changes when it
3061 is closed. This fixed projects.maemo.org bug NB#56305 .
3063 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3065 * src/maemo/modest-connection-specific-smtp-window.c:
3066 (modest_connection_specific_smtp_window_init):
3067 Use gtk_window_set_default_size() to make this window big enough, so
3068 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
3070 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3072 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3073 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3074 (modest_connection_specific_smtp_edit_window_init),
3075 Do not try to connect to a combobox signal before the combobox exists.
3076 This fixes the cras in projects.maemo.org bug NB#56288 .
3077 (modest_connection_specific_smtp_edit_window_get_settings):
3078 Remove the server_account_name parameter which was being checked for NULL
3079 though it was not used.
3081 * src/maemo/modest-connection-specific-smtp-window.c:
3082 (modest_connection_specific_smtp_window_fill_with_connections),
3083 (on_button_edit), (modest_connection_specific_smtp_window_init):
3084 Correct the number of treemodel columns to prevent a warning.
3085 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
3086 libconic does not work.
3088 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3090 * src/modest-tny-account.c:
3091 (modest_tny_account_new_from_server_account):
3092 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
3093 SMTP when "None" was chosen by the user. However, with my SMTP server that
3094 does not support ANONYMOUS, the emails do not leave the Outbox and I see
3097 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3099 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
3100 to explain the memory management issue with the ID in the ModestPair.
3102 * src/gnome/modest-account-assistant.c: (add_receiving_page),
3103 (add_sending_page), (modest_account_assistant_finalize):
3104 * src/gnome/modest-gnome-global-settings-dialog.c:
3105 (create_updating_page), (create_composing_page):
3106 * src/gnome/modest-msg-edit-window.c: (get_transports),
3107 (init_window), (modest_msg_edit_window_finalize),
3108 (modest_msg_edit_window_get_msg_data):
3109 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
3110 * src/gnome/modest-transport-widget.c:
3111 (modest_transport_widget_finalize), (smtp_configuration):
3112 * src/maemo/modest-maemo-global-settings-dialog.c:
3113 (create_updating_page), (create_composing_page):
3114 * src/maemo/modest-msg-edit-window.c: (get_transports),
3115 (init_window), (modest_msg_edit_window_finalize),
3116 (modest_msg_edit_window_get_msg_data),
3117 (modest_msg_edit_window_free_msg_data):
3118 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
3119 (modest_store_widget_finalize):
3120 * src/maemo/modest-transport-widget.c:
3121 (modest_transport_widget_finalize), (smtp_configuration):
3122 * src/modest-main.c: (send_mail):
3123 * src/widgets/modest-combo-box.h:
3124 * src/widgets/modest-global-settings-dialog-priv.h:
3125 * src/widgets/modest-global-settings-dialog.c:
3126 (modest_global_settings_dialog_finalize):
3127 * src/widgets/modest-msg-edit-window.h:
3128 Whenever using modest_combo_box_new(), keep the ModestPairList alive
3129 as long as the combo box, to prevent use of freed memory for the ID.
3131 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3133 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
3134 get_accounts(), to make this clearer. Do not check for the enabled gconf
3135 key, because we do not use this for server accounts (at least, not yet).
3136 This allows us to send email again.
3138 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3140 * src/maemo/modest-platform.c:
3141 (on_modest_conf_update_interval_changed), (modest_platform_init):
3142 Only respond to this particular key change. All these strcmp()s cannot be
3145 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3147 * src/maemo/modest-maemo-global-settings-dialog.c:
3148 (current_connection): Prevent a crash in scratchbox when
3149 ny_maemo_conic_device_get_current_iap_id() returns NULL.
3150 * src/maemo/modest-platform.c:
3151 (on_modest_conf_update_interval_changed), (modest_platform_init):
3152 Get the update interval from gconf and reset it when the gconf key changes.
3154 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3156 * src/modest-protocol-info.c:
3157 * src/modest-protocol-info.h: Adde enum-specific get functions,
3158 instead of using a ModestProtocolType enum parameter.
3160 * src/gnome/modest-account-assistant.c:
3161 * src/gnome/modest-store-widget.c:
3162 * src/gnome/modest-store-widget.h:
3163 * src/gnome/modest-transport-widget.c:
3164 * src/gnome/modest-transport-widget.h:
3165 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
3166 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
3167 * src/maemo/easysetup/modest-easysetup-wizard.c:
3168 * src/maemo/modest-account-settings-dialog.c:
3169 * src/maemo/modest-account-settings-dialog.h:
3170 * src/maemo/modest-store-widget.c:
3171 * src/maemo/modest-store-widget.h:
3172 * src/maemo/modest-transport-widget.c:
3173 * src/maemo/modest-transport-widget.h:
3174 * src/modest-account-mgr-helpers.c:
3175 * src/modest-account-mgr-helpers.h:
3176 * src/modest-account-mgr.c:
3177 * src/modest-account-mgr.h:
3178 * src/modest-tny-account.c:
3179 * src/modest-tny-folder.c:
3180 * src/widgets/modest-account-view.c:
3181 * src/widgets/modest-retrieve-combo-box.c:
3182 * src/widgets/modest-retrieve-combo-box.h:
3183 * src/widgets/modest-secureauth-combo-box.c:
3184 * src/widgets/modest-serversecurity-combo-box.c:
3185 * src/widgets/modest-serversecurity-combo-box.h:
3186 * tests/check_account-mgr.c:
3187 Use the specific functions, and use the re-renamed enum values for GNOME too.
3189 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3191 * src/modest-pair.h:
3192 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
3193 so we can get the second based on the first.
3195 * src/maemo/modest-account-settings-dialog.h:
3196 * src/maemo/modest-account-settings-dialog.c:
3197 Added get_supported_secure_authentication_methods(), though it is mostly
3198 commented-out for now until the necessary API is committed to tinymail.
3199 (modest_account_settings_dialog_set_account_name),
3200 (save_configuration): Request the supported authentication methods from the
3201 server, so we can choose a working method.
3203 * src/modest-tny-account-store.h:
3204 * src/modest-tny-account-store.c:
3205 (modest_tny_account_store_get_session): Rename from
3206 tny_account_store_get_session().
3208 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3210 * src/modest-protocol-info.h: Split the ModestProtocol enum
3211 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
3212 There was no need to have these unrelated values in one enum.
3214 * src/: many files: Adapted to changed enum. This makes the code a bit
3215 clearer, and the compiler could catch some errors.
3217 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3219 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3220 Show the detailed internal camel error message when an error happens
3221 during the configuration, so that our testers can give us more clues.
3222 For instance, in projects.maemo.org bug NB#56910 .
3224 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3226 * src/modest-tny-account.c:
3227 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
3228 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
3230 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3232 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3233 * src/maemo/modest-account-settings-dialog.c:
3234 (modest_account_settings_dialog_set_account_name),
3235 (save_configuration): For the incoming secure authentication checkbox,
3236 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
3237 the UI specification. PLAIN does not seem to be supported for most IMAP
3238 servers anyway, and I am not sure what it would mean.
3239 However, we probably need to discover which of the secure-authentication
3240 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
3241 * src/modest-account-mgr-helpers.c:
3242 (modest_account_mgr_get_server_account_data):
3244 * src/modest-tny-account.c:
3245 (modest_tny_account_new_from_server_account):
3246 Use tny_account_set_mech() to set secure-authentication methods,
3247 with some special-casing for IMAP, based on my observations of how
3250 * src/modest-account-mgr-helpers.h:
3251 * src/modest-account-mgr.c:
3252 * src/modest-defs.h: Comment that the URI is only used for local folders.
3254 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3256 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
3257 parameter const, just to be neat.
3258 * src/modest-text-utils.c: (modest_text_utils_inline):
3259 End g_strconcat() with NULL, as its documentation says. This is almost
3260 certainly the cause of my crash at startup on the device. Interestingly,
3261 valgrind doesn't tell us about these errors.
3263 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3265 * scripts/build-packages: Added more precise comments about how to use
3266 this script, though I still get this error:
3267 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
3268 error building tinymail
3270 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3272 * src/maemo/modest-main-window.c: (on_account_update):
3273 Very slight cleanup, hoping to make it simpler to discover what causes
3274 a crash here sometimes.
3276 * src/modest-tny-account.c:
3277 (modest_tny_account_new_from_server_account): Set the port. Added
3278 comments about the options and a TODO comment because I need to find out
3279 how to specify the secure authentication method.
3281 2007-05-11 Marcus Bauer <marcusb@openismus.com>
3283 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3284 changed CFlags paths form modest to libmodest
3286 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3288 * src/modest-account-mgr-helpers.c:
3289 (modest_account_mgr_get_server_account_data),
3290 (modest_account_mgr_free_server_account_data):
3291 * src/modest-account-mgr-helpers.h:
3292 * src/modest-account-mgr.c:
3293 (modest_account_mgr_add_server_account):
3294 * src/modest-defs.h:
3295 * src/modest-tny-account.c:
3296 (modest_tny_account_new_from_server_account):
3297 Determine the options for tny_camel_account_add_option() here,
3298 based on the settings, rather than storing them directly in gconf.
3300 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3302 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3303 Show a more friendly error dialog now that we expect (from the tinymail
3304 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3306 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3308 * src/maemo/modest-main-window.c: (on_account_update): Check that
3309 account_name is not NULL, to prevent a crash at startup that I am
3310 seeing on the N800. I do wonder why it is NULL.
3312 * src/maemo/easysetup/modest-easysetup-wizard.c:
3313 (create_page_user_details):
3314 * src/maemo/modest-account-settings-dialog.c:
3315 (create_page_user_details), (create_page_outgoing):
3316 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3317 (modest_connection_specific_smtp_edit_window_init):
3318 * src/modest-ui-actions.c:
3319 (modest_ui_actions_on_password_requested):
3320 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3321 might do something useful with the on-screen keyboard.
3323 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3325 * src/maemo/modest-main-window.c: (on_account_update):
3326 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3327 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3329 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3331 * src/modest-tny-account-store.c: (on_account_changed):
3332 Correct the signature of this signal handler.
3334 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3336 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3337 Show a HildonNote instead of a GtkDialog for Maemo.
3339 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3341 * src/widgets/modest-account-view.h:
3342 * src/widgets/modest-account-view.c: (on_account_changed),
3343 (on_account_removed). Added a boolean flag, set/unset by
3344 modest_account_view_block_conf_updates(),
3345 modest_account_view_unblock_conf_updates() to prevent unnecessary
3346 updates, but this is not very useful because the gconf notifications are
3347 so delays (maybe only on Maemo Bora).
3348 So auto-updating is turned off, and these functions do an explicit
3349 update when necessary.
3350 However, something else is still doing too much work when adding/removing
3351 accounts, probably in another part of the application.
3353 * src/maemo/modest-account-view-window.c:
3354 (on_delete_button_clicked), (on_edit_button_clicked),
3355 (on_new_button_clicked): Use the new functions.
3357 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3359 * src/modest-account-mgr-helpers.c:
3360 (modest_account_mgr_set_first_account_as_default):
3361 Sort the list of names alphabetically-by-title, so we choose the first one
3363 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3364 alphabetically by the title.
3366 This fixes projects.maemo.org bug NB#56418 .
3368 * src/modest-account-mgr-priv.c:
3369 (_modest_account_mgr_account_from_key):
3370 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3371 avoid a valgrind error, and possible random behaviour.
3373 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3375 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3376 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3377 tinymail documentation to say that this can be expected.
3378 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3379 pretty, and should not happen, but I would prefer to know when it does.
3381 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3383 * configure.ac: When using the older hildon version, probably on Bora,
3384 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3386 * src/widgets/modest-attachment-view.c:
3387 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3390 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3392 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3393 Implemented the prototype. Can be tested with
3394 tests/dbus_api/test_open_message:
3396 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3398 * src/modest-tny-account-store.c:
3399 (modest_tny_account_store_instance_init), (get_password):
3400 * src/modest-ui-actions.c:
3401 (modest_ui_actions_on_password_requested):
3402 Do not store the password in gconf, because this function is called
3403 for non-remembered passwords. Actually use the cached (in the hash map)
3404 password instead of releasing it.
3405 The password will now not be remembered if it is asked via the protected
3406 password dialog, as per the UI spec.
3408 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3410 * src/modest-defs.h:
3411 * src/modest-account-mgr-helpers.h:
3412 * src/modest-account-mgr-helpers.c:
3413 Added modest_server_account_get_username_has_succeeded(),
3414 modest_server_account_set_username_has_succeeded().
3415 (modest_server_account_set_username),
3416 Reset the has-succeeded flag if the username changes.
3418 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3419 * src/maemo/modest-connection-specific-smtp-window.c:
3420 (modest_connection_specific_smtp_window_save_server_accounts):
3421 Use modest_server_account_set_username() instead of using
3422 modest_conf_set_string() directly, so that the has-succeeded flag is always
3425 * src/modest-ui-actions.c:
3426 (modest_ui_actions_on_password_requested): Dim the username entry if
3427 the username has ever worked, as per the UI spec.
3429 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3431 * src/modest-tny-account-store.c: (get_password):
3432 * src/modest-ui-actions.c:
3433 (modest_ui_actions_on_password_requested):
3434 Allow the username to be changed too, though there is more work to
3435 be done on exactly how this behaves.
3437 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3439 * src/modest-account-mgr-helpers.h:
3440 * src/modest-account-mgr-helpers.c:
3441 Added modest_account_mgr_get_display_name(),
3442 modest_server_account_get_username(),
3443 modest_server_account_set_username(),
3444 modest_server_account_set_password(),
3445 modest_server_account_get_hostname() functions so we do not need to
3446 use the conf API directly.
3448 * src/maemo/modest-main-window.c: (connect_signals):
3449 Actually connect ot the ModestAccountStore::request-password signal,
3450 so that we show the dialog when the password is requested by Tinymail,
3451 for isntance if it is empty.
3453 * src/modest-marshal.list:
3454 * src/modest-tny-account-store.c:
3455 (modest_tny_account_store_class_init), (get_password),
3456 (modest_tny_account_store_alert):
3457 * src/modest-tny-account-store.h:
3458 * src/modest-ui-actions.h:
3459 * src/modest-ui-actions.c:
3460 (modest_ui_actions_on_password_requested):
3461 Change the signal parameters, so it is obvious that we are providing
3462 the non human-readable server name, and receiving both the username
3463 and password, though changing of the username is not yet implemented.
3464 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3465 for the GNOME version.
3467 This should fix the projects.maemo.org bug NB#56209, though it does not
3468 work on Bora, because the gconf_client_get() for the password fails
3469 immediately after we save it with gconf_client_set().
3471 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3474 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3475 caused an undefined symbol error:
3476 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3478 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3480 * src/modest-tny-account-store.c:
3481 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3482 using a GError instead of a string message, so we can translate it in
3485 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3487 * src/maemo/modest-address-book.c:
3488 (modest_address_book_check_names):
3489 * src/maemo/modest-msg-view-window.c:
3490 (modest_msg_view_window_clipboard_owner_change):
3491 * src/modest-init.c: (modest_init_init_ui):
3492 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3493 (update_folders_cb), (modest_mail_operation_update_account):
3494 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3495 (modest_ui_actions_on_msg_attachment_clicked),
3496 (modest_ui_actions_on_msg_recpt_activated):
3497 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3498 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3499 (modest_msg_view_search_next):
3500 * src/widgets/modest-recpt-editor.c:
3501 (modest_recpt_editor_on_button_release_event),
3502 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3503 g_message(). At this point we should only be seeing interesting errors on
3504 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3506 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3508 (modest_wizard_dialog_force_title_update):
3509 * src/maemo/easysetup/modest-wizard-dialog.h:
3510 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3511 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3512 can update the title when appropriate. Otherwise the title is wrong if the
3513 pages are added after adding the notebook to the dialog.
3514 This must be a problem in HildonWizardDialog too.
3515 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3517 * src/maemo/easysetup/modest-easysetup-wizard.c:
3518 (create_subsequent_customsetup_pages),
3519 (create_subsequent_easysetup_pages):
3520 Call modest_wizard_dialog_force_title_update() so that the title is
3521 correct even with GTK+ < 2.10.
3522 This fixes projects.maemo.org bug NB#56145 .
3524 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3526 * src/maemo/modest-platform.c:
3527 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3528 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3531 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3533 * src/widgets/modest-window.h:
3534 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3535 and modest_window_save_state(), which invokes it.
3537 * src/widgets/modest-window-mgr.h:
3538 * src/widgets/modest-window-mgr.c:
3539 Added modest_window_mgr_save_state_for_all_windows(), which calls
3540 the save_state vfunc on all registered windows, if implemented.
3542 * src/gnome/modest-msg-edit-window.c:
3543 * src/gnome/modest-msg-view-window.c:
3544 * src/maemo/modest-msg-edit-window.c:
3545 * src/maemo/modest-msg-view-window.c:
3546 * src/maemo/modest-main-window.c:
3547 Specify the existing save_settings functions as implementations of
3548 ModestWindow::save_state_func().
3550 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3551 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3552 enabling hibernation, for instance.
3554 We may need to do the same thing for restoring settings.
3557 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3559 * src/widgets/modest-window-mgr.c:
3560 * src/widgets/modest-window-mgr.h:
3561 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3562 modest_window_mgr_get_hibernation_is_prevented().
3564 * src/maemo/modest-main-window.c:
3565 (on_hildon_program_is_topmost_notify): Prevent hibernation
3566 (possible when the application goes to the background in the WM),
3567 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3569 * src/maemo/easysetup/modest-easysetup-wizard.c:
3570 (modest_easysetup_wizard_dialog_init):
3571 * src/maemo/modest-account-settings-dialog.c:
3572 (modest_account_settings_dialog_init):
3573 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3574 (modest_connection_specific_smtp_edit_window_init):
3575 * src/maemo/modest-connection-specific-smtp-window.c:
3576 (modest_connection_specific_smtp_window_init):
3577 * src/maemo/modest-signature-editor-dialog.c:
3578 (modest_signature_editor_dialog_init):
3579 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3580 prevent hibernation while any of these account settings dialogs are open.
3582 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3584 * src/maemo/Makefile.am:
3585 * src/maemo/modest-osso-state-saving.c:
3586 * src/maemo/modest-osso-state-saving.h: Added
3587 modest_osso_load_state() and modest_osso_save_state() though they do
3588 nothing now. They should iterate through all the open windows and load/save
3590 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3591 save state when closing.
3593 * src/maemo/modest-main-window.c:
3594 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3595 Add a notification handler for the HildonProgram::is-topmost property,
3596 so we can allow hibernation when the application goes into the background.
3597 But we still need to detect when the accounts setup windows are open so
3598 we can stop hibernation when they are open.
3599 To do this, I also added the main window the HildonProgram. This might have
3600 other side-effects/benefits, and should maybe be done for other windows.
3602 * src/maemo/modest-osso-autosave-callbacks.h:
3603 * src/maemo/modest-osso-autosave-callbacks.c:
3604 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3605 though it does not do anything yet, and we might never need this to do
3606 anything. For instance, we already save drafts.
3608 * src/maemo/modest-platform.c: (modest_platform_init):
3609 Specify the libosso auto-save callback.
3611 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3613 * src/maemo/modest-platform.c:
3614 (modest_platform_set_update_interval):
3615 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3616 aparently stays valid between application instances, so we can use this
3617 to remove and reset it later. According to a maemo-developers email from
3620 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3622 * configure.ac: Depend on libalarm for Maemo.
3624 * src/dbus_api/modest-dbus-api.h:
3625 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3626 (on_send_receive), (modest_dbus_req_handler):
3627 Handle a SEND_RECEIVE D-Bus method.
3629 * libmodest-dbus-client/libmodest-dbus-client.c:
3630 (libmodest_dbus_client_send_and_receive):
3631 * libmodest-dbus-client/libmodest-dbus-client.h:
3632 Add C convenience functions for calling the new D-Bus method.
3634 * src/modest-platform.h:
3635 * src/gnome/modest-platform.c:
3636 * src/maemo/modest-platform.c:
3637 Added modest_platform_set_update_interval(), which uses the
3638 alarmd API on Maemo.
3639 (modest_platform_init),
3640 Call modest_platform_set_update_interval(), using a hard-coded
3641 interval for now (until the global settings dialog is implemented),
3642 though I am not sure that this makes sense yet.
3644 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3646 * src/dbus_api/modest-dbus-callbacks.c:
3647 (modest_osso_cb_hw_state_handler):
3648 * src/dbus_api/modest-dbus-callbacks.h:
3649 * src/maemo/modest-platform.c: (modest_platform_init):
3650 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3651 in case this has some effect on the ability for Maemo to ping the
3654 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3656 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3657 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3658 warning. It is probably a logic error, but I need to fix the build.
3660 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3662 * src/modest-account-mgr.h:
3663 * src/modest-account-mgr.c:
3664 (modest_account_mgr_account_names): Add a gboolean enabled_only
3665 parameter, so we can get lists of onlt the enabled accounts.
3667 (modest_account_mgr_add_account),,
3668 (modest_account_mgr_account_with_display_name_exists):
3669 * src/maemo/modest-msg-edit-window.c: (get_transports):
3670 * src/modest-account-mgr-helpers.c:
3671 (modest_account_mgr_set_first_account_as_default):
3672 * src/modest-init.c: (init_default_account_maybe):
3673 * src/modest-tny-account-store.c: (get_accounts):
3674 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3675 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3676 * tests/check_account-mgr.c: (START_TEST):
3677 Provide the extra parameter, as appropriate.
3679 * src/widgets/modest-account-view.c: (update_account_view):
3680 Do not show disabled accounts (meaning that there is no way to
3681 enable/disable accounts in the UI (the feature is not in our UI
3682 specification), so we can use this internally only to mark unfinished
3683 or temporary account data.
3685 * src/maemo/easysetup/modest-easysetup-wizard.c:
3686 (create_account): Add boolean enable parameter, so we can specify FALSE
3687 to create the temporary account.
3688 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3689 (on_before_next): When finishing, when there is a temporary account, just
3691 Also, use a timeout to delay the showing of the dialog until gconf is likely
3692 to return correct information, due to a maemo gconf bug that is fixed in
3693 osso 1.1, but not yet in Bora.
3694 However, the dialog stays on screen after it is destroyed.
3696 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3697 for invalid data when cancelling. Use a hildon note instead of a dialog
3698 to complain about invalid data. Do not show the account-saved note if the
3699 account is disabled (a temporary account that will not really be saved for use
3702 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3704 * src/modest-account-mgr-helpers.h:
3705 * src/modest-account-mgr-helpers.c:
3706 Added modest_account_mgr_unset_default_account(),
3707 Added modest_account_mgr_set_first_account_as_default().
3709 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3710 If it was the default account, unset the default account name.
3712 * src/maemo/modest-account-view-window.c:
3713 (on_delete_button_clicked): If it was the default account,
3714 set the first remaining account as the default instead.
3716 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3717 a NULL account or a NULL default account, to prevent a crash. This should
3718 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3721 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3723 * src/widgets/modest-recpt-editor.c:
3724 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3725 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3726 TODO comment for this. This fixes the build.
3728 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3729 be the best place for it. This will in future update all auto-update accounts,
3730 rather than just the current/default account, when that gconf key exists.
3731 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3732 if there are no accounts, before calling do_send_receive().
3733 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3735 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3736 * src/maemo/modest-main-window-ui.h:
3737 * src/maemo/modest-main-window.c: (on_connection_changed),
3738 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3739 directly, becaue the signal handler does more.
3741 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3743 * src/modest-account-mgr-helpers.c:
3744 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3745 for the case that the account does not exist.
3747 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3748 (equivalent to the modest account name) rather than the tinymail account name
3749 (equivalent to the modest account title - human readable) to get the account data.
3750 Check for null account data to prevent the crash, and add a TODO comment saying that
3751 this needs fixing because it is using the server account name instead of the account name.
3753 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3755 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3756 * src/maemo/modest-account-settings-dialog.c: (show_error),
3758 Use hildon_note_new_information() for informative and error messages,
3759 which seems to be expected for Maemo applications (no documentation that I know of
3760 says this). I am surprised that there is no distinction between info and error
3763 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3765 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3766 it is easy to find where this is used.
3768 * src/maemo/easysetup/modest-easysetup-wizard.c:
3769 (create_page_welcome), (create_page_account_details),
3770 (create_page_user_details), (create_page_complete_easysetup),
3771 (create_page_custom_incoming), (create_page_custom_outgoing),
3772 (create_page_complete_custom):
3773 * src/maemo/modest-account-settings-dialog.c:
3774 (create_page_account_details), (create_page_user_details),
3775 (create_page_incoming), (create_page_outgoing):
3776 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3777 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3778 (modest_connection_specific_smtp_edit_window_init):
3779 * src/maemo/modest-connection-specific-smtp-window.c:
3780 (modest_connection_specific_smtp_window_init):
3781 * src/maemo/modest-signature-editor-dialog.c:
3782 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3783 and scrolling policy as per the Email Application Layout Guide, if I have
3786 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3788 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3789 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3790 which were empty, because these vfuncs have been removed from TnyAccountStore.
3791 This fixes the build.
3793 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3795 * src/maemo/modest-main-window.c:
3796 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3797 showing/hiding it. Added TODO because it probably should not be NULL.
3798 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3799 because unnecessary g_warnings() make degugging difficult.
3801 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3803 * src/maemo/modest-msg-edit-window.c:
3804 (modest_msg_edit_window_select_color),
3805 (modest_msg_edit_window_select_background_color): 2 const corrections and
3806 moving 2 #endifs before closing brackets, to fix the build.
3808 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3810 * src/maemo/easysetup/modest-easysetup-wizard.h:
3811 * src/maemo/easysetup/modest-easysetup-wizard.c:
3812 (modest_easysetup_wizard_dialog_finalize),
3813 (on_button_edit_advanced_settings), (create_page_complete_custom),
3814 (on_response), (create_account):
3815 Implement the Advanced Settings edit button, by saving the account information,
3816 for the Advanded Settings dialog to use directly from gconf, and removing it
3817 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3818 Bug #5533 in the projects.maemo.org bugzilla.
3820 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3822 * src/maemo/modest-msg-view-window.c:
3823 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3824 when opening a message window.
3826 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3828 * src/maemo/easysetup/modest-easysetup-wizard.c:
3829 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3832 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3833 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3834 gconf settings. I probably added more checks than necessary, but that is safer.
3836 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3837 variable to fix the build, but this seems to be used when it is still NULL.
3839 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3841 * src/modest-platform.h:
3842 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3843 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3844 * src/modest-main.c: Implement this function so we can avoid using
3845 maemo-specific API from cross-platform code.
3847 * src/modest-tny-account-store.c:
3848 (get_smtp_specific_transport_account_for_open_connection):
3849 * src/modest-ui-actions.c: (check_for_connection),
3850 (modest_ui_actions_on_item_not_found):
3851 Use modest_platform_connect_and_wait() and put #idefs around other
3852 maemo-specific code, because only maemo currently has a way to
3853 identify connection names.
3855 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3857 * src/modest-tny-account-store.h:
3858 * src/modest-tny-account-store.c:
3859 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3860 the connection-specific SMTP server settings in the configuration.
3862 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3864 * src/maemo/modest-main-window.c: (on_connection_changed),
3866 * src/modest-main.c: (main), (start_ui), (send_mail):
3867 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3868 that is what is intended.
3870 * src/modest-ui-actions.c: (action_send), (action_receive),
3871 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3872 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3873 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3874 SMTP server is used when it is specified.
3876 (modest_ui_actions_on_send_receive):
3877 Check that a connection is open before proceeding.
3878 Receive and then send, instead of vice-versa, as per the specification.
3880 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3882 * src/modest-mail-operation.c:
3883 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3884 though I guess it should be something other than NULL.
3886 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3888 * src/maemo/easysetup/modest-easysetup-wizard.c:
3889 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3890 combo twice, to avoid an g_warning and to make it visible again.
3891 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3892 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3893 (already intended) dereference when detaching, because we then recreate the menu.
3894 But I am not sure why the warning was happening, and it is possible that this is a memory
3897 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3899 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3900 and uri_parse_mailto() utility functions.
3901 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3903 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3905 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3907 * src/dbus_api/modest-dbus-api.h:
3908 * src/dbus_api/modest-dbus-callbacks.c:
3909 Use an idle callback to execute the modest code in the application's own thread.
3910 Remove the helloworld example method.
3911 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3912 parsed, and the open-message method is not implemented because this is not yet implemented in
3914 * libmodest-dbus-client/libmodest-dbus-client.c:
3915 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3916 (libmodest_dbus_client_open_message):
3917 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3919 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3920 body without crashing.
3922 * tests/dbus_api/Makefile.am:
3923 * tests/dbus_api/test_mail_to.c:
3924 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3926 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3928 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3929 Added file to fix the build. Sorry.
3931 * src/dbus_api/Makefile.am:
3932 * src/dbus_api/modest-dbus-api.h:
3933 * src/dbus_api/modest-dbus-callbacks.h:
3934 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3935 (modest_dbus_req_handler):
3936 Put constants in a separate header so it can be reused by the
3937 client library, without duplication
3939 * libmodest-dbus-client/Makefile.am:
3940 * libmodest-dbus-client/libmodest-dbus-client.c:
3941 (libmodest_dbus_client_call_helloworld),
3942 (libmodfest_dbus_client_send_mail),
3943 (libmodfest_dbus_client_mailto),
3944 (libmodfest_dbus_client_open_message):
3945 * libmodest-dbus-client/libmodest-dbus-client.h:
3946 (Partly) Implement a send_mail D-Bus method.
3948 * tests/dbus_api/Makefile.am:
3949 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3950 the send_email D-Bus method.
3952 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3956 * libmodest-dbus-client/Makefile.am:
3957 * libmodest-dbus-client/libmodest-dbus-client.c:
3958 * libmodest-dbus-client/libmodest-dbus-client.h:
3959 * tests/dbus_api/Makefile.am:
3960 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3961 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3963 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3965 * src/maemo/easysetup/modest-easysetup-wizard.c:
3966 (create_page_account_details):
3967 * src/maemo/modest-account-settings-dialog.c:
3968 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3969 widgets, because this might not be the default in future versions of the Maemo GTK+.
3970 However, I can not not get capitalization to work even in a simple test case.
3972 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3974 * src/maemo/easysetup/modest-easysetup-wizard.c:
3975 (create_page_custom_incoming), (create_page_custom_outgoing):
3976 * src/maemo/modest-account-settings-dialog.c:
3977 (create_page_account_details), (create_page_incoming),
3978 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3979 instead of using gtk_check_button_with_label(), so they are aligned like the other
3980 widgets, as per the UI spec.
3982 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3984 * src/maemo/easysetup/modest-easysetup-wizard.c:
3985 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3986 * src/widgets/modest-validating-entry.c:
3987 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3988 Modest prefix instead of an EasySetup prefix.
3990 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3992 * src/widgets/modest-validating-entry.h:
3993 * src/widgets/modest-validating-entry.c: (on_insert_text),
3994 Added easysetup_validating_entry_set_max_func(), used to set a callback
3995 to call when the max number of characters is reached. GtkEntry has a max-length
3996 already but is silent about it.
3998 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3999 (create_page_account_details), (create_page_user_details),
4001 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
4002 (create_page_account_details), (create_page_user_details),
4003 (create_page_outgoing):
4004 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
4005 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
4006 the UI spec, when the user tries to enter more than the max number of characters.
4008 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4010 * src/maemo/easysetup/modest-easysetup-wizard.c:
4011 (create_page_user_details), (create_page_custom_incoming),
4012 (create_page_custom_outgoing):
4013 * src/maemo/modest-account-settings-dialog.c:
4014 (create_page_user_details), (create_page_incoming),
4015 (create_page_outgoing):
4016 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4017 (modest_connection_specific_smtp_edit_window_init):
4018 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
4019 not appropriate. Bad Maemo-specific defaults!.
4021 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4023 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
4024 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
4025 (modest_signature_editor_dialog_set_settings):
4026 Disable the label and textview when the checkbox is disabled, and use the
4027 specified (UI spec) default signature text.
4029 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4031 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4032 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
4034 * src/modest-defs.h:
4035 * src/modest-account-mgr-helpers.h:
4036 * src/modest-account-mgr-helpers.c:
4037 Added modest_account_mgr_get/set_signature(), using new gconf keys.
4039 * src/maemo/Makefile.am:
4040 * src/maemo/modest-signature-editor-dialog.c:
4041 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
4044 * src/maemo/modest-account-settings-dialog.h:
4045 * src/maemo/modest-account-settings-dialog.c:
4046 (modest_account_settings_dialog_finalize), (on_button_signature),
4047 (save_configuration): Use the new dialog when the Edit button is pressed, and
4048 save the changes if necessary, as per the UI spec.
4050 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4052 * src/maemo/Makefile.am:
4053 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
4054 based on maemo-develoers email from Dirk.
4056 * src/maemo/easysetup/modest-easysetup-wizard.c:
4057 (create_page_welcome), (create_page_account_details),
4058 (create_page_user_details), (create_page_complete_easysetup),
4059 (create_page_custom_incoming), (create_page_custom_outgoing),
4060 (create_page_complete_custom),
4061 (modest_easysetup_wizard_dialog_init):
4062 * src/maemo/modest-account-settings-dialog.c:
4063 (create_page_account_details), (create_page_user_details),
4064 (create_page_incoming), (create_page_outgoing),
4065 (modest_account_settings_dialog_init):
4066 * src/maemo/modest-connection-specific-smtp-window.c:
4067 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
4069 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4071 * src/maemo/easysetup/modest-easysetup-wizard.c:
4072 (create_page_account_details), (create_page_custom_outgoing),
4073 (create_page_complete_custom):
4074 * src/maemo/modest-account-settings-dialog.c:
4075 (create_page_user_details), (create_page_incoming),
4076 (create_page_outgoing):
4077 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4078 (modest_connection_specific_smtp_edit_window_init):
4079 Use the correct (UI spec) port min/max, and use horizontal separators,
4082 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4084 * src/maemo/easysetup/modest-easysetup-wizard.c:
4085 (set_default_custom_servernames):
4086 * src/maemo/modest-account-settings-dialog.c:
4087 (create_page_incoming), (on_combo_outgoing_security_changed),
4088 (on_combo_incoming_security_changed), (create_page_outgoing),
4089 (modest_account_settings_dialog_set_account_name),
4090 (save_configuration):
4091 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4092 (on_combo_security_changed),
4093 (modest_connection_specific_smtp_edit_window_init),
4094 (modest_connection_specific_smtp_edit_window_set_connection),
4095 (modest_connection_specific_smtp_edit_window_get_settings):
4096 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
4099 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4102 * src/maemo/easysetup/modest-easysetup-wizard.c:
4103 (create_page_custom_outgoing), (create_page_complete_custom):
4104 * src/maemo/modest-account-settings-dialog.c:
4105 (create_page_user_details), (create_page_outgoing):
4106 * src/maemo/modest-account-view-window.c: (button_box_new):
4107 Use changed logical IDs as per the most recent UI spec:
4108 mcen_bd_emailsetup_edit -> mcen_bd_edit
4109 mcen_bd_emailsetup_delete -> mcen_bd_delete
4110 mcen_bd_emailsetup_close -> mcen_bd_close
4112 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4116 * src/dbus_api/Makefile.am:
4117 * src/dbus_api/modest-dbus-callbacks.c:
4118 * src/dbus_api/modest-dbus-callbacks.h:
4119 * src/maemo/modest-platform.c: (modest_platform_init):
4120 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
4122 * tests/Makefile.am:
4123 * tests/dbus_api/Makefile.am:
4124 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
4126 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4128 * src/maemo/modest-account-settings-dialog.c:
4129 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4130 Removed unnecessary includes.
4132 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4134 * src/maemo/easysetup/modest-easysetup-wizard.c:
4135 * src/maemo/modest-account-settings-dialog.c:
4136 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4137 * src/widgets/Makefile.am:
4138 * src/widgets/modest-easysetup-secureauth-combo-box.c:
4139 * src/widgets/modest-easysetup-secureauth-combo-box.h:
4140 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
4141 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
4142 * src/widgets/modest-secureauth-combo-box.c:
4143 * src/widgets/modest-secureauth-combo-box.h:
4144 * src/widgets/modest-serversecurity-combo-box.c:
4145 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
4146 made the GObject names more consistent with the rest of the Modest code.
4148 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4150 * src/maemo/easysetup/Makefile.am:
4151 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4152 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
4153 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4154 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4155 * src/maemo/easysetup/modest-easysetup-wizard.c:
4156 * src/maemo/easysetup/modest-validating-entry.c:
4157 * src/maemo/easysetup/modest-validating-entry.h:
4158 * src/maemo/modest-account-settings-dialog.c:
4159 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4160 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
4161 widgets/ because they are used outside of easysetup too. After checking in,
4162 svn will allow me to rename them too.
4164 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4166 * src/gnome/modest-msg-edit-window.c:
4167 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
4168 linker error, to fix the build on the GNOME platform.
4169 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
4170 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
4171 ifdefed out to avoid a warning.
4173 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4175 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
4176 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
4177 some alternative for GTK+ 2.6.
4179 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4181 * src/maemo/modest-address-book.c: Added include to avoid a warning.
4183 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
4184 specified for EmailAccountsDialog in UI spec.
4186 * src/maemo/easysetup/modest-easysetup-wizard.c:
4187 * src/maemo/easysetup/modest-easysetup-wizard.h:
4188 * src/maemo/modest-account-settings-dialog.c:
4189 * src/maemo/modest-account-settings-dialog.h:
4190 Reuse a member window widget for the connection-specific SMTP server accounts,
4191 so we can tell it to create/save the accounts only if we actually save changes.
4193 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4194 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4195 (modest_connection_specific_smtp_edit_window_get_settings):
4196 Return a struct instance for temporarily remembering the entered data.
4198 * src/maemo/modest-connection-specific-smtp-window.h:
4199 * src/maemo/modest-connection-specific-smtp-window.c:
4200 (modest_connection_specific_smtp_window_finalize),
4201 (modest_connection_specific_smtp_window_fill_with_connections),
4203 (modest_connection_specific_smtp_window_save_server_accounts),
4204 (update_model_server_names): Do not actually save data until asked,
4205 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
4207 (on_selection_changed),
4208 (modest_connection_specific_smtp_window_init): Disable the edit
4209 button when nothing is selected.
4211 * src/modest-account-mgr-helpers.c:
4212 * src/modest-account-mgr-helpers.h:
4213 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
4216 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4218 * src/modest-account-mgr-helpers.h:
4219 * src/modest-account-mgr-helpers.c:
4220 (modest_account_mgr_get_unused_account_name),
4221 (modest_account_mgr_get_unused_account_display_name): Added these
4222 utility functions, to avoid code duplication.
4224 * src/maemo/easysetup/modest-easysetup-wizard.c:
4225 (create_page_account_details), (create_account):
4226 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4227 (on_combo_security_changed),
4228 (modest_connection_specific_smtp_edit_window_init),
4229 (modest_connection_specific_smtp_edit_window_save_settings):
4230 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4231 * src/maemo/modest-connection-specific-smtp-window.c:
4232 (modest_connection_specific_smtp_window_finalize),
4233 (modest_connection_specific_smtp_window_fill_with_connections),
4234 (on_button_edit), (modest_connection_specific_smtp_window_init):
4235 * src/maemo/modest-connection-specific-smtp-window.h:
4236 Implementing saving of connection-specific server accounts.
4238 But I need to refactor this so we can save the data for each
4239 possible connection-specific account and only actually create the server accounts
4240 when the easysetup finished, or the OK button is pressed on the account settings
4243 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4245 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4246 (on_combo_security_changed):
4247 (modest_connection_specific_smtp_edit_window_init):
4248 Auto-fill the port number as in the account settings.
4250 (modest_connection_specific_smtp_edit_window_set_connection):
4251 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4252 * src/maemo/modest-connection-specific-smtp-window.c:
4253 (fill_with_connections), (on_button_edit),
4254 (modest_connection_specific_smtp_window_init):
4255 Turn the edit window into a dialog to simplify the code, and
4256 set a WM hint as in a GtkDialog, because only a popup can be on top of
4257 another window in Maemo, and popups usually have no WM decoration.
4259 * src/modest-defs.h:
4260 * src/modest-account-mgr-helpers.c:
4261 (modest_account_mgr_set_connection_specific_smtp),
4262 (modest_account_mgr_remove_connection_specific_smtp),
4263 (modest_account_mgr_get_connection_specific_smtp):
4264 * src/modest-account-mgr-helpers.h: Some functions to write the
4265 connection-specific SMTP server information. Not yet used.
4268 * src/widgets/modest-folder-view.c: (text_cell_data):
4269 Fix a warning about an uninitialized variable.
4270 (on_configuration_key_changed): Put an #ifdef around the use
4271 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
4273 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4275 * src/maemo/modest-account-settings-dialog.h:
4276 * src/maemo/modest-account-settings-dialog.c:
4277 Added connect_for_modified() utility function to mark the new modified boolean.
4279 (create_page_account_details), (create_page_user_details),
4280 (create_page_incoming), (create_page_outgoing), (on_response),
4281 (modest_account_settings_dialog_init),
4282 (modest_account_settings_dialog_set_account_name):
4283 Only warn about unsaved changes when there are actually unsaved changes.
4285 * src/modest-account-mgr-helpers.c:
4286 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
4287 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
4288 to get the data from there in future.
4290 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4292 * src/modest-defs.h:
4294 * src/modest-account-mgr-helpers.h:
4295 * src/modest-account-mgr-helpers.c:
4296 Store the security account setting in a single conf key instead of using
4297 the options list, so that the list is left for just the to-be-removed camel hack,
4298 and because gconf_client_set_list() is failing for some reason.
4300 * src/modest-account-mgr.c:
4301 (modest_account_mgr_add_server_account):
4302 * src/maemo/modest-account-settings-dialog.c:
4303 (modest_account_settings_dialog_set_account_name),
4304 (save_configuration): Use the renamed functions.
4307 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4309 * src/widgets/Makefile.am:
4310 * src/widgets/modest-limit-retrieve-combo-box.c:
4311 * src/widgets/modest-limit-retrieve-combo-box.h:
4312 * src/widgets/modest-retrieve-combo-box.c:
4313 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4314 the account settings dialog.
4316 * src/modest-defs.h:
4317 * src/modest-account-mgr-helpers.h:
4318 * src/modest-account-mgr-helpers.c:
4319 (modest_server_account_get_option_secure_auth),
4320 (modest_server_account_set_option_secure_auth):
4321 * src/modest-account-mgr.c:
4322 (modest_account_mgr_add_server_account):
4323 Use the existing AUTH_MECH conf key for the secure-auth setting,
4324 instead of putting it in the list options, because this was actually used already.
4326 * src/maemo/modest-account-settings-dialog.c:
4327 (create_page_account_details),
4328 (modest_account_settings_dialog_set_account_name),
4329 (save_configuration):
4330 * src/maemo/modest-account-settings-dialog.h:
4331 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4332 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4334 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4336 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4337 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4338 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4340 * src/modest-defs.h:
4341 * src/maemo/modest-account-settings-dialog.c:
4342 (create_page_incoming), (on_combo_outgoing_security_changed),
4343 (on_combo_incoming_security_changed), (create_page_outgoing),
4344 (modest_account_settings_dialog_set_account_name),
4345 (save_configuration): Load/Save the port number, and change it when the
4346 security combo changes, to suitable defaults.
4348 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4350 * src/modest-account-mgr.c:
4351 (modest_account_mgr_add_server_account): Set the security and secure-auth
4352 options, and add a comment saying that the other camel-specific options should be
4355 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4357 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4359 * src/modest-tny-account-store.c: (account_list_free),
4360 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4361 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4364 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4366 * src/modest-protocol-info.c:
4367 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4368 is required by our UI spec. Maybe something in our implementation will use this eventually.
4369 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4370 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4371 instead of the previous 0 placeholder.
4373 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4374 secure-auth settings.
4375 * src/modest-account-mgr-helpers.h:
4376 * src/modest-account-mgr-helpers.c:
4377 (modest_server_account_data_get_option_secure_auth),
4378 (modest_server_account_set_option_secure_auth),
4379 (modest_server_account_data_get_option_security),
4380 (modest_server_account_set_option_security): Added this API for getting and setting the security
4381 and secure-auth settings.
4383 * src/maemo/modest-account-settings-dialog.h:
4384 * src/maemo/modest-account-settings-dialog.c:
4385 (modest_account_settings_dialog_finalize), (check_data),
4386 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4387 about changing titles.
4388 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4389 (save_configuration): Save the security and secure-auth settings.
4391 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4392 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4394 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4396 * src/modest-defs.h:
4397 * src/modest-account-mgr.c:
4398 (modest_account_mgr_add_server_account):
4399 Added and used defines for the options key and value pair strings,
4400 that are used so far, though they do not seem to correspond to anything in our
4401 UI specs or ModestProtocol enum.
4403 * src/modest-account-mgr-helpers.h:
4404 * src/modest-account-mgr-helpers.c:
4405 (compare_option_strings_for_name),
4406 (modest_server_account_data_get_option_value),
4407 (modest_server_account_data_get_option_bool),
4408 (modest_account_mgr_get_server_account_option):
4409 Added helper functions for parsing the options GSList.
4411 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4413 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4414 display name is based on the supplied account name.
4415 * src/modest-account-mgr.c:
4416 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4417 with an inefficient, but good-enough, implementation.
4419 * src/maemo/easysetup/modest-easysetup-wizard.c:
4420 (create_page_account_details), (on_before_next), (create_account):
4421 Check for existing display names rather than (non-user-visible) account names, and just
4422 create and set a unique account name at the end.
4424 * src/maemo/modest-account-settings-dialog.c:
4425 (modest_account_settings_dialog_init),
4426 (modest_account_settings_dialog_set_account_name),
4427 (create_page_incoming): Show the display name, instead of the account name.
4428 (on_response): Do some (not all) extra checks, as in the UI spec.
4429 (save_configuration): Save the display name if it was changed.
4431 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4433 * po/en_GB.po: Added needed logical ID and translation.
4434 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4435 (init_view): Made the is-default column clicking work.
4437 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4440 * src/maemo/easysetup/Makefile.am:
4441 * src/maemo/easysetup/modest-easysetup-wizard.c:
4442 (modest_easysetup_wizard_dialog_init):
4443 * src/maemo/easysetup/provider-data-test.keyfile:
4444 * src/maemo/easysetup/provider-data.keyfile:
4445 Moved the provider data file to the new modest-providers-data package and used it from there.
4447 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4449 * src/modest-local-folder-info.c:
4450 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4451 N_() was already used on the static strings, but this just marks it for translation without
4452 using the translation.
4454 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4456 * src/maemo/modest-account-settings-dialog.c:
4457 (create_page_incoming),
4458 (modest_account_settings_dialog_set_account_name):
4459 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4460 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4461 I will do this if nobody else gets there first.
4463 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4465 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4466 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4467 save the security stuff.
4469 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4471 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4472 Set the email address and user fullname, which I now see must be
4475 * src/maemo/modest-account-settings-dialog.h:
4476 * src/maemo/modest-account-settings-dialog.c:
4478 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4479 leave-on-server and authentication.
4480 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4483 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4486 * src/maemo/modest-account-settings-dialog.c:
4487 * src/maemo/modest-account-settings-dialog.h:
4488 Most (but not all) of the widgets are now present as specified by the UI spec.
4489 No changes are yet saved, and some details are not properly shown yet.
4491 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4493 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4495 * src/maemo/Makefile.am:
4496 * src/maemo/modest-account-settings-dialog.c:
4497 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4498 an existing account. Doesn't do much yet.
4500 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4501 Open the accounts settings dialog when Edit is clicked.
4503 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4505 * src/maemo/easysetup/Makefile.am:
4506 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4508 * src/maemo/easysetup/modest-easysetup-wizard.c:
4509 (modest_easysetup_wizard_dialog_init):
4510 Try to get the source directory from the build system,
4511 instead of hard-coding "./" into the source code, when opening our local
4512 copies of the configuration files.
4513 But this still fails when opening the wizard from the Accounts window,
4514 maybe because the working directory seems to change at runtime.
4515 So the wizard will fail the second time unless you copy the files into their
4516 proper locations - see the stdout warnings for the paths.
4518 (create_page_account_details),(on_before_next):
4519 Check for existing non-server accounts instead of server accounts,
4520 so the default account name is useful again, and to prevent trying to
4523 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4524 Show the wizard when New is clicked.
4526 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4527 (init_view): Show the column headers, and show the columns that are
4528 specified in the UI specs. However, something in Maemo's GTK+ prevents
4529 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4530 change the default account. This is despite unsetting the special properties.
4532 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4534 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4535 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4536 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4537 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4538 to make that clearer.
4539 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4541 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4543 * src/maemo/modest-account-view-window.c:
4544 (modest_account_view_window_init),
4545 (modest_account_view_window_new):
4546 Use the same buttons as specified in the
4547 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4548 the existing widgets, which never had a chance of working.
4549 Put the ModestAccountView treeview in a scrolled window.
4550 Do not repeat the initialization in both _init() and _new().
4552 * src/widgets/modest-account-view.c: (update_account_view):
4553 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4554 this widget and window shows no accounts.
4556 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4558 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4560 * src/maemo/easysetup/modest-easysetup-wizard.c:
4561 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4562 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4563 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4566 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4567 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4568 accounts exist yet, as in the UI spec.
4570 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4572 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4574 * src/maemo/Makefile.am:
4575 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4576 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4577 New window for editing connection-specific smtp details.
4578 Not fully implemented.
4580 * src/maemo/modest-connection-specific-smtp-window.c:
4581 (modest_connection_specific_smtp_window_finalize) :
4582 unref the tree model.
4583 (on_button_edit): Show the edit window.
4585 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4587 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4590 * src/maemo/Makefile.am:
4591 * src/maemo/modest-connection-specific-smtp-window.c:
4592 * src/maemo/modest-connection-specific-smtp-window.h:
4593 New window for showing the list of connections, for connection-specific
4594 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4595 * src/maemo/easysetup/modest-easysetup-wizard.c:
4596 (create_page_custom_outgoing): Show the new window when the button is clicked.
4598 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4600 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4601 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4602 * src/maemo/modest-msg-edit-window.c:
4603 (modest_msg_edit_window_insert_image):
4604 * src/modest-conf.c: (modest_conf_key_escape):
4605 * src/modest-mail-operation.c:
4606 (modest_mail_operation_send_new_mail):
4607 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4608 (modest_ui_actions_on_new_account):
4609 * src/widgets/modest-attachment-view.c: (update_filename_request):
4610 * src/widgets/modest-mail-header-view.c:
4611 Corrected warnings that were breaking the build, by commenting out unused variables,
4612 and a function, and by including a header.
4614 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4616 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4617 so we can #ifdef around platform-specific code when necessary.
4618 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4619 to allow this to build for the GNOME platform too.
4621 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4623 * src/maemo/easysetup/modest-easysetup-wizard.c:
4624 Added util_increment_name() and used it in create_page_account_details()
4625 to make sure that the default account name is always a new name.
4627 (modest_easysetup_wizard_dialog_init),
4628 (set_default_custom_servernames): Some minor memory management fixes.
4630 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4634 * src/modest-runtime.c: (init_i18n): Restored the translation
4635 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4636 are defined in config.h, and the translations are installed.
4638 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4639 is defined for translation.
4641 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4643 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4645 * src/maemo/easysetup/modest-easysetup-wizard.c:
4646 (modest_easysetup_wizard_dialog_init):
4647 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4648 Use realistic paths (though they should use $prefix generically) to the
4649 mcc_mapping and provider-data.keyfile files which might work when they
4650 are installed by the future version of the operator-wizard package,
4651 and then fallback to paths in our source code, with an explanatory
4654 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4658 * src/maemo/Makefile.am:
4659 * src/maemo/easysetup/: Added files from the previously-exernal
4660 osso-modest-easysetup.
4661 * src/maemo/modest-main-window-ui.h:
4662 * src/modest-ui-actions.c:
4663 * src/modest-ui-actions.h:
4664 Added modest_ui_actions_on_new_account() as a signal handler for the
4665 New Account menu item. It shows the easysetup wizard.
4666 * po/en_GB.po: Added additional needed logical IDs and translations.