1 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3 * src/widgets/Makefile.am:
4 * src/widgets/modest-limit-retrieve-combo-box.c:
5 * src/widgets/modest-limit-retrieve-combo-box.h:
6 * src/widgets/modest-retrieve-combo-box.c:
7 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
8 the account settings dialog.
11 * src/modest-account-mgr-helpers.h:
12 * src/modest-account-mgr-helpers.c:
13 (modest_server_account_get_option_secure_auth),
14 (modest_server_account_set_option_secure_auth):
15 * src/modest-account-mgr.c:
16 (modest_account_mgr_add_server_account):
17 Use the existing AUTH_MECH conf key for the secure-auth setting,
18 instead of putting it in the list options, because this was actually used already.
20 * src/maemo/modest-account-settings-dialog.c:
21 (create_page_account_details),
22 (modest_account_settings_dialog_set_account_name),
24 * src/maemo/modest-account-settings-dialog.h:
25 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
26 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
28 2007-04-18 Murray Cumming <murrayc@murrayc.com>
30 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
31 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
32 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
35 * src/maemo/modest-account-settings-dialog.c:
36 (create_page_incoming), (on_combo_outgoing_security_changed),
37 (on_combo_incoming_security_changed), (create_page_outgoing),
38 (modest_account_settings_dialog_set_account_name),
39 (save_configuration): Load/Save the port number, and change it when the
40 security combo changes, to suitable defaults.
42 2007-04-17 Murray Cumming <murrayc@murrayc.com>
44 * src/modest-account-mgr.c:
45 (modest_account_mgr_add_server_account): Set the security and secure-auth
46 options, and add a comment saying that the other camel-specific options should be
49 2007-04-17 Murray Cumming <murrayc@murrayc.com>
51 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
53 * src/modest-tny-account-store.c: (account_list_free),
54 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
55 cursor->data after unreffing it. But there is some strange stuff there so it might not be
58 2007-04-17 Murray Cumming <murrayc@murrayc.com>
60 * src/modest-protocol-info.c:
61 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
62 is required by our UI spec. Maybe something in our implementation will use this eventually.
63 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
64 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
65 instead of the previous 0 placeholder.
67 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
69 * src/modest-account-mgr-helpers.h:
70 * src/modest-account-mgr-helpers.c:
71 (modest_server_account_data_get_option_secure_auth),
72 (modest_server_account_set_option_secure_auth),
73 (modest_server_account_data_get_option_security),
74 (modest_server_account_set_option_security): Added this API for getting and setting the security
75 and secure-auth settings.
77 * src/maemo/modest-account-settings-dialog.h:
78 * src/maemo/modest-account-settings-dialog.c:
79 (modest_account_settings_dialog_finalize), (check_data),
80 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
81 about changing titles.
82 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
83 (save_configuration): Save the security and secure-auth settings.
85 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
86 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
88 2007-04-17 Murray Cumming <murrayc@murrayc.com>
91 * src/modest-account-mgr.c:
92 (modest_account_mgr_add_server_account):
93 Added and used defines for the options key and value pair strings,
94 that are used so far, though they do not seem to correspond to anything in our
95 UI specs or ModestProtocol enum.
97 * src/modest-account-mgr-helpers.h:
98 * src/modest-account-mgr-helpers.c:
99 (compare_option_strings_for_name),
100 (modest_server_account_data_get_option_value),
101 (modest_server_account_data_get_option_bool),
102 (modest_account_mgr_get_server_account_option):
103 Added helper functions for parsing the options GSList.
105 2007-04-16 Murray Cumming <murrayc@murrayc.com>
107 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
108 display name is based on the supplied account name.
109 * src/modest-account-mgr.c:
110 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
111 with an inefficient, but good-enough, implementation.
113 * src/maemo/easysetup/modest-easysetup-wizard.c:
114 (create_page_account_details), (on_before_next), (create_account):
115 Check for existing display names rather than (non-user-visible) account names, and just
116 create and set a unique account name at the end.
118 * src/maemo/modest-account-settings-dialog.c:
119 (modest_account_settings_dialog_init),
120 (modest_account_settings_dialog_set_account_name),
121 (create_page_incoming): Show the display name, instead of the account name.
122 (on_response): Do some (not all) extra checks, as in the UI spec.
123 (save_configuration): Save the display name if it was changed.
125 2007-04-16 Murray Cumming <murrayc@murrayc.com>
127 * po/en_GB.po: Added needed logical ID and translation.
128 * src/widgets/modest-account-view.c: (on_account_default_toggled),
129 (init_view): Made the is-default column clicking work.
131 2007-04-16 Murray Cumming <murrayc@murrayc.com>
134 * src/maemo/easysetup/Makefile.am:
135 * src/maemo/easysetup/modest-easysetup-wizard.c:
136 (modest_easysetup_wizard_dialog_init):
137 * src/maemo/easysetup/provider-data-test.keyfile:
138 * src/maemo/easysetup/provider-data.keyfile:
139 Moved the provider data file to the new modest-providers-data package and used it from there.
141 2007-04-16 Murray Cumming <murrayc@murrayc.com>
143 * src/modest-local-folder-info.c:
144 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
145 N_() was already used on the static strings, but this just marks it for translation without
146 using the translation.
148 2007-04-06 Murray Cumming <murrayc@murrayc.com>
150 * src/maemo/modest-account-settings-dialog.c:
151 (create_page_incoming),
152 (modest_account_settings_dialog_set_account_name):
153 Added comments about the need for new API in ModestAccountMgr to handle the authentication
154 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
155 I will do this if nobody else gets there first.
157 2007-04-06 Murray Cumming <murrayc@murrayc.com>
159 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
160 Saved much of the incoming and outgoing data too, though I cannot yet see how to
161 save the security stuff.
163 2007-04-06 Murray Cumming <murrayc@murrayc.com>
165 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
166 Set the email address and user fullname, which I now see must be
169 * src/maemo/modest-account-settings-dialog.h:
170 * src/maemo/modest-account-settings-dialog.c:
172 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
173 leave-on-server and authentication.
174 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
177 2007-04-06 Murray Cumming <murrayc@murrayc.com>
180 * src/maemo/modest-account-settings-dialog.c:
181 * src/maemo/modest-account-settings-dialog.h:
182 Most (but not all) of the widgets are now present as specified by the UI spec.
183 No changes are yet saved, and some details are not properly shown yet.
185 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
187 2007-04-06 Murray Cumming <murrayc@murrayc.com>
189 * src/maemo/Makefile.am:
190 * src/maemo/modest-account-settings-dialog.c:
191 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
192 an existing account. Doesn't do much yet.
194 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
195 Open the accounts settings dialog when Edit is clicked.
197 2007-04-05 Murray Cumming <murrayc@murrayc.com>
199 * src/maemo/easysetup/Makefile.am:
200 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
202 * src/maemo/easysetup/modest-easysetup-wizard.c:
203 (modest_easysetup_wizard_dialog_init):
204 Try to get the source directory from the build system,
205 instead of hard-coding "./" into the source code, when opening our local
206 copies of the configuration files.
207 But this still fails when opening the wizard from the Accounts window,
208 maybe because the working directory seems to change at runtime.
209 So the wizard will fail the second time unless you copy the files into their
210 proper locations - see the stdout warnings for the paths.
212 (create_page_account_details),(on_before_next):
213 Check for existing non-server accounts instead of server accounts,
214 so the default account name is useful again, and to prevent trying to
217 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
218 Show the wizard when New is clicked.
220 * src/widgets/modest-account-view.c: (on_account_default_toggled),
221 (init_view): Show the column headers, and show the columns that are
222 specified in the UI specs. However, something in Maemo's GTK+ prevents
223 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
224 change the default account. This is despite unsetting the special properties.
226 2007-04-05 Murray Cumming <murrayc@murrayc.com>
228 * docs/reference/modest-design.sgml: Corrected spelling mistake.
229 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
230 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
231 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
232 to make that clearer.
233 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
235 2007-04-05 Murray Cumming <murrayc@murrayc.com>
237 * src/maemo/modest-account-view-window.c:
238 (modest_account_view_window_init),
239 (modest_account_view_window_new):
240 Use the same buttons as specified in the
241 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
242 the existing widgets, which never had a chance of working.
243 Put the ModestAccountView treeview in a scrolled window.
244 Do not repeat the initialization in both _init() and _new().
246 * src/widgets/modest-account-view.c: (update_account_view):
247 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
248 this widget and window shows no accounts.
250 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
252 2007-04-05 Murray Cumming <murrayc@murrayc.com>
254 * src/maemo/easysetup/modest-easysetup-wizard.c:
255 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
256 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
257 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
260 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
261 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
262 accounts exist yet, as in the UI spec.
264 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
266 2007-04-05 Murray Cumming <murrayc@murrayc.com>
268 * src/maemo/Makefile.am:
269 * src/maemo/modest-connection-specific-smtp-edit-window.c:
270 * src/maemo/modest-connection-specific-smtp-edit-window.h:
271 New window for editing connection-specific smtp details.
272 Not fully implemented.
274 * src/maemo/modest-connection-specific-smtp-window.c:
275 (modest_connection_specific_smtp_window_finalize) :
276 unref the tree model.
277 (on_button_edit): Show the edit window.
279 2007-04-05 Murray Cumming <murrayc@murrayc.com>
281 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
284 * src/maemo/Makefile.am:
285 * src/maemo/modest-connection-specific-smtp-window.c:
286 * src/maemo/modest-connection-specific-smtp-window.h:
287 New window for showing the list of connections, for connection-specific
288 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
289 * src/maemo/easysetup/modest-easysetup-wizard.c:
290 (create_page_custom_outgoing): Show the new window when the button is clicked.
292 2007-04-04 Murray Cumming <murrayc@murrayc.com>
294 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
295 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
296 * src/maemo/modest-msg-edit-window.c:
297 (modest_msg_edit_window_insert_image):
298 * src/modest-conf.c: (modest_conf_key_escape):
299 * src/modest-mail-operation.c:
300 (modest_mail_operation_send_new_mail):
301 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
302 (modest_ui_actions_on_new_account):
303 * src/widgets/modest-attachment-view.c: (update_filename_request):
304 * src/widgets/modest-mail-header-view.c:
305 Corrected warnings that were breaking the build, by commenting out unused variables,
306 and a function, and by including a header.
308 2007-04-04 Murray Cumming <murrayc@murrayc.com>
310 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
311 so we can #ifdef around platform-specific code when necessary.
312 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
313 to allow this to build for the GNOME platform too.
315 2007-04-04 Murray Cumming <murrayc@murrayc.com>
317 * src/maemo/easysetup/modest-easysetup-wizard.c:
318 Added util_increment_name() and used it in create_page_account_details()
319 to make sure that the default account name is always a new name.
321 (modest_easysetup_wizard_dialog_init),
322 (set_default_custom_servernames): Some minor memory management fixes.
324 2007-04-04 Murray Cumming <murrayc@murrayc.com>
328 * src/modest-runtime.c: (init_i18n): Restored the translation
329 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
330 are defined in config.h, and the translations are installed.
332 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
333 is defined for translation.
335 2007-04-03 Murray Cumming <murrayc@murrayc.com>
337 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
339 * src/maemo/easysetup/modest-easysetup-wizard.c:
340 (modest_easysetup_wizard_dialog_init):
341 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
342 Use realistic paths (though they should use $prefix generically) to the
343 mcc_mapping and provider-data.keyfile files which might work when they
344 are installed by the future version of the operator-wizard package,
345 and then fallback to paths in our source code, with an explanatory
348 2007-04-03 Murray Cumming <murrayc@murrayc.com>
352 * src/maemo/Makefile.am:
353 * src/maemo/easysetup/: Added files from the previously-exernal
354 osso-modest-easysetup.
355 * src/maemo/modest-main-window-ui.h:
356 * src/modest-ui-actions.c:
357 * src/modest-ui-actions.h:
358 Added modest_ui_actions_on_new_account() as a signal handler for the
359 New Account menu item. It shows the easysetup wizard.
360 * po/en_GB.po: Added additional needed logical IDs and translations.
362 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
363 Apparently ChangeLog is not used for some vague Nokia legal reasons.