1 2007-06-03 Armin Burgmeier <armin@openismus.com>
3 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
4 when the operation queue was not empty. projects.maemo.org bug
7 2007-06-03 Armin Burgmeier <armin@openismus.com>
9 * src/widgets/modest-account-view.c
10 (on_account_default_toggled): Toggle default account column
11 explicitely instead of waiting for gconf notification (which is
12 currently ignored). This should fix projects.maemo.org bug NB#56910
13 for now. It should probably be removed when gconf notifications are
16 2007-06-03 Christian Kellner <ckellner@openismus.com>
18 * libmodest-dbus-client/libmodest-dbus-client.c:
19 Removed debugging spew.
21 * src/dbus_api/modest-dbus-callbacks.c:
24 * src/modest-search.c:
25 (modest_search_all_accounts):
26 Use tny_account_store_get_accounts () on the account store
27 to get all accounts which is the way to get all accounts.
29 * tests/dbus_api/test_search.c: (main):
30 Make it possible to supply the search term on the command line.
32 2007-06-03 Christian Kellner <ckellner@openismus.com>
34 * libmodest-dbus-client/libmodest-dbus-client.c:
35 * libmodest-dbus-client/libmodest-dbus-client.h:
36 Implement searching for mesages over raw dbus. (Client side)
38 * src/dbus_api/Makefile.am:
39 * src/dbus_api/modest-dbus-api.h:
40 * src/dbus_api/modest-dbus-callbacks.c:
41 * src/dbus_api/modest-dbus-callbacks.h:
42 Search framework (Server side). Also implement on_idle_open_message().
44 * src/maemo/modest-platform.c: (modest_platform_init):
45 Prepare for raw dbus/osso rpc interaction.
47 * src/modest-search.h:
48 Changed minsize from unspecific guint to guint32.
50 * src/modest-search.c:
52 Added strange hack which magically made tnymail work.
54 (modest_search_folder),
55 (modest_search_account),
56 (modest_search_all_accounts):
57 Implement helper functions to search all accounts, specific account
60 * tests/dbus_api/Makefile.am:
61 * tests/dbus_api/test_open_message.c:
62 Read url to open from commandline.
64 * tests/dbus_api/test_search.c:
65 Implement small test for dbus search stuff
67 2007-06-02 Armin Burgmeier <armin@openismus.com>
69 * src/maemo/modest-account-settings-dialog.c: Changed window title to
70 include account type and account title. This fixes projects.maemo.org
73 * src/maemo/modest-account-view-window.c: Set a title for the window.
75 2007-06-02 Armin Burgmeier <armin@openismus.com>
77 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
78 incoming and outgoing server name based on email address and server
79 types as long as the names have not been edited manually. This fixes
80 projects.maemo.org bug NB#58671.
82 2007-06-02 Armin Burgmeier <armin@openismus.com>
84 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
85 server type cannot be changed in future to the incoming details page
86 when creating an account. This fixes projects.maemo.org bug NB#59029.
88 2007-06-02 Armin Burgmeier <armin@openismus.com>
90 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
91 and assigned max width chars so that they wrap instead of being
92 truncated. Fixes projects.maemo.org bug NB#56126.
94 2007-06-02 Armin Burgmeier <armin@openismus.com>
96 * src/maemo/modest-connection-specific-smtp-window.c: Add an
97 introductory note to the connection specific smtp servers dialog, as
98 section 8.12 of the email UI specification requires. This fixes
99 projects.maemo.org bug NB#59212.
101 2007-06-01 Murray Cumming <murrayc@murrayc.com>
103 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
104 Check for running mail operations, and offer to cancel them, as per the UI
105 spec. This fixes projects.maemo.org bug NB#59041 .
106 However, I suspect that tinymail may still use the network connection
107 in ways that we cannot detect or cancel. But it should at least adapt to
110 2007-06-01 Murray Cumming <murrayc@murrayc.com>
112 * src/modest-tny-account-store.c: (recreate_all_accounts),
113 (get_cached_accounts), (get_server_accounts): Do more sensible
114 ref-counting of the temporarily-cached outbox accounts list. This seems
115 to fix a crash when entering the password when the password was wrong.
117 2007-06-01 Murray Cumming <murrayc@murrayc.com>
119 * src/gnome/modest-main-window.c: (connect_signals):
120 * src/modest-tny-account-store.c: (get_password),
121 (modest_tny_account_store_alert): Added comments and clues and
122 commented-out code about how we currently fail to deal with connection
123 errors and wrong passwords, and how we should.
125 2007-06-01 Murray Cumming <murrayc@murrayc.com>
127 * src/widgets/modest-retrieve-combo-box.c:
128 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
129 This fixes projects.maemo.org bug NB#58472 .
131 2007-06-01 Murray Cumming <murrayc@murrayc.com>
133 * src/maemo/easysetup/modest-easysetup-wizard.c:
134 (create_page_complete_easysetup):
135 (create_page_complete_custom): Correct the last commit,
136 putting the correct sentences in the correct pages.
138 2007-06-01 Murray Cumming <murrayc@murrayc.com>
140 * src/maemo/easysetup/modest-easysetup-wizard.c:
141 (create_page_complete_custom): Show the second sentence of text
142 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
145 2007-06-01 Murray Cumming <murrayc@murrayc.com>
147 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
148 Set the leave-on-server conf key by default. This fixes
149 projects.maemo.org bug NB#59258 .
151 2007-06-01 Murray Cumming <murrayc@murrayc.com>
153 * src/maemo/modest-account-view-window.c:
154 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
155 logical ID for the confirmation messages. Fixed projects.maemo.org bug
158 2007-06-01 Murray Cumming <murrayc@murrayc.com>
160 * src/maemo/easysetup/modest-easysetup-wizard.c:
161 (create_caption_new_with_asterisk):
162 * src/maemo/modest-account-settings-dialog.c:
163 (create_caption_new_with_asterisk):
164 Uncomment the code to add the asterisk, because they are no longer in the
165 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
166 (update_incoming_server_title): Add an asterisk here too.
168 2007-06-01 Murray Cumming <murrayc@murrayc.com>
170 * src/maemo/modest-maemo-global-settings-dialog.c:
171 (current_connection): Check that we are even connected before trying to
172 get the current connection name, to prevent a warning.
174 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
175 Change the comments because tny_maemo_conic_device_connect() is now meant to
177 * src/modest-mail-operation.c:
178 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
179 make sure we have a connection and fail if we can't connect.
181 2007-05-31 Murray Cumming <murrayc@murrayc.com>
183 * src/maemo/modest-main-window.c:
184 (on_account_store_connecting_finished): Do not try to get the
185 connection ID if we are not really connected. I am surprised that
186 this signal handler is called when we are not connected.
188 2007-05-31 Murray Cumming <murrayc@murrayc.com>
190 * src/modest-error.h:
191 * src/modest-ui-actions.c:
192 (modest_ui_actions_get_msgs_full_error_handler):
193 Renamed an enum, added comments, added an enum
194 for retrieve-limit errors.
196 * src/modest-mail-operation.c: (foreach_add_item),
197 (internal_folder_observer_update), (update_account_thread),
198 (modest_mail_operation_get_msgs_full):
199 (modest_mail_operation_update_account),
200 Added comments about how this works, and some code that should
201 (but does not) check the retrieve-limit. See the TODO comment.
203 2007-05-31 Murray Cumming <murrayc@murrayc.com>
205 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
206 Initialize help_id to fix the build. Warnings are good.
208 2007-05-31 Murray Cumming <murrayc@murrayc.com>
210 * src/widgets/modest-hbox-cell-renderer.c:
211 (modest_hbox_cell_renderer_append):
212 * src/widgets/modest-vbox-cell-renderer.c:
213 (modest_vbox_cell_renderer_append):
214 Fix the last commit by doing an extra ref.
216 2007-05-31 Murray Cumming <murrayc@murrayc.com>
218 * src/widgets/modest-hbox-cell-renderer.c:
219 (modest_hbox_cell_renderer_append):
220 * src/widgets/modest-vbox-cell-renderer.c:
221 (modest_vbox_cell_renderer_append):
222 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
223 to fix the build with Maemo Bora.
224 However, there seems to be a remaining crash, probably due to reference
227 2007-05-30 Murray Cumming <murrayc@murrayc.com>
229 * src/modest-tny-account.c:
230 (modest_tny_account_new_for_local_folders):
231 Use hildon_file_system_info_async_new() to get a better name for
232 the memory card account, setting it as the account name.
233 The timing seems to work, but this is probably
234 not the best place to do this. See the TODO comment.
235 * src/maemo/modest-main-window.c: (create_details_widget):
236 * src/widgets/modest-folder-view.c: (text_cell_data):
237 Use the tny account name instead of hardcoding a name.
239 2007-05-30 Christian Kellner <ckellner@openismus.com>
241 * src/modest-search.c: (modest_search):
242 Correctly set part_search_func even if we have already parsed
243 the query and thus a valid OgsTextSearcher object.
245 2007-05-30 Christian Kellner <ckellner@openismus.com>
248 Search and check for libogs.
251 Incooparte the ogs build env.
253 * src/modest-mime-part-search-stream.c:
254 * src/modest-mime-part-search-stream.h:
255 Removed since we do the real searching now in modest-search.c.
257 * src/modest-search.c:
258 * src/modest-search.h:
259 Implement support for ogs. We use that if available and requested
260 and fall back to modest_text_utils_utf8_strcmp (). The search logic
261 should now handle the corner case when the search term is spread
262 across multiple reads.
263 Also the logic in modest_search () was corrected to search all
264 requested fields until one is found.
266 2007-05-30 Murray Cumming <murrayc@murrayc.com>
268 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
271 * src/modest-init.c: Made modest_init_local_folders() take a
272 path and be public so we can iniitialize maildir folders on
275 * src/modest-local-folder-info.h:
276 * src/modest-local-folder-info.c:
277 (modest_local_folder_info_get_maildir_path): Add a path parameter.
279 * src/modest-tny-account.c:
280 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
281 still means the standard local-folders path on the local volume.
283 * src/modest-tny-account-store.c:
284 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
285 signal so we can detect mount/unmount of the MMC1 card, and do an update of
286 all accounts when that happens.
287 (get_server_accounts): If the MMC1 card is mounted, create a store account for
288 this too, so it shows up in the treeview.
290 2007-05-28 Murray Cumming <murrayc@murrayc.com>
292 * src/maemo/modest-maemo-global-settings-dialog.c:
293 (current_connection):
294 * src/widgets/modest-global-settings-dialog.c:
295 (current_connection_default):
296 Use the enum values instead of 0, 1 and -1,
297 to make the code clearer.
299 * src/modest-account-mgr-helpers.c:
300 (modest_account_mgr_get_connection_specific_smtp): Make this code
303 * src/modest-runtime.h:
304 * src/modest-runtime.c:
305 Added modest_runtime_remove_all_send_queues().
306 * src/maemo/modest-main-window.c:
307 (on_account_store_connecting_finished): Recreate the send queues,
308 using the appropriate transport accounts for this new connection.
309 Some futher adapting might be needed if the old send queues are not
310 automatically stopped at this point.
312 * src/modest-tny-account-store.c: (get_server_accounts):
313 Create the connection-specific transport accounts, so that they can
314 be found later by their ID.
316 * src/modest-tny-account.h:
317 * src/modest-tny-account.c:
318 Added modest_tny_account_new_from_server_account_name().
319 modest_tny_account_new_from_server_account(): Do not create the
320 send queues here, because they will be
321 recreated anyway when the connection changes for the first time.
323 2007-05-28 Murray Cumming <murrayc@murrayc.com>
325 * src/modest-local-folder-info.h:
326 * src/modest-local-folder-info.c:
327 (modest_per_account_local_outbox_folder_info_get_maildir_path),
328 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
329 tbox_folder): Take a modest account name instead of a server TnyAccount,
330 so we can have per-modest-account rather than per-transport-account
332 We must make sure that we change or recreate the exisitng send queues
333 when the connection changes for connection-specific transport accounts.
335 * src/modest-tny-account-store.c:
336 (create_per_account_local_outbox_folders): Create outboxed per modest
337 account, not per transport account.
339 * src/modest-tny-account.h:
340 * src/modest-tny-account.c:
341 (modest_tny_account_get_special_folder): For outboxes, get the
342 parent modest account name. The account is ignored for other folders.
343 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
344 modest account name rather than a server TnyAccount.
346 2007-05-25 Murray Cumming <murrayc@murrayc.com>
348 * src/modest-tny-account.c:
349 (modest_tny_account_new_from_server_account):
350 Call modest_runtime_get_send_queue() immediately after creating transport
351 accounts, so that they start trying to send email from the outbox as soon
352 as possible at startup. This is probably what we want.
354 * src/modest-mail-operation.c: (update_account_thread):
355 * src/modest-runtime.c: (modest_runtime_get_send_queue):
356 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
357 * src/modest-tny-send-queue.h:
358 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
359 (modest_ui_actions_on_send):
360 Added comments about how sending works, though it needs some more work.
362 2007-05-25 Murray Cumming <murrayc@murrayc.com>
364 * src/modest-tny-account.c:
365 (modest_tny_account_get_special_folder): Add TODO because this fails when
367 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
368 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
369 Do not try to show this window when there is no active account. The UI
370 specs does not tell us what to do in this case.
372 2007-05-24 Murray Cumming <murrayc@murrayc.com>
376 * src/maemo/Makefile.am:
377 * src/widgets/Makefile.am: Some dist fixes.
379 2007-05-24 Murray Cumming <murrayc@murrayc.com>
381 * src/maemo/modest-connection-specific-smtp-window.c:
382 (on_button_edit): Make the code clearer, to prevent a double free.
384 2007-05-24 Murray Cumming <murrayc@murrayc.com>
386 * src/maemo/modest-account-settings-dialog.c:
387 (modest_account_settings_dialog_set_account_name),
388 Check the connection-specific smtp servers checkbox if there are any.
390 * src/maemo/modest-connection-specific-smtp-edit-window.c:
391 (modest_connection_specific_smtp_edit_window_init):
392 Start with a suitable port number.
394 * src/modest-account-mgr-helpers.h:
395 * src/modest-account-mgr-helpers.c: Added
396 modest_account_mgr_get_has_connection_specific_smtp().
398 (modest_account_mgr_set_connection_specific_smtp),
399 (modest_account_mgr_remove_connection_specific_smtp),
400 (modest_account_mgr_get_has_connection_specific_smtp),
401 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
402 connection-specific smtp server accounts in the account, rather than
403 the server account conf dir.
405 This fixes bug projects.maemo.org bug NB#58263 .
407 * src/modest-tny-account-store.c:
408 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
409 if there are no server accounts yet, to prevent an infinite loop when there
410 are no accounts. Document that one must be called before the other.
412 2007-05-24 Murray Cumming <murrayc@murrayc.com>
414 * src/modest-account-mgr-helpers.c:
415 (modest_account_mgr_get_default_account): Make sure that at least
416 one account is always the default, if there are any enabled accounts.
417 This is just a sanity check that shouldn't be necessary.
419 * src/modest-account-mgr-priv.c:
420 (_modest_account_mgr_account_from_key): Unescape the conf key to
421 get the real account name. For instance, this is an issue if a space
422 was in the account name, which can happen because the account name
423 is generated from the display name.
424 (_modest_account_mgr_get_account_keyname): Always escape the
426 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
427 Unescape the conf keys to get the real account names.
429 For instance, previously the is-default radio button in the accounts
430 list was not checked for any accounts at first. This fixes that,
431 and might fix several similar bugs.
433 2007-05-23 Murray Cumming <murrayc@murrayc.com>
435 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
436 Removed some debug printfs.
438 2007-05-23 Murray Cumming <murrayc@murrayc.com>
440 Modest on-disk outbox directories are now here, for instance:
441 $HOME/.modest/outboxes/<account-id-1>/outbox
442 $HOME/.modest/outboxes/<account-id-2>/outbox
444 $HOME/.modest/local-folders/outbox
445 so we can have a separate outbox for each account.
446 But they are shown as one outbox in the GtkTreeView, by using a
447 TnyMergeFolder in a ModestTnySimpleFolderStore.
450 * src/modest-tny-simple-folder-store.c:
451 * src/modest-tny-simple-folder-store.h:
452 Added ModestTnySimpleFolderStore, used to contain folders from
453 other folder stores, such as other accounts.
455 * src/modest-tny-outbox-account.h:
456 * src/modest-tny-outbox-account.c:
457 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
458 used for the per-account local outbox folders.
460 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
461 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
462 only use this (internally) now for the non-outbox local folders.
465 * src/modest-init.c: Added modest_init_one_local_folder(), for
466 setting up the directory structure for each local folder.
468 * src/modest-local-folder-info.c:
469 (modest_per_account_local_outbox_folder_info_get_maildir_path),
470 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
472 * src/modest-local-folder-info.h:
473 * src/modest-tny-account-store.c: (on_account_removed),
474 (on_account_changed), (create_per_account_local_outbox_folders),
475 (get_server_accounts), (modest_tny_account_store_get_accounts),
476 (modest_tny_account_store_get_tny_account_by_account),
477 (modest_tny_folder_store_is_virtual_local_folders):
479 * src/modest-tny-account.h:
480 * src/modest-tny-account.c:
481 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
482 to create an on-disk per-account local outbox folder for each
484 (create_per_account_local_outbox_folders): Create a local outbox folder
485 for each transport account.
486 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
487 for all local folders.
489 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
490 instead of using g_object_get/set() directly. It is clearer.
492 (modest_tny_folder_store_get_message_count),
493 (modest_tny_folder_store_get_local_size
494 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
495 because we now use these with non-acount folder stores.
497 (modest_tny_account_get_special_folder),
498 (modest_tny_account_new_from_server_account),
499 (modest_tny_account_new_from_account):
500 (recurse_folders): Adjust to the new outbox system.
502 * src/modest-tny-folder.h:
503 * src/modest-tny-folder.c:
504 (modest_tny_folder_is_local_folder),
505 (modest_tny_folder_get_local_folder_type),
506 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
508 * src/widgets/modest-main-window.h:
509 * src/maemo/modest-main-window.c: (create_details_widget),
510 (modest_main_window_set_contents_style): Show details for any folder store,
513 (modest_tny_folder_get_rules):
514 Remove the const. C does not support constness enough for this.
516 * src/modest-ui-actions.c:
517 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
518 make all outboxes appear as one, in the usual local-folders tree node.
520 (set_active_account_from_tny_account),
521 (modest_ui_actions_on_folder_selection_changed):
522 * src/widgets/modest-folder-view.c: (text_cell_data),
523 (icon_cell_data), (filter_row),
524 (add_account_folders_to_merged_folder),
525 (add_account_folders_to_simple_folder_store), (),
526 (get_cmp_rows_type_pos), (cmp_rows),
527 (modest_folder_view_set_account_id_of_visible_server_account):
528 Adjust to the new outbox system, using generic folder stores and folders
531 2007-05-23 Christian Kellner <ckellner@openismus.com>
533 * src/modest-mail-operation.c:
534 (modest_mail_operation_update_account):
535 Use info->max_size instead of unintialized local var [small
536 build fix]. (Added TODO to review that change since I don't
539 2007-05-23 Marcus Bauer <marcusb@openismus.com>
541 * libmodest-dbus-client/libmodest-dbus-client.c:
542 (libmodest_dbus_client_compose_mail): function added
543 * src/dbus_api/modest-dbus-api.h:
544 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
545 (on_compose_mail): Implementation of the SendAsMail functionality
547 2007-05-22 Murray Cumming <murrayc@murrayc.com>
549 * src/modest-account-mgr.c:
550 (modest_account_mgr_add_server_account): Set the secure-connection
551 conf key for transport accounts as well as store accounts. I don't know
552 why the if was there. For instance, this makes sure that we use SSL
553 for the gmail preset from the easysetup wizard.
555 2007-05-22 Murray Cumming <murrayc@murrayc.com>
557 * src/gnome/modest-main-window.c:
558 (on_account_store_connecting_finished), (connect_signals):
559 * src/maemo/modest-main-window.c:
560 (on_account_store_connecting_finished), (connect_signals),
561 (modest_main_window_new):
562 Handle TnyAccountStore::connecting-finished instead of
563 TnyDevice::connection-changed, because we cannot actually perform
564 operations on accounts until TnyAccountStore has itself responded to
565 the TnyDevice::connection-changed signal. This prevents a GError from
567 Do not try to update at startup, because we (at least on scratchbox)
568 already do an update at startup when the device goes online.
569 This prevents a GError from tinymail.
570 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
571 Added TODO about stopping simultaneous operations.
573 2007-05-21 Murray Cumming <murrayc@murrayc.com>
575 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
576 * src/modest-mail-operation-queue.c:
577 (modest_mail_operation_queue_remove):
578 * src/modest-tny-account-store.c: When GErrors happen, give more clues
579 about where they happened.
581 2007-05-21 Murray Cumming <murrayc@murrayc.com>
583 * src/modest-ui-actions.c:
584 (modest_ui_actions_on_password_requested): Make sure that the remember
585 output parameter is always TRUE.
587 2007-05-21 Murray Cumming <murrayc@murrayc.com>
589 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
590 Show a OK/Cancel dialog if the error is a question, though we still do not
591 know anything more about what we are asking the user.
592 * src/widgets/modest-folder-view.c: (on_drag_data_received):
593 Fix an uninitialized variable (helper). This is a logic error, however.
595 2007-05-21 Christian Kellner <ckellner@openismus.com>
597 * src/modest-search.h:
598 Correct bit shifting in the ModestSearchFlags enum.
600 2007-05-21 Murray Cumming <murrayc@murrayc.com>
602 * src/modest-tny-account.c:
603 (modest_tny_account_new_from_server_account): Do not use the lsub and
604 check-all hard-coded IMAP options when using POP.
606 2007-05-21 Murray Cumming <murrayc@murrayc.com>
608 * src/modest-tny-account.c:
609 (modest_tny_account_new_from_server_account):
610 Use NULL for the secure-auth method for POP when Password auth has been
611 specified by the user, as we already do for IMAP. "auth=Login" causes
612 an error from camel or the server.
614 2007-05-17 Murray Cumming <murrayc@murrayc.com>
616 * src/maemo/modest-account-settings-dialog.c:
617 (create_page_account_details),
618 (modest_account_settings_dialog_set_account_name):
619 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
620 for the leave-on-server checkbox, rathr than just the checkbox, when
621 the protocol is not POP.
623 2007-05-17 Murray Cumming <murrayc@murrayc.com>
625 * src/widgets/modest-account-view.c:
626 * src/widgets/modest-account-view.h:
627 Added modest_account_view_select_account() which will be useful later
628 to asynchronously re-select the edited account.
630 2007-05-17 Murray Cumming <murrayc@murrayc.com>
632 * src/maemo/modest-account-settings-dialog.c:
633 (modest_account_settings_dialog_set_account_name):
634 Automatically choose the port numbers based on the secure authentication
635 methods, if they have not been chosen before.
636 This fixes projects.maemo.org bug NB#56273 .
638 2007-05-17 Murray Cumming <murrayc@murrayc.com>
640 * src/maemo/modest-main-window-ui.h:
641 * src/modest-ui-actions.c:
642 * src/modest-ui-actions.h:
643 Connect the Tools/SMTP Servers menu item to
644 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
645 SMTP servers dialog, as in the UI specification and saves changes when it
646 is closed. This fixed projects.maemo.org bug NB#56305 .
648 2007-05-17 Murray Cumming <murrayc@murrayc.com>
650 * src/maemo/modest-connection-specific-smtp-window.c:
651 (modest_connection_specific_smtp_window_init):
652 Use gtk_window_set_default_size() to make this window big enough, so
653 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
655 2007-05-17 Murray Cumming <murrayc@murrayc.com>
657 * src/maemo/modest-connection-specific-smtp-edit-window.h:
658 * src/maemo/modest-connection-specific-smtp-edit-window.c:
659 (modest_connection_specific_smtp_edit_window_init),
660 Do not try to connect to a combobox signal before the combobox exists.
661 This fixes the cras in projects.maemo.org bug NB#56288 .
662 (modest_connection_specific_smtp_edit_window_get_settings):
663 Remove the server_account_name parameter which was being checked for NULL
664 though it was not used.
666 * src/maemo/modest-connection-specific-smtp-window.c:
667 (modest_connection_specific_smtp_window_fill_with_connections),
668 (on_button_edit), (modest_connection_specific_smtp_window_init):
669 Correct the number of treemodel columns to prevent a warning.
670 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
671 libconic does not work.
673 2007-05-16 Murray Cumming <murrayc@murrayc.com>
675 * src/modest-tny-account.c:
676 (modest_tny_account_new_from_server_account):
677 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
678 SMTP when "None" was chosen by the user. However, with my SMTP server that
679 does not support ANONYMOUS, the emails do not leave the Outbox and I see
682 2007-05-16 Murray Cumming <murrayc@murrayc.com>
684 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
685 to explain the memory management issue with the ID in the ModestPair.
687 * src/gnome/modest-account-assistant.c: (add_receiving_page),
688 (add_sending_page), (modest_account_assistant_finalize):
689 * src/gnome/modest-gnome-global-settings-dialog.c:
690 (create_updating_page), (create_composing_page):
691 * src/gnome/modest-msg-edit-window.c: (get_transports),
692 (init_window), (modest_msg_edit_window_finalize),
693 (modest_msg_edit_window_get_msg_data):
694 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
695 * src/gnome/modest-transport-widget.c:
696 (modest_transport_widget_finalize), (smtp_configuration):
697 * src/maemo/modest-maemo-global-settings-dialog.c:
698 (create_updating_page), (create_composing_page):
699 * src/maemo/modest-msg-edit-window.c: (get_transports),
700 (init_window), (modest_msg_edit_window_finalize),
701 (modest_msg_edit_window_get_msg_data),
702 (modest_msg_edit_window_free_msg_data):
703 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
704 (modest_store_widget_finalize):
705 * src/maemo/modest-transport-widget.c:
706 (modest_transport_widget_finalize), (smtp_configuration):
707 * src/modest-main.c: (send_mail):
708 * src/widgets/modest-combo-box.h:
709 * src/widgets/modest-global-settings-dialog-priv.h:
710 * src/widgets/modest-global-settings-dialog.c:
711 (modest_global_settings_dialog_finalize):
712 * src/widgets/modest-msg-edit-window.h:
713 Whenever using modest_combo_box_new(), keep the ModestPairList alive
714 as long as the combo box, to prevent use of freed memory for the ID.
716 2007-05-15 Murray Cumming <murrayc@murrayc.com>
718 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
719 get_accounts(), to make this clearer. Do not check for the enabled gconf
720 key, because we do not use this for server accounts (at least, not yet).
721 This allows us to send email again.
723 2007-05-15 Murray Cumming <murrayc@murrayc.com>
725 * src/maemo/modest-platform.c:
726 (on_modest_conf_update_interval_changed), (modest_platform_init):
727 Only respond to this particular key change. All these strcmp()s cannot be
730 2007-05-15 Murray Cumming <murrayc@murrayc.com>
732 * src/maemo/modest-maemo-global-settings-dialog.c:
733 (current_connection): Prevent a crash in scratchbox when
734 ny_maemo_conic_device_get_current_iap_id() returns NULL.
735 * src/maemo/modest-platform.c:
736 (on_modest_conf_update_interval_changed), (modest_platform_init):
737 Get the update interval from gconf and reset it when the gconf key changes.
739 2007-05-15 Murray Cumming <murrayc@murrayc.com>
741 * src/modest-protocol-info.c:
742 * src/modest-protocol-info.h: Adde enum-specific get functions,
743 instead of using a ModestProtocolType enum parameter.
745 * src/gnome/modest-account-assistant.c:
746 * src/gnome/modest-store-widget.c:
747 * src/gnome/modest-store-widget.h:
748 * src/gnome/modest-transport-widget.c:
749 * src/gnome/modest-transport-widget.h:
750 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
751 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
752 * src/maemo/easysetup/modest-easysetup-wizard.c:
753 * src/maemo/modest-account-settings-dialog.c:
754 * src/maemo/modest-account-settings-dialog.h:
755 * src/maemo/modest-store-widget.c:
756 * src/maemo/modest-store-widget.h:
757 * src/maemo/modest-transport-widget.c:
758 * src/maemo/modest-transport-widget.h:
759 * src/modest-account-mgr-helpers.c:
760 * src/modest-account-mgr-helpers.h:
761 * src/modest-account-mgr.c:
762 * src/modest-account-mgr.h:
763 * src/modest-tny-account.c:
764 * src/modest-tny-folder.c:
765 * src/widgets/modest-account-view.c:
766 * src/widgets/modest-retrieve-combo-box.c:
767 * src/widgets/modest-retrieve-combo-box.h:
768 * src/widgets/modest-secureauth-combo-box.c:
769 * src/widgets/modest-serversecurity-combo-box.c:
770 * src/widgets/modest-serversecurity-combo-box.h:
771 * tests/check_account-mgr.c:
772 Use the specific functions, and use the re-renamed enum values for GNOME too.
774 2007-05-15 Murray Cumming <murrayc@murrayc.com>
777 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
778 so we can get the second based on the first.
780 * src/maemo/modest-account-settings-dialog.h:
781 * src/maemo/modest-account-settings-dialog.c:
782 Added get_supported_secure_authentication_methods(), though it is mostly
783 commented-out for now until the necessary API is committed to tinymail.
784 (modest_account_settings_dialog_set_account_name),
785 (save_configuration): Request the supported authentication methods from the
786 server, so we can choose a working method.
788 * src/modest-tny-account-store.h:
789 * src/modest-tny-account-store.c:
790 (modest_tny_account_store_get_session): Rename from
791 tny_account_store_get_session().
793 2007-05-14 Murray Cumming <murrayc@murrayc.com>
795 * src/modest-protocol-info.h: Split the ModestProtocol enum
796 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
797 There was no need to have these unrelated values in one enum.
799 * src/: many files: Adapted to changed enum. This makes the code a bit
800 clearer, and the compiler could catch some errors.
802 2007-05-14 Murray Cumming <murrayc@murrayc.com>
804 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
805 Show the detailed internal camel error message when an error happens
806 during the configuration, so that our testers can give us more clues.
807 For instance, in projects.maemo.org bug NB#56910 .
809 2007-05-14 Murray Cumming <murrayc@murrayc.com>
811 * src/modest-tny-account.c:
812 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
813 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
815 2007-05-14 Murray Cumming <murrayc@murrayc.com>
817 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
818 * src/maemo/modest-account-settings-dialog.c:
819 (modest_account_settings_dialog_set_account_name),
820 (save_configuration): For the incoming secure authentication checkbox,
821 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
822 the UI specification. PLAIN does not seem to be supported for most IMAP
823 servers anyway, and I am not sure what it would mean.
824 However, we probably need to discover which of the secure-authentication
825 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
826 * src/modest-account-mgr-helpers.c:
827 (modest_account_mgr_get_server_account_data):
829 * src/modest-tny-account.c:
830 (modest_tny_account_new_from_server_account):
831 Use tny_account_set_mech() to set secure-authentication methods,
832 with some special-casing for IMAP, based on my observations of how
835 * src/modest-account-mgr-helpers.h:
836 * src/modest-account-mgr.c:
837 * src/modest-defs.h: Comment that the URI is only used for local folders.
839 2007-05-11 Murray Cumming <murrayc@murrayc.com>
841 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
842 parameter const, just to be neat.
843 * src/modest-text-utils.c: (modest_text_utils_inline):
844 End g_strconcat() with NULL, as its documentation says. This is almost
845 certainly the cause of my crash at startup on the device. Interestingly,
846 valgrind doesn't tell us about these errors.
848 2007-05-11 Murray Cumming <murrayc@murrayc.com>
850 * scripts/build-packages: Added more precise comments about how to use
851 this script, though I still get this error:
852 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
853 error building tinymail
855 2007-05-11 Murray Cumming <murrayc@murrayc.com>
857 * src/maemo/modest-main-window.c: (on_account_update):
858 Very slight cleanup, hoping to make it simpler to discover what causes
859 a crash here sometimes.
861 * src/modest-tny-account.c:
862 (modest_tny_account_new_from_server_account): Set the port. Added
863 comments about the options and a TODO comment because I need to find out
864 how to specify the secure authentication method.
866 2007-05-11 Marcus Bauer <marcusb@openismus.com>
868 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
869 changed CFlags paths form modest to libmodest
871 2007-05-10 Murray Cumming <murrayc@murrayc.com>
873 * src/modest-account-mgr-helpers.c:
874 (modest_account_mgr_get_server_account_data),
875 (modest_account_mgr_free_server_account_data):
876 * src/modest-account-mgr-helpers.h:
877 * src/modest-account-mgr.c:
878 (modest_account_mgr_add_server_account):
880 * src/modest-tny-account.c:
881 (modest_tny_account_new_from_server_account):
882 Determine the options for tny_camel_account_add_option() here,
883 based on the settings, rather than storing them directly in gconf.
885 2007-05-10 Murray Cumming <murrayc@murrayc.com>
887 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
888 Show a more friendly error dialog now that we expect (from the tinymail
889 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
891 2007-05-10 Murray Cumming <murrayc@murrayc.com>
893 * src/maemo/modest-main-window.c: (on_account_update): Check that
894 account_name is not NULL, to prevent a crash at startup that I am
895 seeing on the N800. I do wonder why it is NULL.
897 * src/maemo/easysetup/modest-easysetup-wizard.c:
898 (create_page_user_details):
899 * src/maemo/modest-account-settings-dialog.c:
900 (create_page_user_details), (create_page_outgoing):
901 * src/maemo/modest-connection-specific-smtp-edit-window.c:
902 (modest_connection_specific_smtp_edit_window_init):
903 * src/modest-ui-actions.c:
904 (modest_ui_actions_on_password_requested):
905 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
906 might do something useful with the on-screen keyboard.
908 2007-05-10 Murray Cumming <murrayc@murrayc.com>
910 * src/maemo/modest-main-window.c: (on_account_update):
911 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
912 NULL, to avoid lots of warnings. However, it probably should not be NULL.
914 2007-05-09 Murray Cumming <murrayc@murrayc.com>
916 * src/modest-tny-account-store.c: (on_account_changed):
917 Correct the signature of this signal handler.
919 2007-05-09 Murray Cumming <murrayc@murrayc.com>
921 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
922 Show a HildonNote instead of a GtkDialog for Maemo.
924 2007-05-09 Murray Cumming <murrayc@murrayc.com>
926 * src/widgets/modest-account-view.h:
927 * src/widgets/modest-account-view.c: (on_account_changed),
928 (on_account_removed). Added a boolean flag, set/unset by
929 modest_account_view_block_conf_updates(),
930 modest_account_view_unblock_conf_updates() to prevent unnecessary
931 updates, but this is not very useful because the gconf notifications are
932 so delays (maybe only on Maemo Bora).
933 So auto-updating is turned off, and these functions do an explicit
934 update when necessary.
935 However, something else is still doing too much work when adding/removing
936 accounts, probably in another part of the application.
938 * src/maemo/modest-account-view-window.c:
939 (on_delete_button_clicked), (on_edit_button_clicked),
940 (on_new_button_clicked): Use the new functions.
942 2007-05-09 Murray Cumming <murrayc@murrayc.com>
944 * src/modest-account-mgr-helpers.c:
945 (modest_account_mgr_set_first_account_as_default):
946 Sort the list of names alphabetically-by-title, so we choose the first one
948 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
949 alphabetically by the title.
951 This fixes projects.maemo.org bug NB#56418 .
953 * src/modest-account-mgr-priv.c:
954 (_modest_account_mgr_account_from_key):
955 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
956 avoid a valgrind error, and possible random behaviour.
958 2007-05-09 Murray Cumming <murrayc@murrayc.com>
960 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
961 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
962 tinymail documentation to say that this can be expected.
963 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
964 pretty, and should not happen, but I would prefer to know when it does.
966 2007-05-09 Murray Cumming <murrayc@murrayc.com>
968 * configure.ac: When using the older hildon version, probably on Bora,
969 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
971 * src/widgets/modest-attachment-view.c:
972 (modest_attachment_view_set_part_default): Initialize variables, to fix the
975 2007-05-09 Marcus Bauer <marcusb@openismus.com>
977 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
978 Implemented the prototype. Can be tested with
979 tests/dbus_api/test_open_message:
981 2007-05-08 Murray Cumming <murrayc@murrayc.com>
983 * src/modest-tny-account-store.c:
984 (modest_tny_account_store_instance_init), (get_password):
985 * src/modest-ui-actions.c:
986 (modest_ui_actions_on_password_requested):
987 Do not store the password in gconf, because this function is called
988 for non-remembered passwords. Actually use the cached (in the hash map)
989 password instead of releasing it.
990 The password will now not be remembered if it is asked via the protected
991 password dialog, as per the UI spec.
993 2007-05-08 Murray Cumming <murrayc@murrayc.com>
996 * src/modest-account-mgr-helpers.h:
997 * src/modest-account-mgr-helpers.c:
998 Added modest_server_account_get_username_has_succeeded(),
999 modest_server_account_set_username_has_succeeded().
1000 (modest_server_account_set_username),
1001 Reset the has-succeeded flag if the username changes.
1003 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1004 * src/maemo/modest-connection-specific-smtp-window.c:
1005 (modest_connection_specific_smtp_window_save_server_accounts):
1006 Use modest_server_account_set_username() instead of using
1007 modest_conf_set_string() directly, so that the has-succeeded flag is always
1010 * src/modest-ui-actions.c:
1011 (modest_ui_actions_on_password_requested): Dim the username entry if
1012 the username has ever worked, as per the UI spec.
1014 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1016 * src/modest-tny-account-store.c: (get_password):
1017 * src/modest-ui-actions.c:
1018 (modest_ui_actions_on_password_requested):
1019 Allow the username to be changed too, though there is more work to
1020 be done on exactly how this behaves.
1022 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1024 * src/modest-account-mgr-helpers.h:
1025 * src/modest-account-mgr-helpers.c:
1026 Added modest_account_mgr_get_display_name(),
1027 modest_server_account_get_username(),
1028 modest_server_account_set_username(),
1029 modest_server_account_set_password(),
1030 modest_server_account_get_hostname() functions so we do not need to
1031 use the conf API directly.
1033 * src/maemo/modest-main-window.c: (connect_signals):
1034 Actually connect ot the ModestAccountStore::request-password signal,
1035 so that we show the dialog when the password is requested by Tinymail,
1036 for isntance if it is empty.
1038 * src/modest-marshal.list:
1039 * src/modest-tny-account-store.c:
1040 (modest_tny_account_store_class_init), (get_password),
1041 (modest_tny_account_store_alert):
1042 * src/modest-tny-account-store.h:
1043 * src/modest-ui-actions.h:
1044 * src/modest-ui-actions.c:
1045 (modest_ui_actions_on_password_requested):
1046 Change the signal parameters, so it is obvious that we are providing
1047 the non human-readable server name, and receiving both the username
1048 and password, though changing of the username is not yet implemented.
1049 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1050 for the GNOME version.
1052 This should fix the projects.maemo.org bug NB#56209, though it does not
1053 work on Bora, because the gconf_client_get() for the password fails
1054 immediately after we save it with gconf_client_set().
1056 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1059 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1060 caused an undefined symbol error:
1061 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1063 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1065 * src/modest-tny-account-store.c:
1066 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1067 using a GError instead of a string message, so we can translate it in
1070 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1072 * src/maemo/modest-address-book.c:
1073 (modest_address_book_check_names):
1074 * src/maemo/modest-msg-view-window.c:
1075 (modest_msg_view_window_clipboard_owner_change):
1076 * src/modest-init.c: (modest_init_init_ui):
1077 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1078 (update_folders_cb), (modest_mail_operation_update_account):
1079 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1080 (modest_ui_actions_on_msg_attachment_clicked),
1081 (modest_ui_actions_on_msg_recpt_activated):
1082 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1083 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1084 (modest_msg_view_search_next):
1085 * src/widgets/modest-recpt-editor.c:
1086 (modest_recpt_editor_on_button_release_event),
1087 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1088 g_message(). At this point we should only be seeing interesting errors on
1089 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1091 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1093 (modest_wizard_dialog_force_title_update):
1094 * src/maemo/easysetup/modest-wizard-dialog.h:
1095 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1096 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1097 can update the title when appropriate. Otherwise the title is wrong if the
1098 pages are added after adding the notebook to the dialog.
1099 This must be a problem in HildonWizardDialog too.
1100 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1102 * src/maemo/easysetup/modest-easysetup-wizard.c:
1103 (create_subsequent_customsetup_pages),
1104 (create_subsequent_easysetup_pages):
1105 Call modest_wizard_dialog_force_title_update() so that the title is
1106 correct even with GTK+ < 2.10.
1107 This fixes projects.maemo.org bug NB#56145 .
1109 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1111 * src/maemo/modest-platform.c:
1112 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1113 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1116 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1118 * src/widgets/modest-window.h:
1119 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1120 and modest_window_save_state(), which invokes it.
1122 * src/widgets/modest-window-mgr.h:
1123 * src/widgets/modest-window-mgr.c:
1124 Added modest_window_mgr_save_state_for_all_windows(), which calls
1125 the save_state vfunc on all registered windows, if implemented.
1127 * src/gnome/modest-msg-edit-window.c:
1128 * src/gnome/modest-msg-view-window.c:
1129 * src/maemo/modest-msg-edit-window.c:
1130 * src/maemo/modest-msg-view-window.c:
1131 * src/maemo/modest-main-window.c:
1132 Specify the existing save_settings functions as implementations of
1133 ModestWindow::save_state_func().
1135 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1136 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1137 enabling hibernation, for instance.
1139 We may need to do the same thing for restoring settings.
1142 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1144 * src/widgets/modest-window-mgr.c:
1145 * src/widgets/modest-window-mgr.h:
1146 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1147 modest_window_mgr_get_hibernation_is_prevented().
1149 * src/maemo/modest-main-window.c:
1150 (on_hildon_program_is_topmost_notify): Prevent hibernation
1151 (possible when the application goes to the background in the WM),
1152 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1154 * src/maemo/easysetup/modest-easysetup-wizard.c:
1155 (modest_easysetup_wizard_dialog_init):
1156 * src/maemo/modest-account-settings-dialog.c:
1157 (modest_account_settings_dialog_init):
1158 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1159 (modest_connection_specific_smtp_edit_window_init):
1160 * src/maemo/modest-connection-specific-smtp-window.c:
1161 (modest_connection_specific_smtp_window_init):
1162 * src/maemo/modest-signature-editor-dialog.c:
1163 (modest_signature_editor_dialog_init):
1164 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1165 prevent hibernation while any of these account settings dialogs are open.
1167 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1169 * src/maemo/Makefile.am:
1170 * src/maemo/modest-osso-state-saving.c:
1171 * src/maemo/modest-osso-state-saving.h: Added
1172 modest_osso_load_state() and modest_osso_save_state() though they do
1173 nothing now. They should iterate through all the open windows and load/save
1175 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1176 save state when closing.
1178 * src/maemo/modest-main-window.c:
1179 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1180 Add a notification handler for the HildonProgram::is-topmost property,
1181 so we can allow hibernation when the application goes into the background.
1182 But we still need to detect when the accounts setup windows are open so
1183 we can stop hibernation when they are open.
1184 To do this, I also added the main window the HildonProgram. This might have
1185 other side-effects/benefits, and should maybe be done for other windows.
1187 * src/maemo/modest-osso-autosave-callbacks.h:
1188 * src/maemo/modest-osso-autosave-callbacks.c:
1189 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1190 though it does not do anything yet, and we might never need this to do
1191 anything. For instance, we already save drafts.
1193 * src/maemo/modest-platform.c: (modest_platform_init):
1194 Specify the libosso auto-save callback.
1196 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1198 * src/maemo/modest-platform.c:
1199 (modest_platform_set_update_interval):
1200 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1201 aparently stays valid between application instances, so we can use this
1202 to remove and reset it later. According to a maemo-developers email from
1205 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1207 * configure.ac: Depend on libalarm for Maemo.
1209 * src/dbus_api/modest-dbus-api.h:
1210 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1211 (on_send_receive), (modest_dbus_req_handler):
1212 Handle a SEND_RECEIVE D-Bus method.
1214 * libmodest-dbus-client/libmodest-dbus-client.c:
1215 (libmodest_dbus_client_send_and_receive):
1216 * libmodest-dbus-client/libmodest-dbus-client.h:
1217 Add C convenience functions for calling the new D-Bus method.
1219 * src/modest-platform.h:
1220 * src/gnome/modest-platform.c:
1221 * src/maemo/modest-platform.c:
1222 Added modest_platform_set_update_interval(), which uses the
1223 alarmd API on Maemo.
1224 (modest_platform_init),
1225 Call modest_platform_set_update_interval(), using a hard-coded
1226 interval for now (until the global settings dialog is implemented),
1227 though I am not sure that this makes sense yet.
1229 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1231 * src/dbus_api/modest-dbus-callbacks.c:
1232 (modest_osso_cb_hw_state_handler):
1233 * src/dbus_api/modest-dbus-callbacks.h:
1234 * src/maemo/modest-platform.c: (modest_platform_init):
1235 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1236 in case this has some effect on the ability for Maemo to ping the
1239 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1241 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1242 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1243 warning. It is probably a logic error, but I need to fix the build.
1245 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1247 * src/modest-account-mgr.h:
1248 * src/modest-account-mgr.c:
1249 (modest_account_mgr_account_names): Add a gboolean enabled_only
1250 parameter, so we can get lists of onlt the enabled accounts.
1252 (modest_account_mgr_add_account),,
1253 (modest_account_mgr_account_with_display_name_exists):
1254 * src/maemo/modest-msg-edit-window.c: (get_transports):
1255 * src/modest-account-mgr-helpers.c:
1256 (modest_account_mgr_set_first_account_as_default):
1257 * src/modest-init.c: (init_default_account_maybe):
1258 * src/modest-tny-account-store.c: (get_accounts):
1259 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1260 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1261 * tests/check_account-mgr.c: (START_TEST):
1262 Provide the extra parameter, as appropriate.
1264 * src/widgets/modest-account-view.c: (update_account_view):
1265 Do not show disabled accounts (meaning that there is no way to
1266 enable/disable accounts in the UI (the feature is not in our UI
1267 specification), so we can use this internally only to mark unfinished
1268 or temporary account data.
1270 * src/maemo/easysetup/modest-easysetup-wizard.c:
1271 (create_account): Add boolean enable parameter, so we can specify FALSE
1272 to create the temporary account.
1273 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1274 (on_before_next): When finishing, when there is a temporary account, just
1276 Also, use a timeout to delay the showing of the dialog until gconf is likely
1277 to return correct information, due to a maemo gconf bug that is fixed in
1278 osso 1.1, but not yet in Bora.
1279 However, the dialog stays on screen after it is destroyed.
1281 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1282 for invalid data when cancelling. Use a hildon note instead of a dialog
1283 to complain about invalid data. Do not show the account-saved note if the
1284 account is disabled (a temporary account that will not really be saved for use
1287 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1289 * src/modest-account-mgr-helpers.h:
1290 * src/modest-account-mgr-helpers.c:
1291 Added modest_account_mgr_unset_default_account(),
1292 Added modest_account_mgr_set_first_account_as_default().
1294 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1295 If it was the default account, unset the default account name.
1297 * src/maemo/modest-account-view-window.c:
1298 (on_delete_button_clicked): If it was the default account,
1299 set the first remaining account as the default instead.
1301 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1302 a NULL account or a NULL default account, to prevent a crash. This should
1303 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1306 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1308 * src/widgets/modest-recpt-editor.c:
1309 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1310 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1311 TODO comment for this. This fixes the build.
1313 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1314 be the best place for it. This will in future update all auto-update accounts,
1315 rather than just the current/default account, when that gconf key exists.
1316 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1317 if there are no accounts, before calling do_send_receive().
1318 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1320 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1321 * src/maemo/modest-main-window-ui.h:
1322 * src/maemo/modest-main-window.c: (on_connection_changed),
1323 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1324 directly, becaue the signal handler does more.
1326 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1328 * src/modest-account-mgr-helpers.c:
1329 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1330 for the case that the account does not exist.
1332 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1333 (equivalent to the modest account name) rather than the tinymail account name
1334 (equivalent to the modest account title - human readable) to get the account data.
1335 Check for null account data to prevent the crash, and add a TODO comment saying that
1336 this needs fixing because it is using the server account name instead of the account name.
1338 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1340 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1341 * src/maemo/modest-account-settings-dialog.c: (show_error),
1343 Use hildon_note_new_information() for informative and error messages,
1344 which seems to be expected for Maemo applications (no documentation that I know of
1345 says this). I am surprised that there is no distinction between info and error
1348 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1350 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1351 it is easy to find where this is used.
1353 * src/maemo/easysetup/modest-easysetup-wizard.c:
1354 (create_page_welcome), (create_page_account_details),
1355 (create_page_user_details), (create_page_complete_easysetup),
1356 (create_page_custom_incoming), (create_page_custom_outgoing),
1357 (create_page_complete_custom):
1358 * src/maemo/modest-account-settings-dialog.c:
1359 (create_page_account_details), (create_page_user_details),
1360 (create_page_incoming), (create_page_outgoing):
1361 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1362 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1363 (modest_connection_specific_smtp_edit_window_init):
1364 * src/maemo/modest-connection-specific-smtp-window.c:
1365 (modest_connection_specific_smtp_window_init):
1366 * src/maemo/modest-signature-editor-dialog.c:
1367 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1368 and scrolling policy as per the Email Application Layout Guide, if I have
1371 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1373 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1374 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1375 which were empty, because these vfuncs have been removed from TnyAccountStore.
1376 This fixes the build.
1378 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1380 * src/maemo/modest-main-window.c:
1381 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1382 showing/hiding it. Added TODO because it probably should not be NULL.
1383 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1384 because unnecessary g_warnings() make degugging difficult.
1386 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1388 * src/maemo/modest-msg-edit-window.c:
1389 (modest_msg_edit_window_select_color),
1390 (modest_msg_edit_window_select_background_color): 2 const corrections and
1391 moving 2 #endifs before closing brackets, to fix the build.
1393 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1395 * src/maemo/easysetup/modest-easysetup-wizard.h:
1396 * src/maemo/easysetup/modest-easysetup-wizard.c:
1397 (modest_easysetup_wizard_dialog_finalize),
1398 (on_button_edit_advanced_settings), (create_page_complete_custom),
1399 (on_response), (create_account):
1400 Implement the Advanced Settings edit button, by saving the account information,
1401 for the Advanded Settings dialog to use directly from gconf, and removing it
1402 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1403 Bug #5533 in the projects.maemo.org bugzilla.
1405 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1407 * src/maemo/modest-msg-view-window.c:
1408 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1409 when opening a message window.
1411 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1413 * src/maemo/easysetup/modest-easysetup-wizard.c:
1414 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1417 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1418 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1419 gconf settings. I probably added more checks than necessary, but that is safer.
1421 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1422 variable to fix the build, but this seems to be used when it is still NULL.
1424 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1426 * src/modest-platform.h:
1427 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1428 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1429 * src/modest-main.c: Implement this function so we can avoid using
1430 maemo-specific API from cross-platform code.
1432 * src/modest-tny-account-store.c:
1433 (get_smtp_specific_transport_account_for_open_connection):
1434 * src/modest-ui-actions.c: (check_for_connection),
1435 (modest_ui_actions_on_item_not_found):
1436 Use modest_platform_connect_and_wait() and put #idefs around other
1437 maemo-specific code, because only maemo currently has a way to
1438 identify connection names.
1440 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1442 * src/modest-tny-account-store.h:
1443 * src/modest-tny-account-store.c:
1444 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1445 the connection-specific SMTP server settings in the configuration.
1447 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1449 * src/maemo/modest-main-window.c: (on_connection_changed),
1451 * src/modest-main.c: (main), (start_ui), (send_mail):
1452 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1453 that is what is intended.
1455 * src/modest-ui-actions.c: (action_send), (action_receive),
1456 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1457 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1458 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1459 SMTP server is used when it is specified.
1461 (modest_ui_actions_on_send_receive):
1462 Check that a connection is open before proceeding.
1463 Receive and then send, instead of vice-versa, as per the specification.
1465 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1467 * src/modest-mail-operation.c:
1468 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1469 though I guess it should be something other than NULL.
1471 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1473 * src/maemo/easysetup/modest-easysetup-wizard.c:
1474 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1475 combo twice, to avoid an g_warning and to make it visible again.
1476 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1477 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1478 (already intended) dereference when detaching, because we then recreate the menu.
1479 But I am not sure why the warning was happening, and it is possible that this is a memory
1482 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1484 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1485 and uri_parse_mailto() utility functions.
1486 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1488 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1490 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1492 * src/dbus_api/modest-dbus-api.h:
1493 * src/dbus_api/modest-dbus-callbacks.c:
1494 Use an idle callback to execute the modest code in the application's own thread.
1495 Remove the helloworld example method.
1496 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1497 parsed, and the open-message method is not implemented because this is not yet implemented in
1499 * libmodest-dbus-client/libmodest-dbus-client.c:
1500 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1501 (libmodest_dbus_client_open_message):
1502 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1504 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1505 body without crashing.
1507 * tests/dbus_api/Makefile.am:
1508 * tests/dbus_api/test_mail_to.c:
1509 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1511 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1513 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1514 Added file to fix the build. Sorry.
1516 * src/dbus_api/Makefile.am:
1517 * src/dbus_api/modest-dbus-api.h:
1518 * src/dbus_api/modest-dbus-callbacks.h:
1519 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1520 (modest_dbus_req_handler):
1521 Put constants in a separate header so it can be reused by the
1522 client library, without duplication
1524 * libmodest-dbus-client/Makefile.am:
1525 * libmodest-dbus-client/libmodest-dbus-client.c:
1526 (libmodest_dbus_client_call_helloworld),
1527 (libmodfest_dbus_client_send_mail),
1528 (libmodfest_dbus_client_mailto),
1529 (libmodfest_dbus_client_open_message):
1530 * libmodest-dbus-client/libmodest-dbus-client.h:
1531 (Partly) Implement a send_mail D-Bus method.
1533 * tests/dbus_api/Makefile.am:
1534 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1535 the send_email D-Bus method.
1537 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1541 * libmodest-dbus-client/Makefile.am:
1542 * libmodest-dbus-client/libmodest-dbus-client.c:
1543 * libmodest-dbus-client/libmodest-dbus-client.h:
1544 * tests/dbus_api/Makefile.am:
1545 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1546 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1548 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1550 * src/maemo/easysetup/modest-easysetup-wizard.c:
1551 (create_page_account_details):
1552 * src/maemo/modest-account-settings-dialog.c:
1553 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1554 widgets, because this might not be the default in future versions of the Maemo GTK+.
1555 However, I can not not get capitalization to work even in a simple test case.
1557 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1559 * src/maemo/easysetup/modest-easysetup-wizard.c:
1560 (create_page_custom_incoming), (create_page_custom_outgoing):
1561 * src/maemo/modest-account-settings-dialog.c:
1562 (create_page_account_details), (create_page_incoming),
1563 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1564 instead of using gtk_check_button_with_label(), so they are aligned like the other
1565 widgets, as per the UI spec.
1567 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1569 * src/maemo/easysetup/modest-easysetup-wizard.c:
1570 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1571 * src/widgets/modest-validating-entry.c:
1572 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1573 Modest prefix instead of an EasySetup prefix.
1575 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1577 * src/widgets/modest-validating-entry.h:
1578 * src/widgets/modest-validating-entry.c: (on_insert_text),
1579 Added easysetup_validating_entry_set_max_func(), used to set a callback
1580 to call when the max number of characters is reached. GtkEntry has a max-length
1581 already but is silent about it.
1583 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1584 (create_page_account_details), (create_page_user_details),
1586 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1587 (create_page_account_details), (create_page_user_details),
1588 (create_page_outgoing):
1589 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1590 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1591 the UI spec, when the user tries to enter more than the max number of characters.
1593 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1595 * src/maemo/easysetup/modest-easysetup-wizard.c:
1596 (create_page_user_details), (create_page_custom_incoming),
1597 (create_page_custom_outgoing):
1598 * src/maemo/modest-account-settings-dialog.c:
1599 (create_page_user_details), (create_page_incoming),
1600 (create_page_outgoing):
1601 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1602 (modest_connection_specific_smtp_edit_window_init):
1603 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1604 not appropriate. Bad Maemo-specific defaults!.
1606 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1608 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1609 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1610 (modest_signature_editor_dialog_set_settings):
1611 Disable the label and textview when the checkbox is disabled, and use the
1612 specified (UI spec) default signature text.
1614 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1616 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1617 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1619 * src/modest-defs.h:
1620 * src/modest-account-mgr-helpers.h:
1621 * src/modest-account-mgr-helpers.c:
1622 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1624 * src/maemo/Makefile.am:
1625 * src/maemo/modest-signature-editor-dialog.c:
1626 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1629 * src/maemo/modest-account-settings-dialog.h:
1630 * src/maemo/modest-account-settings-dialog.c:
1631 (modest_account_settings_dialog_finalize), (on_button_signature),
1632 (save_configuration): Use the new dialog when the Edit button is pressed, and
1633 save the changes if necessary, as per the UI spec.
1635 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1637 * src/maemo/Makefile.am:
1638 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1639 based on maemo-develoers email from Dirk.
1641 * src/maemo/easysetup/modest-easysetup-wizard.c:
1642 (create_page_welcome), (create_page_account_details),
1643 (create_page_user_details), (create_page_complete_easysetup),
1644 (create_page_custom_incoming), (create_page_custom_outgoing),
1645 (create_page_complete_custom),
1646 (modest_easysetup_wizard_dialog_init):
1647 * src/maemo/modest-account-settings-dialog.c:
1648 (create_page_account_details), (create_page_user_details),
1649 (create_page_incoming), (create_page_outgoing),
1650 (modest_account_settings_dialog_init):
1651 * src/maemo/modest-connection-specific-smtp-window.c:
1652 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1654 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1656 * src/maemo/easysetup/modest-easysetup-wizard.c:
1657 (create_page_account_details), (create_page_custom_outgoing),
1658 (create_page_complete_custom):
1659 * src/maemo/modest-account-settings-dialog.c:
1660 (create_page_user_details), (create_page_incoming),
1661 (create_page_outgoing):
1662 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1663 (modest_connection_specific_smtp_edit_window_init):
1664 Use the correct (UI spec) port min/max, and use horizontal separators,
1667 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1669 * src/maemo/easysetup/modest-easysetup-wizard.c:
1670 (set_default_custom_servernames):
1671 * src/maemo/modest-account-settings-dialog.c:
1672 (create_page_incoming), (on_combo_outgoing_security_changed),
1673 (on_combo_incoming_security_changed), (create_page_outgoing),
1674 (modest_account_settings_dialog_set_account_name),
1675 (save_configuration):
1676 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1677 (on_combo_security_changed),
1678 (modest_connection_specific_smtp_edit_window_init),
1679 (modest_connection_specific_smtp_edit_window_set_connection),
1680 (modest_connection_specific_smtp_edit_window_get_settings):
1681 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1684 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1687 * src/maemo/easysetup/modest-easysetup-wizard.c:
1688 (create_page_custom_outgoing), (create_page_complete_custom):
1689 * src/maemo/modest-account-settings-dialog.c:
1690 (create_page_user_details), (create_page_outgoing):
1691 * src/maemo/modest-account-view-window.c: (button_box_new):
1692 Use changed logical IDs as per the most recent UI spec:
1693 mcen_bd_emailsetup_edit -> mcen_bd_edit
1694 mcen_bd_emailsetup_delete -> mcen_bd_delete
1695 mcen_bd_emailsetup_close -> mcen_bd_close
1697 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1701 * src/dbus_api/Makefile.am:
1702 * src/dbus_api/modest-dbus-callbacks.c:
1703 * src/dbus_api/modest-dbus-callbacks.h:
1704 * src/maemo/modest-platform.c: (modest_platform_init):
1705 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1707 * tests/Makefile.am:
1708 * tests/dbus_api/Makefile.am:
1709 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1711 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1713 * src/maemo/modest-account-settings-dialog.c:
1714 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1715 Removed unnecessary includes.
1717 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1719 * src/maemo/easysetup/modest-easysetup-wizard.c:
1720 * src/maemo/modest-account-settings-dialog.c:
1721 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1722 * src/widgets/Makefile.am:
1723 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1724 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1725 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1726 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1727 * src/widgets/modest-secureauth-combo-box.c:
1728 * src/widgets/modest-secureauth-combo-box.h:
1729 * src/widgets/modest-serversecurity-combo-box.c:
1730 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1731 made the GObject names more consistent with the rest of the Modest code.
1733 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1735 * src/maemo/easysetup/Makefile.am:
1736 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1737 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1738 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1739 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1740 * src/maemo/easysetup/modest-easysetup-wizard.c:
1741 * src/maemo/easysetup/modest-validating-entry.c:
1742 * src/maemo/easysetup/modest-validating-entry.h:
1743 * src/maemo/modest-account-settings-dialog.c:
1744 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1745 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1746 widgets/ because they are used outside of easysetup too. After checking in,
1747 svn will allow me to rename them too.
1749 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1751 * src/gnome/modest-msg-edit-window.c:
1752 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1753 linker error, to fix the build on the GNOME platform.
1754 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1755 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1756 ifdefed out to avoid a warning.
1758 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1760 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1761 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1762 some alternative for GTK+ 2.6.
1764 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1766 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1768 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1769 specified for EmailAccountsDialog in UI spec.
1771 * src/maemo/easysetup/modest-easysetup-wizard.c:
1772 * src/maemo/easysetup/modest-easysetup-wizard.h:
1773 * src/maemo/modest-account-settings-dialog.c:
1774 * src/maemo/modest-account-settings-dialog.h:
1775 Reuse a member window widget for the connection-specific SMTP server accounts,
1776 so we can tell it to create/save the accounts only if we actually save changes.
1778 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1779 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1780 (modest_connection_specific_smtp_edit_window_get_settings):
1781 Return a struct instance for temporarily remembering the entered data.
1783 * src/maemo/modest-connection-specific-smtp-window.h:
1784 * src/maemo/modest-connection-specific-smtp-window.c:
1785 (modest_connection_specific_smtp_window_finalize),
1786 (modest_connection_specific_smtp_window_fill_with_connections),
1788 (modest_connection_specific_smtp_window_save_server_accounts),
1789 (update_model_server_names): Do not actually save data until asked,
1790 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1792 (on_selection_changed),
1793 (modest_connection_specific_smtp_window_init): Disable the edit
1794 button when nothing is selected.
1796 * src/modest-account-mgr-helpers.c:
1797 * src/modest-account-mgr-helpers.h:
1798 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1801 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1803 * src/modest-account-mgr-helpers.h:
1804 * src/modest-account-mgr-helpers.c:
1805 (modest_account_mgr_get_unused_account_name),
1806 (modest_account_mgr_get_unused_account_display_name): Added these
1807 utility functions, to avoid code duplication.
1809 * src/maemo/easysetup/modest-easysetup-wizard.c:
1810 (create_page_account_details), (create_account):
1811 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1812 (on_combo_security_changed),
1813 (modest_connection_specific_smtp_edit_window_init),
1814 (modest_connection_specific_smtp_edit_window_save_settings):
1815 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1816 * src/maemo/modest-connection-specific-smtp-window.c:
1817 (modest_connection_specific_smtp_window_finalize),
1818 (modest_connection_specific_smtp_window_fill_with_connections),
1819 (on_button_edit), (modest_connection_specific_smtp_window_init):
1820 * src/maemo/modest-connection-specific-smtp-window.h:
1821 Implementing saving of connection-specific server accounts.
1823 But I need to refactor this so we can save the data for each
1824 possible connection-specific account and only actually create the server accounts
1825 when the easysetup finished, or the OK button is pressed on the account settings
1828 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1830 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1831 (on_combo_security_changed):
1832 (modest_connection_specific_smtp_edit_window_init):
1833 Auto-fill the port number as in the account settings.
1835 (modest_connection_specific_smtp_edit_window_set_connection):
1836 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1837 * src/maemo/modest-connection-specific-smtp-window.c:
1838 (fill_with_connections), (on_button_edit),
1839 (modest_connection_specific_smtp_window_init):
1840 Turn the edit window into a dialog to simplify the code, and
1841 set a WM hint as in a GtkDialog, because only a popup can be on top of
1842 another window in Maemo, and popups usually have no WM decoration.
1844 * src/modest-defs.h:
1845 * src/modest-account-mgr-helpers.c:
1846 (modest_account_mgr_set_connection_specific_smtp),
1847 (modest_account_mgr_remove_connection_specific_smtp),
1848 (modest_account_mgr_get_connection_specific_smtp):
1849 * src/modest-account-mgr-helpers.h: Some functions to write the
1850 connection-specific SMTP server information. Not yet used.
1853 * src/widgets/modest-folder-view.c: (text_cell_data):
1854 Fix a warning about an uninitialized variable.
1855 (on_configuration_key_changed): Put an #ifdef around the use
1856 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1858 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1860 * src/maemo/modest-account-settings-dialog.h:
1861 * src/maemo/modest-account-settings-dialog.c:
1862 Added connect_for_modified() utility function to mark the new modified boolean.
1864 (create_page_account_details), (create_page_user_details),
1865 (create_page_incoming), (create_page_outgoing), (on_response),
1866 (modest_account_settings_dialog_init),
1867 (modest_account_settings_dialog_set_account_name):
1868 Only warn about unsaved changes when there are actually unsaved changes.
1870 * src/modest-account-mgr-helpers.c:
1871 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1872 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1873 to get the data from there in future.
1875 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1877 * src/modest-defs.h:
1879 * src/modest-account-mgr-helpers.h:
1880 * src/modest-account-mgr-helpers.c:
1881 Store the security account setting in a single conf key instead of using
1882 the options list, so that the list is left for just the to-be-removed camel hack,
1883 and because gconf_client_set_list() is failing for some reason.
1885 * src/modest-account-mgr.c:
1886 (modest_account_mgr_add_server_account):
1887 * src/maemo/modest-account-settings-dialog.c:
1888 (modest_account_settings_dialog_set_account_name),
1889 (save_configuration): Use the renamed functions.
1892 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1894 * src/widgets/Makefile.am:
1895 * src/widgets/modest-limit-retrieve-combo-box.c:
1896 * src/widgets/modest-limit-retrieve-combo-box.h:
1897 * src/widgets/modest-retrieve-combo-box.c:
1898 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1899 the account settings dialog.
1901 * src/modest-defs.h:
1902 * src/modest-account-mgr-helpers.h:
1903 * src/modest-account-mgr-helpers.c:
1904 (modest_server_account_get_option_secure_auth),
1905 (modest_server_account_set_option_secure_auth):
1906 * src/modest-account-mgr.c:
1907 (modest_account_mgr_add_server_account):
1908 Use the existing AUTH_MECH conf key for the secure-auth setting,
1909 instead of putting it in the list options, because this was actually used already.
1911 * src/maemo/modest-account-settings-dialog.c:
1912 (create_page_account_details),
1913 (modest_account_settings_dialog_set_account_name),
1914 (save_configuration):
1915 * src/maemo/modest-account-settings-dialog.h:
1916 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1917 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1919 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1921 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1922 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1923 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1925 * src/modest-defs.h:
1926 * src/maemo/modest-account-settings-dialog.c:
1927 (create_page_incoming), (on_combo_outgoing_security_changed),
1928 (on_combo_incoming_security_changed), (create_page_outgoing),
1929 (modest_account_settings_dialog_set_account_name),
1930 (save_configuration): Load/Save the port number, and change it when the
1931 security combo changes, to suitable defaults.
1933 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1935 * src/modest-account-mgr.c:
1936 (modest_account_mgr_add_server_account): Set the security and secure-auth
1937 options, and add a comment saying that the other camel-specific options should be
1940 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1942 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1944 * src/modest-tny-account-store.c: (account_list_free),
1945 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1946 cursor->data after unreffing it. But there is some strange stuff there so it might not be
1949 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1951 * src/modest-protocol-info.c:
1952 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1953 is required by our UI spec. Maybe something in our implementation will use this eventually.
1954 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1955 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1956 instead of the previous 0 placeholder.
1958 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1959 secure-auth settings.
1960 * src/modest-account-mgr-helpers.h:
1961 * src/modest-account-mgr-helpers.c:
1962 (modest_server_account_data_get_option_secure_auth),
1963 (modest_server_account_set_option_secure_auth),
1964 (modest_server_account_data_get_option_security),
1965 (modest_server_account_set_option_security): Added this API for getting and setting the security
1966 and secure-auth settings.
1968 * src/maemo/modest-account-settings-dialog.h:
1969 * src/maemo/modest-account-settings-dialog.c:
1970 (modest_account_settings_dialog_finalize), (check_data),
1971 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1972 about changing titles.
1973 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1974 (save_configuration): Save the security and secure-auth settings.
1976 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1977 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1979 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1981 * src/modest-defs.h:
1982 * src/modest-account-mgr.c:
1983 (modest_account_mgr_add_server_account):
1984 Added and used defines for the options key and value pair strings,
1985 that are used so far, though they do not seem to correspond to anything in our
1986 UI specs or ModestProtocol enum.
1988 * src/modest-account-mgr-helpers.h:
1989 * src/modest-account-mgr-helpers.c:
1990 (compare_option_strings_for_name),
1991 (modest_server_account_data_get_option_value),
1992 (modest_server_account_data_get_option_bool),
1993 (modest_account_mgr_get_server_account_option):
1994 Added helper functions for parsing the options GSList.
1996 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1998 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1999 display name is based on the supplied account name.
2000 * src/modest-account-mgr.c:
2001 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2002 with an inefficient, but good-enough, implementation.
2004 * src/maemo/easysetup/modest-easysetup-wizard.c:
2005 (create_page_account_details), (on_before_next), (create_account):
2006 Check for existing display names rather than (non-user-visible) account names, and just
2007 create and set a unique account name at the end.
2009 * src/maemo/modest-account-settings-dialog.c:
2010 (modest_account_settings_dialog_init),
2011 (modest_account_settings_dialog_set_account_name),
2012 (create_page_incoming): Show the display name, instead of the account name.
2013 (on_response): Do some (not all) extra checks, as in the UI spec.
2014 (save_configuration): Save the display name if it was changed.
2016 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2018 * po/en_GB.po: Added needed logical ID and translation.
2019 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2020 (init_view): Made the is-default column clicking work.
2022 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2025 * src/maemo/easysetup/Makefile.am:
2026 * src/maemo/easysetup/modest-easysetup-wizard.c:
2027 (modest_easysetup_wizard_dialog_init):
2028 * src/maemo/easysetup/provider-data-test.keyfile:
2029 * src/maemo/easysetup/provider-data.keyfile:
2030 Moved the provider data file to the new modest-providers-data package and used it from there.
2032 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2034 * src/modest-local-folder-info.c:
2035 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2036 N_() was already used on the static strings, but this just marks it for translation without
2037 using the translation.
2039 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2041 * src/maemo/modest-account-settings-dialog.c:
2042 (create_page_incoming),
2043 (modest_account_settings_dialog_set_account_name):
2044 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2045 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2046 I will do this if nobody else gets there first.
2048 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2050 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2051 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2052 save the security stuff.
2054 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2056 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2057 Set the email address and user fullname, which I now see must be
2060 * src/maemo/modest-account-settings-dialog.h:
2061 * src/maemo/modest-account-settings-dialog.c:
2063 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2064 leave-on-server and authentication.
2065 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2068 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2071 * src/maemo/modest-account-settings-dialog.c:
2072 * src/maemo/modest-account-settings-dialog.h:
2073 Most (but not all) of the widgets are now present as specified by the UI spec.
2074 No changes are yet saved, and some details are not properly shown yet.
2076 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2078 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2080 * src/maemo/Makefile.am:
2081 * src/maemo/modest-account-settings-dialog.c:
2082 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2083 an existing account. Doesn't do much yet.
2085 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2086 Open the accounts settings dialog when Edit is clicked.
2088 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2090 * src/maemo/easysetup/Makefile.am:
2091 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2093 * src/maemo/easysetup/modest-easysetup-wizard.c:
2094 (modest_easysetup_wizard_dialog_init):
2095 Try to get the source directory from the build system,
2096 instead of hard-coding "./" into the source code, when opening our local
2097 copies of the configuration files.
2098 But this still fails when opening the wizard from the Accounts window,
2099 maybe because the working directory seems to change at runtime.
2100 So the wizard will fail the second time unless you copy the files into their
2101 proper locations - see the stdout warnings for the paths.
2103 (create_page_account_details),(on_before_next):
2104 Check for existing non-server accounts instead of server accounts,
2105 so the default account name is useful again, and to prevent trying to
2108 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2109 Show the wizard when New is clicked.
2111 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2112 (init_view): Show the column headers, and show the columns that are
2113 specified in the UI specs. However, something in Maemo's GTK+ prevents
2114 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2115 change the default account. This is despite unsetting the special properties.
2117 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2119 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2120 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2121 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2122 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2123 to make that clearer.
2124 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2126 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2128 * src/maemo/modest-account-view-window.c:
2129 (modest_account_view_window_init),
2130 (modest_account_view_window_new):
2131 Use the same buttons as specified in the
2132 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2133 the existing widgets, which never had a chance of working.
2134 Put the ModestAccountView treeview in a scrolled window.
2135 Do not repeat the initialization in both _init() and _new().
2137 * src/widgets/modest-account-view.c: (update_account_view):
2138 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2139 this widget and window shows no accounts.
2141 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2143 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2145 * src/maemo/easysetup/modest-easysetup-wizard.c:
2146 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2147 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2148 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2151 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2152 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2153 accounts exist yet, as in the UI spec.
2155 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2157 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2159 * src/maemo/Makefile.am:
2160 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2161 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2162 New window for editing connection-specific smtp details.
2163 Not fully implemented.
2165 * src/maemo/modest-connection-specific-smtp-window.c:
2166 (modest_connection_specific_smtp_window_finalize) :
2167 unref the tree model.
2168 (on_button_edit): Show the edit window.
2170 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2172 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2175 * src/maemo/Makefile.am:
2176 * src/maemo/modest-connection-specific-smtp-window.c:
2177 * src/maemo/modest-connection-specific-smtp-window.h:
2178 New window for showing the list of connections, for connection-specific
2179 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2180 * src/maemo/easysetup/modest-easysetup-wizard.c:
2181 (create_page_custom_outgoing): Show the new window when the button is clicked.
2183 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2185 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2186 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2187 * src/maemo/modest-msg-edit-window.c:
2188 (modest_msg_edit_window_insert_image):
2189 * src/modest-conf.c: (modest_conf_key_escape):
2190 * src/modest-mail-operation.c:
2191 (modest_mail_operation_send_new_mail):
2192 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2193 (modest_ui_actions_on_new_account):
2194 * src/widgets/modest-attachment-view.c: (update_filename_request):
2195 * src/widgets/modest-mail-header-view.c:
2196 Corrected warnings that were breaking the build, by commenting out unused variables,
2197 and a function, and by including a header.
2199 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2201 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2202 so we can #ifdef around platform-specific code when necessary.
2203 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2204 to allow this to build for the GNOME platform too.
2206 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2208 * src/maemo/easysetup/modest-easysetup-wizard.c:
2209 Added util_increment_name() and used it in create_page_account_details()
2210 to make sure that the default account name is always a new name.
2212 (modest_easysetup_wizard_dialog_init),
2213 (set_default_custom_servernames): Some minor memory management fixes.
2215 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2219 * src/modest-runtime.c: (init_i18n): Restored the translation
2220 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2221 are defined in config.h, and the translations are installed.
2223 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2224 is defined for translation.
2226 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2228 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2230 * src/maemo/easysetup/modest-easysetup-wizard.c:
2231 (modest_easysetup_wizard_dialog_init):
2232 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2233 Use realistic paths (though they should use $prefix generically) to the
2234 mcc_mapping and provider-data.keyfile files which might work when they
2235 are installed by the future version of the operator-wizard package,
2236 and then fallback to paths in our source code, with an explanatory
2239 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2243 * src/maemo/Makefile.am:
2244 * src/maemo/easysetup/: Added files from the previously-exernal
2245 osso-modest-easysetup.
2246 * src/maemo/modest-main-window-ui.h:
2247 * src/modest-ui-actions.c:
2248 * src/modest-ui-actions.h:
2249 Added modest_ui_actions_on_new_account() as a signal handler for the
2250 New Account menu item. It shows the easysetup wizard.
2251 * po/en_GB.po: Added additional needed logical IDs and translations.
2253 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2254 Apparently ChangeLog is not used for some vague Nokia legal reasons.