1 2007-08-14 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
4 Comment out part of the last commit because it apparently causes
7 2007-08-14 Murray Cumming <murrayc@murrayc.com>
9 * src/modest-tny-account-store.c: Added the add_mmc_account()
10 function to save some copy/pasting.
11 (modest_tny_account_store_new): If the memory card is mounted,
12 create an account for it at the start, instead of waiting for the
13 user to unmount it and mount it.
15 2007-08-13 Murray Cumming <murrayc@murrayc.com>
17 * src/widgets/modest-account-view.c: (on_account_changed):
18 Do not try to use the human-readable TnyAccount name instead of the
19 ID of the modest account to get the transport account. And unref
20 the transport account. This prevents a g_warning(), and a possible
23 2007-08-13 Murray Cumming <murrayc@murrayc.com>
25 * src/maemo/modest-platform.c:
26 (modest_platform_set_update_interval): Handle the new
27 alarmd error to warn when alarmd is not running, as is the case in
28 scratchbox for me now because
29 "Module /usr/lib/alarmd/libretu.so initialization failed"
31 2007-08-13 Murray Cumming <murrayc@murrayc.com>
33 * src/widgets/modest-header-view-render.c:
34 (_modest_header_view_compact_header_cell_data):
35 NULL some strings after freeing them, trying to deal with
36 the double deletion found in projects.maemo.org bug 64183,
37 probably having no effect.
39 2007-08-13 Murray Cumming <murrayc@murrayc.com>
41 * src/maemo/modest-account-settings-dialog.c:
42 (create_page_incoming), (create_page_outgoing): Use a define
43 for the min and max port numbers.
45 (check_hildon_number_editor_and_warn_value_not_in_range),
46 (check_data): Do an extra check for an invalid port number, as needed
47 in projects.maemo.org bug #64275, when the number is cleared, but this
48 does not work due to bugs.maemo.org bug #1806.
50 2007-08-13 Murray Cumming <murrayc@murrayc.com>
52 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
53 Comment out the debug warning about the unexpected D-Bus methods.
54 They are just annoying now.
55 * src/maemo/modest-platform.c:
56 (modest_platform_set_update_interval): Correct the D-Bus path, instead
57 of using a file path, though it did not seem to break things before.
58 It might be needed now:
59 Use the ALARM_EVENT_ACTIVATION flag so that emails are updated even when
60 modest is not already running. This is the behaviour of the old client, and
61 Mox says it is what we should do for modest.
62 This closes projects.maemo.org bug NB#64327.
64 2007-08-04 Johannes Schmid <johannes.schmid@openismus.com>
66 * src/modest-text-utils.c:
67 Fixed invalid jump due to incorrect string/pointer
69 (See https://projects.maemo.org/trac/email/wiki/ValgrindErrors
72 2007-08-01 Murray Cumming <murrayc@murrayc.com>
74 * src/modest-account-mgr-helpers.h:
75 * src/modest-account-mgr-helpers.c:
76 Added modest_account_mgr_get_first_account_name(),
77 using code from modest_account_mgr_set_first_account_as_default().
79 * src/maemo/modest-main-window.c: Added set_at_least_one_account_visible().
80 (account_number_changed): Call set_at_least_one_account_visible() so that
81 the first account is visible when first added, without the user having to
83 I do wonder how this worked before.
85 2007-08-01 Murray Cumming <murrayc@murrayc.com>
87 * src/modest-tny-account-store.c: (show_password_warning_only),
88 (show_wrong_password), (request_password_and_wait), (get_password),
89 (modest_tny_account_store_alert): Remove the (incomplete anyway)
90 attempts to show UI only in the main context, which used g_idle_add()
91 and mainloops, because tinymail now guarantees that it only calls these
92 callbacks in the mainloop with the gdk lock. This makes everything much
95 2007-08-01 Murray Cumming <murrayc@murrayc.com>
97 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
98 Handle TNY_ACCOUNT_ERROR_TRY_CONNECT_SERVICE_UNAVAILABLE in the same
99 way as TNY_ACCOUNT_ERROR_TRY_CONNECT_HOST_LOOKUP_FAILED, showing an
100 error dialog, instead of ignoring it.
102 2007-08-01 Murray Cumming <murrayc@murrayc.com>
104 * src/maemo/modest-msg-view-window.c:
105 (modest_msg_view_window_get_header),
106 (modest_msg_view_window_last_message_selected):
107 Added comments to explain the use of priv->header_model.
108 * src/modest-ui-dimming-rules.c:
109 (modest_ui_dimming_rules_on_open_msg),
110 (modest_ui_dimming_rules_on_mark_as_read_msg),
111 (modest_ui_dimming_rules_on_mark_as_unread_msg),
112 (modest_ui_dimming_rules_on_remove_attachments),
113 (_invalid_attach_selected), (_selected_msg_marked_as):
114 Renamed _marked_as_deleted() to _selected_message_is_marked_as_deleted(),
115 and changed the parameter to a ModestMainWindow to make it clearer that
116 it never uses any other kind of window.
117 Added _message_is_marked_as_deleted() for examining a ModestMsgViewWindow
118 instead of the selected message.
119 I notice that much of the dimming code and the ModestMsgViewWindow code
120 hard-codes the assumption that the viewed message is always selected in
121 the header view. This does not seem wise or simple.
123 (modest_ui_dimming_rules_on_delete_msg): For a ModestMsgViewWindow,
124 examine the actual message instead of whatever might be selected
125 in the header view. This stops the delete toolbar button and menu item
126 from being dimmed when opening a message view the search UI,
127 partially fixing projects.maemo.org bug NB#63811.
129 However, when actually deleting, I now get this warning:
130 "tny_header_set_flags: This is a header instance for a new message.
131 Only priority and attachment flags are supported"
133 2007-07-30 Johannes Schmid <johannes.schmid@openismus.com>
135 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
137 Show account wizard if no accounts are defined while sending
138 (automatic sending after the account wizard finished does not
139 work because it takes some time until the account manager
140 synchronizes everything. (projects.maemo.org NB#62792)
142 2007-07-30 Murray Cumming <murrayc@murrayc.com>
144 * src/modest-tny-account-store.c: (on_account_removed),
145 (on_account_changed): Emit the ACCOUNT_UPDATE signal so that the
146 account is removed from the View menu. We have TnyAccountStore
147 and ModestTnyAccountStore signals that seem very similar, but this
148 seems to work for now.
150 * src/maemo/modest-main-window.c:
151 (on_show_account_action_activated): Prevent dereference
152 of a NULL if the accoutn does not really exist, though that
153 should not happen anymore.
155 This fixes projects.maemo.org bug NB#64606.
157 2007-07-30 Murray Cumming <murrayc@murrayc.com>
159 * src/modest-ui-actions.c: (run_account_setup_wizard),
160 (modest_ui_actions_on_accounts): Revert a change that set these
161 to modal dialogs, freezing the UI when they show secondary dialogs.
162 This fixed projects.maemo.org bug NB#64519.
164 2007-07-27 Murray Cumming <murrayc@murrayc.com>
166 * src/widgets/modest-header-view-render.c:
167 (_modest_header_view_compact_header_cell_data):
168 Some checks and initialization to try to deal with a crash,
169 probably ineffective.
171 2007-07-27 Murray Cumming <murrayc@murrayc.com>
173 * src/maemo/modest-maemo-utils.c:
174 (modest_maemo_utils_get_supported_secure_authentication_methods):
175 Make sure that we have a connection, asking the user for one
177 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
178 Check for a connection before showing the wizard, because
179 the wizard needs a connection to check for server capabilities.
181 2007-07-27 Murray Cumming <murrayc@murrayc.com>
183 * src/maemo/modest-account-view-window.c:
184 (on_new_button_clicked): Remember the wizard dialog instance,
185 so we can just present it again if necessary. This prevents
186 multiple windows from appearing if you click again quickly on the
187 New button before the dialog appears, fixing projects.maemo.org
190 2007-07-27 Murray Cumming <murrayc@murrayc.com>
192 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
193 Offer a connection dialog if there is no connection when
194 starting modest. This should fix projects.maemo.org bug NB#61134.
196 2007-07-27 Murray Cumming <murrayc@murrayc.com>
198 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
199 Reverted my last commit. I was able to fix the build by doing
200 apt-get install wpeditor0 (replacing other wpeditor packages) and
201 an explicit apt-get install wpeditor-dev to upgrade the -dev
204 2007-07-27 Murray Cumming <murrayc@murrayc.com>
206 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
207 Commented out the use of wp_text_buffer_replace_image()
208 because it does not exist, to break the build. Added a TODO for it.
210 2007-07-26 Murray Cumming <murrayc@murrayc.com>
212 * src/modest-tny-account-store.c: (recreate_all_accounts):
213 Recreate them even if they were NULL before. I guess something
214 else was already creating them before, or this would never
216 (modest_tny_account_store_get_server_account): Make sure that
217 the tny accounts have been created before trying to find one.
218 This allows libmodest_dbus_client_compose_mail() to work
219 when the UI is not yet visible.
220 This is probably useful in other cases too.
222 (get_password): When the password is wrong after it is entered
223 in the protected password dialog, show an info banner (in an
224 idle handler) before showing the protected password dialog
227 2007-07-26 Murray Cumming <murrayc@murrayc.com>
229 * src/modest-ui-actions.h:
230 * src/modest-ui-actions.c: Added
231 modest_do_refresh_current_folder() containing some code from
232 modest_ui_actions_on_send_receive().
233 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
234 Call modest_do_refresh_current_folder() before refreshing the
235 requested account, as in modest_ui_actions_on_send_receive().
236 This is strange, but seems to be necessary to show new mails.
237 Now new emails are finally visible in the UI when downloaded
238 via the automatic update interval, fixing bug NB#57458.
239 This also works because bug NB#57458 has been fixed somehow.
241 2007-07-26 Murray Cumming <murrayc@murrayc.com>
243 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
244 printf more details when we get unhandled D-Bus methods, because
247 * src/modest-mail-operation.c: (update_account_thread):
248 Comment out the tny_camel_pop_store_account_reconnect(), because this
249 is apparently no longer needed, and it did not work before anyway.
250 See the comment in the code.
252 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
253 by checking the header flags. This fixes projects.maemo.org bug
256 2007-07-25 Murray Cumming <murrayc@murrayc.com>
258 * src/maemo/modest-maemo-utils.h:
259 * src/maemo/modest-maemo-utils.c: Added
260 modest_maemo_show_information_note_in_main_context_and_forget().
261 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
262 Use the new function to show simple error dialogs in the main
263 context, though question dialogs are still in the current context,
264 which is unfortunately usually not the main context. This should
267 2007-07-25 Murray Cumming <murrayc@murrayc.com>
269 * src/modest-tny-account-store.c: (get_password):
270 Never save the entered username and password in gconf,
271 because the UI spec says we should not. This helps
272 slightly with projects.maemo.org bug NB#63671.
274 2007-07-25 Murray Cumming <murrayc@murrayc.com>
276 * src/widgets/modest-msg-edit-window.h:
277 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
278 Moved some code here to make it simpler.
279 (modest_msg_edit_window_attach_file_one): Renamed from
280 modest_msg_edit_window_attach_file_interactive().
281 (modest_msg_edit_window_offer_attach_file): Renamed from
282 modest_msg_edit_window_attach_file() and used
283 modest_msg_edit_window_attach_file_one() instead of
284 copy/pasting the code. The old code for one was not using
285 GnomeVFS. This allows use of smb:// URLs when using send-as
286 from external applications, fixing bug NB#63741.
288 (modest_msg_edit_window_insert_image),
289 (modest_msg_edit_window_add_attachment_clicked):
290 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
291 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
292 Adapted to the new function names.
294 2007-07-25 Murray Cumming <murrayc@murrayc.com>
296 (modest_platform_set_update_interval): Set the alarm recurrence
297 fields so that auto-update does not just happen the first time.
298 This should have fixed projects.maemo.org bug NB#63938.
300 When this happens you can see a printf when the D-Bus method is
302 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
304 However, I do not actually seem to get new POP messages even when
305 clicking the refresh button manually. A restart gets them.
306 This might be a problem in today's tinymail only.
308 2007-07-24 Murray Cumming <murrayc@murrayc.com>
310 * src/maemo/modest-maemo-global-settings-dialog.c:
311 (current_connection):
312 Avoid a crash (probably only in scratchbox) when strcmp()ing a
313 NULL when closing the dialog.
315 2007-07-24 Murray Cumming <murrayc@murrayc.com>
317 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
318 Remove the hacky send/receive that didn't work, and instead
319 refilter the treemodel to make the deleted email really vanish from
320 the UI (though the delete-from-menu code does has commented out
321 the code that does that). This fixes projects.maemo.org bug
324 2007-07-24 Murray Cumming <murrayc@murrayc.com>
326 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
327 Try a couple of tricks to force the treeview to update (
328 poke the folder, and do a send/receive refresh), but the deleted
329 email still appears with a strike-through instead of really being
332 2007-07-23 Murray Cumming <murrayc@murrayc.com>
334 * src/dbus_api/modest-dbus-callbacks.c:
335 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
336 because their ID is not human-readable (see the comment about
337 improvements needed to the osso-email-interface API) and
338 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
340 2007-07-23 Murray Cumming <murrayc@murrayc.com>
342 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
343 (add_folders_to_list), (on_dbus_method_get_folders),
344 (modest_dbus_req_filter):
345 * src/maemo/modest-maemo-utils.c:
346 (on_camel_account_get_supported_secure_authentication):
347 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
348 (on_header_view_focus_in):
349 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
350 * src/modest-formatter.c: (modest_formatter_create_body_part):
351 * src/modest-mail-operation.c: (recurse_folders),
352 (update_account_thread), (get_msgs_full_thread),
353 (modest_mail_operation_get_msgs_full),
354 (modest_mail_operation_xfer_msgs):
355 * src/modest-search.c: (search_mime_part_and_child_parts),
356 (modest_search_account), (modest_search_all_accounts):
357 * src/modest-tny-account.c:
358 (modest_tny_account_get_special_folder), (recurse_folders):
359 * src/modest-tny-local-folders-account.c:
360 (modest_tny_local_folders_account_query_passes):
361 * src/modest-tny-msg.c: (copy_mime_part),
362 (modest_tny_msg_find_body_part_from_mime_part):
363 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
364 (modest_tny_send_queue_try_to_send):
365 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
366 (_modest_ui_actions_open), (download_uncached_messages),
367 (reply_forward), (modest_ui_actions_on_copy),
368 (modest_ui_actions_on_details), (has_retrieved_msgs),
369 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
371 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
372 (_selected_msg_marked_as), (_msg_download_completed),
373 (_selected_msg_sent_in_progress):
374 * src/widgets/modest-attachments-view.c:
375 (modest_attachments_view_set_message):
376 * src/widgets/modest-msg-view.c: (find_cid_image):
377 * tests/check_folder-transfer.c: (find_folders):
378 * tests/check_update-account.c: (func):
379 * tests/dbus_api/test_get_folders.c: (main):
380 Checked all uses of tny_iterator_get_current(), making sure
381 that the object is unreferenced (3 or 4 places did not),
382 and adding checks for NULL.
384 2007-07-23 Murray Cumming <murrayc@murrayc.com>
386 * src/dbus_api/modest-dbus-callbacks.c:
387 (on_idle_open_default_inbox): Make sure that the application UI is
389 * src/maemo/easysetup/modest-easysetup-wizard.c:
390 (on_entry_invalid_character): Show the word whitespace instead
391 of (null) in the banner when whitespace was entered.
392 (show_error): Add a comment that this does not work in
393 Maemo Bora, though we do not know why.
395 2007-07-23 Murray Cumming <murrayc@murrayc.com>
397 * src/modest-tny-account.c:
398 (modest_tny_account_get_special_folder): Use an if instead of
399 an assert for when the parent account name is NULL, because this
400 might be causing a crash in projects.maemo.org bug 63192.
401 * src/modest-mail-operation.c:
402 (modest_mail_operation_send_new_mail_cb),
403 (modest_mail_operation_remove_folder): unref the folder that is
404 returned from modest_tny_account_get_special_folder().
406 2007-07-23 Murray Cumming <murrayc@murrayc.com>
408 * src/modest-ui-actions.c:
409 (modest_ui_actions_on_password_requested):
410 Show mail_ib_login_cancelled info banner when the user cancels
411 the protected password dialog, to fix projects.maemo.org
414 2007-07-23 Murray Cumming <murrayc@murrayc.com>
416 * src/maemo/modest-account-settings-dialog.c:
417 (create_page_outgoing): Put this page in a GtkScrolledWindow,
418 matching the UI mock-up in the UI spec, and allowing access
419 to all widgets even when the on-screen keyboard is active.
421 2007-07-23 Murray Cumming <murrayc@murrayc.com>
423 Reverted this previous commit from Johannes,
424 because the scrollbars are always visible and because
425 I think we only need it on onepage of the account
426 settings, not the account wizard.
427 (I wrote the wrong instructions in the bug.)
429 * src/maemo/easysetup/modest-easysetup-wizard.c:
430 Added scrollbars to account wizard dialog.
431 Fixed projects.maemo.org NB #62744
433 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
435 * src/maemo/easysetup/modest-easysetup-wizard.c:
436 (create_page_user_details):
437 Use auto-cap for name (projects.maemo.org NB#63716)
438 * src/widgets/modest-account-view.c: (on_account_busy_changed):
440 2007-07-22 Armin Burgmeier <armin@openismus.com>
442 * src/maemo/modest-ui-actions.c: Use current account instead of
443 default account for creating viewer windows, so that the viewer
444 window knows to which account the viewed message belongs.
446 * src/maemo/modest-msg-view-window.c: Destroy the window when the
447 corresponding account is deleted. This fixes projects.maemo.org bug
450 2007-07-18 Armin Burgmeier <armin@openismus.com>
452 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
453 the dialog close after entering an invalid port number and clicking
454 OK. This fixes projects.maemo.org bug NB#63602.
456 2007-07-18 Armin Burgmeier <armin@openismus.com>
458 * src/modest-tny-account-store.c:
459 (get_server_accounts): Set parent modest account name for each
460 connection-specific transport account so that special folders of such
461 an account can be looked up. This fixes a crash when changing account
462 settings. This might also be related to projects.maemo.org bug
465 2007-07-16 Armin Burgmeier <armin@openismus.com>
467 * src/modest-ui-actions.c: Added a button to create a folder to the
468 move-to dialog. This fixes projects.maemo.org bug NB#.
470 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
472 * src/maemo/easysetup/modest-easysetup-wizard.c:
473 Added scrollbars to account wizard dialog.
474 Fixed projects.maemo.org NB #62744
476 2007-07-16 Murray Cumming <murrayc@murrayc.com>
478 * src/widgets/modest-msg-view.h:
479 * src/widgets/modest-msg-view.c:
480 Added modest_msg_view_get_message_is_empty() but this needs
482 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
483 Check if there is any text in the message yet.
484 But this needs to be implemented properly.
485 (modest_msg_edit_window_toggle_find_toolbar):
486 * src/maemo/modest-msg-view-window.c:
487 (modest_msg_view_window_toggle_find_toolbar):
488 Show a banner warning if there is no text to search, when
489 trying to start a search. This partially fixes
490 projects.maemo.org bug NB#62350.
492 2007-07-13 Murray Cumming <murrayc@murrayc.com>
494 * src/modest-mail-operation.c: (update_account_thread):
495 Initialized num_new_headers to fix the build.
497 2007-07-13 Murray Cumming <murrayc@murrayc.com>
499 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
500 Ignore modest accounts whose server accounts don't exist in gconf.
501 This prevents us trying to create TnyAccount instances for those
502 server accounts when the server account has been removed from gconf,
503 but the parent modest account has not yet been removed from modest.
504 I don't know why this is only noticeable now. It was probably just
505 a harmeless g_warning() anyway.
507 2007-07-13 Murray Cumming <murrayc@murrayc.com>
509 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
510 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
512 2007-07-12 Armin Burgmeier <armin@openismus.com>
514 * src/maemo/modest-main-window.c: Make default account appear bold
515 in view, tools/send & receive and toolbar/send & receive SCM menus.
516 This fixes projects.maemo.org bug NB#59010.
518 2007-07-12 Murray Cumming <murrayc@murrayc.com>
520 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
521 Add a short-cut, by checking if the folder store is an account.
522 This ensures that the Sort menu item and toolbar is dimmed for
523 the local-folders account root item, fixing
524 projects.maemo.org bug NB#62545.
526 2007-07-12 Murray Cumming <murrayc@murrayc.com>
528 * src/modest-tny-account-store.c: (get_password):
529 Show the password dialog (via the signal) only in the mainloop, via
530 an idle handler that we wait for. This could theoretically prevent
531 hangs, though I worry that it could introduce some too.
533 2007-07-12 Murray Cumming <murrayc@murrayc.com>
535 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
536 * src/maemo/modest-platform.c:
537 (modest_platform_connect_and_wait):
538 Take a TnyAccount* parameter and try to set it to online
539 (a TnyCamel-only API), because tinymail sets accounts to offline
540 when the user cancels a password dialog, and doesn't ask again until
541 it has been set to online.
542 However, this is commented out because it causes a hang now.
544 (modest_platform_connect_and_wait_if_network_account):
545 * src/modest-mail-operation.c:
546 (modest_mail_operation_update_account):
547 * src/modest-platform.h:
548 * src/modest-ui-actions.c: (_modest_ui_actions_open),
549 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
551 2007-07-12 Armin Burgmeier <armin@openismus.com>
553 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
555 * src/modest-mail-operation.c:
556 * src/modest-ui-actions.c: Check for already existing folder before
557 querying the server, show error message from camel if the request
558 still fails. This fixes projects.maemo.org bug NB#58701.
560 2007-07-12 Murray Cumming <murrayc@murrayc.com>
562 * src/modest-tny-account-store.h:
563 * src/modest-tny-account-store.c:
564 Added modest_tny_account_store_forget_password_in_memory(),
565 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
566 when creating a new account, so that new passwords will be used, instead of
567 us thinking that it's a second request as a result of a failed password again.
569 2007-07-12 Murray Cumming <murrayc@murrayc.com>
571 * src/dbus_api/modest-dbus-callbacks.c:
572 (on_idle_open_message): If the message is in drafts then open it
573 in an edit window instead of a view window. This fixes
574 projects.maemo.org bug NB#63005.
576 2007-07-12 Murray Cumming <murrayc@murrayc.com>
578 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
579 Avoided a harmless g_warning().
581 2007-07-12 Murray Cumming <murrayc@murrayc.com>
583 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
584 Pass the modest account name, not the TnyAccount display name to
585 modest_msg_view_window_new() so that the reply feature works,
586 fixing projects.maemo.org bug NB#62892.
588 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
589 (modest_msg_view_window_new_with_header_model):
590 * src/maemo/modest-msg-view-window.c:
591 (modest_msg_view_window_new_with_header_model),
592 (modest_msg_view_window_new):
593 * src/modest-ui-actions.c: (reply_forward):
594 * src/widgets/modest-msg-view-window.h:
595 * src/widgets/modest-window.c: (modest_window_set_active_account):
596 Rename an account parameter to modest_account_name to make this clearer.
598 2007-07-11 Murray Cumming <murrayc@murrayc.com>
600 * src/modest-ui-actions.h:
601 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
602 modest_do_message_delete().
603 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
604 Call modest_do_message_delete(), hoping that this would cause messages
605 to be really deleted from search instead of just marked with strike through.
606 Does not seem to help.
608 2007-07-11 Armin Burgmeier <armin@openismus.com>
610 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
611 priv->reselect to FALSE prior to calling
612 modest_folder_view_select_first_inbox_or_local() to prevent endless
613 recursion and thus a crash on startup.
615 2007-07-11 Armin Burgmeier <armin@openismus.com>
617 * src/maemo/modest-account-settings-dialog.h: Include
618 <gtk/gtknotebook.h> to fix the build (at least for me).
620 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
621 Use "New FolderN" as default suggested name if "New folder" already
622 exists, with N being the first free number, though never exceed "New
623 folder99" in which case we just fall back to "New Folder" even though
624 it already exists. This fixes projects.maemo.org bug NB#58663.
626 2007-07-11 Murray Cumming <murrayc@murrayc.com>
628 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
629 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
630 projects.maemo.org bug NB#62778.
632 2007-07-11 Murray Cumming <murrayc@murrayc.com>
634 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
635 Ignore the wrong (for now) secure-smtp setting in the presets -
636 just default to requiring secure authentication for SMTP, because
639 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
641 * src/widgets/modest-folder-view.c: (filter_row)
642 Do not show drafts folder (see UI specs)
644 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
646 * src/modest-ui-actions.c:
647 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
648 place and also not necessary.
650 * src/widgets/modest-folder-view.c: (filter_row)
651 Guess folder type and hide Sent & Outbox if necessary.
652 Fixed project.maemo.org NB#57328
654 2007-07-11 Murray Cumming <murrayc@murrayc.com>
656 * src/modest-ui-actions.h:
657 * src/modest-ui-actions.c:
658 (modest_ui_actions_on_delete_message):
659 Move some code into a new
660 modest_ui_actions_refresh_message_window_after_delete()
661 function so we can use it from elsewhere.
663 * src/dbus_api/modest-dbus-callbacks.c:
664 (on_idle_delete_message), (on_delete_message): Used an idle
665 handler, as we do for the other D-Bus method handlers.
666 Call modest_ui_actions_refresh_message_window_after_delete()
667 if the deleted message was open in a window. This fixed
668 projects.maemo.org bug NB#62862.
670 2007-07-11 Murray Cumming <murrayc@murrayc.com>
672 * src/modest-main.c: (main): Only show the UI at the start if
673 the showui command line option was given. For instance,
674 run-standalone src/modest showui
675 Otherwise, we wait for the top_application D-Bus method to
676 be sent by hildon-desktop when the application is selected
678 This allows us to run without a UI when osso-global-search
679 uses our D-Bus methods.
681 2007-07-11 Murray Cumming <murrayc@murrayc.com>
683 * src/dbus_api/modest-dbus-api.h: Added a define for a
684 top-application D-Bus method.
685 * src/dbus_api/modest-dbus-callbacks.c:
686 (on_top_application),
687 (modest_dbus_req_handler): Handle the top-application D-Bus
688 method, which might be an undocumented D-Bus signal sent by
689 hildon-desktop when it starts the application from the menu.
690 But I am not sure and I need to test it on the device, because
691 my scratchbox does not have the application in the menu now.
692 This method shows the main window, so that it can be invisible
693 when started, for instance, just for email searching from
696 * src/maemo/modest-main-window.c: (restore_settings),
697 (modest_main_window_new): Do not show the window immediately
698 upon creation. We show it later.
699 * src/modest-widget-memory.c: (save_settings_paned):
700 Try (unsuccessfully) to avoid saving the paned position when
701 it is not even visible.
702 (restore_settings_paned): Do not allow a silly paned position.
703 This seems necessary when not showing the window at first.
705 * tests/dbus_api/Makefile.am:
706 * tests/dbus_api/test_top_application.c: (main): Test for the
709 2007-07-10 Murray Cumming <murrayc@murrayc.com>
711 * src/modest-ui-dimming-rules.c:
712 (modest_ui_dimming_rules_on_new_msg),
713 (modest_ui_dimming_rules_on_reply_msg),
714 (modest_ui_dimming_rules_on_delete_msg),
715 (modest_ui_dimming_rules_on_details),
716 (modest_ui_dimming_rules_on_view_window_move_to),
717 (modest_ui_dimming_rules_on_view_previous),
718 (modest_ui_dimming_rules_on_view_next),
719 (_invalid_folder_for_purge): Added checks before
720 casting the window. This looks like an actual
721 logic error in _invalid_folder_for_purge(), because it
722 tries to use a ModestMainWindow as a message window.
724 2007-07-10 Murray Cumming <murrayc@murrayc.com>
726 * src/maemo/modest-account-settings-dialog.c:
727 (show_error): Use the same implementation as in
728 modest-easysetup-wizard.c:
729 (on_entry_invalid_character): The logical ID contains a %s.
730 Guessed what it should be.
731 (on_entry_max), (check_data), (on_response): Adapt to
732 changed show_error().
733 (create_page_account_details): Really call
734 modest_validating_entry_set_func() on the correct widgets.
735 * src/maemo/easysetup/modest-easysetup-wizard.c:
736 (on_entry_invalid_character): Fix the logical ID here too.
737 (create_page_account_details),
738 (create_page_user_details):
740 modest_validating_entry_set_func() on the correct widgets.
742 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
743 Do not try to use the account if it is NULL.
745 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
747 * src/modest-ui-actions.c: (create_move_to_dialog),
748 (modest_ui_actions_on_main_window_move_to),
749 (modest_ui_actions_on_msg_view_window_move_to):
750 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
751 (filter_row), (modest_folder_view_show_non_move_folders):
752 * src/widgets/modest-folder-view.h:
754 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
755 the Sent folder yet as it does not report the correct folder type.
757 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
759 * src/maemo/modest-msg-edit-window.c: (init_window):
762 2007-07-10 Murray Cumming <murrayc@murrayc.com>
764 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
765 Take a parent widget instead of a parent window, and
766 implement this with hildon_banner_show_information() instead.
767 Non-Maemo builds can just ifdef that there.
768 This fixed projects.maemo.org bug NB#62766.
770 (on_entry_invalid_character): Use show_error() again instead
771 of using hildon directly, and use the _CS() macro to use the correct
773 (create_account), (check_for_supported_auth_methods), (on_entry_max):
774 Pass a widget instead od a window to show_error().
776 2007-07-10 Murray Cumming <murrayc@murrayc.com>
778 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
779 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
780 This allows us to show the server name in the error message, fixing
781 projects.maemo.org bug NB#62904.
782 Also, use the appropriate logical ID message for the account protocol.
784 2007-07-10 Murray Cumming <murrayc@murrayc.com>
786 * src/modest-tny-account-store.c: (on_idle_wrong_password):
787 A compilation fix, though the build wasn't broken for me.
789 2007-07-09 Murray Cumming <murrayc@murrayc.com>
791 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
792 Do not try to unref a NULL folder store, to avoid a runtime warning.
793 This seems to happen sometimes when changing accounts settings.
795 2007-07-09 Murray Cumming <murrayc@murrayc.com>
797 * src/modest-tny-account-store.c:
798 (modest_tny_account_store_instance_init),
799 (modest_tny_account_store_finalize),
800 (on_account_settings_hide), (on_idle_wrong_password):
801 Use a GHashTable to ensure that we only show one account settings
802 dialog per modest account. This avoids us having a dialog open for
803 both the store and transport accounts, or due to repeated get_password()
804 calls that shouldn't happen anyway.
806 2007-07-09 Murray Cumming <murrayc@murrayc.com>
808 * src/maemo/modest-maemo-utils.c: (on_hide),
809 (modest_maemo_show_dialog_and_forget): Handle the response, because
810 the window is not even hidden by default.
812 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
813 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
814 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
815 which seems to prevent some modality problems.
817 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
818 Ignore user cancellation errors.
820 * src/modest-account-mgr-helpers.h:
821 * src/modest-account-mgr-helpers.c:
822 Added modest_server_account_get_password() and
823 modest_server_account_get_has_password() to avoid direct use of
826 * src/maemo/modest-account-settings-dialog.h:
827 * src/maemo/modest-account-settings-dialog.c:
828 (modest_account_settings_dialog_init): Store the notebook so we can
830 Added modest_account_settings_dialog_switch_to_user_info().
832 * src/modest-tny-account-store.c:
833 (get_password): When the password in the account settings is wrong (we think),
834 show the relevant page of the account settings dialog, in the mainloop.
835 However, we currently get many of these at once because cancel does not
837 (forget_password): Do not forget the password
838 from the account settings, because this causes side-effects when
839 tinymail seems to call it at strange time, maybe because of how we
840 are cancelling get_password().
841 (modest_tny_account_store_alert): Ignore user cancellations.
843 2007-07-09 Murray Cumming <murrayc@murrayc.com>
845 * src/maemo/modest-maemo-utils.h:
846 * src/maemo/modest-maemo-utils.c:
847 Added modest_maemo_show_information_note_and_forget() for use instead of
848 gtk_dialog_run() when the response is not needed, to avoid an extra
849 mainloop which could cause a hang.
851 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
852 Use the logical IDs for the error message, though they are not
853 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
854 because gtk_dialog_run() caused a hang here (the window did not close).
855 This fixes projects.maemo.org bug NB#62646.
857 2007-07-09 Murray Cumming <murrayc@murrayc.com>
859 * src/modest-account-mgr-helpers.h:
860 * src/modest-account-mgr-helpers.c:
861 Added modest_account_mgr_get_store_protocol().
863 * src/maemo/modest-account-view-window.c:
864 (on_delete_button_clicked): Show different warning text depending on
865 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
866 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
869 2007-07-09 Murray Cumming <murrayc@murrayc.com>
871 * src/maemo/modest-msg-edit-window.c:
872 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
873 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
875 2007-07-07 Armin Burgmeier <armin@openismus.com>
877 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
878 ckdg_ib_maximum_characters_reached from correct package.
880 * src/modest-ui-actions.c: Show an error message when a folder could
881 not be created. Tinymail does not give us specific error codes about
882 what has gone wrong, so we assume that a folder with that name
883 already exists, though there might be other reasons.
885 2007-07-06 Murray Cumming <murrayc@murrayc.com>
887 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
888 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
889 give a more exact error message that can be partly translated.
891 2007-07-05 Murray Cumming <murrayc@murrayc.com>
893 * src/maemo/modest-address-book.c:
894 (select_email_addrs_for_contact): Specify a default window size for the
895 select-email-address dialog, so that it is probably big enough for the
896 title. This should fix projects.maemo.org bug NB#62277.
898 2007-07-05 Murray Cumming <murrayc@murrayc.com>
900 * src/maemo/easysetup/modest-easysetup-wizard.c:
901 (create_page_complete_easysetup): Use
902 gtk_widget_set_size() request to ensure that the text wraps
905 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
907 * src/maemo/easysetup/modest-easysetup-wizard.c:
908 (on_entry_invalid_character), (create_page_account_details),
909 (create_page_user_details):
910 Use new API of ModestValidatingEntry. But for some reason the banner is
911 not shown. I will have to investigate that further.
913 * src/widgets/modest-validating-entry.c: (on_insert_text),
914 (modest_validating_entry_set_func):
915 * src/widgets/modest-validating-entry.h:
916 Added a new callback function to be able to react to prevented
917 characters whitespaces to e.g show a banner.
919 2007-07-05 Armin Burgmeier <armin@openismus.com>
921 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
922 notification of HildonNumberEditor instead of remembering the port
923 number. Thanks to Johannes for pointing this out.
925 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
927 * src/maemo/easysetup/modest-easysetup-wizard.c:
928 Check if there are any user changes before showing a confirmation
929 dialog (projects.maemo.org NB#60946)
931 2007-07-05 Armin Burgmeier <armin@openismus.com>
933 * src/maemo/modest-account-settings-dialog.c: Remember custom port
934 number at the beginning of the dialog and set the modified flag at the
935 end if the port number has changed. This is necessary because
936 HildonNumberEditor does not support notification when the value has
939 2007-07-05 Murray Cumming <murrayc@murrayc.com>
941 * src/modest-ui-actions.c:
942 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
943 a connection before asking anything else. Correct the check for the destination
944 folder so that it succeeds when online.
945 This fixed projects.maemo.org bug NB#61645.
947 2007-07-05 Murray Cumming <murrayc@murrayc.com>
949 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
950 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
951 to fix projects.maemo.org bug NB#62439.
953 2007-07-05 Murray Cumming <murrayc@murrayc.com>
955 * src/modest-tny-account.c: (on_connection_status_changed):
956 Really do not use tny_device_force_offline() here. See the previous comment.
958 2007-07-04 Murray Cumming <murrayc@murrayc.com>
960 * src/modest-tny-account.c: (on_connection_status_changed):
961 Do not use tny_device_force_offline() when tinymail says that something
962 went wrong with the connection. It seems to report this unnecessarily.
964 2007-07-04 Murray Cumming <murrayc@murrayc.com>
966 * src/maemo/modest-connection-specific-smtp-window.c:
967 (modest_connection_specific_smtp_window_init):
968 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
969 does not seem to have any effect in osso 1.1 (though it works in
970 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
972 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
974 * src/maemo/modest-connection-specific-smtp-window.c:
975 Fix UI specification problems with projects.meamo.org NB#60479
977 2007-07-04 Murray Cumming <murrayc@murrayc.com>
979 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
980 clue when this has failed, because the error dialog is not always shown
981 (at least in earlier version).
983 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
984 GError message, because the generic error dialog is not helpful.
986 'This message is not currently available (can't let a new connection go online)'
987 when trying to open an IMAP message.
989 (_modest_ui_actions_open): Offer a connection when some messages would
990 have to be downloaded and we are offline.
992 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
994 * src/widgets/modest-folder-view.c:
995 Don't check for MERGE type anymore as we use the correct type
997 NOTE: For the last two changes you need to update your tinymail copy
998 because of API changes!
1000 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1002 * src/modest-tny-local-folders-account.c:
1003 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
1004 (see projects.maemo.org NB#61580)
1006 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1008 * src/modest-tny-account.c: (on_connection_status_changed):
1009 Commented out the call to modest_platform_connect_and_wait() because this
1010 seems to always hang, and I would like to know if this is the only thing
1011 that causes a hang when showing the connection dialog.
1012 It is not very useful anyway.
1014 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1016 * src/maemo/modest-msg-view-window.c:
1017 (modest_msg_view_window_select_next_message):
1019 * src/modest-platform.h:
1020 * src/maemo/modest-platform.c:
1021 Added modest_platform_connect_and_wait(), which calls
1022 tny_maemo_conic_device_connect() always in the main thread, by calling it
1023 in an idle handler and waiting for the idle handler to run. It should be
1024 in the main thread because it uses GTK+ UI code. It just returns TRUE
1025 if the device is already online.
1027 There is some nasty code to ensure that subsequent calls to
1028 modest_platform_connect_and_wait() just wait for the first one to finish,
1029 by checking repeatedly in another idle handler. This is necessary,
1030 because other threads (or even the main thread, via another idle handler)
1031 can call modest_platform_connect_and_wait() while
1032 modest_platform_connect_and_wait() is running.
1034 (modest_platform_connect_and_wait_if_network_account),
1035 (modest_platform_connect_and_wait_if_network_folderstore):
1036 Convenience functions that calls modest_platform_connect_and_wait() if
1037 the account or folder might want network access.
1039 * src/modest-mail-operation.c:
1040 (modest_mail_operation_update_account):
1041 * src/modest-ui-actions.c: (download_uncached_messages),
1042 (modest_ui_actions_on_rename_folder), (delete_folder),
1043 (modest_ui_actions_on_main_window_move_to),
1044 (modest_ui_actions_on_msg_view_window_move_to):
1045 * src/widgets/modest-folder-view.c:
1046 (drag_and_drop_from_folder_view):
1047 Offer a connection if we are offline.
1049 * src/modest-tny-account.c: (on_connection_status_changed):
1050 Document this as only handling errors during network operations in progress,
1051 and replace the idle code with a simple call to
1052 modest_platform_connect_and_wait(), which does this instead.
1054 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1056 * src/modest-tny-account.c:
1057 (modest_tny_account_get_special_folder): (util_on_idle),
1058 Handle the GError so we can see when tny_folder_store_get_folders()
1059 fails, as it currently does while something else is connecting.
1061 Added util_run_in_main_thread_and_wait()
1062 which uses an idlen handler and mainloop to ensure that the function
1063 is called in the main thread.
1064 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
1065 to make sure that we call attempt the connection in the mainloop only,
1066 which might solve some hangs.
1068 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1070 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
1071 be found by their display name. This is never useful.
1072 * src/modest-tny-account-store.c: (on_account_removed): Find the account
1073 by its ID, instead of trying to use its ID as its display name.
1075 * src/modest-tny-account-store.h:
1076 * src/modest-tny-account.c:
1077 (modest_tny_account_get_special_folder): Add a g_warning() when
1078 tny_folder_store_get_folders() returns an empty list for the maildir.
1080 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
1081 Add a g_warning() when this returns NULL, because that it not allowed
1084 2007-07-02 Armin Burgmeier <armin@openismus.com>
1086 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
1087 note when trying to cancel the wizard. This fixes projects.maemo.org
1090 2007-07-02 Murray Cumming <murrayc@murrayc.com>
1092 * src/modest-tny-account.h:
1093 * src/modest-tny-account.c:
1094 (modest_tny_account_new_from_server_account),
1095 (modest_tny_account_new_from_server_account_name),
1096 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
1097 because this must now be set before setting the proto. This is usd in
1098 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
1099 warning in camel_session_get_service() caused by
1100 tny_camel_transport_account_prepare().
1102 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
1105 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
1107 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1109 (modest_connection_specific_smtp_edit_window_init):
1111 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
1112 of "changed" for now
1114 2007-06-29 Murray Cumming <murrayc@murrayc.com>
1116 * src/modest-tny-account.c:
1117 (modest_tny_account_new_from_server_account):
1118 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
1119 now uses to request a connection when it needs one, and which it uses
1120 to tell us that something is wrong with the connection, so we can force
1121 the accounts offline to prevent further problems.
1123 * src/modest-defs.h:
1124 * src/modest-init.c: (init_default_settings):
1125 * src/modest-mail-operation.c:
1126 (modest_mail_operation_update_account):
1127 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
1128 This should not be necessary anymore. Do not set the conf key that
1129 determined this (it was always TRUE and not set anywhere else).
1131 * src/modest-ui-actions.h: Remove unused and unimplemented
1132 modest_ui_actions_on_online_toggle_toggled().
1134 2007-06-29 Murray Cumming <murrayc@murrayc.com
1136 * src/maemo/modest-main-window.c: (connect_signals):
1137 Don't connect to delete_event twice. Maybe this was harmless.
1139 2007-06-29 Murray Cumming <murrayc@murrayc.com
1141 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
1142 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
1143 Debug output to give some more clue when a folder move is not allowed.
1145 2007-06-28 Murray Cumming <murrayc@murrayc.com
1147 * src/modest-tny-account.c: (on_modest_file_system_info),
1148 (modest_tny_account_get_mmc_account_name):
1149 Always call the callback, without checking whether the name has changed.
1150 * src/widgets/modest-folder-view.c: (strings_are_equal),
1151 (on_model_foreach_set_name), (on_get_mmc_account_name),
1152 (text_cell_data): Compare the name here, and use the name from
1153 the account rather than from the
1154 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
1155 if the name was changed after the account was added to the model.
1156 That's a tinymail bug but not one that I want to fix now.
1158 This finally fixes projects.maemo.org bug NB#59301.
1160 2007-06-27 Armin Burgmeier <armin@openismus.com>
1162 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
1165 2007-06-27 Murray Cumming <murrayc@murrayc.com
1167 * src/modest-tny-account.h:
1168 * src/modest-tny-account.c:
1169 Added modest_tny_account_get_mmc_account_name(), to set the memory
1170 card name asynchronously for the given account and then notify.
1171 (modest_tny_account_new_for_local_folders): Use this new function instead
1172 of using hildon_file_system_info_async_new() directly.
1174 * src/widgets/modest-folder-view.c: (text_cell_data):
1175 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
1176 gtk_tree_model_row_changed() when it is available.
1178 This should fix projects.maemo.org bug NB#59301.
1180 2007-06-27 Murray Cumming <murrayc@murrayc.com
1182 * src/modest-mail-operation.c: (update_account_thread),
1183 (get_msgs_full_thread): Fix typo failures in the revert
1186 2007-06-27 Murray Cumming <murrayc@murrayc.com
1188 * src/maemo/modest-maemo-global-settings-dialog.c:
1189 (idle_select_default_focus):
1190 * src/modest-mail-operation.c: (idle_notify_progress),
1191 (idle_notify_progress_once), (set_last_updated_idle),
1192 (update_account_thread), (get_msgs_full_thread):
1193 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1194 * src/widgets/modest-header-view.c:
1195 (idle_notify_headers_count_changed_destroy),
1196 (idle_notify_headers_count_changed):
1197 Reverted the additions of gdk_threads_enter/leave(), in case this
1198 helps with a startup hang on the device.
1200 2007-06-26 Armin Burgmeier <armin@openismus.com>
1202 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
1203 for supported secure authentication methods from server by
1204 gtk_dialog_run(), saving CPU time and a potential race condition.
1206 2007-06-26 Armin Burgmeier <armin@openismus.com>
1208 * src/maemo/modest-maemo-utils.h:
1209 * src/maemo/modest-maemo-utils.c: Added a
1210 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
1211 only error code to tell the calling code when the user canceled the
1214 * src/maemo/modest-account-settings-dialog.h:
1215 * src/maemo/modest-account-settings-dialog.c:
1216 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
1217 message if the retrieval of secure authentication methods was canceled
1218 by the user. Perform the check before saving anything to configuration
1219 to not end up with half-committed configuration changes, do not show
1220 a "Saving to configuration failed" note when authentication methods
1221 could not be retrieved.
1223 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
1226 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1228 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1229 Only return the first level of folders under accounts, because the
1230 osso-global-search UI spec doesn't want the rest.
1231 This fixed projects.maemo.org bug NB#61811.
1233 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1235 * src/modest-tny-account-store.c:
1236 * src/modest-tny-account-store.h:
1237 Added modest_tny_account_is_memory_card_account().
1238 * src/maemo/modest-main-window.c: (create_details_widget):
1239 Show the same information items for the memory card as we show for the
1240 local-folders, to fix projects.maemo.org bug NB#59307.
1242 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1244 * src/modest-tny-account-store.c: (get_password):
1245 Added some checks for NULL to maybe prevent crashes, though I think
1246 it was Philip's last commit that actually prevented the crash here
1247 when creating a first new account.
1248 But the new account is still not usable (no messages are shown)
1249 until a restart of the application.
1251 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1253 * src/maemo/modest-maemo-global-settings-dialog.c:
1254 (idle_select_default_focus):
1255 * src/modest-mail-operation.c: (idle_notify_progress),
1256 (idle_notify_progress_once), (idle_notify_update_account_queue),
1257 (set_last_updated_idle), (update_account_thread),
1258 (notify_get_msgs_full), (get_msgs_full_destroyer),
1259 (get_msgs_full_thread):
1260 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1261 * src/widgets/modest-header-view.c:
1262 (idle_notify_headers_count_changed_destroy),
1263 (idle_notify_headers_count_changed):
1264 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1265 all idle handlers, because some other thread could be blocking
1266 the GDK lock, so that it can do GUI stuff.
1268 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1270 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1271 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1272 (on_idle_send_receive), (on_idle_open_default_inbox):
1273 * src/maemo/modest-msg-edit-window.c:
1274 (modest_msg_edit_window_attach_file_noninteractive):
1275 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1276 to prevent a hang. I don't quite understand why these are necessary,
1277 beause we should already be in the main loop. I guess something outside
1278 of the main loop is taking the lock.
1280 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1281 we are really using URIs, and use files that are more likely to exist.
1283 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1285 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1286 necessary because configure.ac now defines different variables.
1288 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1290 * libmodest-dbus-client/libmodest-dbus-client.c:
1291 * libmodest-dbus-client/libmodest-dbus-client.h:
1292 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1293 libmodest_dbus_client_compose_mail() is what things actually use.
1295 * src/dbus_api/modest-dbus-api.h:
1296 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1297 * tests/dbus_api/Makefile.am:
1298 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1301 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1303 * src/modest-init.c: (modest_init_local_folders):
1304 For memory-card (or other non local-folders) maildir accounts,
1305 always create an Archive folder, so that there is somewhere to put
1306 messages. This should be less confusing, because the user does not need
1307 to guess that the need to create a folder.
1309 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1311 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1312 Fixed icon size by using (50, 50) which is the same as defined by
1315 2007-06-25 Armin Burgmeier <armin@openismus.com>
1317 * src/widgets/modest-window-mgr.c:
1318 * src/modest-init.c:
1319 * configure.ac: Correctly recognize hildon-notify presence and fixed
1320 the build without it being installed.
1322 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1324 * libmodest-dbus-client/libmodest-dbus-client.c:
1325 (libmodest_dbus_client_search): Fix the build. Sorry.
1326 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1327 (reply_forward_cb): Initialize variables to fix the build.
1329 * src/modest-tny-account-store.c:
1330 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1331 comparison (a silly typo) so that email search results can be opened
1332 when there are more than one account.
1334 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1336 * libmodest-dbus-client/libmodest-dbus-client.c:
1337 (libmodest_dbus_client_search),
1338 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1339 instead of 1 second, because the search gets folders and messages from
1340 the server, which can take a long time. When it times out,
1341 osso-global-search will report no results.
1343 We need to specify whether we should search only cached information
1344 (maybe with a user preference), and the osso-email-search-plugin
1345 API should really be improved to allow that option, and to allow results
1346 to be delivered asynchronously in batches.
1348 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1350 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1351 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1352 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1354 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1356 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1357 that is an empty string. D-Bus seems to give us these instead of NULL.
1359 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1361 * src/dbus_api/modest-dbus-callbacks.c:
1362 * src/maemo/easysetup/modest-easysetup-wizard.h:
1363 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1364 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1365 (modest_connection_specific_smtp_edit_window_init):
1366 * src/maemo/modest-maemo-global-settings-dialog.c:
1368 * src/maemo/modest-maemo-utils.c:
1369 (modest_maemo_utils_setup_images_filechooser):
1370 * src/maemo/modest-main-window.c: (create_details_widget):
1371 * src/maemo/modest-msg-edit-window.c:
1372 (modest_msg_edit_window_attach_file_noninteractive),
1373 (modest_msg_edit_window_color_button_change),
1374 (modest_msg_edit_window_set_zoom):
1375 * src/modest-mail-operation.c: (update_account_thread):
1376 * src/modest-tny-account-store.c:
1377 * src/modest-tny-account.c:
1378 * src/widgets/modest-global-settings-dialog.c:
1379 * src/widgets/modest-window.h:
1381 Fixed build on bora!
1383 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1385 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1386 * src/modest-search.c: (modest_search_folder),
1387 (modest_search_all_accounts): Actually search only in the specified folder,
1388 doing a simple match on the folder ID.
1389 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1390 and added some documentation.
1392 2007-06-22 Armin Burgmeier <armin@openismus.com>
1394 * src/maemo/modest-maemo-utils.h:
1395 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1396 modest_maemo_utils_get_supported_secure_authentication_methods.
1398 * src/maemo/easysetup/modest-easysetup-wizard.c:
1399 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1400 one occured, not just "Server does not support secure authentication".
1402 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1404 * src/modest-tny-account-store.c: (get_password):
1405 Restored the call to tny_account_set_user() because Philip seems to have
1406 stopped this from crashing (by not using the freed string). It still does
1407 not work, but now we can test it.
1409 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1411 * src/maemo/modest-msg-edit-window.c: (init_window):
1412 Comment out use of an uninitialzed GtkScrolledWindow variable,
1413 to fix the build and stop a crash. Yet again.
1415 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1417 * src/modest-tny-account-store.c: (get_password):
1418 Remove the call to tny_account_set_user() because this actually crashes.
1419 As mentioned in the last commit, it is known to not work anyway.
1421 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1423 * src/modest-tny-account-store.c: (get_password):
1424 Use tny_account_set_username() to tell tinymail that the username might
1425 have changed too. But tinymail ignores this: see projects.maemo.org
1427 * src/modest-ui-actions.c:
1428 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1429 reset the connection when changing the username, and improve the comments.
1430 Save the changed username to gconf at least, so it is used when Modest is
1433 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1435 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1436 Do not use a query, so that we get all folders, including for POP and
1437 local-folders. They work as search criteria too.
1438 This fixes projects.maemo.org bug NB#57740.
1440 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1442 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1443 Comment out the use of hildon_notification_set_sound() because it is
1444 not declared, to fix the build. Warnings are serious, people.
1446 2007-06-21 Armin Burgmeier <armin@openismus.com>
1448 * src/maemo/modest-maemo-utils.h:
1449 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1450 modest_maemo_utils_get_supported_secure_authentication_methods()
1451 to query authentication methods for a specific user. This should fix
1452 projects.maemo.org bug NB#61369.
1454 * src/maemo/easysetup/modest-easysetup-wizard.c:
1455 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1458 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1460 * libmodest-dbus-client/libmodest-dbus-client.h:
1461 * libmodest-dbus-client/libmodest-dbus-client.c:
1462 (modest_dbus_message_iter_get_search_hit),
1463 (libmodest_dbus_client_search):
1464 Reorganised and commented this.
1465 Removed modest_search_hit_free() from the public API because it
1468 Added libmodest_dbus_client_get_folders() and
1469 modest_folder_result_list_free().
1471 * src/dbus_api/modest-dbus-api.h:
1472 * src/dbus_api/modest-dbus-callbacks.c:
1473 (modest_dbus_req_filter): Commented. Moved most code to
1474 on_dbus_method_search() and added on_dbus_method_get_folders().
1476 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1477 of the extra D-Bus handler.
1479 * tests/dbus_api/Makefile.am:
1480 * tests/dbus_api/test_get_folders.c: New test for
1481 libmodest_dbus_client_get_folders(). This seems to return an empty list
1482 at the moment. That could be the same error that causes the message list
1483 to be empty sometimes.
1484 This should help with projects.maemo.org bug NB#57740.
1486 2007-06-21 Armin Burgmeier <armin@openismus.com>
1488 * src/modest-mail-operation.c: Do not call
1489 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1490 notify the operation's end after having set the status to CANCELED for
1491 the operation queue to listen on. This fixes a deadlock when there
1492 were mail operations in the queue during its finalization.
1494 * src/modest-singletons.c: Reordered uninitialization of the account
1495 manager to happen after the mail operation queue was uninitialized
1496 because the mail operation's in the queue might still try to access
1497 the account manager (see modest_mail_operation_notify_end()). This
1498 fixes a potential crash when terminating the application.
1500 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1502 * src/modest-search.c:
1503 (search_mime_part_and_child_parts): Moved some code here so we
1504 can search recursively in child folders.
1505 (modest_search_folder): Search in the message as a mime part, instead
1506 of just its child mime parts.
1507 (read_chunk), (search_mime_part_ogs):
1508 Check how many bytes were read, to prevent an endless loop.
1509 Searching in message bodies now works. This finishes the fix for
1510 projects.maemo.org bug NB#61007.
1512 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1514 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1515 Add a g_warning when the item is not a folder.
1517 * src/modest-ui-dimming-rules.c:
1518 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1519 when selected item is not a folder (for instance, an account), because
1520 the UI spec only talks about folders.
1521 I am not sure what the UI spec wants, so this might not totally fix
1522 projects.maemo.org bug NB#60794.
1524 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1526 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1527 (load_from_file): Sort the list. The unsorted list would be more noticeable
1528 in non-English locales.
1530 * src/maemo/modest-msg-edit-window.c:
1531 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1532 warning and fix the build.
1534 * src/maemo/modest-progress-bar-widget.c:
1535 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1536 avoid a g_warning, and probably to avoid a crash.
1538 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1540 * src/modest-search.c: (modest_search_folder): Check for a GError
1541 when calling tny_folder_get_headers(), to show that this is not the cause
1544 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1546 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1547 Actually set the body query instead of the subject query.
1549 * src/modest-search.c: (search_mime_part_ogs),
1550 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1551 which would probably cause it to fail if we got this far.
1553 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1554 to simplify the code.
1555 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1556 be causing search-in-body to fail.
1558 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1560 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1562 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1563 Better debug message when the folder cannot be found.
1564 This should help with fixing projects.maemo.org bug #61287.
1565 * src/modest-search.c: (add_hit): Do not leak the furl string.
1567 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1569 * src/modest-ui-actions.c:
1570 (modest_ui_actions_on_folder_selection_changed):
1571 Do not special-case TNY_MERGE_FOLDER here, because
1572 modest_tny_folder_get_account() already does that. This fixes
1573 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1574 shown when the Outbox was selected).
1576 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1578 * libmodest-dbus-client/libmodest-dbus-client.c:
1579 (_dbus_iter_get_string_or_null): Initialize the string variable in
1580 case this helps with Dirk's crash.
1582 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1584 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1585 though it is not implemented yet (this function is maybe not even used),
1586 to avoid breaking ABI in future.
1587 * libmodest-dbus-client/libmodest-dbus-client.c:
1588 (get_attachments_string): Moved some code into this generic function.
1589 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1590 sends email. It is maybe not used.
1591 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1592 (on_send_mail): Use attachments.
1594 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1595 * src/maemo/modest-msg-edit-window.c:
1596 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1597 a filename before using it, to fix projects.maemo.org bug NB#58233.
1599 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1601 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1602 Initialize the continue_download variable to fix the build, and probably
1603 to fix randome behaviour.
1605 2007-06-18 Armin Burgmeier <armin@openismus.com>
1607 * src/modest-tny-send-queue.h:
1608 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1609 the queue so we can later show it in the UI. Replaced
1610 modest_tny_send_queue_msg_is_being_sent() by
1611 modest_tny_send_queue_get_msg_status().
1613 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1615 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1616 gpointer. This probably was not harmful, but just to be sure.
1618 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1620 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1621 Fix the build, but leave the function broken on Bora, because
1622 hildon_uri_action_get_service() does not exist.
1623 osso_uri_action_get_service() does not exist either, it seems.
1625 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1627 * src/modest-tny-account.c:
1628 (modest_tny_account_new_from_server_account):
1629 Uncommented the url debug output again, because it is useful for
1630 debugging, as I said in the comment.
1632 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1634 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1636 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1637 for Mameo Bora, to fix the build.
1639 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1642 Fixed build with hildon < 0.99
1644 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1645 Check if the selected account is busy instead of checking all accounts
1647 * src/modest-account-mgr-priv.h:
1648 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1649 (modest_account_mgr_init), (compare_account_name),
1650 (modest_account_mgr_set_account_busy),
1651 (modest_account_mgr_account_is_busy):
1652 * src/modest-account-mgr.h:
1653 Added busy information to the account manager. It possible to
1654 set an account to busy or not busy now.
1656 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1657 (modest_mail_operation_update_account),
1658 (modest_mail_operation_notify_end):
1659 Set the account to busy/not busy depending on the operation state.
1661 * src/widgets/modest-account-view.c:
1662 (modest_account_view_finalize), (get_last_updated_string),
1663 (update_account_view), (on_account_busy_changed), (init_view):
1664 Show string "Refreshing..." if the account is currently busy.
1666 All this fixes projects.maemo.org bug NB#59711
1668 2007-06-14 Armin Burgmeier <armin@openismus.com>
1670 * src/widgets/modest-attachments-view.h:
1671 * src/widgets/modest-attachments-view.c: Added
1672 modest_attachments_view_has_attachments() and fixed coordinate
1673 transformation in get_att_view_at_coords(). This fixes attachment
1676 * src/widgets/modest-msg-view.c: Make use of
1677 modest_attachments_view_has_attachments() to decide whether to show
1678 attachments in the header.
1680 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1682 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1683 (on_change), (on_combo_security_changed),
1684 (modest_connection_specific_smtp_edit_window_init),
1685 (modest_connection_specific_smtp_edit_window_set_connection),
1686 (modest_connection_specific_smtp_edit_window_is_dirty):
1687 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1688 * src/maemo/modest-connection-specific-smtp-window.c:
1691 Show an comfirmation dialog for the smpt-edit-window if there are
1692 unsaved changes and the user hits cancel.
1693 (projects.maemo.org bug NB#60479)
1695 2007-06-14 Armin Burgmeier <armin@openismus.com>
1697 * src/maemo/easysetup/modest-easysetup-wizard.c:
1698 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1699 address" info in banner instead of node, and select all the text as
1700 per UI spec. This fixes projects.maemo.org bug NB#60550.
1702 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1704 reviewed by: <delete if not using a buddy>
1706 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1707 * src/modest-ui-actions.c: (folder_refreshed_cb):
1709 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1711 * src/widgets/modest-folder-view.c: (filter_row):
1712 Explictly filter out the per-account outbox accounts. I don't know why
1713 these only sometimes show up, but now they should never show up in the UI.
1714 This should fix projects.maemo.org bug NB#60160.
1716 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1718 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1719 when the toolbar does not exist yet.
1720 * src/modest-widget-memory.c: (save_settings_header_view):
1721 Added g_warnings() to help us to discover when we are trying to set
1722 an empty columns list in gconf.
1724 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1726 * src/modest-init.h:
1727 * src/modest-init.c:
1728 Added modest_init_get_default_header_view_column_ids().
1730 * src/modest-widget-memory.c: (restore_settings_header_view):
1731 Use the new function to get defaults, if the gconf key is empty,
1732 instead of not creating any columns. This seems to fix the
1733 empty right-hand pane problems.
1735 * src/widgets/modest-header-view.h: Improved documentation.
1737 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1739 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1740 Revert the use of the display name as the account name, because this
1741 is generally wrong and would break the code that follows.
1743 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1745 * src/maemo/easysetup/modest-easysetup-wizard.c:
1746 (check_for_supported_auth_methods), (on_before_next),
1749 More correct fix for projects.maemo.org bug NB# 58991
1750 Do not longer accept AUTH_PASSWORD as secure method and choose
1751 correct method when creating the account.
1753 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1755 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1756 Fixed projects.maemo.org bug NB# 58991
1758 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1760 * src/modest-init.c: (modest_init_init_core),
1761 (modest_init_local_folders): Fixed compilation errors.
1763 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1765 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1766 Remove unnecessary lib/include, though it is good in principle when needed.
1768 * src/modest-init.c: (modest_init_one_local_folder),
1769 (modest_init_local_folders):
1770 * src/modest-init.h: Initialize the .modest library for memory cards,
1771 instead of just doing nothing for them. This should allow us to create
1772 folders there, fixing projects.maemo.org bug NB#59297.
1774 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1776 * libmodest-dbus-client/libmodest-dbus-client.c:
1777 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1778 (libmodest_dbus_client_compose_mail),
1779 (libmodest_dbus_client_open_message),
1780 (libmodest_dbus_client_send_and_receive),
1781 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1783 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1784 (on_idle_open_message), (modest_dbus_req_handler),
1785 (search_result_to_message), (modest_dbus_req_filter):
1786 * src/modest-search.c: (add_hit), (modest_search_folder),
1787 (modest_search_all_accounts): Improved debug messages.
1789 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1791 * src/modest-tny-account-store.c:
1792 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1795 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1798 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1800 * src/modest-tny-account-store.c: (get_server_accounts):
1801 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1802 even when there are no accounts, so that the Outbox folder is always
1803 visible. This fixes projects.maemo.org bug NB#60158.
1805 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1807 * src/maemo/modest-main-window.c: (create_details_widget):
1808 Use the mcen_va_never logical ID.
1810 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1812 * src/dbus_api/modest-dbus-api.h:
1813 * src/dbus_api/modest-dbus-callbacks.c:
1814 (on_idle_open_default_inbox), (on_open_default_inbox),
1815 (modest_dbus_req_handler):
1816 Added a new OpenDefaultInbox method.
1818 * libmodest-dbus-client/libmodest-dbus-client.h:
1819 * libmodest-dbus-client/libmodest-dbus-client.c:
1820 Added libmodest_dbus_client_open_default_inbox() to call the new
1821 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1822 though it should maybe be used by a new osso-email-interface function.
1824 * tests/dbus_api/Makefile.am:
1825 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1828 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1830 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1831 NULL, so that the signals get all the keys. This should not actually
1832 change any behaviour because we currently update everything when anything
1835 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1837 * src/widgets/modest-folder-view.c: (text_cell_data),
1838 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1839 (find_inbox_iter): If tinymail tells us that the folder is
1840 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1841 This causes the inbox to be selected at startup, fixing part of
1842 projects.maemo.org bug NB#56305.
1844 * src/modest-ui-dimming-rules.c:
1845 (modest_ui_dimming_rules_on_tools_smtp_servers):
1846 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1847 the SMTP servers menu item.
1848 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1849 that the SMTP Servers menu item is dimmed when there are no accounts,
1850 as a future version of the UI spec will require. This fixes
1851 projects.maemo.org bug NB#56305.
1853 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1855 * src/maemo/modest-maemo-utils.c:
1856 (modest_maemo_utils_get_supported_secure_authentication_methods):
1857 Added label to dialog instead of unreadable title
1859 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1860 (modest_main_window_new):
1861 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1864 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1865 * src/modest-account-mgr.h:
1866 Added method to avoid code duplication
1868 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1869 (modest_ui_actions_on_send_receive):
1870 Use modest_account_mgr_has_accounts
1872 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1874 * src/maemo/easysetup/modest-presets.c:
1875 (modest_presets_get_info_server_security): Do not report secure auth
1877 * src/modest-protocol-info.c: Use the defines for the gconf key names
1878 for secure authentication. This was not working because we were writing
1879 Password and reading password, and the check was case sensitive.
1880 With this, gmail now works for receiving and sending when created via
1883 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1885 * src/maemo/easysetup/modest-presets.c:
1886 (modest_presets_get_info_server_security): Correct the key name for
1887 SecureSmtp, because it seems to be case-sensitive.
1888 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1889 Do not try to get the 0th notebook page if there are 0 pages, to
1890 avoid a g_warning().
1892 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1894 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1895 Prevent use of the new notification feature for now, because it currently
1896 shows one dialog for each new email, which is annoying.
1898 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1900 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1901 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1902 when no country was selected, so that we show the global ones.
1903 * src/maemo/easysetup/modest-presets.c:
1904 (modest_presets_get_providers): Return only the global providers, not
1905 all providers when mmc=0 was requested.
1907 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1909 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1910 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1911 provider ID in the combo.
1913 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1914 Do not show the page numbers, because it would be confusing when we add
1915 the 2 extra pages for the custom setup, when the user chooses the "Other"
1916 provider. This fixes projects.maemo.org bug NB#59028
1918 * src/modest-init.c: (modest_init_init_core),
1919 (modest_init_local_folders):
1920 * src/modest-init.h:
1921 * src/modest-tny-account.c:
1922 (modest_tny_account_new_for_local_folders): Do not create default folders
1923 for the memory card. This should fix projects.maemo.org bug NB#59328.
1925 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1927 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1928 Free the changed_conf_keys string items. They are already freed in the
1929 idle handler if that runs first.
1931 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1933 * src/modest-ui-actions.c:
1934 (modest_ui_actions_on_password_requested): Check that the server name
1935 is not NULL, because I just saw a password dialog with (null) as the
1938 * src/modest-tny-folder.[h|c]: Added
1939 modest_tny_folder_is_memory_card_folder().
1940 * src/modest-ui-dimming-rules.c:
1941 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1942 menu item for memory cards, as per the UI spec (section 7.4). This should
1943 fix projects.maemo.org bug NB#59297.
1945 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1947 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1948 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1949 is another problem with the code, see Murray's comment at line 772)
1951 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1953 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1954 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1955 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1956 (load_from_file), (easysetup_country_combo_box_init),
1957 (easysetup_country_combo_box_get_active_country_ids),
1958 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1959 instead of just one ID, to avoid duplicate country names in the UI.
1961 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1962 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1963 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1964 a single ID, avoiding duplicate providers.
1965 * src/maemo/easysetup/modest-easysetup-wizard.c:
1966 (on_combo_account_country): Adapt to use a list.
1968 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1970 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1971 keys changed in the last X seconds.
1973 * src/modest-account-mgr.h:
1974 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1975 (on_key_change), (modest_account_mgr_class_init),
1976 (modest_account_mgr_init), (modest_account_mgr_finalize):
1977 As the keys are changed, save them in a GSList* and signal that GSList*
1978 further every X seconds, to batch changes, to allow us to do just one
1979 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1980 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1982 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1983 changed signal signature.
1985 * src/modest-conf.c: (modest_conf_set_list),
1986 (modest_conf_on_change): Reenable notification.
1988 (modest_conf_maemo_fake_on_change): Comment out the hack that
1989 notified immediately instead of asynchronously.
1991 * src/widgets/modest-account-view.h:
1992 * src/widgets/modest-account-view.c:
1993 (update_account_view): Select the previously-selected account ID,
1994 if possible. This fixes projects.maemo.org bug NB#56933.
1996 (on_account_changed), (on_account_removed),
1997 (modest_account_view_select_account):
1999 Remove the block/unblock functions
2000 because they were not useful.
2002 * src/maemo/modest-account-view-window.c:
2003 (on_delete_button_clicked), (on_edit_button_clicked),
2004 (on_new_button_clicked): Remove the use of the non-working block/unblock.
2006 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2008 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2009 Improve the error dialog to show Incorrect Account Settings, which seems
2010 clearer, and say that the internal error message (to be removed from the
2011 dialog later) is often misleading.
2012 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
2014 * src/modest-tny-account.c:
2015 (modest_tny_account_new_from_server_account): Uncomment the printf of the
2016 URL because this is so useful for debugging on the device.
2018 * src/widgets/modest-serversecurity-combo-box.c:
2019 (modest_serversecurity_combo_box_fill): Correct a logical ID.
2021 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2023 * src/modest-mail-operation.c:
2024 (modest_mail_operation_send_new_mail):
2025 Added a comment about a nasty but apparently harmless message. Details
2026 added to the wiki g_warnings() page.
2028 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2030 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
2031 (modest_tny_send_queue_class_init):
2032 Do not use the priv struct because it is empty, to avoid g_warnings
2033 about a non-existant priv struct.
2035 * src/modest-tny-account-store.c:
2036 (modest_tny_account_store_get_server_account),
2037 (modest_tny_account_store_get_transport_account_for_open_connection
2038 ): Do not try to get transport server accounts for local folders,
2039 because they don't have any. This avoids a g_warning().
2041 * src/maemo/modest-main-window.c:
2042 (modest_main_window_notify_send_receive_initied),
2043 (on_configuration_key_changed):
2044 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
2045 * src/modest-defs.h:
2046 * src/modest-mail-operation.c:
2047 (modest_mail_operation_update_account):
2048 * src/modest-tny-account-store.h:
2049 * src/modest-tny-account.c:
2050 (modest_tny_account_get_special_folder),
2051 (modest_tny_account_new_for_local_folders),
2052 (modest_tny_account_new_for_per_account_local_outbox_folder):
2053 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
2054 * src/modest-tny-local-folders-account.c:
2055 (add_account_folders_to_merged_folder):
2056 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
2057 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
2058 (modest_ui_actions_on_send):
2059 * src/widgets/modest-folder-view.c: (update_model):
2060 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
2061 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
2062 modest_tny_account_store_get_tny_account_by_account() to
2063 modest_tny_account_store_get_server_account() to make the code clearer.
2065 2007-06-07 Marcus Bauer <marcusb@openismus.com>
2067 * src/dbus_api/modest-dbus-api.h:
2068 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
2069 * src/maemo/modest-msg-edit-window.c:
2070 (modest_msg_edit_window_attach_file_noninteractive):
2071 added g_warning in case the file to be attached does not exist
2072 * tests/dbus_api/test_compose_mail.c: (main):
2073 removed obsolete comment, added generic files as test case
2075 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2077 * src/modest-tny-account-store.c: (get_server_accounts):
2078 Create the local folders account only once, not once for each outbox, and
2079 not only when there are some outboxes.
2081 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2083 * src/widgets/modest-folder-view.c: (update_model): Comment out some
2084 code that is causing a crash at startup. Sergio says that he is fixing this.
2086 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
2088 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2089 * src/maemo/modest-account-settings-dialog.c:
2090 (create_page_outgoing),
2091 (modest_account_settings_dialog_set_account_name),
2092 (save_configuration):
2093 - Fixed handling of the "Use secure authentication" toggle to comply with
2094 the ui specification. See also projects.maemo.org bug NB#58400
2096 - Restore the Secure connection setting combo correctly when loading
2099 * src/maemo/modest-maemo-utils.c:
2100 (on_camel_account_get_supported_secure_authentication),
2101 (modest_maemo_utils_get_supported_secure_authentication_methods):
2102 Fixed a crasher if operation is canceled
2104 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
2105 (modest_protocol_info_auth_is_secure):
2106 * src/modest-protocol-info.h:
2108 Added two new methods to determine if a protocol/auth method is secure/encrypted in
2109 the sense of the "Use secure authentication" toggle.
2111 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2113 * src/modest-tny-account-store.h:
2114 * src/modest-tny-account-store.c:
2115 Added modest_tny_account_store_get_local_folders_account().
2117 * src/modest-tny-folder.h:
2118 * src/modest-tny-folder.c:
2119 (modest_tny_folder_get_account):
2120 Added this replacement for tny_folder_get_account() which returns
2121 the local-folders account for TnyMergeFolders, to avoid the
2122 warning about the unimplemented get_account_func() vfunc().
2124 (modest_tny_folder_get_rules),
2125 * src/modest-ui-actions.c:
2126 (modest_ui_actions_on_folder_selection_changed):
2127 * src/modest-mail-operation.c:
2128 (modest_mail_operation_remove_folder),
2129 (modest_mail_operation_xfer_folder),
2130 (modest_mail_operation_rename_folder),
2131 (modest_mail_operation_get_msg),
2132 (modest_mail_operation_get_msgs_full),
2133 (modest_mail_operation_remove_msg),
2134 (modest_mail_operation_xfer_msgs),
2135 (modest_mail_operation_refresh_folder):
2136 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
2138 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2140 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
2141 (modest_server_account_set_security):
2142 * src/modest-defs.h: Add comments explaining that our
2143 UI spec means TLS when it says Normal, so these do not look like errors.
2145 * src/modest-tny-account.c:
2146 (modest_tny_account_new_from_server_account): Use the new tinymail
2147 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
2148 for TLS. This should fix projects.maemo.org bug NB#58460.
2150 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2152 * src/maemo/easysetup/modest-easysetup-wizard.c:
2153 (create_account): Correct the position of the gconf sanity check warning.
2154 (on_button_edit_advanced_settings): Show the dialog immediately, instead
2155 of using the g_idle_add() hack, because this does not seem to be necessary
2156 on osso 1.1. It might even work on Maemo Bora if the problems were actually
2157 caused by something other than maemo's gconf.
2158 This fixes projects.maemo.org bug #59022.
2160 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2162 * src/modest-account-mgr-helpers.c:
2163 (modest_account_mgr_get_default_account): Do not check that the account
2164 exists if there is no default account (NULL), to fix a runtime warning.
2166 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2168 * src/widgets/modest-folder-view.c: (update_model):
2169 Do not unref the treemodel before we have finished with it.
2170 This prevents a valgrind warning and an occasional crash at startup.
2172 2007-06-06 Marcus Bauer <marcusb@openismus.com>
2174 * libmodest-dbus-client/libmodest-dbus-client.h:
2175 added libmodest_dbus_client_compose_mail()
2176 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2178 added functions needed for SendAsMail() functionality
2179 * src/maemo/modest-msg-edit-window.c:
2180 (modest_msg_edit_window_attach_file_noninteractive):
2181 non interactively attaching files to message edit window
2182 * src/widgets/modest-msg-edit-window.h:
2183 * tests/dbus_api/Makefile.am:
2184 added test_compose_mail.c
2185 * tests/dbus_api/test_compose_mail.c: (main):
2187 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2189 * src/modest-account-view.c:
2190 Fixed bug projects.maemo.org bug NB#59307
2192 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2194 * src/maemo/easysetup/modest-easysetup-wizard.c:
2195 (get_serverport_incoming), (on_before_next), (create_account):
2196 * src/maemo/modest-account-settings-dialog.c:
2197 (modest_account_settings_dialog_set_account_name):
2198 * src/maemo/modest-maemo-utils.c:
2199 (on_camel_account_get_supported_secure_authentication_status),
2200 (on_camel_account_get_supported_secure_authentication),
2201 (on_secure_auth_cancel),
2202 (modest_maemo_utils_get_supported_secure_authentication_methods):
2204 Implemented security authentication for settings and easysetup.
2206 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2208 * src/maemo/modest-main-window.c: (create_details_widget):
2209 Show the total size for memory card accounts too, instead of showing
2210 the name again. Fixes bug projects.maemo.org bug NB#59307.
2212 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2215 * src/modest-tny-simple-folder-store.c:
2216 * src/modest-tny-simple-folder-store.h: Removed.
2218 * src/modest-tny-local-folders-account.h
2219 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
2220 for the local-folders maildir, with an extra TnyMergedFolder containing
2221 the folders of the per-account outbox store accounts.
2222 * src/modest-tny-account-store.c: (get_server_accounts):
2223 Add the outboxes to the special local folders account after creating it.
2225 * src/modest-tny-account.c:
2226 (modest_tny_account_new_for_local_folders): Create the derived
2227 account when creating the main local-folders account.
2229 * src/maemo/modest-main-window.c: (create_details_widget),
2230 (modest_main_window_set_contents_style):
2231 Adapted to the use of the derived account instead of the folder store.
2233 * src/modest-ui-actions.c:
2234 (modest_ui_actions_on_folder_selection_changed):
2235 * src/modest-ui-dimming-rules.c:
2236 (modest_ui_dimming_rules_on_new_folder):
2237 * src/widgets/modest-folder-view.c: (text_cell_data),
2238 (icon_cell_data), (filter_row), (update_model),
2239 (get_cmp_rows_type_pos):
2242 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2243 Do not get the priv struct, because no priv struct has been set,
2244 to avoid a runtime warning.
2246 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2247 #ifelse with #else, to fix a warning, to fix the build.
2250 2007-06-05 Christian Kellner <ckellner@openismus.com>
2252 * libmodest-dbus-client/libmodest-dbus-client.c:
2253 Fix small typo in doc (why do you always see them
2254 AFTER committing stuff?)
2257 2007-06-05 Christian Kellner <ckellner@openismus.com>
2259 * libmodest-dbus-client/libmodest-dbus-client.c:
2260 (libmodest_dbus_client_search):
2261 Initialize hit list with NULL. Also set folder list
2262 to "" if NULL was supplied.
2265 2007-06-03 Christian Kellner <ckellner@openismus.com>
2267 * libmodest-dbus-client/libmodest-dbus-client.c:
2268 (modest_search_hit_list_free):
2269 Make it save to call it with NULL.
2271 * src/dbus_api/modest-dbus-callbacks.c:
2272 * src/modest-search.c:
2273 Return full ModestSearchHits as the search result list not TnyHeader
2274 since can't be around withouth the correspoding TnyFolder.
2276 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2278 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2279 Added currently commented code to check for secure auth
2281 * src/maemo/modest-account-settings-dialog.c: (on_response),
2282 (save_configuration), (show_ok):
2283 Fixed projects.maemo.org bugs NB #59248 and #59251
2285 * src/maemo/modest-maemo-utils.c:
2286 (on_camel_account_get_supported_secure_authentication_status),
2287 (on_camel_account_get_supported_secure_authentication),
2288 (modest_maemo_utils_get_supported_secure_authentication_methods):
2289 * src/maemo/modest-maemo-utils.h:
2290 Moved get_supported_secure_authentication() method here to be able
2291 to use it from easysetup wizard.
2293 * src/modest-pair.c: (on_pair_compare_as_string):
2294 Should compare string with first part of pair and not
2295 strcmp pairs which will crash.
2297 * src/modest-protocol-info.c:
2298 (modest_protocol_info_protocol_is_store):
2299 * src/modest-protocol-info.h:
2300 Added modest_protocol_info_get_auth_protocol_name()
2302 2007-06-03 Armin Burgmeier <armin@openismus.com>
2304 * src/modest-mail-operation.c:
2305 (modest_mail_operation_get_msgs_full): Set priv->account also when
2306 only retrieving a single message. This avoids a crash when canceling
2309 (modest_mail_operation_notify_end): Do not explicitely remove the
2310 operation from the queue but only emit the progress_changed signal.
2311 The queue itself listens to that signal to remove the operation when
2312 it is finished. This reduces coupling and removes a potential deadlock
2313 when modest_mail_operation_notify_end() is called from the queue
2314 itself. If that is a problem performance-wise, I would suggest to
2315 implement a status-changed signal or something.
2317 * src/modest-mail-operation-queue.c: Make sure to never call a
2318 function from another file while the queue is locked. This (hopefully)
2319 fixes another deadlock when exiting the application while retrieving
2322 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2324 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2325 Fixed build if libogs is not available
2327 2007-06-03 Christian Kellner <ckellner@openismus.com>
2329 * libmodest-dbus-client/libmodest-dbus-client.h:
2330 * libmodest-dbus-client/libmodest-dbus-client.c:
2331 (libmodest_dbus_client_delete_message):
2332 Implement deletion of messages (Client side).
2334 (modest_search_hit_free),
2335 (modest_search_hit_list_free):
2336 Utility functions to free the result hits.
2338 * src/dbus_api/modest-dbus-api.h:
2339 * src/dbus_api/modest-dbus-callbacks.c:
2340 (on_delete_message),
2341 (modest_dbus_req_handler):
2342 Implement deletion of messages (Server side).
2344 * tests/dbus_api/test_search.c: (main):
2347 * tests/dbus_api/Makefile.am:
2348 * tests/dbus_api/test_delete_message:
2349 Add little test for the message deletion logic
2351 2007-06-03 Armin Burgmeier <armin@openismus.com>
2353 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2354 when the operation queue was not empty. projects.maemo.org bug
2357 2007-06-03 Armin Burgmeier <armin@openismus.com>
2359 * src/widgets/modest-account-view.c
2360 (on_account_default_toggled): Toggle default account column
2361 explicitely instead of waiting for gconf notification (which is
2362 currently ignored). This should fix projects.maemo.org bug NB#56910
2363 for now. It should probably be removed when gconf notifications are
2366 2007-06-03 Christian Kellner <ckellner@openismus.com>
2368 * libmodest-dbus-client/libmodest-dbus-client.c:
2369 Removed debugging spew.
2371 * src/dbus_api/modest-dbus-callbacks.c:
2372 Added debugging info.
2374 * src/modest-search.c:
2375 (modest_search_all_accounts):
2376 Use tny_account_store_get_accounts () on the account store
2377 to get all accounts which is the way to get all accounts.
2379 * tests/dbus_api/test_search.c: (main):
2380 Make it possible to supply the search term on the command line.
2382 2007-06-03 Christian Kellner <ckellner@openismus.com>
2384 * libmodest-dbus-client/libmodest-dbus-client.c:
2385 * libmodest-dbus-client/libmodest-dbus-client.h:
2386 Implement searching for mesages over raw dbus. (Client side)
2388 * src/dbus_api/Makefile.am:
2389 * src/dbus_api/modest-dbus-api.h:
2390 * src/dbus_api/modest-dbus-callbacks.c:
2391 * src/dbus_api/modest-dbus-callbacks.h:
2392 Search framework (Server side). Also implement on_idle_open_message().
2394 * src/maemo/modest-platform.c: (modest_platform_init):
2395 Prepare for raw dbus/osso rpc interaction.
2397 * src/modest-search.h:
2398 Changed minsize from unspecific guint to guint32.
2400 * src/modest-search.c:
2402 Added strange hack which magically made tnymail work.
2404 (modest_search_folder),
2405 (modest_search_account),
2406 (modest_search_all_accounts):
2407 Implement helper functions to search all accounts, specific account
2410 * tests/dbus_api/Makefile.am:
2411 * tests/dbus_api/test_open_message.c:
2412 Read url to open from commandline.
2414 * tests/dbus_api/test_search.c:
2415 Implement small test for dbus search stuff
2417 2007-06-02 Armin Burgmeier <armin@openismus.com>
2419 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2420 include account type and account title. This fixes projects.maemo.org
2423 * src/maemo/modest-account-view-window.c: Set a title for the window.
2425 2007-06-02 Armin Burgmeier <armin@openismus.com>
2427 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2428 incoming and outgoing server name based on email address and server
2429 types as long as the names have not been edited manually. This fixes
2430 projects.maemo.org bug NB#58671.
2432 2007-06-02 Armin Burgmeier <armin@openismus.com>
2434 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2435 server type cannot be changed in future to the incoming details page
2436 when creating an account. This fixes projects.maemo.org bug NB#59029.
2438 2007-06-02 Armin Burgmeier <armin@openismus.com>
2440 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2441 and assigned max width chars so that they wrap instead of being
2442 truncated. Fixes projects.maemo.org bug NB#56126.
2444 2007-06-02 Armin Burgmeier <armin@openismus.com>
2446 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2447 introductory note to the connection specific smtp servers dialog, as
2448 section 8.12 of the email UI specification requires. This fixes
2449 projects.maemo.org bug NB#59212.
2451 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2453 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2454 Check for running mail operations, and offer to cancel them, as per the UI
2455 spec. This fixes projects.maemo.org bug NB#59041 .
2456 However, I suspect that tinymail may still use the network connection
2457 in ways that we cannot detect or cancel. But it should at least adapt to
2458 changes fairly well.
2460 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2462 * src/modest-tny-account-store.c: (recreate_all_accounts),
2463 (get_cached_accounts), (get_server_accounts): Do more sensible
2464 ref-counting of the temporarily-cached outbox accounts list. This seems
2465 to fix a crash when entering the password when the password was wrong.
2467 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2469 * src/gnome/modest-main-window.c: (connect_signals):
2470 * src/modest-tny-account-store.c: (get_password),
2471 (modest_tny_account_store_alert): Added comments and clues and
2472 commented-out code about how we currently fail to deal with connection
2473 errors and wrong passwords, and how we should.
2475 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2477 * src/widgets/modest-retrieve-combo-box.c:
2478 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2479 This fixes projects.maemo.org bug NB#58472 .
2481 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2483 * src/maemo/easysetup/modest-easysetup-wizard.c:
2484 (create_page_complete_easysetup):
2485 (create_page_complete_custom): Correct the last commit,
2486 putting the correct sentences in the correct pages.
2488 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2490 * src/maemo/easysetup/modest-easysetup-wizard.c:
2491 (create_page_complete_custom): Show the second sentence of text
2492 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2495 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2497 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2498 Set the leave-on-server conf key by default. This fixes
2499 projects.maemo.org bug NB#59258 .
2501 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2503 * src/maemo/modest-account-view-window.c:
2504 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2505 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2508 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2510 * src/maemo/easysetup/modest-easysetup-wizard.c:
2511 (create_caption_new_with_asterisk):
2512 * src/maemo/modest-account-settings-dialog.c:
2513 (create_caption_new_with_asterisk):
2514 Uncomment the code to add the asterisk, because they are no longer in the
2515 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2516 (update_incoming_server_title): Add an asterisk here too.
2518 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2520 * src/maemo/modest-maemo-global-settings-dialog.c:
2521 (current_connection): Check that we are even connected before trying to
2522 get the current connection name, to prevent a warning.
2524 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2525 Change the comments because tny_maemo_conic_device_connect() is now meant to
2527 * src/modest-mail-operation.c:
2528 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2529 make sure we have a connection and fail if we can't connect.
2531 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2533 * src/maemo/modest-main-window.c:
2534 (on_account_store_connecting_finished): Do not try to get the
2535 connection ID if we are not really connected. I am surprised that
2536 this signal handler is called when we are not connected.
2538 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2540 * src/modest-error.h:
2541 * src/modest-ui-actions.c:
2542 (modest_ui_actions_get_msgs_full_error_handler):
2543 Renamed an enum, added comments, added an enum
2544 for retrieve-limit errors.
2546 * src/modest-mail-operation.c: (foreach_add_item),
2547 (internal_folder_observer_update), (update_account_thread),
2548 (modest_mail_operation_get_msgs_full):
2549 (modest_mail_operation_update_account),
2550 Added comments about how this works, and some code that should
2551 (but does not) check the retrieve-limit. See the TODO comment.
2553 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2555 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2556 Initialize help_id to fix the build. Warnings are good.
2558 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2560 * src/widgets/modest-hbox-cell-renderer.c:
2561 (modest_hbox_cell_renderer_append):
2562 * src/widgets/modest-vbox-cell-renderer.c:
2563 (modest_vbox_cell_renderer_append):
2564 Fix the last commit by doing an extra ref.
2566 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2568 * src/widgets/modest-hbox-cell-renderer.c:
2569 (modest_hbox_cell_renderer_append):
2570 * src/widgets/modest-vbox-cell-renderer.c:
2571 (modest_vbox_cell_renderer_append):
2572 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2573 to fix the build with Maemo Bora.
2574 However, there seems to be a remaining crash, probably due to reference
2577 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2579 * src/modest-tny-account.c:
2580 (modest_tny_account_new_for_local_folders):
2581 Use hildon_file_system_info_async_new() to get a better name for
2582 the memory card account, setting it as the account name.
2583 The timing seems to work, but this is probably
2584 not the best place to do this. See the TODO comment.
2585 * src/maemo/modest-main-window.c: (create_details_widget):
2586 * src/widgets/modest-folder-view.c: (text_cell_data):
2587 Use the tny account name instead of hardcoding a name.
2589 2007-05-30 Christian Kellner <ckellner@openismus.com>
2591 * src/modest-search.c: (modest_search):
2592 Correctly set part_search_func even if we have already parsed
2593 the query and thus a valid OgsTextSearcher object.
2595 2007-05-30 Christian Kellner <ckellner@openismus.com>
2598 Search and check for libogs.
2601 Incooparte the ogs build env.
2603 * src/modest-mime-part-search-stream.c:
2604 * src/modest-mime-part-search-stream.h:
2605 Removed since we do the real searching now in modest-search.c.
2607 * src/modest-search.c:
2608 * src/modest-search.h:
2609 Implement support for ogs. We use that if available and requested
2610 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2611 should now handle the corner case when the search term is spread
2612 across multiple reads.
2613 Also the logic in modest_search () was corrected to search all
2614 requested fields until one is found.
2616 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2618 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2620 * src/modest-init.h:
2621 * src/modest-init.c: Made modest_init_local_folders() take a
2622 path and be public so we can iniitialize maildir folders on
2625 * src/modest-local-folder-info.h:
2626 * src/modest-local-folder-info.c:
2627 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2629 * src/modest-tny-account.c:
2630 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2631 still means the standard local-folders path on the local volume.
2633 * src/modest-tny-account-store.c:
2634 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2635 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2636 all accounts when that happens.
2637 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2638 this too, so it shows up in the treeview.
2640 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2642 * src/maemo/modest-maemo-global-settings-dialog.c:
2643 (current_connection):
2644 * src/widgets/modest-global-settings-dialog.c:
2645 (current_connection_default):
2646 Use the enum values instead of 0, 1 and -1,
2647 to make the code clearer.
2649 * src/modest-account-mgr-helpers.c:
2650 (modest_account_mgr_get_connection_specific_smtp): Make this code
2653 * src/modest-runtime.h:
2654 * src/modest-runtime.c:
2655 Added modest_runtime_remove_all_send_queues().
2656 * src/maemo/modest-main-window.c:
2657 (on_account_store_connecting_finished): Recreate the send queues,
2658 using the appropriate transport accounts for this new connection.
2659 Some futher adapting might be needed if the old send queues are not
2660 automatically stopped at this point.
2662 * src/modest-tny-account-store.c: (get_server_accounts):
2663 Create the connection-specific transport accounts, so that they can
2664 be found later by their ID.
2666 * src/modest-tny-account.h:
2667 * src/modest-tny-account.c:
2668 Added modest_tny_account_new_from_server_account_name().
2669 modest_tny_account_new_from_server_account(): Do not create the
2670 send queues here, because they will be
2671 recreated anyway when the connection changes for the first time.
2673 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2675 * src/modest-local-folder-info.h:
2676 * src/modest-local-folder-info.c:
2677 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2678 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2679 tbox_folder): Take a modest account name instead of a server TnyAccount,
2680 so we can have per-modest-account rather than per-transport-account
2682 We must make sure that we change or recreate the exisitng send queues
2683 when the connection changes for connection-specific transport accounts.
2685 * src/modest-tny-account-store.c:
2686 (create_per_account_local_outbox_folders): Create outboxed per modest
2687 account, not per transport account.
2689 * src/modest-tny-account.h:
2690 * src/modest-tny-account.c:
2691 (modest_tny_account_get_special_folder): For outboxes, get the
2692 parent modest account name. The account is ignored for other folders.
2693 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2694 modest account name rather than a server TnyAccount.
2696 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2698 * src/modest-tny-account.c:
2699 (modest_tny_account_new_from_server_account):
2700 Call modest_runtime_get_send_queue() immediately after creating transport
2701 accounts, so that they start trying to send email from the outbox as soon
2702 as possible at startup. This is probably what we want.
2704 * src/modest-mail-operation.c: (update_account_thread):
2705 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2706 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2707 * src/modest-tny-send-queue.h:
2708 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2709 (modest_ui_actions_on_send):
2710 Added comments about how sending works, though it needs some more work.
2712 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2714 * src/modest-tny-account.c:
2715 (modest_tny_account_get_special_folder): Add TODO because this fails when
2716 the network is busy.
2717 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2718 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2719 Do not try to show this window when there is no active account. The UI
2720 specs does not tell us what to do in this case.
2722 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2726 * src/maemo/Makefile.am:
2727 * src/widgets/Makefile.am: Some dist fixes.
2729 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2731 * src/maemo/modest-connection-specific-smtp-window.c:
2732 (on_button_edit): Make the code clearer, to prevent a double free.
2734 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2736 * src/maemo/modest-account-settings-dialog.c:
2737 (modest_account_settings_dialog_set_account_name),
2738 Check the connection-specific smtp servers checkbox if there are any.
2740 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2741 (modest_connection_specific_smtp_edit_window_init):
2742 Start with a suitable port number.
2744 * src/modest-account-mgr-helpers.h:
2745 * src/modest-account-mgr-helpers.c: Added
2746 modest_account_mgr_get_has_connection_specific_smtp().
2748 (modest_account_mgr_set_connection_specific_smtp),
2749 (modest_account_mgr_remove_connection_specific_smtp),
2750 (modest_account_mgr_get_has_connection_specific_smtp),
2751 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2752 connection-specific smtp server accounts in the account, rather than
2753 the server account conf dir.
2755 This fixes bug projects.maemo.org bug NB#58263 .
2757 * src/modest-tny-account-store.c:
2758 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2759 if there are no server accounts yet, to prevent an infinite loop when there
2760 are no accounts. Document that one must be called before the other.
2762 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2764 * src/modest-account-mgr-helpers.c:
2765 (modest_account_mgr_get_default_account): Make sure that at least
2766 one account is always the default, if there are any enabled accounts.
2767 This is just a sanity check that shouldn't be necessary.
2769 * src/modest-account-mgr-priv.c:
2770 (_modest_account_mgr_account_from_key): Unescape the conf key to
2771 get the real account name. For instance, this is an issue if a space
2772 was in the account name, which can happen because the account name
2773 is generated from the display name.
2774 (_modest_account_mgr_get_account_keyname): Always escape the
2776 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2777 Unescape the conf keys to get the real account names.
2779 For instance, previously the is-default radio button in the accounts
2780 list was not checked for any accounts at first. This fixes that,
2781 and might fix several similar bugs.
2783 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2785 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2786 Removed some debug printfs.
2788 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2790 Modest on-disk outbox directories are now here, for instance:
2791 $HOME/.modest/outboxes/<account-id-1>/outbox
2792 $HOME/.modest/outboxes/<account-id-2>/outbox
2794 $HOME/.modest/local-folders/outbox
2795 so we can have a separate outbox for each account.
2796 But they are shown as one outbox in the GtkTreeView, by using a
2797 TnyMergeFolder in a ModestTnySimpleFolderStore.
2800 * src/modest-tny-simple-folder-store.c:
2801 * src/modest-tny-simple-folder-store.h:
2802 Added ModestTnySimpleFolderStore, used to contain folders from
2803 other folder stores, such as other accounts.
2805 * src/modest-tny-outbox-account.h:
2806 * src/modest-tny-outbox-account.c:
2807 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2808 used for the per-account local outbox folders.
2810 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2811 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2812 only use this (internally) now for the non-outbox local folders.
2814 * src/modest-init.h:
2815 * src/modest-init.c: Added modest_init_one_local_folder(), for
2816 setting up the directory structure for each local folder.
2818 * src/modest-local-folder-info.c:
2819 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2820 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2822 * src/modest-local-folder-info.h:
2823 * src/modest-tny-account-store.c: (on_account_removed),
2824 (on_account_changed), (create_per_account_local_outbox_folders),
2825 (get_server_accounts), (modest_tny_account_store_get_accounts),
2826 (modest_tny_account_store_get_tny_account_by_account),
2827 (modest_tny_folder_store_is_virtual_local_folders):
2829 * src/modest-tny-account.h:
2830 * src/modest-tny-account.c:
2831 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2832 to create an on-disk per-account local outbox folder for each
2834 (create_per_account_local_outbox_folders): Create a local outbox folder
2835 for each transport account.
2836 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2837 for all local folders.
2839 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2840 instead of using g_object_get/set() directly. It is clearer.
2842 (modest_tny_folder_store_get_message_count),
2843 (modest_tny_folder_store_get_local_size
2844 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2845 because we now use these with non-acount folder stores.
2847 (modest_tny_account_get_special_folder),
2848 (modest_tny_account_new_from_server_account),
2849 (modest_tny_account_new_from_account):
2850 (recurse_folders): Adjust to the new outbox system.
2852 * src/modest-tny-folder.h:
2853 * src/modest-tny-folder.c:
2854 (modest_tny_folder_is_local_folder),
2855 (modest_tny_folder_get_local_folder_type),
2856 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2858 * src/widgets/modest-main-window.h:
2859 * src/maemo/modest-main-window.c: (create_details_widget),
2860 (modest_main_window_set_contents_style): Show details for any folder store,
2863 (modest_tny_folder_get_rules):
2864 Remove the const. C does not support constness enough for this.
2866 * src/modest-ui-actions.c:
2867 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2868 make all outboxes appear as one, in the usual local-folders tree node.
2870 (set_active_account_from_tny_account),
2871 (modest_ui_actions_on_folder_selection_changed):
2872 * src/widgets/modest-folder-view.c: (text_cell_data),
2873 (icon_cell_data), (filter_row),
2874 (add_account_folders_to_merged_folder),
2875 (add_account_folders_to_simple_folder_store), (),
2876 (get_cmp_rows_type_pos), (cmp_rows),
2877 (modest_folder_view_set_account_id_of_visible_server_account):
2878 Adjust to the new outbox system, using generic folder stores and folders
2879 in the GtkTreeModel.
2881 2007-05-23 Christian Kellner <ckellner@openismus.com>
2883 * src/modest-mail-operation.c:
2884 (modest_mail_operation_update_account):
2885 Use info->max_size instead of unintialized local var [small
2886 build fix]. (Added TODO to review that change since I don't
2889 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2891 * libmodest-dbus-client/libmodest-dbus-client.c:
2892 (libmodest_dbus_client_compose_mail): function added
2893 * src/dbus_api/modest-dbus-api.h:
2894 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2895 (on_compose_mail): Implementation of the SendAsMail functionality
2897 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2899 * src/modest-account-mgr.c:
2900 (modest_account_mgr_add_server_account): Set the secure-connection
2901 conf key for transport accounts as well as store accounts. I don't know
2902 why the if was there. For instance, this makes sure that we use SSL
2903 for the gmail preset from the easysetup wizard.
2905 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2907 * src/gnome/modest-main-window.c:
2908 (on_account_store_connecting_finished), (connect_signals):
2909 * src/maemo/modest-main-window.c:
2910 (on_account_store_connecting_finished), (connect_signals),
2911 (modest_main_window_new):
2912 Handle TnyAccountStore::connecting-finished instead of
2913 TnyDevice::connection-changed, because we cannot actually perform
2914 operations on accounts until TnyAccountStore has itself responded to
2915 the TnyDevice::connection-changed signal. This prevents a GError from
2917 Do not try to update at startup, because we (at least on scratchbox)
2918 already do an update at startup when the device goes online.
2919 This prevents a GError from tinymail.
2920 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2921 Added TODO about stopping simultaneous operations.
2923 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2925 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2926 * src/modest-mail-operation-queue.c:
2927 (modest_mail_operation_queue_remove):
2928 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2929 about where they happened.
2931 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2933 * src/modest-ui-actions.c:
2934 (modest_ui_actions_on_password_requested): Make sure that the remember
2935 output parameter is always TRUE.
2937 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2939 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2940 Show a OK/Cancel dialog if the error is a question, though we still do not
2941 know anything more about what we are asking the user.
2942 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2943 Fix an uninitialized variable (helper). This is a logic error, however.
2945 2007-05-21 Christian Kellner <ckellner@openismus.com>
2947 * src/modest-search.h:
2948 Correct bit shifting in the ModestSearchFlags enum.
2950 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2952 * src/modest-tny-account.c:
2953 (modest_tny_account_new_from_server_account): Do not use the lsub and
2954 check-all hard-coded IMAP options when using POP.
2956 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2958 * src/modest-tny-account.c:
2959 (modest_tny_account_new_from_server_account):
2960 Use NULL for the secure-auth method for POP when Password auth has been
2961 specified by the user, as we already do for IMAP. "auth=Login" causes
2962 an error from camel or the server.
2964 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2966 * src/maemo/modest-account-settings-dialog.c:
2967 (create_page_account_details),
2968 (modest_account_settings_dialog_set_account_name):
2969 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2970 for the leave-on-server checkbox, rathr than just the checkbox, when
2971 the protocol is not POP.
2973 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2975 * src/widgets/modest-account-view.c:
2976 * src/widgets/modest-account-view.h:
2977 Added modest_account_view_select_account() which will be useful later
2978 to asynchronously re-select the edited account.
2980 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2982 * src/maemo/modest-account-settings-dialog.c:
2983 (modest_account_settings_dialog_set_account_name):
2984 Automatically choose the port numbers based on the secure authentication
2985 methods, if they have not been chosen before.
2986 This fixes projects.maemo.org bug NB#56273 .
2988 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2990 * src/maemo/modest-main-window-ui.h:
2991 * src/modest-ui-actions.c:
2992 * src/modest-ui-actions.h:
2993 Connect the Tools/SMTP Servers menu item to
2994 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2995 SMTP servers dialog, as in the UI specification and saves changes when it
2996 is closed. This fixed projects.maemo.org bug NB#56305 .
2998 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3000 * src/maemo/modest-connection-specific-smtp-window.c:
3001 (modest_connection_specific_smtp_window_init):
3002 Use gtk_window_set_default_size() to make this window big enough, so
3003 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
3005 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3007 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3008 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3009 (modest_connection_specific_smtp_edit_window_init),
3010 Do not try to connect to a combobox signal before the combobox exists.
3011 This fixes the cras in projects.maemo.org bug NB#56288 .
3012 (modest_connection_specific_smtp_edit_window_get_settings):
3013 Remove the server_account_name parameter which was being checked for NULL
3014 though it was not used.
3016 * src/maemo/modest-connection-specific-smtp-window.c:
3017 (modest_connection_specific_smtp_window_fill_with_connections),
3018 (on_button_edit), (modest_connection_specific_smtp_window_init):
3019 Correct the number of treemodel columns to prevent a warning.
3020 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
3021 libconic does not work.
3023 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3025 * src/modest-tny-account.c:
3026 (modest_tny_account_new_from_server_account):
3027 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
3028 SMTP when "None" was chosen by the user. However, with my SMTP server that
3029 does not support ANONYMOUS, the emails do not leave the Outbox and I see
3032 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3034 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
3035 to explain the memory management issue with the ID in the ModestPair.
3037 * src/gnome/modest-account-assistant.c: (add_receiving_page),
3038 (add_sending_page), (modest_account_assistant_finalize):
3039 * src/gnome/modest-gnome-global-settings-dialog.c:
3040 (create_updating_page), (create_composing_page):
3041 * src/gnome/modest-msg-edit-window.c: (get_transports),
3042 (init_window), (modest_msg_edit_window_finalize),
3043 (modest_msg_edit_window_get_msg_data):
3044 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
3045 * src/gnome/modest-transport-widget.c:
3046 (modest_transport_widget_finalize), (smtp_configuration):
3047 * src/maemo/modest-maemo-global-settings-dialog.c:
3048 (create_updating_page), (create_composing_page):
3049 * src/maemo/modest-msg-edit-window.c: (get_transports),
3050 (init_window), (modest_msg_edit_window_finalize),
3051 (modest_msg_edit_window_get_msg_data),
3052 (modest_msg_edit_window_free_msg_data):
3053 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
3054 (modest_store_widget_finalize):
3055 * src/maemo/modest-transport-widget.c:
3056 (modest_transport_widget_finalize), (smtp_configuration):
3057 * src/modest-main.c: (send_mail):
3058 * src/widgets/modest-combo-box.h:
3059 * src/widgets/modest-global-settings-dialog-priv.h:
3060 * src/widgets/modest-global-settings-dialog.c:
3061 (modest_global_settings_dialog_finalize):
3062 * src/widgets/modest-msg-edit-window.h:
3063 Whenever using modest_combo_box_new(), keep the ModestPairList alive
3064 as long as the combo box, to prevent use of freed memory for the ID.
3066 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3068 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
3069 get_accounts(), to make this clearer. Do not check for the enabled gconf
3070 key, because we do not use this for server accounts (at least, not yet).
3071 This allows us to send email again.
3073 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3075 * src/maemo/modest-platform.c:
3076 (on_modest_conf_update_interval_changed), (modest_platform_init):
3077 Only respond to this particular key change. All these strcmp()s cannot be
3080 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3082 * src/maemo/modest-maemo-global-settings-dialog.c:
3083 (current_connection): Prevent a crash in scratchbox when
3084 ny_maemo_conic_device_get_current_iap_id() returns NULL.
3085 * src/maemo/modest-platform.c:
3086 (on_modest_conf_update_interval_changed), (modest_platform_init):
3087 Get the update interval from gconf and reset it when the gconf key changes.
3089 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3091 * src/modest-protocol-info.c:
3092 * src/modest-protocol-info.h: Adde enum-specific get functions,
3093 instead of using a ModestProtocolType enum parameter.
3095 * src/gnome/modest-account-assistant.c:
3096 * src/gnome/modest-store-widget.c:
3097 * src/gnome/modest-store-widget.h:
3098 * src/gnome/modest-transport-widget.c:
3099 * src/gnome/modest-transport-widget.h:
3100 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
3101 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
3102 * src/maemo/easysetup/modest-easysetup-wizard.c:
3103 * src/maemo/modest-account-settings-dialog.c:
3104 * src/maemo/modest-account-settings-dialog.h:
3105 * src/maemo/modest-store-widget.c:
3106 * src/maemo/modest-store-widget.h:
3107 * src/maemo/modest-transport-widget.c:
3108 * src/maemo/modest-transport-widget.h:
3109 * src/modest-account-mgr-helpers.c:
3110 * src/modest-account-mgr-helpers.h:
3111 * src/modest-account-mgr.c:
3112 * src/modest-account-mgr.h:
3113 * src/modest-tny-account.c:
3114 * src/modest-tny-folder.c:
3115 * src/widgets/modest-account-view.c:
3116 * src/widgets/modest-retrieve-combo-box.c:
3117 * src/widgets/modest-retrieve-combo-box.h:
3118 * src/widgets/modest-secureauth-combo-box.c:
3119 * src/widgets/modest-serversecurity-combo-box.c:
3120 * src/widgets/modest-serversecurity-combo-box.h:
3121 * tests/check_account-mgr.c:
3122 Use the specific functions, and use the re-renamed enum values for GNOME too.
3124 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3126 * src/modest-pair.h:
3127 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
3128 so we can get the second based on the first.
3130 * src/maemo/modest-account-settings-dialog.h:
3131 * src/maemo/modest-account-settings-dialog.c:
3132 Added get_supported_secure_authentication_methods(), though it is mostly
3133 commented-out for now until the necessary API is committed to tinymail.
3134 (modest_account_settings_dialog_set_account_name),
3135 (save_configuration): Request the supported authentication methods from the
3136 server, so we can choose a working method.
3138 * src/modest-tny-account-store.h:
3139 * src/modest-tny-account-store.c:
3140 (modest_tny_account_store_get_session): Rename from
3141 tny_account_store_get_session().
3143 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3145 * src/modest-protocol-info.h: Split the ModestProtocol enum
3146 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
3147 There was no need to have these unrelated values in one enum.
3149 * src/: many files: Adapted to changed enum. This makes the code a bit
3150 clearer, and the compiler could catch some errors.
3152 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3154 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3155 Show the detailed internal camel error message when an error happens
3156 during the configuration, so that our testers can give us more clues.
3157 For instance, in projects.maemo.org bug NB#56910 .
3159 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3161 * src/modest-tny-account.c:
3162 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
3163 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
3165 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3167 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3168 * src/maemo/modest-account-settings-dialog.c:
3169 (modest_account_settings_dialog_set_account_name),
3170 (save_configuration): For the incoming secure authentication checkbox,
3171 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
3172 the UI specification. PLAIN does not seem to be supported for most IMAP
3173 servers anyway, and I am not sure what it would mean.
3174 However, we probably need to discover which of the secure-authentication
3175 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
3176 * src/modest-account-mgr-helpers.c:
3177 (modest_account_mgr_get_server_account_data):
3179 * src/modest-tny-account.c:
3180 (modest_tny_account_new_from_server_account):
3181 Use tny_account_set_mech() to set secure-authentication methods,
3182 with some special-casing for IMAP, based on my observations of how
3185 * src/modest-account-mgr-helpers.h:
3186 * src/modest-account-mgr.c:
3187 * src/modest-defs.h: Comment that the URI is only used for local folders.
3189 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3191 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
3192 parameter const, just to be neat.
3193 * src/modest-text-utils.c: (modest_text_utils_inline):
3194 End g_strconcat() with NULL, as its documentation says. This is almost
3195 certainly the cause of my crash at startup on the device. Interestingly,
3196 valgrind doesn't tell us about these errors.
3198 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3200 * scripts/build-packages: Added more precise comments about how to use
3201 this script, though I still get this error:
3202 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
3203 error building tinymail
3205 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3207 * src/maemo/modest-main-window.c: (on_account_update):
3208 Very slight cleanup, hoping to make it simpler to discover what causes
3209 a crash here sometimes.
3211 * src/modest-tny-account.c:
3212 (modest_tny_account_new_from_server_account): Set the port. Added
3213 comments about the options and a TODO comment because I need to find out
3214 how to specify the secure authentication method.
3216 2007-05-11 Marcus Bauer <marcusb@openismus.com>
3218 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3219 changed CFlags paths form modest to libmodest
3221 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3223 * src/modest-account-mgr-helpers.c:
3224 (modest_account_mgr_get_server_account_data),
3225 (modest_account_mgr_free_server_account_data):
3226 * src/modest-account-mgr-helpers.h:
3227 * src/modest-account-mgr.c:
3228 (modest_account_mgr_add_server_account):
3229 * src/modest-defs.h:
3230 * src/modest-tny-account.c:
3231 (modest_tny_account_new_from_server_account):
3232 Determine the options for tny_camel_account_add_option() here,
3233 based on the settings, rather than storing them directly in gconf.
3235 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3237 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3238 Show a more friendly error dialog now that we expect (from the tinymail
3239 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3241 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3243 * src/maemo/modest-main-window.c: (on_account_update): Check that
3244 account_name is not NULL, to prevent a crash at startup that I am
3245 seeing on the N800. I do wonder why it is NULL.
3247 * src/maemo/easysetup/modest-easysetup-wizard.c:
3248 (create_page_user_details):
3249 * src/maemo/modest-account-settings-dialog.c:
3250 (create_page_user_details), (create_page_outgoing):
3251 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3252 (modest_connection_specific_smtp_edit_window_init):
3253 * src/modest-ui-actions.c:
3254 (modest_ui_actions_on_password_requested):
3255 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3256 might do something useful with the on-screen keyboard.
3258 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3260 * src/maemo/modest-main-window.c: (on_account_update):
3261 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3262 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3264 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3266 * src/modest-tny-account-store.c: (on_account_changed):
3267 Correct the signature of this signal handler.
3269 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3271 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3272 Show a HildonNote instead of a GtkDialog for Maemo.
3274 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3276 * src/widgets/modest-account-view.h:
3277 * src/widgets/modest-account-view.c: (on_account_changed),
3278 (on_account_removed). Added a boolean flag, set/unset by
3279 modest_account_view_block_conf_updates(),
3280 modest_account_view_unblock_conf_updates() to prevent unnecessary
3281 updates, but this is not very useful because the gconf notifications are
3282 so delays (maybe only on Maemo Bora).
3283 So auto-updating is turned off, and these functions do an explicit
3284 update when necessary.
3285 However, something else is still doing too much work when adding/removing
3286 accounts, probably in another part of the application.
3288 * src/maemo/modest-account-view-window.c:
3289 (on_delete_button_clicked), (on_edit_button_clicked),
3290 (on_new_button_clicked): Use the new functions.
3292 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3294 * src/modest-account-mgr-helpers.c:
3295 (modest_account_mgr_set_first_account_as_default):
3296 Sort the list of names alphabetically-by-title, so we choose the first one
3298 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3299 alphabetically by the title.
3301 This fixes projects.maemo.org bug NB#56418 .
3303 * src/modest-account-mgr-priv.c:
3304 (_modest_account_mgr_account_from_key):
3305 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3306 avoid a valgrind error, and possible random behaviour.
3308 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3310 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3311 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3312 tinymail documentation to say that this can be expected.
3313 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3314 pretty, and should not happen, but I would prefer to know when it does.
3316 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3318 * configure.ac: When using the older hildon version, probably on Bora,
3319 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3321 * src/widgets/modest-attachment-view.c:
3322 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3325 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3327 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3328 Implemented the prototype. Can be tested with
3329 tests/dbus_api/test_open_message:
3331 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3333 * src/modest-tny-account-store.c:
3334 (modest_tny_account_store_instance_init), (get_password):
3335 * src/modest-ui-actions.c:
3336 (modest_ui_actions_on_password_requested):
3337 Do not store the password in gconf, because this function is called
3338 for non-remembered passwords. Actually use the cached (in the hash map)
3339 password instead of releasing it.
3340 The password will now not be remembered if it is asked via the protected
3341 password dialog, as per the UI spec.
3343 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3345 * src/modest-defs.h:
3346 * src/modest-account-mgr-helpers.h:
3347 * src/modest-account-mgr-helpers.c:
3348 Added modest_server_account_get_username_has_succeeded(),
3349 modest_server_account_set_username_has_succeeded().
3350 (modest_server_account_set_username),
3351 Reset the has-succeeded flag if the username changes.
3353 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3354 * src/maemo/modest-connection-specific-smtp-window.c:
3355 (modest_connection_specific_smtp_window_save_server_accounts):
3356 Use modest_server_account_set_username() instead of using
3357 modest_conf_set_string() directly, so that the has-succeeded flag is always
3360 * src/modest-ui-actions.c:
3361 (modest_ui_actions_on_password_requested): Dim the username entry if
3362 the username has ever worked, as per the UI spec.
3364 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3366 * src/modest-tny-account-store.c: (get_password):
3367 * src/modest-ui-actions.c:
3368 (modest_ui_actions_on_password_requested):
3369 Allow the username to be changed too, though there is more work to
3370 be done on exactly how this behaves.
3372 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3374 * src/modest-account-mgr-helpers.h:
3375 * src/modest-account-mgr-helpers.c:
3376 Added modest_account_mgr_get_display_name(),
3377 modest_server_account_get_username(),
3378 modest_server_account_set_username(),
3379 modest_server_account_set_password(),
3380 modest_server_account_get_hostname() functions so we do not need to
3381 use the conf API directly.
3383 * src/maemo/modest-main-window.c: (connect_signals):
3384 Actually connect ot the ModestAccountStore::request-password signal,
3385 so that we show the dialog when the password is requested by Tinymail,
3386 for isntance if it is empty.
3388 * src/modest-marshal.list:
3389 * src/modest-tny-account-store.c:
3390 (modest_tny_account_store_class_init), (get_password),
3391 (modest_tny_account_store_alert):
3392 * src/modest-tny-account-store.h:
3393 * src/modest-ui-actions.h:
3394 * src/modest-ui-actions.c:
3395 (modest_ui_actions_on_password_requested):
3396 Change the signal parameters, so it is obvious that we are providing
3397 the non human-readable server name, and receiving both the username
3398 and password, though changing of the username is not yet implemented.
3399 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3400 for the GNOME version.
3402 This should fix the projects.maemo.org bug NB#56209, though it does not
3403 work on Bora, because the gconf_client_get() for the password fails
3404 immediately after we save it with gconf_client_set().
3406 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3409 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3410 caused an undefined symbol error:
3411 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3413 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3415 * src/modest-tny-account-store.c:
3416 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3417 using a GError instead of a string message, so we can translate it in
3420 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3422 * src/maemo/modest-address-book.c:
3423 (modest_address_book_check_names):
3424 * src/maemo/modest-msg-view-window.c:
3425 (modest_msg_view_window_clipboard_owner_change):
3426 * src/modest-init.c: (modest_init_init_ui):
3427 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3428 (update_folders_cb), (modest_mail_operation_update_account):
3429 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3430 (modest_ui_actions_on_msg_attachment_clicked),
3431 (modest_ui_actions_on_msg_recpt_activated):
3432 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3433 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3434 (modest_msg_view_search_next):
3435 * src/widgets/modest-recpt-editor.c:
3436 (modest_recpt_editor_on_button_release_event),
3437 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3438 g_message(). At this point we should only be seeing interesting errors on
3439 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3441 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3443 (modest_wizard_dialog_force_title_update):
3444 * src/maemo/easysetup/modest-wizard-dialog.h:
3445 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3446 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3447 can update the title when appropriate. Otherwise the title is wrong if the
3448 pages are added after adding the notebook to the dialog.
3449 This must be a problem in HildonWizardDialog too.
3450 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3452 * src/maemo/easysetup/modest-easysetup-wizard.c:
3453 (create_subsequent_customsetup_pages),
3454 (create_subsequent_easysetup_pages):
3455 Call modest_wizard_dialog_force_title_update() so that the title is
3456 correct even with GTK+ < 2.10.
3457 This fixes projects.maemo.org bug NB#56145 .
3459 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3461 * src/maemo/modest-platform.c:
3462 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3463 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3466 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3468 * src/widgets/modest-window.h:
3469 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3470 and modest_window_save_state(), which invokes it.
3472 * src/widgets/modest-window-mgr.h:
3473 * src/widgets/modest-window-mgr.c:
3474 Added modest_window_mgr_save_state_for_all_windows(), which calls
3475 the save_state vfunc on all registered windows, if implemented.
3477 * src/gnome/modest-msg-edit-window.c:
3478 * src/gnome/modest-msg-view-window.c:
3479 * src/maemo/modest-msg-edit-window.c:
3480 * src/maemo/modest-msg-view-window.c:
3481 * src/maemo/modest-main-window.c:
3482 Specify the existing save_settings functions as implementations of
3483 ModestWindow::save_state_func().
3485 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3486 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3487 enabling hibernation, for instance.
3489 We may need to do the same thing for restoring settings.
3492 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3494 * src/widgets/modest-window-mgr.c:
3495 * src/widgets/modest-window-mgr.h:
3496 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3497 modest_window_mgr_get_hibernation_is_prevented().
3499 * src/maemo/modest-main-window.c:
3500 (on_hildon_program_is_topmost_notify): Prevent hibernation
3501 (possible when the application goes to the background in the WM),
3502 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3504 * src/maemo/easysetup/modest-easysetup-wizard.c:
3505 (modest_easysetup_wizard_dialog_init):
3506 * src/maemo/modest-account-settings-dialog.c:
3507 (modest_account_settings_dialog_init):
3508 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3509 (modest_connection_specific_smtp_edit_window_init):
3510 * src/maemo/modest-connection-specific-smtp-window.c:
3511 (modest_connection_specific_smtp_window_init):
3512 * src/maemo/modest-signature-editor-dialog.c:
3513 (modest_signature_editor_dialog_init):
3514 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3515 prevent hibernation while any of these account settings dialogs are open.
3517 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3519 * src/maemo/Makefile.am:
3520 * src/maemo/modest-osso-state-saving.c:
3521 * src/maemo/modest-osso-state-saving.h: Added
3522 modest_osso_load_state() and modest_osso_save_state() though they do
3523 nothing now. They should iterate through all the open windows and load/save
3525 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3526 save state when closing.
3528 * src/maemo/modest-main-window.c:
3529 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3530 Add a notification handler for the HildonProgram::is-topmost property,
3531 so we can allow hibernation when the application goes into the background.
3532 But we still need to detect when the accounts setup windows are open so
3533 we can stop hibernation when they are open.
3534 To do this, I also added the main window the HildonProgram. This might have
3535 other side-effects/benefits, and should maybe be done for other windows.
3537 * src/maemo/modest-osso-autosave-callbacks.h:
3538 * src/maemo/modest-osso-autosave-callbacks.c:
3539 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3540 though it does not do anything yet, and we might never need this to do
3541 anything. For instance, we already save drafts.
3543 * src/maemo/modest-platform.c: (modest_platform_init):
3544 Specify the libosso auto-save callback.
3546 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3548 * src/maemo/modest-platform.c:
3549 (modest_platform_set_update_interval):
3550 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3551 aparently stays valid between application instances, so we can use this
3552 to remove and reset it later. According to a maemo-developers email from
3555 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3557 * configure.ac: Depend on libalarm for Maemo.
3559 * src/dbus_api/modest-dbus-api.h:
3560 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3561 (on_send_receive), (modest_dbus_req_handler):
3562 Handle a SEND_RECEIVE D-Bus method.
3564 * libmodest-dbus-client/libmodest-dbus-client.c:
3565 (libmodest_dbus_client_send_and_receive):
3566 * libmodest-dbus-client/libmodest-dbus-client.h:
3567 Add C convenience functions for calling the new D-Bus method.
3569 * src/modest-platform.h:
3570 * src/gnome/modest-platform.c:
3571 * src/maemo/modest-platform.c:
3572 Added modest_platform_set_update_interval(), which uses the
3573 alarmd API on Maemo.
3574 (modest_platform_init),
3575 Call modest_platform_set_update_interval(), using a hard-coded
3576 interval for now (until the global settings dialog is implemented),
3577 though I am not sure that this makes sense yet.
3579 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3581 * src/dbus_api/modest-dbus-callbacks.c:
3582 (modest_osso_cb_hw_state_handler):
3583 * src/dbus_api/modest-dbus-callbacks.h:
3584 * src/maemo/modest-platform.c: (modest_platform_init):
3585 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3586 in case this has some effect on the ability for Maemo to ping the
3589 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3591 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3592 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3593 warning. It is probably a logic error, but I need to fix the build.
3595 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3597 * src/modest-account-mgr.h:
3598 * src/modest-account-mgr.c:
3599 (modest_account_mgr_account_names): Add a gboolean enabled_only
3600 parameter, so we can get lists of onlt the enabled accounts.
3602 (modest_account_mgr_add_account),,
3603 (modest_account_mgr_account_with_display_name_exists):
3604 * src/maemo/modest-msg-edit-window.c: (get_transports):
3605 * src/modest-account-mgr-helpers.c:
3606 (modest_account_mgr_set_first_account_as_default):
3607 * src/modest-init.c: (init_default_account_maybe):
3608 * src/modest-tny-account-store.c: (get_accounts):
3609 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3610 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3611 * tests/check_account-mgr.c: (START_TEST):
3612 Provide the extra parameter, as appropriate.
3614 * src/widgets/modest-account-view.c: (update_account_view):
3615 Do not show disabled accounts (meaning that there is no way to
3616 enable/disable accounts in the UI (the feature is not in our UI
3617 specification), so we can use this internally only to mark unfinished
3618 or temporary account data.
3620 * src/maemo/easysetup/modest-easysetup-wizard.c:
3621 (create_account): Add boolean enable parameter, so we can specify FALSE
3622 to create the temporary account.
3623 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3624 (on_before_next): When finishing, when there is a temporary account, just
3626 Also, use a timeout to delay the showing of the dialog until gconf is likely
3627 to return correct information, due to a maemo gconf bug that is fixed in
3628 osso 1.1, but not yet in Bora.
3629 However, the dialog stays on screen after it is destroyed.
3631 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3632 for invalid data when cancelling. Use a hildon note instead of a dialog
3633 to complain about invalid data. Do not show the account-saved note if the
3634 account is disabled (a temporary account that will not really be saved for use
3637 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3639 * src/modest-account-mgr-helpers.h:
3640 * src/modest-account-mgr-helpers.c:
3641 Added modest_account_mgr_unset_default_account(),
3642 Added modest_account_mgr_set_first_account_as_default().
3644 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3645 If it was the default account, unset the default account name.
3647 * src/maemo/modest-account-view-window.c:
3648 (on_delete_button_clicked): If it was the default account,
3649 set the first remaining account as the default instead.
3651 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3652 a NULL account or a NULL default account, to prevent a crash. This should
3653 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3656 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3658 * src/widgets/modest-recpt-editor.c:
3659 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3660 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3661 TODO comment for this. This fixes the build.
3663 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3664 be the best place for it. This will in future update all auto-update accounts,
3665 rather than just the current/default account, when that gconf key exists.
3666 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3667 if there are no accounts, before calling do_send_receive().
3668 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3670 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3671 * src/maemo/modest-main-window-ui.h:
3672 * src/maemo/modest-main-window.c: (on_connection_changed),
3673 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3674 directly, becaue the signal handler does more.
3676 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3678 * src/modest-account-mgr-helpers.c:
3679 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3680 for the case that the account does not exist.
3682 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3683 (equivalent to the modest account name) rather than the tinymail account name
3684 (equivalent to the modest account title - human readable) to get the account data.
3685 Check for null account data to prevent the crash, and add a TODO comment saying that
3686 this needs fixing because it is using the server account name instead of the account name.
3688 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3690 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3691 * src/maemo/modest-account-settings-dialog.c: (show_error),
3693 Use hildon_note_new_information() for informative and error messages,
3694 which seems to be expected for Maemo applications (no documentation that I know of
3695 says this). I am surprised that there is no distinction between info and error
3698 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3700 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3701 it is easy to find where this is used.
3703 * src/maemo/easysetup/modest-easysetup-wizard.c:
3704 (create_page_welcome), (create_page_account_details),
3705 (create_page_user_details), (create_page_complete_easysetup),
3706 (create_page_custom_incoming), (create_page_custom_outgoing),
3707 (create_page_complete_custom):
3708 * src/maemo/modest-account-settings-dialog.c:
3709 (create_page_account_details), (create_page_user_details),
3710 (create_page_incoming), (create_page_outgoing):
3711 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3712 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3713 (modest_connection_specific_smtp_edit_window_init):
3714 * src/maemo/modest-connection-specific-smtp-window.c:
3715 (modest_connection_specific_smtp_window_init):
3716 * src/maemo/modest-signature-editor-dialog.c:
3717 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3718 and scrolling policy as per the Email Application Layout Guide, if I have
3721 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3723 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3724 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3725 which were empty, because these vfuncs have been removed from TnyAccountStore.
3726 This fixes the build.
3728 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3730 * src/maemo/modest-main-window.c:
3731 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3732 showing/hiding it. Added TODO because it probably should not be NULL.
3733 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3734 because unnecessary g_warnings() make degugging difficult.
3736 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3738 * src/maemo/modest-msg-edit-window.c:
3739 (modest_msg_edit_window_select_color),
3740 (modest_msg_edit_window_select_background_color): 2 const corrections and
3741 moving 2 #endifs before closing brackets, to fix the build.
3743 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3745 * src/maemo/easysetup/modest-easysetup-wizard.h:
3746 * src/maemo/easysetup/modest-easysetup-wizard.c:
3747 (modest_easysetup_wizard_dialog_finalize),
3748 (on_button_edit_advanced_settings), (create_page_complete_custom),
3749 (on_response), (create_account):
3750 Implement the Advanced Settings edit button, by saving the account information,
3751 for the Advanded Settings dialog to use directly from gconf, and removing it
3752 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3753 Bug #5533 in the projects.maemo.org bugzilla.
3755 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3757 * src/maemo/modest-msg-view-window.c:
3758 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3759 when opening a message window.
3761 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3763 * src/maemo/easysetup/modest-easysetup-wizard.c:
3764 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3767 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3768 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3769 gconf settings. I probably added more checks than necessary, but that is safer.
3771 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3772 variable to fix the build, but this seems to be used when it is still NULL.
3774 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3776 * src/modest-platform.h:
3777 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3778 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3779 * src/modest-main.c: Implement this function so we can avoid using
3780 maemo-specific API from cross-platform code.
3782 * src/modest-tny-account-store.c:
3783 (get_smtp_specific_transport_account_for_open_connection):
3784 * src/modest-ui-actions.c: (check_for_connection),
3785 (modest_ui_actions_on_item_not_found):
3786 Use modest_platform_connect_and_wait() and put #idefs around other
3787 maemo-specific code, because only maemo currently has a way to
3788 identify connection names.
3790 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3792 * src/modest-tny-account-store.h:
3793 * src/modest-tny-account-store.c:
3794 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3795 the connection-specific SMTP server settings in the configuration.
3797 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3799 * src/maemo/modest-main-window.c: (on_connection_changed),
3801 * src/modest-main.c: (main), (start_ui), (send_mail):
3802 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3803 that is what is intended.
3805 * src/modest-ui-actions.c: (action_send), (action_receive),
3806 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3807 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3808 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3809 SMTP server is used when it is specified.
3811 (modest_ui_actions_on_send_receive):
3812 Check that a connection is open before proceeding.
3813 Receive and then send, instead of vice-versa, as per the specification.
3815 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3817 * src/modest-mail-operation.c:
3818 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3819 though I guess it should be something other than NULL.
3821 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3823 * src/maemo/easysetup/modest-easysetup-wizard.c:
3824 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3825 combo twice, to avoid an g_warning and to make it visible again.
3826 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3827 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3828 (already intended) dereference when detaching, because we then recreate the menu.
3829 But I am not sure why the warning was happening, and it is possible that this is a memory
3832 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3834 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3835 and uri_parse_mailto() utility functions.
3836 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3838 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3840 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3842 * src/dbus_api/modest-dbus-api.h:
3843 * src/dbus_api/modest-dbus-callbacks.c:
3844 Use an idle callback to execute the modest code in the application's own thread.
3845 Remove the helloworld example method.
3846 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3847 parsed, and the open-message method is not implemented because this is not yet implemented in
3849 * libmodest-dbus-client/libmodest-dbus-client.c:
3850 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3851 (libmodest_dbus_client_open_message):
3852 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3854 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3855 body without crashing.
3857 * tests/dbus_api/Makefile.am:
3858 * tests/dbus_api/test_mail_to.c:
3859 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3861 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3863 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3864 Added file to fix the build. Sorry.
3866 * src/dbus_api/Makefile.am:
3867 * src/dbus_api/modest-dbus-api.h:
3868 * src/dbus_api/modest-dbus-callbacks.h:
3869 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3870 (modest_dbus_req_handler):
3871 Put constants in a separate header so it can be reused by the
3872 client library, without duplication
3874 * libmodest-dbus-client/Makefile.am:
3875 * libmodest-dbus-client/libmodest-dbus-client.c:
3876 (libmodest_dbus_client_call_helloworld),
3877 (libmodfest_dbus_client_send_mail),
3878 (libmodfest_dbus_client_mailto),
3879 (libmodfest_dbus_client_open_message):
3880 * libmodest-dbus-client/libmodest-dbus-client.h:
3881 (Partly) Implement a send_mail D-Bus method.
3883 * tests/dbus_api/Makefile.am:
3884 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3885 the send_email D-Bus method.
3887 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3891 * libmodest-dbus-client/Makefile.am:
3892 * libmodest-dbus-client/libmodest-dbus-client.c:
3893 * libmodest-dbus-client/libmodest-dbus-client.h:
3894 * tests/dbus_api/Makefile.am:
3895 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3896 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3898 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3900 * src/maemo/easysetup/modest-easysetup-wizard.c:
3901 (create_page_account_details):
3902 * src/maemo/modest-account-settings-dialog.c:
3903 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3904 widgets, because this might not be the default in future versions of the Maemo GTK+.
3905 However, I can not not get capitalization to work even in a simple test case.
3907 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3909 * src/maemo/easysetup/modest-easysetup-wizard.c:
3910 (create_page_custom_incoming), (create_page_custom_outgoing):
3911 * src/maemo/modest-account-settings-dialog.c:
3912 (create_page_account_details), (create_page_incoming),
3913 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3914 instead of using gtk_check_button_with_label(), so they are aligned like the other
3915 widgets, as per the UI spec.
3917 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3919 * src/maemo/easysetup/modest-easysetup-wizard.c:
3920 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3921 * src/widgets/modest-validating-entry.c:
3922 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3923 Modest prefix instead of an EasySetup prefix.
3925 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3927 * src/widgets/modest-validating-entry.h:
3928 * src/widgets/modest-validating-entry.c: (on_insert_text),
3929 Added easysetup_validating_entry_set_max_func(), used to set a callback
3930 to call when the max number of characters is reached. GtkEntry has a max-length
3931 already but is silent about it.
3933 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3934 (create_page_account_details), (create_page_user_details),
3936 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3937 (create_page_account_details), (create_page_user_details),
3938 (create_page_outgoing):
3939 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3940 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3941 the UI spec, when the user tries to enter more than the max number of characters.
3943 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3945 * src/maemo/easysetup/modest-easysetup-wizard.c:
3946 (create_page_user_details), (create_page_custom_incoming),
3947 (create_page_custom_outgoing):
3948 * src/maemo/modest-account-settings-dialog.c:
3949 (create_page_user_details), (create_page_incoming),
3950 (create_page_outgoing):
3951 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3952 (modest_connection_specific_smtp_edit_window_init):
3953 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3954 not appropriate. Bad Maemo-specific defaults!.
3956 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3958 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3959 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3960 (modest_signature_editor_dialog_set_settings):
3961 Disable the label and textview when the checkbox is disabled, and use the
3962 specified (UI spec) default signature text.
3964 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3966 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3967 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3969 * src/modest-defs.h:
3970 * src/modest-account-mgr-helpers.h:
3971 * src/modest-account-mgr-helpers.c:
3972 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3974 * src/maemo/Makefile.am:
3975 * src/maemo/modest-signature-editor-dialog.c:
3976 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3979 * src/maemo/modest-account-settings-dialog.h:
3980 * src/maemo/modest-account-settings-dialog.c:
3981 (modest_account_settings_dialog_finalize), (on_button_signature),
3982 (save_configuration): Use the new dialog when the Edit button is pressed, and
3983 save the changes if necessary, as per the UI spec.
3985 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3987 * src/maemo/Makefile.am:
3988 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3989 based on maemo-develoers email from Dirk.
3991 * src/maemo/easysetup/modest-easysetup-wizard.c:
3992 (create_page_welcome), (create_page_account_details),
3993 (create_page_user_details), (create_page_complete_easysetup),
3994 (create_page_custom_incoming), (create_page_custom_outgoing),
3995 (create_page_complete_custom),
3996 (modest_easysetup_wizard_dialog_init):
3997 * src/maemo/modest-account-settings-dialog.c:
3998 (create_page_account_details), (create_page_user_details),
3999 (create_page_incoming), (create_page_outgoing),
4000 (modest_account_settings_dialog_init):
4001 * src/maemo/modest-connection-specific-smtp-window.c:
4002 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
4004 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4006 * src/maemo/easysetup/modest-easysetup-wizard.c:
4007 (create_page_account_details), (create_page_custom_outgoing),
4008 (create_page_complete_custom):
4009 * src/maemo/modest-account-settings-dialog.c:
4010 (create_page_user_details), (create_page_incoming),
4011 (create_page_outgoing):
4012 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4013 (modest_connection_specific_smtp_edit_window_init):
4014 Use the correct (UI spec) port min/max, and use horizontal separators,
4017 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4019 * src/maemo/easysetup/modest-easysetup-wizard.c:
4020 (set_default_custom_servernames):
4021 * src/maemo/modest-account-settings-dialog.c:
4022 (create_page_incoming), (on_combo_outgoing_security_changed),
4023 (on_combo_incoming_security_changed), (create_page_outgoing),
4024 (modest_account_settings_dialog_set_account_name),
4025 (save_configuration):
4026 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4027 (on_combo_security_changed),
4028 (modest_connection_specific_smtp_edit_window_init),
4029 (modest_connection_specific_smtp_edit_window_set_connection),
4030 (modest_connection_specific_smtp_edit_window_get_settings):
4031 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
4034 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4037 * src/maemo/easysetup/modest-easysetup-wizard.c:
4038 (create_page_custom_outgoing), (create_page_complete_custom):
4039 * src/maemo/modest-account-settings-dialog.c:
4040 (create_page_user_details), (create_page_outgoing):
4041 * src/maemo/modest-account-view-window.c: (button_box_new):
4042 Use changed logical IDs as per the most recent UI spec:
4043 mcen_bd_emailsetup_edit -> mcen_bd_edit
4044 mcen_bd_emailsetup_delete -> mcen_bd_delete
4045 mcen_bd_emailsetup_close -> mcen_bd_close
4047 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4051 * src/dbus_api/Makefile.am:
4052 * src/dbus_api/modest-dbus-callbacks.c:
4053 * src/dbus_api/modest-dbus-callbacks.h:
4054 * src/maemo/modest-platform.c: (modest_platform_init):
4055 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
4057 * tests/Makefile.am:
4058 * tests/dbus_api/Makefile.am:
4059 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
4061 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4063 * src/maemo/modest-account-settings-dialog.c:
4064 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4065 Removed unnecessary includes.
4067 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4069 * src/maemo/easysetup/modest-easysetup-wizard.c:
4070 * src/maemo/modest-account-settings-dialog.c:
4071 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4072 * src/widgets/Makefile.am:
4073 * src/widgets/modest-easysetup-secureauth-combo-box.c:
4074 * src/widgets/modest-easysetup-secureauth-combo-box.h:
4075 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
4076 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
4077 * src/widgets/modest-secureauth-combo-box.c:
4078 * src/widgets/modest-secureauth-combo-box.h:
4079 * src/widgets/modest-serversecurity-combo-box.c:
4080 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
4081 made the GObject names more consistent with the rest of the Modest code.
4083 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4085 * src/maemo/easysetup/Makefile.am:
4086 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4087 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
4088 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4089 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4090 * src/maemo/easysetup/modest-easysetup-wizard.c:
4091 * src/maemo/easysetup/modest-validating-entry.c:
4092 * src/maemo/easysetup/modest-validating-entry.h:
4093 * src/maemo/modest-account-settings-dialog.c:
4094 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4095 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
4096 widgets/ because they are used outside of easysetup too. After checking in,
4097 svn will allow me to rename them too.
4099 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4101 * src/gnome/modest-msg-edit-window.c:
4102 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
4103 linker error, to fix the build on the GNOME platform.
4104 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
4105 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
4106 ifdefed out to avoid a warning.
4108 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4110 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
4111 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
4112 some alternative for GTK+ 2.6.
4114 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4116 * src/maemo/modest-address-book.c: Added include to avoid a warning.
4118 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
4119 specified for EmailAccountsDialog in UI spec.
4121 * src/maemo/easysetup/modest-easysetup-wizard.c:
4122 * src/maemo/easysetup/modest-easysetup-wizard.h:
4123 * src/maemo/modest-account-settings-dialog.c:
4124 * src/maemo/modest-account-settings-dialog.h:
4125 Reuse a member window widget for the connection-specific SMTP server accounts,
4126 so we can tell it to create/save the accounts only if we actually save changes.
4128 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4129 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4130 (modest_connection_specific_smtp_edit_window_get_settings):
4131 Return a struct instance for temporarily remembering the entered data.
4133 * src/maemo/modest-connection-specific-smtp-window.h:
4134 * src/maemo/modest-connection-specific-smtp-window.c:
4135 (modest_connection_specific_smtp_window_finalize),
4136 (modest_connection_specific_smtp_window_fill_with_connections),
4138 (modest_connection_specific_smtp_window_save_server_accounts),
4139 (update_model_server_names): Do not actually save data until asked,
4140 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
4142 (on_selection_changed),
4143 (modest_connection_specific_smtp_window_init): Disable the edit
4144 button when nothing is selected.
4146 * src/modest-account-mgr-helpers.c:
4147 * src/modest-account-mgr-helpers.h:
4148 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
4151 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4153 * src/modest-account-mgr-helpers.h:
4154 * src/modest-account-mgr-helpers.c:
4155 (modest_account_mgr_get_unused_account_name),
4156 (modest_account_mgr_get_unused_account_display_name): Added these
4157 utility functions, to avoid code duplication.
4159 * src/maemo/easysetup/modest-easysetup-wizard.c:
4160 (create_page_account_details), (create_account):
4161 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4162 (on_combo_security_changed),
4163 (modest_connection_specific_smtp_edit_window_init),
4164 (modest_connection_specific_smtp_edit_window_save_settings):
4165 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4166 * src/maemo/modest-connection-specific-smtp-window.c:
4167 (modest_connection_specific_smtp_window_finalize),
4168 (modest_connection_specific_smtp_window_fill_with_connections),
4169 (on_button_edit), (modest_connection_specific_smtp_window_init):
4170 * src/maemo/modest-connection-specific-smtp-window.h:
4171 Implementing saving of connection-specific server accounts.
4173 But I need to refactor this so we can save the data for each
4174 possible connection-specific account and only actually create the server accounts
4175 when the easysetup finished, or the OK button is pressed on the account settings
4178 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4180 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4181 (on_combo_security_changed):
4182 (modest_connection_specific_smtp_edit_window_init):
4183 Auto-fill the port number as in the account settings.
4185 (modest_connection_specific_smtp_edit_window_set_connection):
4186 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4187 * src/maemo/modest-connection-specific-smtp-window.c:
4188 (fill_with_connections), (on_button_edit),
4189 (modest_connection_specific_smtp_window_init):
4190 Turn the edit window into a dialog to simplify the code, and
4191 set a WM hint as in a GtkDialog, because only a popup can be on top of
4192 another window in Maemo, and popups usually have no WM decoration.
4194 * src/modest-defs.h:
4195 * src/modest-account-mgr-helpers.c:
4196 (modest_account_mgr_set_connection_specific_smtp),
4197 (modest_account_mgr_remove_connection_specific_smtp),
4198 (modest_account_mgr_get_connection_specific_smtp):
4199 * src/modest-account-mgr-helpers.h: Some functions to write the
4200 connection-specific SMTP server information. Not yet used.
4203 * src/widgets/modest-folder-view.c: (text_cell_data):
4204 Fix a warning about an uninitialized variable.
4205 (on_configuration_key_changed): Put an #ifdef around the use
4206 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
4208 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4210 * src/maemo/modest-account-settings-dialog.h:
4211 * src/maemo/modest-account-settings-dialog.c:
4212 Added connect_for_modified() utility function to mark the new modified boolean.
4214 (create_page_account_details), (create_page_user_details),
4215 (create_page_incoming), (create_page_outgoing), (on_response),
4216 (modest_account_settings_dialog_init),
4217 (modest_account_settings_dialog_set_account_name):
4218 Only warn about unsaved changes when there are actually unsaved changes.
4220 * src/modest-account-mgr-helpers.c:
4221 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
4222 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
4223 to get the data from there in future.
4225 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4227 * src/modest-defs.h:
4229 * src/modest-account-mgr-helpers.h:
4230 * src/modest-account-mgr-helpers.c:
4231 Store the security account setting in a single conf key instead of using
4232 the options list, so that the list is left for just the to-be-removed camel hack,
4233 and because gconf_client_set_list() is failing for some reason.
4235 * src/modest-account-mgr.c:
4236 (modest_account_mgr_add_server_account):
4237 * src/maemo/modest-account-settings-dialog.c:
4238 (modest_account_settings_dialog_set_account_name),
4239 (save_configuration): Use the renamed functions.
4242 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4244 * src/widgets/Makefile.am:
4245 * src/widgets/modest-limit-retrieve-combo-box.c:
4246 * src/widgets/modest-limit-retrieve-combo-box.h:
4247 * src/widgets/modest-retrieve-combo-box.c:
4248 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4249 the account settings dialog.
4251 * src/modest-defs.h:
4252 * src/modest-account-mgr-helpers.h:
4253 * src/modest-account-mgr-helpers.c:
4254 (modest_server_account_get_option_secure_auth),
4255 (modest_server_account_set_option_secure_auth):
4256 * src/modest-account-mgr.c:
4257 (modest_account_mgr_add_server_account):
4258 Use the existing AUTH_MECH conf key for the secure-auth setting,
4259 instead of putting it in the list options, because this was actually used already.
4261 * src/maemo/modest-account-settings-dialog.c:
4262 (create_page_account_details),
4263 (modest_account_settings_dialog_set_account_name),
4264 (save_configuration):
4265 * src/maemo/modest-account-settings-dialog.h:
4266 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4267 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4269 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4271 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4272 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4273 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4275 * src/modest-defs.h:
4276 * src/maemo/modest-account-settings-dialog.c:
4277 (create_page_incoming), (on_combo_outgoing_security_changed),
4278 (on_combo_incoming_security_changed), (create_page_outgoing),
4279 (modest_account_settings_dialog_set_account_name),
4280 (save_configuration): Load/Save the port number, and change it when the
4281 security combo changes, to suitable defaults.
4283 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4285 * src/modest-account-mgr.c:
4286 (modest_account_mgr_add_server_account): Set the security and secure-auth
4287 options, and add a comment saying that the other camel-specific options should be
4290 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4292 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4294 * src/modest-tny-account-store.c: (account_list_free),
4295 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4296 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4299 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4301 * src/modest-protocol-info.c:
4302 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4303 is required by our UI spec. Maybe something in our implementation will use this eventually.
4304 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4305 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4306 instead of the previous 0 placeholder.
4308 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4309 secure-auth settings.
4310 * src/modest-account-mgr-helpers.h:
4311 * src/modest-account-mgr-helpers.c:
4312 (modest_server_account_data_get_option_secure_auth),
4313 (modest_server_account_set_option_secure_auth),
4314 (modest_server_account_data_get_option_security),
4315 (modest_server_account_set_option_security): Added this API for getting and setting the security
4316 and secure-auth settings.
4318 * src/maemo/modest-account-settings-dialog.h:
4319 * src/maemo/modest-account-settings-dialog.c:
4320 (modest_account_settings_dialog_finalize), (check_data),
4321 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4322 about changing titles.
4323 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4324 (save_configuration): Save the security and secure-auth settings.
4326 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4327 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4329 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4331 * src/modest-defs.h:
4332 * src/modest-account-mgr.c:
4333 (modest_account_mgr_add_server_account):
4334 Added and used defines for the options key and value pair strings,
4335 that are used so far, though they do not seem to correspond to anything in our
4336 UI specs or ModestProtocol enum.
4338 * src/modest-account-mgr-helpers.h:
4339 * src/modest-account-mgr-helpers.c:
4340 (compare_option_strings_for_name),
4341 (modest_server_account_data_get_option_value),
4342 (modest_server_account_data_get_option_bool),
4343 (modest_account_mgr_get_server_account_option):
4344 Added helper functions for parsing the options GSList.
4346 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4348 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4349 display name is based on the supplied account name.
4350 * src/modest-account-mgr.c:
4351 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4352 with an inefficient, but good-enough, implementation.
4354 * src/maemo/easysetup/modest-easysetup-wizard.c:
4355 (create_page_account_details), (on_before_next), (create_account):
4356 Check for existing display names rather than (non-user-visible) account names, and just
4357 create and set a unique account name at the end.
4359 * src/maemo/modest-account-settings-dialog.c:
4360 (modest_account_settings_dialog_init),
4361 (modest_account_settings_dialog_set_account_name),
4362 (create_page_incoming): Show the display name, instead of the account name.
4363 (on_response): Do some (not all) extra checks, as in the UI spec.
4364 (save_configuration): Save the display name if it was changed.
4366 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4368 * po/en_GB.po: Added needed logical ID and translation.
4369 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4370 (init_view): Made the is-default column clicking work.
4372 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4375 * src/maemo/easysetup/Makefile.am:
4376 * src/maemo/easysetup/modest-easysetup-wizard.c:
4377 (modest_easysetup_wizard_dialog_init):
4378 * src/maemo/easysetup/provider-data-test.keyfile:
4379 * src/maemo/easysetup/provider-data.keyfile:
4380 Moved the provider data file to the new modest-providers-data package and used it from there.
4382 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4384 * src/modest-local-folder-info.c:
4385 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4386 N_() was already used on the static strings, but this just marks it for translation without
4387 using the translation.
4389 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4391 * src/maemo/modest-account-settings-dialog.c:
4392 (create_page_incoming),
4393 (modest_account_settings_dialog_set_account_name):
4394 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4395 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4396 I will do this if nobody else gets there first.
4398 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4400 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4401 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4402 save the security stuff.
4404 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4406 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4407 Set the email address and user fullname, which I now see must be
4410 * src/maemo/modest-account-settings-dialog.h:
4411 * src/maemo/modest-account-settings-dialog.c:
4413 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4414 leave-on-server and authentication.
4415 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4418 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4421 * src/maemo/modest-account-settings-dialog.c:
4422 * src/maemo/modest-account-settings-dialog.h:
4423 Most (but not all) of the widgets are now present as specified by the UI spec.
4424 No changes are yet saved, and some details are not properly shown yet.
4426 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4428 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4430 * src/maemo/Makefile.am:
4431 * src/maemo/modest-account-settings-dialog.c:
4432 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4433 an existing account. Doesn't do much yet.
4435 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4436 Open the accounts settings dialog when Edit is clicked.
4438 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4440 * src/maemo/easysetup/Makefile.am:
4441 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4443 * src/maemo/easysetup/modest-easysetup-wizard.c:
4444 (modest_easysetup_wizard_dialog_init):
4445 Try to get the source directory from the build system,
4446 instead of hard-coding "./" into the source code, when opening our local
4447 copies of the configuration files.
4448 But this still fails when opening the wizard from the Accounts window,
4449 maybe because the working directory seems to change at runtime.
4450 So the wizard will fail the second time unless you copy the files into their
4451 proper locations - see the stdout warnings for the paths.
4453 (create_page_account_details),(on_before_next):
4454 Check for existing non-server accounts instead of server accounts,
4455 so the default account name is useful again, and to prevent trying to
4458 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4459 Show the wizard when New is clicked.
4461 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4462 (init_view): Show the column headers, and show the columns that are
4463 specified in the UI specs. However, something in Maemo's GTK+ prevents
4464 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4465 change the default account. This is despite unsetting the special properties.
4467 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4469 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4470 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4471 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4472 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4473 to make that clearer.
4474 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4476 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4478 * src/maemo/modest-account-view-window.c:
4479 (modest_account_view_window_init),
4480 (modest_account_view_window_new):
4481 Use the same buttons as specified in the
4482 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4483 the existing widgets, which never had a chance of working.
4484 Put the ModestAccountView treeview in a scrolled window.
4485 Do not repeat the initialization in both _init() and _new().
4487 * src/widgets/modest-account-view.c: (update_account_view):
4488 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4489 this widget and window shows no accounts.
4491 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4493 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4495 * src/maemo/easysetup/modest-easysetup-wizard.c:
4496 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4497 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4498 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4501 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4502 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4503 accounts exist yet, as in the UI spec.
4505 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4507 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4509 * src/maemo/Makefile.am:
4510 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4511 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4512 New window for editing connection-specific smtp details.
4513 Not fully implemented.
4515 * src/maemo/modest-connection-specific-smtp-window.c:
4516 (modest_connection_specific_smtp_window_finalize) :
4517 unref the tree model.
4518 (on_button_edit): Show the edit window.
4520 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4522 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4525 * src/maemo/Makefile.am:
4526 * src/maemo/modest-connection-specific-smtp-window.c:
4527 * src/maemo/modest-connection-specific-smtp-window.h:
4528 New window for showing the list of connections, for connection-specific
4529 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4530 * src/maemo/easysetup/modest-easysetup-wizard.c:
4531 (create_page_custom_outgoing): Show the new window when the button is clicked.
4533 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4535 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4536 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4537 * src/maemo/modest-msg-edit-window.c:
4538 (modest_msg_edit_window_insert_image):
4539 * src/modest-conf.c: (modest_conf_key_escape):
4540 * src/modest-mail-operation.c:
4541 (modest_mail_operation_send_new_mail):
4542 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4543 (modest_ui_actions_on_new_account):
4544 * src/widgets/modest-attachment-view.c: (update_filename_request):
4545 * src/widgets/modest-mail-header-view.c:
4546 Corrected warnings that were breaking the build, by commenting out unused variables,
4547 and a function, and by including a header.
4549 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4551 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4552 so we can #ifdef around platform-specific code when necessary.
4553 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4554 to allow this to build for the GNOME platform too.
4556 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4558 * src/maemo/easysetup/modest-easysetup-wizard.c:
4559 Added util_increment_name() and used it in create_page_account_details()
4560 to make sure that the default account name is always a new name.
4562 (modest_easysetup_wizard_dialog_init),
4563 (set_default_custom_servernames): Some minor memory management fixes.
4565 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4569 * src/modest-runtime.c: (init_i18n): Restored the translation
4570 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4571 are defined in config.h, and the translations are installed.
4573 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4574 is defined for translation.
4576 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4578 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4580 * src/maemo/easysetup/modest-easysetup-wizard.c:
4581 (modest_easysetup_wizard_dialog_init):
4582 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4583 Use realistic paths (though they should use $prefix generically) to the
4584 mcc_mapping and provider-data.keyfile files which might work when they
4585 are installed by the future version of the operator-wizard package,
4586 and then fallback to paths in our source code, with an explanatory
4589 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4593 * src/maemo/Makefile.am:
4594 * src/maemo/easysetup/: Added files from the previously-exernal
4595 osso-modest-easysetup.
4596 * src/maemo/modest-main-window-ui.h:
4597 * src/modest-ui-actions.c:
4598 * src/modest-ui-actions.h:
4599 Added modest_ui_actions_on_new_account() as a signal handler for the
4600 New Account menu item. It shows the easysetup wizard.
4601 * po/en_GB.po: Added additional needed logical IDs and translations.