1 2007-08-24 Armin Burgmeier <armin@openismus.com>
3 * src/modest-widget-memory.c: Always show the default account when the
4 application is started, as stated in the UI spec. This fixes
5 projects.maemo.org bug NB#66630.
7 2007-08-24 Armin Burgmeier <armin@openismus.com>
9 * src/maemo/modest-platform.c:
10 (modest_platform_run_rename_folder_dialog): Use logical IDs instead of
11 english text for strings in the rename folder dialog, fixing
12 projects.maemo.org bug NB#66338.
14 2007-08-22 Armin Burgmeier <armin@openismus.com>
16 * src/widgets/modest-account-view.c: Fix for bora by using
17 MODEST_HAVE_HILDON0_WIDGETS instead of MODEST_HILDON_VERSION_0. The
18 latter seems not be used anymore.
20 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c: Some
23 * src/maemo/modest-main-window.c: Update menu items when the default
24 account changes so that the current default account is always bolded.
25 This fixes maemo.projects.org bug NB#66173.
27 2007-08-17 Murray Cumming <murrayc@murrayc.com>
29 * src/dbus_api/modest-dbus-callbacks.c:
30 (on_dbus_method_get_folders): Avoid trying to get the account name
31 when there are no accounts, to avoid critical g_warnings, fixing
32 projects.maemo.org bug NB#65574.
34 2007-08-17 Murray Cumming <murrayc@murrayc.com>
36 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg):
37 Use modest_account_mgr_get_signature() instead of accessing gconf
38 directly, to slightly simplify the code.
39 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
40 Append the signature also when opening via other applications,
41 fixing projects.maemo.org bug NB#65828.
43 2007-08-17 Murray Cumming <murrayc@murrayc.com>
45 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_msg_id):
46 Check for NULLs to prevent a crash when opening an email that is
47 an attachment in another email, fixing projects.maemo.org bug
50 2007-08-17 Murray Cumming <murrayc@murrayc.com>
52 * src/modest-ui-dimming-rules.c:
53 (modest_ui_dimming_rules_on_view_window_move_to):
54 Enable the Move To toolbar button for search results, fixing the
55 last part of projects.maemo.org bug NB#63807.
57 2007-08-17 Murray Cumming <murrayc@murrayc.com>
59 * src/dbus_api/modest-dbus-callbacks.c:
60 (check_and_offer_account_creation): Use gdk_thread_enter/leave(),
61 because this is called from idle handlers, to fix hangs afte the
63 (find_message_by_url): Added a TODO comment about a crash that
64 happens when tinymail was built with DBC checks.
66 2007-08-16 Murray Cumming <murrayc@murrayc.com>
68 * src/modest-search.c: (modest_search_folder):
69 * src/modest-search.h: Rename ModestSearch::before to start_date
70 and after to end_date, using the same names as the libogs struct
72 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
73 The start_date and end_date were swapped in the check. This
74 fixes date range searches, fixing projects.maemo.org bug NB#63407.
76 2007-08-16 Murray Cumming <murrayc@murrayc.com>
78 * src/maemo/modest-account-view-window.c:
79 Added (check_for_active_acount).
80 (on_delete_button_clicked), (on_edit_button_clicked):
81 When an account is doing something (such as refreshing),
82 show the same warning for account deletion as for account
83 editing, to fix projects.maemo.org bug NB#64588.
85 2007-08-16 Murray Cumming <murrayc@murrayc.com>
87 * src/widgets/modest-msg-view-window.h:
88 * src/gnome/modest-msg-view-window.c:
89 * src/maemo/modest-msg-view-window.c:
90 Added modest_msg_view_window_construct().
91 (modest_msg_view_window_new_with_header_model),
92 Added modest_msg_view_window_new_for_search_result),
93 Renamed modest_msg_view_window_new() to
94 modest_msg_view_window_new_for_attachment(),
95 and modest_msg_view_window_is_search_result(),
96 so we can explicitly know that the window is for an
97 attachment or a search result or a message from the list.
99 (modest_msg_view_window_view_attachment):
100 * src/modest-ui-actions.c: (open_msg_cb): Use the renamed function.
101 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
102 Use modest_msg_view_window_new_for_search_result().
104 * src/modest-ui-dimming-rules.c:
105 (modest_ui_dimming_rules_on_delete_msg): Enable the delete button
106 for search results, fixing projects.maemo.org bug NB#63811.
108 2007-08-16 Armin Burgmeier <armin@openismus.com>
110 * src/modest-ui-actions.c: Show a banner instead of a dialog when
111 renaming a folder fails, to stay consistent with what happens when
112 creating a folder fails.
114 * src/maemo/easysetup/modest-easysetup-country-combo-box.c: Optimized
115 slightly country loading from the mmc_mappings file, fixed a memory
118 2007-08-16 Murray Cumming <murrayc@murrayc.com>
120 * src/modest-tny-account-store.c: (volume_path_is_mounted):
121 Check the GnomeVFSVolume activation path instead of the device path,
122 so that the memory card is really really shown in the UI.
124 2007-08-16 Murray Cumming <murrayc@murrayc.com>
126 * src/maemo/easysetup/modest-easysetup-wizard.c:
127 (get_entered_account_title), (on_before_next), (entry_is_empty),
129 * src/maemo/modest-account-settings-dialog.c:
130 (get_entered_account_title), (on_button_signature), (check_data),
131 (save_configuration), (entry_is_empty):
132 Strip the account title of whitespace at the start and end before
133 using it or checking it. This means that an all-whitespace title
134 is not allowed, fixing projects.maemo.org bug NB#64977.
136 2007-08-15 Murray Cumming <murrayc@murrayc.com>
138 * src/modest-ui-actions.h:
139 * src/modest-ui-actions.c: Renamed modest_run_account_setup_wizard()
140 to modest_run_account_setup_wizard() and made it public.
141 * src/dbus_api/modest-dbus-callbacks.c:
142 (check_and_offer_account_creation), (on_idle_mail_to),
143 (on_idle_compose_mail), (on_idle_open_default_inbox):
144 Offer account creation if necessary, fixing projects.maemo.org
147 2007-08-15 Murray Cumming <murrayc@murrayc.com>
149 * src/modest-ui-actions.c: (run_account_setup_wizard):
150 Return a gboolean to indicate success.
151 (modest_ui_actions_on_new_msg), (open_msg_cb), (reply_forward),
152 (modest_ui_actions_on_send): When offering account creation, only
153 give up (return) if account creation failed. Otherwise continue
154 with the original request. This fixed projects.maemo.org bug
157 2007-08-15 Murray Cumming <murrayc@murrayc.com>
159 * src/widgets/modest-recpt-editor.c:
160 (modest_recpt_editor_instance_init): Turn off hildon auto-capitalization,
161 to fix projects.maemo.org bug NB#63789.
163 2007-08-15 Murray Cumming <murrayc@murrayc.com>
165 * src/modest-tny-account-store.c: Added volume_path_is_mounted().
166 (modest_tny_account_store_new): Properly detect the memory card at
167 startup, and add an account for it.
169 2007-08-14 Murray Cumming <murrayc@murrayc.com>
171 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
172 Commented out the MMC code again because it mistakenly detects
173 the card even when it isn't inserted.
175 2007-08-14 Murray Cumming <murrayc@murrayc.com>
177 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
178 Renabled the call to add_mmc_account() because I do not believe
179 it could be the cause of the mentioned hang (in scratchbox, where
180 there is no memory card), and because I have tested that it works
183 2007-08-14 Murray Cumming <murrayc@murrayc.com>
185 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
186 Comment out part of the last commit because it apparently causes
189 2007-08-14 Murray Cumming <murrayc@murrayc.com>
191 * src/modest-tny-account-store.c: Added the add_mmc_account()
192 function to save some copy/pasting.
193 (modest_tny_account_store_new): If the memory card is mounted,
194 create an account for it at the start, instead of waiting for the
195 user to unmount it and mount it.
197 2007-08-13 Murray Cumming <murrayc@murrayc.com>
199 * src/widgets/modest-account-view.c: (on_account_changed):
200 Do not try to use the human-readable TnyAccount name instead of the
201 ID of the modest account to get the transport account. And unref
202 the transport account. This prevents a g_warning(), and a possible
205 2007-08-13 Murray Cumming <murrayc@murrayc.com>
207 * src/maemo/modest-platform.c:
208 (modest_platform_set_update_interval): Handle the new
209 alarmd error to warn when alarmd is not running, as is the case in
210 scratchbox for me now because
211 "Module /usr/lib/alarmd/libretu.so initialization failed"
213 2007-08-13 Murray Cumming <murrayc@murrayc.com>
215 * src/widgets/modest-header-view-render.c:
216 (_modest_header_view_compact_header_cell_data):
217 NULL some strings after freeing them, trying to deal with
218 the double deletion found in projects.maemo.org bug 64183,
219 probably having no effect.
221 2007-08-13 Murray Cumming <murrayc@murrayc.com>
223 * src/maemo/modest-account-settings-dialog.c:
224 (create_page_incoming), (create_page_outgoing): Use a define
225 for the min and max port numbers.
227 (check_hildon_number_editor_and_warn_value_not_in_range),
228 (check_data): Do an extra check for an invalid port number, as needed
229 in projects.maemo.org bug #64275, when the number is cleared, but this
230 does not work due to bugs.maemo.org bug #1806.
232 2007-08-13 Murray Cumming <murrayc@murrayc.com>
234 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
235 Comment out the debug warning about the unexpected D-Bus methods.
236 They are just annoying now.
237 * src/maemo/modest-platform.c:
238 (modest_platform_set_update_interval): Correct the D-Bus path, instead
239 of using a file path, though it did not seem to break things before.
240 It might be needed now:
241 Use the ALARM_EVENT_ACTIVATION flag so that emails are updated even when
242 modest is not already running. This is the behaviour of the old client, and
243 Mox says it is what we should do for modest.
244 This closes projects.maemo.org bug NB#64327.
246 2007-08-04 Johannes Schmid <johannes.schmid@openismus.com>
248 * src/modest-text-utils.c:
249 Fixed invalid jump due to incorrect string/pointer
251 (See https://projects.maemo.org/trac/email/wiki/ValgrindErrors
254 2007-08-01 Murray Cumming <murrayc@murrayc.com>
256 * src/modest-account-mgr-helpers.h:
257 * src/modest-account-mgr-helpers.c:
258 Added modest_account_mgr_get_first_account_name(),
259 using code from modest_account_mgr_set_first_account_as_default().
261 * src/maemo/modest-main-window.c: Added set_at_least_one_account_visible().
262 (account_number_changed): Call set_at_least_one_account_visible() so that
263 the first account is visible when first added, without the user having to
265 I do wonder how this worked before.
267 2007-08-01 Murray Cumming <murrayc@murrayc.com>
269 * src/modest-tny-account-store.c: (show_password_warning_only),
270 (show_wrong_password), (request_password_and_wait), (get_password),
271 (modest_tny_account_store_alert): Remove the (incomplete anyway)
272 attempts to show UI only in the main context, which used g_idle_add()
273 and mainloops, because tinymail now guarantees that it only calls these
274 callbacks in the mainloop with the gdk lock. This makes everything much
277 2007-08-01 Murray Cumming <murrayc@murrayc.com>
279 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
280 Handle TNY_ACCOUNT_ERROR_TRY_CONNECT_SERVICE_UNAVAILABLE in the same
281 way as TNY_ACCOUNT_ERROR_TRY_CONNECT_HOST_LOOKUP_FAILED, showing an
282 error dialog, instead of ignoring it.
284 2007-08-01 Murray Cumming <murrayc@murrayc.com>
286 * src/maemo/modest-msg-view-window.c:
287 (modest_msg_view_window_get_header),
288 (modest_msg_view_window_last_message_selected):
289 Added comments to explain the use of priv->header_model.
290 * src/modest-ui-dimming-rules.c:
291 (modest_ui_dimming_rules_on_open_msg),
292 (modest_ui_dimming_rules_on_mark_as_read_msg),
293 (modest_ui_dimming_rules_on_mark_as_unread_msg),
294 (modest_ui_dimming_rules_on_remove_attachments),
295 (_invalid_attach_selected), (_selected_msg_marked_as):
296 Renamed _marked_as_deleted() to _selected_message_is_marked_as_deleted(),
297 and changed the parameter to a ModestMainWindow to make it clearer that
298 it never uses any other kind of window.
299 Added _message_is_marked_as_deleted() for examining a ModestMsgViewWindow
300 instead of the selected message.
301 I notice that much of the dimming code and the ModestMsgViewWindow code
302 hard-codes the assumption that the viewed message is always selected in
303 the header view. This does not seem wise or simple.
305 (modest_ui_dimming_rules_on_delete_msg): For a ModestMsgViewWindow,
306 examine the actual message instead of whatever might be selected
307 in the header view. This stops the delete toolbar button and menu item
308 from being dimmed when opening a message view the search UI,
309 partially fixing projects.maemo.org bug NB#63811.
311 However, when actually deleting, I now get this warning:
312 "tny_header_set_flags: This is a header instance for a new message.
313 Only priority and attachment flags are supported"
315 2007-07-30 Johannes Schmid <johannes.schmid@openismus.com>
317 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
319 Show account wizard if no accounts are defined while sending
320 (automatic sending after the account wizard finished does not
321 work because it takes some time until the account manager
322 synchronizes everything. (projects.maemo.org NB#62792)
324 2007-07-30 Murray Cumming <murrayc@murrayc.com>
326 * src/modest-tny-account-store.c: (on_account_removed),
327 (on_account_changed): Emit the ACCOUNT_UPDATE signal so that the
328 account is removed from the View menu. We have TnyAccountStore
329 and ModestTnyAccountStore signals that seem very similar, but this
330 seems to work for now.
332 * src/maemo/modest-main-window.c:
333 (on_show_account_action_activated): Prevent dereference
334 of a NULL if the accoutn does not really exist, though that
335 should not happen anymore.
337 This fixes projects.maemo.org bug NB#64606.
339 2007-07-30 Murray Cumming <murrayc@murrayc.com>
341 * src/modest-ui-actions.c: (run_account_setup_wizard),
342 (modest_ui_actions_on_accounts): Revert a change that set these
343 to modal dialogs, freezing the UI when they show secondary dialogs.
344 This fixed projects.maemo.org bug NB#64519.
346 2007-07-27 Murray Cumming <murrayc@murrayc.com>
348 * src/widgets/modest-header-view-render.c:
349 (_modest_header_view_compact_header_cell_data):
350 Some checks and initialization to try to deal with a crash,
351 probably ineffective.
353 2007-07-27 Murray Cumming <murrayc@murrayc.com>
355 * src/maemo/modest-maemo-utils.c:
356 (modest_maemo_utils_get_supported_secure_authentication_methods):
357 Make sure that we have a connection, asking the user for one
359 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
360 Check for a connection before showing the wizard, because
361 the wizard needs a connection to check for server capabilities.
363 2007-07-27 Murray Cumming <murrayc@murrayc.com>
365 * src/maemo/modest-account-view-window.c:
366 (on_new_button_clicked): Remember the wizard dialog instance,
367 so we can just present it again if necessary. This prevents
368 multiple windows from appearing if you click again quickly on the
369 New button before the dialog appears, fixing projects.maemo.org
372 2007-07-27 Murray Cumming <murrayc@murrayc.com>
374 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
375 Offer a connection dialog if there is no connection when
376 starting modest. This should fix projects.maemo.org bug NB#61134.
378 2007-07-27 Murray Cumming <murrayc@murrayc.com>
380 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
381 Reverted my last commit. I was able to fix the build by doing
382 apt-get install wpeditor0 (replacing other wpeditor packages) and
383 an explicit apt-get install wpeditor-dev to upgrade the -dev
386 2007-07-27 Murray Cumming <murrayc@murrayc.com>
388 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
389 Commented out the use of wp_text_buffer_replace_image()
390 because it does not exist, to break the build. Added a TODO for it.
392 2007-07-26 Murray Cumming <murrayc@murrayc.com>
394 * src/modest-tny-account-store.c: (recreate_all_accounts):
395 Recreate them even if they were NULL before. I guess something
396 else was already creating them before, or this would never
398 (modest_tny_account_store_get_server_account): Make sure that
399 the tny accounts have been created before trying to find one.
400 This allows libmodest_dbus_client_compose_mail() to work
401 when the UI is not yet visible.
402 This is probably useful in other cases too.
404 (get_password): When the password is wrong after it is entered
405 in the protected password dialog, show an info banner (in an
406 idle handler) before showing the protected password dialog
409 2007-07-26 Murray Cumming <murrayc@murrayc.com>
411 * src/modest-ui-actions.h:
412 * src/modest-ui-actions.c: Added
413 modest_do_refresh_current_folder() containing some code from
414 modest_ui_actions_on_send_receive().
415 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
416 Call modest_do_refresh_current_folder() before refreshing the
417 requested account, as in modest_ui_actions_on_send_receive().
418 This is strange, but seems to be necessary to show new mails.
419 Now new emails are finally visible in the UI when downloaded
420 via the automatic update interval, fixing bug NB#57458.
421 This also works because bug NB#57458 has been fixed somehow.
423 2007-07-26 Murray Cumming <murrayc@murrayc.com>
425 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
426 printf more details when we get unhandled D-Bus methods, because
429 * src/modest-mail-operation.c: (update_account_thread):
430 Comment out the tny_camel_pop_store_account_reconnect(), because this
431 is apparently no longer needed, and it did not work before anyway.
432 See the comment in the code.
434 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
435 by checking the header flags. This fixes projects.maemo.org bug
438 2007-07-25 Murray Cumming <murrayc@murrayc.com>
440 * src/maemo/modest-maemo-utils.h:
441 * src/maemo/modest-maemo-utils.c: Added
442 modest_maemo_show_information_note_in_main_context_and_forget().
443 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
444 Use the new function to show simple error dialogs in the main
445 context, though question dialogs are still in the current context,
446 which is unfortunately usually not the main context. This should
449 2007-07-25 Murray Cumming <murrayc@murrayc.com>
451 * src/modest-tny-account-store.c: (get_password):
452 Never save the entered username and password in gconf,
453 because the UI spec says we should not. This helps
454 slightly with projects.maemo.org bug NB#63671.
456 2007-07-25 Murray Cumming <murrayc@murrayc.com>
458 * src/widgets/modest-msg-edit-window.h:
459 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
460 Moved some code here to make it simpler.
461 (modest_msg_edit_window_attach_file_one): Renamed from
462 modest_msg_edit_window_attach_file_interactive().
463 (modest_msg_edit_window_offer_attach_file): Renamed from
464 modest_msg_edit_window_attach_file() and used
465 modest_msg_edit_window_attach_file_one() instead of
466 copy/pasting the code. The old code for one was not using
467 GnomeVFS. This allows use of smb:// URLs when using send-as
468 from external applications, fixing bug NB#63741.
470 (modest_msg_edit_window_insert_image),
471 (modest_msg_edit_window_add_attachment_clicked):
472 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
473 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
474 Adapted to the new function names.
476 2007-07-25 Murray Cumming <murrayc@murrayc.com>
478 (modest_platform_set_update_interval): Set the alarm recurrence
479 fields so that auto-update does not just happen the first time.
480 This should have fixed projects.maemo.org bug NB#63938.
482 When this happens you can see a printf when the D-Bus method is
484 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
486 However, I do not actually seem to get new POP messages even when
487 clicking the refresh button manually. A restart gets them.
488 This might be a problem in today's tinymail only.
490 2007-07-24 Murray Cumming <murrayc@murrayc.com>
492 * src/maemo/modest-maemo-global-settings-dialog.c:
493 (current_connection):
494 Avoid a crash (probably only in scratchbox) when strcmp()ing a
495 NULL when closing the dialog.
497 2007-07-24 Murray Cumming <murrayc@murrayc.com>
499 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
500 Remove the hacky send/receive that didn't work, and instead
501 refilter the treemodel to make the deleted email really vanish from
502 the UI (though the delete-from-menu code does has commented out
503 the code that does that). This fixes projects.maemo.org bug
506 2007-07-24 Murray Cumming <murrayc@murrayc.com>
508 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
509 Try a couple of tricks to force the treeview to update (
510 poke the folder, and do a send/receive refresh), but the deleted
511 email still appears with a strike-through instead of really being
514 2007-07-23 Murray Cumming <murrayc@murrayc.com>
516 * src/dbus_api/modest-dbus-callbacks.c:
517 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
518 because their ID is not human-readable (see the comment about
519 improvements needed to the osso-email-interface API) and
520 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
522 2007-07-23 Murray Cumming <murrayc@murrayc.com>
524 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
525 (add_folders_to_list), (on_dbus_method_get_folders),
526 (modest_dbus_req_filter):
527 * src/maemo/modest-maemo-utils.c:
528 (on_camel_account_get_supported_secure_authentication):
529 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
530 (on_header_view_focus_in):
531 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
532 * src/modest-formatter.c: (modest_formatter_create_body_part):
533 * src/modest-mail-operation.c: (recurse_folders),
534 (update_account_thread), (get_msgs_full_thread),
535 (modest_mail_operation_get_msgs_full),
536 (modest_mail_operation_xfer_msgs):
537 * src/modest-search.c: (search_mime_part_and_child_parts),
538 (modest_search_account), (modest_search_all_accounts):
539 * src/modest-tny-account.c:
540 (modest_tny_account_get_special_folder), (recurse_folders):
541 * src/modest-tny-local-folders-account.c:
542 (modest_tny_local_folders_account_query_passes):
543 * src/modest-tny-msg.c: (copy_mime_part),
544 (modest_tny_msg_find_body_part_from_mime_part):
545 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
546 (modest_tny_send_queue_try_to_send):
547 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
548 (_modest_ui_actions_open), (download_uncached_messages),
549 (reply_forward), (modest_ui_actions_on_copy),
550 (modest_ui_actions_on_details), (has_retrieved_msgs),
551 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
553 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
554 (_selected_msg_marked_as), (_msg_download_completed),
555 (_selected_msg_sent_in_progress):
556 * src/widgets/modest-attachments-view.c:
557 (modest_attachments_view_set_message):
558 * src/widgets/modest-msg-view.c: (find_cid_image):
559 * tests/check_folder-transfer.c: (find_folders):
560 * tests/check_update-account.c: (func):
561 * tests/dbus_api/test_get_folders.c: (main):
562 Checked all uses of tny_iterator_get_current(), making sure
563 that the object is unreferenced (3 or 4 places did not),
564 and adding checks for NULL.
566 2007-07-23 Murray Cumming <murrayc@murrayc.com>
568 * src/dbus_api/modest-dbus-callbacks.c:
569 (on_idle_open_default_inbox): Make sure that the application UI is
571 * src/maemo/easysetup/modest-easysetup-wizard.c:
572 (on_entry_invalid_character): Show the word whitespace instead
573 of (null) in the banner when whitespace was entered.
574 (show_error): Add a comment that this does not work in
575 Maemo Bora, though we do not know why.
577 2007-07-23 Murray Cumming <murrayc@murrayc.com>
579 * src/modest-tny-account.c:
580 (modest_tny_account_get_special_folder): Use an if instead of
581 an assert for when the parent account name is NULL, because this
582 might be causing a crash in projects.maemo.org bug 63192.
583 * src/modest-mail-operation.c:
584 (modest_mail_operation_send_new_mail_cb),
585 (modest_mail_operation_remove_folder): unref the folder that is
586 returned from modest_tny_account_get_special_folder().
588 2007-07-23 Murray Cumming <murrayc@murrayc.com>
590 * src/modest-ui-actions.c:
591 (modest_ui_actions_on_password_requested):
592 Show mail_ib_login_cancelled info banner when the user cancels
593 the protected password dialog, to fix projects.maemo.org
596 2007-07-23 Murray Cumming <murrayc@murrayc.com>
598 * src/maemo/modest-account-settings-dialog.c:
599 (create_page_outgoing): Put this page in a GtkScrolledWindow,
600 matching the UI mock-up in the UI spec, and allowing access
601 to all widgets even when the on-screen keyboard is active.
603 2007-07-23 Murray Cumming <murrayc@murrayc.com>
605 Reverted this previous commit from Johannes,
606 because the scrollbars are always visible and because
607 I think we only need it on onepage of the account
608 settings, not the account wizard.
609 (I wrote the wrong instructions in the bug.)
611 * src/maemo/easysetup/modest-easysetup-wizard.c:
612 Added scrollbars to account wizard dialog.
613 Fixed projects.maemo.org NB #62744
615 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
617 * src/maemo/easysetup/modest-easysetup-wizard.c:
618 (create_page_user_details):
619 Use auto-cap for name (projects.maemo.org NB#63716)
620 * src/widgets/modest-account-view.c: (on_account_busy_changed):
622 2007-07-22 Armin Burgmeier <armin@openismus.com>
624 * src/maemo/modest-ui-actions.c: Use current account instead of
625 default account for creating viewer windows, so that the viewer
626 window knows to which account the viewed message belongs.
628 * src/maemo/modest-msg-view-window.c: Destroy the window when the
629 corresponding account is deleted. This fixes projects.maemo.org bug
632 2007-07-18 Armin Burgmeier <armin@openismus.com>
634 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
635 the dialog close after entering an invalid port number and clicking
636 OK. This fixes projects.maemo.org bug NB#63602.
638 2007-07-18 Armin Burgmeier <armin@openismus.com>
640 * src/modest-tny-account-store.c:
641 (get_server_accounts): Set parent modest account name for each
642 connection-specific transport account so that special folders of such
643 an account can be looked up. This fixes a crash when changing account
644 settings. This might also be related to projects.maemo.org bug
647 2007-07-16 Armin Burgmeier <armin@openismus.com>
649 * src/modest-ui-actions.c: Added a button to create a folder to the
650 move-to dialog. This fixes projects.maemo.org bug NB#59863.
652 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
654 * src/maemo/easysetup/modest-easysetup-wizard.c:
655 Added scrollbars to account wizard dialog.
656 Fixed projects.maemo.org NB #62744
658 2007-07-16 Murray Cumming <murrayc@murrayc.com>
660 * src/widgets/modest-msg-view.h:
661 * src/widgets/modest-msg-view.c:
662 Added modest_msg_view_get_message_is_empty() but this needs
664 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
665 Check if there is any text in the message yet.
666 But this needs to be implemented properly.
667 (modest_msg_edit_window_toggle_find_toolbar):
668 * src/maemo/modest-msg-view-window.c:
669 (modest_msg_view_window_toggle_find_toolbar):
670 Show a banner warning if there is no text to search, when
671 trying to start a search. This partially fixes
672 projects.maemo.org bug NB#62350.
674 2007-07-13 Murray Cumming <murrayc@murrayc.com>
676 * src/modest-mail-operation.c: (update_account_thread):
677 Initialized num_new_headers to fix the build.
679 2007-07-13 Murray Cumming <murrayc@murrayc.com>
681 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
682 Ignore modest accounts whose server accounts don't exist in gconf.
683 This prevents us trying to create TnyAccount instances for those
684 server accounts when the server account has been removed from gconf,
685 but the parent modest account has not yet been removed from modest.
686 I don't know why this is only noticeable now. It was probably just
687 a harmeless g_warning() anyway.
689 2007-07-13 Murray Cumming <murrayc@murrayc.com>
691 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
692 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
694 2007-07-12 Armin Burgmeier <armin@openismus.com>
696 * src/maemo/modest-main-window.c: Make default account appear bold
697 in view, tools/send & receive and toolbar/send & receive SCM menus.
698 This fixes projects.maemo.org bug NB#59010.
700 2007-07-12 Murray Cumming <murrayc@murrayc.com>
702 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
703 Add a short-cut, by checking if the folder store is an account.
704 This ensures that the Sort menu item and toolbar is dimmed for
705 the local-folders account root item, fixing
706 projects.maemo.org bug NB#62545.
708 2007-07-12 Murray Cumming <murrayc@murrayc.com>
710 * src/modest-tny-account-store.c: (get_password):
711 Show the password dialog (via the signal) only in the mainloop, via
712 an idle handler that we wait for. This could theoretically prevent
713 hangs, though I worry that it could introduce some too.
715 2007-07-12 Murray Cumming <murrayc@murrayc.com>
717 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
718 * src/maemo/modest-platform.c:
719 (modest_platform_connect_and_wait):
720 Take a TnyAccount* parameter and try to set it to online
721 (a TnyCamel-only API), because tinymail sets accounts to offline
722 when the user cancels a password dialog, and doesn't ask again until
723 it has been set to online.
724 However, this is commented out because it causes a hang now.
726 (modest_platform_connect_and_wait_if_network_account):
727 * src/modest-mail-operation.c:
728 (modest_mail_operation_update_account):
729 * src/modest-platform.h:
730 * src/modest-ui-actions.c: (_modest_ui_actions_open),
731 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
733 2007-07-12 Armin Burgmeier <armin@openismus.com>
735 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
737 * src/modest-mail-operation.c:
738 * src/modest-ui-actions.c: Check for already existing folder before
739 querying the server, show error message from camel if the request
740 still fails. This fixes projects.maemo.org bug NB#58701.
742 2007-07-12 Murray Cumming <murrayc@murrayc.com>
744 * src/modest-tny-account-store.h:
745 * src/modest-tny-account-store.c:
746 Added modest_tny_account_store_forget_password_in_memory(),
747 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
748 when creating a new account, so that new passwords will be used, instead of
749 us thinking that it's a second request as a result of a failed password again.
751 2007-07-12 Murray Cumming <murrayc@murrayc.com>
753 * src/dbus_api/modest-dbus-callbacks.c:
754 (on_idle_open_message): If the message is in drafts then open it
755 in an edit window instead of a view window. This fixes
756 projects.maemo.org bug NB#63005.
758 2007-07-12 Murray Cumming <murrayc@murrayc.com>
760 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
761 Avoided a harmless g_warning().
763 2007-07-12 Murray Cumming <murrayc@murrayc.com>
765 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
766 Pass the modest account name, not the TnyAccount display name to
767 modest_msg_view_window_new() so that the reply feature works,
768 fixing projects.maemo.org bug NB#62892.
770 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
771 (modest_msg_view_window_new_with_header_model):
772 * src/maemo/modest-msg-view-window.c:
773 (modest_msg_view_window_new_with_header_model),
774 (modest_msg_view_window_new):
775 * src/modest-ui-actions.c: (reply_forward):
776 * src/widgets/modest-msg-view-window.h:
777 * src/widgets/modest-window.c: (modest_window_set_active_account):
778 Rename an account parameter to modest_account_name to make this clearer.
780 2007-07-11 Murray Cumming <murrayc@murrayc.com>
782 * src/modest-ui-actions.h:
783 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
784 modest_do_message_delete().
785 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
786 Call modest_do_message_delete(), hoping that this would cause messages
787 to be really deleted from search instead of just marked with strike through.
788 Does not seem to help.
790 2007-07-11 Armin Burgmeier <armin@openismus.com>
792 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
793 priv->reselect to FALSE prior to calling
794 modest_folder_view_select_first_inbox_or_local() to prevent endless
795 recursion and thus a crash on startup.
797 2007-07-11 Armin Burgmeier <armin@openismus.com>
799 * src/maemo/modest-account-settings-dialog.h: Include
800 <gtk/gtknotebook.h> to fix the build (at least for me).
802 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
803 Use "New FolderN" as default suggested name if "New folder" already
804 exists, with N being the first free number, though never exceed "New
805 folder99" in which case we just fall back to "New Folder" even though
806 it already exists. This fixes projects.maemo.org bug NB#58663.
808 2007-07-11 Murray Cumming <murrayc@murrayc.com>
810 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
811 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
812 projects.maemo.org bug NB#62778.
814 2007-07-11 Murray Cumming <murrayc@murrayc.com>
816 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
817 Ignore the wrong (for now) secure-smtp setting in the presets -
818 just default to requiring secure authentication for SMTP, because
821 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
823 * src/widgets/modest-folder-view.c: (filter_row)
824 Do not show drafts folder (see UI specs)
826 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
828 * src/modest-ui-actions.c:
829 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
830 place and also not necessary.
832 * src/widgets/modest-folder-view.c: (filter_row)
833 Guess folder type and hide Sent & Outbox if necessary.
834 Fixed project.maemo.org NB#57328
836 2007-07-11 Murray Cumming <murrayc@murrayc.com>
838 * src/modest-ui-actions.h:
839 * src/modest-ui-actions.c:
840 (modest_ui_actions_on_delete_message):
841 Move some code into a new
842 modest_ui_actions_refresh_message_window_after_delete()
843 function so we can use it from elsewhere.
845 * src/dbus_api/modest-dbus-callbacks.c:
846 (on_idle_delete_message), (on_delete_message): Used an idle
847 handler, as we do for the other D-Bus method handlers.
848 Call modest_ui_actions_refresh_message_window_after_delete()
849 if the deleted message was open in a window. This fixed
850 projects.maemo.org bug NB#62862.
852 2007-07-11 Murray Cumming <murrayc@murrayc.com>
854 * src/modest-main.c: (main): Only show the UI at the start if
855 the showui command line option was given. For instance,
856 run-standalone src/modest showui
857 Otherwise, we wait for the top_application D-Bus method to
858 be sent by hildon-desktop when the application is selected
860 This allows us to run without a UI when osso-global-search
861 uses our D-Bus methods.
863 2007-07-11 Murray Cumming <murrayc@murrayc.com>
865 * src/dbus_api/modest-dbus-api.h: Added a define for a
866 top-application D-Bus method.
867 * src/dbus_api/modest-dbus-callbacks.c:
868 (on_top_application),
869 (modest_dbus_req_handler): Handle the top-application D-Bus
870 method, which might be an undocumented D-Bus signal sent by
871 hildon-desktop when it starts the application from the menu.
872 But I am not sure and I need to test it on the device, because
873 my scratchbox does not have the application in the menu now.
874 This method shows the main window, so that it can be invisible
875 when started, for instance, just for email searching from
878 * src/maemo/modest-main-window.c: (restore_settings),
879 (modest_main_window_new): Do not show the window immediately
880 upon creation. We show it later.
881 * src/modest-widget-memory.c: (save_settings_paned):
882 Try (unsuccessfully) to avoid saving the paned position when
883 it is not even visible.
884 (restore_settings_paned): Do not allow a silly paned position.
885 This seems necessary when not showing the window at first.
887 * tests/dbus_api/Makefile.am:
888 * tests/dbus_api/test_top_application.c: (main): Test for the
891 2007-07-10 Murray Cumming <murrayc@murrayc.com>
893 * src/modest-ui-dimming-rules.c:
894 (modest_ui_dimming_rules_on_new_msg),
895 (modest_ui_dimming_rules_on_reply_msg),
896 (modest_ui_dimming_rules_on_delete_msg),
897 (modest_ui_dimming_rules_on_details),
898 (modest_ui_dimming_rules_on_view_window_move_to),
899 (modest_ui_dimming_rules_on_view_previous),
900 (modest_ui_dimming_rules_on_view_next),
901 (_invalid_folder_for_purge): Added checks before
902 casting the window. This looks like an actual
903 logic error in _invalid_folder_for_purge(), because it
904 tries to use a ModestMainWindow as a message window.
906 2007-07-10 Murray Cumming <murrayc@murrayc.com>
908 * src/maemo/modest-account-settings-dialog.c:
909 (show_error): Use the same implementation as in
910 modest-easysetup-wizard.c:
911 (on_entry_invalid_character): The logical ID contains a %s.
912 Guessed what it should be.
913 (on_entry_max), (check_data), (on_response): Adapt to
914 changed show_error().
915 (create_page_account_details): Really call
916 modest_validating_entry_set_func() on the correct widgets.
917 * src/maemo/easysetup/modest-easysetup-wizard.c:
918 (on_entry_invalid_character): Fix the logical ID here too.
919 (create_page_account_details),
920 (create_page_user_details):
922 modest_validating_entry_set_func() on the correct widgets.
924 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
925 Do not try to use the account if it is NULL.
927 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
929 * src/modest-ui-actions.c: (create_move_to_dialog),
930 (modest_ui_actions_on_main_window_move_to),
931 (modest_ui_actions_on_msg_view_window_move_to):
932 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
933 (filter_row), (modest_folder_view_show_non_move_folders):
934 * src/widgets/modest-folder-view.h:
936 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
937 the Sent folder yet as it does not report the correct folder type.
939 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
941 * src/maemo/modest-msg-edit-window.c: (init_window):
944 2007-07-10 Murray Cumming <murrayc@murrayc.com>
946 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
947 Take a parent widget instead of a parent window, and
948 implement this with hildon_banner_show_information() instead.
949 Non-Maemo builds can just ifdef that there.
950 This fixed projects.maemo.org bug NB#62766.
952 (on_entry_invalid_character): Use show_error() again instead
953 of using hildon directly, and use the _CS() macro to use the correct
955 (create_account), (check_for_supported_auth_methods), (on_entry_max):
956 Pass a widget instead od a window to show_error().
958 2007-07-10 Murray Cumming <murrayc@murrayc.com>
960 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
961 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
962 This allows us to show the server name in the error message, fixing
963 projects.maemo.org bug NB#62904.
964 Also, use the appropriate logical ID message for the account protocol.
966 2007-07-10 Murray Cumming <murrayc@murrayc.com>
968 * src/modest-tny-account-store.c: (on_idle_wrong_password):
969 A compilation fix, though the build wasn't broken for me.
971 2007-07-09 Murray Cumming <murrayc@murrayc.com>
973 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
974 Do not try to unref a NULL folder store, to avoid a runtime warning.
975 This seems to happen sometimes when changing accounts settings.
977 2007-07-09 Murray Cumming <murrayc@murrayc.com>
979 * src/modest-tny-account-store.c:
980 (modest_tny_account_store_instance_init),
981 (modest_tny_account_store_finalize),
982 (on_account_settings_hide), (on_idle_wrong_password):
983 Use a GHashTable to ensure that we only show one account settings
984 dialog per modest account. This avoids us having a dialog open for
985 both the store and transport accounts, or due to repeated get_password()
986 calls that shouldn't happen anyway.
988 2007-07-09 Murray Cumming <murrayc@murrayc.com>
990 * src/maemo/modest-maemo-utils.c: (on_hide),
991 (modest_maemo_show_dialog_and_forget): Handle the response, because
992 the window is not even hidden by default.
994 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
995 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
996 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
997 which seems to prevent some modality problems.
999 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
1000 Ignore user cancellation errors.
1002 * src/modest-account-mgr-helpers.h:
1003 * src/modest-account-mgr-helpers.c:
1004 Added modest_server_account_get_password() and
1005 modest_server_account_get_has_password() to avoid direct use of
1008 * src/maemo/modest-account-settings-dialog.h:
1009 * src/maemo/modest-account-settings-dialog.c:
1010 (modest_account_settings_dialog_init): Store the notebook so we can
1012 Added modest_account_settings_dialog_switch_to_user_info().
1014 * src/modest-tny-account-store.c:
1015 (get_password): When the password in the account settings is wrong (we think),
1016 show the relevant page of the account settings dialog, in the mainloop.
1017 However, we currently get many of these at once because cancel does not
1019 (forget_password): Do not forget the password
1020 from the account settings, because this causes side-effects when
1021 tinymail seems to call it at strange time, maybe because of how we
1022 are cancelling get_password().
1023 (modest_tny_account_store_alert): Ignore user cancellations.
1025 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1027 * src/maemo/modest-maemo-utils.h:
1028 * src/maemo/modest-maemo-utils.c:
1029 Added modest_maemo_show_information_note_and_forget() for use instead of
1030 gtk_dialog_run() when the response is not needed, to avoid an extra
1031 mainloop which could cause a hang.
1033 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
1034 Use the logical IDs for the error message, though they are not
1035 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
1036 because gtk_dialog_run() caused a hang here (the window did not close).
1037 This fixes projects.maemo.org bug NB#62646.
1039 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1041 * src/modest-account-mgr-helpers.h:
1042 * src/modest-account-mgr-helpers.c:
1043 Added modest_account_mgr_get_store_protocol().
1045 * src/maemo/modest-account-view-window.c:
1046 (on_delete_button_clicked): Show different warning text depending on
1047 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
1048 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
1051 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1053 * src/maemo/modest-msg-edit-window.c:
1054 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
1055 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
1057 2007-07-07 Armin Burgmeier <armin@openismus.com>
1059 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
1060 ckdg_ib_maximum_characters_reached from correct package.
1062 * src/modest-ui-actions.c: Show an error message when a folder could
1063 not be created. Tinymail does not give us specific error codes about
1064 what has gone wrong, so we assume that a folder with that name
1065 already exists, though there might be other reasons.
1067 2007-07-06 Murray Cumming <murrayc@murrayc.com>
1069 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1070 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
1071 give a more exact error message that can be partly translated.
1073 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1075 * src/maemo/modest-address-book.c:
1076 (select_email_addrs_for_contact): Specify a default window size for the
1077 select-email-address dialog, so that it is probably big enough for the
1078 title. This should fix projects.maemo.org bug NB#62277.
1080 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1082 * src/maemo/easysetup/modest-easysetup-wizard.c:
1083 (create_page_complete_easysetup): Use
1084 gtk_widget_set_size() request to ensure that the text wraps
1087 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
1089 * src/maemo/easysetup/modest-easysetup-wizard.c:
1090 (on_entry_invalid_character), (create_page_account_details),
1091 (create_page_user_details):
1092 Use new API of ModestValidatingEntry. But for some reason the banner is
1093 not shown. I will have to investigate that further.
1095 * src/widgets/modest-validating-entry.c: (on_insert_text),
1096 (modest_validating_entry_set_func):
1097 * src/widgets/modest-validating-entry.h:
1098 Added a new callback function to be able to react to prevented
1099 characters whitespaces to e.g show a banner.
1101 2007-07-05 Armin Burgmeier <armin@openismus.com>
1103 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
1104 notification of HildonNumberEditor instead of remembering the port
1105 number. Thanks to Johannes for pointing this out.
1107 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
1109 * src/maemo/easysetup/modest-easysetup-wizard.c:
1110 Check if there are any user changes before showing a confirmation
1111 dialog (projects.maemo.org NB#60946)
1113 2007-07-05 Armin Burgmeier <armin@openismus.com>
1115 * src/maemo/modest-account-settings-dialog.c: Remember custom port
1116 number at the beginning of the dialog and set the modified flag at the
1117 end if the port number has changed. This is necessary because
1118 HildonNumberEditor does not support notification when the value has
1121 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1123 * src/modest-ui-actions.c:
1124 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
1125 a connection before asking anything else. Correct the check for the destination
1126 folder so that it succeeds when online.
1127 This fixed projects.maemo.org bug NB#61645.
1129 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1131 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
1132 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
1133 to fix projects.maemo.org bug NB#62439.
1135 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1137 * src/modest-tny-account.c: (on_connection_status_changed):
1138 Really do not use tny_device_force_offline() here. See the previous comment.
1140 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1142 * src/modest-tny-account.c: (on_connection_status_changed):
1143 Do not use tny_device_force_offline() when tinymail says that something
1144 went wrong with the connection. It seems to report this unnecessarily.
1146 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1148 * src/maemo/modest-connection-specific-smtp-window.c:
1149 (modest_connection_specific_smtp_window_init):
1150 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
1151 does not seem to have any effect in osso 1.1 (though it works in
1152 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
1154 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1156 * src/maemo/modest-connection-specific-smtp-window.c:
1157 Fix UI specification problems with projects.meamo.org NB#60479
1159 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1161 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
1162 clue when this has failed, because the error dialog is not always shown
1163 (at least in earlier version).
1165 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
1166 GError message, because the generic error dialog is not helpful.
1168 'This message is not currently available (can't let a new connection go online)'
1169 when trying to open an IMAP message.
1171 (_modest_ui_actions_open): Offer a connection when some messages would
1172 have to be downloaded and we are offline.
1174 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1176 * src/widgets/modest-folder-view.c:
1177 Don't check for MERGE type anymore as we use the correct type
1179 NOTE: For the last two changes you need to update your tinymail copy
1180 because of API changes!
1182 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1184 * src/modest-tny-local-folders-account.c:
1185 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
1186 (see projects.maemo.org NB#61580)
1188 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1190 * src/modest-tny-account.c: (on_connection_status_changed):
1191 Commented out the call to modest_platform_connect_and_wait() because this
1192 seems to always hang, and I would like to know if this is the only thing
1193 that causes a hang when showing the connection dialog.
1194 It is not very useful anyway.
1196 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1198 * src/maemo/modest-msg-view-window.c:
1199 (modest_msg_view_window_select_next_message):
1201 * src/modest-platform.h:
1202 * src/maemo/modest-platform.c:
1203 Added modest_platform_connect_and_wait(), which calls
1204 tny_maemo_conic_device_connect() always in the main thread, by calling it
1205 in an idle handler and waiting for the idle handler to run. It should be
1206 in the main thread because it uses GTK+ UI code. It just returns TRUE
1207 if the device is already online.
1209 There is some nasty code to ensure that subsequent calls to
1210 modest_platform_connect_and_wait() just wait for the first one to finish,
1211 by checking repeatedly in another idle handler. This is necessary,
1212 because other threads (or even the main thread, via another idle handler)
1213 can call modest_platform_connect_and_wait() while
1214 modest_platform_connect_and_wait() is running.
1216 (modest_platform_connect_and_wait_if_network_account),
1217 (modest_platform_connect_and_wait_if_network_folderstore):
1218 Convenience functions that calls modest_platform_connect_and_wait() if
1219 the account or folder might want network access.
1221 * src/modest-mail-operation.c:
1222 (modest_mail_operation_update_account):
1223 * src/modest-ui-actions.c: (download_uncached_messages),
1224 (modest_ui_actions_on_rename_folder), (delete_folder),
1225 (modest_ui_actions_on_main_window_move_to),
1226 (modest_ui_actions_on_msg_view_window_move_to):
1227 * src/widgets/modest-folder-view.c:
1228 (drag_and_drop_from_folder_view):
1229 Offer a connection if we are offline.
1231 * src/modest-tny-account.c: (on_connection_status_changed):
1232 Document this as only handling errors during network operations in progress,
1233 and replace the idle code with a simple call to
1234 modest_platform_connect_and_wait(), which does this instead.
1236 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1238 * src/modest-tny-account.c:
1239 (modest_tny_account_get_special_folder): (util_on_idle),
1240 Handle the GError so we can see when tny_folder_store_get_folders()
1241 fails, as it currently does while something else is connecting.
1243 Added util_run_in_main_thread_and_wait()
1244 which uses an idlen handler and mainloop to ensure that the function
1245 is called in the main thread.
1246 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
1247 to make sure that we call attempt the connection in the mainloop only,
1248 which might solve some hangs.
1250 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1252 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
1253 be found by their display name. This is never useful.
1254 * src/modest-tny-account-store.c: (on_account_removed): Find the account
1255 by its ID, instead of trying to use its ID as its display name.
1257 * src/modest-tny-account-store.h:
1258 * src/modest-tny-account.c:
1259 (modest_tny_account_get_special_folder): Add a g_warning() when
1260 tny_folder_store_get_folders() returns an empty list for the maildir.
1262 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
1263 Add a g_warning() when this returns NULL, because that it not allowed
1266 2007-07-02 Armin Burgmeier <armin@openismus.com>
1268 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
1269 note when trying to cancel the wizard. This fixes projects.maemo.org
1272 2007-07-02 Murray Cumming <murrayc@murrayc.com>
1274 * src/modest-tny-account.h:
1275 * src/modest-tny-account.c:
1276 (modest_tny_account_new_from_server_account),
1277 (modest_tny_account_new_from_server_account_name),
1278 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
1279 because this must now be set before setting the proto. This is usd in
1280 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
1281 warning in camel_session_get_service() caused by
1282 tny_camel_transport_account_prepare().
1284 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
1287 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
1289 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1291 (modest_connection_specific_smtp_edit_window_init):
1293 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
1294 of "changed" for now
1296 2007-06-29 Murray Cumming <murrayc@murrayc.com>
1298 * src/modest-tny-account.c:
1299 (modest_tny_account_new_from_server_account):
1300 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
1301 now uses to request a connection when it needs one, and which it uses
1302 to tell us that something is wrong with the connection, so we can force
1303 the accounts offline to prevent further problems.
1305 * src/modest-defs.h:
1306 * src/modest-init.c: (init_default_settings):
1307 * src/modest-mail-operation.c:
1308 (modest_mail_operation_update_account):
1309 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
1310 This should not be necessary anymore. Do not set the conf key that
1311 determined this (it was always TRUE and not set anywhere else).
1313 * src/modest-ui-actions.h: Remove unused and unimplemented
1314 modest_ui_actions_on_online_toggle_toggled().
1316 2007-06-29 Murray Cumming <murrayc@murrayc.com
1318 * src/maemo/modest-main-window.c: (connect_signals):
1319 Don't connect to delete_event twice. Maybe this was harmless.
1321 2007-06-29 Murray Cumming <murrayc@murrayc.com
1323 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
1324 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
1325 Debug output to give some more clue when a folder move is not allowed.
1327 2007-06-28 Murray Cumming <murrayc@murrayc.com
1329 * src/modest-tny-account.c: (on_modest_file_system_info),
1330 (modest_tny_account_get_mmc_account_name):
1331 Always call the callback, without checking whether the name has changed.
1332 * src/widgets/modest-folder-view.c: (strings_are_equal),
1333 (on_model_foreach_set_name), (on_get_mmc_account_name),
1334 (text_cell_data): Compare the name here, and use the name from
1335 the account rather than from the
1336 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
1337 if the name was changed after the account was added to the model.
1338 That's a tinymail bug but not one that I want to fix now.
1340 This finally fixes projects.maemo.org bug NB#59301.
1342 2007-06-27 Armin Burgmeier <armin@openismus.com>
1344 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
1347 2007-06-27 Murray Cumming <murrayc@murrayc.com
1349 * src/modest-tny-account.h:
1350 * src/modest-tny-account.c:
1351 Added modest_tny_account_get_mmc_account_name(), to set the memory
1352 card name asynchronously for the given account and then notify.
1353 (modest_tny_account_new_for_local_folders): Use this new function instead
1354 of using hildon_file_system_info_async_new() directly.
1356 * src/widgets/modest-folder-view.c: (text_cell_data):
1357 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
1358 gtk_tree_model_row_changed() when it is available.
1360 This should fix projects.maemo.org bug NB#59301.
1362 2007-06-27 Murray Cumming <murrayc@murrayc.com
1364 * src/modest-mail-operation.c: (update_account_thread),
1365 (get_msgs_full_thread): Fix typo failures in the revert
1368 2007-06-27 Murray Cumming <murrayc@murrayc.com
1370 * src/maemo/modest-maemo-global-settings-dialog.c:
1371 (idle_select_default_focus):
1372 * src/modest-mail-operation.c: (idle_notify_progress),
1373 (idle_notify_progress_once), (set_last_updated_idle),
1374 (update_account_thread), (get_msgs_full_thread):
1375 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1376 * src/widgets/modest-header-view.c:
1377 (idle_notify_headers_count_changed_destroy),
1378 (idle_notify_headers_count_changed):
1379 Reverted the additions of gdk_threads_enter/leave(), in case this
1380 helps with a startup hang on the device.
1382 2007-06-26 Armin Burgmeier <armin@openismus.com>
1384 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
1385 for supported secure authentication methods from server by
1386 gtk_dialog_run(), saving CPU time and a potential race condition.
1388 2007-06-26 Armin Burgmeier <armin@openismus.com>
1390 * src/maemo/modest-maemo-utils.h:
1391 * src/maemo/modest-maemo-utils.c: Added a
1392 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
1393 only error code to tell the calling code when the user canceled the
1396 * src/maemo/modest-account-settings-dialog.h:
1397 * src/maemo/modest-account-settings-dialog.c:
1398 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
1399 message if the retrieval of secure authentication methods was canceled
1400 by the user. Perform the check before saving anything to configuration
1401 to not end up with half-committed configuration changes, do not show
1402 a "Saving to configuration failed" note when authentication methods
1403 could not be retrieved.
1405 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
1408 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1410 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1411 Only return the first level of folders under accounts, because the
1412 osso-global-search UI spec doesn't want the rest.
1413 This fixed projects.maemo.org bug NB#61811.
1415 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1417 * src/modest-tny-account-store.c:
1418 * src/modest-tny-account-store.h:
1419 Added modest_tny_account_is_memory_card_account().
1420 * src/maemo/modest-main-window.c: (create_details_widget):
1421 Show the same information items for the memory card as we show for the
1422 local-folders, to fix projects.maemo.org bug NB#59307.
1424 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1426 * src/modest-tny-account-store.c: (get_password):
1427 Added some checks for NULL to maybe prevent crashes, though I think
1428 it was Philip's last commit that actually prevented the crash here
1429 when creating a first new account.
1430 But the new account is still not usable (no messages are shown)
1431 until a restart of the application.
1433 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1435 * src/maemo/modest-maemo-global-settings-dialog.c:
1436 (idle_select_default_focus):
1437 * src/modest-mail-operation.c: (idle_notify_progress),
1438 (idle_notify_progress_once), (idle_notify_update_account_queue),
1439 (set_last_updated_idle), (update_account_thread),
1440 (notify_get_msgs_full), (get_msgs_full_destroyer),
1441 (get_msgs_full_thread):
1442 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1443 * src/widgets/modest-header-view.c:
1444 (idle_notify_headers_count_changed_destroy),
1445 (idle_notify_headers_count_changed):
1446 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1447 all idle handlers, because some other thread could be blocking
1448 the GDK lock, so that it can do GUI stuff.
1450 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1452 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1453 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1454 (on_idle_send_receive), (on_idle_open_default_inbox):
1455 * src/maemo/modest-msg-edit-window.c:
1456 (modest_msg_edit_window_attach_file_noninteractive):
1457 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1458 to prevent a hang. I don't quite understand why these are necessary,
1459 beause we should already be in the main loop. I guess something outside
1460 of the main loop is taking the lock.
1462 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1463 we are really using URIs, and use files that are more likely to exist.
1465 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1467 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1468 necessary because configure.ac now defines different variables.
1470 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1472 * libmodest-dbus-client/libmodest-dbus-client.c:
1473 * libmodest-dbus-client/libmodest-dbus-client.h:
1474 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1475 libmodest_dbus_client_compose_mail() is what things actually use.
1477 * src/dbus_api/modest-dbus-api.h:
1478 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1479 * tests/dbus_api/Makefile.am:
1480 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1483 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1485 * src/modest-init.c: (modest_init_local_folders):
1486 For memory-card (or other non local-folders) maildir accounts,
1487 always create an Archive folder, so that there is somewhere to put
1488 messages. This should be less confusing, because the user does not need
1489 to guess that the need to create a folder.
1491 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1493 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1494 Fixed icon size by using (50, 50) which is the same as defined by
1497 2007-06-25 Armin Burgmeier <armin@openismus.com>
1499 * src/widgets/modest-window-mgr.c:
1500 * src/modest-init.c:
1501 * configure.ac: Correctly recognize hildon-notify presence and fixed
1502 the build without it being installed.
1504 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1506 * libmodest-dbus-client/libmodest-dbus-client.c:
1507 (libmodest_dbus_client_search): Fix the build. Sorry.
1508 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1509 (reply_forward_cb): Initialize variables to fix the build.
1511 * src/modest-tny-account-store.c:
1512 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1513 comparison (a silly typo) so that email search results can be opened
1514 when there are more than one account.
1516 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1518 * libmodest-dbus-client/libmodest-dbus-client.c:
1519 (libmodest_dbus_client_search),
1520 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1521 instead of 1 second, because the search gets folders and messages from
1522 the server, which can take a long time. When it times out,
1523 osso-global-search will report no results.
1525 We need to specify whether we should search only cached information
1526 (maybe with a user preference), and the osso-email-search-plugin
1527 API should really be improved to allow that option, and to allow results
1528 to be delivered asynchronously in batches.
1530 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1532 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1533 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1534 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1536 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1538 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1539 that is an empty string. D-Bus seems to give us these instead of NULL.
1541 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1543 * src/dbus_api/modest-dbus-callbacks.c:
1544 * src/maemo/easysetup/modest-easysetup-wizard.h:
1545 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1546 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1547 (modest_connection_specific_smtp_edit_window_init):
1548 * src/maemo/modest-maemo-global-settings-dialog.c:
1550 * src/maemo/modest-maemo-utils.c:
1551 (modest_maemo_utils_setup_images_filechooser):
1552 * src/maemo/modest-main-window.c: (create_details_widget):
1553 * src/maemo/modest-msg-edit-window.c:
1554 (modest_msg_edit_window_attach_file_noninteractive),
1555 (modest_msg_edit_window_color_button_change),
1556 (modest_msg_edit_window_set_zoom):
1557 * src/modest-mail-operation.c: (update_account_thread):
1558 * src/modest-tny-account-store.c:
1559 * src/modest-tny-account.c:
1560 * src/widgets/modest-global-settings-dialog.c:
1561 * src/widgets/modest-window.h:
1563 Fixed build on bora!
1565 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1567 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1568 * src/modest-search.c: (modest_search_folder),
1569 (modest_search_all_accounts): Actually search only in the specified folder,
1570 doing a simple match on the folder ID.
1571 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1572 and added some documentation.
1574 2007-06-22 Armin Burgmeier <armin@openismus.com>
1576 * src/maemo/modest-maemo-utils.h:
1577 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1578 modest_maemo_utils_get_supported_secure_authentication_methods.
1580 * src/maemo/easysetup/modest-easysetup-wizard.c:
1581 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1582 one occured, not just "Server does not support secure authentication".
1584 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1586 * src/modest-tny-account-store.c: (get_password):
1587 Restored the call to tny_account_set_user() because Philip seems to have
1588 stopped this from crashing (by not using the freed string). It still does
1589 not work, but now we can test it.
1591 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1593 * src/maemo/modest-msg-edit-window.c: (init_window):
1594 Comment out use of an uninitialzed GtkScrolledWindow variable,
1595 to fix the build and stop a crash. Yet again.
1597 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1599 * src/modest-tny-account-store.c: (get_password):
1600 Remove the call to tny_account_set_user() because this actually crashes.
1601 As mentioned in the last commit, it is known to not work anyway.
1603 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1605 * src/modest-tny-account-store.c: (get_password):
1606 Use tny_account_set_username() to tell tinymail that the username might
1607 have changed too. But tinymail ignores this: see projects.maemo.org
1609 * src/modest-ui-actions.c:
1610 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1611 reset the connection when changing the username, and improve the comments.
1612 Save the changed username to gconf at least, so it is used when Modest is
1615 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1617 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1618 Do not use a query, so that we get all folders, including for POP and
1619 local-folders. They work as search criteria too.
1620 This fixes projects.maemo.org bug NB#57740.
1622 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1624 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1625 Comment out the use of hildon_notification_set_sound() because it is
1626 not declared, to fix the build. Warnings are serious, people.
1628 2007-06-21 Armin Burgmeier <armin@openismus.com>
1630 * src/maemo/modest-maemo-utils.h:
1631 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1632 modest_maemo_utils_get_supported_secure_authentication_methods()
1633 to query authentication methods for a specific user. This should fix
1634 projects.maemo.org bug NB#61369.
1636 * src/maemo/easysetup/modest-easysetup-wizard.c:
1637 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1640 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1642 * libmodest-dbus-client/libmodest-dbus-client.h:
1643 * libmodest-dbus-client/libmodest-dbus-client.c:
1644 (modest_dbus_message_iter_get_search_hit),
1645 (libmodest_dbus_client_search):
1646 Reorganised and commented this.
1647 Removed modest_search_hit_free() from the public API because it
1650 Added libmodest_dbus_client_get_folders() and
1651 modest_folder_result_list_free().
1653 * src/dbus_api/modest-dbus-api.h:
1654 * src/dbus_api/modest-dbus-callbacks.c:
1655 (modest_dbus_req_filter): Commented. Moved most code to
1656 on_dbus_method_search() and added on_dbus_method_get_folders().
1658 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1659 of the extra D-Bus handler.
1661 * tests/dbus_api/Makefile.am:
1662 * tests/dbus_api/test_get_folders.c: New test for
1663 libmodest_dbus_client_get_folders(). This seems to return an empty list
1664 at the moment. That could be the same error that causes the message list
1665 to be empty sometimes.
1666 This should help with projects.maemo.org bug NB#57740.
1668 2007-06-21 Armin Burgmeier <armin@openismus.com>
1670 * src/modest-mail-operation.c: Do not call
1671 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1672 notify the operation's end after having set the status to CANCELED for
1673 the operation queue to listen on. This fixes a deadlock when there
1674 were mail operations in the queue during its finalization.
1676 * src/modest-singletons.c: Reordered uninitialization of the account
1677 manager to happen after the mail operation queue was uninitialized
1678 because the mail operation's in the queue might still try to access
1679 the account manager (see modest_mail_operation_notify_end()). This
1680 fixes a potential crash when terminating the application.
1682 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1684 * src/modest-search.c:
1685 (search_mime_part_and_child_parts): Moved some code here so we
1686 can search recursively in child folders.
1687 (modest_search_folder): Search in the message as a mime part, instead
1688 of just its child mime parts.
1689 (read_chunk), (search_mime_part_ogs):
1690 Check how many bytes were read, to prevent an endless loop.
1691 Searching in message bodies now works. This finishes the fix for
1692 projects.maemo.org bug NB#61007.
1694 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1696 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1697 Add a g_warning when the item is not a folder.
1699 * src/modest-ui-dimming-rules.c:
1700 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1701 when selected item is not a folder (for instance, an account), because
1702 the UI spec only talks about folders.
1703 I am not sure what the UI spec wants, so this might not totally fix
1704 projects.maemo.org bug NB#60794.
1706 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1708 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1709 (load_from_file): Sort the list. The unsorted list would be more noticeable
1710 in non-English locales.
1712 * src/maemo/modest-msg-edit-window.c:
1713 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1714 warning and fix the build.
1716 * src/maemo/modest-progress-bar-widget.c:
1717 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1718 avoid a g_warning, and probably to avoid a crash.
1720 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1722 * src/modest-search.c: (modest_search_folder): Check for a GError
1723 when calling tny_folder_get_headers(), to show that this is not the cause
1726 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1728 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1729 Actually set the body query instead of the subject query.
1731 * src/modest-search.c: (search_mime_part_ogs),
1732 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1733 which would probably cause it to fail if we got this far.
1735 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1736 to simplify the code.
1737 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1738 be causing search-in-body to fail.
1740 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1742 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1744 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1745 Better debug message when the folder cannot be found.
1746 This should help with fixing projects.maemo.org bug #61287.
1747 * src/modest-search.c: (add_hit): Do not leak the furl string.
1749 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1751 * src/modest-ui-actions.c:
1752 (modest_ui_actions_on_folder_selection_changed):
1753 Do not special-case TNY_MERGE_FOLDER here, because
1754 modest_tny_folder_get_account() already does that. This fixes
1755 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1756 shown when the Outbox was selected).
1758 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1760 * libmodest-dbus-client/libmodest-dbus-client.c:
1761 (_dbus_iter_get_string_or_null): Initialize the string variable in
1762 case this helps with Dirk's crash.
1764 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1766 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1767 though it is not implemented yet (this function is maybe not even used),
1768 to avoid breaking ABI in future.
1769 * libmodest-dbus-client/libmodest-dbus-client.c:
1770 (get_attachments_string): Moved some code into this generic function.
1771 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1772 sends email. It is maybe not used.
1773 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1774 (on_send_mail): Use attachments.
1776 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1777 * src/maemo/modest-msg-edit-window.c:
1778 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1779 a filename before using it, to fix projects.maemo.org bug NB#58233.
1781 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1783 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1784 Initialize the continue_download variable to fix the build, and probably
1785 to fix randome behaviour.
1787 2007-06-18 Armin Burgmeier <armin@openismus.com>
1789 * src/modest-tny-send-queue.h:
1790 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1791 the queue so we can later show it in the UI. Replaced
1792 modest_tny_send_queue_msg_is_being_sent() by
1793 modest_tny_send_queue_get_msg_status().
1795 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1797 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1798 gpointer. This probably was not harmful, but just to be sure.
1800 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1802 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1803 Fix the build, but leave the function broken on Bora, because
1804 hildon_uri_action_get_service() does not exist.
1805 osso_uri_action_get_service() does not exist either, it seems.
1807 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1809 * src/modest-tny-account.c:
1810 (modest_tny_account_new_from_server_account):
1811 Uncommented the url debug output again, because it is useful for
1812 debugging, as I said in the comment.
1814 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1816 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1818 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1819 for Mameo Bora, to fix the build.
1821 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1824 Fixed build with hildon < 0.99
1826 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1827 Check if the selected account is busy instead of checking all accounts
1829 * src/modest-account-mgr-priv.h:
1830 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1831 (modest_account_mgr_init), (compare_account_name),
1832 (modest_account_mgr_set_account_busy),
1833 (modest_account_mgr_account_is_busy):
1834 * src/modest-account-mgr.h:
1835 Added busy information to the account manager. It possible to
1836 set an account to busy or not busy now.
1838 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1839 (modest_mail_operation_update_account),
1840 (modest_mail_operation_notify_end):
1841 Set the account to busy/not busy depending on the operation state.
1843 * src/widgets/modest-account-view.c:
1844 (modest_account_view_finalize), (get_last_updated_string),
1845 (update_account_view), (on_account_busy_changed), (init_view):
1846 Show string "Refreshing..." if the account is currently busy.
1848 All this fixes projects.maemo.org bug NB#59711
1850 2007-06-14 Armin Burgmeier <armin@openismus.com>
1852 * src/widgets/modest-attachments-view.h:
1853 * src/widgets/modest-attachments-view.c: Added
1854 modest_attachments_view_has_attachments() and fixed coordinate
1855 transformation in get_att_view_at_coords(). This fixes attachment
1858 * src/widgets/modest-msg-view.c: Make use of
1859 modest_attachments_view_has_attachments() to decide whether to show
1860 attachments in the header.
1862 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1864 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1865 (on_change), (on_combo_security_changed),
1866 (modest_connection_specific_smtp_edit_window_init),
1867 (modest_connection_specific_smtp_edit_window_set_connection),
1868 (modest_connection_specific_smtp_edit_window_is_dirty):
1869 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1870 * src/maemo/modest-connection-specific-smtp-window.c:
1873 Show an comfirmation dialog for the smpt-edit-window if there are
1874 unsaved changes and the user hits cancel.
1875 (projects.maemo.org bug NB#60479)
1877 2007-06-14 Armin Burgmeier <armin@openismus.com>
1879 * src/maemo/easysetup/modest-easysetup-wizard.c:
1880 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1881 address" info in banner instead of node, and select all the text as
1882 per UI spec. This fixes projects.maemo.org bug NB#60550.
1884 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1886 reviewed by: <delete if not using a buddy>
1888 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1889 * src/modest-ui-actions.c: (folder_refreshed_cb):
1891 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1893 * src/widgets/modest-folder-view.c: (filter_row):
1894 Explictly filter out the per-account outbox accounts. I don't know why
1895 these only sometimes show up, but now they should never show up in the UI.
1896 This should fix projects.maemo.org bug NB#60160.
1898 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1900 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1901 when the toolbar does not exist yet.
1902 * src/modest-widget-memory.c: (save_settings_header_view):
1903 Added g_warnings() to help us to discover when we are trying to set
1904 an empty columns list in gconf.
1906 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1908 * src/modest-init.h:
1909 * src/modest-init.c:
1910 Added modest_init_get_default_header_view_column_ids().
1912 * src/modest-widget-memory.c: (restore_settings_header_view):
1913 Use the new function to get defaults, if the gconf key is empty,
1914 instead of not creating any columns. This seems to fix the
1915 empty right-hand pane problems.
1917 * src/widgets/modest-header-view.h: Improved documentation.
1919 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1921 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1922 Revert the use of the display name as the account name, because this
1923 is generally wrong and would break the code that follows.
1925 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1927 * src/maemo/easysetup/modest-easysetup-wizard.c:
1928 (check_for_supported_auth_methods), (on_before_next),
1931 More correct fix for projects.maemo.org bug NB# 58991
1932 Do not longer accept AUTH_PASSWORD as secure method and choose
1933 correct method when creating the account.
1935 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1937 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1938 Fixed projects.maemo.org bug NB# 58991
1940 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1942 * src/modest-init.c: (modest_init_init_core),
1943 (modest_init_local_folders): Fixed compilation errors.
1945 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1947 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1948 Remove unnecessary lib/include, though it is good in principle when needed.
1950 * src/modest-init.c: (modest_init_one_local_folder),
1951 (modest_init_local_folders):
1952 * src/modest-init.h: Initialize the .modest library for memory cards,
1953 instead of just doing nothing for them. This should allow us to create
1954 folders there, fixing projects.maemo.org bug NB#59297.
1956 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1958 * libmodest-dbus-client/libmodest-dbus-client.c:
1959 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1960 (libmodest_dbus_client_compose_mail),
1961 (libmodest_dbus_client_open_message),
1962 (libmodest_dbus_client_send_and_receive),
1963 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1965 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1966 (on_idle_open_message), (modest_dbus_req_handler),
1967 (search_result_to_message), (modest_dbus_req_filter):
1968 * src/modest-search.c: (add_hit), (modest_search_folder),
1969 (modest_search_all_accounts): Improved debug messages.
1971 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1973 * src/modest-tny-account-store.c:
1974 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1977 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1980 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1982 * src/modest-tny-account-store.c: (get_server_accounts):
1983 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1984 even when there are no accounts, so that the Outbox folder is always
1985 visible. This fixes projects.maemo.org bug NB#60158.
1987 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1989 * src/maemo/modest-main-window.c: (create_details_widget):
1990 Use the mcen_va_never logical ID.
1992 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1994 * src/dbus_api/modest-dbus-api.h:
1995 * src/dbus_api/modest-dbus-callbacks.c:
1996 (on_idle_open_default_inbox), (on_open_default_inbox),
1997 (modest_dbus_req_handler):
1998 Added a new OpenDefaultInbox method.
2000 * libmodest-dbus-client/libmodest-dbus-client.h:
2001 * libmodest-dbus-client/libmodest-dbus-client.c:
2002 Added libmodest_dbus_client_open_default_inbox() to call the new
2003 dbus method. This should be useful to projects.maemo.org bug NB#57214,
2004 though it should maybe be used by a new osso-email-interface function.
2006 * tests/dbus_api/Makefile.am:
2007 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
2010 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2012 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
2013 NULL, so that the signals get all the keys. This should not actually
2014 change any behaviour because we currently update everything when anything
2017 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2019 * src/widgets/modest-folder-view.c: (text_cell_data),
2020 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
2021 (find_inbox_iter): If tinymail tells us that the folder is
2022 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
2023 This causes the inbox to be selected at startup, fixing part of
2024 projects.maemo.org bug NB#56305.
2026 * src/modest-ui-dimming-rules.c:
2027 (modest_ui_dimming_rules_on_tools_smtp_servers):
2028 * src/modest-ui-dimming-rules.h: Added a callback function to dim
2029 the SMTP servers menu item.
2030 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
2031 that the SMTP Servers menu item is dimmed when there are no accounts,
2032 as a future version of the UI spec will require. This fixes
2033 projects.maemo.org bug NB#56305.
2035 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
2037 * src/maemo/modest-maemo-utils.c:
2038 (modest_maemo_utils_get_supported_secure_authentication_methods):
2039 Added label to dialog instead of unreadable title
2041 * src/maemo/modest-main-window.c: (sync_accounts_cb),
2042 (modest_main_window_new):
2043 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
2046 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
2047 * src/modest-account-mgr.h:
2048 Added method to avoid code duplication
2050 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2051 (modest_ui_actions_on_send_receive):
2052 Use modest_account_mgr_has_accounts
2054 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2056 * src/maemo/easysetup/modest-presets.c:
2057 (modest_presets_get_info_server_security): Do not report secure auth
2059 * src/modest-protocol-info.c: Use the defines for the gconf key names
2060 for secure authentication. This was not working because we were writing
2061 Password and reading password, and the check was case sensitive.
2062 With this, gmail now works for receiving and sending when created via
2065 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2067 * src/maemo/easysetup/modest-presets.c:
2068 (modest_presets_get_info_server_security): Correct the key name for
2069 SecureSmtp, because it seems to be case-sensitive.
2070 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
2071 Do not try to get the 0th notebook page if there are 0 pages, to
2072 avoid a g_warning().
2074 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2076 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
2077 Prevent use of the new notification feature for now, because it currently
2078 shows one dialog for each new email, which is annoying.
2080 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2082 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2083 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
2084 when no country was selected, so that we show the global ones.
2085 * src/maemo/easysetup/modest-presets.c:
2086 (modest_presets_get_providers): Return only the global providers, not
2087 all providers when mmc=0 was requested.
2089 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2091 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2092 (easysetup_provider_combo_box_fill): Remove debug code that showed the
2093 provider ID in the combo.
2095 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
2096 Do not show the page numbers, because it would be confusing when we add
2097 the 2 extra pages for the custom setup, when the user chooses the "Other"
2098 provider. This fixes projects.maemo.org bug NB#59028
2100 * src/modest-init.c: (modest_init_init_core),
2101 (modest_init_local_folders):
2102 * src/modest-init.h:
2103 * src/modest-tny-account.c:
2104 (modest_tny_account_new_for_local_folders): Do not create default folders
2105 for the memory card. This should fix projects.maemo.org bug NB#59328.
2107 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2109 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
2110 Free the changed_conf_keys string items. They are already freed in the
2111 idle handler if that runs first.
2113 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2115 * src/modest-ui-actions.c:
2116 (modest_ui_actions_on_password_requested): Check that the server name
2117 is not NULL, because I just saw a password dialog with (null) as the
2120 * src/modest-tny-folder.[h|c]: Added
2121 modest_tny_folder_is_memory_card_folder().
2122 * src/modest-ui-dimming-rules.c:
2123 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
2124 menu item for memory cards, as per the UI spec (section 7.4). This should
2125 fix projects.maemo.org bug NB#59297.
2127 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
2129 * src/maemo/modest-main-window.c: (sync_accounts_cb):
2130 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
2131 is another problem with the code, see Murray's comment at line 772)
2133 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2135 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
2136 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2137 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
2138 (load_from_file), (easysetup_country_combo_box_init),
2139 (easysetup_country_combo_box_get_active_country_ids),
2140 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
2141 instead of just one ID, to avoid duplicate country names in the UI.
2143 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
2144 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2145 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
2146 a single ID, avoiding duplicate providers.
2147 * src/maemo/easysetup/modest-easysetup-wizard.c:
2148 (on_combo_account_country): Adapt to use a list.
2150 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2152 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
2153 keys changed in the last X seconds.
2155 * src/modest-account-mgr.h:
2156 * src/modest-account-mgr.c: (on_timeout_notify_changes),
2157 (on_key_change), (modest_account_mgr_class_init),
2158 (modest_account_mgr_init), (modest_account_mgr_finalize):
2159 As the keys are changed, save them in a GSList* and signal that GSList*
2160 further every X seconds, to batch changes, to allow us to do just one
2161 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
2162 bug NB#56941 and other (UI-blocking) delays when changing account settings.
2164 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
2165 changed signal signature.
2167 * src/modest-conf.c: (modest_conf_set_list),
2168 (modest_conf_on_change): Reenable notification.
2170 (modest_conf_maemo_fake_on_change): Comment out the hack that
2171 notified immediately instead of asynchronously.
2173 * src/widgets/modest-account-view.h:
2174 * src/widgets/modest-account-view.c:
2175 (update_account_view): Select the previously-selected account ID,
2176 if possible. This fixes projects.maemo.org bug NB#56933.
2178 (on_account_changed), (on_account_removed),
2179 (modest_account_view_select_account):
2181 Remove the block/unblock functions
2182 because they were not useful.
2184 * src/maemo/modest-account-view-window.c:
2185 (on_delete_button_clicked), (on_edit_button_clicked),
2186 (on_new_button_clicked): Remove the use of the non-working block/unblock.
2188 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2190 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2191 Improve the error dialog to show Incorrect Account Settings, which seems
2192 clearer, and say that the internal error message (to be removed from the
2193 dialog later) is often misleading.
2194 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
2196 * src/modest-tny-account.c:
2197 (modest_tny_account_new_from_server_account): Uncomment the printf of the
2198 URL because this is so useful for debugging on the device.
2200 * src/widgets/modest-serversecurity-combo-box.c:
2201 (modest_serversecurity_combo_box_fill): Correct a logical ID.
2203 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2205 * src/modest-mail-operation.c:
2206 (modest_mail_operation_send_new_mail):
2207 Added a comment about a nasty but apparently harmless message. Details
2208 added to the wiki g_warnings() page.
2210 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2212 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
2213 (modest_tny_send_queue_class_init):
2214 Do not use the priv struct because it is empty, to avoid g_warnings
2215 about a non-existant priv struct.
2217 * src/modest-tny-account-store.c:
2218 (modest_tny_account_store_get_server_account),
2219 (modest_tny_account_store_get_transport_account_for_open_connection
2220 ): Do not try to get transport server accounts for local folders,
2221 because they don't have any. This avoids a g_warning().
2223 * src/maemo/modest-main-window.c:
2224 (modest_main_window_notify_send_receive_initied),
2225 (on_configuration_key_changed):
2226 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
2227 * src/modest-defs.h:
2228 * src/modest-mail-operation.c:
2229 (modest_mail_operation_update_account):
2230 * src/modest-tny-account-store.h:
2231 * src/modest-tny-account.c:
2232 (modest_tny_account_get_special_folder),
2233 (modest_tny_account_new_for_local_folders),
2234 (modest_tny_account_new_for_per_account_local_outbox_folder):
2235 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
2236 * src/modest-tny-local-folders-account.c:
2237 (add_account_folders_to_merged_folder):
2238 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
2239 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
2240 (modest_ui_actions_on_send):
2241 * src/widgets/modest-folder-view.c: (update_model):
2242 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
2243 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
2244 modest_tny_account_store_get_tny_account_by_account() to
2245 modest_tny_account_store_get_server_account() to make the code clearer.
2247 2007-06-07 Marcus Bauer <marcusb@openismus.com>
2249 * src/dbus_api/modest-dbus-api.h:
2250 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
2251 * src/maemo/modest-msg-edit-window.c:
2252 (modest_msg_edit_window_attach_file_noninteractive):
2253 added g_warning in case the file to be attached does not exist
2254 * tests/dbus_api/test_compose_mail.c: (main):
2255 removed obsolete comment, added generic files as test case
2257 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2259 * src/modest-tny-account-store.c: (get_server_accounts):
2260 Create the local folders account only once, not once for each outbox, and
2261 not only when there are some outboxes.
2263 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2265 * src/widgets/modest-folder-view.c: (update_model): Comment out some
2266 code that is causing a crash at startup. Sergio says that he is fixing this.
2268 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
2270 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2271 * src/maemo/modest-account-settings-dialog.c:
2272 (create_page_outgoing),
2273 (modest_account_settings_dialog_set_account_name),
2274 (save_configuration):
2275 - Fixed handling of the "Use secure authentication" toggle to comply with
2276 the ui specification. See also projects.maemo.org bug NB#58400
2278 - Restore the Secure connection setting combo correctly when loading
2281 * src/maemo/modest-maemo-utils.c:
2282 (on_camel_account_get_supported_secure_authentication),
2283 (modest_maemo_utils_get_supported_secure_authentication_methods):
2284 Fixed a crasher if operation is canceled
2286 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
2287 (modest_protocol_info_auth_is_secure):
2288 * src/modest-protocol-info.h:
2290 Added two new methods to determine if a protocol/auth method is secure/encrypted in
2291 the sense of the "Use secure authentication" toggle.
2293 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2295 * src/modest-tny-account-store.h:
2296 * src/modest-tny-account-store.c:
2297 Added modest_tny_account_store_get_local_folders_account().
2299 * src/modest-tny-folder.h:
2300 * src/modest-tny-folder.c:
2301 (modest_tny_folder_get_account):
2302 Added this replacement for tny_folder_get_account() which returns
2303 the local-folders account for TnyMergeFolders, to avoid the
2304 warning about the unimplemented get_account_func() vfunc().
2306 (modest_tny_folder_get_rules),
2307 * src/modest-ui-actions.c:
2308 (modest_ui_actions_on_folder_selection_changed):
2309 * src/modest-mail-operation.c:
2310 (modest_mail_operation_remove_folder),
2311 (modest_mail_operation_xfer_folder),
2312 (modest_mail_operation_rename_folder),
2313 (modest_mail_operation_get_msg),
2314 (modest_mail_operation_get_msgs_full),
2315 (modest_mail_operation_remove_msg),
2316 (modest_mail_operation_xfer_msgs),
2317 (modest_mail_operation_refresh_folder):
2318 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
2320 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2322 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
2323 (modest_server_account_set_security):
2324 * src/modest-defs.h: Add comments explaining that our
2325 UI spec means TLS when it says Normal, so these do not look like errors.
2327 * src/modest-tny-account.c:
2328 (modest_tny_account_new_from_server_account): Use the new tinymail
2329 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
2330 for TLS. This should fix projects.maemo.org bug NB#58460.
2332 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2334 * src/maemo/easysetup/modest-easysetup-wizard.c:
2335 (create_account): Correct the position of the gconf sanity check warning.
2336 (on_button_edit_advanced_settings): Show the dialog immediately, instead
2337 of using the g_idle_add() hack, because this does not seem to be necessary
2338 on osso 1.1. It might even work on Maemo Bora if the problems were actually
2339 caused by something other than maemo's gconf.
2340 This fixes projects.maemo.org bug #59022.
2342 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2344 * src/modest-account-mgr-helpers.c:
2345 (modest_account_mgr_get_default_account): Do not check that the account
2346 exists if there is no default account (NULL), to fix a runtime warning.
2348 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2350 * src/widgets/modest-folder-view.c: (update_model):
2351 Do not unref the treemodel before we have finished with it.
2352 This prevents a valgrind warning and an occasional crash at startup.
2354 2007-06-06 Marcus Bauer <marcusb@openismus.com>
2356 * libmodest-dbus-client/libmodest-dbus-client.h:
2357 added libmodest_dbus_client_compose_mail()
2358 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2360 added functions needed for SendAsMail() functionality
2361 * src/maemo/modest-msg-edit-window.c:
2362 (modest_msg_edit_window_attach_file_noninteractive):
2363 non interactively attaching files to message edit window
2364 * src/widgets/modest-msg-edit-window.h:
2365 * tests/dbus_api/Makefile.am:
2366 added test_compose_mail.c
2367 * tests/dbus_api/test_compose_mail.c: (main):
2369 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2371 * src/modest-account-view.c:
2372 Fixed bug projects.maemo.org bug NB#59307
2374 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2376 * src/maemo/easysetup/modest-easysetup-wizard.c:
2377 (get_serverport_incoming), (on_before_next), (create_account):
2378 * src/maemo/modest-account-settings-dialog.c:
2379 (modest_account_settings_dialog_set_account_name):
2380 * src/maemo/modest-maemo-utils.c:
2381 (on_camel_account_get_supported_secure_authentication_status),
2382 (on_camel_account_get_supported_secure_authentication),
2383 (on_secure_auth_cancel),
2384 (modest_maemo_utils_get_supported_secure_authentication_methods):
2386 Implemented security authentication for settings and easysetup.
2388 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2390 * src/maemo/modest-main-window.c: (create_details_widget):
2391 Show the total size for memory card accounts too, instead of showing
2392 the name again. Fixes bug projects.maemo.org bug NB#59307.
2394 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2397 * src/modest-tny-simple-folder-store.c:
2398 * src/modest-tny-simple-folder-store.h: Removed.
2400 * src/modest-tny-local-folders-account.h
2401 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
2402 for the local-folders maildir, with an extra TnyMergedFolder containing
2403 the folders of the per-account outbox store accounts.
2404 * src/modest-tny-account-store.c: (get_server_accounts):
2405 Add the outboxes to the special local folders account after creating it.
2407 * src/modest-tny-account.c:
2408 (modest_tny_account_new_for_local_folders): Create the derived
2409 account when creating the main local-folders account.
2411 * src/maemo/modest-main-window.c: (create_details_widget),
2412 (modest_main_window_set_contents_style):
2413 Adapted to the use of the derived account instead of the folder store.
2415 * src/modest-ui-actions.c:
2416 (modest_ui_actions_on_folder_selection_changed):
2417 * src/modest-ui-dimming-rules.c:
2418 (modest_ui_dimming_rules_on_new_folder):
2419 * src/widgets/modest-folder-view.c: (text_cell_data),
2420 (icon_cell_data), (filter_row), (update_model),
2421 (get_cmp_rows_type_pos):
2424 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2425 Do not get the priv struct, because no priv struct has been set,
2426 to avoid a runtime warning.
2428 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2429 #ifelse with #else, to fix a warning, to fix the build.
2432 2007-06-05 Christian Kellner <ckellner@openismus.com>
2434 * libmodest-dbus-client/libmodest-dbus-client.c:
2435 Fix small typo in doc (why do you always see them
2436 AFTER committing stuff?)
2439 2007-06-05 Christian Kellner <ckellner@openismus.com>
2441 * libmodest-dbus-client/libmodest-dbus-client.c:
2442 (libmodest_dbus_client_search):
2443 Initialize hit list with NULL. Also set folder list
2444 to "" if NULL was supplied.
2447 2007-06-03 Christian Kellner <ckellner@openismus.com>
2449 * libmodest-dbus-client/libmodest-dbus-client.c:
2450 (modest_search_hit_list_free):
2451 Make it save to call it with NULL.
2453 * src/dbus_api/modest-dbus-callbacks.c:
2454 * src/modest-search.c:
2455 Return full ModestSearchHits as the search result list not TnyHeader
2456 since can't be around withouth the correspoding TnyFolder.
2458 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2460 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2461 Added currently commented code to check for secure auth
2463 * src/maemo/modest-account-settings-dialog.c: (on_response),
2464 (save_configuration), (show_ok):
2465 Fixed projects.maemo.org bugs NB #59248 and #59251
2467 * src/maemo/modest-maemo-utils.c:
2468 (on_camel_account_get_supported_secure_authentication_status),
2469 (on_camel_account_get_supported_secure_authentication),
2470 (modest_maemo_utils_get_supported_secure_authentication_methods):
2471 * src/maemo/modest-maemo-utils.h:
2472 Moved get_supported_secure_authentication() method here to be able
2473 to use it from easysetup wizard.
2475 * src/modest-pair.c: (on_pair_compare_as_string):
2476 Should compare string with first part of pair and not
2477 strcmp pairs which will crash.
2479 * src/modest-protocol-info.c:
2480 (modest_protocol_info_protocol_is_store):
2481 * src/modest-protocol-info.h:
2482 Added modest_protocol_info_get_auth_protocol_name()
2484 2007-06-03 Armin Burgmeier <armin@openismus.com>
2486 * src/modest-mail-operation.c:
2487 (modest_mail_operation_get_msgs_full): Set priv->account also when
2488 only retrieving a single message. This avoids a crash when canceling
2491 (modest_mail_operation_notify_end): Do not explicitely remove the
2492 operation from the queue but only emit the progress_changed signal.
2493 The queue itself listens to that signal to remove the operation when
2494 it is finished. This reduces coupling and removes a potential deadlock
2495 when modest_mail_operation_notify_end() is called from the queue
2496 itself. If that is a problem performance-wise, I would suggest to
2497 implement a status-changed signal or something.
2499 * src/modest-mail-operation-queue.c: Make sure to never call a
2500 function from another file while the queue is locked. This (hopefully)
2501 fixes another deadlock when exiting the application while retrieving
2504 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2506 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2507 Fixed build if libogs is not available
2509 2007-06-03 Christian Kellner <ckellner@openismus.com>
2511 * libmodest-dbus-client/libmodest-dbus-client.h:
2512 * libmodest-dbus-client/libmodest-dbus-client.c:
2513 (libmodest_dbus_client_delete_message):
2514 Implement deletion of messages (Client side).
2516 (modest_search_hit_free),
2517 (modest_search_hit_list_free):
2518 Utility functions to free the result hits.
2520 * src/dbus_api/modest-dbus-api.h:
2521 * src/dbus_api/modest-dbus-callbacks.c:
2522 (on_delete_message),
2523 (modest_dbus_req_handler):
2524 Implement deletion of messages (Server side).
2526 * tests/dbus_api/test_search.c: (main):
2529 * tests/dbus_api/Makefile.am:
2530 * tests/dbus_api/test_delete_message:
2531 Add little test for the message deletion logic
2533 2007-06-03 Armin Burgmeier <armin@openismus.com>
2535 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2536 when the operation queue was not empty. projects.maemo.org bug
2539 2007-06-03 Armin Burgmeier <armin@openismus.com>
2541 * src/widgets/modest-account-view.c
2542 (on_account_default_toggled): Toggle default account column
2543 explicitely instead of waiting for gconf notification (which is
2544 currently ignored). This should fix projects.maemo.org bug NB#56910
2545 for now. It should probably be removed when gconf notifications are
2548 2007-06-03 Christian Kellner <ckellner@openismus.com>
2550 * libmodest-dbus-client/libmodest-dbus-client.c:
2551 Removed debugging spew.
2553 * src/dbus_api/modest-dbus-callbacks.c:
2554 Added debugging info.
2556 * src/modest-search.c:
2557 (modest_search_all_accounts):
2558 Use tny_account_store_get_accounts () on the account store
2559 to get all accounts which is the way to get all accounts.
2561 * tests/dbus_api/test_search.c: (main):
2562 Make it possible to supply the search term on the command line.
2564 2007-06-03 Christian Kellner <ckellner@openismus.com>
2566 * libmodest-dbus-client/libmodest-dbus-client.c:
2567 * libmodest-dbus-client/libmodest-dbus-client.h:
2568 Implement searching for mesages over raw dbus. (Client side)
2570 * src/dbus_api/Makefile.am:
2571 * src/dbus_api/modest-dbus-api.h:
2572 * src/dbus_api/modest-dbus-callbacks.c:
2573 * src/dbus_api/modest-dbus-callbacks.h:
2574 Search framework (Server side). Also implement on_idle_open_message().
2576 * src/maemo/modest-platform.c: (modest_platform_init):
2577 Prepare for raw dbus/osso rpc interaction.
2579 * src/modest-search.h:
2580 Changed minsize from unspecific guint to guint32.
2582 * src/modest-search.c:
2584 Added strange hack which magically made tnymail work.
2586 (modest_search_folder),
2587 (modest_search_account),
2588 (modest_search_all_accounts):
2589 Implement helper functions to search all accounts, specific account
2592 * tests/dbus_api/Makefile.am:
2593 * tests/dbus_api/test_open_message.c:
2594 Read url to open from commandline.
2596 * tests/dbus_api/test_search.c:
2597 Implement small test for dbus search stuff
2599 2007-06-02 Armin Burgmeier <armin@openismus.com>
2601 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2602 include account type and account title. This fixes projects.maemo.org
2605 * src/maemo/modest-account-view-window.c: Set a title for the window.
2607 2007-06-02 Armin Burgmeier <armin@openismus.com>
2609 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2610 incoming and outgoing server name based on email address and server
2611 types as long as the names have not been edited manually. This fixes
2612 projects.maemo.org bug NB#58671.
2614 2007-06-02 Armin Burgmeier <armin@openismus.com>
2616 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2617 server type cannot be changed in future to the incoming details page
2618 when creating an account. This fixes projects.maemo.org bug NB#59029.
2620 2007-06-02 Armin Burgmeier <armin@openismus.com>
2622 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2623 and assigned max width chars so that they wrap instead of being
2624 truncated. Fixes projects.maemo.org bug NB#56126.
2626 2007-06-02 Armin Burgmeier <armin@openismus.com>
2628 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2629 introductory note to the connection specific smtp servers dialog, as
2630 section 8.12 of the email UI specification requires. This fixes
2631 projects.maemo.org bug NB#59212.
2633 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2635 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2636 Check for running mail operations, and offer to cancel them, as per the UI
2637 spec. This fixes projects.maemo.org bug NB#59041 .
2638 However, I suspect that tinymail may still use the network connection
2639 in ways that we cannot detect or cancel. But it should at least adapt to
2640 changes fairly well.
2642 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2644 * src/modest-tny-account-store.c: (recreate_all_accounts),
2645 (get_cached_accounts), (get_server_accounts): Do more sensible
2646 ref-counting of the temporarily-cached outbox accounts list. This seems
2647 to fix a crash when entering the password when the password was wrong.
2649 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2651 * src/gnome/modest-main-window.c: (connect_signals):
2652 * src/modest-tny-account-store.c: (get_password),
2653 (modest_tny_account_store_alert): Added comments and clues and
2654 commented-out code about how we currently fail to deal with connection
2655 errors and wrong passwords, and how we should.
2657 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2659 * src/widgets/modest-retrieve-combo-box.c:
2660 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2661 This fixes projects.maemo.org bug NB#58472 .
2663 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2665 * src/maemo/easysetup/modest-easysetup-wizard.c:
2666 (create_page_complete_easysetup):
2667 (create_page_complete_custom): Correct the last commit,
2668 putting the correct sentences in the correct pages.
2670 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2672 * src/maemo/easysetup/modest-easysetup-wizard.c:
2673 (create_page_complete_custom): Show the second sentence of text
2674 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2677 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2679 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2680 Set the leave-on-server conf key by default. This fixes
2681 projects.maemo.org bug NB#59258 .
2683 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2685 * src/maemo/modest-account-view-window.c:
2686 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2687 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2690 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2692 * src/maemo/easysetup/modest-easysetup-wizard.c:
2693 (create_caption_new_with_asterisk):
2694 * src/maemo/modest-account-settings-dialog.c:
2695 (create_caption_new_with_asterisk):
2696 Uncomment the code to add the asterisk, because they are no longer in the
2697 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2698 (update_incoming_server_title): Add an asterisk here too.
2700 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2702 * src/maemo/modest-maemo-global-settings-dialog.c:
2703 (current_connection): Check that we are even connected before trying to
2704 get the current connection name, to prevent a warning.
2706 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2707 Change the comments because tny_maemo_conic_device_connect() is now meant to
2709 * src/modest-mail-operation.c:
2710 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2711 make sure we have a connection and fail if we can't connect.
2713 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2715 * src/maemo/modest-main-window.c:
2716 (on_account_store_connecting_finished): Do not try to get the
2717 connection ID if we are not really connected. I am surprised that
2718 this signal handler is called when we are not connected.
2720 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2722 * src/modest-error.h:
2723 * src/modest-ui-actions.c:
2724 (modest_ui_actions_get_msgs_full_error_handler):
2725 Renamed an enum, added comments, added an enum
2726 for retrieve-limit errors.
2728 * src/modest-mail-operation.c: (foreach_add_item),
2729 (internal_folder_observer_update), (update_account_thread),
2730 (modest_mail_operation_get_msgs_full):
2731 (modest_mail_operation_update_account),
2732 Added comments about how this works, and some code that should
2733 (but does not) check the retrieve-limit. See the TODO comment.
2735 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2737 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2738 Initialize help_id to fix the build. Warnings are good.
2740 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2742 * src/widgets/modest-hbox-cell-renderer.c:
2743 (modest_hbox_cell_renderer_append):
2744 * src/widgets/modest-vbox-cell-renderer.c:
2745 (modest_vbox_cell_renderer_append):
2746 Fix the last commit by doing an extra ref.
2748 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2750 * src/widgets/modest-hbox-cell-renderer.c:
2751 (modest_hbox_cell_renderer_append):
2752 * src/widgets/modest-vbox-cell-renderer.c:
2753 (modest_vbox_cell_renderer_append):
2754 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2755 to fix the build with Maemo Bora.
2756 However, there seems to be a remaining crash, probably due to reference
2759 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2761 * src/modest-tny-account.c:
2762 (modest_tny_account_new_for_local_folders):
2763 Use hildon_file_system_info_async_new() to get a better name for
2764 the memory card account, setting it as the account name.
2765 The timing seems to work, but this is probably
2766 not the best place to do this. See the TODO comment.
2767 * src/maemo/modest-main-window.c: (create_details_widget):
2768 * src/widgets/modest-folder-view.c: (text_cell_data):
2769 Use the tny account name instead of hardcoding a name.
2771 2007-05-30 Christian Kellner <ckellner@openismus.com>
2773 * src/modest-search.c: (modest_search):
2774 Correctly set part_search_func even if we have already parsed
2775 the query and thus a valid OgsTextSearcher object.
2777 2007-05-30 Christian Kellner <ckellner@openismus.com>
2780 Search and check for libogs.
2783 Incooparte the ogs build env.
2785 * src/modest-mime-part-search-stream.c:
2786 * src/modest-mime-part-search-stream.h:
2787 Removed since we do the real searching now in modest-search.c.
2789 * src/modest-search.c:
2790 * src/modest-search.h:
2791 Implement support for ogs. We use that if available and requested
2792 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2793 should now handle the corner case when the search term is spread
2794 across multiple reads.
2795 Also the logic in modest_search () was corrected to search all
2796 requested fields until one is found.
2798 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2800 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2802 * src/modest-init.h:
2803 * src/modest-init.c: Made modest_init_local_folders() take a
2804 path and be public so we can iniitialize maildir folders on
2807 * src/modest-local-folder-info.h:
2808 * src/modest-local-folder-info.c:
2809 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2811 * src/modest-tny-account.c:
2812 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2813 still means the standard local-folders path on the local volume.
2815 * src/modest-tny-account-store.c:
2816 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2817 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2818 all accounts when that happens.
2819 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2820 this too, so it shows up in the treeview.
2822 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2824 * src/maemo/modest-maemo-global-settings-dialog.c:
2825 (current_connection):
2826 * src/widgets/modest-global-settings-dialog.c:
2827 (current_connection_default):
2828 Use the enum values instead of 0, 1 and -1,
2829 to make the code clearer.
2831 * src/modest-account-mgr-helpers.c:
2832 (modest_account_mgr_get_connection_specific_smtp): Make this code
2835 * src/modest-runtime.h:
2836 * src/modest-runtime.c:
2837 Added modest_runtime_remove_all_send_queues().
2838 * src/maemo/modest-main-window.c:
2839 (on_account_store_connecting_finished): Recreate the send queues,
2840 using the appropriate transport accounts for this new connection.
2841 Some futher adapting might be needed if the old send queues are not
2842 automatically stopped at this point.
2844 * src/modest-tny-account-store.c: (get_server_accounts):
2845 Create the connection-specific transport accounts, so that they can
2846 be found later by their ID.
2848 * src/modest-tny-account.h:
2849 * src/modest-tny-account.c:
2850 Added modest_tny_account_new_from_server_account_name().
2851 modest_tny_account_new_from_server_account(): Do not create the
2852 send queues here, because they will be
2853 recreated anyway when the connection changes for the first time.
2855 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2857 * src/modest-local-folder-info.h:
2858 * src/modest-local-folder-info.c:
2859 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2860 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2861 tbox_folder): Take a modest account name instead of a server TnyAccount,
2862 so we can have per-modest-account rather than per-transport-account
2864 We must make sure that we change or recreate the exisitng send queues
2865 when the connection changes for connection-specific transport accounts.
2867 * src/modest-tny-account-store.c:
2868 (create_per_account_local_outbox_folders): Create outboxed per modest
2869 account, not per transport account.
2871 * src/modest-tny-account.h:
2872 * src/modest-tny-account.c:
2873 (modest_tny_account_get_special_folder): For outboxes, get the
2874 parent modest account name. The account is ignored for other folders.
2875 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2876 modest account name rather than a server TnyAccount.
2878 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2880 * src/modest-tny-account.c:
2881 (modest_tny_account_new_from_server_account):
2882 Call modest_runtime_get_send_queue() immediately after creating transport
2883 accounts, so that they start trying to send email from the outbox as soon
2884 as possible at startup. This is probably what we want.
2886 * src/modest-mail-operation.c: (update_account_thread):
2887 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2888 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2889 * src/modest-tny-send-queue.h:
2890 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2891 (modest_ui_actions_on_send):
2892 Added comments about how sending works, though it needs some more work.
2894 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2896 * src/modest-tny-account.c:
2897 (modest_tny_account_get_special_folder): Add TODO because this fails when
2898 the network is busy.
2899 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2900 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2901 Do not try to show this window when there is no active account. The UI
2902 specs does not tell us what to do in this case.
2904 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2908 * src/maemo/Makefile.am:
2909 * src/widgets/Makefile.am: Some dist fixes.
2911 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2913 * src/maemo/modest-connection-specific-smtp-window.c:
2914 (on_button_edit): Make the code clearer, to prevent a double free.
2916 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2918 * src/maemo/modest-account-settings-dialog.c:
2919 (modest_account_settings_dialog_set_account_name),
2920 Check the connection-specific smtp servers checkbox if there are any.
2922 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2923 (modest_connection_specific_smtp_edit_window_init):
2924 Start with a suitable port number.
2926 * src/modest-account-mgr-helpers.h:
2927 * src/modest-account-mgr-helpers.c: Added
2928 modest_account_mgr_get_has_connection_specific_smtp().
2930 (modest_account_mgr_set_connection_specific_smtp),
2931 (modest_account_mgr_remove_connection_specific_smtp),
2932 (modest_account_mgr_get_has_connection_specific_smtp),
2933 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2934 connection-specific smtp server accounts in the account, rather than
2935 the server account conf dir.
2937 This fixes bug projects.maemo.org bug NB#58263 .
2939 * src/modest-tny-account-store.c:
2940 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2941 if there are no server accounts yet, to prevent an infinite loop when there
2942 are no accounts. Document that one must be called before the other.
2944 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2946 * src/modest-account-mgr-helpers.c:
2947 (modest_account_mgr_get_default_account): Make sure that at least
2948 one account is always the default, if there are any enabled accounts.
2949 This is just a sanity check that shouldn't be necessary.
2951 * src/modest-account-mgr-priv.c:
2952 (_modest_account_mgr_account_from_key): Unescape the conf key to
2953 get the real account name. For instance, this is an issue if a space
2954 was in the account name, which can happen because the account name
2955 is generated from the display name.
2956 (_modest_account_mgr_get_account_keyname): Always escape the
2958 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2959 Unescape the conf keys to get the real account names.
2961 For instance, previously the is-default radio button in the accounts
2962 list was not checked for any accounts at first. This fixes that,
2963 and might fix several similar bugs.
2965 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2967 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2968 Removed some debug printfs.
2970 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2972 Modest on-disk outbox directories are now here, for instance:
2973 $HOME/.modest/outboxes/<account-id-1>/outbox
2974 $HOME/.modest/outboxes/<account-id-2>/outbox
2976 $HOME/.modest/local-folders/outbox
2977 so we can have a separate outbox for each account.
2978 But they are shown as one outbox in the GtkTreeView, by using a
2979 TnyMergeFolder in a ModestTnySimpleFolderStore.
2982 * src/modest-tny-simple-folder-store.c:
2983 * src/modest-tny-simple-folder-store.h:
2984 Added ModestTnySimpleFolderStore, used to contain folders from
2985 other folder stores, such as other accounts.
2987 * src/modest-tny-outbox-account.h:
2988 * src/modest-tny-outbox-account.c:
2989 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2990 used for the per-account local outbox folders.
2992 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2993 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2994 only use this (internally) now for the non-outbox local folders.
2996 * src/modest-init.h:
2997 * src/modest-init.c: Added modest_init_one_local_folder(), for
2998 setting up the directory structure for each local folder.
3000 * src/modest-local-folder-info.c:
3001 (modest_per_account_local_outbox_folder_info_get_maildir_path),
3002 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
3004 * src/modest-local-folder-info.h:
3005 * src/modest-tny-account-store.c: (on_account_removed),
3006 (on_account_changed), (create_per_account_local_outbox_folders),
3007 (get_server_accounts), (modest_tny_account_store_get_accounts),
3008 (modest_tny_account_store_get_tny_account_by_account),
3009 (modest_tny_folder_store_is_virtual_local_folders):
3011 * src/modest-tny-account.h:
3012 * src/modest-tny-account.c:
3013 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
3014 to create an on-disk per-account local outbox folder for each
3016 (create_per_account_local_outbox_folders): Create a local outbox folder
3017 for each transport account.
3018 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
3019 for all local folders.
3021 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
3022 instead of using g_object_get/set() directly. It is clearer.
3024 (modest_tny_folder_store_get_message_count),
3025 (modest_tny_folder_store_get_local_size
3026 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
3027 because we now use these with non-acount folder stores.
3029 (modest_tny_account_get_special_folder),
3030 (modest_tny_account_new_from_server_account),
3031 (modest_tny_account_new_from_account):
3032 (recurse_folders): Adjust to the new outbox system.
3034 * src/modest-tny-folder.h:
3035 * src/modest-tny-folder.c:
3036 (modest_tny_folder_is_local_folder),
3037 (modest_tny_folder_get_local_folder_type),
3038 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
3040 * src/widgets/modest-main-window.h:
3041 * src/maemo/modest-main-window.c: (create_details_widget),
3042 (modest_main_window_set_contents_style): Show details for any folder store,
3045 (modest_tny_folder_get_rules):
3046 Remove the const. C does not support constness enough for this.
3048 * src/modest-ui-actions.c:
3049 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
3050 make all outboxes appear as one, in the usual local-folders tree node.
3052 (set_active_account_from_tny_account),
3053 (modest_ui_actions_on_folder_selection_changed):
3054 * src/widgets/modest-folder-view.c: (text_cell_data),
3055 (icon_cell_data), (filter_row),
3056 (add_account_folders_to_merged_folder),
3057 (add_account_folders_to_simple_folder_store), (),
3058 (get_cmp_rows_type_pos), (cmp_rows),
3059 (modest_folder_view_set_account_id_of_visible_server_account):
3060 Adjust to the new outbox system, using generic folder stores and folders
3061 in the GtkTreeModel.
3063 2007-05-23 Christian Kellner <ckellner@openismus.com>
3065 * src/modest-mail-operation.c:
3066 (modest_mail_operation_update_account):
3067 Use info->max_size instead of unintialized local var [small
3068 build fix]. (Added TODO to review that change since I don't
3071 2007-05-23 Marcus Bauer <marcusb@openismus.com>
3073 * libmodest-dbus-client/libmodest-dbus-client.c:
3074 (libmodest_dbus_client_compose_mail): function added
3075 * src/dbus_api/modest-dbus-api.h:
3076 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
3077 (on_compose_mail): Implementation of the SendAsMail functionality
3079 2007-05-22 Murray Cumming <murrayc@murrayc.com>
3081 * src/modest-account-mgr.c:
3082 (modest_account_mgr_add_server_account): Set the secure-connection
3083 conf key for transport accounts as well as store accounts. I don't know
3084 why the if was there. For instance, this makes sure that we use SSL
3085 for the gmail preset from the easysetup wizard.
3087 2007-05-22 Murray Cumming <murrayc@murrayc.com>
3089 * src/gnome/modest-main-window.c:
3090 (on_account_store_connecting_finished), (connect_signals):
3091 * src/maemo/modest-main-window.c:
3092 (on_account_store_connecting_finished), (connect_signals),
3093 (modest_main_window_new):
3094 Handle TnyAccountStore::connecting-finished instead of
3095 TnyDevice::connection-changed, because we cannot actually perform
3096 operations on accounts until TnyAccountStore has itself responded to
3097 the TnyDevice::connection-changed signal. This prevents a GError from
3099 Do not try to update at startup, because we (at least on scratchbox)
3100 already do an update at startup when the device goes online.
3101 This prevents a GError from tinymail.
3102 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
3103 Added TODO about stopping simultaneous operations.
3105 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3107 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
3108 * src/modest-mail-operation-queue.c:
3109 (modest_mail_operation_queue_remove):
3110 * src/modest-tny-account-store.c: When GErrors happen, give more clues
3111 about where they happened.
3113 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3115 * src/modest-ui-actions.c:
3116 (modest_ui_actions_on_password_requested): Make sure that the remember
3117 output parameter is always TRUE.
3119 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3121 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3122 Show a OK/Cancel dialog if the error is a question, though we still do not
3123 know anything more about what we are asking the user.
3124 * src/widgets/modest-folder-view.c: (on_drag_data_received):
3125 Fix an uninitialized variable (helper). This is a logic error, however.
3127 2007-05-21 Christian Kellner <ckellner@openismus.com>
3129 * src/modest-search.h:
3130 Correct bit shifting in the ModestSearchFlags enum.
3132 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3134 * src/modest-tny-account.c:
3135 (modest_tny_account_new_from_server_account): Do not use the lsub and
3136 check-all hard-coded IMAP options when using POP.
3138 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3140 * src/modest-tny-account.c:
3141 (modest_tny_account_new_from_server_account):
3142 Use NULL for the secure-auth method for POP when Password auth has been
3143 specified by the user, as we already do for IMAP. "auth=Login" causes
3144 an error from camel or the server.
3146 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3148 * src/maemo/modest-account-settings-dialog.c:
3149 (create_page_account_details),
3150 (modest_account_settings_dialog_set_account_name):
3151 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
3152 for the leave-on-server checkbox, rathr than just the checkbox, when
3153 the protocol is not POP.
3155 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3157 * src/widgets/modest-account-view.c:
3158 * src/widgets/modest-account-view.h:
3159 Added modest_account_view_select_account() which will be useful later
3160 to asynchronously re-select the edited account.
3162 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3164 * src/maemo/modest-account-settings-dialog.c:
3165 (modest_account_settings_dialog_set_account_name):
3166 Automatically choose the port numbers based on the secure authentication
3167 methods, if they have not been chosen before.
3168 This fixes projects.maemo.org bug NB#56273 .
3170 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3172 * src/maemo/modest-main-window-ui.h:
3173 * src/modest-ui-actions.c:
3174 * src/modest-ui-actions.h:
3175 Connect the Tools/SMTP Servers menu item to
3176 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
3177 SMTP servers dialog, as in the UI specification and saves changes when it
3178 is closed. This fixed projects.maemo.org bug NB#56305 .
3180 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3182 * src/maemo/modest-connection-specific-smtp-window.c:
3183 (modest_connection_specific_smtp_window_init):
3184 Use gtk_window_set_default_size() to make this window big enough, so
3185 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
3187 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3189 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3190 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3191 (modest_connection_specific_smtp_edit_window_init),
3192 Do not try to connect to a combobox signal before the combobox exists.
3193 This fixes the cras in projects.maemo.org bug NB#56288 .
3194 (modest_connection_specific_smtp_edit_window_get_settings):
3195 Remove the server_account_name parameter which was being checked for NULL
3196 though it was not used.
3198 * src/maemo/modest-connection-specific-smtp-window.c:
3199 (modest_connection_specific_smtp_window_fill_with_connections),
3200 (on_button_edit), (modest_connection_specific_smtp_window_init):
3201 Correct the number of treemodel columns to prevent a warning.
3202 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
3203 libconic does not work.
3205 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3207 * src/modest-tny-account.c:
3208 (modest_tny_account_new_from_server_account):
3209 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
3210 SMTP when "None" was chosen by the user. However, with my SMTP server that
3211 does not support ANONYMOUS, the emails do not leave the Outbox and I see
3214 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3216 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
3217 to explain the memory management issue with the ID in the ModestPair.
3219 * src/gnome/modest-account-assistant.c: (add_receiving_page),
3220 (add_sending_page), (modest_account_assistant_finalize):
3221 * src/gnome/modest-gnome-global-settings-dialog.c:
3222 (create_updating_page), (create_composing_page):
3223 * src/gnome/modest-msg-edit-window.c: (get_transports),
3224 (init_window), (modest_msg_edit_window_finalize),
3225 (modest_msg_edit_window_get_msg_data):
3226 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
3227 * src/gnome/modest-transport-widget.c:
3228 (modest_transport_widget_finalize), (smtp_configuration):
3229 * src/maemo/modest-maemo-global-settings-dialog.c:
3230 (create_updating_page), (create_composing_page):
3231 * src/maemo/modest-msg-edit-window.c: (get_transports),
3232 (init_window), (modest_msg_edit_window_finalize),
3233 (modest_msg_edit_window_get_msg_data),
3234 (modest_msg_edit_window_free_msg_data):
3235 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
3236 (modest_store_widget_finalize):
3237 * src/maemo/modest-transport-widget.c:
3238 (modest_transport_widget_finalize), (smtp_configuration):
3239 * src/modest-main.c: (send_mail):
3240 * src/widgets/modest-combo-box.h:
3241 * src/widgets/modest-global-settings-dialog-priv.h:
3242 * src/widgets/modest-global-settings-dialog.c:
3243 (modest_global_settings_dialog_finalize):
3244 * src/widgets/modest-msg-edit-window.h:
3245 Whenever using modest_combo_box_new(), keep the ModestPairList alive
3246 as long as the combo box, to prevent use of freed memory for the ID.
3248 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3250 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
3251 get_accounts(), to make this clearer. Do not check for the enabled gconf
3252 key, because we do not use this for server accounts (at least, not yet).
3253 This allows us to send email again.
3255 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3257 * src/maemo/modest-platform.c:
3258 (on_modest_conf_update_interval_changed), (modest_platform_init):
3259 Only respond to this particular key change. All these strcmp()s cannot be
3262 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3264 * src/maemo/modest-maemo-global-settings-dialog.c:
3265 (current_connection): Prevent a crash in scratchbox when
3266 ny_maemo_conic_device_get_current_iap_id() returns NULL.
3267 * src/maemo/modest-platform.c:
3268 (on_modest_conf_update_interval_changed), (modest_platform_init):
3269 Get the update interval from gconf and reset it when the gconf key changes.
3271 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3273 * src/modest-protocol-info.c:
3274 * src/modest-protocol-info.h: Adde enum-specific get functions,
3275 instead of using a ModestProtocolType enum parameter.
3277 * src/gnome/modest-account-assistant.c:
3278 * src/gnome/modest-store-widget.c:
3279 * src/gnome/modest-store-widget.h:
3280 * src/gnome/modest-transport-widget.c:
3281 * src/gnome/modest-transport-widget.h:
3282 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
3283 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
3284 * src/maemo/easysetup/modest-easysetup-wizard.c:
3285 * src/maemo/modest-account-settings-dialog.c:
3286 * src/maemo/modest-account-settings-dialog.h:
3287 * src/maemo/modest-store-widget.c:
3288 * src/maemo/modest-store-widget.h:
3289 * src/maemo/modest-transport-widget.c:
3290 * src/maemo/modest-transport-widget.h:
3291 * src/modest-account-mgr-helpers.c:
3292 * src/modest-account-mgr-helpers.h:
3293 * src/modest-account-mgr.c:
3294 * src/modest-account-mgr.h:
3295 * src/modest-tny-account.c:
3296 * src/modest-tny-folder.c:
3297 * src/widgets/modest-account-view.c:
3298 * src/widgets/modest-retrieve-combo-box.c:
3299 * src/widgets/modest-retrieve-combo-box.h:
3300 * src/widgets/modest-secureauth-combo-box.c:
3301 * src/widgets/modest-serversecurity-combo-box.c:
3302 * src/widgets/modest-serversecurity-combo-box.h:
3303 * tests/check_account-mgr.c:
3304 Use the specific functions, and use the re-renamed enum values for GNOME too.
3306 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3308 * src/modest-pair.h:
3309 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
3310 so we can get the second based on the first.
3312 * src/maemo/modest-account-settings-dialog.h:
3313 * src/maemo/modest-account-settings-dialog.c:
3314 Added get_supported_secure_authentication_methods(), though it is mostly
3315 commented-out for now until the necessary API is committed to tinymail.
3316 (modest_account_settings_dialog_set_account_name),
3317 (save_configuration): Request the supported authentication methods from the
3318 server, so we can choose a working method.
3320 * src/modest-tny-account-store.h:
3321 * src/modest-tny-account-store.c:
3322 (modest_tny_account_store_get_session): Rename from
3323 tny_account_store_get_session().
3325 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3327 * src/modest-protocol-info.h: Split the ModestProtocol enum
3328 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
3329 There was no need to have these unrelated values in one enum.
3331 * src/: many files: Adapted to changed enum. This makes the code a bit
3332 clearer, and the compiler could catch some errors.
3334 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3336 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3337 Show the detailed internal camel error message when an error happens
3338 during the configuration, so that our testers can give us more clues.
3339 For instance, in projects.maemo.org bug NB#56910 .
3341 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3343 * src/modest-tny-account.c:
3344 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
3345 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
3347 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3349 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3350 * src/maemo/modest-account-settings-dialog.c:
3351 (modest_account_settings_dialog_set_account_name),
3352 (save_configuration): For the incoming secure authentication checkbox,
3353 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
3354 the UI specification. PLAIN does not seem to be supported for most IMAP
3355 servers anyway, and I am not sure what it would mean.
3356 However, we probably need to discover which of the secure-authentication
3357 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
3358 * src/modest-account-mgr-helpers.c:
3359 (modest_account_mgr_get_server_account_data):
3361 * src/modest-tny-account.c:
3362 (modest_tny_account_new_from_server_account):
3363 Use tny_account_set_mech() to set secure-authentication methods,
3364 with some special-casing for IMAP, based on my observations of how
3367 * src/modest-account-mgr-helpers.h:
3368 * src/modest-account-mgr.c:
3369 * src/modest-defs.h: Comment that the URI is only used for local folders.
3371 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3373 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
3374 parameter const, just to be neat.
3375 * src/modest-text-utils.c: (modest_text_utils_inline):
3376 End g_strconcat() with NULL, as its documentation says. This is almost
3377 certainly the cause of my crash at startup on the device. Interestingly,
3378 valgrind doesn't tell us about these errors.
3380 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3382 * scripts/build-packages: Added more precise comments about how to use
3383 this script, though I still get this error:
3384 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
3385 error building tinymail
3387 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3389 * src/maemo/modest-main-window.c: (on_account_update):
3390 Very slight cleanup, hoping to make it simpler to discover what causes
3391 a crash here sometimes.
3393 * src/modest-tny-account.c:
3394 (modest_tny_account_new_from_server_account): Set the port. Added
3395 comments about the options and a TODO comment because I need to find out
3396 how to specify the secure authentication method.
3398 2007-05-11 Marcus Bauer <marcusb@openismus.com>
3400 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3401 changed CFlags paths form modest to libmodest
3403 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3405 * src/modest-account-mgr-helpers.c:
3406 (modest_account_mgr_get_server_account_data),
3407 (modest_account_mgr_free_server_account_data):
3408 * src/modest-account-mgr-helpers.h:
3409 * src/modest-account-mgr.c:
3410 (modest_account_mgr_add_server_account):
3411 * src/modest-defs.h:
3412 * src/modest-tny-account.c:
3413 (modest_tny_account_new_from_server_account):
3414 Determine the options for tny_camel_account_add_option() here,
3415 based on the settings, rather than storing them directly in gconf.
3417 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3419 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3420 Show a more friendly error dialog now that we expect (from the tinymail
3421 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3423 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3425 * src/maemo/modest-main-window.c: (on_account_update): Check that
3426 account_name is not NULL, to prevent a crash at startup that I am
3427 seeing on the N800. I do wonder why it is NULL.
3429 * src/maemo/easysetup/modest-easysetup-wizard.c:
3430 (create_page_user_details):
3431 * src/maemo/modest-account-settings-dialog.c:
3432 (create_page_user_details), (create_page_outgoing):
3433 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3434 (modest_connection_specific_smtp_edit_window_init):
3435 * src/modest-ui-actions.c:
3436 (modest_ui_actions_on_password_requested):
3437 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3438 might do something useful with the on-screen keyboard.
3440 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3442 * src/maemo/modest-main-window.c: (on_account_update):
3443 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3444 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3446 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3448 * src/modest-tny-account-store.c: (on_account_changed):
3449 Correct the signature of this signal handler.
3451 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3453 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3454 Show a HildonNote instead of a GtkDialog for Maemo.
3456 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3458 * src/widgets/modest-account-view.h:
3459 * src/widgets/modest-account-view.c: (on_account_changed),
3460 (on_account_removed). Added a boolean flag, set/unset by
3461 modest_account_view_block_conf_updates(),
3462 modest_account_view_unblock_conf_updates() to prevent unnecessary
3463 updates, but this is not very useful because the gconf notifications are
3464 so delays (maybe only on Maemo Bora).
3465 So auto-updating is turned off, and these functions do an explicit
3466 update when necessary.
3467 However, something else is still doing too much work when adding/removing
3468 accounts, probably in another part of the application.
3470 * src/maemo/modest-account-view-window.c:
3471 (on_delete_button_clicked), (on_edit_button_clicked),
3472 (on_new_button_clicked): Use the new functions.
3474 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3476 * src/modest-account-mgr-helpers.c:
3477 (modest_account_mgr_set_first_account_as_default):
3478 Sort the list of names alphabetically-by-title, so we choose the first one
3480 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3481 alphabetically by the title.
3483 This fixes projects.maemo.org bug NB#56418 .
3485 * src/modest-account-mgr-priv.c:
3486 (_modest_account_mgr_account_from_key):
3487 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3488 avoid a valgrind error, and possible random behaviour.
3490 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3492 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3493 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3494 tinymail documentation to say that this can be expected.
3495 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3496 pretty, and should not happen, but I would prefer to know when it does.
3498 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3500 * configure.ac: When using the older hildon version, probably on Bora,
3501 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3503 * src/widgets/modest-attachment-view.c:
3504 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3507 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3509 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3510 Implemented the prototype. Can be tested with
3511 tests/dbus_api/test_open_message:
3513 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3515 * src/modest-tny-account-store.c:
3516 (modest_tny_account_store_instance_init), (get_password):
3517 * src/modest-ui-actions.c:
3518 (modest_ui_actions_on_password_requested):
3519 Do not store the password in gconf, because this function is called
3520 for non-remembered passwords. Actually use the cached (in the hash map)
3521 password instead of releasing it.
3522 The password will now not be remembered if it is asked via the protected
3523 password dialog, as per the UI spec.
3525 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3527 * src/modest-defs.h:
3528 * src/modest-account-mgr-helpers.h:
3529 * src/modest-account-mgr-helpers.c:
3530 Added modest_server_account_get_username_has_succeeded(),
3531 modest_server_account_set_username_has_succeeded().
3532 (modest_server_account_set_username),
3533 Reset the has-succeeded flag if the username changes.
3535 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3536 * src/maemo/modest-connection-specific-smtp-window.c:
3537 (modest_connection_specific_smtp_window_save_server_accounts):
3538 Use modest_server_account_set_username() instead of using
3539 modest_conf_set_string() directly, so that the has-succeeded flag is always
3542 * src/modest-ui-actions.c:
3543 (modest_ui_actions_on_password_requested): Dim the username entry if
3544 the username has ever worked, as per the UI spec.
3546 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3548 * src/modest-tny-account-store.c: (get_password):
3549 * src/modest-ui-actions.c:
3550 (modest_ui_actions_on_password_requested):
3551 Allow the username to be changed too, though there is more work to
3552 be done on exactly how this behaves.
3554 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3556 * src/modest-account-mgr-helpers.h:
3557 * src/modest-account-mgr-helpers.c:
3558 Added modest_account_mgr_get_display_name(),
3559 modest_server_account_get_username(),
3560 modest_server_account_set_username(),
3561 modest_server_account_set_password(),
3562 modest_server_account_get_hostname() functions so we do not need to
3563 use the conf API directly.
3565 * src/maemo/modest-main-window.c: (connect_signals):
3566 Actually connect ot the ModestAccountStore::request-password signal,
3567 so that we show the dialog when the password is requested by Tinymail,
3568 for isntance if it is empty.
3570 * src/modest-marshal.list:
3571 * src/modest-tny-account-store.c:
3572 (modest_tny_account_store_class_init), (get_password),
3573 (modest_tny_account_store_alert):
3574 * src/modest-tny-account-store.h:
3575 * src/modest-ui-actions.h:
3576 * src/modest-ui-actions.c:
3577 (modest_ui_actions_on_password_requested):
3578 Change the signal parameters, so it is obvious that we are providing
3579 the non human-readable server name, and receiving both the username
3580 and password, though changing of the username is not yet implemented.
3581 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3582 for the GNOME version.
3584 This should fix the projects.maemo.org bug NB#56209, though it does not
3585 work on Bora, because the gconf_client_get() for the password fails
3586 immediately after we save it with gconf_client_set().
3588 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3591 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3592 caused an undefined symbol error:
3593 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3595 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3597 * src/modest-tny-account-store.c:
3598 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3599 using a GError instead of a string message, so we can translate it in
3602 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3604 * src/maemo/modest-address-book.c:
3605 (modest_address_book_check_names):
3606 * src/maemo/modest-msg-view-window.c:
3607 (modest_msg_view_window_clipboard_owner_change):
3608 * src/modest-init.c: (modest_init_init_ui):
3609 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3610 (update_folders_cb), (modest_mail_operation_update_account):
3611 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3612 (modest_ui_actions_on_msg_attachment_clicked),
3613 (modest_ui_actions_on_msg_recpt_activated):
3614 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3615 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3616 (modest_msg_view_search_next):
3617 * src/widgets/modest-recpt-editor.c:
3618 (modest_recpt_editor_on_button_release_event),
3619 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3620 g_message(). At this point we should only be seeing interesting errors on
3621 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3623 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3625 (modest_wizard_dialog_force_title_update):
3626 * src/maemo/easysetup/modest-wizard-dialog.h:
3627 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3628 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3629 can update the title when appropriate. Otherwise the title is wrong if the
3630 pages are added after adding the notebook to the dialog.
3631 This must be a problem in HildonWizardDialog too.
3632 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3634 * src/maemo/easysetup/modest-easysetup-wizard.c:
3635 (create_subsequent_customsetup_pages),
3636 (create_subsequent_easysetup_pages):
3637 Call modest_wizard_dialog_force_title_update() so that the title is
3638 correct even with GTK+ < 2.10.
3639 This fixes projects.maemo.org bug NB#56145 .
3641 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3643 * src/maemo/modest-platform.c:
3644 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3645 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3648 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3650 * src/widgets/modest-window.h:
3651 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3652 and modest_window_save_state(), which invokes it.
3654 * src/widgets/modest-window-mgr.h:
3655 * src/widgets/modest-window-mgr.c:
3656 Added modest_window_mgr_save_state_for_all_windows(), which calls
3657 the save_state vfunc on all registered windows, if implemented.
3659 * src/gnome/modest-msg-edit-window.c:
3660 * src/gnome/modest-msg-view-window.c:
3661 * src/maemo/modest-msg-edit-window.c:
3662 * src/maemo/modest-msg-view-window.c:
3663 * src/maemo/modest-main-window.c:
3664 Specify the existing save_settings functions as implementations of
3665 ModestWindow::save_state_func().
3667 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3668 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3669 enabling hibernation, for instance.
3671 We may need to do the same thing for restoring settings.
3674 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3676 * src/widgets/modest-window-mgr.c:
3677 * src/widgets/modest-window-mgr.h:
3678 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3679 modest_window_mgr_get_hibernation_is_prevented().
3681 * src/maemo/modest-main-window.c:
3682 (on_hildon_program_is_topmost_notify): Prevent hibernation
3683 (possible when the application goes to the background in the WM),
3684 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3686 * src/maemo/easysetup/modest-easysetup-wizard.c:
3687 (modest_easysetup_wizard_dialog_init):
3688 * src/maemo/modest-account-settings-dialog.c:
3689 (modest_account_settings_dialog_init):
3690 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3691 (modest_connection_specific_smtp_edit_window_init):
3692 * src/maemo/modest-connection-specific-smtp-window.c:
3693 (modest_connection_specific_smtp_window_init):
3694 * src/maemo/modest-signature-editor-dialog.c:
3695 (modest_signature_editor_dialog_init):
3696 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3697 prevent hibernation while any of these account settings dialogs are open.
3699 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3701 * src/maemo/Makefile.am:
3702 * src/maemo/modest-osso-state-saving.c:
3703 * src/maemo/modest-osso-state-saving.h: Added
3704 modest_osso_load_state() and modest_osso_save_state() though they do
3705 nothing now. They should iterate through all the open windows and load/save
3707 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3708 save state when closing.
3710 * src/maemo/modest-main-window.c:
3711 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3712 Add a notification handler for the HildonProgram::is-topmost property,
3713 so we can allow hibernation when the application goes into the background.
3714 But we still need to detect when the accounts setup windows are open so
3715 we can stop hibernation when they are open.
3716 To do this, I also added the main window the HildonProgram. This might have
3717 other side-effects/benefits, and should maybe be done for other windows.
3719 * src/maemo/modest-osso-autosave-callbacks.h:
3720 * src/maemo/modest-osso-autosave-callbacks.c:
3721 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3722 though it does not do anything yet, and we might never need this to do
3723 anything. For instance, we already save drafts.
3725 * src/maemo/modest-platform.c: (modest_platform_init):
3726 Specify the libosso auto-save callback.
3728 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3730 * src/maemo/modest-platform.c:
3731 (modest_platform_set_update_interval):
3732 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3733 aparently stays valid between application instances, so we can use this
3734 to remove and reset it later. According to a maemo-developers email from
3737 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3739 * configure.ac: Depend on libalarm for Maemo.
3741 * src/dbus_api/modest-dbus-api.h:
3742 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3743 (on_send_receive), (modest_dbus_req_handler):
3744 Handle a SEND_RECEIVE D-Bus method.
3746 * libmodest-dbus-client/libmodest-dbus-client.c:
3747 (libmodest_dbus_client_send_and_receive):
3748 * libmodest-dbus-client/libmodest-dbus-client.h:
3749 Add C convenience functions for calling the new D-Bus method.
3751 * src/modest-platform.h:
3752 * src/gnome/modest-platform.c:
3753 * src/maemo/modest-platform.c:
3754 Added modest_platform_set_update_interval(), which uses the
3755 alarmd API on Maemo.
3756 (modest_platform_init),
3757 Call modest_platform_set_update_interval(), using a hard-coded
3758 interval for now (until the global settings dialog is implemented),
3759 though I am not sure that this makes sense yet.
3761 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3763 * src/dbus_api/modest-dbus-callbacks.c:
3764 (modest_osso_cb_hw_state_handler):
3765 * src/dbus_api/modest-dbus-callbacks.h:
3766 * src/maemo/modest-platform.c: (modest_platform_init):
3767 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3768 in case this has some effect on the ability for Maemo to ping the
3771 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3773 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3774 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3775 warning. It is probably a logic error, but I need to fix the build.
3777 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3779 * src/modest-account-mgr.h:
3780 * src/modest-account-mgr.c:
3781 (modest_account_mgr_account_names): Add a gboolean enabled_only
3782 parameter, so we can get lists of onlt the enabled accounts.
3784 (modest_account_mgr_add_account),,
3785 (modest_account_mgr_account_with_display_name_exists):
3786 * src/maemo/modest-msg-edit-window.c: (get_transports):
3787 * src/modest-account-mgr-helpers.c:
3788 (modest_account_mgr_set_first_account_as_default):
3789 * src/modest-init.c: (init_default_account_maybe):
3790 * src/modest-tny-account-store.c: (get_accounts):
3791 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3792 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3793 * tests/check_account-mgr.c: (START_TEST):
3794 Provide the extra parameter, as appropriate.
3796 * src/widgets/modest-account-view.c: (update_account_view):
3797 Do not show disabled accounts (meaning that there is no way to
3798 enable/disable accounts in the UI (the feature is not in our UI
3799 specification), so we can use this internally only to mark unfinished
3800 or temporary account data.
3802 * src/maemo/easysetup/modest-easysetup-wizard.c:
3803 (create_account): Add boolean enable parameter, so we can specify FALSE
3804 to create the temporary account.
3805 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3806 (on_before_next): When finishing, when there is a temporary account, just
3808 Also, use a timeout to delay the showing of the dialog until gconf is likely
3809 to return correct information, due to a maemo gconf bug that is fixed in
3810 osso 1.1, but not yet in Bora.
3811 However, the dialog stays on screen after it is destroyed.
3813 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3814 for invalid data when cancelling. Use a hildon note instead of a dialog
3815 to complain about invalid data. Do not show the account-saved note if the
3816 account is disabled (a temporary account that will not really be saved for use
3819 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3821 * src/modest-account-mgr-helpers.h:
3822 * src/modest-account-mgr-helpers.c:
3823 Added modest_account_mgr_unset_default_account(),
3824 Added modest_account_mgr_set_first_account_as_default().
3826 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3827 If it was the default account, unset the default account name.
3829 * src/maemo/modest-account-view-window.c:
3830 (on_delete_button_clicked): If it was the default account,
3831 set the first remaining account as the default instead.
3833 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3834 a NULL account or a NULL default account, to prevent a crash. This should
3835 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3838 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3840 * src/widgets/modest-recpt-editor.c:
3841 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3842 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3843 TODO comment for this. This fixes the build.
3845 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3846 be the best place for it. This will in future update all auto-update accounts,
3847 rather than just the current/default account, when that gconf key exists.
3848 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3849 if there are no accounts, before calling do_send_receive().
3850 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3852 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3853 * src/maemo/modest-main-window-ui.h:
3854 * src/maemo/modest-main-window.c: (on_connection_changed),
3855 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3856 directly, becaue the signal handler does more.
3858 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3860 * src/modest-account-mgr-helpers.c:
3861 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3862 for the case that the account does not exist.
3864 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3865 (equivalent to the modest account name) rather than the tinymail account name
3866 (equivalent to the modest account title - human readable) to get the account data.
3867 Check for null account data to prevent the crash, and add a TODO comment saying that
3868 this needs fixing because it is using the server account name instead of the account name.
3870 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3872 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3873 * src/maemo/modest-account-settings-dialog.c: (show_error),
3875 Use hildon_note_new_information() for informative and error messages,
3876 which seems to be expected for Maemo applications (no documentation that I know of
3877 says this). I am surprised that there is no distinction between info and error
3880 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3882 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3883 it is easy to find where this is used.
3885 * src/maemo/easysetup/modest-easysetup-wizard.c:
3886 (create_page_welcome), (create_page_account_details),
3887 (create_page_user_details), (create_page_complete_easysetup),
3888 (create_page_custom_incoming), (create_page_custom_outgoing),
3889 (create_page_complete_custom):
3890 * src/maemo/modest-account-settings-dialog.c:
3891 (create_page_account_details), (create_page_user_details),
3892 (create_page_incoming), (create_page_outgoing):
3893 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3894 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3895 (modest_connection_specific_smtp_edit_window_init):
3896 * src/maemo/modest-connection-specific-smtp-window.c:
3897 (modest_connection_specific_smtp_window_init):
3898 * src/maemo/modest-signature-editor-dialog.c:
3899 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3900 and scrolling policy as per the Email Application Layout Guide, if I have
3903 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3905 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3906 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3907 which were empty, because these vfuncs have been removed from TnyAccountStore.
3908 This fixes the build.
3910 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3912 * src/maemo/modest-main-window.c:
3913 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3914 showing/hiding it. Added TODO because it probably should not be NULL.
3915 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3916 because unnecessary g_warnings() make degugging difficult.
3918 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3920 * src/maemo/modest-msg-edit-window.c:
3921 (modest_msg_edit_window_select_color),
3922 (modest_msg_edit_window_select_background_color): 2 const corrections and
3923 moving 2 #endifs before closing brackets, to fix the build.
3925 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3927 * src/maemo/easysetup/modest-easysetup-wizard.h:
3928 * src/maemo/easysetup/modest-easysetup-wizard.c:
3929 (modest_easysetup_wizard_dialog_finalize),
3930 (on_button_edit_advanced_settings), (create_page_complete_custom),
3931 (on_response), (create_account):
3932 Implement the Advanced Settings edit button, by saving the account information,
3933 for the Advanded Settings dialog to use directly from gconf, and removing it
3934 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3935 Bug #5533 in the projects.maemo.org bugzilla.
3937 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3939 * src/maemo/modest-msg-view-window.c:
3940 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3941 when opening a message window.
3943 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3945 * src/maemo/easysetup/modest-easysetup-wizard.c:
3946 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3949 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3950 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3951 gconf settings. I probably added more checks than necessary, but that is safer.
3953 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3954 variable to fix the build, but this seems to be used when it is still NULL.
3956 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3958 * src/modest-platform.h:
3959 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3960 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3961 * src/modest-main.c: Implement this function so we can avoid using
3962 maemo-specific API from cross-platform code.
3964 * src/modest-tny-account-store.c:
3965 (get_smtp_specific_transport_account_for_open_connection):
3966 * src/modest-ui-actions.c: (check_for_connection),
3967 (modest_ui_actions_on_item_not_found):
3968 Use modest_platform_connect_and_wait() and put #idefs around other
3969 maemo-specific code, because only maemo currently has a way to
3970 identify connection names.
3972 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3974 * src/modest-tny-account-store.h:
3975 * src/modest-tny-account-store.c:
3976 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3977 the connection-specific SMTP server settings in the configuration.
3979 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3981 * src/maemo/modest-main-window.c: (on_connection_changed),
3983 * src/modest-main.c: (main), (start_ui), (send_mail):
3984 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3985 that is what is intended.
3987 * src/modest-ui-actions.c: (action_send), (action_receive),
3988 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3989 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3990 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3991 SMTP server is used when it is specified.
3993 (modest_ui_actions_on_send_receive):
3994 Check that a connection is open before proceeding.
3995 Receive and then send, instead of vice-versa, as per the specification.
3997 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3999 * src/modest-mail-operation.c:
4000 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
4001 though I guess it should be something other than NULL.
4003 2007-04-26 Murray Cumming <murrayc@murrayc.com>
4005 * src/maemo/easysetup/modest-easysetup-wizard.c:
4006 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
4007 combo twice, to avoid an g_warning and to make it visible again.
4008 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
4009 attached before detaching it, to avoid a g_warning, and add comment about the implicit
4010 (already intended) dereference when detaching, because we then recreate the menu.
4011 But I am not sure why the warning was happening, and it is possible that this is a memory
4014 2007-04-25 Murray Cumming <murrayc@murrayc.com>
4016 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
4017 and uri_parse_mailto() utility functions.
4018 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
4020 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
4022 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4024 * src/dbus_api/modest-dbus-api.h:
4025 * src/dbus_api/modest-dbus-callbacks.c:
4026 Use an idle callback to execute the modest code in the application's own thread.
4027 Remove the helloworld example method.
4028 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
4029 parsed, and the open-message method is not implemented because this is not yet implemented in
4031 * libmodest-dbus-client/libmodest-dbus-client.c:
4032 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
4033 (libmodest_dbus_client_open_message):
4034 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
4036 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
4037 body without crashing.
4039 * tests/dbus_api/Makefile.am:
4040 * tests/dbus_api/test_mail_to.c:
4041 * tests/dbus_api/test_open_message.c: New tests for the new methods.
4043 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4045 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
4046 Added file to fix the build. Sorry.
4048 * src/dbus_api/Makefile.am:
4049 * src/dbus_api/modest-dbus-api.h:
4050 * src/dbus_api/modest-dbus-callbacks.h:
4051 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
4052 (modest_dbus_req_handler):
4053 Put constants in a separate header so it can be reused by the
4054 client library, without duplication
4056 * libmodest-dbus-client/Makefile.am:
4057 * libmodest-dbus-client/libmodest-dbus-client.c:
4058 (libmodest_dbus_client_call_helloworld),
4059 (libmodfest_dbus_client_send_mail),
4060 (libmodfest_dbus_client_mailto),
4061 (libmodfest_dbus_client_open_message):
4062 * libmodest-dbus-client/libmodest-dbus-client.h:
4063 (Partly) Implement a send_mail D-Bus method.
4065 * tests/dbus_api/Makefile.am:
4066 * tests/dbus_api/test_send_mail.c: (main): Added a test for
4067 the send_email D-Bus method.
4069 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4073 * libmodest-dbus-client/Makefile.am:
4074 * libmodest-dbus-client/libmodest-dbus-client.c:
4075 * libmodest-dbus-client/libmodest-dbus-client.h:
4076 * tests/dbus_api/Makefile.am:
4077 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
4078 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
4080 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4082 * src/maemo/easysetup/modest-easysetup-wizard.c:
4083 (create_page_account_details):
4084 * src/maemo/modest-account-settings-dialog.c:
4085 (create_page_account_details): Explicitly set auto-capitalization mode for the title
4086 widgets, because this might not be the default in future versions of the Maemo GTK+.
4087 However, I can not not get capitalization to work even in a simple test case.
4089 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4091 * src/maemo/easysetup/modest-easysetup-wizard.c:
4092 (create_page_custom_incoming), (create_page_custom_outgoing):
4093 * src/maemo/modest-account-settings-dialog.c:
4094 (create_page_account_details), (create_page_incoming),
4095 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
4096 instead of using gtk_check_button_with_label(), so they are aligned like the other
4097 widgets, as per the UI spec.
4099 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4101 * src/maemo/easysetup/modest-easysetup-wizard.c:
4102 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4103 * src/widgets/modest-validating-entry.c:
4104 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
4105 Modest prefix instead of an EasySetup prefix.
4107 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4109 * src/widgets/modest-validating-entry.h:
4110 * src/widgets/modest-validating-entry.c: (on_insert_text),
4111 Added easysetup_validating_entry_set_max_func(), used to set a callback
4112 to call when the max number of characters is reached. GtkEntry has a max-length
4113 already but is silent about it.
4115 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
4116 (create_page_account_details), (create_page_user_details),
4118 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
4119 (create_page_account_details), (create_page_user_details),
4120 (create_page_outgoing):
4121 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
4122 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
4123 the UI spec, when the user tries to enter more than the max number of characters.
4125 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4127 * src/maemo/easysetup/modest-easysetup-wizard.c:
4128 (create_page_user_details), (create_page_custom_incoming),
4129 (create_page_custom_outgoing):
4130 * src/maemo/modest-account-settings-dialog.c:
4131 (create_page_user_details), (create_page_incoming),
4132 (create_page_outgoing):
4133 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4134 (modest_connection_specific_smtp_edit_window_init):
4135 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
4136 not appropriate. Bad Maemo-specific defaults!.
4138 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4140 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
4141 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
4142 (modest_signature_editor_dialog_set_settings):
4143 Disable the label and textview when the checkbox is disabled, and use the
4144 specified (UI spec) default signature text.
4146 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4148 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4149 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
4151 * src/modest-defs.h:
4152 * src/modest-account-mgr-helpers.h:
4153 * src/modest-account-mgr-helpers.c:
4154 Added modest_account_mgr_get/set_signature(), using new gconf keys.
4156 * src/maemo/Makefile.am:
4157 * src/maemo/modest-signature-editor-dialog.c:
4158 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
4161 * src/maemo/modest-account-settings-dialog.h:
4162 * src/maemo/modest-account-settings-dialog.c:
4163 (modest_account_settings_dialog_finalize), (on_button_signature),
4164 (save_configuration): Use the new dialog when the Edit button is pressed, and
4165 save the changes if necessary, as per the UI spec.
4167 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4169 * src/maemo/Makefile.am:
4170 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
4171 based on maemo-develoers email from Dirk.
4173 * src/maemo/easysetup/modest-easysetup-wizard.c:
4174 (create_page_welcome), (create_page_account_details),
4175 (create_page_user_details), (create_page_complete_easysetup),
4176 (create_page_custom_incoming), (create_page_custom_outgoing),
4177 (create_page_complete_custom),
4178 (modest_easysetup_wizard_dialog_init):
4179 * src/maemo/modest-account-settings-dialog.c:
4180 (create_page_account_details), (create_page_user_details),
4181 (create_page_incoming), (create_page_outgoing),
4182 (modest_account_settings_dialog_init):
4183 * src/maemo/modest-connection-specific-smtp-window.c:
4184 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
4186 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4188 * src/maemo/easysetup/modest-easysetup-wizard.c:
4189 (create_page_account_details), (create_page_custom_outgoing),
4190 (create_page_complete_custom):
4191 * src/maemo/modest-account-settings-dialog.c:
4192 (create_page_user_details), (create_page_incoming),
4193 (create_page_outgoing):
4194 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4195 (modest_connection_specific_smtp_edit_window_init):
4196 Use the correct (UI spec) port min/max, and use horizontal separators,
4199 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4201 * src/maemo/easysetup/modest-easysetup-wizard.c:
4202 (set_default_custom_servernames):
4203 * src/maemo/modest-account-settings-dialog.c:
4204 (create_page_incoming), (on_combo_outgoing_security_changed),
4205 (on_combo_incoming_security_changed), (create_page_outgoing),
4206 (modest_account_settings_dialog_set_account_name),
4207 (save_configuration):
4208 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4209 (on_combo_security_changed),
4210 (modest_connection_specific_smtp_edit_window_init),
4211 (modest_connection_specific_smtp_edit_window_set_connection),
4212 (modest_connection_specific_smtp_edit_window_get_settings):
4213 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
4216 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4219 * src/maemo/easysetup/modest-easysetup-wizard.c:
4220 (create_page_custom_outgoing), (create_page_complete_custom):
4221 * src/maemo/modest-account-settings-dialog.c:
4222 (create_page_user_details), (create_page_outgoing):
4223 * src/maemo/modest-account-view-window.c: (button_box_new):
4224 Use changed logical IDs as per the most recent UI spec:
4225 mcen_bd_emailsetup_edit -> mcen_bd_edit
4226 mcen_bd_emailsetup_delete -> mcen_bd_delete
4227 mcen_bd_emailsetup_close -> mcen_bd_close
4229 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4233 * src/dbus_api/Makefile.am:
4234 * src/dbus_api/modest-dbus-callbacks.c:
4235 * src/dbus_api/modest-dbus-callbacks.h:
4236 * src/maemo/modest-platform.c: (modest_platform_init):
4237 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
4239 * tests/Makefile.am:
4240 * tests/dbus_api/Makefile.am:
4241 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
4243 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4245 * src/maemo/modest-account-settings-dialog.c:
4246 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4247 Removed unnecessary includes.
4249 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4251 * src/maemo/easysetup/modest-easysetup-wizard.c:
4252 * src/maemo/modest-account-settings-dialog.c:
4253 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4254 * src/widgets/Makefile.am:
4255 * src/widgets/modest-easysetup-secureauth-combo-box.c:
4256 * src/widgets/modest-easysetup-secureauth-combo-box.h:
4257 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
4258 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
4259 * src/widgets/modest-secureauth-combo-box.c:
4260 * src/widgets/modest-secureauth-combo-box.h:
4261 * src/widgets/modest-serversecurity-combo-box.c:
4262 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
4263 made the GObject names more consistent with the rest of the Modest code.
4265 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4267 * src/maemo/easysetup/Makefile.am:
4268 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4269 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
4270 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4271 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4272 * src/maemo/easysetup/modest-easysetup-wizard.c:
4273 * src/maemo/easysetup/modest-validating-entry.c:
4274 * src/maemo/easysetup/modest-validating-entry.h:
4275 * src/maemo/modest-account-settings-dialog.c:
4276 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4277 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
4278 widgets/ because they are used outside of easysetup too. After checking in,
4279 svn will allow me to rename them too.
4281 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4283 * src/gnome/modest-msg-edit-window.c:
4284 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
4285 linker error, to fix the build on the GNOME platform.
4286 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
4287 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
4288 ifdefed out to avoid a warning.
4290 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4292 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
4293 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
4294 some alternative for GTK+ 2.6.
4296 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4298 * src/maemo/modest-address-book.c: Added include to avoid a warning.
4300 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
4301 specified for EmailAccountsDialog in UI spec.
4303 * src/maemo/easysetup/modest-easysetup-wizard.c:
4304 * src/maemo/easysetup/modest-easysetup-wizard.h:
4305 * src/maemo/modest-account-settings-dialog.c:
4306 * src/maemo/modest-account-settings-dialog.h:
4307 Reuse a member window widget for the connection-specific SMTP server accounts,
4308 so we can tell it to create/save the accounts only if we actually save changes.
4310 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4311 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4312 (modest_connection_specific_smtp_edit_window_get_settings):
4313 Return a struct instance for temporarily remembering the entered data.
4315 * src/maemo/modest-connection-specific-smtp-window.h:
4316 * src/maemo/modest-connection-specific-smtp-window.c:
4317 (modest_connection_specific_smtp_window_finalize),
4318 (modest_connection_specific_smtp_window_fill_with_connections),
4320 (modest_connection_specific_smtp_window_save_server_accounts),
4321 (update_model_server_names): Do not actually save data until asked,
4322 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
4324 (on_selection_changed),
4325 (modest_connection_specific_smtp_window_init): Disable the edit
4326 button when nothing is selected.
4328 * src/modest-account-mgr-helpers.c:
4329 * src/modest-account-mgr-helpers.h:
4330 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
4333 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4335 * src/modest-account-mgr-helpers.h:
4336 * src/modest-account-mgr-helpers.c:
4337 (modest_account_mgr_get_unused_account_name),
4338 (modest_account_mgr_get_unused_account_display_name): Added these
4339 utility functions, to avoid code duplication.
4341 * src/maemo/easysetup/modest-easysetup-wizard.c:
4342 (create_page_account_details), (create_account):
4343 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4344 (on_combo_security_changed),
4345 (modest_connection_specific_smtp_edit_window_init),
4346 (modest_connection_specific_smtp_edit_window_save_settings):
4347 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4348 * src/maemo/modest-connection-specific-smtp-window.c:
4349 (modest_connection_specific_smtp_window_finalize),
4350 (modest_connection_specific_smtp_window_fill_with_connections),
4351 (on_button_edit), (modest_connection_specific_smtp_window_init):
4352 * src/maemo/modest-connection-specific-smtp-window.h:
4353 Implementing saving of connection-specific server accounts.
4355 But I need to refactor this so we can save the data for each
4356 possible connection-specific account and only actually create the server accounts
4357 when the easysetup finished, or the OK button is pressed on the account settings
4360 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4362 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4363 (on_combo_security_changed):
4364 (modest_connection_specific_smtp_edit_window_init):
4365 Auto-fill the port number as in the account settings.
4367 (modest_connection_specific_smtp_edit_window_set_connection):
4368 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4369 * src/maemo/modest-connection-specific-smtp-window.c:
4370 (fill_with_connections), (on_button_edit),
4371 (modest_connection_specific_smtp_window_init):
4372 Turn the edit window into a dialog to simplify the code, and
4373 set a WM hint as in a GtkDialog, because only a popup can be on top of
4374 another window in Maemo, and popups usually have no WM decoration.
4376 * src/modest-defs.h:
4377 * src/modest-account-mgr-helpers.c:
4378 (modest_account_mgr_set_connection_specific_smtp),
4379 (modest_account_mgr_remove_connection_specific_smtp),
4380 (modest_account_mgr_get_connection_specific_smtp):
4381 * src/modest-account-mgr-helpers.h: Some functions to write the
4382 connection-specific SMTP server information. Not yet used.
4385 * src/widgets/modest-folder-view.c: (text_cell_data):
4386 Fix a warning about an uninitialized variable.
4387 (on_configuration_key_changed): Put an #ifdef around the use
4388 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
4390 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4392 * src/maemo/modest-account-settings-dialog.h:
4393 * src/maemo/modest-account-settings-dialog.c:
4394 Added connect_for_modified() utility function to mark the new modified boolean.
4396 (create_page_account_details), (create_page_user_details),
4397 (create_page_incoming), (create_page_outgoing), (on_response),
4398 (modest_account_settings_dialog_init),
4399 (modest_account_settings_dialog_set_account_name):
4400 Only warn about unsaved changes when there are actually unsaved changes.
4402 * src/modest-account-mgr-helpers.c:
4403 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
4404 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
4405 to get the data from there in future.
4407 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4409 * src/modest-defs.h:
4411 * src/modest-account-mgr-helpers.h:
4412 * src/modest-account-mgr-helpers.c:
4413 Store the security account setting in a single conf key instead of using
4414 the options list, so that the list is left for just the to-be-removed camel hack,
4415 and because gconf_client_set_list() is failing for some reason.
4417 * src/modest-account-mgr.c:
4418 (modest_account_mgr_add_server_account):
4419 * src/maemo/modest-account-settings-dialog.c:
4420 (modest_account_settings_dialog_set_account_name),
4421 (save_configuration): Use the renamed functions.
4424 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4426 * src/widgets/Makefile.am:
4427 * src/widgets/modest-limit-retrieve-combo-box.c:
4428 * src/widgets/modest-limit-retrieve-combo-box.h:
4429 * src/widgets/modest-retrieve-combo-box.c:
4430 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4431 the account settings dialog.
4433 * src/modest-defs.h:
4434 * src/modest-account-mgr-helpers.h:
4435 * src/modest-account-mgr-helpers.c:
4436 (modest_server_account_get_option_secure_auth),
4437 (modest_server_account_set_option_secure_auth):
4438 * src/modest-account-mgr.c:
4439 (modest_account_mgr_add_server_account):
4440 Use the existing AUTH_MECH conf key for the secure-auth setting,
4441 instead of putting it in the list options, because this was actually used already.
4443 * src/maemo/modest-account-settings-dialog.c:
4444 (create_page_account_details),
4445 (modest_account_settings_dialog_set_account_name),
4446 (save_configuration):
4447 * src/maemo/modest-account-settings-dialog.h:
4448 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4449 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4451 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4453 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4454 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4455 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4457 * src/modest-defs.h:
4458 * src/maemo/modest-account-settings-dialog.c:
4459 (create_page_incoming), (on_combo_outgoing_security_changed),
4460 (on_combo_incoming_security_changed), (create_page_outgoing),
4461 (modest_account_settings_dialog_set_account_name),
4462 (save_configuration): Load/Save the port number, and change it when the
4463 security combo changes, to suitable defaults.
4465 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4467 * src/modest-account-mgr.c:
4468 (modest_account_mgr_add_server_account): Set the security and secure-auth
4469 options, and add a comment saying that the other camel-specific options should be
4472 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4474 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4476 * src/modest-tny-account-store.c: (account_list_free),
4477 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4478 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4481 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4483 * src/modest-protocol-info.c:
4484 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4485 is required by our UI spec. Maybe something in our implementation will use this eventually.
4486 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4487 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4488 instead of the previous 0 placeholder.
4490 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4491 secure-auth settings.
4492 * src/modest-account-mgr-helpers.h:
4493 * src/modest-account-mgr-helpers.c:
4494 (modest_server_account_data_get_option_secure_auth),
4495 (modest_server_account_set_option_secure_auth),
4496 (modest_server_account_data_get_option_security),
4497 (modest_server_account_set_option_security): Added this API for getting and setting the security
4498 and secure-auth settings.
4500 * src/maemo/modest-account-settings-dialog.h:
4501 * src/maemo/modest-account-settings-dialog.c:
4502 (modest_account_settings_dialog_finalize), (check_data),
4503 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4504 about changing titles.
4505 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4506 (save_configuration): Save the security and secure-auth settings.
4508 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4509 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4511 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4513 * src/modest-defs.h:
4514 * src/modest-account-mgr.c:
4515 (modest_account_mgr_add_server_account):
4516 Added and used defines for the options key and value pair strings,
4517 that are used so far, though they do not seem to correspond to anything in our
4518 UI specs or ModestProtocol enum.
4520 * src/modest-account-mgr-helpers.h:
4521 * src/modest-account-mgr-helpers.c:
4522 (compare_option_strings_for_name),
4523 (modest_server_account_data_get_option_value),
4524 (modest_server_account_data_get_option_bool),
4525 (modest_account_mgr_get_server_account_option):
4526 Added helper functions for parsing the options GSList.
4528 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4530 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4531 display name is based on the supplied account name.
4532 * src/modest-account-mgr.c:
4533 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4534 with an inefficient, but good-enough, implementation.
4536 * src/maemo/easysetup/modest-easysetup-wizard.c:
4537 (create_page_account_details), (on_before_next), (create_account):
4538 Check for existing display names rather than (non-user-visible) account names, and just
4539 create and set a unique account name at the end.
4541 * src/maemo/modest-account-settings-dialog.c:
4542 (modest_account_settings_dialog_init),
4543 (modest_account_settings_dialog_set_account_name),
4544 (create_page_incoming): Show the display name, instead of the account name.
4545 (on_response): Do some (not all) extra checks, as in the UI spec.
4546 (save_configuration): Save the display name if it was changed.
4548 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4550 * po/en_GB.po: Added needed logical ID and translation.
4551 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4552 (init_view): Made the is-default column clicking work.
4554 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4557 * src/maemo/easysetup/Makefile.am:
4558 * src/maemo/easysetup/modest-easysetup-wizard.c:
4559 (modest_easysetup_wizard_dialog_init):
4560 * src/maemo/easysetup/provider-data-test.keyfile:
4561 * src/maemo/easysetup/provider-data.keyfile:
4562 Moved the provider data file to the new modest-providers-data package and used it from there.
4564 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4566 * src/modest-local-folder-info.c:
4567 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4568 N_() was already used on the static strings, but this just marks it for translation without
4569 using the translation.
4571 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4573 * src/maemo/modest-account-settings-dialog.c:
4574 (create_page_incoming),
4575 (modest_account_settings_dialog_set_account_name):
4576 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4577 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4578 I will do this if nobody else gets there first.
4580 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4582 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4583 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4584 save the security stuff.
4586 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4588 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4589 Set the email address and user fullname, which I now see must be
4592 * src/maemo/modest-account-settings-dialog.h:
4593 * src/maemo/modest-account-settings-dialog.c:
4595 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4596 leave-on-server and authentication.
4597 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4600 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4603 * src/maemo/modest-account-settings-dialog.c:
4604 * src/maemo/modest-account-settings-dialog.h:
4605 Most (but not all) of the widgets are now present as specified by the UI spec.
4606 No changes are yet saved, and some details are not properly shown yet.
4608 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4610 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4612 * src/maemo/Makefile.am:
4613 * src/maemo/modest-account-settings-dialog.c:
4614 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4615 an existing account. Doesn't do much yet.
4617 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4618 Open the accounts settings dialog when Edit is clicked.
4620 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4622 * src/maemo/easysetup/Makefile.am:
4623 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4625 * src/maemo/easysetup/modest-easysetup-wizard.c:
4626 (modest_easysetup_wizard_dialog_init):
4627 Try to get the source directory from the build system,
4628 instead of hard-coding "./" into the source code, when opening our local
4629 copies of the configuration files.
4630 But this still fails when opening the wizard from the Accounts window,
4631 maybe because the working directory seems to change at runtime.
4632 So the wizard will fail the second time unless you copy the files into their
4633 proper locations - see the stdout warnings for the paths.
4635 (create_page_account_details),(on_before_next):
4636 Check for existing non-server accounts instead of server accounts,
4637 so the default account name is useful again, and to prevent trying to
4640 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4641 Show the wizard when New is clicked.
4643 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4644 (init_view): Show the column headers, and show the columns that are
4645 specified in the UI specs. However, something in Maemo's GTK+ prevents
4646 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4647 change the default account. This is despite unsetting the special properties.
4649 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4651 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4652 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4653 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4654 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4655 to make that clearer.
4656 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4658 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4660 * src/maemo/modest-account-view-window.c:
4661 (modest_account_view_window_init),
4662 (modest_account_view_window_new):
4663 Use the same buttons as specified in the
4664 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4665 the existing widgets, which never had a chance of working.
4666 Put the ModestAccountView treeview in a scrolled window.
4667 Do not repeat the initialization in both _init() and _new().
4669 * src/widgets/modest-account-view.c: (update_account_view):
4670 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4671 this widget and window shows no accounts.
4673 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4675 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4677 * src/maemo/easysetup/modest-easysetup-wizard.c:
4678 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4679 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4680 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4683 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4684 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4685 accounts exist yet, as in the UI spec.
4687 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4689 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4691 * src/maemo/Makefile.am:
4692 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4693 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4694 New window for editing connection-specific smtp details.
4695 Not fully implemented.
4697 * src/maemo/modest-connection-specific-smtp-window.c:
4698 (modest_connection_specific_smtp_window_finalize) :
4699 unref the tree model.
4700 (on_button_edit): Show the edit window.
4702 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4704 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4707 * src/maemo/Makefile.am:
4708 * src/maemo/modest-connection-specific-smtp-window.c:
4709 * src/maemo/modest-connection-specific-smtp-window.h:
4710 New window for showing the list of connections, for connection-specific
4711 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4712 * src/maemo/easysetup/modest-easysetup-wizard.c:
4713 (create_page_custom_outgoing): Show the new window when the button is clicked.
4715 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4717 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4718 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4719 * src/maemo/modest-msg-edit-window.c:
4720 (modest_msg_edit_window_insert_image):
4721 * src/modest-conf.c: (modest_conf_key_escape):
4722 * src/modest-mail-operation.c:
4723 (modest_mail_operation_send_new_mail):
4724 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4725 (modest_ui_actions_on_new_account):
4726 * src/widgets/modest-attachment-view.c: (update_filename_request):
4727 * src/widgets/modest-mail-header-view.c:
4728 Corrected warnings that were breaking the build, by commenting out unused variables,
4729 and a function, and by including a header.
4731 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4733 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4734 so we can #ifdef around platform-specific code when necessary.
4735 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4736 to allow this to build for the GNOME platform too.
4738 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4740 * src/maemo/easysetup/modest-easysetup-wizard.c:
4741 Added util_increment_name() and used it in create_page_account_details()
4742 to make sure that the default account name is always a new name.
4744 (modest_easysetup_wizard_dialog_init),
4745 (set_default_custom_servernames): Some minor memory management fixes.
4747 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4751 * src/modest-runtime.c: (init_i18n): Restored the translation
4752 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4753 are defined in config.h, and the translations are installed.
4755 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4756 is defined for translation.
4758 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4760 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4762 * src/maemo/easysetup/modest-easysetup-wizard.c:
4763 (modest_easysetup_wizard_dialog_init):
4764 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4765 Use realistic paths (though they should use $prefix generically) to the
4766 mcc_mapping and provider-data.keyfile files which might work when they
4767 are installed by the future version of the operator-wizard package,
4768 and then fallback to paths in our source code, with an explanatory
4771 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4775 * src/maemo/Makefile.am:
4776 * src/maemo/easysetup/: Added files from the previously-exernal
4777 osso-modest-easysetup.
4778 * src/maemo/modest-main-window-ui.h:
4779 * src/modest-ui-actions.c:
4780 * src/modest-ui-actions.h:
4781 Added modest_ui_actions_on_new_account() as a signal handler for the
4782 New Account menu item. It shows the easysetup wizard.
4783 * po/en_GB.po: Added additional needed logical IDs and translations.