1 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
4 * src/modest-mail-operation-queue.c:
5 (modest_mail_operation_queue_remove):
6 * src/modest-tny-account-store.c: When GErrors happen, give more clues
7 about where they happened.
9 2007-05-21 Murray Cumming <murrayc@murrayc.com>
11 * src/modest-ui-actions.c:
12 (modest_ui_actions_on_password_requested): Make sure that the remember
13 output parameter is always TRUE.
15 2007-05-21 Murray Cumming <murrayc@murrayc.com>
17 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
18 Show a OK/Cancel dialog if the error is a question, though we still do not
19 know anything more about what we are asking the user.
20 * src/widgets/modest-folder-view.c: (on_drag_data_received):
21 Fix an uninitialized variable (helper). This is a logic error, however.
23 2007-05-21 Christian Kellner <ckellner@openismus.com>
25 * src/modest-search.h:
26 Correct bit shifting in the ModestSearchFlags enum.
28 2007-05-21 Murray Cumming <murrayc@murrayc.com>
30 * src/modest-tny-account.c:
31 (modest_tny_account_new_from_server_account): Do not use the lsub and
32 check-all hard-coded IMAP options when using POP.
34 2007-05-21 Murray Cumming <murrayc@murrayc.com>
36 * src/modest-tny-account.c:
37 (modest_tny_account_new_from_server_account):
38 Use NULL for the secure-auth method for POP when Password auth has been
39 specified by the user, as we already do for IMAP. "auth=Login" causes
40 an error from camel or the server.
42 2007-05-17 Murray Cumming <murrayc@murrayc.com>
44 * src/maemo/modest-account-settings-dialog.c:
45 (create_page_account_details),
46 (modest_account_settings_dialog_set_account_name):
47 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
48 for the leave-on-server checkbox, rathr than just the checkbox, when
49 the protocol is not POP.
51 2007-05-17 Murray Cumming <murrayc@murrayc.com>
53 * src/widgets/modest-account-view.c:
54 * src/widgets/modest-account-view.h:
55 Added modest_account_view_select_account() which will be useful later
56 to asynchronously re-select the edited account.
58 2007-05-17 Murray Cumming <murrayc@murrayc.com>
60 * src/maemo/modest-account-settings-dialog.c:
61 (modest_account_settings_dialog_set_account_name):
62 Automatically choose the port numbers based on the secure authentication
63 methods, if they have not been chosen before.
64 This fixes projects.maemo.org bug NB#56273 .
66 2007-05-17 Murray Cumming <murrayc@murrayc.com>
68 * src/maemo/modest-main-window-ui.h:
69 * src/modest-ui-actions.c:
70 * src/modest-ui-actions.h:
71 Connect the Tools/SMTP Servers menu item to
72 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
73 SMTP servers dialog, as in the UI specification and saves changes when it
74 is closed. This fixed projects.maemo.org bug NB#56305 .
76 2007-05-17 Murray Cumming <murrayc@murrayc.com>
78 * src/maemo/modest-connection-specific-smtp-window.c:
79 (modest_connection_specific_smtp_window_init):
80 Use gtk_window_set_default_size() to make this window big enough, so
81 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
83 2007-05-17 Murray Cumming <murrayc@murrayc.com>
85 * src/maemo/modest-connection-specific-smtp-edit-window.h:
86 * src/maemo/modest-connection-specific-smtp-edit-window.c:
87 (modest_connection_specific_smtp_edit_window_init),
88 Do not try to connect to a combobox signal before the combobox exists.
89 This fixes the cras in projects.maemo.org bug NB#56288 .
90 (modest_connection_specific_smtp_edit_window_get_settings):
91 Remove the server_account_name parameter which was being checked for NULL
92 though it was not used.
94 * src/maemo/modest-connection-specific-smtp-window.c:
95 (modest_connection_specific_smtp_window_fill_with_connections),
96 (on_button_edit), (modest_connection_specific_smtp_window_init):
97 Correct the number of treemodel columns to prevent a warning.
98 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
99 libconic does not work.
101 2007-05-16 Murray Cumming <murrayc@murrayc.com>
103 * src/modest-tny-account.c:
104 (modest_tny_account_new_from_server_account):
105 Excplicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
106 SMTP when "None" was chosen by the user. However, with my SMTP server that
107 does not support ANONYMOUS, the emails do not leave the Outbox and I see
110 2007-05-16 Murray Cumming <murrayc@murrayc.com>
112 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
113 to explain the memory management issue with the ID in the ModestPair.
115 * src/gnome/modest-account-assistant.c: (add_receiving_page),
116 (add_sending_page), (modest_account_assistant_finalize):
117 * src/gnome/modest-gnome-global-settings-dialog.c:
118 (create_updating_page), (create_composing_page):
119 * src/gnome/modest-msg-edit-window.c: (get_transports),
120 (init_window), (modest_msg_edit_window_finalize),
121 (modest_msg_edit_window_get_msg_data):
122 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
123 * src/gnome/modest-transport-widget.c:
124 (modest_transport_widget_finalize), (smtp_configuration):
125 * src/maemo/modest-maemo-global-settings-dialog.c:
126 (create_updating_page), (create_composing_page):
127 * src/maemo/modest-msg-edit-window.c: (get_transports),
128 (init_window), (modest_msg_edit_window_finalize),
129 (modest_msg_edit_window_get_msg_data),
130 (modest_msg_edit_window_free_msg_data):
131 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
132 (modest_store_widget_finalize):
133 * src/maemo/modest-transport-widget.c:
134 (modest_transport_widget_finalize), (smtp_configuration):
135 * src/modest-main.c: (send_mail):
136 * src/widgets/modest-combo-box.h:
137 * src/widgets/modest-global-settings-dialog-priv.h:
138 * src/widgets/modest-global-settings-dialog.c:
139 (modest_global_settings_dialog_finalize):
140 * src/widgets/modest-msg-edit-window.h:
141 Whenever using modest_combo_box_new(), keep the ModestPairList alive
142 as long as the combo box, to prevent use of freed memory for the ID.
144 2007-05-15 Murray Cumming <murrayc@murrayc.com>
146 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
147 get_accounts(), to make this clearer. Do not check for the enabled gconf
148 key, because we do not use this for server accounts (at least, not yet).
149 This allows us to send email again.
151 2007-05-15 Murray Cumming <murrayc@murrayc.com>
153 * src/maemo/modest-platform.c:
154 (on_modest_conf_update_interval_changed), (modest_platform_init):
155 Only respond to this particular key change. All these strcmp()s cannot be
158 2007-05-15 Murray Cumming <murrayc@murrayc.com>
160 * src/maemo/modest-maemo-global-settings-dialog.c:
161 (current_connection): Prevent a crash in scratchbox when
162 ny_maemo_conic_device_get_current_iap_id() returns NULL.
163 * src/maemo/modest-platform.c:
164 (on_modest_conf_update_interval_changed), (modest_platform_init):
165 Get the update interval from gconf and reset it when the gconf key changes.
167 2007-05-15 Murray Cumming <murrayc@murrayc.com>
169 * src/modest-protocol-info.c:
170 * src/modest-protocol-info.h: Adde enum-specific get functions,
171 instead of using a ModestProtocolType enum parameter.
173 * src/gnome/modest-account-assistant.c:
174 * src/gnome/modest-store-widget.c:
175 * src/gnome/modest-store-widget.h:
176 * src/gnome/modest-transport-widget.c:
177 * src/gnome/modest-transport-widget.h:
178 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
179 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
180 * src/maemo/easysetup/modest-easysetup-wizard.c:
181 * src/maemo/modest-account-settings-dialog.c:
182 * src/maemo/modest-account-settings-dialog.h:
183 * src/maemo/modest-store-widget.c:
184 * src/maemo/modest-store-widget.h:
185 * src/maemo/modest-transport-widget.c:
186 * src/maemo/modest-transport-widget.h:
187 * src/modest-account-mgr-helpers.c:
188 * src/modest-account-mgr-helpers.h:
189 * src/modest-account-mgr.c:
190 * src/modest-account-mgr.h:
191 * src/modest-tny-account.c:
192 * src/modest-tny-folder.c:
193 * src/widgets/modest-account-view.c:
194 * src/widgets/modest-retrieve-combo-box.c:
195 * src/widgets/modest-retrieve-combo-box.h:
196 * src/widgets/modest-secureauth-combo-box.c:
197 * src/widgets/modest-serversecurity-combo-box.c:
198 * src/widgets/modest-serversecurity-combo-box.h:
199 * tests/check_account-mgr.c:
200 Use the specific functions, and use the re-renamed enum values for GNOME too.
202 2007-05-15 Murray Cumming <murrayc@murrayc.com>
205 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
206 so we can get the second based on the first.
208 * src/maemo/modest-account-settings-dialog.h:
209 * src/maemo/modest-account-settings-dialog.c:
210 Added get_supported_secure_authentication_methods(), though it is mostly
211 commented-out for now until the necessary API is committed to tinymail.
212 (modest_account_settings_dialog_set_account_name),
213 (save_configuration): Request the supported authentication methods from the
214 server, so we can choose a working method.
216 * src/modest-tny-account-store.h:
217 * src/modest-tny-account-store.c:
218 (modest_tny_account_store_get_session): Rename from
219 tny_account_store_get_session().
221 2007-05-14 Murray Cumming <murrayc@murrayc.com>
223 * src/modest-protocol-info.h: Split the ModestProtocol enum
224 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
225 There was no need to have these unrelated values in one enum.
227 * src/: many files: Adapted to changed enum. This makes the code a bit
228 clearer, and the compiler could catch some errors.
230 2007-05-14 Murray Cumming <murrayc@murrayc.com>
232 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
233 Show the detailed internal camel error message when an error happens
234 during the configuration, so that our testers can give us more clues.
235 For instance, in projects.maemo.org bug NB#56910 .
237 2007-05-14 Murray Cumming <murrayc@murrayc.com>
239 * src/modest-tny-account.c:
240 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
241 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
243 2007-05-14 Murray Cumming <murrayc@murrayc.com>
245 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
246 * src/maemo/modest-account-settings-dialog.c:
247 (modest_account_settings_dialog_set_account_name),
248 (save_configuration): For the incoming secure authentication checkbox,
249 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
250 the UI specification. PLAIN does not seem to be supported for most IMAP
251 servers anyway, and I am not sure what it would mean.
252 However, we probably need to discover which of the secure-authentication
253 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
254 * src/modest-account-mgr-helpers.c:
255 (modest_account_mgr_get_server_account_data):
257 * src/modest-tny-account.c:
258 (modest_tny_account_new_from_server_account):
259 Use tny_account_set_mech() to set secure-authentication methods,
260 with some special-casing for IMAP, based on my observations of how
263 * src/modest-account-mgr-helpers.h:
264 * src/modest-account-mgr.c:
265 * src/modest-defs.h: Comment that the URI is only used for local folders.
267 2007-05-11 Murray Cumming <murrayc@murrayc.com>
269 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
270 parameter const, just to be neat.
271 * src/modest-text-utils.c: (modest_text_utils_inline):
272 End g_strconcat() with NULL, as its documentation says. This is almost
273 certainly the cause of my crash at startup on the device. Interestingly,
274 valgrind doesn't tell us about these errors.
276 2007-05-11 Murray Cumming <murrayc@murrayc.com>
278 * scripts/build-packages: Added more precise comments about how to use
279 this script, though I still get this error:
280 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
281 error building tinymail
283 2007-05-11 Murray Cumming <murrayc@murrayc.com>
285 * src/maemo/modest-main-window.c: (on_account_update):
286 Very slight cleanup, hoping to make it simpler to discover what causes
287 a crash here sometimes.
289 * src/modest-tny-account.c:
290 (modest_tny_account_new_from_server_account): Set the port. Added
291 comments about the options and a TODO comment because I need to find out
292 how to specify the secure authentication method.
294 2007-05-11 Marcus Bauer <marcusb@openismus.com>
296 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
297 changed CFlags paths form modest to libmodest
299 2007-05-10 Murray Cumming <murrayc@murrayc.com>
301 * src/modest-account-mgr-helpers.c:
302 (modest_account_mgr_get_server_account_data),
303 (modest_account_mgr_free_server_account_data):
304 * src/modest-account-mgr-helpers.h:
305 * src/modest-account-mgr.c:
306 (modest_account_mgr_add_server_account):
308 * src/modest-tny-account.c:
309 (modest_tny_account_new_from_server_account):
310 Determine the options for tny_camel_account_add_option() here,
311 based on the settings, rather than storing them directly in gconf.
313 2007-05-10 Murray Cumming <murrayc@murrayc.com>
315 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
316 Show a more friendly error dialog now that we expect (from the tinymail
317 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
319 2007-05-10 Murray Cumming <murrayc@murrayc.com>
321 * src/maemo/modest-main-window.c: (on_account_update): Check that
322 account_name is not NULL, to prevent a crash at startup that I am
323 seeing on the N800. I do wonder why it is NULL.
325 * src/maemo/easysetup/modest-easysetup-wizard.c:
326 (create_page_user_details):
327 * src/maemo/modest-account-settings-dialog.c:
328 (create_page_user_details), (create_page_outgoing):
329 * src/maemo/modest-connection-specific-smtp-edit-window.c:
330 (modest_connection_specific_smtp_edit_window_init):
331 * src/modest-ui-actions.c:
332 (modest_ui_actions_on_password_requested):
333 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
334 might do something useful with the on-screen keyboard.
336 2007-05-10 Murray Cumming <murrayc@murrayc.com>
338 * src/maemo/modest-main-window.c: (on_account_update):
339 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
340 NULL, to avoid lots of warnings. However, it probably should not be NULL.
342 2007-05-09 Murray Cumming <murrayc@murrayc.com>
344 * src/modest-tny-account-store.c: (on_account_changed):
345 Correct the signature of this signal handler.
347 2007-05-09 Murray Cumming <murrayc@murrayc.com>
349 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
350 Show a HildonNote instead of a GtkDialog for Maemo.
352 2007-05-09 Murray Cumming <murrayc@murrayc.com>
354 * src/widgets/modest-account-view.h:
355 * src/widgets/modest-account-view.c: (on_account_changed),
356 (on_account_removed). Added a boolean flag, set/unset by
357 modest_account_view_block_conf_updates(),
358 modest_account_view_unblock_conf_updates() to prevent unnecessary
359 updates, but this is not very useful because the gconf notifications are
360 so delays (maybe only on Maemo Bora).
361 So auto-updating is turned off, and these functions do an explicit
362 update when necessary.
363 However, something else is still doing too much work when adding/removing
364 accounts, probably in another part of the application.
366 * src/maemo/modest-account-view-window.c:
367 (on_delete_button_clicked), (on_edit_button_clicked),
368 (on_new_button_clicked): Use the new functions.
370 2007-05-09 Murray Cumming <murrayc@murrayc.com>
372 * src/modest-account-mgr-helpers.c:
373 (modest_account_mgr_set_first_account_as_default):
374 Sort the list of names alphabetically-by-title, so we choose the first one
376 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
377 alphabetically by the title.
379 This fixes projects.maemo.org bug NB#56418 .
381 * src/modest-account-mgr-priv.c:
382 (_modest_account_mgr_account_from_key):
383 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
384 avoid a valgrind error, and possible random behaviour.
386 2007-05-09 Murray Cumming <murrayc@murrayc.com>
388 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
389 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
390 tinymail documentation to say that this can be expected.
391 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
392 pretty, and should not happen, but I would prefer to know when it does.
394 2007-05-09 Murray Cumming <murrayc@murrayc.com>
396 * configure.ac: When using the older hildon version, probably on Bora,
397 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
399 * src/widgets/modest-attachment-view.c:
400 (modest_attachment_view_set_part_default): Initialize variables, to fix the
403 2007-05-09 Marcus Bauer <marcusb@openismus.com>
405 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
406 Implemented the prototype. Can be tested with
407 tests/dbus_api/test_open_message:
409 2007-05-08 Murray Cumming <murrayc@murrayc.com>
411 * src/modest-tny-account-store.c:
412 (modest_tny_account_store_instance_init), (get_password):
413 * src/modest-ui-actions.c:
414 (modest_ui_actions_on_password_requested):
415 Do not store the password in gconf, because this function is called
416 for non-remembered passwords. Actually use the cached (in the hash map)
417 password instead of releasing it.
418 The password will now not be remembered if it is asked via the protected
419 password dialog, as per the UI spec.
421 2007-05-08 Murray Cumming <murrayc@murrayc.com>
424 * src/modest-account-mgr-helpers.h:
425 * src/modest-account-mgr-helpers.c:
426 Added modest_server_account_get_username_has_succeeded(),
427 modest_server_account_set_username_has_succeeded().
428 (modest_server_account_set_username),
429 Reset the has-succeeded flag if the username changes.
431 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
432 * src/maemo/modest-connection-specific-smtp-window.c:
433 (modest_connection_specific_smtp_window_save_server_accounts):
434 Use modest_server_account_set_username() instead of using
435 modest_conf_set_string() directly, so that the has-succeeded flag is always
438 * src/modest-ui-actions.c:
439 (modest_ui_actions_on_password_requested): Dim the username entry if
440 the username has ever worked, as per the UI spec.
442 2007-05-08 Murray Cumming <murrayc@murrayc.com>
444 * src/modest-tny-account-store.c: (get_password):
445 * src/modest-ui-actions.c:
446 (modest_ui_actions_on_password_requested):
447 Allow the username to be changed too, though there is more work to
448 be done on exactly how this behaves.
450 2007-05-08 Murray Cumming <murrayc@murrayc.com>
452 * src/modest-account-mgr-helpers.h:
453 * src/modest-account-mgr-helpers.c:
454 Added modest_account_mgr_get_display_name(),
455 modest_server_account_get_username(),
456 modest_server_account_set_username(),
457 modest_server_account_set_password(),
458 modest_server_account_get_hostname() functions so we do not need to
459 use the conf API directly.
461 * src/maemo/modest-main-window.c: (connect_signals):
462 Actually connect ot the ModestAccountStore::request-password signal,
463 so that we show the dialog when the password is requested by Tinymail,
464 for isntance if it is empty.
466 * src/modest-marshal.list:
467 * src/modest-tny-account-store.c:
468 (modest_tny_account_store_class_init), (get_password),
469 (modest_tny_account_store_alert):
470 * src/modest-tny-account-store.h:
471 * src/modest-ui-actions.h:
472 * src/modest-ui-actions.c:
473 (modest_ui_actions_on_password_requested):
474 Change the signal parameters, so it is obvious that we are providing
475 the non human-readable server name, and receiving both the username
476 and password, though changing of the username is not yet implemented.
477 Change the dialog UI to match the Maemo UI specifications, with #idfefing
478 for the GNOME version.
480 This should fix the projects.maemo.org bug NB#56209, though it does not
481 work on Bora, because the gconf_client_get() for the password fails
482 immediately after we save it with gconf_client_set().
484 2007-05-08 Murray Cumming <murrayc@murrayc.com>
487 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
488 caused an undefined symbol error:
489 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
491 2007-05-08 Murray Cumming <murrayc@murrayc.com>
493 * src/modest-tny-account-store.c:
494 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
495 using a GError instead of a string message, so we can translate it in
498 2007-05-08 Murray Cumming <murrayc@murrayc.com>
500 * src/maemo/modest-address-book.c:
501 (modest_address_book_check_names):
502 * src/maemo/modest-msg-view-window.c:
503 (modest_msg_view_window_clipboard_owner_change):
504 * src/modest-init.c: (modest_init_init_ui):
505 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
506 (update_folders_cb), (modest_mail_operation_update_account):
507 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
508 (modest_ui_actions_on_msg_attachment_clicked),
509 (modest_ui_actions_on_msg_recpt_activated):
510 * src/widgets/modest-header-view.c: (drag_data_get_cb):
511 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
512 (modest_msg_view_search_next):
513 * src/widgets/modest-recpt-editor.c:
514 (modest_recpt_editor_on_button_release_event),
515 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
516 g_message(). At this point we should only be seeing interesting errors on
517 stdout. Debugging messages could be #ifdefed-out if they are still useful.
519 2007-05-07 Murray Cumming <murrayc@murrayc.com>
521 (modest_wizard_dialog_force_title_update):
522 * src/maemo/easysetup/modest-wizard-dialog.h:
523 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
524 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
525 can update the title when appropriate. Otherwise the title is wrong if the
526 pages are added after adding the notebook to the dialog.
527 This must be a problem in HildonWizardDialog too.
528 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
530 * src/maemo/easysetup/modest-easysetup-wizard.c:
531 (create_subsequent_customsetup_pages),
532 (create_subsequent_easysetup_pages):
533 Call modest_wizard_dialog_force_title_update() so that the title is
534 correct even with GTK+ < 2.10.
535 This fixes projects.maemo.org bug NB#56145 .
537 2007-05-07 Murray Cumming <murrayc@murrayc.com>
539 * src/maemo/modest-platform.c:
540 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
541 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
544 2007-05-07 Murray Cumming <murrayc@murrayc.com>
546 * src/widgets/modest-window.h:
547 * src/widgets/modest-window.c: Added a save_state_func vfunc,
548 and modest_window_save_state(), which invokes it.
550 * src/widgets/modest-window-mgr.h:
551 * src/widgets/modest-window-mgr.c:
552 Added modest_window_mgr_save_state_for_all_windows(), which calls
553 the save_state vfunc on all registered windows, if implemented.
555 * src/gnome/modest-msg-edit-window.c:
556 * src/gnome/modest-msg-view-window.c:
557 * src/maemo/modest-msg-edit-window.c:
558 * src/maemo/modest-msg-view-window.c:
559 * src/maemo/modest-main-window.c:
560 Specify the existing save_settings functions as implementations of
561 ModestWindow::save_state_func().
563 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
564 Call modest_window_mgr_save_state_for_all_windows(). This happens before
565 enabling hibernation, for instance.
567 We may need to do the same thing for restoring settings.
570 2007-05-07 Murray Cumming <murrayc@murrayc.com>
572 * src/widgets/modest-window-mgr.c:
573 * src/widgets/modest-window-mgr.h:
574 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
575 modest_window_mgr_get_hibernation_is_prevented().
577 * src/maemo/modest-main-window.c:
578 (on_hildon_program_is_topmost_notify): Prevent hibernation
579 (possible when the application goes to the background in the WM),
580 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
582 * src/maemo/easysetup/modest-easysetup-wizard.c:
583 (modest_easysetup_wizard_dialog_init):
584 * src/maemo/modest-account-settings-dialog.c:
585 (modest_account_settings_dialog_init):
586 * src/maemo/modest-connection-specific-smtp-edit-window.c:
587 (modest_connection_specific_smtp_edit_window_init):
588 * src/maemo/modest-connection-specific-smtp-window.c:
589 (modest_connection_specific_smtp_window_init):
590 * src/maemo/modest-signature-editor-dialog.c:
591 (modest_signature_editor_dialog_init):
592 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
593 prevent hibernation while any of these account settings dialogs are open.
595 2007-05-04 Murray Cumming <murrayc@murrayc.com>
597 * src/maemo/Makefile.am:
598 * src/maemo/modest-osso-state-saving.c:
599 * src/maemo/modest-osso-state-saving.h: Added
600 modest_osso_load_state() and modest_osso_save_state() though they do
601 nothing now. They should iterate through all the open windows and load/save
603 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
604 save state when closing.
606 * src/maemo/modest-main-window.c:
607 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
608 Add a notification handler for the HildonProgram::is-topmost property,
609 so we can allow hibernation when the application goes into the background.
610 But we still need to detect when the accounts setup windows are open so
611 we can stop hibernation when they are open.
612 To do this, I also added the main window the HildonProgram. This might have
613 other side-effects/benefits, and should maybe be done for other windows.
615 * src/maemo/modest-osso-autosave-callbacks.h:
616 * src/maemo/modest-osso-autosave-callbacks.c:
617 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
618 though it does not do anything yet, and we might never need this to do
619 anything. For instance, we already save drafts.
621 * src/maemo/modest-platform.c: (modest_platform_init):
622 Specify the libosso auto-save callback.
624 2007-05-03 Murray Cumming <murrayc@murrayc.com>
626 * src/maemo/modest-platform.c:
627 (modest_platform_set_update_interval):
628 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
629 aparently stays valid between application instances, so we can use this
630 to remove and reset it later. According to a maemo-developers email from
633 2007-05-03 Murray Cumming <murrayc@murrayc.com>
635 * configure.ac: Depend on libalarm for Maemo.
637 * src/dbus_api/modest-dbus-api.h:
638 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
639 (on_send_receive), (modest_dbus_req_handler):
640 Handle a SEND_RECEIVE D-Bus method.
642 * libmodest-dbus-client/libmodest-dbus-client.c:
643 (libmodest_dbus_client_send_and_receive):
644 * libmodest-dbus-client/libmodest-dbus-client.h:
645 Add C convenience functions for calling the new D-Bus method.
647 * src/modest-platform.h:
648 * src/gnome/modest-platform.c:
649 * src/maemo/modest-platform.c:
650 Added modest_platform_set_update_interval(), which uses the
652 (modest_platform_init),
653 Call modest_platform_set_update_interval(), using a hard-coded
654 interval for now (until the global settings dialog is implemented),
655 though I am not sure that this makes sense yet.
657 2007-05-02 Murray Cumming <murrayc@murrayc.com>
659 * src/dbus_api/modest-dbus-callbacks.c:
660 (modest_osso_cb_hw_state_handler):
661 * src/dbus_api/modest-dbus-callbacks.h:
662 * src/maemo/modest-platform.c: (modest_platform_init):
663 Registered (empty) callbacks for the osso hardware state D-Bus signals,
664 in case this has some effect on the ability for Maemo to ping the
667 2007-05-02 Murray Cumming <murrayc@murrayc.com>
669 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
670 Comment out an if() that checks a gchar for < 0, causing a build-breaking
671 warning. It is probably a logic error, but I need to fix the build.
673 2007-05-02 Murray Cumming <murrayc@murrayc.com>
675 * src/modest-account-mgr.h:
676 * src/modest-account-mgr.c:
677 (modest_account_mgr_account_names): Add a gboolean enabled_only
678 parameter, so we can get lists of onlt the enabled accounts.
680 (modest_account_mgr_add_account),,
681 (modest_account_mgr_account_with_display_name_exists):
682 * src/maemo/modest-msg-edit-window.c: (get_transports):
683 * src/modest-account-mgr-helpers.c:
684 (modest_account_mgr_set_first_account_as_default):
685 * src/modest-init.c: (init_default_account_maybe):
686 * src/modest-tny-account-store.c: (get_accounts):
687 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
688 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
689 * tests/check_account-mgr.c: (START_TEST):
690 Provide the extra parameter, as appropriate.
692 * src/widgets/modest-account-view.c: (update_account_view):
693 Do not show disabled accounts (meaning that there is no way to
694 enable/disable accounts in the UI (the feature is not in our UI
695 specification), so we can use this internally only to mark unfinished
696 or temporary account data.
698 * src/maemo/easysetup/modest-easysetup-wizard.c:
699 (create_account): Add boolean enable parameter, so we can specify FALSE
700 to create the temporary account.
701 (on_button_edit_advanced_settings): Create the temporary account as disabled.
702 (on_before_next): When finishing, when there is a temporary account, just
704 Also, use a timeout to delay the showing of the dialog until gconf is likely
705 to return correct information, due to a maemo gconf bug that is fixed in
706 osso 1.1, but not yet in Bora.
707 However, the dialog stays on screen after it is destroyed.
709 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
710 for invalid data when cancelling. Use a hildon note instead of a dialog
711 to complain about invalid data. Do not show the account-saved note if the
712 account is disabled (a temporary account that will not really be saved for use
715 2007-04-30 Murray Cumming <murrayc@murrayc.com>
717 * src/modest-account-mgr-helpers.h:
718 * src/modest-account-mgr-helpers.c:
719 Added modest_account_mgr_unset_default_account(),
720 Added modest_account_mgr_set_first_account_as_default().
722 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
723 If it was the default account, unset the default account name.
725 * src/maemo/modest-account-view-window.c:
726 (on_delete_button_clicked): If it was the default account,
727 set the first remaining account as the default instead.
729 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
730 a NULL account or a NULL default account, to prevent a crash. This should
731 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
734 2007-04-30 Murray Cumming <murrayc@murrayc.com>
736 * src/widgets/modest-recpt-editor.c:
737 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
738 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
739 TODO comment for this. This fixes the build.
741 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
742 be the best place for it. This will in future update all auto-update accounts,
743 rather than just the current/default account, when that gconf key exists.
744 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
745 if there are no accounts, before calling do_send_receive().
746 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
748 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
749 * src/maemo/modest-main-window-ui.h:
750 * src/maemo/modest-main-window.c: (on_connection_changed),
751 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
752 directly, becaue the signal handler does more.
754 2007-04-30 Murray Cumming <murrayc@murrayc.com>
756 * src/modest-account-mgr-helpers.c:
757 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
758 for the case that the account does not exist.
760 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
761 (equivalent to the modest account name) rather than the tinymail account name
762 (equivalent to the modest account title - human readable) to get the account data.
763 Check for null account data to prevent the crash, and add a TODO comment saying that
764 this needs fixing because it is using the server account name instead of the account name.
766 2007-04-29 Murray Cumming <murrayc@murrayc.com>
768 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
769 * src/maemo/modest-account-settings-dialog.c: (show_error),
771 Use hildon_note_new_information() for informative and error messages,
772 which seems to be expected for Maemo applications (no documentation that I know of
773 says this). I am surprised that there is no distinction between info and error
776 2007-04-29 Murray Cumming <murrayc@murrayc.com>
778 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
779 it is easy to find where this is used.
781 * src/maemo/easysetup/modest-easysetup-wizard.c:
782 (create_page_welcome), (create_page_account_details),
783 (create_page_user_details), (create_page_complete_easysetup),
784 (create_page_custom_incoming), (create_page_custom_outgoing),
785 (create_page_complete_custom):
786 * src/maemo/modest-account-settings-dialog.c:
787 (create_page_account_details), (create_page_user_details),
788 (create_page_incoming), (create_page_outgoing):
789 * src/maemo/modest-account-view-window.c: (window_vbox_new):
790 * src/maemo/modest-connection-specific-smtp-edit-window.c:
791 (modest_connection_specific_smtp_edit_window_init):
792 * src/maemo/modest-connection-specific-smtp-window.c:
793 (modest_connection_specific_smtp_window_init):
794 * src/maemo/modest-signature-editor-dialog.c:
795 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
796 and scrolling policy as per the Email Application Layout Guide, if I have
799 2007-04-27 Murray Cumming <murrayc@murrayc.com>
801 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
802 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
803 which were empty, because these vfuncs have been removed from TnyAccountStore.
804 This fixes the build.
806 2007-04-27 Murray Cumming <murrayc@murrayc.com>
808 * src/maemo/modest-main-window.c:
809 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
810 showing/hiding it. Added TODO because it probably should not be NULL.
811 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
812 because unnecessary g_warnings() make degugging difficult.
814 2007-04-27 Murray Cumming <murrayc@murrayc.com>
816 * src/maemo/modest-msg-edit-window.c:
817 (modest_msg_edit_window_select_color),
818 (modest_msg_edit_window_select_background_color): 2 const corrections and
819 moving 2 #endifs before closing brackets, to fix the build.
821 2007-04-27 Murray Cumming <murrayc@murrayc.com>
823 * src/maemo/easysetup/modest-easysetup-wizard.h:
824 * src/maemo/easysetup/modest-easysetup-wizard.c:
825 (modest_easysetup_wizard_dialog_finalize),
826 (on_button_edit_advanced_settings), (create_page_complete_custom),
827 (on_response), (create_account):
828 Implement the Advanced Settings edit button, by saving the account information,
829 for the Advanded Settings dialog to use directly from gconf, and removing it
830 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
831 Bug #5533 in the projects.maemo.org bugzilla.
833 2007-04-27 Murray Cumming <murrayc@murrayc.com>
835 * src/maemo/modest-msg-view-window.c:
836 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
837 when opening a message window.
839 2007-04-27 Murray Cumming <murrayc@murrayc.com>
841 * src/maemo/easysetup/modest-easysetup-wizard.c:
842 (create_page_custom_outgoing): Correct the position of the horizontal separator to
845 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
846 before showing/hiding them, to avoid a crash when clicking on folders when there are no
847 gconf settings. I probably added more checks than necessary, but that is safer.
849 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
850 variable to fix the build, but this seems to be used when it is still NULL.
852 2007-04-27 Murray Cumming <murrayc@murrayc.com>
854 * src/modest-platform.h:
855 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
856 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
857 * src/modest-main.c: Implement this function so we can avoid using
858 maemo-specific API from cross-platform code.
860 * src/modest-tny-account-store.c:
861 (get_smtp_specific_transport_account_for_open_connection):
862 * src/modest-ui-actions.c: (check_for_connection),
863 (modest_ui_actions_on_item_not_found):
864 Use modest_platform_connect_and_wait() and put #idefs around other
865 maemo-specific code, because only maemo currently has a way to
866 identify connection names.
868 2007-04-27 Murray Cumming <murrayc@murrayc.com>
870 * src/modest-tny-account-store.h:
871 * src/modest-tny-account-store.c:
872 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
873 the connection-specific SMTP server settings in the configuration.
875 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
877 * src/maemo/modest-main-window.c: (on_connection_changed),
879 * src/modest-main.c: (main), (start_ui), (send_mail):
880 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
881 that is what is intended.
883 * src/modest-ui-actions.c: (action_send), (action_receive),
884 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
885 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
886 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
887 SMTP server is used when it is specified.
889 (modest_ui_actions_on_send_receive):
890 Check that a connection is open before proceeding.
891 Receive and then send, instead of vice-versa, as per the specification.
893 2007-04-26 Murray Cumming <murrayc@murrayc.com>
895 * src/modest-mail-operation.c:
896 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
897 though I guess it should be something other than NULL.
899 2007-04-26 Murray Cumming <murrayc@murrayc.com>
901 * src/maemo/easysetup/modest-easysetup-wizard.c:
902 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
903 combo twice, to avoid an g_warning and to make it visible again.
904 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
905 attached before detaching it, to avoid a g_warning, and add comment about the implicit
906 (already intended) dereference when detaching, because we then recreate the menu.
907 But I am not sure why the warning was happening, and it is possible that this is a memory
910 2007-04-25 Murray Cumming <murrayc@murrayc.com>
912 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
913 and uri_parse_mailto() utility functions.
914 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
916 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
918 2007-04-24 Murray Cumming <murrayc@murrayc.com>
920 * src/dbus_api/modest-dbus-api.h:
921 * src/dbus_api/modest-dbus-callbacks.c:
922 Use an idle callback to execute the modest code in the application's own thread.
923 Remove the helloworld example method.
924 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
925 parsed, and the open-message method is not implemented because this is not yet implemented in
927 * libmodest-dbus-client/libmodest-dbus-client.c:
928 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
929 (libmodest_dbus_client_open_message):
930 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
932 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
933 body without crashing.
935 * tests/dbus_api/Makefile.am:
936 * tests/dbus_api/test_mail_to.c:
937 * tests/dbus_api/test_open_message.c: New tests for the new methods.
939 2007-04-24 Murray Cumming <murrayc@murrayc.com>
941 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
942 Added file to fix the build. Sorry.
944 * src/dbus_api/Makefile.am:
945 * src/dbus_api/modest-dbus-api.h:
946 * src/dbus_api/modest-dbus-callbacks.h:
947 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
948 (modest_dbus_req_handler):
949 Put constants in a separate header so it can be reused by the
950 client library, without duplication
952 * libmodest-dbus-client/Makefile.am:
953 * libmodest-dbus-client/libmodest-dbus-client.c:
954 (libmodest_dbus_client_call_helloworld),
955 (libmodfest_dbus_client_send_mail),
956 (libmodfest_dbus_client_mailto),
957 (libmodfest_dbus_client_open_message):
958 * libmodest-dbus-client/libmodest-dbus-client.h:
959 (Partly) Implement a send_mail D-Bus method.
961 * tests/dbus_api/Makefile.am:
962 * tests/dbus_api/test_send_mail.c: (main): Added a test for
963 the send_email D-Bus method.
965 2007-04-24 Murray Cumming <murrayc@murrayc.com>
969 * libmodest-dbus-client/Makefile.am:
970 * libmodest-dbus-client/libmodest-dbus-client.c:
971 * libmodest-dbus-client/libmodest-dbus-client.h:
972 * tests/dbus_api/Makefile.am:
973 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
974 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
976 2007-04-24 Murray Cumming <murrayc@murrayc.com>
978 * src/maemo/easysetup/modest-easysetup-wizard.c:
979 (create_page_account_details):
980 * src/maemo/modest-account-settings-dialog.c:
981 (create_page_account_details): Explicitly set auto-capitalization mode for the title
982 widgets, because this might not be the default in future versions of the Maemo GTK+.
983 However, I can not not get capitalization to work even in a simple test case.
985 2007-04-24 Murray Cumming <murrayc@murrayc.com>
987 * src/maemo/easysetup/modest-easysetup-wizard.c:
988 (create_page_custom_incoming), (create_page_custom_outgoing):
989 * src/maemo/modest-account-settings-dialog.c:
990 (create_page_account_details), (create_page_incoming),
991 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
992 instead of using gtk_check_button_with_label(), so they are aligned like the other
993 widgets, as per the UI spec.
995 2007-04-24 Murray Cumming <murrayc@murrayc.com>
997 * src/maemo/easysetup/modest-easysetup-wizard.c:
998 * src/maemo/modest-connection-specific-smtp-edit-window.c:
999 * src/widgets/modest-validating-entry.c:
1000 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1001 Modest prefix instead of an EasySetup prefix.
1003 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1005 * src/widgets/modest-validating-entry.h:
1006 * src/widgets/modest-validating-entry.c: (on_insert_text),
1007 Added easysetup_validating_entry_set_max_func(), used to set a callback
1008 to call when the max number of characters is reached. GtkEntry has a max-length
1009 already but is silent about it.
1011 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1012 (create_page_account_details), (create_page_user_details),
1014 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1015 (create_page_account_details), (create_page_user_details),
1016 (create_page_outgoing):
1017 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1018 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1019 the UI spec, when the user tries to enter more than the max number of characters.
1021 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1023 * src/maemo/easysetup/modest-easysetup-wizard.c:
1024 (create_page_user_details), (create_page_custom_incoming),
1025 (create_page_custom_outgoing):
1026 * src/maemo/modest-account-settings-dialog.c:
1027 (create_page_user_details), (create_page_incoming),
1028 (create_page_outgoing):
1029 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1030 (modest_connection_specific_smtp_edit_window_init):
1031 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1032 not appropriate. Bad Maemo-specific defaults!.
1034 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1036 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1037 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1038 (modest_signature_editor_dialog_set_settings):
1039 Disable the label and textview when the checkbox is disabled, and use the
1040 specified (UI spec) default signature text.
1042 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1044 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1045 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1047 * src/modest-defs.h:
1048 * src/modest-account-mgr-helpers.h:
1049 * src/modest-account-mgr-helpers.c:
1050 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1052 * src/maemo/Makefile.am:
1053 * src/maemo/modest-signature-editor-dialog.c:
1054 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1057 * src/maemo/modest-account-settings-dialog.h:
1058 * src/maemo/modest-account-settings-dialog.c:
1059 (modest_account_settings_dialog_finalize), (on_button_signature),
1060 (save_configuration): Use the new dialog when the Edit button is pressed, and
1061 save the changes if necessary, as per the UI spec.
1063 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1065 * src/maemo/Makefile.am:
1066 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1067 based on maemo-develoers email from Dirk.
1069 * src/maemo/easysetup/modest-easysetup-wizard.c:
1070 (create_page_welcome), (create_page_account_details),
1071 (create_page_user_details), (create_page_complete_easysetup),
1072 (create_page_custom_incoming), (create_page_custom_outgoing),
1073 (create_page_complete_custom),
1074 (modest_easysetup_wizard_dialog_init):
1075 * src/maemo/modest-account-settings-dialog.c:
1076 (create_page_account_details), (create_page_user_details),
1077 (create_page_incoming), (create_page_outgoing),
1078 (modest_account_settings_dialog_init):
1079 * src/maemo/modest-connection-specific-smtp-window.c:
1080 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1082 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1084 * src/maemo/easysetup/modest-easysetup-wizard.c:
1085 (create_page_account_details), (create_page_custom_outgoing),
1086 (create_page_complete_custom):
1087 * src/maemo/modest-account-settings-dialog.c:
1088 (create_page_user_details), (create_page_incoming),
1089 (create_page_outgoing):
1090 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1091 (modest_connection_specific_smtp_edit_window_init):
1092 Use the correct (UI spec) port min/max, and use horizontal separators,
1095 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1097 * src/maemo/easysetup/modest-easysetup-wizard.c:
1098 (set_default_custom_servernames):
1099 * src/maemo/modest-account-settings-dialog.c:
1100 (create_page_incoming), (on_combo_outgoing_security_changed),
1101 (on_combo_incoming_security_changed), (create_page_outgoing),
1102 (modest_account_settings_dialog_set_account_name),
1103 (save_configuration):
1104 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1105 (on_combo_security_changed),
1106 (modest_connection_specific_smtp_edit_window_init),
1107 (modest_connection_specific_smtp_edit_window_set_connection),
1108 (modest_connection_specific_smtp_edit_window_get_settings):
1109 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1112 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1115 * src/maemo/easysetup/modest-easysetup-wizard.c:
1116 (create_page_custom_outgoing), (create_page_complete_custom):
1117 * src/maemo/modest-account-settings-dialog.c:
1118 (create_page_user_details), (create_page_outgoing):
1119 * src/maemo/modest-account-view-window.c: (button_box_new):
1120 Use changed logical IDs as per the most recent UI spec:
1121 mcen_bd_emailsetup_edit -> mcen_bd_edit
1122 mcen_bd_emailsetup_delete -> mcen_bd_delete
1123 mcen_bd_emailsetup_close -> mcen_bd_close
1125 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1129 * src/dbus_api/Makefile.am:
1130 * src/dbus_api/modest-dbus-callbacks.c:
1131 * src/dbus_api/modest-dbus-callbacks.h:
1132 * src/maemo/modest-platform.c: (modest_platform_init):
1133 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1135 * tests/Makefile.am:
1136 * tests/dbus_api/Makefile.am:
1137 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1139 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1141 * src/maemo/modest-account-settings-dialog.c:
1142 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1143 Removed unnecessary includes.
1145 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1147 * src/maemo/easysetup/modest-easysetup-wizard.c:
1148 * src/maemo/modest-account-settings-dialog.c:
1149 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1150 * src/widgets/Makefile.am:
1151 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1152 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1153 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1154 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1155 * src/widgets/modest-secureauth-combo-box.c:
1156 * src/widgets/modest-secureauth-combo-box.h:
1157 * src/widgets/modest-serversecurity-combo-box.c:
1158 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1159 made the GObject names more consistent with the rest of the Modest code.
1161 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1163 * src/maemo/easysetup/Makefile.am:
1164 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1165 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1166 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1167 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1168 * src/maemo/easysetup/modest-easysetup-wizard.c:
1169 * src/maemo/easysetup/modest-validating-entry.c:
1170 * src/maemo/easysetup/modest-validating-entry.h:
1171 * src/maemo/modest-account-settings-dialog.c:
1172 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1173 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1174 widgets/ because they are used outside of easysetup too. After checking in,
1175 svn will allow me to rename them too.
1177 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1179 * src/gnome/modest-msg-edit-window.c:
1180 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1181 linker error, to fix the build on the GNOME platform.
1182 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1183 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1184 ifdefed out to avoid a warning.
1186 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1188 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1189 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1190 some alternative for GTK+ 2.6.
1192 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1194 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1196 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1197 specified for EmailAccountsDialog in UI spec.
1199 * src/maemo/easysetup/modest-easysetup-wizard.c:
1200 * src/maemo/easysetup/modest-easysetup-wizard.h:
1201 * src/maemo/modest-account-settings-dialog.c:
1202 * src/maemo/modest-account-settings-dialog.h:
1203 Reuse a member window widget for the connection-specific SMTP server accounts,
1204 so we can tell it to create/save the accounts only if we actually save changes.
1206 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1207 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1208 (modest_connection_specific_smtp_edit_window_get_settings):
1209 Return a struct instance for temporarily remembering the entered data.
1211 * src/maemo/modest-connection-specific-smtp-window.h:
1212 * src/maemo/modest-connection-specific-smtp-window.c:
1213 (modest_connection_specific_smtp_window_finalize),
1214 (modest_connection_specific_smtp_window_fill_with_connections),
1216 (modest_connection_specific_smtp_window_save_server_accounts),
1217 (update_model_server_names): Do not actually save data until asked,
1218 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1220 (on_selection_changed),
1221 (modest_connection_specific_smtp_window_init): Disable the edit
1222 button when nothing is selected.
1224 * src/modest-account-mgr-helpers.c:
1225 * src/modest-account-mgr-helpers.h:
1226 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1229 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1231 * src/modest-account-mgr-helpers.h:
1232 * src/modest-account-mgr-helpers.c:
1233 (modest_account_mgr_get_unused_account_name),
1234 (modest_account_mgr_get_unused_account_display_name): Added these
1235 utility functions, to avoid code duplication.
1237 * src/maemo/easysetup/modest-easysetup-wizard.c:
1238 (create_page_account_details), (create_account):
1239 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1240 (on_combo_security_changed),
1241 (modest_connection_specific_smtp_edit_window_init),
1242 (modest_connection_specific_smtp_edit_window_save_settings):
1243 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1244 * src/maemo/modest-connection-specific-smtp-window.c:
1245 (modest_connection_specific_smtp_window_finalize),
1246 (modest_connection_specific_smtp_window_fill_with_connections),
1247 (on_button_edit), (modest_connection_specific_smtp_window_init):
1248 * src/maemo/modest-connection-specific-smtp-window.h:
1249 Implementing saving of connection-specific server accounts.
1251 But I need to refactor this so we can save the data for each
1252 possible connection-specific account and only actually create the server accounts
1253 when the easysetup finished, or the OK button is pressed on the account settings
1256 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1258 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1259 (on_combo_security_changed):
1260 (modest_connection_specific_smtp_edit_window_init):
1261 Auto-fill the port number as in the account settings.
1263 (modest_connection_specific_smtp_edit_window_set_connection):
1264 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1265 * src/maemo/modest-connection-specific-smtp-window.c:
1266 (fill_with_connections), (on_button_edit),
1267 (modest_connection_specific_smtp_window_init):
1268 Turn the edit window into a dialog to simplify the code, and
1269 set a WM hint as in a GtkDialog, because only a popup can be on top of
1270 another window in Maemo, and popups usually have no WM decoration.
1272 * src/modest-defs.h:
1273 * src/modest-account-mgr-helpers.c:
1274 (modest_account_mgr_set_connection_specific_smtp),
1275 (modest_account_mgr_remove_connection_specific_smtp),
1276 (modest_account_mgr_get_connection_specific_smtp):
1277 * src/modest-account-mgr-helpers.h: Some functions to write the
1278 connection-specific SMTP server information. Not yet used.
1281 * src/widgets/modest-folder-view.c: (text_cell_data):
1282 Fix a warning about an uninitialized variable.
1283 (on_configuration_key_changed): Put an #ifdef around the use
1284 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1286 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1288 * src/maemo/modest-account-settings-dialog.h:
1289 * src/maemo/modest-account-settings-dialog.c:
1290 Added connect_for_modified() utility function to mark the new modified boolean.
1292 (create_page_account_details), (create_page_user_details),
1293 (create_page_incoming), (create_page_outgoing), (on_response),
1294 (modest_account_settings_dialog_init),
1295 (modest_account_settings_dialog_set_account_name):
1296 Only warn about unsaved changes when there are actually unsaved changes.
1298 * src/modest-account-mgr-helpers.c:
1299 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1300 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1301 to get the data from there in future.
1303 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1305 * src/modest-defs.h:
1307 * src/modest-account-mgr-helpers.h:
1308 * src/modest-account-mgr-helpers.c:
1309 Store the security account setting in a single conf key instead of using
1310 the options list, so that the list is left for just the to-be-removed camel hack,
1311 and because gconf_client_set_list() is failing for some reason.
1313 * src/modest-account-mgr.c:
1314 (modest_account_mgr_add_server_account):
1315 * src/maemo/modest-account-settings-dialog.c:
1316 (modest_account_settings_dialog_set_account_name),
1317 (save_configuration): Use the renamed functions.
1320 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1322 * src/widgets/Makefile.am:
1323 * src/widgets/modest-limit-retrieve-combo-box.c:
1324 * src/widgets/modest-limit-retrieve-combo-box.h:
1325 * src/widgets/modest-retrieve-combo-box.c:
1326 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1327 the account settings dialog.
1329 * src/modest-defs.h:
1330 * src/modest-account-mgr-helpers.h:
1331 * src/modest-account-mgr-helpers.c:
1332 (modest_server_account_get_option_secure_auth),
1333 (modest_server_account_set_option_secure_auth):
1334 * src/modest-account-mgr.c:
1335 (modest_account_mgr_add_server_account):
1336 Use the existing AUTH_MECH conf key for the secure-auth setting,
1337 instead of putting it in the list options, because this was actually used already.
1339 * src/maemo/modest-account-settings-dialog.c:
1340 (create_page_account_details),
1341 (modest_account_settings_dialog_set_account_name),
1342 (save_configuration):
1343 * src/maemo/modest-account-settings-dialog.h:
1344 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1345 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1347 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1349 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1350 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1351 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1353 * src/modest-defs.h:
1354 * src/maemo/modest-account-settings-dialog.c:
1355 (create_page_incoming), (on_combo_outgoing_security_changed),
1356 (on_combo_incoming_security_changed), (create_page_outgoing),
1357 (modest_account_settings_dialog_set_account_name),
1358 (save_configuration): Load/Save the port number, and change it when the
1359 security combo changes, to suitable defaults.
1361 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1363 * src/modest-account-mgr.c:
1364 (modest_account_mgr_add_server_account): Set the security and secure-auth
1365 options, and add a comment saying that the other camel-specific options should be
1368 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1370 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1372 * src/modest-tny-account-store.c: (account_list_free),
1373 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1374 cursor->data after unreffing it. But there is some strange stuff there so it might not be
1377 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1379 * src/modest-protocol-info.c:
1380 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1381 is required by our UI spec. Maybe something in our implementation will use this eventually.
1382 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1383 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1384 instead of the previous 0 placeholder.
1386 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1387 secure-auth settings.
1388 * src/modest-account-mgr-helpers.h:
1389 * src/modest-account-mgr-helpers.c:
1390 (modest_server_account_data_get_option_secure_auth),
1391 (modest_server_account_set_option_secure_auth),
1392 (modest_server_account_data_get_option_security),
1393 (modest_server_account_set_option_security): Added this API for getting and setting the security
1394 and secure-auth settings.
1396 * src/maemo/modest-account-settings-dialog.h:
1397 * src/maemo/modest-account-settings-dialog.c:
1398 (modest_account_settings_dialog_finalize), (check_data),
1399 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1400 about changing titles.
1401 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1402 (save_configuration): Save the security and secure-auth settings.
1404 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1405 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1407 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1409 * src/modest-defs.h:
1410 * src/modest-account-mgr.c:
1411 (modest_account_mgr_add_server_account):
1412 Added and used defines for the options key and value pair strings,
1413 that are used so far, though they do not seem to correspond to anything in our
1414 UI specs or ModestProtocol enum.
1416 * src/modest-account-mgr-helpers.h:
1417 * src/modest-account-mgr-helpers.c:
1418 (compare_option_strings_for_name),
1419 (modest_server_account_data_get_option_value),
1420 (modest_server_account_data_get_option_bool),
1421 (modest_account_mgr_get_server_account_option):
1422 Added helper functions for parsing the options GSList.
1424 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1426 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1427 display name is based on the supplied account name.
1428 * src/modest-account-mgr.c:
1429 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1430 with an inefficient, but good-enough, implementation.
1432 * src/maemo/easysetup/modest-easysetup-wizard.c:
1433 (create_page_account_details), (on_before_next), (create_account):
1434 Check for existing display names rather than (non-user-visible) account names, and just
1435 create and set a unique account name at the end.
1437 * src/maemo/modest-account-settings-dialog.c:
1438 (modest_account_settings_dialog_init),
1439 (modest_account_settings_dialog_set_account_name),
1440 (create_page_incoming): Show the display name, instead of the account name.
1441 (on_response): Do some (not all) extra checks, as in the UI spec.
1442 (save_configuration): Save the display name if it was changed.
1444 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1446 * po/en_GB.po: Added needed logical ID and translation.
1447 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1448 (init_view): Made the is-default column clicking work.
1450 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1453 * src/maemo/easysetup/Makefile.am:
1454 * src/maemo/easysetup/modest-easysetup-wizard.c:
1455 (modest_easysetup_wizard_dialog_init):
1456 * src/maemo/easysetup/provider-data-test.keyfile:
1457 * src/maemo/easysetup/provider-data.keyfile:
1458 Moved the provider data file to the new modest-providers-data package and used it from there.
1460 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1462 * src/modest-local-folder-info.c:
1463 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1464 N_() was already used on the static strings, but this just marks it for translation without
1465 using the translation.
1467 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1469 * src/maemo/modest-account-settings-dialog.c:
1470 (create_page_incoming),
1471 (modest_account_settings_dialog_set_account_name):
1472 Added comments about the need for new API in ModestAccountMgr to handle the authentication
1473 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1474 I will do this if nobody else gets there first.
1476 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1478 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1479 Saved much of the incoming and outgoing data too, though I cannot yet see how to
1480 save the security stuff.
1482 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1484 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1485 Set the email address and user fullname, which I now see must be
1488 * src/maemo/modest-account-settings-dialog.h:
1489 * src/maemo/modest-account-settings-dialog.c:
1491 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1492 leave-on-server and authentication.
1493 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1496 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1499 * src/maemo/modest-account-settings-dialog.c:
1500 * src/maemo/modest-account-settings-dialog.h:
1501 Most (but not all) of the widgets are now present as specified by the UI spec.
1502 No changes are yet saved, and some details are not properly shown yet.
1504 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1506 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1508 * src/maemo/Makefile.am:
1509 * src/maemo/modest-account-settings-dialog.c:
1510 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1511 an existing account. Doesn't do much yet.
1513 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1514 Open the accounts settings dialog when Edit is clicked.
1516 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1518 * src/maemo/easysetup/Makefile.am:
1519 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1521 * src/maemo/easysetup/modest-easysetup-wizard.c:
1522 (modest_easysetup_wizard_dialog_init):
1523 Try to get the source directory from the build system,
1524 instead of hard-coding "./" into the source code, when opening our local
1525 copies of the configuration files.
1526 But this still fails when opening the wizard from the Accounts window,
1527 maybe because the working directory seems to change at runtime.
1528 So the wizard will fail the second time unless you copy the files into their
1529 proper locations - see the stdout warnings for the paths.
1531 (create_page_account_details),(on_before_next):
1532 Check for existing non-server accounts instead of server accounts,
1533 so the default account name is useful again, and to prevent trying to
1536 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1537 Show the wizard when New is clicked.
1539 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1540 (init_view): Show the column headers, and show the columns that are
1541 specified in the UI specs. However, something in Maemo's GTK+ prevents
1542 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1543 change the default account. This is despite unsetting the special properties.
1545 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1547 * docs/reference/modest-design.sgml: Corrected spelling mistake.
1548 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1549 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1550 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1551 to make that clearer.
1552 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1554 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1556 * src/maemo/modest-account-view-window.c:
1557 (modest_account_view_window_init),
1558 (modest_account_view_window_new):
1559 Use the same buttons as specified in the
1560 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1561 the existing widgets, which never had a chance of working.
1562 Put the ModestAccountView treeview in a scrolled window.
1563 Do not repeat the initialization in both _init() and _new().
1565 * src/widgets/modest-account-view.c: (update_account_view):
1566 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1567 this widget and window shows no accounts.
1569 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1571 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1573 * src/maemo/easysetup/modest-easysetup-wizard.c:
1574 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1575 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1576 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1579 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1580 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1581 accounts exist yet, as in the UI spec.
1583 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
1585 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1587 * src/maemo/Makefile.am:
1588 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1589 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1590 New window for editing connection-specific smtp details.
1591 Not fully implemented.
1593 * src/maemo/modest-connection-specific-smtp-window.c:
1594 (modest_connection_specific_smtp_window_finalize) :
1595 unref the tree model.
1596 (on_button_edit): Show the edit window.
1598 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1600 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
1603 * src/maemo/Makefile.am:
1604 * src/maemo/modest-connection-specific-smtp-window.c:
1605 * src/maemo/modest-connection-specific-smtp-window.h:
1606 New window for showing the list of connections, for connection-specific
1607 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
1608 * src/maemo/easysetup/modest-easysetup-wizard.c:
1609 (create_page_custom_outgoing): Show the new window when the button is clicked.
1611 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1613 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1614 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1615 * src/maemo/modest-msg-edit-window.c:
1616 (modest_msg_edit_window_insert_image):
1617 * src/modest-conf.c: (modest_conf_key_escape):
1618 * src/modest-mail-operation.c:
1619 (modest_mail_operation_send_new_mail):
1620 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1621 (modest_ui_actions_on_new_account):
1622 * src/widgets/modest-attachment-view.c: (update_filename_request):
1623 * src/widgets/modest-mail-header-view.c:
1624 Corrected warnings that were breaking the build, by commenting out unused variables,
1625 and a function, and by including a header.
1627 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1629 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
1630 so we can #ifdef around platform-specific code when necessary.
1631 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
1632 to allow this to build for the GNOME platform too.
1634 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1636 * src/maemo/easysetup/modest-easysetup-wizard.c:
1637 Added util_increment_name() and used it in create_page_account_details()
1638 to make sure that the default account name is always a new name.
1640 (modest_easysetup_wizard_dialog_init),
1641 (set_default_custom_servernames): Some minor memory management fixes.
1643 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1647 * src/modest-runtime.c: (init_i18n): Restored the translation
1648 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
1649 are defined in config.h, and the translations are installed.
1651 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
1652 is defined for translation.
1654 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1656 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1658 * src/maemo/easysetup/modest-easysetup-wizard.c:
1659 (modest_easysetup_wizard_dialog_init):
1660 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1661 Use realistic paths (though they should use $prefix generically) to the
1662 mcc_mapping and provider-data.keyfile files which might work when they
1663 are installed by the future version of the operator-wizard package,
1664 and then fallback to paths in our source code, with an explanatory
1667 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1671 * src/maemo/Makefile.am:
1672 * src/maemo/easysetup/: Added files from the previously-exernal
1673 osso-modest-easysetup.
1674 * src/maemo/modest-main-window-ui.h:
1675 * src/modest-ui-actions.c:
1676 * src/modest-ui-actions.h:
1677 Added modest_ui_actions_on_new_account() as a signal handler for the
1678 New Account menu item. It shows the easysetup wizard.
1679 * po/en_GB.po: Added additional needed logical IDs and translations.
1681 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
1682 Apparently ChangeLog is not used for some vague Nokia legal reasons.