1 2007-06-07 Marcus Bauer <marcusb@openismus.com>
3 * src/dbus_api/modest-dbus-api.h:
4 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
5 * src/maemo/modest-msg-edit-window.c:
6 (modest_msg_edit_window_attach_file_noninteractive):
7 added g_warning in case the file to be attached does not exist
8 * tests/dbus_api/test_compose_mail.c: (main):
9 removed obsolete comment, added generic files as test case
11 2007-06-07 Murray Cumming <murrayc@murrayc.com>
13 * src/modest-tny-account-store.c: (get_server_accounts):
14 Create the local folders account only once, not once for each outbox, and
15 not only when there are some outboxes.
17 2007-06-07 Murray Cumming <murrayc@murrayc.com>
19 * src/widgets/modest-folder-view.c: (update_model): Comment out some
20 code that is causing a crash at startup. Sergio says that he is fixing this.
22 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
24 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
25 * src/maemo/modest-account-settings-dialog.c:
26 (create_page_outgoing),
27 (modest_account_settings_dialog_set_account_name),
29 - Fixed handling of the "Use secure authentication" toggle to comply with
30 the ui specification. See also projects.maemo.org bug NB#58400
32 - Restore the Secure connection setting combo correctly when loading
35 * src/maemo/modest-maemo-utils.c:
36 (on_camel_account_get_supported_secure_authentication),
37 (modest_maemo_utils_get_supported_secure_authentication_methods):
38 Fixed a crasher if operation is canceled
40 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
41 (modest_protocol_info_auth_is_secure):
42 * src/modest-protocol-info.h:
44 Added two new methods to determine if a protocol/auth method is secure/encrypted in
45 the sense of the "Use secure authentication" toggle.
47 2007-06-07 Murray Cumming <murrayc@murrayc.com>
49 * src/modest-tny-account-store.h:
50 * src/modest-tny-account-store.c:
51 Added modest_tny_account_store_get_local_folders_account().
53 * src/modest-tny-folder.h:
54 * src/modest-tny-folder.c:
55 (modest_tny_folder_get_account):
56 Added this replacement for tny_folder_get_account() which returns
57 the local-folders account for TnyMergeFolders, to avoid the
58 warning about the unimplemented get_account_func() vfunc().
60 (modest_tny_folder_get_rules),
61 * src/modest-ui-actions.c:
62 (modest_ui_actions_on_folder_selection_changed):
63 * src/modest-mail-operation.c:
64 (modest_mail_operation_remove_folder),
65 (modest_mail_operation_xfer_folder),
66 (modest_mail_operation_rename_folder),
67 (modest_mail_operation_get_msg),
68 (modest_mail_operation_get_msgs_full),
69 (modest_mail_operation_remove_msg),
70 (modest_mail_operation_xfer_msgs),
71 (modest_mail_operation_refresh_folder):
72 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
74 2007-06-07 Murray Cumming <murrayc@murrayc.com>
76 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
77 (modest_server_account_set_security):
78 * src/modest-defs.h: Add comments explaining that our
79 UI spec means TLS when it says Normal, so these do not look like errors.
81 * src/modest-tny-account.c:
82 (modest_tny_account_new_from_server_account): Use the new tinymail
83 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
84 for TLS. This should fix projects.maemo.org bug NB#58460.
86 2007-06-06 Murray Cumming <murrayc@murrayc.com>
88 * src/maemo/easysetup/modest-easysetup-wizard.c:
89 (create_account): Correct the position of the gconf sanity check warning.
90 (on_button_edit_advanced_settings): Show the dialog immediately, instead
91 of using the g_idle_add() hack, because this does not seem to be necessary
92 on osso 1.1. It might even work on Maemo Bora if the problems were actually
93 caused by something other than maemo's gconf.
94 This fixes projects.maemo.org bug #59022.
96 2007-06-06 Murray Cumming <murrayc@murrayc.com>
98 * src/modest-account-mgr-helpers.c:
99 (modest_account_mgr_get_default_account): Do not check that the account
100 exists if there is no default account (NULL), to fix a runtime warning.
102 2007-06-06 Murray Cumming <murrayc@murrayc.com>
104 * src/widgets/modest-folder-view.c: (update_model):
105 Do not unref the treemodel before we have finished with it.
106 This prevents a valgrind warning and an occasional crash at startup.
108 2007-06-06 Marcus Bauer <marcusb@openismus.com>
110 * libmodest-dbus-client/libmodest-dbus-client.h:
111 added libmodest_dbus_client_compose_mail()
112 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
114 added functions needed for SendAsMail() functionality
115 * src/maemo/modest-msg-edit-window.c:
116 (modest_msg_edit_window_attach_file_noninteractive):
117 non interactively attaching files to message edit window
118 * src/widgets/modest-msg-edit-window.h:
119 * tests/dbus_api/Makefile.am:
120 added test_compose_mail.c
121 * tests/dbus_api/test_compose_mail.c: (main):
123 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
125 * src/modest-account-view.c:
126 Fixed bug projects.maemo.org bug NB#59307
128 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
130 * src/maemo/easysetup/modest-easysetup-wizard.c:
131 (get_serverport_incoming), (on_before_next), (create_account):
132 * src/maemo/modest-account-settings-dialog.c:
133 (modest_account_settings_dialog_set_account_name):
134 * src/maemo/modest-maemo-utils.c:
135 (on_camel_account_get_supported_secure_authentication_status),
136 (on_camel_account_get_supported_secure_authentication),
137 (on_secure_auth_cancel),
138 (modest_maemo_utils_get_supported_secure_authentication_methods):
140 Implemented security authentication for settings and easysetup.
142 2007-06-05 Murray Cumming <murrayc@murrayc.com>
144 * src/maemo/modest-main-window.c: (create_details_widget):
145 Show the total size for memory card accounts too, instead of showing
146 the name again. Fixes bug projects.maemo.org bug NB#59307.
148 2007-06-05 Murray Cumming <murrayc@murrayc.com>
151 * src/modest-tny-simple-folder-store.c:
152 * src/modest-tny-simple-folder-store.h: Removed.
154 * src/modest-tny-local-folders-account.h
155 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
156 for the local-folders maildir, with an extra TnyMergedFolder containing
157 the folders of the per-account outbox store accounts.
158 * src/modest-tny-account-store.c: (get_server_accounts):
159 Add the outboxes to the special local folders account after creating it.
161 * src/modest-tny-account.c:
162 (modest_tny_account_new_for_local_folders): Create the derived
163 account when creating the main local-folders account.
165 * src/maemo/modest-main-window.c: (create_details_widget),
166 (modest_main_window_set_contents_style):
167 Adapted to the use of the derived account instead of the folder store.
169 * src/modest-ui-actions.c:
170 (modest_ui_actions_on_folder_selection_changed):
171 * src/modest-ui-dimming-rules.c:
172 (modest_ui_dimming_rules_on_new_folder):
173 * src/widgets/modest-folder-view.c: (text_cell_data),
174 (icon_cell_data), (filter_row), (update_model),
175 (get_cmp_rows_type_pos):
178 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
179 Do not get the priv struct, because no priv struct has been set,
180 to avoid a runtime warning.
182 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
183 #ifelse with #else, to fix a warning, to fix the build.
186 2007-06-05 Christian Kellner <ckellner@openismus.com>
188 * libmodest-dbus-client/libmodest-dbus-client.c:
189 Fix small typo in doc (why do you always see them
190 AFTER committing stuff?)
193 2007-06-05 Christian Kellner <ckellner@openismus.com>
195 * libmodest-dbus-client/libmodest-dbus-client.c:
196 (libmodest_dbus_client_search):
197 Initialize hit list with NULL. Also set folder list
198 to "" if NULL was supplied.
201 2007-06-03 Christian Kellner <ckellner@openismus.com>
203 * libmodest-dbus-client/libmodest-dbus-client.c:
204 (modest_search_hit_list_free):
205 Make it save to call it with NULL.
207 * src/dbus_api/modest-dbus-callbacks.c:
208 * src/modest-search.c:
209 Return full ModestSearchHits as the search result list not TnyHeader
210 since can't be around withouth the correspoding TnyFolder.
212 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
214 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
215 Added currently commented code to check for secure auth
217 * src/maemo/modest-account-settings-dialog.c: (on_response),
218 (save_configuration), (show_ok):
219 Fixed projects.maemo.org bugs NB #59248 and #59251
221 * src/maemo/modest-maemo-utils.c:
222 (on_camel_account_get_supported_secure_authentication_status),
223 (on_camel_account_get_supported_secure_authentication),
224 (modest_maemo_utils_get_supported_secure_authentication_methods):
225 * src/maemo/modest-maemo-utils.h:
226 Moved get_supported_secure_authentication() method here to be able
227 to use it from easysetup wizard.
229 * src/modest-pair.c: (on_pair_compare_as_string):
230 Should compare string with first part of pair and not
231 strcmp pairs which will crash.
233 * src/modest-protocol-info.c:
234 (modest_protocol_info_protocol_is_store):
235 * src/modest-protocol-info.h:
236 Added modest_protocol_info_get_auth_protocol_name()
238 2007-06-03 Armin Burgmeier <armin@openismus.com>
240 * src/modest-mail-operation.c:
241 (modest_mail_operation_get_msgs_full): Set priv->account also when
242 only retrieving a single message. This avoids a crash when canceling
245 (modest_mail_operation_notify_end): Do not explicitely remove the
246 operation from the queue but only emit the progress_changed signal.
247 The queue itself listens to that signal to remove the operation when
248 it is finished. This reduces coupling and removes a potential deadlock
249 when modest_mail_operation_notify_end() is called from the queue
250 itself. If that is a problem performance-wise, I would suggest to
251 implement a status-changed signal or something.
253 * src/modest-mail-operation-queue.c: Make sure to never call a
254 function from another file while the queue is locked. This (hopefully)
255 fixes another deadlock when exiting the application while retrieving
258 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
260 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
261 Fixed build if libogs is not available
263 2007-06-03 Christian Kellner <ckellner@openismus.com>
265 * libmodest-dbus-client/libmodest-dbus-client.h:
266 * libmodest-dbus-client/libmodest-dbus-client.c:
267 (libmodest_dbus_client_delete_message):
268 Implement deletion of messages (Client side).
270 (modest_search_hit_free),
271 (modest_search_hit_list_free):
272 Utility functions to free the result hits.
274 * src/dbus_api/modest-dbus-api.h:
275 * src/dbus_api/modest-dbus-callbacks.c:
277 (modest_dbus_req_handler):
278 Implement deletion of messages (Server side).
280 * tests/dbus_api/test_search.c: (main):
283 * tests/dbus_api/Makefile.am:
284 * tests/dbus_api/test_delete_message:
285 Add little test for the message deletion logic
287 2007-06-03 Armin Burgmeier <armin@openismus.com>
289 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
290 when the operation queue was not empty. projects.maemo.org bug
293 2007-06-03 Armin Burgmeier <armin@openismus.com>
295 * src/widgets/modest-account-view.c
296 (on_account_default_toggled): Toggle default account column
297 explicitely instead of waiting for gconf notification (which is
298 currently ignored). This should fix projects.maemo.org bug NB#56910
299 for now. It should probably be removed when gconf notifications are
302 2007-06-03 Christian Kellner <ckellner@openismus.com>
304 * libmodest-dbus-client/libmodest-dbus-client.c:
305 Removed debugging spew.
307 * src/dbus_api/modest-dbus-callbacks.c:
308 Added debugging info.
310 * src/modest-search.c:
311 (modest_search_all_accounts):
312 Use tny_account_store_get_accounts () on the account store
313 to get all accounts which is the way to get all accounts.
315 * tests/dbus_api/test_search.c: (main):
316 Make it possible to supply the search term on the command line.
318 2007-06-03 Christian Kellner <ckellner@openismus.com>
320 * libmodest-dbus-client/libmodest-dbus-client.c:
321 * libmodest-dbus-client/libmodest-dbus-client.h:
322 Implement searching for mesages over raw dbus. (Client side)
324 * src/dbus_api/Makefile.am:
325 * src/dbus_api/modest-dbus-api.h:
326 * src/dbus_api/modest-dbus-callbacks.c:
327 * src/dbus_api/modest-dbus-callbacks.h:
328 Search framework (Server side). Also implement on_idle_open_message().
330 * src/maemo/modest-platform.c: (modest_platform_init):
331 Prepare for raw dbus/osso rpc interaction.
333 * src/modest-search.h:
334 Changed minsize from unspecific guint to guint32.
336 * src/modest-search.c:
338 Added strange hack which magically made tnymail work.
340 (modest_search_folder),
341 (modest_search_account),
342 (modest_search_all_accounts):
343 Implement helper functions to search all accounts, specific account
346 * tests/dbus_api/Makefile.am:
347 * tests/dbus_api/test_open_message.c:
348 Read url to open from commandline.
350 * tests/dbus_api/test_search.c:
351 Implement small test for dbus search stuff
353 2007-06-02 Armin Burgmeier <armin@openismus.com>
355 * src/maemo/modest-account-settings-dialog.c: Changed window title to
356 include account type and account title. This fixes projects.maemo.org
359 * src/maemo/modest-account-view-window.c: Set a title for the window.
361 2007-06-02 Armin Burgmeier <armin@openismus.com>
363 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
364 incoming and outgoing server name based on email address and server
365 types as long as the names have not been edited manually. This fixes
366 projects.maemo.org bug NB#58671.
368 2007-06-02 Armin Burgmeier <armin@openismus.com>
370 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
371 server type cannot be changed in future to the incoming details page
372 when creating an account. This fixes projects.maemo.org bug NB#59029.
374 2007-06-02 Armin Burgmeier <armin@openismus.com>
376 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
377 and assigned max width chars so that they wrap instead of being
378 truncated. Fixes projects.maemo.org bug NB#56126.
380 2007-06-02 Armin Burgmeier <armin@openismus.com>
382 * src/maemo/modest-connection-specific-smtp-window.c: Add an
383 introductory note to the connection specific smtp servers dialog, as
384 section 8.12 of the email UI specification requires. This fixes
385 projects.maemo.org bug NB#59212.
387 2007-06-01 Murray Cumming <murrayc@murrayc.com>
389 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
390 Check for running mail operations, and offer to cancel them, as per the UI
391 spec. This fixes projects.maemo.org bug NB#59041 .
392 However, I suspect that tinymail may still use the network connection
393 in ways that we cannot detect or cancel. But it should at least adapt to
396 2007-06-01 Murray Cumming <murrayc@murrayc.com>
398 * src/modest-tny-account-store.c: (recreate_all_accounts),
399 (get_cached_accounts), (get_server_accounts): Do more sensible
400 ref-counting of the temporarily-cached outbox accounts list. This seems
401 to fix a crash when entering the password when the password was wrong.
403 2007-06-01 Murray Cumming <murrayc@murrayc.com>
405 * src/gnome/modest-main-window.c: (connect_signals):
406 * src/modest-tny-account-store.c: (get_password),
407 (modest_tny_account_store_alert): Added comments and clues and
408 commented-out code about how we currently fail to deal with connection
409 errors and wrong passwords, and how we should.
411 2007-06-01 Murray Cumming <murrayc@murrayc.com>
413 * src/widgets/modest-retrieve-combo-box.c:
414 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
415 This fixes projects.maemo.org bug NB#58472 .
417 2007-06-01 Murray Cumming <murrayc@murrayc.com>
419 * src/maemo/easysetup/modest-easysetup-wizard.c:
420 (create_page_complete_easysetup):
421 (create_page_complete_custom): Correct the last commit,
422 putting the correct sentences in the correct pages.
424 2007-06-01 Murray Cumming <murrayc@murrayc.com>
426 * src/maemo/easysetup/modest-easysetup-wizard.c:
427 (create_page_complete_custom): Show the second sentence of text
428 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
431 2007-06-01 Murray Cumming <murrayc@murrayc.com>
433 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
434 Set the leave-on-server conf key by default. This fixes
435 projects.maemo.org bug NB#59258 .
437 2007-06-01 Murray Cumming <murrayc@murrayc.com>
439 * src/maemo/modest-account-view-window.c:
440 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
441 logical ID for the confirmation messages. Fixed projects.maemo.org bug
444 2007-06-01 Murray Cumming <murrayc@murrayc.com>
446 * src/maemo/easysetup/modest-easysetup-wizard.c:
447 (create_caption_new_with_asterisk):
448 * src/maemo/modest-account-settings-dialog.c:
449 (create_caption_new_with_asterisk):
450 Uncomment the code to add the asterisk, because they are no longer in the
451 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
452 (update_incoming_server_title): Add an asterisk here too.
454 2007-06-01 Murray Cumming <murrayc@murrayc.com>
456 * src/maemo/modest-maemo-global-settings-dialog.c:
457 (current_connection): Check that we are even connected before trying to
458 get the current connection name, to prevent a warning.
460 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
461 Change the comments because tny_maemo_conic_device_connect() is now meant to
463 * src/modest-mail-operation.c:
464 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
465 make sure we have a connection and fail if we can't connect.
467 2007-05-31 Murray Cumming <murrayc@murrayc.com>
469 * src/maemo/modest-main-window.c:
470 (on_account_store_connecting_finished): Do not try to get the
471 connection ID if we are not really connected. I am surprised that
472 this signal handler is called when we are not connected.
474 2007-05-31 Murray Cumming <murrayc@murrayc.com>
476 * src/modest-error.h:
477 * src/modest-ui-actions.c:
478 (modest_ui_actions_get_msgs_full_error_handler):
479 Renamed an enum, added comments, added an enum
480 for retrieve-limit errors.
482 * src/modest-mail-operation.c: (foreach_add_item),
483 (internal_folder_observer_update), (update_account_thread),
484 (modest_mail_operation_get_msgs_full):
485 (modest_mail_operation_update_account),
486 Added comments about how this works, and some code that should
487 (but does not) check the retrieve-limit. See the TODO comment.
489 2007-05-31 Murray Cumming <murrayc@murrayc.com>
491 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
492 Initialize help_id to fix the build. Warnings are good.
494 2007-05-31 Murray Cumming <murrayc@murrayc.com>
496 * src/widgets/modest-hbox-cell-renderer.c:
497 (modest_hbox_cell_renderer_append):
498 * src/widgets/modest-vbox-cell-renderer.c:
499 (modest_vbox_cell_renderer_append):
500 Fix the last commit by doing an extra ref.
502 2007-05-31 Murray Cumming <murrayc@murrayc.com>
504 * src/widgets/modest-hbox-cell-renderer.c:
505 (modest_hbox_cell_renderer_append):
506 * src/widgets/modest-vbox-cell-renderer.c:
507 (modest_vbox_cell_renderer_append):
508 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
509 to fix the build with Maemo Bora.
510 However, there seems to be a remaining crash, probably due to reference
513 2007-05-30 Murray Cumming <murrayc@murrayc.com>
515 * src/modest-tny-account.c:
516 (modest_tny_account_new_for_local_folders):
517 Use hildon_file_system_info_async_new() to get a better name for
518 the memory card account, setting it as the account name.
519 The timing seems to work, but this is probably
520 not the best place to do this. See the TODO comment.
521 * src/maemo/modest-main-window.c: (create_details_widget):
522 * src/widgets/modest-folder-view.c: (text_cell_data):
523 Use the tny account name instead of hardcoding a name.
525 2007-05-30 Christian Kellner <ckellner@openismus.com>
527 * src/modest-search.c: (modest_search):
528 Correctly set part_search_func even if we have already parsed
529 the query and thus a valid OgsTextSearcher object.
531 2007-05-30 Christian Kellner <ckellner@openismus.com>
534 Search and check for libogs.
537 Incooparte the ogs build env.
539 * src/modest-mime-part-search-stream.c:
540 * src/modest-mime-part-search-stream.h:
541 Removed since we do the real searching now in modest-search.c.
543 * src/modest-search.c:
544 * src/modest-search.h:
545 Implement support for ogs. We use that if available and requested
546 and fall back to modest_text_utils_utf8_strcmp (). The search logic
547 should now handle the corner case when the search term is spread
548 across multiple reads.
549 Also the logic in modest_search () was corrected to search all
550 requested fields until one is found.
552 2007-05-30 Murray Cumming <murrayc@murrayc.com>
554 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
557 * src/modest-init.c: Made modest_init_local_folders() take a
558 path and be public so we can iniitialize maildir folders on
561 * src/modest-local-folder-info.h:
562 * src/modest-local-folder-info.c:
563 (modest_local_folder_info_get_maildir_path): Add a path parameter.
565 * src/modest-tny-account.c:
566 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
567 still means the standard local-folders path on the local volume.
569 * src/modest-tny-account-store.c:
570 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
571 signal so we can detect mount/unmount of the MMC1 card, and do an update of
572 all accounts when that happens.
573 (get_server_accounts): If the MMC1 card is mounted, create a store account for
574 this too, so it shows up in the treeview.
576 2007-05-28 Murray Cumming <murrayc@murrayc.com>
578 * src/maemo/modest-maemo-global-settings-dialog.c:
579 (current_connection):
580 * src/widgets/modest-global-settings-dialog.c:
581 (current_connection_default):
582 Use the enum values instead of 0, 1 and -1,
583 to make the code clearer.
585 * src/modest-account-mgr-helpers.c:
586 (modest_account_mgr_get_connection_specific_smtp): Make this code
589 * src/modest-runtime.h:
590 * src/modest-runtime.c:
591 Added modest_runtime_remove_all_send_queues().
592 * src/maemo/modest-main-window.c:
593 (on_account_store_connecting_finished): Recreate the send queues,
594 using the appropriate transport accounts for this new connection.
595 Some futher adapting might be needed if the old send queues are not
596 automatically stopped at this point.
598 * src/modest-tny-account-store.c: (get_server_accounts):
599 Create the connection-specific transport accounts, so that they can
600 be found later by their ID.
602 * src/modest-tny-account.h:
603 * src/modest-tny-account.c:
604 Added modest_tny_account_new_from_server_account_name().
605 modest_tny_account_new_from_server_account(): Do not create the
606 send queues here, because they will be
607 recreated anyway when the connection changes for the first time.
609 2007-05-28 Murray Cumming <murrayc@murrayc.com>
611 * src/modest-local-folder-info.h:
612 * src/modest-local-folder-info.c:
613 (modest_per_account_local_outbox_folder_info_get_maildir_path),
614 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
615 tbox_folder): Take a modest account name instead of a server TnyAccount,
616 so we can have per-modest-account rather than per-transport-account
618 We must make sure that we change or recreate the exisitng send queues
619 when the connection changes for connection-specific transport accounts.
621 * src/modest-tny-account-store.c:
622 (create_per_account_local_outbox_folders): Create outboxed per modest
623 account, not per transport account.
625 * src/modest-tny-account.h:
626 * src/modest-tny-account.c:
627 (modest_tny_account_get_special_folder): For outboxes, get the
628 parent modest account name. The account is ignored for other folders.
629 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
630 modest account name rather than a server TnyAccount.
632 2007-05-25 Murray Cumming <murrayc@murrayc.com>
634 * src/modest-tny-account.c:
635 (modest_tny_account_new_from_server_account):
636 Call modest_runtime_get_send_queue() immediately after creating transport
637 accounts, so that they start trying to send email from the outbox as soon
638 as possible at startup. This is probably what we want.
640 * src/modest-mail-operation.c: (update_account_thread):
641 * src/modest-runtime.c: (modest_runtime_get_send_queue):
642 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
643 * src/modest-tny-send-queue.h:
644 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
645 (modest_ui_actions_on_send):
646 Added comments about how sending works, though it needs some more work.
648 2007-05-25 Murray Cumming <murrayc@murrayc.com>
650 * src/modest-tny-account.c:
651 (modest_tny_account_get_special_folder): Add TODO because this fails when
653 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
654 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
655 Do not try to show this window when there is no active account. The UI
656 specs does not tell us what to do in this case.
658 2007-05-24 Murray Cumming <murrayc@murrayc.com>
662 * src/maemo/Makefile.am:
663 * src/widgets/Makefile.am: Some dist fixes.
665 2007-05-24 Murray Cumming <murrayc@murrayc.com>
667 * src/maemo/modest-connection-specific-smtp-window.c:
668 (on_button_edit): Make the code clearer, to prevent a double free.
670 2007-05-24 Murray Cumming <murrayc@murrayc.com>
672 * src/maemo/modest-account-settings-dialog.c:
673 (modest_account_settings_dialog_set_account_name),
674 Check the connection-specific smtp servers checkbox if there are any.
676 * src/maemo/modest-connection-specific-smtp-edit-window.c:
677 (modest_connection_specific_smtp_edit_window_init):
678 Start with a suitable port number.
680 * src/modest-account-mgr-helpers.h:
681 * src/modest-account-mgr-helpers.c: Added
682 modest_account_mgr_get_has_connection_specific_smtp().
684 (modest_account_mgr_set_connection_specific_smtp),
685 (modest_account_mgr_remove_connection_specific_smtp),
686 (modest_account_mgr_get_has_connection_specific_smtp),
687 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
688 connection-specific smtp server accounts in the account, rather than
689 the server account conf dir.
691 This fixes bug projects.maemo.org bug NB#58263 .
693 * src/modest-tny-account-store.c:
694 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
695 if there are no server accounts yet, to prevent an infinite loop when there
696 are no accounts. Document that one must be called before the other.
698 2007-05-24 Murray Cumming <murrayc@murrayc.com>
700 * src/modest-account-mgr-helpers.c:
701 (modest_account_mgr_get_default_account): Make sure that at least
702 one account is always the default, if there are any enabled accounts.
703 This is just a sanity check that shouldn't be necessary.
705 * src/modest-account-mgr-priv.c:
706 (_modest_account_mgr_account_from_key): Unescape the conf key to
707 get the real account name. For instance, this is an issue if a space
708 was in the account name, which can happen because the account name
709 is generated from the display name.
710 (_modest_account_mgr_get_account_keyname): Always escape the
712 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
713 Unescape the conf keys to get the real account names.
715 For instance, previously the is-default radio button in the accounts
716 list was not checked for any accounts at first. This fixes that,
717 and might fix several similar bugs.
719 2007-05-23 Murray Cumming <murrayc@murrayc.com>
721 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
722 Removed some debug printfs.
724 2007-05-23 Murray Cumming <murrayc@murrayc.com>
726 Modest on-disk outbox directories are now here, for instance:
727 $HOME/.modest/outboxes/<account-id-1>/outbox
728 $HOME/.modest/outboxes/<account-id-2>/outbox
730 $HOME/.modest/local-folders/outbox
731 so we can have a separate outbox for each account.
732 But they are shown as one outbox in the GtkTreeView, by using a
733 TnyMergeFolder in a ModestTnySimpleFolderStore.
736 * src/modest-tny-simple-folder-store.c:
737 * src/modest-tny-simple-folder-store.h:
738 Added ModestTnySimpleFolderStore, used to contain folders from
739 other folder stores, such as other accounts.
741 * src/modest-tny-outbox-account.h:
742 * src/modest-tny-outbox-account.c:
743 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
744 used for the per-account local outbox folders.
746 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
747 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
748 only use this (internally) now for the non-outbox local folders.
751 * src/modest-init.c: Added modest_init_one_local_folder(), for
752 setting up the directory structure for each local folder.
754 * src/modest-local-folder-info.c:
755 (modest_per_account_local_outbox_folder_info_get_maildir_path),
756 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
758 * src/modest-local-folder-info.h:
759 * src/modest-tny-account-store.c: (on_account_removed),
760 (on_account_changed), (create_per_account_local_outbox_folders),
761 (get_server_accounts), (modest_tny_account_store_get_accounts),
762 (modest_tny_account_store_get_tny_account_by_account),
763 (modest_tny_folder_store_is_virtual_local_folders):
765 * src/modest-tny-account.h:
766 * src/modest-tny-account.c:
767 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
768 to create an on-disk per-account local outbox folder for each
770 (create_per_account_local_outbox_folders): Create a local outbox folder
771 for each transport account.
772 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
773 for all local folders.
775 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
776 instead of using g_object_get/set() directly. It is clearer.
778 (modest_tny_folder_store_get_message_count),
779 (modest_tny_folder_store_get_local_size
780 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
781 because we now use these with non-acount folder stores.
783 (modest_tny_account_get_special_folder),
784 (modest_tny_account_new_from_server_account),
785 (modest_tny_account_new_from_account):
786 (recurse_folders): Adjust to the new outbox system.
788 * src/modest-tny-folder.h:
789 * src/modest-tny-folder.c:
790 (modest_tny_folder_is_local_folder),
791 (modest_tny_folder_get_local_folder_type),
792 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
794 * src/widgets/modest-main-window.h:
795 * src/maemo/modest-main-window.c: (create_details_widget),
796 (modest_main_window_set_contents_style): Show details for any folder store,
799 (modest_tny_folder_get_rules):
800 Remove the const. C does not support constness enough for this.
802 * src/modest-ui-actions.c:
803 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
804 make all outboxes appear as one, in the usual local-folders tree node.
806 (set_active_account_from_tny_account),
807 (modest_ui_actions_on_folder_selection_changed):
808 * src/widgets/modest-folder-view.c: (text_cell_data),
809 (icon_cell_data), (filter_row),
810 (add_account_folders_to_merged_folder),
811 (add_account_folders_to_simple_folder_store), (),
812 (get_cmp_rows_type_pos), (cmp_rows),
813 (modest_folder_view_set_account_id_of_visible_server_account):
814 Adjust to the new outbox system, using generic folder stores and folders
817 2007-05-23 Christian Kellner <ckellner@openismus.com>
819 * src/modest-mail-operation.c:
820 (modest_mail_operation_update_account):
821 Use info->max_size instead of unintialized local var [small
822 build fix]. (Added TODO to review that change since I don't
825 2007-05-23 Marcus Bauer <marcusb@openismus.com>
827 * libmodest-dbus-client/libmodest-dbus-client.c:
828 (libmodest_dbus_client_compose_mail): function added
829 * src/dbus_api/modest-dbus-api.h:
830 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
831 (on_compose_mail): Implementation of the SendAsMail functionality
833 2007-05-22 Murray Cumming <murrayc@murrayc.com>
835 * src/modest-account-mgr.c:
836 (modest_account_mgr_add_server_account): Set the secure-connection
837 conf key for transport accounts as well as store accounts. I don't know
838 why the if was there. For instance, this makes sure that we use SSL
839 for the gmail preset from the easysetup wizard.
841 2007-05-22 Murray Cumming <murrayc@murrayc.com>
843 * src/gnome/modest-main-window.c:
844 (on_account_store_connecting_finished), (connect_signals):
845 * src/maemo/modest-main-window.c:
846 (on_account_store_connecting_finished), (connect_signals),
847 (modest_main_window_new):
848 Handle TnyAccountStore::connecting-finished instead of
849 TnyDevice::connection-changed, because we cannot actually perform
850 operations on accounts until TnyAccountStore has itself responded to
851 the TnyDevice::connection-changed signal. This prevents a GError from
853 Do not try to update at startup, because we (at least on scratchbox)
854 already do an update at startup when the device goes online.
855 This prevents a GError from tinymail.
856 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
857 Added TODO about stopping simultaneous operations.
859 2007-05-21 Murray Cumming <murrayc@murrayc.com>
861 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
862 * src/modest-mail-operation-queue.c:
863 (modest_mail_operation_queue_remove):
864 * src/modest-tny-account-store.c: When GErrors happen, give more clues
865 about where they happened.
867 2007-05-21 Murray Cumming <murrayc@murrayc.com>
869 * src/modest-ui-actions.c:
870 (modest_ui_actions_on_password_requested): Make sure that the remember
871 output parameter is always TRUE.
873 2007-05-21 Murray Cumming <murrayc@murrayc.com>
875 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
876 Show a OK/Cancel dialog if the error is a question, though we still do not
877 know anything more about what we are asking the user.
878 * src/widgets/modest-folder-view.c: (on_drag_data_received):
879 Fix an uninitialized variable (helper). This is a logic error, however.
881 2007-05-21 Christian Kellner <ckellner@openismus.com>
883 * src/modest-search.h:
884 Correct bit shifting in the ModestSearchFlags enum.
886 2007-05-21 Murray Cumming <murrayc@murrayc.com>
888 * src/modest-tny-account.c:
889 (modest_tny_account_new_from_server_account): Do not use the lsub and
890 check-all hard-coded IMAP options when using POP.
892 2007-05-21 Murray Cumming <murrayc@murrayc.com>
894 * src/modest-tny-account.c:
895 (modest_tny_account_new_from_server_account):
896 Use NULL for the secure-auth method for POP when Password auth has been
897 specified by the user, as we already do for IMAP. "auth=Login" causes
898 an error from camel or the server.
900 2007-05-17 Murray Cumming <murrayc@murrayc.com>
902 * src/maemo/modest-account-settings-dialog.c:
903 (create_page_account_details),
904 (modest_account_settings_dialog_set_account_name):
905 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
906 for the leave-on-server checkbox, rathr than just the checkbox, when
907 the protocol is not POP.
909 2007-05-17 Murray Cumming <murrayc@murrayc.com>
911 * src/widgets/modest-account-view.c:
912 * src/widgets/modest-account-view.h:
913 Added modest_account_view_select_account() which will be useful later
914 to asynchronously re-select the edited account.
916 2007-05-17 Murray Cumming <murrayc@murrayc.com>
918 * src/maemo/modest-account-settings-dialog.c:
919 (modest_account_settings_dialog_set_account_name):
920 Automatically choose the port numbers based on the secure authentication
921 methods, if they have not been chosen before.
922 This fixes projects.maemo.org bug NB#56273 .
924 2007-05-17 Murray Cumming <murrayc@murrayc.com>
926 * src/maemo/modest-main-window-ui.h:
927 * src/modest-ui-actions.c:
928 * src/modest-ui-actions.h:
929 Connect the Tools/SMTP Servers menu item to
930 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
931 SMTP servers dialog, as in the UI specification and saves changes when it
932 is closed. This fixed projects.maemo.org bug NB#56305 .
934 2007-05-17 Murray Cumming <murrayc@murrayc.com>
936 * src/maemo/modest-connection-specific-smtp-window.c:
937 (modest_connection_specific_smtp_window_init):
938 Use gtk_window_set_default_size() to make this window big enough, so
939 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
941 2007-05-17 Murray Cumming <murrayc@murrayc.com>
943 * src/maemo/modest-connection-specific-smtp-edit-window.h:
944 * src/maemo/modest-connection-specific-smtp-edit-window.c:
945 (modest_connection_specific_smtp_edit_window_init),
946 Do not try to connect to a combobox signal before the combobox exists.
947 This fixes the cras in projects.maemo.org bug NB#56288 .
948 (modest_connection_specific_smtp_edit_window_get_settings):
949 Remove the server_account_name parameter which was being checked for NULL
950 though it was not used.
952 * src/maemo/modest-connection-specific-smtp-window.c:
953 (modest_connection_specific_smtp_window_fill_with_connections),
954 (on_button_edit), (modest_connection_specific_smtp_window_init):
955 Correct the number of treemodel columns to prevent a warning.
956 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
957 libconic does not work.
959 2007-05-16 Murray Cumming <murrayc@murrayc.com>
961 * src/modest-tny-account.c:
962 (modest_tny_account_new_from_server_account):
963 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
964 SMTP when "None" was chosen by the user. However, with my SMTP server that
965 does not support ANONYMOUS, the emails do not leave the Outbox and I see
968 2007-05-16 Murray Cumming <murrayc@murrayc.com>
970 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
971 to explain the memory management issue with the ID in the ModestPair.
973 * src/gnome/modest-account-assistant.c: (add_receiving_page),
974 (add_sending_page), (modest_account_assistant_finalize):
975 * src/gnome/modest-gnome-global-settings-dialog.c:
976 (create_updating_page), (create_composing_page):
977 * src/gnome/modest-msg-edit-window.c: (get_transports),
978 (init_window), (modest_msg_edit_window_finalize),
979 (modest_msg_edit_window_get_msg_data):
980 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
981 * src/gnome/modest-transport-widget.c:
982 (modest_transport_widget_finalize), (smtp_configuration):
983 * src/maemo/modest-maemo-global-settings-dialog.c:
984 (create_updating_page), (create_composing_page):
985 * src/maemo/modest-msg-edit-window.c: (get_transports),
986 (init_window), (modest_msg_edit_window_finalize),
987 (modest_msg_edit_window_get_msg_data),
988 (modest_msg_edit_window_free_msg_data):
989 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
990 (modest_store_widget_finalize):
991 * src/maemo/modest-transport-widget.c:
992 (modest_transport_widget_finalize), (smtp_configuration):
993 * src/modest-main.c: (send_mail):
994 * src/widgets/modest-combo-box.h:
995 * src/widgets/modest-global-settings-dialog-priv.h:
996 * src/widgets/modest-global-settings-dialog.c:
997 (modest_global_settings_dialog_finalize):
998 * src/widgets/modest-msg-edit-window.h:
999 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1000 as long as the combo box, to prevent use of freed memory for the ID.
1002 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1004 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1005 get_accounts(), to make this clearer. Do not check for the enabled gconf
1006 key, because we do not use this for server accounts (at least, not yet).
1007 This allows us to send email again.
1009 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1011 * src/maemo/modest-platform.c:
1012 (on_modest_conf_update_interval_changed), (modest_platform_init):
1013 Only respond to this particular key change. All these strcmp()s cannot be
1016 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1018 * src/maemo/modest-maemo-global-settings-dialog.c:
1019 (current_connection): Prevent a crash in scratchbox when
1020 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1021 * src/maemo/modest-platform.c:
1022 (on_modest_conf_update_interval_changed), (modest_platform_init):
1023 Get the update interval from gconf and reset it when the gconf key changes.
1025 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1027 * src/modest-protocol-info.c:
1028 * src/modest-protocol-info.h: Adde enum-specific get functions,
1029 instead of using a ModestProtocolType enum parameter.
1031 * src/gnome/modest-account-assistant.c:
1032 * src/gnome/modest-store-widget.c:
1033 * src/gnome/modest-store-widget.h:
1034 * src/gnome/modest-transport-widget.c:
1035 * src/gnome/modest-transport-widget.h:
1036 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1037 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1038 * src/maemo/easysetup/modest-easysetup-wizard.c:
1039 * src/maemo/modest-account-settings-dialog.c:
1040 * src/maemo/modest-account-settings-dialog.h:
1041 * src/maemo/modest-store-widget.c:
1042 * src/maemo/modest-store-widget.h:
1043 * src/maemo/modest-transport-widget.c:
1044 * src/maemo/modest-transport-widget.h:
1045 * src/modest-account-mgr-helpers.c:
1046 * src/modest-account-mgr-helpers.h:
1047 * src/modest-account-mgr.c:
1048 * src/modest-account-mgr.h:
1049 * src/modest-tny-account.c:
1050 * src/modest-tny-folder.c:
1051 * src/widgets/modest-account-view.c:
1052 * src/widgets/modest-retrieve-combo-box.c:
1053 * src/widgets/modest-retrieve-combo-box.h:
1054 * src/widgets/modest-secureauth-combo-box.c:
1055 * src/widgets/modest-serversecurity-combo-box.c:
1056 * src/widgets/modest-serversecurity-combo-box.h:
1057 * tests/check_account-mgr.c:
1058 Use the specific functions, and use the re-renamed enum values for GNOME too.
1060 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1062 * src/modest-pair.h:
1063 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1064 so we can get the second based on the first.
1066 * src/maemo/modest-account-settings-dialog.h:
1067 * src/maemo/modest-account-settings-dialog.c:
1068 Added get_supported_secure_authentication_methods(), though it is mostly
1069 commented-out for now until the necessary API is committed to tinymail.
1070 (modest_account_settings_dialog_set_account_name),
1071 (save_configuration): Request the supported authentication methods from the
1072 server, so we can choose a working method.
1074 * src/modest-tny-account-store.h:
1075 * src/modest-tny-account-store.c:
1076 (modest_tny_account_store_get_session): Rename from
1077 tny_account_store_get_session().
1079 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1081 * src/modest-protocol-info.h: Split the ModestProtocol enum
1082 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1083 There was no need to have these unrelated values in one enum.
1085 * src/: many files: Adapted to changed enum. This makes the code a bit
1086 clearer, and the compiler could catch some errors.
1088 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1090 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1091 Show the detailed internal camel error message when an error happens
1092 during the configuration, so that our testers can give us more clues.
1093 For instance, in projects.maemo.org bug NB#56910 .
1095 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1097 * src/modest-tny-account.c:
1098 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1099 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1101 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1103 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1104 * src/maemo/modest-account-settings-dialog.c:
1105 (modest_account_settings_dialog_set_account_name),
1106 (save_configuration): For the incoming secure authentication checkbox,
1107 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1108 the UI specification. PLAIN does not seem to be supported for most IMAP
1109 servers anyway, and I am not sure what it would mean.
1110 However, we probably need to discover which of the secure-authentication
1111 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1112 * src/modest-account-mgr-helpers.c:
1113 (modest_account_mgr_get_server_account_data):
1115 * src/modest-tny-account.c:
1116 (modest_tny_account_new_from_server_account):
1117 Use tny_account_set_mech() to set secure-authentication methods,
1118 with some special-casing for IMAP, based on my observations of how
1121 * src/modest-account-mgr-helpers.h:
1122 * src/modest-account-mgr.c:
1123 * src/modest-defs.h: Comment that the URI is only used for local folders.
1125 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1127 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1128 parameter const, just to be neat.
1129 * src/modest-text-utils.c: (modest_text_utils_inline):
1130 End g_strconcat() with NULL, as its documentation says. This is almost
1131 certainly the cause of my crash at startup on the device. Interestingly,
1132 valgrind doesn't tell us about these errors.
1134 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1136 * scripts/build-packages: Added more precise comments about how to use
1137 this script, though I still get this error:
1138 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1139 error building tinymail
1141 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1143 * src/maemo/modest-main-window.c: (on_account_update):
1144 Very slight cleanup, hoping to make it simpler to discover what causes
1145 a crash here sometimes.
1147 * src/modest-tny-account.c:
1148 (modest_tny_account_new_from_server_account): Set the port. Added
1149 comments about the options and a TODO comment because I need to find out
1150 how to specify the secure authentication method.
1152 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1154 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1155 changed CFlags paths form modest to libmodest
1157 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1159 * src/modest-account-mgr-helpers.c:
1160 (modest_account_mgr_get_server_account_data),
1161 (modest_account_mgr_free_server_account_data):
1162 * src/modest-account-mgr-helpers.h:
1163 * src/modest-account-mgr.c:
1164 (modest_account_mgr_add_server_account):
1165 * src/modest-defs.h:
1166 * src/modest-tny-account.c:
1167 (modest_tny_account_new_from_server_account):
1168 Determine the options for tny_camel_account_add_option() here,
1169 based on the settings, rather than storing them directly in gconf.
1171 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1173 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1174 Show a more friendly error dialog now that we expect (from the tinymail
1175 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1177 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1179 * src/maemo/modest-main-window.c: (on_account_update): Check that
1180 account_name is not NULL, to prevent a crash at startup that I am
1181 seeing on the N800. I do wonder why it is NULL.
1183 * src/maemo/easysetup/modest-easysetup-wizard.c:
1184 (create_page_user_details):
1185 * src/maemo/modest-account-settings-dialog.c:
1186 (create_page_user_details), (create_page_outgoing):
1187 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1188 (modest_connection_specific_smtp_edit_window_init):
1189 * src/modest-ui-actions.c:
1190 (modest_ui_actions_on_password_requested):
1191 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1192 might do something useful with the on-screen keyboard.
1194 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1196 * src/maemo/modest-main-window.c: (on_account_update):
1197 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1198 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1200 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1202 * src/modest-tny-account-store.c: (on_account_changed):
1203 Correct the signature of this signal handler.
1205 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1207 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1208 Show a HildonNote instead of a GtkDialog for Maemo.
1210 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1212 * src/widgets/modest-account-view.h:
1213 * src/widgets/modest-account-view.c: (on_account_changed),
1214 (on_account_removed). Added a boolean flag, set/unset by
1215 modest_account_view_block_conf_updates(),
1216 modest_account_view_unblock_conf_updates() to prevent unnecessary
1217 updates, but this is not very useful because the gconf notifications are
1218 so delays (maybe only on Maemo Bora).
1219 So auto-updating is turned off, and these functions do an explicit
1220 update when necessary.
1221 However, something else is still doing too much work when adding/removing
1222 accounts, probably in another part of the application.
1224 * src/maemo/modest-account-view-window.c:
1225 (on_delete_button_clicked), (on_edit_button_clicked),
1226 (on_new_button_clicked): Use the new functions.
1228 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1230 * src/modest-account-mgr-helpers.c:
1231 (modest_account_mgr_set_first_account_as_default):
1232 Sort the list of names alphabetically-by-title, so we choose the first one
1234 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1235 alphabetically by the title.
1237 This fixes projects.maemo.org bug NB#56418 .
1239 * src/modest-account-mgr-priv.c:
1240 (_modest_account_mgr_account_from_key):
1241 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1242 avoid a valgrind error, and possible random behaviour.
1244 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1246 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1247 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1248 tinymail documentation to say that this can be expected.
1249 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1250 pretty, and should not happen, but I would prefer to know when it does.
1252 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1254 * configure.ac: When using the older hildon version, probably on Bora,
1255 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1257 * src/widgets/modest-attachment-view.c:
1258 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1261 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1263 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1264 Implemented the prototype. Can be tested with
1265 tests/dbus_api/test_open_message:
1267 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1269 * src/modest-tny-account-store.c:
1270 (modest_tny_account_store_instance_init), (get_password):
1271 * src/modest-ui-actions.c:
1272 (modest_ui_actions_on_password_requested):
1273 Do not store the password in gconf, because this function is called
1274 for non-remembered passwords. Actually use the cached (in the hash map)
1275 password instead of releasing it.
1276 The password will now not be remembered if it is asked via the protected
1277 password dialog, as per the UI spec.
1279 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1281 * src/modest-defs.h:
1282 * src/modest-account-mgr-helpers.h:
1283 * src/modest-account-mgr-helpers.c:
1284 Added modest_server_account_get_username_has_succeeded(),
1285 modest_server_account_set_username_has_succeeded().
1286 (modest_server_account_set_username),
1287 Reset the has-succeeded flag if the username changes.
1289 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1290 * src/maemo/modest-connection-specific-smtp-window.c:
1291 (modest_connection_specific_smtp_window_save_server_accounts):
1292 Use modest_server_account_set_username() instead of using
1293 modest_conf_set_string() directly, so that the has-succeeded flag is always
1296 * src/modest-ui-actions.c:
1297 (modest_ui_actions_on_password_requested): Dim the username entry if
1298 the username has ever worked, as per the UI spec.
1300 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1302 * src/modest-tny-account-store.c: (get_password):
1303 * src/modest-ui-actions.c:
1304 (modest_ui_actions_on_password_requested):
1305 Allow the username to be changed too, though there is more work to
1306 be done on exactly how this behaves.
1308 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1310 * src/modest-account-mgr-helpers.h:
1311 * src/modest-account-mgr-helpers.c:
1312 Added modest_account_mgr_get_display_name(),
1313 modest_server_account_get_username(),
1314 modest_server_account_set_username(),
1315 modest_server_account_set_password(),
1316 modest_server_account_get_hostname() functions so we do not need to
1317 use the conf API directly.
1319 * src/maemo/modest-main-window.c: (connect_signals):
1320 Actually connect ot the ModestAccountStore::request-password signal,
1321 so that we show the dialog when the password is requested by Tinymail,
1322 for isntance if it is empty.
1324 * src/modest-marshal.list:
1325 * src/modest-tny-account-store.c:
1326 (modest_tny_account_store_class_init), (get_password),
1327 (modest_tny_account_store_alert):
1328 * src/modest-tny-account-store.h:
1329 * src/modest-ui-actions.h:
1330 * src/modest-ui-actions.c:
1331 (modest_ui_actions_on_password_requested):
1332 Change the signal parameters, so it is obvious that we are providing
1333 the non human-readable server name, and receiving both the username
1334 and password, though changing of the username is not yet implemented.
1335 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1336 for the GNOME version.
1338 This should fix the projects.maemo.org bug NB#56209, though it does not
1339 work on Bora, because the gconf_client_get() for the password fails
1340 immediately after we save it with gconf_client_set().
1342 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1345 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1346 caused an undefined symbol error:
1347 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1349 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1351 * src/modest-tny-account-store.c:
1352 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1353 using a GError instead of a string message, so we can translate it in
1356 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1358 * src/maemo/modest-address-book.c:
1359 (modest_address_book_check_names):
1360 * src/maemo/modest-msg-view-window.c:
1361 (modest_msg_view_window_clipboard_owner_change):
1362 * src/modest-init.c: (modest_init_init_ui):
1363 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1364 (update_folders_cb), (modest_mail_operation_update_account):
1365 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1366 (modest_ui_actions_on_msg_attachment_clicked),
1367 (modest_ui_actions_on_msg_recpt_activated):
1368 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1369 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1370 (modest_msg_view_search_next):
1371 * src/widgets/modest-recpt-editor.c:
1372 (modest_recpt_editor_on_button_release_event),
1373 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1374 g_message(). At this point we should only be seeing interesting errors on
1375 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1377 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1379 (modest_wizard_dialog_force_title_update):
1380 * src/maemo/easysetup/modest-wizard-dialog.h:
1381 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1382 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1383 can update the title when appropriate. Otherwise the title is wrong if the
1384 pages are added after adding the notebook to the dialog.
1385 This must be a problem in HildonWizardDialog too.
1386 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1388 * src/maemo/easysetup/modest-easysetup-wizard.c:
1389 (create_subsequent_customsetup_pages),
1390 (create_subsequent_easysetup_pages):
1391 Call modest_wizard_dialog_force_title_update() so that the title is
1392 correct even with GTK+ < 2.10.
1393 This fixes projects.maemo.org bug NB#56145 .
1395 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1397 * src/maemo/modest-platform.c:
1398 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1399 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1402 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1404 * src/widgets/modest-window.h:
1405 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1406 and modest_window_save_state(), which invokes it.
1408 * src/widgets/modest-window-mgr.h:
1409 * src/widgets/modest-window-mgr.c:
1410 Added modest_window_mgr_save_state_for_all_windows(), which calls
1411 the save_state vfunc on all registered windows, if implemented.
1413 * src/gnome/modest-msg-edit-window.c:
1414 * src/gnome/modest-msg-view-window.c:
1415 * src/maemo/modest-msg-edit-window.c:
1416 * src/maemo/modest-msg-view-window.c:
1417 * src/maemo/modest-main-window.c:
1418 Specify the existing save_settings functions as implementations of
1419 ModestWindow::save_state_func().
1421 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1422 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1423 enabling hibernation, for instance.
1425 We may need to do the same thing for restoring settings.
1428 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1430 * src/widgets/modest-window-mgr.c:
1431 * src/widgets/modest-window-mgr.h:
1432 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1433 modest_window_mgr_get_hibernation_is_prevented().
1435 * src/maemo/modest-main-window.c:
1436 (on_hildon_program_is_topmost_notify): Prevent hibernation
1437 (possible when the application goes to the background in the WM),
1438 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1440 * src/maemo/easysetup/modest-easysetup-wizard.c:
1441 (modest_easysetup_wizard_dialog_init):
1442 * src/maemo/modest-account-settings-dialog.c:
1443 (modest_account_settings_dialog_init):
1444 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1445 (modest_connection_specific_smtp_edit_window_init):
1446 * src/maemo/modest-connection-specific-smtp-window.c:
1447 (modest_connection_specific_smtp_window_init):
1448 * src/maemo/modest-signature-editor-dialog.c:
1449 (modest_signature_editor_dialog_init):
1450 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1451 prevent hibernation while any of these account settings dialogs are open.
1453 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1455 * src/maemo/Makefile.am:
1456 * src/maemo/modest-osso-state-saving.c:
1457 * src/maemo/modest-osso-state-saving.h: Added
1458 modest_osso_load_state() and modest_osso_save_state() though they do
1459 nothing now. They should iterate through all the open windows and load/save
1461 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1462 save state when closing.
1464 * src/maemo/modest-main-window.c:
1465 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1466 Add a notification handler for the HildonProgram::is-topmost property,
1467 so we can allow hibernation when the application goes into the background.
1468 But we still need to detect when the accounts setup windows are open so
1469 we can stop hibernation when they are open.
1470 To do this, I also added the main window the HildonProgram. This might have
1471 other side-effects/benefits, and should maybe be done for other windows.
1473 * src/maemo/modest-osso-autosave-callbacks.h:
1474 * src/maemo/modest-osso-autosave-callbacks.c:
1475 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1476 though it does not do anything yet, and we might never need this to do
1477 anything. For instance, we already save drafts.
1479 * src/maemo/modest-platform.c: (modest_platform_init):
1480 Specify the libosso auto-save callback.
1482 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1484 * src/maemo/modest-platform.c:
1485 (modest_platform_set_update_interval):
1486 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1487 aparently stays valid between application instances, so we can use this
1488 to remove and reset it later. According to a maemo-developers email from
1491 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1493 * configure.ac: Depend on libalarm for Maemo.
1495 * src/dbus_api/modest-dbus-api.h:
1496 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1497 (on_send_receive), (modest_dbus_req_handler):
1498 Handle a SEND_RECEIVE D-Bus method.
1500 * libmodest-dbus-client/libmodest-dbus-client.c:
1501 (libmodest_dbus_client_send_and_receive):
1502 * libmodest-dbus-client/libmodest-dbus-client.h:
1503 Add C convenience functions for calling the new D-Bus method.
1505 * src/modest-platform.h:
1506 * src/gnome/modest-platform.c:
1507 * src/maemo/modest-platform.c:
1508 Added modest_platform_set_update_interval(), which uses the
1509 alarmd API on Maemo.
1510 (modest_platform_init),
1511 Call modest_platform_set_update_interval(), using a hard-coded
1512 interval for now (until the global settings dialog is implemented),
1513 though I am not sure that this makes sense yet.
1515 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1517 * src/dbus_api/modest-dbus-callbacks.c:
1518 (modest_osso_cb_hw_state_handler):
1519 * src/dbus_api/modest-dbus-callbacks.h:
1520 * src/maemo/modest-platform.c: (modest_platform_init):
1521 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1522 in case this has some effect on the ability for Maemo to ping the
1525 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1527 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1528 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1529 warning. It is probably a logic error, but I need to fix the build.
1531 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1533 * src/modest-account-mgr.h:
1534 * src/modest-account-mgr.c:
1535 (modest_account_mgr_account_names): Add a gboolean enabled_only
1536 parameter, so we can get lists of onlt the enabled accounts.
1538 (modest_account_mgr_add_account),,
1539 (modest_account_mgr_account_with_display_name_exists):
1540 * src/maemo/modest-msg-edit-window.c: (get_transports):
1541 * src/modest-account-mgr-helpers.c:
1542 (modest_account_mgr_set_first_account_as_default):
1543 * src/modest-init.c: (init_default_account_maybe):
1544 * src/modest-tny-account-store.c: (get_accounts):
1545 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1546 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1547 * tests/check_account-mgr.c: (START_TEST):
1548 Provide the extra parameter, as appropriate.
1550 * src/widgets/modest-account-view.c: (update_account_view):
1551 Do not show disabled accounts (meaning that there is no way to
1552 enable/disable accounts in the UI (the feature is not in our UI
1553 specification), so we can use this internally only to mark unfinished
1554 or temporary account data.
1556 * src/maemo/easysetup/modest-easysetup-wizard.c:
1557 (create_account): Add boolean enable parameter, so we can specify FALSE
1558 to create the temporary account.
1559 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1560 (on_before_next): When finishing, when there is a temporary account, just
1562 Also, use a timeout to delay the showing of the dialog until gconf is likely
1563 to return correct information, due to a maemo gconf bug that is fixed in
1564 osso 1.1, but not yet in Bora.
1565 However, the dialog stays on screen after it is destroyed.
1567 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1568 for invalid data when cancelling. Use a hildon note instead of a dialog
1569 to complain about invalid data. Do not show the account-saved note if the
1570 account is disabled (a temporary account that will not really be saved for use
1573 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1575 * src/modest-account-mgr-helpers.h:
1576 * src/modest-account-mgr-helpers.c:
1577 Added modest_account_mgr_unset_default_account(),
1578 Added modest_account_mgr_set_first_account_as_default().
1580 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1581 If it was the default account, unset the default account name.
1583 * src/maemo/modest-account-view-window.c:
1584 (on_delete_button_clicked): If it was the default account,
1585 set the first remaining account as the default instead.
1587 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1588 a NULL account or a NULL default account, to prevent a crash. This should
1589 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1592 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1594 * src/widgets/modest-recpt-editor.c:
1595 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1596 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1597 TODO comment for this. This fixes the build.
1599 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1600 be the best place for it. This will in future update all auto-update accounts,
1601 rather than just the current/default account, when that gconf key exists.
1602 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1603 if there are no accounts, before calling do_send_receive().
1604 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1606 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1607 * src/maemo/modest-main-window-ui.h:
1608 * src/maemo/modest-main-window.c: (on_connection_changed),
1609 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1610 directly, becaue the signal handler does more.
1612 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1614 * src/modest-account-mgr-helpers.c:
1615 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1616 for the case that the account does not exist.
1618 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1619 (equivalent to the modest account name) rather than the tinymail account name
1620 (equivalent to the modest account title - human readable) to get the account data.
1621 Check for null account data to prevent the crash, and add a TODO comment saying that
1622 this needs fixing because it is using the server account name instead of the account name.
1624 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1626 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1627 * src/maemo/modest-account-settings-dialog.c: (show_error),
1629 Use hildon_note_new_information() for informative and error messages,
1630 which seems to be expected for Maemo applications (no documentation that I know of
1631 says this). I am surprised that there is no distinction between info and error
1634 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1636 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1637 it is easy to find where this is used.
1639 * src/maemo/easysetup/modest-easysetup-wizard.c:
1640 (create_page_welcome), (create_page_account_details),
1641 (create_page_user_details), (create_page_complete_easysetup),
1642 (create_page_custom_incoming), (create_page_custom_outgoing),
1643 (create_page_complete_custom):
1644 * src/maemo/modest-account-settings-dialog.c:
1645 (create_page_account_details), (create_page_user_details),
1646 (create_page_incoming), (create_page_outgoing):
1647 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1648 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1649 (modest_connection_specific_smtp_edit_window_init):
1650 * src/maemo/modest-connection-specific-smtp-window.c:
1651 (modest_connection_specific_smtp_window_init):
1652 * src/maemo/modest-signature-editor-dialog.c:
1653 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1654 and scrolling policy as per the Email Application Layout Guide, if I have
1657 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1659 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1660 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1661 which were empty, because these vfuncs have been removed from TnyAccountStore.
1662 This fixes the build.
1664 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1666 * src/maemo/modest-main-window.c:
1667 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1668 showing/hiding it. Added TODO because it probably should not be NULL.
1669 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1670 because unnecessary g_warnings() make degugging difficult.
1672 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1674 * src/maemo/modest-msg-edit-window.c:
1675 (modest_msg_edit_window_select_color),
1676 (modest_msg_edit_window_select_background_color): 2 const corrections and
1677 moving 2 #endifs before closing brackets, to fix the build.
1679 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1681 * src/maemo/easysetup/modest-easysetup-wizard.h:
1682 * src/maemo/easysetup/modest-easysetup-wizard.c:
1683 (modest_easysetup_wizard_dialog_finalize),
1684 (on_button_edit_advanced_settings), (create_page_complete_custom),
1685 (on_response), (create_account):
1686 Implement the Advanced Settings edit button, by saving the account information,
1687 for the Advanded Settings dialog to use directly from gconf, and removing it
1688 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1689 Bug #5533 in the projects.maemo.org bugzilla.
1691 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1693 * src/maemo/modest-msg-view-window.c:
1694 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1695 when opening a message window.
1697 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1699 * src/maemo/easysetup/modest-easysetup-wizard.c:
1700 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1703 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1704 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1705 gconf settings. I probably added more checks than necessary, but that is safer.
1707 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1708 variable to fix the build, but this seems to be used when it is still NULL.
1710 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1712 * src/modest-platform.h:
1713 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1714 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1715 * src/modest-main.c: Implement this function so we can avoid using
1716 maemo-specific API from cross-platform code.
1718 * src/modest-tny-account-store.c:
1719 (get_smtp_specific_transport_account_for_open_connection):
1720 * src/modest-ui-actions.c: (check_for_connection),
1721 (modest_ui_actions_on_item_not_found):
1722 Use modest_platform_connect_and_wait() and put #idefs around other
1723 maemo-specific code, because only maemo currently has a way to
1724 identify connection names.
1726 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1728 * src/modest-tny-account-store.h:
1729 * src/modest-tny-account-store.c:
1730 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1731 the connection-specific SMTP server settings in the configuration.
1733 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1735 * src/maemo/modest-main-window.c: (on_connection_changed),
1737 * src/modest-main.c: (main), (start_ui), (send_mail):
1738 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1739 that is what is intended.
1741 * src/modest-ui-actions.c: (action_send), (action_receive),
1742 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1743 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1744 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1745 SMTP server is used when it is specified.
1747 (modest_ui_actions_on_send_receive):
1748 Check that a connection is open before proceeding.
1749 Receive and then send, instead of vice-versa, as per the specification.
1751 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1753 * src/modest-mail-operation.c:
1754 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1755 though I guess it should be something other than NULL.
1757 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1759 * src/maemo/easysetup/modest-easysetup-wizard.c:
1760 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1761 combo twice, to avoid an g_warning and to make it visible again.
1762 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1763 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1764 (already intended) dereference when detaching, because we then recreate the menu.
1765 But I am not sure why the warning was happening, and it is possible that this is a memory
1768 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1770 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1771 and uri_parse_mailto() utility functions.
1772 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1774 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1776 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1778 * src/dbus_api/modest-dbus-api.h:
1779 * src/dbus_api/modest-dbus-callbacks.c:
1780 Use an idle callback to execute the modest code in the application's own thread.
1781 Remove the helloworld example method.
1782 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1783 parsed, and the open-message method is not implemented because this is not yet implemented in
1785 * libmodest-dbus-client/libmodest-dbus-client.c:
1786 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1787 (libmodest_dbus_client_open_message):
1788 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1790 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1791 body without crashing.
1793 * tests/dbus_api/Makefile.am:
1794 * tests/dbus_api/test_mail_to.c:
1795 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1797 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1799 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1800 Added file to fix the build. Sorry.
1802 * src/dbus_api/Makefile.am:
1803 * src/dbus_api/modest-dbus-api.h:
1804 * src/dbus_api/modest-dbus-callbacks.h:
1805 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1806 (modest_dbus_req_handler):
1807 Put constants in a separate header so it can be reused by the
1808 client library, without duplication
1810 * libmodest-dbus-client/Makefile.am:
1811 * libmodest-dbus-client/libmodest-dbus-client.c:
1812 (libmodest_dbus_client_call_helloworld),
1813 (libmodfest_dbus_client_send_mail),
1814 (libmodfest_dbus_client_mailto),
1815 (libmodfest_dbus_client_open_message):
1816 * libmodest-dbus-client/libmodest-dbus-client.h:
1817 (Partly) Implement a send_mail D-Bus method.
1819 * tests/dbus_api/Makefile.am:
1820 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1821 the send_email D-Bus method.
1823 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1827 * libmodest-dbus-client/Makefile.am:
1828 * libmodest-dbus-client/libmodest-dbus-client.c:
1829 * libmodest-dbus-client/libmodest-dbus-client.h:
1830 * tests/dbus_api/Makefile.am:
1831 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1832 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1834 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1836 * src/maemo/easysetup/modest-easysetup-wizard.c:
1837 (create_page_account_details):
1838 * src/maemo/modest-account-settings-dialog.c:
1839 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1840 widgets, because this might not be the default in future versions of the Maemo GTK+.
1841 However, I can not not get capitalization to work even in a simple test case.
1843 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1845 * src/maemo/easysetup/modest-easysetup-wizard.c:
1846 (create_page_custom_incoming), (create_page_custom_outgoing):
1847 * src/maemo/modest-account-settings-dialog.c:
1848 (create_page_account_details), (create_page_incoming),
1849 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1850 instead of using gtk_check_button_with_label(), so they are aligned like the other
1851 widgets, as per the UI spec.
1853 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1855 * src/maemo/easysetup/modest-easysetup-wizard.c:
1856 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1857 * src/widgets/modest-validating-entry.c:
1858 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1859 Modest prefix instead of an EasySetup prefix.
1861 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1863 * src/widgets/modest-validating-entry.h:
1864 * src/widgets/modest-validating-entry.c: (on_insert_text),
1865 Added easysetup_validating_entry_set_max_func(), used to set a callback
1866 to call when the max number of characters is reached. GtkEntry has a max-length
1867 already but is silent about it.
1869 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1870 (create_page_account_details), (create_page_user_details),
1872 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1873 (create_page_account_details), (create_page_user_details),
1874 (create_page_outgoing):
1875 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1876 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1877 the UI spec, when the user tries to enter more than the max number of characters.
1879 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1881 * src/maemo/easysetup/modest-easysetup-wizard.c:
1882 (create_page_user_details), (create_page_custom_incoming),
1883 (create_page_custom_outgoing):
1884 * src/maemo/modest-account-settings-dialog.c:
1885 (create_page_user_details), (create_page_incoming),
1886 (create_page_outgoing):
1887 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1888 (modest_connection_specific_smtp_edit_window_init):
1889 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1890 not appropriate. Bad Maemo-specific defaults!.
1892 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1894 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1895 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1896 (modest_signature_editor_dialog_set_settings):
1897 Disable the label and textview when the checkbox is disabled, and use the
1898 specified (UI spec) default signature text.
1900 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1902 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1903 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1905 * src/modest-defs.h:
1906 * src/modest-account-mgr-helpers.h:
1907 * src/modest-account-mgr-helpers.c:
1908 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1910 * src/maemo/Makefile.am:
1911 * src/maemo/modest-signature-editor-dialog.c:
1912 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1915 * src/maemo/modest-account-settings-dialog.h:
1916 * src/maemo/modest-account-settings-dialog.c:
1917 (modest_account_settings_dialog_finalize), (on_button_signature),
1918 (save_configuration): Use the new dialog when the Edit button is pressed, and
1919 save the changes if necessary, as per the UI spec.
1921 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1923 * src/maemo/Makefile.am:
1924 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1925 based on maemo-develoers email from Dirk.
1927 * src/maemo/easysetup/modest-easysetup-wizard.c:
1928 (create_page_welcome), (create_page_account_details),
1929 (create_page_user_details), (create_page_complete_easysetup),
1930 (create_page_custom_incoming), (create_page_custom_outgoing),
1931 (create_page_complete_custom),
1932 (modest_easysetup_wizard_dialog_init):
1933 * src/maemo/modest-account-settings-dialog.c:
1934 (create_page_account_details), (create_page_user_details),
1935 (create_page_incoming), (create_page_outgoing),
1936 (modest_account_settings_dialog_init):
1937 * src/maemo/modest-connection-specific-smtp-window.c:
1938 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1940 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1942 * src/maemo/easysetup/modest-easysetup-wizard.c:
1943 (create_page_account_details), (create_page_custom_outgoing),
1944 (create_page_complete_custom):
1945 * src/maemo/modest-account-settings-dialog.c:
1946 (create_page_user_details), (create_page_incoming),
1947 (create_page_outgoing):
1948 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1949 (modest_connection_specific_smtp_edit_window_init):
1950 Use the correct (UI spec) port min/max, and use horizontal separators,
1953 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1955 * src/maemo/easysetup/modest-easysetup-wizard.c:
1956 (set_default_custom_servernames):
1957 * src/maemo/modest-account-settings-dialog.c:
1958 (create_page_incoming), (on_combo_outgoing_security_changed),
1959 (on_combo_incoming_security_changed), (create_page_outgoing),
1960 (modest_account_settings_dialog_set_account_name),
1961 (save_configuration):
1962 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1963 (on_combo_security_changed),
1964 (modest_connection_specific_smtp_edit_window_init),
1965 (modest_connection_specific_smtp_edit_window_set_connection),
1966 (modest_connection_specific_smtp_edit_window_get_settings):
1967 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1970 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1973 * src/maemo/easysetup/modest-easysetup-wizard.c:
1974 (create_page_custom_outgoing), (create_page_complete_custom):
1975 * src/maemo/modest-account-settings-dialog.c:
1976 (create_page_user_details), (create_page_outgoing):
1977 * src/maemo/modest-account-view-window.c: (button_box_new):
1978 Use changed logical IDs as per the most recent UI spec:
1979 mcen_bd_emailsetup_edit -> mcen_bd_edit
1980 mcen_bd_emailsetup_delete -> mcen_bd_delete
1981 mcen_bd_emailsetup_close -> mcen_bd_close
1983 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1987 * src/dbus_api/Makefile.am:
1988 * src/dbus_api/modest-dbus-callbacks.c:
1989 * src/dbus_api/modest-dbus-callbacks.h:
1990 * src/maemo/modest-platform.c: (modest_platform_init):
1991 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1993 * tests/Makefile.am:
1994 * tests/dbus_api/Makefile.am:
1995 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1997 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1999 * src/maemo/modest-account-settings-dialog.c:
2000 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2001 Removed unnecessary includes.
2003 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2005 * src/maemo/easysetup/modest-easysetup-wizard.c:
2006 * src/maemo/modest-account-settings-dialog.c:
2007 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2008 * src/widgets/Makefile.am:
2009 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2010 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2011 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2012 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2013 * src/widgets/modest-secureauth-combo-box.c:
2014 * src/widgets/modest-secureauth-combo-box.h:
2015 * src/widgets/modest-serversecurity-combo-box.c:
2016 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2017 made the GObject names more consistent with the rest of the Modest code.
2019 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2021 * src/maemo/easysetup/Makefile.am:
2022 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2023 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2024 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2025 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2026 * src/maemo/easysetup/modest-easysetup-wizard.c:
2027 * src/maemo/easysetup/modest-validating-entry.c:
2028 * src/maemo/easysetup/modest-validating-entry.h:
2029 * src/maemo/modest-account-settings-dialog.c:
2030 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2031 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2032 widgets/ because they are used outside of easysetup too. After checking in,
2033 svn will allow me to rename them too.
2035 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2037 * src/gnome/modest-msg-edit-window.c:
2038 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2039 linker error, to fix the build on the GNOME platform.
2040 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2041 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2042 ifdefed out to avoid a warning.
2044 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2046 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2047 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2048 some alternative for GTK+ 2.6.
2050 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2052 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2054 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2055 specified for EmailAccountsDialog in UI spec.
2057 * src/maemo/easysetup/modest-easysetup-wizard.c:
2058 * src/maemo/easysetup/modest-easysetup-wizard.h:
2059 * src/maemo/modest-account-settings-dialog.c:
2060 * src/maemo/modest-account-settings-dialog.h:
2061 Reuse a member window widget for the connection-specific SMTP server accounts,
2062 so we can tell it to create/save the accounts only if we actually save changes.
2064 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2065 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2066 (modest_connection_specific_smtp_edit_window_get_settings):
2067 Return a struct instance for temporarily remembering the entered data.
2069 * src/maemo/modest-connection-specific-smtp-window.h:
2070 * src/maemo/modest-connection-specific-smtp-window.c:
2071 (modest_connection_specific_smtp_window_finalize),
2072 (modest_connection_specific_smtp_window_fill_with_connections),
2074 (modest_connection_specific_smtp_window_save_server_accounts),
2075 (update_model_server_names): Do not actually save data until asked,
2076 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2078 (on_selection_changed),
2079 (modest_connection_specific_smtp_window_init): Disable the edit
2080 button when nothing is selected.
2082 * src/modest-account-mgr-helpers.c:
2083 * src/modest-account-mgr-helpers.h:
2084 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2087 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2089 * src/modest-account-mgr-helpers.h:
2090 * src/modest-account-mgr-helpers.c:
2091 (modest_account_mgr_get_unused_account_name),
2092 (modest_account_mgr_get_unused_account_display_name): Added these
2093 utility functions, to avoid code duplication.
2095 * src/maemo/easysetup/modest-easysetup-wizard.c:
2096 (create_page_account_details), (create_account):
2097 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2098 (on_combo_security_changed),
2099 (modest_connection_specific_smtp_edit_window_init),
2100 (modest_connection_specific_smtp_edit_window_save_settings):
2101 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2102 * src/maemo/modest-connection-specific-smtp-window.c:
2103 (modest_connection_specific_smtp_window_finalize),
2104 (modest_connection_specific_smtp_window_fill_with_connections),
2105 (on_button_edit), (modest_connection_specific_smtp_window_init):
2106 * src/maemo/modest-connection-specific-smtp-window.h:
2107 Implementing saving of connection-specific server accounts.
2109 But I need to refactor this so we can save the data for each
2110 possible connection-specific account and only actually create the server accounts
2111 when the easysetup finished, or the OK button is pressed on the account settings
2114 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2116 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2117 (on_combo_security_changed):
2118 (modest_connection_specific_smtp_edit_window_init):
2119 Auto-fill the port number as in the account settings.
2121 (modest_connection_specific_smtp_edit_window_set_connection):
2122 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2123 * src/maemo/modest-connection-specific-smtp-window.c:
2124 (fill_with_connections), (on_button_edit),
2125 (modest_connection_specific_smtp_window_init):
2126 Turn the edit window into a dialog to simplify the code, and
2127 set a WM hint as in a GtkDialog, because only a popup can be on top of
2128 another window in Maemo, and popups usually have no WM decoration.
2130 * src/modest-defs.h:
2131 * src/modest-account-mgr-helpers.c:
2132 (modest_account_mgr_set_connection_specific_smtp),
2133 (modest_account_mgr_remove_connection_specific_smtp),
2134 (modest_account_mgr_get_connection_specific_smtp):
2135 * src/modest-account-mgr-helpers.h: Some functions to write the
2136 connection-specific SMTP server information. Not yet used.
2139 * src/widgets/modest-folder-view.c: (text_cell_data):
2140 Fix a warning about an uninitialized variable.
2141 (on_configuration_key_changed): Put an #ifdef around the use
2142 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2144 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2146 * src/maemo/modest-account-settings-dialog.h:
2147 * src/maemo/modest-account-settings-dialog.c:
2148 Added connect_for_modified() utility function to mark the new modified boolean.
2150 (create_page_account_details), (create_page_user_details),
2151 (create_page_incoming), (create_page_outgoing), (on_response),
2152 (modest_account_settings_dialog_init),
2153 (modest_account_settings_dialog_set_account_name):
2154 Only warn about unsaved changes when there are actually unsaved changes.
2156 * src/modest-account-mgr-helpers.c:
2157 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2158 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2159 to get the data from there in future.
2161 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2163 * src/modest-defs.h:
2165 * src/modest-account-mgr-helpers.h:
2166 * src/modest-account-mgr-helpers.c:
2167 Store the security account setting in a single conf key instead of using
2168 the options list, so that the list is left for just the to-be-removed camel hack,
2169 and because gconf_client_set_list() is failing for some reason.
2171 * src/modest-account-mgr.c:
2172 (modest_account_mgr_add_server_account):
2173 * src/maemo/modest-account-settings-dialog.c:
2174 (modest_account_settings_dialog_set_account_name),
2175 (save_configuration): Use the renamed functions.
2178 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2180 * src/widgets/Makefile.am:
2181 * src/widgets/modest-limit-retrieve-combo-box.c:
2182 * src/widgets/modest-limit-retrieve-combo-box.h:
2183 * src/widgets/modest-retrieve-combo-box.c:
2184 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2185 the account settings dialog.
2187 * src/modest-defs.h:
2188 * src/modest-account-mgr-helpers.h:
2189 * src/modest-account-mgr-helpers.c:
2190 (modest_server_account_get_option_secure_auth),
2191 (modest_server_account_set_option_secure_auth):
2192 * src/modest-account-mgr.c:
2193 (modest_account_mgr_add_server_account):
2194 Use the existing AUTH_MECH conf key for the secure-auth setting,
2195 instead of putting it in the list options, because this was actually used already.
2197 * src/maemo/modest-account-settings-dialog.c:
2198 (create_page_account_details),
2199 (modest_account_settings_dialog_set_account_name),
2200 (save_configuration):
2201 * src/maemo/modest-account-settings-dialog.h:
2202 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2203 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2205 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2207 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2208 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2209 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2211 * src/modest-defs.h:
2212 * src/maemo/modest-account-settings-dialog.c:
2213 (create_page_incoming), (on_combo_outgoing_security_changed),
2214 (on_combo_incoming_security_changed), (create_page_outgoing),
2215 (modest_account_settings_dialog_set_account_name),
2216 (save_configuration): Load/Save the port number, and change it when the
2217 security combo changes, to suitable defaults.
2219 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2221 * src/modest-account-mgr.c:
2222 (modest_account_mgr_add_server_account): Set the security and secure-auth
2223 options, and add a comment saying that the other camel-specific options should be
2226 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2228 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2230 * src/modest-tny-account-store.c: (account_list_free),
2231 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2232 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2235 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2237 * src/modest-protocol-info.c:
2238 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2239 is required by our UI spec. Maybe something in our implementation will use this eventually.
2240 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2241 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2242 instead of the previous 0 placeholder.
2244 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2245 secure-auth settings.
2246 * src/modest-account-mgr-helpers.h:
2247 * src/modest-account-mgr-helpers.c:
2248 (modest_server_account_data_get_option_secure_auth),
2249 (modest_server_account_set_option_secure_auth),
2250 (modest_server_account_data_get_option_security),
2251 (modest_server_account_set_option_security): Added this API for getting and setting the security
2252 and secure-auth settings.
2254 * src/maemo/modest-account-settings-dialog.h:
2255 * src/maemo/modest-account-settings-dialog.c:
2256 (modest_account_settings_dialog_finalize), (check_data),
2257 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2258 about changing titles.
2259 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2260 (save_configuration): Save the security and secure-auth settings.
2262 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2263 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2265 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2267 * src/modest-defs.h:
2268 * src/modest-account-mgr.c:
2269 (modest_account_mgr_add_server_account):
2270 Added and used defines for the options key and value pair strings,
2271 that are used so far, though they do not seem to correspond to anything in our
2272 UI specs or ModestProtocol enum.
2274 * src/modest-account-mgr-helpers.h:
2275 * src/modest-account-mgr-helpers.c:
2276 (compare_option_strings_for_name),
2277 (modest_server_account_data_get_option_value),
2278 (modest_server_account_data_get_option_bool),
2279 (modest_account_mgr_get_server_account_option):
2280 Added helper functions for parsing the options GSList.
2282 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2284 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2285 display name is based on the supplied account name.
2286 * src/modest-account-mgr.c:
2287 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2288 with an inefficient, but good-enough, implementation.
2290 * src/maemo/easysetup/modest-easysetup-wizard.c:
2291 (create_page_account_details), (on_before_next), (create_account):
2292 Check for existing display names rather than (non-user-visible) account names, and just
2293 create and set a unique account name at the end.
2295 * src/maemo/modest-account-settings-dialog.c:
2296 (modest_account_settings_dialog_init),
2297 (modest_account_settings_dialog_set_account_name),
2298 (create_page_incoming): Show the display name, instead of the account name.
2299 (on_response): Do some (not all) extra checks, as in the UI spec.
2300 (save_configuration): Save the display name if it was changed.
2302 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2304 * po/en_GB.po: Added needed logical ID and translation.
2305 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2306 (init_view): Made the is-default column clicking work.
2308 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2311 * src/maemo/easysetup/Makefile.am:
2312 * src/maemo/easysetup/modest-easysetup-wizard.c:
2313 (modest_easysetup_wizard_dialog_init):
2314 * src/maemo/easysetup/provider-data-test.keyfile:
2315 * src/maemo/easysetup/provider-data.keyfile:
2316 Moved the provider data file to the new modest-providers-data package and used it from there.
2318 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2320 * src/modest-local-folder-info.c:
2321 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2322 N_() was already used on the static strings, but this just marks it for translation without
2323 using the translation.
2325 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2327 * src/maemo/modest-account-settings-dialog.c:
2328 (create_page_incoming),
2329 (modest_account_settings_dialog_set_account_name):
2330 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2331 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2332 I will do this if nobody else gets there first.
2334 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2336 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2337 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2338 save the security stuff.
2340 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2342 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2343 Set the email address and user fullname, which I now see must be
2346 * src/maemo/modest-account-settings-dialog.h:
2347 * src/maemo/modest-account-settings-dialog.c:
2349 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2350 leave-on-server and authentication.
2351 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2354 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2357 * src/maemo/modest-account-settings-dialog.c:
2358 * src/maemo/modest-account-settings-dialog.h:
2359 Most (but not all) of the widgets are now present as specified by the UI spec.
2360 No changes are yet saved, and some details are not properly shown yet.
2362 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2364 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2366 * src/maemo/Makefile.am:
2367 * src/maemo/modest-account-settings-dialog.c:
2368 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2369 an existing account. Doesn't do much yet.
2371 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2372 Open the accounts settings dialog when Edit is clicked.
2374 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2376 * src/maemo/easysetup/Makefile.am:
2377 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2379 * src/maemo/easysetup/modest-easysetup-wizard.c:
2380 (modest_easysetup_wizard_dialog_init):
2381 Try to get the source directory from the build system,
2382 instead of hard-coding "./" into the source code, when opening our local
2383 copies of the configuration files.
2384 But this still fails when opening the wizard from the Accounts window,
2385 maybe because the working directory seems to change at runtime.
2386 So the wizard will fail the second time unless you copy the files into their
2387 proper locations - see the stdout warnings for the paths.
2389 (create_page_account_details),(on_before_next):
2390 Check for existing non-server accounts instead of server accounts,
2391 so the default account name is useful again, and to prevent trying to
2394 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2395 Show the wizard when New is clicked.
2397 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2398 (init_view): Show the column headers, and show the columns that are
2399 specified in the UI specs. However, something in Maemo's GTK+ prevents
2400 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2401 change the default account. This is despite unsetting the special properties.
2403 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2405 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2406 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2407 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2408 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2409 to make that clearer.
2410 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2412 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2414 * src/maemo/modest-account-view-window.c:
2415 (modest_account_view_window_init),
2416 (modest_account_view_window_new):
2417 Use the same buttons as specified in the
2418 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2419 the existing widgets, which never had a chance of working.
2420 Put the ModestAccountView treeview in a scrolled window.
2421 Do not repeat the initialization in both _init() and _new().
2423 * src/widgets/modest-account-view.c: (update_account_view):
2424 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2425 this widget and window shows no accounts.
2427 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2429 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2431 * src/maemo/easysetup/modest-easysetup-wizard.c:
2432 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2433 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2434 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2437 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2438 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2439 accounts exist yet, as in the UI spec.
2441 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2443 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2445 * src/maemo/Makefile.am:
2446 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2447 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2448 New window for editing connection-specific smtp details.
2449 Not fully implemented.
2451 * src/maemo/modest-connection-specific-smtp-window.c:
2452 (modest_connection_specific_smtp_window_finalize) :
2453 unref the tree model.
2454 (on_button_edit): Show the edit window.
2456 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2458 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2461 * src/maemo/Makefile.am:
2462 * src/maemo/modest-connection-specific-smtp-window.c:
2463 * src/maemo/modest-connection-specific-smtp-window.h:
2464 New window for showing the list of connections, for connection-specific
2465 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2466 * src/maemo/easysetup/modest-easysetup-wizard.c:
2467 (create_page_custom_outgoing): Show the new window when the button is clicked.
2469 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2471 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2472 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2473 * src/maemo/modest-msg-edit-window.c:
2474 (modest_msg_edit_window_insert_image):
2475 * src/modest-conf.c: (modest_conf_key_escape):
2476 * src/modest-mail-operation.c:
2477 (modest_mail_operation_send_new_mail):
2478 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2479 (modest_ui_actions_on_new_account):
2480 * src/widgets/modest-attachment-view.c: (update_filename_request):
2481 * src/widgets/modest-mail-header-view.c:
2482 Corrected warnings that were breaking the build, by commenting out unused variables,
2483 and a function, and by including a header.
2485 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2487 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2488 so we can #ifdef around platform-specific code when necessary.
2489 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2490 to allow this to build for the GNOME platform too.
2492 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2494 * src/maemo/easysetup/modest-easysetup-wizard.c:
2495 Added util_increment_name() and used it in create_page_account_details()
2496 to make sure that the default account name is always a new name.
2498 (modest_easysetup_wizard_dialog_init),
2499 (set_default_custom_servernames): Some minor memory management fixes.
2501 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2505 * src/modest-runtime.c: (init_i18n): Restored the translation
2506 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2507 are defined in config.h, and the translations are installed.
2509 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2510 is defined for translation.
2512 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2514 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2516 * src/maemo/easysetup/modest-easysetup-wizard.c:
2517 (modest_easysetup_wizard_dialog_init):
2518 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2519 Use realistic paths (though they should use $prefix generically) to the
2520 mcc_mapping and provider-data.keyfile files which might work when they
2521 are installed by the future version of the operator-wizard package,
2522 and then fallback to paths in our source code, with an explanatory
2525 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2529 * src/maemo/Makefile.am:
2530 * src/maemo/easysetup/: Added files from the previously-exernal
2531 osso-modest-easysetup.
2532 * src/maemo/modest-main-window-ui.h:
2533 * src/modest-ui-actions.c:
2534 * src/modest-ui-actions.h:
2535 Added modest_ui_actions_on_new_account() as a signal handler for the
2536 New Account menu item. It shows the easysetup wizard.
2537 * po/en_GB.po: Added additional needed logical IDs and translations.
2539 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2540 Apparently ChangeLog is not used for some vague Nokia legal reasons.