1 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
3 * src/modest-account-view.c:
4 Fixed bug projects.maemo.org bug NB#59307
6 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
8 * src/maemo/easysetup/modest-easysetup-wizard.c:
9 (get_serverport_incoming), (on_before_next), (create_account):
10 * src/maemo/modest-account-settings-dialog.c:
11 (modest_account_settings_dialog_set_account_name):
12 * src/maemo/modest-maemo-utils.c:
13 (on_camel_account_get_supported_secure_authentication_status),
14 (on_camel_account_get_supported_secure_authentication),
15 (on_secure_auth_cancel),
16 (modest_maemo_utils_get_supported_secure_authentication_methods):
18 Implemented security authentication for settings and easysetup.
20 2007-06-05 Murray Cumming <murrayc@murrayc.com>
22 * src/maemo/modest-main-window.c: (create_details_widget):
23 Show the total size for memory card accounts too, instead of showing
24 the name again. Fixes bug projects.maemo.org bug NB#59307.
26 2007-06-05 Murray Cumming <murrayc@murrayc.com>
29 * src/modest-tny-simple-folder-store.c:
30 * src/modest-tny-simple-folder-store.h: Removed.
32 * src/modest-tny-local-folders-account.h
33 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
34 for the local-folders maildir, with an extra TnyMergedFolder containing
35 the folders of the per-account outbox store accounts.
36 * src/modest-tny-account-store.c: (get_server_accounts):
37 Add the outboxes to the special local folders account after creating it.
39 * src/modest-tny-account.c:
40 (modest_tny_account_new_for_local_folders): Create the derived
41 account when creating the main local-folders account.
43 * src/maemo/modest-main-window.c: (create_details_widget),
44 (modest_main_window_set_contents_style):
45 Adapted to the use of the derived account instead of the folder store.
47 * src/modest-ui-actions.c:
48 (modest_ui_actions_on_folder_selection_changed):
49 * src/modest-ui-dimming-rules.c:
50 (modest_ui_dimming_rules_on_new_folder):
51 * src/widgets/modest-folder-view.c: (text_cell_data),
52 (icon_cell_data), (filter_row), (update_model),
53 (get_cmp_rows_type_pos):
56 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
57 Do not get the priv struct, because no priv struct has been set,
58 to avoid a runtime warning.
60 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
61 #ifelse with #else, to fix a warning, to fix the build.
64 2007-06-05 Christian Kellner <ckellner@openismus.com>
66 * libmodest-dbus-client/libmodest-dbus-client.c:
67 Fix small typo in doc (why do you always see them
68 AFTER committing stuff?)
71 2007-06-05 Christian Kellner <ckellner@openismus.com>
73 * libmodest-dbus-client/libmodest-dbus-client.c:
74 (libmodest_dbus_client_search):
75 Initialize hit list with NULL. Also set folder list
76 to "" if NULL was supplied.
79 2007-06-03 Christian Kellner <ckellner@openismus.com>
81 * libmodest-dbus-client/libmodest-dbus-client.c:
82 (modest_search_hit_list_free):
83 Make it save to call it with NULL.
85 * src/dbus_api/modest-dbus-callbacks.c:
86 * src/modest-search.c:
87 Return full ModestSearchHits as the search result list not TnyHeader
88 since can't be around withouth the correspoding TnyFolder.
90 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
92 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
93 Added currently commented code to check for secure auth
95 * src/maemo/modest-account-settings-dialog.c: (on_response),
96 (save_configuration), (show_ok):
97 Fixed projects.maemo.org bugs NB #59248 and #59251
99 * src/maemo/modest-maemo-utils.c:
100 (on_camel_account_get_supported_secure_authentication_status),
101 (on_camel_account_get_supported_secure_authentication),
102 (modest_maemo_utils_get_supported_secure_authentication_methods):
103 * src/maemo/modest-maemo-utils.h:
104 Moved get_supported_secure_authentication() method here to be able
105 to use it from easysetup wizard.
107 * src/modest-pair.c: (on_pair_compare_as_string):
108 Should compare string with first part of pair and not
109 strcmp pairs which will crash.
111 * src/modest-protocol-info.c:
112 (modest_protocol_info_protocol_is_store):
113 * src/modest-protocol-info.h:
114 Added modest_protocol_info_get_auth_protocol_name()
116 2007-06-03 Armin Burgmeier <armin@openismus.com>
118 * src/modest-mail-operation.c:
119 (modest_mail_operation_get_msgs_full): Set priv->account also when
120 only retrieving a single message. This avoids a crash when canceling
123 (modest_mail_operation_notify_end): Do not explicitely remove the
124 operation from the queue but only emit the progress_changed signal.
125 The queue itself listens to that signal to remove the operation when
126 it is finished. This reduces coupling and removes a potential deadlock
127 when modest_mail_operation_notify_end() is called from the queue
128 itself. If that is a problem performance-wise, I would suggest to
129 implement a status-changed signal or something.
131 * src/modest-mail-operation-queue.c: Make sure to never call a
132 function from another file while the queue is locked. This (hopefully)
133 fixes another deadlock when exiting the application while retrieving
136 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
138 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
139 Fixed build if libogs is not available
141 2007-06-03 Christian Kellner <ckellner@openismus.com>
143 * libmodest-dbus-client/libmodest-dbus-client.h:
144 * libmodest-dbus-client/libmodest-dbus-client.c:
145 (libmodest_dbus_client_delete_message):
146 Implement deletion of messages (Client side).
148 (modest_search_hit_free),
149 (modest_search_hit_list_free):
150 Utility functions to free the result hits.
152 * src/dbus_api/modest-dbus-api.h:
153 * src/dbus_api/modest-dbus-callbacks.c:
155 (modest_dbus_req_handler):
156 Implement deletion of messages (Server side).
158 * tests/dbus_api/test_search.c: (main):
161 * tests/dbus_api/Makefile.am:
162 * tests/dbus_api/test_delete_message:
163 Add little test for the message deletion logic
165 2007-06-03 Armin Burgmeier <armin@openismus.com>
167 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
168 when the operation queue was not empty. projects.maemo.org bug
171 2007-06-03 Armin Burgmeier <armin@openismus.com>
173 * src/widgets/modest-account-view.c
174 (on_account_default_toggled): Toggle default account column
175 explicitely instead of waiting for gconf notification (which is
176 currently ignored). This should fix projects.maemo.org bug NB#56910
177 for now. It should probably be removed when gconf notifications are
180 2007-06-03 Christian Kellner <ckellner@openismus.com>
182 * libmodest-dbus-client/libmodest-dbus-client.c:
183 Removed debugging spew.
185 * src/dbus_api/modest-dbus-callbacks.c:
186 Added debugging info.
188 * src/modest-search.c:
189 (modest_search_all_accounts):
190 Use tny_account_store_get_accounts () on the account store
191 to get all accounts which is the way to get all accounts.
193 * tests/dbus_api/test_search.c: (main):
194 Make it possible to supply the search term on the command line.
196 2007-06-03 Christian Kellner <ckellner@openismus.com>
198 * libmodest-dbus-client/libmodest-dbus-client.c:
199 * libmodest-dbus-client/libmodest-dbus-client.h:
200 Implement searching for mesages over raw dbus. (Client side)
202 * src/dbus_api/Makefile.am:
203 * src/dbus_api/modest-dbus-api.h:
204 * src/dbus_api/modest-dbus-callbacks.c:
205 * src/dbus_api/modest-dbus-callbacks.h:
206 Search framework (Server side). Also implement on_idle_open_message().
208 * src/maemo/modest-platform.c: (modest_platform_init):
209 Prepare for raw dbus/osso rpc interaction.
211 * src/modest-search.h:
212 Changed minsize from unspecific guint to guint32.
214 * src/modest-search.c:
216 Added strange hack which magically made tnymail work.
218 (modest_search_folder),
219 (modest_search_account),
220 (modest_search_all_accounts):
221 Implement helper functions to search all accounts, specific account
224 * tests/dbus_api/Makefile.am:
225 * tests/dbus_api/test_open_message.c:
226 Read url to open from commandline.
228 * tests/dbus_api/test_search.c:
229 Implement small test for dbus search stuff
231 2007-06-02 Armin Burgmeier <armin@openismus.com>
233 * src/maemo/modest-account-settings-dialog.c: Changed window title to
234 include account type and account title. This fixes projects.maemo.org
237 * src/maemo/modest-account-view-window.c: Set a title for the window.
239 2007-06-02 Armin Burgmeier <armin@openismus.com>
241 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
242 incoming and outgoing server name based on email address and server
243 types as long as the names have not been edited manually. This fixes
244 projects.maemo.org bug NB#58671.
246 2007-06-02 Armin Burgmeier <armin@openismus.com>
248 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
249 server type cannot be changed in future to the incoming details page
250 when creating an account. This fixes projects.maemo.org bug NB#59029.
252 2007-06-02 Armin Burgmeier <armin@openismus.com>
254 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
255 and assigned max width chars so that they wrap instead of being
256 truncated. Fixes projects.maemo.org bug NB#56126.
258 2007-06-02 Armin Burgmeier <armin@openismus.com>
260 * src/maemo/modest-connection-specific-smtp-window.c: Add an
261 introductory note to the connection specific smtp servers dialog, as
262 section 8.12 of the email UI specification requires. This fixes
263 projects.maemo.org bug NB#59212.
265 2007-06-01 Murray Cumming <murrayc@murrayc.com>
267 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
268 Check for running mail operations, and offer to cancel them, as per the UI
269 spec. This fixes projects.maemo.org bug NB#59041 .
270 However, I suspect that tinymail may still use the network connection
271 in ways that we cannot detect or cancel. But it should at least adapt to
274 2007-06-01 Murray Cumming <murrayc@murrayc.com>
276 * src/modest-tny-account-store.c: (recreate_all_accounts),
277 (get_cached_accounts), (get_server_accounts): Do more sensible
278 ref-counting of the temporarily-cached outbox accounts list. This seems
279 to fix a crash when entering the password when the password was wrong.
281 2007-06-01 Murray Cumming <murrayc@murrayc.com>
283 * src/gnome/modest-main-window.c: (connect_signals):
284 * src/modest-tny-account-store.c: (get_password),
285 (modest_tny_account_store_alert): Added comments and clues and
286 commented-out code about how we currently fail to deal with connection
287 errors and wrong passwords, and how we should.
289 2007-06-01 Murray Cumming <murrayc@murrayc.com>
291 * src/widgets/modest-retrieve-combo-box.c:
292 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
293 This fixes projects.maemo.org bug NB#58472 .
295 2007-06-01 Murray Cumming <murrayc@murrayc.com>
297 * src/maemo/easysetup/modest-easysetup-wizard.c:
298 (create_page_complete_easysetup):
299 (create_page_complete_custom): Correct the last commit,
300 putting the correct sentences in the correct pages.
302 2007-06-01 Murray Cumming <murrayc@murrayc.com>
304 * src/maemo/easysetup/modest-easysetup-wizard.c:
305 (create_page_complete_custom): Show the second sentence of text
306 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
309 2007-06-01 Murray Cumming <murrayc@murrayc.com>
311 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
312 Set the leave-on-server conf key by default. This fixes
313 projects.maemo.org bug NB#59258 .
315 2007-06-01 Murray Cumming <murrayc@murrayc.com>
317 * src/maemo/modest-account-view-window.c:
318 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
319 logical ID for the confirmation messages. Fixed projects.maemo.org bug
322 2007-06-01 Murray Cumming <murrayc@murrayc.com>
324 * src/maemo/easysetup/modest-easysetup-wizard.c:
325 (create_caption_new_with_asterisk):
326 * src/maemo/modest-account-settings-dialog.c:
327 (create_caption_new_with_asterisk):
328 Uncomment the code to add the asterisk, because they are no longer in the
329 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
330 (update_incoming_server_title): Add an asterisk here too.
332 2007-06-01 Murray Cumming <murrayc@murrayc.com>
334 * src/maemo/modest-maemo-global-settings-dialog.c:
335 (current_connection): Check that we are even connected before trying to
336 get the current connection name, to prevent a warning.
338 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
339 Change the comments because tny_maemo_conic_device_connect() is now meant to
341 * src/modest-mail-operation.c:
342 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
343 make sure we have a connection and fail if we can't connect.
345 2007-05-31 Murray Cumming <murrayc@murrayc.com>
347 * src/maemo/modest-main-window.c:
348 (on_account_store_connecting_finished): Do not try to get the
349 connection ID if we are not really connected. I am surprised that
350 this signal handler is called when we are not connected.
352 2007-05-31 Murray Cumming <murrayc@murrayc.com>
354 * src/modest-error.h:
355 * src/modest-ui-actions.c:
356 (modest_ui_actions_get_msgs_full_error_handler):
357 Renamed an enum, added comments, added an enum
358 for retrieve-limit errors.
360 * src/modest-mail-operation.c: (foreach_add_item),
361 (internal_folder_observer_update), (update_account_thread),
362 (modest_mail_operation_get_msgs_full):
363 (modest_mail_operation_update_account),
364 Added comments about how this works, and some code that should
365 (but does not) check the retrieve-limit. See the TODO comment.
367 2007-05-31 Murray Cumming <murrayc@murrayc.com>
369 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
370 Initialize help_id to fix the build. Warnings are good.
372 2007-05-31 Murray Cumming <murrayc@murrayc.com>
374 * src/widgets/modest-hbox-cell-renderer.c:
375 (modest_hbox_cell_renderer_append):
376 * src/widgets/modest-vbox-cell-renderer.c:
377 (modest_vbox_cell_renderer_append):
378 Fix the last commit by doing an extra ref.
380 2007-05-31 Murray Cumming <murrayc@murrayc.com>
382 * src/widgets/modest-hbox-cell-renderer.c:
383 (modest_hbox_cell_renderer_append):
384 * src/widgets/modest-vbox-cell-renderer.c:
385 (modest_vbox_cell_renderer_append):
386 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
387 to fix the build with Maemo Bora.
388 However, there seems to be a remaining crash, probably due to reference
391 2007-05-30 Murray Cumming <murrayc@murrayc.com>
393 * src/modest-tny-account.c:
394 (modest_tny_account_new_for_local_folders):
395 Use hildon_file_system_info_async_new() to get a better name for
396 the memory card account, setting it as the account name.
397 The timing seems to work, but this is probably
398 not the best place to do this. See the TODO comment.
399 * src/maemo/modest-main-window.c: (create_details_widget):
400 * src/widgets/modest-folder-view.c: (text_cell_data):
401 Use the tny account name instead of hardcoding a name.
403 2007-05-30 Christian Kellner <ckellner@openismus.com>
405 * src/modest-search.c: (modest_search):
406 Correctly set part_search_func even if we have already parsed
407 the query and thus a valid OgsTextSearcher object.
409 2007-05-30 Christian Kellner <ckellner@openismus.com>
412 Search and check for libogs.
415 Incooparte the ogs build env.
417 * src/modest-mime-part-search-stream.c:
418 * src/modest-mime-part-search-stream.h:
419 Removed since we do the real searching now in modest-search.c.
421 * src/modest-search.c:
422 * src/modest-search.h:
423 Implement support for ogs. We use that if available and requested
424 and fall back to modest_text_utils_utf8_strcmp (). The search logic
425 should now handle the corner case when the search term is spread
426 across multiple reads.
427 Also the logic in modest_search () was corrected to search all
428 requested fields until one is found.
430 2007-05-30 Murray Cumming <murrayc@murrayc.com>
432 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
435 * src/modest-init.c: Made modest_init_local_folders() take a
436 path and be public so we can iniitialize maildir folders on
439 * src/modest-local-folder-info.h:
440 * src/modest-local-folder-info.c:
441 (modest_local_folder_info_get_maildir_path): Add a path parameter.
443 * src/modest-tny-account.c:
444 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
445 still means the standard local-folders path on the local volume.
447 * src/modest-tny-account-store.c:
448 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
449 signal so we can detect mount/unmount of the MMC1 card, and do an update of
450 all accounts when that happens.
451 (get_server_accounts): If the MMC1 card is mounted, create a store account for
452 this too, so it shows up in the treeview.
454 2007-05-28 Murray Cumming <murrayc@murrayc.com>
456 * src/maemo/modest-maemo-global-settings-dialog.c:
457 (current_connection):
458 * src/widgets/modest-global-settings-dialog.c:
459 (current_connection_default):
460 Use the enum values instead of 0, 1 and -1,
461 to make the code clearer.
463 * src/modest-account-mgr-helpers.c:
464 (modest_account_mgr_get_connection_specific_smtp): Make this code
467 * src/modest-runtime.h:
468 * src/modest-runtime.c:
469 Added modest_runtime_remove_all_send_queues().
470 * src/maemo/modest-main-window.c:
471 (on_account_store_connecting_finished): Recreate the send queues,
472 using the appropriate transport accounts for this new connection.
473 Some futher adapting might be needed if the old send queues are not
474 automatically stopped at this point.
476 * src/modest-tny-account-store.c: (get_server_accounts):
477 Create the connection-specific transport accounts, so that they can
478 be found later by their ID.
480 * src/modest-tny-account.h:
481 * src/modest-tny-account.c:
482 Added modest_tny_account_new_from_server_account_name().
483 modest_tny_account_new_from_server_account(): Do not create the
484 send queues here, because they will be
485 recreated anyway when the connection changes for the first time.
487 2007-05-28 Murray Cumming <murrayc@murrayc.com>
489 * src/modest-local-folder-info.h:
490 * src/modest-local-folder-info.c:
491 (modest_per_account_local_outbox_folder_info_get_maildir_path),
492 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
493 tbox_folder): Take a modest account name instead of a server TnyAccount,
494 so we can have per-modest-account rather than per-transport-account
496 We must make sure that we change or recreate the exisitng send queues
497 when the connection changes for connection-specific transport accounts.
499 * src/modest-tny-account-store.c:
500 (create_per_account_local_outbox_folders): Create outboxed per modest
501 account, not per transport account.
503 * src/modest-tny-account.h:
504 * src/modest-tny-account.c:
505 (modest_tny_account_get_special_folder): For outboxes, get the
506 parent modest account name. The account is ignored for other folders.
507 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
508 modest account name rather than a server TnyAccount.
510 2007-05-25 Murray Cumming <murrayc@murrayc.com>
512 * src/modest-tny-account.c:
513 (modest_tny_account_new_from_server_account):
514 Call modest_runtime_get_send_queue() immediately after creating transport
515 accounts, so that they start trying to send email from the outbox as soon
516 as possible at startup. This is probably what we want.
518 * src/modest-mail-operation.c: (update_account_thread):
519 * src/modest-runtime.c: (modest_runtime_get_send_queue):
520 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
521 * src/modest-tny-send-queue.h:
522 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
523 (modest_ui_actions_on_send):
524 Added comments about how sending works, though it needs some more work.
526 2007-05-25 Murray Cumming <murrayc@murrayc.com>
528 * src/modest-tny-account.c:
529 (modest_tny_account_get_special_folder): Add TODO because this fails when
531 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
532 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
533 Do not try to show this window when there is no active account. The UI
534 specs does not tell us what to do in this case.
536 2007-05-24 Murray Cumming <murrayc@murrayc.com>
540 * src/maemo/Makefile.am:
541 * src/widgets/Makefile.am: Some dist fixes.
543 2007-05-24 Murray Cumming <murrayc@murrayc.com>
545 * src/maemo/modest-connection-specific-smtp-window.c:
546 (on_button_edit): Make the code clearer, to prevent a double free.
548 2007-05-24 Murray Cumming <murrayc@murrayc.com>
550 * src/maemo/modest-account-settings-dialog.c:
551 (modest_account_settings_dialog_set_account_name),
552 Check the connection-specific smtp servers checkbox if there are any.
554 * src/maemo/modest-connection-specific-smtp-edit-window.c:
555 (modest_connection_specific_smtp_edit_window_init):
556 Start with a suitable port number.
558 * src/modest-account-mgr-helpers.h:
559 * src/modest-account-mgr-helpers.c: Added
560 modest_account_mgr_get_has_connection_specific_smtp().
562 (modest_account_mgr_set_connection_specific_smtp),
563 (modest_account_mgr_remove_connection_specific_smtp),
564 (modest_account_mgr_get_has_connection_specific_smtp),
565 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
566 connection-specific smtp server accounts in the account, rather than
567 the server account conf dir.
569 This fixes bug projects.maemo.org bug NB#58263 .
571 * src/modest-tny-account-store.c:
572 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
573 if there are no server accounts yet, to prevent an infinite loop when there
574 are no accounts. Document that one must be called before the other.
576 2007-05-24 Murray Cumming <murrayc@murrayc.com>
578 * src/modest-account-mgr-helpers.c:
579 (modest_account_mgr_get_default_account): Make sure that at least
580 one account is always the default, if there are any enabled accounts.
581 This is just a sanity check that shouldn't be necessary.
583 * src/modest-account-mgr-priv.c:
584 (_modest_account_mgr_account_from_key): Unescape the conf key to
585 get the real account name. For instance, this is an issue if a space
586 was in the account name, which can happen because the account name
587 is generated from the display name.
588 (_modest_account_mgr_get_account_keyname): Always escape the
590 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
591 Unescape the conf keys to get the real account names.
593 For instance, previously the is-default radio button in the accounts
594 list was not checked for any accounts at first. This fixes that,
595 and might fix several similar bugs.
597 2007-05-23 Murray Cumming <murrayc@murrayc.com>
599 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
600 Removed some debug printfs.
602 2007-05-23 Murray Cumming <murrayc@murrayc.com>
604 Modest on-disk outbox directories are now here, for instance:
605 $HOME/.modest/outboxes/<account-id-1>/outbox
606 $HOME/.modest/outboxes/<account-id-2>/outbox
608 $HOME/.modest/local-folders/outbox
609 so we can have a separate outbox for each account.
610 But they are shown as one outbox in the GtkTreeView, by using a
611 TnyMergeFolder in a ModestTnySimpleFolderStore.
614 * src/modest-tny-simple-folder-store.c:
615 * src/modest-tny-simple-folder-store.h:
616 Added ModestTnySimpleFolderStore, used to contain folders from
617 other folder stores, such as other accounts.
619 * src/modest-tny-outbox-account.h:
620 * src/modest-tny-outbox-account.c:
621 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
622 used for the per-account local outbox folders.
624 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
625 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
626 only use this (internally) now for the non-outbox local folders.
629 * src/modest-init.c: Added modest_init_one_local_folder(), for
630 setting up the directory structure for each local folder.
632 * src/modest-local-folder-info.c:
633 (modest_per_account_local_outbox_folder_info_get_maildir_path),
634 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
636 * src/modest-local-folder-info.h:
637 * src/modest-tny-account-store.c: (on_account_removed),
638 (on_account_changed), (create_per_account_local_outbox_folders),
639 (get_server_accounts), (modest_tny_account_store_get_accounts),
640 (modest_tny_account_store_get_tny_account_by_account),
641 (modest_tny_folder_store_is_virtual_local_folders):
643 * src/modest-tny-account.h:
644 * src/modest-tny-account.c:
645 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
646 to create an on-disk per-account local outbox folder for each
648 (create_per_account_local_outbox_folders): Create a local outbox folder
649 for each transport account.
650 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
651 for all local folders.
653 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
654 instead of using g_object_get/set() directly. It is clearer.
656 (modest_tny_folder_store_get_message_count),
657 (modest_tny_folder_store_get_local_size
658 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
659 because we now use these with non-acount folder stores.
661 (modest_tny_account_get_special_folder),
662 (modest_tny_account_new_from_server_account),
663 (modest_tny_account_new_from_account):
664 (recurse_folders): Adjust to the new outbox system.
666 * src/modest-tny-folder.h:
667 * src/modest-tny-folder.c:
668 (modest_tny_folder_is_local_folder),
669 (modest_tny_folder_get_local_folder_type),
670 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
672 * src/widgets/modest-main-window.h:
673 * src/maemo/modest-main-window.c: (create_details_widget),
674 (modest_main_window_set_contents_style): Show details for any folder store,
677 (modest_tny_folder_get_rules):
678 Remove the const. C does not support constness enough for this.
680 * src/modest-ui-actions.c:
681 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
682 make all outboxes appear as one, in the usual local-folders tree node.
684 (set_active_account_from_tny_account),
685 (modest_ui_actions_on_folder_selection_changed):
686 * src/widgets/modest-folder-view.c: (text_cell_data),
687 (icon_cell_data), (filter_row),
688 (add_account_folders_to_merged_folder),
689 (add_account_folders_to_simple_folder_store), (),
690 (get_cmp_rows_type_pos), (cmp_rows),
691 (modest_folder_view_set_account_id_of_visible_server_account):
692 Adjust to the new outbox system, using generic folder stores and folders
695 2007-05-23 Christian Kellner <ckellner@openismus.com>
697 * src/modest-mail-operation.c:
698 (modest_mail_operation_update_account):
699 Use info->max_size instead of unintialized local var [small
700 build fix]. (Added TODO to review that change since I don't
703 2007-05-23 Marcus Bauer <marcusb@openismus.com>
705 * libmodest-dbus-client/libmodest-dbus-client.c:
706 (libmodest_dbus_client_compose_mail): function added
707 * src/dbus_api/modest-dbus-api.h:
708 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
709 (on_compose_mail): Implementation of the SendAsMail functionality
711 2007-05-22 Murray Cumming <murrayc@murrayc.com>
713 * src/modest-account-mgr.c:
714 (modest_account_mgr_add_server_account): Set the secure-connection
715 conf key for transport accounts as well as store accounts. I don't know
716 why the if was there. For instance, this makes sure that we use SSL
717 for the gmail preset from the easysetup wizard.
719 2007-05-22 Murray Cumming <murrayc@murrayc.com>
721 * src/gnome/modest-main-window.c:
722 (on_account_store_connecting_finished), (connect_signals):
723 * src/maemo/modest-main-window.c:
724 (on_account_store_connecting_finished), (connect_signals),
725 (modest_main_window_new):
726 Handle TnyAccountStore::connecting-finished instead of
727 TnyDevice::connection-changed, because we cannot actually perform
728 operations on accounts until TnyAccountStore has itself responded to
729 the TnyDevice::connection-changed signal. This prevents a GError from
731 Do not try to update at startup, because we (at least on scratchbox)
732 already do an update at startup when the device goes online.
733 This prevents a GError from tinymail.
734 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
735 Added TODO about stopping simultaneous operations.
737 2007-05-21 Murray Cumming <murrayc@murrayc.com>
739 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
740 * src/modest-mail-operation-queue.c:
741 (modest_mail_operation_queue_remove):
742 * src/modest-tny-account-store.c: When GErrors happen, give more clues
743 about where they happened.
745 2007-05-21 Murray Cumming <murrayc@murrayc.com>
747 * src/modest-ui-actions.c:
748 (modest_ui_actions_on_password_requested): Make sure that the remember
749 output parameter is always TRUE.
751 2007-05-21 Murray Cumming <murrayc@murrayc.com>
753 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
754 Show a OK/Cancel dialog if the error is a question, though we still do not
755 know anything more about what we are asking the user.
756 * src/widgets/modest-folder-view.c: (on_drag_data_received):
757 Fix an uninitialized variable (helper). This is a logic error, however.
759 2007-05-21 Christian Kellner <ckellner@openismus.com>
761 * src/modest-search.h:
762 Correct bit shifting in the ModestSearchFlags enum.
764 2007-05-21 Murray Cumming <murrayc@murrayc.com>
766 * src/modest-tny-account.c:
767 (modest_tny_account_new_from_server_account): Do not use the lsub and
768 check-all hard-coded IMAP options when using POP.
770 2007-05-21 Murray Cumming <murrayc@murrayc.com>
772 * src/modest-tny-account.c:
773 (modest_tny_account_new_from_server_account):
774 Use NULL for the secure-auth method for POP when Password auth has been
775 specified by the user, as we already do for IMAP. "auth=Login" causes
776 an error from camel or the server.
778 2007-05-17 Murray Cumming <murrayc@murrayc.com>
780 * src/maemo/modest-account-settings-dialog.c:
781 (create_page_account_details),
782 (modest_account_settings_dialog_set_account_name):
783 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
784 for the leave-on-server checkbox, rathr than just the checkbox, when
785 the protocol is not POP.
787 2007-05-17 Murray Cumming <murrayc@murrayc.com>
789 * src/widgets/modest-account-view.c:
790 * src/widgets/modest-account-view.h:
791 Added modest_account_view_select_account() which will be useful later
792 to asynchronously re-select the edited account.
794 2007-05-17 Murray Cumming <murrayc@murrayc.com>
796 * src/maemo/modest-account-settings-dialog.c:
797 (modest_account_settings_dialog_set_account_name):
798 Automatically choose the port numbers based on the secure authentication
799 methods, if they have not been chosen before.
800 This fixes projects.maemo.org bug NB#56273 .
802 2007-05-17 Murray Cumming <murrayc@murrayc.com>
804 * src/maemo/modest-main-window-ui.h:
805 * src/modest-ui-actions.c:
806 * src/modest-ui-actions.h:
807 Connect the Tools/SMTP Servers menu item to
808 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
809 SMTP servers dialog, as in the UI specification and saves changes when it
810 is closed. This fixed projects.maemo.org bug NB#56305 .
812 2007-05-17 Murray Cumming <murrayc@murrayc.com>
814 * src/maemo/modest-connection-specific-smtp-window.c:
815 (modest_connection_specific_smtp_window_init):
816 Use gtk_window_set_default_size() to make this window big enough, so
817 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
819 2007-05-17 Murray Cumming <murrayc@murrayc.com>
821 * src/maemo/modest-connection-specific-smtp-edit-window.h:
822 * src/maemo/modest-connection-specific-smtp-edit-window.c:
823 (modest_connection_specific_smtp_edit_window_init),
824 Do not try to connect to a combobox signal before the combobox exists.
825 This fixes the cras in projects.maemo.org bug NB#56288 .
826 (modest_connection_specific_smtp_edit_window_get_settings):
827 Remove the server_account_name parameter which was being checked for NULL
828 though it was not used.
830 * src/maemo/modest-connection-specific-smtp-window.c:
831 (modest_connection_specific_smtp_window_fill_with_connections),
832 (on_button_edit), (modest_connection_specific_smtp_window_init):
833 Correct the number of treemodel columns to prevent a warning.
834 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
835 libconic does not work.
837 2007-05-16 Murray Cumming <murrayc@murrayc.com>
839 * src/modest-tny-account.c:
840 (modest_tny_account_new_from_server_account):
841 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
842 SMTP when "None" was chosen by the user. However, with my SMTP server that
843 does not support ANONYMOUS, the emails do not leave the Outbox and I see
846 2007-05-16 Murray Cumming <murrayc@murrayc.com>
848 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
849 to explain the memory management issue with the ID in the ModestPair.
851 * src/gnome/modest-account-assistant.c: (add_receiving_page),
852 (add_sending_page), (modest_account_assistant_finalize):
853 * src/gnome/modest-gnome-global-settings-dialog.c:
854 (create_updating_page), (create_composing_page):
855 * src/gnome/modest-msg-edit-window.c: (get_transports),
856 (init_window), (modest_msg_edit_window_finalize),
857 (modest_msg_edit_window_get_msg_data):
858 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
859 * src/gnome/modest-transport-widget.c:
860 (modest_transport_widget_finalize), (smtp_configuration):
861 * src/maemo/modest-maemo-global-settings-dialog.c:
862 (create_updating_page), (create_composing_page):
863 * src/maemo/modest-msg-edit-window.c: (get_transports),
864 (init_window), (modest_msg_edit_window_finalize),
865 (modest_msg_edit_window_get_msg_data),
866 (modest_msg_edit_window_free_msg_data):
867 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
868 (modest_store_widget_finalize):
869 * src/maemo/modest-transport-widget.c:
870 (modest_transport_widget_finalize), (smtp_configuration):
871 * src/modest-main.c: (send_mail):
872 * src/widgets/modest-combo-box.h:
873 * src/widgets/modest-global-settings-dialog-priv.h:
874 * src/widgets/modest-global-settings-dialog.c:
875 (modest_global_settings_dialog_finalize):
876 * src/widgets/modest-msg-edit-window.h:
877 Whenever using modest_combo_box_new(), keep the ModestPairList alive
878 as long as the combo box, to prevent use of freed memory for the ID.
880 2007-05-15 Murray Cumming <murrayc@murrayc.com>
882 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
883 get_accounts(), to make this clearer. Do not check for the enabled gconf
884 key, because we do not use this for server accounts (at least, not yet).
885 This allows us to send email again.
887 2007-05-15 Murray Cumming <murrayc@murrayc.com>
889 * src/maemo/modest-platform.c:
890 (on_modest_conf_update_interval_changed), (modest_platform_init):
891 Only respond to this particular key change. All these strcmp()s cannot be
894 2007-05-15 Murray Cumming <murrayc@murrayc.com>
896 * src/maemo/modest-maemo-global-settings-dialog.c:
897 (current_connection): Prevent a crash in scratchbox when
898 ny_maemo_conic_device_get_current_iap_id() returns NULL.
899 * src/maemo/modest-platform.c:
900 (on_modest_conf_update_interval_changed), (modest_platform_init):
901 Get the update interval from gconf and reset it when the gconf key changes.
903 2007-05-15 Murray Cumming <murrayc@murrayc.com>
905 * src/modest-protocol-info.c:
906 * src/modest-protocol-info.h: Adde enum-specific get functions,
907 instead of using a ModestProtocolType enum parameter.
909 * src/gnome/modest-account-assistant.c:
910 * src/gnome/modest-store-widget.c:
911 * src/gnome/modest-store-widget.h:
912 * src/gnome/modest-transport-widget.c:
913 * src/gnome/modest-transport-widget.h:
914 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
915 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
916 * src/maemo/easysetup/modest-easysetup-wizard.c:
917 * src/maemo/modest-account-settings-dialog.c:
918 * src/maemo/modest-account-settings-dialog.h:
919 * src/maemo/modest-store-widget.c:
920 * src/maemo/modest-store-widget.h:
921 * src/maemo/modest-transport-widget.c:
922 * src/maemo/modest-transport-widget.h:
923 * src/modest-account-mgr-helpers.c:
924 * src/modest-account-mgr-helpers.h:
925 * src/modest-account-mgr.c:
926 * src/modest-account-mgr.h:
927 * src/modest-tny-account.c:
928 * src/modest-tny-folder.c:
929 * src/widgets/modest-account-view.c:
930 * src/widgets/modest-retrieve-combo-box.c:
931 * src/widgets/modest-retrieve-combo-box.h:
932 * src/widgets/modest-secureauth-combo-box.c:
933 * src/widgets/modest-serversecurity-combo-box.c:
934 * src/widgets/modest-serversecurity-combo-box.h:
935 * tests/check_account-mgr.c:
936 Use the specific functions, and use the re-renamed enum values for GNOME too.
938 2007-05-15 Murray Cumming <murrayc@murrayc.com>
941 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
942 so we can get the second based on the first.
944 * src/maemo/modest-account-settings-dialog.h:
945 * src/maemo/modest-account-settings-dialog.c:
946 Added get_supported_secure_authentication_methods(), though it is mostly
947 commented-out for now until the necessary API is committed to tinymail.
948 (modest_account_settings_dialog_set_account_name),
949 (save_configuration): Request the supported authentication methods from the
950 server, so we can choose a working method.
952 * src/modest-tny-account-store.h:
953 * src/modest-tny-account-store.c:
954 (modest_tny_account_store_get_session): Rename from
955 tny_account_store_get_session().
957 2007-05-14 Murray Cumming <murrayc@murrayc.com>
959 * src/modest-protocol-info.h: Split the ModestProtocol enum
960 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
961 There was no need to have these unrelated values in one enum.
963 * src/: many files: Adapted to changed enum. This makes the code a bit
964 clearer, and the compiler could catch some errors.
966 2007-05-14 Murray Cumming <murrayc@murrayc.com>
968 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
969 Show the detailed internal camel error message when an error happens
970 during the configuration, so that our testers can give us more clues.
971 For instance, in projects.maemo.org bug NB#56910 .
973 2007-05-14 Murray Cumming <murrayc@murrayc.com>
975 * src/modest-tny-account.c:
976 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
977 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
979 2007-05-14 Murray Cumming <murrayc@murrayc.com>
981 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
982 * src/maemo/modest-account-settings-dialog.c:
983 (modest_account_settings_dialog_set_account_name),
984 (save_configuration): For the incoming secure authentication checkbox,
985 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
986 the UI specification. PLAIN does not seem to be supported for most IMAP
987 servers anyway, and I am not sure what it would mean.
988 However, we probably need to discover which of the secure-authentication
989 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
990 * src/modest-account-mgr-helpers.c:
991 (modest_account_mgr_get_server_account_data):
993 * src/modest-tny-account.c:
994 (modest_tny_account_new_from_server_account):
995 Use tny_account_set_mech() to set secure-authentication methods,
996 with some special-casing for IMAP, based on my observations of how
999 * src/modest-account-mgr-helpers.h:
1000 * src/modest-account-mgr.c:
1001 * src/modest-defs.h: Comment that the URI is only used for local folders.
1003 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1005 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1006 parameter const, just to be neat.
1007 * src/modest-text-utils.c: (modest_text_utils_inline):
1008 End g_strconcat() with NULL, as its documentation says. This is almost
1009 certainly the cause of my crash at startup on the device. Interestingly,
1010 valgrind doesn't tell us about these errors.
1012 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1014 * scripts/build-packages: Added more precise comments about how to use
1015 this script, though I still get this error:
1016 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1017 error building tinymail
1019 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1021 * src/maemo/modest-main-window.c: (on_account_update):
1022 Very slight cleanup, hoping to make it simpler to discover what causes
1023 a crash here sometimes.
1025 * src/modest-tny-account.c:
1026 (modest_tny_account_new_from_server_account): Set the port. Added
1027 comments about the options and a TODO comment because I need to find out
1028 how to specify the secure authentication method.
1030 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1032 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1033 changed CFlags paths form modest to libmodest
1035 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1037 * src/modest-account-mgr-helpers.c:
1038 (modest_account_mgr_get_server_account_data),
1039 (modest_account_mgr_free_server_account_data):
1040 * src/modest-account-mgr-helpers.h:
1041 * src/modest-account-mgr.c:
1042 (modest_account_mgr_add_server_account):
1043 * src/modest-defs.h:
1044 * src/modest-tny-account.c:
1045 (modest_tny_account_new_from_server_account):
1046 Determine the options for tny_camel_account_add_option() here,
1047 based on the settings, rather than storing them directly in gconf.
1049 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1051 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1052 Show a more friendly error dialog now that we expect (from the tinymail
1053 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1055 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1057 * src/maemo/modest-main-window.c: (on_account_update): Check that
1058 account_name is not NULL, to prevent a crash at startup that I am
1059 seeing on the N800. I do wonder why it is NULL.
1061 * src/maemo/easysetup/modest-easysetup-wizard.c:
1062 (create_page_user_details):
1063 * src/maemo/modest-account-settings-dialog.c:
1064 (create_page_user_details), (create_page_outgoing):
1065 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1066 (modest_connection_specific_smtp_edit_window_init):
1067 * src/modest-ui-actions.c:
1068 (modest_ui_actions_on_password_requested):
1069 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1070 might do something useful with the on-screen keyboard.
1072 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1074 * src/maemo/modest-main-window.c: (on_account_update):
1075 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1076 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1078 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1080 * src/modest-tny-account-store.c: (on_account_changed):
1081 Correct the signature of this signal handler.
1083 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1085 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1086 Show a HildonNote instead of a GtkDialog for Maemo.
1088 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1090 * src/widgets/modest-account-view.h:
1091 * src/widgets/modest-account-view.c: (on_account_changed),
1092 (on_account_removed). Added a boolean flag, set/unset by
1093 modest_account_view_block_conf_updates(),
1094 modest_account_view_unblock_conf_updates() to prevent unnecessary
1095 updates, but this is not very useful because the gconf notifications are
1096 so delays (maybe only on Maemo Bora).
1097 So auto-updating is turned off, and these functions do an explicit
1098 update when necessary.
1099 However, something else is still doing too much work when adding/removing
1100 accounts, probably in another part of the application.
1102 * src/maemo/modest-account-view-window.c:
1103 (on_delete_button_clicked), (on_edit_button_clicked),
1104 (on_new_button_clicked): Use the new functions.
1106 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1108 * src/modest-account-mgr-helpers.c:
1109 (modest_account_mgr_set_first_account_as_default):
1110 Sort the list of names alphabetically-by-title, so we choose the first one
1112 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1113 alphabetically by the title.
1115 This fixes projects.maemo.org bug NB#56418 .
1117 * src/modest-account-mgr-priv.c:
1118 (_modest_account_mgr_account_from_key):
1119 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1120 avoid a valgrind error, and possible random behaviour.
1122 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1124 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1125 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1126 tinymail documentation to say that this can be expected.
1127 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1128 pretty, and should not happen, but I would prefer to know when it does.
1130 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1132 * configure.ac: When using the older hildon version, probably on Bora,
1133 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1135 * src/widgets/modest-attachment-view.c:
1136 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1139 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1141 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1142 Implemented the prototype. Can be tested with
1143 tests/dbus_api/test_open_message:
1145 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1147 * src/modest-tny-account-store.c:
1148 (modest_tny_account_store_instance_init), (get_password):
1149 * src/modest-ui-actions.c:
1150 (modest_ui_actions_on_password_requested):
1151 Do not store the password in gconf, because this function is called
1152 for non-remembered passwords. Actually use the cached (in the hash map)
1153 password instead of releasing it.
1154 The password will now not be remembered if it is asked via the protected
1155 password dialog, as per the UI spec.
1157 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1159 * src/modest-defs.h:
1160 * src/modest-account-mgr-helpers.h:
1161 * src/modest-account-mgr-helpers.c:
1162 Added modest_server_account_get_username_has_succeeded(),
1163 modest_server_account_set_username_has_succeeded().
1164 (modest_server_account_set_username),
1165 Reset the has-succeeded flag if the username changes.
1167 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1168 * src/maemo/modest-connection-specific-smtp-window.c:
1169 (modest_connection_specific_smtp_window_save_server_accounts):
1170 Use modest_server_account_set_username() instead of using
1171 modest_conf_set_string() directly, so that the has-succeeded flag is always
1174 * src/modest-ui-actions.c:
1175 (modest_ui_actions_on_password_requested): Dim the username entry if
1176 the username has ever worked, as per the UI spec.
1178 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1180 * src/modest-tny-account-store.c: (get_password):
1181 * src/modest-ui-actions.c:
1182 (modest_ui_actions_on_password_requested):
1183 Allow the username to be changed too, though there is more work to
1184 be done on exactly how this behaves.
1186 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1188 * src/modest-account-mgr-helpers.h:
1189 * src/modest-account-mgr-helpers.c:
1190 Added modest_account_mgr_get_display_name(),
1191 modest_server_account_get_username(),
1192 modest_server_account_set_username(),
1193 modest_server_account_set_password(),
1194 modest_server_account_get_hostname() functions so we do not need to
1195 use the conf API directly.
1197 * src/maemo/modest-main-window.c: (connect_signals):
1198 Actually connect ot the ModestAccountStore::request-password signal,
1199 so that we show the dialog when the password is requested by Tinymail,
1200 for isntance if it is empty.
1202 * src/modest-marshal.list:
1203 * src/modest-tny-account-store.c:
1204 (modest_tny_account_store_class_init), (get_password),
1205 (modest_tny_account_store_alert):
1206 * src/modest-tny-account-store.h:
1207 * src/modest-ui-actions.h:
1208 * src/modest-ui-actions.c:
1209 (modest_ui_actions_on_password_requested):
1210 Change the signal parameters, so it is obvious that we are providing
1211 the non human-readable server name, and receiving both the username
1212 and password, though changing of the username is not yet implemented.
1213 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1214 for the GNOME version.
1216 This should fix the projects.maemo.org bug NB#56209, though it does not
1217 work on Bora, because the gconf_client_get() for the password fails
1218 immediately after we save it with gconf_client_set().
1220 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1223 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1224 caused an undefined symbol error:
1225 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1227 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1229 * src/modest-tny-account-store.c:
1230 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1231 using a GError instead of a string message, so we can translate it in
1234 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1236 * src/maemo/modest-address-book.c:
1237 (modest_address_book_check_names):
1238 * src/maemo/modest-msg-view-window.c:
1239 (modest_msg_view_window_clipboard_owner_change):
1240 * src/modest-init.c: (modest_init_init_ui):
1241 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1242 (update_folders_cb), (modest_mail_operation_update_account):
1243 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1244 (modest_ui_actions_on_msg_attachment_clicked),
1245 (modest_ui_actions_on_msg_recpt_activated):
1246 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1247 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1248 (modest_msg_view_search_next):
1249 * src/widgets/modest-recpt-editor.c:
1250 (modest_recpt_editor_on_button_release_event),
1251 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1252 g_message(). At this point we should only be seeing interesting errors on
1253 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1255 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1257 (modest_wizard_dialog_force_title_update):
1258 * src/maemo/easysetup/modest-wizard-dialog.h:
1259 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1260 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1261 can update the title when appropriate. Otherwise the title is wrong if the
1262 pages are added after adding the notebook to the dialog.
1263 This must be a problem in HildonWizardDialog too.
1264 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1266 * src/maemo/easysetup/modest-easysetup-wizard.c:
1267 (create_subsequent_customsetup_pages),
1268 (create_subsequent_easysetup_pages):
1269 Call modest_wizard_dialog_force_title_update() so that the title is
1270 correct even with GTK+ < 2.10.
1271 This fixes projects.maemo.org bug NB#56145 .
1273 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1275 * src/maemo/modest-platform.c:
1276 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1277 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1280 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1282 * src/widgets/modest-window.h:
1283 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1284 and modest_window_save_state(), which invokes it.
1286 * src/widgets/modest-window-mgr.h:
1287 * src/widgets/modest-window-mgr.c:
1288 Added modest_window_mgr_save_state_for_all_windows(), which calls
1289 the save_state vfunc on all registered windows, if implemented.
1291 * src/gnome/modest-msg-edit-window.c:
1292 * src/gnome/modest-msg-view-window.c:
1293 * src/maemo/modest-msg-edit-window.c:
1294 * src/maemo/modest-msg-view-window.c:
1295 * src/maemo/modest-main-window.c:
1296 Specify the existing save_settings functions as implementations of
1297 ModestWindow::save_state_func().
1299 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1300 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1301 enabling hibernation, for instance.
1303 We may need to do the same thing for restoring settings.
1306 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1308 * src/widgets/modest-window-mgr.c:
1309 * src/widgets/modest-window-mgr.h:
1310 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1311 modest_window_mgr_get_hibernation_is_prevented().
1313 * src/maemo/modest-main-window.c:
1314 (on_hildon_program_is_topmost_notify): Prevent hibernation
1315 (possible when the application goes to the background in the WM),
1316 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1318 * src/maemo/easysetup/modest-easysetup-wizard.c:
1319 (modest_easysetup_wizard_dialog_init):
1320 * src/maemo/modest-account-settings-dialog.c:
1321 (modest_account_settings_dialog_init):
1322 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1323 (modest_connection_specific_smtp_edit_window_init):
1324 * src/maemo/modest-connection-specific-smtp-window.c:
1325 (modest_connection_specific_smtp_window_init):
1326 * src/maemo/modest-signature-editor-dialog.c:
1327 (modest_signature_editor_dialog_init):
1328 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1329 prevent hibernation while any of these account settings dialogs are open.
1331 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1333 * src/maemo/Makefile.am:
1334 * src/maemo/modest-osso-state-saving.c:
1335 * src/maemo/modest-osso-state-saving.h: Added
1336 modest_osso_load_state() and modest_osso_save_state() though they do
1337 nothing now. They should iterate through all the open windows and load/save
1339 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1340 save state when closing.
1342 * src/maemo/modest-main-window.c:
1343 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1344 Add a notification handler for the HildonProgram::is-topmost property,
1345 so we can allow hibernation when the application goes into the background.
1346 But we still need to detect when the accounts setup windows are open so
1347 we can stop hibernation when they are open.
1348 To do this, I also added the main window the HildonProgram. This might have
1349 other side-effects/benefits, and should maybe be done for other windows.
1351 * src/maemo/modest-osso-autosave-callbacks.h:
1352 * src/maemo/modest-osso-autosave-callbacks.c:
1353 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1354 though it does not do anything yet, and we might never need this to do
1355 anything. For instance, we already save drafts.
1357 * src/maemo/modest-platform.c: (modest_platform_init):
1358 Specify the libosso auto-save callback.
1360 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1362 * src/maemo/modest-platform.c:
1363 (modest_platform_set_update_interval):
1364 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1365 aparently stays valid between application instances, so we can use this
1366 to remove and reset it later. According to a maemo-developers email from
1369 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1371 * configure.ac: Depend on libalarm for Maemo.
1373 * src/dbus_api/modest-dbus-api.h:
1374 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1375 (on_send_receive), (modest_dbus_req_handler):
1376 Handle a SEND_RECEIVE D-Bus method.
1378 * libmodest-dbus-client/libmodest-dbus-client.c:
1379 (libmodest_dbus_client_send_and_receive):
1380 * libmodest-dbus-client/libmodest-dbus-client.h:
1381 Add C convenience functions for calling the new D-Bus method.
1383 * src/modest-platform.h:
1384 * src/gnome/modest-platform.c:
1385 * src/maemo/modest-platform.c:
1386 Added modest_platform_set_update_interval(), which uses the
1387 alarmd API on Maemo.
1388 (modest_platform_init),
1389 Call modest_platform_set_update_interval(), using a hard-coded
1390 interval for now (until the global settings dialog is implemented),
1391 though I am not sure that this makes sense yet.
1393 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1395 * src/dbus_api/modest-dbus-callbacks.c:
1396 (modest_osso_cb_hw_state_handler):
1397 * src/dbus_api/modest-dbus-callbacks.h:
1398 * src/maemo/modest-platform.c: (modest_platform_init):
1399 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1400 in case this has some effect on the ability for Maemo to ping the
1403 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1405 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1406 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1407 warning. It is probably a logic error, but I need to fix the build.
1409 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1411 * src/modest-account-mgr.h:
1412 * src/modest-account-mgr.c:
1413 (modest_account_mgr_account_names): Add a gboolean enabled_only
1414 parameter, so we can get lists of onlt the enabled accounts.
1416 (modest_account_mgr_add_account),,
1417 (modest_account_mgr_account_with_display_name_exists):
1418 * src/maemo/modest-msg-edit-window.c: (get_transports):
1419 * src/modest-account-mgr-helpers.c:
1420 (modest_account_mgr_set_first_account_as_default):
1421 * src/modest-init.c: (init_default_account_maybe):
1422 * src/modest-tny-account-store.c: (get_accounts):
1423 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1424 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1425 * tests/check_account-mgr.c: (START_TEST):
1426 Provide the extra parameter, as appropriate.
1428 * src/widgets/modest-account-view.c: (update_account_view):
1429 Do not show disabled accounts (meaning that there is no way to
1430 enable/disable accounts in the UI (the feature is not in our UI
1431 specification), so we can use this internally only to mark unfinished
1432 or temporary account data.
1434 * src/maemo/easysetup/modest-easysetup-wizard.c:
1435 (create_account): Add boolean enable parameter, so we can specify FALSE
1436 to create the temporary account.
1437 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1438 (on_before_next): When finishing, when there is a temporary account, just
1440 Also, use a timeout to delay the showing of the dialog until gconf is likely
1441 to return correct information, due to a maemo gconf bug that is fixed in
1442 osso 1.1, but not yet in Bora.
1443 However, the dialog stays on screen after it is destroyed.
1445 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1446 for invalid data when cancelling. Use a hildon note instead of a dialog
1447 to complain about invalid data. Do not show the account-saved note if the
1448 account is disabled (a temporary account that will not really be saved for use
1451 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1453 * src/modest-account-mgr-helpers.h:
1454 * src/modest-account-mgr-helpers.c:
1455 Added modest_account_mgr_unset_default_account(),
1456 Added modest_account_mgr_set_first_account_as_default().
1458 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1459 If it was the default account, unset the default account name.
1461 * src/maemo/modest-account-view-window.c:
1462 (on_delete_button_clicked): If it was the default account,
1463 set the first remaining account as the default instead.
1465 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1466 a NULL account or a NULL default account, to prevent a crash. This should
1467 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1470 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1472 * src/widgets/modest-recpt-editor.c:
1473 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1474 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1475 TODO comment for this. This fixes the build.
1477 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1478 be the best place for it. This will in future update all auto-update accounts,
1479 rather than just the current/default account, when that gconf key exists.
1480 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1481 if there are no accounts, before calling do_send_receive().
1482 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1484 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1485 * src/maemo/modest-main-window-ui.h:
1486 * src/maemo/modest-main-window.c: (on_connection_changed),
1487 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1488 directly, becaue the signal handler does more.
1490 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1492 * src/modest-account-mgr-helpers.c:
1493 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1494 for the case that the account does not exist.
1496 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1497 (equivalent to the modest account name) rather than the tinymail account name
1498 (equivalent to the modest account title - human readable) to get the account data.
1499 Check for null account data to prevent the crash, and add a TODO comment saying that
1500 this needs fixing because it is using the server account name instead of the account name.
1502 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1504 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1505 * src/maemo/modest-account-settings-dialog.c: (show_error),
1507 Use hildon_note_new_information() for informative and error messages,
1508 which seems to be expected for Maemo applications (no documentation that I know of
1509 says this). I am surprised that there is no distinction between info and error
1512 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1514 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1515 it is easy to find where this is used.
1517 * src/maemo/easysetup/modest-easysetup-wizard.c:
1518 (create_page_welcome), (create_page_account_details),
1519 (create_page_user_details), (create_page_complete_easysetup),
1520 (create_page_custom_incoming), (create_page_custom_outgoing),
1521 (create_page_complete_custom):
1522 * src/maemo/modest-account-settings-dialog.c:
1523 (create_page_account_details), (create_page_user_details),
1524 (create_page_incoming), (create_page_outgoing):
1525 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1526 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1527 (modest_connection_specific_smtp_edit_window_init):
1528 * src/maemo/modest-connection-specific-smtp-window.c:
1529 (modest_connection_specific_smtp_window_init):
1530 * src/maemo/modest-signature-editor-dialog.c:
1531 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1532 and scrolling policy as per the Email Application Layout Guide, if I have
1535 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1537 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1538 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1539 which were empty, because these vfuncs have been removed from TnyAccountStore.
1540 This fixes the build.
1542 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1544 * src/maemo/modest-main-window.c:
1545 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1546 showing/hiding it. Added TODO because it probably should not be NULL.
1547 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1548 because unnecessary g_warnings() make degugging difficult.
1550 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1552 * src/maemo/modest-msg-edit-window.c:
1553 (modest_msg_edit_window_select_color),
1554 (modest_msg_edit_window_select_background_color): 2 const corrections and
1555 moving 2 #endifs before closing brackets, to fix the build.
1557 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1559 * src/maemo/easysetup/modest-easysetup-wizard.h:
1560 * src/maemo/easysetup/modest-easysetup-wizard.c:
1561 (modest_easysetup_wizard_dialog_finalize),
1562 (on_button_edit_advanced_settings), (create_page_complete_custom),
1563 (on_response), (create_account):
1564 Implement the Advanced Settings edit button, by saving the account information,
1565 for the Advanded Settings dialog to use directly from gconf, and removing it
1566 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1567 Bug #5533 in the projects.maemo.org bugzilla.
1569 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1571 * src/maemo/modest-msg-view-window.c:
1572 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1573 when opening a message window.
1575 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1577 * src/maemo/easysetup/modest-easysetup-wizard.c:
1578 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1581 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1582 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1583 gconf settings. I probably added more checks than necessary, but that is safer.
1585 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1586 variable to fix the build, but this seems to be used when it is still NULL.
1588 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1590 * src/modest-platform.h:
1591 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1592 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1593 * src/modest-main.c: Implement this function so we can avoid using
1594 maemo-specific API from cross-platform code.
1596 * src/modest-tny-account-store.c:
1597 (get_smtp_specific_transport_account_for_open_connection):
1598 * src/modest-ui-actions.c: (check_for_connection),
1599 (modest_ui_actions_on_item_not_found):
1600 Use modest_platform_connect_and_wait() and put #idefs around other
1601 maemo-specific code, because only maemo currently has a way to
1602 identify connection names.
1604 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1606 * src/modest-tny-account-store.h:
1607 * src/modest-tny-account-store.c:
1608 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1609 the connection-specific SMTP server settings in the configuration.
1611 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1613 * src/maemo/modest-main-window.c: (on_connection_changed),
1615 * src/modest-main.c: (main), (start_ui), (send_mail):
1616 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1617 that is what is intended.
1619 * src/modest-ui-actions.c: (action_send), (action_receive),
1620 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1621 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1622 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1623 SMTP server is used when it is specified.
1625 (modest_ui_actions_on_send_receive):
1626 Check that a connection is open before proceeding.
1627 Receive and then send, instead of vice-versa, as per the specification.
1629 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1631 * src/modest-mail-operation.c:
1632 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1633 though I guess it should be something other than NULL.
1635 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1637 * src/maemo/easysetup/modest-easysetup-wizard.c:
1638 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1639 combo twice, to avoid an g_warning and to make it visible again.
1640 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1641 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1642 (already intended) dereference when detaching, because we then recreate the menu.
1643 But I am not sure why the warning was happening, and it is possible that this is a memory
1646 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1648 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1649 and uri_parse_mailto() utility functions.
1650 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1652 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1654 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1656 * src/dbus_api/modest-dbus-api.h:
1657 * src/dbus_api/modest-dbus-callbacks.c:
1658 Use an idle callback to execute the modest code in the application's own thread.
1659 Remove the helloworld example method.
1660 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1661 parsed, and the open-message method is not implemented because this is not yet implemented in
1663 * libmodest-dbus-client/libmodest-dbus-client.c:
1664 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1665 (libmodest_dbus_client_open_message):
1666 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1668 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1669 body without crashing.
1671 * tests/dbus_api/Makefile.am:
1672 * tests/dbus_api/test_mail_to.c:
1673 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1675 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1677 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1678 Added file to fix the build. Sorry.
1680 * src/dbus_api/Makefile.am:
1681 * src/dbus_api/modest-dbus-api.h:
1682 * src/dbus_api/modest-dbus-callbacks.h:
1683 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1684 (modest_dbus_req_handler):
1685 Put constants in a separate header so it can be reused by the
1686 client library, without duplication
1688 * libmodest-dbus-client/Makefile.am:
1689 * libmodest-dbus-client/libmodest-dbus-client.c:
1690 (libmodest_dbus_client_call_helloworld),
1691 (libmodfest_dbus_client_send_mail),
1692 (libmodfest_dbus_client_mailto),
1693 (libmodfest_dbus_client_open_message):
1694 * libmodest-dbus-client/libmodest-dbus-client.h:
1695 (Partly) Implement a send_mail D-Bus method.
1697 * tests/dbus_api/Makefile.am:
1698 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1699 the send_email D-Bus method.
1701 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1705 * libmodest-dbus-client/Makefile.am:
1706 * libmodest-dbus-client/libmodest-dbus-client.c:
1707 * libmodest-dbus-client/libmodest-dbus-client.h:
1708 * tests/dbus_api/Makefile.am:
1709 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1710 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1712 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1714 * src/maemo/easysetup/modest-easysetup-wizard.c:
1715 (create_page_account_details):
1716 * src/maemo/modest-account-settings-dialog.c:
1717 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1718 widgets, because this might not be the default in future versions of the Maemo GTK+.
1719 However, I can not not get capitalization to work even in a simple test case.
1721 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1723 * src/maemo/easysetup/modest-easysetup-wizard.c:
1724 (create_page_custom_incoming), (create_page_custom_outgoing):
1725 * src/maemo/modest-account-settings-dialog.c:
1726 (create_page_account_details), (create_page_incoming),
1727 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1728 instead of using gtk_check_button_with_label(), so they are aligned like the other
1729 widgets, as per the UI spec.
1731 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1733 * src/maemo/easysetup/modest-easysetup-wizard.c:
1734 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1735 * src/widgets/modest-validating-entry.c:
1736 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1737 Modest prefix instead of an EasySetup prefix.
1739 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1741 * src/widgets/modest-validating-entry.h:
1742 * src/widgets/modest-validating-entry.c: (on_insert_text),
1743 Added easysetup_validating_entry_set_max_func(), used to set a callback
1744 to call when the max number of characters is reached. GtkEntry has a max-length
1745 already but is silent about it.
1747 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1748 (create_page_account_details), (create_page_user_details),
1750 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1751 (create_page_account_details), (create_page_user_details),
1752 (create_page_outgoing):
1753 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1754 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1755 the UI spec, when the user tries to enter more than the max number of characters.
1757 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1759 * src/maemo/easysetup/modest-easysetup-wizard.c:
1760 (create_page_user_details), (create_page_custom_incoming),
1761 (create_page_custom_outgoing):
1762 * src/maemo/modest-account-settings-dialog.c:
1763 (create_page_user_details), (create_page_incoming),
1764 (create_page_outgoing):
1765 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1766 (modest_connection_specific_smtp_edit_window_init):
1767 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1768 not appropriate. Bad Maemo-specific defaults!.
1770 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1772 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1773 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1774 (modest_signature_editor_dialog_set_settings):
1775 Disable the label and textview when the checkbox is disabled, and use the
1776 specified (UI spec) default signature text.
1778 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1780 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1781 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1783 * src/modest-defs.h:
1784 * src/modest-account-mgr-helpers.h:
1785 * src/modest-account-mgr-helpers.c:
1786 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1788 * src/maemo/Makefile.am:
1789 * src/maemo/modest-signature-editor-dialog.c:
1790 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1793 * src/maemo/modest-account-settings-dialog.h:
1794 * src/maemo/modest-account-settings-dialog.c:
1795 (modest_account_settings_dialog_finalize), (on_button_signature),
1796 (save_configuration): Use the new dialog when the Edit button is pressed, and
1797 save the changes if necessary, as per the UI spec.
1799 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1801 * src/maemo/Makefile.am:
1802 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1803 based on maemo-develoers email from Dirk.
1805 * src/maemo/easysetup/modest-easysetup-wizard.c:
1806 (create_page_welcome), (create_page_account_details),
1807 (create_page_user_details), (create_page_complete_easysetup),
1808 (create_page_custom_incoming), (create_page_custom_outgoing),
1809 (create_page_complete_custom),
1810 (modest_easysetup_wizard_dialog_init):
1811 * src/maemo/modest-account-settings-dialog.c:
1812 (create_page_account_details), (create_page_user_details),
1813 (create_page_incoming), (create_page_outgoing),
1814 (modest_account_settings_dialog_init):
1815 * src/maemo/modest-connection-specific-smtp-window.c:
1816 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1818 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1820 * src/maemo/easysetup/modest-easysetup-wizard.c:
1821 (create_page_account_details), (create_page_custom_outgoing),
1822 (create_page_complete_custom):
1823 * src/maemo/modest-account-settings-dialog.c:
1824 (create_page_user_details), (create_page_incoming),
1825 (create_page_outgoing):
1826 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1827 (modest_connection_specific_smtp_edit_window_init):
1828 Use the correct (UI spec) port min/max, and use horizontal separators,
1831 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1833 * src/maemo/easysetup/modest-easysetup-wizard.c:
1834 (set_default_custom_servernames):
1835 * src/maemo/modest-account-settings-dialog.c:
1836 (create_page_incoming), (on_combo_outgoing_security_changed),
1837 (on_combo_incoming_security_changed), (create_page_outgoing),
1838 (modest_account_settings_dialog_set_account_name),
1839 (save_configuration):
1840 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1841 (on_combo_security_changed),
1842 (modest_connection_specific_smtp_edit_window_init),
1843 (modest_connection_specific_smtp_edit_window_set_connection),
1844 (modest_connection_specific_smtp_edit_window_get_settings):
1845 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1848 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1851 * src/maemo/easysetup/modest-easysetup-wizard.c:
1852 (create_page_custom_outgoing), (create_page_complete_custom):
1853 * src/maemo/modest-account-settings-dialog.c:
1854 (create_page_user_details), (create_page_outgoing):
1855 * src/maemo/modest-account-view-window.c: (button_box_new):
1856 Use changed logical IDs as per the most recent UI spec:
1857 mcen_bd_emailsetup_edit -> mcen_bd_edit
1858 mcen_bd_emailsetup_delete -> mcen_bd_delete
1859 mcen_bd_emailsetup_close -> mcen_bd_close
1861 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1865 * src/dbus_api/Makefile.am:
1866 * src/dbus_api/modest-dbus-callbacks.c:
1867 * src/dbus_api/modest-dbus-callbacks.h:
1868 * src/maemo/modest-platform.c: (modest_platform_init):
1869 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1871 * tests/Makefile.am:
1872 * tests/dbus_api/Makefile.am:
1873 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1875 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1877 * src/maemo/modest-account-settings-dialog.c:
1878 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1879 Removed unnecessary includes.
1881 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1883 * src/maemo/easysetup/modest-easysetup-wizard.c:
1884 * src/maemo/modest-account-settings-dialog.c:
1885 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1886 * src/widgets/Makefile.am:
1887 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1888 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1889 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1890 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1891 * src/widgets/modest-secureauth-combo-box.c:
1892 * src/widgets/modest-secureauth-combo-box.h:
1893 * src/widgets/modest-serversecurity-combo-box.c:
1894 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1895 made the GObject names more consistent with the rest of the Modest code.
1897 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1899 * src/maemo/easysetup/Makefile.am:
1900 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1901 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1902 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1903 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1904 * src/maemo/easysetup/modest-easysetup-wizard.c:
1905 * src/maemo/easysetup/modest-validating-entry.c:
1906 * src/maemo/easysetup/modest-validating-entry.h:
1907 * src/maemo/modest-account-settings-dialog.c:
1908 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1909 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1910 widgets/ because they are used outside of easysetup too. After checking in,
1911 svn will allow me to rename them too.
1913 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1915 * src/gnome/modest-msg-edit-window.c:
1916 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1917 linker error, to fix the build on the GNOME platform.
1918 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1919 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1920 ifdefed out to avoid a warning.
1922 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1924 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1925 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1926 some alternative for GTK+ 2.6.
1928 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1930 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1932 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1933 specified for EmailAccountsDialog in UI spec.
1935 * src/maemo/easysetup/modest-easysetup-wizard.c:
1936 * src/maemo/easysetup/modest-easysetup-wizard.h:
1937 * src/maemo/modest-account-settings-dialog.c:
1938 * src/maemo/modest-account-settings-dialog.h:
1939 Reuse a member window widget for the connection-specific SMTP server accounts,
1940 so we can tell it to create/save the accounts only if we actually save changes.
1942 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1943 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1944 (modest_connection_specific_smtp_edit_window_get_settings):
1945 Return a struct instance for temporarily remembering the entered data.
1947 * src/maemo/modest-connection-specific-smtp-window.h:
1948 * src/maemo/modest-connection-specific-smtp-window.c:
1949 (modest_connection_specific_smtp_window_finalize),
1950 (modest_connection_specific_smtp_window_fill_with_connections),
1952 (modest_connection_specific_smtp_window_save_server_accounts),
1953 (update_model_server_names): Do not actually save data until asked,
1954 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1956 (on_selection_changed),
1957 (modest_connection_specific_smtp_window_init): Disable the edit
1958 button when nothing is selected.
1960 * src/modest-account-mgr-helpers.c:
1961 * src/modest-account-mgr-helpers.h:
1962 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1965 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1967 * src/modest-account-mgr-helpers.h:
1968 * src/modest-account-mgr-helpers.c:
1969 (modest_account_mgr_get_unused_account_name),
1970 (modest_account_mgr_get_unused_account_display_name): Added these
1971 utility functions, to avoid code duplication.
1973 * src/maemo/easysetup/modest-easysetup-wizard.c:
1974 (create_page_account_details), (create_account):
1975 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1976 (on_combo_security_changed),
1977 (modest_connection_specific_smtp_edit_window_init),
1978 (modest_connection_specific_smtp_edit_window_save_settings):
1979 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1980 * src/maemo/modest-connection-specific-smtp-window.c:
1981 (modest_connection_specific_smtp_window_finalize),
1982 (modest_connection_specific_smtp_window_fill_with_connections),
1983 (on_button_edit), (modest_connection_specific_smtp_window_init):
1984 * src/maemo/modest-connection-specific-smtp-window.h:
1985 Implementing saving of connection-specific server accounts.
1987 But I need to refactor this so we can save the data for each
1988 possible connection-specific account and only actually create the server accounts
1989 when the easysetup finished, or the OK button is pressed on the account settings
1992 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1994 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1995 (on_combo_security_changed):
1996 (modest_connection_specific_smtp_edit_window_init):
1997 Auto-fill the port number as in the account settings.
1999 (modest_connection_specific_smtp_edit_window_set_connection):
2000 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2001 * src/maemo/modest-connection-specific-smtp-window.c:
2002 (fill_with_connections), (on_button_edit),
2003 (modest_connection_specific_smtp_window_init):
2004 Turn the edit window into a dialog to simplify the code, and
2005 set a WM hint as in a GtkDialog, because only a popup can be on top of
2006 another window in Maemo, and popups usually have no WM decoration.
2008 * src/modest-defs.h:
2009 * src/modest-account-mgr-helpers.c:
2010 (modest_account_mgr_set_connection_specific_smtp),
2011 (modest_account_mgr_remove_connection_specific_smtp),
2012 (modest_account_mgr_get_connection_specific_smtp):
2013 * src/modest-account-mgr-helpers.h: Some functions to write the
2014 connection-specific SMTP server information. Not yet used.
2017 * src/widgets/modest-folder-view.c: (text_cell_data):
2018 Fix a warning about an uninitialized variable.
2019 (on_configuration_key_changed): Put an #ifdef around the use
2020 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2022 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2024 * src/maemo/modest-account-settings-dialog.h:
2025 * src/maemo/modest-account-settings-dialog.c:
2026 Added connect_for_modified() utility function to mark the new modified boolean.
2028 (create_page_account_details), (create_page_user_details),
2029 (create_page_incoming), (create_page_outgoing), (on_response),
2030 (modest_account_settings_dialog_init),
2031 (modest_account_settings_dialog_set_account_name):
2032 Only warn about unsaved changes when there are actually unsaved changes.
2034 * src/modest-account-mgr-helpers.c:
2035 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2036 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2037 to get the data from there in future.
2039 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2041 * src/modest-defs.h:
2043 * src/modest-account-mgr-helpers.h:
2044 * src/modest-account-mgr-helpers.c:
2045 Store the security account setting in a single conf key instead of using
2046 the options list, so that the list is left for just the to-be-removed camel hack,
2047 and because gconf_client_set_list() is failing for some reason.
2049 * src/modest-account-mgr.c:
2050 (modest_account_mgr_add_server_account):
2051 * src/maemo/modest-account-settings-dialog.c:
2052 (modest_account_settings_dialog_set_account_name),
2053 (save_configuration): Use the renamed functions.
2056 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2058 * src/widgets/Makefile.am:
2059 * src/widgets/modest-limit-retrieve-combo-box.c:
2060 * src/widgets/modest-limit-retrieve-combo-box.h:
2061 * src/widgets/modest-retrieve-combo-box.c:
2062 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2063 the account settings dialog.
2065 * src/modest-defs.h:
2066 * src/modest-account-mgr-helpers.h:
2067 * src/modest-account-mgr-helpers.c:
2068 (modest_server_account_get_option_secure_auth),
2069 (modest_server_account_set_option_secure_auth):
2070 * src/modest-account-mgr.c:
2071 (modest_account_mgr_add_server_account):
2072 Use the existing AUTH_MECH conf key for the secure-auth setting,
2073 instead of putting it in the list options, because this was actually used already.
2075 * src/maemo/modest-account-settings-dialog.c:
2076 (create_page_account_details),
2077 (modest_account_settings_dialog_set_account_name),
2078 (save_configuration):
2079 * src/maemo/modest-account-settings-dialog.h:
2080 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2081 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2083 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2085 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2086 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2087 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2089 * src/modest-defs.h:
2090 * src/maemo/modest-account-settings-dialog.c:
2091 (create_page_incoming), (on_combo_outgoing_security_changed),
2092 (on_combo_incoming_security_changed), (create_page_outgoing),
2093 (modest_account_settings_dialog_set_account_name),
2094 (save_configuration): Load/Save the port number, and change it when the
2095 security combo changes, to suitable defaults.
2097 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2099 * src/modest-account-mgr.c:
2100 (modest_account_mgr_add_server_account): Set the security and secure-auth
2101 options, and add a comment saying that the other camel-specific options should be
2104 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2106 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2108 * src/modest-tny-account-store.c: (account_list_free),
2109 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2110 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2113 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2115 * src/modest-protocol-info.c:
2116 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2117 is required by our UI spec. Maybe something in our implementation will use this eventually.
2118 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2119 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2120 instead of the previous 0 placeholder.
2122 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2123 secure-auth settings.
2124 * src/modest-account-mgr-helpers.h:
2125 * src/modest-account-mgr-helpers.c:
2126 (modest_server_account_data_get_option_secure_auth),
2127 (modest_server_account_set_option_secure_auth),
2128 (modest_server_account_data_get_option_security),
2129 (modest_server_account_set_option_security): Added this API for getting and setting the security
2130 and secure-auth settings.
2132 * src/maemo/modest-account-settings-dialog.h:
2133 * src/maemo/modest-account-settings-dialog.c:
2134 (modest_account_settings_dialog_finalize), (check_data),
2135 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2136 about changing titles.
2137 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2138 (save_configuration): Save the security and secure-auth settings.
2140 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2141 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2143 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2145 * src/modest-defs.h:
2146 * src/modest-account-mgr.c:
2147 (modest_account_mgr_add_server_account):
2148 Added and used defines for the options key and value pair strings,
2149 that are used so far, though they do not seem to correspond to anything in our
2150 UI specs or ModestProtocol enum.
2152 * src/modest-account-mgr-helpers.h:
2153 * src/modest-account-mgr-helpers.c:
2154 (compare_option_strings_for_name),
2155 (modest_server_account_data_get_option_value),
2156 (modest_server_account_data_get_option_bool),
2157 (modest_account_mgr_get_server_account_option):
2158 Added helper functions for parsing the options GSList.
2160 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2162 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2163 display name is based on the supplied account name.
2164 * src/modest-account-mgr.c:
2165 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2166 with an inefficient, but good-enough, implementation.
2168 * src/maemo/easysetup/modest-easysetup-wizard.c:
2169 (create_page_account_details), (on_before_next), (create_account):
2170 Check for existing display names rather than (non-user-visible) account names, and just
2171 create and set a unique account name at the end.
2173 * src/maemo/modest-account-settings-dialog.c:
2174 (modest_account_settings_dialog_init),
2175 (modest_account_settings_dialog_set_account_name),
2176 (create_page_incoming): Show the display name, instead of the account name.
2177 (on_response): Do some (not all) extra checks, as in the UI spec.
2178 (save_configuration): Save the display name if it was changed.
2180 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2182 * po/en_GB.po: Added needed logical ID and translation.
2183 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2184 (init_view): Made the is-default column clicking work.
2186 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2189 * src/maemo/easysetup/Makefile.am:
2190 * src/maemo/easysetup/modest-easysetup-wizard.c:
2191 (modest_easysetup_wizard_dialog_init):
2192 * src/maemo/easysetup/provider-data-test.keyfile:
2193 * src/maemo/easysetup/provider-data.keyfile:
2194 Moved the provider data file to the new modest-providers-data package and used it from there.
2196 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2198 * src/modest-local-folder-info.c:
2199 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2200 N_() was already used on the static strings, but this just marks it for translation without
2201 using the translation.
2203 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2205 * src/maemo/modest-account-settings-dialog.c:
2206 (create_page_incoming),
2207 (modest_account_settings_dialog_set_account_name):
2208 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2209 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2210 I will do this if nobody else gets there first.
2212 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2214 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2215 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2216 save the security stuff.
2218 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2220 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2221 Set the email address and user fullname, which I now see must be
2224 * src/maemo/modest-account-settings-dialog.h:
2225 * src/maemo/modest-account-settings-dialog.c:
2227 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2228 leave-on-server and authentication.
2229 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2232 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2235 * src/maemo/modest-account-settings-dialog.c:
2236 * src/maemo/modest-account-settings-dialog.h:
2237 Most (but not all) of the widgets are now present as specified by the UI spec.
2238 No changes are yet saved, and some details are not properly shown yet.
2240 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2242 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2244 * src/maemo/Makefile.am:
2245 * src/maemo/modest-account-settings-dialog.c:
2246 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2247 an existing account. Doesn't do much yet.
2249 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2250 Open the accounts settings dialog when Edit is clicked.
2252 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2254 * src/maemo/easysetup/Makefile.am:
2255 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2257 * src/maemo/easysetup/modest-easysetup-wizard.c:
2258 (modest_easysetup_wizard_dialog_init):
2259 Try to get the source directory from the build system,
2260 instead of hard-coding "./" into the source code, when opening our local
2261 copies of the configuration files.
2262 But this still fails when opening the wizard from the Accounts window,
2263 maybe because the working directory seems to change at runtime.
2264 So the wizard will fail the second time unless you copy the files into their
2265 proper locations - see the stdout warnings for the paths.
2267 (create_page_account_details),(on_before_next):
2268 Check for existing non-server accounts instead of server accounts,
2269 so the default account name is useful again, and to prevent trying to
2272 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2273 Show the wizard when New is clicked.
2275 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2276 (init_view): Show the column headers, and show the columns that are
2277 specified in the UI specs. However, something in Maemo's GTK+ prevents
2278 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2279 change the default account. This is despite unsetting the special properties.
2281 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2283 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2284 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2285 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2286 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2287 to make that clearer.
2288 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2290 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2292 * src/maemo/modest-account-view-window.c:
2293 (modest_account_view_window_init),
2294 (modest_account_view_window_new):
2295 Use the same buttons as specified in the
2296 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2297 the existing widgets, which never had a chance of working.
2298 Put the ModestAccountView treeview in a scrolled window.
2299 Do not repeat the initialization in both _init() and _new().
2301 * src/widgets/modest-account-view.c: (update_account_view):
2302 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2303 this widget and window shows no accounts.
2305 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2307 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2309 * src/maemo/easysetup/modest-easysetup-wizard.c:
2310 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2311 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2312 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2315 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2316 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2317 accounts exist yet, as in the UI spec.
2319 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2321 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2323 * src/maemo/Makefile.am:
2324 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2325 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2326 New window for editing connection-specific smtp details.
2327 Not fully implemented.
2329 * src/maemo/modest-connection-specific-smtp-window.c:
2330 (modest_connection_specific_smtp_window_finalize) :
2331 unref the tree model.
2332 (on_button_edit): Show the edit window.
2334 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2336 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2339 * src/maemo/Makefile.am:
2340 * src/maemo/modest-connection-specific-smtp-window.c:
2341 * src/maemo/modest-connection-specific-smtp-window.h:
2342 New window for showing the list of connections, for connection-specific
2343 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2344 * src/maemo/easysetup/modest-easysetup-wizard.c:
2345 (create_page_custom_outgoing): Show the new window when the button is clicked.
2347 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2349 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2350 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2351 * src/maemo/modest-msg-edit-window.c:
2352 (modest_msg_edit_window_insert_image):
2353 * src/modest-conf.c: (modest_conf_key_escape):
2354 * src/modest-mail-operation.c:
2355 (modest_mail_operation_send_new_mail):
2356 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2357 (modest_ui_actions_on_new_account):
2358 * src/widgets/modest-attachment-view.c: (update_filename_request):
2359 * src/widgets/modest-mail-header-view.c:
2360 Corrected warnings that were breaking the build, by commenting out unused variables,
2361 and a function, and by including a header.
2363 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2365 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2366 so we can #ifdef around platform-specific code when necessary.
2367 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2368 to allow this to build for the GNOME platform too.
2370 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2372 * src/maemo/easysetup/modest-easysetup-wizard.c:
2373 Added util_increment_name() and used it in create_page_account_details()
2374 to make sure that the default account name is always a new name.
2376 (modest_easysetup_wizard_dialog_init),
2377 (set_default_custom_servernames): Some minor memory management fixes.
2379 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2383 * src/modest-runtime.c: (init_i18n): Restored the translation
2384 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2385 are defined in config.h, and the translations are installed.
2387 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2388 is defined for translation.
2390 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2392 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2394 * src/maemo/easysetup/modest-easysetup-wizard.c:
2395 (modest_easysetup_wizard_dialog_init):
2396 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2397 Use realistic paths (though they should use $prefix generically) to the
2398 mcc_mapping and provider-data.keyfile files which might work when they
2399 are installed by the future version of the operator-wizard package,
2400 and then fallback to paths in our source code, with an explanatory
2403 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2407 * src/maemo/Makefile.am:
2408 * src/maemo/easysetup/: Added files from the previously-exernal
2409 osso-modest-easysetup.
2410 * src/maemo/modest-main-window-ui.h:
2411 * src/modest-ui-actions.c:
2412 * src/modest-ui-actions.h:
2413 Added modest_ui_actions_on_new_account() as a signal handler for the
2414 New Account menu item. It shows the easysetup wizard.
2415 * po/en_GB.po: Added additional needed logical IDs and translations.
2417 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2418 Apparently ChangeLog is not used for some vague Nokia legal reasons.