git.maemo.org Git - modest/blob - ChangeLog2

   1 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
   2
   3         * src/maemo/easysetup/modest-easysetup-wizard.c:
   4         (create_page_custom_outgoing): Correct the position of the horizontal separator to
   5         match the UI spec.
   6
   7         * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
   8         before showing/hiding them, to avoid a crash when clicking on folders when there are no
   9         gconf settings. I probably added more checks than necessary, but that is safer.
  10
  11         * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
  12         variable to fix the build, but this seems to be used when it is still NULL.
  13
  14 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
  15
  16         * src/modest-platform.h:
  17         * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
  18         * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
  19         * src/modest-main.c: Implement this function so we can avoid using
  20         maemo-specific API from cross-platform code.
  21         (main):
  22         * src/modest-tny-account-store.c:
  23         (get_smtp_specific_transport_account_for_open_connection):
  24         * src/modest-ui-actions.c: (check_for_connection),
  25         (modest_ui_actions_on_item_not_found):
  26         Use modest_platform_connect_and_wait() and put #idefs around other
  27         maemo-specific code, because only maemo currently has a way to
  28         identify connection names.
  29
  30 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
  31
  32         * src/modest-tny-account-store.h:
  33         * src/modest-tny-account-store.c:
  34         Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
  35         the connection-specific SMTP server settings in the configuration.
  36
  37         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
  38         (on_idle_mail_to):
  39         * src/maemo/modest-main-window.c: (on_connection_changed),
  40         (connect_signals):
  41         * src/modest-main.c: (main), (start_ui), (send_mail):
  42         Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
  43         that is what is intended.
  44
  45         * src/modest-ui-actions.c: (action_send), (action_receive),
  46         (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
  47         Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
  48         modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
  49         SMTP server is used when it is specified.
  50
  51         (modest_ui_actions_on_send_receive):
  52         Check that a connection is open before proceeding.
  53         Receive and then send, instead of vice-versa, as per the specification.
  54
  55 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
  56
  57         * src/modest-mail-operation.c:
  58         (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
  59         though I guess it should be something other than NULL.
  60
  61 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
  62
  63         * src/maemo/easysetup/modest-easysetup-wizard.c:
  64         (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
  65         combo twice, to avoid an g_warning and to make it visible again.
  66         * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
  67         attached before detaching it, to avoid a g_warning, and add comment about the implicit
  68         (already intended) dereference when detaching, because we then recreate the menu.
  69         But I am not sure why the warning was happening, and it is possible that this is a memory
  70         leak.
  71
  72 2007-04-25  Murray Cumming  <murrayc@murrayc.com>
  73
  74         * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
  75         and uri_parse_mailto() utility functions.
  76         (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
  77         the mailto URI.
  78         * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
  79
  80 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
  81
  82         * src/dbus_api/modest-dbus-api.h:
  83         * src/dbus_api/modest-dbus-callbacks.c:
  84         Use an idle callback to execute the modest code in the application's own thread.
  85         Remove the helloworld example method.
  86         Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
  87         parsed, and the open-message method is not implemented because this is not yet implemented in
  88         modest itself.
  89         * libmodest-dbus-client/libmodest-dbus-client.c:
  90         (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
  91         (libmodest_dbus_client_open_message):
  92         * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
  93
  94         * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
  95         body without crashing.
  96
  97         * tests/dbus_api/Makefile.am:
  98         * tests/dbus_api/test_mail_to.c:
  99         * tests/dbus_api/test_open_message.c: New tests for the new methods.
 100
 101 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 102
 103         * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
 104         Added file to fix the build. Sorry.
 105
 106         * src/dbus_api/Makefile.am:
 107         * src/dbus_api/modest-dbus-api.h:
 108         * src/dbus_api/modest-dbus-callbacks.h:
 109         * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
 110         (modest_dbus_req_handler):
 111         Put constants in a separate header so it can be reused by the
 112         client library, without duplication
 113
 114         * libmodest-dbus-client/Makefile.am:
 115         * libmodest-dbus-client/libmodest-dbus-client.c:
 116         (libmodest_dbus_client_call_helloworld),
 117         (libmodfest_dbus_client_send_mail),
 118         (libmodfest_dbus_client_mailto),
 119         (libmodfest_dbus_client_open_message):
 120         * libmodest-dbus-client/libmodest-dbus-client.h:
 121         (Partly) Implement a send_mail D-Bus method.
 122
 123         * tests/dbus_api/Makefile.am:
 124         * tests/dbus_api/test_send_mail.c: (main): Added a test for
 125         the send_email D-Bus method.
 126
 127 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 128
 129         * Makefile.am:
 130         * configure.ac:
 131         * libmodest-dbus-client/Makefile.am:
 132         * libmodest-dbus-client/libmodest-dbus-client.c:
 133         * libmodest-dbus-client/libmodest-dbus-client.h:
 134         * tests/dbus_api/Makefile.am:
 135         * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
 136         for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
 137
 138 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 139
 140         * src/maemo/easysetup/modest-easysetup-wizard.c:
 141         (create_page_account_details):
 142         * src/maemo/modest-account-settings-dialog.c:
 143         (create_page_account_details): Explicitly set auto-capitalization mode for the title
 144         widgets, because this might not be the default in future versions of the Maemo GTK+.
 145         However, I can not not get capitalization to work even in a simple test case.
 146
 147 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 148
 149         * src/maemo/easysetup/modest-easysetup-wizard.c:
 150         (create_page_custom_incoming), (create_page_custom_outgoing):
 151         * src/maemo/modest-account-settings-dialog.c:
 152         (create_page_account_details), (create_page_incoming),
 153         (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
 154         instead of using gtk_check_button_with_label(), so they are aligned like the other
 155         widgets, as per the UI spec.
 156
 157 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 158
 159         * src/maemo/easysetup/modest-easysetup-wizard.c:
 160         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 161         * src/widgets/modest-validating-entry.c:
 162         * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
 163         Modest prefix instead of an EasySetup prefix.
 164
 165 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 166
 167         * src/widgets/modest-validating-entry.h:
 168         * src/widgets/modest-validating-entry.c: (on_insert_text),
 169         Added easysetup_validating_entry_set_max_func(), used to set a callback
 170         to call when the max number of characters is reached. GtkEntry has a max-length
 171         already but is silent about it.
 172
 173         * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
 174         (create_page_account_details), (create_page_user_details),
 175         (create_account):
 176         * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
 177         (create_page_account_details), (create_page_user_details),
 178         (create_page_outgoing):
 179         * src/modest-ui-actions.c: (modest_ui_actions_on_details):
 180         Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
 181         the UI spec, when the user tries to enter more than the max number of characters.
 182
 183 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 184
 185         * src/maemo/easysetup/modest-easysetup-wizard.c:
 186         (create_page_user_details), (create_page_custom_incoming),
 187         (create_page_custom_outgoing):
 188         * src/maemo/modest-account-settings-dialog.c:
 189         (create_page_user_details), (create_page_incoming),
 190         (create_page_outgoing):
 191         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 192         (modest_connection_specific_smtp_edit_window_init):
 193         Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
 194         not appropriate. Bad Maemo-specific defaults!.
 195
 196 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 197
 198         * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
 199         (on_toggle_button_changed), (modest_signature_editor_dialog_init),
 200         (modest_signature_editor_dialog_set_settings):
 201         Disable the label and textview when the checkbox is disabled, and use the
 202         specified (UI spec) default signature text.
 203
 204 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 205
 206         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 207         (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
 208
 209         * src/modest-defs.h:
 210         * src/modest-account-mgr-helpers.h:
 211         * src/modest-account-mgr-helpers.c:
 212         Added modest_account_mgr_get/set_signature(), using new gconf keys.
 213
 214         * src/maemo/Makefile.am:
 215         * src/maemo/modest-signature-editor-dialog.c:
 216         * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
 217         as per the UI spec.
 218
 219         * src/maemo/modest-account-settings-dialog.h:
 220         * src/maemo/modest-account-settings-dialog.c:
 221         (modest_account_settings_dialog_finalize), (on_button_signature),
 222         (save_configuration): Use the new dialog when the Edit button is pressed, and
 223         save the changes if necessary, as per the UI spec.
 224
 225 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 226
 227         * src/maemo/Makefile.am:
 228         * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
 229         based on maemo-develoers email from Dirk.
 230
 231         * src/maemo/easysetup/modest-easysetup-wizard.c:
 232         (create_page_welcome), (create_page_account_details),
 233         (create_page_user_details), (create_page_complete_easysetup),
 234         (create_page_custom_incoming), (create_page_custom_outgoing),
 235         (create_page_complete_custom),
 236         (modest_easysetup_wizard_dialog_init):
 237         * src/maemo/modest-account-settings-dialog.c:
 238         (create_page_account_details), (create_page_user_details),
 239         (create_page_incoming), (create_page_outgoing),
 240         (modest_account_settings_dialog_init):
 241         * src/maemo/modest-connection-specific-smtp-window.c:
 242         (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
 243
 244 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 245
 246         * src/maemo/easysetup/modest-easysetup-wizard.c:
 247         (create_page_account_details), (create_page_custom_outgoing),
 248         (create_page_complete_custom):
 249         * src/maemo/modest-account-settings-dialog.c:
 250         (create_page_user_details), (create_page_incoming),
 251         (create_page_outgoing):
 252         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 253         (modest_connection_specific_smtp_edit_window_init):
 254         Use the correct (UI spec) port min/max, and use horizontal separators,
 255         as per the UI spec.
 256
 257 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 258
 259         * src/maemo/easysetup/modest-easysetup-wizard.c:
 260         (set_default_custom_servernames):
 261         * src/maemo/modest-account-settings-dialog.c:
 262         (create_page_incoming), (on_combo_outgoing_security_changed),
 263         (on_combo_incoming_security_changed), (create_page_outgoing),
 264         (modest_account_settings_dialog_set_account_name),
 265         (save_configuration):
 266         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 267         (on_combo_security_changed),
 268         (modest_connection_specific_smtp_edit_window_init),
 269         (modest_connection_specific_smtp_edit_window_set_connection),
 270         (modest_connection_specific_smtp_edit_window_get_settings):
 271         Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
 272         as per the UI spec.
 273
 274 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 275
 276         * po/en_GB.po:
 277         * src/maemo/easysetup/modest-easysetup-wizard.c:
 278         (create_page_custom_outgoing), (create_page_complete_custom):
 279         * src/maemo/modest-account-settings-dialog.c:
 280         (create_page_user_details), (create_page_outgoing):
 281         * src/maemo/modest-account-view-window.c: (button_box_new):
 282         Use changed logical IDs as per the most recent UI spec:
 283         mcen_bd_emailsetup_edit -> mcen_bd_edit
 284         mcen_bd_emailsetup_delete -> mcen_bd_delete
 285         mcen_bd_emailsetup_close -> mcen_bd_close
 286
 287 2007-04-20  2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 288
 289         * configure.ac:
 290         * src/Makefile.am:
 291         * src/dbus_api/Makefile.am:
 292         * src/dbus_api/modest-dbus-callbacks.c:
 293         * src/dbus_api/modest-dbus-callbacks.h:
 294         * src/maemo/modest-platform.c: (modest_platform_init):
 295         Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
 296         method.
 297         * tests/Makefile.am:
 298         * tests/dbus_api/Makefile.am:
 299         * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
 300
 301 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 302
 303         * src/maemo/modest-account-settings-dialog.c:
 304         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 305         Removed unnecessary includes.
 306
 307 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 308
 309         * src/maemo/easysetup/modest-easysetup-wizard.c:
 310         * src/maemo/modest-account-settings-dialog.c:
 311         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 312         * src/widgets/Makefile.am:
 313         * src/widgets/modest-easysetup-secureauth-combo-box.c:
 314         * src/widgets/modest-easysetup-secureauth-combo-box.h:
 315         * src/widgets/modest-easysetup-serversecurity-combo-box.c:
 316         * src/widgets/modest-easysetup-serversecurity-combo-box.h:
 317         * src/widgets/modest-secureauth-combo-box.c:
 318         * src/widgets/modest-secureauth-combo-box.h:
 319         * src/widgets/modest-serversecurity-combo-box.c:
 320         * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
 321         made the GObject names more consistent with the rest of the Modest code.
 322
 323 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 324
 325         * src/maemo/easysetup/Makefile.am:
 326         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 327         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
 328         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 329         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 330         * src/maemo/easysetup/modest-easysetup-wizard.c:
 331         * src/maemo/easysetup/modest-validating-entry.c:
 332         * src/maemo/easysetup/modest-validating-entry.h:
 333         * src/maemo/modest-account-settings-dialog.c:
 334         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 335         * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
 336         widgets/ because they are used outside of easysetup too. After checking in,
 337         svn will allow me to rename them too.
 338
 339 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 340
 341         * src/gnome/modest-msg-edit-window.c:
 342         (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
 343         linker error, to fix the build on the GNOME platform.
 344         modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
 345         modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
 346         ifdefed out to avoid a warning.
 347
 348 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 349
 350         * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
 351         use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
 352         some alternative for GTK+ 2.6.
 353
 354 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 355
 356         * src/maemo/modest-address-book.c: Added include to avoid a warning.
 357
 358         * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
 359         specified for EmailAccountsDialog in UI spec.
 360
 361         * src/maemo/easysetup/modest-easysetup-wizard.c:
 362         * src/maemo/easysetup/modest-easysetup-wizard.h:
 363         * src/maemo/modest-account-settings-dialog.c:
 364         * src/maemo/modest-account-settings-dialog.h:
 365         Reuse a member window widget for the connection-specific SMTP server accounts,
 366         so we can tell it to create/save the accounts only if we actually save changes.
 367
 368         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 369         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 370         (modest_connection_specific_smtp_edit_window_get_settings):
 371         Return a struct instance for temporarily remembering the entered data.
 372
 373         * src/maemo/modest-connection-specific-smtp-window.h:
 374         * src/maemo/modest-connection-specific-smtp-window.c:
 375         (modest_connection_specific_smtp_window_finalize),
 376         (modest_connection_specific_smtp_window_fill_with_connections),
 377         (on_button_edit),
 378         (modest_connection_specific_smtp_window_save_server_accounts),
 379         (update_model_server_names): Do not actually save data until asked,
 380         when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
 381
 382         (on_selection_changed),
 383         (modest_connection_specific_smtp_window_init): Disable the edit
 384         button when nothing is selected.
 385
 386         * src/modest-account-mgr-helpers.c:
 387         * src/modest-account-mgr-helpers.h:
 388         Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
 389         elsewhere.
 390
 391 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 392
 393         * src/modest-account-mgr-helpers.h:
 394         * src/modest-account-mgr-helpers.c:
 395         (modest_account_mgr_get_unused_account_name),
 396         (modest_account_mgr_get_unused_account_display_name): Added these
 397         utility functions, to avoid code duplication.
 398
 399         * src/maemo/easysetup/modest-easysetup-wizard.c:
 400         (create_page_account_details), (create_account):
 401         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 402         (on_combo_security_changed),
 403         (modest_connection_specific_smtp_edit_window_init),
 404         (modest_connection_specific_smtp_edit_window_save_settings):
 405         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 406         * src/maemo/modest-connection-specific-smtp-window.c:
 407         (modest_connection_specific_smtp_window_finalize),
 408         (modest_connection_specific_smtp_window_fill_with_connections),
 409         (on_button_edit), (modest_connection_specific_smtp_window_init):
 410         * src/maemo/modest-connection-specific-smtp-window.h:
 411         Implementing saving of connection-specific server accounts.
 412
 413         But I need to refactor this so we can save the data for each
 414         possible connection-specific account and only actually create the server accounts
 415         when the easysetup finished, or the OK button is pressed on the account settings
 416         dialog.
 417
 418 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 419
 420         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 421         (on_combo_security_changed):
 422         (modest_connection_specific_smtp_edit_window_init):
 423         Auto-fill the port number as in the account settings.
 424
 425         (modest_connection_specific_smtp_edit_window_set_connection):
 426         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 427         * src/maemo/modest-connection-specific-smtp-window.c:
 428         (fill_with_connections), (on_button_edit),
 429         (modest_connection_specific_smtp_window_init):
 430         Turn the edit window into a dialog to simplify the code, and
 431         set a WM hint as in a GtkDialog, because only a popup can be on top of
 432         another window in Maemo, and popups usually have no WM decoration.
 433
 434         * src/modest-defs.h:
 435         * src/modest-account-mgr-helpers.c:
 436         (modest_account_mgr_set_connection_specific_smtp),
 437         (modest_account_mgr_remove_connection_specific_smtp),
 438         (modest_account_mgr_get_connection_specific_smtp):
 439         * src/modest-account-mgr-helpers.h: Some functions to write the
 440         connection-specific SMTP server information. Not yet used.
 441
 442
 443         * src/widgets/modest-folder-view.c: (text_cell_data):
 444         Fix a warning about an uninitialized variable.
 445         (on_configuration_key_changed): Put an #ifdef around the use
 446         of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
 447
 448 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 449
 450         * src/maemo/modest-account-settings-dialog.h:
 451         * src/maemo/modest-account-settings-dialog.c:
 452         Added connect_for_modified() utility function to mark the new modified boolean.
 453
 454         (create_page_account_details), (create_page_user_details),
 455         (create_page_incoming), (create_page_outgoing), (on_response),
 456         (modest_account_settings_dialog_init),
 457         (modest_account_settings_dialog_set_account_name):
 458         Only warn about unsaved changes when there are actually unsaved changes.
 459
 460         * src/modest-account-mgr-helpers.c:
 461         * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
 462         into the ModestServerAccountData struct. I do not use it yet, but someone might expect
 463         to get the data from there in future.
 464
 465 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 466
 467         * src/modest-defs.h:
 468
 469         * src/modest-account-mgr-helpers.h:
 470         * src/modest-account-mgr-helpers.c:
 471         Store the security account setting in a single conf key instead of using
 472         the options list, so that the list is left for just the to-be-removed camel hack,
 473         and because gconf_client_set_list() is failing for some reason.
 474
 475         * src/modest-account-mgr.c:
 476         (modest_account_mgr_add_server_account):
 477         * src/maemo/modest-account-settings-dialog.c:
 478         (modest_account_settings_dialog_set_account_name),
 479         (save_configuration): Use the renamed functions.
 480
 481
 482 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 483
 484         * src/widgets/Makefile.am:
 485         * src/widgets/modest-limit-retrieve-combo-box.c:
 486         * src/widgets/modest-limit-retrieve-combo-box.h:
 487         * src/widgets/modest-retrieve-combo-box.c:
 488         * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
 489         the account settings dialog.
 490
 491         * src/modest-defs.h:
 492         * src/modest-account-mgr-helpers.h:
 493         * src/modest-account-mgr-helpers.c:
 494         (modest_server_account_get_option_secure_auth),
 495         (modest_server_account_set_option_secure_auth):
 496         * src/modest-account-mgr.c:
 497         (modest_account_mgr_add_server_account):
 498         Use the existing AUTH_MECH conf key for the secure-auth setting,
 499         instead of putting it in the list options, because this was actually used already.
 500
 501         * src/maemo/modest-account-settings-dialog.c:
 502         (create_page_account_details),
 503         (modest_account_settings_dialog_set_account_name),
 504         (save_configuration):
 505         * src/maemo/modest-account-settings-dialog.h:
 506         Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
 507         Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
 508
 509 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 510
 511         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 512         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 513         Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
 514
 515         * src/modest-defs.h:
 516         * src/maemo/modest-account-settings-dialog.c:
 517         (create_page_incoming), (on_combo_outgoing_security_changed),
 518         (on_combo_incoming_security_changed), (create_page_outgoing),
 519         (modest_account_settings_dialog_set_account_name),
 520         (save_configuration): Load/Save the port number, and change it when the
 521         security combo changes, to suitable defaults.
 522
 523 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 524
 525         * src/modest-account-mgr.c:
 526         (modest_account_mgr_add_server_account): Set the security and secure-auth
 527         options, and add a comment saying that the other camel-specific options should be
 528         removed in future.
 529
 530 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 531
 532         * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
 533         found by valgrind.
 534         * src/modest-tny-account-store.c: (account_list_free),
 535         (on_account_changed): Add a TODO comment about a valgrind error, caused by using
 536         cursor->data after unreffing it. But there is some strange stuff there so it might not be
 537         easy to fix.
 538
 539 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 540
 541         * src/modest-protocol-info.c:
 542         * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
 543         is required by our UI spec. Maybe something in our implementation will use this eventually.
 544         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 545         (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
 546         instead of the previous 0 placeholder.
 547
 548         * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
 549         secure-auth settings.
 550         * src/modest-account-mgr-helpers.h:
 551         * src/modest-account-mgr-helpers.c:
 552         (modest_server_account_data_get_option_secure_auth),
 553         (modest_server_account_set_option_secure_auth),
 554         (modest_server_account_data_get_option_security),
 555         (modest_server_account_set_option_security): Added this API for getting and setting the security
 556         and secure-auth settings.
 557
 558         * src/maemo/modest-account-settings-dialog.h:
 559         * src/maemo/modest-account-settings-dialog.c:
 560         (modest_account_settings_dialog_finalize), (check_data),
 561         (on_response): Store the original title as well as the name, to avoid unnececessary warnings
 562         about changing titles.
 563         (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
 564         (save_configuration): Save the security and secure-auth settings.
 565
 566         * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
 567         is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
 568
 569 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 570
 571         * src/modest-defs.h:
 572         * src/modest-account-mgr.c:
 573         (modest_account_mgr_add_server_account):
 574         Added and used defines for the options key and value pair strings,
 575         that are used so far, though they do not seem to correspond to anything in our
 576         UI specs or ModestProtocol enum.
 577
 578         * src/modest-account-mgr-helpers.h:
 579         * src/modest-account-mgr-helpers.c:
 580         (compare_option_strings_for_name),
 581         (modest_server_account_data_get_option_value),
 582         (modest_server_account_data_get_option_bool),
 583         (modest_account_mgr_get_server_account_option):
 584         Added helper functions for parsing the options GSList.
 585
 586 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 587
 588         * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
 589         display name is based on the supplied account name.
 590         * src/modest-account-mgr.c:
 591         * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
 592         with an inefficient, but good-enough, implementation.
 593
 594         * src/maemo/easysetup/modest-easysetup-wizard.c:
 595         (create_page_account_details), (on_before_next), (create_account):
 596         Check for existing display names rather than (non-user-visible) account names, and just
 597         create and set a unique account name at the end.
 598
 599         * src/maemo/modest-account-settings-dialog.c:
 600         (modest_account_settings_dialog_init),
 601         (modest_account_settings_dialog_set_account_name),
 602         (create_page_incoming): Show the display name, instead of the account name.
 603         (on_response): Do some (not all) extra checks, as in the UI spec.
 604         (save_configuration): Save the display name if it was changed.
 605
 606 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 607
 608         * po/en_GB.po: Added needed logical ID and translation.
 609         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 610         (init_view): Made the is-default column clicking work.
 611
 612 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 613
 614         * configure.ac:
 615         * src/maemo/easysetup/Makefile.am:
 616         * src/maemo/easysetup/modest-easysetup-wizard.c:
 617         (modest_easysetup_wizard_dialog_init):
 618         * src/maemo/easysetup/provider-data-test.keyfile:
 619         * src/maemo/easysetup/provider-data.keyfile:
 620         Moved the provider data file to the new modest-providers-data package and used it from there.
 621
 622 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 623
 624         * src/modest-local-folder-info.c:
 625         (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
 626         N_() was already used on the static strings, but this just marks it for translation without
 627         using the translation.
 628
 629 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 630
 631         * src/maemo/modest-account-settings-dialog.c:
 632         (create_page_incoming),
 633         (modest_account_settings_dialog_set_account_name):
 634         Added comments about the need for new API in ModestAccountMgr to handle the authentication
 635         and secure-connection stuff that is stored in the options GSList* with hard-coded names.
 636         I will do this if nobody else gets there first.
 637
 638 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 639
 640         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
 641         Saved much of the incoming and outgoing data too, though I cannot yet see how to
 642         save the security stuff.
 643
 644 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 645
 646         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 647         Set the email address and user fullname, which I now see must be
 648         done separately.
 649
 650         * src/maemo/modest-account-settings-dialog.h:
 651         * src/maemo/modest-account-settings-dialog.c:
 652          (on_response),
 653         (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
 654         leave-on-server and authentication.
 655         (save_configuration): Save most of the non-server-account specific stuff, but I don't see
 656         how to do the rest.
 657
 658 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 659
 660
 661         * src/maemo/modest-account-settings-dialog.c:
 662         * src/maemo/modest-account-settings-dialog.h:
 663         Most (but not all) of the widgets are now present as specified by the UI spec.
 664         No changes are yet saved, and some details are not properly shown yet.
 665
 666         * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
 667
 668 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 669
 670         * src/maemo/Makefile.am:
 671         * src/maemo/modest-account-settings-dialog.c:
 672         * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
 673         an existing account. Doesn't do much yet.
 674
 675         * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
 676         Open the accounts settings dialog when Edit is clicked.
 677
 678 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 679
 680         * src/maemo/easysetup/Makefile.am:
 681         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
 682         (load_from_file):
 683         * src/maemo/easysetup/modest-easysetup-wizard.c:
 684         (modest_easysetup_wizard_dialog_init):
 685         Try to get the source directory from the build system,
 686         instead of hard-coding "./" into the source code, when opening our local
 687         copies of the configuration files.
 688         But this still fails when opening the wizard from the Accounts window,
 689         maybe because the working directory seems to change at runtime.
 690         So the wizard will fail the second time unless you copy the files into their
 691         proper locations - see the stdout warnings for the paths.
 692
 693         (create_page_account_details),(on_before_next):
 694         Check for existing non-server accounts instead of server accounts,
 695         so the default account name is useful again, and to prevent trying to
 696         recreate accounts.
 697
 698         * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
 699         Show the wizard when New is clicked.
 700
 701         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 702         (init_view): Show the column headers, and show the columns that are
 703         specified in the UI specs. However, something in Maemo's GTK+ prevents
 704         us from handling the GtkCellRendererToggle::toggled signal, so we cannot
 705         change the default account. This is despite unsetting the special properties.
 706
 707 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 708
 709         * docs/reference/modest-design.sgml: Corrected spelling mistake.
 710         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 711         Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
 712         This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
 713         to make that clearer.
 714         * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
 715
 716 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 717
 718         * src/maemo/modest-account-view-window.c:
 719         (modest_account_view_window_init),
 720         (modest_account_view_window_new):
 721         Use the same buttons as specified in the
 722         UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
 723         the existing widgets, which never had a chance of working.
 724         Put the ModestAccountView treeview in a scrolled window.
 725         Do not repeat the initialization in both _init() and _new().
 726
 727         * src/widgets/modest-account-view.c: (update_account_view):
 728         Add a warning about modest_account_mgr_account_names() returning NULL, which is why
 729         this widget and window shows no accounts.
 730
 731         * po/en_GB.po: Added translations needed for the dialog button logical IDs.
 732
 733 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 734
 735         * src/maemo/easysetup/modest-easysetup-wizard.c:
 736         (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
 737         (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
 738         returns NULL after modest_account_mgr_add_server_account() returned TRUE,
 739         which seems wrong.
 740
 741         * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
 742         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
 743         accounts exist yet, as in the UI spec.
 744
 745         * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
 746
 747 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 748
 749         * src/maemo/Makefile.am:
 750         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 751         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 752         New window for editing connection-specific smtp details.
 753         Not fully implemented.
 754
 755         * src/maemo/modest-connection-specific-smtp-window.c:
 756         (modest_connection_specific_smtp_window_finalize) :
 757         unref the tree model.
 758         (on_button_edit): Show the edit window.
 759
 760 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 761
 762         * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
 763         error for me.
 764
 765         * src/maemo/Makefile.am:
 766         * src/maemo/modest-connection-specific-smtp-window.c:
 767         * src/maemo/modest-connection-specific-smtp-window.h:
 768         New window for showing the list of connections, for connection-specific
 769         SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
 770         * src/maemo/easysetup/modest-easysetup-wizard.c:
 771         (create_page_custom_outgoing): Show the new window when the button is clicked.
 772
 773 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 774
 775         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 776         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
 777         * src/maemo/modest-msg-edit-window.c:
 778         (modest_msg_edit_window_insert_image):
 779         * src/modest-conf.c: (modest_conf_key_escape):
 780         * src/modest-mail-operation.c:
 781         (modest_mail_operation_send_new_mail):
 782         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
 783         (modest_ui_actions_on_new_account):
 784         * src/widgets/modest-attachment-view.c: (update_filename_request):
 785         * src/widgets/modest-mail-header-view.c:
 786         Corrected warnings that were breaking the build, by commenting out unused variables,
 787         and a function, and by including a header.
 788
 789 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 790
 791         * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
 792         so we can #ifdef around platform-specific code when necessary.
 793         * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
 794         to allow this to build for the GNOME platform too.
 795
 796 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 797
 798         * src/maemo/easysetup/modest-easysetup-wizard.c:
 799         Added util_increment_name() and used it in create_page_account_details()
 800         to make sure that the default account name is always a new name.
 801
 802         (modest_easysetup_wizard_dialog_init),
 803         (set_default_custom_servernames): Some minor memory management fixes.
 804
 805 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 806
 807         * Makefile.am:
 808         * configure.ac:
 809         * src/modest-runtime.c: (init_i18n): Restored the translation
 810         infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
 811         are defined in config.h, and the translations are installed.
 812
 813         * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
 814         is defined for translation.
 815
 816 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
 817
 818         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
 819         (load_from_file):
 820         * src/maemo/easysetup/modest-easysetup-wizard.c:
 821         (modest_easysetup_wizard_dialog_init):
 822         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
 823         Use realistic paths (though they should use $prefix generically) to the
 824         mcc_mapping and provider-data.keyfile files which might work when they
 825         are installed by the future version of the operator-wizard package,
 826         and then fallback to paths in our source code, with an explanatory
 827         warning.
 828
 829 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
 830
 831         * configure.ac:
 832         * src/Makefile.am:
 833         * src/maemo/Makefile.am:
 834         * src/maemo/easysetup/: Added files from the previously-exernal
 835         osso-modest-easysetup.
 836         * src/maemo/modest-main-window-ui.h:
 837         * src/modest-ui-actions.c:
 838         * src/modest-ui-actions.h:
 839         Added modest_ui_actions_on_new_account() as a signal handler for the
 840         New Account menu item. It shows the easysetup wizard.
 841         * po/en_GB.po: Added additional needed logical IDs and translations.
 842
 843 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
 844 Apparently ChangeLog is not used for some vague Nokia legal reasons.
 845