1 2007-07-12 Murray Cumming <murrayc@murrayc.com>
3 * src/dbus_api/modest-dbus-callbacks.c:
4 (on_idle_open_message): If the message is in drafts then open it
5 in an edit window instead of a view window. This fixes
6 projects.maemo.org bug NB#63005.
8 2007-07-12 Murray Cumming <murrayc@murrayc.com>
10 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
11 Avoided a harmless g_warning().
13 2007-07-12 Murray Cumming <murrayc@murrayc.com>
15 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
16 Pass the modest account name, not the TnyAccount display name to
17 modest_msg_view_window_new() so that the reply feature works,
18 fixing projects.maemo.org bug NB#62892.
20 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
21 (modest_msg_view_window_new_with_header_model):
22 * src/maemo/modest-msg-view-window.c:
23 (modest_msg_view_window_new_with_header_model),
24 (modest_msg_view_window_new):
25 * src/modest-ui-actions.c: (reply_forward):
26 * src/widgets/modest-msg-view-window.h:
27 * src/widgets/modest-window.c: (modest_window_set_active_account):
28 Rename an account parameter to modest_account_name to make this clearer.
30 2007-07-11 Murray Cumming <murrayc@murrayc.com>
32 * src/modest-ui-actions.h:
33 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
34 modest_do_message_delete().
35 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
36 Call modest_do_message_delete(), hoping that this would cause messages
37 to be really deleted from search instead of just marked with strike through.
38 Does not seem to help.
40 2007-07-11 Armin Burgmeier <armin@openismus.com>
42 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
43 priv->reselect to FALSE prior to calling
44 modest_folder_view_select_first_inbox_or_local() to prevent endless
45 recursion and thus a crash on startup.
47 2007-07-11 Armin Burgmeier <armin@openismus.com>
49 * src/maemo/modest-account-settings-dialog.h: Include
50 <gtk/gtknotebook.h> to fix the build (at least for me).
52 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
53 Use "New FolderN" as default suggested name if "New folder" already
54 exists, with N being the first free number, though never exceed "New
55 folder99" in which case we just fall back to "New Folder" even though
56 it already exists. This fixes projects.maemo.org bug NB#58663.
58 2007-07-11 Murray Cumming <murrayc@murrayc.com>
60 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
61 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
62 projects.maemo.org bug NB#62778.
64 2007-07-11 Murray Cumming <murrayc@murrayc.com>
66 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
67 Ignore the wrong (for now) secure-smtp setting in the presets -
68 just default to requiring secure authentication for SMTP, because
71 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
73 * src/widgets/modest-folder-view.c: (filter_row)
74 Do not show drafts folder (see UI specs)
76 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
78 * src/modest-ui-actions.c:
79 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
80 place and also not necessary.
82 * src/widgets/modest-folder-view.c: (filter_row)
83 Guess folder type and hide Sent & Outbox if necessary.
84 Fixed project.maemo.org NB#57328
86 2007-07-11 Murray Cumming <murrayc@murrayc.com>
88 * src/modest-ui-actions.h:
89 * src/modest-ui-actions.c:
90 (modest_ui_actions_on_delete_message):
91 Move some code into a new
92 modest_ui_actions_refresh_message_window_after_delete()
93 function so we can use it from elsewhere.
95 * src/dbus_api/modest-dbus-callbacks.c:
96 (on_idle_delete_message), (on_delete_message): Used an idle
97 handler, as we do for the other D-Bus method handlers.
98 Call modest_ui_actions_refresh_message_window_after_delete()
99 if the deleted message was open in a window. This fixed
100 projects.maemo.org bug NB#62862.
102 2007-07-11 Murray Cumming <murrayc@murrayc.com>
104 * src/modest-main.c: (main): Only show the UI at the start if
105 the showui command line option was given. For instance,
106 run-standalone src/modest showui
107 Otherwise, we wait for the top_application D-Bus method to
108 be sent by hildon-desktop when the application is selected
110 This allows us to run without a UI when osso-global-search
111 uses our D-Bus methods.
113 2007-07-11 Murray Cumming <murrayc@murrayc.com>
115 * src/dbus_api/modest-dbus-api.h: Added a define for a
116 top-application D-Bus method.
117 * src/dbus_api/modest-dbus-callbacks.c:
118 (on_top_application),
119 (modest_dbus_req_handler): Handle the top-application D-Bus
120 method, which might be an undocumented D-Bus signal sent by
121 hildon-desktop when it starts the application from the menu.
122 But I am not sure and I need to test it on the device, because
123 my scratchbox does not have the application in the menu now.
124 This method shows the main window, so that it can be invisible
125 when started, for instance, just for email searching from
128 * src/maemo/modest-main-window.c: (restore_settings),
129 (modest_main_window_new): Do not show the window immediately
130 upon creation. We show it later.
131 * src/modest-widget-memory.c: (save_settings_paned):
132 Try (unsuccessfully) to avoid saving the paned position when
133 it is not even visible.
134 (restore_settings_paned): Do not allow a silly paned position.
135 This seems necessary when not showing the window at first.
137 * tests/dbus_api/Makefile.am:
138 * tests/dbus_api/test_top_application.c: (main): Test for the
141 2007-07-10 Murray Cumming <murrayc@murrayc.com>
143 * src/modest-ui-dimming-rules.c:
144 (modest_ui_dimming_rules_on_new_msg),
145 (modest_ui_dimming_rules_on_reply_msg),
146 (modest_ui_dimming_rules_on_delete_msg),
147 (modest_ui_dimming_rules_on_details),
148 (modest_ui_dimming_rules_on_view_window_move_to),
149 (modest_ui_dimming_rules_on_view_previous),
150 (modest_ui_dimming_rules_on_view_next),
151 (_invalid_folder_for_purge): Added checks before
152 casting the window. This looks like an actual
153 logic error in _invalid_folder_for_purge(), because it
154 tries to use a ModestMainWindow as a message window.
156 2007-07-10 Murray Cumming <murrayc@murrayc.com>
158 * src/maemo/modest-account-settings-dialog.c:
159 (show_error): Use the same implementation as in
160 modest-easysetup-wizard.c:
161 (on_entry_invalid_character): The logical ID contains a %s.
162 Guessed what it should be.
163 (on_entry_max), (check_data), (on_response): Adapt to
164 changed show_error().
165 (create_page_account_details): Really call
166 modest_validating_entry_set_func() on the correct widgets.
167 * src/maemo/easysetup/modest-easysetup-wizard.c:
168 (on_entry_invalid_character): Fix the logical ID here too.
169 (create_page_account_details),
170 (create_page_user_details):
172 modest_validating_entry_set_func() on the correct widgets.
174 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
175 Do not try to use the account if it is NULL.
177 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
179 * src/modest-ui-actions.c: (create_move_to_dialog),
180 (modest_ui_actions_on_main_window_move_to),
181 (modest_ui_actions_on_msg_view_window_move_to):
182 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
183 (filter_row), (modest_folder_view_show_non_move_folders):
184 * src/widgets/modest-folder-view.h:
186 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
187 the Sent folder yet as it does not report the correct folder type.
189 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
191 * src/maemo/modest-msg-edit-window.c: (init_window):
194 2007-07-10 Murray Cumming <murrayc@murrayc.com>
196 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
197 Take a parent widget instead of a parent window, and
198 implement this with hildon_banner_show_information() instead.
199 Non-Maemo builds can just ifdef that there.
200 This fixed projects.maemo.org bug NB#62766.
202 (on_entry_invalid_character): Use show_error() again instead
203 of using hildon directly, and use the _CS() macro to use the correct
205 (create_account), (check_for_supported_auth_methods), (on_entry_max):
206 Pass a widget instead od a window to show_error().
208 2007-07-10 Murray Cumming <murrayc@murrayc.com>
210 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
211 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
212 This allows us to show the server name in the error message, fixing
213 projects.maemo.org bug NB#62904.
214 Also, use the appropriate logical ID message for the account protocol.
216 2007-07-10 Murray Cumming <murrayc@murrayc.com>
218 * src/modest-tny-account-store.c: (on_idle_wrong_password):
219 A compilation fix, though the build wasn't broken for me.
221 2007-07-09 Murray Cumming <murrayc@murrayc.com>
223 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
224 Do not try to unref a NULL folder store, to avoid a runtime warning.
225 This seems to happen sometimes when changing accounts settings.
227 2007-07-09 Murray Cumming <murrayc@murrayc.com>
229 * src/modest-tny-account-store.c:
230 (modest_tny_account_store_instance_init),
231 (modest_tny_account_store_finalize),
232 (on_account_settings_hide), (on_idle_wrong_password):
233 Use a GHashTable to ensure that we only show one account settings
234 dialog per modest account. This avoids us having a dialog open for
235 both the store and transport accounts, or due to repeated get_password()
236 calls that shouldn't happen anyway.
238 2007-07-09 Murray Cumming <murrayc@murrayc.com>
240 * src/maemo/modest-maemo-utils.c: (on_hide),
241 (modest_maemo_show_dialog_and_forget): Handle the response, because
242 the window is not even hidden by default.
244 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
245 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
246 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
247 which seems to prevent some modality problems.
249 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
250 Ignore user cancellation errors.
252 * src/modest-account-mgr-helpers.h:
253 * src/modest-account-mgr-helpers.c:
254 Added modest_server_account_get_password() and
255 modest_server_account_get_has_password() to avoid direct use of
258 * src/maemo/modest-account-settings-dialog.h:
259 * src/maemo/modest-account-settings-dialog.c:
260 (modest_account_settings_dialog_init): Store the notebook so we can
262 Added modest_account_settings_dialog_switch_to_user_info().
264 * src/modest-tny-account-store.c:
265 (get_password): When the password in the account settings is wrong (we think),
266 show the relevant page of the account settings dialog, in the mainloop.
267 However, we currently get many of these at once because cancel does not
269 (forget_password): Do not forget the password
270 from the account settings, because this causes side-effects when
271 tinymail seems to call it at strange time, maybe because of how we
272 are cancelling get_password().
273 (modest_tny_account_store_alert): Ignore user cancellations.
275 2007-07-09 Murray Cumming <murrayc@murrayc.com>
277 * src/maemo/modest-maemo-utils.h:
278 * src/maemo/modest-maemo-utils.c:
279 Added modest_maemo_show_information_note_and_forget() for use instead of
280 gtk_dialog_run() when the response is not needed, to avoid an extra
281 mainloop which could cause a hang.
283 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
284 Use the logical IDs for the error message, though they are not
285 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
286 because gtk_dialog_run() caused a hang here (the window did not close).
287 This fixes projects.maemo.org bug NB#62646.
289 2007-07-09 Murray Cumming <murrayc@murrayc.com>
291 * src/modest-account-mgr-helpers.h:
292 * src/modest-account-mgr-helpers.c:
293 Added modest_account_mgr_get_store_protocol().
295 * src/maemo/modest-account-view-window.c:
296 (on_delete_button_clicked): Show different warning text depending on
297 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
298 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
301 2007-07-09 Murray Cumming <murrayc@murrayc.com>
303 * src/maemo/modest-msg-edit-window.c:
304 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
305 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
307 2007-07-07 Armin Burgmeier <armin@openismus.com>
309 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
310 ckdg_ib_maximum_characters_reached from correct package.
312 * src/modest-ui-actions.c: Show an error message when a folder could
313 not be created. Tinymail does not give us specific error codes about
314 what has gone wrong, so we assume that a folder with that name
315 already exists, though there might be other reasons.
317 2007-07-06 Murray Cumming <murrayc@murrayc.com>
319 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
320 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
321 give a more exact error message that can be partly translated.
323 2007-07-05 Murray Cumming <murrayc@murrayc.com>
325 * src/maemo/modest-address-book.c:
326 (select_email_addrs_for_contact): Specify a default window size for the
327 select-email-address dialog, so that it is probably big enough for the
328 title. This should fix projects.maemo.org bug NB#62277.
330 2007-07-05 Murray Cumming <murrayc@murrayc.com>
332 * src/maemo/easysetup/modest-easysetup-wizard.c:
333 (create_page_complete_easysetup): Use
334 gtk_widget_set_size() request to ensure that the text wraps
337 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
339 * src/maemo/easysetup/modest-easysetup-wizard.c:
340 (on_entry_invalid_character), (create_page_account_details),
341 (create_page_user_details):
342 Use new API of ModestValidatingEntry. But for some reason the banner is
343 not shown. I will have to investigate that further.
345 * src/widgets/modest-validating-entry.c: (on_insert_text),
346 (modest_validating_entry_set_func):
347 * src/widgets/modest-validating-entry.h:
348 Added a new callback function to be able to react to prevented
349 characters whitespaces to e.g show a banner.
351 2007-07-05 Armin Burgmeier <armin@openismus.com>
353 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
354 notification of HildonNumberEditor instead of remembering the port
355 number. Thanks to Johannes for pointing this out.
357 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
359 * src/maemo/easysetup/modest-easysetup-wizard.c:
360 Check if there are any user changes before showing a confirmation
361 dialog (projects.maemo.org NB#60946)
363 2007-07-05 Armin Burgmeier <armin@openismus.com>
365 * src/maemo/modest-account-settings-dialog.c: Remember custom port
366 number at the beginning of the dialog and set the modified flag at the
367 end if the port number has changed. This is necessary because
368 HildonNumberEditor does not support notification when the value has
371 2007-07-05 Murray Cumming <murrayc@murrayc.com>
373 * src/modest-ui-actions.c:
374 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
375 a connection before asking anything else. Correct the check for the destination
376 folder so that it succeeds when online.
377 This fixed projects.maemo.org bug NB#61645.
379 2007-07-05 Murray Cumming <murrayc@murrayc.com>
381 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
382 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
383 to fix projects.maemo.org bug NB#62439.
385 2007-07-05 Murray Cumming <murrayc@murrayc.com>
387 * src/modest-tny-account.c: (on_connection_status_changed):
388 Really do not use tny_device_force_offline() here. See the previous comment.
390 2007-07-04 Murray Cumming <murrayc@murrayc.com>
392 * src/modest-tny-account.c: (on_connection_status_changed):
393 Do not use tny_device_force_offline() when tinymail says that something
394 went wrong with the connection. It seems to report this unnecessarily.
396 2007-07-04 Murray Cumming <murrayc@murrayc.com>
398 * src/maemo/modest-connection-specific-smtp-window.c:
399 (modest_connection_specific_smtp_window_init):
400 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
401 does not seem to have any effect in osso 1.1 (though it works in
402 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
404 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
406 * src/maemo/modest-connection-specific-smtp-window.c:
407 Fix UI specification problems with projects.meamo.org NB#60479
409 2007-07-04 Murray Cumming <murrayc@murrayc.com>
411 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
412 clue when this has failed, because the error dialog is not always shown
413 (at least in earlier version).
415 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
416 GError message, because the generic error dialog is not helpful.
418 'This message is not currently available (can't let a new connection go online)'
419 when trying to open an IMAP message.
421 (_modest_ui_actions_open): Offer a connection when some messages would
422 have to be downloaded and we are offline.
424 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
426 * src/widgets/modest-folder-view.c:
427 Don't check for MERGE type anymore as we use the correct type
429 NOTE: For the last two changes you need to update your tinymail copy
430 because of API changes!
432 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
434 * src/modest-tny-local-folders-account.c:
435 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
436 (see projects.maemo.org NB#61580)
438 2007-07-04 Murray Cumming <murrayc@murrayc.com>
440 * src/modest-tny-account.c: (on_connection_status_changed):
441 Commented out the call to modest_platform_connect_and_wait() because this
442 seems to always hang, and I would like to know if this is the only thing
443 that causes a hang when showing the connection dialog.
444 It is not very useful anyway.
446 2007-07-04 Murray Cumming <murrayc@murrayc.com>
448 * src/maemo/modest-msg-view-window.c:
449 (modest_msg_view_window_select_next_message):
451 * src/modest-platform.h:
452 * src/maemo/modest-platform.c:
453 Added modest_platform_connect_and_wait(), which calls
454 tny_maemo_conic_device_connect() always in the main thread, by calling it
455 in an idle handler and waiting for the idle handler to run. It should be
456 in the main thread because it uses GTK+ UI code. It just returns TRUE
457 if the device is already online.
459 There is some nasty code to ensure that subsequent calls to
460 modest_platform_connect_and_wait() just wait for the first one to finish,
461 by checking repeatedly in another idle handler. This is necessary,
462 because other threads (or even the main thread, via another idle handler)
463 can call modest_platform_connect_and_wait() while
464 modest_platform_connect_and_wait() is running.
466 (modest_platform_connect_and_wait_if_network_account),
467 (modest_platform_connect_and_wait_if_network_folderstore):
468 Convenience functions that calls modest_platform_connect_and_wait() if
469 the account or folder might want network access.
471 * src/modest-mail-operation.c:
472 (modest_mail_operation_update_account):
473 * src/modest-ui-actions.c: (download_uncached_messages),
474 (modest_ui_actions_on_rename_folder), (delete_folder),
475 (modest_ui_actions_on_main_window_move_to),
476 (modest_ui_actions_on_msg_view_window_move_to):
477 * src/widgets/modest-folder-view.c:
478 (drag_and_drop_from_folder_view):
479 Offer a connection if we are offline.
481 * src/modest-tny-account.c: (on_connection_status_changed):
482 Document this as only handling errors during network operations in progress,
483 and replace the idle code with a simple call to
484 modest_platform_connect_and_wait(), which does this instead.
486 2007-07-03 Murray Cumming <murrayc@murrayc.com>
488 * src/modest-tny-account.c:
489 (modest_tny_account_get_special_folder): (util_on_idle),
490 Handle the GError so we can see when tny_folder_store_get_folders()
491 fails, as it currently does while something else is connecting.
493 Added util_run_in_main_thread_and_wait()
494 which uses an idlen handler and mainloop to ensure that the function
495 is called in the main thread.
496 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
497 to make sure that we call attempt the connection in the mainloop only,
498 which might solve some hangs.
500 2007-07-03 Murray Cumming <murrayc@murrayc.com>
502 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
503 be found by their display name. This is never useful.
504 * src/modest-tny-account-store.c: (on_account_removed): Find the account
505 by its ID, instead of trying to use its ID as its display name.
507 * src/modest-tny-account-store.h:
508 * src/modest-tny-account.c:
509 (modest_tny_account_get_special_folder): Add a g_warning() when
510 tny_folder_store_get_folders() returns an empty list for the maildir.
512 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
513 Add a g_warning() when this returns NULL, because that it not allowed
516 2007-07-02 Armin Burgmeier <armin@openismus.com>
518 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
519 note when trying to cancel the wizard. This fixes projects.maemo.org
522 2007-07-02 Murray Cumming <murrayc@murrayc.com>
524 * src/modest-tny-account.h:
525 * src/modest-tny-account.c:
526 (modest_tny_account_new_from_server_account),
527 (modest_tny_account_new_from_server_account_name),
528 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
529 because this must now be set before setting the proto. This is usd in
530 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
531 warning in camel_session_get_service() caused by
532 tny_camel_transport_account_prepare().
534 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
537 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
539 * src/maemo/modest-connection-specific-smtp-edit-window.c:
541 (modest_connection_specific_smtp_edit_window_init):
543 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
546 2007-06-29 Murray Cumming <murrayc@murrayc.com>
548 * src/modest-tny-account.c:
549 (modest_tny_account_new_from_server_account):
550 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
551 now uses to request a connection when it needs one, and which it uses
552 to tell us that something is wrong with the connection, so we can force
553 the accounts offline to prevent further problems.
556 * src/modest-init.c: (init_default_settings):
557 * src/modest-mail-operation.c:
558 (modest_mail_operation_update_account):
559 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
560 This should not be necessary anymore. Do not set the conf key that
561 determined this (it was always TRUE and not set anywhere else).
563 * src/modest-ui-actions.h: Remove unused and unimplemented
564 modest_ui_actions_on_online_toggle_toggled().
566 2007-06-29 Murray Cumming <murrayc@murrayc.com
568 * src/maemo/modest-main-window.c: (connect_signals):
569 Don't connect to delete_event twice. Maybe this was harmless.
571 2007-06-29 Murray Cumming <murrayc@murrayc.com
573 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
574 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
575 Debug output to give some more clue when a folder move is not allowed.
577 2007-06-28 Murray Cumming <murrayc@murrayc.com
579 * src/modest-tny-account.c: (on_modest_file_system_info),
580 (modest_tny_account_get_mmc_account_name):
581 Always call the callback, without checking whether the name has changed.
582 * src/widgets/modest-folder-view.c: (strings_are_equal),
583 (on_model_foreach_set_name), (on_get_mmc_account_name),
584 (text_cell_data): Compare the name here, and use the name from
585 the account rather than from the
586 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
587 if the name was changed after the account was added to the model.
588 That's a tinymail bug but not one that I want to fix now.
590 This finally fixes projects.maemo.org bug NB#59301.
592 2007-06-27 Armin Burgmeier <armin@openismus.com>
594 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
597 2007-06-27 Murray Cumming <murrayc@murrayc.com
599 * src/modest-tny-account.h:
600 * src/modest-tny-account.c:
601 Added modest_tny_account_get_mmc_account_name(), to set the memory
602 card name asynchronously for the given account and then notify.
603 (modest_tny_account_new_for_local_folders): Use this new function instead
604 of using hildon_file_system_info_async_new() directly.
606 * src/widgets/modest-folder-view.c: (text_cell_data):
607 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
608 gtk_tree_model_row_changed() when it is available.
610 This should fix projects.maemo.org bug NB#59301.
612 2007-06-27 Murray Cumming <murrayc@murrayc.com
614 * src/modest-mail-operation.c: (update_account_thread),
615 (get_msgs_full_thread): Fix typo failures in the revert
618 2007-06-27 Murray Cumming <murrayc@murrayc.com
620 * src/maemo/modest-maemo-global-settings-dialog.c:
621 (idle_select_default_focus):
622 * src/modest-mail-operation.c: (idle_notify_progress),
623 (idle_notify_progress_once), (set_last_updated_idle),
624 (update_account_thread), (get_msgs_full_thread):
625 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
626 * src/widgets/modest-header-view.c:
627 (idle_notify_headers_count_changed_destroy),
628 (idle_notify_headers_count_changed):
629 Reverted the additions of gdk_threads_enter/leave(), in case this
630 helps with a startup hang on the device.
632 2007-06-26 Armin Burgmeier <armin@openismus.com>
634 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
635 for supported secure authentication methods from server by
636 gtk_dialog_run(), saving CPU time and a potential race condition.
638 2007-06-26 Armin Burgmeier <armin@openismus.com>
640 * src/maemo/modest-maemo-utils.h:
641 * src/maemo/modest-maemo-utils.c: Added a
642 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
643 only error code to tell the calling code when the user canceled the
646 * src/maemo/modest-account-settings-dialog.h:
647 * src/maemo/modest-account-settings-dialog.c:
648 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
649 message if the retrieval of secure authentication methods was canceled
650 by the user. Perform the check before saving anything to configuration
651 to not end up with half-committed configuration changes, do not show
652 a "Saving to configuration failed" note when authentication methods
653 could not be retrieved.
655 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
658 2007-06-26 Murray Cumming <murrayc@murrayc.com>
660 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
661 Only return the first level of folders under accounts, because the
662 osso-global-search UI spec doesn't want the rest.
663 This fixed projects.maemo.org bug NB#61811.
665 2007-06-26 Murray Cumming <murrayc@murrayc.com>
667 * src/modest-tny-account-store.c:
668 * src/modest-tny-account-store.h:
669 Added modest_tny_account_is_memory_card_account().
670 * src/maemo/modest-main-window.c: (create_details_widget):
671 Show the same information items for the memory card as we show for the
672 local-folders, to fix projects.maemo.org bug NB#59307.
674 2007-06-26 Murray Cumming <murrayc@murrayc.com>
676 * src/modest-tny-account-store.c: (get_password):
677 Added some checks for NULL to maybe prevent crashes, though I think
678 it was Philip's last commit that actually prevented the crash here
679 when creating a first new account.
680 But the new account is still not usable (no messages are shown)
681 until a restart of the application.
683 2007-06-26 Murray Cumming <murrayc@murrayc.com>
685 * src/maemo/modest-maemo-global-settings-dialog.c:
686 (idle_select_default_focus):
687 * src/modest-mail-operation.c: (idle_notify_progress),
688 (idle_notify_progress_once), (idle_notify_update_account_queue),
689 (set_last_updated_idle), (update_account_thread),
690 (notify_get_msgs_full), (get_msgs_full_destroyer),
691 (get_msgs_full_thread):
692 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
693 * src/widgets/modest-header-view.c:
694 (idle_notify_headers_count_changed_destroy),
695 (idle_notify_headers_count_changed):
696 Use gdk_threads_enter() and gdk_threads_enter_leave() in
697 all idle handlers, because some other thread could be blocking
698 the GDK lock, so that it can do GUI stuff.
700 2007-06-26 Murray Cumming <murrayc@murrayc.com>
702 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
703 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
704 (on_idle_send_receive), (on_idle_open_default_inbox):
705 * src/maemo/modest-msg-edit-window.c:
706 (modest_msg_edit_window_attach_file_noninteractive):
707 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
708 to prevent a hang. I don't quite understand why these are necessary,
709 beause we should already be in the main loop. I guess something outside
710 of the main loop is taking the lock.
712 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
713 we are really using URIs, and use files that are more likely to exist.
715 2007-06-26 Murray Cumming <murrayc@murrayc.com>
717 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
718 necessary because configure.ac now defines different variables.
720 2007-06-26 Murray Cumming <murrayc@murrayc.com>
722 * libmodest-dbus-client/libmodest-dbus-client.c:
723 * libmodest-dbus-client/libmodest-dbus-client.h:
724 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
725 libmodest_dbus_client_compose_mail() is what things actually use.
727 * src/dbus_api/modest-dbus-api.h:
728 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
729 * tests/dbus_api/Makefile.am:
730 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
733 2007-06-26 Murray Cumming <murrayc@murrayc.com>
735 * src/modest-init.c: (modest_init_local_folders):
736 For memory-card (or other non local-folders) maildir accounts,
737 always create an Archive folder, so that there is somewhere to put
738 messages. This should be less confusing, because the user does not need
739 to guess that the need to create a folder.
741 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
743 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
744 Fixed icon size by using (50, 50) which is the same as defined by
747 2007-06-25 Armin Burgmeier <armin@openismus.com>
749 * src/widgets/modest-window-mgr.c:
751 * configure.ac: Correctly recognize hildon-notify presence and fixed
752 the build without it being installed.
754 2007-06-25 Murray Cumming <murrayc@murrayc.com>
756 * libmodest-dbus-client/libmodest-dbus-client.c:
757 (libmodest_dbus_client_search): Fix the build. Sorry.
758 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
759 (reply_forward_cb): Initialize variables to fix the build.
761 * src/modest-tny-account-store.c:
762 (modest_tny_account_store_get_tny_account_by): Fix the account URI
763 comparison (a silly typo) so that email search results can be opened
764 when there are more than one account.
766 2007-06-25 Murray Cumming <murrayc@murrayc.com>
768 * libmodest-dbus-client/libmodest-dbus-client.c:
769 (libmodest_dbus_client_search),
770 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
771 instead of 1 second, because the search gets folders and messages from
772 the server, which can take a long time. When it times out,
773 osso-global-search will report no results.
775 We need to specify whether we should search only cached information
776 (maybe with a user preference), and the osso-email-search-plugin
777 API should really be improved to allow that option, and to allow results
778 to be delivered asynchronously in batches.
780 2007-06-25 Murray Cumming <murrayc@murrayc.com>
782 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
783 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
784 GTK_ICON_SIZE_DIALOG is probably the wrong size.
786 2007-06-25 Murray Cumming <murrayc@murrayc.com>
788 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
789 that is an empty string. D-Bus seems to give us these instead of NULL.
791 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
793 * src/dbus_api/modest-dbus-callbacks.c:
794 * src/maemo/easysetup/modest-easysetup-wizard.h:
795 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
796 * src/maemo/modest-connection-specific-smtp-edit-window.c:
797 (modest_connection_specific_smtp_edit_window_init):
798 * src/maemo/modest-maemo-global-settings-dialog.c:
800 * src/maemo/modest-maemo-utils.c:
801 (modest_maemo_utils_setup_images_filechooser):
802 * src/maemo/modest-main-window.c: (create_details_widget):
803 * src/maemo/modest-msg-edit-window.c:
804 (modest_msg_edit_window_attach_file_noninteractive),
805 (modest_msg_edit_window_color_button_change),
806 (modest_msg_edit_window_set_zoom):
807 * src/modest-mail-operation.c: (update_account_thread):
808 * src/modest-tny-account-store.c:
809 * src/modest-tny-account.c:
810 * src/widgets/modest-global-settings-dialog.c:
811 * src/widgets/modest-window.h:
815 2007-06-25 Murray Cumming <murrayc@murrayc.com>
817 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
818 * src/modest-search.c: (modest_search_folder),
819 (modest_search_all_accounts): Actually search only in the specified folder,
820 doing a simple match on the folder ID.
821 * src/modest-search.h: Added a folder field to the ModestSearch struct,
822 and added some documentation.
824 2007-06-22 Armin Burgmeier <armin@openismus.com>
826 * src/maemo/modest-maemo-utils.h:
827 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
828 modest_maemo_utils_get_supported_secure_authentication_methods.
830 * src/maemo/easysetup/modest-easysetup-wizard.c:
831 * src/maemo/modest-account-settings-dialog.c: Show correct error if
832 one occured, not just "Server does not support secure authentication".
834 2007-06-22 Murray Cumming <murrayc@murrayc.com>
836 * src/modest-tny-account-store.c: (get_password):
837 Restored the call to tny_account_set_user() because Philip seems to have
838 stopped this from crashing (by not using the freed string). It still does
839 not work, but now we can test it.
841 2007-06-22 Murray Cumming <murrayc@murrayc.com>
843 * src/maemo/modest-msg-edit-window.c: (init_window):
844 Comment out use of an uninitialzed GtkScrolledWindow variable,
845 to fix the build and stop a crash. Yet again.
847 2007-06-22 Murray Cumming <murrayc@murrayc.com>
849 * src/modest-tny-account-store.c: (get_password):
850 Remove the call to tny_account_set_user() because this actually crashes.
851 As mentioned in the last commit, it is known to not work anyway.
853 2007-06-22 Murray Cumming <murrayc@murrayc.com>
855 * src/modest-tny-account-store.c: (get_password):
856 Use tny_account_set_username() to tell tinymail that the username might
857 have changed too. But tinymail ignores this: see projects.maemo.org
859 * src/modest-ui-actions.c:
860 (modest_ui_actions_on_password_requested): Remove the useless attempt to
861 reset the connection when changing the username, and improve the comments.
862 Save the changed username to gconf at least, so it is used when Modest is
865 2007-06-21 Murray Cumming <murrayc@murrayc.com>
867 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
868 Do not use a query, so that we get all folders, including for POP and
869 local-folders. They work as search criteria too.
870 This fixes projects.maemo.org bug NB#57740.
872 2007-06-21 Murray Cumming <murrayc@murrayc.com>
874 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
875 Comment out the use of hildon_notification_set_sound() because it is
876 not declared, to fix the build. Warnings are serious, people.
878 2007-06-21 Armin Burgmeier <armin@openismus.com>
880 * src/maemo/modest-maemo-utils.h:
881 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
882 modest_maemo_utils_get_supported_secure_authentication_methods()
883 to query authentication methods for a specific user. This should fix
884 projects.maemo.org bug NB#61369.
886 * src/maemo/easysetup/modest-easysetup-wizard.c:
887 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
890 2007-06-21 Murray Cumming <murrayc@murrayc.com>
892 * libmodest-dbus-client/libmodest-dbus-client.h:
893 * libmodest-dbus-client/libmodest-dbus-client.c:
894 (modest_dbus_message_iter_get_search_hit),
895 (libmodest_dbus_client_search):
896 Reorganised and commented this.
897 Removed modest_search_hit_free() from the public API because it
900 Added libmodest_dbus_client_get_folders() and
901 modest_folder_result_list_free().
903 * src/dbus_api/modest-dbus-api.h:
904 * src/dbus_api/modest-dbus-callbacks.c:
905 (modest_dbus_req_filter): Commented. Moved most code to
906 on_dbus_method_search() and added on_dbus_method_get_folders().
908 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
909 of the extra D-Bus handler.
911 * tests/dbus_api/Makefile.am:
912 * tests/dbus_api/test_get_folders.c: New test for
913 libmodest_dbus_client_get_folders(). This seems to return an empty list
914 at the moment. That could be the same error that causes the message list
915 to be empty sometimes.
916 This should help with projects.maemo.org bug NB#57740.
918 2007-06-21 Armin Burgmeier <armin@openismus.com>
920 * src/modest-mail-operation.c: Do not call
921 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
922 notify the operation's end after having set the status to CANCELED for
923 the operation queue to listen on. This fixes a deadlock when there
924 were mail operations in the queue during its finalization.
926 * src/modest-singletons.c: Reordered uninitialization of the account
927 manager to happen after the mail operation queue was uninitialized
928 because the mail operation's in the queue might still try to access
929 the account manager (see modest_mail_operation_notify_end()). This
930 fixes a potential crash when terminating the application.
932 2007-06-21 Murray Cumming <murrayc@murrayc.com>
934 * src/modest-search.c:
935 (search_mime_part_and_child_parts): Moved some code here so we
936 can search recursively in child folders.
937 (modest_search_folder): Search in the message as a mime part, instead
938 of just its child mime parts.
939 (read_chunk), (search_mime_part_ogs):
940 Check how many bytes were read, to prevent an endless loop.
941 Searching in message bodies now works. This finishes the fix for
942 projects.maemo.org bug NB#61007.
944 2007-06-20 Murray Cumming <murrayc@murrayc.com>
946 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
947 Add a g_warning when the item is not a folder.
949 * src/modest-ui-dimming-rules.c:
950 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
951 when selected item is not a folder (for instance, an account), because
952 the UI spec only talks about folders.
953 I am not sure what the UI spec wants, so this might not totally fix
954 projects.maemo.org bug NB#60794.
956 2007-06-20 Murray Cumming <murrayc@murrayc.com>
958 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
959 (load_from_file): Sort the list. The unsorted list would be more noticeable
960 in non-English locales.
962 * src/maemo/modest-msg-edit-window.c:
963 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
964 warning and fix the build.
966 * src/maemo/modest-progress-bar-widget.c:
967 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
968 avoid a g_warning, and probably to avoid a crash.
970 2007-06-20 Murray Cumming <murrayc@murrayc.com>
972 * src/modest-search.c: (modest_search_folder): Check for a GError
973 when calling tny_folder_get_headers(), to show that this is not the cause
976 2007-06-20 Murray Cumming <murrayc@murrayc.com>
978 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
979 Actually set the body query instead of the subject query.
981 * src/modest-search.c: (search_mime_part_ogs),
982 (search_mime_part_strcmp): Remove extra space from the text/* regex,
983 which would probably cause it to fail if we got this far.
985 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
986 to simplify the code.
987 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
988 be causing search-in-body to fail.
990 2007-06-20 Murray Cumming <murrayc@murrayc.com>
992 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
994 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
995 Better debug message when the folder cannot be found.
996 This should help with fixing projects.maemo.org bug #61287.
997 * src/modest-search.c: (add_hit): Do not leak the furl string.
999 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1001 * src/modest-ui-actions.c:
1002 (modest_ui_actions_on_folder_selection_changed):
1003 Do not special-case TNY_MERGE_FOLDER here, because
1004 modest_tny_folder_get_account() already does that. This fixes
1005 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1006 shown when the Outbox was selected).
1008 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1010 * libmodest-dbus-client/libmodest-dbus-client.c:
1011 (_dbus_iter_get_string_or_null): Initialize the string variable in
1012 case this helps with Dirk's crash.
1014 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1016 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1017 though it is not implemented yet (this function is maybe not even used),
1018 to avoid breaking ABI in future.
1019 * libmodest-dbus-client/libmodest-dbus-client.c:
1020 (get_attachments_string): Moved some code into this generic function.
1021 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1022 sends email. It is maybe not used.
1023 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1024 (on_send_mail): Use attachments.
1026 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1027 * src/maemo/modest-msg-edit-window.c:
1028 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1029 a filename before using it, to fix projects.maemo.org bug NB#58233.
1031 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1033 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1034 Initialize the continue_download variable to fix the build, and probably
1035 to fix randome behaviour.
1037 2007-06-18 Armin Burgmeier <armin@openismus.com>
1039 * src/modest-tny-send-queue.h:
1040 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1041 the queue so we can later show it in the UI. Replaced
1042 modest_tny_send_queue_msg_is_being_sent() by
1043 modest_tny_send_queue_get_msg_status().
1045 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1047 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1048 gpointer. This probably was not harmful, but just to be sure.
1050 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1052 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1053 Fix the build, but leave the function broken on Bora, because
1054 hildon_uri_action_get_service() does not exist.
1055 osso_uri_action_get_service() does not exist either, it seems.
1057 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1059 * src/modest-tny-account.c:
1060 (modest_tny_account_new_from_server_account):
1061 Uncommented the url debug output again, because it is useful for
1062 debugging, as I said in the comment.
1064 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1066 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1068 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1069 for Mameo Bora, to fix the build.
1071 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1074 Fixed build with hildon < 0.99
1076 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1077 Check if the selected account is busy instead of checking all accounts
1079 * src/modest-account-mgr-priv.h:
1080 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1081 (modest_account_mgr_init), (compare_account_name),
1082 (modest_account_mgr_set_account_busy),
1083 (modest_account_mgr_account_is_busy):
1084 * src/modest-account-mgr.h:
1085 Added busy information to the account manager. It possible to
1086 set an account to busy or not busy now.
1088 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1089 (modest_mail_operation_update_account),
1090 (modest_mail_operation_notify_end):
1091 Set the account to busy/not busy depending on the operation state.
1093 * src/widgets/modest-account-view.c:
1094 (modest_account_view_finalize), (get_last_updated_string),
1095 (update_account_view), (on_account_busy_changed), (init_view):
1096 Show string "Refreshing..." if the account is currently busy.
1098 All this fixes projects.maemo.org bug NB#59711
1100 2007-06-14 Armin Burgmeier <armin@openismus.com>
1102 * src/widgets/modest-attachments-view.h:
1103 * src/widgets/modest-attachments-view.c: Added
1104 modest_attachments_view_has_attachments() and fixed coordinate
1105 transformation in get_att_view_at_coords(). This fixes attachment
1108 * src/widgets/modest-msg-view.c: Make use of
1109 modest_attachments_view_has_attachments() to decide whether to show
1110 attachments in the header.
1112 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1114 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1115 (on_change), (on_combo_security_changed),
1116 (modest_connection_specific_smtp_edit_window_init),
1117 (modest_connection_specific_smtp_edit_window_set_connection),
1118 (modest_connection_specific_smtp_edit_window_is_dirty):
1119 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1120 * src/maemo/modest-connection-specific-smtp-window.c:
1123 Show an comfirmation dialog for the smpt-edit-window if there are
1124 unsaved changes and the user hits cancel.
1125 (projects.maemo.org bug NB#60479)
1127 2007-06-14 Armin Burgmeier <armin@openismus.com>
1129 * src/maemo/easysetup/modest-easysetup-wizard.c:
1130 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1131 address" info in banner instead of node, and select all the text as
1132 per UI spec. This fixes projects.maemo.org bug NB#60550.
1134 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1136 reviewed by: <delete if not using a buddy>
1138 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1139 * src/modest-ui-actions.c: (folder_refreshed_cb):
1141 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1143 * src/widgets/modest-folder-view.c: (filter_row):
1144 Explictly filter out the per-account outbox accounts. I don't know why
1145 these only sometimes show up, but now they should never show up in the UI.
1146 This should fix projects.maemo.org bug NB#60160.
1148 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1150 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1151 when the toolbar does not exist yet.
1152 * src/modest-widget-memory.c: (save_settings_header_view):
1153 Added g_warnings() to help us to discover when we are trying to set
1154 an empty columns list in gconf.
1156 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1158 * src/modest-init.h:
1159 * src/modest-init.c:
1160 Added modest_init_get_default_header_view_column_ids().
1162 * src/modest-widget-memory.c: (restore_settings_header_view):
1163 Use the new function to get defaults, if the gconf key is empty,
1164 instead of not creating any columns. This seems to fix the
1165 empty right-hand pane problems.
1167 * src/widgets/modest-header-view.h: Improved documentation.
1169 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1171 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1172 Revert the use of the display name as the account name, because this
1173 is generally wrong and would break the code that follows.
1175 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1177 * src/maemo/easysetup/modest-easysetup-wizard.c:
1178 (check_for_supported_auth_methods), (on_before_next),
1181 More correct fix for projects.maemo.org bug NB# 58991
1182 Do not longer accept AUTH_PASSWORD as secure method and choose
1183 correct method when creating the account.
1185 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1187 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1188 Fixed projects.maemo.org bug NB# 58991
1190 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1192 * src/modest-init.c: (modest_init_init_core),
1193 (modest_init_local_folders): Fixed compilation errors.
1195 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1197 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1198 Remove unnecessary lib/include, though it is good in principle when needed.
1200 * src/modest-init.c: (modest_init_one_local_folder),
1201 (modest_init_local_folders):
1202 * src/modest-init.h: Initialize the .modest library for memory cards,
1203 instead of just doing nothing for them. This should allow us to create
1204 folders there, fixing projects.maemo.org bug NB#59297.
1206 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1208 * libmodest-dbus-client/libmodest-dbus-client.c:
1209 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1210 (libmodest_dbus_client_compose_mail),
1211 (libmodest_dbus_client_open_message),
1212 (libmodest_dbus_client_send_and_receive),
1213 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1215 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1216 (on_idle_open_message), (modest_dbus_req_handler),
1217 (search_result_to_message), (modest_dbus_req_filter):
1218 * src/modest-search.c: (add_hit), (modest_search_folder),
1219 (modest_search_all_accounts): Improved debug messages.
1221 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1223 * src/modest-tny-account-store.c:
1224 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1227 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1230 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1232 * src/modest-tny-account-store.c: (get_server_accounts):
1233 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1234 even when there are no accounts, so that the Outbox folder is always
1235 visible. This fixes projects.maemo.org bug NB#60158.
1237 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1239 * src/maemo/modest-main-window.c: (create_details_widget):
1240 Use the mcen_va_never logical ID.
1242 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1244 * src/dbus_api/modest-dbus-api.h:
1245 * src/dbus_api/modest-dbus-callbacks.c:
1246 (on_idle_open_default_inbox), (on_open_default_inbox),
1247 (modest_dbus_req_handler):
1248 Added a new OpenDefaultInbox method.
1250 * libmodest-dbus-client/libmodest-dbus-client.h:
1251 * libmodest-dbus-client/libmodest-dbus-client.c:
1252 Added libmodest_dbus_client_open_default_inbox() to call the new
1253 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1254 though it should maybe be used by a new osso-email-interface function.
1256 * tests/dbus_api/Makefile.am:
1257 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1260 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1262 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1263 NULL, so that the signals get all the keys. This should not actually
1264 change any behaviour because we currently update everything when anything
1267 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1269 * src/widgets/modest-folder-view.c: (text_cell_data),
1270 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1271 (find_inbox_iter): If tinymail tells us that the folder is
1272 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1273 This causes the inbox to be selected at startup, fixing part of
1274 projects.maemo.org bug NB#56305.
1276 * src/modest-ui-dimming-rules.c:
1277 (modest_ui_dimming_rules_on_tools_smtp_servers):
1278 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1279 the SMTP servers menu item.
1280 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1281 that the SMTP Servers menu item is dimmed when there are no accounts,
1282 as a future version of the UI spec will require. This fixes
1283 projects.maemo.org bug NB#56305.
1285 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1287 * src/maemo/modest-maemo-utils.c:
1288 (modest_maemo_utils_get_supported_secure_authentication_methods):
1289 Added label to dialog instead of unreadable title
1291 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1292 (modest_main_window_new):
1293 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1296 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1297 * src/modest-account-mgr.h:
1298 Added method to avoid code duplication
1300 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1301 (modest_ui_actions_on_send_receive):
1302 Use modest_account_mgr_has_accounts
1304 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1306 * src/maemo/easysetup/modest-presets.c:
1307 (modest_presets_get_info_server_security): Do not report secure auth
1309 * src/modest-protocol-info.c: Use the defines for the gconf key names
1310 for secure authentication. This was not working because we were writing
1311 Password and reading password, and the check was case sensitive.
1312 With this, gmail now works for receiving and sending when created via
1315 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1317 * src/maemo/easysetup/modest-presets.c:
1318 (modest_presets_get_info_server_security): Correct the key name for
1319 SecureSmtp, because it seems to be case-sensitive.
1320 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1321 Do not try to get the 0th notebook page if there are 0 pages, to
1322 avoid a g_warning().
1324 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1326 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1327 Prevent use of the new notification feature for now, because it currently
1328 shows one dialog for each new email, which is annoying.
1330 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1332 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1333 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1334 when no country was selected, so that we show the global ones.
1335 * src/maemo/easysetup/modest-presets.c:
1336 (modest_presets_get_providers): Return only the global providers, not
1337 all providers when mmc=0 was requested.
1339 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1341 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1342 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1343 provider ID in the combo.
1345 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1346 Do not show the page numbers, because it would be confusing when we add
1347 the 2 extra pages for the custom setup, when the user chooses the "Other"
1348 provider. This fixes projects.maemo.org bug NB#59028
1350 * src/modest-init.c: (modest_init_init_core),
1351 (modest_init_local_folders):
1352 * src/modest-init.h:
1353 * src/modest-tny-account.c:
1354 (modest_tny_account_new_for_local_folders): Do not create default folders
1355 for the memory card. This should fix projects.maemo.org bug NB#59328.
1357 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1359 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1360 Free the changed_conf_keys string items. They are already freed in the
1361 idle handler if that runs first.
1363 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1365 * src/modest-ui-actions.c:
1366 (modest_ui_actions_on_password_requested): Check that the server name
1367 is not NULL, because I just saw a password dialog with (null) as the
1370 * src/modest-tny-folder.[h|c]: Added
1371 modest_tny_folder_is_memory_card_folder().
1372 * src/modest-ui-dimming-rules.c:
1373 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1374 menu item for memory cards, as per the UI spec (section 7.4). This should
1375 fix projects.maemo.org bug NB#59297.
1377 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1379 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1380 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1381 is another problem with the code, see Murray's comment at line 772)
1383 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1385 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1386 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1387 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1388 (load_from_file), (easysetup_country_combo_box_init),
1389 (easysetup_country_combo_box_get_active_country_ids),
1390 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1391 instead of just one ID, to avoid duplicate country names in the UI.
1393 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1394 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1395 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1396 a single ID, avoiding duplicate providers.
1397 * src/maemo/easysetup/modest-easysetup-wizard.c:
1398 (on_combo_account_country): Adapt to use a list.
1400 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1402 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1403 keys changed in the last X seconds.
1405 * src/modest-account-mgr.h:
1406 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1407 (on_key_change), (modest_account_mgr_class_init),
1408 (modest_account_mgr_init), (modest_account_mgr_finalize):
1409 As the keys are changed, save them in a GSList* and signal that GSList*
1410 further every X seconds, to batch changes, to allow us to do just one
1411 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1412 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1414 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1415 changed signal signature.
1417 * src/modest-conf.c: (modest_conf_set_list),
1418 (modest_conf_on_change): Reenable notification.
1420 (modest_conf_maemo_fake_on_change): Comment out the hack that
1421 notified immediately instead of asynchronously.
1423 * src/widgets/modest-account-view.h:
1424 * src/widgets/modest-account-view.c:
1425 (update_account_view): Select the previously-selected account ID,
1426 if possible. This fixes projects.maemo.org bug NB#56933.
1428 (on_account_changed), (on_account_removed),
1429 (modest_account_view_select_account):
1431 Remove the block/unblock functions
1432 because they were not useful.
1434 * src/maemo/modest-account-view-window.c:
1435 (on_delete_button_clicked), (on_edit_button_clicked),
1436 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1438 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1440 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1441 Improve the error dialog to show Incorrect Account Settings, which seems
1442 clearer, and say that the internal error message (to be removed from the
1443 dialog later) is often misleading.
1444 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1446 * src/modest-tny-account.c:
1447 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1448 URL because this is so useful for debugging on the device.
1450 * src/widgets/modest-serversecurity-combo-box.c:
1451 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1453 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1455 * src/modest-mail-operation.c:
1456 (modest_mail_operation_send_new_mail):
1457 Added a comment about a nasty but apparently harmless message. Details
1458 added to the wiki g_warnings() page.
1460 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1462 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1463 (modest_tny_send_queue_class_init):
1464 Do not use the priv struct because it is empty, to avoid g_warnings
1465 about a non-existant priv struct.
1467 * src/modest-tny-account-store.c:
1468 (modest_tny_account_store_get_server_account),
1469 (modest_tny_account_store_get_transport_account_for_open_connection
1470 ): Do not try to get transport server accounts for local folders,
1471 because they don't have any. This avoids a g_warning().
1473 * src/maemo/modest-main-window.c:
1474 (modest_main_window_notify_send_receive_initied),
1475 (on_configuration_key_changed):
1476 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1477 * src/modest-defs.h:
1478 * src/modest-mail-operation.c:
1479 (modest_mail_operation_update_account):
1480 * src/modest-tny-account-store.h:
1481 * src/modest-tny-account.c:
1482 (modest_tny_account_get_special_folder),
1483 (modest_tny_account_new_for_local_folders),
1484 (modest_tny_account_new_for_per_account_local_outbox_folder):
1485 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1486 * src/modest-tny-local-folders-account.c:
1487 (add_account_folders_to_merged_folder):
1488 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1489 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1490 (modest_ui_actions_on_send):
1491 * src/widgets/modest-folder-view.c: (update_model):
1492 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1493 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1494 modest_tny_account_store_get_tny_account_by_account() to
1495 modest_tny_account_store_get_server_account() to make the code clearer.
1497 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1499 * src/dbus_api/modest-dbus-api.h:
1500 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1501 * src/maemo/modest-msg-edit-window.c:
1502 (modest_msg_edit_window_attach_file_noninteractive):
1503 added g_warning in case the file to be attached does not exist
1504 * tests/dbus_api/test_compose_mail.c: (main):
1505 removed obsolete comment, added generic files as test case
1507 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1509 * src/modest-tny-account-store.c: (get_server_accounts):
1510 Create the local folders account only once, not once for each outbox, and
1511 not only when there are some outboxes.
1513 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1515 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1516 code that is causing a crash at startup. Sergio says that he is fixing this.
1518 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1520 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1521 * src/maemo/modest-account-settings-dialog.c:
1522 (create_page_outgoing),
1523 (modest_account_settings_dialog_set_account_name),
1524 (save_configuration):
1525 - Fixed handling of the "Use secure authentication" toggle to comply with
1526 the ui specification. See also projects.maemo.org bug NB#58400
1528 - Restore the Secure connection setting combo correctly when loading
1531 * src/maemo/modest-maemo-utils.c:
1532 (on_camel_account_get_supported_secure_authentication),
1533 (modest_maemo_utils_get_supported_secure_authentication_methods):
1534 Fixed a crasher if operation is canceled
1536 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1537 (modest_protocol_info_auth_is_secure):
1538 * src/modest-protocol-info.h:
1540 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1541 the sense of the "Use secure authentication" toggle.
1543 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1545 * src/modest-tny-account-store.h:
1546 * src/modest-tny-account-store.c:
1547 Added modest_tny_account_store_get_local_folders_account().
1549 * src/modest-tny-folder.h:
1550 * src/modest-tny-folder.c:
1551 (modest_tny_folder_get_account):
1552 Added this replacement for tny_folder_get_account() which returns
1553 the local-folders account for TnyMergeFolders, to avoid the
1554 warning about the unimplemented get_account_func() vfunc().
1556 (modest_tny_folder_get_rules),
1557 * src/modest-ui-actions.c:
1558 (modest_ui_actions_on_folder_selection_changed):
1559 * src/modest-mail-operation.c:
1560 (modest_mail_operation_remove_folder),
1561 (modest_mail_operation_xfer_folder),
1562 (modest_mail_operation_rename_folder),
1563 (modest_mail_operation_get_msg),
1564 (modest_mail_operation_get_msgs_full),
1565 (modest_mail_operation_remove_msg),
1566 (modest_mail_operation_xfer_msgs),
1567 (modest_mail_operation_refresh_folder):
1568 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1570 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1572 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1573 (modest_server_account_set_security):
1574 * src/modest-defs.h: Add comments explaining that our
1575 UI spec means TLS when it says Normal, so these do not look like errors.
1577 * src/modest-tny-account.c:
1578 (modest_tny_account_new_from_server_account): Use the new tinymail
1579 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1580 for TLS. This should fix projects.maemo.org bug NB#58460.
1582 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1584 * src/maemo/easysetup/modest-easysetup-wizard.c:
1585 (create_account): Correct the position of the gconf sanity check warning.
1586 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1587 of using the g_idle_add() hack, because this does not seem to be necessary
1588 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1589 caused by something other than maemo's gconf.
1590 This fixes projects.maemo.org bug #59022.
1592 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1594 * src/modest-account-mgr-helpers.c:
1595 (modest_account_mgr_get_default_account): Do not check that the account
1596 exists if there is no default account (NULL), to fix a runtime warning.
1598 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1600 * src/widgets/modest-folder-view.c: (update_model):
1601 Do not unref the treemodel before we have finished with it.
1602 This prevents a valgrind warning and an occasional crash at startup.
1604 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1606 * libmodest-dbus-client/libmodest-dbus-client.h:
1607 added libmodest_dbus_client_compose_mail()
1608 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1610 added functions needed for SendAsMail() functionality
1611 * src/maemo/modest-msg-edit-window.c:
1612 (modest_msg_edit_window_attach_file_noninteractive):
1613 non interactively attaching files to message edit window
1614 * src/widgets/modest-msg-edit-window.h:
1615 * tests/dbus_api/Makefile.am:
1616 added test_compose_mail.c
1617 * tests/dbus_api/test_compose_mail.c: (main):
1619 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1621 * src/modest-account-view.c:
1622 Fixed bug projects.maemo.org bug NB#59307
1624 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1626 * src/maemo/easysetup/modest-easysetup-wizard.c:
1627 (get_serverport_incoming), (on_before_next), (create_account):
1628 * src/maemo/modest-account-settings-dialog.c:
1629 (modest_account_settings_dialog_set_account_name):
1630 * src/maemo/modest-maemo-utils.c:
1631 (on_camel_account_get_supported_secure_authentication_status),
1632 (on_camel_account_get_supported_secure_authentication),
1633 (on_secure_auth_cancel),
1634 (modest_maemo_utils_get_supported_secure_authentication_methods):
1636 Implemented security authentication for settings and easysetup.
1638 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1640 * src/maemo/modest-main-window.c: (create_details_widget):
1641 Show the total size for memory card accounts too, instead of showing
1642 the name again. Fixes bug projects.maemo.org bug NB#59307.
1644 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1647 * src/modest-tny-simple-folder-store.c:
1648 * src/modest-tny-simple-folder-store.h: Removed.
1650 * src/modest-tny-local-folders-account.h
1651 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1652 for the local-folders maildir, with an extra TnyMergedFolder containing
1653 the folders of the per-account outbox store accounts.
1654 * src/modest-tny-account-store.c: (get_server_accounts):
1655 Add the outboxes to the special local folders account after creating it.
1657 * src/modest-tny-account.c:
1658 (modest_tny_account_new_for_local_folders): Create the derived
1659 account when creating the main local-folders account.
1661 * src/maemo/modest-main-window.c: (create_details_widget),
1662 (modest_main_window_set_contents_style):
1663 Adapted to the use of the derived account instead of the folder store.
1665 * src/modest-ui-actions.c:
1666 (modest_ui_actions_on_folder_selection_changed):
1667 * src/modest-ui-dimming-rules.c:
1668 (modest_ui_dimming_rules_on_new_folder):
1669 * src/widgets/modest-folder-view.c: (text_cell_data),
1670 (icon_cell_data), (filter_row), (update_model),
1671 (get_cmp_rows_type_pos):
1674 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1675 Do not get the priv struct, because no priv struct has been set,
1676 to avoid a runtime warning.
1678 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1679 #ifelse with #else, to fix a warning, to fix the build.
1682 2007-06-05 Christian Kellner <ckellner@openismus.com>
1684 * libmodest-dbus-client/libmodest-dbus-client.c:
1685 Fix small typo in doc (why do you always see them
1686 AFTER committing stuff?)
1689 2007-06-05 Christian Kellner <ckellner@openismus.com>
1691 * libmodest-dbus-client/libmodest-dbus-client.c:
1692 (libmodest_dbus_client_search):
1693 Initialize hit list with NULL. Also set folder list
1694 to "" if NULL was supplied.
1697 2007-06-03 Christian Kellner <ckellner@openismus.com>
1699 * libmodest-dbus-client/libmodest-dbus-client.c:
1700 (modest_search_hit_list_free):
1701 Make it save to call it with NULL.
1703 * src/dbus_api/modest-dbus-callbacks.c:
1704 * src/modest-search.c:
1705 Return full ModestSearchHits as the search result list not TnyHeader
1706 since can't be around withouth the correspoding TnyFolder.
1708 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1710 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1711 Added currently commented code to check for secure auth
1713 * src/maemo/modest-account-settings-dialog.c: (on_response),
1714 (save_configuration), (show_ok):
1715 Fixed projects.maemo.org bugs NB #59248 and #59251
1717 * src/maemo/modest-maemo-utils.c:
1718 (on_camel_account_get_supported_secure_authentication_status),
1719 (on_camel_account_get_supported_secure_authentication),
1720 (modest_maemo_utils_get_supported_secure_authentication_methods):
1721 * src/maemo/modest-maemo-utils.h:
1722 Moved get_supported_secure_authentication() method here to be able
1723 to use it from easysetup wizard.
1725 * src/modest-pair.c: (on_pair_compare_as_string):
1726 Should compare string with first part of pair and not
1727 strcmp pairs which will crash.
1729 * src/modest-protocol-info.c:
1730 (modest_protocol_info_protocol_is_store):
1731 * src/modest-protocol-info.h:
1732 Added modest_protocol_info_get_auth_protocol_name()
1734 2007-06-03 Armin Burgmeier <armin@openismus.com>
1736 * src/modest-mail-operation.c:
1737 (modest_mail_operation_get_msgs_full): Set priv->account also when
1738 only retrieving a single message. This avoids a crash when canceling
1741 (modest_mail_operation_notify_end): Do not explicitely remove the
1742 operation from the queue but only emit the progress_changed signal.
1743 The queue itself listens to that signal to remove the operation when
1744 it is finished. This reduces coupling and removes a potential deadlock
1745 when modest_mail_operation_notify_end() is called from the queue
1746 itself. If that is a problem performance-wise, I would suggest to
1747 implement a status-changed signal or something.
1749 * src/modest-mail-operation-queue.c: Make sure to never call a
1750 function from another file while the queue is locked. This (hopefully)
1751 fixes another deadlock when exiting the application while retrieving
1754 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1756 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1757 Fixed build if libogs is not available
1759 2007-06-03 Christian Kellner <ckellner@openismus.com>
1761 * libmodest-dbus-client/libmodest-dbus-client.h:
1762 * libmodest-dbus-client/libmodest-dbus-client.c:
1763 (libmodest_dbus_client_delete_message):
1764 Implement deletion of messages (Client side).
1766 (modest_search_hit_free),
1767 (modest_search_hit_list_free):
1768 Utility functions to free the result hits.
1770 * src/dbus_api/modest-dbus-api.h:
1771 * src/dbus_api/modest-dbus-callbacks.c:
1772 (on_delete_message),
1773 (modest_dbus_req_handler):
1774 Implement deletion of messages (Server side).
1776 * tests/dbus_api/test_search.c: (main):
1779 * tests/dbus_api/Makefile.am:
1780 * tests/dbus_api/test_delete_message:
1781 Add little test for the message deletion logic
1783 2007-06-03 Armin Burgmeier <armin@openismus.com>
1785 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1786 when the operation queue was not empty. projects.maemo.org bug
1789 2007-06-03 Armin Burgmeier <armin@openismus.com>
1791 * src/widgets/modest-account-view.c
1792 (on_account_default_toggled): Toggle default account column
1793 explicitely instead of waiting for gconf notification (which is
1794 currently ignored). This should fix projects.maemo.org bug NB#56910
1795 for now. It should probably be removed when gconf notifications are
1798 2007-06-03 Christian Kellner <ckellner@openismus.com>
1800 * libmodest-dbus-client/libmodest-dbus-client.c:
1801 Removed debugging spew.
1803 * src/dbus_api/modest-dbus-callbacks.c:
1804 Added debugging info.
1806 * src/modest-search.c:
1807 (modest_search_all_accounts):
1808 Use tny_account_store_get_accounts () on the account store
1809 to get all accounts which is the way to get all accounts.
1811 * tests/dbus_api/test_search.c: (main):
1812 Make it possible to supply the search term on the command line.
1814 2007-06-03 Christian Kellner <ckellner@openismus.com>
1816 * libmodest-dbus-client/libmodest-dbus-client.c:
1817 * libmodest-dbus-client/libmodest-dbus-client.h:
1818 Implement searching for mesages over raw dbus. (Client side)
1820 * src/dbus_api/Makefile.am:
1821 * src/dbus_api/modest-dbus-api.h:
1822 * src/dbus_api/modest-dbus-callbacks.c:
1823 * src/dbus_api/modest-dbus-callbacks.h:
1824 Search framework (Server side). Also implement on_idle_open_message().
1826 * src/maemo/modest-platform.c: (modest_platform_init):
1827 Prepare for raw dbus/osso rpc interaction.
1829 * src/modest-search.h:
1830 Changed minsize from unspecific guint to guint32.
1832 * src/modest-search.c:
1834 Added strange hack which magically made tnymail work.
1836 (modest_search_folder),
1837 (modest_search_account),
1838 (modest_search_all_accounts):
1839 Implement helper functions to search all accounts, specific account
1842 * tests/dbus_api/Makefile.am:
1843 * tests/dbus_api/test_open_message.c:
1844 Read url to open from commandline.
1846 * tests/dbus_api/test_search.c:
1847 Implement small test for dbus search stuff
1849 2007-06-02 Armin Burgmeier <armin@openismus.com>
1851 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1852 include account type and account title. This fixes projects.maemo.org
1855 * src/maemo/modest-account-view-window.c: Set a title for the window.
1857 2007-06-02 Armin Burgmeier <armin@openismus.com>
1859 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1860 incoming and outgoing server name based on email address and server
1861 types as long as the names have not been edited manually. This fixes
1862 projects.maemo.org bug NB#58671.
1864 2007-06-02 Armin Burgmeier <armin@openismus.com>
1866 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1867 server type cannot be changed in future to the incoming details page
1868 when creating an account. This fixes projects.maemo.org bug NB#59029.
1870 2007-06-02 Armin Burgmeier <armin@openismus.com>
1872 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1873 and assigned max width chars so that they wrap instead of being
1874 truncated. Fixes projects.maemo.org bug NB#56126.
1876 2007-06-02 Armin Burgmeier <armin@openismus.com>
1878 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1879 introductory note to the connection specific smtp servers dialog, as
1880 section 8.12 of the email UI specification requires. This fixes
1881 projects.maemo.org bug NB#59212.
1883 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1885 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1886 Check for running mail operations, and offer to cancel them, as per the UI
1887 spec. This fixes projects.maemo.org bug NB#59041 .
1888 However, I suspect that tinymail may still use the network connection
1889 in ways that we cannot detect or cancel. But it should at least adapt to
1890 changes fairly well.
1892 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1894 * src/modest-tny-account-store.c: (recreate_all_accounts),
1895 (get_cached_accounts), (get_server_accounts): Do more sensible
1896 ref-counting of the temporarily-cached outbox accounts list. This seems
1897 to fix a crash when entering the password when the password was wrong.
1899 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1901 * src/gnome/modest-main-window.c: (connect_signals):
1902 * src/modest-tny-account-store.c: (get_password),
1903 (modest_tny_account_store_alert): Added comments and clues and
1904 commented-out code about how we currently fail to deal with connection
1905 errors and wrong passwords, and how we should.
1907 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1909 * src/widgets/modest-retrieve-combo-box.c:
1910 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1911 This fixes projects.maemo.org bug NB#58472 .
1913 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1915 * src/maemo/easysetup/modest-easysetup-wizard.c:
1916 (create_page_complete_easysetup):
1917 (create_page_complete_custom): Correct the last commit,
1918 putting the correct sentences in the correct pages.
1920 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1922 * src/maemo/easysetup/modest-easysetup-wizard.c:
1923 (create_page_complete_custom): Show the second sentence of text
1924 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1927 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1929 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1930 Set the leave-on-server conf key by default. This fixes
1931 projects.maemo.org bug NB#59258 .
1933 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1935 * src/maemo/modest-account-view-window.c:
1936 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1937 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1940 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1942 * src/maemo/easysetup/modest-easysetup-wizard.c:
1943 (create_caption_new_with_asterisk):
1944 * src/maemo/modest-account-settings-dialog.c:
1945 (create_caption_new_with_asterisk):
1946 Uncomment the code to add the asterisk, because they are no longer in the
1947 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1948 (update_incoming_server_title): Add an asterisk here too.
1950 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1952 * src/maemo/modest-maemo-global-settings-dialog.c:
1953 (current_connection): Check that we are even connected before trying to
1954 get the current connection name, to prevent a warning.
1956 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1957 Change the comments because tny_maemo_conic_device_connect() is now meant to
1959 * src/modest-mail-operation.c:
1960 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1961 make sure we have a connection and fail if we can't connect.
1963 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1965 * src/maemo/modest-main-window.c:
1966 (on_account_store_connecting_finished): Do not try to get the
1967 connection ID if we are not really connected. I am surprised that
1968 this signal handler is called when we are not connected.
1970 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1972 * src/modest-error.h:
1973 * src/modest-ui-actions.c:
1974 (modest_ui_actions_get_msgs_full_error_handler):
1975 Renamed an enum, added comments, added an enum
1976 for retrieve-limit errors.
1978 * src/modest-mail-operation.c: (foreach_add_item),
1979 (internal_folder_observer_update), (update_account_thread),
1980 (modest_mail_operation_get_msgs_full):
1981 (modest_mail_operation_update_account),
1982 Added comments about how this works, and some code that should
1983 (but does not) check the retrieve-limit. See the TODO comment.
1985 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1987 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1988 Initialize help_id to fix the build. Warnings are good.
1990 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1992 * src/widgets/modest-hbox-cell-renderer.c:
1993 (modest_hbox_cell_renderer_append):
1994 * src/widgets/modest-vbox-cell-renderer.c:
1995 (modest_vbox_cell_renderer_append):
1996 Fix the last commit by doing an extra ref.
1998 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2000 * src/widgets/modest-hbox-cell-renderer.c:
2001 (modest_hbox_cell_renderer_append):
2002 * src/widgets/modest-vbox-cell-renderer.c:
2003 (modest_vbox_cell_renderer_append):
2004 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2005 to fix the build with Maemo Bora.
2006 However, there seems to be a remaining crash, probably due to reference
2009 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2011 * src/modest-tny-account.c:
2012 (modest_tny_account_new_for_local_folders):
2013 Use hildon_file_system_info_async_new() to get a better name for
2014 the memory card account, setting it as the account name.
2015 The timing seems to work, but this is probably
2016 not the best place to do this. See the TODO comment.
2017 * src/maemo/modest-main-window.c: (create_details_widget):
2018 * src/widgets/modest-folder-view.c: (text_cell_data):
2019 Use the tny account name instead of hardcoding a name.
2021 2007-05-30 Christian Kellner <ckellner@openismus.com>
2023 * src/modest-search.c: (modest_search):
2024 Correctly set part_search_func even if we have already parsed
2025 the query and thus a valid OgsTextSearcher object.
2027 2007-05-30 Christian Kellner <ckellner@openismus.com>
2030 Search and check for libogs.
2033 Incooparte the ogs build env.
2035 * src/modest-mime-part-search-stream.c:
2036 * src/modest-mime-part-search-stream.h:
2037 Removed since we do the real searching now in modest-search.c.
2039 * src/modest-search.c:
2040 * src/modest-search.h:
2041 Implement support for ogs. We use that if available and requested
2042 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2043 should now handle the corner case when the search term is spread
2044 across multiple reads.
2045 Also the logic in modest_search () was corrected to search all
2046 requested fields until one is found.
2048 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2050 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2052 * src/modest-init.h:
2053 * src/modest-init.c: Made modest_init_local_folders() take a
2054 path and be public so we can iniitialize maildir folders on
2057 * src/modest-local-folder-info.h:
2058 * src/modest-local-folder-info.c:
2059 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2061 * src/modest-tny-account.c:
2062 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2063 still means the standard local-folders path on the local volume.
2065 * src/modest-tny-account-store.c:
2066 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2067 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2068 all accounts when that happens.
2069 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2070 this too, so it shows up in the treeview.
2072 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2074 * src/maemo/modest-maemo-global-settings-dialog.c:
2075 (current_connection):
2076 * src/widgets/modest-global-settings-dialog.c:
2077 (current_connection_default):
2078 Use the enum values instead of 0, 1 and -1,
2079 to make the code clearer.
2081 * src/modest-account-mgr-helpers.c:
2082 (modest_account_mgr_get_connection_specific_smtp): Make this code
2085 * src/modest-runtime.h:
2086 * src/modest-runtime.c:
2087 Added modest_runtime_remove_all_send_queues().
2088 * src/maemo/modest-main-window.c:
2089 (on_account_store_connecting_finished): Recreate the send queues,
2090 using the appropriate transport accounts for this new connection.
2091 Some futher adapting might be needed if the old send queues are not
2092 automatically stopped at this point.
2094 * src/modest-tny-account-store.c: (get_server_accounts):
2095 Create the connection-specific transport accounts, so that they can
2096 be found later by their ID.
2098 * src/modest-tny-account.h:
2099 * src/modest-tny-account.c:
2100 Added modest_tny_account_new_from_server_account_name().
2101 modest_tny_account_new_from_server_account(): Do not create the
2102 send queues here, because they will be
2103 recreated anyway when the connection changes for the first time.
2105 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2107 * src/modest-local-folder-info.h:
2108 * src/modest-local-folder-info.c:
2109 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2110 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2111 tbox_folder): Take a modest account name instead of a server TnyAccount,
2112 so we can have per-modest-account rather than per-transport-account
2114 We must make sure that we change or recreate the exisitng send queues
2115 when the connection changes for connection-specific transport accounts.
2117 * src/modest-tny-account-store.c:
2118 (create_per_account_local_outbox_folders): Create outboxed per modest
2119 account, not per transport account.
2121 * src/modest-tny-account.h:
2122 * src/modest-tny-account.c:
2123 (modest_tny_account_get_special_folder): For outboxes, get the
2124 parent modest account name. The account is ignored for other folders.
2125 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2126 modest account name rather than a server TnyAccount.
2128 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2130 * src/modest-tny-account.c:
2131 (modest_tny_account_new_from_server_account):
2132 Call modest_runtime_get_send_queue() immediately after creating transport
2133 accounts, so that they start trying to send email from the outbox as soon
2134 as possible at startup. This is probably what we want.
2136 * src/modest-mail-operation.c: (update_account_thread):
2137 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2138 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2139 * src/modest-tny-send-queue.h:
2140 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2141 (modest_ui_actions_on_send):
2142 Added comments about how sending works, though it needs some more work.
2144 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2146 * src/modest-tny-account.c:
2147 (modest_tny_account_get_special_folder): Add TODO because this fails when
2148 the network is busy.
2149 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2150 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2151 Do not try to show this window when there is no active account. The UI
2152 specs does not tell us what to do in this case.
2154 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2158 * src/maemo/Makefile.am:
2159 * src/widgets/Makefile.am: Some dist fixes.
2161 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2163 * src/maemo/modest-connection-specific-smtp-window.c:
2164 (on_button_edit): Make the code clearer, to prevent a double free.
2166 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2168 * src/maemo/modest-account-settings-dialog.c:
2169 (modest_account_settings_dialog_set_account_name),
2170 Check the connection-specific smtp servers checkbox if there are any.
2172 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2173 (modest_connection_specific_smtp_edit_window_init):
2174 Start with a suitable port number.
2176 * src/modest-account-mgr-helpers.h:
2177 * src/modest-account-mgr-helpers.c: Added
2178 modest_account_mgr_get_has_connection_specific_smtp().
2180 (modest_account_mgr_set_connection_specific_smtp),
2181 (modest_account_mgr_remove_connection_specific_smtp),
2182 (modest_account_mgr_get_has_connection_specific_smtp),
2183 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2184 connection-specific smtp server accounts in the account, rather than
2185 the server account conf dir.
2187 This fixes bug projects.maemo.org bug NB#58263 .
2189 * src/modest-tny-account-store.c:
2190 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2191 if there are no server accounts yet, to prevent an infinite loop when there
2192 are no accounts. Document that one must be called before the other.
2194 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2196 * src/modest-account-mgr-helpers.c:
2197 (modest_account_mgr_get_default_account): Make sure that at least
2198 one account is always the default, if there are any enabled accounts.
2199 This is just a sanity check that shouldn't be necessary.
2201 * src/modest-account-mgr-priv.c:
2202 (_modest_account_mgr_account_from_key): Unescape the conf key to
2203 get the real account name. For instance, this is an issue if a space
2204 was in the account name, which can happen because the account name
2205 is generated from the display name.
2206 (_modest_account_mgr_get_account_keyname): Always escape the
2208 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2209 Unescape the conf keys to get the real account names.
2211 For instance, previously the is-default radio button in the accounts
2212 list was not checked for any accounts at first. This fixes that,
2213 and might fix several similar bugs.
2215 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2217 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2218 Removed some debug printfs.
2220 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2222 Modest on-disk outbox directories are now here, for instance:
2223 $HOME/.modest/outboxes/<account-id-1>/outbox
2224 $HOME/.modest/outboxes/<account-id-2>/outbox
2226 $HOME/.modest/local-folders/outbox
2227 so we can have a separate outbox for each account.
2228 But they are shown as one outbox in the GtkTreeView, by using a
2229 TnyMergeFolder in a ModestTnySimpleFolderStore.
2232 * src/modest-tny-simple-folder-store.c:
2233 * src/modest-tny-simple-folder-store.h:
2234 Added ModestTnySimpleFolderStore, used to contain folders from
2235 other folder stores, such as other accounts.
2237 * src/modest-tny-outbox-account.h:
2238 * src/modest-tny-outbox-account.c:
2239 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2240 used for the per-account local outbox folders.
2242 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2243 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2244 only use this (internally) now for the non-outbox local folders.
2246 * src/modest-init.h:
2247 * src/modest-init.c: Added modest_init_one_local_folder(), for
2248 setting up the directory structure for each local folder.
2250 * src/modest-local-folder-info.c:
2251 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2252 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2254 * src/modest-local-folder-info.h:
2255 * src/modest-tny-account-store.c: (on_account_removed),
2256 (on_account_changed), (create_per_account_local_outbox_folders),
2257 (get_server_accounts), (modest_tny_account_store_get_accounts),
2258 (modest_tny_account_store_get_tny_account_by_account),
2259 (modest_tny_folder_store_is_virtual_local_folders):
2261 * src/modest-tny-account.h:
2262 * src/modest-tny-account.c:
2263 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2264 to create an on-disk per-account local outbox folder for each
2266 (create_per_account_local_outbox_folders): Create a local outbox folder
2267 for each transport account.
2268 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2269 for all local folders.
2271 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2272 instead of using g_object_get/set() directly. It is clearer.
2274 (modest_tny_folder_store_get_message_count),
2275 (modest_tny_folder_store_get_local_size
2276 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2277 because we now use these with non-acount folder stores.
2279 (modest_tny_account_get_special_folder),
2280 (modest_tny_account_new_from_server_account),
2281 (modest_tny_account_new_from_account):
2282 (recurse_folders): Adjust to the new outbox system.
2284 * src/modest-tny-folder.h:
2285 * src/modest-tny-folder.c:
2286 (modest_tny_folder_is_local_folder),
2287 (modest_tny_folder_get_local_folder_type),
2288 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2290 * src/widgets/modest-main-window.h:
2291 * src/maemo/modest-main-window.c: (create_details_widget),
2292 (modest_main_window_set_contents_style): Show details for any folder store,
2295 (modest_tny_folder_get_rules):
2296 Remove the const. C does not support constness enough for this.
2298 * src/modest-ui-actions.c:
2299 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2300 make all outboxes appear as one, in the usual local-folders tree node.
2302 (set_active_account_from_tny_account),
2303 (modest_ui_actions_on_folder_selection_changed):
2304 * src/widgets/modest-folder-view.c: (text_cell_data),
2305 (icon_cell_data), (filter_row),
2306 (add_account_folders_to_merged_folder),
2307 (add_account_folders_to_simple_folder_store), (),
2308 (get_cmp_rows_type_pos), (cmp_rows),
2309 (modest_folder_view_set_account_id_of_visible_server_account):
2310 Adjust to the new outbox system, using generic folder stores and folders
2311 in the GtkTreeModel.
2313 2007-05-23 Christian Kellner <ckellner@openismus.com>
2315 * src/modest-mail-operation.c:
2316 (modest_mail_operation_update_account):
2317 Use info->max_size instead of unintialized local var [small
2318 build fix]. (Added TODO to review that change since I don't
2321 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2323 * libmodest-dbus-client/libmodest-dbus-client.c:
2324 (libmodest_dbus_client_compose_mail): function added
2325 * src/dbus_api/modest-dbus-api.h:
2326 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2327 (on_compose_mail): Implementation of the SendAsMail functionality
2329 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2331 * src/modest-account-mgr.c:
2332 (modest_account_mgr_add_server_account): Set the secure-connection
2333 conf key for transport accounts as well as store accounts. I don't know
2334 why the if was there. For instance, this makes sure that we use SSL
2335 for the gmail preset from the easysetup wizard.
2337 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2339 * src/gnome/modest-main-window.c:
2340 (on_account_store_connecting_finished), (connect_signals):
2341 * src/maemo/modest-main-window.c:
2342 (on_account_store_connecting_finished), (connect_signals),
2343 (modest_main_window_new):
2344 Handle TnyAccountStore::connecting-finished instead of
2345 TnyDevice::connection-changed, because we cannot actually perform
2346 operations on accounts until TnyAccountStore has itself responded to
2347 the TnyDevice::connection-changed signal. This prevents a GError from
2349 Do not try to update at startup, because we (at least on scratchbox)
2350 already do an update at startup when the device goes online.
2351 This prevents a GError from tinymail.
2352 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2353 Added TODO about stopping simultaneous operations.
2355 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2357 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2358 * src/modest-mail-operation-queue.c:
2359 (modest_mail_operation_queue_remove):
2360 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2361 about where they happened.
2363 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2365 * src/modest-ui-actions.c:
2366 (modest_ui_actions_on_password_requested): Make sure that the remember
2367 output parameter is always TRUE.
2369 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2371 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2372 Show a OK/Cancel dialog if the error is a question, though we still do not
2373 know anything more about what we are asking the user.
2374 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2375 Fix an uninitialized variable (helper). This is a logic error, however.
2377 2007-05-21 Christian Kellner <ckellner@openismus.com>
2379 * src/modest-search.h:
2380 Correct bit shifting in the ModestSearchFlags enum.
2382 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2384 * src/modest-tny-account.c:
2385 (modest_tny_account_new_from_server_account): Do not use the lsub and
2386 check-all hard-coded IMAP options when using POP.
2388 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2390 * src/modest-tny-account.c:
2391 (modest_tny_account_new_from_server_account):
2392 Use NULL for the secure-auth method for POP when Password auth has been
2393 specified by the user, as we already do for IMAP. "auth=Login" causes
2394 an error from camel or the server.
2396 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2398 * src/maemo/modest-account-settings-dialog.c:
2399 (create_page_account_details),
2400 (modest_account_settings_dialog_set_account_name):
2401 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2402 for the leave-on-server checkbox, rathr than just the checkbox, when
2403 the protocol is not POP.
2405 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2407 * src/widgets/modest-account-view.c:
2408 * src/widgets/modest-account-view.h:
2409 Added modest_account_view_select_account() which will be useful later
2410 to asynchronously re-select the edited account.
2412 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2414 * src/maemo/modest-account-settings-dialog.c:
2415 (modest_account_settings_dialog_set_account_name):
2416 Automatically choose the port numbers based on the secure authentication
2417 methods, if they have not been chosen before.
2418 This fixes projects.maemo.org bug NB#56273 .
2420 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2422 * src/maemo/modest-main-window-ui.h:
2423 * src/modest-ui-actions.c:
2424 * src/modest-ui-actions.h:
2425 Connect the Tools/SMTP Servers menu item to
2426 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2427 SMTP servers dialog, as in the UI specification and saves changes when it
2428 is closed. This fixed projects.maemo.org bug NB#56305 .
2430 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2432 * src/maemo/modest-connection-specific-smtp-window.c:
2433 (modest_connection_specific_smtp_window_init):
2434 Use gtk_window_set_default_size() to make this window big enough, so
2435 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2437 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2439 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2440 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2441 (modest_connection_specific_smtp_edit_window_init),
2442 Do not try to connect to a combobox signal before the combobox exists.
2443 This fixes the cras in projects.maemo.org bug NB#56288 .
2444 (modest_connection_specific_smtp_edit_window_get_settings):
2445 Remove the server_account_name parameter which was being checked for NULL
2446 though it was not used.
2448 * src/maemo/modest-connection-specific-smtp-window.c:
2449 (modest_connection_specific_smtp_window_fill_with_connections),
2450 (on_button_edit), (modest_connection_specific_smtp_window_init):
2451 Correct the number of treemodel columns to prevent a warning.
2452 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2453 libconic does not work.
2455 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2457 * src/modest-tny-account.c:
2458 (modest_tny_account_new_from_server_account):
2459 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2460 SMTP when "None" was chosen by the user. However, with my SMTP server that
2461 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2464 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2466 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2467 to explain the memory management issue with the ID in the ModestPair.
2469 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2470 (add_sending_page), (modest_account_assistant_finalize):
2471 * src/gnome/modest-gnome-global-settings-dialog.c:
2472 (create_updating_page), (create_composing_page):
2473 * src/gnome/modest-msg-edit-window.c: (get_transports),
2474 (init_window), (modest_msg_edit_window_finalize),
2475 (modest_msg_edit_window_get_msg_data):
2476 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2477 * src/gnome/modest-transport-widget.c:
2478 (modest_transport_widget_finalize), (smtp_configuration):
2479 * src/maemo/modest-maemo-global-settings-dialog.c:
2480 (create_updating_page), (create_composing_page):
2481 * src/maemo/modest-msg-edit-window.c: (get_transports),
2482 (init_window), (modest_msg_edit_window_finalize),
2483 (modest_msg_edit_window_get_msg_data),
2484 (modest_msg_edit_window_free_msg_data):
2485 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2486 (modest_store_widget_finalize):
2487 * src/maemo/modest-transport-widget.c:
2488 (modest_transport_widget_finalize), (smtp_configuration):
2489 * src/modest-main.c: (send_mail):
2490 * src/widgets/modest-combo-box.h:
2491 * src/widgets/modest-global-settings-dialog-priv.h:
2492 * src/widgets/modest-global-settings-dialog.c:
2493 (modest_global_settings_dialog_finalize):
2494 * src/widgets/modest-msg-edit-window.h:
2495 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2496 as long as the combo box, to prevent use of freed memory for the ID.
2498 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2500 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2501 get_accounts(), to make this clearer. Do not check for the enabled gconf
2502 key, because we do not use this for server accounts (at least, not yet).
2503 This allows us to send email again.
2505 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2507 * src/maemo/modest-platform.c:
2508 (on_modest_conf_update_interval_changed), (modest_platform_init):
2509 Only respond to this particular key change. All these strcmp()s cannot be
2512 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2514 * src/maemo/modest-maemo-global-settings-dialog.c:
2515 (current_connection): Prevent a crash in scratchbox when
2516 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2517 * src/maemo/modest-platform.c:
2518 (on_modest_conf_update_interval_changed), (modest_platform_init):
2519 Get the update interval from gconf and reset it when the gconf key changes.
2521 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2523 * src/modest-protocol-info.c:
2524 * src/modest-protocol-info.h: Adde enum-specific get functions,
2525 instead of using a ModestProtocolType enum parameter.
2527 * src/gnome/modest-account-assistant.c:
2528 * src/gnome/modest-store-widget.c:
2529 * src/gnome/modest-store-widget.h:
2530 * src/gnome/modest-transport-widget.c:
2531 * src/gnome/modest-transport-widget.h:
2532 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2533 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2534 * src/maemo/easysetup/modest-easysetup-wizard.c:
2535 * src/maemo/modest-account-settings-dialog.c:
2536 * src/maemo/modest-account-settings-dialog.h:
2537 * src/maemo/modest-store-widget.c:
2538 * src/maemo/modest-store-widget.h:
2539 * src/maemo/modest-transport-widget.c:
2540 * src/maemo/modest-transport-widget.h:
2541 * src/modest-account-mgr-helpers.c:
2542 * src/modest-account-mgr-helpers.h:
2543 * src/modest-account-mgr.c:
2544 * src/modest-account-mgr.h:
2545 * src/modest-tny-account.c:
2546 * src/modest-tny-folder.c:
2547 * src/widgets/modest-account-view.c:
2548 * src/widgets/modest-retrieve-combo-box.c:
2549 * src/widgets/modest-retrieve-combo-box.h:
2550 * src/widgets/modest-secureauth-combo-box.c:
2551 * src/widgets/modest-serversecurity-combo-box.c:
2552 * src/widgets/modest-serversecurity-combo-box.h:
2553 * tests/check_account-mgr.c:
2554 Use the specific functions, and use the re-renamed enum values for GNOME too.
2556 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2558 * src/modest-pair.h:
2559 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2560 so we can get the second based on the first.
2562 * src/maemo/modest-account-settings-dialog.h:
2563 * src/maemo/modest-account-settings-dialog.c:
2564 Added get_supported_secure_authentication_methods(), though it is mostly
2565 commented-out for now until the necessary API is committed to tinymail.
2566 (modest_account_settings_dialog_set_account_name),
2567 (save_configuration): Request the supported authentication methods from the
2568 server, so we can choose a working method.
2570 * src/modest-tny-account-store.h:
2571 * src/modest-tny-account-store.c:
2572 (modest_tny_account_store_get_session): Rename from
2573 tny_account_store_get_session().
2575 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2577 * src/modest-protocol-info.h: Split the ModestProtocol enum
2578 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2579 There was no need to have these unrelated values in one enum.
2581 * src/: many files: Adapted to changed enum. This makes the code a bit
2582 clearer, and the compiler could catch some errors.
2584 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2586 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2587 Show the detailed internal camel error message when an error happens
2588 during the configuration, so that our testers can give us more clues.
2589 For instance, in projects.maemo.org bug NB#56910 .
2591 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2593 * src/modest-tny-account.c:
2594 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2595 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2597 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2599 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2600 * src/maemo/modest-account-settings-dialog.c:
2601 (modest_account_settings_dialog_set_account_name),
2602 (save_configuration): For the incoming secure authentication checkbox,
2603 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2604 the UI specification. PLAIN does not seem to be supported for most IMAP
2605 servers anyway, and I am not sure what it would mean.
2606 However, we probably need to discover which of the secure-authentication
2607 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2608 * src/modest-account-mgr-helpers.c:
2609 (modest_account_mgr_get_server_account_data):
2611 * src/modest-tny-account.c:
2612 (modest_tny_account_new_from_server_account):
2613 Use tny_account_set_mech() to set secure-authentication methods,
2614 with some special-casing for IMAP, based on my observations of how
2617 * src/modest-account-mgr-helpers.h:
2618 * src/modest-account-mgr.c:
2619 * src/modest-defs.h: Comment that the URI is only used for local folders.
2621 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2623 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2624 parameter const, just to be neat.
2625 * src/modest-text-utils.c: (modest_text_utils_inline):
2626 End g_strconcat() with NULL, as its documentation says. This is almost
2627 certainly the cause of my crash at startup on the device. Interestingly,
2628 valgrind doesn't tell us about these errors.
2630 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2632 * scripts/build-packages: Added more precise comments about how to use
2633 this script, though I still get this error:
2634 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2635 error building tinymail
2637 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2639 * src/maemo/modest-main-window.c: (on_account_update):
2640 Very slight cleanup, hoping to make it simpler to discover what causes
2641 a crash here sometimes.
2643 * src/modest-tny-account.c:
2644 (modest_tny_account_new_from_server_account): Set the port. Added
2645 comments about the options and a TODO comment because I need to find out
2646 how to specify the secure authentication method.
2648 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2650 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2651 changed CFlags paths form modest to libmodest
2653 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2655 * src/modest-account-mgr-helpers.c:
2656 (modest_account_mgr_get_server_account_data),
2657 (modest_account_mgr_free_server_account_data):
2658 * src/modest-account-mgr-helpers.h:
2659 * src/modest-account-mgr.c:
2660 (modest_account_mgr_add_server_account):
2661 * src/modest-defs.h:
2662 * src/modest-tny-account.c:
2663 (modest_tny_account_new_from_server_account):
2664 Determine the options for tny_camel_account_add_option() here,
2665 based on the settings, rather than storing them directly in gconf.
2667 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2669 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2670 Show a more friendly error dialog now that we expect (from the tinymail
2671 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2673 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2675 * src/maemo/modest-main-window.c: (on_account_update): Check that
2676 account_name is not NULL, to prevent a crash at startup that I am
2677 seeing on the N800. I do wonder why it is NULL.
2679 * src/maemo/easysetup/modest-easysetup-wizard.c:
2680 (create_page_user_details):
2681 * src/maemo/modest-account-settings-dialog.c:
2682 (create_page_user_details), (create_page_outgoing):
2683 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2684 (modest_connection_specific_smtp_edit_window_init):
2685 * src/modest-ui-actions.c:
2686 (modest_ui_actions_on_password_requested):
2687 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2688 might do something useful with the on-screen keyboard.
2690 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2692 * src/maemo/modest-main-window.c: (on_account_update):
2693 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2694 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2696 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2698 * src/modest-tny-account-store.c: (on_account_changed):
2699 Correct the signature of this signal handler.
2701 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2703 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2704 Show a HildonNote instead of a GtkDialog for Maemo.
2706 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2708 * src/widgets/modest-account-view.h:
2709 * src/widgets/modest-account-view.c: (on_account_changed),
2710 (on_account_removed). Added a boolean flag, set/unset by
2711 modest_account_view_block_conf_updates(),
2712 modest_account_view_unblock_conf_updates() to prevent unnecessary
2713 updates, but this is not very useful because the gconf notifications are
2714 so delays (maybe only on Maemo Bora).
2715 So auto-updating is turned off, and these functions do an explicit
2716 update when necessary.
2717 However, something else is still doing too much work when adding/removing
2718 accounts, probably in another part of the application.
2720 * src/maemo/modest-account-view-window.c:
2721 (on_delete_button_clicked), (on_edit_button_clicked),
2722 (on_new_button_clicked): Use the new functions.
2724 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2726 * src/modest-account-mgr-helpers.c:
2727 (modest_account_mgr_set_first_account_as_default):
2728 Sort the list of names alphabetically-by-title, so we choose the first one
2730 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2731 alphabetically by the title.
2733 This fixes projects.maemo.org bug NB#56418 .
2735 * src/modest-account-mgr-priv.c:
2736 (_modest_account_mgr_account_from_key):
2737 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2738 avoid a valgrind error, and possible random behaviour.
2740 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2742 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2743 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2744 tinymail documentation to say that this can be expected.
2745 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2746 pretty, and should not happen, but I would prefer to know when it does.
2748 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2750 * configure.ac: When using the older hildon version, probably on Bora,
2751 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2753 * src/widgets/modest-attachment-view.c:
2754 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2757 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2759 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2760 Implemented the prototype. Can be tested with
2761 tests/dbus_api/test_open_message:
2763 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2765 * src/modest-tny-account-store.c:
2766 (modest_tny_account_store_instance_init), (get_password):
2767 * src/modest-ui-actions.c:
2768 (modest_ui_actions_on_password_requested):
2769 Do not store the password in gconf, because this function is called
2770 for non-remembered passwords. Actually use the cached (in the hash map)
2771 password instead of releasing it.
2772 The password will now not be remembered if it is asked via the protected
2773 password dialog, as per the UI spec.
2775 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2777 * src/modest-defs.h:
2778 * src/modest-account-mgr-helpers.h:
2779 * src/modest-account-mgr-helpers.c:
2780 Added modest_server_account_get_username_has_succeeded(),
2781 modest_server_account_set_username_has_succeeded().
2782 (modest_server_account_set_username),
2783 Reset the has-succeeded flag if the username changes.
2785 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2786 * src/maemo/modest-connection-specific-smtp-window.c:
2787 (modest_connection_specific_smtp_window_save_server_accounts):
2788 Use modest_server_account_set_username() instead of using
2789 modest_conf_set_string() directly, so that the has-succeeded flag is always
2792 * src/modest-ui-actions.c:
2793 (modest_ui_actions_on_password_requested): Dim the username entry if
2794 the username has ever worked, as per the UI spec.
2796 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2798 * src/modest-tny-account-store.c: (get_password):
2799 * src/modest-ui-actions.c:
2800 (modest_ui_actions_on_password_requested):
2801 Allow the username to be changed too, though there is more work to
2802 be done on exactly how this behaves.
2804 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2806 * src/modest-account-mgr-helpers.h:
2807 * src/modest-account-mgr-helpers.c:
2808 Added modest_account_mgr_get_display_name(),
2809 modest_server_account_get_username(),
2810 modest_server_account_set_username(),
2811 modest_server_account_set_password(),
2812 modest_server_account_get_hostname() functions so we do not need to
2813 use the conf API directly.
2815 * src/maemo/modest-main-window.c: (connect_signals):
2816 Actually connect ot the ModestAccountStore::request-password signal,
2817 so that we show the dialog when the password is requested by Tinymail,
2818 for isntance if it is empty.
2820 * src/modest-marshal.list:
2821 * src/modest-tny-account-store.c:
2822 (modest_tny_account_store_class_init), (get_password),
2823 (modest_tny_account_store_alert):
2824 * src/modest-tny-account-store.h:
2825 * src/modest-ui-actions.h:
2826 * src/modest-ui-actions.c:
2827 (modest_ui_actions_on_password_requested):
2828 Change the signal parameters, so it is obvious that we are providing
2829 the non human-readable server name, and receiving both the username
2830 and password, though changing of the username is not yet implemented.
2831 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2832 for the GNOME version.
2834 This should fix the projects.maemo.org bug NB#56209, though it does not
2835 work on Bora, because the gconf_client_get() for the password fails
2836 immediately after we save it with gconf_client_set().
2838 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2841 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2842 caused an undefined symbol error:
2843 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2845 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2847 * src/modest-tny-account-store.c:
2848 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2849 using a GError instead of a string message, so we can translate it in
2852 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2854 * src/maemo/modest-address-book.c:
2855 (modest_address_book_check_names):
2856 * src/maemo/modest-msg-view-window.c:
2857 (modest_msg_view_window_clipboard_owner_change):
2858 * src/modest-init.c: (modest_init_init_ui):
2859 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2860 (update_folders_cb), (modest_mail_operation_update_account):
2861 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2862 (modest_ui_actions_on_msg_attachment_clicked),
2863 (modest_ui_actions_on_msg_recpt_activated):
2864 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2865 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2866 (modest_msg_view_search_next):
2867 * src/widgets/modest-recpt-editor.c:
2868 (modest_recpt_editor_on_button_release_event),
2869 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2870 g_message(). At this point we should only be seeing interesting errors on
2871 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2873 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2875 (modest_wizard_dialog_force_title_update):
2876 * src/maemo/easysetup/modest-wizard-dialog.h:
2877 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2878 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2879 can update the title when appropriate. Otherwise the title is wrong if the
2880 pages are added after adding the notebook to the dialog.
2881 This must be a problem in HildonWizardDialog too.
2882 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2884 * src/maemo/easysetup/modest-easysetup-wizard.c:
2885 (create_subsequent_customsetup_pages),
2886 (create_subsequent_easysetup_pages):
2887 Call modest_wizard_dialog_force_title_update() so that the title is
2888 correct even with GTK+ < 2.10.
2889 This fixes projects.maemo.org bug NB#56145 .
2891 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2893 * src/maemo/modest-platform.c:
2894 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2895 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2898 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2900 * src/widgets/modest-window.h:
2901 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2902 and modest_window_save_state(), which invokes it.
2904 * src/widgets/modest-window-mgr.h:
2905 * src/widgets/modest-window-mgr.c:
2906 Added modest_window_mgr_save_state_for_all_windows(), which calls
2907 the save_state vfunc on all registered windows, if implemented.
2909 * src/gnome/modest-msg-edit-window.c:
2910 * src/gnome/modest-msg-view-window.c:
2911 * src/maemo/modest-msg-edit-window.c:
2912 * src/maemo/modest-msg-view-window.c:
2913 * src/maemo/modest-main-window.c:
2914 Specify the existing save_settings functions as implementations of
2915 ModestWindow::save_state_func().
2917 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2918 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2919 enabling hibernation, for instance.
2921 We may need to do the same thing for restoring settings.
2924 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2926 * src/widgets/modest-window-mgr.c:
2927 * src/widgets/modest-window-mgr.h:
2928 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2929 modest_window_mgr_get_hibernation_is_prevented().
2931 * src/maemo/modest-main-window.c:
2932 (on_hildon_program_is_topmost_notify): Prevent hibernation
2933 (possible when the application goes to the background in the WM),
2934 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2936 * src/maemo/easysetup/modest-easysetup-wizard.c:
2937 (modest_easysetup_wizard_dialog_init):
2938 * src/maemo/modest-account-settings-dialog.c:
2939 (modest_account_settings_dialog_init):
2940 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2941 (modest_connection_specific_smtp_edit_window_init):
2942 * src/maemo/modest-connection-specific-smtp-window.c:
2943 (modest_connection_specific_smtp_window_init):
2944 * src/maemo/modest-signature-editor-dialog.c:
2945 (modest_signature_editor_dialog_init):
2946 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2947 prevent hibernation while any of these account settings dialogs are open.
2949 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2951 * src/maemo/Makefile.am:
2952 * src/maemo/modest-osso-state-saving.c:
2953 * src/maemo/modest-osso-state-saving.h: Added
2954 modest_osso_load_state() and modest_osso_save_state() though they do
2955 nothing now. They should iterate through all the open windows and load/save
2957 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2958 save state when closing.
2960 * src/maemo/modest-main-window.c:
2961 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2962 Add a notification handler for the HildonProgram::is-topmost property,
2963 so we can allow hibernation when the application goes into the background.
2964 But we still need to detect when the accounts setup windows are open so
2965 we can stop hibernation when they are open.
2966 To do this, I also added the main window the HildonProgram. This might have
2967 other side-effects/benefits, and should maybe be done for other windows.
2969 * src/maemo/modest-osso-autosave-callbacks.h:
2970 * src/maemo/modest-osso-autosave-callbacks.c:
2971 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2972 though it does not do anything yet, and we might never need this to do
2973 anything. For instance, we already save drafts.
2975 * src/maemo/modest-platform.c: (modest_platform_init):
2976 Specify the libosso auto-save callback.
2978 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2980 * src/maemo/modest-platform.c:
2981 (modest_platform_set_update_interval):
2982 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2983 aparently stays valid between application instances, so we can use this
2984 to remove and reset it later. According to a maemo-developers email from
2987 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2989 * configure.ac: Depend on libalarm for Maemo.
2991 * src/dbus_api/modest-dbus-api.h:
2992 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2993 (on_send_receive), (modest_dbus_req_handler):
2994 Handle a SEND_RECEIVE D-Bus method.
2996 * libmodest-dbus-client/libmodest-dbus-client.c:
2997 (libmodest_dbus_client_send_and_receive):
2998 * libmodest-dbus-client/libmodest-dbus-client.h:
2999 Add C convenience functions for calling the new D-Bus method.
3001 * src/modest-platform.h:
3002 * src/gnome/modest-platform.c:
3003 * src/maemo/modest-platform.c:
3004 Added modest_platform_set_update_interval(), which uses the
3005 alarmd API on Maemo.
3006 (modest_platform_init),
3007 Call modest_platform_set_update_interval(), using a hard-coded
3008 interval for now (until the global settings dialog is implemented),
3009 though I am not sure that this makes sense yet.
3011 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3013 * src/dbus_api/modest-dbus-callbacks.c:
3014 (modest_osso_cb_hw_state_handler):
3015 * src/dbus_api/modest-dbus-callbacks.h:
3016 * src/maemo/modest-platform.c: (modest_platform_init):
3017 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3018 in case this has some effect on the ability for Maemo to ping the
3021 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3023 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3024 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3025 warning. It is probably a logic error, but I need to fix the build.
3027 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3029 * src/modest-account-mgr.h:
3030 * src/modest-account-mgr.c:
3031 (modest_account_mgr_account_names): Add a gboolean enabled_only
3032 parameter, so we can get lists of onlt the enabled accounts.
3034 (modest_account_mgr_add_account),,
3035 (modest_account_mgr_account_with_display_name_exists):
3036 * src/maemo/modest-msg-edit-window.c: (get_transports):
3037 * src/modest-account-mgr-helpers.c:
3038 (modest_account_mgr_set_first_account_as_default):
3039 * src/modest-init.c: (init_default_account_maybe):
3040 * src/modest-tny-account-store.c: (get_accounts):
3041 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3042 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3043 * tests/check_account-mgr.c: (START_TEST):
3044 Provide the extra parameter, as appropriate.
3046 * src/widgets/modest-account-view.c: (update_account_view):
3047 Do not show disabled accounts (meaning that there is no way to
3048 enable/disable accounts in the UI (the feature is not in our UI
3049 specification), so we can use this internally only to mark unfinished
3050 or temporary account data.
3052 * src/maemo/easysetup/modest-easysetup-wizard.c:
3053 (create_account): Add boolean enable parameter, so we can specify FALSE
3054 to create the temporary account.
3055 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3056 (on_before_next): When finishing, when there is a temporary account, just
3058 Also, use a timeout to delay the showing of the dialog until gconf is likely
3059 to return correct information, due to a maemo gconf bug that is fixed in
3060 osso 1.1, but not yet in Bora.
3061 However, the dialog stays on screen after it is destroyed.
3063 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3064 for invalid data when cancelling. Use a hildon note instead of a dialog
3065 to complain about invalid data. Do not show the account-saved note if the
3066 account is disabled (a temporary account that will not really be saved for use
3069 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3071 * src/modest-account-mgr-helpers.h:
3072 * src/modest-account-mgr-helpers.c:
3073 Added modest_account_mgr_unset_default_account(),
3074 Added modest_account_mgr_set_first_account_as_default().
3076 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3077 If it was the default account, unset the default account name.
3079 * src/maemo/modest-account-view-window.c:
3080 (on_delete_button_clicked): If it was the default account,
3081 set the first remaining account as the default instead.
3083 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3084 a NULL account or a NULL default account, to prevent a crash. This should
3085 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3088 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3090 * src/widgets/modest-recpt-editor.c:
3091 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3092 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3093 TODO comment for this. This fixes the build.
3095 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3096 be the best place for it. This will in future update all auto-update accounts,
3097 rather than just the current/default account, when that gconf key exists.
3098 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3099 if there are no accounts, before calling do_send_receive().
3100 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3102 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3103 * src/maemo/modest-main-window-ui.h:
3104 * src/maemo/modest-main-window.c: (on_connection_changed),
3105 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3106 directly, becaue the signal handler does more.
3108 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3110 * src/modest-account-mgr-helpers.c:
3111 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3112 for the case that the account does not exist.
3114 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3115 (equivalent to the modest account name) rather than the tinymail account name
3116 (equivalent to the modest account title - human readable) to get the account data.
3117 Check for null account data to prevent the crash, and add a TODO comment saying that
3118 this needs fixing because it is using the server account name instead of the account name.
3120 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3122 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3123 * src/maemo/modest-account-settings-dialog.c: (show_error),
3125 Use hildon_note_new_information() for informative and error messages,
3126 which seems to be expected for Maemo applications (no documentation that I know of
3127 says this). I am surprised that there is no distinction between info and error
3130 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3132 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3133 it is easy to find where this is used.
3135 * src/maemo/easysetup/modest-easysetup-wizard.c:
3136 (create_page_welcome), (create_page_account_details),
3137 (create_page_user_details), (create_page_complete_easysetup),
3138 (create_page_custom_incoming), (create_page_custom_outgoing),
3139 (create_page_complete_custom):
3140 * src/maemo/modest-account-settings-dialog.c:
3141 (create_page_account_details), (create_page_user_details),
3142 (create_page_incoming), (create_page_outgoing):
3143 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3144 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3145 (modest_connection_specific_smtp_edit_window_init):
3146 * src/maemo/modest-connection-specific-smtp-window.c:
3147 (modest_connection_specific_smtp_window_init):
3148 * src/maemo/modest-signature-editor-dialog.c:
3149 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3150 and scrolling policy as per the Email Application Layout Guide, if I have
3153 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3155 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3156 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3157 which were empty, because these vfuncs have been removed from TnyAccountStore.
3158 This fixes the build.
3160 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3162 * src/maemo/modest-main-window.c:
3163 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3164 showing/hiding it. Added TODO because it probably should not be NULL.
3165 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3166 because unnecessary g_warnings() make degugging difficult.
3168 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3170 * src/maemo/modest-msg-edit-window.c:
3171 (modest_msg_edit_window_select_color),
3172 (modest_msg_edit_window_select_background_color): 2 const corrections and
3173 moving 2 #endifs before closing brackets, to fix the build.
3175 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3177 * src/maemo/easysetup/modest-easysetup-wizard.h:
3178 * src/maemo/easysetup/modest-easysetup-wizard.c:
3179 (modest_easysetup_wizard_dialog_finalize),
3180 (on_button_edit_advanced_settings), (create_page_complete_custom),
3181 (on_response), (create_account):
3182 Implement the Advanced Settings edit button, by saving the account information,
3183 for the Advanded Settings dialog to use directly from gconf, and removing it
3184 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3185 Bug #5533 in the projects.maemo.org bugzilla.
3187 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3189 * src/maemo/modest-msg-view-window.c:
3190 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3191 when opening a message window.
3193 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3195 * src/maemo/easysetup/modest-easysetup-wizard.c:
3196 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3199 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3200 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3201 gconf settings. I probably added more checks than necessary, but that is safer.
3203 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3204 variable to fix the build, but this seems to be used when it is still NULL.
3206 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3208 * src/modest-platform.h:
3209 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3210 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3211 * src/modest-main.c: Implement this function so we can avoid using
3212 maemo-specific API from cross-platform code.
3214 * src/modest-tny-account-store.c:
3215 (get_smtp_specific_transport_account_for_open_connection):
3216 * src/modest-ui-actions.c: (check_for_connection),
3217 (modest_ui_actions_on_item_not_found):
3218 Use modest_platform_connect_and_wait() and put #idefs around other
3219 maemo-specific code, because only maemo currently has a way to
3220 identify connection names.
3222 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3224 * src/modest-tny-account-store.h:
3225 * src/modest-tny-account-store.c:
3226 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3227 the connection-specific SMTP server settings in the configuration.
3229 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3231 * src/maemo/modest-main-window.c: (on_connection_changed),
3233 * src/modest-main.c: (main), (start_ui), (send_mail):
3234 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3235 that is what is intended.
3237 * src/modest-ui-actions.c: (action_send), (action_receive),
3238 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3239 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3240 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3241 SMTP server is used when it is specified.
3243 (modest_ui_actions_on_send_receive):
3244 Check that a connection is open before proceeding.
3245 Receive and then send, instead of vice-versa, as per the specification.
3247 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3249 * src/modest-mail-operation.c:
3250 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3251 though I guess it should be something other than NULL.
3253 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3255 * src/maemo/easysetup/modest-easysetup-wizard.c:
3256 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3257 combo twice, to avoid an g_warning and to make it visible again.
3258 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3259 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3260 (already intended) dereference when detaching, because we then recreate the menu.
3261 But I am not sure why the warning was happening, and it is possible that this is a memory
3264 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3266 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3267 and uri_parse_mailto() utility functions.
3268 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3270 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3272 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3274 * src/dbus_api/modest-dbus-api.h:
3275 * src/dbus_api/modest-dbus-callbacks.c:
3276 Use an idle callback to execute the modest code in the application's own thread.
3277 Remove the helloworld example method.
3278 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3279 parsed, and the open-message method is not implemented because this is not yet implemented in
3281 * libmodest-dbus-client/libmodest-dbus-client.c:
3282 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3283 (libmodest_dbus_client_open_message):
3284 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3286 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3287 body without crashing.
3289 * tests/dbus_api/Makefile.am:
3290 * tests/dbus_api/test_mail_to.c:
3291 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3293 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3295 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3296 Added file to fix the build. Sorry.
3298 * src/dbus_api/Makefile.am:
3299 * src/dbus_api/modest-dbus-api.h:
3300 * src/dbus_api/modest-dbus-callbacks.h:
3301 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3302 (modest_dbus_req_handler):
3303 Put constants in a separate header so it can be reused by the
3304 client library, without duplication
3306 * libmodest-dbus-client/Makefile.am:
3307 * libmodest-dbus-client/libmodest-dbus-client.c:
3308 (libmodest_dbus_client_call_helloworld),
3309 (libmodfest_dbus_client_send_mail),
3310 (libmodfest_dbus_client_mailto),
3311 (libmodfest_dbus_client_open_message):
3312 * libmodest-dbus-client/libmodest-dbus-client.h:
3313 (Partly) Implement a send_mail D-Bus method.
3315 * tests/dbus_api/Makefile.am:
3316 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3317 the send_email D-Bus method.
3319 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3323 * libmodest-dbus-client/Makefile.am:
3324 * libmodest-dbus-client/libmodest-dbus-client.c:
3325 * libmodest-dbus-client/libmodest-dbus-client.h:
3326 * tests/dbus_api/Makefile.am:
3327 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3328 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3330 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3332 * src/maemo/easysetup/modest-easysetup-wizard.c:
3333 (create_page_account_details):
3334 * src/maemo/modest-account-settings-dialog.c:
3335 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3336 widgets, because this might not be the default in future versions of the Maemo GTK+.
3337 However, I can not not get capitalization to work even in a simple test case.
3339 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3341 * src/maemo/easysetup/modest-easysetup-wizard.c:
3342 (create_page_custom_incoming), (create_page_custom_outgoing):
3343 * src/maemo/modest-account-settings-dialog.c:
3344 (create_page_account_details), (create_page_incoming),
3345 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3346 instead of using gtk_check_button_with_label(), so they are aligned like the other
3347 widgets, as per the UI spec.
3349 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3351 * src/maemo/easysetup/modest-easysetup-wizard.c:
3352 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3353 * src/widgets/modest-validating-entry.c:
3354 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3355 Modest prefix instead of an EasySetup prefix.
3357 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3359 * src/widgets/modest-validating-entry.h:
3360 * src/widgets/modest-validating-entry.c: (on_insert_text),
3361 Added easysetup_validating_entry_set_max_func(), used to set a callback
3362 to call when the max number of characters is reached. GtkEntry has a max-length
3363 already but is silent about it.
3365 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3366 (create_page_account_details), (create_page_user_details),
3368 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3369 (create_page_account_details), (create_page_user_details),
3370 (create_page_outgoing):
3371 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3372 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3373 the UI spec, when the user tries to enter more than the max number of characters.
3375 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3377 * src/maemo/easysetup/modest-easysetup-wizard.c:
3378 (create_page_user_details), (create_page_custom_incoming),
3379 (create_page_custom_outgoing):
3380 * src/maemo/modest-account-settings-dialog.c:
3381 (create_page_user_details), (create_page_incoming),
3382 (create_page_outgoing):
3383 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3384 (modest_connection_specific_smtp_edit_window_init):
3385 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3386 not appropriate. Bad Maemo-specific defaults!.
3388 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3390 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3391 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3392 (modest_signature_editor_dialog_set_settings):
3393 Disable the label and textview when the checkbox is disabled, and use the
3394 specified (UI spec) default signature text.
3396 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3398 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3399 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3401 * src/modest-defs.h:
3402 * src/modest-account-mgr-helpers.h:
3403 * src/modest-account-mgr-helpers.c:
3404 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3406 * src/maemo/Makefile.am:
3407 * src/maemo/modest-signature-editor-dialog.c:
3408 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3411 * src/maemo/modest-account-settings-dialog.h:
3412 * src/maemo/modest-account-settings-dialog.c:
3413 (modest_account_settings_dialog_finalize), (on_button_signature),
3414 (save_configuration): Use the new dialog when the Edit button is pressed, and
3415 save the changes if necessary, as per the UI spec.
3417 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3419 * src/maemo/Makefile.am:
3420 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3421 based on maemo-develoers email from Dirk.
3423 * src/maemo/easysetup/modest-easysetup-wizard.c:
3424 (create_page_welcome), (create_page_account_details),
3425 (create_page_user_details), (create_page_complete_easysetup),
3426 (create_page_custom_incoming), (create_page_custom_outgoing),
3427 (create_page_complete_custom),
3428 (modest_easysetup_wizard_dialog_init):
3429 * src/maemo/modest-account-settings-dialog.c:
3430 (create_page_account_details), (create_page_user_details),
3431 (create_page_incoming), (create_page_outgoing),
3432 (modest_account_settings_dialog_init):
3433 * src/maemo/modest-connection-specific-smtp-window.c:
3434 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3436 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3438 * src/maemo/easysetup/modest-easysetup-wizard.c:
3439 (create_page_account_details), (create_page_custom_outgoing),
3440 (create_page_complete_custom):
3441 * src/maemo/modest-account-settings-dialog.c:
3442 (create_page_user_details), (create_page_incoming),
3443 (create_page_outgoing):
3444 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3445 (modest_connection_specific_smtp_edit_window_init):
3446 Use the correct (UI spec) port min/max, and use horizontal separators,
3449 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3451 * src/maemo/easysetup/modest-easysetup-wizard.c:
3452 (set_default_custom_servernames):
3453 * src/maemo/modest-account-settings-dialog.c:
3454 (create_page_incoming), (on_combo_outgoing_security_changed),
3455 (on_combo_incoming_security_changed), (create_page_outgoing),
3456 (modest_account_settings_dialog_set_account_name),
3457 (save_configuration):
3458 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3459 (on_combo_security_changed),
3460 (modest_connection_specific_smtp_edit_window_init),
3461 (modest_connection_specific_smtp_edit_window_set_connection),
3462 (modest_connection_specific_smtp_edit_window_get_settings):
3463 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3466 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3469 * src/maemo/easysetup/modest-easysetup-wizard.c:
3470 (create_page_custom_outgoing), (create_page_complete_custom):
3471 * src/maemo/modest-account-settings-dialog.c:
3472 (create_page_user_details), (create_page_outgoing):
3473 * src/maemo/modest-account-view-window.c: (button_box_new):
3474 Use changed logical IDs as per the most recent UI spec:
3475 mcen_bd_emailsetup_edit -> mcen_bd_edit
3476 mcen_bd_emailsetup_delete -> mcen_bd_delete
3477 mcen_bd_emailsetup_close -> mcen_bd_close
3479 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3483 * src/dbus_api/Makefile.am:
3484 * src/dbus_api/modest-dbus-callbacks.c:
3485 * src/dbus_api/modest-dbus-callbacks.h:
3486 * src/maemo/modest-platform.c: (modest_platform_init):
3487 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3489 * tests/Makefile.am:
3490 * tests/dbus_api/Makefile.am:
3491 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3493 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3495 * src/maemo/modest-account-settings-dialog.c:
3496 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3497 Removed unnecessary includes.
3499 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3501 * src/maemo/easysetup/modest-easysetup-wizard.c:
3502 * src/maemo/modest-account-settings-dialog.c:
3503 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3504 * src/widgets/Makefile.am:
3505 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3506 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3507 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3508 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3509 * src/widgets/modest-secureauth-combo-box.c:
3510 * src/widgets/modest-secureauth-combo-box.h:
3511 * src/widgets/modest-serversecurity-combo-box.c:
3512 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3513 made the GObject names more consistent with the rest of the Modest code.
3515 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3517 * src/maemo/easysetup/Makefile.am:
3518 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3519 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3520 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3521 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3522 * src/maemo/easysetup/modest-easysetup-wizard.c:
3523 * src/maemo/easysetup/modest-validating-entry.c:
3524 * src/maemo/easysetup/modest-validating-entry.h:
3525 * src/maemo/modest-account-settings-dialog.c:
3526 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3527 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3528 widgets/ because they are used outside of easysetup too. After checking in,
3529 svn will allow me to rename them too.
3531 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3533 * src/gnome/modest-msg-edit-window.c:
3534 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3535 linker error, to fix the build on the GNOME platform.
3536 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3537 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3538 ifdefed out to avoid a warning.
3540 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3542 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3543 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3544 some alternative for GTK+ 2.6.
3546 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3548 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3550 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3551 specified for EmailAccountsDialog in UI spec.
3553 * src/maemo/easysetup/modest-easysetup-wizard.c:
3554 * src/maemo/easysetup/modest-easysetup-wizard.h:
3555 * src/maemo/modest-account-settings-dialog.c:
3556 * src/maemo/modest-account-settings-dialog.h:
3557 Reuse a member window widget for the connection-specific SMTP server accounts,
3558 so we can tell it to create/save the accounts only if we actually save changes.
3560 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3561 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3562 (modest_connection_specific_smtp_edit_window_get_settings):
3563 Return a struct instance for temporarily remembering the entered data.
3565 * src/maemo/modest-connection-specific-smtp-window.h:
3566 * src/maemo/modest-connection-specific-smtp-window.c:
3567 (modest_connection_specific_smtp_window_finalize),
3568 (modest_connection_specific_smtp_window_fill_with_connections),
3570 (modest_connection_specific_smtp_window_save_server_accounts),
3571 (update_model_server_names): Do not actually save data until asked,
3572 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3574 (on_selection_changed),
3575 (modest_connection_specific_smtp_window_init): Disable the edit
3576 button when nothing is selected.
3578 * src/modest-account-mgr-helpers.c:
3579 * src/modest-account-mgr-helpers.h:
3580 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3583 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3585 * src/modest-account-mgr-helpers.h:
3586 * src/modest-account-mgr-helpers.c:
3587 (modest_account_mgr_get_unused_account_name),
3588 (modest_account_mgr_get_unused_account_display_name): Added these
3589 utility functions, to avoid code duplication.
3591 * src/maemo/easysetup/modest-easysetup-wizard.c:
3592 (create_page_account_details), (create_account):
3593 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3594 (on_combo_security_changed),
3595 (modest_connection_specific_smtp_edit_window_init),
3596 (modest_connection_specific_smtp_edit_window_save_settings):
3597 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3598 * src/maemo/modest-connection-specific-smtp-window.c:
3599 (modest_connection_specific_smtp_window_finalize),
3600 (modest_connection_specific_smtp_window_fill_with_connections),
3601 (on_button_edit), (modest_connection_specific_smtp_window_init):
3602 * src/maemo/modest-connection-specific-smtp-window.h:
3603 Implementing saving of connection-specific server accounts.
3605 But I need to refactor this so we can save the data for each
3606 possible connection-specific account and only actually create the server accounts
3607 when the easysetup finished, or the OK button is pressed on the account settings
3610 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3612 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3613 (on_combo_security_changed):
3614 (modest_connection_specific_smtp_edit_window_init):
3615 Auto-fill the port number as in the account settings.
3617 (modest_connection_specific_smtp_edit_window_set_connection):
3618 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3619 * src/maemo/modest-connection-specific-smtp-window.c:
3620 (fill_with_connections), (on_button_edit),
3621 (modest_connection_specific_smtp_window_init):
3622 Turn the edit window into a dialog to simplify the code, and
3623 set a WM hint as in a GtkDialog, because only a popup can be on top of
3624 another window in Maemo, and popups usually have no WM decoration.
3626 * src/modest-defs.h:
3627 * src/modest-account-mgr-helpers.c:
3628 (modest_account_mgr_set_connection_specific_smtp),
3629 (modest_account_mgr_remove_connection_specific_smtp),
3630 (modest_account_mgr_get_connection_specific_smtp):
3631 * src/modest-account-mgr-helpers.h: Some functions to write the
3632 connection-specific SMTP server information. Not yet used.
3635 * src/widgets/modest-folder-view.c: (text_cell_data):
3636 Fix a warning about an uninitialized variable.
3637 (on_configuration_key_changed): Put an #ifdef around the use
3638 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3640 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3642 * src/maemo/modest-account-settings-dialog.h:
3643 * src/maemo/modest-account-settings-dialog.c:
3644 Added connect_for_modified() utility function to mark the new modified boolean.
3646 (create_page_account_details), (create_page_user_details),
3647 (create_page_incoming), (create_page_outgoing), (on_response),
3648 (modest_account_settings_dialog_init),
3649 (modest_account_settings_dialog_set_account_name):
3650 Only warn about unsaved changes when there are actually unsaved changes.
3652 * src/modest-account-mgr-helpers.c:
3653 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3654 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3655 to get the data from there in future.
3657 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3659 * src/modest-defs.h:
3661 * src/modest-account-mgr-helpers.h:
3662 * src/modest-account-mgr-helpers.c:
3663 Store the security account setting in a single conf key instead of using
3664 the options list, so that the list is left for just the to-be-removed camel hack,
3665 and because gconf_client_set_list() is failing for some reason.
3667 * src/modest-account-mgr.c:
3668 (modest_account_mgr_add_server_account):
3669 * src/maemo/modest-account-settings-dialog.c:
3670 (modest_account_settings_dialog_set_account_name),
3671 (save_configuration): Use the renamed functions.
3674 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3676 * src/widgets/Makefile.am:
3677 * src/widgets/modest-limit-retrieve-combo-box.c:
3678 * src/widgets/modest-limit-retrieve-combo-box.h:
3679 * src/widgets/modest-retrieve-combo-box.c:
3680 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3681 the account settings dialog.
3683 * src/modest-defs.h:
3684 * src/modest-account-mgr-helpers.h:
3685 * src/modest-account-mgr-helpers.c:
3686 (modest_server_account_get_option_secure_auth),
3687 (modest_server_account_set_option_secure_auth):
3688 * src/modest-account-mgr.c:
3689 (modest_account_mgr_add_server_account):
3690 Use the existing AUTH_MECH conf key for the secure-auth setting,
3691 instead of putting it in the list options, because this was actually used already.
3693 * src/maemo/modest-account-settings-dialog.c:
3694 (create_page_account_details),
3695 (modest_account_settings_dialog_set_account_name),
3696 (save_configuration):
3697 * src/maemo/modest-account-settings-dialog.h:
3698 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3699 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3701 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3703 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3704 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3705 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3707 * src/modest-defs.h:
3708 * src/maemo/modest-account-settings-dialog.c:
3709 (create_page_incoming), (on_combo_outgoing_security_changed),
3710 (on_combo_incoming_security_changed), (create_page_outgoing),
3711 (modest_account_settings_dialog_set_account_name),
3712 (save_configuration): Load/Save the port number, and change it when the
3713 security combo changes, to suitable defaults.
3715 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3717 * src/modest-account-mgr.c:
3718 (modest_account_mgr_add_server_account): Set the security and secure-auth
3719 options, and add a comment saying that the other camel-specific options should be
3722 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3724 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3726 * src/modest-tny-account-store.c: (account_list_free),
3727 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3728 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3731 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3733 * src/modest-protocol-info.c:
3734 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3735 is required by our UI spec. Maybe something in our implementation will use this eventually.
3736 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3737 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3738 instead of the previous 0 placeholder.
3740 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3741 secure-auth settings.
3742 * src/modest-account-mgr-helpers.h:
3743 * src/modest-account-mgr-helpers.c:
3744 (modest_server_account_data_get_option_secure_auth),
3745 (modest_server_account_set_option_secure_auth),
3746 (modest_server_account_data_get_option_security),
3747 (modest_server_account_set_option_security): Added this API for getting and setting the security
3748 and secure-auth settings.
3750 * src/maemo/modest-account-settings-dialog.h:
3751 * src/maemo/modest-account-settings-dialog.c:
3752 (modest_account_settings_dialog_finalize), (check_data),
3753 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3754 about changing titles.
3755 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3756 (save_configuration): Save the security and secure-auth settings.
3758 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3759 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3761 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3763 * src/modest-defs.h:
3764 * src/modest-account-mgr.c:
3765 (modest_account_mgr_add_server_account):
3766 Added and used defines for the options key and value pair strings,
3767 that are used so far, though they do not seem to correspond to anything in our
3768 UI specs or ModestProtocol enum.
3770 * src/modest-account-mgr-helpers.h:
3771 * src/modest-account-mgr-helpers.c:
3772 (compare_option_strings_for_name),
3773 (modest_server_account_data_get_option_value),
3774 (modest_server_account_data_get_option_bool),
3775 (modest_account_mgr_get_server_account_option):
3776 Added helper functions for parsing the options GSList.
3778 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3780 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3781 display name is based on the supplied account name.
3782 * src/modest-account-mgr.c:
3783 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3784 with an inefficient, but good-enough, implementation.
3786 * src/maemo/easysetup/modest-easysetup-wizard.c:
3787 (create_page_account_details), (on_before_next), (create_account):
3788 Check for existing display names rather than (non-user-visible) account names, and just
3789 create and set a unique account name at the end.
3791 * src/maemo/modest-account-settings-dialog.c:
3792 (modest_account_settings_dialog_init),
3793 (modest_account_settings_dialog_set_account_name),
3794 (create_page_incoming): Show the display name, instead of the account name.
3795 (on_response): Do some (not all) extra checks, as in the UI spec.
3796 (save_configuration): Save the display name if it was changed.
3798 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3800 * po/en_GB.po: Added needed logical ID and translation.
3801 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3802 (init_view): Made the is-default column clicking work.
3804 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3807 * src/maemo/easysetup/Makefile.am:
3808 * src/maemo/easysetup/modest-easysetup-wizard.c:
3809 (modest_easysetup_wizard_dialog_init):
3810 * src/maemo/easysetup/provider-data-test.keyfile:
3811 * src/maemo/easysetup/provider-data.keyfile:
3812 Moved the provider data file to the new modest-providers-data package and used it from there.
3814 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3816 * src/modest-local-folder-info.c:
3817 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3818 N_() was already used on the static strings, but this just marks it for translation without
3819 using the translation.
3821 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3823 * src/maemo/modest-account-settings-dialog.c:
3824 (create_page_incoming),
3825 (modest_account_settings_dialog_set_account_name):
3826 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3827 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3828 I will do this if nobody else gets there first.
3830 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3832 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3833 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3834 save the security stuff.
3836 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3838 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3839 Set the email address and user fullname, which I now see must be
3842 * src/maemo/modest-account-settings-dialog.h:
3843 * src/maemo/modest-account-settings-dialog.c:
3845 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3846 leave-on-server and authentication.
3847 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3850 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3853 * src/maemo/modest-account-settings-dialog.c:
3854 * src/maemo/modest-account-settings-dialog.h:
3855 Most (but not all) of the widgets are now present as specified by the UI spec.
3856 No changes are yet saved, and some details are not properly shown yet.
3858 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3860 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3862 * src/maemo/Makefile.am:
3863 * src/maemo/modest-account-settings-dialog.c:
3864 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3865 an existing account. Doesn't do much yet.
3867 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3868 Open the accounts settings dialog when Edit is clicked.
3870 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3872 * src/maemo/easysetup/Makefile.am:
3873 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3875 * src/maemo/easysetup/modest-easysetup-wizard.c:
3876 (modest_easysetup_wizard_dialog_init):
3877 Try to get the source directory from the build system,
3878 instead of hard-coding "./" into the source code, when opening our local
3879 copies of the configuration files.
3880 But this still fails when opening the wizard from the Accounts window,
3881 maybe because the working directory seems to change at runtime.
3882 So the wizard will fail the second time unless you copy the files into their
3883 proper locations - see the stdout warnings for the paths.
3885 (create_page_account_details),(on_before_next):
3886 Check for existing non-server accounts instead of server accounts,
3887 so the default account name is useful again, and to prevent trying to
3890 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3891 Show the wizard when New is clicked.
3893 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3894 (init_view): Show the column headers, and show the columns that are
3895 specified in the UI specs. However, something in Maemo's GTK+ prevents
3896 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3897 change the default account. This is despite unsetting the special properties.
3899 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3901 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3902 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3903 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3904 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3905 to make that clearer.
3906 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3908 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3910 * src/maemo/modest-account-view-window.c:
3911 (modest_account_view_window_init),
3912 (modest_account_view_window_new):
3913 Use the same buttons as specified in the
3914 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3915 the existing widgets, which never had a chance of working.
3916 Put the ModestAccountView treeview in a scrolled window.
3917 Do not repeat the initialization in both _init() and _new().
3919 * src/widgets/modest-account-view.c: (update_account_view):
3920 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3921 this widget and window shows no accounts.
3923 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3925 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3927 * src/maemo/easysetup/modest-easysetup-wizard.c:
3928 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3929 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3930 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3933 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3934 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3935 accounts exist yet, as in the UI spec.
3937 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3939 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3941 * src/maemo/Makefile.am:
3942 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3943 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3944 New window for editing connection-specific smtp details.
3945 Not fully implemented.
3947 * src/maemo/modest-connection-specific-smtp-window.c:
3948 (modest_connection_specific_smtp_window_finalize) :
3949 unref the tree model.
3950 (on_button_edit): Show the edit window.
3952 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3954 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3957 * src/maemo/Makefile.am:
3958 * src/maemo/modest-connection-specific-smtp-window.c:
3959 * src/maemo/modest-connection-specific-smtp-window.h:
3960 New window for showing the list of connections, for connection-specific
3961 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3962 * src/maemo/easysetup/modest-easysetup-wizard.c:
3963 (create_page_custom_outgoing): Show the new window when the button is clicked.
3965 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3967 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3968 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3969 * src/maemo/modest-msg-edit-window.c:
3970 (modest_msg_edit_window_insert_image):
3971 * src/modest-conf.c: (modest_conf_key_escape):
3972 * src/modest-mail-operation.c:
3973 (modest_mail_operation_send_new_mail):
3974 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3975 (modest_ui_actions_on_new_account):
3976 * src/widgets/modest-attachment-view.c: (update_filename_request):
3977 * src/widgets/modest-mail-header-view.c:
3978 Corrected warnings that were breaking the build, by commenting out unused variables,
3979 and a function, and by including a header.
3981 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3983 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3984 so we can #ifdef around platform-specific code when necessary.
3985 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3986 to allow this to build for the GNOME platform too.
3988 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3990 * src/maemo/easysetup/modest-easysetup-wizard.c:
3991 Added util_increment_name() and used it in create_page_account_details()
3992 to make sure that the default account name is always a new name.
3994 (modest_easysetup_wizard_dialog_init),
3995 (set_default_custom_servernames): Some minor memory management fixes.
3997 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4001 * src/modest-runtime.c: (init_i18n): Restored the translation
4002 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4003 are defined in config.h, and the translations are installed.
4005 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4006 is defined for translation.
4008 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4010 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4012 * src/maemo/easysetup/modest-easysetup-wizard.c:
4013 (modest_easysetup_wizard_dialog_init):
4014 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4015 Use realistic paths (though they should use $prefix generically) to the
4016 mcc_mapping and provider-data.keyfile files which might work when they
4017 are installed by the future version of the operator-wizard package,
4018 and then fallback to paths in our source code, with an explanatory
4021 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4025 * src/maemo/Makefile.am:
4026 * src/maemo/easysetup/: Added files from the previously-exernal
4027 osso-modest-easysetup.
4028 * src/maemo/modest-main-window-ui.h:
4029 * src/modest-ui-actions.c:
4030 * src/modest-ui-actions.h:
4031 Added modest_ui_actions_on_new_account() as a signal handler for the
4032 New Account menu item. It shows the easysetup wizard.
4033 * po/en_GB.po: Added additional needed logical IDs and translations.