1 2007-06-26 Murray Cumming <murrayc@murrayc.com>
3 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
4 necessary because configure.ac now defines different variables.
6 2007-06-26 Murray Cumming <murrayc@murrayc.com>
8 * libmodest-dbus-client/libmodest-dbus-client.c:
9 * libmodest-dbus-client/libmodest-dbus-client.h:
10 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
11 libmodest_dbus_client_compose_mail() is what things actually use.
13 * src/dbus_api/modest-dbus-api.h:
14 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
15 * tests/dbus_api/Makefile.am:
16 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
19 2007-06-26 Murray Cumming <murrayc@murrayc.com>
21 * src/modest-init.c: (modest_init_local_folders):
22 For memory-card (or other non local-folders) maildir accounts,
23 always create an Archive folder, so that there is somewhere to put
24 messages. This should be less confusing, because the user does not need
25 to guess that the need to create a folder.
27 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
29 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
30 Fixed icon size by using (50, 50) which is the same as defined by
33 2007-06-25 Armin Burgmeier <armin@openismus.com>
35 * src/widgets/modest-window-mgr.c:
37 * configure.ac: Correctly recognize hildon-notify presence and fixed
38 the build without it being installed.
40 2007-06-25 Murray Cumming <murrayc@murrayc.com>
42 * libmodest-dbus-client/libmodest-dbus-client.c:
43 (libmodest_dbus_client_search): Fix the build. Sorry.
44 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
45 (reply_forward_cb): Initialize variables to fix the build.
47 * src/modest-tny-account-store.c:
48 (modest_tny_account_store_get_tny_account_by): Fix the account URI
49 comparison (a silly typo) so that email search results can be opened
50 when there are more than one account.
52 2007-06-25 Murray Cumming <murrayc@murrayc.com>
54 * libmodest-dbus-client/libmodest-dbus-client.c:
55 (libmodest_dbus_client_search),
56 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
57 instead of 1 second, because the search gets folders and messages from
58 the server, which can take a long time. When it times out,
59 osso-global-search will report no results.
61 We need to specify whether we should search only cached information
62 (maybe with a user preference), and the osso-email-search-plugin
63 API should really be improved to allow that option, and to allow results
64 to be delivered asynchronously in batches.
66 2007-06-25 Murray Cumming <murrayc@murrayc.com>
68 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
69 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
70 GTK_ICON_SIZE_DIALOG is probably the wrong size.
72 2007-06-25 Murray Cumming <murrayc@murrayc.com>
74 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
75 that is an empty string. D-Bus seems to give us these instead of NULL.
77 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
79 * src/dbus_api/modest-dbus-callbacks.c:
80 * src/maemo/easysetup/modest-easysetup-wizard.h:
81 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
82 * src/maemo/modest-connection-specific-smtp-edit-window.c:
83 (modest_connection_specific_smtp_edit_window_init):
84 * src/maemo/modest-maemo-global-settings-dialog.c:
86 * src/maemo/modest-maemo-utils.c:
87 (modest_maemo_utils_setup_images_filechooser):
88 * src/maemo/modest-main-window.c: (create_details_widget):
89 * src/maemo/modest-msg-edit-window.c:
90 (modest_msg_edit_window_attach_file_noninteractive),
91 (modest_msg_edit_window_color_button_change),
92 (modest_msg_edit_window_set_zoom):
93 * src/modest-mail-operation.c: (update_account_thread):
94 * src/modest-tny-account-store.c:
95 * src/modest-tny-account.c:
96 * src/widgets/modest-global-settings-dialog.c:
97 * src/widgets/modest-window.h:
101 2007-06-25 Murray Cumming <murrayc@murrayc.com>
103 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
104 * src/modest-search.c: (modest_search_folder),
105 (modest_search_all_accounts): Actually search only in the specified folder,
106 doing a simple match on the folder ID.
107 * src/modest-search.h: Added a folder field to the ModestSearch struct,
108 and added some documentation.
110 2007-06-22 Armin Burgmeier <armin@openismus.com>
112 * src/maemo/modest-maemo-utils.h:
113 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
114 modest_maemo_utils_get_supported_secure_authentication_methods.
116 * src/maemo/easysetup/modest-easysetup-wizard.c:
117 * src/maemo/modest-account-settings-dialog.c: Show correct error if
118 one occured, not just "Server does not support secure authentication".
120 2007-06-22 Murray Cumming <murrayc@murrayc.com>
122 * src/modest-tny-account-store.c: (get_password):
123 Restored the call to tny_account_set_user() because Philip seems to have
124 stopped this from crashing (by not using the freed string). It still does
125 not work, but now we can test it.
127 2007-06-22 Murray Cumming <murrayc@murrayc.com>
129 * src/maemo/modest-msg-edit-window.c: (init_window):
130 Comment out use of an uninitialzed GtkScrolledWindow variable,
131 to fix the build and stop a crash. Yet again.
133 2007-06-22 Murray Cumming <murrayc@murrayc.com>
135 * src/modest-tny-account-store.c: (get_password):
136 Remove the call to tny_account_set_user() because this actually crashes.
137 As mentioned in the last commit, it is known to not work anyway.
139 2007-06-22 Murray Cumming <murrayc@murrayc.com>
141 * src/modest-tny-account-store.c: (get_password):
142 Use tny_account_set_username() to tell tinymail that the username might
143 have changed too. But tinymail ignores this: see projects.maemo.org
145 * src/modest-ui-actions.c:
146 (modest_ui_actions_on_password_requested): Remove the useless attempt to
147 reset the connection when changing the username, and improve the comments.
148 Save the changed username to gconf at least, so it is used when Modest is
151 2007-06-21 Murray Cumming <murrayc@murrayc.com>
153 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
154 Do not use a query, so that we get all folders, including for POP and
155 local-folders. They work as search criteria too.
156 This fixes projects.maemo.org bug NB#57740.
158 2007-06-21 Murray Cumming <murrayc@murrayc.com>
160 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
161 Comment out the use of hildon_notification_set_sound() because it is
162 not declared, to fix the build. Warnings are serious, people.
164 2007-06-21 Armin Burgmeier <armin@openismus.com>
166 * src/maemo/modest-maemo-utils.h:
167 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
168 modest_maemo_utils_get_supported_secure_authentication_methods()
169 to query authentication methods for a specific user. This should fix
170 projects.maemo.org bug NB#61369.
172 * src/maemo/easysetup/modest-easysetup-wizard.c:
173 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
176 2007-06-21 Murray Cumming <murrayc@murrayc.com>
178 * libmodest-dbus-client/libmodest-dbus-client.h:
179 * libmodest-dbus-client/libmodest-dbus-client.c:
180 (modest_dbus_message_iter_get_search_hit),
181 (libmodest_dbus_client_search):
182 Reorganised and commented this.
183 Removed modest_search_hit_free() from the public API because it
186 Added libmodest_dbus_client_get_folders() and
187 modest_folder_result_list_free().
189 * src/dbus_api/modest-dbus-api.h:
190 * src/dbus_api/modest-dbus-callbacks.c:
191 (modest_dbus_req_filter): Commented. Moved most code to
192 on_dbus_method_search() and added on_dbus_method_get_folders().
194 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
195 of the extra D-Bus handler.
197 * tests/dbus_api/Makefile.am:
198 * tests/dbus_api/test_get_folders.c: New test for
199 libmodest_dbus_client_get_folders(). This seems to return an empty list
200 at the moment. That could be the same error that causes the message list
201 to be empty sometimes.
202 This should help with projects.maemo.org bug NB#57740.
204 2007-06-21 Armin Burgmeier <armin@openismus.com>
206 * src/modest-mail-operation.c: Do not call
207 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
208 notify the operation's end after having set the status to CANCELED for
209 the operation queue to listen on. This fixes a deadlock when there
210 were mail operations in the queue during its finalization.
212 * src/modest-singletons.c: Reordered uninitialization of the account
213 manager to happen after the mail operation queue was uninitialized
214 because the mail operation's in the queue might still try to access
215 the account manager (see modest_mail_operation_notify_end()). This
216 fixes a potential crash when terminating the application.
218 2007-06-21 Murray Cumming <murrayc@murrayc.com>
220 * src/modest-search.c:
221 (search_mime_part_and_child_parts): Moved some code here so we
222 can search recursively in child folders.
223 (modest_search_folder): Search in the message as a mime part, instead
224 of just its child mime parts.
225 (read_chunk), (search_mime_part_ogs):
226 Check how many bytes were read, to prevent an endless loop.
227 Searching in message bodies now works. This finishes the fix for
228 projects.maemo.org bug NB#61007.
230 2007-06-20 Murray Cumming <murrayc@murrayc.com>
232 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
233 Add a g_warning when the item is not a folder.
235 * src/modest-ui-dimming-rules.c:
236 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
237 when selected item is not a folder (for instance, an account), because
238 the UI spec only talks about folders.
239 I am not sure what the UI spec wants, so this might not totally fix
240 projects.maemo.org bug NB#60794.
242 2007-06-20 Murray Cumming <murrayc@murrayc.com>
244 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
245 (load_from_file): Sort the list. The unsorted list would be more noticeable
246 in non-English locales.
248 * src/maemo/modest-msg-edit-window.c:
249 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
250 warning and fix the build.
252 * src/maemo/modest-progress-bar-widget.c:
253 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
254 avoid a g_warning, and probably to avoid a crash.
256 2007-06-20 Murray Cumming <murrayc@murrayc.com>
258 * src/modest-search.c: (modest_search_folder): Check for a GError
259 when calling tny_folder_get_headers(), to show that this is not the cause
262 2007-06-20 Murray Cumming <murrayc@murrayc.com>
264 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
265 Actually set the body query instead of the subject query.
267 * src/modest-search.c: (search_mime_part_ogs),
268 (search_mime_part_strcmp): Remove extra space from the text/* regex,
269 which would probably cause it to fail if we got this far.
271 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
272 to simplify the code.
273 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
274 be causing search-in-body to fail.
276 2007-06-20 Murray Cumming <murrayc@murrayc.com>
278 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
280 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
281 Better debug message when the folder cannot be found.
282 This should help with fixing projects.maemo.org bug #61287.
283 * src/modest-search.c: (add_hit): Do not leak the furl string.
285 2007-06-20 Murray Cumming <murrayc@murrayc.com>
287 * src/modest-ui-actions.c:
288 (modest_ui_actions_on_folder_selection_changed):
289 Do not special-case TNY_MERGE_FOLDER here, because
290 modest_tny_folder_get_account() already does that. This fixes
291 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
292 shown when the Outbox was selected).
294 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
296 * libmodest-dbus-client/libmodest-dbus-client.c:
297 (_dbus_iter_get_string_or_null): Initialize the string variable in
298 case this helps with Dirk's crash.
300 2007-06-19 Murray Cumming <murrayc@murrayc.com>
302 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
303 though it is not implemented yet (this function is maybe not even used),
304 to avoid breaking ABI in future.
305 * libmodest-dbus-client/libmodest-dbus-client.c:
306 (get_attachments_string): Moved some code into this generic function.
307 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
308 sends email. It is maybe not used.
309 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
310 (on_send_mail): Use attachments.
312 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
313 * src/maemo/modest-msg-edit-window.c:
314 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
315 a filename before using it, to fix projects.maemo.org bug NB#58233.
317 2007-06-19 Murray Cumming <murrayc@murrayc.com>
319 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
320 Initialize the continue_download variable to fix the build, and probably
321 to fix randome behaviour.
323 2007-06-18 Armin Burgmeier <armin@openismus.com>
325 * src/modest-tny-send-queue.h:
326 * src/modest-tny-send-queue.c: Keep track of the status of messages in
327 the queue so we can later show it in the UI. Replaced
328 modest_tny_send_queue_msg_is_being_sent() by
329 modest_tny_send_queue_get_msg_status().
331 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
333 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
334 gpointer. This probably was not harmful, but just to be sure.
336 2007-06-18 Murray Cumming <murrayc@murrayc.com>
338 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
339 Fix the build, but leave the function broken on Bora, because
340 hildon_uri_action_get_service() does not exist.
341 osso_uri_action_get_service() does not exist either, it seems.
343 2007-06-18 Murray Cumming <murrayc@murrayc.com>
345 * src/modest-tny-account.c:
346 (modest_tny_account_new_from_server_account):
347 Uncommented the url debug output again, because it is useful for
348 debugging, as I said in the comment.
350 2007-06-18 Murray Cumming <murrayc@murrayc.com>
352 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
354 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
355 for Mameo Bora, to fix the build.
357 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
360 Fixed build with hildon < 0.99
362 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
363 Check if the selected account is busy instead of checking all accounts
365 * src/modest-account-mgr-priv.h:
366 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
367 (modest_account_mgr_init), (compare_account_name),
368 (modest_account_mgr_set_account_busy),
369 (modest_account_mgr_account_is_busy):
370 * src/modest-account-mgr.h:
371 Added busy information to the account manager. It possible to
372 set an account to busy or not busy now.
374 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
375 (modest_mail_operation_update_account),
376 (modest_mail_operation_notify_end):
377 Set the account to busy/not busy depending on the operation state.
379 * src/widgets/modest-account-view.c:
380 (modest_account_view_finalize), (get_last_updated_string),
381 (update_account_view), (on_account_busy_changed), (init_view):
382 Show string "Refreshing..." if the account is currently busy.
384 All this fixes projects.maemo.org bug NB#59711
386 2007-06-14 Armin Burgmeier <armin@openismus.com>
388 * src/widgets/modest-attachments-view.h:
389 * src/widgets/modest-attachments-view.c: Added
390 modest_attachments_view_has_attachments() and fixed coordinate
391 transformation in get_att_view_at_coords(). This fixes attachment
394 * src/widgets/modest-msg-view.c: Make use of
395 modest_attachments_view_has_attachments() to decide whether to show
396 attachments in the header.
398 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
400 * src/maemo/modest-connection-specific-smtp-edit-window.c:
401 (on_change), (on_combo_security_changed),
402 (modest_connection_specific_smtp_edit_window_init),
403 (modest_connection_specific_smtp_edit_window_set_connection),
404 (modest_connection_specific_smtp_edit_window_is_dirty):
405 * src/maemo/modest-connection-specific-smtp-edit-window.h:
406 * src/maemo/modest-connection-specific-smtp-window.c:
409 Show an comfirmation dialog for the smpt-edit-window if there are
410 unsaved changes and the user hits cancel.
411 (projects.maemo.org bug NB#60479)
413 2007-06-14 Armin Burgmeier <armin@openismus.com>
415 * src/maemo/easysetup/modest-easysetup-wizard.c:
416 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
417 address" info in banner instead of node, and select all the text as
418 per UI spec. This fixes projects.maemo.org bug NB#60550.
420 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
422 reviewed by: <delete if not using a buddy>
424 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
425 * src/modest-ui-actions.c: (folder_refreshed_cb):
427 2007-06-14 Murray Cumming <murrayc@murrayc.com>
429 * src/widgets/modest-folder-view.c: (filter_row):
430 Explictly filter out the per-account outbox accounts. I don't know why
431 these only sometimes show up, but now they should never show up in the UI.
432 This should fix projects.maemo.org bug NB#60160.
434 2007-06-14 Murray Cumming <murrayc@murrayc.com>
436 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
437 when the toolbar does not exist yet.
438 * src/modest-widget-memory.c: (save_settings_header_view):
439 Added g_warnings() to help us to discover when we are trying to set
440 an empty columns list in gconf.
442 2007-06-14 Murray Cumming <murrayc@murrayc.com>
446 Added modest_init_get_default_header_view_column_ids().
448 * src/modest-widget-memory.c: (restore_settings_header_view):
449 Use the new function to get defaults, if the gconf key is empty,
450 instead of not creating any columns. This seems to fix the
451 empty right-hand pane problems.
453 * src/widgets/modest-header-view.h: Improved documentation.
455 2007-06-13 Murray Cumming <murrayc@murrayc.com>
457 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
458 Revert the use of the display name as the account name, because this
459 is generally wrong and would break the code that follows.
461 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
463 * src/maemo/easysetup/modest-easysetup-wizard.c:
464 (check_for_supported_auth_methods), (on_before_next),
467 More correct fix for projects.maemo.org bug NB# 58991
468 Do not longer accept AUTH_PASSWORD as secure method and choose
469 correct method when creating the account.
471 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
473 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
474 Fixed projects.maemo.org bug NB# 58991
476 2007-06-13 Murray Cumming <murrayc@murrayc.com>
478 * src/modest-init.c: (modest_init_init_core),
479 (modest_init_local_folders): Fixed compilation errors.
481 2007-06-13 Murray Cumming <murrayc@murrayc.com>
483 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
484 Remove unnecessary lib/include, though it is good in principle when needed.
486 * src/modest-init.c: (modest_init_one_local_folder),
487 (modest_init_local_folders):
488 * src/modest-init.h: Initialize the .modest library for memory cards,
489 instead of just doing nothing for them. This should allow us to create
490 folders there, fixing projects.maemo.org bug NB#59297.
492 2007-06-13 Murray Cumming <murrayc@murrayc.com>
494 * libmodest-dbus-client/libmodest-dbus-client.c:
495 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
496 (libmodest_dbus_client_compose_mail),
497 (libmodest_dbus_client_open_message),
498 (libmodest_dbus_client_send_and_receive),
499 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
501 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
502 (on_idle_open_message), (modest_dbus_req_handler),
503 (search_result_to_message), (modest_dbus_req_filter):
504 * src/modest-search.c: (add_hit), (modest_search_folder),
505 (modest_search_all_accounts): Improved debug messages.
507 * tests/dbus_api/test_open_message.c: (main): Improved comments.
509 * src/modest-tny-account-store.c:
510 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
513 2007-06-13 Murray Cumming <murrayc@murrayc.com>
516 2007-06-12 Murray Cumming <murrayc@murrayc.com>
518 * src/modest-tny-account-store.c: (get_server_accounts):
519 Call modest_tny_local_folders_account_add_merged_outbox_folders()
520 even when there are no accounts, so that the Outbox folder is always
521 visible. This fixes projects.maemo.org bug NB#60158.
523 2007-06-12 Murray Cumming <murrayc@murrayc.com>
525 * src/maemo/modest-main-window.c: (create_details_widget):
526 Use the mcen_va_never logical ID.
528 2007-06-12 Murray Cumming <murrayc@murrayc.com>
530 * src/dbus_api/modest-dbus-api.h:
531 * src/dbus_api/modest-dbus-callbacks.c:
532 (on_idle_open_default_inbox), (on_open_default_inbox),
533 (modest_dbus_req_handler):
534 Added a new OpenDefaultInbox method.
536 * libmodest-dbus-client/libmodest-dbus-client.h:
537 * libmodest-dbus-client/libmodest-dbus-client.c:
538 Added libmodest_dbus_client_open_default_inbox() to call the new
539 dbus method. This should be useful to projects.maemo.org bug NB#57214,
540 though it should maybe be used by a new osso-email-interface function.
542 * tests/dbus_api/Makefile.am:
543 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
546 2007-06-12 Murray Cumming <murrayc@murrayc.com>
548 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
549 NULL, so that the signals get all the keys. This should not actually
550 change any behaviour because we currently update everything when anything
553 2007-06-12 Murray Cumming <murrayc@murrayc.com>
555 * src/widgets/modest-folder-view.c: (text_cell_data),
556 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
557 (find_inbox_iter): If tinymail tells us that the folder is
558 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
559 This causes the inbox to be selected at startup, fixing part of
560 projects.maemo.org bug NB#56305.
562 * src/modest-ui-dimming-rules.c:
563 (modest_ui_dimming_rules_on_tools_smtp_servers):
564 * src/modest-ui-dimming-rules.h: Added a callback function to dim
565 the SMTP servers menu item.
566 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
567 that the SMTP Servers menu item is dimmed when there are no accounts,
568 as a future version of the UI spec will require. This fixes
569 projects.maemo.org bug NB#56305.
571 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
573 * src/maemo/modest-maemo-utils.c:
574 (modest_maemo_utils_get_supported_secure_authentication_methods):
575 Added label to dialog instead of unreadable title
577 * src/maemo/modest-main-window.c: (sync_accounts_cb),
578 (modest_main_window_new):
579 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
582 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
583 * src/modest-account-mgr.h:
584 Added method to avoid code duplication
586 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
587 (modest_ui_actions_on_send_receive):
588 Use modest_account_mgr_has_accounts
590 2007-06-11 Murray Cumming <murrayc@murrayc.com>
592 * src/maemo/easysetup/modest-presets.c:
593 (modest_presets_get_info_server_security): Do not report secure auth
595 * src/modest-protocol-info.c: Use the defines for the gconf key names
596 for secure authentication. This was not working because we were writing
597 Password and reading password, and the check was case sensitive.
598 With this, gmail now works for receiving and sending when created via
601 2007-06-11 Murray Cumming <murrayc@murrayc.com>
603 * src/maemo/easysetup/modest-presets.c:
604 (modest_presets_get_info_server_security): Correct the key name for
605 SecureSmtp, because it seems to be case-sensitive.
606 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
607 Do not try to get the 0th notebook page if there are 0 pages, to
610 2007-06-11 Murray Cumming <murrayc@murrayc.com>
612 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
613 Prevent use of the new notification feature for now, because it currently
614 shows one dialog for each new email, which is annoying.
616 2007-06-11 Murray Cumming <murrayc@murrayc.com>
618 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
619 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
620 when no country was selected, so that we show the global ones.
621 * src/maemo/easysetup/modest-presets.c:
622 (modest_presets_get_providers): Return only the global providers, not
623 all providers when mmc=0 was requested.
625 2007-06-11 Murray Cumming <murrayc@murrayc.com>
627 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
628 (easysetup_provider_combo_box_fill): Remove debug code that showed the
629 provider ID in the combo.
631 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
632 Do not show the page numbers, because it would be confusing when we add
633 the 2 extra pages for the custom setup, when the user chooses the "Other"
634 provider. This fixes projects.maemo.org bug NB#59028
636 * src/modest-init.c: (modest_init_init_core),
637 (modest_init_local_folders):
639 * src/modest-tny-account.c:
640 (modest_tny_account_new_for_local_folders): Do not create default folders
641 for the memory card. This should fix projects.maemo.org bug NB#59328.
643 2007-06-11 Murray Cumming <murrayc@murrayc.com>
645 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
646 Free the changed_conf_keys string items. They are already freed in the
647 idle handler if that runs first.
649 2007-06-11 Murray Cumming <murrayc@murrayc.com>
651 * src/modest-ui-actions.c:
652 (modest_ui_actions_on_password_requested): Check that the server name
653 is not NULL, because I just saw a password dialog with (null) as the
656 * src/modest-tny-folder.[h|c]: Added
657 modest_tny_folder_is_memory_card_folder().
658 * src/modest-ui-dimming-rules.c:
659 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
660 menu item for memory cards, as per the UI spec (section 7.4). This should
661 fix projects.maemo.org bug NB#59297.
663 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
665 * src/maemo/modest-main-window.c: (sync_accounts_cb):
666 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
667 is another problem with the code, see Murray's comment at line 772)
669 2007-06-08 Murray Cumming <murrayc@murrayc.com>
671 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
672 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
673 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
674 (load_from_file), (easysetup_country_combo_box_init),
675 (easysetup_country_combo_box_get_active_country_ids),
676 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
677 instead of just one ID, to avoid duplicate country names in the UI.
679 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
680 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
681 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
682 a single ID, avoiding duplicate providers.
683 * src/maemo/easysetup/modest-easysetup-wizard.c:
684 (on_combo_account_country): Adapt to use a list.
686 2007-06-08 Murray Cumming <murrayc@murrayc.com>
688 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
689 keys changed in the last X seconds.
691 * src/modest-account-mgr.h:
692 * src/modest-account-mgr.c: (on_timeout_notify_changes),
693 (on_key_change), (modest_account_mgr_class_init),
694 (modest_account_mgr_init), (modest_account_mgr_finalize):
695 As the keys are changed, save them in a GSList* and signal that GSList*
696 further every X seconds, to batch changes, to allow us to do just one
697 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
698 bug NB#56941 and other (UI-blocking) delays when changing account settings.
700 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
701 changed signal signature.
703 * src/modest-conf.c: (modest_conf_set_list),
704 (modest_conf_on_change): Reenable notification.
706 (modest_conf_maemo_fake_on_change): Comment out the hack that
707 notified immediately instead of asynchronously.
709 * src/widgets/modest-account-view.h:
710 * src/widgets/modest-account-view.c:
711 (update_account_view): Select the previously-selected account ID,
712 if possible. This fixes projects.maemo.org bug NB#56933.
714 (on_account_changed), (on_account_removed),
715 (modest_account_view_select_account):
717 Remove the block/unblock functions
718 because they were not useful.
720 * src/maemo/modest-account-view-window.c:
721 (on_delete_button_clicked), (on_edit_button_clicked),
722 (on_new_button_clicked): Remove the use of the non-working block/unblock.
724 2007-06-08 Murray Cumming <murrayc@murrayc.com>
726 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
727 Improve the error dialog to show Incorrect Account Settings, which seems
728 clearer, and say that the internal error message (to be removed from the
729 dialog later) is often misleading.
730 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
732 * src/modest-tny-account.c:
733 (modest_tny_account_new_from_server_account): Uncomment the printf of the
734 URL because this is so useful for debugging on the device.
736 * src/widgets/modest-serversecurity-combo-box.c:
737 (modest_serversecurity_combo_box_fill): Correct a logical ID.
739 2007-06-08 Murray Cumming <murrayc@murrayc.com>
741 * src/modest-mail-operation.c:
742 (modest_mail_operation_send_new_mail):
743 Added a comment about a nasty but apparently harmless message. Details
744 added to the wiki g_warnings() page.
746 2007-06-08 Murray Cumming <murrayc@murrayc.com>
748 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
749 (modest_tny_send_queue_class_init):
750 Do not use the priv struct because it is empty, to avoid g_warnings
751 about a non-existant priv struct.
753 * src/modest-tny-account-store.c:
754 (modest_tny_account_store_get_server_account),
755 (modest_tny_account_store_get_transport_account_for_open_connection
756 ): Do not try to get transport server accounts for local folders,
757 because they don't have any. This avoids a g_warning().
759 * src/maemo/modest-main-window.c:
760 (modest_main_window_notify_send_receive_initied),
761 (on_configuration_key_changed):
762 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
764 * src/modest-mail-operation.c:
765 (modest_mail_operation_update_account):
766 * src/modest-tny-account-store.h:
767 * src/modest-tny-account.c:
768 (modest_tny_account_get_special_folder),
769 (modest_tny_account_new_for_local_folders),
770 (modest_tny_account_new_for_per_account_local_outbox_folder):
771 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
772 * src/modest-tny-local-folders-account.c:
773 (add_account_folders_to_merged_folder):
774 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
775 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
776 (modest_ui_actions_on_send):
777 * src/widgets/modest-folder-view.c: (update_model):
778 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
779 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
780 modest_tny_account_store_get_tny_account_by_account() to
781 modest_tny_account_store_get_server_account() to make the code clearer.
783 2007-06-07 Marcus Bauer <marcusb@openismus.com>
785 * src/dbus_api/modest-dbus-api.h:
786 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
787 * src/maemo/modest-msg-edit-window.c:
788 (modest_msg_edit_window_attach_file_noninteractive):
789 added g_warning in case the file to be attached does not exist
790 * tests/dbus_api/test_compose_mail.c: (main):
791 removed obsolete comment, added generic files as test case
793 2007-06-07 Murray Cumming <murrayc@murrayc.com>
795 * src/modest-tny-account-store.c: (get_server_accounts):
796 Create the local folders account only once, not once for each outbox, and
797 not only when there are some outboxes.
799 2007-06-07 Murray Cumming <murrayc@murrayc.com>
801 * src/widgets/modest-folder-view.c: (update_model): Comment out some
802 code that is causing a crash at startup. Sergio says that he is fixing this.
804 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
806 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
807 * src/maemo/modest-account-settings-dialog.c:
808 (create_page_outgoing),
809 (modest_account_settings_dialog_set_account_name),
810 (save_configuration):
811 - Fixed handling of the "Use secure authentication" toggle to comply with
812 the ui specification. See also projects.maemo.org bug NB#58400
814 - Restore the Secure connection setting combo correctly when loading
817 * src/maemo/modest-maemo-utils.c:
818 (on_camel_account_get_supported_secure_authentication),
819 (modest_maemo_utils_get_supported_secure_authentication_methods):
820 Fixed a crasher if operation is canceled
822 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
823 (modest_protocol_info_auth_is_secure):
824 * src/modest-protocol-info.h:
826 Added two new methods to determine if a protocol/auth method is secure/encrypted in
827 the sense of the "Use secure authentication" toggle.
829 2007-06-07 Murray Cumming <murrayc@murrayc.com>
831 * src/modest-tny-account-store.h:
832 * src/modest-tny-account-store.c:
833 Added modest_tny_account_store_get_local_folders_account().
835 * src/modest-tny-folder.h:
836 * src/modest-tny-folder.c:
837 (modest_tny_folder_get_account):
838 Added this replacement for tny_folder_get_account() which returns
839 the local-folders account for TnyMergeFolders, to avoid the
840 warning about the unimplemented get_account_func() vfunc().
842 (modest_tny_folder_get_rules),
843 * src/modest-ui-actions.c:
844 (modest_ui_actions_on_folder_selection_changed):
845 * src/modest-mail-operation.c:
846 (modest_mail_operation_remove_folder),
847 (modest_mail_operation_xfer_folder),
848 (modest_mail_operation_rename_folder),
849 (modest_mail_operation_get_msg),
850 (modest_mail_operation_get_msgs_full),
851 (modest_mail_operation_remove_msg),
852 (modest_mail_operation_xfer_msgs),
853 (modest_mail_operation_refresh_folder):
854 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
856 2007-06-07 Murray Cumming <murrayc@murrayc.com>
858 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
859 (modest_server_account_set_security):
860 * src/modest-defs.h: Add comments explaining that our
861 UI spec means TLS when it says Normal, so these do not look like errors.
863 * src/modest-tny-account.c:
864 (modest_tny_account_new_from_server_account): Use the new tinymail
865 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
866 for TLS. This should fix projects.maemo.org bug NB#58460.
868 2007-06-06 Murray Cumming <murrayc@murrayc.com>
870 * src/maemo/easysetup/modest-easysetup-wizard.c:
871 (create_account): Correct the position of the gconf sanity check warning.
872 (on_button_edit_advanced_settings): Show the dialog immediately, instead
873 of using the g_idle_add() hack, because this does not seem to be necessary
874 on osso 1.1. It might even work on Maemo Bora if the problems were actually
875 caused by something other than maemo's gconf.
876 This fixes projects.maemo.org bug #59022.
878 2007-06-06 Murray Cumming <murrayc@murrayc.com>
880 * src/modest-account-mgr-helpers.c:
881 (modest_account_mgr_get_default_account): Do not check that the account
882 exists if there is no default account (NULL), to fix a runtime warning.
884 2007-06-06 Murray Cumming <murrayc@murrayc.com>
886 * src/widgets/modest-folder-view.c: (update_model):
887 Do not unref the treemodel before we have finished with it.
888 This prevents a valgrind warning and an occasional crash at startup.
890 2007-06-06 Marcus Bauer <marcusb@openismus.com>
892 * libmodest-dbus-client/libmodest-dbus-client.h:
893 added libmodest_dbus_client_compose_mail()
894 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
896 added functions needed for SendAsMail() functionality
897 * src/maemo/modest-msg-edit-window.c:
898 (modest_msg_edit_window_attach_file_noninteractive):
899 non interactively attaching files to message edit window
900 * src/widgets/modest-msg-edit-window.h:
901 * tests/dbus_api/Makefile.am:
902 added test_compose_mail.c
903 * tests/dbus_api/test_compose_mail.c: (main):
905 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
907 * src/modest-account-view.c:
908 Fixed bug projects.maemo.org bug NB#59307
910 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
912 * src/maemo/easysetup/modest-easysetup-wizard.c:
913 (get_serverport_incoming), (on_before_next), (create_account):
914 * src/maemo/modest-account-settings-dialog.c:
915 (modest_account_settings_dialog_set_account_name):
916 * src/maemo/modest-maemo-utils.c:
917 (on_camel_account_get_supported_secure_authentication_status),
918 (on_camel_account_get_supported_secure_authentication),
919 (on_secure_auth_cancel),
920 (modest_maemo_utils_get_supported_secure_authentication_methods):
922 Implemented security authentication for settings and easysetup.
924 2007-06-05 Murray Cumming <murrayc@murrayc.com>
926 * src/maemo/modest-main-window.c: (create_details_widget):
927 Show the total size for memory card accounts too, instead of showing
928 the name again. Fixes bug projects.maemo.org bug NB#59307.
930 2007-06-05 Murray Cumming <murrayc@murrayc.com>
933 * src/modest-tny-simple-folder-store.c:
934 * src/modest-tny-simple-folder-store.h: Removed.
936 * src/modest-tny-local-folders-account.h
937 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
938 for the local-folders maildir, with an extra TnyMergedFolder containing
939 the folders of the per-account outbox store accounts.
940 * src/modest-tny-account-store.c: (get_server_accounts):
941 Add the outboxes to the special local folders account after creating it.
943 * src/modest-tny-account.c:
944 (modest_tny_account_new_for_local_folders): Create the derived
945 account when creating the main local-folders account.
947 * src/maemo/modest-main-window.c: (create_details_widget),
948 (modest_main_window_set_contents_style):
949 Adapted to the use of the derived account instead of the folder store.
951 * src/modest-ui-actions.c:
952 (modest_ui_actions_on_folder_selection_changed):
953 * src/modest-ui-dimming-rules.c:
954 (modest_ui_dimming_rules_on_new_folder):
955 * src/widgets/modest-folder-view.c: (text_cell_data),
956 (icon_cell_data), (filter_row), (update_model),
957 (get_cmp_rows_type_pos):
960 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
961 Do not get the priv struct, because no priv struct has been set,
962 to avoid a runtime warning.
964 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
965 #ifelse with #else, to fix a warning, to fix the build.
968 2007-06-05 Christian Kellner <ckellner@openismus.com>
970 * libmodest-dbus-client/libmodest-dbus-client.c:
971 Fix small typo in doc (why do you always see them
972 AFTER committing stuff?)
975 2007-06-05 Christian Kellner <ckellner@openismus.com>
977 * libmodest-dbus-client/libmodest-dbus-client.c:
978 (libmodest_dbus_client_search):
979 Initialize hit list with NULL. Also set folder list
980 to "" if NULL was supplied.
983 2007-06-03 Christian Kellner <ckellner@openismus.com>
985 * libmodest-dbus-client/libmodest-dbus-client.c:
986 (modest_search_hit_list_free):
987 Make it save to call it with NULL.
989 * src/dbus_api/modest-dbus-callbacks.c:
990 * src/modest-search.c:
991 Return full ModestSearchHits as the search result list not TnyHeader
992 since can't be around withouth the correspoding TnyFolder.
994 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
996 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
997 Added currently commented code to check for secure auth
999 * src/maemo/modest-account-settings-dialog.c: (on_response),
1000 (save_configuration), (show_ok):
1001 Fixed projects.maemo.org bugs NB #59248 and #59251
1003 * src/maemo/modest-maemo-utils.c:
1004 (on_camel_account_get_supported_secure_authentication_status),
1005 (on_camel_account_get_supported_secure_authentication),
1006 (modest_maemo_utils_get_supported_secure_authentication_methods):
1007 * src/maemo/modest-maemo-utils.h:
1008 Moved get_supported_secure_authentication() method here to be able
1009 to use it from easysetup wizard.
1011 * src/modest-pair.c: (on_pair_compare_as_string):
1012 Should compare string with first part of pair and not
1013 strcmp pairs which will crash.
1015 * src/modest-protocol-info.c:
1016 (modest_protocol_info_protocol_is_store):
1017 * src/modest-protocol-info.h:
1018 Added modest_protocol_info_get_auth_protocol_name()
1020 2007-06-03 Armin Burgmeier <armin@openismus.com>
1022 * src/modest-mail-operation.c:
1023 (modest_mail_operation_get_msgs_full): Set priv->account also when
1024 only retrieving a single message. This avoids a crash when canceling
1027 (modest_mail_operation_notify_end): Do not explicitely remove the
1028 operation from the queue but only emit the progress_changed signal.
1029 The queue itself listens to that signal to remove the operation when
1030 it is finished. This reduces coupling and removes a potential deadlock
1031 when modest_mail_operation_notify_end() is called from the queue
1032 itself. If that is a problem performance-wise, I would suggest to
1033 implement a status-changed signal or something.
1035 * src/modest-mail-operation-queue.c: Make sure to never call a
1036 function from another file while the queue is locked. This (hopefully)
1037 fixes another deadlock when exiting the application while retrieving
1040 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1042 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1043 Fixed build if libogs is not available
1045 2007-06-03 Christian Kellner <ckellner@openismus.com>
1047 * libmodest-dbus-client/libmodest-dbus-client.h:
1048 * libmodest-dbus-client/libmodest-dbus-client.c:
1049 (libmodest_dbus_client_delete_message):
1050 Implement deletion of messages (Client side).
1052 (modest_search_hit_free),
1053 (modest_search_hit_list_free):
1054 Utility functions to free the result hits.
1056 * src/dbus_api/modest-dbus-api.h:
1057 * src/dbus_api/modest-dbus-callbacks.c:
1058 (on_delete_message),
1059 (modest_dbus_req_handler):
1060 Implement deletion of messages (Server side).
1062 * tests/dbus_api/test_search.c: (main):
1065 * tests/dbus_api/Makefile.am:
1066 * tests/dbus_api/test_delete_message:
1067 Add little test for the message deletion logic
1069 2007-06-03 Armin Burgmeier <armin@openismus.com>
1071 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1072 when the operation queue was not empty. projects.maemo.org bug
1075 2007-06-03 Armin Burgmeier <armin@openismus.com>
1077 * src/widgets/modest-account-view.c
1078 (on_account_default_toggled): Toggle default account column
1079 explicitely instead of waiting for gconf notification (which is
1080 currently ignored). This should fix projects.maemo.org bug NB#56910
1081 for now. It should probably be removed when gconf notifications are
1084 2007-06-03 Christian Kellner <ckellner@openismus.com>
1086 * libmodest-dbus-client/libmodest-dbus-client.c:
1087 Removed debugging spew.
1089 * src/dbus_api/modest-dbus-callbacks.c:
1090 Added debugging info.
1092 * src/modest-search.c:
1093 (modest_search_all_accounts):
1094 Use tny_account_store_get_accounts () on the account store
1095 to get all accounts which is the way to get all accounts.
1097 * tests/dbus_api/test_search.c: (main):
1098 Make it possible to supply the search term on the command line.
1100 2007-06-03 Christian Kellner <ckellner@openismus.com>
1102 * libmodest-dbus-client/libmodest-dbus-client.c:
1103 * libmodest-dbus-client/libmodest-dbus-client.h:
1104 Implement searching for mesages over raw dbus. (Client side)
1106 * src/dbus_api/Makefile.am:
1107 * src/dbus_api/modest-dbus-api.h:
1108 * src/dbus_api/modest-dbus-callbacks.c:
1109 * src/dbus_api/modest-dbus-callbacks.h:
1110 Search framework (Server side). Also implement on_idle_open_message().
1112 * src/maemo/modest-platform.c: (modest_platform_init):
1113 Prepare for raw dbus/osso rpc interaction.
1115 * src/modest-search.h:
1116 Changed minsize from unspecific guint to guint32.
1118 * src/modest-search.c:
1120 Added strange hack which magically made tnymail work.
1122 (modest_search_folder),
1123 (modest_search_account),
1124 (modest_search_all_accounts):
1125 Implement helper functions to search all accounts, specific account
1128 * tests/dbus_api/Makefile.am:
1129 * tests/dbus_api/test_open_message.c:
1130 Read url to open from commandline.
1132 * tests/dbus_api/test_search.c:
1133 Implement small test for dbus search stuff
1135 2007-06-02 Armin Burgmeier <armin@openismus.com>
1137 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1138 include account type and account title. This fixes projects.maemo.org
1141 * src/maemo/modest-account-view-window.c: Set a title for the window.
1143 2007-06-02 Armin Burgmeier <armin@openismus.com>
1145 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1146 incoming and outgoing server name based on email address and server
1147 types as long as the names have not been edited manually. This fixes
1148 projects.maemo.org bug NB#58671.
1150 2007-06-02 Armin Burgmeier <armin@openismus.com>
1152 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1153 server type cannot be changed in future to the incoming details page
1154 when creating an account. This fixes projects.maemo.org bug NB#59029.
1156 2007-06-02 Armin Burgmeier <armin@openismus.com>
1158 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1159 and assigned max width chars so that they wrap instead of being
1160 truncated. Fixes projects.maemo.org bug NB#56126.
1162 2007-06-02 Armin Burgmeier <armin@openismus.com>
1164 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1165 introductory note to the connection specific smtp servers dialog, as
1166 section 8.12 of the email UI specification requires. This fixes
1167 projects.maemo.org bug NB#59212.
1169 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1171 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1172 Check for running mail operations, and offer to cancel them, as per the UI
1173 spec. This fixes projects.maemo.org bug NB#59041 .
1174 However, I suspect that tinymail may still use the network connection
1175 in ways that we cannot detect or cancel. But it should at least adapt to
1176 changes fairly well.
1178 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1180 * src/modest-tny-account-store.c: (recreate_all_accounts),
1181 (get_cached_accounts), (get_server_accounts): Do more sensible
1182 ref-counting of the temporarily-cached outbox accounts list. This seems
1183 to fix a crash when entering the password when the password was wrong.
1185 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1187 * src/gnome/modest-main-window.c: (connect_signals):
1188 * src/modest-tny-account-store.c: (get_password),
1189 (modest_tny_account_store_alert): Added comments and clues and
1190 commented-out code about how we currently fail to deal with connection
1191 errors and wrong passwords, and how we should.
1193 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1195 * src/widgets/modest-retrieve-combo-box.c:
1196 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1197 This fixes projects.maemo.org bug NB#58472 .
1199 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1201 * src/maemo/easysetup/modest-easysetup-wizard.c:
1202 (create_page_complete_easysetup):
1203 (create_page_complete_custom): Correct the last commit,
1204 putting the correct sentences in the correct pages.
1206 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1208 * src/maemo/easysetup/modest-easysetup-wizard.c:
1209 (create_page_complete_custom): Show the second sentence of text
1210 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1213 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1215 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1216 Set the leave-on-server conf key by default. This fixes
1217 projects.maemo.org bug NB#59258 .
1219 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1221 * src/maemo/modest-account-view-window.c:
1222 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1223 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1226 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1228 * src/maemo/easysetup/modest-easysetup-wizard.c:
1229 (create_caption_new_with_asterisk):
1230 * src/maemo/modest-account-settings-dialog.c:
1231 (create_caption_new_with_asterisk):
1232 Uncomment the code to add the asterisk, because they are no longer in the
1233 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1234 (update_incoming_server_title): Add an asterisk here too.
1236 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1238 * src/maemo/modest-maemo-global-settings-dialog.c:
1239 (current_connection): Check that we are even connected before trying to
1240 get the current connection name, to prevent a warning.
1242 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1243 Change the comments because tny_maemo_conic_device_connect() is now meant to
1245 * src/modest-mail-operation.c:
1246 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1247 make sure we have a connection and fail if we can't connect.
1249 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1251 * src/maemo/modest-main-window.c:
1252 (on_account_store_connecting_finished): Do not try to get the
1253 connection ID if we are not really connected. I am surprised that
1254 this signal handler is called when we are not connected.
1256 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1258 * src/modest-error.h:
1259 * src/modest-ui-actions.c:
1260 (modest_ui_actions_get_msgs_full_error_handler):
1261 Renamed an enum, added comments, added an enum
1262 for retrieve-limit errors.
1264 * src/modest-mail-operation.c: (foreach_add_item),
1265 (internal_folder_observer_update), (update_account_thread),
1266 (modest_mail_operation_get_msgs_full):
1267 (modest_mail_operation_update_account),
1268 Added comments about how this works, and some code that should
1269 (but does not) check the retrieve-limit. See the TODO comment.
1271 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1273 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1274 Initialize help_id to fix the build. Warnings are good.
1276 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1278 * src/widgets/modest-hbox-cell-renderer.c:
1279 (modest_hbox_cell_renderer_append):
1280 * src/widgets/modest-vbox-cell-renderer.c:
1281 (modest_vbox_cell_renderer_append):
1282 Fix the last commit by doing an extra ref.
1284 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1286 * src/widgets/modest-hbox-cell-renderer.c:
1287 (modest_hbox_cell_renderer_append):
1288 * src/widgets/modest-vbox-cell-renderer.c:
1289 (modest_vbox_cell_renderer_append):
1290 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1291 to fix the build with Maemo Bora.
1292 However, there seems to be a remaining crash, probably due to reference
1295 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1297 * src/modest-tny-account.c:
1298 (modest_tny_account_new_for_local_folders):
1299 Use hildon_file_system_info_async_new() to get a better name for
1300 the memory card account, setting it as the account name.
1301 The timing seems to work, but this is probably
1302 not the best place to do this. See the TODO comment.
1303 * src/maemo/modest-main-window.c: (create_details_widget):
1304 * src/widgets/modest-folder-view.c: (text_cell_data):
1305 Use the tny account name instead of hardcoding a name.
1307 2007-05-30 Christian Kellner <ckellner@openismus.com>
1309 * src/modest-search.c: (modest_search):
1310 Correctly set part_search_func even if we have already parsed
1311 the query and thus a valid OgsTextSearcher object.
1313 2007-05-30 Christian Kellner <ckellner@openismus.com>
1316 Search and check for libogs.
1319 Incooparte the ogs build env.
1321 * src/modest-mime-part-search-stream.c:
1322 * src/modest-mime-part-search-stream.h:
1323 Removed since we do the real searching now in modest-search.c.
1325 * src/modest-search.c:
1326 * src/modest-search.h:
1327 Implement support for ogs. We use that if available and requested
1328 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1329 should now handle the corner case when the search term is spread
1330 across multiple reads.
1331 Also the logic in modest_search () was corrected to search all
1332 requested fields until one is found.
1334 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1336 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1338 * src/modest-init.h:
1339 * src/modest-init.c: Made modest_init_local_folders() take a
1340 path and be public so we can iniitialize maildir folders on
1343 * src/modest-local-folder-info.h:
1344 * src/modest-local-folder-info.c:
1345 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1347 * src/modest-tny-account.c:
1348 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1349 still means the standard local-folders path on the local volume.
1351 * src/modest-tny-account-store.c:
1352 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1353 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1354 all accounts when that happens.
1355 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1356 this too, so it shows up in the treeview.
1358 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1360 * src/maemo/modest-maemo-global-settings-dialog.c:
1361 (current_connection):
1362 * src/widgets/modest-global-settings-dialog.c:
1363 (current_connection_default):
1364 Use the enum values instead of 0, 1 and -1,
1365 to make the code clearer.
1367 * src/modest-account-mgr-helpers.c:
1368 (modest_account_mgr_get_connection_specific_smtp): Make this code
1371 * src/modest-runtime.h:
1372 * src/modest-runtime.c:
1373 Added modest_runtime_remove_all_send_queues().
1374 * src/maemo/modest-main-window.c:
1375 (on_account_store_connecting_finished): Recreate the send queues,
1376 using the appropriate transport accounts for this new connection.
1377 Some futher adapting might be needed if the old send queues are not
1378 automatically stopped at this point.
1380 * src/modest-tny-account-store.c: (get_server_accounts):
1381 Create the connection-specific transport accounts, so that they can
1382 be found later by their ID.
1384 * src/modest-tny-account.h:
1385 * src/modest-tny-account.c:
1386 Added modest_tny_account_new_from_server_account_name().
1387 modest_tny_account_new_from_server_account(): Do not create the
1388 send queues here, because they will be
1389 recreated anyway when the connection changes for the first time.
1391 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1393 * src/modest-local-folder-info.h:
1394 * src/modest-local-folder-info.c:
1395 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1396 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1397 tbox_folder): Take a modest account name instead of a server TnyAccount,
1398 so we can have per-modest-account rather than per-transport-account
1400 We must make sure that we change or recreate the exisitng send queues
1401 when the connection changes for connection-specific transport accounts.
1403 * src/modest-tny-account-store.c:
1404 (create_per_account_local_outbox_folders): Create outboxed per modest
1405 account, not per transport account.
1407 * src/modest-tny-account.h:
1408 * src/modest-tny-account.c:
1409 (modest_tny_account_get_special_folder): For outboxes, get the
1410 parent modest account name. The account is ignored for other folders.
1411 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1412 modest account name rather than a server TnyAccount.
1414 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1416 * src/modest-tny-account.c:
1417 (modest_tny_account_new_from_server_account):
1418 Call modest_runtime_get_send_queue() immediately after creating transport
1419 accounts, so that they start trying to send email from the outbox as soon
1420 as possible at startup. This is probably what we want.
1422 * src/modest-mail-operation.c: (update_account_thread):
1423 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1424 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1425 * src/modest-tny-send-queue.h:
1426 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1427 (modest_ui_actions_on_send):
1428 Added comments about how sending works, though it needs some more work.
1430 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1432 * src/modest-tny-account.c:
1433 (modest_tny_account_get_special_folder): Add TODO because this fails when
1434 the network is busy.
1435 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1436 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1437 Do not try to show this window when there is no active account. The UI
1438 specs does not tell us what to do in this case.
1440 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1444 * src/maemo/Makefile.am:
1445 * src/widgets/Makefile.am: Some dist fixes.
1447 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1449 * src/maemo/modest-connection-specific-smtp-window.c:
1450 (on_button_edit): Make the code clearer, to prevent a double free.
1452 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1454 * src/maemo/modest-account-settings-dialog.c:
1455 (modest_account_settings_dialog_set_account_name),
1456 Check the connection-specific smtp servers checkbox if there are any.
1458 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1459 (modest_connection_specific_smtp_edit_window_init):
1460 Start with a suitable port number.
1462 * src/modest-account-mgr-helpers.h:
1463 * src/modest-account-mgr-helpers.c: Added
1464 modest_account_mgr_get_has_connection_specific_smtp().
1466 (modest_account_mgr_set_connection_specific_smtp),
1467 (modest_account_mgr_remove_connection_specific_smtp),
1468 (modest_account_mgr_get_has_connection_specific_smtp),
1469 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1470 connection-specific smtp server accounts in the account, rather than
1471 the server account conf dir.
1473 This fixes bug projects.maemo.org bug NB#58263 .
1475 * src/modest-tny-account-store.c:
1476 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1477 if there are no server accounts yet, to prevent an infinite loop when there
1478 are no accounts. Document that one must be called before the other.
1480 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1482 * src/modest-account-mgr-helpers.c:
1483 (modest_account_mgr_get_default_account): Make sure that at least
1484 one account is always the default, if there are any enabled accounts.
1485 This is just a sanity check that shouldn't be necessary.
1487 * src/modest-account-mgr-priv.c:
1488 (_modest_account_mgr_account_from_key): Unescape the conf key to
1489 get the real account name. For instance, this is an issue if a space
1490 was in the account name, which can happen because the account name
1491 is generated from the display name.
1492 (_modest_account_mgr_get_account_keyname): Always escape the
1494 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1495 Unescape the conf keys to get the real account names.
1497 For instance, previously the is-default radio button in the accounts
1498 list was not checked for any accounts at first. This fixes that,
1499 and might fix several similar bugs.
1501 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1503 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1504 Removed some debug printfs.
1506 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1508 Modest on-disk outbox directories are now here, for instance:
1509 $HOME/.modest/outboxes/<account-id-1>/outbox
1510 $HOME/.modest/outboxes/<account-id-2>/outbox
1512 $HOME/.modest/local-folders/outbox
1513 so we can have a separate outbox for each account.
1514 But they are shown as one outbox in the GtkTreeView, by using a
1515 TnyMergeFolder in a ModestTnySimpleFolderStore.
1518 * src/modest-tny-simple-folder-store.c:
1519 * src/modest-tny-simple-folder-store.h:
1520 Added ModestTnySimpleFolderStore, used to contain folders from
1521 other folder stores, such as other accounts.
1523 * src/modest-tny-outbox-account.h:
1524 * src/modest-tny-outbox-account.c:
1525 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1526 used for the per-account local outbox folders.
1528 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1529 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1530 only use this (internally) now for the non-outbox local folders.
1532 * src/modest-init.h:
1533 * src/modest-init.c: Added modest_init_one_local_folder(), for
1534 setting up the directory structure for each local folder.
1536 * src/modest-local-folder-info.c:
1537 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1538 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1540 * src/modest-local-folder-info.h:
1541 * src/modest-tny-account-store.c: (on_account_removed),
1542 (on_account_changed), (create_per_account_local_outbox_folders),
1543 (get_server_accounts), (modest_tny_account_store_get_accounts),
1544 (modest_tny_account_store_get_tny_account_by_account),
1545 (modest_tny_folder_store_is_virtual_local_folders):
1547 * src/modest-tny-account.h:
1548 * src/modest-tny-account.c:
1549 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1550 to create an on-disk per-account local outbox folder for each
1552 (create_per_account_local_outbox_folders): Create a local outbox folder
1553 for each transport account.
1554 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1555 for all local folders.
1557 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1558 instead of using g_object_get/set() directly. It is clearer.
1560 (modest_tny_folder_store_get_message_count),
1561 (modest_tny_folder_store_get_local_size
1562 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1563 because we now use these with non-acount folder stores.
1565 (modest_tny_account_get_special_folder),
1566 (modest_tny_account_new_from_server_account),
1567 (modest_tny_account_new_from_account):
1568 (recurse_folders): Adjust to the new outbox system.
1570 * src/modest-tny-folder.h:
1571 * src/modest-tny-folder.c:
1572 (modest_tny_folder_is_local_folder),
1573 (modest_tny_folder_get_local_folder_type),
1574 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1576 * src/widgets/modest-main-window.h:
1577 * src/maemo/modest-main-window.c: (create_details_widget),
1578 (modest_main_window_set_contents_style): Show details for any folder store,
1581 (modest_tny_folder_get_rules):
1582 Remove the const. C does not support constness enough for this.
1584 * src/modest-ui-actions.c:
1585 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1586 make all outboxes appear as one, in the usual local-folders tree node.
1588 (set_active_account_from_tny_account),
1589 (modest_ui_actions_on_folder_selection_changed):
1590 * src/widgets/modest-folder-view.c: (text_cell_data),
1591 (icon_cell_data), (filter_row),
1592 (add_account_folders_to_merged_folder),
1593 (add_account_folders_to_simple_folder_store), (),
1594 (get_cmp_rows_type_pos), (cmp_rows),
1595 (modest_folder_view_set_account_id_of_visible_server_account):
1596 Adjust to the new outbox system, using generic folder stores and folders
1597 in the GtkTreeModel.
1599 2007-05-23 Christian Kellner <ckellner@openismus.com>
1601 * src/modest-mail-operation.c:
1602 (modest_mail_operation_update_account):
1603 Use info->max_size instead of unintialized local var [small
1604 build fix]. (Added TODO to review that change since I don't
1607 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1609 * libmodest-dbus-client/libmodest-dbus-client.c:
1610 (libmodest_dbus_client_compose_mail): function added
1611 * src/dbus_api/modest-dbus-api.h:
1612 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1613 (on_compose_mail): Implementation of the SendAsMail functionality
1615 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1617 * src/modest-account-mgr.c:
1618 (modest_account_mgr_add_server_account): Set the secure-connection
1619 conf key for transport accounts as well as store accounts. I don't know
1620 why the if was there. For instance, this makes sure that we use SSL
1621 for the gmail preset from the easysetup wizard.
1623 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1625 * src/gnome/modest-main-window.c:
1626 (on_account_store_connecting_finished), (connect_signals):
1627 * src/maemo/modest-main-window.c:
1628 (on_account_store_connecting_finished), (connect_signals),
1629 (modest_main_window_new):
1630 Handle TnyAccountStore::connecting-finished instead of
1631 TnyDevice::connection-changed, because we cannot actually perform
1632 operations on accounts until TnyAccountStore has itself responded to
1633 the TnyDevice::connection-changed signal. This prevents a GError from
1635 Do not try to update at startup, because we (at least on scratchbox)
1636 already do an update at startup when the device goes online.
1637 This prevents a GError from tinymail.
1638 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1639 Added TODO about stopping simultaneous operations.
1641 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1643 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1644 * src/modest-mail-operation-queue.c:
1645 (modest_mail_operation_queue_remove):
1646 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1647 about where they happened.
1649 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1651 * src/modest-ui-actions.c:
1652 (modest_ui_actions_on_password_requested): Make sure that the remember
1653 output parameter is always TRUE.
1655 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1657 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1658 Show a OK/Cancel dialog if the error is a question, though we still do not
1659 know anything more about what we are asking the user.
1660 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1661 Fix an uninitialized variable (helper). This is a logic error, however.
1663 2007-05-21 Christian Kellner <ckellner@openismus.com>
1665 * src/modest-search.h:
1666 Correct bit shifting in the ModestSearchFlags enum.
1668 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1670 * src/modest-tny-account.c:
1671 (modest_tny_account_new_from_server_account): Do not use the lsub and
1672 check-all hard-coded IMAP options when using POP.
1674 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1676 * src/modest-tny-account.c:
1677 (modest_tny_account_new_from_server_account):
1678 Use NULL for the secure-auth method for POP when Password auth has been
1679 specified by the user, as we already do for IMAP. "auth=Login" causes
1680 an error from camel or the server.
1682 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1684 * src/maemo/modest-account-settings-dialog.c:
1685 (create_page_account_details),
1686 (modest_account_settings_dialog_set_account_name):
1687 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1688 for the leave-on-server checkbox, rathr than just the checkbox, when
1689 the protocol is not POP.
1691 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1693 * src/widgets/modest-account-view.c:
1694 * src/widgets/modest-account-view.h:
1695 Added modest_account_view_select_account() which will be useful later
1696 to asynchronously re-select the edited account.
1698 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1700 * src/maemo/modest-account-settings-dialog.c:
1701 (modest_account_settings_dialog_set_account_name):
1702 Automatically choose the port numbers based on the secure authentication
1703 methods, if they have not been chosen before.
1704 This fixes projects.maemo.org bug NB#56273 .
1706 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1708 * src/maemo/modest-main-window-ui.h:
1709 * src/modest-ui-actions.c:
1710 * src/modest-ui-actions.h:
1711 Connect the Tools/SMTP Servers menu item to
1712 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1713 SMTP servers dialog, as in the UI specification and saves changes when it
1714 is closed. This fixed projects.maemo.org bug NB#56305 .
1716 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1718 * src/maemo/modest-connection-specific-smtp-window.c:
1719 (modest_connection_specific_smtp_window_init):
1720 Use gtk_window_set_default_size() to make this window big enough, so
1721 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1723 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1725 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1726 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1727 (modest_connection_specific_smtp_edit_window_init),
1728 Do not try to connect to a combobox signal before the combobox exists.
1729 This fixes the cras in projects.maemo.org bug NB#56288 .
1730 (modest_connection_specific_smtp_edit_window_get_settings):
1731 Remove the server_account_name parameter which was being checked for NULL
1732 though it was not used.
1734 * src/maemo/modest-connection-specific-smtp-window.c:
1735 (modest_connection_specific_smtp_window_fill_with_connections),
1736 (on_button_edit), (modest_connection_specific_smtp_window_init):
1737 Correct the number of treemodel columns to prevent a warning.
1738 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1739 libconic does not work.
1741 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1743 * src/modest-tny-account.c:
1744 (modest_tny_account_new_from_server_account):
1745 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1746 SMTP when "None" was chosen by the user. However, with my SMTP server that
1747 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1750 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1752 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1753 to explain the memory management issue with the ID in the ModestPair.
1755 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1756 (add_sending_page), (modest_account_assistant_finalize):
1757 * src/gnome/modest-gnome-global-settings-dialog.c:
1758 (create_updating_page), (create_composing_page):
1759 * src/gnome/modest-msg-edit-window.c: (get_transports),
1760 (init_window), (modest_msg_edit_window_finalize),
1761 (modest_msg_edit_window_get_msg_data):
1762 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1763 * src/gnome/modest-transport-widget.c:
1764 (modest_transport_widget_finalize), (smtp_configuration):
1765 * src/maemo/modest-maemo-global-settings-dialog.c:
1766 (create_updating_page), (create_composing_page):
1767 * src/maemo/modest-msg-edit-window.c: (get_transports),
1768 (init_window), (modest_msg_edit_window_finalize),
1769 (modest_msg_edit_window_get_msg_data),
1770 (modest_msg_edit_window_free_msg_data):
1771 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1772 (modest_store_widget_finalize):
1773 * src/maemo/modest-transport-widget.c:
1774 (modest_transport_widget_finalize), (smtp_configuration):
1775 * src/modest-main.c: (send_mail):
1776 * src/widgets/modest-combo-box.h:
1777 * src/widgets/modest-global-settings-dialog-priv.h:
1778 * src/widgets/modest-global-settings-dialog.c:
1779 (modest_global_settings_dialog_finalize):
1780 * src/widgets/modest-msg-edit-window.h:
1781 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1782 as long as the combo box, to prevent use of freed memory for the ID.
1784 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1786 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1787 get_accounts(), to make this clearer. Do not check for the enabled gconf
1788 key, because we do not use this for server accounts (at least, not yet).
1789 This allows us to send email again.
1791 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1793 * src/maemo/modest-platform.c:
1794 (on_modest_conf_update_interval_changed), (modest_platform_init):
1795 Only respond to this particular key change. All these strcmp()s cannot be
1798 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1800 * src/maemo/modest-maemo-global-settings-dialog.c:
1801 (current_connection): Prevent a crash in scratchbox when
1802 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1803 * src/maemo/modest-platform.c:
1804 (on_modest_conf_update_interval_changed), (modest_platform_init):
1805 Get the update interval from gconf and reset it when the gconf key changes.
1807 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1809 * src/modest-protocol-info.c:
1810 * src/modest-protocol-info.h: Adde enum-specific get functions,
1811 instead of using a ModestProtocolType enum parameter.
1813 * src/gnome/modest-account-assistant.c:
1814 * src/gnome/modest-store-widget.c:
1815 * src/gnome/modest-store-widget.h:
1816 * src/gnome/modest-transport-widget.c:
1817 * src/gnome/modest-transport-widget.h:
1818 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1819 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1820 * src/maemo/easysetup/modest-easysetup-wizard.c:
1821 * src/maemo/modest-account-settings-dialog.c:
1822 * src/maemo/modest-account-settings-dialog.h:
1823 * src/maemo/modest-store-widget.c:
1824 * src/maemo/modest-store-widget.h:
1825 * src/maemo/modest-transport-widget.c:
1826 * src/maemo/modest-transport-widget.h:
1827 * src/modest-account-mgr-helpers.c:
1828 * src/modest-account-mgr-helpers.h:
1829 * src/modest-account-mgr.c:
1830 * src/modest-account-mgr.h:
1831 * src/modest-tny-account.c:
1832 * src/modest-tny-folder.c:
1833 * src/widgets/modest-account-view.c:
1834 * src/widgets/modest-retrieve-combo-box.c:
1835 * src/widgets/modest-retrieve-combo-box.h:
1836 * src/widgets/modest-secureauth-combo-box.c:
1837 * src/widgets/modest-serversecurity-combo-box.c:
1838 * src/widgets/modest-serversecurity-combo-box.h:
1839 * tests/check_account-mgr.c:
1840 Use the specific functions, and use the re-renamed enum values for GNOME too.
1842 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1844 * src/modest-pair.h:
1845 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1846 so we can get the second based on the first.
1848 * src/maemo/modest-account-settings-dialog.h:
1849 * src/maemo/modest-account-settings-dialog.c:
1850 Added get_supported_secure_authentication_methods(), though it is mostly
1851 commented-out for now until the necessary API is committed to tinymail.
1852 (modest_account_settings_dialog_set_account_name),
1853 (save_configuration): Request the supported authentication methods from the
1854 server, so we can choose a working method.
1856 * src/modest-tny-account-store.h:
1857 * src/modest-tny-account-store.c:
1858 (modest_tny_account_store_get_session): Rename from
1859 tny_account_store_get_session().
1861 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1863 * src/modest-protocol-info.h: Split the ModestProtocol enum
1864 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1865 There was no need to have these unrelated values in one enum.
1867 * src/: many files: Adapted to changed enum. This makes the code a bit
1868 clearer, and the compiler could catch some errors.
1870 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1872 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1873 Show the detailed internal camel error message when an error happens
1874 during the configuration, so that our testers can give us more clues.
1875 For instance, in projects.maemo.org bug NB#56910 .
1877 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1879 * src/modest-tny-account.c:
1880 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1881 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1883 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1885 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1886 * src/maemo/modest-account-settings-dialog.c:
1887 (modest_account_settings_dialog_set_account_name),
1888 (save_configuration): For the incoming secure authentication checkbox,
1889 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1890 the UI specification. PLAIN does not seem to be supported for most IMAP
1891 servers anyway, and I am not sure what it would mean.
1892 However, we probably need to discover which of the secure-authentication
1893 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1894 * src/modest-account-mgr-helpers.c:
1895 (modest_account_mgr_get_server_account_data):
1897 * src/modest-tny-account.c:
1898 (modest_tny_account_new_from_server_account):
1899 Use tny_account_set_mech() to set secure-authentication methods,
1900 with some special-casing for IMAP, based on my observations of how
1903 * src/modest-account-mgr-helpers.h:
1904 * src/modest-account-mgr.c:
1905 * src/modest-defs.h: Comment that the URI is only used for local folders.
1907 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1909 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1910 parameter const, just to be neat.
1911 * src/modest-text-utils.c: (modest_text_utils_inline):
1912 End g_strconcat() with NULL, as its documentation says. This is almost
1913 certainly the cause of my crash at startup on the device. Interestingly,
1914 valgrind doesn't tell us about these errors.
1916 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1918 * scripts/build-packages: Added more precise comments about how to use
1919 this script, though I still get this error:
1920 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1921 error building tinymail
1923 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1925 * src/maemo/modest-main-window.c: (on_account_update):
1926 Very slight cleanup, hoping to make it simpler to discover what causes
1927 a crash here sometimes.
1929 * src/modest-tny-account.c:
1930 (modest_tny_account_new_from_server_account): Set the port. Added
1931 comments about the options and a TODO comment because I need to find out
1932 how to specify the secure authentication method.
1934 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1936 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1937 changed CFlags paths form modest to libmodest
1939 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1941 * src/modest-account-mgr-helpers.c:
1942 (modest_account_mgr_get_server_account_data),
1943 (modest_account_mgr_free_server_account_data):
1944 * src/modest-account-mgr-helpers.h:
1945 * src/modest-account-mgr.c:
1946 (modest_account_mgr_add_server_account):
1947 * src/modest-defs.h:
1948 * src/modest-tny-account.c:
1949 (modest_tny_account_new_from_server_account):
1950 Determine the options for tny_camel_account_add_option() here,
1951 based on the settings, rather than storing them directly in gconf.
1953 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1955 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1956 Show a more friendly error dialog now that we expect (from the tinymail
1957 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1959 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1961 * src/maemo/modest-main-window.c: (on_account_update): Check that
1962 account_name is not NULL, to prevent a crash at startup that I am
1963 seeing on the N800. I do wonder why it is NULL.
1965 * src/maemo/easysetup/modest-easysetup-wizard.c:
1966 (create_page_user_details):
1967 * src/maemo/modest-account-settings-dialog.c:
1968 (create_page_user_details), (create_page_outgoing):
1969 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1970 (modest_connection_specific_smtp_edit_window_init):
1971 * src/modest-ui-actions.c:
1972 (modest_ui_actions_on_password_requested):
1973 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1974 might do something useful with the on-screen keyboard.
1976 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1978 * src/maemo/modest-main-window.c: (on_account_update):
1979 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1980 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1982 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1984 * src/modest-tny-account-store.c: (on_account_changed):
1985 Correct the signature of this signal handler.
1987 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1989 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1990 Show a HildonNote instead of a GtkDialog for Maemo.
1992 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1994 * src/widgets/modest-account-view.h:
1995 * src/widgets/modest-account-view.c: (on_account_changed),
1996 (on_account_removed). Added a boolean flag, set/unset by
1997 modest_account_view_block_conf_updates(),
1998 modest_account_view_unblock_conf_updates() to prevent unnecessary
1999 updates, but this is not very useful because the gconf notifications are
2000 so delays (maybe only on Maemo Bora).
2001 So auto-updating is turned off, and these functions do an explicit
2002 update when necessary.
2003 However, something else is still doing too much work when adding/removing
2004 accounts, probably in another part of the application.
2006 * src/maemo/modest-account-view-window.c:
2007 (on_delete_button_clicked), (on_edit_button_clicked),
2008 (on_new_button_clicked): Use the new functions.
2010 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2012 * src/modest-account-mgr-helpers.c:
2013 (modest_account_mgr_set_first_account_as_default):
2014 Sort the list of names alphabetically-by-title, so we choose the first one
2016 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2017 alphabetically by the title.
2019 This fixes projects.maemo.org bug NB#56418 .
2021 * src/modest-account-mgr-priv.c:
2022 (_modest_account_mgr_account_from_key):
2023 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2024 avoid a valgrind error, and possible random behaviour.
2026 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2028 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2029 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2030 tinymail documentation to say that this can be expected.
2031 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2032 pretty, and should not happen, but I would prefer to know when it does.
2034 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2036 * configure.ac: When using the older hildon version, probably on Bora,
2037 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2039 * src/widgets/modest-attachment-view.c:
2040 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2043 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2045 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2046 Implemented the prototype. Can be tested with
2047 tests/dbus_api/test_open_message:
2049 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2051 * src/modest-tny-account-store.c:
2052 (modest_tny_account_store_instance_init), (get_password):
2053 * src/modest-ui-actions.c:
2054 (modest_ui_actions_on_password_requested):
2055 Do not store the password in gconf, because this function is called
2056 for non-remembered passwords. Actually use the cached (in the hash map)
2057 password instead of releasing it.
2058 The password will now not be remembered if it is asked via the protected
2059 password dialog, as per the UI spec.
2061 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2063 * src/modest-defs.h:
2064 * src/modest-account-mgr-helpers.h:
2065 * src/modest-account-mgr-helpers.c:
2066 Added modest_server_account_get_username_has_succeeded(),
2067 modest_server_account_set_username_has_succeeded().
2068 (modest_server_account_set_username),
2069 Reset the has-succeeded flag if the username changes.
2071 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2072 * src/maemo/modest-connection-specific-smtp-window.c:
2073 (modest_connection_specific_smtp_window_save_server_accounts):
2074 Use modest_server_account_set_username() instead of using
2075 modest_conf_set_string() directly, so that the has-succeeded flag is always
2078 * src/modest-ui-actions.c:
2079 (modest_ui_actions_on_password_requested): Dim the username entry if
2080 the username has ever worked, as per the UI spec.
2082 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2084 * src/modest-tny-account-store.c: (get_password):
2085 * src/modest-ui-actions.c:
2086 (modest_ui_actions_on_password_requested):
2087 Allow the username to be changed too, though there is more work to
2088 be done on exactly how this behaves.
2090 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2092 * src/modest-account-mgr-helpers.h:
2093 * src/modest-account-mgr-helpers.c:
2094 Added modest_account_mgr_get_display_name(),
2095 modest_server_account_get_username(),
2096 modest_server_account_set_username(),
2097 modest_server_account_set_password(),
2098 modest_server_account_get_hostname() functions so we do not need to
2099 use the conf API directly.
2101 * src/maemo/modest-main-window.c: (connect_signals):
2102 Actually connect ot the ModestAccountStore::request-password signal,
2103 so that we show the dialog when the password is requested by Tinymail,
2104 for isntance if it is empty.
2106 * src/modest-marshal.list:
2107 * src/modest-tny-account-store.c:
2108 (modest_tny_account_store_class_init), (get_password),
2109 (modest_tny_account_store_alert):
2110 * src/modest-tny-account-store.h:
2111 * src/modest-ui-actions.h:
2112 * src/modest-ui-actions.c:
2113 (modest_ui_actions_on_password_requested):
2114 Change the signal parameters, so it is obvious that we are providing
2115 the non human-readable server name, and receiving both the username
2116 and password, though changing of the username is not yet implemented.
2117 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2118 for the GNOME version.
2120 This should fix the projects.maemo.org bug NB#56209, though it does not
2121 work on Bora, because the gconf_client_get() for the password fails
2122 immediately after we save it with gconf_client_set().
2124 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2127 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2128 caused an undefined symbol error:
2129 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2131 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2133 * src/modest-tny-account-store.c:
2134 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2135 using a GError instead of a string message, so we can translate it in
2138 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2140 * src/maemo/modest-address-book.c:
2141 (modest_address_book_check_names):
2142 * src/maemo/modest-msg-view-window.c:
2143 (modest_msg_view_window_clipboard_owner_change):
2144 * src/modest-init.c: (modest_init_init_ui):
2145 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2146 (update_folders_cb), (modest_mail_operation_update_account):
2147 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2148 (modest_ui_actions_on_msg_attachment_clicked),
2149 (modest_ui_actions_on_msg_recpt_activated):
2150 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2151 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2152 (modest_msg_view_search_next):
2153 * src/widgets/modest-recpt-editor.c:
2154 (modest_recpt_editor_on_button_release_event),
2155 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2156 g_message(). At this point we should only be seeing interesting errors on
2157 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2159 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2161 (modest_wizard_dialog_force_title_update):
2162 * src/maemo/easysetup/modest-wizard-dialog.h:
2163 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2164 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2165 can update the title when appropriate. Otherwise the title is wrong if the
2166 pages are added after adding the notebook to the dialog.
2167 This must be a problem in HildonWizardDialog too.
2168 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2170 * src/maemo/easysetup/modest-easysetup-wizard.c:
2171 (create_subsequent_customsetup_pages),
2172 (create_subsequent_easysetup_pages):
2173 Call modest_wizard_dialog_force_title_update() so that the title is
2174 correct even with GTK+ < 2.10.
2175 This fixes projects.maemo.org bug NB#56145 .
2177 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2179 * src/maemo/modest-platform.c:
2180 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2181 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2184 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2186 * src/widgets/modest-window.h:
2187 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2188 and modest_window_save_state(), which invokes it.
2190 * src/widgets/modest-window-mgr.h:
2191 * src/widgets/modest-window-mgr.c:
2192 Added modest_window_mgr_save_state_for_all_windows(), which calls
2193 the save_state vfunc on all registered windows, if implemented.
2195 * src/gnome/modest-msg-edit-window.c:
2196 * src/gnome/modest-msg-view-window.c:
2197 * src/maemo/modest-msg-edit-window.c:
2198 * src/maemo/modest-msg-view-window.c:
2199 * src/maemo/modest-main-window.c:
2200 Specify the existing save_settings functions as implementations of
2201 ModestWindow::save_state_func().
2203 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2204 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2205 enabling hibernation, for instance.
2207 We may need to do the same thing for restoring settings.
2210 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2212 * src/widgets/modest-window-mgr.c:
2213 * src/widgets/modest-window-mgr.h:
2214 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2215 modest_window_mgr_get_hibernation_is_prevented().
2217 * src/maemo/modest-main-window.c:
2218 (on_hildon_program_is_topmost_notify): Prevent hibernation
2219 (possible when the application goes to the background in the WM),
2220 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2222 * src/maemo/easysetup/modest-easysetup-wizard.c:
2223 (modest_easysetup_wizard_dialog_init):
2224 * src/maemo/modest-account-settings-dialog.c:
2225 (modest_account_settings_dialog_init):
2226 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2227 (modest_connection_specific_smtp_edit_window_init):
2228 * src/maemo/modest-connection-specific-smtp-window.c:
2229 (modest_connection_specific_smtp_window_init):
2230 * src/maemo/modest-signature-editor-dialog.c:
2231 (modest_signature_editor_dialog_init):
2232 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2233 prevent hibernation while any of these account settings dialogs are open.
2235 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2237 * src/maemo/Makefile.am:
2238 * src/maemo/modest-osso-state-saving.c:
2239 * src/maemo/modest-osso-state-saving.h: Added
2240 modest_osso_load_state() and modest_osso_save_state() though they do
2241 nothing now. They should iterate through all the open windows and load/save
2243 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2244 save state when closing.
2246 * src/maemo/modest-main-window.c:
2247 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2248 Add a notification handler for the HildonProgram::is-topmost property,
2249 so we can allow hibernation when the application goes into the background.
2250 But we still need to detect when the accounts setup windows are open so
2251 we can stop hibernation when they are open.
2252 To do this, I also added the main window the HildonProgram. This might have
2253 other side-effects/benefits, and should maybe be done for other windows.
2255 * src/maemo/modest-osso-autosave-callbacks.h:
2256 * src/maemo/modest-osso-autosave-callbacks.c:
2257 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2258 though it does not do anything yet, and we might never need this to do
2259 anything. For instance, we already save drafts.
2261 * src/maemo/modest-platform.c: (modest_platform_init):
2262 Specify the libosso auto-save callback.
2264 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2266 * src/maemo/modest-platform.c:
2267 (modest_platform_set_update_interval):
2268 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2269 aparently stays valid between application instances, so we can use this
2270 to remove and reset it later. According to a maemo-developers email from
2273 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2275 * configure.ac: Depend on libalarm for Maemo.
2277 * src/dbus_api/modest-dbus-api.h:
2278 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2279 (on_send_receive), (modest_dbus_req_handler):
2280 Handle a SEND_RECEIVE D-Bus method.
2282 * libmodest-dbus-client/libmodest-dbus-client.c:
2283 (libmodest_dbus_client_send_and_receive):
2284 * libmodest-dbus-client/libmodest-dbus-client.h:
2285 Add C convenience functions for calling the new D-Bus method.
2287 * src/modest-platform.h:
2288 * src/gnome/modest-platform.c:
2289 * src/maemo/modest-platform.c:
2290 Added modest_platform_set_update_interval(), which uses the
2291 alarmd API on Maemo.
2292 (modest_platform_init),
2293 Call modest_platform_set_update_interval(), using a hard-coded
2294 interval for now (until the global settings dialog is implemented),
2295 though I am not sure that this makes sense yet.
2297 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2299 * src/dbus_api/modest-dbus-callbacks.c:
2300 (modest_osso_cb_hw_state_handler):
2301 * src/dbus_api/modest-dbus-callbacks.h:
2302 * src/maemo/modest-platform.c: (modest_platform_init):
2303 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2304 in case this has some effect on the ability for Maemo to ping the
2307 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2309 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2310 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2311 warning. It is probably a logic error, but I need to fix the build.
2313 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2315 * src/modest-account-mgr.h:
2316 * src/modest-account-mgr.c:
2317 (modest_account_mgr_account_names): Add a gboolean enabled_only
2318 parameter, so we can get lists of onlt the enabled accounts.
2320 (modest_account_mgr_add_account),,
2321 (modest_account_mgr_account_with_display_name_exists):
2322 * src/maemo/modest-msg-edit-window.c: (get_transports):
2323 * src/modest-account-mgr-helpers.c:
2324 (modest_account_mgr_set_first_account_as_default):
2325 * src/modest-init.c: (init_default_account_maybe):
2326 * src/modest-tny-account-store.c: (get_accounts):
2327 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2328 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2329 * tests/check_account-mgr.c: (START_TEST):
2330 Provide the extra parameter, as appropriate.
2332 * src/widgets/modest-account-view.c: (update_account_view):
2333 Do not show disabled accounts (meaning that there is no way to
2334 enable/disable accounts in the UI (the feature is not in our UI
2335 specification), so we can use this internally only to mark unfinished
2336 or temporary account data.
2338 * src/maemo/easysetup/modest-easysetup-wizard.c:
2339 (create_account): Add boolean enable parameter, so we can specify FALSE
2340 to create the temporary account.
2341 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2342 (on_before_next): When finishing, when there is a temporary account, just
2344 Also, use a timeout to delay the showing of the dialog until gconf is likely
2345 to return correct information, due to a maemo gconf bug that is fixed in
2346 osso 1.1, but not yet in Bora.
2347 However, the dialog stays on screen after it is destroyed.
2349 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2350 for invalid data when cancelling. Use a hildon note instead of a dialog
2351 to complain about invalid data. Do not show the account-saved note if the
2352 account is disabled (a temporary account that will not really be saved for use
2355 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2357 * src/modest-account-mgr-helpers.h:
2358 * src/modest-account-mgr-helpers.c:
2359 Added modest_account_mgr_unset_default_account(),
2360 Added modest_account_mgr_set_first_account_as_default().
2362 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2363 If it was the default account, unset the default account name.
2365 * src/maemo/modest-account-view-window.c:
2366 (on_delete_button_clicked): If it was the default account,
2367 set the first remaining account as the default instead.
2369 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2370 a NULL account or a NULL default account, to prevent a crash. This should
2371 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2374 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2376 * src/widgets/modest-recpt-editor.c:
2377 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2378 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2379 TODO comment for this. This fixes the build.
2381 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2382 be the best place for it. This will in future update all auto-update accounts,
2383 rather than just the current/default account, when that gconf key exists.
2384 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2385 if there are no accounts, before calling do_send_receive().
2386 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2388 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2389 * src/maemo/modest-main-window-ui.h:
2390 * src/maemo/modest-main-window.c: (on_connection_changed),
2391 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2392 directly, becaue the signal handler does more.
2394 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2396 * src/modest-account-mgr-helpers.c:
2397 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2398 for the case that the account does not exist.
2400 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2401 (equivalent to the modest account name) rather than the tinymail account name
2402 (equivalent to the modest account title - human readable) to get the account data.
2403 Check for null account data to prevent the crash, and add a TODO comment saying that
2404 this needs fixing because it is using the server account name instead of the account name.
2406 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2408 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2409 * src/maemo/modest-account-settings-dialog.c: (show_error),
2411 Use hildon_note_new_information() for informative and error messages,
2412 which seems to be expected for Maemo applications (no documentation that I know of
2413 says this). I am surprised that there is no distinction between info and error
2416 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2418 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2419 it is easy to find where this is used.
2421 * src/maemo/easysetup/modest-easysetup-wizard.c:
2422 (create_page_welcome), (create_page_account_details),
2423 (create_page_user_details), (create_page_complete_easysetup),
2424 (create_page_custom_incoming), (create_page_custom_outgoing),
2425 (create_page_complete_custom):
2426 * src/maemo/modest-account-settings-dialog.c:
2427 (create_page_account_details), (create_page_user_details),
2428 (create_page_incoming), (create_page_outgoing):
2429 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2430 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2431 (modest_connection_specific_smtp_edit_window_init):
2432 * src/maemo/modest-connection-specific-smtp-window.c:
2433 (modest_connection_specific_smtp_window_init):
2434 * src/maemo/modest-signature-editor-dialog.c:
2435 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2436 and scrolling policy as per the Email Application Layout Guide, if I have
2439 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2441 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2442 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2443 which were empty, because these vfuncs have been removed from TnyAccountStore.
2444 This fixes the build.
2446 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2448 * src/maemo/modest-main-window.c:
2449 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2450 showing/hiding it. Added TODO because it probably should not be NULL.
2451 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2452 because unnecessary g_warnings() make degugging difficult.
2454 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2456 * src/maemo/modest-msg-edit-window.c:
2457 (modest_msg_edit_window_select_color),
2458 (modest_msg_edit_window_select_background_color): 2 const corrections and
2459 moving 2 #endifs before closing brackets, to fix the build.
2461 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2463 * src/maemo/easysetup/modest-easysetup-wizard.h:
2464 * src/maemo/easysetup/modest-easysetup-wizard.c:
2465 (modest_easysetup_wizard_dialog_finalize),
2466 (on_button_edit_advanced_settings), (create_page_complete_custom),
2467 (on_response), (create_account):
2468 Implement the Advanced Settings edit button, by saving the account information,
2469 for the Advanded Settings dialog to use directly from gconf, and removing it
2470 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2471 Bug #5533 in the projects.maemo.org bugzilla.
2473 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2475 * src/maemo/modest-msg-view-window.c:
2476 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2477 when opening a message window.
2479 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2481 * src/maemo/easysetup/modest-easysetup-wizard.c:
2482 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2485 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2486 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2487 gconf settings. I probably added more checks than necessary, but that is safer.
2489 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2490 variable to fix the build, but this seems to be used when it is still NULL.
2492 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2494 * src/modest-platform.h:
2495 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2496 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2497 * src/modest-main.c: Implement this function so we can avoid using
2498 maemo-specific API from cross-platform code.
2500 * src/modest-tny-account-store.c:
2501 (get_smtp_specific_transport_account_for_open_connection):
2502 * src/modest-ui-actions.c: (check_for_connection),
2503 (modest_ui_actions_on_item_not_found):
2504 Use modest_platform_connect_and_wait() and put #idefs around other
2505 maemo-specific code, because only maemo currently has a way to
2506 identify connection names.
2508 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2510 * src/modest-tny-account-store.h:
2511 * src/modest-tny-account-store.c:
2512 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2513 the connection-specific SMTP server settings in the configuration.
2515 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2517 * src/maemo/modest-main-window.c: (on_connection_changed),
2519 * src/modest-main.c: (main), (start_ui), (send_mail):
2520 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2521 that is what is intended.
2523 * src/modest-ui-actions.c: (action_send), (action_receive),
2524 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2525 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2526 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2527 SMTP server is used when it is specified.
2529 (modest_ui_actions_on_send_receive):
2530 Check that a connection is open before proceeding.
2531 Receive and then send, instead of vice-versa, as per the specification.
2533 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2535 * src/modest-mail-operation.c:
2536 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2537 though I guess it should be something other than NULL.
2539 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2541 * src/maemo/easysetup/modest-easysetup-wizard.c:
2542 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2543 combo twice, to avoid an g_warning and to make it visible again.
2544 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2545 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2546 (already intended) dereference when detaching, because we then recreate the menu.
2547 But I am not sure why the warning was happening, and it is possible that this is a memory
2550 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2552 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2553 and uri_parse_mailto() utility functions.
2554 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2556 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2558 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2560 * src/dbus_api/modest-dbus-api.h:
2561 * src/dbus_api/modest-dbus-callbacks.c:
2562 Use an idle callback to execute the modest code in the application's own thread.
2563 Remove the helloworld example method.
2564 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2565 parsed, and the open-message method is not implemented because this is not yet implemented in
2567 * libmodest-dbus-client/libmodest-dbus-client.c:
2568 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2569 (libmodest_dbus_client_open_message):
2570 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2572 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2573 body without crashing.
2575 * tests/dbus_api/Makefile.am:
2576 * tests/dbus_api/test_mail_to.c:
2577 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2579 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2581 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2582 Added file to fix the build. Sorry.
2584 * src/dbus_api/Makefile.am:
2585 * src/dbus_api/modest-dbus-api.h:
2586 * src/dbus_api/modest-dbus-callbacks.h:
2587 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2588 (modest_dbus_req_handler):
2589 Put constants in a separate header so it can be reused by the
2590 client library, without duplication
2592 * libmodest-dbus-client/Makefile.am:
2593 * libmodest-dbus-client/libmodest-dbus-client.c:
2594 (libmodest_dbus_client_call_helloworld),
2595 (libmodfest_dbus_client_send_mail),
2596 (libmodfest_dbus_client_mailto),
2597 (libmodfest_dbus_client_open_message):
2598 * libmodest-dbus-client/libmodest-dbus-client.h:
2599 (Partly) Implement a send_mail D-Bus method.
2601 * tests/dbus_api/Makefile.am:
2602 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2603 the send_email D-Bus method.
2605 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2609 * libmodest-dbus-client/Makefile.am:
2610 * libmodest-dbus-client/libmodest-dbus-client.c:
2611 * libmodest-dbus-client/libmodest-dbus-client.h:
2612 * tests/dbus_api/Makefile.am:
2613 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2614 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2616 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2618 * src/maemo/easysetup/modest-easysetup-wizard.c:
2619 (create_page_account_details):
2620 * src/maemo/modest-account-settings-dialog.c:
2621 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2622 widgets, because this might not be the default in future versions of the Maemo GTK+.
2623 However, I can not not get capitalization to work even in a simple test case.
2625 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2627 * src/maemo/easysetup/modest-easysetup-wizard.c:
2628 (create_page_custom_incoming), (create_page_custom_outgoing):
2629 * src/maemo/modest-account-settings-dialog.c:
2630 (create_page_account_details), (create_page_incoming),
2631 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2632 instead of using gtk_check_button_with_label(), so they are aligned like the other
2633 widgets, as per the UI spec.
2635 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2637 * src/maemo/easysetup/modest-easysetup-wizard.c:
2638 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2639 * src/widgets/modest-validating-entry.c:
2640 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2641 Modest prefix instead of an EasySetup prefix.
2643 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2645 * src/widgets/modest-validating-entry.h:
2646 * src/widgets/modest-validating-entry.c: (on_insert_text),
2647 Added easysetup_validating_entry_set_max_func(), used to set a callback
2648 to call when the max number of characters is reached. GtkEntry has a max-length
2649 already but is silent about it.
2651 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2652 (create_page_account_details), (create_page_user_details),
2654 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2655 (create_page_account_details), (create_page_user_details),
2656 (create_page_outgoing):
2657 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2658 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2659 the UI spec, when the user tries to enter more than the max number of characters.
2661 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2663 * src/maemo/easysetup/modest-easysetup-wizard.c:
2664 (create_page_user_details), (create_page_custom_incoming),
2665 (create_page_custom_outgoing):
2666 * src/maemo/modest-account-settings-dialog.c:
2667 (create_page_user_details), (create_page_incoming),
2668 (create_page_outgoing):
2669 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2670 (modest_connection_specific_smtp_edit_window_init):
2671 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2672 not appropriate. Bad Maemo-specific defaults!.
2674 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2676 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2677 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2678 (modest_signature_editor_dialog_set_settings):
2679 Disable the label and textview when the checkbox is disabled, and use the
2680 specified (UI spec) default signature text.
2682 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2684 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2685 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2687 * src/modest-defs.h:
2688 * src/modest-account-mgr-helpers.h:
2689 * src/modest-account-mgr-helpers.c:
2690 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2692 * src/maemo/Makefile.am:
2693 * src/maemo/modest-signature-editor-dialog.c:
2694 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2697 * src/maemo/modest-account-settings-dialog.h:
2698 * src/maemo/modest-account-settings-dialog.c:
2699 (modest_account_settings_dialog_finalize), (on_button_signature),
2700 (save_configuration): Use the new dialog when the Edit button is pressed, and
2701 save the changes if necessary, as per the UI spec.
2703 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2705 * src/maemo/Makefile.am:
2706 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2707 based on maemo-develoers email from Dirk.
2709 * src/maemo/easysetup/modest-easysetup-wizard.c:
2710 (create_page_welcome), (create_page_account_details),
2711 (create_page_user_details), (create_page_complete_easysetup),
2712 (create_page_custom_incoming), (create_page_custom_outgoing),
2713 (create_page_complete_custom),
2714 (modest_easysetup_wizard_dialog_init):
2715 * src/maemo/modest-account-settings-dialog.c:
2716 (create_page_account_details), (create_page_user_details),
2717 (create_page_incoming), (create_page_outgoing),
2718 (modest_account_settings_dialog_init):
2719 * src/maemo/modest-connection-specific-smtp-window.c:
2720 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2722 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2724 * src/maemo/easysetup/modest-easysetup-wizard.c:
2725 (create_page_account_details), (create_page_custom_outgoing),
2726 (create_page_complete_custom):
2727 * src/maemo/modest-account-settings-dialog.c:
2728 (create_page_user_details), (create_page_incoming),
2729 (create_page_outgoing):
2730 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2731 (modest_connection_specific_smtp_edit_window_init):
2732 Use the correct (UI spec) port min/max, and use horizontal separators,
2735 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2737 * src/maemo/easysetup/modest-easysetup-wizard.c:
2738 (set_default_custom_servernames):
2739 * src/maemo/modest-account-settings-dialog.c:
2740 (create_page_incoming), (on_combo_outgoing_security_changed),
2741 (on_combo_incoming_security_changed), (create_page_outgoing),
2742 (modest_account_settings_dialog_set_account_name),
2743 (save_configuration):
2744 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2745 (on_combo_security_changed),
2746 (modest_connection_specific_smtp_edit_window_init),
2747 (modest_connection_specific_smtp_edit_window_set_connection),
2748 (modest_connection_specific_smtp_edit_window_get_settings):
2749 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2752 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2755 * src/maemo/easysetup/modest-easysetup-wizard.c:
2756 (create_page_custom_outgoing), (create_page_complete_custom):
2757 * src/maemo/modest-account-settings-dialog.c:
2758 (create_page_user_details), (create_page_outgoing):
2759 * src/maemo/modest-account-view-window.c: (button_box_new):
2760 Use changed logical IDs as per the most recent UI spec:
2761 mcen_bd_emailsetup_edit -> mcen_bd_edit
2762 mcen_bd_emailsetup_delete -> mcen_bd_delete
2763 mcen_bd_emailsetup_close -> mcen_bd_close
2765 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2769 * src/dbus_api/Makefile.am:
2770 * src/dbus_api/modest-dbus-callbacks.c:
2771 * src/dbus_api/modest-dbus-callbacks.h:
2772 * src/maemo/modest-platform.c: (modest_platform_init):
2773 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2775 * tests/Makefile.am:
2776 * tests/dbus_api/Makefile.am:
2777 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2779 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2781 * src/maemo/modest-account-settings-dialog.c:
2782 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2783 Removed unnecessary includes.
2785 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2787 * src/maemo/easysetup/modest-easysetup-wizard.c:
2788 * src/maemo/modest-account-settings-dialog.c:
2789 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2790 * src/widgets/Makefile.am:
2791 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2792 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2793 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2794 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2795 * src/widgets/modest-secureauth-combo-box.c:
2796 * src/widgets/modest-secureauth-combo-box.h:
2797 * src/widgets/modest-serversecurity-combo-box.c:
2798 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2799 made the GObject names more consistent with the rest of the Modest code.
2801 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2803 * src/maemo/easysetup/Makefile.am:
2804 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2805 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2806 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2807 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2808 * src/maemo/easysetup/modest-easysetup-wizard.c:
2809 * src/maemo/easysetup/modest-validating-entry.c:
2810 * src/maemo/easysetup/modest-validating-entry.h:
2811 * src/maemo/modest-account-settings-dialog.c:
2812 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2813 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2814 widgets/ because they are used outside of easysetup too. After checking in,
2815 svn will allow me to rename them too.
2817 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2819 * src/gnome/modest-msg-edit-window.c:
2820 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2821 linker error, to fix the build on the GNOME platform.
2822 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2823 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2824 ifdefed out to avoid a warning.
2826 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2828 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2829 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2830 some alternative for GTK+ 2.6.
2832 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2834 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2836 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2837 specified for EmailAccountsDialog in UI spec.
2839 * src/maemo/easysetup/modest-easysetup-wizard.c:
2840 * src/maemo/easysetup/modest-easysetup-wizard.h:
2841 * src/maemo/modest-account-settings-dialog.c:
2842 * src/maemo/modest-account-settings-dialog.h:
2843 Reuse a member window widget for the connection-specific SMTP server accounts,
2844 so we can tell it to create/save the accounts only if we actually save changes.
2846 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2847 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2848 (modest_connection_specific_smtp_edit_window_get_settings):
2849 Return a struct instance for temporarily remembering the entered data.
2851 * src/maemo/modest-connection-specific-smtp-window.h:
2852 * src/maemo/modest-connection-specific-smtp-window.c:
2853 (modest_connection_specific_smtp_window_finalize),
2854 (modest_connection_specific_smtp_window_fill_with_connections),
2856 (modest_connection_specific_smtp_window_save_server_accounts),
2857 (update_model_server_names): Do not actually save data until asked,
2858 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2860 (on_selection_changed),
2861 (modest_connection_specific_smtp_window_init): Disable the edit
2862 button when nothing is selected.
2864 * src/modest-account-mgr-helpers.c:
2865 * src/modest-account-mgr-helpers.h:
2866 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2869 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2871 * src/modest-account-mgr-helpers.h:
2872 * src/modest-account-mgr-helpers.c:
2873 (modest_account_mgr_get_unused_account_name),
2874 (modest_account_mgr_get_unused_account_display_name): Added these
2875 utility functions, to avoid code duplication.
2877 * src/maemo/easysetup/modest-easysetup-wizard.c:
2878 (create_page_account_details), (create_account):
2879 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2880 (on_combo_security_changed),
2881 (modest_connection_specific_smtp_edit_window_init),
2882 (modest_connection_specific_smtp_edit_window_save_settings):
2883 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2884 * src/maemo/modest-connection-specific-smtp-window.c:
2885 (modest_connection_specific_smtp_window_finalize),
2886 (modest_connection_specific_smtp_window_fill_with_connections),
2887 (on_button_edit), (modest_connection_specific_smtp_window_init):
2888 * src/maemo/modest-connection-specific-smtp-window.h:
2889 Implementing saving of connection-specific server accounts.
2891 But I need to refactor this so we can save the data for each
2892 possible connection-specific account and only actually create the server accounts
2893 when the easysetup finished, or the OK button is pressed on the account settings
2896 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2898 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2899 (on_combo_security_changed):
2900 (modest_connection_specific_smtp_edit_window_init):
2901 Auto-fill the port number as in the account settings.
2903 (modest_connection_specific_smtp_edit_window_set_connection):
2904 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2905 * src/maemo/modest-connection-specific-smtp-window.c:
2906 (fill_with_connections), (on_button_edit),
2907 (modest_connection_specific_smtp_window_init):
2908 Turn the edit window into a dialog to simplify the code, and
2909 set a WM hint as in a GtkDialog, because only a popup can be on top of
2910 another window in Maemo, and popups usually have no WM decoration.
2912 * src/modest-defs.h:
2913 * src/modest-account-mgr-helpers.c:
2914 (modest_account_mgr_set_connection_specific_smtp),
2915 (modest_account_mgr_remove_connection_specific_smtp),
2916 (modest_account_mgr_get_connection_specific_smtp):
2917 * src/modest-account-mgr-helpers.h: Some functions to write the
2918 connection-specific SMTP server information. Not yet used.
2921 * src/widgets/modest-folder-view.c: (text_cell_data):
2922 Fix a warning about an uninitialized variable.
2923 (on_configuration_key_changed): Put an #ifdef around the use
2924 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2926 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2928 * src/maemo/modest-account-settings-dialog.h:
2929 * src/maemo/modest-account-settings-dialog.c:
2930 Added connect_for_modified() utility function to mark the new modified boolean.
2932 (create_page_account_details), (create_page_user_details),
2933 (create_page_incoming), (create_page_outgoing), (on_response),
2934 (modest_account_settings_dialog_init),
2935 (modest_account_settings_dialog_set_account_name):
2936 Only warn about unsaved changes when there are actually unsaved changes.
2938 * src/modest-account-mgr-helpers.c:
2939 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2940 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2941 to get the data from there in future.
2943 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2945 * src/modest-defs.h:
2947 * src/modest-account-mgr-helpers.h:
2948 * src/modest-account-mgr-helpers.c:
2949 Store the security account setting in a single conf key instead of using
2950 the options list, so that the list is left for just the to-be-removed camel hack,
2951 and because gconf_client_set_list() is failing for some reason.
2953 * src/modest-account-mgr.c:
2954 (modest_account_mgr_add_server_account):
2955 * src/maemo/modest-account-settings-dialog.c:
2956 (modest_account_settings_dialog_set_account_name),
2957 (save_configuration): Use the renamed functions.
2960 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2962 * src/widgets/Makefile.am:
2963 * src/widgets/modest-limit-retrieve-combo-box.c:
2964 * src/widgets/modest-limit-retrieve-combo-box.h:
2965 * src/widgets/modest-retrieve-combo-box.c:
2966 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2967 the account settings dialog.
2969 * src/modest-defs.h:
2970 * src/modest-account-mgr-helpers.h:
2971 * src/modest-account-mgr-helpers.c:
2972 (modest_server_account_get_option_secure_auth),
2973 (modest_server_account_set_option_secure_auth):
2974 * src/modest-account-mgr.c:
2975 (modest_account_mgr_add_server_account):
2976 Use the existing AUTH_MECH conf key for the secure-auth setting,
2977 instead of putting it in the list options, because this was actually used already.
2979 * src/maemo/modest-account-settings-dialog.c:
2980 (create_page_account_details),
2981 (modest_account_settings_dialog_set_account_name),
2982 (save_configuration):
2983 * src/maemo/modest-account-settings-dialog.h:
2984 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2985 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2987 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2989 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2990 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2991 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2993 * src/modest-defs.h:
2994 * src/maemo/modest-account-settings-dialog.c:
2995 (create_page_incoming), (on_combo_outgoing_security_changed),
2996 (on_combo_incoming_security_changed), (create_page_outgoing),
2997 (modest_account_settings_dialog_set_account_name),
2998 (save_configuration): Load/Save the port number, and change it when the
2999 security combo changes, to suitable defaults.
3001 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3003 * src/modest-account-mgr.c:
3004 (modest_account_mgr_add_server_account): Set the security and secure-auth
3005 options, and add a comment saying that the other camel-specific options should be
3008 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3010 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3012 * src/modest-tny-account-store.c: (account_list_free),
3013 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3014 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3017 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3019 * src/modest-protocol-info.c:
3020 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3021 is required by our UI spec. Maybe something in our implementation will use this eventually.
3022 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3023 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3024 instead of the previous 0 placeholder.
3026 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3027 secure-auth settings.
3028 * src/modest-account-mgr-helpers.h:
3029 * src/modest-account-mgr-helpers.c:
3030 (modest_server_account_data_get_option_secure_auth),
3031 (modest_server_account_set_option_secure_auth),
3032 (modest_server_account_data_get_option_security),
3033 (modest_server_account_set_option_security): Added this API for getting and setting the security
3034 and secure-auth settings.
3036 * src/maemo/modest-account-settings-dialog.h:
3037 * src/maemo/modest-account-settings-dialog.c:
3038 (modest_account_settings_dialog_finalize), (check_data),
3039 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3040 about changing titles.
3041 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3042 (save_configuration): Save the security and secure-auth settings.
3044 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3045 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3047 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3049 * src/modest-defs.h:
3050 * src/modest-account-mgr.c:
3051 (modest_account_mgr_add_server_account):
3052 Added and used defines for the options key and value pair strings,
3053 that are used so far, though they do not seem to correspond to anything in our
3054 UI specs or ModestProtocol enum.
3056 * src/modest-account-mgr-helpers.h:
3057 * src/modest-account-mgr-helpers.c:
3058 (compare_option_strings_for_name),
3059 (modest_server_account_data_get_option_value),
3060 (modest_server_account_data_get_option_bool),
3061 (modest_account_mgr_get_server_account_option):
3062 Added helper functions for parsing the options GSList.
3064 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3066 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3067 display name is based on the supplied account name.
3068 * src/modest-account-mgr.c:
3069 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3070 with an inefficient, but good-enough, implementation.
3072 * src/maemo/easysetup/modest-easysetup-wizard.c:
3073 (create_page_account_details), (on_before_next), (create_account):
3074 Check for existing display names rather than (non-user-visible) account names, and just
3075 create and set a unique account name at the end.
3077 * src/maemo/modest-account-settings-dialog.c:
3078 (modest_account_settings_dialog_init),
3079 (modest_account_settings_dialog_set_account_name),
3080 (create_page_incoming): Show the display name, instead of the account name.
3081 (on_response): Do some (not all) extra checks, as in the UI spec.
3082 (save_configuration): Save the display name if it was changed.
3084 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3086 * po/en_GB.po: Added needed logical ID and translation.
3087 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3088 (init_view): Made the is-default column clicking work.
3090 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3093 * src/maemo/easysetup/Makefile.am:
3094 * src/maemo/easysetup/modest-easysetup-wizard.c:
3095 (modest_easysetup_wizard_dialog_init):
3096 * src/maemo/easysetup/provider-data-test.keyfile:
3097 * src/maemo/easysetup/provider-data.keyfile:
3098 Moved the provider data file to the new modest-providers-data package and used it from there.
3100 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3102 * src/modest-local-folder-info.c:
3103 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3104 N_() was already used on the static strings, but this just marks it for translation without
3105 using the translation.
3107 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3109 * src/maemo/modest-account-settings-dialog.c:
3110 (create_page_incoming),
3111 (modest_account_settings_dialog_set_account_name):
3112 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3113 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3114 I will do this if nobody else gets there first.
3116 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3118 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3119 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3120 save the security stuff.
3122 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3124 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3125 Set the email address and user fullname, which I now see must be
3128 * src/maemo/modest-account-settings-dialog.h:
3129 * src/maemo/modest-account-settings-dialog.c:
3131 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3132 leave-on-server and authentication.
3133 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3136 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3139 * src/maemo/modest-account-settings-dialog.c:
3140 * src/maemo/modest-account-settings-dialog.h:
3141 Most (but not all) of the widgets are now present as specified by the UI spec.
3142 No changes are yet saved, and some details are not properly shown yet.
3144 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3146 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3148 * src/maemo/Makefile.am:
3149 * src/maemo/modest-account-settings-dialog.c:
3150 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3151 an existing account. Doesn't do much yet.
3153 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3154 Open the accounts settings dialog when Edit is clicked.
3156 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3158 * src/maemo/easysetup/Makefile.am:
3159 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3161 * src/maemo/easysetup/modest-easysetup-wizard.c:
3162 (modest_easysetup_wizard_dialog_init):
3163 Try to get the source directory from the build system,
3164 instead of hard-coding "./" into the source code, when opening our local
3165 copies of the configuration files.
3166 But this still fails when opening the wizard from the Accounts window,
3167 maybe because the working directory seems to change at runtime.
3168 So the wizard will fail the second time unless you copy the files into their
3169 proper locations - see the stdout warnings for the paths.
3171 (create_page_account_details),(on_before_next):
3172 Check for existing non-server accounts instead of server accounts,
3173 so the default account name is useful again, and to prevent trying to
3176 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3177 Show the wizard when New is clicked.
3179 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3180 (init_view): Show the column headers, and show the columns that are
3181 specified in the UI specs. However, something in Maemo's GTK+ prevents
3182 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3183 change the default account. This is despite unsetting the special properties.
3185 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3187 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3188 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3189 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3190 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3191 to make that clearer.
3192 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3194 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3196 * src/maemo/modest-account-view-window.c:
3197 (modest_account_view_window_init),
3198 (modest_account_view_window_new):
3199 Use the same buttons as specified in the
3200 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3201 the existing widgets, which never had a chance of working.
3202 Put the ModestAccountView treeview in a scrolled window.
3203 Do not repeat the initialization in both _init() and _new().
3205 * src/widgets/modest-account-view.c: (update_account_view):
3206 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3207 this widget and window shows no accounts.
3209 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3211 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3213 * src/maemo/easysetup/modest-easysetup-wizard.c:
3214 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3215 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3216 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3219 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3220 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3221 accounts exist yet, as in the UI spec.
3223 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3225 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3227 * src/maemo/Makefile.am:
3228 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3229 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3230 New window for editing connection-specific smtp details.
3231 Not fully implemented.
3233 * src/maemo/modest-connection-specific-smtp-window.c:
3234 (modest_connection_specific_smtp_window_finalize) :
3235 unref the tree model.
3236 (on_button_edit): Show the edit window.
3238 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3240 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3243 * src/maemo/Makefile.am:
3244 * src/maemo/modest-connection-specific-smtp-window.c:
3245 * src/maemo/modest-connection-specific-smtp-window.h:
3246 New window for showing the list of connections, for connection-specific
3247 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3248 * src/maemo/easysetup/modest-easysetup-wizard.c:
3249 (create_page_custom_outgoing): Show the new window when the button is clicked.
3251 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3253 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3254 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3255 * src/maemo/modest-msg-edit-window.c:
3256 (modest_msg_edit_window_insert_image):
3257 * src/modest-conf.c: (modest_conf_key_escape):
3258 * src/modest-mail-operation.c:
3259 (modest_mail_operation_send_new_mail):
3260 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3261 (modest_ui_actions_on_new_account):
3262 * src/widgets/modest-attachment-view.c: (update_filename_request):
3263 * src/widgets/modest-mail-header-view.c:
3264 Corrected warnings that were breaking the build, by commenting out unused variables,
3265 and a function, and by including a header.
3267 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3269 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3270 so we can #ifdef around platform-specific code when necessary.
3271 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3272 to allow this to build for the GNOME platform too.
3274 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3276 * src/maemo/easysetup/modest-easysetup-wizard.c:
3277 Added util_increment_name() and used it in create_page_account_details()
3278 to make sure that the default account name is always a new name.
3280 (modest_easysetup_wizard_dialog_init),
3281 (set_default_custom_servernames): Some minor memory management fixes.
3283 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3287 * src/modest-runtime.c: (init_i18n): Restored the translation
3288 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3289 are defined in config.h, and the translations are installed.
3291 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3292 is defined for translation.
3294 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3296 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3298 * src/maemo/easysetup/modest-easysetup-wizard.c:
3299 (modest_easysetup_wizard_dialog_init):
3300 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3301 Use realistic paths (though they should use $prefix generically) to the
3302 mcc_mapping and provider-data.keyfile files which might work when they
3303 are installed by the future version of the operator-wizard package,
3304 and then fallback to paths in our source code, with an explanatory
3307 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3311 * src/maemo/Makefile.am:
3312 * src/maemo/easysetup/: Added files from the previously-exernal
3313 osso-modest-easysetup.
3314 * src/maemo/modest-main-window-ui.h:
3315 * src/modest-ui-actions.c:
3316 * src/modest-ui-actions.h:
3317 Added modest_ui_actions_on_new_account() as a signal handler for the
3318 New Account menu item. It shows the easysetup wizard.
3319 * po/en_GB.po: Added additional needed logical IDs and translations.