1 2007-06-02 Armin Burgmeier <armin@openismus.com>
3 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
4 server type cannot be changed in future to the incoming details page
5 when creating an account. This fixes projects.maemo.org bug NB#59029.
7 2007-06-02 Armin Burgmeier <armin@openismus.com>
9 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
10 and assigned max width chars so that they wrap instead of being
11 truncated. Fixes projects.maemo.org bug NB#56126.
13 2007-06-02 Armin Burgmeier <armin@openismus.com>
15 * src/maemo/modest-connection-specific-smtp-window.c: Add an
16 introductory note to the connection specific smtp servers dialog, as
17 section 8.12 of the email UI specification requires. This fixes
18 projects.maemo.org bug NB#59212.
20 2007-06-01 Murray Cumming <murrayc@murrayc.com>
22 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
23 Check for running mail operations, and offer to cancel them, as per the UI
24 spec. This fixes projects.maemo.org bug NB#59041 .
25 However, I suspect that tinymail may still use the network connection
26 in ways that we cannot detect or cancel. But it should at least adapt to
29 2007-06-01 Murray Cumming <murrayc@murrayc.com>
31 * src/modest-tny-account-store.c: (recreate_all_accounts),
32 (get_cached_accounts), (get_server_accounts): Do more sensible
33 ref-counting of the temporarily-cached outbox accounts list. This seems
34 to fix a crash when entering the password when the password was wrong.
36 2007-06-01 Murray Cumming <murrayc@murrayc.com>
38 * src/gnome/modest-main-window.c: (connect_signals):
39 * src/modest-tny-account-store.c: (get_password),
40 (modest_tny_account_store_alert): Added comments and clues and
41 commented-out code about how we currently fail to deal with connection
42 errors and wrong passwords, and how we should.
44 2007-06-01 Murray Cumming <murrayc@murrayc.com>
46 * src/widgets/modest-retrieve-combo-box.c:
47 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
48 This fixes projects.maemo.org bug NB#58472 .
50 2007-06-01 Murray Cumming <murrayc@murrayc.com>
52 * src/maemo/easysetup/modest-easysetup-wizard.c:
53 (create_page_complete_easysetup):
54 (create_page_complete_custom): Correct the last commit,
55 putting the correct sentences in the correct pages.
57 2007-06-01 Murray Cumming <murrayc@murrayc.com>
59 * src/maemo/easysetup/modest-easysetup-wizard.c:
60 (create_page_complete_custom): Show the second sentence of text
61 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
64 2007-06-01 Murray Cumming <murrayc@murrayc.com>
66 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
67 Set the leave-on-server conf key by default. This fixes
68 projects.maemo.org bug NB#59258 .
70 2007-06-01 Murray Cumming <murrayc@murrayc.com>
72 * src/maemo/modest-account-view-window.c:
73 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
74 logical ID for the confirmation messages. Fixed projects.maemo.org bug
77 2007-06-01 Murray Cumming <murrayc@murrayc.com>
79 * src/maemo/easysetup/modest-easysetup-wizard.c:
80 (create_caption_new_with_asterisk):
81 * src/maemo/modest-account-settings-dialog.c:
82 (create_caption_new_with_asterisk):
83 Uncomment the code to add the asterisk, because they are no longer in the
84 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
85 (update_incoming_server_title): Add an asterisk here too.
87 2007-06-01 Murray Cumming <murrayc@murrayc.com>
89 * src/maemo/modest-maemo-global-settings-dialog.c:
90 (current_connection): Check that we are even connected before trying to
91 get the current connection name, to prevent a warning.
93 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
94 Change the comments because tny_maemo_conic_device_connect() is now meant to
96 * src/modest-mail-operation.c:
97 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
98 make sure we have a connection and fail if we can't connect.
100 2007-05-31 Murray Cumming <murrayc@murrayc.com>
102 * src/maemo/modest-main-window.c:
103 (on_account_store_connecting_finished): Do not try to get the
104 connection ID if we are not really connected. I am surprised that
105 this signal handler is called when we are not connected.
107 2007-05-31 Murray Cumming <murrayc@murrayc.com>
109 * src/modest-error.h:
110 * src/modest-ui-actions.c:
111 (modest_ui_actions_get_msgs_full_error_handler):
112 Renamed an enum, added comments, added an enum
113 for retrieve-limit errors.
115 * src/modest-mail-operation.c: (foreach_add_item),
116 (internal_folder_observer_update), (update_account_thread),
117 (modest_mail_operation_get_msgs_full):
118 (modest_mail_operation_update_account),
119 Added comments about how this works, and some code that should
120 (but does not) check the retrieve-limit. See the TODO comment.
122 2007-05-31 Murray Cumming <murrayc@murrayc.com>
124 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
125 Initialize help_id to fix the build. Warnings are good.
127 2007-05-31 Murray Cumming <murrayc@murrayc.com>
129 * src/widgets/modest-hbox-cell-renderer.c:
130 (modest_hbox_cell_renderer_append):
131 * src/widgets/modest-vbox-cell-renderer.c:
132 (modest_vbox_cell_renderer_append):
133 Fix the last commit by doing an extra ref.
135 2007-05-31 Murray Cumming <murrayc@murrayc.com>
137 * src/widgets/modest-hbox-cell-renderer.c:
138 (modest_hbox_cell_renderer_append):
139 * src/widgets/modest-vbox-cell-renderer.c:
140 (modest_vbox_cell_renderer_append):
141 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
142 to fix the build with Maemo Bora.
143 However, there seems to be a remaining crash, probably due to reference
146 2007-05-30 Murray Cumming <murrayc@murrayc.com>
148 * src/modest-tny-account.c:
149 (modest_tny_account_new_for_local_folders):
150 Use hildon_file_system_info_async_new() to get a better name for
151 the memory card account, setting it as the account name.
152 The timing seems to work, but this is probably
153 not the best place to do this. See the TODO comment.
154 * src/maemo/modest-main-window.c: (create_details_widget):
155 * src/widgets/modest-folder-view.c: (text_cell_data):
156 Use the tny account name instead of hardcoding a name.
158 2007-05-30 Christian Kellner <ckellner@openismus.com>
160 * src/modest-search.c: (modest_search):
161 Correctly set part_search_func even if we have already parsed
162 the query and thus a valid OgsTextSearcher object.
164 2007-05-30 Christian Kellner <ckellner@openismus.com>
167 Search and check for libogs.
170 Incooparte the ogs build env.
172 * src/modest-mime-part-search-stream.c:
173 * src/modest-mime-part-search-stream.h:
174 Removed since we do the real searching now in modest-search.c.
176 * src/modest-search.c:
177 * src/modest-search.h:
178 Implement support for ogs. We use that if available and requested
179 and fall back to modest_text_utils_utf8_strcmp (). The search logic
180 should now handle the corner case when the search term is spread
181 across multiple reads.
182 Also the logic in modest_search () was corrected to search all
183 requested fields until one is found.
185 2007-05-30 Murray Cumming <murrayc@murrayc.com>
187 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
190 * src/modest-init.c: Made modest_init_local_folders() take a
191 path and be public so we can iniitialize maildir folders on
194 * src/modest-local-folder-info.h:
195 * src/modest-local-folder-info.c:
196 (modest_local_folder_info_get_maildir_path): Add a path parameter.
198 * src/modest-tny-account.c:
199 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
200 still means the standard local-folders path on the local volume.
202 * src/modest-tny-account-store.c:
203 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
204 signal so we can detect mount/unmount of the MMC1 card, and do an update of
205 all accounts when that happens.
206 (get_server_accounts): If the MMC1 card is mounted, create a store account for
207 this too, so it shows up in the treeview.
209 2007-05-28 Murray Cumming <murrayc@murrayc.com>
211 * src/maemo/modest-maemo-global-settings-dialog.c:
212 (current_connection):
213 * src/widgets/modest-global-settings-dialog.c:
214 (current_connection_default):
215 Use the enum values instead of 0, 1 and -1,
216 to make the code clearer.
218 * src/modest-account-mgr-helpers.c:
219 (modest_account_mgr_get_connection_specific_smtp): Make this code
222 * src/modest-runtime.h:
223 * src/modest-runtime.c:
224 Added modest_runtime_remove_all_send_queues().
225 * src/maemo/modest-main-window.c:
226 (on_account_store_connecting_finished): Recreate the send queues,
227 using the appropriate transport accounts for this new connection.
228 Some futher adapting might be needed if the old send queues are not
229 automatically stopped at this point.
231 * src/modest-tny-account-store.c: (get_server_accounts):
232 Create the connection-specific transport accounts, so that they can
233 be found later by their ID.
235 * src/modest-tny-account.h:
236 * src/modest-tny-account.c:
237 Added modest_tny_account_new_from_server_account_name().
238 modest_tny_account_new_from_server_account(): Do not create the
239 send queues here, because they will be
240 recreated anyway when the connection changes for the first time.
242 2007-05-28 Murray Cumming <murrayc@murrayc.com>
244 * src/modest-local-folder-info.h:
245 * src/modest-local-folder-info.c:
246 (modest_per_account_local_outbox_folder_info_get_maildir_path),
247 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
248 tbox_folder): Take a modest account name instead of a server TnyAccount,
249 so we can have per-modest-account rather than per-transport-account
251 We must make sure that we change or recreate the exisitng send queues
252 when the connection changes for connection-specific transport accounts.
254 * src/modest-tny-account-store.c:
255 (create_per_account_local_outbox_folders): Create outboxed per modest
256 account, not per transport account.
258 * src/modest-tny-account.h:
259 * src/modest-tny-account.c:
260 (modest_tny_account_get_special_folder): For outboxes, get the
261 parent modest account name. The account is ignored for other folders.
262 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
263 modest account name rather than a server TnyAccount.
265 2007-05-25 Murray Cumming <murrayc@murrayc.com>
267 * src/modest-tny-account.c:
268 (modest_tny_account_new_from_server_account):
269 Call modest_runtime_get_send_queue() immediately after creating transport
270 accounts, so that they start trying to send email from the outbox as soon
271 as possible at startup. This is probably what we want.
273 * src/modest-mail-operation.c: (update_account_thread):
274 * src/modest-runtime.c: (modest_runtime_get_send_queue):
275 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
276 * src/modest-tny-send-queue.h:
277 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
278 (modest_ui_actions_on_send):
279 Added comments about how sending works, though it needs some more work.
281 2007-05-25 Murray Cumming <murrayc@murrayc.com>
283 * src/modest-tny-account.c:
284 (modest_tny_account_get_special_folder): Add TODO because this fails when
286 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
287 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
288 Do not try to show this window when there is no active account. The UI
289 specs does not tell us what to do in this case.
291 2007-05-24 Murray Cumming <murrayc@murrayc.com>
295 * src/maemo/Makefile.am:
296 * src/widgets/Makefile.am: Some dist fixes.
298 2007-05-24 Murray Cumming <murrayc@murrayc.com>
300 * src/maemo/modest-connection-specific-smtp-window.c:
301 (on_button_edit): Make the code clearer, to prevent a double free.
303 2007-05-24 Murray Cumming <murrayc@murrayc.com>
305 * src/maemo/modest-account-settings-dialog.c:
306 (modest_account_settings_dialog_set_account_name),
307 Check the connection-specific smtp servers checkbox if there are any.
309 * src/maemo/modest-connection-specific-smtp-edit-window.c:
310 (modest_connection_specific_smtp_edit_window_init):
311 Start with a suitable port number.
313 * src/modest-account-mgr-helpers.h:
314 * src/modest-account-mgr-helpers.c: Added
315 modest_account_mgr_get_has_connection_specific_smtp().
317 (modest_account_mgr_set_connection_specific_smtp),
318 (modest_account_mgr_remove_connection_specific_smtp),
319 (modest_account_mgr_get_has_connection_specific_smtp),
320 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
321 connection-specific smtp server accounts in the account, rather than
322 the server account conf dir.
324 This fixes bug projects.maemo.org bug NB#58263 .
326 * src/modest-tny-account-store.c:
327 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
328 if there are no server accounts yet, to prevent an infinite loop when there
329 are no accounts. Document that one must be called before the other.
331 2007-05-24 Murray Cumming <murrayc@murrayc.com>
333 * src/modest-account-mgr-helpers.c:
334 (modest_account_mgr_get_default_account): Make sure that at least
335 one account is always the default, if there are any enabled accounts.
336 This is just a sanity check that shouldn't be necessary.
338 * src/modest-account-mgr-priv.c:
339 (_modest_account_mgr_account_from_key): Unescape the conf key to
340 get the real account name. For instance, this is an issue if a space
341 was in the account name, which can happen because the account name
342 is generated from the display name.
343 (_modest_account_mgr_get_account_keyname): Always escape the
345 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
346 Unescape the conf keys to get the real account names.
348 For instance, previously the is-default radio button in the accounts
349 list was not checked for any accounts at first. This fixes that,
350 and might fix several similar bugs.
352 2007-05-23 Murray Cumming <murrayc@murrayc.com>
354 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
355 Removed some debug printfs.
357 2007-05-23 Murray Cumming <murrayc@murrayc.com>
359 Modest on-disk outbox directories are now here, for instance:
360 $HOME/.modest/outboxes/<account-id-1>/outbox
361 $HOME/.modest/outboxes/<account-id-2>/outbox
363 $HOME/.modest/local-folders/outbox
364 so we can have a separate outbox for each account.
365 But they are shown as one outbox in the GtkTreeView, by using a
366 TnyMergeFolder in a ModestTnySimpleFolderStore.
369 * src/modest-tny-simple-folder-store.c:
370 * src/modest-tny-simple-folder-store.h:
371 Added ModestTnySimpleFolderStore, used to contain folders from
372 other folder stores, such as other accounts.
374 * src/modest-tny-outbox-account.h:
375 * src/modest-tny-outbox-account.c:
376 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
377 used for the per-account local outbox folders.
379 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
380 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
381 only use this (internally) now for the non-outbox local folders.
384 * src/modest-init.c: Added modest_init_one_local_folder(), for
385 setting up the directory structure for each local folder.
387 * src/modest-local-folder-info.c:
388 (modest_per_account_local_outbox_folder_info_get_maildir_path),
389 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
391 * src/modest-local-folder-info.h:
392 * src/modest-tny-account-store.c: (on_account_removed),
393 (on_account_changed), (create_per_account_local_outbox_folders),
394 (get_server_accounts), (modest_tny_account_store_get_accounts),
395 (modest_tny_account_store_get_tny_account_by_account),
396 (modest_tny_folder_store_is_virtual_local_folders):
398 * src/modest-tny-account.h:
399 * src/modest-tny-account.c:
400 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
401 to create an on-disk per-account local outbox folder for each
403 (create_per_account_local_outbox_folders): Create a local outbox folder
404 for each transport account.
405 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
406 for all local folders.
408 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
409 instead of using g_object_get/set() directly. It is clearer.
411 (modest_tny_folder_store_get_message_count),
412 (modest_tny_folder_store_get_local_size
413 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
414 because we now use these with non-acount folder stores.
416 (modest_tny_account_get_special_folder),
417 (modest_tny_account_new_from_server_account),
418 (modest_tny_account_new_from_account):
419 (recurse_folders): Adjust to the new outbox system.
421 * src/modest-tny-folder.h:
422 * src/modest-tny-folder.c:
423 (modest_tny_folder_is_local_folder),
424 (modest_tny_folder_get_local_folder_type),
425 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
427 * src/widgets/modest-main-window.h:
428 * src/maemo/modest-main-window.c: (create_details_widget),
429 (modest_main_window_set_contents_style): Show details for any folder store,
432 (modest_tny_folder_get_rules):
433 Remove the const. C does not support constness enough for this.
435 * src/modest-ui-actions.c:
436 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
437 make all outboxes appear as one, in the usual local-folders tree node.
439 (set_active_account_from_tny_account),
440 (modest_ui_actions_on_folder_selection_changed):
441 * src/widgets/modest-folder-view.c: (text_cell_data),
442 (icon_cell_data), (filter_row),
443 (add_account_folders_to_merged_folder),
444 (add_account_folders_to_simple_folder_store), (),
445 (get_cmp_rows_type_pos), (cmp_rows),
446 (modest_folder_view_set_account_id_of_visible_server_account):
447 Adjust to the new outbox system, using generic folder stores and folders
450 2007-05-23 Christian Kellner <ckellner@openismus.com>
452 * src/modest-mail-operation.c:
453 (modest_mail_operation_update_account):
454 Use info->max_size instead of unintialized local var [small
455 build fix]. (Added TODO to review that change since I don't
458 2007-05-23 Marcus Bauer <marcusb@openismus.com>
460 * libmodest-dbus-client/libmodest-dbus-client.c:
461 (libmodest_dbus_client_compose_mail): function added
462 * src/dbus_api/modest-dbus-api.h:
463 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
464 (on_compose_mail): Implementation of the SendAsMail functionality
466 2007-05-22 Murray Cumming <murrayc@murrayc.com>
468 * src/modest-account-mgr.c:
469 (modest_account_mgr_add_server_account): Set the secure-connection
470 conf key for transport accounts as well as store accounts. I don't know
471 why the if was there. For instance, this makes sure that we use SSL
472 for the gmail preset from the easysetup wizard.
474 2007-05-22 Murray Cumming <murrayc@murrayc.com>
476 * src/gnome/modest-main-window.c:
477 (on_account_store_connecting_finished), (connect_signals):
478 * src/maemo/modest-main-window.c:
479 (on_account_store_connecting_finished), (connect_signals),
480 (modest_main_window_new):
481 Handle TnyAccountStore::connecting-finished instead of
482 TnyDevice::connection-changed, because we cannot actually perform
483 operations on accounts until TnyAccountStore has itself responded to
484 the TnyDevice::connection-changed signal. This prevents a GError from
486 Do not try to update at startup, because we (at least on scratchbox)
487 already do an update at startup when the device goes online.
488 This prevents a GError from tinymail.
489 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
490 Added TODO about stopping simultaneous operations.
492 2007-05-21 Murray Cumming <murrayc@murrayc.com>
494 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
495 * src/modest-mail-operation-queue.c:
496 (modest_mail_operation_queue_remove):
497 * src/modest-tny-account-store.c: When GErrors happen, give more clues
498 about where they happened.
500 2007-05-21 Murray Cumming <murrayc@murrayc.com>
502 * src/modest-ui-actions.c:
503 (modest_ui_actions_on_password_requested): Make sure that the remember
504 output parameter is always TRUE.
506 2007-05-21 Murray Cumming <murrayc@murrayc.com>
508 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
509 Show a OK/Cancel dialog if the error is a question, though we still do not
510 know anything more about what we are asking the user.
511 * src/widgets/modest-folder-view.c: (on_drag_data_received):
512 Fix an uninitialized variable (helper). This is a logic error, however.
514 2007-05-21 Christian Kellner <ckellner@openismus.com>
516 * src/modest-search.h:
517 Correct bit shifting in the ModestSearchFlags enum.
519 2007-05-21 Murray Cumming <murrayc@murrayc.com>
521 * src/modest-tny-account.c:
522 (modest_tny_account_new_from_server_account): Do not use the lsub and
523 check-all hard-coded IMAP options when using POP.
525 2007-05-21 Murray Cumming <murrayc@murrayc.com>
527 * src/modest-tny-account.c:
528 (modest_tny_account_new_from_server_account):
529 Use NULL for the secure-auth method for POP when Password auth has been
530 specified by the user, as we already do for IMAP. "auth=Login" causes
531 an error from camel or the server.
533 2007-05-17 Murray Cumming <murrayc@murrayc.com>
535 * src/maemo/modest-account-settings-dialog.c:
536 (create_page_account_details),
537 (modest_account_settings_dialog_set_account_name):
538 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
539 for the leave-on-server checkbox, rathr than just the checkbox, when
540 the protocol is not POP.
542 2007-05-17 Murray Cumming <murrayc@murrayc.com>
544 * src/widgets/modest-account-view.c:
545 * src/widgets/modest-account-view.h:
546 Added modest_account_view_select_account() which will be useful later
547 to asynchronously re-select the edited account.
549 2007-05-17 Murray Cumming <murrayc@murrayc.com>
551 * src/maemo/modest-account-settings-dialog.c:
552 (modest_account_settings_dialog_set_account_name):
553 Automatically choose the port numbers based on the secure authentication
554 methods, if they have not been chosen before.
555 This fixes projects.maemo.org bug NB#56273 .
557 2007-05-17 Murray Cumming <murrayc@murrayc.com>
559 * src/maemo/modest-main-window-ui.h:
560 * src/modest-ui-actions.c:
561 * src/modest-ui-actions.h:
562 Connect the Tools/SMTP Servers menu item to
563 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
564 SMTP servers dialog, as in the UI specification and saves changes when it
565 is closed. This fixed projects.maemo.org bug NB#56305 .
567 2007-05-17 Murray Cumming <murrayc@murrayc.com>
569 * src/maemo/modest-connection-specific-smtp-window.c:
570 (modest_connection_specific_smtp_window_init):
571 Use gtk_window_set_default_size() to make this window big enough, so
572 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
574 2007-05-17 Murray Cumming <murrayc@murrayc.com>
576 * src/maemo/modest-connection-specific-smtp-edit-window.h:
577 * src/maemo/modest-connection-specific-smtp-edit-window.c:
578 (modest_connection_specific_smtp_edit_window_init),
579 Do not try to connect to a combobox signal before the combobox exists.
580 This fixes the cras in projects.maemo.org bug NB#56288 .
581 (modest_connection_specific_smtp_edit_window_get_settings):
582 Remove the server_account_name parameter which was being checked for NULL
583 though it was not used.
585 * src/maemo/modest-connection-specific-smtp-window.c:
586 (modest_connection_specific_smtp_window_fill_with_connections),
587 (on_button_edit), (modest_connection_specific_smtp_window_init):
588 Correct the number of treemodel columns to prevent a warning.
589 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
590 libconic does not work.
592 2007-05-16 Murray Cumming <murrayc@murrayc.com>
594 * src/modest-tny-account.c:
595 (modest_tny_account_new_from_server_account):
596 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
597 SMTP when "None" was chosen by the user. However, with my SMTP server that
598 does not support ANONYMOUS, the emails do not leave the Outbox and I see
601 2007-05-16 Murray Cumming <murrayc@murrayc.com>
603 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
604 to explain the memory management issue with the ID in the ModestPair.
606 * src/gnome/modest-account-assistant.c: (add_receiving_page),
607 (add_sending_page), (modest_account_assistant_finalize):
608 * src/gnome/modest-gnome-global-settings-dialog.c:
609 (create_updating_page), (create_composing_page):
610 * src/gnome/modest-msg-edit-window.c: (get_transports),
611 (init_window), (modest_msg_edit_window_finalize),
612 (modest_msg_edit_window_get_msg_data):
613 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
614 * src/gnome/modest-transport-widget.c:
615 (modest_transport_widget_finalize), (smtp_configuration):
616 * src/maemo/modest-maemo-global-settings-dialog.c:
617 (create_updating_page), (create_composing_page):
618 * src/maemo/modest-msg-edit-window.c: (get_transports),
619 (init_window), (modest_msg_edit_window_finalize),
620 (modest_msg_edit_window_get_msg_data),
621 (modest_msg_edit_window_free_msg_data):
622 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
623 (modest_store_widget_finalize):
624 * src/maemo/modest-transport-widget.c:
625 (modest_transport_widget_finalize), (smtp_configuration):
626 * src/modest-main.c: (send_mail):
627 * src/widgets/modest-combo-box.h:
628 * src/widgets/modest-global-settings-dialog-priv.h:
629 * src/widgets/modest-global-settings-dialog.c:
630 (modest_global_settings_dialog_finalize):
631 * src/widgets/modest-msg-edit-window.h:
632 Whenever using modest_combo_box_new(), keep the ModestPairList alive
633 as long as the combo box, to prevent use of freed memory for the ID.
635 2007-05-15 Murray Cumming <murrayc@murrayc.com>
637 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
638 get_accounts(), to make this clearer. Do not check for the enabled gconf
639 key, because we do not use this for server accounts (at least, not yet).
640 This allows us to send email again.
642 2007-05-15 Murray Cumming <murrayc@murrayc.com>
644 * src/maemo/modest-platform.c:
645 (on_modest_conf_update_interval_changed), (modest_platform_init):
646 Only respond to this particular key change. All these strcmp()s cannot be
649 2007-05-15 Murray Cumming <murrayc@murrayc.com>
651 * src/maemo/modest-maemo-global-settings-dialog.c:
652 (current_connection): Prevent a crash in scratchbox when
653 ny_maemo_conic_device_get_current_iap_id() returns NULL.
654 * src/maemo/modest-platform.c:
655 (on_modest_conf_update_interval_changed), (modest_platform_init):
656 Get the update interval from gconf and reset it when the gconf key changes.
658 2007-05-15 Murray Cumming <murrayc@murrayc.com>
660 * src/modest-protocol-info.c:
661 * src/modest-protocol-info.h: Adde enum-specific get functions,
662 instead of using a ModestProtocolType enum parameter.
664 * src/gnome/modest-account-assistant.c:
665 * src/gnome/modest-store-widget.c:
666 * src/gnome/modest-store-widget.h:
667 * src/gnome/modest-transport-widget.c:
668 * src/gnome/modest-transport-widget.h:
669 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
670 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
671 * src/maemo/easysetup/modest-easysetup-wizard.c:
672 * src/maemo/modest-account-settings-dialog.c:
673 * src/maemo/modest-account-settings-dialog.h:
674 * src/maemo/modest-store-widget.c:
675 * src/maemo/modest-store-widget.h:
676 * src/maemo/modest-transport-widget.c:
677 * src/maemo/modest-transport-widget.h:
678 * src/modest-account-mgr-helpers.c:
679 * src/modest-account-mgr-helpers.h:
680 * src/modest-account-mgr.c:
681 * src/modest-account-mgr.h:
682 * src/modest-tny-account.c:
683 * src/modest-tny-folder.c:
684 * src/widgets/modest-account-view.c:
685 * src/widgets/modest-retrieve-combo-box.c:
686 * src/widgets/modest-retrieve-combo-box.h:
687 * src/widgets/modest-secureauth-combo-box.c:
688 * src/widgets/modest-serversecurity-combo-box.c:
689 * src/widgets/modest-serversecurity-combo-box.h:
690 * tests/check_account-mgr.c:
691 Use the specific functions, and use the re-renamed enum values for GNOME too.
693 2007-05-15 Murray Cumming <murrayc@murrayc.com>
696 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
697 so we can get the second based on the first.
699 * src/maemo/modest-account-settings-dialog.h:
700 * src/maemo/modest-account-settings-dialog.c:
701 Added get_supported_secure_authentication_methods(), though it is mostly
702 commented-out for now until the necessary API is committed to tinymail.
703 (modest_account_settings_dialog_set_account_name),
704 (save_configuration): Request the supported authentication methods from the
705 server, so we can choose a working method.
707 * src/modest-tny-account-store.h:
708 * src/modest-tny-account-store.c:
709 (modest_tny_account_store_get_session): Rename from
710 tny_account_store_get_session().
712 2007-05-14 Murray Cumming <murrayc@murrayc.com>
714 * src/modest-protocol-info.h: Split the ModestProtocol enum
715 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
716 There was no need to have these unrelated values in one enum.
718 * src/: many files: Adapted to changed enum. This makes the code a bit
719 clearer, and the compiler could catch some errors.
721 2007-05-14 Murray Cumming <murrayc@murrayc.com>
723 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
724 Show the detailed internal camel error message when an error happens
725 during the configuration, so that our testers can give us more clues.
726 For instance, in projects.maemo.org bug NB#56910 .
728 2007-05-14 Murray Cumming <murrayc@murrayc.com>
730 * src/modest-tny-account.c:
731 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
732 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
734 2007-05-14 Murray Cumming <murrayc@murrayc.com>
736 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
737 * src/maemo/modest-account-settings-dialog.c:
738 (modest_account_settings_dialog_set_account_name),
739 (save_configuration): For the incoming secure authentication checkbox,
740 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
741 the UI specification. PLAIN does not seem to be supported for most IMAP
742 servers anyway, and I am not sure what it would mean.
743 However, we probably need to discover which of the secure-authentication
744 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
745 * src/modest-account-mgr-helpers.c:
746 (modest_account_mgr_get_server_account_data):
748 * src/modest-tny-account.c:
749 (modest_tny_account_new_from_server_account):
750 Use tny_account_set_mech() to set secure-authentication methods,
751 with some special-casing for IMAP, based on my observations of how
754 * src/modest-account-mgr-helpers.h:
755 * src/modest-account-mgr.c:
756 * src/modest-defs.h: Comment that the URI is only used for local folders.
758 2007-05-11 Murray Cumming <murrayc@murrayc.com>
760 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
761 parameter const, just to be neat.
762 * src/modest-text-utils.c: (modest_text_utils_inline):
763 End g_strconcat() with NULL, as its documentation says. This is almost
764 certainly the cause of my crash at startup on the device. Interestingly,
765 valgrind doesn't tell us about these errors.
767 2007-05-11 Murray Cumming <murrayc@murrayc.com>
769 * scripts/build-packages: Added more precise comments about how to use
770 this script, though I still get this error:
771 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
772 error building tinymail
774 2007-05-11 Murray Cumming <murrayc@murrayc.com>
776 * src/maemo/modest-main-window.c: (on_account_update):
777 Very slight cleanup, hoping to make it simpler to discover what causes
778 a crash here sometimes.
780 * src/modest-tny-account.c:
781 (modest_tny_account_new_from_server_account): Set the port. Added
782 comments about the options and a TODO comment because I need to find out
783 how to specify the secure authentication method.
785 2007-05-11 Marcus Bauer <marcusb@openismus.com>
787 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
788 changed CFlags paths form modest to libmodest
790 2007-05-10 Murray Cumming <murrayc@murrayc.com>
792 * src/modest-account-mgr-helpers.c:
793 (modest_account_mgr_get_server_account_data),
794 (modest_account_mgr_free_server_account_data):
795 * src/modest-account-mgr-helpers.h:
796 * src/modest-account-mgr.c:
797 (modest_account_mgr_add_server_account):
799 * src/modest-tny-account.c:
800 (modest_tny_account_new_from_server_account):
801 Determine the options for tny_camel_account_add_option() here,
802 based on the settings, rather than storing them directly in gconf.
804 2007-05-10 Murray Cumming <murrayc@murrayc.com>
806 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
807 Show a more friendly error dialog now that we expect (from the tinymail
808 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
810 2007-05-10 Murray Cumming <murrayc@murrayc.com>
812 * src/maemo/modest-main-window.c: (on_account_update): Check that
813 account_name is not NULL, to prevent a crash at startup that I am
814 seeing on the N800. I do wonder why it is NULL.
816 * src/maemo/easysetup/modest-easysetup-wizard.c:
817 (create_page_user_details):
818 * src/maemo/modest-account-settings-dialog.c:
819 (create_page_user_details), (create_page_outgoing):
820 * src/maemo/modest-connection-specific-smtp-edit-window.c:
821 (modest_connection_specific_smtp_edit_window_init):
822 * src/modest-ui-actions.c:
823 (modest_ui_actions_on_password_requested):
824 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
825 might do something useful with the on-screen keyboard.
827 2007-05-10 Murray Cumming <murrayc@murrayc.com>
829 * src/maemo/modest-main-window.c: (on_account_update):
830 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
831 NULL, to avoid lots of warnings. However, it probably should not be NULL.
833 2007-05-09 Murray Cumming <murrayc@murrayc.com>
835 * src/modest-tny-account-store.c: (on_account_changed):
836 Correct the signature of this signal handler.
838 2007-05-09 Murray Cumming <murrayc@murrayc.com>
840 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
841 Show a HildonNote instead of a GtkDialog for Maemo.
843 2007-05-09 Murray Cumming <murrayc@murrayc.com>
845 * src/widgets/modest-account-view.h:
846 * src/widgets/modest-account-view.c: (on_account_changed),
847 (on_account_removed). Added a boolean flag, set/unset by
848 modest_account_view_block_conf_updates(),
849 modest_account_view_unblock_conf_updates() to prevent unnecessary
850 updates, but this is not very useful because the gconf notifications are
851 so delays (maybe only on Maemo Bora).
852 So auto-updating is turned off, and these functions do an explicit
853 update when necessary.
854 However, something else is still doing too much work when adding/removing
855 accounts, probably in another part of the application.
857 * src/maemo/modest-account-view-window.c:
858 (on_delete_button_clicked), (on_edit_button_clicked),
859 (on_new_button_clicked): Use the new functions.
861 2007-05-09 Murray Cumming <murrayc@murrayc.com>
863 * src/modest-account-mgr-helpers.c:
864 (modest_account_mgr_set_first_account_as_default):
865 Sort the list of names alphabetically-by-title, so we choose the first one
867 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
868 alphabetically by the title.
870 This fixes projects.maemo.org bug NB#56418 .
872 * src/modest-account-mgr-priv.c:
873 (_modest_account_mgr_account_from_key):
874 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
875 avoid a valgrind error, and possible random behaviour.
877 2007-05-09 Murray Cumming <murrayc@murrayc.com>
879 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
880 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
881 tinymail documentation to say that this can be expected.
882 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
883 pretty, and should not happen, but I would prefer to know when it does.
885 2007-05-09 Murray Cumming <murrayc@murrayc.com>
887 * configure.ac: When using the older hildon version, probably on Bora,
888 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
890 * src/widgets/modest-attachment-view.c:
891 (modest_attachment_view_set_part_default): Initialize variables, to fix the
894 2007-05-09 Marcus Bauer <marcusb@openismus.com>
896 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
897 Implemented the prototype. Can be tested with
898 tests/dbus_api/test_open_message:
900 2007-05-08 Murray Cumming <murrayc@murrayc.com>
902 * src/modest-tny-account-store.c:
903 (modest_tny_account_store_instance_init), (get_password):
904 * src/modest-ui-actions.c:
905 (modest_ui_actions_on_password_requested):
906 Do not store the password in gconf, because this function is called
907 for non-remembered passwords. Actually use the cached (in the hash map)
908 password instead of releasing it.
909 The password will now not be remembered if it is asked via the protected
910 password dialog, as per the UI spec.
912 2007-05-08 Murray Cumming <murrayc@murrayc.com>
915 * src/modest-account-mgr-helpers.h:
916 * src/modest-account-mgr-helpers.c:
917 Added modest_server_account_get_username_has_succeeded(),
918 modest_server_account_set_username_has_succeeded().
919 (modest_server_account_set_username),
920 Reset the has-succeeded flag if the username changes.
922 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
923 * src/maemo/modest-connection-specific-smtp-window.c:
924 (modest_connection_specific_smtp_window_save_server_accounts):
925 Use modest_server_account_set_username() instead of using
926 modest_conf_set_string() directly, so that the has-succeeded flag is always
929 * src/modest-ui-actions.c:
930 (modest_ui_actions_on_password_requested): Dim the username entry if
931 the username has ever worked, as per the UI spec.
933 2007-05-08 Murray Cumming <murrayc@murrayc.com>
935 * src/modest-tny-account-store.c: (get_password):
936 * src/modest-ui-actions.c:
937 (modest_ui_actions_on_password_requested):
938 Allow the username to be changed too, though there is more work to
939 be done on exactly how this behaves.
941 2007-05-08 Murray Cumming <murrayc@murrayc.com>
943 * src/modest-account-mgr-helpers.h:
944 * src/modest-account-mgr-helpers.c:
945 Added modest_account_mgr_get_display_name(),
946 modest_server_account_get_username(),
947 modest_server_account_set_username(),
948 modest_server_account_set_password(),
949 modest_server_account_get_hostname() functions so we do not need to
950 use the conf API directly.
952 * src/maemo/modest-main-window.c: (connect_signals):
953 Actually connect ot the ModestAccountStore::request-password signal,
954 so that we show the dialog when the password is requested by Tinymail,
955 for isntance if it is empty.
957 * src/modest-marshal.list:
958 * src/modest-tny-account-store.c:
959 (modest_tny_account_store_class_init), (get_password),
960 (modest_tny_account_store_alert):
961 * src/modest-tny-account-store.h:
962 * src/modest-ui-actions.h:
963 * src/modest-ui-actions.c:
964 (modest_ui_actions_on_password_requested):
965 Change the signal parameters, so it is obvious that we are providing
966 the non human-readable server name, and receiving both the username
967 and password, though changing of the username is not yet implemented.
968 Change the dialog UI to match the Maemo UI specifications, with #idfefing
969 for the GNOME version.
971 This should fix the projects.maemo.org bug NB#56209, though it does not
972 work on Bora, because the gconf_client_get() for the password fails
973 immediately after we save it with gconf_client_set().
975 2007-05-08 Murray Cumming <murrayc@murrayc.com>
978 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
979 caused an undefined symbol error:
980 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
982 2007-05-08 Murray Cumming <murrayc@murrayc.com>
984 * src/modest-tny-account-store.c:
985 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
986 using a GError instead of a string message, so we can translate it in
989 2007-05-08 Murray Cumming <murrayc@murrayc.com>
991 * src/maemo/modest-address-book.c:
992 (modest_address_book_check_names):
993 * src/maemo/modest-msg-view-window.c:
994 (modest_msg_view_window_clipboard_owner_change):
995 * src/modest-init.c: (modest_init_init_ui):
996 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
997 (update_folders_cb), (modest_mail_operation_update_account):
998 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
999 (modest_ui_actions_on_msg_attachment_clicked),
1000 (modest_ui_actions_on_msg_recpt_activated):
1001 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1002 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1003 (modest_msg_view_search_next):
1004 * src/widgets/modest-recpt-editor.c:
1005 (modest_recpt_editor_on_button_release_event),
1006 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1007 g_message(). At this point we should only be seeing interesting errors on
1008 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1010 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1012 (modest_wizard_dialog_force_title_update):
1013 * src/maemo/easysetup/modest-wizard-dialog.h:
1014 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1015 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1016 can update the title when appropriate. Otherwise the title is wrong if the
1017 pages are added after adding the notebook to the dialog.
1018 This must be a problem in HildonWizardDialog too.
1019 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1021 * src/maemo/easysetup/modest-easysetup-wizard.c:
1022 (create_subsequent_customsetup_pages),
1023 (create_subsequent_easysetup_pages):
1024 Call modest_wizard_dialog_force_title_update() so that the title is
1025 correct even with GTK+ < 2.10.
1026 This fixes projects.maemo.org bug NB#56145 .
1028 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1030 * src/maemo/modest-platform.c:
1031 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1032 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1035 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1037 * src/widgets/modest-window.h:
1038 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1039 and modest_window_save_state(), which invokes it.
1041 * src/widgets/modest-window-mgr.h:
1042 * src/widgets/modest-window-mgr.c:
1043 Added modest_window_mgr_save_state_for_all_windows(), which calls
1044 the save_state vfunc on all registered windows, if implemented.
1046 * src/gnome/modest-msg-edit-window.c:
1047 * src/gnome/modest-msg-view-window.c:
1048 * src/maemo/modest-msg-edit-window.c:
1049 * src/maemo/modest-msg-view-window.c:
1050 * src/maemo/modest-main-window.c:
1051 Specify the existing save_settings functions as implementations of
1052 ModestWindow::save_state_func().
1054 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1055 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1056 enabling hibernation, for instance.
1058 We may need to do the same thing for restoring settings.
1061 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1063 * src/widgets/modest-window-mgr.c:
1064 * src/widgets/modest-window-mgr.h:
1065 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1066 modest_window_mgr_get_hibernation_is_prevented().
1068 * src/maemo/modest-main-window.c:
1069 (on_hildon_program_is_topmost_notify): Prevent hibernation
1070 (possible when the application goes to the background in the WM),
1071 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1073 * src/maemo/easysetup/modest-easysetup-wizard.c:
1074 (modest_easysetup_wizard_dialog_init):
1075 * src/maemo/modest-account-settings-dialog.c:
1076 (modest_account_settings_dialog_init):
1077 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1078 (modest_connection_specific_smtp_edit_window_init):
1079 * src/maemo/modest-connection-specific-smtp-window.c:
1080 (modest_connection_specific_smtp_window_init):
1081 * src/maemo/modest-signature-editor-dialog.c:
1082 (modest_signature_editor_dialog_init):
1083 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1084 prevent hibernation while any of these account settings dialogs are open.
1086 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1088 * src/maemo/Makefile.am:
1089 * src/maemo/modest-osso-state-saving.c:
1090 * src/maemo/modest-osso-state-saving.h: Added
1091 modest_osso_load_state() and modest_osso_save_state() though they do
1092 nothing now. They should iterate through all the open windows and load/save
1094 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1095 save state when closing.
1097 * src/maemo/modest-main-window.c:
1098 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1099 Add a notification handler for the HildonProgram::is-topmost property,
1100 so we can allow hibernation when the application goes into the background.
1101 But we still need to detect when the accounts setup windows are open so
1102 we can stop hibernation when they are open.
1103 To do this, I also added the main window the HildonProgram. This might have
1104 other side-effects/benefits, and should maybe be done for other windows.
1106 * src/maemo/modest-osso-autosave-callbacks.h:
1107 * src/maemo/modest-osso-autosave-callbacks.c:
1108 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1109 though it does not do anything yet, and we might never need this to do
1110 anything. For instance, we already save drafts.
1112 * src/maemo/modest-platform.c: (modest_platform_init):
1113 Specify the libosso auto-save callback.
1115 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1117 * src/maemo/modest-platform.c:
1118 (modest_platform_set_update_interval):
1119 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1120 aparently stays valid between application instances, so we can use this
1121 to remove and reset it later. According to a maemo-developers email from
1124 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1126 * configure.ac: Depend on libalarm for Maemo.
1128 * src/dbus_api/modest-dbus-api.h:
1129 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1130 (on_send_receive), (modest_dbus_req_handler):
1131 Handle a SEND_RECEIVE D-Bus method.
1133 * libmodest-dbus-client/libmodest-dbus-client.c:
1134 (libmodest_dbus_client_send_and_receive):
1135 * libmodest-dbus-client/libmodest-dbus-client.h:
1136 Add C convenience functions for calling the new D-Bus method.
1138 * src/modest-platform.h:
1139 * src/gnome/modest-platform.c:
1140 * src/maemo/modest-platform.c:
1141 Added modest_platform_set_update_interval(), which uses the
1142 alarmd API on Maemo.
1143 (modest_platform_init),
1144 Call modest_platform_set_update_interval(), using a hard-coded
1145 interval for now (until the global settings dialog is implemented),
1146 though I am not sure that this makes sense yet.
1148 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1150 * src/dbus_api/modest-dbus-callbacks.c:
1151 (modest_osso_cb_hw_state_handler):
1152 * src/dbus_api/modest-dbus-callbacks.h:
1153 * src/maemo/modest-platform.c: (modest_platform_init):
1154 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1155 in case this has some effect on the ability for Maemo to ping the
1158 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1160 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1161 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1162 warning. It is probably a logic error, but I need to fix the build.
1164 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1166 * src/modest-account-mgr.h:
1167 * src/modest-account-mgr.c:
1168 (modest_account_mgr_account_names): Add a gboolean enabled_only
1169 parameter, so we can get lists of onlt the enabled accounts.
1171 (modest_account_mgr_add_account),,
1172 (modest_account_mgr_account_with_display_name_exists):
1173 * src/maemo/modest-msg-edit-window.c: (get_transports):
1174 * src/modest-account-mgr-helpers.c:
1175 (modest_account_mgr_set_first_account_as_default):
1176 * src/modest-init.c: (init_default_account_maybe):
1177 * src/modest-tny-account-store.c: (get_accounts):
1178 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1179 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1180 * tests/check_account-mgr.c: (START_TEST):
1181 Provide the extra parameter, as appropriate.
1183 * src/widgets/modest-account-view.c: (update_account_view):
1184 Do not show disabled accounts (meaning that there is no way to
1185 enable/disable accounts in the UI (the feature is not in our UI
1186 specification), so we can use this internally only to mark unfinished
1187 or temporary account data.
1189 * src/maemo/easysetup/modest-easysetup-wizard.c:
1190 (create_account): Add boolean enable parameter, so we can specify FALSE
1191 to create the temporary account.
1192 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1193 (on_before_next): When finishing, when there is a temporary account, just
1195 Also, use a timeout to delay the showing of the dialog until gconf is likely
1196 to return correct information, due to a maemo gconf bug that is fixed in
1197 osso 1.1, but not yet in Bora.
1198 However, the dialog stays on screen after it is destroyed.
1200 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1201 for invalid data when cancelling. Use a hildon note instead of a dialog
1202 to complain about invalid data. Do not show the account-saved note if the
1203 account is disabled (a temporary account that will not really be saved for use
1206 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1208 * src/modest-account-mgr-helpers.h:
1209 * src/modest-account-mgr-helpers.c:
1210 Added modest_account_mgr_unset_default_account(),
1211 Added modest_account_mgr_set_first_account_as_default().
1213 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1214 If it was the default account, unset the default account name.
1216 * src/maemo/modest-account-view-window.c:
1217 (on_delete_button_clicked): If it was the default account,
1218 set the first remaining account as the default instead.
1220 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1221 a NULL account or a NULL default account, to prevent a crash. This should
1222 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1225 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1227 * src/widgets/modest-recpt-editor.c:
1228 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1229 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1230 TODO comment for this. This fixes the build.
1232 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1233 be the best place for it. This will in future update all auto-update accounts,
1234 rather than just the current/default account, when that gconf key exists.
1235 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1236 if there are no accounts, before calling do_send_receive().
1237 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1239 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1240 * src/maemo/modest-main-window-ui.h:
1241 * src/maemo/modest-main-window.c: (on_connection_changed),
1242 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1243 directly, becaue the signal handler does more.
1245 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1247 * src/modest-account-mgr-helpers.c:
1248 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1249 for the case that the account does not exist.
1251 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1252 (equivalent to the modest account name) rather than the tinymail account name
1253 (equivalent to the modest account title - human readable) to get the account data.
1254 Check for null account data to prevent the crash, and add a TODO comment saying that
1255 this needs fixing because it is using the server account name instead of the account name.
1257 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1259 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1260 * src/maemo/modest-account-settings-dialog.c: (show_error),
1262 Use hildon_note_new_information() for informative and error messages,
1263 which seems to be expected for Maemo applications (no documentation that I know of
1264 says this). I am surprised that there is no distinction between info and error
1267 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1269 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1270 it is easy to find where this is used.
1272 * src/maemo/easysetup/modest-easysetup-wizard.c:
1273 (create_page_welcome), (create_page_account_details),
1274 (create_page_user_details), (create_page_complete_easysetup),
1275 (create_page_custom_incoming), (create_page_custom_outgoing),
1276 (create_page_complete_custom):
1277 * src/maemo/modest-account-settings-dialog.c:
1278 (create_page_account_details), (create_page_user_details),
1279 (create_page_incoming), (create_page_outgoing):
1280 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1281 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1282 (modest_connection_specific_smtp_edit_window_init):
1283 * src/maemo/modest-connection-specific-smtp-window.c:
1284 (modest_connection_specific_smtp_window_init):
1285 * src/maemo/modest-signature-editor-dialog.c:
1286 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1287 and scrolling policy as per the Email Application Layout Guide, if I have
1290 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1292 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1293 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1294 which were empty, because these vfuncs have been removed from TnyAccountStore.
1295 This fixes the build.
1297 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1299 * src/maemo/modest-main-window.c:
1300 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1301 showing/hiding it. Added TODO because it probably should not be NULL.
1302 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1303 because unnecessary g_warnings() make degugging difficult.
1305 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1307 * src/maemo/modest-msg-edit-window.c:
1308 (modest_msg_edit_window_select_color),
1309 (modest_msg_edit_window_select_background_color): 2 const corrections and
1310 moving 2 #endifs before closing brackets, to fix the build.
1312 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1314 * src/maemo/easysetup/modest-easysetup-wizard.h:
1315 * src/maemo/easysetup/modest-easysetup-wizard.c:
1316 (modest_easysetup_wizard_dialog_finalize),
1317 (on_button_edit_advanced_settings), (create_page_complete_custom),
1318 (on_response), (create_account):
1319 Implement the Advanced Settings edit button, by saving the account information,
1320 for the Advanded Settings dialog to use directly from gconf, and removing it
1321 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1322 Bug #5533 in the projects.maemo.org bugzilla.
1324 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1326 * src/maemo/modest-msg-view-window.c:
1327 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1328 when opening a message window.
1330 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1332 * src/maemo/easysetup/modest-easysetup-wizard.c:
1333 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1336 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1337 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1338 gconf settings. I probably added more checks than necessary, but that is safer.
1340 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1341 variable to fix the build, but this seems to be used when it is still NULL.
1343 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1345 * src/modest-platform.h:
1346 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1347 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1348 * src/modest-main.c: Implement this function so we can avoid using
1349 maemo-specific API from cross-platform code.
1351 * src/modest-tny-account-store.c:
1352 (get_smtp_specific_transport_account_for_open_connection):
1353 * src/modest-ui-actions.c: (check_for_connection),
1354 (modest_ui_actions_on_item_not_found):
1355 Use modest_platform_connect_and_wait() and put #idefs around other
1356 maemo-specific code, because only maemo currently has a way to
1357 identify connection names.
1359 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1361 * src/modest-tny-account-store.h:
1362 * src/modest-tny-account-store.c:
1363 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1364 the connection-specific SMTP server settings in the configuration.
1366 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1368 * src/maemo/modest-main-window.c: (on_connection_changed),
1370 * src/modest-main.c: (main), (start_ui), (send_mail):
1371 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1372 that is what is intended.
1374 * src/modest-ui-actions.c: (action_send), (action_receive),
1375 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1376 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1377 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1378 SMTP server is used when it is specified.
1380 (modest_ui_actions_on_send_receive):
1381 Check that a connection is open before proceeding.
1382 Receive and then send, instead of vice-versa, as per the specification.
1384 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1386 * src/modest-mail-operation.c:
1387 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1388 though I guess it should be something other than NULL.
1390 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1392 * src/maemo/easysetup/modest-easysetup-wizard.c:
1393 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1394 combo twice, to avoid an g_warning and to make it visible again.
1395 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1396 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1397 (already intended) dereference when detaching, because we then recreate the menu.
1398 But I am not sure why the warning was happening, and it is possible that this is a memory
1401 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1403 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1404 and uri_parse_mailto() utility functions.
1405 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1407 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1409 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1411 * src/dbus_api/modest-dbus-api.h:
1412 * src/dbus_api/modest-dbus-callbacks.c:
1413 Use an idle callback to execute the modest code in the application's own thread.
1414 Remove the helloworld example method.
1415 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1416 parsed, and the open-message method is not implemented because this is not yet implemented in
1418 * libmodest-dbus-client/libmodest-dbus-client.c:
1419 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1420 (libmodest_dbus_client_open_message):
1421 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1423 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1424 body without crashing.
1426 * tests/dbus_api/Makefile.am:
1427 * tests/dbus_api/test_mail_to.c:
1428 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1430 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1432 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1433 Added file to fix the build. Sorry.
1435 * src/dbus_api/Makefile.am:
1436 * src/dbus_api/modest-dbus-api.h:
1437 * src/dbus_api/modest-dbus-callbacks.h:
1438 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1439 (modest_dbus_req_handler):
1440 Put constants in a separate header so it can be reused by the
1441 client library, without duplication
1443 * libmodest-dbus-client/Makefile.am:
1444 * libmodest-dbus-client/libmodest-dbus-client.c:
1445 (libmodest_dbus_client_call_helloworld),
1446 (libmodfest_dbus_client_send_mail),
1447 (libmodfest_dbus_client_mailto),
1448 (libmodfest_dbus_client_open_message):
1449 * libmodest-dbus-client/libmodest-dbus-client.h:
1450 (Partly) Implement a send_mail D-Bus method.
1452 * tests/dbus_api/Makefile.am:
1453 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1454 the send_email D-Bus method.
1456 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1460 * libmodest-dbus-client/Makefile.am:
1461 * libmodest-dbus-client/libmodest-dbus-client.c:
1462 * libmodest-dbus-client/libmodest-dbus-client.h:
1463 * tests/dbus_api/Makefile.am:
1464 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1465 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1467 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1469 * src/maemo/easysetup/modest-easysetup-wizard.c:
1470 (create_page_account_details):
1471 * src/maemo/modest-account-settings-dialog.c:
1472 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1473 widgets, because this might not be the default in future versions of the Maemo GTK+.
1474 However, I can not not get capitalization to work even in a simple test case.
1476 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1478 * src/maemo/easysetup/modest-easysetup-wizard.c:
1479 (create_page_custom_incoming), (create_page_custom_outgoing):
1480 * src/maemo/modest-account-settings-dialog.c:
1481 (create_page_account_details), (create_page_incoming),
1482 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1483 instead of using gtk_check_button_with_label(), so they are aligned like the other
1484 widgets, as per the UI spec.
1486 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1488 * src/maemo/easysetup/modest-easysetup-wizard.c:
1489 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1490 * src/widgets/modest-validating-entry.c:
1491 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1492 Modest prefix instead of an EasySetup prefix.
1494 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1496 * src/widgets/modest-validating-entry.h:
1497 * src/widgets/modest-validating-entry.c: (on_insert_text),
1498 Added easysetup_validating_entry_set_max_func(), used to set a callback
1499 to call when the max number of characters is reached. GtkEntry has a max-length
1500 already but is silent about it.
1502 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1503 (create_page_account_details), (create_page_user_details),
1505 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1506 (create_page_account_details), (create_page_user_details),
1507 (create_page_outgoing):
1508 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1509 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1510 the UI spec, when the user tries to enter more than the max number of characters.
1512 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1514 * src/maemo/easysetup/modest-easysetup-wizard.c:
1515 (create_page_user_details), (create_page_custom_incoming),
1516 (create_page_custom_outgoing):
1517 * src/maemo/modest-account-settings-dialog.c:
1518 (create_page_user_details), (create_page_incoming),
1519 (create_page_outgoing):
1520 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1521 (modest_connection_specific_smtp_edit_window_init):
1522 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1523 not appropriate. Bad Maemo-specific defaults!.
1525 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1527 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1528 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1529 (modest_signature_editor_dialog_set_settings):
1530 Disable the label and textview when the checkbox is disabled, and use the
1531 specified (UI spec) default signature text.
1533 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1535 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1536 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1538 * src/modest-defs.h:
1539 * src/modest-account-mgr-helpers.h:
1540 * src/modest-account-mgr-helpers.c:
1541 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1543 * src/maemo/Makefile.am:
1544 * src/maemo/modest-signature-editor-dialog.c:
1545 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1548 * src/maemo/modest-account-settings-dialog.h:
1549 * src/maemo/modest-account-settings-dialog.c:
1550 (modest_account_settings_dialog_finalize), (on_button_signature),
1551 (save_configuration): Use the new dialog when the Edit button is pressed, and
1552 save the changes if necessary, as per the UI spec.
1554 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1556 * src/maemo/Makefile.am:
1557 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1558 based on maemo-develoers email from Dirk.
1560 * src/maemo/easysetup/modest-easysetup-wizard.c:
1561 (create_page_welcome), (create_page_account_details),
1562 (create_page_user_details), (create_page_complete_easysetup),
1563 (create_page_custom_incoming), (create_page_custom_outgoing),
1564 (create_page_complete_custom),
1565 (modest_easysetup_wizard_dialog_init):
1566 * src/maemo/modest-account-settings-dialog.c:
1567 (create_page_account_details), (create_page_user_details),
1568 (create_page_incoming), (create_page_outgoing),
1569 (modest_account_settings_dialog_init):
1570 * src/maemo/modest-connection-specific-smtp-window.c:
1571 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1573 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1575 * src/maemo/easysetup/modest-easysetup-wizard.c:
1576 (create_page_account_details), (create_page_custom_outgoing),
1577 (create_page_complete_custom):
1578 * src/maemo/modest-account-settings-dialog.c:
1579 (create_page_user_details), (create_page_incoming),
1580 (create_page_outgoing):
1581 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1582 (modest_connection_specific_smtp_edit_window_init):
1583 Use the correct (UI spec) port min/max, and use horizontal separators,
1586 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1588 * src/maemo/easysetup/modest-easysetup-wizard.c:
1589 (set_default_custom_servernames):
1590 * src/maemo/modest-account-settings-dialog.c:
1591 (create_page_incoming), (on_combo_outgoing_security_changed),
1592 (on_combo_incoming_security_changed), (create_page_outgoing),
1593 (modest_account_settings_dialog_set_account_name),
1594 (save_configuration):
1595 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1596 (on_combo_security_changed),
1597 (modest_connection_specific_smtp_edit_window_init),
1598 (modest_connection_specific_smtp_edit_window_set_connection),
1599 (modest_connection_specific_smtp_edit_window_get_settings):
1600 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1603 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1606 * src/maemo/easysetup/modest-easysetup-wizard.c:
1607 (create_page_custom_outgoing), (create_page_complete_custom):
1608 * src/maemo/modest-account-settings-dialog.c:
1609 (create_page_user_details), (create_page_outgoing):
1610 * src/maemo/modest-account-view-window.c: (button_box_new):
1611 Use changed logical IDs as per the most recent UI spec:
1612 mcen_bd_emailsetup_edit -> mcen_bd_edit
1613 mcen_bd_emailsetup_delete -> mcen_bd_delete
1614 mcen_bd_emailsetup_close -> mcen_bd_close
1616 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1620 * src/dbus_api/Makefile.am:
1621 * src/dbus_api/modest-dbus-callbacks.c:
1622 * src/dbus_api/modest-dbus-callbacks.h:
1623 * src/maemo/modest-platform.c: (modest_platform_init):
1624 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1626 * tests/Makefile.am:
1627 * tests/dbus_api/Makefile.am:
1628 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1630 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1632 * src/maemo/modest-account-settings-dialog.c:
1633 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1634 Removed unnecessary includes.
1636 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1638 * src/maemo/easysetup/modest-easysetup-wizard.c:
1639 * src/maemo/modest-account-settings-dialog.c:
1640 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1641 * src/widgets/Makefile.am:
1642 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1643 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1644 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1645 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1646 * src/widgets/modest-secureauth-combo-box.c:
1647 * src/widgets/modest-secureauth-combo-box.h:
1648 * src/widgets/modest-serversecurity-combo-box.c:
1649 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1650 made the GObject names more consistent with the rest of the Modest code.
1652 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1654 * src/maemo/easysetup/Makefile.am:
1655 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1656 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1657 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1658 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1659 * src/maemo/easysetup/modest-easysetup-wizard.c:
1660 * src/maemo/easysetup/modest-validating-entry.c:
1661 * src/maemo/easysetup/modest-validating-entry.h:
1662 * src/maemo/modest-account-settings-dialog.c:
1663 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1664 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1665 widgets/ because they are used outside of easysetup too. After checking in,
1666 svn will allow me to rename them too.
1668 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1670 * src/gnome/modest-msg-edit-window.c:
1671 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1672 linker error, to fix the build on the GNOME platform.
1673 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1674 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1675 ifdefed out to avoid a warning.
1677 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1679 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1680 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1681 some alternative for GTK+ 2.6.
1683 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1685 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1687 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1688 specified for EmailAccountsDialog in UI spec.
1690 * src/maemo/easysetup/modest-easysetup-wizard.c:
1691 * src/maemo/easysetup/modest-easysetup-wizard.h:
1692 * src/maemo/modest-account-settings-dialog.c:
1693 * src/maemo/modest-account-settings-dialog.h:
1694 Reuse a member window widget for the connection-specific SMTP server accounts,
1695 so we can tell it to create/save the accounts only if we actually save changes.
1697 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1698 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1699 (modest_connection_specific_smtp_edit_window_get_settings):
1700 Return a struct instance for temporarily remembering the entered data.
1702 * src/maemo/modest-connection-specific-smtp-window.h:
1703 * src/maemo/modest-connection-specific-smtp-window.c:
1704 (modest_connection_specific_smtp_window_finalize),
1705 (modest_connection_specific_smtp_window_fill_with_connections),
1707 (modest_connection_specific_smtp_window_save_server_accounts),
1708 (update_model_server_names): Do not actually save data until asked,
1709 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1711 (on_selection_changed),
1712 (modest_connection_specific_smtp_window_init): Disable the edit
1713 button when nothing is selected.
1715 * src/modest-account-mgr-helpers.c:
1716 * src/modest-account-mgr-helpers.h:
1717 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1720 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1722 * src/modest-account-mgr-helpers.h:
1723 * src/modest-account-mgr-helpers.c:
1724 (modest_account_mgr_get_unused_account_name),
1725 (modest_account_mgr_get_unused_account_display_name): Added these
1726 utility functions, to avoid code duplication.
1728 * src/maemo/easysetup/modest-easysetup-wizard.c:
1729 (create_page_account_details), (create_account):
1730 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1731 (on_combo_security_changed),
1732 (modest_connection_specific_smtp_edit_window_init),
1733 (modest_connection_specific_smtp_edit_window_save_settings):
1734 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1735 * src/maemo/modest-connection-specific-smtp-window.c:
1736 (modest_connection_specific_smtp_window_finalize),
1737 (modest_connection_specific_smtp_window_fill_with_connections),
1738 (on_button_edit), (modest_connection_specific_smtp_window_init):
1739 * src/maemo/modest-connection-specific-smtp-window.h:
1740 Implementing saving of connection-specific server accounts.
1742 But I need to refactor this so we can save the data for each
1743 possible connection-specific account and only actually create the server accounts
1744 when the easysetup finished, or the OK button is pressed on the account settings
1747 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1749 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1750 (on_combo_security_changed):
1751 (modest_connection_specific_smtp_edit_window_init):
1752 Auto-fill the port number as in the account settings.
1754 (modest_connection_specific_smtp_edit_window_set_connection):
1755 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1756 * src/maemo/modest-connection-specific-smtp-window.c:
1757 (fill_with_connections), (on_button_edit),
1758 (modest_connection_specific_smtp_window_init):
1759 Turn the edit window into a dialog to simplify the code, and
1760 set a WM hint as in a GtkDialog, because only a popup can be on top of
1761 another window in Maemo, and popups usually have no WM decoration.
1763 * src/modest-defs.h:
1764 * src/modest-account-mgr-helpers.c:
1765 (modest_account_mgr_set_connection_specific_smtp),
1766 (modest_account_mgr_remove_connection_specific_smtp),
1767 (modest_account_mgr_get_connection_specific_smtp):
1768 * src/modest-account-mgr-helpers.h: Some functions to write the
1769 connection-specific SMTP server information. Not yet used.
1772 * src/widgets/modest-folder-view.c: (text_cell_data):
1773 Fix a warning about an uninitialized variable.
1774 (on_configuration_key_changed): Put an #ifdef around the use
1775 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1777 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1779 * src/maemo/modest-account-settings-dialog.h:
1780 * src/maemo/modest-account-settings-dialog.c:
1781 Added connect_for_modified() utility function to mark the new modified boolean.
1783 (create_page_account_details), (create_page_user_details),
1784 (create_page_incoming), (create_page_outgoing), (on_response),
1785 (modest_account_settings_dialog_init),
1786 (modest_account_settings_dialog_set_account_name):
1787 Only warn about unsaved changes when there are actually unsaved changes.
1789 * src/modest-account-mgr-helpers.c:
1790 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1791 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1792 to get the data from there in future.
1794 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1796 * src/modest-defs.h:
1798 * src/modest-account-mgr-helpers.h:
1799 * src/modest-account-mgr-helpers.c:
1800 Store the security account setting in a single conf key instead of using
1801 the options list, so that the list is left for just the to-be-removed camel hack,
1802 and because gconf_client_set_list() is failing for some reason.
1804 * src/modest-account-mgr.c:
1805 (modest_account_mgr_add_server_account):
1806 * src/maemo/modest-account-settings-dialog.c:
1807 (modest_account_settings_dialog_set_account_name),
1808 (save_configuration): Use the renamed functions.
1811 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1813 * src/widgets/Makefile.am:
1814 * src/widgets/modest-limit-retrieve-combo-box.c:
1815 * src/widgets/modest-limit-retrieve-combo-box.h:
1816 * src/widgets/modest-retrieve-combo-box.c:
1817 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1818 the account settings dialog.
1820 * src/modest-defs.h:
1821 * src/modest-account-mgr-helpers.h:
1822 * src/modest-account-mgr-helpers.c:
1823 (modest_server_account_get_option_secure_auth),
1824 (modest_server_account_set_option_secure_auth):
1825 * src/modest-account-mgr.c:
1826 (modest_account_mgr_add_server_account):
1827 Use the existing AUTH_MECH conf key for the secure-auth setting,
1828 instead of putting it in the list options, because this was actually used already.
1830 * src/maemo/modest-account-settings-dialog.c:
1831 (create_page_account_details),
1832 (modest_account_settings_dialog_set_account_name),
1833 (save_configuration):
1834 * src/maemo/modest-account-settings-dialog.h:
1835 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1836 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1838 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1840 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1841 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1842 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1844 * src/modest-defs.h:
1845 * src/maemo/modest-account-settings-dialog.c:
1846 (create_page_incoming), (on_combo_outgoing_security_changed),
1847 (on_combo_incoming_security_changed), (create_page_outgoing),
1848 (modest_account_settings_dialog_set_account_name),
1849 (save_configuration): Load/Save the port number, and change it when the
1850 security combo changes, to suitable defaults.
1852 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1854 * src/modest-account-mgr.c:
1855 (modest_account_mgr_add_server_account): Set the security and secure-auth
1856 options, and add a comment saying that the other camel-specific options should be
1859 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1861 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1863 * src/modest-tny-account-store.c: (account_list_free),
1864 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1865 cursor->data after unreffing it. But there is some strange stuff there so it might not be
1868 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1870 * src/modest-protocol-info.c:
1871 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1872 is required by our UI spec. Maybe something in our implementation will use this eventually.
1873 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1874 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1875 instead of the previous 0 placeholder.
1877 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1878 secure-auth settings.
1879 * src/modest-account-mgr-helpers.h:
1880 * src/modest-account-mgr-helpers.c:
1881 (modest_server_account_data_get_option_secure_auth),
1882 (modest_server_account_set_option_secure_auth),
1883 (modest_server_account_data_get_option_security),
1884 (modest_server_account_set_option_security): Added this API for getting and setting the security
1885 and secure-auth settings.
1887 * src/maemo/modest-account-settings-dialog.h:
1888 * src/maemo/modest-account-settings-dialog.c:
1889 (modest_account_settings_dialog_finalize), (check_data),
1890 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1891 about changing titles.
1892 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1893 (save_configuration): Save the security and secure-auth settings.
1895 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1896 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1898 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1900 * src/modest-defs.h:
1901 * src/modest-account-mgr.c:
1902 (modest_account_mgr_add_server_account):
1903 Added and used defines for the options key and value pair strings,
1904 that are used so far, though they do not seem to correspond to anything in our
1905 UI specs or ModestProtocol enum.
1907 * src/modest-account-mgr-helpers.h:
1908 * src/modest-account-mgr-helpers.c:
1909 (compare_option_strings_for_name),
1910 (modest_server_account_data_get_option_value),
1911 (modest_server_account_data_get_option_bool),
1912 (modest_account_mgr_get_server_account_option):
1913 Added helper functions for parsing the options GSList.
1915 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1917 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1918 display name is based on the supplied account name.
1919 * src/modest-account-mgr.c:
1920 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1921 with an inefficient, but good-enough, implementation.
1923 * src/maemo/easysetup/modest-easysetup-wizard.c:
1924 (create_page_account_details), (on_before_next), (create_account):
1925 Check for existing display names rather than (non-user-visible) account names, and just
1926 create and set a unique account name at the end.
1928 * src/maemo/modest-account-settings-dialog.c:
1929 (modest_account_settings_dialog_init),
1930 (modest_account_settings_dialog_set_account_name),
1931 (create_page_incoming): Show the display name, instead of the account name.
1932 (on_response): Do some (not all) extra checks, as in the UI spec.
1933 (save_configuration): Save the display name if it was changed.
1935 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1937 * po/en_GB.po: Added needed logical ID and translation.
1938 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1939 (init_view): Made the is-default column clicking work.
1941 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1944 * src/maemo/easysetup/Makefile.am:
1945 * src/maemo/easysetup/modest-easysetup-wizard.c:
1946 (modest_easysetup_wizard_dialog_init):
1947 * src/maemo/easysetup/provider-data-test.keyfile:
1948 * src/maemo/easysetup/provider-data.keyfile:
1949 Moved the provider data file to the new modest-providers-data package and used it from there.
1951 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1953 * src/modest-local-folder-info.c:
1954 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1955 N_() was already used on the static strings, but this just marks it for translation without
1956 using the translation.
1958 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1960 * src/maemo/modest-account-settings-dialog.c:
1961 (create_page_incoming),
1962 (modest_account_settings_dialog_set_account_name):
1963 Added comments about the need for new API in ModestAccountMgr to handle the authentication
1964 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1965 I will do this if nobody else gets there first.
1967 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1969 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1970 Saved much of the incoming and outgoing data too, though I cannot yet see how to
1971 save the security stuff.
1973 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1975 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1976 Set the email address and user fullname, which I now see must be
1979 * src/maemo/modest-account-settings-dialog.h:
1980 * src/maemo/modest-account-settings-dialog.c:
1982 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1983 leave-on-server and authentication.
1984 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1987 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1990 * src/maemo/modest-account-settings-dialog.c:
1991 * src/maemo/modest-account-settings-dialog.h:
1992 Most (but not all) of the widgets are now present as specified by the UI spec.
1993 No changes are yet saved, and some details are not properly shown yet.
1995 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1997 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1999 * src/maemo/Makefile.am:
2000 * src/maemo/modest-account-settings-dialog.c:
2001 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2002 an existing account. Doesn't do much yet.
2004 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2005 Open the accounts settings dialog when Edit is clicked.
2007 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2009 * src/maemo/easysetup/Makefile.am:
2010 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2012 * src/maemo/easysetup/modest-easysetup-wizard.c:
2013 (modest_easysetup_wizard_dialog_init):
2014 Try to get the source directory from the build system,
2015 instead of hard-coding "./" into the source code, when opening our local
2016 copies of the configuration files.
2017 But this still fails when opening the wizard from the Accounts window,
2018 maybe because the working directory seems to change at runtime.
2019 So the wizard will fail the second time unless you copy the files into their
2020 proper locations - see the stdout warnings for the paths.
2022 (create_page_account_details),(on_before_next):
2023 Check for existing non-server accounts instead of server accounts,
2024 so the default account name is useful again, and to prevent trying to
2027 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2028 Show the wizard when New is clicked.
2030 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2031 (init_view): Show the column headers, and show the columns that are
2032 specified in the UI specs. However, something in Maemo's GTK+ prevents
2033 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2034 change the default account. This is despite unsetting the special properties.
2036 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2038 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2039 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2040 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2041 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2042 to make that clearer.
2043 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2045 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2047 * src/maemo/modest-account-view-window.c:
2048 (modest_account_view_window_init),
2049 (modest_account_view_window_new):
2050 Use the same buttons as specified in the
2051 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2052 the existing widgets, which never had a chance of working.
2053 Put the ModestAccountView treeview in a scrolled window.
2054 Do not repeat the initialization in both _init() and _new().
2056 * src/widgets/modest-account-view.c: (update_account_view):
2057 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2058 this widget and window shows no accounts.
2060 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2062 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2064 * src/maemo/easysetup/modest-easysetup-wizard.c:
2065 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2066 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2067 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2070 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2071 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2072 accounts exist yet, as in the UI spec.
2074 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2076 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2078 * src/maemo/Makefile.am:
2079 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2080 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2081 New window for editing connection-specific smtp details.
2082 Not fully implemented.
2084 * src/maemo/modest-connection-specific-smtp-window.c:
2085 (modest_connection_specific_smtp_window_finalize) :
2086 unref the tree model.
2087 (on_button_edit): Show the edit window.
2089 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2091 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2094 * src/maemo/Makefile.am:
2095 * src/maemo/modest-connection-specific-smtp-window.c:
2096 * src/maemo/modest-connection-specific-smtp-window.h:
2097 New window for showing the list of connections, for connection-specific
2098 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2099 * src/maemo/easysetup/modest-easysetup-wizard.c:
2100 (create_page_custom_outgoing): Show the new window when the button is clicked.
2102 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2104 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2105 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2106 * src/maemo/modest-msg-edit-window.c:
2107 (modest_msg_edit_window_insert_image):
2108 * src/modest-conf.c: (modest_conf_key_escape):
2109 * src/modest-mail-operation.c:
2110 (modest_mail_operation_send_new_mail):
2111 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2112 (modest_ui_actions_on_new_account):
2113 * src/widgets/modest-attachment-view.c: (update_filename_request):
2114 * src/widgets/modest-mail-header-view.c:
2115 Corrected warnings that were breaking the build, by commenting out unused variables,
2116 and a function, and by including a header.
2118 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2120 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2121 so we can #ifdef around platform-specific code when necessary.
2122 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2123 to allow this to build for the GNOME platform too.
2125 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2127 * src/maemo/easysetup/modest-easysetup-wizard.c:
2128 Added util_increment_name() and used it in create_page_account_details()
2129 to make sure that the default account name is always a new name.
2131 (modest_easysetup_wizard_dialog_init),
2132 (set_default_custom_servernames): Some minor memory management fixes.
2134 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2138 * src/modest-runtime.c: (init_i18n): Restored the translation
2139 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2140 are defined in config.h, and the translations are installed.
2142 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2143 is defined for translation.
2145 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2147 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2149 * src/maemo/easysetup/modest-easysetup-wizard.c:
2150 (modest_easysetup_wizard_dialog_init):
2151 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2152 Use realistic paths (though they should use $prefix generically) to the
2153 mcc_mapping and provider-data.keyfile files which might work when they
2154 are installed by the future version of the operator-wizard package,
2155 and then fallback to paths in our source code, with an explanatory
2158 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2162 * src/maemo/Makefile.am:
2163 * src/maemo/easysetup/: Added files from the previously-exernal
2164 osso-modest-easysetup.
2165 * src/maemo/modest-main-window-ui.h:
2166 * src/modest-ui-actions.c:
2167 * src/modest-ui-actions.h:
2168 Added modest_ui_actions_on_new_account() as a signal handler for the
2169 New Account menu item. It shows the easysetup wizard.
2170 * po/en_GB.po: Added additional needed logical IDs and translations.
2172 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2173 Apparently ChangeLog is not used for some vague Nokia legal reasons.