1 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
3 * src/maemo/modest-maemo-utils.c:
4 (modest_maemo_utils_get_supported_secure_authentication_methods):
5 Added label to dialog instead of unreadable title
7 * src/maemo/modest-main-window.c: (sync_accounts_cb),
8 (modest_main_window_new):
9 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
12 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
13 * src/modest-account-mgr.h:
14 Added method to avoid code duplication
16 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
17 (modest_ui_actions_on_send_receive):
18 Use modest_account_mgr_has_accounts
20 2007-06-11 Murray Cumming <murrayc@murrayc.com>
22 * src/maemo/easysetup/modest-presets.c:
23 (modest_presets_get_info_server_security): Do not report secure auth
25 * src/modest-protocol-info.c: Use the defines for the gconf key names
26 for secure authentication. This was not working because we were writing
27 Password and reading password, and the check was case sensitive.
28 With this, gmail now works for receiving and sending when created via
31 2007-06-11 Murray Cumming <murrayc@murrayc.com>
33 * src/maemo/easysetup/modest-presets.c:
34 (modest_presets_get_info_server_security): Correct the key name for
35 SecureSmtp, because it seems to be case-sensitive.
36 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
37 Do not try to get the 0th notebook page if there are 0 pages, to
40 2007-06-11 Murray Cumming <murrayc@murrayc.com>
42 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
43 Prevent use of the new notification feature for now, because it currently
44 shows one dialog for each new email, which is annoying.
46 2007-06-11 Murray Cumming <murrayc@murrayc.com>
48 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
49 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
50 when no country was selected, so that we show the global ones.
51 * src/maemo/easysetup/modest-presets.c:
52 (modest_presets_get_providers): Return only the global providers, not
53 all providers when mmc=0 was requested.
55 2007-06-11 Murray Cumming <murrayc@murrayc.com>
57 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
58 (easysetup_provider_combo_box_fill): Remove debug code that showed the
59 provider ID in the combo.
61 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
62 Do not show the page numbers, because it would be confusing when we add
63 the 2 extra pages for the custom setup, when the user chooses the "Other"
64 provider. This fixes projects.maemo.org bug NB#59028
66 * src/modest-init.c: (modest_init_init_core),
67 (modest_init_local_folders):
69 * src/modest-tny-account.c:
70 (modest_tny_account_new_for_local_folders): Do not create default folders
71 for the memory card. This should fix projects.maemo.org bug NB#59328.
73 2007-06-11 Murray Cumming <murrayc@murrayc.com>
75 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
76 Free the changed_conf_keys string items. They are already freed in the
77 idle handler if that runs first.
79 2007-06-11 Murray Cumming <murrayc@murrayc.com>
81 * src/modest-ui-actions.c:
82 (modest_ui_actions_on_password_requested): Check that the server name
83 is not NULL, because I just saw a password dialog with (null) as the
86 * src/modest-tny-folder.[h|c]: Added
87 modest_tny_folder_is_memory_card_folder().
88 * src/modest-ui-dimming-rules.c:
89 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
90 menu item for memory cards, as per the UI spec (section 7.4). This should
91 fix projects.maemo.org bug NB#59297.
93 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
95 * src/maemo/modest-main-window.c: (sync_accounts_cb):
96 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
97 is another problem with the code, see Murray's comment at line 772)
99 2007-06-08 Murray Cumming <murrayc@murrayc.com>
101 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
102 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
103 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
104 (load_from_file), (easysetup_country_combo_box_init),
105 (easysetup_country_combo_box_get_active_country_ids),
106 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
107 instead of just one ID, to avoid duplicate country names in the UI.
109 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
110 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
111 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
112 a single ID, avoiding duplicate providers.
113 * src/maemo/easysetup/modest-easysetup-wizard.c:
114 (on_combo_account_country): Adapt to use a list.
116 2007-06-08 Murray Cumming <murrayc@murrayc.com>
118 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
119 keys changed in the last X seconds.
121 * src/modest-account-mgr.h:
122 * src/modest-account-mgr.c: (on_timeout_notify_changes),
123 (on_key_change), (modest_account_mgr_class_init),
124 (modest_account_mgr_init), (modest_account_mgr_finalize):
125 As the keys are changed, save them in a GSList* and signal that GSList*
126 further every X seconds, to batch changes, to allow us to do just one
127 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
128 bug NB#56941 and other (UI-blocking) delays when changing account settings.
130 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
131 changed signal signature.
133 * src/modest-conf.c: (modest_conf_set_list),
134 (modest_conf_on_change): Reenable notification.
136 (modest_conf_maemo_fake_on_change): Comment out the hack that
137 notified immediately instead of asynchronously.
139 * src/widgets/modest-account-view.h:
140 * src/widgets/modest-account-view.c:
141 (update_account_view): Select the previously-selected account ID,
142 if possible. This fixes projects.maemo.org bug NB#56933.
144 (on_account_changed), (on_account_removed),
145 (modest_account_view_select_account):
147 Remove the block/unblock functions
148 because they were not useful.
150 * src/maemo/modest-account-view-window.c:
151 (on_delete_button_clicked), (on_edit_button_clicked),
152 (on_new_button_clicked): Remove the use of the non-working block/unblock.
154 2007-06-08 Murray Cumming <murrayc@murrayc.com>
156 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
157 Improve the error dialog to show Incorrect Account Settings, which seems
158 clearer, and say that the internal error message (to be removed from the
159 dialog later) is often misleading.
160 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
162 * src/modest-tny-account.c:
163 (modest_tny_account_new_from_server_account): Uncomment the printf of the
164 URL because this is so useful for debugging on the device.
166 * src/widgets/modest-serversecurity-combo-box.c:
167 (modest_serversecurity_combo_box_fill): Correct a logical ID.
169 2007-06-08 Murray Cumming <murrayc@murrayc.com>
171 * src/modest-mail-operation.c:
172 (modest_mail_operation_send_new_mail):
173 Added a comment about a nasty but apparently harmless message. Details
174 added to the wiki g_warnings() page.
176 2007-06-08 Murray Cumming <murrayc@murrayc.com>
178 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
179 (modest_tny_send_queue_class_init):
180 Do not use the priv struct because it is empty, to avoid g_warnings
181 about a non-existant priv struct.
183 * src/modest-tny-account-store.c:
184 (modest_tny_account_store_get_server_account),
185 (modest_tny_account_store_get_transport_account_for_open_connection
186 ): Do not try to get transport server accounts for local folders,
187 because they don't have any. This avoids a g_warning().
189 * src/maemo/modest-main-window.c:
190 (modest_main_window_notify_send_receive_initied),
191 (on_configuration_key_changed):
192 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
194 * src/modest-mail-operation.c:
195 (modest_mail_operation_update_account):
196 * src/modest-tny-account-store.h:
197 * src/modest-tny-account.c:
198 (modest_tny_account_get_special_folder),
199 (modest_tny_account_new_for_local_folders),
200 (modest_tny_account_new_for_per_account_local_outbox_folder):
201 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
202 * src/modest-tny-local-folders-account.c:
203 (add_account_folders_to_merged_folder):
204 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
205 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
206 (modest_ui_actions_on_send):
207 * src/widgets/modest-folder-view.c: (update_model):
208 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
209 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
210 modest_tny_account_store_get_tny_account_by_account() to
211 modest_tny_account_store_get_server_account() to make the code clearer.
213 2007-06-07 Marcus Bauer <marcusb@openismus.com>
215 * src/dbus_api/modest-dbus-api.h:
216 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
217 * src/maemo/modest-msg-edit-window.c:
218 (modest_msg_edit_window_attach_file_noninteractive):
219 added g_warning in case the file to be attached does not exist
220 * tests/dbus_api/test_compose_mail.c: (main):
221 removed obsolete comment, added generic files as test case
223 2007-06-07 Murray Cumming <murrayc@murrayc.com>
225 * src/modest-tny-account-store.c: (get_server_accounts):
226 Create the local folders account only once, not once for each outbox, and
227 not only when there are some outboxes.
229 2007-06-07 Murray Cumming <murrayc@murrayc.com>
231 * src/widgets/modest-folder-view.c: (update_model): Comment out some
232 code that is causing a crash at startup. Sergio says that he is fixing this.
234 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
236 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
237 * src/maemo/modest-account-settings-dialog.c:
238 (create_page_outgoing),
239 (modest_account_settings_dialog_set_account_name),
240 (save_configuration):
241 - Fixed handling of the "Use secure authentication" toggle to comply with
242 the ui specification. See also projects.maemo.org bug NB#58400
244 - Restore the Secure connection setting combo correctly when loading
247 * src/maemo/modest-maemo-utils.c:
248 (on_camel_account_get_supported_secure_authentication),
249 (modest_maemo_utils_get_supported_secure_authentication_methods):
250 Fixed a crasher if operation is canceled
252 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
253 (modest_protocol_info_auth_is_secure):
254 * src/modest-protocol-info.h:
256 Added two new methods to determine if a protocol/auth method is secure/encrypted in
257 the sense of the "Use secure authentication" toggle.
259 2007-06-07 Murray Cumming <murrayc@murrayc.com>
261 * src/modest-tny-account-store.h:
262 * src/modest-tny-account-store.c:
263 Added modest_tny_account_store_get_local_folders_account().
265 * src/modest-tny-folder.h:
266 * src/modest-tny-folder.c:
267 (modest_tny_folder_get_account):
268 Added this replacement for tny_folder_get_account() which returns
269 the local-folders account for TnyMergeFolders, to avoid the
270 warning about the unimplemented get_account_func() vfunc().
272 (modest_tny_folder_get_rules),
273 * src/modest-ui-actions.c:
274 (modest_ui_actions_on_folder_selection_changed):
275 * src/modest-mail-operation.c:
276 (modest_mail_operation_remove_folder),
277 (modest_mail_operation_xfer_folder),
278 (modest_mail_operation_rename_folder),
279 (modest_mail_operation_get_msg),
280 (modest_mail_operation_get_msgs_full),
281 (modest_mail_operation_remove_msg),
282 (modest_mail_operation_xfer_msgs),
283 (modest_mail_operation_refresh_folder):
284 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
286 2007-06-07 Murray Cumming <murrayc@murrayc.com>
288 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
289 (modest_server_account_set_security):
290 * src/modest-defs.h: Add comments explaining that our
291 UI spec means TLS when it says Normal, so these do not look like errors.
293 * src/modest-tny-account.c:
294 (modest_tny_account_new_from_server_account): Use the new tinymail
295 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
296 for TLS. This should fix projects.maemo.org bug NB#58460.
298 2007-06-06 Murray Cumming <murrayc@murrayc.com>
300 * src/maemo/easysetup/modest-easysetup-wizard.c:
301 (create_account): Correct the position of the gconf sanity check warning.
302 (on_button_edit_advanced_settings): Show the dialog immediately, instead
303 of using the g_idle_add() hack, because this does not seem to be necessary
304 on osso 1.1. It might even work on Maemo Bora if the problems were actually
305 caused by something other than maemo's gconf.
306 This fixes projects.maemo.org bug #59022.
308 2007-06-06 Murray Cumming <murrayc@murrayc.com>
310 * src/modest-account-mgr-helpers.c:
311 (modest_account_mgr_get_default_account): Do not check that the account
312 exists if there is no default account (NULL), to fix a runtime warning.
314 2007-06-06 Murray Cumming <murrayc@murrayc.com>
316 * src/widgets/modest-folder-view.c: (update_model):
317 Do not unref the treemodel before we have finished with it.
318 This prevents a valgrind warning and an occasional crash at startup.
320 2007-06-06 Marcus Bauer <marcusb@openismus.com>
322 * libmodest-dbus-client/libmodest-dbus-client.h:
323 added libmodest_dbus_client_compose_mail()
324 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
326 added functions needed for SendAsMail() functionality
327 * src/maemo/modest-msg-edit-window.c:
328 (modest_msg_edit_window_attach_file_noninteractive):
329 non interactively attaching files to message edit window
330 * src/widgets/modest-msg-edit-window.h:
331 * tests/dbus_api/Makefile.am:
332 added test_compose_mail.c
333 * tests/dbus_api/test_compose_mail.c: (main):
335 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
337 * src/modest-account-view.c:
338 Fixed bug projects.maemo.org bug NB#59307
340 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
342 * src/maemo/easysetup/modest-easysetup-wizard.c:
343 (get_serverport_incoming), (on_before_next), (create_account):
344 * src/maemo/modest-account-settings-dialog.c:
345 (modest_account_settings_dialog_set_account_name):
346 * src/maemo/modest-maemo-utils.c:
347 (on_camel_account_get_supported_secure_authentication_status),
348 (on_camel_account_get_supported_secure_authentication),
349 (on_secure_auth_cancel),
350 (modest_maemo_utils_get_supported_secure_authentication_methods):
352 Implemented security authentication for settings and easysetup.
354 2007-06-05 Murray Cumming <murrayc@murrayc.com>
356 * src/maemo/modest-main-window.c: (create_details_widget):
357 Show the total size for memory card accounts too, instead of showing
358 the name again. Fixes bug projects.maemo.org bug NB#59307.
360 2007-06-05 Murray Cumming <murrayc@murrayc.com>
363 * src/modest-tny-simple-folder-store.c:
364 * src/modest-tny-simple-folder-store.h: Removed.
366 * src/modest-tny-local-folders-account.h
367 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
368 for the local-folders maildir, with an extra TnyMergedFolder containing
369 the folders of the per-account outbox store accounts.
370 * src/modest-tny-account-store.c: (get_server_accounts):
371 Add the outboxes to the special local folders account after creating it.
373 * src/modest-tny-account.c:
374 (modest_tny_account_new_for_local_folders): Create the derived
375 account when creating the main local-folders account.
377 * src/maemo/modest-main-window.c: (create_details_widget),
378 (modest_main_window_set_contents_style):
379 Adapted to the use of the derived account instead of the folder store.
381 * src/modest-ui-actions.c:
382 (modest_ui_actions_on_folder_selection_changed):
383 * src/modest-ui-dimming-rules.c:
384 (modest_ui_dimming_rules_on_new_folder):
385 * src/widgets/modest-folder-view.c: (text_cell_data),
386 (icon_cell_data), (filter_row), (update_model),
387 (get_cmp_rows_type_pos):
390 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
391 Do not get the priv struct, because no priv struct has been set,
392 to avoid a runtime warning.
394 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
395 #ifelse with #else, to fix a warning, to fix the build.
398 2007-06-05 Christian Kellner <ckellner@openismus.com>
400 * libmodest-dbus-client/libmodest-dbus-client.c:
401 Fix small typo in doc (why do you always see them
402 AFTER committing stuff?)
405 2007-06-05 Christian Kellner <ckellner@openismus.com>
407 * libmodest-dbus-client/libmodest-dbus-client.c:
408 (libmodest_dbus_client_search):
409 Initialize hit list with NULL. Also set folder list
410 to "" if NULL was supplied.
413 2007-06-03 Christian Kellner <ckellner@openismus.com>
415 * libmodest-dbus-client/libmodest-dbus-client.c:
416 (modest_search_hit_list_free):
417 Make it save to call it with NULL.
419 * src/dbus_api/modest-dbus-callbacks.c:
420 * src/modest-search.c:
421 Return full ModestSearchHits as the search result list not TnyHeader
422 since can't be around withouth the correspoding TnyFolder.
424 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
426 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
427 Added currently commented code to check for secure auth
429 * src/maemo/modest-account-settings-dialog.c: (on_response),
430 (save_configuration), (show_ok):
431 Fixed projects.maemo.org bugs NB #59248 and #59251
433 * src/maemo/modest-maemo-utils.c:
434 (on_camel_account_get_supported_secure_authentication_status),
435 (on_camel_account_get_supported_secure_authentication),
436 (modest_maemo_utils_get_supported_secure_authentication_methods):
437 * src/maemo/modest-maemo-utils.h:
438 Moved get_supported_secure_authentication() method here to be able
439 to use it from easysetup wizard.
441 * src/modest-pair.c: (on_pair_compare_as_string):
442 Should compare string with first part of pair and not
443 strcmp pairs which will crash.
445 * src/modest-protocol-info.c:
446 (modest_protocol_info_protocol_is_store):
447 * src/modest-protocol-info.h:
448 Added modest_protocol_info_get_auth_protocol_name()
450 2007-06-03 Armin Burgmeier <armin@openismus.com>
452 * src/modest-mail-operation.c:
453 (modest_mail_operation_get_msgs_full): Set priv->account also when
454 only retrieving a single message. This avoids a crash when canceling
457 (modest_mail_operation_notify_end): Do not explicitely remove the
458 operation from the queue but only emit the progress_changed signal.
459 The queue itself listens to that signal to remove the operation when
460 it is finished. This reduces coupling and removes a potential deadlock
461 when modest_mail_operation_notify_end() is called from the queue
462 itself. If that is a problem performance-wise, I would suggest to
463 implement a status-changed signal or something.
465 * src/modest-mail-operation-queue.c: Make sure to never call a
466 function from another file while the queue is locked. This (hopefully)
467 fixes another deadlock when exiting the application while retrieving
470 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
472 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
473 Fixed build if libogs is not available
475 2007-06-03 Christian Kellner <ckellner@openismus.com>
477 * libmodest-dbus-client/libmodest-dbus-client.h:
478 * libmodest-dbus-client/libmodest-dbus-client.c:
479 (libmodest_dbus_client_delete_message):
480 Implement deletion of messages (Client side).
482 (modest_search_hit_free),
483 (modest_search_hit_list_free):
484 Utility functions to free the result hits.
486 * src/dbus_api/modest-dbus-api.h:
487 * src/dbus_api/modest-dbus-callbacks.c:
489 (modest_dbus_req_handler):
490 Implement deletion of messages (Server side).
492 * tests/dbus_api/test_search.c: (main):
495 * tests/dbus_api/Makefile.am:
496 * tests/dbus_api/test_delete_message:
497 Add little test for the message deletion logic
499 2007-06-03 Armin Burgmeier <armin@openismus.com>
501 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
502 when the operation queue was not empty. projects.maemo.org bug
505 2007-06-03 Armin Burgmeier <armin@openismus.com>
507 * src/widgets/modest-account-view.c
508 (on_account_default_toggled): Toggle default account column
509 explicitely instead of waiting for gconf notification (which is
510 currently ignored). This should fix projects.maemo.org bug NB#56910
511 for now. It should probably be removed when gconf notifications are
514 2007-06-03 Christian Kellner <ckellner@openismus.com>
516 * libmodest-dbus-client/libmodest-dbus-client.c:
517 Removed debugging spew.
519 * src/dbus_api/modest-dbus-callbacks.c:
520 Added debugging info.
522 * src/modest-search.c:
523 (modest_search_all_accounts):
524 Use tny_account_store_get_accounts () on the account store
525 to get all accounts which is the way to get all accounts.
527 * tests/dbus_api/test_search.c: (main):
528 Make it possible to supply the search term on the command line.
530 2007-06-03 Christian Kellner <ckellner@openismus.com>
532 * libmodest-dbus-client/libmodest-dbus-client.c:
533 * libmodest-dbus-client/libmodest-dbus-client.h:
534 Implement searching for mesages over raw dbus. (Client side)
536 * src/dbus_api/Makefile.am:
537 * src/dbus_api/modest-dbus-api.h:
538 * src/dbus_api/modest-dbus-callbacks.c:
539 * src/dbus_api/modest-dbus-callbacks.h:
540 Search framework (Server side). Also implement on_idle_open_message().
542 * src/maemo/modest-platform.c: (modest_platform_init):
543 Prepare for raw dbus/osso rpc interaction.
545 * src/modest-search.h:
546 Changed minsize from unspecific guint to guint32.
548 * src/modest-search.c:
550 Added strange hack which magically made tnymail work.
552 (modest_search_folder),
553 (modest_search_account),
554 (modest_search_all_accounts):
555 Implement helper functions to search all accounts, specific account
558 * tests/dbus_api/Makefile.am:
559 * tests/dbus_api/test_open_message.c:
560 Read url to open from commandline.
562 * tests/dbus_api/test_search.c:
563 Implement small test for dbus search stuff
565 2007-06-02 Armin Burgmeier <armin@openismus.com>
567 * src/maemo/modest-account-settings-dialog.c: Changed window title to
568 include account type and account title. This fixes projects.maemo.org
571 * src/maemo/modest-account-view-window.c: Set a title for the window.
573 2007-06-02 Armin Burgmeier <armin@openismus.com>
575 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
576 incoming and outgoing server name based on email address and server
577 types as long as the names have not been edited manually. This fixes
578 projects.maemo.org bug NB#58671.
580 2007-06-02 Armin Burgmeier <armin@openismus.com>
582 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
583 server type cannot be changed in future to the incoming details page
584 when creating an account. This fixes projects.maemo.org bug NB#59029.
586 2007-06-02 Armin Burgmeier <armin@openismus.com>
588 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
589 and assigned max width chars so that they wrap instead of being
590 truncated. Fixes projects.maemo.org bug NB#56126.
592 2007-06-02 Armin Burgmeier <armin@openismus.com>
594 * src/maemo/modest-connection-specific-smtp-window.c: Add an
595 introductory note to the connection specific smtp servers dialog, as
596 section 8.12 of the email UI specification requires. This fixes
597 projects.maemo.org bug NB#59212.
599 2007-06-01 Murray Cumming <murrayc@murrayc.com>
601 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
602 Check for running mail operations, and offer to cancel them, as per the UI
603 spec. This fixes projects.maemo.org bug NB#59041 .
604 However, I suspect that tinymail may still use the network connection
605 in ways that we cannot detect or cancel. But it should at least adapt to
608 2007-06-01 Murray Cumming <murrayc@murrayc.com>
610 * src/modest-tny-account-store.c: (recreate_all_accounts),
611 (get_cached_accounts), (get_server_accounts): Do more sensible
612 ref-counting of the temporarily-cached outbox accounts list. This seems
613 to fix a crash when entering the password when the password was wrong.
615 2007-06-01 Murray Cumming <murrayc@murrayc.com>
617 * src/gnome/modest-main-window.c: (connect_signals):
618 * src/modest-tny-account-store.c: (get_password),
619 (modest_tny_account_store_alert): Added comments and clues and
620 commented-out code about how we currently fail to deal with connection
621 errors and wrong passwords, and how we should.
623 2007-06-01 Murray Cumming <murrayc@murrayc.com>
625 * src/widgets/modest-retrieve-combo-box.c:
626 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
627 This fixes projects.maemo.org bug NB#58472 .
629 2007-06-01 Murray Cumming <murrayc@murrayc.com>
631 * src/maemo/easysetup/modest-easysetup-wizard.c:
632 (create_page_complete_easysetup):
633 (create_page_complete_custom): Correct the last commit,
634 putting the correct sentences in the correct pages.
636 2007-06-01 Murray Cumming <murrayc@murrayc.com>
638 * src/maemo/easysetup/modest-easysetup-wizard.c:
639 (create_page_complete_custom): Show the second sentence of text
640 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
643 2007-06-01 Murray Cumming <murrayc@murrayc.com>
645 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
646 Set the leave-on-server conf key by default. This fixes
647 projects.maemo.org bug NB#59258 .
649 2007-06-01 Murray Cumming <murrayc@murrayc.com>
651 * src/maemo/modest-account-view-window.c:
652 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
653 logical ID for the confirmation messages. Fixed projects.maemo.org bug
656 2007-06-01 Murray Cumming <murrayc@murrayc.com>
658 * src/maemo/easysetup/modest-easysetup-wizard.c:
659 (create_caption_new_with_asterisk):
660 * src/maemo/modest-account-settings-dialog.c:
661 (create_caption_new_with_asterisk):
662 Uncomment the code to add the asterisk, because they are no longer in the
663 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
664 (update_incoming_server_title): Add an asterisk here too.
666 2007-06-01 Murray Cumming <murrayc@murrayc.com>
668 * src/maemo/modest-maemo-global-settings-dialog.c:
669 (current_connection): Check that we are even connected before trying to
670 get the current connection name, to prevent a warning.
672 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
673 Change the comments because tny_maemo_conic_device_connect() is now meant to
675 * src/modest-mail-operation.c:
676 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
677 make sure we have a connection and fail if we can't connect.
679 2007-05-31 Murray Cumming <murrayc@murrayc.com>
681 * src/maemo/modest-main-window.c:
682 (on_account_store_connecting_finished): Do not try to get the
683 connection ID if we are not really connected. I am surprised that
684 this signal handler is called when we are not connected.
686 2007-05-31 Murray Cumming <murrayc@murrayc.com>
688 * src/modest-error.h:
689 * src/modest-ui-actions.c:
690 (modest_ui_actions_get_msgs_full_error_handler):
691 Renamed an enum, added comments, added an enum
692 for retrieve-limit errors.
694 * src/modest-mail-operation.c: (foreach_add_item),
695 (internal_folder_observer_update), (update_account_thread),
696 (modest_mail_operation_get_msgs_full):
697 (modest_mail_operation_update_account),
698 Added comments about how this works, and some code that should
699 (but does not) check the retrieve-limit. See the TODO comment.
701 2007-05-31 Murray Cumming <murrayc@murrayc.com>
703 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
704 Initialize help_id to fix the build. Warnings are good.
706 2007-05-31 Murray Cumming <murrayc@murrayc.com>
708 * src/widgets/modest-hbox-cell-renderer.c:
709 (modest_hbox_cell_renderer_append):
710 * src/widgets/modest-vbox-cell-renderer.c:
711 (modest_vbox_cell_renderer_append):
712 Fix the last commit by doing an extra ref.
714 2007-05-31 Murray Cumming <murrayc@murrayc.com>
716 * src/widgets/modest-hbox-cell-renderer.c:
717 (modest_hbox_cell_renderer_append):
718 * src/widgets/modest-vbox-cell-renderer.c:
719 (modest_vbox_cell_renderer_append):
720 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
721 to fix the build with Maemo Bora.
722 However, there seems to be a remaining crash, probably due to reference
725 2007-05-30 Murray Cumming <murrayc@murrayc.com>
727 * src/modest-tny-account.c:
728 (modest_tny_account_new_for_local_folders):
729 Use hildon_file_system_info_async_new() to get a better name for
730 the memory card account, setting it as the account name.
731 The timing seems to work, but this is probably
732 not the best place to do this. See the TODO comment.
733 * src/maemo/modest-main-window.c: (create_details_widget):
734 * src/widgets/modest-folder-view.c: (text_cell_data):
735 Use the tny account name instead of hardcoding a name.
737 2007-05-30 Christian Kellner <ckellner@openismus.com>
739 * src/modest-search.c: (modest_search):
740 Correctly set part_search_func even if we have already parsed
741 the query and thus a valid OgsTextSearcher object.
743 2007-05-30 Christian Kellner <ckellner@openismus.com>
746 Search and check for libogs.
749 Incooparte the ogs build env.
751 * src/modest-mime-part-search-stream.c:
752 * src/modest-mime-part-search-stream.h:
753 Removed since we do the real searching now in modest-search.c.
755 * src/modest-search.c:
756 * src/modest-search.h:
757 Implement support for ogs. We use that if available and requested
758 and fall back to modest_text_utils_utf8_strcmp (). The search logic
759 should now handle the corner case when the search term is spread
760 across multiple reads.
761 Also the logic in modest_search () was corrected to search all
762 requested fields until one is found.
764 2007-05-30 Murray Cumming <murrayc@murrayc.com>
766 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
769 * src/modest-init.c: Made modest_init_local_folders() take a
770 path and be public so we can iniitialize maildir folders on
773 * src/modest-local-folder-info.h:
774 * src/modest-local-folder-info.c:
775 (modest_local_folder_info_get_maildir_path): Add a path parameter.
777 * src/modest-tny-account.c:
778 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
779 still means the standard local-folders path on the local volume.
781 * src/modest-tny-account-store.c:
782 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
783 signal so we can detect mount/unmount of the MMC1 card, and do an update of
784 all accounts when that happens.
785 (get_server_accounts): If the MMC1 card is mounted, create a store account for
786 this too, so it shows up in the treeview.
788 2007-05-28 Murray Cumming <murrayc@murrayc.com>
790 * src/maemo/modest-maemo-global-settings-dialog.c:
791 (current_connection):
792 * src/widgets/modest-global-settings-dialog.c:
793 (current_connection_default):
794 Use the enum values instead of 0, 1 and -1,
795 to make the code clearer.
797 * src/modest-account-mgr-helpers.c:
798 (modest_account_mgr_get_connection_specific_smtp): Make this code
801 * src/modest-runtime.h:
802 * src/modest-runtime.c:
803 Added modest_runtime_remove_all_send_queues().
804 * src/maemo/modest-main-window.c:
805 (on_account_store_connecting_finished): Recreate the send queues,
806 using the appropriate transport accounts for this new connection.
807 Some futher adapting might be needed if the old send queues are not
808 automatically stopped at this point.
810 * src/modest-tny-account-store.c: (get_server_accounts):
811 Create the connection-specific transport accounts, so that they can
812 be found later by their ID.
814 * src/modest-tny-account.h:
815 * src/modest-tny-account.c:
816 Added modest_tny_account_new_from_server_account_name().
817 modest_tny_account_new_from_server_account(): Do not create the
818 send queues here, because they will be
819 recreated anyway when the connection changes for the first time.
821 2007-05-28 Murray Cumming <murrayc@murrayc.com>
823 * src/modest-local-folder-info.h:
824 * src/modest-local-folder-info.c:
825 (modest_per_account_local_outbox_folder_info_get_maildir_path),
826 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
827 tbox_folder): Take a modest account name instead of a server TnyAccount,
828 so we can have per-modest-account rather than per-transport-account
830 We must make sure that we change or recreate the exisitng send queues
831 when the connection changes for connection-specific transport accounts.
833 * src/modest-tny-account-store.c:
834 (create_per_account_local_outbox_folders): Create outboxed per modest
835 account, not per transport account.
837 * src/modest-tny-account.h:
838 * src/modest-tny-account.c:
839 (modest_tny_account_get_special_folder): For outboxes, get the
840 parent modest account name. The account is ignored for other folders.
841 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
842 modest account name rather than a server TnyAccount.
844 2007-05-25 Murray Cumming <murrayc@murrayc.com>
846 * src/modest-tny-account.c:
847 (modest_tny_account_new_from_server_account):
848 Call modest_runtime_get_send_queue() immediately after creating transport
849 accounts, so that they start trying to send email from the outbox as soon
850 as possible at startup. This is probably what we want.
852 * src/modest-mail-operation.c: (update_account_thread):
853 * src/modest-runtime.c: (modest_runtime_get_send_queue):
854 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
855 * src/modest-tny-send-queue.h:
856 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
857 (modest_ui_actions_on_send):
858 Added comments about how sending works, though it needs some more work.
860 2007-05-25 Murray Cumming <murrayc@murrayc.com>
862 * src/modest-tny-account.c:
863 (modest_tny_account_get_special_folder): Add TODO because this fails when
865 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
866 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
867 Do not try to show this window when there is no active account. The UI
868 specs does not tell us what to do in this case.
870 2007-05-24 Murray Cumming <murrayc@murrayc.com>
874 * src/maemo/Makefile.am:
875 * src/widgets/Makefile.am: Some dist fixes.
877 2007-05-24 Murray Cumming <murrayc@murrayc.com>
879 * src/maemo/modest-connection-specific-smtp-window.c:
880 (on_button_edit): Make the code clearer, to prevent a double free.
882 2007-05-24 Murray Cumming <murrayc@murrayc.com>
884 * src/maemo/modest-account-settings-dialog.c:
885 (modest_account_settings_dialog_set_account_name),
886 Check the connection-specific smtp servers checkbox if there are any.
888 * src/maemo/modest-connection-specific-smtp-edit-window.c:
889 (modest_connection_specific_smtp_edit_window_init):
890 Start with a suitable port number.
892 * src/modest-account-mgr-helpers.h:
893 * src/modest-account-mgr-helpers.c: Added
894 modest_account_mgr_get_has_connection_specific_smtp().
896 (modest_account_mgr_set_connection_specific_smtp),
897 (modest_account_mgr_remove_connection_specific_smtp),
898 (modest_account_mgr_get_has_connection_specific_smtp),
899 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
900 connection-specific smtp server accounts in the account, rather than
901 the server account conf dir.
903 This fixes bug projects.maemo.org bug NB#58263 .
905 * src/modest-tny-account-store.c:
906 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
907 if there are no server accounts yet, to prevent an infinite loop when there
908 are no accounts. Document that one must be called before the other.
910 2007-05-24 Murray Cumming <murrayc@murrayc.com>
912 * src/modest-account-mgr-helpers.c:
913 (modest_account_mgr_get_default_account): Make sure that at least
914 one account is always the default, if there are any enabled accounts.
915 This is just a sanity check that shouldn't be necessary.
917 * src/modest-account-mgr-priv.c:
918 (_modest_account_mgr_account_from_key): Unescape the conf key to
919 get the real account name. For instance, this is an issue if a space
920 was in the account name, which can happen because the account name
921 is generated from the display name.
922 (_modest_account_mgr_get_account_keyname): Always escape the
924 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
925 Unescape the conf keys to get the real account names.
927 For instance, previously the is-default radio button in the accounts
928 list was not checked for any accounts at first. This fixes that,
929 and might fix several similar bugs.
931 2007-05-23 Murray Cumming <murrayc@murrayc.com>
933 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
934 Removed some debug printfs.
936 2007-05-23 Murray Cumming <murrayc@murrayc.com>
938 Modest on-disk outbox directories are now here, for instance:
939 $HOME/.modest/outboxes/<account-id-1>/outbox
940 $HOME/.modest/outboxes/<account-id-2>/outbox
942 $HOME/.modest/local-folders/outbox
943 so we can have a separate outbox for each account.
944 But they are shown as one outbox in the GtkTreeView, by using a
945 TnyMergeFolder in a ModestTnySimpleFolderStore.
948 * src/modest-tny-simple-folder-store.c:
949 * src/modest-tny-simple-folder-store.h:
950 Added ModestTnySimpleFolderStore, used to contain folders from
951 other folder stores, such as other accounts.
953 * src/modest-tny-outbox-account.h:
954 * src/modest-tny-outbox-account.c:
955 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
956 used for the per-account local outbox folders.
958 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
959 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
960 only use this (internally) now for the non-outbox local folders.
963 * src/modest-init.c: Added modest_init_one_local_folder(), for
964 setting up the directory structure for each local folder.
966 * src/modest-local-folder-info.c:
967 (modest_per_account_local_outbox_folder_info_get_maildir_path),
968 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
970 * src/modest-local-folder-info.h:
971 * src/modest-tny-account-store.c: (on_account_removed),
972 (on_account_changed), (create_per_account_local_outbox_folders),
973 (get_server_accounts), (modest_tny_account_store_get_accounts),
974 (modest_tny_account_store_get_tny_account_by_account),
975 (modest_tny_folder_store_is_virtual_local_folders):
977 * src/modest-tny-account.h:
978 * src/modest-tny-account.c:
979 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
980 to create an on-disk per-account local outbox folder for each
982 (create_per_account_local_outbox_folders): Create a local outbox folder
983 for each transport account.
984 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
985 for all local folders.
987 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
988 instead of using g_object_get/set() directly. It is clearer.
990 (modest_tny_folder_store_get_message_count),
991 (modest_tny_folder_store_get_local_size
992 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
993 because we now use these with non-acount folder stores.
995 (modest_tny_account_get_special_folder),
996 (modest_tny_account_new_from_server_account),
997 (modest_tny_account_new_from_account):
998 (recurse_folders): Adjust to the new outbox system.
1000 * src/modest-tny-folder.h:
1001 * src/modest-tny-folder.c:
1002 (modest_tny_folder_is_local_folder),
1003 (modest_tny_folder_get_local_folder_type),
1004 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1006 * src/widgets/modest-main-window.h:
1007 * src/maemo/modest-main-window.c: (create_details_widget),
1008 (modest_main_window_set_contents_style): Show details for any folder store,
1011 (modest_tny_folder_get_rules):
1012 Remove the const. C does not support constness enough for this.
1014 * src/modest-ui-actions.c:
1015 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1016 make all outboxes appear as one, in the usual local-folders tree node.
1018 (set_active_account_from_tny_account),
1019 (modest_ui_actions_on_folder_selection_changed):
1020 * src/widgets/modest-folder-view.c: (text_cell_data),
1021 (icon_cell_data), (filter_row),
1022 (add_account_folders_to_merged_folder),
1023 (add_account_folders_to_simple_folder_store), (),
1024 (get_cmp_rows_type_pos), (cmp_rows),
1025 (modest_folder_view_set_account_id_of_visible_server_account):
1026 Adjust to the new outbox system, using generic folder stores and folders
1027 in the GtkTreeModel.
1029 2007-05-23 Christian Kellner <ckellner@openismus.com>
1031 * src/modest-mail-operation.c:
1032 (modest_mail_operation_update_account):
1033 Use info->max_size instead of unintialized local var [small
1034 build fix]. (Added TODO to review that change since I don't
1037 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1039 * libmodest-dbus-client/libmodest-dbus-client.c:
1040 (libmodest_dbus_client_compose_mail): function added
1041 * src/dbus_api/modest-dbus-api.h:
1042 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1043 (on_compose_mail): Implementation of the SendAsMail functionality
1045 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1047 * src/modest-account-mgr.c:
1048 (modest_account_mgr_add_server_account): Set the secure-connection
1049 conf key for transport accounts as well as store accounts. I don't know
1050 why the if was there. For instance, this makes sure that we use SSL
1051 for the gmail preset from the easysetup wizard.
1053 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1055 * src/gnome/modest-main-window.c:
1056 (on_account_store_connecting_finished), (connect_signals):
1057 * src/maemo/modest-main-window.c:
1058 (on_account_store_connecting_finished), (connect_signals),
1059 (modest_main_window_new):
1060 Handle TnyAccountStore::connecting-finished instead of
1061 TnyDevice::connection-changed, because we cannot actually perform
1062 operations on accounts until TnyAccountStore has itself responded to
1063 the TnyDevice::connection-changed signal. This prevents a GError from
1065 Do not try to update at startup, because we (at least on scratchbox)
1066 already do an update at startup when the device goes online.
1067 This prevents a GError from tinymail.
1068 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1069 Added TODO about stopping simultaneous operations.
1071 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1073 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1074 * src/modest-mail-operation-queue.c:
1075 (modest_mail_operation_queue_remove):
1076 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1077 about where they happened.
1079 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1081 * src/modest-ui-actions.c:
1082 (modest_ui_actions_on_password_requested): Make sure that the remember
1083 output parameter is always TRUE.
1085 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1087 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1088 Show a OK/Cancel dialog if the error is a question, though we still do not
1089 know anything more about what we are asking the user.
1090 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1091 Fix an uninitialized variable (helper). This is a logic error, however.
1093 2007-05-21 Christian Kellner <ckellner@openismus.com>
1095 * src/modest-search.h:
1096 Correct bit shifting in the ModestSearchFlags enum.
1098 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1100 * src/modest-tny-account.c:
1101 (modest_tny_account_new_from_server_account): Do not use the lsub and
1102 check-all hard-coded IMAP options when using POP.
1104 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1106 * src/modest-tny-account.c:
1107 (modest_tny_account_new_from_server_account):
1108 Use NULL for the secure-auth method for POP when Password auth has been
1109 specified by the user, as we already do for IMAP. "auth=Login" causes
1110 an error from camel or the server.
1112 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1114 * src/maemo/modest-account-settings-dialog.c:
1115 (create_page_account_details),
1116 (modest_account_settings_dialog_set_account_name):
1117 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1118 for the leave-on-server checkbox, rathr than just the checkbox, when
1119 the protocol is not POP.
1121 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1123 * src/widgets/modest-account-view.c:
1124 * src/widgets/modest-account-view.h:
1125 Added modest_account_view_select_account() which will be useful later
1126 to asynchronously re-select the edited account.
1128 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1130 * src/maemo/modest-account-settings-dialog.c:
1131 (modest_account_settings_dialog_set_account_name):
1132 Automatically choose the port numbers based on the secure authentication
1133 methods, if they have not been chosen before.
1134 This fixes projects.maemo.org bug NB#56273 .
1136 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1138 * src/maemo/modest-main-window-ui.h:
1139 * src/modest-ui-actions.c:
1140 * src/modest-ui-actions.h:
1141 Connect the Tools/SMTP Servers menu item to
1142 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1143 SMTP servers dialog, as in the UI specification and saves changes when it
1144 is closed. This fixed projects.maemo.org bug NB#56305 .
1146 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1148 * src/maemo/modest-connection-specific-smtp-window.c:
1149 (modest_connection_specific_smtp_window_init):
1150 Use gtk_window_set_default_size() to make this window big enough, so
1151 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1153 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1155 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1156 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1157 (modest_connection_specific_smtp_edit_window_init),
1158 Do not try to connect to a combobox signal before the combobox exists.
1159 This fixes the cras in projects.maemo.org bug NB#56288 .
1160 (modest_connection_specific_smtp_edit_window_get_settings):
1161 Remove the server_account_name parameter which was being checked for NULL
1162 though it was not used.
1164 * src/maemo/modest-connection-specific-smtp-window.c:
1165 (modest_connection_specific_smtp_window_fill_with_connections),
1166 (on_button_edit), (modest_connection_specific_smtp_window_init):
1167 Correct the number of treemodel columns to prevent a warning.
1168 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1169 libconic does not work.
1171 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1173 * src/modest-tny-account.c:
1174 (modest_tny_account_new_from_server_account):
1175 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1176 SMTP when "None" was chosen by the user. However, with my SMTP server that
1177 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1180 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1182 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1183 to explain the memory management issue with the ID in the ModestPair.
1185 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1186 (add_sending_page), (modest_account_assistant_finalize):
1187 * src/gnome/modest-gnome-global-settings-dialog.c:
1188 (create_updating_page), (create_composing_page):
1189 * src/gnome/modest-msg-edit-window.c: (get_transports),
1190 (init_window), (modest_msg_edit_window_finalize),
1191 (modest_msg_edit_window_get_msg_data):
1192 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1193 * src/gnome/modest-transport-widget.c:
1194 (modest_transport_widget_finalize), (smtp_configuration):
1195 * src/maemo/modest-maemo-global-settings-dialog.c:
1196 (create_updating_page), (create_composing_page):
1197 * src/maemo/modest-msg-edit-window.c: (get_transports),
1198 (init_window), (modest_msg_edit_window_finalize),
1199 (modest_msg_edit_window_get_msg_data),
1200 (modest_msg_edit_window_free_msg_data):
1201 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1202 (modest_store_widget_finalize):
1203 * src/maemo/modest-transport-widget.c:
1204 (modest_transport_widget_finalize), (smtp_configuration):
1205 * src/modest-main.c: (send_mail):
1206 * src/widgets/modest-combo-box.h:
1207 * src/widgets/modest-global-settings-dialog-priv.h:
1208 * src/widgets/modest-global-settings-dialog.c:
1209 (modest_global_settings_dialog_finalize):
1210 * src/widgets/modest-msg-edit-window.h:
1211 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1212 as long as the combo box, to prevent use of freed memory for the ID.
1214 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1216 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1217 get_accounts(), to make this clearer. Do not check for the enabled gconf
1218 key, because we do not use this for server accounts (at least, not yet).
1219 This allows us to send email again.
1221 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1223 * src/maemo/modest-platform.c:
1224 (on_modest_conf_update_interval_changed), (modest_platform_init):
1225 Only respond to this particular key change. All these strcmp()s cannot be
1228 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1230 * src/maemo/modest-maemo-global-settings-dialog.c:
1231 (current_connection): Prevent a crash in scratchbox when
1232 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1233 * src/maemo/modest-platform.c:
1234 (on_modest_conf_update_interval_changed), (modest_platform_init):
1235 Get the update interval from gconf and reset it when the gconf key changes.
1237 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1239 * src/modest-protocol-info.c:
1240 * src/modest-protocol-info.h: Adde enum-specific get functions,
1241 instead of using a ModestProtocolType enum parameter.
1243 * src/gnome/modest-account-assistant.c:
1244 * src/gnome/modest-store-widget.c:
1245 * src/gnome/modest-store-widget.h:
1246 * src/gnome/modest-transport-widget.c:
1247 * src/gnome/modest-transport-widget.h:
1248 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1249 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1250 * src/maemo/easysetup/modest-easysetup-wizard.c:
1251 * src/maemo/modest-account-settings-dialog.c:
1252 * src/maemo/modest-account-settings-dialog.h:
1253 * src/maemo/modest-store-widget.c:
1254 * src/maemo/modest-store-widget.h:
1255 * src/maemo/modest-transport-widget.c:
1256 * src/maemo/modest-transport-widget.h:
1257 * src/modest-account-mgr-helpers.c:
1258 * src/modest-account-mgr-helpers.h:
1259 * src/modest-account-mgr.c:
1260 * src/modest-account-mgr.h:
1261 * src/modest-tny-account.c:
1262 * src/modest-tny-folder.c:
1263 * src/widgets/modest-account-view.c:
1264 * src/widgets/modest-retrieve-combo-box.c:
1265 * src/widgets/modest-retrieve-combo-box.h:
1266 * src/widgets/modest-secureauth-combo-box.c:
1267 * src/widgets/modest-serversecurity-combo-box.c:
1268 * src/widgets/modest-serversecurity-combo-box.h:
1269 * tests/check_account-mgr.c:
1270 Use the specific functions, and use the re-renamed enum values for GNOME too.
1272 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1274 * src/modest-pair.h:
1275 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1276 so we can get the second based on the first.
1278 * src/maemo/modest-account-settings-dialog.h:
1279 * src/maemo/modest-account-settings-dialog.c:
1280 Added get_supported_secure_authentication_methods(), though it is mostly
1281 commented-out for now until the necessary API is committed to tinymail.
1282 (modest_account_settings_dialog_set_account_name),
1283 (save_configuration): Request the supported authentication methods from the
1284 server, so we can choose a working method.
1286 * src/modest-tny-account-store.h:
1287 * src/modest-tny-account-store.c:
1288 (modest_tny_account_store_get_session): Rename from
1289 tny_account_store_get_session().
1291 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1293 * src/modest-protocol-info.h: Split the ModestProtocol enum
1294 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1295 There was no need to have these unrelated values in one enum.
1297 * src/: many files: Adapted to changed enum. This makes the code a bit
1298 clearer, and the compiler could catch some errors.
1300 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1302 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1303 Show the detailed internal camel error message when an error happens
1304 during the configuration, so that our testers can give us more clues.
1305 For instance, in projects.maemo.org bug NB#56910 .
1307 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1309 * src/modest-tny-account.c:
1310 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1311 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1313 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1315 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1316 * src/maemo/modest-account-settings-dialog.c:
1317 (modest_account_settings_dialog_set_account_name),
1318 (save_configuration): For the incoming secure authentication checkbox,
1319 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1320 the UI specification. PLAIN does not seem to be supported for most IMAP
1321 servers anyway, and I am not sure what it would mean.
1322 However, we probably need to discover which of the secure-authentication
1323 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1324 * src/modest-account-mgr-helpers.c:
1325 (modest_account_mgr_get_server_account_data):
1327 * src/modest-tny-account.c:
1328 (modest_tny_account_new_from_server_account):
1329 Use tny_account_set_mech() to set secure-authentication methods,
1330 with some special-casing for IMAP, based on my observations of how
1333 * src/modest-account-mgr-helpers.h:
1334 * src/modest-account-mgr.c:
1335 * src/modest-defs.h: Comment that the URI is only used for local folders.
1337 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1339 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1340 parameter const, just to be neat.
1341 * src/modest-text-utils.c: (modest_text_utils_inline):
1342 End g_strconcat() with NULL, as its documentation says. This is almost
1343 certainly the cause of my crash at startup on the device. Interestingly,
1344 valgrind doesn't tell us about these errors.
1346 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1348 * scripts/build-packages: Added more precise comments about how to use
1349 this script, though I still get this error:
1350 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1351 error building tinymail
1353 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1355 * src/maemo/modest-main-window.c: (on_account_update):
1356 Very slight cleanup, hoping to make it simpler to discover what causes
1357 a crash here sometimes.
1359 * src/modest-tny-account.c:
1360 (modest_tny_account_new_from_server_account): Set the port. Added
1361 comments about the options and a TODO comment because I need to find out
1362 how to specify the secure authentication method.
1364 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1366 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1367 changed CFlags paths form modest to libmodest
1369 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1371 * src/modest-account-mgr-helpers.c:
1372 (modest_account_mgr_get_server_account_data),
1373 (modest_account_mgr_free_server_account_data):
1374 * src/modest-account-mgr-helpers.h:
1375 * src/modest-account-mgr.c:
1376 (modest_account_mgr_add_server_account):
1377 * src/modest-defs.h:
1378 * src/modest-tny-account.c:
1379 (modest_tny_account_new_from_server_account):
1380 Determine the options for tny_camel_account_add_option() here,
1381 based on the settings, rather than storing them directly in gconf.
1383 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1385 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1386 Show a more friendly error dialog now that we expect (from the tinymail
1387 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1389 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1391 * src/maemo/modest-main-window.c: (on_account_update): Check that
1392 account_name is not NULL, to prevent a crash at startup that I am
1393 seeing on the N800. I do wonder why it is NULL.
1395 * src/maemo/easysetup/modest-easysetup-wizard.c:
1396 (create_page_user_details):
1397 * src/maemo/modest-account-settings-dialog.c:
1398 (create_page_user_details), (create_page_outgoing):
1399 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1400 (modest_connection_specific_smtp_edit_window_init):
1401 * src/modest-ui-actions.c:
1402 (modest_ui_actions_on_password_requested):
1403 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1404 might do something useful with the on-screen keyboard.
1406 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1408 * src/maemo/modest-main-window.c: (on_account_update):
1409 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1410 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1412 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1414 * src/modest-tny-account-store.c: (on_account_changed):
1415 Correct the signature of this signal handler.
1417 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1419 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1420 Show a HildonNote instead of a GtkDialog for Maemo.
1422 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1424 * src/widgets/modest-account-view.h:
1425 * src/widgets/modest-account-view.c: (on_account_changed),
1426 (on_account_removed). Added a boolean flag, set/unset by
1427 modest_account_view_block_conf_updates(),
1428 modest_account_view_unblock_conf_updates() to prevent unnecessary
1429 updates, but this is not very useful because the gconf notifications are
1430 so delays (maybe only on Maemo Bora).
1431 So auto-updating is turned off, and these functions do an explicit
1432 update when necessary.
1433 However, something else is still doing too much work when adding/removing
1434 accounts, probably in another part of the application.
1436 * src/maemo/modest-account-view-window.c:
1437 (on_delete_button_clicked), (on_edit_button_clicked),
1438 (on_new_button_clicked): Use the new functions.
1440 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1442 * src/modest-account-mgr-helpers.c:
1443 (modest_account_mgr_set_first_account_as_default):
1444 Sort the list of names alphabetically-by-title, so we choose the first one
1446 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1447 alphabetically by the title.
1449 This fixes projects.maemo.org bug NB#56418 .
1451 * src/modest-account-mgr-priv.c:
1452 (_modest_account_mgr_account_from_key):
1453 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1454 avoid a valgrind error, and possible random behaviour.
1456 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1458 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1459 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1460 tinymail documentation to say that this can be expected.
1461 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1462 pretty, and should not happen, but I would prefer to know when it does.
1464 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1466 * configure.ac: When using the older hildon version, probably on Bora,
1467 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1469 * src/widgets/modest-attachment-view.c:
1470 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1473 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1475 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1476 Implemented the prototype. Can be tested with
1477 tests/dbus_api/test_open_message:
1479 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1481 * src/modest-tny-account-store.c:
1482 (modest_tny_account_store_instance_init), (get_password):
1483 * src/modest-ui-actions.c:
1484 (modest_ui_actions_on_password_requested):
1485 Do not store the password in gconf, because this function is called
1486 for non-remembered passwords. Actually use the cached (in the hash map)
1487 password instead of releasing it.
1488 The password will now not be remembered if it is asked via the protected
1489 password dialog, as per the UI spec.
1491 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1493 * src/modest-defs.h:
1494 * src/modest-account-mgr-helpers.h:
1495 * src/modest-account-mgr-helpers.c:
1496 Added modest_server_account_get_username_has_succeeded(),
1497 modest_server_account_set_username_has_succeeded().
1498 (modest_server_account_set_username),
1499 Reset the has-succeeded flag if the username changes.
1501 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1502 * src/maemo/modest-connection-specific-smtp-window.c:
1503 (modest_connection_specific_smtp_window_save_server_accounts):
1504 Use modest_server_account_set_username() instead of using
1505 modest_conf_set_string() directly, so that the has-succeeded flag is always
1508 * src/modest-ui-actions.c:
1509 (modest_ui_actions_on_password_requested): Dim the username entry if
1510 the username has ever worked, as per the UI spec.
1512 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1514 * src/modest-tny-account-store.c: (get_password):
1515 * src/modest-ui-actions.c:
1516 (modest_ui_actions_on_password_requested):
1517 Allow the username to be changed too, though there is more work to
1518 be done on exactly how this behaves.
1520 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1522 * src/modest-account-mgr-helpers.h:
1523 * src/modest-account-mgr-helpers.c:
1524 Added modest_account_mgr_get_display_name(),
1525 modest_server_account_get_username(),
1526 modest_server_account_set_username(),
1527 modest_server_account_set_password(),
1528 modest_server_account_get_hostname() functions so we do not need to
1529 use the conf API directly.
1531 * src/maemo/modest-main-window.c: (connect_signals):
1532 Actually connect ot the ModestAccountStore::request-password signal,
1533 so that we show the dialog when the password is requested by Tinymail,
1534 for isntance if it is empty.
1536 * src/modest-marshal.list:
1537 * src/modest-tny-account-store.c:
1538 (modest_tny_account_store_class_init), (get_password),
1539 (modest_tny_account_store_alert):
1540 * src/modest-tny-account-store.h:
1541 * src/modest-ui-actions.h:
1542 * src/modest-ui-actions.c:
1543 (modest_ui_actions_on_password_requested):
1544 Change the signal parameters, so it is obvious that we are providing
1545 the non human-readable server name, and receiving both the username
1546 and password, though changing of the username is not yet implemented.
1547 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1548 for the GNOME version.
1550 This should fix the projects.maemo.org bug NB#56209, though it does not
1551 work on Bora, because the gconf_client_get() for the password fails
1552 immediately after we save it with gconf_client_set().
1554 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1557 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1558 caused an undefined symbol error:
1559 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1561 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1563 * src/modest-tny-account-store.c:
1564 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1565 using a GError instead of a string message, so we can translate it in
1568 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1570 * src/maemo/modest-address-book.c:
1571 (modest_address_book_check_names):
1572 * src/maemo/modest-msg-view-window.c:
1573 (modest_msg_view_window_clipboard_owner_change):
1574 * src/modest-init.c: (modest_init_init_ui):
1575 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1576 (update_folders_cb), (modest_mail_operation_update_account):
1577 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1578 (modest_ui_actions_on_msg_attachment_clicked),
1579 (modest_ui_actions_on_msg_recpt_activated):
1580 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1581 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1582 (modest_msg_view_search_next):
1583 * src/widgets/modest-recpt-editor.c:
1584 (modest_recpt_editor_on_button_release_event),
1585 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1586 g_message(). At this point we should only be seeing interesting errors on
1587 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1589 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1591 (modest_wizard_dialog_force_title_update):
1592 * src/maemo/easysetup/modest-wizard-dialog.h:
1593 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1594 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1595 can update the title when appropriate. Otherwise the title is wrong if the
1596 pages are added after adding the notebook to the dialog.
1597 This must be a problem in HildonWizardDialog too.
1598 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1600 * src/maemo/easysetup/modest-easysetup-wizard.c:
1601 (create_subsequent_customsetup_pages),
1602 (create_subsequent_easysetup_pages):
1603 Call modest_wizard_dialog_force_title_update() so that the title is
1604 correct even with GTK+ < 2.10.
1605 This fixes projects.maemo.org bug NB#56145 .
1607 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1609 * src/maemo/modest-platform.c:
1610 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1611 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1614 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1616 * src/widgets/modest-window.h:
1617 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1618 and modest_window_save_state(), which invokes it.
1620 * src/widgets/modest-window-mgr.h:
1621 * src/widgets/modest-window-mgr.c:
1622 Added modest_window_mgr_save_state_for_all_windows(), which calls
1623 the save_state vfunc on all registered windows, if implemented.
1625 * src/gnome/modest-msg-edit-window.c:
1626 * src/gnome/modest-msg-view-window.c:
1627 * src/maemo/modest-msg-edit-window.c:
1628 * src/maemo/modest-msg-view-window.c:
1629 * src/maemo/modest-main-window.c:
1630 Specify the existing save_settings functions as implementations of
1631 ModestWindow::save_state_func().
1633 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1634 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1635 enabling hibernation, for instance.
1637 We may need to do the same thing for restoring settings.
1640 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1642 * src/widgets/modest-window-mgr.c:
1643 * src/widgets/modest-window-mgr.h:
1644 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1645 modest_window_mgr_get_hibernation_is_prevented().
1647 * src/maemo/modest-main-window.c:
1648 (on_hildon_program_is_topmost_notify): Prevent hibernation
1649 (possible when the application goes to the background in the WM),
1650 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1652 * src/maemo/easysetup/modest-easysetup-wizard.c:
1653 (modest_easysetup_wizard_dialog_init):
1654 * src/maemo/modest-account-settings-dialog.c:
1655 (modest_account_settings_dialog_init):
1656 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1657 (modest_connection_specific_smtp_edit_window_init):
1658 * src/maemo/modest-connection-specific-smtp-window.c:
1659 (modest_connection_specific_smtp_window_init):
1660 * src/maemo/modest-signature-editor-dialog.c:
1661 (modest_signature_editor_dialog_init):
1662 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1663 prevent hibernation while any of these account settings dialogs are open.
1665 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1667 * src/maemo/Makefile.am:
1668 * src/maemo/modest-osso-state-saving.c:
1669 * src/maemo/modest-osso-state-saving.h: Added
1670 modest_osso_load_state() and modest_osso_save_state() though they do
1671 nothing now. They should iterate through all the open windows and load/save
1673 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1674 save state when closing.
1676 * src/maemo/modest-main-window.c:
1677 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1678 Add a notification handler for the HildonProgram::is-topmost property,
1679 so we can allow hibernation when the application goes into the background.
1680 But we still need to detect when the accounts setup windows are open so
1681 we can stop hibernation when they are open.
1682 To do this, I also added the main window the HildonProgram. This might have
1683 other side-effects/benefits, and should maybe be done for other windows.
1685 * src/maemo/modest-osso-autosave-callbacks.h:
1686 * src/maemo/modest-osso-autosave-callbacks.c:
1687 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1688 though it does not do anything yet, and we might never need this to do
1689 anything. For instance, we already save drafts.
1691 * src/maemo/modest-platform.c: (modest_platform_init):
1692 Specify the libosso auto-save callback.
1694 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1696 * src/maemo/modest-platform.c:
1697 (modest_platform_set_update_interval):
1698 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1699 aparently stays valid between application instances, so we can use this
1700 to remove and reset it later. According to a maemo-developers email from
1703 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1705 * configure.ac: Depend on libalarm for Maemo.
1707 * src/dbus_api/modest-dbus-api.h:
1708 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1709 (on_send_receive), (modest_dbus_req_handler):
1710 Handle a SEND_RECEIVE D-Bus method.
1712 * libmodest-dbus-client/libmodest-dbus-client.c:
1713 (libmodest_dbus_client_send_and_receive):
1714 * libmodest-dbus-client/libmodest-dbus-client.h:
1715 Add C convenience functions for calling the new D-Bus method.
1717 * src/modest-platform.h:
1718 * src/gnome/modest-platform.c:
1719 * src/maemo/modest-platform.c:
1720 Added modest_platform_set_update_interval(), which uses the
1721 alarmd API on Maemo.
1722 (modest_platform_init),
1723 Call modest_platform_set_update_interval(), using a hard-coded
1724 interval for now (until the global settings dialog is implemented),
1725 though I am not sure that this makes sense yet.
1727 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1729 * src/dbus_api/modest-dbus-callbacks.c:
1730 (modest_osso_cb_hw_state_handler):
1731 * src/dbus_api/modest-dbus-callbacks.h:
1732 * src/maemo/modest-platform.c: (modest_platform_init):
1733 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1734 in case this has some effect on the ability for Maemo to ping the
1737 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1739 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1740 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1741 warning. It is probably a logic error, but I need to fix the build.
1743 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1745 * src/modest-account-mgr.h:
1746 * src/modest-account-mgr.c:
1747 (modest_account_mgr_account_names): Add a gboolean enabled_only
1748 parameter, so we can get lists of onlt the enabled accounts.
1750 (modest_account_mgr_add_account),,
1751 (modest_account_mgr_account_with_display_name_exists):
1752 * src/maemo/modest-msg-edit-window.c: (get_transports):
1753 * src/modest-account-mgr-helpers.c:
1754 (modest_account_mgr_set_first_account_as_default):
1755 * src/modest-init.c: (init_default_account_maybe):
1756 * src/modest-tny-account-store.c: (get_accounts):
1757 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1758 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1759 * tests/check_account-mgr.c: (START_TEST):
1760 Provide the extra parameter, as appropriate.
1762 * src/widgets/modest-account-view.c: (update_account_view):
1763 Do not show disabled accounts (meaning that there is no way to
1764 enable/disable accounts in the UI (the feature is not in our UI
1765 specification), so we can use this internally only to mark unfinished
1766 or temporary account data.
1768 * src/maemo/easysetup/modest-easysetup-wizard.c:
1769 (create_account): Add boolean enable parameter, so we can specify FALSE
1770 to create the temporary account.
1771 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1772 (on_before_next): When finishing, when there is a temporary account, just
1774 Also, use a timeout to delay the showing of the dialog until gconf is likely
1775 to return correct information, due to a maemo gconf bug that is fixed in
1776 osso 1.1, but not yet in Bora.
1777 However, the dialog stays on screen after it is destroyed.
1779 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1780 for invalid data when cancelling. Use a hildon note instead of a dialog
1781 to complain about invalid data. Do not show the account-saved note if the
1782 account is disabled (a temporary account that will not really be saved for use
1785 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1787 * src/modest-account-mgr-helpers.h:
1788 * src/modest-account-mgr-helpers.c:
1789 Added modest_account_mgr_unset_default_account(),
1790 Added modest_account_mgr_set_first_account_as_default().
1792 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1793 If it was the default account, unset the default account name.
1795 * src/maemo/modest-account-view-window.c:
1796 (on_delete_button_clicked): If it was the default account,
1797 set the first remaining account as the default instead.
1799 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1800 a NULL account or a NULL default account, to prevent a crash. This should
1801 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1804 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1806 * src/widgets/modest-recpt-editor.c:
1807 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1808 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1809 TODO comment for this. This fixes the build.
1811 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1812 be the best place for it. This will in future update all auto-update accounts,
1813 rather than just the current/default account, when that gconf key exists.
1814 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1815 if there are no accounts, before calling do_send_receive().
1816 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1818 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1819 * src/maemo/modest-main-window-ui.h:
1820 * src/maemo/modest-main-window.c: (on_connection_changed),
1821 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1822 directly, becaue the signal handler does more.
1824 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1826 * src/modest-account-mgr-helpers.c:
1827 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1828 for the case that the account does not exist.
1830 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1831 (equivalent to the modest account name) rather than the tinymail account name
1832 (equivalent to the modest account title - human readable) to get the account data.
1833 Check for null account data to prevent the crash, and add a TODO comment saying that
1834 this needs fixing because it is using the server account name instead of the account name.
1836 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1838 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1839 * src/maemo/modest-account-settings-dialog.c: (show_error),
1841 Use hildon_note_new_information() for informative and error messages,
1842 which seems to be expected for Maemo applications (no documentation that I know of
1843 says this). I am surprised that there is no distinction between info and error
1846 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1848 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1849 it is easy to find where this is used.
1851 * src/maemo/easysetup/modest-easysetup-wizard.c:
1852 (create_page_welcome), (create_page_account_details),
1853 (create_page_user_details), (create_page_complete_easysetup),
1854 (create_page_custom_incoming), (create_page_custom_outgoing),
1855 (create_page_complete_custom):
1856 * src/maemo/modest-account-settings-dialog.c:
1857 (create_page_account_details), (create_page_user_details),
1858 (create_page_incoming), (create_page_outgoing):
1859 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1860 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1861 (modest_connection_specific_smtp_edit_window_init):
1862 * src/maemo/modest-connection-specific-smtp-window.c:
1863 (modest_connection_specific_smtp_window_init):
1864 * src/maemo/modest-signature-editor-dialog.c:
1865 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1866 and scrolling policy as per the Email Application Layout Guide, if I have
1869 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1871 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1872 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1873 which were empty, because these vfuncs have been removed from TnyAccountStore.
1874 This fixes the build.
1876 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1878 * src/maemo/modest-main-window.c:
1879 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1880 showing/hiding it. Added TODO because it probably should not be NULL.
1881 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1882 because unnecessary g_warnings() make degugging difficult.
1884 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1886 * src/maemo/modest-msg-edit-window.c:
1887 (modest_msg_edit_window_select_color),
1888 (modest_msg_edit_window_select_background_color): 2 const corrections and
1889 moving 2 #endifs before closing brackets, to fix the build.
1891 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1893 * src/maemo/easysetup/modest-easysetup-wizard.h:
1894 * src/maemo/easysetup/modest-easysetup-wizard.c:
1895 (modest_easysetup_wizard_dialog_finalize),
1896 (on_button_edit_advanced_settings), (create_page_complete_custom),
1897 (on_response), (create_account):
1898 Implement the Advanced Settings edit button, by saving the account information,
1899 for the Advanded Settings dialog to use directly from gconf, and removing it
1900 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1901 Bug #5533 in the projects.maemo.org bugzilla.
1903 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1905 * src/maemo/modest-msg-view-window.c:
1906 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1907 when opening a message window.
1909 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1911 * src/maemo/easysetup/modest-easysetup-wizard.c:
1912 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1915 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1916 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1917 gconf settings. I probably added more checks than necessary, but that is safer.
1919 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1920 variable to fix the build, but this seems to be used when it is still NULL.
1922 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1924 * src/modest-platform.h:
1925 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1926 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1927 * src/modest-main.c: Implement this function so we can avoid using
1928 maemo-specific API from cross-platform code.
1930 * src/modest-tny-account-store.c:
1931 (get_smtp_specific_transport_account_for_open_connection):
1932 * src/modest-ui-actions.c: (check_for_connection),
1933 (modest_ui_actions_on_item_not_found):
1934 Use modest_platform_connect_and_wait() and put #idefs around other
1935 maemo-specific code, because only maemo currently has a way to
1936 identify connection names.
1938 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1940 * src/modest-tny-account-store.h:
1941 * src/modest-tny-account-store.c:
1942 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1943 the connection-specific SMTP server settings in the configuration.
1945 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1947 * src/maemo/modest-main-window.c: (on_connection_changed),
1949 * src/modest-main.c: (main), (start_ui), (send_mail):
1950 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1951 that is what is intended.
1953 * src/modest-ui-actions.c: (action_send), (action_receive),
1954 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1955 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1956 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1957 SMTP server is used when it is specified.
1959 (modest_ui_actions_on_send_receive):
1960 Check that a connection is open before proceeding.
1961 Receive and then send, instead of vice-versa, as per the specification.
1963 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1965 * src/modest-mail-operation.c:
1966 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1967 though I guess it should be something other than NULL.
1969 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1971 * src/maemo/easysetup/modest-easysetup-wizard.c:
1972 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1973 combo twice, to avoid an g_warning and to make it visible again.
1974 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1975 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1976 (already intended) dereference when detaching, because we then recreate the menu.
1977 But I am not sure why the warning was happening, and it is possible that this is a memory
1980 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1982 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1983 and uri_parse_mailto() utility functions.
1984 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1986 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1988 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1990 * src/dbus_api/modest-dbus-api.h:
1991 * src/dbus_api/modest-dbus-callbacks.c:
1992 Use an idle callback to execute the modest code in the application's own thread.
1993 Remove the helloworld example method.
1994 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1995 parsed, and the open-message method is not implemented because this is not yet implemented in
1997 * libmodest-dbus-client/libmodest-dbus-client.c:
1998 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1999 (libmodest_dbus_client_open_message):
2000 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2002 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2003 body without crashing.
2005 * tests/dbus_api/Makefile.am:
2006 * tests/dbus_api/test_mail_to.c:
2007 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2009 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2011 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2012 Added file to fix the build. Sorry.
2014 * src/dbus_api/Makefile.am:
2015 * src/dbus_api/modest-dbus-api.h:
2016 * src/dbus_api/modest-dbus-callbacks.h:
2017 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2018 (modest_dbus_req_handler):
2019 Put constants in a separate header so it can be reused by the
2020 client library, without duplication
2022 * libmodest-dbus-client/Makefile.am:
2023 * libmodest-dbus-client/libmodest-dbus-client.c:
2024 (libmodest_dbus_client_call_helloworld),
2025 (libmodfest_dbus_client_send_mail),
2026 (libmodfest_dbus_client_mailto),
2027 (libmodfest_dbus_client_open_message):
2028 * libmodest-dbus-client/libmodest-dbus-client.h:
2029 (Partly) Implement a send_mail D-Bus method.
2031 * tests/dbus_api/Makefile.am:
2032 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2033 the send_email D-Bus method.
2035 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2039 * libmodest-dbus-client/Makefile.am:
2040 * libmodest-dbus-client/libmodest-dbus-client.c:
2041 * libmodest-dbus-client/libmodest-dbus-client.h:
2042 * tests/dbus_api/Makefile.am:
2043 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2044 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2046 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2048 * src/maemo/easysetup/modest-easysetup-wizard.c:
2049 (create_page_account_details):
2050 * src/maemo/modest-account-settings-dialog.c:
2051 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2052 widgets, because this might not be the default in future versions of the Maemo GTK+.
2053 However, I can not not get capitalization to work even in a simple test case.
2055 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2057 * src/maemo/easysetup/modest-easysetup-wizard.c:
2058 (create_page_custom_incoming), (create_page_custom_outgoing):
2059 * src/maemo/modest-account-settings-dialog.c:
2060 (create_page_account_details), (create_page_incoming),
2061 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2062 instead of using gtk_check_button_with_label(), so they are aligned like the other
2063 widgets, as per the UI spec.
2065 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2067 * src/maemo/easysetup/modest-easysetup-wizard.c:
2068 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2069 * src/widgets/modest-validating-entry.c:
2070 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2071 Modest prefix instead of an EasySetup prefix.
2073 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2075 * src/widgets/modest-validating-entry.h:
2076 * src/widgets/modest-validating-entry.c: (on_insert_text),
2077 Added easysetup_validating_entry_set_max_func(), used to set a callback
2078 to call when the max number of characters is reached. GtkEntry has a max-length
2079 already but is silent about it.
2081 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2082 (create_page_account_details), (create_page_user_details),
2084 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2085 (create_page_account_details), (create_page_user_details),
2086 (create_page_outgoing):
2087 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2088 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2089 the UI spec, when the user tries to enter more than the max number of characters.
2091 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2093 * src/maemo/easysetup/modest-easysetup-wizard.c:
2094 (create_page_user_details), (create_page_custom_incoming),
2095 (create_page_custom_outgoing):
2096 * src/maemo/modest-account-settings-dialog.c:
2097 (create_page_user_details), (create_page_incoming),
2098 (create_page_outgoing):
2099 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2100 (modest_connection_specific_smtp_edit_window_init):
2101 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2102 not appropriate. Bad Maemo-specific defaults!.
2104 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2106 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2107 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2108 (modest_signature_editor_dialog_set_settings):
2109 Disable the label and textview when the checkbox is disabled, and use the
2110 specified (UI spec) default signature text.
2112 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2114 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2115 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2117 * src/modest-defs.h:
2118 * src/modest-account-mgr-helpers.h:
2119 * src/modest-account-mgr-helpers.c:
2120 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2122 * src/maemo/Makefile.am:
2123 * src/maemo/modest-signature-editor-dialog.c:
2124 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2127 * src/maemo/modest-account-settings-dialog.h:
2128 * src/maemo/modest-account-settings-dialog.c:
2129 (modest_account_settings_dialog_finalize), (on_button_signature),
2130 (save_configuration): Use the new dialog when the Edit button is pressed, and
2131 save the changes if necessary, as per the UI spec.
2133 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2135 * src/maemo/Makefile.am:
2136 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2137 based on maemo-develoers email from Dirk.
2139 * src/maemo/easysetup/modest-easysetup-wizard.c:
2140 (create_page_welcome), (create_page_account_details),
2141 (create_page_user_details), (create_page_complete_easysetup),
2142 (create_page_custom_incoming), (create_page_custom_outgoing),
2143 (create_page_complete_custom),
2144 (modest_easysetup_wizard_dialog_init):
2145 * src/maemo/modest-account-settings-dialog.c:
2146 (create_page_account_details), (create_page_user_details),
2147 (create_page_incoming), (create_page_outgoing),
2148 (modest_account_settings_dialog_init):
2149 * src/maemo/modest-connection-specific-smtp-window.c:
2150 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2152 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2154 * src/maemo/easysetup/modest-easysetup-wizard.c:
2155 (create_page_account_details), (create_page_custom_outgoing),
2156 (create_page_complete_custom):
2157 * src/maemo/modest-account-settings-dialog.c:
2158 (create_page_user_details), (create_page_incoming),
2159 (create_page_outgoing):
2160 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2161 (modest_connection_specific_smtp_edit_window_init):
2162 Use the correct (UI spec) port min/max, and use horizontal separators,
2165 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2167 * src/maemo/easysetup/modest-easysetup-wizard.c:
2168 (set_default_custom_servernames):
2169 * src/maemo/modest-account-settings-dialog.c:
2170 (create_page_incoming), (on_combo_outgoing_security_changed),
2171 (on_combo_incoming_security_changed), (create_page_outgoing),
2172 (modest_account_settings_dialog_set_account_name),
2173 (save_configuration):
2174 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2175 (on_combo_security_changed),
2176 (modest_connection_specific_smtp_edit_window_init),
2177 (modest_connection_specific_smtp_edit_window_set_connection),
2178 (modest_connection_specific_smtp_edit_window_get_settings):
2179 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2182 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2185 * src/maemo/easysetup/modest-easysetup-wizard.c:
2186 (create_page_custom_outgoing), (create_page_complete_custom):
2187 * src/maemo/modest-account-settings-dialog.c:
2188 (create_page_user_details), (create_page_outgoing):
2189 * src/maemo/modest-account-view-window.c: (button_box_new):
2190 Use changed logical IDs as per the most recent UI spec:
2191 mcen_bd_emailsetup_edit -> mcen_bd_edit
2192 mcen_bd_emailsetup_delete -> mcen_bd_delete
2193 mcen_bd_emailsetup_close -> mcen_bd_close
2195 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2199 * src/dbus_api/Makefile.am:
2200 * src/dbus_api/modest-dbus-callbacks.c:
2201 * src/dbus_api/modest-dbus-callbacks.h:
2202 * src/maemo/modest-platform.c: (modest_platform_init):
2203 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2205 * tests/Makefile.am:
2206 * tests/dbus_api/Makefile.am:
2207 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2209 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2211 * src/maemo/modest-account-settings-dialog.c:
2212 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2213 Removed unnecessary includes.
2215 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2217 * src/maemo/easysetup/modest-easysetup-wizard.c:
2218 * src/maemo/modest-account-settings-dialog.c:
2219 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2220 * src/widgets/Makefile.am:
2221 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2222 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2223 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2224 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2225 * src/widgets/modest-secureauth-combo-box.c:
2226 * src/widgets/modest-secureauth-combo-box.h:
2227 * src/widgets/modest-serversecurity-combo-box.c:
2228 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2229 made the GObject names more consistent with the rest of the Modest code.
2231 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2233 * src/maemo/easysetup/Makefile.am:
2234 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2235 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2236 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2237 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2238 * src/maemo/easysetup/modest-easysetup-wizard.c:
2239 * src/maemo/easysetup/modest-validating-entry.c:
2240 * src/maemo/easysetup/modest-validating-entry.h:
2241 * src/maemo/modest-account-settings-dialog.c:
2242 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2243 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2244 widgets/ because they are used outside of easysetup too. After checking in,
2245 svn will allow me to rename them too.
2247 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2249 * src/gnome/modest-msg-edit-window.c:
2250 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2251 linker error, to fix the build on the GNOME platform.
2252 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2253 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2254 ifdefed out to avoid a warning.
2256 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2258 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2259 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2260 some alternative for GTK+ 2.6.
2262 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2264 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2266 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2267 specified for EmailAccountsDialog in UI spec.
2269 * src/maemo/easysetup/modest-easysetup-wizard.c:
2270 * src/maemo/easysetup/modest-easysetup-wizard.h:
2271 * src/maemo/modest-account-settings-dialog.c:
2272 * src/maemo/modest-account-settings-dialog.h:
2273 Reuse a member window widget for the connection-specific SMTP server accounts,
2274 so we can tell it to create/save the accounts only if we actually save changes.
2276 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2277 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2278 (modest_connection_specific_smtp_edit_window_get_settings):
2279 Return a struct instance for temporarily remembering the entered data.
2281 * src/maemo/modest-connection-specific-smtp-window.h:
2282 * src/maemo/modest-connection-specific-smtp-window.c:
2283 (modest_connection_specific_smtp_window_finalize),
2284 (modest_connection_specific_smtp_window_fill_with_connections),
2286 (modest_connection_specific_smtp_window_save_server_accounts),
2287 (update_model_server_names): Do not actually save data until asked,
2288 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2290 (on_selection_changed),
2291 (modest_connection_specific_smtp_window_init): Disable the edit
2292 button when nothing is selected.
2294 * src/modest-account-mgr-helpers.c:
2295 * src/modest-account-mgr-helpers.h:
2296 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2299 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2301 * src/modest-account-mgr-helpers.h:
2302 * src/modest-account-mgr-helpers.c:
2303 (modest_account_mgr_get_unused_account_name),
2304 (modest_account_mgr_get_unused_account_display_name): Added these
2305 utility functions, to avoid code duplication.
2307 * src/maemo/easysetup/modest-easysetup-wizard.c:
2308 (create_page_account_details), (create_account):
2309 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2310 (on_combo_security_changed),
2311 (modest_connection_specific_smtp_edit_window_init),
2312 (modest_connection_specific_smtp_edit_window_save_settings):
2313 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2314 * src/maemo/modest-connection-specific-smtp-window.c:
2315 (modest_connection_specific_smtp_window_finalize),
2316 (modest_connection_specific_smtp_window_fill_with_connections),
2317 (on_button_edit), (modest_connection_specific_smtp_window_init):
2318 * src/maemo/modest-connection-specific-smtp-window.h:
2319 Implementing saving of connection-specific server accounts.
2321 But I need to refactor this so we can save the data for each
2322 possible connection-specific account and only actually create the server accounts
2323 when the easysetup finished, or the OK button is pressed on the account settings
2326 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2328 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2329 (on_combo_security_changed):
2330 (modest_connection_specific_smtp_edit_window_init):
2331 Auto-fill the port number as in the account settings.
2333 (modest_connection_specific_smtp_edit_window_set_connection):
2334 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2335 * src/maemo/modest-connection-specific-smtp-window.c:
2336 (fill_with_connections), (on_button_edit),
2337 (modest_connection_specific_smtp_window_init):
2338 Turn the edit window into a dialog to simplify the code, and
2339 set a WM hint as in a GtkDialog, because only a popup can be on top of
2340 another window in Maemo, and popups usually have no WM decoration.
2342 * src/modest-defs.h:
2343 * src/modest-account-mgr-helpers.c:
2344 (modest_account_mgr_set_connection_specific_smtp),
2345 (modest_account_mgr_remove_connection_specific_smtp),
2346 (modest_account_mgr_get_connection_specific_smtp):
2347 * src/modest-account-mgr-helpers.h: Some functions to write the
2348 connection-specific SMTP server information. Not yet used.
2351 * src/widgets/modest-folder-view.c: (text_cell_data):
2352 Fix a warning about an uninitialized variable.
2353 (on_configuration_key_changed): Put an #ifdef around the use
2354 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2356 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2358 * src/maemo/modest-account-settings-dialog.h:
2359 * src/maemo/modest-account-settings-dialog.c:
2360 Added connect_for_modified() utility function to mark the new modified boolean.
2362 (create_page_account_details), (create_page_user_details),
2363 (create_page_incoming), (create_page_outgoing), (on_response),
2364 (modest_account_settings_dialog_init),
2365 (modest_account_settings_dialog_set_account_name):
2366 Only warn about unsaved changes when there are actually unsaved changes.
2368 * src/modest-account-mgr-helpers.c:
2369 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2370 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2371 to get the data from there in future.
2373 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2375 * src/modest-defs.h:
2377 * src/modest-account-mgr-helpers.h:
2378 * src/modest-account-mgr-helpers.c:
2379 Store the security account setting in a single conf key instead of using
2380 the options list, so that the list is left for just the to-be-removed camel hack,
2381 and because gconf_client_set_list() is failing for some reason.
2383 * src/modest-account-mgr.c:
2384 (modest_account_mgr_add_server_account):
2385 * src/maemo/modest-account-settings-dialog.c:
2386 (modest_account_settings_dialog_set_account_name),
2387 (save_configuration): Use the renamed functions.
2390 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2392 * src/widgets/Makefile.am:
2393 * src/widgets/modest-limit-retrieve-combo-box.c:
2394 * src/widgets/modest-limit-retrieve-combo-box.h:
2395 * src/widgets/modest-retrieve-combo-box.c:
2396 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2397 the account settings dialog.
2399 * src/modest-defs.h:
2400 * src/modest-account-mgr-helpers.h:
2401 * src/modest-account-mgr-helpers.c:
2402 (modest_server_account_get_option_secure_auth),
2403 (modest_server_account_set_option_secure_auth):
2404 * src/modest-account-mgr.c:
2405 (modest_account_mgr_add_server_account):
2406 Use the existing AUTH_MECH conf key for the secure-auth setting,
2407 instead of putting it in the list options, because this was actually used already.
2409 * src/maemo/modest-account-settings-dialog.c:
2410 (create_page_account_details),
2411 (modest_account_settings_dialog_set_account_name),
2412 (save_configuration):
2413 * src/maemo/modest-account-settings-dialog.h:
2414 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2415 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2417 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2419 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2420 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2421 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2423 * src/modest-defs.h:
2424 * src/maemo/modest-account-settings-dialog.c:
2425 (create_page_incoming), (on_combo_outgoing_security_changed),
2426 (on_combo_incoming_security_changed), (create_page_outgoing),
2427 (modest_account_settings_dialog_set_account_name),
2428 (save_configuration): Load/Save the port number, and change it when the
2429 security combo changes, to suitable defaults.
2431 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2433 * src/modest-account-mgr.c:
2434 (modest_account_mgr_add_server_account): Set the security and secure-auth
2435 options, and add a comment saying that the other camel-specific options should be
2438 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2440 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2442 * src/modest-tny-account-store.c: (account_list_free),
2443 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2444 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2447 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2449 * src/modest-protocol-info.c:
2450 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2451 is required by our UI spec. Maybe something in our implementation will use this eventually.
2452 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2453 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2454 instead of the previous 0 placeholder.
2456 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2457 secure-auth settings.
2458 * src/modest-account-mgr-helpers.h:
2459 * src/modest-account-mgr-helpers.c:
2460 (modest_server_account_data_get_option_secure_auth),
2461 (modest_server_account_set_option_secure_auth),
2462 (modest_server_account_data_get_option_security),
2463 (modest_server_account_set_option_security): Added this API for getting and setting the security
2464 and secure-auth settings.
2466 * src/maemo/modest-account-settings-dialog.h:
2467 * src/maemo/modest-account-settings-dialog.c:
2468 (modest_account_settings_dialog_finalize), (check_data),
2469 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2470 about changing titles.
2471 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2472 (save_configuration): Save the security and secure-auth settings.
2474 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2475 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2477 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2479 * src/modest-defs.h:
2480 * src/modest-account-mgr.c:
2481 (modest_account_mgr_add_server_account):
2482 Added and used defines for the options key and value pair strings,
2483 that are used so far, though they do not seem to correspond to anything in our
2484 UI specs or ModestProtocol enum.
2486 * src/modest-account-mgr-helpers.h:
2487 * src/modest-account-mgr-helpers.c:
2488 (compare_option_strings_for_name),
2489 (modest_server_account_data_get_option_value),
2490 (modest_server_account_data_get_option_bool),
2491 (modest_account_mgr_get_server_account_option):
2492 Added helper functions for parsing the options GSList.
2494 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2496 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2497 display name is based on the supplied account name.
2498 * src/modest-account-mgr.c:
2499 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2500 with an inefficient, but good-enough, implementation.
2502 * src/maemo/easysetup/modest-easysetup-wizard.c:
2503 (create_page_account_details), (on_before_next), (create_account):
2504 Check for existing display names rather than (non-user-visible) account names, and just
2505 create and set a unique account name at the end.
2507 * src/maemo/modest-account-settings-dialog.c:
2508 (modest_account_settings_dialog_init),
2509 (modest_account_settings_dialog_set_account_name),
2510 (create_page_incoming): Show the display name, instead of the account name.
2511 (on_response): Do some (not all) extra checks, as in the UI spec.
2512 (save_configuration): Save the display name if it was changed.
2514 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2516 * po/en_GB.po: Added needed logical ID and translation.
2517 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2518 (init_view): Made the is-default column clicking work.
2520 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2523 * src/maemo/easysetup/Makefile.am:
2524 * src/maemo/easysetup/modest-easysetup-wizard.c:
2525 (modest_easysetup_wizard_dialog_init):
2526 * src/maemo/easysetup/provider-data-test.keyfile:
2527 * src/maemo/easysetup/provider-data.keyfile:
2528 Moved the provider data file to the new modest-providers-data package and used it from there.
2530 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2532 * src/modest-local-folder-info.c:
2533 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2534 N_() was already used on the static strings, but this just marks it for translation without
2535 using the translation.
2537 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2539 * src/maemo/modest-account-settings-dialog.c:
2540 (create_page_incoming),
2541 (modest_account_settings_dialog_set_account_name):
2542 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2543 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2544 I will do this if nobody else gets there first.
2546 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2548 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2549 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2550 save the security stuff.
2552 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2554 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2555 Set the email address and user fullname, which I now see must be
2558 * src/maemo/modest-account-settings-dialog.h:
2559 * src/maemo/modest-account-settings-dialog.c:
2561 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2562 leave-on-server and authentication.
2563 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2566 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2569 * src/maemo/modest-account-settings-dialog.c:
2570 * src/maemo/modest-account-settings-dialog.h:
2571 Most (but not all) of the widgets are now present as specified by the UI spec.
2572 No changes are yet saved, and some details are not properly shown yet.
2574 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2576 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2578 * src/maemo/Makefile.am:
2579 * src/maemo/modest-account-settings-dialog.c:
2580 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2581 an existing account. Doesn't do much yet.
2583 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2584 Open the accounts settings dialog when Edit is clicked.
2586 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2588 * src/maemo/easysetup/Makefile.am:
2589 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2591 * src/maemo/easysetup/modest-easysetup-wizard.c:
2592 (modest_easysetup_wizard_dialog_init):
2593 Try to get the source directory from the build system,
2594 instead of hard-coding "./" into the source code, when opening our local
2595 copies of the configuration files.
2596 But this still fails when opening the wizard from the Accounts window,
2597 maybe because the working directory seems to change at runtime.
2598 So the wizard will fail the second time unless you copy the files into their
2599 proper locations - see the stdout warnings for the paths.
2601 (create_page_account_details),(on_before_next):
2602 Check for existing non-server accounts instead of server accounts,
2603 so the default account name is useful again, and to prevent trying to
2606 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2607 Show the wizard when New is clicked.
2609 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2610 (init_view): Show the column headers, and show the columns that are
2611 specified in the UI specs. However, something in Maemo's GTK+ prevents
2612 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2613 change the default account. This is despite unsetting the special properties.
2615 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2617 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2618 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2619 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2620 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2621 to make that clearer.
2622 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2624 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2626 * src/maemo/modest-account-view-window.c:
2627 (modest_account_view_window_init),
2628 (modest_account_view_window_new):
2629 Use the same buttons as specified in the
2630 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2631 the existing widgets, which never had a chance of working.
2632 Put the ModestAccountView treeview in a scrolled window.
2633 Do not repeat the initialization in both _init() and _new().
2635 * src/widgets/modest-account-view.c: (update_account_view):
2636 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2637 this widget and window shows no accounts.
2639 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2641 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2643 * src/maemo/easysetup/modest-easysetup-wizard.c:
2644 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2645 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2646 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2649 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2650 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2651 accounts exist yet, as in the UI spec.
2653 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2655 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2657 * src/maemo/Makefile.am:
2658 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2659 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2660 New window for editing connection-specific smtp details.
2661 Not fully implemented.
2663 * src/maemo/modest-connection-specific-smtp-window.c:
2664 (modest_connection_specific_smtp_window_finalize) :
2665 unref the tree model.
2666 (on_button_edit): Show the edit window.
2668 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2670 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2673 * src/maemo/Makefile.am:
2674 * src/maemo/modest-connection-specific-smtp-window.c:
2675 * src/maemo/modest-connection-specific-smtp-window.h:
2676 New window for showing the list of connections, for connection-specific
2677 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2678 * src/maemo/easysetup/modest-easysetup-wizard.c:
2679 (create_page_custom_outgoing): Show the new window when the button is clicked.
2681 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2683 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2684 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2685 * src/maemo/modest-msg-edit-window.c:
2686 (modest_msg_edit_window_insert_image):
2687 * src/modest-conf.c: (modest_conf_key_escape):
2688 * src/modest-mail-operation.c:
2689 (modest_mail_operation_send_new_mail):
2690 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2691 (modest_ui_actions_on_new_account):
2692 * src/widgets/modest-attachment-view.c: (update_filename_request):
2693 * src/widgets/modest-mail-header-view.c:
2694 Corrected warnings that were breaking the build, by commenting out unused variables,
2695 and a function, and by including a header.
2697 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2699 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2700 so we can #ifdef around platform-specific code when necessary.
2701 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2702 to allow this to build for the GNOME platform too.
2704 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2706 * src/maemo/easysetup/modest-easysetup-wizard.c:
2707 Added util_increment_name() and used it in create_page_account_details()
2708 to make sure that the default account name is always a new name.
2710 (modest_easysetup_wizard_dialog_init),
2711 (set_default_custom_servernames): Some minor memory management fixes.
2713 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2717 * src/modest-runtime.c: (init_i18n): Restored the translation
2718 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2719 are defined in config.h, and the translations are installed.
2721 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2722 is defined for translation.
2724 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2726 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2728 * src/maemo/easysetup/modest-easysetup-wizard.c:
2729 (modest_easysetup_wizard_dialog_init):
2730 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2731 Use realistic paths (though they should use $prefix generically) to the
2732 mcc_mapping and provider-data.keyfile files which might work when they
2733 are installed by the future version of the operator-wizard package,
2734 and then fallback to paths in our source code, with an explanatory
2737 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2741 * src/maemo/Makefile.am:
2742 * src/maemo/easysetup/: Added files from the previously-exernal
2743 osso-modest-easysetup.
2744 * src/maemo/modest-main-window-ui.h:
2745 * src/modest-ui-actions.c:
2746 * src/modest-ui-actions.h:
2747 Added modest_ui_actions_on_new_account() as a signal handler for the
2748 New Account menu item. It shows the easysetup wizard.
2749 * po/en_GB.po: Added additional needed logical IDs and translations.
2751 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2752 Apparently ChangeLog is not used for some vague Nokia legal reasons.