1 2007-06-13 Murray Cumming <murrayc@murrayc.com>
3 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
4 Remove unnecessary lib/include, though it is good in principle when needed.
6 * src/modest-init.c: (modest_init_one_local_folder),
7 (modest_init_local_folders):
8 * src/modest-init.h: Initialize the .modest library for memory cards,
9 instead of just doing nothing for them. This should allow us to create
10 folders there, fixing projects.maemo.org bug NB#59297.
12 2007-06-13 Murray Cumming <murrayc@murrayc.com>
14 * libmodest-dbus-client/libmodest-dbus-client.c:
15 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
16 (libmodest_dbus_client_compose_mail),
17 (libmodest_dbus_client_open_message),
18 (libmodest_dbus_client_send_and_receive),
19 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
21 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
22 (on_idle_open_message), (modest_dbus_req_handler),
23 (search_result_to_message), (modest_dbus_req_filter):
24 * src/modest-search.c: (add_hit), (modest_search_folder),
25 (modest_search_all_accounts): Improved debug messages.
27 * tests/dbus_api/test_open_message.c: (main): Improved comments.
29 * src/modest-tny-account-store.c:
30 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
33 2007-06-13 Murray Cumming <murrayc@murrayc.com>
36 2007-06-12 Murray Cumming <murrayc@murrayc.com>
38 * src/modest-tny-account-store.c: (get_server_accounts):
39 Call modest_tny_local_folders_account_add_merged_outbox_folders()
40 even when there are no accounts, so that the Outbox folder is always
41 visible. This fixes projects.maemo.org bug NB#60158.
43 2007-06-12 Murray Cumming <murrayc@murrayc.com>
45 * src/maemo/modest-main-window.c: (create_details_widget):
46 Use the mcen_va_never logical ID.
48 2007-06-12 Murray Cumming <murrayc@murrayc.com>
50 * src/dbus_api/modest-dbus-api.h:
51 * src/dbus_api/modest-dbus-callbacks.c:
52 (on_idle_open_default_inbox), (on_open_default_inbox),
53 (modest_dbus_req_handler):
54 Added a new OpenDefaultInbox method.
56 * libmodest-dbus-client/libmodest-dbus-client.h:
57 * libmodest-dbus-client/libmodest-dbus-client.c:
58 Added libmodest_dbus_client_open_default_inbox() to call the new
59 dbus method. This should be useful to projects.maemo.org bug NB#57214,
60 though it should maybe be used by a new osso-email-interface function.
62 * tests/dbus_api/Makefile.am:
63 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
66 2007-06-12 Murray Cumming <murrayc@murrayc.com>
68 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
69 NULL, so that the signals get all the keys. This should not actually
70 change any behaviour because we currently update everything when anything
73 2007-06-12 Murray Cumming <murrayc@murrayc.com>
75 * src/widgets/modest-folder-view.c: (text_cell_data),
76 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
77 (find_inbox_iter): If tinymail tells us that the folder is
78 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
79 This causes the inbox to be selected at startup, fixing part of
80 projects.maemo.org bug NB#56305.
82 * src/modest-ui-dimming-rules.c:
83 (modest_ui_dimming_rules_on_tools_smtp_servers):
84 * src/modest-ui-dimming-rules.h: Added a callback function to dim
85 the SMTP servers menu item.
86 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
87 that the SMTP Servers menu item is dimmed when there are no accounts,
88 as a future version of the UI spec will require. This fixes
89 projects.maemo.org bug NB#56305.
91 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
93 * src/maemo/modest-maemo-utils.c:
94 (modest_maemo_utils_get_supported_secure_authentication_methods):
95 Added label to dialog instead of unreadable title
97 * src/maemo/modest-main-window.c: (sync_accounts_cb),
98 (modest_main_window_new):
99 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
102 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
103 * src/modest-account-mgr.h:
104 Added method to avoid code duplication
106 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
107 (modest_ui_actions_on_send_receive):
108 Use modest_account_mgr_has_accounts
110 2007-06-11 Murray Cumming <murrayc@murrayc.com>
112 * src/maemo/easysetup/modest-presets.c:
113 (modest_presets_get_info_server_security): Do not report secure auth
115 * src/modest-protocol-info.c: Use the defines for the gconf key names
116 for secure authentication. This was not working because we were writing
117 Password and reading password, and the check was case sensitive.
118 With this, gmail now works for receiving and sending when created via
121 2007-06-11 Murray Cumming <murrayc@murrayc.com>
123 * src/maemo/easysetup/modest-presets.c:
124 (modest_presets_get_info_server_security): Correct the key name for
125 SecureSmtp, because it seems to be case-sensitive.
126 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
127 Do not try to get the 0th notebook page if there are 0 pages, to
130 2007-06-11 Murray Cumming <murrayc@murrayc.com>
132 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
133 Prevent use of the new notification feature for now, because it currently
134 shows one dialog for each new email, which is annoying.
136 2007-06-11 Murray Cumming <murrayc@murrayc.com>
138 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
139 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
140 when no country was selected, so that we show the global ones.
141 * src/maemo/easysetup/modest-presets.c:
142 (modest_presets_get_providers): Return only the global providers, not
143 all providers when mmc=0 was requested.
145 2007-06-11 Murray Cumming <murrayc@murrayc.com>
147 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
148 (easysetup_provider_combo_box_fill): Remove debug code that showed the
149 provider ID in the combo.
151 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
152 Do not show the page numbers, because it would be confusing when we add
153 the 2 extra pages for the custom setup, when the user chooses the "Other"
154 provider. This fixes projects.maemo.org bug NB#59028
156 * src/modest-init.c: (modest_init_init_core),
157 (modest_init_local_folders):
159 * src/modest-tny-account.c:
160 (modest_tny_account_new_for_local_folders): Do not create default folders
161 for the memory card. This should fix projects.maemo.org bug NB#59328.
163 2007-06-11 Murray Cumming <murrayc@murrayc.com>
165 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
166 Free the changed_conf_keys string items. They are already freed in the
167 idle handler if that runs first.
169 2007-06-11 Murray Cumming <murrayc@murrayc.com>
171 * src/modest-ui-actions.c:
172 (modest_ui_actions_on_password_requested): Check that the server name
173 is not NULL, because I just saw a password dialog with (null) as the
176 * src/modest-tny-folder.[h|c]: Added
177 modest_tny_folder_is_memory_card_folder().
178 * src/modest-ui-dimming-rules.c:
179 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
180 menu item for memory cards, as per the UI spec (section 7.4). This should
181 fix projects.maemo.org bug NB#59297.
183 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
185 * src/maemo/modest-main-window.c: (sync_accounts_cb):
186 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
187 is another problem with the code, see Murray's comment at line 772)
189 2007-06-08 Murray Cumming <murrayc@murrayc.com>
191 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
192 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
193 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
194 (load_from_file), (easysetup_country_combo_box_init),
195 (easysetup_country_combo_box_get_active_country_ids),
196 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
197 instead of just one ID, to avoid duplicate country names in the UI.
199 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
200 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
201 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
202 a single ID, avoiding duplicate providers.
203 * src/maemo/easysetup/modest-easysetup-wizard.c:
204 (on_combo_account_country): Adapt to use a list.
206 2007-06-08 Murray Cumming <murrayc@murrayc.com>
208 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
209 keys changed in the last X seconds.
211 * src/modest-account-mgr.h:
212 * src/modest-account-mgr.c: (on_timeout_notify_changes),
213 (on_key_change), (modest_account_mgr_class_init),
214 (modest_account_mgr_init), (modest_account_mgr_finalize):
215 As the keys are changed, save them in a GSList* and signal that GSList*
216 further every X seconds, to batch changes, to allow us to do just one
217 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
218 bug NB#56941 and other (UI-blocking) delays when changing account settings.
220 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
221 changed signal signature.
223 * src/modest-conf.c: (modest_conf_set_list),
224 (modest_conf_on_change): Reenable notification.
226 (modest_conf_maemo_fake_on_change): Comment out the hack that
227 notified immediately instead of asynchronously.
229 * src/widgets/modest-account-view.h:
230 * src/widgets/modest-account-view.c:
231 (update_account_view): Select the previously-selected account ID,
232 if possible. This fixes projects.maemo.org bug NB#56933.
234 (on_account_changed), (on_account_removed),
235 (modest_account_view_select_account):
237 Remove the block/unblock functions
238 because they were not useful.
240 * src/maemo/modest-account-view-window.c:
241 (on_delete_button_clicked), (on_edit_button_clicked),
242 (on_new_button_clicked): Remove the use of the non-working block/unblock.
244 2007-06-08 Murray Cumming <murrayc@murrayc.com>
246 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
247 Improve the error dialog to show Incorrect Account Settings, which seems
248 clearer, and say that the internal error message (to be removed from the
249 dialog later) is often misleading.
250 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
252 * src/modest-tny-account.c:
253 (modest_tny_account_new_from_server_account): Uncomment the printf of the
254 URL because this is so useful for debugging on the device.
256 * src/widgets/modest-serversecurity-combo-box.c:
257 (modest_serversecurity_combo_box_fill): Correct a logical ID.
259 2007-06-08 Murray Cumming <murrayc@murrayc.com>
261 * src/modest-mail-operation.c:
262 (modest_mail_operation_send_new_mail):
263 Added a comment about a nasty but apparently harmless message. Details
264 added to the wiki g_warnings() page.
266 2007-06-08 Murray Cumming <murrayc@murrayc.com>
268 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
269 (modest_tny_send_queue_class_init):
270 Do not use the priv struct because it is empty, to avoid g_warnings
271 about a non-existant priv struct.
273 * src/modest-tny-account-store.c:
274 (modest_tny_account_store_get_server_account),
275 (modest_tny_account_store_get_transport_account_for_open_connection
276 ): Do not try to get transport server accounts for local folders,
277 because they don't have any. This avoids a g_warning().
279 * src/maemo/modest-main-window.c:
280 (modest_main_window_notify_send_receive_initied),
281 (on_configuration_key_changed):
282 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
284 * src/modest-mail-operation.c:
285 (modest_mail_operation_update_account):
286 * src/modest-tny-account-store.h:
287 * src/modest-tny-account.c:
288 (modest_tny_account_get_special_folder),
289 (modest_tny_account_new_for_local_folders),
290 (modest_tny_account_new_for_per_account_local_outbox_folder):
291 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
292 * src/modest-tny-local-folders-account.c:
293 (add_account_folders_to_merged_folder):
294 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
295 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
296 (modest_ui_actions_on_send):
297 * src/widgets/modest-folder-view.c: (update_model):
298 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
299 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
300 modest_tny_account_store_get_tny_account_by_account() to
301 modest_tny_account_store_get_server_account() to make the code clearer.
303 2007-06-07 Marcus Bauer <marcusb@openismus.com>
305 * src/dbus_api/modest-dbus-api.h:
306 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
307 * src/maemo/modest-msg-edit-window.c:
308 (modest_msg_edit_window_attach_file_noninteractive):
309 added g_warning in case the file to be attached does not exist
310 * tests/dbus_api/test_compose_mail.c: (main):
311 removed obsolete comment, added generic files as test case
313 2007-06-07 Murray Cumming <murrayc@murrayc.com>
315 * src/modest-tny-account-store.c: (get_server_accounts):
316 Create the local folders account only once, not once for each outbox, and
317 not only when there are some outboxes.
319 2007-06-07 Murray Cumming <murrayc@murrayc.com>
321 * src/widgets/modest-folder-view.c: (update_model): Comment out some
322 code that is causing a crash at startup. Sergio says that he is fixing this.
324 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
326 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
327 * src/maemo/modest-account-settings-dialog.c:
328 (create_page_outgoing),
329 (modest_account_settings_dialog_set_account_name),
330 (save_configuration):
331 - Fixed handling of the "Use secure authentication" toggle to comply with
332 the ui specification. See also projects.maemo.org bug NB#58400
334 - Restore the Secure connection setting combo correctly when loading
337 * src/maemo/modest-maemo-utils.c:
338 (on_camel_account_get_supported_secure_authentication),
339 (modest_maemo_utils_get_supported_secure_authentication_methods):
340 Fixed a crasher if operation is canceled
342 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
343 (modest_protocol_info_auth_is_secure):
344 * src/modest-protocol-info.h:
346 Added two new methods to determine if a protocol/auth method is secure/encrypted in
347 the sense of the "Use secure authentication" toggle.
349 2007-06-07 Murray Cumming <murrayc@murrayc.com>
351 * src/modest-tny-account-store.h:
352 * src/modest-tny-account-store.c:
353 Added modest_tny_account_store_get_local_folders_account().
355 * src/modest-tny-folder.h:
356 * src/modest-tny-folder.c:
357 (modest_tny_folder_get_account):
358 Added this replacement for tny_folder_get_account() which returns
359 the local-folders account for TnyMergeFolders, to avoid the
360 warning about the unimplemented get_account_func() vfunc().
362 (modest_tny_folder_get_rules),
363 * src/modest-ui-actions.c:
364 (modest_ui_actions_on_folder_selection_changed):
365 * src/modest-mail-operation.c:
366 (modest_mail_operation_remove_folder),
367 (modest_mail_operation_xfer_folder),
368 (modest_mail_operation_rename_folder),
369 (modest_mail_operation_get_msg),
370 (modest_mail_operation_get_msgs_full),
371 (modest_mail_operation_remove_msg),
372 (modest_mail_operation_xfer_msgs),
373 (modest_mail_operation_refresh_folder):
374 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
376 2007-06-07 Murray Cumming <murrayc@murrayc.com>
378 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
379 (modest_server_account_set_security):
380 * src/modest-defs.h: Add comments explaining that our
381 UI spec means TLS when it says Normal, so these do not look like errors.
383 * src/modest-tny-account.c:
384 (modest_tny_account_new_from_server_account): Use the new tinymail
385 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
386 for TLS. This should fix projects.maemo.org bug NB#58460.
388 2007-06-06 Murray Cumming <murrayc@murrayc.com>
390 * src/maemo/easysetup/modest-easysetup-wizard.c:
391 (create_account): Correct the position of the gconf sanity check warning.
392 (on_button_edit_advanced_settings): Show the dialog immediately, instead
393 of using the g_idle_add() hack, because this does not seem to be necessary
394 on osso 1.1. It might even work on Maemo Bora if the problems were actually
395 caused by something other than maemo's gconf.
396 This fixes projects.maemo.org bug #59022.
398 2007-06-06 Murray Cumming <murrayc@murrayc.com>
400 * src/modest-account-mgr-helpers.c:
401 (modest_account_mgr_get_default_account): Do not check that the account
402 exists if there is no default account (NULL), to fix a runtime warning.
404 2007-06-06 Murray Cumming <murrayc@murrayc.com>
406 * src/widgets/modest-folder-view.c: (update_model):
407 Do not unref the treemodel before we have finished with it.
408 This prevents a valgrind warning and an occasional crash at startup.
410 2007-06-06 Marcus Bauer <marcusb@openismus.com>
412 * libmodest-dbus-client/libmodest-dbus-client.h:
413 added libmodest_dbus_client_compose_mail()
414 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
416 added functions needed for SendAsMail() functionality
417 * src/maemo/modest-msg-edit-window.c:
418 (modest_msg_edit_window_attach_file_noninteractive):
419 non interactively attaching files to message edit window
420 * src/widgets/modest-msg-edit-window.h:
421 * tests/dbus_api/Makefile.am:
422 added test_compose_mail.c
423 * tests/dbus_api/test_compose_mail.c: (main):
425 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
427 * src/modest-account-view.c:
428 Fixed bug projects.maemo.org bug NB#59307
430 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
432 * src/maemo/easysetup/modest-easysetup-wizard.c:
433 (get_serverport_incoming), (on_before_next), (create_account):
434 * src/maemo/modest-account-settings-dialog.c:
435 (modest_account_settings_dialog_set_account_name):
436 * src/maemo/modest-maemo-utils.c:
437 (on_camel_account_get_supported_secure_authentication_status),
438 (on_camel_account_get_supported_secure_authentication),
439 (on_secure_auth_cancel),
440 (modest_maemo_utils_get_supported_secure_authentication_methods):
442 Implemented security authentication for settings and easysetup.
444 2007-06-05 Murray Cumming <murrayc@murrayc.com>
446 * src/maemo/modest-main-window.c: (create_details_widget):
447 Show the total size for memory card accounts too, instead of showing
448 the name again. Fixes bug projects.maemo.org bug NB#59307.
450 2007-06-05 Murray Cumming <murrayc@murrayc.com>
453 * src/modest-tny-simple-folder-store.c:
454 * src/modest-tny-simple-folder-store.h: Removed.
456 * src/modest-tny-local-folders-account.h
457 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
458 for the local-folders maildir, with an extra TnyMergedFolder containing
459 the folders of the per-account outbox store accounts.
460 * src/modest-tny-account-store.c: (get_server_accounts):
461 Add the outboxes to the special local folders account after creating it.
463 * src/modest-tny-account.c:
464 (modest_tny_account_new_for_local_folders): Create the derived
465 account when creating the main local-folders account.
467 * src/maemo/modest-main-window.c: (create_details_widget),
468 (modest_main_window_set_contents_style):
469 Adapted to the use of the derived account instead of the folder store.
471 * src/modest-ui-actions.c:
472 (modest_ui_actions_on_folder_selection_changed):
473 * src/modest-ui-dimming-rules.c:
474 (modest_ui_dimming_rules_on_new_folder):
475 * src/widgets/modest-folder-view.c: (text_cell_data),
476 (icon_cell_data), (filter_row), (update_model),
477 (get_cmp_rows_type_pos):
480 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
481 Do not get the priv struct, because no priv struct has been set,
482 to avoid a runtime warning.
484 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
485 #ifelse with #else, to fix a warning, to fix the build.
488 2007-06-05 Christian Kellner <ckellner@openismus.com>
490 * libmodest-dbus-client/libmodest-dbus-client.c:
491 Fix small typo in doc (why do you always see them
492 AFTER committing stuff?)
495 2007-06-05 Christian Kellner <ckellner@openismus.com>
497 * libmodest-dbus-client/libmodest-dbus-client.c:
498 (libmodest_dbus_client_search):
499 Initialize hit list with NULL. Also set folder list
500 to "" if NULL was supplied.
503 2007-06-03 Christian Kellner <ckellner@openismus.com>
505 * libmodest-dbus-client/libmodest-dbus-client.c:
506 (modest_search_hit_list_free):
507 Make it save to call it with NULL.
509 * src/dbus_api/modest-dbus-callbacks.c:
510 * src/modest-search.c:
511 Return full ModestSearchHits as the search result list not TnyHeader
512 since can't be around withouth the correspoding TnyFolder.
514 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
516 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
517 Added currently commented code to check for secure auth
519 * src/maemo/modest-account-settings-dialog.c: (on_response),
520 (save_configuration), (show_ok):
521 Fixed projects.maemo.org bugs NB #59248 and #59251
523 * src/maemo/modest-maemo-utils.c:
524 (on_camel_account_get_supported_secure_authentication_status),
525 (on_camel_account_get_supported_secure_authentication),
526 (modest_maemo_utils_get_supported_secure_authentication_methods):
527 * src/maemo/modest-maemo-utils.h:
528 Moved get_supported_secure_authentication() method here to be able
529 to use it from easysetup wizard.
531 * src/modest-pair.c: (on_pair_compare_as_string):
532 Should compare string with first part of pair and not
533 strcmp pairs which will crash.
535 * src/modest-protocol-info.c:
536 (modest_protocol_info_protocol_is_store):
537 * src/modest-protocol-info.h:
538 Added modest_protocol_info_get_auth_protocol_name()
540 2007-06-03 Armin Burgmeier <armin@openismus.com>
542 * src/modest-mail-operation.c:
543 (modest_mail_operation_get_msgs_full): Set priv->account also when
544 only retrieving a single message. This avoids a crash when canceling
547 (modest_mail_operation_notify_end): Do not explicitely remove the
548 operation from the queue but only emit the progress_changed signal.
549 The queue itself listens to that signal to remove the operation when
550 it is finished. This reduces coupling and removes a potential deadlock
551 when modest_mail_operation_notify_end() is called from the queue
552 itself. If that is a problem performance-wise, I would suggest to
553 implement a status-changed signal or something.
555 * src/modest-mail-operation-queue.c: Make sure to never call a
556 function from another file while the queue is locked. This (hopefully)
557 fixes another deadlock when exiting the application while retrieving
560 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
562 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
563 Fixed build if libogs is not available
565 2007-06-03 Christian Kellner <ckellner@openismus.com>
567 * libmodest-dbus-client/libmodest-dbus-client.h:
568 * libmodest-dbus-client/libmodest-dbus-client.c:
569 (libmodest_dbus_client_delete_message):
570 Implement deletion of messages (Client side).
572 (modest_search_hit_free),
573 (modest_search_hit_list_free):
574 Utility functions to free the result hits.
576 * src/dbus_api/modest-dbus-api.h:
577 * src/dbus_api/modest-dbus-callbacks.c:
579 (modest_dbus_req_handler):
580 Implement deletion of messages (Server side).
582 * tests/dbus_api/test_search.c: (main):
585 * tests/dbus_api/Makefile.am:
586 * tests/dbus_api/test_delete_message:
587 Add little test for the message deletion logic
589 2007-06-03 Armin Burgmeier <armin@openismus.com>
591 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
592 when the operation queue was not empty. projects.maemo.org bug
595 2007-06-03 Armin Burgmeier <armin@openismus.com>
597 * src/widgets/modest-account-view.c
598 (on_account_default_toggled): Toggle default account column
599 explicitely instead of waiting for gconf notification (which is
600 currently ignored). This should fix projects.maemo.org bug NB#56910
601 for now. It should probably be removed when gconf notifications are
604 2007-06-03 Christian Kellner <ckellner@openismus.com>
606 * libmodest-dbus-client/libmodest-dbus-client.c:
607 Removed debugging spew.
609 * src/dbus_api/modest-dbus-callbacks.c:
610 Added debugging info.
612 * src/modest-search.c:
613 (modest_search_all_accounts):
614 Use tny_account_store_get_accounts () on the account store
615 to get all accounts which is the way to get all accounts.
617 * tests/dbus_api/test_search.c: (main):
618 Make it possible to supply the search term on the command line.
620 2007-06-03 Christian Kellner <ckellner@openismus.com>
622 * libmodest-dbus-client/libmodest-dbus-client.c:
623 * libmodest-dbus-client/libmodest-dbus-client.h:
624 Implement searching for mesages over raw dbus. (Client side)
626 * src/dbus_api/Makefile.am:
627 * src/dbus_api/modest-dbus-api.h:
628 * src/dbus_api/modest-dbus-callbacks.c:
629 * src/dbus_api/modest-dbus-callbacks.h:
630 Search framework (Server side). Also implement on_idle_open_message().
632 * src/maemo/modest-platform.c: (modest_platform_init):
633 Prepare for raw dbus/osso rpc interaction.
635 * src/modest-search.h:
636 Changed minsize from unspecific guint to guint32.
638 * src/modest-search.c:
640 Added strange hack which magically made tnymail work.
642 (modest_search_folder),
643 (modest_search_account),
644 (modest_search_all_accounts):
645 Implement helper functions to search all accounts, specific account
648 * tests/dbus_api/Makefile.am:
649 * tests/dbus_api/test_open_message.c:
650 Read url to open from commandline.
652 * tests/dbus_api/test_search.c:
653 Implement small test for dbus search stuff
655 2007-06-02 Armin Burgmeier <armin@openismus.com>
657 * src/maemo/modest-account-settings-dialog.c: Changed window title to
658 include account type and account title. This fixes projects.maemo.org
661 * src/maemo/modest-account-view-window.c: Set a title for the window.
663 2007-06-02 Armin Burgmeier <armin@openismus.com>
665 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
666 incoming and outgoing server name based on email address and server
667 types as long as the names have not been edited manually. This fixes
668 projects.maemo.org bug NB#58671.
670 2007-06-02 Armin Burgmeier <armin@openismus.com>
672 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
673 server type cannot be changed in future to the incoming details page
674 when creating an account. This fixes projects.maemo.org bug NB#59029.
676 2007-06-02 Armin Burgmeier <armin@openismus.com>
678 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
679 and assigned max width chars so that they wrap instead of being
680 truncated. Fixes projects.maemo.org bug NB#56126.
682 2007-06-02 Armin Burgmeier <armin@openismus.com>
684 * src/maemo/modest-connection-specific-smtp-window.c: Add an
685 introductory note to the connection specific smtp servers dialog, as
686 section 8.12 of the email UI specification requires. This fixes
687 projects.maemo.org bug NB#59212.
689 2007-06-01 Murray Cumming <murrayc@murrayc.com>
691 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
692 Check for running mail operations, and offer to cancel them, as per the UI
693 spec. This fixes projects.maemo.org bug NB#59041 .
694 However, I suspect that tinymail may still use the network connection
695 in ways that we cannot detect or cancel. But it should at least adapt to
698 2007-06-01 Murray Cumming <murrayc@murrayc.com>
700 * src/modest-tny-account-store.c: (recreate_all_accounts),
701 (get_cached_accounts), (get_server_accounts): Do more sensible
702 ref-counting of the temporarily-cached outbox accounts list. This seems
703 to fix a crash when entering the password when the password was wrong.
705 2007-06-01 Murray Cumming <murrayc@murrayc.com>
707 * src/gnome/modest-main-window.c: (connect_signals):
708 * src/modest-tny-account-store.c: (get_password),
709 (modest_tny_account_store_alert): Added comments and clues and
710 commented-out code about how we currently fail to deal with connection
711 errors and wrong passwords, and how we should.
713 2007-06-01 Murray Cumming <murrayc@murrayc.com>
715 * src/widgets/modest-retrieve-combo-box.c:
716 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
717 This fixes projects.maemo.org bug NB#58472 .
719 2007-06-01 Murray Cumming <murrayc@murrayc.com>
721 * src/maemo/easysetup/modest-easysetup-wizard.c:
722 (create_page_complete_easysetup):
723 (create_page_complete_custom): Correct the last commit,
724 putting the correct sentences in the correct pages.
726 2007-06-01 Murray Cumming <murrayc@murrayc.com>
728 * src/maemo/easysetup/modest-easysetup-wizard.c:
729 (create_page_complete_custom): Show the second sentence of text
730 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
733 2007-06-01 Murray Cumming <murrayc@murrayc.com>
735 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
736 Set the leave-on-server conf key by default. This fixes
737 projects.maemo.org bug NB#59258 .
739 2007-06-01 Murray Cumming <murrayc@murrayc.com>
741 * src/maemo/modest-account-view-window.c:
742 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
743 logical ID for the confirmation messages. Fixed projects.maemo.org bug
746 2007-06-01 Murray Cumming <murrayc@murrayc.com>
748 * src/maemo/easysetup/modest-easysetup-wizard.c:
749 (create_caption_new_with_asterisk):
750 * src/maemo/modest-account-settings-dialog.c:
751 (create_caption_new_with_asterisk):
752 Uncomment the code to add the asterisk, because they are no longer in the
753 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
754 (update_incoming_server_title): Add an asterisk here too.
756 2007-06-01 Murray Cumming <murrayc@murrayc.com>
758 * src/maemo/modest-maemo-global-settings-dialog.c:
759 (current_connection): Check that we are even connected before trying to
760 get the current connection name, to prevent a warning.
762 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
763 Change the comments because tny_maemo_conic_device_connect() is now meant to
765 * src/modest-mail-operation.c:
766 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
767 make sure we have a connection and fail if we can't connect.
769 2007-05-31 Murray Cumming <murrayc@murrayc.com>
771 * src/maemo/modest-main-window.c:
772 (on_account_store_connecting_finished): Do not try to get the
773 connection ID if we are not really connected. I am surprised that
774 this signal handler is called when we are not connected.
776 2007-05-31 Murray Cumming <murrayc@murrayc.com>
778 * src/modest-error.h:
779 * src/modest-ui-actions.c:
780 (modest_ui_actions_get_msgs_full_error_handler):
781 Renamed an enum, added comments, added an enum
782 for retrieve-limit errors.
784 * src/modest-mail-operation.c: (foreach_add_item),
785 (internal_folder_observer_update), (update_account_thread),
786 (modest_mail_operation_get_msgs_full):
787 (modest_mail_operation_update_account),
788 Added comments about how this works, and some code that should
789 (but does not) check the retrieve-limit. See the TODO comment.
791 2007-05-31 Murray Cumming <murrayc@murrayc.com>
793 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
794 Initialize help_id to fix the build. Warnings are good.
796 2007-05-31 Murray Cumming <murrayc@murrayc.com>
798 * src/widgets/modest-hbox-cell-renderer.c:
799 (modest_hbox_cell_renderer_append):
800 * src/widgets/modest-vbox-cell-renderer.c:
801 (modest_vbox_cell_renderer_append):
802 Fix the last commit by doing an extra ref.
804 2007-05-31 Murray Cumming <murrayc@murrayc.com>
806 * src/widgets/modest-hbox-cell-renderer.c:
807 (modest_hbox_cell_renderer_append):
808 * src/widgets/modest-vbox-cell-renderer.c:
809 (modest_vbox_cell_renderer_append):
810 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
811 to fix the build with Maemo Bora.
812 However, there seems to be a remaining crash, probably due to reference
815 2007-05-30 Murray Cumming <murrayc@murrayc.com>
817 * src/modest-tny-account.c:
818 (modest_tny_account_new_for_local_folders):
819 Use hildon_file_system_info_async_new() to get a better name for
820 the memory card account, setting it as the account name.
821 The timing seems to work, but this is probably
822 not the best place to do this. See the TODO comment.
823 * src/maemo/modest-main-window.c: (create_details_widget):
824 * src/widgets/modest-folder-view.c: (text_cell_data):
825 Use the tny account name instead of hardcoding a name.
827 2007-05-30 Christian Kellner <ckellner@openismus.com>
829 * src/modest-search.c: (modest_search):
830 Correctly set part_search_func even if we have already parsed
831 the query and thus a valid OgsTextSearcher object.
833 2007-05-30 Christian Kellner <ckellner@openismus.com>
836 Search and check for libogs.
839 Incooparte the ogs build env.
841 * src/modest-mime-part-search-stream.c:
842 * src/modest-mime-part-search-stream.h:
843 Removed since we do the real searching now in modest-search.c.
845 * src/modest-search.c:
846 * src/modest-search.h:
847 Implement support for ogs. We use that if available and requested
848 and fall back to modest_text_utils_utf8_strcmp (). The search logic
849 should now handle the corner case when the search term is spread
850 across multiple reads.
851 Also the logic in modest_search () was corrected to search all
852 requested fields until one is found.
854 2007-05-30 Murray Cumming <murrayc@murrayc.com>
856 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
859 * src/modest-init.c: Made modest_init_local_folders() take a
860 path and be public so we can iniitialize maildir folders on
863 * src/modest-local-folder-info.h:
864 * src/modest-local-folder-info.c:
865 (modest_local_folder_info_get_maildir_path): Add a path parameter.
867 * src/modest-tny-account.c:
868 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
869 still means the standard local-folders path on the local volume.
871 * src/modest-tny-account-store.c:
872 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
873 signal so we can detect mount/unmount of the MMC1 card, and do an update of
874 all accounts when that happens.
875 (get_server_accounts): If the MMC1 card is mounted, create a store account for
876 this too, so it shows up in the treeview.
878 2007-05-28 Murray Cumming <murrayc@murrayc.com>
880 * src/maemo/modest-maemo-global-settings-dialog.c:
881 (current_connection):
882 * src/widgets/modest-global-settings-dialog.c:
883 (current_connection_default):
884 Use the enum values instead of 0, 1 and -1,
885 to make the code clearer.
887 * src/modest-account-mgr-helpers.c:
888 (modest_account_mgr_get_connection_specific_smtp): Make this code
891 * src/modest-runtime.h:
892 * src/modest-runtime.c:
893 Added modest_runtime_remove_all_send_queues().
894 * src/maemo/modest-main-window.c:
895 (on_account_store_connecting_finished): Recreate the send queues,
896 using the appropriate transport accounts for this new connection.
897 Some futher adapting might be needed if the old send queues are not
898 automatically stopped at this point.
900 * src/modest-tny-account-store.c: (get_server_accounts):
901 Create the connection-specific transport accounts, so that they can
902 be found later by their ID.
904 * src/modest-tny-account.h:
905 * src/modest-tny-account.c:
906 Added modest_tny_account_new_from_server_account_name().
907 modest_tny_account_new_from_server_account(): Do not create the
908 send queues here, because they will be
909 recreated anyway when the connection changes for the first time.
911 2007-05-28 Murray Cumming <murrayc@murrayc.com>
913 * src/modest-local-folder-info.h:
914 * src/modest-local-folder-info.c:
915 (modest_per_account_local_outbox_folder_info_get_maildir_path),
916 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
917 tbox_folder): Take a modest account name instead of a server TnyAccount,
918 so we can have per-modest-account rather than per-transport-account
920 We must make sure that we change or recreate the exisitng send queues
921 when the connection changes for connection-specific transport accounts.
923 * src/modest-tny-account-store.c:
924 (create_per_account_local_outbox_folders): Create outboxed per modest
925 account, not per transport account.
927 * src/modest-tny-account.h:
928 * src/modest-tny-account.c:
929 (modest_tny_account_get_special_folder): For outboxes, get the
930 parent modest account name. The account is ignored for other folders.
931 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
932 modest account name rather than a server TnyAccount.
934 2007-05-25 Murray Cumming <murrayc@murrayc.com>
936 * src/modest-tny-account.c:
937 (modest_tny_account_new_from_server_account):
938 Call modest_runtime_get_send_queue() immediately after creating transport
939 accounts, so that they start trying to send email from the outbox as soon
940 as possible at startup. This is probably what we want.
942 * src/modest-mail-operation.c: (update_account_thread):
943 * src/modest-runtime.c: (modest_runtime_get_send_queue):
944 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
945 * src/modest-tny-send-queue.h:
946 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
947 (modest_ui_actions_on_send):
948 Added comments about how sending works, though it needs some more work.
950 2007-05-25 Murray Cumming <murrayc@murrayc.com>
952 * src/modest-tny-account.c:
953 (modest_tny_account_get_special_folder): Add TODO because this fails when
955 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
956 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
957 Do not try to show this window when there is no active account. The UI
958 specs does not tell us what to do in this case.
960 2007-05-24 Murray Cumming <murrayc@murrayc.com>
964 * src/maemo/Makefile.am:
965 * src/widgets/Makefile.am: Some dist fixes.
967 2007-05-24 Murray Cumming <murrayc@murrayc.com>
969 * src/maemo/modest-connection-specific-smtp-window.c:
970 (on_button_edit): Make the code clearer, to prevent a double free.
972 2007-05-24 Murray Cumming <murrayc@murrayc.com>
974 * src/maemo/modest-account-settings-dialog.c:
975 (modest_account_settings_dialog_set_account_name),
976 Check the connection-specific smtp servers checkbox if there are any.
978 * src/maemo/modest-connection-specific-smtp-edit-window.c:
979 (modest_connection_specific_smtp_edit_window_init):
980 Start with a suitable port number.
982 * src/modest-account-mgr-helpers.h:
983 * src/modest-account-mgr-helpers.c: Added
984 modest_account_mgr_get_has_connection_specific_smtp().
986 (modest_account_mgr_set_connection_specific_smtp),
987 (modest_account_mgr_remove_connection_specific_smtp),
988 (modest_account_mgr_get_has_connection_specific_smtp),
989 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
990 connection-specific smtp server accounts in the account, rather than
991 the server account conf dir.
993 This fixes bug projects.maemo.org bug NB#58263 .
995 * src/modest-tny-account-store.c:
996 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
997 if there are no server accounts yet, to prevent an infinite loop when there
998 are no accounts. Document that one must be called before the other.
1000 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1002 * src/modest-account-mgr-helpers.c:
1003 (modest_account_mgr_get_default_account): Make sure that at least
1004 one account is always the default, if there are any enabled accounts.
1005 This is just a sanity check that shouldn't be necessary.
1007 * src/modest-account-mgr-priv.c:
1008 (_modest_account_mgr_account_from_key): Unescape the conf key to
1009 get the real account name. For instance, this is an issue if a space
1010 was in the account name, which can happen because the account name
1011 is generated from the display name.
1012 (_modest_account_mgr_get_account_keyname): Always escape the
1014 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1015 Unescape the conf keys to get the real account names.
1017 For instance, previously the is-default radio button in the accounts
1018 list was not checked for any accounts at first. This fixes that,
1019 and might fix several similar bugs.
1021 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1023 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1024 Removed some debug printfs.
1026 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1028 Modest on-disk outbox directories are now here, for instance:
1029 $HOME/.modest/outboxes/<account-id-1>/outbox
1030 $HOME/.modest/outboxes/<account-id-2>/outbox
1032 $HOME/.modest/local-folders/outbox
1033 so we can have a separate outbox for each account.
1034 But they are shown as one outbox in the GtkTreeView, by using a
1035 TnyMergeFolder in a ModestTnySimpleFolderStore.
1038 * src/modest-tny-simple-folder-store.c:
1039 * src/modest-tny-simple-folder-store.h:
1040 Added ModestTnySimpleFolderStore, used to contain folders from
1041 other folder stores, such as other accounts.
1043 * src/modest-tny-outbox-account.h:
1044 * src/modest-tny-outbox-account.c:
1045 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1046 used for the per-account local outbox folders.
1048 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1049 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1050 only use this (internally) now for the non-outbox local folders.
1052 * src/modest-init.h:
1053 * src/modest-init.c: Added modest_init_one_local_folder(), for
1054 setting up the directory structure for each local folder.
1056 * src/modest-local-folder-info.c:
1057 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1058 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1060 * src/modest-local-folder-info.h:
1061 * src/modest-tny-account-store.c: (on_account_removed),
1062 (on_account_changed), (create_per_account_local_outbox_folders),
1063 (get_server_accounts), (modest_tny_account_store_get_accounts),
1064 (modest_tny_account_store_get_tny_account_by_account),
1065 (modest_tny_folder_store_is_virtual_local_folders):
1067 * src/modest-tny-account.h:
1068 * src/modest-tny-account.c:
1069 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1070 to create an on-disk per-account local outbox folder for each
1072 (create_per_account_local_outbox_folders): Create a local outbox folder
1073 for each transport account.
1074 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1075 for all local folders.
1077 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1078 instead of using g_object_get/set() directly. It is clearer.
1080 (modest_tny_folder_store_get_message_count),
1081 (modest_tny_folder_store_get_local_size
1082 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1083 because we now use these with non-acount folder stores.
1085 (modest_tny_account_get_special_folder),
1086 (modest_tny_account_new_from_server_account),
1087 (modest_tny_account_new_from_account):
1088 (recurse_folders): Adjust to the new outbox system.
1090 * src/modest-tny-folder.h:
1091 * src/modest-tny-folder.c:
1092 (modest_tny_folder_is_local_folder),
1093 (modest_tny_folder_get_local_folder_type),
1094 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1096 * src/widgets/modest-main-window.h:
1097 * src/maemo/modest-main-window.c: (create_details_widget),
1098 (modest_main_window_set_contents_style): Show details for any folder store,
1101 (modest_tny_folder_get_rules):
1102 Remove the const. C does not support constness enough for this.
1104 * src/modest-ui-actions.c:
1105 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1106 make all outboxes appear as one, in the usual local-folders tree node.
1108 (set_active_account_from_tny_account),
1109 (modest_ui_actions_on_folder_selection_changed):
1110 * src/widgets/modest-folder-view.c: (text_cell_data),
1111 (icon_cell_data), (filter_row),
1112 (add_account_folders_to_merged_folder),
1113 (add_account_folders_to_simple_folder_store), (),
1114 (get_cmp_rows_type_pos), (cmp_rows),
1115 (modest_folder_view_set_account_id_of_visible_server_account):
1116 Adjust to the new outbox system, using generic folder stores and folders
1117 in the GtkTreeModel.
1119 2007-05-23 Christian Kellner <ckellner@openismus.com>
1121 * src/modest-mail-operation.c:
1122 (modest_mail_operation_update_account):
1123 Use info->max_size instead of unintialized local var [small
1124 build fix]. (Added TODO to review that change since I don't
1127 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1129 * libmodest-dbus-client/libmodest-dbus-client.c:
1130 (libmodest_dbus_client_compose_mail): function added
1131 * src/dbus_api/modest-dbus-api.h:
1132 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1133 (on_compose_mail): Implementation of the SendAsMail functionality
1135 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1137 * src/modest-account-mgr.c:
1138 (modest_account_mgr_add_server_account): Set the secure-connection
1139 conf key for transport accounts as well as store accounts. I don't know
1140 why the if was there. For instance, this makes sure that we use SSL
1141 for the gmail preset from the easysetup wizard.
1143 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1145 * src/gnome/modest-main-window.c:
1146 (on_account_store_connecting_finished), (connect_signals):
1147 * src/maemo/modest-main-window.c:
1148 (on_account_store_connecting_finished), (connect_signals),
1149 (modest_main_window_new):
1150 Handle TnyAccountStore::connecting-finished instead of
1151 TnyDevice::connection-changed, because we cannot actually perform
1152 operations on accounts until TnyAccountStore has itself responded to
1153 the TnyDevice::connection-changed signal. This prevents a GError from
1155 Do not try to update at startup, because we (at least on scratchbox)
1156 already do an update at startup when the device goes online.
1157 This prevents a GError from tinymail.
1158 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1159 Added TODO about stopping simultaneous operations.
1161 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1163 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1164 * src/modest-mail-operation-queue.c:
1165 (modest_mail_operation_queue_remove):
1166 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1167 about where they happened.
1169 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1171 * src/modest-ui-actions.c:
1172 (modest_ui_actions_on_password_requested): Make sure that the remember
1173 output parameter is always TRUE.
1175 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1177 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1178 Show a OK/Cancel dialog if the error is a question, though we still do not
1179 know anything more about what we are asking the user.
1180 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1181 Fix an uninitialized variable (helper). This is a logic error, however.
1183 2007-05-21 Christian Kellner <ckellner@openismus.com>
1185 * src/modest-search.h:
1186 Correct bit shifting in the ModestSearchFlags enum.
1188 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1190 * src/modest-tny-account.c:
1191 (modest_tny_account_new_from_server_account): Do not use the lsub and
1192 check-all hard-coded IMAP options when using POP.
1194 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1196 * src/modest-tny-account.c:
1197 (modest_tny_account_new_from_server_account):
1198 Use NULL for the secure-auth method for POP when Password auth has been
1199 specified by the user, as we already do for IMAP. "auth=Login" causes
1200 an error from camel or the server.
1202 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1204 * src/maemo/modest-account-settings-dialog.c:
1205 (create_page_account_details),
1206 (modest_account_settings_dialog_set_account_name):
1207 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1208 for the leave-on-server checkbox, rathr than just the checkbox, when
1209 the protocol is not POP.
1211 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1213 * src/widgets/modest-account-view.c:
1214 * src/widgets/modest-account-view.h:
1215 Added modest_account_view_select_account() which will be useful later
1216 to asynchronously re-select the edited account.
1218 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1220 * src/maemo/modest-account-settings-dialog.c:
1221 (modest_account_settings_dialog_set_account_name):
1222 Automatically choose the port numbers based on the secure authentication
1223 methods, if they have not been chosen before.
1224 This fixes projects.maemo.org bug NB#56273 .
1226 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1228 * src/maemo/modest-main-window-ui.h:
1229 * src/modest-ui-actions.c:
1230 * src/modest-ui-actions.h:
1231 Connect the Tools/SMTP Servers menu item to
1232 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1233 SMTP servers dialog, as in the UI specification and saves changes when it
1234 is closed. This fixed projects.maemo.org bug NB#56305 .
1236 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1238 * src/maemo/modest-connection-specific-smtp-window.c:
1239 (modest_connection_specific_smtp_window_init):
1240 Use gtk_window_set_default_size() to make this window big enough, so
1241 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1243 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1245 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1246 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1247 (modest_connection_specific_smtp_edit_window_init),
1248 Do not try to connect to a combobox signal before the combobox exists.
1249 This fixes the cras in projects.maemo.org bug NB#56288 .
1250 (modest_connection_specific_smtp_edit_window_get_settings):
1251 Remove the server_account_name parameter which was being checked for NULL
1252 though it was not used.
1254 * src/maemo/modest-connection-specific-smtp-window.c:
1255 (modest_connection_specific_smtp_window_fill_with_connections),
1256 (on_button_edit), (modest_connection_specific_smtp_window_init):
1257 Correct the number of treemodel columns to prevent a warning.
1258 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1259 libconic does not work.
1261 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1263 * src/modest-tny-account.c:
1264 (modest_tny_account_new_from_server_account):
1265 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1266 SMTP when "None" was chosen by the user. However, with my SMTP server that
1267 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1270 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1272 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1273 to explain the memory management issue with the ID in the ModestPair.
1275 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1276 (add_sending_page), (modest_account_assistant_finalize):
1277 * src/gnome/modest-gnome-global-settings-dialog.c:
1278 (create_updating_page), (create_composing_page):
1279 * src/gnome/modest-msg-edit-window.c: (get_transports),
1280 (init_window), (modest_msg_edit_window_finalize),
1281 (modest_msg_edit_window_get_msg_data):
1282 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1283 * src/gnome/modest-transport-widget.c:
1284 (modest_transport_widget_finalize), (smtp_configuration):
1285 * src/maemo/modest-maemo-global-settings-dialog.c:
1286 (create_updating_page), (create_composing_page):
1287 * src/maemo/modest-msg-edit-window.c: (get_transports),
1288 (init_window), (modest_msg_edit_window_finalize),
1289 (modest_msg_edit_window_get_msg_data),
1290 (modest_msg_edit_window_free_msg_data):
1291 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1292 (modest_store_widget_finalize):
1293 * src/maemo/modest-transport-widget.c:
1294 (modest_transport_widget_finalize), (smtp_configuration):
1295 * src/modest-main.c: (send_mail):
1296 * src/widgets/modest-combo-box.h:
1297 * src/widgets/modest-global-settings-dialog-priv.h:
1298 * src/widgets/modest-global-settings-dialog.c:
1299 (modest_global_settings_dialog_finalize):
1300 * src/widgets/modest-msg-edit-window.h:
1301 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1302 as long as the combo box, to prevent use of freed memory for the ID.
1304 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1306 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1307 get_accounts(), to make this clearer. Do not check for the enabled gconf
1308 key, because we do not use this for server accounts (at least, not yet).
1309 This allows us to send email again.
1311 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1313 * src/maemo/modest-platform.c:
1314 (on_modest_conf_update_interval_changed), (modest_platform_init):
1315 Only respond to this particular key change. All these strcmp()s cannot be
1318 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1320 * src/maemo/modest-maemo-global-settings-dialog.c:
1321 (current_connection): Prevent a crash in scratchbox when
1322 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1323 * src/maemo/modest-platform.c:
1324 (on_modest_conf_update_interval_changed), (modest_platform_init):
1325 Get the update interval from gconf and reset it when the gconf key changes.
1327 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1329 * src/modest-protocol-info.c:
1330 * src/modest-protocol-info.h: Adde enum-specific get functions,
1331 instead of using a ModestProtocolType enum parameter.
1333 * src/gnome/modest-account-assistant.c:
1334 * src/gnome/modest-store-widget.c:
1335 * src/gnome/modest-store-widget.h:
1336 * src/gnome/modest-transport-widget.c:
1337 * src/gnome/modest-transport-widget.h:
1338 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1339 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1340 * src/maemo/easysetup/modest-easysetup-wizard.c:
1341 * src/maemo/modest-account-settings-dialog.c:
1342 * src/maemo/modest-account-settings-dialog.h:
1343 * src/maemo/modest-store-widget.c:
1344 * src/maemo/modest-store-widget.h:
1345 * src/maemo/modest-transport-widget.c:
1346 * src/maemo/modest-transport-widget.h:
1347 * src/modest-account-mgr-helpers.c:
1348 * src/modest-account-mgr-helpers.h:
1349 * src/modest-account-mgr.c:
1350 * src/modest-account-mgr.h:
1351 * src/modest-tny-account.c:
1352 * src/modest-tny-folder.c:
1353 * src/widgets/modest-account-view.c:
1354 * src/widgets/modest-retrieve-combo-box.c:
1355 * src/widgets/modest-retrieve-combo-box.h:
1356 * src/widgets/modest-secureauth-combo-box.c:
1357 * src/widgets/modest-serversecurity-combo-box.c:
1358 * src/widgets/modest-serversecurity-combo-box.h:
1359 * tests/check_account-mgr.c:
1360 Use the specific functions, and use the re-renamed enum values for GNOME too.
1362 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1364 * src/modest-pair.h:
1365 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1366 so we can get the second based on the first.
1368 * src/maemo/modest-account-settings-dialog.h:
1369 * src/maemo/modest-account-settings-dialog.c:
1370 Added get_supported_secure_authentication_methods(), though it is mostly
1371 commented-out for now until the necessary API is committed to tinymail.
1372 (modest_account_settings_dialog_set_account_name),
1373 (save_configuration): Request the supported authentication methods from the
1374 server, so we can choose a working method.
1376 * src/modest-tny-account-store.h:
1377 * src/modest-tny-account-store.c:
1378 (modest_tny_account_store_get_session): Rename from
1379 tny_account_store_get_session().
1381 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1383 * src/modest-protocol-info.h: Split the ModestProtocol enum
1384 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1385 There was no need to have these unrelated values in one enum.
1387 * src/: many files: Adapted to changed enum. This makes the code a bit
1388 clearer, and the compiler could catch some errors.
1390 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1392 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1393 Show the detailed internal camel error message when an error happens
1394 during the configuration, so that our testers can give us more clues.
1395 For instance, in projects.maemo.org bug NB#56910 .
1397 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1399 * src/modest-tny-account.c:
1400 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1401 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1403 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1405 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1406 * src/maemo/modest-account-settings-dialog.c:
1407 (modest_account_settings_dialog_set_account_name),
1408 (save_configuration): For the incoming secure authentication checkbox,
1409 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1410 the UI specification. PLAIN does not seem to be supported for most IMAP
1411 servers anyway, and I am not sure what it would mean.
1412 However, we probably need to discover which of the secure-authentication
1413 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1414 * src/modest-account-mgr-helpers.c:
1415 (modest_account_mgr_get_server_account_data):
1417 * src/modest-tny-account.c:
1418 (modest_tny_account_new_from_server_account):
1419 Use tny_account_set_mech() to set secure-authentication methods,
1420 with some special-casing for IMAP, based on my observations of how
1423 * src/modest-account-mgr-helpers.h:
1424 * src/modest-account-mgr.c:
1425 * src/modest-defs.h: Comment that the URI is only used for local folders.
1427 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1429 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1430 parameter const, just to be neat.
1431 * src/modest-text-utils.c: (modest_text_utils_inline):
1432 End g_strconcat() with NULL, as its documentation says. This is almost
1433 certainly the cause of my crash at startup on the device. Interestingly,
1434 valgrind doesn't tell us about these errors.
1436 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1438 * scripts/build-packages: Added more precise comments about how to use
1439 this script, though I still get this error:
1440 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1441 error building tinymail
1443 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1445 * src/maemo/modest-main-window.c: (on_account_update):
1446 Very slight cleanup, hoping to make it simpler to discover what causes
1447 a crash here sometimes.
1449 * src/modest-tny-account.c:
1450 (modest_tny_account_new_from_server_account): Set the port. Added
1451 comments about the options and a TODO comment because I need to find out
1452 how to specify the secure authentication method.
1454 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1456 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1457 changed CFlags paths form modest to libmodest
1459 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1461 * src/modest-account-mgr-helpers.c:
1462 (modest_account_mgr_get_server_account_data),
1463 (modest_account_mgr_free_server_account_data):
1464 * src/modest-account-mgr-helpers.h:
1465 * src/modest-account-mgr.c:
1466 (modest_account_mgr_add_server_account):
1467 * src/modest-defs.h:
1468 * src/modest-tny-account.c:
1469 (modest_tny_account_new_from_server_account):
1470 Determine the options for tny_camel_account_add_option() here,
1471 based on the settings, rather than storing them directly in gconf.
1473 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1475 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1476 Show a more friendly error dialog now that we expect (from the tinymail
1477 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1479 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1481 * src/maemo/modest-main-window.c: (on_account_update): Check that
1482 account_name is not NULL, to prevent a crash at startup that I am
1483 seeing on the N800. I do wonder why it is NULL.
1485 * src/maemo/easysetup/modest-easysetup-wizard.c:
1486 (create_page_user_details):
1487 * src/maemo/modest-account-settings-dialog.c:
1488 (create_page_user_details), (create_page_outgoing):
1489 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1490 (modest_connection_specific_smtp_edit_window_init):
1491 * src/modest-ui-actions.c:
1492 (modest_ui_actions_on_password_requested):
1493 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1494 might do something useful with the on-screen keyboard.
1496 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1498 * src/maemo/modest-main-window.c: (on_account_update):
1499 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1500 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1502 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1504 * src/modest-tny-account-store.c: (on_account_changed):
1505 Correct the signature of this signal handler.
1507 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1509 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1510 Show a HildonNote instead of a GtkDialog for Maemo.
1512 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1514 * src/widgets/modest-account-view.h:
1515 * src/widgets/modest-account-view.c: (on_account_changed),
1516 (on_account_removed). Added a boolean flag, set/unset by
1517 modest_account_view_block_conf_updates(),
1518 modest_account_view_unblock_conf_updates() to prevent unnecessary
1519 updates, but this is not very useful because the gconf notifications are
1520 so delays (maybe only on Maemo Bora).
1521 So auto-updating is turned off, and these functions do an explicit
1522 update when necessary.
1523 However, something else is still doing too much work when adding/removing
1524 accounts, probably in another part of the application.
1526 * src/maemo/modest-account-view-window.c:
1527 (on_delete_button_clicked), (on_edit_button_clicked),
1528 (on_new_button_clicked): Use the new functions.
1530 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1532 * src/modest-account-mgr-helpers.c:
1533 (modest_account_mgr_set_first_account_as_default):
1534 Sort the list of names alphabetically-by-title, so we choose the first one
1536 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1537 alphabetically by the title.
1539 This fixes projects.maemo.org bug NB#56418 .
1541 * src/modest-account-mgr-priv.c:
1542 (_modest_account_mgr_account_from_key):
1543 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1544 avoid a valgrind error, and possible random behaviour.
1546 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1548 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1549 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1550 tinymail documentation to say that this can be expected.
1551 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1552 pretty, and should not happen, but I would prefer to know when it does.
1554 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1556 * configure.ac: When using the older hildon version, probably on Bora,
1557 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1559 * src/widgets/modest-attachment-view.c:
1560 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1563 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1565 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1566 Implemented the prototype. Can be tested with
1567 tests/dbus_api/test_open_message:
1569 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1571 * src/modest-tny-account-store.c:
1572 (modest_tny_account_store_instance_init), (get_password):
1573 * src/modest-ui-actions.c:
1574 (modest_ui_actions_on_password_requested):
1575 Do not store the password in gconf, because this function is called
1576 for non-remembered passwords. Actually use the cached (in the hash map)
1577 password instead of releasing it.
1578 The password will now not be remembered if it is asked via the protected
1579 password dialog, as per the UI spec.
1581 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1583 * src/modest-defs.h:
1584 * src/modest-account-mgr-helpers.h:
1585 * src/modest-account-mgr-helpers.c:
1586 Added modest_server_account_get_username_has_succeeded(),
1587 modest_server_account_set_username_has_succeeded().
1588 (modest_server_account_set_username),
1589 Reset the has-succeeded flag if the username changes.
1591 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1592 * src/maemo/modest-connection-specific-smtp-window.c:
1593 (modest_connection_specific_smtp_window_save_server_accounts):
1594 Use modest_server_account_set_username() instead of using
1595 modest_conf_set_string() directly, so that the has-succeeded flag is always
1598 * src/modest-ui-actions.c:
1599 (modest_ui_actions_on_password_requested): Dim the username entry if
1600 the username has ever worked, as per the UI spec.
1602 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1604 * src/modest-tny-account-store.c: (get_password):
1605 * src/modest-ui-actions.c:
1606 (modest_ui_actions_on_password_requested):
1607 Allow the username to be changed too, though there is more work to
1608 be done on exactly how this behaves.
1610 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1612 * src/modest-account-mgr-helpers.h:
1613 * src/modest-account-mgr-helpers.c:
1614 Added modest_account_mgr_get_display_name(),
1615 modest_server_account_get_username(),
1616 modest_server_account_set_username(),
1617 modest_server_account_set_password(),
1618 modest_server_account_get_hostname() functions so we do not need to
1619 use the conf API directly.
1621 * src/maemo/modest-main-window.c: (connect_signals):
1622 Actually connect ot the ModestAccountStore::request-password signal,
1623 so that we show the dialog when the password is requested by Tinymail,
1624 for isntance if it is empty.
1626 * src/modest-marshal.list:
1627 * src/modest-tny-account-store.c:
1628 (modest_tny_account_store_class_init), (get_password),
1629 (modest_tny_account_store_alert):
1630 * src/modest-tny-account-store.h:
1631 * src/modest-ui-actions.h:
1632 * src/modest-ui-actions.c:
1633 (modest_ui_actions_on_password_requested):
1634 Change the signal parameters, so it is obvious that we are providing
1635 the non human-readable server name, and receiving both the username
1636 and password, though changing of the username is not yet implemented.
1637 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1638 for the GNOME version.
1640 This should fix the projects.maemo.org bug NB#56209, though it does not
1641 work on Bora, because the gconf_client_get() for the password fails
1642 immediately after we save it with gconf_client_set().
1644 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1647 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1648 caused an undefined symbol error:
1649 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1651 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1653 * src/modest-tny-account-store.c:
1654 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1655 using a GError instead of a string message, so we can translate it in
1658 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1660 * src/maemo/modest-address-book.c:
1661 (modest_address_book_check_names):
1662 * src/maemo/modest-msg-view-window.c:
1663 (modest_msg_view_window_clipboard_owner_change):
1664 * src/modest-init.c: (modest_init_init_ui):
1665 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1666 (update_folders_cb), (modest_mail_operation_update_account):
1667 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1668 (modest_ui_actions_on_msg_attachment_clicked),
1669 (modest_ui_actions_on_msg_recpt_activated):
1670 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1671 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1672 (modest_msg_view_search_next):
1673 * src/widgets/modest-recpt-editor.c:
1674 (modest_recpt_editor_on_button_release_event),
1675 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1676 g_message(). At this point we should only be seeing interesting errors on
1677 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1679 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1681 (modest_wizard_dialog_force_title_update):
1682 * src/maemo/easysetup/modest-wizard-dialog.h:
1683 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1684 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1685 can update the title when appropriate. Otherwise the title is wrong if the
1686 pages are added after adding the notebook to the dialog.
1687 This must be a problem in HildonWizardDialog too.
1688 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1690 * src/maemo/easysetup/modest-easysetup-wizard.c:
1691 (create_subsequent_customsetup_pages),
1692 (create_subsequent_easysetup_pages):
1693 Call modest_wizard_dialog_force_title_update() so that the title is
1694 correct even with GTK+ < 2.10.
1695 This fixes projects.maemo.org bug NB#56145 .
1697 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1699 * src/maemo/modest-platform.c:
1700 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1701 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1704 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1706 * src/widgets/modest-window.h:
1707 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1708 and modest_window_save_state(), which invokes it.
1710 * src/widgets/modest-window-mgr.h:
1711 * src/widgets/modest-window-mgr.c:
1712 Added modest_window_mgr_save_state_for_all_windows(), which calls
1713 the save_state vfunc on all registered windows, if implemented.
1715 * src/gnome/modest-msg-edit-window.c:
1716 * src/gnome/modest-msg-view-window.c:
1717 * src/maemo/modest-msg-edit-window.c:
1718 * src/maemo/modest-msg-view-window.c:
1719 * src/maemo/modest-main-window.c:
1720 Specify the existing save_settings functions as implementations of
1721 ModestWindow::save_state_func().
1723 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1724 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1725 enabling hibernation, for instance.
1727 We may need to do the same thing for restoring settings.
1730 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1732 * src/widgets/modest-window-mgr.c:
1733 * src/widgets/modest-window-mgr.h:
1734 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1735 modest_window_mgr_get_hibernation_is_prevented().
1737 * src/maemo/modest-main-window.c:
1738 (on_hildon_program_is_topmost_notify): Prevent hibernation
1739 (possible when the application goes to the background in the WM),
1740 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1742 * src/maemo/easysetup/modest-easysetup-wizard.c:
1743 (modest_easysetup_wizard_dialog_init):
1744 * src/maemo/modest-account-settings-dialog.c:
1745 (modest_account_settings_dialog_init):
1746 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1747 (modest_connection_specific_smtp_edit_window_init):
1748 * src/maemo/modest-connection-specific-smtp-window.c:
1749 (modest_connection_specific_smtp_window_init):
1750 * src/maemo/modest-signature-editor-dialog.c:
1751 (modest_signature_editor_dialog_init):
1752 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1753 prevent hibernation while any of these account settings dialogs are open.
1755 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1757 * src/maemo/Makefile.am:
1758 * src/maemo/modest-osso-state-saving.c:
1759 * src/maemo/modest-osso-state-saving.h: Added
1760 modest_osso_load_state() and modest_osso_save_state() though they do
1761 nothing now. They should iterate through all the open windows and load/save
1763 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1764 save state when closing.
1766 * src/maemo/modest-main-window.c:
1767 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1768 Add a notification handler for the HildonProgram::is-topmost property,
1769 so we can allow hibernation when the application goes into the background.
1770 But we still need to detect when the accounts setup windows are open so
1771 we can stop hibernation when they are open.
1772 To do this, I also added the main window the HildonProgram. This might have
1773 other side-effects/benefits, and should maybe be done for other windows.
1775 * src/maemo/modest-osso-autosave-callbacks.h:
1776 * src/maemo/modest-osso-autosave-callbacks.c:
1777 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1778 though it does not do anything yet, and we might never need this to do
1779 anything. For instance, we already save drafts.
1781 * src/maemo/modest-platform.c: (modest_platform_init):
1782 Specify the libosso auto-save callback.
1784 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1786 * src/maemo/modest-platform.c:
1787 (modest_platform_set_update_interval):
1788 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1789 aparently stays valid between application instances, so we can use this
1790 to remove and reset it later. According to a maemo-developers email from
1793 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1795 * configure.ac: Depend on libalarm for Maemo.
1797 * src/dbus_api/modest-dbus-api.h:
1798 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1799 (on_send_receive), (modest_dbus_req_handler):
1800 Handle a SEND_RECEIVE D-Bus method.
1802 * libmodest-dbus-client/libmodest-dbus-client.c:
1803 (libmodest_dbus_client_send_and_receive):
1804 * libmodest-dbus-client/libmodest-dbus-client.h:
1805 Add C convenience functions for calling the new D-Bus method.
1807 * src/modest-platform.h:
1808 * src/gnome/modest-platform.c:
1809 * src/maemo/modest-platform.c:
1810 Added modest_platform_set_update_interval(), which uses the
1811 alarmd API on Maemo.
1812 (modest_platform_init),
1813 Call modest_platform_set_update_interval(), using a hard-coded
1814 interval for now (until the global settings dialog is implemented),
1815 though I am not sure that this makes sense yet.
1817 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1819 * src/dbus_api/modest-dbus-callbacks.c:
1820 (modest_osso_cb_hw_state_handler):
1821 * src/dbus_api/modest-dbus-callbacks.h:
1822 * src/maemo/modest-platform.c: (modest_platform_init):
1823 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1824 in case this has some effect on the ability for Maemo to ping the
1827 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1829 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1830 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1831 warning. It is probably a logic error, but I need to fix the build.
1833 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1835 * src/modest-account-mgr.h:
1836 * src/modest-account-mgr.c:
1837 (modest_account_mgr_account_names): Add a gboolean enabled_only
1838 parameter, so we can get lists of onlt the enabled accounts.
1840 (modest_account_mgr_add_account),,
1841 (modest_account_mgr_account_with_display_name_exists):
1842 * src/maemo/modest-msg-edit-window.c: (get_transports):
1843 * src/modest-account-mgr-helpers.c:
1844 (modest_account_mgr_set_first_account_as_default):
1845 * src/modest-init.c: (init_default_account_maybe):
1846 * src/modest-tny-account-store.c: (get_accounts):
1847 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1848 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1849 * tests/check_account-mgr.c: (START_TEST):
1850 Provide the extra parameter, as appropriate.
1852 * src/widgets/modest-account-view.c: (update_account_view):
1853 Do not show disabled accounts (meaning that there is no way to
1854 enable/disable accounts in the UI (the feature is not in our UI
1855 specification), so we can use this internally only to mark unfinished
1856 or temporary account data.
1858 * src/maemo/easysetup/modest-easysetup-wizard.c:
1859 (create_account): Add boolean enable parameter, so we can specify FALSE
1860 to create the temporary account.
1861 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1862 (on_before_next): When finishing, when there is a temporary account, just
1864 Also, use a timeout to delay the showing of the dialog until gconf is likely
1865 to return correct information, due to a maemo gconf bug that is fixed in
1866 osso 1.1, but not yet in Bora.
1867 However, the dialog stays on screen after it is destroyed.
1869 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1870 for invalid data when cancelling. Use a hildon note instead of a dialog
1871 to complain about invalid data. Do not show the account-saved note if the
1872 account is disabled (a temporary account that will not really be saved for use
1875 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1877 * src/modest-account-mgr-helpers.h:
1878 * src/modest-account-mgr-helpers.c:
1879 Added modest_account_mgr_unset_default_account(),
1880 Added modest_account_mgr_set_first_account_as_default().
1882 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1883 If it was the default account, unset the default account name.
1885 * src/maemo/modest-account-view-window.c:
1886 (on_delete_button_clicked): If it was the default account,
1887 set the first remaining account as the default instead.
1889 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1890 a NULL account or a NULL default account, to prevent a crash. This should
1891 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1894 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1896 * src/widgets/modest-recpt-editor.c:
1897 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1898 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1899 TODO comment for this. This fixes the build.
1901 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1902 be the best place for it. This will in future update all auto-update accounts,
1903 rather than just the current/default account, when that gconf key exists.
1904 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1905 if there are no accounts, before calling do_send_receive().
1906 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1908 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1909 * src/maemo/modest-main-window-ui.h:
1910 * src/maemo/modest-main-window.c: (on_connection_changed),
1911 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1912 directly, becaue the signal handler does more.
1914 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1916 * src/modest-account-mgr-helpers.c:
1917 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1918 for the case that the account does not exist.
1920 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1921 (equivalent to the modest account name) rather than the tinymail account name
1922 (equivalent to the modest account title - human readable) to get the account data.
1923 Check for null account data to prevent the crash, and add a TODO comment saying that
1924 this needs fixing because it is using the server account name instead of the account name.
1926 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1928 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1929 * src/maemo/modest-account-settings-dialog.c: (show_error),
1931 Use hildon_note_new_information() for informative and error messages,
1932 which seems to be expected for Maemo applications (no documentation that I know of
1933 says this). I am surprised that there is no distinction between info and error
1936 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1938 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1939 it is easy to find where this is used.
1941 * src/maemo/easysetup/modest-easysetup-wizard.c:
1942 (create_page_welcome), (create_page_account_details),
1943 (create_page_user_details), (create_page_complete_easysetup),
1944 (create_page_custom_incoming), (create_page_custom_outgoing),
1945 (create_page_complete_custom):
1946 * src/maemo/modest-account-settings-dialog.c:
1947 (create_page_account_details), (create_page_user_details),
1948 (create_page_incoming), (create_page_outgoing):
1949 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1950 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1951 (modest_connection_specific_smtp_edit_window_init):
1952 * src/maemo/modest-connection-specific-smtp-window.c:
1953 (modest_connection_specific_smtp_window_init):
1954 * src/maemo/modest-signature-editor-dialog.c:
1955 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1956 and scrolling policy as per the Email Application Layout Guide, if I have
1959 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1961 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1962 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1963 which were empty, because these vfuncs have been removed from TnyAccountStore.
1964 This fixes the build.
1966 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1968 * src/maemo/modest-main-window.c:
1969 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1970 showing/hiding it. Added TODO because it probably should not be NULL.
1971 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1972 because unnecessary g_warnings() make degugging difficult.
1974 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1976 * src/maemo/modest-msg-edit-window.c:
1977 (modest_msg_edit_window_select_color),
1978 (modest_msg_edit_window_select_background_color): 2 const corrections and
1979 moving 2 #endifs before closing brackets, to fix the build.
1981 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1983 * src/maemo/easysetup/modest-easysetup-wizard.h:
1984 * src/maemo/easysetup/modest-easysetup-wizard.c:
1985 (modest_easysetup_wizard_dialog_finalize),
1986 (on_button_edit_advanced_settings), (create_page_complete_custom),
1987 (on_response), (create_account):
1988 Implement the Advanced Settings edit button, by saving the account information,
1989 for the Advanded Settings dialog to use directly from gconf, and removing it
1990 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1991 Bug #5533 in the projects.maemo.org bugzilla.
1993 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1995 * src/maemo/modest-msg-view-window.c:
1996 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1997 when opening a message window.
1999 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2001 * src/maemo/easysetup/modest-easysetup-wizard.c:
2002 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2005 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2006 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2007 gconf settings. I probably added more checks than necessary, but that is safer.
2009 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2010 variable to fix the build, but this seems to be used when it is still NULL.
2012 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2014 * src/modest-platform.h:
2015 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2016 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2017 * src/modest-main.c: Implement this function so we can avoid using
2018 maemo-specific API from cross-platform code.
2020 * src/modest-tny-account-store.c:
2021 (get_smtp_specific_transport_account_for_open_connection):
2022 * src/modest-ui-actions.c: (check_for_connection),
2023 (modest_ui_actions_on_item_not_found):
2024 Use modest_platform_connect_and_wait() and put #idefs around other
2025 maemo-specific code, because only maemo currently has a way to
2026 identify connection names.
2028 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2030 * src/modest-tny-account-store.h:
2031 * src/modest-tny-account-store.c:
2032 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2033 the connection-specific SMTP server settings in the configuration.
2035 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2037 * src/maemo/modest-main-window.c: (on_connection_changed),
2039 * src/modest-main.c: (main), (start_ui), (send_mail):
2040 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2041 that is what is intended.
2043 * src/modest-ui-actions.c: (action_send), (action_receive),
2044 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2045 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2046 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2047 SMTP server is used when it is specified.
2049 (modest_ui_actions_on_send_receive):
2050 Check that a connection is open before proceeding.
2051 Receive and then send, instead of vice-versa, as per the specification.
2053 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2055 * src/modest-mail-operation.c:
2056 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2057 though I guess it should be something other than NULL.
2059 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2061 * src/maemo/easysetup/modest-easysetup-wizard.c:
2062 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2063 combo twice, to avoid an g_warning and to make it visible again.
2064 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2065 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2066 (already intended) dereference when detaching, because we then recreate the menu.
2067 But I am not sure why the warning was happening, and it is possible that this is a memory
2070 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2072 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2073 and uri_parse_mailto() utility functions.
2074 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2076 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2078 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2080 * src/dbus_api/modest-dbus-api.h:
2081 * src/dbus_api/modest-dbus-callbacks.c:
2082 Use an idle callback to execute the modest code in the application's own thread.
2083 Remove the helloworld example method.
2084 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2085 parsed, and the open-message method is not implemented because this is not yet implemented in
2087 * libmodest-dbus-client/libmodest-dbus-client.c:
2088 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2089 (libmodest_dbus_client_open_message):
2090 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2092 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2093 body without crashing.
2095 * tests/dbus_api/Makefile.am:
2096 * tests/dbus_api/test_mail_to.c:
2097 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2099 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2101 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2102 Added file to fix the build. Sorry.
2104 * src/dbus_api/Makefile.am:
2105 * src/dbus_api/modest-dbus-api.h:
2106 * src/dbus_api/modest-dbus-callbacks.h:
2107 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2108 (modest_dbus_req_handler):
2109 Put constants in a separate header so it can be reused by the
2110 client library, without duplication
2112 * libmodest-dbus-client/Makefile.am:
2113 * libmodest-dbus-client/libmodest-dbus-client.c:
2114 (libmodest_dbus_client_call_helloworld),
2115 (libmodfest_dbus_client_send_mail),
2116 (libmodfest_dbus_client_mailto),
2117 (libmodfest_dbus_client_open_message):
2118 * libmodest-dbus-client/libmodest-dbus-client.h:
2119 (Partly) Implement a send_mail D-Bus method.
2121 * tests/dbus_api/Makefile.am:
2122 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2123 the send_email D-Bus method.
2125 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2129 * libmodest-dbus-client/Makefile.am:
2130 * libmodest-dbus-client/libmodest-dbus-client.c:
2131 * libmodest-dbus-client/libmodest-dbus-client.h:
2132 * tests/dbus_api/Makefile.am:
2133 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2134 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2136 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2138 * src/maemo/easysetup/modest-easysetup-wizard.c:
2139 (create_page_account_details):
2140 * src/maemo/modest-account-settings-dialog.c:
2141 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2142 widgets, because this might not be the default in future versions of the Maemo GTK+.
2143 However, I can not not get capitalization to work even in a simple test case.
2145 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2147 * src/maemo/easysetup/modest-easysetup-wizard.c:
2148 (create_page_custom_incoming), (create_page_custom_outgoing):
2149 * src/maemo/modest-account-settings-dialog.c:
2150 (create_page_account_details), (create_page_incoming),
2151 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2152 instead of using gtk_check_button_with_label(), so they are aligned like the other
2153 widgets, as per the UI spec.
2155 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2157 * src/maemo/easysetup/modest-easysetup-wizard.c:
2158 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2159 * src/widgets/modest-validating-entry.c:
2160 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2161 Modest prefix instead of an EasySetup prefix.
2163 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2165 * src/widgets/modest-validating-entry.h:
2166 * src/widgets/modest-validating-entry.c: (on_insert_text),
2167 Added easysetup_validating_entry_set_max_func(), used to set a callback
2168 to call when the max number of characters is reached. GtkEntry has a max-length
2169 already but is silent about it.
2171 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2172 (create_page_account_details), (create_page_user_details),
2174 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2175 (create_page_account_details), (create_page_user_details),
2176 (create_page_outgoing):
2177 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2178 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2179 the UI spec, when the user tries to enter more than the max number of characters.
2181 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2183 * src/maemo/easysetup/modest-easysetup-wizard.c:
2184 (create_page_user_details), (create_page_custom_incoming),
2185 (create_page_custom_outgoing):
2186 * src/maemo/modest-account-settings-dialog.c:
2187 (create_page_user_details), (create_page_incoming),
2188 (create_page_outgoing):
2189 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2190 (modest_connection_specific_smtp_edit_window_init):
2191 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2192 not appropriate. Bad Maemo-specific defaults!.
2194 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2196 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2197 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2198 (modest_signature_editor_dialog_set_settings):
2199 Disable the label and textview when the checkbox is disabled, and use the
2200 specified (UI spec) default signature text.
2202 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2204 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2205 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2207 * src/modest-defs.h:
2208 * src/modest-account-mgr-helpers.h:
2209 * src/modest-account-mgr-helpers.c:
2210 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2212 * src/maemo/Makefile.am:
2213 * src/maemo/modest-signature-editor-dialog.c:
2214 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2217 * src/maemo/modest-account-settings-dialog.h:
2218 * src/maemo/modest-account-settings-dialog.c:
2219 (modest_account_settings_dialog_finalize), (on_button_signature),
2220 (save_configuration): Use the new dialog when the Edit button is pressed, and
2221 save the changes if necessary, as per the UI spec.
2223 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2225 * src/maemo/Makefile.am:
2226 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2227 based on maemo-develoers email from Dirk.
2229 * src/maemo/easysetup/modest-easysetup-wizard.c:
2230 (create_page_welcome), (create_page_account_details),
2231 (create_page_user_details), (create_page_complete_easysetup),
2232 (create_page_custom_incoming), (create_page_custom_outgoing),
2233 (create_page_complete_custom),
2234 (modest_easysetup_wizard_dialog_init):
2235 * src/maemo/modest-account-settings-dialog.c:
2236 (create_page_account_details), (create_page_user_details),
2237 (create_page_incoming), (create_page_outgoing),
2238 (modest_account_settings_dialog_init):
2239 * src/maemo/modest-connection-specific-smtp-window.c:
2240 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2242 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2244 * src/maemo/easysetup/modest-easysetup-wizard.c:
2245 (create_page_account_details), (create_page_custom_outgoing),
2246 (create_page_complete_custom):
2247 * src/maemo/modest-account-settings-dialog.c:
2248 (create_page_user_details), (create_page_incoming),
2249 (create_page_outgoing):
2250 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2251 (modest_connection_specific_smtp_edit_window_init):
2252 Use the correct (UI spec) port min/max, and use horizontal separators,
2255 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2257 * src/maemo/easysetup/modest-easysetup-wizard.c:
2258 (set_default_custom_servernames):
2259 * src/maemo/modest-account-settings-dialog.c:
2260 (create_page_incoming), (on_combo_outgoing_security_changed),
2261 (on_combo_incoming_security_changed), (create_page_outgoing),
2262 (modest_account_settings_dialog_set_account_name),
2263 (save_configuration):
2264 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2265 (on_combo_security_changed),
2266 (modest_connection_specific_smtp_edit_window_init),
2267 (modest_connection_specific_smtp_edit_window_set_connection),
2268 (modest_connection_specific_smtp_edit_window_get_settings):
2269 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2272 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2275 * src/maemo/easysetup/modest-easysetup-wizard.c:
2276 (create_page_custom_outgoing), (create_page_complete_custom):
2277 * src/maemo/modest-account-settings-dialog.c:
2278 (create_page_user_details), (create_page_outgoing):
2279 * src/maemo/modest-account-view-window.c: (button_box_new):
2280 Use changed logical IDs as per the most recent UI spec:
2281 mcen_bd_emailsetup_edit -> mcen_bd_edit
2282 mcen_bd_emailsetup_delete -> mcen_bd_delete
2283 mcen_bd_emailsetup_close -> mcen_bd_close
2285 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2289 * src/dbus_api/Makefile.am:
2290 * src/dbus_api/modest-dbus-callbacks.c:
2291 * src/dbus_api/modest-dbus-callbacks.h:
2292 * src/maemo/modest-platform.c: (modest_platform_init):
2293 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2295 * tests/Makefile.am:
2296 * tests/dbus_api/Makefile.am:
2297 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2299 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2301 * src/maemo/modest-account-settings-dialog.c:
2302 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2303 Removed unnecessary includes.
2305 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2307 * src/maemo/easysetup/modest-easysetup-wizard.c:
2308 * src/maemo/modest-account-settings-dialog.c:
2309 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2310 * src/widgets/Makefile.am:
2311 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2312 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2313 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2314 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2315 * src/widgets/modest-secureauth-combo-box.c:
2316 * src/widgets/modest-secureauth-combo-box.h:
2317 * src/widgets/modest-serversecurity-combo-box.c:
2318 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2319 made the GObject names more consistent with the rest of the Modest code.
2321 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2323 * src/maemo/easysetup/Makefile.am:
2324 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2325 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2326 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2327 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2328 * src/maemo/easysetup/modest-easysetup-wizard.c:
2329 * src/maemo/easysetup/modest-validating-entry.c:
2330 * src/maemo/easysetup/modest-validating-entry.h:
2331 * src/maemo/modest-account-settings-dialog.c:
2332 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2333 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2334 widgets/ because they are used outside of easysetup too. After checking in,
2335 svn will allow me to rename them too.
2337 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2339 * src/gnome/modest-msg-edit-window.c:
2340 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2341 linker error, to fix the build on the GNOME platform.
2342 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2343 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2344 ifdefed out to avoid a warning.
2346 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2348 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2349 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2350 some alternative for GTK+ 2.6.
2352 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2354 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2356 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2357 specified for EmailAccountsDialog in UI spec.
2359 * src/maemo/easysetup/modest-easysetup-wizard.c:
2360 * src/maemo/easysetup/modest-easysetup-wizard.h:
2361 * src/maemo/modest-account-settings-dialog.c:
2362 * src/maemo/modest-account-settings-dialog.h:
2363 Reuse a member window widget for the connection-specific SMTP server accounts,
2364 so we can tell it to create/save the accounts only if we actually save changes.
2366 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2367 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2368 (modest_connection_specific_smtp_edit_window_get_settings):
2369 Return a struct instance for temporarily remembering the entered data.
2371 * src/maemo/modest-connection-specific-smtp-window.h:
2372 * src/maemo/modest-connection-specific-smtp-window.c:
2373 (modest_connection_specific_smtp_window_finalize),
2374 (modest_connection_specific_smtp_window_fill_with_connections),
2376 (modest_connection_specific_smtp_window_save_server_accounts),
2377 (update_model_server_names): Do not actually save data until asked,
2378 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2380 (on_selection_changed),
2381 (modest_connection_specific_smtp_window_init): Disable the edit
2382 button when nothing is selected.
2384 * src/modest-account-mgr-helpers.c:
2385 * src/modest-account-mgr-helpers.h:
2386 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2389 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2391 * src/modest-account-mgr-helpers.h:
2392 * src/modest-account-mgr-helpers.c:
2393 (modest_account_mgr_get_unused_account_name),
2394 (modest_account_mgr_get_unused_account_display_name): Added these
2395 utility functions, to avoid code duplication.
2397 * src/maemo/easysetup/modest-easysetup-wizard.c:
2398 (create_page_account_details), (create_account):
2399 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2400 (on_combo_security_changed),
2401 (modest_connection_specific_smtp_edit_window_init),
2402 (modest_connection_specific_smtp_edit_window_save_settings):
2403 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2404 * src/maemo/modest-connection-specific-smtp-window.c:
2405 (modest_connection_specific_smtp_window_finalize),
2406 (modest_connection_specific_smtp_window_fill_with_connections),
2407 (on_button_edit), (modest_connection_specific_smtp_window_init):
2408 * src/maemo/modest-connection-specific-smtp-window.h:
2409 Implementing saving of connection-specific server accounts.
2411 But I need to refactor this so we can save the data for each
2412 possible connection-specific account and only actually create the server accounts
2413 when the easysetup finished, or the OK button is pressed on the account settings
2416 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2418 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2419 (on_combo_security_changed):
2420 (modest_connection_specific_smtp_edit_window_init):
2421 Auto-fill the port number as in the account settings.
2423 (modest_connection_specific_smtp_edit_window_set_connection):
2424 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2425 * src/maemo/modest-connection-specific-smtp-window.c:
2426 (fill_with_connections), (on_button_edit),
2427 (modest_connection_specific_smtp_window_init):
2428 Turn the edit window into a dialog to simplify the code, and
2429 set a WM hint as in a GtkDialog, because only a popup can be on top of
2430 another window in Maemo, and popups usually have no WM decoration.
2432 * src/modest-defs.h:
2433 * src/modest-account-mgr-helpers.c:
2434 (modest_account_mgr_set_connection_specific_smtp),
2435 (modest_account_mgr_remove_connection_specific_smtp),
2436 (modest_account_mgr_get_connection_specific_smtp):
2437 * src/modest-account-mgr-helpers.h: Some functions to write the
2438 connection-specific SMTP server information. Not yet used.
2441 * src/widgets/modest-folder-view.c: (text_cell_data):
2442 Fix a warning about an uninitialized variable.
2443 (on_configuration_key_changed): Put an #ifdef around the use
2444 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2446 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2448 * src/maemo/modest-account-settings-dialog.h:
2449 * src/maemo/modest-account-settings-dialog.c:
2450 Added connect_for_modified() utility function to mark the new modified boolean.
2452 (create_page_account_details), (create_page_user_details),
2453 (create_page_incoming), (create_page_outgoing), (on_response),
2454 (modest_account_settings_dialog_init),
2455 (modest_account_settings_dialog_set_account_name):
2456 Only warn about unsaved changes when there are actually unsaved changes.
2458 * src/modest-account-mgr-helpers.c:
2459 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2460 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2461 to get the data from there in future.
2463 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2465 * src/modest-defs.h:
2467 * src/modest-account-mgr-helpers.h:
2468 * src/modest-account-mgr-helpers.c:
2469 Store the security account setting in a single conf key instead of using
2470 the options list, so that the list is left for just the to-be-removed camel hack,
2471 and because gconf_client_set_list() is failing for some reason.
2473 * src/modest-account-mgr.c:
2474 (modest_account_mgr_add_server_account):
2475 * src/maemo/modest-account-settings-dialog.c:
2476 (modest_account_settings_dialog_set_account_name),
2477 (save_configuration): Use the renamed functions.
2480 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2482 * src/widgets/Makefile.am:
2483 * src/widgets/modest-limit-retrieve-combo-box.c:
2484 * src/widgets/modest-limit-retrieve-combo-box.h:
2485 * src/widgets/modest-retrieve-combo-box.c:
2486 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2487 the account settings dialog.
2489 * src/modest-defs.h:
2490 * src/modest-account-mgr-helpers.h:
2491 * src/modest-account-mgr-helpers.c:
2492 (modest_server_account_get_option_secure_auth),
2493 (modest_server_account_set_option_secure_auth):
2494 * src/modest-account-mgr.c:
2495 (modest_account_mgr_add_server_account):
2496 Use the existing AUTH_MECH conf key for the secure-auth setting,
2497 instead of putting it in the list options, because this was actually used already.
2499 * src/maemo/modest-account-settings-dialog.c:
2500 (create_page_account_details),
2501 (modest_account_settings_dialog_set_account_name),
2502 (save_configuration):
2503 * src/maemo/modest-account-settings-dialog.h:
2504 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2505 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2507 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2509 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2510 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2511 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2513 * src/modest-defs.h:
2514 * src/maemo/modest-account-settings-dialog.c:
2515 (create_page_incoming), (on_combo_outgoing_security_changed),
2516 (on_combo_incoming_security_changed), (create_page_outgoing),
2517 (modest_account_settings_dialog_set_account_name),
2518 (save_configuration): Load/Save the port number, and change it when the
2519 security combo changes, to suitable defaults.
2521 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2523 * src/modest-account-mgr.c:
2524 (modest_account_mgr_add_server_account): Set the security and secure-auth
2525 options, and add a comment saying that the other camel-specific options should be
2528 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2530 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2532 * src/modest-tny-account-store.c: (account_list_free),
2533 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2534 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2537 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2539 * src/modest-protocol-info.c:
2540 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2541 is required by our UI spec. Maybe something in our implementation will use this eventually.
2542 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2543 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2544 instead of the previous 0 placeholder.
2546 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2547 secure-auth settings.
2548 * src/modest-account-mgr-helpers.h:
2549 * src/modest-account-mgr-helpers.c:
2550 (modest_server_account_data_get_option_secure_auth),
2551 (modest_server_account_set_option_secure_auth),
2552 (modest_server_account_data_get_option_security),
2553 (modest_server_account_set_option_security): Added this API for getting and setting the security
2554 and secure-auth settings.
2556 * src/maemo/modest-account-settings-dialog.h:
2557 * src/maemo/modest-account-settings-dialog.c:
2558 (modest_account_settings_dialog_finalize), (check_data),
2559 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2560 about changing titles.
2561 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2562 (save_configuration): Save the security and secure-auth settings.
2564 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2565 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2567 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2569 * src/modest-defs.h:
2570 * src/modest-account-mgr.c:
2571 (modest_account_mgr_add_server_account):
2572 Added and used defines for the options key and value pair strings,
2573 that are used so far, though they do not seem to correspond to anything in our
2574 UI specs or ModestProtocol enum.
2576 * src/modest-account-mgr-helpers.h:
2577 * src/modest-account-mgr-helpers.c:
2578 (compare_option_strings_for_name),
2579 (modest_server_account_data_get_option_value),
2580 (modest_server_account_data_get_option_bool),
2581 (modest_account_mgr_get_server_account_option):
2582 Added helper functions for parsing the options GSList.
2584 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2586 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2587 display name is based on the supplied account name.
2588 * src/modest-account-mgr.c:
2589 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2590 with an inefficient, but good-enough, implementation.
2592 * src/maemo/easysetup/modest-easysetup-wizard.c:
2593 (create_page_account_details), (on_before_next), (create_account):
2594 Check for existing display names rather than (non-user-visible) account names, and just
2595 create and set a unique account name at the end.
2597 * src/maemo/modest-account-settings-dialog.c:
2598 (modest_account_settings_dialog_init),
2599 (modest_account_settings_dialog_set_account_name),
2600 (create_page_incoming): Show the display name, instead of the account name.
2601 (on_response): Do some (not all) extra checks, as in the UI spec.
2602 (save_configuration): Save the display name if it was changed.
2604 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2606 * po/en_GB.po: Added needed logical ID and translation.
2607 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2608 (init_view): Made the is-default column clicking work.
2610 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2613 * src/maemo/easysetup/Makefile.am:
2614 * src/maemo/easysetup/modest-easysetup-wizard.c:
2615 (modest_easysetup_wizard_dialog_init):
2616 * src/maemo/easysetup/provider-data-test.keyfile:
2617 * src/maemo/easysetup/provider-data.keyfile:
2618 Moved the provider data file to the new modest-providers-data package and used it from there.
2620 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2622 * src/modest-local-folder-info.c:
2623 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2624 N_() was already used on the static strings, but this just marks it for translation without
2625 using the translation.
2627 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2629 * src/maemo/modest-account-settings-dialog.c:
2630 (create_page_incoming),
2631 (modest_account_settings_dialog_set_account_name):
2632 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2633 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2634 I will do this if nobody else gets there first.
2636 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2638 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2639 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2640 save the security stuff.
2642 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2644 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2645 Set the email address and user fullname, which I now see must be
2648 * src/maemo/modest-account-settings-dialog.h:
2649 * src/maemo/modest-account-settings-dialog.c:
2651 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2652 leave-on-server and authentication.
2653 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2656 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2659 * src/maemo/modest-account-settings-dialog.c:
2660 * src/maemo/modest-account-settings-dialog.h:
2661 Most (but not all) of the widgets are now present as specified by the UI spec.
2662 No changes are yet saved, and some details are not properly shown yet.
2664 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2666 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2668 * src/maemo/Makefile.am:
2669 * src/maemo/modest-account-settings-dialog.c:
2670 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2671 an existing account. Doesn't do much yet.
2673 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2674 Open the accounts settings dialog when Edit is clicked.
2676 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2678 * src/maemo/easysetup/Makefile.am:
2679 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2681 * src/maemo/easysetup/modest-easysetup-wizard.c:
2682 (modest_easysetup_wizard_dialog_init):
2683 Try to get the source directory from the build system,
2684 instead of hard-coding "./" into the source code, when opening our local
2685 copies of the configuration files.
2686 But this still fails when opening the wizard from the Accounts window,
2687 maybe because the working directory seems to change at runtime.
2688 So the wizard will fail the second time unless you copy the files into their
2689 proper locations - see the stdout warnings for the paths.
2691 (create_page_account_details),(on_before_next):
2692 Check for existing non-server accounts instead of server accounts,
2693 so the default account name is useful again, and to prevent trying to
2696 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2697 Show the wizard when New is clicked.
2699 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2700 (init_view): Show the column headers, and show the columns that are
2701 specified in the UI specs. However, something in Maemo's GTK+ prevents
2702 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2703 change the default account. This is despite unsetting the special properties.
2705 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2707 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2708 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2709 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2710 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2711 to make that clearer.
2712 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2714 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2716 * src/maemo/modest-account-view-window.c:
2717 (modest_account_view_window_init),
2718 (modest_account_view_window_new):
2719 Use the same buttons as specified in the
2720 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2721 the existing widgets, which never had a chance of working.
2722 Put the ModestAccountView treeview in a scrolled window.
2723 Do not repeat the initialization in both _init() and _new().
2725 * src/widgets/modest-account-view.c: (update_account_view):
2726 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2727 this widget and window shows no accounts.
2729 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2731 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2733 * src/maemo/easysetup/modest-easysetup-wizard.c:
2734 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2735 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2736 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2739 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2740 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2741 accounts exist yet, as in the UI spec.
2743 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2745 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2747 * src/maemo/Makefile.am:
2748 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2749 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2750 New window for editing connection-specific smtp details.
2751 Not fully implemented.
2753 * src/maemo/modest-connection-specific-smtp-window.c:
2754 (modest_connection_specific_smtp_window_finalize) :
2755 unref the tree model.
2756 (on_button_edit): Show the edit window.
2758 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2760 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2763 * src/maemo/Makefile.am:
2764 * src/maemo/modest-connection-specific-smtp-window.c:
2765 * src/maemo/modest-connection-specific-smtp-window.h:
2766 New window for showing the list of connections, for connection-specific
2767 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2768 * src/maemo/easysetup/modest-easysetup-wizard.c:
2769 (create_page_custom_outgoing): Show the new window when the button is clicked.
2771 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2773 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2774 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2775 * src/maemo/modest-msg-edit-window.c:
2776 (modest_msg_edit_window_insert_image):
2777 * src/modest-conf.c: (modest_conf_key_escape):
2778 * src/modest-mail-operation.c:
2779 (modest_mail_operation_send_new_mail):
2780 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2781 (modest_ui_actions_on_new_account):
2782 * src/widgets/modest-attachment-view.c: (update_filename_request):
2783 * src/widgets/modest-mail-header-view.c:
2784 Corrected warnings that were breaking the build, by commenting out unused variables,
2785 and a function, and by including a header.
2787 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2789 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2790 so we can #ifdef around platform-specific code when necessary.
2791 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2792 to allow this to build for the GNOME platform too.
2794 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2796 * src/maemo/easysetup/modest-easysetup-wizard.c:
2797 Added util_increment_name() and used it in create_page_account_details()
2798 to make sure that the default account name is always a new name.
2800 (modest_easysetup_wizard_dialog_init),
2801 (set_default_custom_servernames): Some minor memory management fixes.
2803 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2807 * src/modest-runtime.c: (init_i18n): Restored the translation
2808 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2809 are defined in config.h, and the translations are installed.
2811 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2812 is defined for translation.
2814 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2816 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2818 * src/maemo/easysetup/modest-easysetup-wizard.c:
2819 (modest_easysetup_wizard_dialog_init):
2820 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2821 Use realistic paths (though they should use $prefix generically) to the
2822 mcc_mapping and provider-data.keyfile files which might work when they
2823 are installed by the future version of the operator-wizard package,
2824 and then fallback to paths in our source code, with an explanatory
2827 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2831 * src/maemo/Makefile.am:
2832 * src/maemo/easysetup/: Added files from the previously-exernal
2833 osso-modest-easysetup.
2834 * src/maemo/modest-main-window-ui.h:
2835 * src/modest-ui-actions.c:
2836 * src/modest-ui-actions.h:
2837 Added modest_ui_actions_on_new_account() as a signal handler for the
2838 New Account menu item. It shows the easysetup wizard.
2839 * po/en_GB.po: Added additional needed logical IDs and translations.
2841 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2842 Apparently ChangeLog is not used for some vague Nokia legal reasons.