1 2007-06-01 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4 Check for running mail operations, and offer to cancel them, as per the UI
5 spec. This fixes projects.maemo.org bug NB#59041 .
6 However, I suspect that tinymail may still use the network connection
7 in ways that we cannot detect or cancel. But it should at least adapt to
10 2007-06-01 Murray Cumming <murrayc@murrayc.com>
12 * src/modest-tny-account-store.c: (recreate_all_accounts),
13 (get_cached_accounts), (get_server_accounts): Do more sensible
14 ref-counting of the temporarily-cached outbox accounts list. This seems
15 to fix a crash when entering the password when the password was wrong.
17 2007-06-01 Murray Cumming <murrayc@murrayc.com>
19 * src/gnome/modest-main-window.c: (connect_signals):
20 * src/modest-tny-account-store.c: (get_password),
21 (modest_tny_account_store_alert): Added comments and clues and
22 commented-out code about how we currently fail to deal with connection
23 errors and wrong passwords, and how we should.
25 2007-06-01 Murray Cumming <murrayc@murrayc.com>
27 * src/widgets/modest-retrieve-combo-box.c:
28 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
29 This fixes projects.maemo.org bug NB#58472 .
31 2007-06-01 Murray Cumming <murrayc@murrayc.com>
33 * src/maemo/easysetup/modest-easysetup-wizard.c:
34 (create_page_complete_easysetup):
35 (create_page_complete_custom): Correct the last commit,
36 putting the correct sentences in the correct pages.
38 2007-06-01 Murray Cumming <murrayc@murrayc.com>
40 * src/maemo/easysetup/modest-easysetup-wizard.c:
41 (create_page_complete_custom): Show the second sentence of text
42 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
45 2007-06-01 Murray Cumming <murrayc@murrayc.com>
47 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
48 Set the leave-on-server conf key by default. This fixes
49 projects.maemo.org bug NB#59258 .
51 2007-06-01 Murray Cumming <murrayc@murrayc.com>
53 * src/maemo/modest-account-view-window.c:
54 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
55 logical ID for the confirmation messages. Fixed projects.maemo.org bug
58 2007-06-01 Murray Cumming <murrayc@murrayc.com>
60 * src/maemo/easysetup/modest-easysetup-wizard.c:
61 (create_caption_new_with_asterisk):
62 * src/maemo/modest-account-settings-dialog.c:
63 (create_caption_new_with_asterisk):
64 Uncomment the code to add the asterisk, because they are no longer in the
65 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
66 (update_incoming_server_title): Add an asterisk here too.
68 2007-06-01 Murray Cumming <murrayc@murrayc.com>
70 * src/maemo/modest-maemo-global-settings-dialog.c:
71 (current_connection): Check that we are even connected before trying to
72 get the current connection name, to prevent a warning.
74 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
75 Change the comments because tny_maemo_conic_device_connect() is now meant to
77 * src/modest-mail-operation.c:
78 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
79 make sure we have a connection and fail if we can't connect.
81 2007-05-31 Murray Cumming <murrayc@murrayc.com>
83 * src/maemo/modest-main-window.c:
84 (on_account_store_connecting_finished): Do not try to get the
85 connection ID if we are not really connected. I am surprised that
86 this signal handler is called when we are not connected.
88 2007-05-31 Murray Cumming <murrayc@murrayc.com>
91 * src/modest-ui-actions.c:
92 (modest_ui_actions_get_msgs_full_error_handler):
93 Renamed an enum, added comments, added an enum
94 for retrieve-limit errors.
96 * src/modest-mail-operation.c: (foreach_add_item),
97 (internal_folder_observer_update), (update_account_thread),
98 (modest_mail_operation_get_msgs_full):
99 (modest_mail_operation_update_account),
100 Added comments about how this works, and some code that should
101 (but does not) check the retrieve-limit. See the TODO comment.
103 2007-05-31 Murray Cumming <murrayc@murrayc.com>
105 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
106 Initialize help_id to fix the build. Warnings are good.
108 2007-05-31 Murray Cumming <murrayc@murrayc.com>
110 * src/widgets/modest-hbox-cell-renderer.c:
111 (modest_hbox_cell_renderer_append):
112 * src/widgets/modest-vbox-cell-renderer.c:
113 (modest_vbox_cell_renderer_append):
114 Fix the last commit by doing an extra ref.
116 2007-05-31 Murray Cumming <murrayc@murrayc.com>
118 * src/widgets/modest-hbox-cell-renderer.c:
119 (modest_hbox_cell_renderer_append):
120 * src/widgets/modest-vbox-cell-renderer.c:
121 (modest_vbox_cell_renderer_append):
122 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
123 to fix the build with Maemo Bora.
124 However, there seems to be a remaining crash, probably due to reference
127 2007-05-30 Murray Cumming <murrayc@murrayc.com>
129 * src/modest-tny-account.c:
130 (modest_tny_account_new_for_local_folders):
131 Use hildon_file_system_info_async_new() to get a better name for
132 the memory card account, setting it as the account name.
133 The timing seems to work, but this is probably
134 not the best place to do this. See the TODO comment.
135 * src/maemo/modest-main-window.c: (create_details_widget):
136 * src/widgets/modest-folder-view.c: (text_cell_data):
137 Use the tny account name instead of hardcoding a name.
139 2007-05-30 Christian Kellner <ckellner@openismus.com>
141 * src/modest-search.c: (modest_search):
142 Correctly set part_search_func even if we have already parsed
143 the query and thus a valid OgsTextSearcher object.
145 2007-05-30 Christian Kellner <ckellner@openismus.com>
148 Search and check for libogs.
151 Incooparte the ogs build env.
153 * src/modest-mime-part-search-stream.c:
154 * src/modest-mime-part-search-stream.h:
155 Removed since we do the real searching now in modest-search.c.
157 * src/modest-search.c:
158 * src/modest-search.h:
159 Implement support for ogs. We use that if available and requested
160 and fall back to modest_text_utils_utf8_strcmp (). The search logic
161 should now handle the corner case when the search term is spread
162 across multiple reads.
163 Also the logic in modest_search () was corrected to search all
164 requested fields until one is found.
166 2007-05-30 Murray Cumming <murrayc@murrayc.com>
168 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
171 * src/modest-init.c: Made modest_init_local_folders() take a
172 path and be public so we can iniitialize maildir folders on
175 * src/modest-local-folder-info.h:
176 * src/modest-local-folder-info.c:
177 (modest_local_folder_info_get_maildir_path): Add a path parameter.
179 * src/modest-tny-account.c:
180 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
181 still means the standard local-folders path on the local volume.
183 * src/modest-tny-account-store.c:
184 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
185 signal so we can detect mount/unmount of the MMC1 card, and do an update of
186 all accounts when that happens.
187 (get_server_accounts): If the MMC1 card is mounted, create a store account for
188 this too, so it shows up in the treeview.
190 2007-05-28 Murray Cumming <murrayc@murrayc.com>
192 * src/maemo/modest-maemo-global-settings-dialog.c:
193 (current_connection):
194 * src/widgets/modest-global-settings-dialog.c:
195 (current_connection_default):
196 Use the enum values instead of 0, 1 and -1,
197 to make the code clearer.
199 * src/modest-account-mgr-helpers.c:
200 (modest_account_mgr_get_connection_specific_smtp): Make this code
203 * src/modest-runtime.h:
204 * src/modest-runtime.c:
205 Added modest_runtime_remove_all_send_queues().
206 * src/maemo/modest-main-window.c:
207 (on_account_store_connecting_finished): Recreate the send queues,
208 using the appropriate transport accounts for this new connection.
209 Some futher adapting might be needed if the old send queues are not
210 automatically stopped at this point.
212 * src/modest-tny-account-store.c: (get_server_accounts):
213 Create the connection-specific transport accounts, so that they can
214 be found later by their ID.
216 * src/modest-tny-account.h:
217 * src/modest-tny-account.c:
218 Added modest_tny_account_new_from_server_account_name().
219 modest_tny_account_new_from_server_account(): Do not create the
220 send queues here, because they will be
221 recreated anyway when the connection changes for the first time.
223 2007-05-28 Murray Cumming <murrayc@murrayc.com>
225 * src/modest-local-folder-info.h:
226 * src/modest-local-folder-info.c:
227 (modest_per_account_local_outbox_folder_info_get_maildir_path),
228 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
229 tbox_folder): Take a modest account name instead of a server TnyAccount,
230 so we can have per-modest-account rather than per-transport-account
232 We must make sure that we change or recreate the exisitng send queues
233 when the connection changes for connection-specific transport accounts.
235 * src/modest-tny-account-store.c:
236 (create_per_account_local_outbox_folders): Create outboxed per modest
237 account, not per transport account.
239 * src/modest-tny-account.h:
240 * src/modest-tny-account.c:
241 (modest_tny_account_get_special_folder): For outboxes, get the
242 parent modest account name. The account is ignored for other folders.
243 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
244 modest account name rather than a server TnyAccount.
246 2007-05-25 Murray Cumming <murrayc@murrayc.com>
248 * src/modest-tny-account.c:
249 (modest_tny_account_new_from_server_account):
250 Call modest_runtime_get_send_queue() immediately after creating transport
251 accounts, so that they start trying to send email from the outbox as soon
252 as possible at startup. This is probably what we want.
254 * src/modest-mail-operation.c: (update_account_thread):
255 * src/modest-runtime.c: (modest_runtime_get_send_queue):
256 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
257 * src/modest-tny-send-queue.h:
258 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
259 (modest_ui_actions_on_send):
260 Added comments about how sending works, though it needs some more work.
262 2007-05-25 Murray Cumming <murrayc@murrayc.com>
264 * src/modest-tny-account.c:
265 (modest_tny_account_get_special_folder): Add TODO because this fails when
267 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
268 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
269 Do not try to show this window when there is no active account. The UI
270 specs does not tell us what to do in this case.
272 2007-05-24 Murray Cumming <murrayc@murrayc.com>
276 * src/maemo/Makefile.am:
277 * src/widgets/Makefile.am: Some dist fixes.
279 2007-05-24 Murray Cumming <murrayc@murrayc.com>
281 * src/maemo/modest-connection-specific-smtp-window.c:
282 (on_button_edit): Make the code clearer, to prevent a double free.
284 2007-05-24 Murray Cumming <murrayc@murrayc.com>
286 * src/maemo/modest-account-settings-dialog.c:
287 (modest_account_settings_dialog_set_account_name),
288 Check the connection-specific smtp servers checkbox if there are any.
290 * src/maemo/modest-connection-specific-smtp-edit-window.c:
291 (modest_connection_specific_smtp_edit_window_init):
292 Start with a suitable port number.
294 * src/modest-account-mgr-helpers.h:
295 * src/modest-account-mgr-helpers.c: Added
296 modest_account_mgr_get_has_connection_specific_smtp().
298 (modest_account_mgr_set_connection_specific_smtp),
299 (modest_account_mgr_remove_connection_specific_smtp),
300 (modest_account_mgr_get_has_connection_specific_smtp),
301 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
302 connection-specific smtp server accounts in the account, rather than
303 the server account conf dir.
305 This fixes bug projects.maemo.org bug NB#58263 .
307 * src/modest-tny-account-store.c:
308 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
309 if there are no server accounts yet, to prevent an infinite loop when there
310 are no accounts. Document that one must be called before the other.
312 2007-05-24 Murray Cumming <murrayc@murrayc.com>
314 * src/modest-account-mgr-helpers.c:
315 (modest_account_mgr_get_default_account): Make sure that at least
316 one account is always the default, if there are any enabled accounts.
317 This is just a sanity check that shouldn't be necessary.
319 * src/modest-account-mgr-priv.c:
320 (_modest_account_mgr_account_from_key): Unescape the conf key to
321 get the real account name. For instance, this is an issue if a space
322 was in the account name, which can happen because the account name
323 is generated from the display name.
324 (_modest_account_mgr_get_account_keyname): Always escape the
326 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
327 Unescape the conf keys to get the real account names.
329 For instance, previously the is-default radio button in the accounts
330 list was not checked for any accounts at first. This fixes that,
331 and might fix several similar bugs.
333 2007-05-23 Murray Cumming <murrayc@murrayc.com>
335 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
336 Removed some debug printfs.
338 2007-05-23 Murray Cumming <murrayc@murrayc.com>
340 Modest on-disk outbox directories are now here, for instance:
341 $HOME/.modest/outboxes/<account-id-1>/outbox
342 $HOME/.modest/outboxes/<account-id-2>/outbox
344 $HOME/.modest/local-folders/outbox
345 so we can have a separate outbox for each account.
346 But they are shown as one outbox in the GtkTreeView, by using a
347 TnyMergeFolder in a ModestTnySimpleFolderStore.
350 * src/modest-tny-simple-folder-store.c:
351 * src/modest-tny-simple-folder-store.h:
352 Added ModestTnySimpleFolderStore, used to contain folders from
353 other folder stores, such as other accounts.
355 * src/modest-tny-outbox-account.h:
356 * src/modest-tny-outbox-account.c:
357 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
358 used for the per-account local outbox folders.
360 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
361 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
362 only use this (internally) now for the non-outbox local folders.
365 * src/modest-init.c: Added modest_init_one_local_folder(), for
366 setting up the directory structure for each local folder.
368 * src/modest-local-folder-info.c:
369 (modest_per_account_local_outbox_folder_info_get_maildir_path),
370 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
372 * src/modest-local-folder-info.h:
373 * src/modest-tny-account-store.c: (on_account_removed),
374 (on_account_changed), (create_per_account_local_outbox_folders),
375 (get_server_accounts), (modest_tny_account_store_get_accounts),
376 (modest_tny_account_store_get_tny_account_by_account),
377 (modest_tny_folder_store_is_virtual_local_folders):
379 * src/modest-tny-account.h:
380 * src/modest-tny-account.c:
381 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
382 to create an on-disk per-account local outbox folder for each
384 (create_per_account_local_outbox_folders): Create a local outbox folder
385 for each transport account.
386 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
387 for all local folders.
389 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
390 instead of using g_object_get/set() directly. It is clearer.
392 (modest_tny_folder_store_get_message_count),
393 (modest_tny_folder_store_get_local_size
394 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
395 because we now use these with non-acount folder stores.
397 (modest_tny_account_get_special_folder),
398 (modest_tny_account_new_from_server_account),
399 (modest_tny_account_new_from_account):
400 (recurse_folders): Adjust to the new outbox system.
402 * src/modest-tny-folder.h:
403 * src/modest-tny-folder.c:
404 (modest_tny_folder_is_local_folder),
405 (modest_tny_folder_get_local_folder_type),
406 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
408 * src/widgets/modest-main-window.h:
409 * src/maemo/modest-main-window.c: (create_details_widget),
410 (modest_main_window_set_contents_style): Show details for any folder store,
413 (modest_tny_folder_get_rules):
414 Remove the const. C does not support constness enough for this.
416 * src/modest-ui-actions.c:
417 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
418 make all outboxes appear as one, in the usual local-folders tree node.
420 (set_active_account_from_tny_account),
421 (modest_ui_actions_on_folder_selection_changed):
422 * src/widgets/modest-folder-view.c: (text_cell_data),
423 (icon_cell_data), (filter_row),
424 (add_account_folders_to_merged_folder),
425 (add_account_folders_to_simple_folder_store), (),
426 (get_cmp_rows_type_pos), (cmp_rows),
427 (modest_folder_view_set_account_id_of_visible_server_account):
428 Adjust to the new outbox system, using generic folder stores and folders
431 2007-05-23 Christian Kellner <ckellner@openismus.com>
433 * src/modest-mail-operation.c:
434 (modest_mail_operation_update_account):
435 Use info->max_size instead of unintialized local var [small
436 build fix]. (Added TODO to review that change since I don't
439 2007-05-23 Marcus Bauer <marcusb@openismus.com>
441 * libmodest-dbus-client/libmodest-dbus-client.c:
442 (libmodest_dbus_client_compose_mail): function added
443 * src/dbus_api/modest-dbus-api.h:
444 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
445 (on_compose_mail): Implementation of the SendAsMail functionality
447 2007-05-22 Murray Cumming <murrayc@murrayc.com>
449 * src/modest-account-mgr.c:
450 (modest_account_mgr_add_server_account): Set the secure-connection
451 conf key for transport accounts as well as store accounts. I don't know
452 why the if was there. For instance, this makes sure that we use SSL
453 for the gmail preset from the easysetup wizard.
455 2007-05-22 Murray Cumming <murrayc@murrayc.com>
457 * src/gnome/modest-main-window.c:
458 (on_account_store_connecting_finished), (connect_signals):
459 * src/maemo/modest-main-window.c:
460 (on_account_store_connecting_finished), (connect_signals),
461 (modest_main_window_new):
462 Handle TnyAccountStore::connecting-finished instead of
463 TnyDevice::connection-changed, because we cannot actually perform
464 operations on accounts until TnyAccountStore has itself responded to
465 the TnyDevice::connection-changed signal. This prevents a GError from
467 Do not try to update at startup, because we (at least on scratchbox)
468 already do an update at startup when the device goes online.
469 This prevents a GError from tinymail.
470 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
471 Added TODO about stopping simultaneous operations.
473 2007-05-21 Murray Cumming <murrayc@murrayc.com>
475 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
476 * src/modest-mail-operation-queue.c:
477 (modest_mail_operation_queue_remove):
478 * src/modest-tny-account-store.c: When GErrors happen, give more clues
479 about where they happened.
481 2007-05-21 Murray Cumming <murrayc@murrayc.com>
483 * src/modest-ui-actions.c:
484 (modest_ui_actions_on_password_requested): Make sure that the remember
485 output parameter is always TRUE.
487 2007-05-21 Murray Cumming <murrayc@murrayc.com>
489 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
490 Show a OK/Cancel dialog if the error is a question, though we still do not
491 know anything more about what we are asking the user.
492 * src/widgets/modest-folder-view.c: (on_drag_data_received):
493 Fix an uninitialized variable (helper). This is a logic error, however.
495 2007-05-21 Christian Kellner <ckellner@openismus.com>
497 * src/modest-search.h:
498 Correct bit shifting in the ModestSearchFlags enum.
500 2007-05-21 Murray Cumming <murrayc@murrayc.com>
502 * src/modest-tny-account.c:
503 (modest_tny_account_new_from_server_account): Do not use the lsub and
504 check-all hard-coded IMAP options when using POP.
506 2007-05-21 Murray Cumming <murrayc@murrayc.com>
508 * src/modest-tny-account.c:
509 (modest_tny_account_new_from_server_account):
510 Use NULL for the secure-auth method for POP when Password auth has been
511 specified by the user, as we already do for IMAP. "auth=Login" causes
512 an error from camel or the server.
514 2007-05-17 Murray Cumming <murrayc@murrayc.com>
516 * src/maemo/modest-account-settings-dialog.c:
517 (create_page_account_details),
518 (modest_account_settings_dialog_set_account_name):
519 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
520 for the leave-on-server checkbox, rathr than just the checkbox, when
521 the protocol is not POP.
523 2007-05-17 Murray Cumming <murrayc@murrayc.com>
525 * src/widgets/modest-account-view.c:
526 * src/widgets/modest-account-view.h:
527 Added modest_account_view_select_account() which will be useful later
528 to asynchronously re-select the edited account.
530 2007-05-17 Murray Cumming <murrayc@murrayc.com>
532 * src/maemo/modest-account-settings-dialog.c:
533 (modest_account_settings_dialog_set_account_name):
534 Automatically choose the port numbers based on the secure authentication
535 methods, if they have not been chosen before.
536 This fixes projects.maemo.org bug NB#56273 .
538 2007-05-17 Murray Cumming <murrayc@murrayc.com>
540 * src/maemo/modest-main-window-ui.h:
541 * src/modest-ui-actions.c:
542 * src/modest-ui-actions.h:
543 Connect the Tools/SMTP Servers menu item to
544 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
545 SMTP servers dialog, as in the UI specification and saves changes when it
546 is closed. This fixed projects.maemo.org bug NB#56305 .
548 2007-05-17 Murray Cumming <murrayc@murrayc.com>
550 * src/maemo/modest-connection-specific-smtp-window.c:
551 (modest_connection_specific_smtp_window_init):
552 Use gtk_window_set_default_size() to make this window big enough, so
553 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
555 2007-05-17 Murray Cumming <murrayc@murrayc.com>
557 * src/maemo/modest-connection-specific-smtp-edit-window.h:
558 * src/maemo/modest-connection-specific-smtp-edit-window.c:
559 (modest_connection_specific_smtp_edit_window_init),
560 Do not try to connect to a combobox signal before the combobox exists.
561 This fixes the cras in projects.maemo.org bug NB#56288 .
562 (modest_connection_specific_smtp_edit_window_get_settings):
563 Remove the server_account_name parameter which was being checked for NULL
564 though it was not used.
566 * src/maemo/modest-connection-specific-smtp-window.c:
567 (modest_connection_specific_smtp_window_fill_with_connections),
568 (on_button_edit), (modest_connection_specific_smtp_window_init):
569 Correct the number of treemodel columns to prevent a warning.
570 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
571 libconic does not work.
573 2007-05-16 Murray Cumming <murrayc@murrayc.com>
575 * src/modest-tny-account.c:
576 (modest_tny_account_new_from_server_account):
577 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
578 SMTP when "None" was chosen by the user. However, with my SMTP server that
579 does not support ANONYMOUS, the emails do not leave the Outbox and I see
582 2007-05-16 Murray Cumming <murrayc@murrayc.com>
584 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
585 to explain the memory management issue with the ID in the ModestPair.
587 * src/gnome/modest-account-assistant.c: (add_receiving_page),
588 (add_sending_page), (modest_account_assistant_finalize):
589 * src/gnome/modest-gnome-global-settings-dialog.c:
590 (create_updating_page), (create_composing_page):
591 * src/gnome/modest-msg-edit-window.c: (get_transports),
592 (init_window), (modest_msg_edit_window_finalize),
593 (modest_msg_edit_window_get_msg_data):
594 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
595 * src/gnome/modest-transport-widget.c:
596 (modest_transport_widget_finalize), (smtp_configuration):
597 * src/maemo/modest-maemo-global-settings-dialog.c:
598 (create_updating_page), (create_composing_page):
599 * src/maemo/modest-msg-edit-window.c: (get_transports),
600 (init_window), (modest_msg_edit_window_finalize),
601 (modest_msg_edit_window_get_msg_data),
602 (modest_msg_edit_window_free_msg_data):
603 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
604 (modest_store_widget_finalize):
605 * src/maemo/modest-transport-widget.c:
606 (modest_transport_widget_finalize), (smtp_configuration):
607 * src/modest-main.c: (send_mail):
608 * src/widgets/modest-combo-box.h:
609 * src/widgets/modest-global-settings-dialog-priv.h:
610 * src/widgets/modest-global-settings-dialog.c:
611 (modest_global_settings_dialog_finalize):
612 * src/widgets/modest-msg-edit-window.h:
613 Whenever using modest_combo_box_new(), keep the ModestPairList alive
614 as long as the combo box, to prevent use of freed memory for the ID.
616 2007-05-15 Murray Cumming <murrayc@murrayc.com>
618 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
619 get_accounts(), to make this clearer. Do not check for the enabled gconf
620 key, because we do not use this for server accounts (at least, not yet).
621 This allows us to send email again.
623 2007-05-15 Murray Cumming <murrayc@murrayc.com>
625 * src/maemo/modest-platform.c:
626 (on_modest_conf_update_interval_changed), (modest_platform_init):
627 Only respond to this particular key change. All these strcmp()s cannot be
630 2007-05-15 Murray Cumming <murrayc@murrayc.com>
632 * src/maemo/modest-maemo-global-settings-dialog.c:
633 (current_connection): Prevent a crash in scratchbox when
634 ny_maemo_conic_device_get_current_iap_id() returns NULL.
635 * src/maemo/modest-platform.c:
636 (on_modest_conf_update_interval_changed), (modest_platform_init):
637 Get the update interval from gconf and reset it when the gconf key changes.
639 2007-05-15 Murray Cumming <murrayc@murrayc.com>
641 * src/modest-protocol-info.c:
642 * src/modest-protocol-info.h: Adde enum-specific get functions,
643 instead of using a ModestProtocolType enum parameter.
645 * src/gnome/modest-account-assistant.c:
646 * src/gnome/modest-store-widget.c:
647 * src/gnome/modest-store-widget.h:
648 * src/gnome/modest-transport-widget.c:
649 * src/gnome/modest-transport-widget.h:
650 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
651 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
652 * src/maemo/easysetup/modest-easysetup-wizard.c:
653 * src/maemo/modest-account-settings-dialog.c:
654 * src/maemo/modest-account-settings-dialog.h:
655 * src/maemo/modest-store-widget.c:
656 * src/maemo/modest-store-widget.h:
657 * src/maemo/modest-transport-widget.c:
658 * src/maemo/modest-transport-widget.h:
659 * src/modest-account-mgr-helpers.c:
660 * src/modest-account-mgr-helpers.h:
661 * src/modest-account-mgr.c:
662 * src/modest-account-mgr.h:
663 * src/modest-tny-account.c:
664 * src/modest-tny-folder.c:
665 * src/widgets/modest-account-view.c:
666 * src/widgets/modest-retrieve-combo-box.c:
667 * src/widgets/modest-retrieve-combo-box.h:
668 * src/widgets/modest-secureauth-combo-box.c:
669 * src/widgets/modest-serversecurity-combo-box.c:
670 * src/widgets/modest-serversecurity-combo-box.h:
671 * tests/check_account-mgr.c:
672 Use the specific functions, and use the re-renamed enum values for GNOME too.
674 2007-05-15 Murray Cumming <murrayc@murrayc.com>
677 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
678 so we can get the second based on the first.
680 * src/maemo/modest-account-settings-dialog.h:
681 * src/maemo/modest-account-settings-dialog.c:
682 Added get_supported_secure_authentication_methods(), though it is mostly
683 commented-out for now until the necessary API is committed to tinymail.
684 (modest_account_settings_dialog_set_account_name),
685 (save_configuration): Request the supported authentication methods from the
686 server, so we can choose a working method.
688 * src/modest-tny-account-store.h:
689 * src/modest-tny-account-store.c:
690 (modest_tny_account_store_get_session): Rename from
691 tny_account_store_get_session().
693 2007-05-14 Murray Cumming <murrayc@murrayc.com>
695 * src/modest-protocol-info.h: Split the ModestProtocol enum
696 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
697 There was no need to have these unrelated values in one enum.
699 * src/: many files: Adapted to changed enum. This makes the code a bit
700 clearer, and the compiler could catch some errors.
702 2007-05-14 Murray Cumming <murrayc@murrayc.com>
704 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
705 Show the detailed internal camel error message when an error happens
706 during the configuration, so that our testers can give us more clues.
707 For instance, in projects.maemo.org bug NB#56910 .
709 2007-05-14 Murray Cumming <murrayc@murrayc.com>
711 * src/modest-tny-account.c:
712 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
713 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
715 2007-05-14 Murray Cumming <murrayc@murrayc.com>
717 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
718 * src/maemo/modest-account-settings-dialog.c:
719 (modest_account_settings_dialog_set_account_name),
720 (save_configuration): For the incoming secure authentication checkbox,
721 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
722 the UI specification. PLAIN does not seem to be supported for most IMAP
723 servers anyway, and I am not sure what it would mean.
724 However, we probably need to discover which of the secure-authentication
725 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
726 * src/modest-account-mgr-helpers.c:
727 (modest_account_mgr_get_server_account_data):
729 * src/modest-tny-account.c:
730 (modest_tny_account_new_from_server_account):
731 Use tny_account_set_mech() to set secure-authentication methods,
732 with some special-casing for IMAP, based on my observations of how
735 * src/modest-account-mgr-helpers.h:
736 * src/modest-account-mgr.c:
737 * src/modest-defs.h: Comment that the URI is only used for local folders.
739 2007-05-11 Murray Cumming <murrayc@murrayc.com>
741 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
742 parameter const, just to be neat.
743 * src/modest-text-utils.c: (modest_text_utils_inline):
744 End g_strconcat() with NULL, as its documentation says. This is almost
745 certainly the cause of my crash at startup on the device. Interestingly,
746 valgrind doesn't tell us about these errors.
748 2007-05-11 Murray Cumming <murrayc@murrayc.com>
750 * scripts/build-packages: Added more precise comments about how to use
751 this script, though I still get this error:
752 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
753 error building tinymail
755 2007-05-11 Murray Cumming <murrayc@murrayc.com>
757 * src/maemo/modest-main-window.c: (on_account_update):
758 Very slight cleanup, hoping to make it simpler to discover what causes
759 a crash here sometimes.
761 * src/modest-tny-account.c:
762 (modest_tny_account_new_from_server_account): Set the port. Added
763 comments about the options and a TODO comment because I need to find out
764 how to specify the secure authentication method.
766 2007-05-11 Marcus Bauer <marcusb@openismus.com>
768 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
769 changed CFlags paths form modest to libmodest
771 2007-05-10 Murray Cumming <murrayc@murrayc.com>
773 * src/modest-account-mgr-helpers.c:
774 (modest_account_mgr_get_server_account_data),
775 (modest_account_mgr_free_server_account_data):
776 * src/modest-account-mgr-helpers.h:
777 * src/modest-account-mgr.c:
778 (modest_account_mgr_add_server_account):
780 * src/modest-tny-account.c:
781 (modest_tny_account_new_from_server_account):
782 Determine the options for tny_camel_account_add_option() here,
783 based on the settings, rather than storing them directly in gconf.
785 2007-05-10 Murray Cumming <murrayc@murrayc.com>
787 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
788 Show a more friendly error dialog now that we expect (from the tinymail
789 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
791 2007-05-10 Murray Cumming <murrayc@murrayc.com>
793 * src/maemo/modest-main-window.c: (on_account_update): Check that
794 account_name is not NULL, to prevent a crash at startup that I am
795 seeing on the N800. I do wonder why it is NULL.
797 * src/maemo/easysetup/modest-easysetup-wizard.c:
798 (create_page_user_details):
799 * src/maemo/modest-account-settings-dialog.c:
800 (create_page_user_details), (create_page_outgoing):
801 * src/maemo/modest-connection-specific-smtp-edit-window.c:
802 (modest_connection_specific_smtp_edit_window_init):
803 * src/modest-ui-actions.c:
804 (modest_ui_actions_on_password_requested):
805 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
806 might do something useful with the on-screen keyboard.
808 2007-05-10 Murray Cumming <murrayc@murrayc.com>
810 * src/maemo/modest-main-window.c: (on_account_update):
811 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
812 NULL, to avoid lots of warnings. However, it probably should not be NULL.
814 2007-05-09 Murray Cumming <murrayc@murrayc.com>
816 * src/modest-tny-account-store.c: (on_account_changed):
817 Correct the signature of this signal handler.
819 2007-05-09 Murray Cumming <murrayc@murrayc.com>
821 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
822 Show a HildonNote instead of a GtkDialog for Maemo.
824 2007-05-09 Murray Cumming <murrayc@murrayc.com>
826 * src/widgets/modest-account-view.h:
827 * src/widgets/modest-account-view.c: (on_account_changed),
828 (on_account_removed). Added a boolean flag, set/unset by
829 modest_account_view_block_conf_updates(),
830 modest_account_view_unblock_conf_updates() to prevent unnecessary
831 updates, but this is not very useful because the gconf notifications are
832 so delays (maybe only on Maemo Bora).
833 So auto-updating is turned off, and these functions do an explicit
834 update when necessary.
835 However, something else is still doing too much work when adding/removing
836 accounts, probably in another part of the application.
838 * src/maemo/modest-account-view-window.c:
839 (on_delete_button_clicked), (on_edit_button_clicked),
840 (on_new_button_clicked): Use the new functions.
842 2007-05-09 Murray Cumming <murrayc@murrayc.com>
844 * src/modest-account-mgr-helpers.c:
845 (modest_account_mgr_set_first_account_as_default):
846 Sort the list of names alphabetically-by-title, so we choose the first one
848 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
849 alphabetically by the title.
851 This fixes projects.maemo.org bug NB#56418 .
853 * src/modest-account-mgr-priv.c:
854 (_modest_account_mgr_account_from_key):
855 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
856 avoid a valgrind error, and possible random behaviour.
858 2007-05-09 Murray Cumming <murrayc@murrayc.com>
860 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
861 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
862 tinymail documentation to say that this can be expected.
863 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
864 pretty, and should not happen, but I would prefer to know when it does.
866 2007-05-09 Murray Cumming <murrayc@murrayc.com>
868 * configure.ac: When using the older hildon version, probably on Bora,
869 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
871 * src/widgets/modest-attachment-view.c:
872 (modest_attachment_view_set_part_default): Initialize variables, to fix the
875 2007-05-09 Marcus Bauer <marcusb@openismus.com>
877 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
878 Implemented the prototype. Can be tested with
879 tests/dbus_api/test_open_message:
881 2007-05-08 Murray Cumming <murrayc@murrayc.com>
883 * src/modest-tny-account-store.c:
884 (modest_tny_account_store_instance_init), (get_password):
885 * src/modest-ui-actions.c:
886 (modest_ui_actions_on_password_requested):
887 Do not store the password in gconf, because this function is called
888 for non-remembered passwords. Actually use the cached (in the hash map)
889 password instead of releasing it.
890 The password will now not be remembered if it is asked via the protected
891 password dialog, as per the UI spec.
893 2007-05-08 Murray Cumming <murrayc@murrayc.com>
896 * src/modest-account-mgr-helpers.h:
897 * src/modest-account-mgr-helpers.c:
898 Added modest_server_account_get_username_has_succeeded(),
899 modest_server_account_set_username_has_succeeded().
900 (modest_server_account_set_username),
901 Reset the has-succeeded flag if the username changes.
903 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
904 * src/maemo/modest-connection-specific-smtp-window.c:
905 (modest_connection_specific_smtp_window_save_server_accounts):
906 Use modest_server_account_set_username() instead of using
907 modest_conf_set_string() directly, so that the has-succeeded flag is always
910 * src/modest-ui-actions.c:
911 (modest_ui_actions_on_password_requested): Dim the username entry if
912 the username has ever worked, as per the UI spec.
914 2007-05-08 Murray Cumming <murrayc@murrayc.com>
916 * src/modest-tny-account-store.c: (get_password):
917 * src/modest-ui-actions.c:
918 (modest_ui_actions_on_password_requested):
919 Allow the username to be changed too, though there is more work to
920 be done on exactly how this behaves.
922 2007-05-08 Murray Cumming <murrayc@murrayc.com>
924 * src/modest-account-mgr-helpers.h:
925 * src/modest-account-mgr-helpers.c:
926 Added modest_account_mgr_get_display_name(),
927 modest_server_account_get_username(),
928 modest_server_account_set_username(),
929 modest_server_account_set_password(),
930 modest_server_account_get_hostname() functions so we do not need to
931 use the conf API directly.
933 * src/maemo/modest-main-window.c: (connect_signals):
934 Actually connect ot the ModestAccountStore::request-password signal,
935 so that we show the dialog when the password is requested by Tinymail,
936 for isntance if it is empty.
938 * src/modest-marshal.list:
939 * src/modest-tny-account-store.c:
940 (modest_tny_account_store_class_init), (get_password),
941 (modest_tny_account_store_alert):
942 * src/modest-tny-account-store.h:
943 * src/modest-ui-actions.h:
944 * src/modest-ui-actions.c:
945 (modest_ui_actions_on_password_requested):
946 Change the signal parameters, so it is obvious that we are providing
947 the non human-readable server name, and receiving both the username
948 and password, though changing of the username is not yet implemented.
949 Change the dialog UI to match the Maemo UI specifications, with #idfefing
950 for the GNOME version.
952 This should fix the projects.maemo.org bug NB#56209, though it does not
953 work on Bora, because the gconf_client_get() for the password fails
954 immediately after we save it with gconf_client_set().
956 2007-05-08 Murray Cumming <murrayc@murrayc.com>
959 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
960 caused an undefined symbol error:
961 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
963 2007-05-08 Murray Cumming <murrayc@murrayc.com>
965 * src/modest-tny-account-store.c:
966 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
967 using a GError instead of a string message, so we can translate it in
970 2007-05-08 Murray Cumming <murrayc@murrayc.com>
972 * src/maemo/modest-address-book.c:
973 (modest_address_book_check_names):
974 * src/maemo/modest-msg-view-window.c:
975 (modest_msg_view_window_clipboard_owner_change):
976 * src/modest-init.c: (modest_init_init_ui):
977 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
978 (update_folders_cb), (modest_mail_operation_update_account):
979 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
980 (modest_ui_actions_on_msg_attachment_clicked),
981 (modest_ui_actions_on_msg_recpt_activated):
982 * src/widgets/modest-header-view.c: (drag_data_get_cb):
983 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
984 (modest_msg_view_search_next):
985 * src/widgets/modest-recpt-editor.c:
986 (modest_recpt_editor_on_button_release_event),
987 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
988 g_message(). At this point we should only be seeing interesting errors on
989 stdout. Debugging messages could be #ifdefed-out if they are still useful.
991 2007-05-07 Murray Cumming <murrayc@murrayc.com>
993 (modest_wizard_dialog_force_title_update):
994 * src/maemo/easysetup/modest-wizard-dialog.h:
995 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
996 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
997 can update the title when appropriate. Otherwise the title is wrong if the
998 pages are added after adding the notebook to the dialog.
999 This must be a problem in HildonWizardDialog too.
1000 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1002 * src/maemo/easysetup/modest-easysetup-wizard.c:
1003 (create_subsequent_customsetup_pages),
1004 (create_subsequent_easysetup_pages):
1005 Call modest_wizard_dialog_force_title_update() so that the title is
1006 correct even with GTK+ < 2.10.
1007 This fixes projects.maemo.org bug NB#56145 .
1009 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1011 * src/maemo/modest-platform.c:
1012 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1013 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1016 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1018 * src/widgets/modest-window.h:
1019 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1020 and modest_window_save_state(), which invokes it.
1022 * src/widgets/modest-window-mgr.h:
1023 * src/widgets/modest-window-mgr.c:
1024 Added modest_window_mgr_save_state_for_all_windows(), which calls
1025 the save_state vfunc on all registered windows, if implemented.
1027 * src/gnome/modest-msg-edit-window.c:
1028 * src/gnome/modest-msg-view-window.c:
1029 * src/maemo/modest-msg-edit-window.c:
1030 * src/maemo/modest-msg-view-window.c:
1031 * src/maemo/modest-main-window.c:
1032 Specify the existing save_settings functions as implementations of
1033 ModestWindow::save_state_func().
1035 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1036 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1037 enabling hibernation, for instance.
1039 We may need to do the same thing for restoring settings.
1042 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1044 * src/widgets/modest-window-mgr.c:
1045 * src/widgets/modest-window-mgr.h:
1046 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1047 modest_window_mgr_get_hibernation_is_prevented().
1049 * src/maemo/modest-main-window.c:
1050 (on_hildon_program_is_topmost_notify): Prevent hibernation
1051 (possible when the application goes to the background in the WM),
1052 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1054 * src/maemo/easysetup/modest-easysetup-wizard.c:
1055 (modest_easysetup_wizard_dialog_init):
1056 * src/maemo/modest-account-settings-dialog.c:
1057 (modest_account_settings_dialog_init):
1058 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1059 (modest_connection_specific_smtp_edit_window_init):
1060 * src/maemo/modest-connection-specific-smtp-window.c:
1061 (modest_connection_specific_smtp_window_init):
1062 * src/maemo/modest-signature-editor-dialog.c:
1063 (modest_signature_editor_dialog_init):
1064 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1065 prevent hibernation while any of these account settings dialogs are open.
1067 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1069 * src/maemo/Makefile.am:
1070 * src/maemo/modest-osso-state-saving.c:
1071 * src/maemo/modest-osso-state-saving.h: Added
1072 modest_osso_load_state() and modest_osso_save_state() though they do
1073 nothing now. They should iterate through all the open windows and load/save
1075 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1076 save state when closing.
1078 * src/maemo/modest-main-window.c:
1079 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1080 Add a notification handler for the HildonProgram::is-topmost property,
1081 so we can allow hibernation when the application goes into the background.
1082 But we still need to detect when the accounts setup windows are open so
1083 we can stop hibernation when they are open.
1084 To do this, I also added the main window the HildonProgram. This might have
1085 other side-effects/benefits, and should maybe be done for other windows.
1087 * src/maemo/modest-osso-autosave-callbacks.h:
1088 * src/maemo/modest-osso-autosave-callbacks.c:
1089 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1090 though it does not do anything yet, and we might never need this to do
1091 anything. For instance, we already save drafts.
1093 * src/maemo/modest-platform.c: (modest_platform_init):
1094 Specify the libosso auto-save callback.
1096 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1098 * src/maemo/modest-platform.c:
1099 (modest_platform_set_update_interval):
1100 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1101 aparently stays valid between application instances, so we can use this
1102 to remove and reset it later. According to a maemo-developers email from
1105 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1107 * configure.ac: Depend on libalarm for Maemo.
1109 * src/dbus_api/modest-dbus-api.h:
1110 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1111 (on_send_receive), (modest_dbus_req_handler):
1112 Handle a SEND_RECEIVE D-Bus method.
1114 * libmodest-dbus-client/libmodest-dbus-client.c:
1115 (libmodest_dbus_client_send_and_receive):
1116 * libmodest-dbus-client/libmodest-dbus-client.h:
1117 Add C convenience functions for calling the new D-Bus method.
1119 * src/modest-platform.h:
1120 * src/gnome/modest-platform.c:
1121 * src/maemo/modest-platform.c:
1122 Added modest_platform_set_update_interval(), which uses the
1123 alarmd API on Maemo.
1124 (modest_platform_init),
1125 Call modest_platform_set_update_interval(), using a hard-coded
1126 interval for now (until the global settings dialog is implemented),
1127 though I am not sure that this makes sense yet.
1129 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1131 * src/dbus_api/modest-dbus-callbacks.c:
1132 (modest_osso_cb_hw_state_handler):
1133 * src/dbus_api/modest-dbus-callbacks.h:
1134 * src/maemo/modest-platform.c: (modest_platform_init):
1135 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1136 in case this has some effect on the ability for Maemo to ping the
1139 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1141 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1142 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1143 warning. It is probably a logic error, but I need to fix the build.
1145 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1147 * src/modest-account-mgr.h:
1148 * src/modest-account-mgr.c:
1149 (modest_account_mgr_account_names): Add a gboolean enabled_only
1150 parameter, so we can get lists of onlt the enabled accounts.
1152 (modest_account_mgr_add_account),,
1153 (modest_account_mgr_account_with_display_name_exists):
1154 * src/maemo/modest-msg-edit-window.c: (get_transports):
1155 * src/modest-account-mgr-helpers.c:
1156 (modest_account_mgr_set_first_account_as_default):
1157 * src/modest-init.c: (init_default_account_maybe):
1158 * src/modest-tny-account-store.c: (get_accounts):
1159 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1160 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1161 * tests/check_account-mgr.c: (START_TEST):
1162 Provide the extra parameter, as appropriate.
1164 * src/widgets/modest-account-view.c: (update_account_view):
1165 Do not show disabled accounts (meaning that there is no way to
1166 enable/disable accounts in the UI (the feature is not in our UI
1167 specification), so we can use this internally only to mark unfinished
1168 or temporary account data.
1170 * src/maemo/easysetup/modest-easysetup-wizard.c:
1171 (create_account): Add boolean enable parameter, so we can specify FALSE
1172 to create the temporary account.
1173 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1174 (on_before_next): When finishing, when there is a temporary account, just
1176 Also, use a timeout to delay the showing of the dialog until gconf is likely
1177 to return correct information, due to a maemo gconf bug that is fixed in
1178 osso 1.1, but not yet in Bora.
1179 However, the dialog stays on screen after it is destroyed.
1181 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1182 for invalid data when cancelling. Use a hildon note instead of a dialog
1183 to complain about invalid data. Do not show the account-saved note if the
1184 account is disabled (a temporary account that will not really be saved for use
1187 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1189 * src/modest-account-mgr-helpers.h:
1190 * src/modest-account-mgr-helpers.c:
1191 Added modest_account_mgr_unset_default_account(),
1192 Added modest_account_mgr_set_first_account_as_default().
1194 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1195 If it was the default account, unset the default account name.
1197 * src/maemo/modest-account-view-window.c:
1198 (on_delete_button_clicked): If it was the default account,
1199 set the first remaining account as the default instead.
1201 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1202 a NULL account or a NULL default account, to prevent a crash. This should
1203 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1206 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1208 * src/widgets/modest-recpt-editor.c:
1209 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1210 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1211 TODO comment for this. This fixes the build.
1213 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1214 be the best place for it. This will in future update all auto-update accounts,
1215 rather than just the current/default account, when that gconf key exists.
1216 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1217 if there are no accounts, before calling do_send_receive().
1218 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1220 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1221 * src/maemo/modest-main-window-ui.h:
1222 * src/maemo/modest-main-window.c: (on_connection_changed),
1223 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1224 directly, becaue the signal handler does more.
1226 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1228 * src/modest-account-mgr-helpers.c:
1229 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1230 for the case that the account does not exist.
1232 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1233 (equivalent to the modest account name) rather than the tinymail account name
1234 (equivalent to the modest account title - human readable) to get the account data.
1235 Check for null account data to prevent the crash, and add a TODO comment saying that
1236 this needs fixing because it is using the server account name instead of the account name.
1238 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1240 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1241 * src/maemo/modest-account-settings-dialog.c: (show_error),
1243 Use hildon_note_new_information() for informative and error messages,
1244 which seems to be expected for Maemo applications (no documentation that I know of
1245 says this). I am surprised that there is no distinction between info and error
1248 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1250 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1251 it is easy to find where this is used.
1253 * src/maemo/easysetup/modest-easysetup-wizard.c:
1254 (create_page_welcome), (create_page_account_details),
1255 (create_page_user_details), (create_page_complete_easysetup),
1256 (create_page_custom_incoming), (create_page_custom_outgoing),
1257 (create_page_complete_custom):
1258 * src/maemo/modest-account-settings-dialog.c:
1259 (create_page_account_details), (create_page_user_details),
1260 (create_page_incoming), (create_page_outgoing):
1261 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1262 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1263 (modest_connection_specific_smtp_edit_window_init):
1264 * src/maemo/modest-connection-specific-smtp-window.c:
1265 (modest_connection_specific_smtp_window_init):
1266 * src/maemo/modest-signature-editor-dialog.c:
1267 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1268 and scrolling policy as per the Email Application Layout Guide, if I have
1271 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1273 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1274 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1275 which were empty, because these vfuncs have been removed from TnyAccountStore.
1276 This fixes the build.
1278 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1280 * src/maemo/modest-main-window.c:
1281 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1282 showing/hiding it. Added TODO because it probably should not be NULL.
1283 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1284 because unnecessary g_warnings() make degugging difficult.
1286 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1288 * src/maemo/modest-msg-edit-window.c:
1289 (modest_msg_edit_window_select_color),
1290 (modest_msg_edit_window_select_background_color): 2 const corrections and
1291 moving 2 #endifs before closing brackets, to fix the build.
1293 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1295 * src/maemo/easysetup/modest-easysetup-wizard.h:
1296 * src/maemo/easysetup/modest-easysetup-wizard.c:
1297 (modest_easysetup_wizard_dialog_finalize),
1298 (on_button_edit_advanced_settings), (create_page_complete_custom),
1299 (on_response), (create_account):
1300 Implement the Advanced Settings edit button, by saving the account information,
1301 for the Advanded Settings dialog to use directly from gconf, and removing it
1302 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1303 Bug #5533 in the projects.maemo.org bugzilla.
1305 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1307 * src/maemo/modest-msg-view-window.c:
1308 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1309 when opening a message window.
1311 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1313 * src/maemo/easysetup/modest-easysetup-wizard.c:
1314 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1317 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1318 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1319 gconf settings. I probably added more checks than necessary, but that is safer.
1321 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1322 variable to fix the build, but this seems to be used when it is still NULL.
1324 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1326 * src/modest-platform.h:
1327 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1328 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1329 * src/modest-main.c: Implement this function so we can avoid using
1330 maemo-specific API from cross-platform code.
1332 * src/modest-tny-account-store.c:
1333 (get_smtp_specific_transport_account_for_open_connection):
1334 * src/modest-ui-actions.c: (check_for_connection),
1335 (modest_ui_actions_on_item_not_found):
1336 Use modest_platform_connect_and_wait() and put #idefs around other
1337 maemo-specific code, because only maemo currently has a way to
1338 identify connection names.
1340 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1342 * src/modest-tny-account-store.h:
1343 * src/modest-tny-account-store.c:
1344 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1345 the connection-specific SMTP server settings in the configuration.
1347 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1349 * src/maemo/modest-main-window.c: (on_connection_changed),
1351 * src/modest-main.c: (main), (start_ui), (send_mail):
1352 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1353 that is what is intended.
1355 * src/modest-ui-actions.c: (action_send), (action_receive),
1356 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1357 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1358 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1359 SMTP server is used when it is specified.
1361 (modest_ui_actions_on_send_receive):
1362 Check that a connection is open before proceeding.
1363 Receive and then send, instead of vice-versa, as per the specification.
1365 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1367 * src/modest-mail-operation.c:
1368 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1369 though I guess it should be something other than NULL.
1371 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1373 * src/maemo/easysetup/modest-easysetup-wizard.c:
1374 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1375 combo twice, to avoid an g_warning and to make it visible again.
1376 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1377 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1378 (already intended) dereference when detaching, because we then recreate the menu.
1379 But I am not sure why the warning was happening, and it is possible that this is a memory
1382 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1384 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1385 and uri_parse_mailto() utility functions.
1386 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1388 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1390 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1392 * src/dbus_api/modest-dbus-api.h:
1393 * src/dbus_api/modest-dbus-callbacks.c:
1394 Use an idle callback to execute the modest code in the application's own thread.
1395 Remove the helloworld example method.
1396 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1397 parsed, and the open-message method is not implemented because this is not yet implemented in
1399 * libmodest-dbus-client/libmodest-dbus-client.c:
1400 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1401 (libmodest_dbus_client_open_message):
1402 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1404 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1405 body without crashing.
1407 * tests/dbus_api/Makefile.am:
1408 * tests/dbus_api/test_mail_to.c:
1409 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1411 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1413 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1414 Added file to fix the build. Sorry.
1416 * src/dbus_api/Makefile.am:
1417 * src/dbus_api/modest-dbus-api.h:
1418 * src/dbus_api/modest-dbus-callbacks.h:
1419 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1420 (modest_dbus_req_handler):
1421 Put constants in a separate header so it can be reused by the
1422 client library, without duplication
1424 * libmodest-dbus-client/Makefile.am:
1425 * libmodest-dbus-client/libmodest-dbus-client.c:
1426 (libmodest_dbus_client_call_helloworld),
1427 (libmodfest_dbus_client_send_mail),
1428 (libmodfest_dbus_client_mailto),
1429 (libmodfest_dbus_client_open_message):
1430 * libmodest-dbus-client/libmodest-dbus-client.h:
1431 (Partly) Implement a send_mail D-Bus method.
1433 * tests/dbus_api/Makefile.am:
1434 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1435 the send_email D-Bus method.
1437 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1441 * libmodest-dbus-client/Makefile.am:
1442 * libmodest-dbus-client/libmodest-dbus-client.c:
1443 * libmodest-dbus-client/libmodest-dbus-client.h:
1444 * tests/dbus_api/Makefile.am:
1445 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1446 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1448 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1450 * src/maemo/easysetup/modest-easysetup-wizard.c:
1451 (create_page_account_details):
1452 * src/maemo/modest-account-settings-dialog.c:
1453 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1454 widgets, because this might not be the default in future versions of the Maemo GTK+.
1455 However, I can not not get capitalization to work even in a simple test case.
1457 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1459 * src/maemo/easysetup/modest-easysetup-wizard.c:
1460 (create_page_custom_incoming), (create_page_custom_outgoing):
1461 * src/maemo/modest-account-settings-dialog.c:
1462 (create_page_account_details), (create_page_incoming),
1463 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1464 instead of using gtk_check_button_with_label(), so they are aligned like the other
1465 widgets, as per the UI spec.
1467 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1469 * src/maemo/easysetup/modest-easysetup-wizard.c:
1470 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1471 * src/widgets/modest-validating-entry.c:
1472 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1473 Modest prefix instead of an EasySetup prefix.
1475 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1477 * src/widgets/modest-validating-entry.h:
1478 * src/widgets/modest-validating-entry.c: (on_insert_text),
1479 Added easysetup_validating_entry_set_max_func(), used to set a callback
1480 to call when the max number of characters is reached. GtkEntry has a max-length
1481 already but is silent about it.
1483 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1484 (create_page_account_details), (create_page_user_details),
1486 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1487 (create_page_account_details), (create_page_user_details),
1488 (create_page_outgoing):
1489 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1490 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1491 the UI spec, when the user tries to enter more than the max number of characters.
1493 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1495 * src/maemo/easysetup/modest-easysetup-wizard.c:
1496 (create_page_user_details), (create_page_custom_incoming),
1497 (create_page_custom_outgoing):
1498 * src/maemo/modest-account-settings-dialog.c:
1499 (create_page_user_details), (create_page_incoming),
1500 (create_page_outgoing):
1501 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1502 (modest_connection_specific_smtp_edit_window_init):
1503 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1504 not appropriate. Bad Maemo-specific defaults!.
1506 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1508 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1509 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1510 (modest_signature_editor_dialog_set_settings):
1511 Disable the label and textview when the checkbox is disabled, and use the
1512 specified (UI spec) default signature text.
1514 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1516 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1517 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1519 * src/modest-defs.h:
1520 * src/modest-account-mgr-helpers.h:
1521 * src/modest-account-mgr-helpers.c:
1522 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1524 * src/maemo/Makefile.am:
1525 * src/maemo/modest-signature-editor-dialog.c:
1526 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1529 * src/maemo/modest-account-settings-dialog.h:
1530 * src/maemo/modest-account-settings-dialog.c:
1531 (modest_account_settings_dialog_finalize), (on_button_signature),
1532 (save_configuration): Use the new dialog when the Edit button is pressed, and
1533 save the changes if necessary, as per the UI spec.
1535 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1537 * src/maemo/Makefile.am:
1538 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1539 based on maemo-develoers email from Dirk.
1541 * src/maemo/easysetup/modest-easysetup-wizard.c:
1542 (create_page_welcome), (create_page_account_details),
1543 (create_page_user_details), (create_page_complete_easysetup),
1544 (create_page_custom_incoming), (create_page_custom_outgoing),
1545 (create_page_complete_custom),
1546 (modest_easysetup_wizard_dialog_init):
1547 * src/maemo/modest-account-settings-dialog.c:
1548 (create_page_account_details), (create_page_user_details),
1549 (create_page_incoming), (create_page_outgoing),
1550 (modest_account_settings_dialog_init):
1551 * src/maemo/modest-connection-specific-smtp-window.c:
1552 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1554 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1556 * src/maemo/easysetup/modest-easysetup-wizard.c:
1557 (create_page_account_details), (create_page_custom_outgoing),
1558 (create_page_complete_custom):
1559 * src/maemo/modest-account-settings-dialog.c:
1560 (create_page_user_details), (create_page_incoming),
1561 (create_page_outgoing):
1562 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1563 (modest_connection_specific_smtp_edit_window_init):
1564 Use the correct (UI spec) port min/max, and use horizontal separators,
1567 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1569 * src/maemo/easysetup/modest-easysetup-wizard.c:
1570 (set_default_custom_servernames):
1571 * src/maemo/modest-account-settings-dialog.c:
1572 (create_page_incoming), (on_combo_outgoing_security_changed),
1573 (on_combo_incoming_security_changed), (create_page_outgoing),
1574 (modest_account_settings_dialog_set_account_name),
1575 (save_configuration):
1576 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1577 (on_combo_security_changed),
1578 (modest_connection_specific_smtp_edit_window_init),
1579 (modest_connection_specific_smtp_edit_window_set_connection),
1580 (modest_connection_specific_smtp_edit_window_get_settings):
1581 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1584 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1587 * src/maemo/easysetup/modest-easysetup-wizard.c:
1588 (create_page_custom_outgoing), (create_page_complete_custom):
1589 * src/maemo/modest-account-settings-dialog.c:
1590 (create_page_user_details), (create_page_outgoing):
1591 * src/maemo/modest-account-view-window.c: (button_box_new):
1592 Use changed logical IDs as per the most recent UI spec:
1593 mcen_bd_emailsetup_edit -> mcen_bd_edit
1594 mcen_bd_emailsetup_delete -> mcen_bd_delete
1595 mcen_bd_emailsetup_close -> mcen_bd_close
1597 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1601 * src/dbus_api/Makefile.am:
1602 * src/dbus_api/modest-dbus-callbacks.c:
1603 * src/dbus_api/modest-dbus-callbacks.h:
1604 * src/maemo/modest-platform.c: (modest_platform_init):
1605 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1607 * tests/Makefile.am:
1608 * tests/dbus_api/Makefile.am:
1609 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1611 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1613 * src/maemo/modest-account-settings-dialog.c:
1614 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1615 Removed unnecessary includes.
1617 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1619 * src/maemo/easysetup/modest-easysetup-wizard.c:
1620 * src/maemo/modest-account-settings-dialog.c:
1621 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1622 * src/widgets/Makefile.am:
1623 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1624 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1625 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1626 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1627 * src/widgets/modest-secureauth-combo-box.c:
1628 * src/widgets/modest-secureauth-combo-box.h:
1629 * src/widgets/modest-serversecurity-combo-box.c:
1630 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1631 made the GObject names more consistent with the rest of the Modest code.
1633 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1635 * src/maemo/easysetup/Makefile.am:
1636 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1637 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1638 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1639 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1640 * src/maemo/easysetup/modest-easysetup-wizard.c:
1641 * src/maemo/easysetup/modest-validating-entry.c:
1642 * src/maemo/easysetup/modest-validating-entry.h:
1643 * src/maemo/modest-account-settings-dialog.c:
1644 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1645 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1646 widgets/ because they are used outside of easysetup too. After checking in,
1647 svn will allow me to rename them too.
1649 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1651 * src/gnome/modest-msg-edit-window.c:
1652 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1653 linker error, to fix the build on the GNOME platform.
1654 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1655 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1656 ifdefed out to avoid a warning.
1658 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1660 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1661 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1662 some alternative for GTK+ 2.6.
1664 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1666 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1668 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1669 specified for EmailAccountsDialog in UI spec.
1671 * src/maemo/easysetup/modest-easysetup-wizard.c:
1672 * src/maemo/easysetup/modest-easysetup-wizard.h:
1673 * src/maemo/modest-account-settings-dialog.c:
1674 * src/maemo/modest-account-settings-dialog.h:
1675 Reuse a member window widget for the connection-specific SMTP server accounts,
1676 so we can tell it to create/save the accounts only if we actually save changes.
1678 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1679 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1680 (modest_connection_specific_smtp_edit_window_get_settings):
1681 Return a struct instance for temporarily remembering the entered data.
1683 * src/maemo/modest-connection-specific-smtp-window.h:
1684 * src/maemo/modest-connection-specific-smtp-window.c:
1685 (modest_connection_specific_smtp_window_finalize),
1686 (modest_connection_specific_smtp_window_fill_with_connections),
1688 (modest_connection_specific_smtp_window_save_server_accounts),
1689 (update_model_server_names): Do not actually save data until asked,
1690 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1692 (on_selection_changed),
1693 (modest_connection_specific_smtp_window_init): Disable the edit
1694 button when nothing is selected.
1696 * src/modest-account-mgr-helpers.c:
1697 * src/modest-account-mgr-helpers.h:
1698 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1701 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1703 * src/modest-account-mgr-helpers.h:
1704 * src/modest-account-mgr-helpers.c:
1705 (modest_account_mgr_get_unused_account_name),
1706 (modest_account_mgr_get_unused_account_display_name): Added these
1707 utility functions, to avoid code duplication.
1709 * src/maemo/easysetup/modest-easysetup-wizard.c:
1710 (create_page_account_details), (create_account):
1711 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1712 (on_combo_security_changed),
1713 (modest_connection_specific_smtp_edit_window_init),
1714 (modest_connection_specific_smtp_edit_window_save_settings):
1715 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1716 * src/maemo/modest-connection-specific-smtp-window.c:
1717 (modest_connection_specific_smtp_window_finalize),
1718 (modest_connection_specific_smtp_window_fill_with_connections),
1719 (on_button_edit), (modest_connection_specific_smtp_window_init):
1720 * src/maemo/modest-connection-specific-smtp-window.h:
1721 Implementing saving of connection-specific server accounts.
1723 But I need to refactor this so we can save the data for each
1724 possible connection-specific account and only actually create the server accounts
1725 when the easysetup finished, or the OK button is pressed on the account settings
1728 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1730 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1731 (on_combo_security_changed):
1732 (modest_connection_specific_smtp_edit_window_init):
1733 Auto-fill the port number as in the account settings.
1735 (modest_connection_specific_smtp_edit_window_set_connection):
1736 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1737 * src/maemo/modest-connection-specific-smtp-window.c:
1738 (fill_with_connections), (on_button_edit),
1739 (modest_connection_specific_smtp_window_init):
1740 Turn the edit window into a dialog to simplify the code, and
1741 set a WM hint as in a GtkDialog, because only a popup can be on top of
1742 another window in Maemo, and popups usually have no WM decoration.
1744 * src/modest-defs.h:
1745 * src/modest-account-mgr-helpers.c:
1746 (modest_account_mgr_set_connection_specific_smtp),
1747 (modest_account_mgr_remove_connection_specific_smtp),
1748 (modest_account_mgr_get_connection_specific_smtp):
1749 * src/modest-account-mgr-helpers.h: Some functions to write the
1750 connection-specific SMTP server information. Not yet used.
1753 * src/widgets/modest-folder-view.c: (text_cell_data):
1754 Fix a warning about an uninitialized variable.
1755 (on_configuration_key_changed): Put an #ifdef around the use
1756 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1758 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1760 * src/maemo/modest-account-settings-dialog.h:
1761 * src/maemo/modest-account-settings-dialog.c:
1762 Added connect_for_modified() utility function to mark the new modified boolean.
1764 (create_page_account_details), (create_page_user_details),
1765 (create_page_incoming), (create_page_outgoing), (on_response),
1766 (modest_account_settings_dialog_init),
1767 (modest_account_settings_dialog_set_account_name):
1768 Only warn about unsaved changes when there are actually unsaved changes.
1770 * src/modest-account-mgr-helpers.c:
1771 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1772 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1773 to get the data from there in future.
1775 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1777 * src/modest-defs.h:
1779 * src/modest-account-mgr-helpers.h:
1780 * src/modest-account-mgr-helpers.c:
1781 Store the security account setting in a single conf key instead of using
1782 the options list, so that the list is left for just the to-be-removed camel hack,
1783 and because gconf_client_set_list() is failing for some reason.
1785 * src/modest-account-mgr.c:
1786 (modest_account_mgr_add_server_account):
1787 * src/maemo/modest-account-settings-dialog.c:
1788 (modest_account_settings_dialog_set_account_name),
1789 (save_configuration): Use the renamed functions.
1792 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1794 * src/widgets/Makefile.am:
1795 * src/widgets/modest-limit-retrieve-combo-box.c:
1796 * src/widgets/modest-limit-retrieve-combo-box.h:
1797 * src/widgets/modest-retrieve-combo-box.c:
1798 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1799 the account settings dialog.
1801 * src/modest-defs.h:
1802 * src/modest-account-mgr-helpers.h:
1803 * src/modest-account-mgr-helpers.c:
1804 (modest_server_account_get_option_secure_auth),
1805 (modest_server_account_set_option_secure_auth):
1806 * src/modest-account-mgr.c:
1807 (modest_account_mgr_add_server_account):
1808 Use the existing AUTH_MECH conf key for the secure-auth setting,
1809 instead of putting it in the list options, because this was actually used already.
1811 * src/maemo/modest-account-settings-dialog.c:
1812 (create_page_account_details),
1813 (modest_account_settings_dialog_set_account_name),
1814 (save_configuration):
1815 * src/maemo/modest-account-settings-dialog.h:
1816 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1817 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1819 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1821 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1822 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1823 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1825 * src/modest-defs.h:
1826 * src/maemo/modest-account-settings-dialog.c:
1827 (create_page_incoming), (on_combo_outgoing_security_changed),
1828 (on_combo_incoming_security_changed), (create_page_outgoing),
1829 (modest_account_settings_dialog_set_account_name),
1830 (save_configuration): Load/Save the port number, and change it when the
1831 security combo changes, to suitable defaults.
1833 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1835 * src/modest-account-mgr.c:
1836 (modest_account_mgr_add_server_account): Set the security and secure-auth
1837 options, and add a comment saying that the other camel-specific options should be
1840 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1842 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1844 * src/modest-tny-account-store.c: (account_list_free),
1845 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1846 cursor->data after unreffing it. But there is some strange stuff there so it might not be
1849 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1851 * src/modest-protocol-info.c:
1852 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1853 is required by our UI spec. Maybe something in our implementation will use this eventually.
1854 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1855 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1856 instead of the previous 0 placeholder.
1858 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1859 secure-auth settings.
1860 * src/modest-account-mgr-helpers.h:
1861 * src/modest-account-mgr-helpers.c:
1862 (modest_server_account_data_get_option_secure_auth),
1863 (modest_server_account_set_option_secure_auth),
1864 (modest_server_account_data_get_option_security),
1865 (modest_server_account_set_option_security): Added this API for getting and setting the security
1866 and secure-auth settings.
1868 * src/maemo/modest-account-settings-dialog.h:
1869 * src/maemo/modest-account-settings-dialog.c:
1870 (modest_account_settings_dialog_finalize), (check_data),
1871 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1872 about changing titles.
1873 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1874 (save_configuration): Save the security and secure-auth settings.
1876 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1877 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1879 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1881 * src/modest-defs.h:
1882 * src/modest-account-mgr.c:
1883 (modest_account_mgr_add_server_account):
1884 Added and used defines for the options key and value pair strings,
1885 that are used so far, though they do not seem to correspond to anything in our
1886 UI specs or ModestProtocol enum.
1888 * src/modest-account-mgr-helpers.h:
1889 * src/modest-account-mgr-helpers.c:
1890 (compare_option_strings_for_name),
1891 (modest_server_account_data_get_option_value),
1892 (modest_server_account_data_get_option_bool),
1893 (modest_account_mgr_get_server_account_option):
1894 Added helper functions for parsing the options GSList.
1896 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1898 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1899 display name is based on the supplied account name.
1900 * src/modest-account-mgr.c:
1901 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1902 with an inefficient, but good-enough, implementation.
1904 * src/maemo/easysetup/modest-easysetup-wizard.c:
1905 (create_page_account_details), (on_before_next), (create_account):
1906 Check for existing display names rather than (non-user-visible) account names, and just
1907 create and set a unique account name at the end.
1909 * src/maemo/modest-account-settings-dialog.c:
1910 (modest_account_settings_dialog_init),
1911 (modest_account_settings_dialog_set_account_name),
1912 (create_page_incoming): Show the display name, instead of the account name.
1913 (on_response): Do some (not all) extra checks, as in the UI spec.
1914 (save_configuration): Save the display name if it was changed.
1916 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1918 * po/en_GB.po: Added needed logical ID and translation.
1919 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1920 (init_view): Made the is-default column clicking work.
1922 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1925 * src/maemo/easysetup/Makefile.am:
1926 * src/maemo/easysetup/modest-easysetup-wizard.c:
1927 (modest_easysetup_wizard_dialog_init):
1928 * src/maemo/easysetup/provider-data-test.keyfile:
1929 * src/maemo/easysetup/provider-data.keyfile:
1930 Moved the provider data file to the new modest-providers-data package and used it from there.
1932 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1934 * src/modest-local-folder-info.c:
1935 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1936 N_() was already used on the static strings, but this just marks it for translation without
1937 using the translation.
1939 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1941 * src/maemo/modest-account-settings-dialog.c:
1942 (create_page_incoming),
1943 (modest_account_settings_dialog_set_account_name):
1944 Added comments about the need for new API in ModestAccountMgr to handle the authentication
1945 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1946 I will do this if nobody else gets there first.
1948 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1950 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1951 Saved much of the incoming and outgoing data too, though I cannot yet see how to
1952 save the security stuff.
1954 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1956 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1957 Set the email address and user fullname, which I now see must be
1960 * src/maemo/modest-account-settings-dialog.h:
1961 * src/maemo/modest-account-settings-dialog.c:
1963 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1964 leave-on-server and authentication.
1965 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1968 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1971 * src/maemo/modest-account-settings-dialog.c:
1972 * src/maemo/modest-account-settings-dialog.h:
1973 Most (but not all) of the widgets are now present as specified by the UI spec.
1974 No changes are yet saved, and some details are not properly shown yet.
1976 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1978 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1980 * src/maemo/Makefile.am:
1981 * src/maemo/modest-account-settings-dialog.c:
1982 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1983 an existing account. Doesn't do much yet.
1985 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1986 Open the accounts settings dialog when Edit is clicked.
1988 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1990 * src/maemo/easysetup/Makefile.am:
1991 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1993 * src/maemo/easysetup/modest-easysetup-wizard.c:
1994 (modest_easysetup_wizard_dialog_init):
1995 Try to get the source directory from the build system,
1996 instead of hard-coding "./" into the source code, when opening our local
1997 copies of the configuration files.
1998 But this still fails when opening the wizard from the Accounts window,
1999 maybe because the working directory seems to change at runtime.
2000 So the wizard will fail the second time unless you copy the files into their
2001 proper locations - see the stdout warnings for the paths.
2003 (create_page_account_details),(on_before_next):
2004 Check for existing non-server accounts instead of server accounts,
2005 so the default account name is useful again, and to prevent trying to
2008 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2009 Show the wizard when New is clicked.
2011 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2012 (init_view): Show the column headers, and show the columns that are
2013 specified in the UI specs. However, something in Maemo's GTK+ prevents
2014 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2015 change the default account. This is despite unsetting the special properties.
2017 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2019 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2020 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2021 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2022 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2023 to make that clearer.
2024 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2026 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2028 * src/maemo/modest-account-view-window.c:
2029 (modest_account_view_window_init),
2030 (modest_account_view_window_new):
2031 Use the same buttons as specified in the
2032 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2033 the existing widgets, which never had a chance of working.
2034 Put the ModestAccountView treeview in a scrolled window.
2035 Do not repeat the initialization in both _init() and _new().
2037 * src/widgets/modest-account-view.c: (update_account_view):
2038 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2039 this widget and window shows no accounts.
2041 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2043 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2045 * src/maemo/easysetup/modest-easysetup-wizard.c:
2046 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2047 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2048 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2051 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2052 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2053 accounts exist yet, as in the UI spec.
2055 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2057 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2059 * src/maemo/Makefile.am:
2060 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2061 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2062 New window for editing connection-specific smtp details.
2063 Not fully implemented.
2065 * src/maemo/modest-connection-specific-smtp-window.c:
2066 (modest_connection_specific_smtp_window_finalize) :
2067 unref the tree model.
2068 (on_button_edit): Show the edit window.
2070 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2072 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2075 * src/maemo/Makefile.am:
2076 * src/maemo/modest-connection-specific-smtp-window.c:
2077 * src/maemo/modest-connection-specific-smtp-window.h:
2078 New window for showing the list of connections, for connection-specific
2079 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2080 * src/maemo/easysetup/modest-easysetup-wizard.c:
2081 (create_page_custom_outgoing): Show the new window when the button is clicked.
2083 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2085 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2086 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2087 * src/maemo/modest-msg-edit-window.c:
2088 (modest_msg_edit_window_insert_image):
2089 * src/modest-conf.c: (modest_conf_key_escape):
2090 * src/modest-mail-operation.c:
2091 (modest_mail_operation_send_new_mail):
2092 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2093 (modest_ui_actions_on_new_account):
2094 * src/widgets/modest-attachment-view.c: (update_filename_request):
2095 * src/widgets/modest-mail-header-view.c:
2096 Corrected warnings that were breaking the build, by commenting out unused variables,
2097 and a function, and by including a header.
2099 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2101 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2102 so we can #ifdef around platform-specific code when necessary.
2103 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2104 to allow this to build for the GNOME platform too.
2106 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2108 * src/maemo/easysetup/modest-easysetup-wizard.c:
2109 Added util_increment_name() and used it in create_page_account_details()
2110 to make sure that the default account name is always a new name.
2112 (modest_easysetup_wizard_dialog_init),
2113 (set_default_custom_servernames): Some minor memory management fixes.
2115 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2119 * src/modest-runtime.c: (init_i18n): Restored the translation
2120 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2121 are defined in config.h, and the translations are installed.
2123 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2124 is defined for translation.
2126 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2128 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2130 * src/maemo/easysetup/modest-easysetup-wizard.c:
2131 (modest_easysetup_wizard_dialog_init):
2132 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2133 Use realistic paths (though they should use $prefix generically) to the
2134 mcc_mapping and provider-data.keyfile files which might work when they
2135 are installed by the future version of the operator-wizard package,
2136 and then fallback to paths in our source code, with an explanatory
2139 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2143 * src/maemo/Makefile.am:
2144 * src/maemo/easysetup/: Added files from the previously-exernal
2145 osso-modest-easysetup.
2146 * src/maemo/modest-main-window-ui.h:
2147 * src/modest-ui-actions.c:
2148 * src/modest-ui-actions.h:
2149 Added modest_ui_actions_on_new_account() as a signal handler for the
2150 New Account menu item. It shows the easysetup wizard.
2151 * po/en_GB.po: Added additional needed logical IDs and translations.
2153 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2154 Apparently ChangeLog is not used for some vague Nokia legal reasons.