1 2007-06-01 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/easysetup/modest-easysetup-wizard.c:
4 (create_page_complete_custom): Show the second sentence of text
5 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
8 2007-06-01 Murray Cumming <murrayc@murrayc.com>
10 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
11 Set the leave-on-server conf key by default. This fixes
12 projects.maemo.org bug NB#59258 .
14 2007-06-01 Murray Cumming <murrayc@murrayc.com>
16 * src/maemo/modest-account-view-window.c:
17 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
18 logical ID for the confirmation messages. Fixed projects.maemo.org bug
21 2007-06-01 Murray Cumming <murrayc@murrayc.com>
23 * src/maemo/easysetup/modest-easysetup-wizard.c:
24 (create_caption_new_with_asterisk):
25 * src/maemo/modest-account-settings-dialog.c:
26 (create_caption_new_with_asterisk):
27 Uncomment the code to add the asterisk, because they are no longer in the
28 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
29 (update_incoming_server_title): Add an asterisk here too.
31 2007-06-01 Murray Cumming <murrayc@murrayc.com>
33 * src/maemo/modest-maemo-global-settings-dialog.c:
34 (current_connection): Check that we are even connected before trying to
35 get the current connection name, to prevent a warning.
37 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
38 Change the comments because tny_maemo_conic_device_connect() is now meant to
40 * src/modest-mail-operation.c:
41 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
42 make sure we have a connection and fail if we can't connect.
44 2007-05-31 Murray Cumming <murrayc@murrayc.com>
46 * src/maemo/modest-main-window.c:
47 (on_account_store_connecting_finished): Do not try to get the
48 connection ID if we are not really connected. I am surprised that
49 this signal handler is called when we are not connected.
51 2007-05-31 Murray Cumming <murrayc@murrayc.com>
54 * src/modest-ui-actions.c:
55 (modest_ui_actions_get_msgs_full_error_handler):
56 Renamed an enum, added comments, added an enum
57 for retrieve-limit errors.
59 * src/modest-mail-operation.c: (foreach_add_item),
60 (internal_folder_observer_update), (update_account_thread),
61 (modest_mail_operation_get_msgs_full):
62 (modest_mail_operation_update_account),
63 Added comments about how this works, and some code that should
64 (but does not) check the retrieve-limit. See the TODO comment.
66 2007-05-31 Murray Cumming <murrayc@murrayc.com>
68 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
69 Initialize help_id to fix the build. Warnings are good.
71 2007-05-31 Murray Cumming <murrayc@murrayc.com>
73 * src/widgets/modest-hbox-cell-renderer.c:
74 (modest_hbox_cell_renderer_append):
75 * src/widgets/modest-vbox-cell-renderer.c:
76 (modest_vbox_cell_renderer_append):
77 Fix the last commit by doing an extra ref.
79 2007-05-31 Murray Cumming <murrayc@murrayc.com>
81 * src/widgets/modest-hbox-cell-renderer.c:
82 (modest_hbox_cell_renderer_append):
83 * src/widgets/modest-vbox-cell-renderer.c:
84 (modest_vbox_cell_renderer_append):
85 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
86 to fix the build with Maemo Bora.
87 However, there seems to be a remaining crash, probably due to reference
90 2007-05-30 Murray Cumming <murrayc@murrayc.com>
92 * src/modest-tny-account.c:
93 (modest_tny_account_new_for_local_folders):
94 Use hildon_file_system_info_async_new() to get a better name for
95 the memory card account, setting it as the account name.
96 The timing seems to work, but this is probably
97 not the best place to do this. See the TODO comment.
98 * src/maemo/modest-main-window.c: (create_details_widget):
99 * src/widgets/modest-folder-view.c: (text_cell_data):
100 Use the tny account name instead of hardcoding a name.
102 2007-05-30 Christian Kellner <ckellner@openismus.com>
104 * src/modest-search.c: (modest_search):
105 Correctly set part_search_func even if we have already parsed
106 the query and thus a valid OgsTextSearcher object.
108 2007-05-30 Christian Kellner <ckellner@openismus.com>
111 Search and check for libogs.
114 Incooparte the ogs build env.
116 * src/modest-mime-part-search-stream.c:
117 * src/modest-mime-part-search-stream.h:
118 Removed since we do the real searching now in modest-search.c.
120 * src/modest-search.c:
121 * src/modest-search.h:
122 Implement support for ogs. We use that if available and requested
123 and fall back to modest_text_utils_utf8_strcmp (). The search logic
124 should now handle the corner case when the search term is spread
125 across multiple reads.
126 Also the logic in modest_search () was corrected to search all
127 requested fields until one is found.
129 2007-05-30 Murray Cumming <murrayc@murrayc.com>
131 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
134 * src/modest-init.c: Made modest_init_local_folders() take a
135 path and be public so we can iniitialize maildir folders on
138 * src/modest-local-folder-info.h:
139 * src/modest-local-folder-info.c:
140 (modest_local_folder_info_get_maildir_path): Add a path parameter.
142 * src/modest-tny-account.c:
143 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
144 still means the standard local-folders path on the local volume.
146 * src/modest-tny-account-store.c:
147 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
148 signal so we can detect mount/unmount of the MMC1 card, and do an update of
149 all accounts when that happens.
150 (get_server_accounts): If the MMC1 card is mounted, create a store account for
151 this too, so it shows up in the treeview.
153 2007-05-28 Murray Cumming <murrayc@murrayc.com>
155 * src/maemo/modest-maemo-global-settings-dialog.c:
156 (current_connection):
157 * src/widgets/modest-global-settings-dialog.c:
158 (current_connection_default):
159 Use the enum values instead of 0, 1 and -1,
160 to make the code clearer.
162 * src/modest-account-mgr-helpers.c:
163 (modest_account_mgr_get_connection_specific_smtp): Make this code
166 * src/modest-runtime.h:
167 * src/modest-runtime.c:
168 Added modest_runtime_remove_all_send_queues().
169 * src/maemo/modest-main-window.c:
170 (on_account_store_connecting_finished): Recreate the send queues,
171 using the appropriate transport accounts for this new connection.
172 Some futher adapting might be needed if the old send queues are not
173 automatically stopped at this point.
175 * src/modest-tny-account-store.c: (get_server_accounts):
176 Create the connection-specific transport accounts, so that they can
177 be found later by their ID.
179 * src/modest-tny-account.h:
180 * src/modest-tny-account.c:
181 Added modest_tny_account_new_from_server_account_name().
182 modest_tny_account_new_from_server_account(): Do not create the
183 send queues here, because they will be
184 recreated anyway when the connection changes for the first time.
186 2007-05-28 Murray Cumming <murrayc@murrayc.com>
188 * src/modest-local-folder-info.h:
189 * src/modest-local-folder-info.c:
190 (modest_per_account_local_outbox_folder_info_get_maildir_path),
191 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
192 tbox_folder): Take a modest account name instead of a server TnyAccount,
193 so we can have per-modest-account rather than per-transport-account
195 We must make sure that we change or recreate the exisitng send queues
196 when the connection changes for connection-specific transport accounts.
198 * src/modest-tny-account-store.c:
199 (create_per_account_local_outbox_folders): Create outboxed per modest
200 account, not per transport account.
202 * src/modest-tny-account.h:
203 * src/modest-tny-account.c:
204 (modest_tny_account_get_special_folder): For outboxes, get the
205 parent modest account name. The account is ignored for other folders.
206 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
207 modest account name rather than a server TnyAccount.
209 2007-05-25 Murray Cumming <murrayc@murrayc.com>
211 * src/modest-tny-account.c:
212 (modest_tny_account_new_from_server_account):
213 Call modest_runtime_get_send_queue() immediately after creating transport
214 accounts, so that they start trying to send email from the outbox as soon
215 as possible at startup. This is probably what we want.
217 * src/modest-mail-operation.c: (update_account_thread):
218 * src/modest-runtime.c: (modest_runtime_get_send_queue):
219 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
220 * src/modest-tny-send-queue.h:
221 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
222 (modest_ui_actions_on_send):
223 Added comments about how sending works, though it needs some more work.
225 2007-05-25 Murray Cumming <murrayc@murrayc.com>
227 * src/modest-tny-account.c:
228 (modest_tny_account_get_special_folder): Add TODO because this fails when
230 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
231 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
232 Do not try to show this window when there is no active account. The UI
233 specs does not tell us what to do in this case.
235 2007-05-24 Murray Cumming <murrayc@murrayc.com>
239 * src/maemo/Makefile.am:
240 * src/widgets/Makefile.am: Some dist fixes.
242 2007-05-24 Murray Cumming <murrayc@murrayc.com>
244 * src/maemo/modest-connection-specific-smtp-window.c:
245 (on_button_edit): Make the code clearer, to prevent a double free.
247 2007-05-24 Murray Cumming <murrayc@murrayc.com>
249 * src/maemo/modest-account-settings-dialog.c:
250 (modest_account_settings_dialog_set_account_name),
251 Check the connection-specific smtp servers checkbox if there are any.
253 * src/maemo/modest-connection-specific-smtp-edit-window.c:
254 (modest_connection_specific_smtp_edit_window_init):
255 Start with a suitable port number.
257 * src/modest-account-mgr-helpers.h:
258 * src/modest-account-mgr-helpers.c: Added
259 modest_account_mgr_get_has_connection_specific_smtp().
261 (modest_account_mgr_set_connection_specific_smtp),
262 (modest_account_mgr_remove_connection_specific_smtp),
263 (modest_account_mgr_get_has_connection_specific_smtp),
264 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
265 connection-specific smtp server accounts in the account, rather than
266 the server account conf dir.
268 This fixes bug projects.maemo.org bug NB#58263 .
270 * src/modest-tny-account-store.c:
271 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
272 if there are no server accounts yet, to prevent an infinite loop when there
273 are no accounts. Document that one must be called before the other.
275 2007-05-24 Murray Cumming <murrayc@murrayc.com>
277 * src/modest-account-mgr-helpers.c:
278 (modest_account_mgr_get_default_account): Make sure that at least
279 one account is always the default, if there are any enabled accounts.
280 This is just a sanity check that shouldn't be necessary.
282 * src/modest-account-mgr-priv.c:
283 (_modest_account_mgr_account_from_key): Unescape the conf key to
284 get the real account name. For instance, this is an issue if a space
285 was in the account name, which can happen because the account name
286 is generated from the display name.
287 (_modest_account_mgr_get_account_keyname): Always escape the
289 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
290 Unescape the conf keys to get the real account names.
292 For instance, previously the is-default radio button in the accounts
293 list was not checked for any accounts at first. This fixes that,
294 and might fix several similar bugs.
296 2007-05-23 Murray Cumming <murrayc@murrayc.com>
298 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
299 Removed some debug printfs.
301 2007-05-23 Murray Cumming <murrayc@murrayc.com>
303 Modest on-disk outbox directories are now here, for instance:
304 $HOME/.modest/outboxes/<account-id-1>/outbox
305 $HOME/.modest/outboxes/<account-id-2>/outbox
307 $HOME/.modest/local-folders/outbox
308 so we can have a separate outbox for each account.
309 But they are shown as one outbox in the GtkTreeView, by using a
310 TnyMergeFolder in a ModestTnySimpleFolderStore.
313 * src/modest-tny-simple-folder-store.c:
314 * src/modest-tny-simple-folder-store.h:
315 Added ModestTnySimpleFolderStore, used to contain folders from
316 other folder stores, such as other accounts.
318 * src/modest-tny-outbox-account.h:
319 * src/modest-tny-outbox-account.c:
320 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
321 used for the per-account local outbox folders.
323 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
324 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
325 only use this (internally) now for the non-outbox local folders.
328 * src/modest-init.c: Added modest_init_one_local_folder(), for
329 setting up the directory structure for each local folder.
331 * src/modest-local-folder-info.c:
332 (modest_per_account_local_outbox_folder_info_get_maildir_path),
333 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
335 * src/modest-local-folder-info.h:
336 * src/modest-tny-account-store.c: (on_account_removed),
337 (on_account_changed), (create_per_account_local_outbox_folders),
338 (get_server_accounts), (modest_tny_account_store_get_accounts),
339 (modest_tny_account_store_get_tny_account_by_account),
340 (modest_tny_folder_store_is_virtual_local_folders):
342 * src/modest-tny-account.h:
343 * src/modest-tny-account.c:
344 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
345 to create an on-disk per-account local outbox folder for each
347 (create_per_account_local_outbox_folders): Create a local outbox folder
348 for each transport account.
349 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
350 for all local folders.
352 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
353 instead of using g_object_get/set() directly. It is clearer.
355 (modest_tny_folder_store_get_message_count),
356 (modest_tny_folder_store_get_local_size
357 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
358 because we now use these with non-acount folder stores.
360 (modest_tny_account_get_special_folder),
361 (modest_tny_account_new_from_server_account),
362 (modest_tny_account_new_from_account):
363 (recurse_folders): Adjust to the new outbox system.
365 * src/modest-tny-folder.h:
366 * src/modest-tny-folder.c:
367 (modest_tny_folder_is_local_folder),
368 (modest_tny_folder_get_local_folder_type),
369 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
371 * src/widgets/modest-main-window.h:
372 * src/maemo/modest-main-window.c: (create_details_widget),
373 (modest_main_window_set_contents_style): Show details for any folder store,
376 (modest_tny_folder_get_rules):
377 Remove the const. C does not support constness enough for this.
379 * src/modest-ui-actions.c:
380 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
381 make all outboxes appear as one, in the usual local-folders tree node.
383 (set_active_account_from_tny_account),
384 (modest_ui_actions_on_folder_selection_changed):
385 * src/widgets/modest-folder-view.c: (text_cell_data),
386 (icon_cell_data), (filter_row),
387 (add_account_folders_to_merged_folder),
388 (add_account_folders_to_simple_folder_store), (),
389 (get_cmp_rows_type_pos), (cmp_rows),
390 (modest_folder_view_set_account_id_of_visible_server_account):
391 Adjust to the new outbox system, using generic folder stores and folders
394 2007-05-23 Christian Kellner <ckellner@openismus.com>
396 * src/modest-mail-operation.c:
397 (modest_mail_operation_update_account):
398 Use info->max_size instead of unintialized local var [small
399 build fix]. (Added TODO to review that change since I don't
402 2007-05-23 Marcus Bauer <marcusb@openismus.com>
404 * libmodest-dbus-client/libmodest-dbus-client.c:
405 (libmodest_dbus_client_compose_mail): function added
406 * src/dbus_api/modest-dbus-api.h:
407 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
408 (on_compose_mail): Implementation of the SendAsMail functionality
410 2007-05-22 Murray Cumming <murrayc@murrayc.com>
412 * src/modest-account-mgr.c:
413 (modest_account_mgr_add_server_account): Set the secure-connection
414 conf key for transport accounts as well as store accounts. I don't know
415 why the if was there. For instance, this makes sure that we use SSL
416 for the gmail preset from the easysetup wizard.
418 2007-05-22 Murray Cumming <murrayc@murrayc.com>
420 * src/gnome/modest-main-window.c:
421 (on_account_store_connecting_finished), (connect_signals):
422 * src/maemo/modest-main-window.c:
423 (on_account_store_connecting_finished), (connect_signals),
424 (modest_main_window_new):
425 Handle TnyAccountStore::connecting-finished instead of
426 TnyDevice::connection-changed, because we cannot actually perform
427 operations on accounts until TnyAccountStore has itself responded to
428 the TnyDevice::connection-changed signal. This prevents a GError from
430 Do not try to update at startup, because we (at least on scratchbox)
431 already do an update at startup when the device goes online.
432 This prevents a GError from tinymail.
433 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
434 Added TODO about stopping simultaneous operations.
436 2007-05-21 Murray Cumming <murrayc@murrayc.com>
438 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
439 * src/modest-mail-operation-queue.c:
440 (modest_mail_operation_queue_remove):
441 * src/modest-tny-account-store.c: When GErrors happen, give more clues
442 about where they happened.
444 2007-05-21 Murray Cumming <murrayc@murrayc.com>
446 * src/modest-ui-actions.c:
447 (modest_ui_actions_on_password_requested): Make sure that the remember
448 output parameter is always TRUE.
450 2007-05-21 Murray Cumming <murrayc@murrayc.com>
452 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
453 Show a OK/Cancel dialog if the error is a question, though we still do not
454 know anything more about what we are asking the user.
455 * src/widgets/modest-folder-view.c: (on_drag_data_received):
456 Fix an uninitialized variable (helper). This is a logic error, however.
458 2007-05-21 Christian Kellner <ckellner@openismus.com>
460 * src/modest-search.h:
461 Correct bit shifting in the ModestSearchFlags enum.
463 2007-05-21 Murray Cumming <murrayc@murrayc.com>
465 * src/modest-tny-account.c:
466 (modest_tny_account_new_from_server_account): Do not use the lsub and
467 check-all hard-coded IMAP options when using POP.
469 2007-05-21 Murray Cumming <murrayc@murrayc.com>
471 * src/modest-tny-account.c:
472 (modest_tny_account_new_from_server_account):
473 Use NULL for the secure-auth method for POP when Password auth has been
474 specified by the user, as we already do for IMAP. "auth=Login" causes
475 an error from camel or the server.
477 2007-05-17 Murray Cumming <murrayc@murrayc.com>
479 * src/maemo/modest-account-settings-dialog.c:
480 (create_page_account_details),
481 (modest_account_settings_dialog_set_account_name):
482 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
483 for the leave-on-server checkbox, rathr than just the checkbox, when
484 the protocol is not POP.
486 2007-05-17 Murray Cumming <murrayc@murrayc.com>
488 * src/widgets/modest-account-view.c:
489 * src/widgets/modest-account-view.h:
490 Added modest_account_view_select_account() which will be useful later
491 to asynchronously re-select the edited account.
493 2007-05-17 Murray Cumming <murrayc@murrayc.com>
495 * src/maemo/modest-account-settings-dialog.c:
496 (modest_account_settings_dialog_set_account_name):
497 Automatically choose the port numbers based on the secure authentication
498 methods, if they have not been chosen before.
499 This fixes projects.maemo.org bug NB#56273 .
501 2007-05-17 Murray Cumming <murrayc@murrayc.com>
503 * src/maemo/modest-main-window-ui.h:
504 * src/modest-ui-actions.c:
505 * src/modest-ui-actions.h:
506 Connect the Tools/SMTP Servers menu item to
507 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
508 SMTP servers dialog, as in the UI specification and saves changes when it
509 is closed. This fixed projects.maemo.org bug NB#56305 .
511 2007-05-17 Murray Cumming <murrayc@murrayc.com>
513 * src/maemo/modest-connection-specific-smtp-window.c:
514 (modest_connection_specific_smtp_window_init):
515 Use gtk_window_set_default_size() to make this window big enough, so
516 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
518 2007-05-17 Murray Cumming <murrayc@murrayc.com>
520 * src/maemo/modest-connection-specific-smtp-edit-window.h:
521 * src/maemo/modest-connection-specific-smtp-edit-window.c:
522 (modest_connection_specific_smtp_edit_window_init),
523 Do not try to connect to a combobox signal before the combobox exists.
524 This fixes the cras in projects.maemo.org bug NB#56288 .
525 (modest_connection_specific_smtp_edit_window_get_settings):
526 Remove the server_account_name parameter which was being checked for NULL
527 though it was not used.
529 * src/maemo/modest-connection-specific-smtp-window.c:
530 (modest_connection_specific_smtp_window_fill_with_connections),
531 (on_button_edit), (modest_connection_specific_smtp_window_init):
532 Correct the number of treemodel columns to prevent a warning.
533 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
534 libconic does not work.
536 2007-05-16 Murray Cumming <murrayc@murrayc.com>
538 * src/modest-tny-account.c:
539 (modest_tny_account_new_from_server_account):
540 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
541 SMTP when "None" was chosen by the user. However, with my SMTP server that
542 does not support ANONYMOUS, the emails do not leave the Outbox and I see
545 2007-05-16 Murray Cumming <murrayc@murrayc.com>
547 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
548 to explain the memory management issue with the ID in the ModestPair.
550 * src/gnome/modest-account-assistant.c: (add_receiving_page),
551 (add_sending_page), (modest_account_assistant_finalize):
552 * src/gnome/modest-gnome-global-settings-dialog.c:
553 (create_updating_page), (create_composing_page):
554 * src/gnome/modest-msg-edit-window.c: (get_transports),
555 (init_window), (modest_msg_edit_window_finalize),
556 (modest_msg_edit_window_get_msg_data):
557 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
558 * src/gnome/modest-transport-widget.c:
559 (modest_transport_widget_finalize), (smtp_configuration):
560 * src/maemo/modest-maemo-global-settings-dialog.c:
561 (create_updating_page), (create_composing_page):
562 * src/maemo/modest-msg-edit-window.c: (get_transports),
563 (init_window), (modest_msg_edit_window_finalize),
564 (modest_msg_edit_window_get_msg_data),
565 (modest_msg_edit_window_free_msg_data):
566 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
567 (modest_store_widget_finalize):
568 * src/maemo/modest-transport-widget.c:
569 (modest_transport_widget_finalize), (smtp_configuration):
570 * src/modest-main.c: (send_mail):
571 * src/widgets/modest-combo-box.h:
572 * src/widgets/modest-global-settings-dialog-priv.h:
573 * src/widgets/modest-global-settings-dialog.c:
574 (modest_global_settings_dialog_finalize):
575 * src/widgets/modest-msg-edit-window.h:
576 Whenever using modest_combo_box_new(), keep the ModestPairList alive
577 as long as the combo box, to prevent use of freed memory for the ID.
579 2007-05-15 Murray Cumming <murrayc@murrayc.com>
581 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
582 get_accounts(), to make this clearer. Do not check for the enabled gconf
583 key, because we do not use this for server accounts (at least, not yet).
584 This allows us to send email again.
586 2007-05-15 Murray Cumming <murrayc@murrayc.com>
588 * src/maemo/modest-platform.c:
589 (on_modest_conf_update_interval_changed), (modest_platform_init):
590 Only respond to this particular key change. All these strcmp()s cannot be
593 2007-05-15 Murray Cumming <murrayc@murrayc.com>
595 * src/maemo/modest-maemo-global-settings-dialog.c:
596 (current_connection): Prevent a crash in scratchbox when
597 ny_maemo_conic_device_get_current_iap_id() returns NULL.
598 * src/maemo/modest-platform.c:
599 (on_modest_conf_update_interval_changed), (modest_platform_init):
600 Get the update interval from gconf and reset it when the gconf key changes.
602 2007-05-15 Murray Cumming <murrayc@murrayc.com>
604 * src/modest-protocol-info.c:
605 * src/modest-protocol-info.h: Adde enum-specific get functions,
606 instead of using a ModestProtocolType enum parameter.
608 * src/gnome/modest-account-assistant.c:
609 * src/gnome/modest-store-widget.c:
610 * src/gnome/modest-store-widget.h:
611 * src/gnome/modest-transport-widget.c:
612 * src/gnome/modest-transport-widget.h:
613 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
614 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
615 * src/maemo/easysetup/modest-easysetup-wizard.c:
616 * src/maemo/modest-account-settings-dialog.c:
617 * src/maemo/modest-account-settings-dialog.h:
618 * src/maemo/modest-store-widget.c:
619 * src/maemo/modest-store-widget.h:
620 * src/maemo/modest-transport-widget.c:
621 * src/maemo/modest-transport-widget.h:
622 * src/modest-account-mgr-helpers.c:
623 * src/modest-account-mgr-helpers.h:
624 * src/modest-account-mgr.c:
625 * src/modest-account-mgr.h:
626 * src/modest-tny-account.c:
627 * src/modest-tny-folder.c:
628 * src/widgets/modest-account-view.c:
629 * src/widgets/modest-retrieve-combo-box.c:
630 * src/widgets/modest-retrieve-combo-box.h:
631 * src/widgets/modest-secureauth-combo-box.c:
632 * src/widgets/modest-serversecurity-combo-box.c:
633 * src/widgets/modest-serversecurity-combo-box.h:
634 * tests/check_account-mgr.c:
635 Use the specific functions, and use the re-renamed enum values for GNOME too.
637 2007-05-15 Murray Cumming <murrayc@murrayc.com>
640 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
641 so we can get the second based on the first.
643 * src/maemo/modest-account-settings-dialog.h:
644 * src/maemo/modest-account-settings-dialog.c:
645 Added get_supported_secure_authentication_methods(), though it is mostly
646 commented-out for now until the necessary API is committed to tinymail.
647 (modest_account_settings_dialog_set_account_name),
648 (save_configuration): Request the supported authentication methods from the
649 server, so we can choose a working method.
651 * src/modest-tny-account-store.h:
652 * src/modest-tny-account-store.c:
653 (modest_tny_account_store_get_session): Rename from
654 tny_account_store_get_session().
656 2007-05-14 Murray Cumming <murrayc@murrayc.com>
658 * src/modest-protocol-info.h: Split the ModestProtocol enum
659 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
660 There was no need to have these unrelated values in one enum.
662 * src/: many files: Adapted to changed enum. This makes the code a bit
663 clearer, and the compiler could catch some errors.
665 2007-05-14 Murray Cumming <murrayc@murrayc.com>
667 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
668 Show the detailed internal camel error message when an error happens
669 during the configuration, so that our testers can give us more clues.
670 For instance, in projects.maemo.org bug NB#56910 .
672 2007-05-14 Murray Cumming <murrayc@murrayc.com>
674 * src/modest-tny-account.c:
675 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
676 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
678 2007-05-14 Murray Cumming <murrayc@murrayc.com>
680 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
681 * src/maemo/modest-account-settings-dialog.c:
682 (modest_account_settings_dialog_set_account_name),
683 (save_configuration): For the incoming secure authentication checkbox,
684 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
685 the UI specification. PLAIN does not seem to be supported for most IMAP
686 servers anyway, and I am not sure what it would mean.
687 However, we probably need to discover which of the secure-authentication
688 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
689 * src/modest-account-mgr-helpers.c:
690 (modest_account_mgr_get_server_account_data):
692 * src/modest-tny-account.c:
693 (modest_tny_account_new_from_server_account):
694 Use tny_account_set_mech() to set secure-authentication methods,
695 with some special-casing for IMAP, based on my observations of how
698 * src/modest-account-mgr-helpers.h:
699 * src/modest-account-mgr.c:
700 * src/modest-defs.h: Comment that the URI is only used for local folders.
702 2007-05-11 Murray Cumming <murrayc@murrayc.com>
704 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
705 parameter const, just to be neat.
706 * src/modest-text-utils.c: (modest_text_utils_inline):
707 End g_strconcat() with NULL, as its documentation says. This is almost
708 certainly the cause of my crash at startup on the device. Interestingly,
709 valgrind doesn't tell us about these errors.
711 2007-05-11 Murray Cumming <murrayc@murrayc.com>
713 * scripts/build-packages: Added more precise comments about how to use
714 this script, though I still get this error:
715 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
716 error building tinymail
718 2007-05-11 Murray Cumming <murrayc@murrayc.com>
720 * src/maemo/modest-main-window.c: (on_account_update):
721 Very slight cleanup, hoping to make it simpler to discover what causes
722 a crash here sometimes.
724 * src/modest-tny-account.c:
725 (modest_tny_account_new_from_server_account): Set the port. Added
726 comments about the options and a TODO comment because I need to find out
727 how to specify the secure authentication method.
729 2007-05-11 Marcus Bauer <marcusb@openismus.com>
731 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
732 changed CFlags paths form modest to libmodest
734 2007-05-10 Murray Cumming <murrayc@murrayc.com>
736 * src/modest-account-mgr-helpers.c:
737 (modest_account_mgr_get_server_account_data),
738 (modest_account_mgr_free_server_account_data):
739 * src/modest-account-mgr-helpers.h:
740 * src/modest-account-mgr.c:
741 (modest_account_mgr_add_server_account):
743 * src/modest-tny-account.c:
744 (modest_tny_account_new_from_server_account):
745 Determine the options for tny_camel_account_add_option() here,
746 based on the settings, rather than storing them directly in gconf.
748 2007-05-10 Murray Cumming <murrayc@murrayc.com>
750 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
751 Show a more friendly error dialog now that we expect (from the tinymail
752 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
754 2007-05-10 Murray Cumming <murrayc@murrayc.com>
756 * src/maemo/modest-main-window.c: (on_account_update): Check that
757 account_name is not NULL, to prevent a crash at startup that I am
758 seeing on the N800. I do wonder why it is NULL.
760 * src/maemo/easysetup/modest-easysetup-wizard.c:
761 (create_page_user_details):
762 * src/maemo/modest-account-settings-dialog.c:
763 (create_page_user_details), (create_page_outgoing):
764 * src/maemo/modest-connection-specific-smtp-edit-window.c:
765 (modest_connection_specific_smtp_edit_window_init):
766 * src/modest-ui-actions.c:
767 (modest_ui_actions_on_password_requested):
768 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
769 might do something useful with the on-screen keyboard.
771 2007-05-10 Murray Cumming <murrayc@murrayc.com>
773 * src/maemo/modest-main-window.c: (on_account_update):
774 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
775 NULL, to avoid lots of warnings. However, it probably should not be NULL.
777 2007-05-09 Murray Cumming <murrayc@murrayc.com>
779 * src/modest-tny-account-store.c: (on_account_changed):
780 Correct the signature of this signal handler.
782 2007-05-09 Murray Cumming <murrayc@murrayc.com>
784 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
785 Show a HildonNote instead of a GtkDialog for Maemo.
787 2007-05-09 Murray Cumming <murrayc@murrayc.com>
789 * src/widgets/modest-account-view.h:
790 * src/widgets/modest-account-view.c: (on_account_changed),
791 (on_account_removed). Added a boolean flag, set/unset by
792 modest_account_view_block_conf_updates(),
793 modest_account_view_unblock_conf_updates() to prevent unnecessary
794 updates, but this is not very useful because the gconf notifications are
795 so delays (maybe only on Maemo Bora).
796 So auto-updating is turned off, and these functions do an explicit
797 update when necessary.
798 However, something else is still doing too much work when adding/removing
799 accounts, probably in another part of the application.
801 * src/maemo/modest-account-view-window.c:
802 (on_delete_button_clicked), (on_edit_button_clicked),
803 (on_new_button_clicked): Use the new functions.
805 2007-05-09 Murray Cumming <murrayc@murrayc.com>
807 * src/modest-account-mgr-helpers.c:
808 (modest_account_mgr_set_first_account_as_default):
809 Sort the list of names alphabetically-by-title, so we choose the first one
811 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
812 alphabetically by the title.
814 This fixes projects.maemo.org bug NB#56418 .
816 * src/modest-account-mgr-priv.c:
817 (_modest_account_mgr_account_from_key):
818 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
819 avoid a valgrind error, and possible random behaviour.
821 2007-05-09 Murray Cumming <murrayc@murrayc.com>
823 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
824 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
825 tinymail documentation to say that this can be expected.
826 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
827 pretty, and should not happen, but I would prefer to know when it does.
829 2007-05-09 Murray Cumming <murrayc@murrayc.com>
831 * configure.ac: When using the older hildon version, probably on Bora,
832 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
834 * src/widgets/modest-attachment-view.c:
835 (modest_attachment_view_set_part_default): Initialize variables, to fix the
838 2007-05-09 Marcus Bauer <marcusb@openismus.com>
840 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
841 Implemented the prototype. Can be tested with
842 tests/dbus_api/test_open_message:
844 2007-05-08 Murray Cumming <murrayc@murrayc.com>
846 * src/modest-tny-account-store.c:
847 (modest_tny_account_store_instance_init), (get_password):
848 * src/modest-ui-actions.c:
849 (modest_ui_actions_on_password_requested):
850 Do not store the password in gconf, because this function is called
851 for non-remembered passwords. Actually use the cached (in the hash map)
852 password instead of releasing it.
853 The password will now not be remembered if it is asked via the protected
854 password dialog, as per the UI spec.
856 2007-05-08 Murray Cumming <murrayc@murrayc.com>
859 * src/modest-account-mgr-helpers.h:
860 * src/modest-account-mgr-helpers.c:
861 Added modest_server_account_get_username_has_succeeded(),
862 modest_server_account_set_username_has_succeeded().
863 (modest_server_account_set_username),
864 Reset the has-succeeded flag if the username changes.
866 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
867 * src/maemo/modest-connection-specific-smtp-window.c:
868 (modest_connection_specific_smtp_window_save_server_accounts):
869 Use modest_server_account_set_username() instead of using
870 modest_conf_set_string() directly, so that the has-succeeded flag is always
873 * src/modest-ui-actions.c:
874 (modest_ui_actions_on_password_requested): Dim the username entry if
875 the username has ever worked, as per the UI spec.
877 2007-05-08 Murray Cumming <murrayc@murrayc.com>
879 * src/modest-tny-account-store.c: (get_password):
880 * src/modest-ui-actions.c:
881 (modest_ui_actions_on_password_requested):
882 Allow the username to be changed too, though there is more work to
883 be done on exactly how this behaves.
885 2007-05-08 Murray Cumming <murrayc@murrayc.com>
887 * src/modest-account-mgr-helpers.h:
888 * src/modest-account-mgr-helpers.c:
889 Added modest_account_mgr_get_display_name(),
890 modest_server_account_get_username(),
891 modest_server_account_set_username(),
892 modest_server_account_set_password(),
893 modest_server_account_get_hostname() functions so we do not need to
894 use the conf API directly.
896 * src/maemo/modest-main-window.c: (connect_signals):
897 Actually connect ot the ModestAccountStore::request-password signal,
898 so that we show the dialog when the password is requested by Tinymail,
899 for isntance if it is empty.
901 * src/modest-marshal.list:
902 * src/modest-tny-account-store.c:
903 (modest_tny_account_store_class_init), (get_password),
904 (modest_tny_account_store_alert):
905 * src/modest-tny-account-store.h:
906 * src/modest-ui-actions.h:
907 * src/modest-ui-actions.c:
908 (modest_ui_actions_on_password_requested):
909 Change the signal parameters, so it is obvious that we are providing
910 the non human-readable server name, and receiving both the username
911 and password, though changing of the username is not yet implemented.
912 Change the dialog UI to match the Maemo UI specifications, with #idfefing
913 for the GNOME version.
915 This should fix the projects.maemo.org bug NB#56209, though it does not
916 work on Bora, because the gconf_client_get() for the password fails
917 immediately after we save it with gconf_client_set().
919 2007-05-08 Murray Cumming <murrayc@murrayc.com>
922 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
923 caused an undefined symbol error:
924 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
926 2007-05-08 Murray Cumming <murrayc@murrayc.com>
928 * src/modest-tny-account-store.c:
929 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
930 using a GError instead of a string message, so we can translate it in
933 2007-05-08 Murray Cumming <murrayc@murrayc.com>
935 * src/maemo/modest-address-book.c:
936 (modest_address_book_check_names):
937 * src/maemo/modest-msg-view-window.c:
938 (modest_msg_view_window_clipboard_owner_change):
939 * src/modest-init.c: (modest_init_init_ui):
940 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
941 (update_folders_cb), (modest_mail_operation_update_account):
942 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
943 (modest_ui_actions_on_msg_attachment_clicked),
944 (modest_ui_actions_on_msg_recpt_activated):
945 * src/widgets/modest-header-view.c: (drag_data_get_cb):
946 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
947 (modest_msg_view_search_next):
948 * src/widgets/modest-recpt-editor.c:
949 (modest_recpt_editor_on_button_release_event),
950 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
951 g_message(). At this point we should only be seeing interesting errors on
952 stdout. Debugging messages could be #ifdefed-out if they are still useful.
954 2007-05-07 Murray Cumming <murrayc@murrayc.com>
956 (modest_wizard_dialog_force_title_update):
957 * src/maemo/easysetup/modest-wizard-dialog.h:
958 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
959 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
960 can update the title when appropriate. Otherwise the title is wrong if the
961 pages are added after adding the notebook to the dialog.
962 This must be a problem in HildonWizardDialog too.
963 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
965 * src/maemo/easysetup/modest-easysetup-wizard.c:
966 (create_subsequent_customsetup_pages),
967 (create_subsequent_easysetup_pages):
968 Call modest_wizard_dialog_force_title_update() so that the title is
969 correct even with GTK+ < 2.10.
970 This fixes projects.maemo.org bug NB#56145 .
972 2007-05-07 Murray Cumming <murrayc@murrayc.com>
974 * src/maemo/modest-platform.c:
975 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
976 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
979 2007-05-07 Murray Cumming <murrayc@murrayc.com>
981 * src/widgets/modest-window.h:
982 * src/widgets/modest-window.c: Added a save_state_func vfunc,
983 and modest_window_save_state(), which invokes it.
985 * src/widgets/modest-window-mgr.h:
986 * src/widgets/modest-window-mgr.c:
987 Added modest_window_mgr_save_state_for_all_windows(), which calls
988 the save_state vfunc on all registered windows, if implemented.
990 * src/gnome/modest-msg-edit-window.c:
991 * src/gnome/modest-msg-view-window.c:
992 * src/maemo/modest-msg-edit-window.c:
993 * src/maemo/modest-msg-view-window.c:
994 * src/maemo/modest-main-window.c:
995 Specify the existing save_settings functions as implementations of
996 ModestWindow::save_state_func().
998 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
999 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1000 enabling hibernation, for instance.
1002 We may need to do the same thing for restoring settings.
1005 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1007 * src/widgets/modest-window-mgr.c:
1008 * src/widgets/modest-window-mgr.h:
1009 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1010 modest_window_mgr_get_hibernation_is_prevented().
1012 * src/maemo/modest-main-window.c:
1013 (on_hildon_program_is_topmost_notify): Prevent hibernation
1014 (possible when the application goes to the background in the WM),
1015 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1017 * src/maemo/easysetup/modest-easysetup-wizard.c:
1018 (modest_easysetup_wizard_dialog_init):
1019 * src/maemo/modest-account-settings-dialog.c:
1020 (modest_account_settings_dialog_init):
1021 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1022 (modest_connection_specific_smtp_edit_window_init):
1023 * src/maemo/modest-connection-specific-smtp-window.c:
1024 (modest_connection_specific_smtp_window_init):
1025 * src/maemo/modest-signature-editor-dialog.c:
1026 (modest_signature_editor_dialog_init):
1027 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1028 prevent hibernation while any of these account settings dialogs are open.
1030 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1032 * src/maemo/Makefile.am:
1033 * src/maemo/modest-osso-state-saving.c:
1034 * src/maemo/modest-osso-state-saving.h: Added
1035 modest_osso_load_state() and modest_osso_save_state() though they do
1036 nothing now. They should iterate through all the open windows and load/save
1038 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1039 save state when closing.
1041 * src/maemo/modest-main-window.c:
1042 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1043 Add a notification handler for the HildonProgram::is-topmost property,
1044 so we can allow hibernation when the application goes into the background.
1045 But we still need to detect when the accounts setup windows are open so
1046 we can stop hibernation when they are open.
1047 To do this, I also added the main window the HildonProgram. This might have
1048 other side-effects/benefits, and should maybe be done for other windows.
1050 * src/maemo/modest-osso-autosave-callbacks.h:
1051 * src/maemo/modest-osso-autosave-callbacks.c:
1052 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1053 though it does not do anything yet, and we might never need this to do
1054 anything. For instance, we already save drafts.
1056 * src/maemo/modest-platform.c: (modest_platform_init):
1057 Specify the libosso auto-save callback.
1059 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1061 * src/maemo/modest-platform.c:
1062 (modest_platform_set_update_interval):
1063 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1064 aparently stays valid between application instances, so we can use this
1065 to remove and reset it later. According to a maemo-developers email from
1068 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1070 * configure.ac: Depend on libalarm for Maemo.
1072 * src/dbus_api/modest-dbus-api.h:
1073 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1074 (on_send_receive), (modest_dbus_req_handler):
1075 Handle a SEND_RECEIVE D-Bus method.
1077 * libmodest-dbus-client/libmodest-dbus-client.c:
1078 (libmodest_dbus_client_send_and_receive):
1079 * libmodest-dbus-client/libmodest-dbus-client.h:
1080 Add C convenience functions for calling the new D-Bus method.
1082 * src/modest-platform.h:
1083 * src/gnome/modest-platform.c:
1084 * src/maemo/modest-platform.c:
1085 Added modest_platform_set_update_interval(), which uses the
1086 alarmd API on Maemo.
1087 (modest_platform_init),
1088 Call modest_platform_set_update_interval(), using a hard-coded
1089 interval for now (until the global settings dialog is implemented),
1090 though I am not sure that this makes sense yet.
1092 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1094 * src/dbus_api/modest-dbus-callbacks.c:
1095 (modest_osso_cb_hw_state_handler):
1096 * src/dbus_api/modest-dbus-callbacks.h:
1097 * src/maemo/modest-platform.c: (modest_platform_init):
1098 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1099 in case this has some effect on the ability for Maemo to ping the
1102 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1104 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1105 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1106 warning. It is probably a logic error, but I need to fix the build.
1108 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1110 * src/modest-account-mgr.h:
1111 * src/modest-account-mgr.c:
1112 (modest_account_mgr_account_names): Add a gboolean enabled_only
1113 parameter, so we can get lists of onlt the enabled accounts.
1115 (modest_account_mgr_add_account),,
1116 (modest_account_mgr_account_with_display_name_exists):
1117 * src/maemo/modest-msg-edit-window.c: (get_transports):
1118 * src/modest-account-mgr-helpers.c:
1119 (modest_account_mgr_set_first_account_as_default):
1120 * src/modest-init.c: (init_default_account_maybe):
1121 * src/modest-tny-account-store.c: (get_accounts):
1122 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1123 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1124 * tests/check_account-mgr.c: (START_TEST):
1125 Provide the extra parameter, as appropriate.
1127 * src/widgets/modest-account-view.c: (update_account_view):
1128 Do not show disabled accounts (meaning that there is no way to
1129 enable/disable accounts in the UI (the feature is not in our UI
1130 specification), so we can use this internally only to mark unfinished
1131 or temporary account data.
1133 * src/maemo/easysetup/modest-easysetup-wizard.c:
1134 (create_account): Add boolean enable parameter, so we can specify FALSE
1135 to create the temporary account.
1136 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1137 (on_before_next): When finishing, when there is a temporary account, just
1139 Also, use a timeout to delay the showing of the dialog until gconf is likely
1140 to return correct information, due to a maemo gconf bug that is fixed in
1141 osso 1.1, but not yet in Bora.
1142 However, the dialog stays on screen after it is destroyed.
1144 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1145 for invalid data when cancelling. Use a hildon note instead of a dialog
1146 to complain about invalid data. Do not show the account-saved note if the
1147 account is disabled (a temporary account that will not really be saved for use
1150 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1152 * src/modest-account-mgr-helpers.h:
1153 * src/modest-account-mgr-helpers.c:
1154 Added modest_account_mgr_unset_default_account(),
1155 Added modest_account_mgr_set_first_account_as_default().
1157 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1158 If it was the default account, unset the default account name.
1160 * src/maemo/modest-account-view-window.c:
1161 (on_delete_button_clicked): If it was the default account,
1162 set the first remaining account as the default instead.
1164 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1165 a NULL account or a NULL default account, to prevent a crash. This should
1166 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1169 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1171 * src/widgets/modest-recpt-editor.c:
1172 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1173 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1174 TODO comment for this. This fixes the build.
1176 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1177 be the best place for it. This will in future update all auto-update accounts,
1178 rather than just the current/default account, when that gconf key exists.
1179 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1180 if there are no accounts, before calling do_send_receive().
1181 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1183 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1184 * src/maemo/modest-main-window-ui.h:
1185 * src/maemo/modest-main-window.c: (on_connection_changed),
1186 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1187 directly, becaue the signal handler does more.
1189 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1191 * src/modest-account-mgr-helpers.c:
1192 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1193 for the case that the account does not exist.
1195 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1196 (equivalent to the modest account name) rather than the tinymail account name
1197 (equivalent to the modest account title - human readable) to get the account data.
1198 Check for null account data to prevent the crash, and add a TODO comment saying that
1199 this needs fixing because it is using the server account name instead of the account name.
1201 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1203 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1204 * src/maemo/modest-account-settings-dialog.c: (show_error),
1206 Use hildon_note_new_information() for informative and error messages,
1207 which seems to be expected for Maemo applications (no documentation that I know of
1208 says this). I am surprised that there is no distinction between info and error
1211 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1213 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1214 it is easy to find where this is used.
1216 * src/maemo/easysetup/modest-easysetup-wizard.c:
1217 (create_page_welcome), (create_page_account_details),
1218 (create_page_user_details), (create_page_complete_easysetup),
1219 (create_page_custom_incoming), (create_page_custom_outgoing),
1220 (create_page_complete_custom):
1221 * src/maemo/modest-account-settings-dialog.c:
1222 (create_page_account_details), (create_page_user_details),
1223 (create_page_incoming), (create_page_outgoing):
1224 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1225 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1226 (modest_connection_specific_smtp_edit_window_init):
1227 * src/maemo/modest-connection-specific-smtp-window.c:
1228 (modest_connection_specific_smtp_window_init):
1229 * src/maemo/modest-signature-editor-dialog.c:
1230 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1231 and scrolling policy as per the Email Application Layout Guide, if I have
1234 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1236 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1237 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1238 which were empty, because these vfuncs have been removed from TnyAccountStore.
1239 This fixes the build.
1241 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1243 * src/maemo/modest-main-window.c:
1244 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1245 showing/hiding it. Added TODO because it probably should not be NULL.
1246 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1247 because unnecessary g_warnings() make degugging difficult.
1249 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1251 * src/maemo/modest-msg-edit-window.c:
1252 (modest_msg_edit_window_select_color),
1253 (modest_msg_edit_window_select_background_color): 2 const corrections and
1254 moving 2 #endifs before closing brackets, to fix the build.
1256 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1258 * src/maemo/easysetup/modest-easysetup-wizard.h:
1259 * src/maemo/easysetup/modest-easysetup-wizard.c:
1260 (modest_easysetup_wizard_dialog_finalize),
1261 (on_button_edit_advanced_settings), (create_page_complete_custom),
1262 (on_response), (create_account):
1263 Implement the Advanced Settings edit button, by saving the account information,
1264 for the Advanded Settings dialog to use directly from gconf, and removing it
1265 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1266 Bug #5533 in the projects.maemo.org bugzilla.
1268 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1270 * src/maemo/modest-msg-view-window.c:
1271 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1272 when opening a message window.
1274 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1276 * src/maemo/easysetup/modest-easysetup-wizard.c:
1277 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1280 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1281 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1282 gconf settings. I probably added more checks than necessary, but that is safer.
1284 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1285 variable to fix the build, but this seems to be used when it is still NULL.
1287 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1289 * src/modest-platform.h:
1290 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1291 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1292 * src/modest-main.c: Implement this function so we can avoid using
1293 maemo-specific API from cross-platform code.
1295 * src/modest-tny-account-store.c:
1296 (get_smtp_specific_transport_account_for_open_connection):
1297 * src/modest-ui-actions.c: (check_for_connection),
1298 (modest_ui_actions_on_item_not_found):
1299 Use modest_platform_connect_and_wait() and put #idefs around other
1300 maemo-specific code, because only maemo currently has a way to
1301 identify connection names.
1303 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1305 * src/modest-tny-account-store.h:
1306 * src/modest-tny-account-store.c:
1307 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1308 the connection-specific SMTP server settings in the configuration.
1310 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1312 * src/maemo/modest-main-window.c: (on_connection_changed),
1314 * src/modest-main.c: (main), (start_ui), (send_mail):
1315 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1316 that is what is intended.
1318 * src/modest-ui-actions.c: (action_send), (action_receive),
1319 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1320 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1321 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1322 SMTP server is used when it is specified.
1324 (modest_ui_actions_on_send_receive):
1325 Check that a connection is open before proceeding.
1326 Receive and then send, instead of vice-versa, as per the specification.
1328 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1330 * src/modest-mail-operation.c:
1331 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1332 though I guess it should be something other than NULL.
1334 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1336 * src/maemo/easysetup/modest-easysetup-wizard.c:
1337 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1338 combo twice, to avoid an g_warning and to make it visible again.
1339 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1340 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1341 (already intended) dereference when detaching, because we then recreate the menu.
1342 But I am not sure why the warning was happening, and it is possible that this is a memory
1345 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1347 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1348 and uri_parse_mailto() utility functions.
1349 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1351 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1353 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1355 * src/dbus_api/modest-dbus-api.h:
1356 * src/dbus_api/modest-dbus-callbacks.c:
1357 Use an idle callback to execute the modest code in the application's own thread.
1358 Remove the helloworld example method.
1359 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1360 parsed, and the open-message method is not implemented because this is not yet implemented in
1362 * libmodest-dbus-client/libmodest-dbus-client.c:
1363 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1364 (libmodest_dbus_client_open_message):
1365 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1367 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1368 body without crashing.
1370 * tests/dbus_api/Makefile.am:
1371 * tests/dbus_api/test_mail_to.c:
1372 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1374 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1376 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1377 Added file to fix the build. Sorry.
1379 * src/dbus_api/Makefile.am:
1380 * src/dbus_api/modest-dbus-api.h:
1381 * src/dbus_api/modest-dbus-callbacks.h:
1382 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1383 (modest_dbus_req_handler):
1384 Put constants in a separate header so it can be reused by the
1385 client library, without duplication
1387 * libmodest-dbus-client/Makefile.am:
1388 * libmodest-dbus-client/libmodest-dbus-client.c:
1389 (libmodest_dbus_client_call_helloworld),
1390 (libmodfest_dbus_client_send_mail),
1391 (libmodfest_dbus_client_mailto),
1392 (libmodfest_dbus_client_open_message):
1393 * libmodest-dbus-client/libmodest-dbus-client.h:
1394 (Partly) Implement a send_mail D-Bus method.
1396 * tests/dbus_api/Makefile.am:
1397 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1398 the send_email D-Bus method.
1400 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1404 * libmodest-dbus-client/Makefile.am:
1405 * libmodest-dbus-client/libmodest-dbus-client.c:
1406 * libmodest-dbus-client/libmodest-dbus-client.h:
1407 * tests/dbus_api/Makefile.am:
1408 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1409 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1411 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1413 * src/maemo/easysetup/modest-easysetup-wizard.c:
1414 (create_page_account_details):
1415 * src/maemo/modest-account-settings-dialog.c:
1416 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1417 widgets, because this might not be the default in future versions of the Maemo GTK+.
1418 However, I can not not get capitalization to work even in a simple test case.
1420 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1422 * src/maemo/easysetup/modest-easysetup-wizard.c:
1423 (create_page_custom_incoming), (create_page_custom_outgoing):
1424 * src/maemo/modest-account-settings-dialog.c:
1425 (create_page_account_details), (create_page_incoming),
1426 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1427 instead of using gtk_check_button_with_label(), so they are aligned like the other
1428 widgets, as per the UI spec.
1430 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1432 * src/maemo/easysetup/modest-easysetup-wizard.c:
1433 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1434 * src/widgets/modest-validating-entry.c:
1435 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1436 Modest prefix instead of an EasySetup prefix.
1438 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1440 * src/widgets/modest-validating-entry.h:
1441 * src/widgets/modest-validating-entry.c: (on_insert_text),
1442 Added easysetup_validating_entry_set_max_func(), used to set a callback
1443 to call when the max number of characters is reached. GtkEntry has a max-length
1444 already but is silent about it.
1446 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1447 (create_page_account_details), (create_page_user_details),
1449 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1450 (create_page_account_details), (create_page_user_details),
1451 (create_page_outgoing):
1452 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1453 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1454 the UI spec, when the user tries to enter more than the max number of characters.
1456 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1458 * src/maemo/easysetup/modest-easysetup-wizard.c:
1459 (create_page_user_details), (create_page_custom_incoming),
1460 (create_page_custom_outgoing):
1461 * src/maemo/modest-account-settings-dialog.c:
1462 (create_page_user_details), (create_page_incoming),
1463 (create_page_outgoing):
1464 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1465 (modest_connection_specific_smtp_edit_window_init):
1466 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1467 not appropriate. Bad Maemo-specific defaults!.
1469 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1471 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1472 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1473 (modest_signature_editor_dialog_set_settings):
1474 Disable the label and textview when the checkbox is disabled, and use the
1475 specified (UI spec) default signature text.
1477 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1479 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1480 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1482 * src/modest-defs.h:
1483 * src/modest-account-mgr-helpers.h:
1484 * src/modest-account-mgr-helpers.c:
1485 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1487 * src/maemo/Makefile.am:
1488 * src/maemo/modest-signature-editor-dialog.c:
1489 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1492 * src/maemo/modest-account-settings-dialog.h:
1493 * src/maemo/modest-account-settings-dialog.c:
1494 (modest_account_settings_dialog_finalize), (on_button_signature),
1495 (save_configuration): Use the new dialog when the Edit button is pressed, and
1496 save the changes if necessary, as per the UI spec.
1498 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1500 * src/maemo/Makefile.am:
1501 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1502 based on maemo-develoers email from Dirk.
1504 * src/maemo/easysetup/modest-easysetup-wizard.c:
1505 (create_page_welcome), (create_page_account_details),
1506 (create_page_user_details), (create_page_complete_easysetup),
1507 (create_page_custom_incoming), (create_page_custom_outgoing),
1508 (create_page_complete_custom),
1509 (modest_easysetup_wizard_dialog_init):
1510 * src/maemo/modest-account-settings-dialog.c:
1511 (create_page_account_details), (create_page_user_details),
1512 (create_page_incoming), (create_page_outgoing),
1513 (modest_account_settings_dialog_init):
1514 * src/maemo/modest-connection-specific-smtp-window.c:
1515 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1517 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1519 * src/maemo/easysetup/modest-easysetup-wizard.c:
1520 (create_page_account_details), (create_page_custom_outgoing),
1521 (create_page_complete_custom):
1522 * src/maemo/modest-account-settings-dialog.c:
1523 (create_page_user_details), (create_page_incoming),
1524 (create_page_outgoing):
1525 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1526 (modest_connection_specific_smtp_edit_window_init):
1527 Use the correct (UI spec) port min/max, and use horizontal separators,
1530 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1532 * src/maemo/easysetup/modest-easysetup-wizard.c:
1533 (set_default_custom_servernames):
1534 * src/maemo/modest-account-settings-dialog.c:
1535 (create_page_incoming), (on_combo_outgoing_security_changed),
1536 (on_combo_incoming_security_changed), (create_page_outgoing),
1537 (modest_account_settings_dialog_set_account_name),
1538 (save_configuration):
1539 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1540 (on_combo_security_changed),
1541 (modest_connection_specific_smtp_edit_window_init),
1542 (modest_connection_specific_smtp_edit_window_set_connection),
1543 (modest_connection_specific_smtp_edit_window_get_settings):
1544 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1547 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1550 * src/maemo/easysetup/modest-easysetup-wizard.c:
1551 (create_page_custom_outgoing), (create_page_complete_custom):
1552 * src/maemo/modest-account-settings-dialog.c:
1553 (create_page_user_details), (create_page_outgoing):
1554 * src/maemo/modest-account-view-window.c: (button_box_new):
1555 Use changed logical IDs as per the most recent UI spec:
1556 mcen_bd_emailsetup_edit -> mcen_bd_edit
1557 mcen_bd_emailsetup_delete -> mcen_bd_delete
1558 mcen_bd_emailsetup_close -> mcen_bd_close
1560 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1564 * src/dbus_api/Makefile.am:
1565 * src/dbus_api/modest-dbus-callbacks.c:
1566 * src/dbus_api/modest-dbus-callbacks.h:
1567 * src/maemo/modest-platform.c: (modest_platform_init):
1568 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1570 * tests/Makefile.am:
1571 * tests/dbus_api/Makefile.am:
1572 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1574 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1576 * src/maemo/modest-account-settings-dialog.c:
1577 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1578 Removed unnecessary includes.
1580 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1582 * src/maemo/easysetup/modest-easysetup-wizard.c:
1583 * src/maemo/modest-account-settings-dialog.c:
1584 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1585 * src/widgets/Makefile.am:
1586 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1587 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1588 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1589 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1590 * src/widgets/modest-secureauth-combo-box.c:
1591 * src/widgets/modest-secureauth-combo-box.h:
1592 * src/widgets/modest-serversecurity-combo-box.c:
1593 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1594 made the GObject names more consistent with the rest of the Modest code.
1596 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1598 * src/maemo/easysetup/Makefile.am:
1599 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1600 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1601 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1602 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1603 * src/maemo/easysetup/modest-easysetup-wizard.c:
1604 * src/maemo/easysetup/modest-validating-entry.c:
1605 * src/maemo/easysetup/modest-validating-entry.h:
1606 * src/maemo/modest-account-settings-dialog.c:
1607 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1608 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1609 widgets/ because they are used outside of easysetup too. After checking in,
1610 svn will allow me to rename them too.
1612 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1614 * src/gnome/modest-msg-edit-window.c:
1615 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1616 linker error, to fix the build on the GNOME platform.
1617 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1618 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1619 ifdefed out to avoid a warning.
1621 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1623 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1624 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1625 some alternative for GTK+ 2.6.
1627 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1629 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1631 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1632 specified for EmailAccountsDialog in UI spec.
1634 * src/maemo/easysetup/modest-easysetup-wizard.c:
1635 * src/maemo/easysetup/modest-easysetup-wizard.h:
1636 * src/maemo/modest-account-settings-dialog.c:
1637 * src/maemo/modest-account-settings-dialog.h:
1638 Reuse a member window widget for the connection-specific SMTP server accounts,
1639 so we can tell it to create/save the accounts only if we actually save changes.
1641 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1642 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1643 (modest_connection_specific_smtp_edit_window_get_settings):
1644 Return a struct instance for temporarily remembering the entered data.
1646 * src/maemo/modest-connection-specific-smtp-window.h:
1647 * src/maemo/modest-connection-specific-smtp-window.c:
1648 (modest_connection_specific_smtp_window_finalize),
1649 (modest_connection_specific_smtp_window_fill_with_connections),
1651 (modest_connection_specific_smtp_window_save_server_accounts),
1652 (update_model_server_names): Do not actually save data until asked,
1653 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1655 (on_selection_changed),
1656 (modest_connection_specific_smtp_window_init): Disable the edit
1657 button when nothing is selected.
1659 * src/modest-account-mgr-helpers.c:
1660 * src/modest-account-mgr-helpers.h:
1661 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1664 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1666 * src/modest-account-mgr-helpers.h:
1667 * src/modest-account-mgr-helpers.c:
1668 (modest_account_mgr_get_unused_account_name),
1669 (modest_account_mgr_get_unused_account_display_name): Added these
1670 utility functions, to avoid code duplication.
1672 * src/maemo/easysetup/modest-easysetup-wizard.c:
1673 (create_page_account_details), (create_account):
1674 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1675 (on_combo_security_changed),
1676 (modest_connection_specific_smtp_edit_window_init),
1677 (modest_connection_specific_smtp_edit_window_save_settings):
1678 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1679 * src/maemo/modest-connection-specific-smtp-window.c:
1680 (modest_connection_specific_smtp_window_finalize),
1681 (modest_connection_specific_smtp_window_fill_with_connections),
1682 (on_button_edit), (modest_connection_specific_smtp_window_init):
1683 * src/maemo/modest-connection-specific-smtp-window.h:
1684 Implementing saving of connection-specific server accounts.
1686 But I need to refactor this so we can save the data for each
1687 possible connection-specific account and only actually create the server accounts
1688 when the easysetup finished, or the OK button is pressed on the account settings
1691 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1693 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1694 (on_combo_security_changed):
1695 (modest_connection_specific_smtp_edit_window_init):
1696 Auto-fill the port number as in the account settings.
1698 (modest_connection_specific_smtp_edit_window_set_connection):
1699 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1700 * src/maemo/modest-connection-specific-smtp-window.c:
1701 (fill_with_connections), (on_button_edit),
1702 (modest_connection_specific_smtp_window_init):
1703 Turn the edit window into a dialog to simplify the code, and
1704 set a WM hint as in a GtkDialog, because only a popup can be on top of
1705 another window in Maemo, and popups usually have no WM decoration.
1707 * src/modest-defs.h:
1708 * src/modest-account-mgr-helpers.c:
1709 (modest_account_mgr_set_connection_specific_smtp),
1710 (modest_account_mgr_remove_connection_specific_smtp),
1711 (modest_account_mgr_get_connection_specific_smtp):
1712 * src/modest-account-mgr-helpers.h: Some functions to write the
1713 connection-specific SMTP server information. Not yet used.
1716 * src/widgets/modest-folder-view.c: (text_cell_data):
1717 Fix a warning about an uninitialized variable.
1718 (on_configuration_key_changed): Put an #ifdef around the use
1719 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1721 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1723 * src/maemo/modest-account-settings-dialog.h:
1724 * src/maemo/modest-account-settings-dialog.c:
1725 Added connect_for_modified() utility function to mark the new modified boolean.
1727 (create_page_account_details), (create_page_user_details),
1728 (create_page_incoming), (create_page_outgoing), (on_response),
1729 (modest_account_settings_dialog_init),
1730 (modest_account_settings_dialog_set_account_name):
1731 Only warn about unsaved changes when there are actually unsaved changes.
1733 * src/modest-account-mgr-helpers.c:
1734 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1735 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1736 to get the data from there in future.
1738 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1740 * src/modest-defs.h:
1742 * src/modest-account-mgr-helpers.h:
1743 * src/modest-account-mgr-helpers.c:
1744 Store the security account setting in a single conf key instead of using
1745 the options list, so that the list is left for just the to-be-removed camel hack,
1746 and because gconf_client_set_list() is failing for some reason.
1748 * src/modest-account-mgr.c:
1749 (modest_account_mgr_add_server_account):
1750 * src/maemo/modest-account-settings-dialog.c:
1751 (modest_account_settings_dialog_set_account_name),
1752 (save_configuration): Use the renamed functions.
1755 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1757 * src/widgets/Makefile.am:
1758 * src/widgets/modest-limit-retrieve-combo-box.c:
1759 * src/widgets/modest-limit-retrieve-combo-box.h:
1760 * src/widgets/modest-retrieve-combo-box.c:
1761 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1762 the account settings dialog.
1764 * src/modest-defs.h:
1765 * src/modest-account-mgr-helpers.h:
1766 * src/modest-account-mgr-helpers.c:
1767 (modest_server_account_get_option_secure_auth),
1768 (modest_server_account_set_option_secure_auth):
1769 * src/modest-account-mgr.c:
1770 (modest_account_mgr_add_server_account):
1771 Use the existing AUTH_MECH conf key for the secure-auth setting,
1772 instead of putting it in the list options, because this was actually used already.
1774 * src/maemo/modest-account-settings-dialog.c:
1775 (create_page_account_details),
1776 (modest_account_settings_dialog_set_account_name),
1777 (save_configuration):
1778 * src/maemo/modest-account-settings-dialog.h:
1779 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1780 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1782 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1784 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1785 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1786 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1788 * src/modest-defs.h:
1789 * src/maemo/modest-account-settings-dialog.c:
1790 (create_page_incoming), (on_combo_outgoing_security_changed),
1791 (on_combo_incoming_security_changed), (create_page_outgoing),
1792 (modest_account_settings_dialog_set_account_name),
1793 (save_configuration): Load/Save the port number, and change it when the
1794 security combo changes, to suitable defaults.
1796 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1798 * src/modest-account-mgr.c:
1799 (modest_account_mgr_add_server_account): Set the security and secure-auth
1800 options, and add a comment saying that the other camel-specific options should be
1803 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1805 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1807 * src/modest-tny-account-store.c: (account_list_free),
1808 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1809 cursor->data after unreffing it. But there is some strange stuff there so it might not be
1812 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1814 * src/modest-protocol-info.c:
1815 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1816 is required by our UI spec. Maybe something in our implementation will use this eventually.
1817 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1818 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1819 instead of the previous 0 placeholder.
1821 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1822 secure-auth settings.
1823 * src/modest-account-mgr-helpers.h:
1824 * src/modest-account-mgr-helpers.c:
1825 (modest_server_account_data_get_option_secure_auth),
1826 (modest_server_account_set_option_secure_auth),
1827 (modest_server_account_data_get_option_security),
1828 (modest_server_account_set_option_security): Added this API for getting and setting the security
1829 and secure-auth settings.
1831 * src/maemo/modest-account-settings-dialog.h:
1832 * src/maemo/modest-account-settings-dialog.c:
1833 (modest_account_settings_dialog_finalize), (check_data),
1834 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1835 about changing titles.
1836 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1837 (save_configuration): Save the security and secure-auth settings.
1839 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1840 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1842 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1844 * src/modest-defs.h:
1845 * src/modest-account-mgr.c:
1846 (modest_account_mgr_add_server_account):
1847 Added and used defines for the options key and value pair strings,
1848 that are used so far, though they do not seem to correspond to anything in our
1849 UI specs or ModestProtocol enum.
1851 * src/modest-account-mgr-helpers.h:
1852 * src/modest-account-mgr-helpers.c:
1853 (compare_option_strings_for_name),
1854 (modest_server_account_data_get_option_value),
1855 (modest_server_account_data_get_option_bool),
1856 (modest_account_mgr_get_server_account_option):
1857 Added helper functions for parsing the options GSList.
1859 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1861 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1862 display name is based on the supplied account name.
1863 * src/modest-account-mgr.c:
1864 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1865 with an inefficient, but good-enough, implementation.
1867 * src/maemo/easysetup/modest-easysetup-wizard.c:
1868 (create_page_account_details), (on_before_next), (create_account):
1869 Check for existing display names rather than (non-user-visible) account names, and just
1870 create and set a unique account name at the end.
1872 * src/maemo/modest-account-settings-dialog.c:
1873 (modest_account_settings_dialog_init),
1874 (modest_account_settings_dialog_set_account_name),
1875 (create_page_incoming): Show the display name, instead of the account name.
1876 (on_response): Do some (not all) extra checks, as in the UI spec.
1877 (save_configuration): Save the display name if it was changed.
1879 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1881 * po/en_GB.po: Added needed logical ID and translation.
1882 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1883 (init_view): Made the is-default column clicking work.
1885 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1888 * src/maemo/easysetup/Makefile.am:
1889 * src/maemo/easysetup/modest-easysetup-wizard.c:
1890 (modest_easysetup_wizard_dialog_init):
1891 * src/maemo/easysetup/provider-data-test.keyfile:
1892 * src/maemo/easysetup/provider-data.keyfile:
1893 Moved the provider data file to the new modest-providers-data package and used it from there.
1895 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1897 * src/modest-local-folder-info.c:
1898 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1899 N_() was already used on the static strings, but this just marks it for translation without
1900 using the translation.
1902 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1904 * src/maemo/modest-account-settings-dialog.c:
1905 (create_page_incoming),
1906 (modest_account_settings_dialog_set_account_name):
1907 Added comments about the need for new API in ModestAccountMgr to handle the authentication
1908 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1909 I will do this if nobody else gets there first.
1911 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1913 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1914 Saved much of the incoming and outgoing data too, though I cannot yet see how to
1915 save the security stuff.
1917 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1919 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1920 Set the email address and user fullname, which I now see must be
1923 * src/maemo/modest-account-settings-dialog.h:
1924 * src/maemo/modest-account-settings-dialog.c:
1926 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1927 leave-on-server and authentication.
1928 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1931 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1934 * src/maemo/modest-account-settings-dialog.c:
1935 * src/maemo/modest-account-settings-dialog.h:
1936 Most (but not all) of the widgets are now present as specified by the UI spec.
1937 No changes are yet saved, and some details are not properly shown yet.
1939 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1941 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1943 * src/maemo/Makefile.am:
1944 * src/maemo/modest-account-settings-dialog.c:
1945 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1946 an existing account. Doesn't do much yet.
1948 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1949 Open the accounts settings dialog when Edit is clicked.
1951 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1953 * src/maemo/easysetup/Makefile.am:
1954 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1956 * src/maemo/easysetup/modest-easysetup-wizard.c:
1957 (modest_easysetup_wizard_dialog_init):
1958 Try to get the source directory from the build system,
1959 instead of hard-coding "./" into the source code, when opening our local
1960 copies of the configuration files.
1961 But this still fails when opening the wizard from the Accounts window,
1962 maybe because the working directory seems to change at runtime.
1963 So the wizard will fail the second time unless you copy the files into their
1964 proper locations - see the stdout warnings for the paths.
1966 (create_page_account_details),(on_before_next):
1967 Check for existing non-server accounts instead of server accounts,
1968 so the default account name is useful again, and to prevent trying to
1971 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1972 Show the wizard when New is clicked.
1974 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1975 (init_view): Show the column headers, and show the columns that are
1976 specified in the UI specs. However, something in Maemo's GTK+ prevents
1977 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1978 change the default account. This is despite unsetting the special properties.
1980 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1982 * docs/reference/modest-design.sgml: Corrected spelling mistake.
1983 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1984 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1985 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1986 to make that clearer.
1987 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1989 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1991 * src/maemo/modest-account-view-window.c:
1992 (modest_account_view_window_init),
1993 (modest_account_view_window_new):
1994 Use the same buttons as specified in the
1995 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1996 the existing widgets, which never had a chance of working.
1997 Put the ModestAccountView treeview in a scrolled window.
1998 Do not repeat the initialization in both _init() and _new().
2000 * src/widgets/modest-account-view.c: (update_account_view):
2001 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2002 this widget and window shows no accounts.
2004 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2006 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2008 * src/maemo/easysetup/modest-easysetup-wizard.c:
2009 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2010 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2011 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2014 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2015 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2016 accounts exist yet, as in the UI spec.
2018 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2020 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2022 * src/maemo/Makefile.am:
2023 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2024 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2025 New window for editing connection-specific smtp details.
2026 Not fully implemented.
2028 * src/maemo/modest-connection-specific-smtp-window.c:
2029 (modest_connection_specific_smtp_window_finalize) :
2030 unref the tree model.
2031 (on_button_edit): Show the edit window.
2033 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2035 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2038 * src/maemo/Makefile.am:
2039 * src/maemo/modest-connection-specific-smtp-window.c:
2040 * src/maemo/modest-connection-specific-smtp-window.h:
2041 New window for showing the list of connections, for connection-specific
2042 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2043 * src/maemo/easysetup/modest-easysetup-wizard.c:
2044 (create_page_custom_outgoing): Show the new window when the button is clicked.
2046 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2048 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2049 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2050 * src/maemo/modest-msg-edit-window.c:
2051 (modest_msg_edit_window_insert_image):
2052 * src/modest-conf.c: (modest_conf_key_escape):
2053 * src/modest-mail-operation.c:
2054 (modest_mail_operation_send_new_mail):
2055 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2056 (modest_ui_actions_on_new_account):
2057 * src/widgets/modest-attachment-view.c: (update_filename_request):
2058 * src/widgets/modest-mail-header-view.c:
2059 Corrected warnings that were breaking the build, by commenting out unused variables,
2060 and a function, and by including a header.
2062 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2064 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2065 so we can #ifdef around platform-specific code when necessary.
2066 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2067 to allow this to build for the GNOME platform too.
2069 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2071 * src/maemo/easysetup/modest-easysetup-wizard.c:
2072 Added util_increment_name() and used it in create_page_account_details()
2073 to make sure that the default account name is always a new name.
2075 (modest_easysetup_wizard_dialog_init),
2076 (set_default_custom_servernames): Some minor memory management fixes.
2078 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2082 * src/modest-runtime.c: (init_i18n): Restored the translation
2083 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2084 are defined in config.h, and the translations are installed.
2086 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2087 is defined for translation.
2089 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2091 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2093 * src/maemo/easysetup/modest-easysetup-wizard.c:
2094 (modest_easysetup_wizard_dialog_init):
2095 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2096 Use realistic paths (though they should use $prefix generically) to the
2097 mcc_mapping and provider-data.keyfile files which might work when they
2098 are installed by the future version of the operator-wizard package,
2099 and then fallback to paths in our source code, with an explanatory
2102 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2106 * src/maemo/Makefile.am:
2107 * src/maemo/easysetup/: Added files from the previously-exernal
2108 osso-modest-easysetup.
2109 * src/maemo/modest-main-window-ui.h:
2110 * src/modest-ui-actions.c:
2111 * src/modest-ui-actions.h:
2112 Added modest_ui_actions_on_new_account() as a signal handler for the
2113 New Account menu item. It shows the easysetup wizard.
2114 * po/en_GB.po: Added additional needed logical IDs and translations.
2116 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2117 Apparently ChangeLog is not used for some vague Nokia legal reasons.