1 2007-07-16 Murray Cumming <murrayc@murrayc.com>
3 * src/widgets/modest-msg-view.h:
4 * src/widgets/modest-msg-view.c:
5 Added modest_msg_view_get_message_is_empty() but this needs
7 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
8 Check if there is any text in the message yet.
9 But this needs to be implemented properly.
10 (modest_msg_edit_window_toggle_find_toolbar):
11 * src/maemo/modest-msg-view-window.c:
12 (modest_msg_view_window_toggle_find_toolbar):
13 Show a banner warning if there is no text to search, when
14 trying to start a search. This partially fixes
15 projects.maemo.org bug NB#62350.
17 2007-07-13 Murray Cumming <murrayc@murrayc.com>
19 * src/modest-mail-operation.c: (update_account_thread):
20 Initialized num_new_headers to fix the build.
22 2007-07-13 Murray Cumming <murrayc@murrayc.com>
24 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
25 Ignore modest accounts whose server accounts don't exist in gconf.
26 This prevents us trying to create TnyAccount instances for those
27 server accounts when the server account has been removed from gconf,
28 but the parent modest account has not yet been removed from modest.
29 I don't know why this is only noticeable now. It was probably just
30 a harmeless g_warning() anyway.
32 2007-07-13 Murray Cumming <murrayc@murrayc.com>
34 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
35 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
37 2007-07-12 Armin Burgmeier <armin@openismus.com>
39 * src/maemo/modest-main-window.c: Make default account appear bold
40 in view, tools/send & receive and toolbar/send & receive SCM menus.
41 This fixes projects.maemo.org bug NB#59010.
43 2007-07-12 Murray Cumming <murrayc@murrayc.com>
45 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
46 Add a short-cut, by checking if the folder store is an account.
47 This ensures that the Sort menu item and toolbar is dimmed for
48 the local-folders account root item, fixing
49 projects.maemo.org bug NB#62545.
51 2007-07-12 Murray Cumming <murrayc@murrayc.com>
53 * src/modest-tny-account-store.c: (get_password):
54 Show the password dialog (via the signal) only in the mainloop, via
55 an idle handler that we wait for. This could theoretically prevent
56 hangs, though I worry that it could introduce some too.
58 2007-07-12 Murray Cumming <murrayc@murrayc.com>
60 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
61 * src/maemo/modest-platform.c:
62 (modest_platform_connect_and_wait):
63 Take a TnyAccount* parameter and try to set it to online
64 (a TnyCamel-only API), because tinymail sets accounts to offline
65 when the user cancels a password dialog, and doesn't ask again until
66 it has been set to online.
67 However, this is commented out because it causes a hang now.
69 (modest_platform_connect_and_wait_if_network_account):
70 * src/modest-mail-operation.c:
71 (modest_mail_operation_update_account):
72 * src/modest-platform.h:
73 * src/modest-ui-actions.c: (_modest_ui_actions_open),
74 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
76 2007-07-12 Armin Burgmeier <armin@openismus.com>
78 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
80 * src/modest-mail-operation.c:
81 * src/modest-ui-actions.c: Check for already existing folder before
82 querying the server, show error message from camel if the request
83 still fails. This fixes projects.maemo.org bug NB#58701.
85 2007-07-12 Murray Cumming <murrayc@murrayc.com>
87 * src/modest-tny-account-store.h:
88 * src/modest-tny-account-store.c:
89 Added modest_tny_account_store_forget_password_in_memory(),
90 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
91 when creating a new account, so that new passwords will be used, instead of
92 us thinking that it's a second request as a result of a failed password again.
94 2007-07-12 Murray Cumming <murrayc@murrayc.com>
96 * src/dbus_api/modest-dbus-callbacks.c:
97 (on_idle_open_message): If the message is in drafts then open it
98 in an edit window instead of a view window. This fixes
99 projects.maemo.org bug NB#63005.
101 2007-07-12 Murray Cumming <murrayc@murrayc.com>
103 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
104 Avoided a harmless g_warning().
106 2007-07-12 Murray Cumming <murrayc@murrayc.com>
108 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
109 Pass the modest account name, not the TnyAccount display name to
110 modest_msg_view_window_new() so that the reply feature works,
111 fixing projects.maemo.org bug NB#62892.
113 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
114 (modest_msg_view_window_new_with_header_model):
115 * src/maemo/modest-msg-view-window.c:
116 (modest_msg_view_window_new_with_header_model),
117 (modest_msg_view_window_new):
118 * src/modest-ui-actions.c: (reply_forward):
119 * src/widgets/modest-msg-view-window.h:
120 * src/widgets/modest-window.c: (modest_window_set_active_account):
121 Rename an account parameter to modest_account_name to make this clearer.
123 2007-07-11 Murray Cumming <murrayc@murrayc.com>
125 * src/modest-ui-actions.h:
126 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
127 modest_do_message_delete().
128 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
129 Call modest_do_message_delete(), hoping that this would cause messages
130 to be really deleted from search instead of just marked with strike through.
131 Does not seem to help.
133 2007-07-11 Armin Burgmeier <armin@openismus.com>
135 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
136 priv->reselect to FALSE prior to calling
137 modest_folder_view_select_first_inbox_or_local() to prevent endless
138 recursion and thus a crash on startup.
140 2007-07-11 Armin Burgmeier <armin@openismus.com>
142 * src/maemo/modest-account-settings-dialog.h: Include
143 <gtk/gtknotebook.h> to fix the build (at least for me).
145 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
146 Use "New FolderN" as default suggested name if "New folder" already
147 exists, with N being the first free number, though never exceed "New
148 folder99" in which case we just fall back to "New Folder" even though
149 it already exists. This fixes projects.maemo.org bug NB#58663.
151 2007-07-11 Murray Cumming <murrayc@murrayc.com>
153 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
154 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
155 projects.maemo.org bug NB#62778.
157 2007-07-11 Murray Cumming <murrayc@murrayc.com>
159 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
160 Ignore the wrong (for now) secure-smtp setting in the presets -
161 just default to requiring secure authentication for SMTP, because
164 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
166 * src/widgets/modest-folder-view.c: (filter_row)
167 Do not show drafts folder (see UI specs)
169 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
171 * src/modest-ui-actions.c:
172 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
173 place and also not necessary.
175 * src/widgets/modest-folder-view.c: (filter_row)
176 Guess folder type and hide Sent & Outbox if necessary.
177 Fixed project.maemo.org NB#57328
179 2007-07-11 Murray Cumming <murrayc@murrayc.com>
181 * src/modest-ui-actions.h:
182 * src/modest-ui-actions.c:
183 (modest_ui_actions_on_delete_message):
184 Move some code into a new
185 modest_ui_actions_refresh_message_window_after_delete()
186 function so we can use it from elsewhere.
188 * src/dbus_api/modest-dbus-callbacks.c:
189 (on_idle_delete_message), (on_delete_message): Used an idle
190 handler, as we do for the other D-Bus method handlers.
191 Call modest_ui_actions_refresh_message_window_after_delete()
192 if the deleted message was open in a window. This fixed
193 projects.maemo.org bug NB#62862.
195 2007-07-11 Murray Cumming <murrayc@murrayc.com>
197 * src/modest-main.c: (main): Only show the UI at the start if
198 the showui command line option was given. For instance,
199 run-standalone src/modest showui
200 Otherwise, we wait for the top_application D-Bus method to
201 be sent by hildon-desktop when the application is selected
203 This allows us to run without a UI when osso-global-search
204 uses our D-Bus methods.
206 2007-07-11 Murray Cumming <murrayc@murrayc.com>
208 * src/dbus_api/modest-dbus-api.h: Added a define for a
209 top-application D-Bus method.
210 * src/dbus_api/modest-dbus-callbacks.c:
211 (on_top_application),
212 (modest_dbus_req_handler): Handle the top-application D-Bus
213 method, which might be an undocumented D-Bus signal sent by
214 hildon-desktop when it starts the application from the menu.
215 But I am not sure and I need to test it on the device, because
216 my scratchbox does not have the application in the menu now.
217 This method shows the main window, so that it can be invisible
218 when started, for instance, just for email searching from
221 * src/maemo/modest-main-window.c: (restore_settings),
222 (modest_main_window_new): Do not show the window immediately
223 upon creation. We show it later.
224 * src/modest-widget-memory.c: (save_settings_paned):
225 Try (unsuccessfully) to avoid saving the paned position when
226 it is not even visible.
227 (restore_settings_paned): Do not allow a silly paned position.
228 This seems necessary when not showing the window at first.
230 * tests/dbus_api/Makefile.am:
231 * tests/dbus_api/test_top_application.c: (main): Test for the
234 2007-07-10 Murray Cumming <murrayc@murrayc.com>
236 * src/modest-ui-dimming-rules.c:
237 (modest_ui_dimming_rules_on_new_msg),
238 (modest_ui_dimming_rules_on_reply_msg),
239 (modest_ui_dimming_rules_on_delete_msg),
240 (modest_ui_dimming_rules_on_details),
241 (modest_ui_dimming_rules_on_view_window_move_to),
242 (modest_ui_dimming_rules_on_view_previous),
243 (modest_ui_dimming_rules_on_view_next),
244 (_invalid_folder_for_purge): Added checks before
245 casting the window. This looks like an actual
246 logic error in _invalid_folder_for_purge(), because it
247 tries to use a ModestMainWindow as a message window.
249 2007-07-10 Murray Cumming <murrayc@murrayc.com>
251 * src/maemo/modest-account-settings-dialog.c:
252 (show_error): Use the same implementation as in
253 modest-easysetup-wizard.c:
254 (on_entry_invalid_character): The logical ID contains a %s.
255 Guessed what it should be.
256 (on_entry_max), (check_data), (on_response): Adapt to
257 changed show_error().
258 (create_page_account_details): Really call
259 modest_validating_entry_set_func() on the correct widgets.
260 * src/maemo/easysetup/modest-easysetup-wizard.c:
261 (on_entry_invalid_character): Fix the logical ID here too.
262 (create_page_account_details),
263 (create_page_user_details):
265 modest_validating_entry_set_func() on the correct widgets.
267 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
268 Do not try to use the account if it is NULL.
270 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
272 * src/modest-ui-actions.c: (create_move_to_dialog),
273 (modest_ui_actions_on_main_window_move_to),
274 (modest_ui_actions_on_msg_view_window_move_to):
275 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
276 (filter_row), (modest_folder_view_show_non_move_folders):
277 * src/widgets/modest-folder-view.h:
279 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
280 the Sent folder yet as it does not report the correct folder type.
282 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
284 * src/maemo/modest-msg-edit-window.c: (init_window):
287 2007-07-10 Murray Cumming <murrayc@murrayc.com>
289 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
290 Take a parent widget instead of a parent window, and
291 implement this with hildon_banner_show_information() instead.
292 Non-Maemo builds can just ifdef that there.
293 This fixed projects.maemo.org bug NB#62766.
295 (on_entry_invalid_character): Use show_error() again instead
296 of using hildon directly, and use the _CS() macro to use the correct
298 (create_account), (check_for_supported_auth_methods), (on_entry_max):
299 Pass a widget instead od a window to show_error().
301 2007-07-10 Murray Cumming <murrayc@murrayc.com>
303 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
304 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
305 This allows us to show the server name in the error message, fixing
306 projects.maemo.org bug NB#62904.
307 Also, use the appropriate logical ID message for the account protocol.
309 2007-07-10 Murray Cumming <murrayc@murrayc.com>
311 * src/modest-tny-account-store.c: (on_idle_wrong_password):
312 A compilation fix, though the build wasn't broken for me.
314 2007-07-09 Murray Cumming <murrayc@murrayc.com>
316 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
317 Do not try to unref a NULL folder store, to avoid a runtime warning.
318 This seems to happen sometimes when changing accounts settings.
320 2007-07-09 Murray Cumming <murrayc@murrayc.com>
322 * src/modest-tny-account-store.c:
323 (modest_tny_account_store_instance_init),
324 (modest_tny_account_store_finalize),
325 (on_account_settings_hide), (on_idle_wrong_password):
326 Use a GHashTable to ensure that we only show one account settings
327 dialog per modest account. This avoids us having a dialog open for
328 both the store and transport accounts, or due to repeated get_password()
329 calls that shouldn't happen anyway.
331 2007-07-09 Murray Cumming <murrayc@murrayc.com>
333 * src/maemo/modest-maemo-utils.c: (on_hide),
334 (modest_maemo_show_dialog_and_forget): Handle the response, because
335 the window is not even hidden by default.
337 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
338 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
339 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
340 which seems to prevent some modality problems.
342 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
343 Ignore user cancellation errors.
345 * src/modest-account-mgr-helpers.h:
346 * src/modest-account-mgr-helpers.c:
347 Added modest_server_account_get_password() and
348 modest_server_account_get_has_password() to avoid direct use of
351 * src/maemo/modest-account-settings-dialog.h:
352 * src/maemo/modest-account-settings-dialog.c:
353 (modest_account_settings_dialog_init): Store the notebook so we can
355 Added modest_account_settings_dialog_switch_to_user_info().
357 * src/modest-tny-account-store.c:
358 (get_password): When the password in the account settings is wrong (we think),
359 show the relevant page of the account settings dialog, in the mainloop.
360 However, we currently get many of these at once because cancel does not
362 (forget_password): Do not forget the password
363 from the account settings, because this causes side-effects when
364 tinymail seems to call it at strange time, maybe because of how we
365 are cancelling get_password().
366 (modest_tny_account_store_alert): Ignore user cancellations.
368 2007-07-09 Murray Cumming <murrayc@murrayc.com>
370 * src/maemo/modest-maemo-utils.h:
371 * src/maemo/modest-maemo-utils.c:
372 Added modest_maemo_show_information_note_and_forget() for use instead of
373 gtk_dialog_run() when the response is not needed, to avoid an extra
374 mainloop which could cause a hang.
376 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
377 Use the logical IDs for the error message, though they are not
378 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
379 because gtk_dialog_run() caused a hang here (the window did not close).
380 This fixes projects.maemo.org bug NB#62646.
382 2007-07-09 Murray Cumming <murrayc@murrayc.com>
384 * src/modest-account-mgr-helpers.h:
385 * src/modest-account-mgr-helpers.c:
386 Added modest_account_mgr_get_store_protocol().
388 * src/maemo/modest-account-view-window.c:
389 (on_delete_button_clicked): Show different warning text depending on
390 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
391 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
394 2007-07-09 Murray Cumming <murrayc@murrayc.com>
396 * src/maemo/modest-msg-edit-window.c:
397 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
398 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
400 2007-07-07 Armin Burgmeier <armin@openismus.com>
402 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
403 ckdg_ib_maximum_characters_reached from correct package.
405 * src/modest-ui-actions.c: Show an error message when a folder could
406 not be created. Tinymail does not give us specific error codes about
407 what has gone wrong, so we assume that a folder with that name
408 already exists, though there might be other reasons.
410 2007-07-06 Murray Cumming <murrayc@murrayc.com>
412 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
413 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
414 give a more exact error message that can be partly translated.
416 2007-07-05 Murray Cumming <murrayc@murrayc.com>
418 * src/maemo/modest-address-book.c:
419 (select_email_addrs_for_contact): Specify a default window size for the
420 select-email-address dialog, so that it is probably big enough for the
421 title. This should fix projects.maemo.org bug NB#62277.
423 2007-07-05 Murray Cumming <murrayc@murrayc.com>
425 * src/maemo/easysetup/modest-easysetup-wizard.c:
426 (create_page_complete_easysetup): Use
427 gtk_widget_set_size() request to ensure that the text wraps
430 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
432 * src/maemo/easysetup/modest-easysetup-wizard.c:
433 (on_entry_invalid_character), (create_page_account_details),
434 (create_page_user_details):
435 Use new API of ModestValidatingEntry. But for some reason the banner is
436 not shown. I will have to investigate that further.
438 * src/widgets/modest-validating-entry.c: (on_insert_text),
439 (modest_validating_entry_set_func):
440 * src/widgets/modest-validating-entry.h:
441 Added a new callback function to be able to react to prevented
442 characters whitespaces to e.g show a banner.
444 2007-07-05 Armin Burgmeier <armin@openismus.com>
446 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
447 notification of HildonNumberEditor instead of remembering the port
448 number. Thanks to Johannes for pointing this out.
450 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
452 * src/maemo/easysetup/modest-easysetup-wizard.c:
453 Check if there are any user changes before showing a confirmation
454 dialog (projects.maemo.org NB#60946)
456 2007-07-05 Armin Burgmeier <armin@openismus.com>
458 * src/maemo/modest-account-settings-dialog.c: Remember custom port
459 number at the beginning of the dialog and set the modified flag at the
460 end if the port number has changed. This is necessary because
461 HildonNumberEditor does not support notification when the value has
464 2007-07-05 Murray Cumming <murrayc@murrayc.com>
466 * src/modest-ui-actions.c:
467 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
468 a connection before asking anything else. Correct the check for the destination
469 folder so that it succeeds when online.
470 This fixed projects.maemo.org bug NB#61645.
472 2007-07-05 Murray Cumming <murrayc@murrayc.com>
474 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
475 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
476 to fix projects.maemo.org bug NB#62439.
478 2007-07-05 Murray Cumming <murrayc@murrayc.com>
480 * src/modest-tny-account.c: (on_connection_status_changed):
481 Really do not use tny_device_force_offline() here. See the previous comment.
483 2007-07-04 Murray Cumming <murrayc@murrayc.com>
485 * src/modest-tny-account.c: (on_connection_status_changed):
486 Do not use tny_device_force_offline() when tinymail says that something
487 went wrong with the connection. It seems to report this unnecessarily.
489 2007-07-04 Murray Cumming <murrayc@murrayc.com>
491 * src/maemo/modest-connection-specific-smtp-window.c:
492 (modest_connection_specific_smtp_window_init):
493 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
494 does not seem to have any effect in osso 1.1 (though it works in
495 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
497 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
499 * src/maemo/modest-connection-specific-smtp-window.c:
500 Fix UI specification problems with projects.meamo.org NB#60479
502 2007-07-04 Murray Cumming <murrayc@murrayc.com>
504 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
505 clue when this has failed, because the error dialog is not always shown
506 (at least in earlier version).
508 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
509 GError message, because the generic error dialog is not helpful.
511 'This message is not currently available (can't let a new connection go online)'
512 when trying to open an IMAP message.
514 (_modest_ui_actions_open): Offer a connection when some messages would
515 have to be downloaded and we are offline.
517 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
519 * src/widgets/modest-folder-view.c:
520 Don't check for MERGE type anymore as we use the correct type
522 NOTE: For the last two changes you need to update your tinymail copy
523 because of API changes!
525 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
527 * src/modest-tny-local-folders-account.c:
528 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
529 (see projects.maemo.org NB#61580)
531 2007-07-04 Murray Cumming <murrayc@murrayc.com>
533 * src/modest-tny-account.c: (on_connection_status_changed):
534 Commented out the call to modest_platform_connect_and_wait() because this
535 seems to always hang, and I would like to know if this is the only thing
536 that causes a hang when showing the connection dialog.
537 It is not very useful anyway.
539 2007-07-04 Murray Cumming <murrayc@murrayc.com>
541 * src/maemo/modest-msg-view-window.c:
542 (modest_msg_view_window_select_next_message):
544 * src/modest-platform.h:
545 * src/maemo/modest-platform.c:
546 Added modest_platform_connect_and_wait(), which calls
547 tny_maemo_conic_device_connect() always in the main thread, by calling it
548 in an idle handler and waiting for the idle handler to run. It should be
549 in the main thread because it uses GTK+ UI code. It just returns TRUE
550 if the device is already online.
552 There is some nasty code to ensure that subsequent calls to
553 modest_platform_connect_and_wait() just wait for the first one to finish,
554 by checking repeatedly in another idle handler. This is necessary,
555 because other threads (or even the main thread, via another idle handler)
556 can call modest_platform_connect_and_wait() while
557 modest_platform_connect_and_wait() is running.
559 (modest_platform_connect_and_wait_if_network_account),
560 (modest_platform_connect_and_wait_if_network_folderstore):
561 Convenience functions that calls modest_platform_connect_and_wait() if
562 the account or folder might want network access.
564 * src/modest-mail-operation.c:
565 (modest_mail_operation_update_account):
566 * src/modest-ui-actions.c: (download_uncached_messages),
567 (modest_ui_actions_on_rename_folder), (delete_folder),
568 (modest_ui_actions_on_main_window_move_to),
569 (modest_ui_actions_on_msg_view_window_move_to):
570 * src/widgets/modest-folder-view.c:
571 (drag_and_drop_from_folder_view):
572 Offer a connection if we are offline.
574 * src/modest-tny-account.c: (on_connection_status_changed):
575 Document this as only handling errors during network operations in progress,
576 and replace the idle code with a simple call to
577 modest_platform_connect_and_wait(), which does this instead.
579 2007-07-03 Murray Cumming <murrayc@murrayc.com>
581 * src/modest-tny-account.c:
582 (modest_tny_account_get_special_folder): (util_on_idle),
583 Handle the GError so we can see when tny_folder_store_get_folders()
584 fails, as it currently does while something else is connecting.
586 Added util_run_in_main_thread_and_wait()
587 which uses an idlen handler and mainloop to ensure that the function
588 is called in the main thread.
589 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
590 to make sure that we call attempt the connection in the mainloop only,
591 which might solve some hangs.
593 2007-07-03 Murray Cumming <murrayc@murrayc.com>
595 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
596 be found by their display name. This is never useful.
597 * src/modest-tny-account-store.c: (on_account_removed): Find the account
598 by its ID, instead of trying to use its ID as its display name.
600 * src/modest-tny-account-store.h:
601 * src/modest-tny-account.c:
602 (modest_tny_account_get_special_folder): Add a g_warning() when
603 tny_folder_store_get_folders() returns an empty list for the maildir.
605 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
606 Add a g_warning() when this returns NULL, because that it not allowed
609 2007-07-02 Armin Burgmeier <armin@openismus.com>
611 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
612 note when trying to cancel the wizard. This fixes projects.maemo.org
615 2007-07-02 Murray Cumming <murrayc@murrayc.com>
617 * src/modest-tny-account.h:
618 * src/modest-tny-account.c:
619 (modest_tny_account_new_from_server_account),
620 (modest_tny_account_new_from_server_account_name),
621 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
622 because this must now be set before setting the proto. This is usd in
623 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
624 warning in camel_session_get_service() caused by
625 tny_camel_transport_account_prepare().
627 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
630 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
632 * src/maemo/modest-connection-specific-smtp-edit-window.c:
634 (modest_connection_specific_smtp_edit_window_init):
636 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
639 2007-06-29 Murray Cumming <murrayc@murrayc.com>
641 * src/modest-tny-account.c:
642 (modest_tny_account_new_from_server_account):
643 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
644 now uses to request a connection when it needs one, and which it uses
645 to tell us that something is wrong with the connection, so we can force
646 the accounts offline to prevent further problems.
649 * src/modest-init.c: (init_default_settings):
650 * src/modest-mail-operation.c:
651 (modest_mail_operation_update_account):
652 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
653 This should not be necessary anymore. Do not set the conf key that
654 determined this (it was always TRUE and not set anywhere else).
656 * src/modest-ui-actions.h: Remove unused and unimplemented
657 modest_ui_actions_on_online_toggle_toggled().
659 2007-06-29 Murray Cumming <murrayc@murrayc.com
661 * src/maemo/modest-main-window.c: (connect_signals):
662 Don't connect to delete_event twice. Maybe this was harmless.
664 2007-06-29 Murray Cumming <murrayc@murrayc.com
666 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
667 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
668 Debug output to give some more clue when a folder move is not allowed.
670 2007-06-28 Murray Cumming <murrayc@murrayc.com
672 * src/modest-tny-account.c: (on_modest_file_system_info),
673 (modest_tny_account_get_mmc_account_name):
674 Always call the callback, without checking whether the name has changed.
675 * src/widgets/modest-folder-view.c: (strings_are_equal),
676 (on_model_foreach_set_name), (on_get_mmc_account_name),
677 (text_cell_data): Compare the name here, and use the name from
678 the account rather than from the
679 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
680 if the name was changed after the account was added to the model.
681 That's a tinymail bug but not one that I want to fix now.
683 This finally fixes projects.maemo.org bug NB#59301.
685 2007-06-27 Armin Burgmeier <armin@openismus.com>
687 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
690 2007-06-27 Murray Cumming <murrayc@murrayc.com
692 * src/modest-tny-account.h:
693 * src/modest-tny-account.c:
694 Added modest_tny_account_get_mmc_account_name(), to set the memory
695 card name asynchronously for the given account and then notify.
696 (modest_tny_account_new_for_local_folders): Use this new function instead
697 of using hildon_file_system_info_async_new() directly.
699 * src/widgets/modest-folder-view.c: (text_cell_data):
700 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
701 gtk_tree_model_row_changed() when it is available.
703 This should fix projects.maemo.org bug NB#59301.
705 2007-06-27 Murray Cumming <murrayc@murrayc.com
707 * src/modest-mail-operation.c: (update_account_thread),
708 (get_msgs_full_thread): Fix typo failures in the revert
711 2007-06-27 Murray Cumming <murrayc@murrayc.com
713 * src/maemo/modest-maemo-global-settings-dialog.c:
714 (idle_select_default_focus):
715 * src/modest-mail-operation.c: (idle_notify_progress),
716 (idle_notify_progress_once), (set_last_updated_idle),
717 (update_account_thread), (get_msgs_full_thread):
718 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
719 * src/widgets/modest-header-view.c:
720 (idle_notify_headers_count_changed_destroy),
721 (idle_notify_headers_count_changed):
722 Reverted the additions of gdk_threads_enter/leave(), in case this
723 helps with a startup hang on the device.
725 2007-06-26 Armin Burgmeier <armin@openismus.com>
727 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
728 for supported secure authentication methods from server by
729 gtk_dialog_run(), saving CPU time and a potential race condition.
731 2007-06-26 Armin Burgmeier <armin@openismus.com>
733 * src/maemo/modest-maemo-utils.h:
734 * src/maemo/modest-maemo-utils.c: Added a
735 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
736 only error code to tell the calling code when the user canceled the
739 * src/maemo/modest-account-settings-dialog.h:
740 * src/maemo/modest-account-settings-dialog.c:
741 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
742 message if the retrieval of secure authentication methods was canceled
743 by the user. Perform the check before saving anything to configuration
744 to not end up with half-committed configuration changes, do not show
745 a "Saving to configuration failed" note when authentication methods
746 could not be retrieved.
748 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
751 2007-06-26 Murray Cumming <murrayc@murrayc.com>
753 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
754 Only return the first level of folders under accounts, because the
755 osso-global-search UI spec doesn't want the rest.
756 This fixed projects.maemo.org bug NB#61811.
758 2007-06-26 Murray Cumming <murrayc@murrayc.com>
760 * src/modest-tny-account-store.c:
761 * src/modest-tny-account-store.h:
762 Added modest_tny_account_is_memory_card_account().
763 * src/maemo/modest-main-window.c: (create_details_widget):
764 Show the same information items for the memory card as we show for the
765 local-folders, to fix projects.maemo.org bug NB#59307.
767 2007-06-26 Murray Cumming <murrayc@murrayc.com>
769 * src/modest-tny-account-store.c: (get_password):
770 Added some checks for NULL to maybe prevent crashes, though I think
771 it was Philip's last commit that actually prevented the crash here
772 when creating a first new account.
773 But the new account is still not usable (no messages are shown)
774 until a restart of the application.
776 2007-06-26 Murray Cumming <murrayc@murrayc.com>
778 * src/maemo/modest-maemo-global-settings-dialog.c:
779 (idle_select_default_focus):
780 * src/modest-mail-operation.c: (idle_notify_progress),
781 (idle_notify_progress_once), (idle_notify_update_account_queue),
782 (set_last_updated_idle), (update_account_thread),
783 (notify_get_msgs_full), (get_msgs_full_destroyer),
784 (get_msgs_full_thread):
785 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
786 * src/widgets/modest-header-view.c:
787 (idle_notify_headers_count_changed_destroy),
788 (idle_notify_headers_count_changed):
789 Use gdk_threads_enter() and gdk_threads_enter_leave() in
790 all idle handlers, because some other thread could be blocking
791 the GDK lock, so that it can do GUI stuff.
793 2007-06-26 Murray Cumming <murrayc@murrayc.com>
795 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
796 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
797 (on_idle_send_receive), (on_idle_open_default_inbox):
798 * src/maemo/modest-msg-edit-window.c:
799 (modest_msg_edit_window_attach_file_noninteractive):
800 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
801 to prevent a hang. I don't quite understand why these are necessary,
802 beause we should already be in the main loop. I guess something outside
803 of the main loop is taking the lock.
805 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
806 we are really using URIs, and use files that are more likely to exist.
808 2007-06-26 Murray Cumming <murrayc@murrayc.com>
810 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
811 necessary because configure.ac now defines different variables.
813 2007-06-26 Murray Cumming <murrayc@murrayc.com>
815 * libmodest-dbus-client/libmodest-dbus-client.c:
816 * libmodest-dbus-client/libmodest-dbus-client.h:
817 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
818 libmodest_dbus_client_compose_mail() is what things actually use.
820 * src/dbus_api/modest-dbus-api.h:
821 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
822 * tests/dbus_api/Makefile.am:
823 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
826 2007-06-26 Murray Cumming <murrayc@murrayc.com>
828 * src/modest-init.c: (modest_init_local_folders):
829 For memory-card (or other non local-folders) maildir accounts,
830 always create an Archive folder, so that there is somewhere to put
831 messages. This should be less confusing, because the user does not need
832 to guess that the need to create a folder.
834 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
836 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
837 Fixed icon size by using (50, 50) which is the same as defined by
840 2007-06-25 Armin Burgmeier <armin@openismus.com>
842 * src/widgets/modest-window-mgr.c:
844 * configure.ac: Correctly recognize hildon-notify presence and fixed
845 the build without it being installed.
847 2007-06-25 Murray Cumming <murrayc@murrayc.com>
849 * libmodest-dbus-client/libmodest-dbus-client.c:
850 (libmodest_dbus_client_search): Fix the build. Sorry.
851 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
852 (reply_forward_cb): Initialize variables to fix the build.
854 * src/modest-tny-account-store.c:
855 (modest_tny_account_store_get_tny_account_by): Fix the account URI
856 comparison (a silly typo) so that email search results can be opened
857 when there are more than one account.
859 2007-06-25 Murray Cumming <murrayc@murrayc.com>
861 * libmodest-dbus-client/libmodest-dbus-client.c:
862 (libmodest_dbus_client_search),
863 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
864 instead of 1 second, because the search gets folders and messages from
865 the server, which can take a long time. When it times out,
866 osso-global-search will report no results.
868 We need to specify whether we should search only cached information
869 (maybe with a user preference), and the osso-email-search-plugin
870 API should really be improved to allow that option, and to allow results
871 to be delivered asynchronously in batches.
873 2007-06-25 Murray Cumming <murrayc@murrayc.com>
875 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
876 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
877 GTK_ICON_SIZE_DIALOG is probably the wrong size.
879 2007-06-25 Murray Cumming <murrayc@murrayc.com>
881 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
882 that is an empty string. D-Bus seems to give us these instead of NULL.
884 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
886 * src/dbus_api/modest-dbus-callbacks.c:
887 * src/maemo/easysetup/modest-easysetup-wizard.h:
888 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
889 * src/maemo/modest-connection-specific-smtp-edit-window.c:
890 (modest_connection_specific_smtp_edit_window_init):
891 * src/maemo/modest-maemo-global-settings-dialog.c:
893 * src/maemo/modest-maemo-utils.c:
894 (modest_maemo_utils_setup_images_filechooser):
895 * src/maemo/modest-main-window.c: (create_details_widget):
896 * src/maemo/modest-msg-edit-window.c:
897 (modest_msg_edit_window_attach_file_noninteractive),
898 (modest_msg_edit_window_color_button_change),
899 (modest_msg_edit_window_set_zoom):
900 * src/modest-mail-operation.c: (update_account_thread):
901 * src/modest-tny-account-store.c:
902 * src/modest-tny-account.c:
903 * src/widgets/modest-global-settings-dialog.c:
904 * src/widgets/modest-window.h:
908 2007-06-25 Murray Cumming <murrayc@murrayc.com>
910 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
911 * src/modest-search.c: (modest_search_folder),
912 (modest_search_all_accounts): Actually search only in the specified folder,
913 doing a simple match on the folder ID.
914 * src/modest-search.h: Added a folder field to the ModestSearch struct,
915 and added some documentation.
917 2007-06-22 Armin Burgmeier <armin@openismus.com>
919 * src/maemo/modest-maemo-utils.h:
920 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
921 modest_maemo_utils_get_supported_secure_authentication_methods.
923 * src/maemo/easysetup/modest-easysetup-wizard.c:
924 * src/maemo/modest-account-settings-dialog.c: Show correct error if
925 one occured, not just "Server does not support secure authentication".
927 2007-06-22 Murray Cumming <murrayc@murrayc.com>
929 * src/modest-tny-account-store.c: (get_password):
930 Restored the call to tny_account_set_user() because Philip seems to have
931 stopped this from crashing (by not using the freed string). It still does
932 not work, but now we can test it.
934 2007-06-22 Murray Cumming <murrayc@murrayc.com>
936 * src/maemo/modest-msg-edit-window.c: (init_window):
937 Comment out use of an uninitialzed GtkScrolledWindow variable,
938 to fix the build and stop a crash. Yet again.
940 2007-06-22 Murray Cumming <murrayc@murrayc.com>
942 * src/modest-tny-account-store.c: (get_password):
943 Remove the call to tny_account_set_user() because this actually crashes.
944 As mentioned in the last commit, it is known to not work anyway.
946 2007-06-22 Murray Cumming <murrayc@murrayc.com>
948 * src/modest-tny-account-store.c: (get_password):
949 Use tny_account_set_username() to tell tinymail that the username might
950 have changed too. But tinymail ignores this: see projects.maemo.org
952 * src/modest-ui-actions.c:
953 (modest_ui_actions_on_password_requested): Remove the useless attempt to
954 reset the connection when changing the username, and improve the comments.
955 Save the changed username to gconf at least, so it is used when Modest is
958 2007-06-21 Murray Cumming <murrayc@murrayc.com>
960 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
961 Do not use a query, so that we get all folders, including for POP and
962 local-folders. They work as search criteria too.
963 This fixes projects.maemo.org bug NB#57740.
965 2007-06-21 Murray Cumming <murrayc@murrayc.com>
967 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
968 Comment out the use of hildon_notification_set_sound() because it is
969 not declared, to fix the build. Warnings are serious, people.
971 2007-06-21 Armin Burgmeier <armin@openismus.com>
973 * src/maemo/modest-maemo-utils.h:
974 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
975 modest_maemo_utils_get_supported_secure_authentication_methods()
976 to query authentication methods for a specific user. This should fix
977 projects.maemo.org bug NB#61369.
979 * src/maemo/easysetup/modest-easysetup-wizard.c:
980 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
983 2007-06-21 Murray Cumming <murrayc@murrayc.com>
985 * libmodest-dbus-client/libmodest-dbus-client.h:
986 * libmodest-dbus-client/libmodest-dbus-client.c:
987 (modest_dbus_message_iter_get_search_hit),
988 (libmodest_dbus_client_search):
989 Reorganised and commented this.
990 Removed modest_search_hit_free() from the public API because it
993 Added libmodest_dbus_client_get_folders() and
994 modest_folder_result_list_free().
996 * src/dbus_api/modest-dbus-api.h:
997 * src/dbus_api/modest-dbus-callbacks.c:
998 (modest_dbus_req_filter): Commented. Moved most code to
999 on_dbus_method_search() and added on_dbus_method_get_folders().
1001 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1002 of the extra D-Bus handler.
1004 * tests/dbus_api/Makefile.am:
1005 * tests/dbus_api/test_get_folders.c: New test for
1006 libmodest_dbus_client_get_folders(). This seems to return an empty list
1007 at the moment. That could be the same error that causes the message list
1008 to be empty sometimes.
1009 This should help with projects.maemo.org bug NB#57740.
1011 2007-06-21 Armin Burgmeier <armin@openismus.com>
1013 * src/modest-mail-operation.c: Do not call
1014 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1015 notify the operation's end after having set the status to CANCELED for
1016 the operation queue to listen on. This fixes a deadlock when there
1017 were mail operations in the queue during its finalization.
1019 * src/modest-singletons.c: Reordered uninitialization of the account
1020 manager to happen after the mail operation queue was uninitialized
1021 because the mail operation's in the queue might still try to access
1022 the account manager (see modest_mail_operation_notify_end()). This
1023 fixes a potential crash when terminating the application.
1025 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1027 * src/modest-search.c:
1028 (search_mime_part_and_child_parts): Moved some code here so we
1029 can search recursively in child folders.
1030 (modest_search_folder): Search in the message as a mime part, instead
1031 of just its child mime parts.
1032 (read_chunk), (search_mime_part_ogs):
1033 Check how many bytes were read, to prevent an endless loop.
1034 Searching in message bodies now works. This finishes the fix for
1035 projects.maemo.org bug NB#61007.
1037 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1039 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1040 Add a g_warning when the item is not a folder.
1042 * src/modest-ui-dimming-rules.c:
1043 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1044 when selected item is not a folder (for instance, an account), because
1045 the UI spec only talks about folders.
1046 I am not sure what the UI spec wants, so this might not totally fix
1047 projects.maemo.org bug NB#60794.
1049 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1051 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1052 (load_from_file): Sort the list. The unsorted list would be more noticeable
1053 in non-English locales.
1055 * src/maemo/modest-msg-edit-window.c:
1056 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1057 warning and fix the build.
1059 * src/maemo/modest-progress-bar-widget.c:
1060 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1061 avoid a g_warning, and probably to avoid a crash.
1063 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1065 * src/modest-search.c: (modest_search_folder): Check for a GError
1066 when calling tny_folder_get_headers(), to show that this is not the cause
1069 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1071 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1072 Actually set the body query instead of the subject query.
1074 * src/modest-search.c: (search_mime_part_ogs),
1075 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1076 which would probably cause it to fail if we got this far.
1078 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1079 to simplify the code.
1080 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1081 be causing search-in-body to fail.
1083 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1085 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1087 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1088 Better debug message when the folder cannot be found.
1089 This should help with fixing projects.maemo.org bug #61287.
1090 * src/modest-search.c: (add_hit): Do not leak the furl string.
1092 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1094 * src/modest-ui-actions.c:
1095 (modest_ui_actions_on_folder_selection_changed):
1096 Do not special-case TNY_MERGE_FOLDER here, because
1097 modest_tny_folder_get_account() already does that. This fixes
1098 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1099 shown when the Outbox was selected).
1101 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1103 * libmodest-dbus-client/libmodest-dbus-client.c:
1104 (_dbus_iter_get_string_or_null): Initialize the string variable in
1105 case this helps with Dirk's crash.
1107 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1109 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1110 though it is not implemented yet (this function is maybe not even used),
1111 to avoid breaking ABI in future.
1112 * libmodest-dbus-client/libmodest-dbus-client.c:
1113 (get_attachments_string): Moved some code into this generic function.
1114 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1115 sends email. It is maybe not used.
1116 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1117 (on_send_mail): Use attachments.
1119 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1120 * src/maemo/modest-msg-edit-window.c:
1121 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1122 a filename before using it, to fix projects.maemo.org bug NB#58233.
1124 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1126 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1127 Initialize the continue_download variable to fix the build, and probably
1128 to fix randome behaviour.
1130 2007-06-18 Armin Burgmeier <armin@openismus.com>
1132 * src/modest-tny-send-queue.h:
1133 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1134 the queue so we can later show it in the UI. Replaced
1135 modest_tny_send_queue_msg_is_being_sent() by
1136 modest_tny_send_queue_get_msg_status().
1138 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1140 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1141 gpointer. This probably was not harmful, but just to be sure.
1143 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1145 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1146 Fix the build, but leave the function broken on Bora, because
1147 hildon_uri_action_get_service() does not exist.
1148 osso_uri_action_get_service() does not exist either, it seems.
1150 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1152 * src/modest-tny-account.c:
1153 (modest_tny_account_new_from_server_account):
1154 Uncommented the url debug output again, because it is useful for
1155 debugging, as I said in the comment.
1157 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1159 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1161 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1162 for Mameo Bora, to fix the build.
1164 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1167 Fixed build with hildon < 0.99
1169 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1170 Check if the selected account is busy instead of checking all accounts
1172 * src/modest-account-mgr-priv.h:
1173 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1174 (modest_account_mgr_init), (compare_account_name),
1175 (modest_account_mgr_set_account_busy),
1176 (modest_account_mgr_account_is_busy):
1177 * src/modest-account-mgr.h:
1178 Added busy information to the account manager. It possible to
1179 set an account to busy or not busy now.
1181 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1182 (modest_mail_operation_update_account),
1183 (modest_mail_operation_notify_end):
1184 Set the account to busy/not busy depending on the operation state.
1186 * src/widgets/modest-account-view.c:
1187 (modest_account_view_finalize), (get_last_updated_string),
1188 (update_account_view), (on_account_busy_changed), (init_view):
1189 Show string "Refreshing..." if the account is currently busy.
1191 All this fixes projects.maemo.org bug NB#59711
1193 2007-06-14 Armin Burgmeier <armin@openismus.com>
1195 * src/widgets/modest-attachments-view.h:
1196 * src/widgets/modest-attachments-view.c: Added
1197 modest_attachments_view_has_attachments() and fixed coordinate
1198 transformation in get_att_view_at_coords(). This fixes attachment
1201 * src/widgets/modest-msg-view.c: Make use of
1202 modest_attachments_view_has_attachments() to decide whether to show
1203 attachments in the header.
1205 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1207 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1208 (on_change), (on_combo_security_changed),
1209 (modest_connection_specific_smtp_edit_window_init),
1210 (modest_connection_specific_smtp_edit_window_set_connection),
1211 (modest_connection_specific_smtp_edit_window_is_dirty):
1212 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1213 * src/maemo/modest-connection-specific-smtp-window.c:
1216 Show an comfirmation dialog for the smpt-edit-window if there are
1217 unsaved changes and the user hits cancel.
1218 (projects.maemo.org bug NB#60479)
1220 2007-06-14 Armin Burgmeier <armin@openismus.com>
1222 * src/maemo/easysetup/modest-easysetup-wizard.c:
1223 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1224 address" info in banner instead of node, and select all the text as
1225 per UI spec. This fixes projects.maemo.org bug NB#60550.
1227 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1229 reviewed by: <delete if not using a buddy>
1231 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1232 * src/modest-ui-actions.c: (folder_refreshed_cb):
1234 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1236 * src/widgets/modest-folder-view.c: (filter_row):
1237 Explictly filter out the per-account outbox accounts. I don't know why
1238 these only sometimes show up, but now they should never show up in the UI.
1239 This should fix projects.maemo.org bug NB#60160.
1241 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1243 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1244 when the toolbar does not exist yet.
1245 * src/modest-widget-memory.c: (save_settings_header_view):
1246 Added g_warnings() to help us to discover when we are trying to set
1247 an empty columns list in gconf.
1249 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1251 * src/modest-init.h:
1252 * src/modest-init.c:
1253 Added modest_init_get_default_header_view_column_ids().
1255 * src/modest-widget-memory.c: (restore_settings_header_view):
1256 Use the new function to get defaults, if the gconf key is empty,
1257 instead of not creating any columns. This seems to fix the
1258 empty right-hand pane problems.
1260 * src/widgets/modest-header-view.h: Improved documentation.
1262 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1264 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1265 Revert the use of the display name as the account name, because this
1266 is generally wrong and would break the code that follows.
1268 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1270 * src/maemo/easysetup/modest-easysetup-wizard.c:
1271 (check_for_supported_auth_methods), (on_before_next),
1274 More correct fix for projects.maemo.org bug NB# 58991
1275 Do not longer accept AUTH_PASSWORD as secure method and choose
1276 correct method when creating the account.
1278 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1280 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1281 Fixed projects.maemo.org bug NB# 58991
1283 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1285 * src/modest-init.c: (modest_init_init_core),
1286 (modest_init_local_folders): Fixed compilation errors.
1288 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1290 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1291 Remove unnecessary lib/include, though it is good in principle when needed.
1293 * src/modest-init.c: (modest_init_one_local_folder),
1294 (modest_init_local_folders):
1295 * src/modest-init.h: Initialize the .modest library for memory cards,
1296 instead of just doing nothing for them. This should allow us to create
1297 folders there, fixing projects.maemo.org bug NB#59297.
1299 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1301 * libmodest-dbus-client/libmodest-dbus-client.c:
1302 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1303 (libmodest_dbus_client_compose_mail),
1304 (libmodest_dbus_client_open_message),
1305 (libmodest_dbus_client_send_and_receive),
1306 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1308 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1309 (on_idle_open_message), (modest_dbus_req_handler),
1310 (search_result_to_message), (modest_dbus_req_filter):
1311 * src/modest-search.c: (add_hit), (modest_search_folder),
1312 (modest_search_all_accounts): Improved debug messages.
1314 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1316 * src/modest-tny-account-store.c:
1317 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1320 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1323 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1325 * src/modest-tny-account-store.c: (get_server_accounts):
1326 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1327 even when there are no accounts, so that the Outbox folder is always
1328 visible. This fixes projects.maemo.org bug NB#60158.
1330 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1332 * src/maemo/modest-main-window.c: (create_details_widget):
1333 Use the mcen_va_never logical ID.
1335 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1337 * src/dbus_api/modest-dbus-api.h:
1338 * src/dbus_api/modest-dbus-callbacks.c:
1339 (on_idle_open_default_inbox), (on_open_default_inbox),
1340 (modest_dbus_req_handler):
1341 Added a new OpenDefaultInbox method.
1343 * libmodest-dbus-client/libmodest-dbus-client.h:
1344 * libmodest-dbus-client/libmodest-dbus-client.c:
1345 Added libmodest_dbus_client_open_default_inbox() to call the new
1346 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1347 though it should maybe be used by a new osso-email-interface function.
1349 * tests/dbus_api/Makefile.am:
1350 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1353 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1355 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1356 NULL, so that the signals get all the keys. This should not actually
1357 change any behaviour because we currently update everything when anything
1360 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1362 * src/widgets/modest-folder-view.c: (text_cell_data),
1363 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1364 (find_inbox_iter): If tinymail tells us that the folder is
1365 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1366 This causes the inbox to be selected at startup, fixing part of
1367 projects.maemo.org bug NB#56305.
1369 * src/modest-ui-dimming-rules.c:
1370 (modest_ui_dimming_rules_on_tools_smtp_servers):
1371 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1372 the SMTP servers menu item.
1373 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1374 that the SMTP Servers menu item is dimmed when there are no accounts,
1375 as a future version of the UI spec will require. This fixes
1376 projects.maemo.org bug NB#56305.
1378 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1380 * src/maemo/modest-maemo-utils.c:
1381 (modest_maemo_utils_get_supported_secure_authentication_methods):
1382 Added label to dialog instead of unreadable title
1384 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1385 (modest_main_window_new):
1386 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1389 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1390 * src/modest-account-mgr.h:
1391 Added method to avoid code duplication
1393 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1394 (modest_ui_actions_on_send_receive):
1395 Use modest_account_mgr_has_accounts
1397 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1399 * src/maemo/easysetup/modest-presets.c:
1400 (modest_presets_get_info_server_security): Do not report secure auth
1402 * src/modest-protocol-info.c: Use the defines for the gconf key names
1403 for secure authentication. This was not working because we were writing
1404 Password and reading password, and the check was case sensitive.
1405 With this, gmail now works for receiving and sending when created via
1408 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1410 * src/maemo/easysetup/modest-presets.c:
1411 (modest_presets_get_info_server_security): Correct the key name for
1412 SecureSmtp, because it seems to be case-sensitive.
1413 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1414 Do not try to get the 0th notebook page if there are 0 pages, to
1415 avoid a g_warning().
1417 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1419 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1420 Prevent use of the new notification feature for now, because it currently
1421 shows one dialog for each new email, which is annoying.
1423 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1425 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1426 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1427 when no country was selected, so that we show the global ones.
1428 * src/maemo/easysetup/modest-presets.c:
1429 (modest_presets_get_providers): Return only the global providers, not
1430 all providers when mmc=0 was requested.
1432 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1434 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1435 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1436 provider ID in the combo.
1438 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1439 Do not show the page numbers, because it would be confusing when we add
1440 the 2 extra pages for the custom setup, when the user chooses the "Other"
1441 provider. This fixes projects.maemo.org bug NB#59028
1443 * src/modest-init.c: (modest_init_init_core),
1444 (modest_init_local_folders):
1445 * src/modest-init.h:
1446 * src/modest-tny-account.c:
1447 (modest_tny_account_new_for_local_folders): Do not create default folders
1448 for the memory card. This should fix projects.maemo.org bug NB#59328.
1450 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1452 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1453 Free the changed_conf_keys string items. They are already freed in the
1454 idle handler if that runs first.
1456 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1458 * src/modest-ui-actions.c:
1459 (modest_ui_actions_on_password_requested): Check that the server name
1460 is not NULL, because I just saw a password dialog with (null) as the
1463 * src/modest-tny-folder.[h|c]: Added
1464 modest_tny_folder_is_memory_card_folder().
1465 * src/modest-ui-dimming-rules.c:
1466 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1467 menu item for memory cards, as per the UI spec (section 7.4). This should
1468 fix projects.maemo.org bug NB#59297.
1470 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1472 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1473 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1474 is another problem with the code, see Murray's comment at line 772)
1476 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1478 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1479 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1480 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1481 (load_from_file), (easysetup_country_combo_box_init),
1482 (easysetup_country_combo_box_get_active_country_ids),
1483 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1484 instead of just one ID, to avoid duplicate country names in the UI.
1486 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1487 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1488 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1489 a single ID, avoiding duplicate providers.
1490 * src/maemo/easysetup/modest-easysetup-wizard.c:
1491 (on_combo_account_country): Adapt to use a list.
1493 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1495 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1496 keys changed in the last X seconds.
1498 * src/modest-account-mgr.h:
1499 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1500 (on_key_change), (modest_account_mgr_class_init),
1501 (modest_account_mgr_init), (modest_account_mgr_finalize):
1502 As the keys are changed, save them in a GSList* and signal that GSList*
1503 further every X seconds, to batch changes, to allow us to do just one
1504 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1505 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1507 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1508 changed signal signature.
1510 * src/modest-conf.c: (modest_conf_set_list),
1511 (modest_conf_on_change): Reenable notification.
1513 (modest_conf_maemo_fake_on_change): Comment out the hack that
1514 notified immediately instead of asynchronously.
1516 * src/widgets/modest-account-view.h:
1517 * src/widgets/modest-account-view.c:
1518 (update_account_view): Select the previously-selected account ID,
1519 if possible. This fixes projects.maemo.org bug NB#56933.
1521 (on_account_changed), (on_account_removed),
1522 (modest_account_view_select_account):
1524 Remove the block/unblock functions
1525 because they were not useful.
1527 * src/maemo/modest-account-view-window.c:
1528 (on_delete_button_clicked), (on_edit_button_clicked),
1529 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1531 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1533 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1534 Improve the error dialog to show Incorrect Account Settings, which seems
1535 clearer, and say that the internal error message (to be removed from the
1536 dialog later) is often misleading.
1537 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1539 * src/modest-tny-account.c:
1540 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1541 URL because this is so useful for debugging on the device.
1543 * src/widgets/modest-serversecurity-combo-box.c:
1544 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1546 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1548 * src/modest-mail-operation.c:
1549 (modest_mail_operation_send_new_mail):
1550 Added a comment about a nasty but apparently harmless message. Details
1551 added to the wiki g_warnings() page.
1553 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1555 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1556 (modest_tny_send_queue_class_init):
1557 Do not use the priv struct because it is empty, to avoid g_warnings
1558 about a non-existant priv struct.
1560 * src/modest-tny-account-store.c:
1561 (modest_tny_account_store_get_server_account),
1562 (modest_tny_account_store_get_transport_account_for_open_connection
1563 ): Do not try to get transport server accounts for local folders,
1564 because they don't have any. This avoids a g_warning().
1566 * src/maemo/modest-main-window.c:
1567 (modest_main_window_notify_send_receive_initied),
1568 (on_configuration_key_changed):
1569 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1570 * src/modest-defs.h:
1571 * src/modest-mail-operation.c:
1572 (modest_mail_operation_update_account):
1573 * src/modest-tny-account-store.h:
1574 * src/modest-tny-account.c:
1575 (modest_tny_account_get_special_folder),
1576 (modest_tny_account_new_for_local_folders),
1577 (modest_tny_account_new_for_per_account_local_outbox_folder):
1578 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1579 * src/modest-tny-local-folders-account.c:
1580 (add_account_folders_to_merged_folder):
1581 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1582 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1583 (modest_ui_actions_on_send):
1584 * src/widgets/modest-folder-view.c: (update_model):
1585 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1586 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1587 modest_tny_account_store_get_tny_account_by_account() to
1588 modest_tny_account_store_get_server_account() to make the code clearer.
1590 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1592 * src/dbus_api/modest-dbus-api.h:
1593 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1594 * src/maemo/modest-msg-edit-window.c:
1595 (modest_msg_edit_window_attach_file_noninteractive):
1596 added g_warning in case the file to be attached does not exist
1597 * tests/dbus_api/test_compose_mail.c: (main):
1598 removed obsolete comment, added generic files as test case
1600 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1602 * src/modest-tny-account-store.c: (get_server_accounts):
1603 Create the local folders account only once, not once for each outbox, and
1604 not only when there are some outboxes.
1606 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1608 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1609 code that is causing a crash at startup. Sergio says that he is fixing this.
1611 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1613 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1614 * src/maemo/modest-account-settings-dialog.c:
1615 (create_page_outgoing),
1616 (modest_account_settings_dialog_set_account_name),
1617 (save_configuration):
1618 - Fixed handling of the "Use secure authentication" toggle to comply with
1619 the ui specification. See also projects.maemo.org bug NB#58400
1621 - Restore the Secure connection setting combo correctly when loading
1624 * src/maemo/modest-maemo-utils.c:
1625 (on_camel_account_get_supported_secure_authentication),
1626 (modest_maemo_utils_get_supported_secure_authentication_methods):
1627 Fixed a crasher if operation is canceled
1629 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1630 (modest_protocol_info_auth_is_secure):
1631 * src/modest-protocol-info.h:
1633 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1634 the sense of the "Use secure authentication" toggle.
1636 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1638 * src/modest-tny-account-store.h:
1639 * src/modest-tny-account-store.c:
1640 Added modest_tny_account_store_get_local_folders_account().
1642 * src/modest-tny-folder.h:
1643 * src/modest-tny-folder.c:
1644 (modest_tny_folder_get_account):
1645 Added this replacement for tny_folder_get_account() which returns
1646 the local-folders account for TnyMergeFolders, to avoid the
1647 warning about the unimplemented get_account_func() vfunc().
1649 (modest_tny_folder_get_rules),
1650 * src/modest-ui-actions.c:
1651 (modest_ui_actions_on_folder_selection_changed):
1652 * src/modest-mail-operation.c:
1653 (modest_mail_operation_remove_folder),
1654 (modest_mail_operation_xfer_folder),
1655 (modest_mail_operation_rename_folder),
1656 (modest_mail_operation_get_msg),
1657 (modest_mail_operation_get_msgs_full),
1658 (modest_mail_operation_remove_msg),
1659 (modest_mail_operation_xfer_msgs),
1660 (modest_mail_operation_refresh_folder):
1661 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1663 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1665 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1666 (modest_server_account_set_security):
1667 * src/modest-defs.h: Add comments explaining that our
1668 UI spec means TLS when it says Normal, so these do not look like errors.
1670 * src/modest-tny-account.c:
1671 (modest_tny_account_new_from_server_account): Use the new tinymail
1672 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1673 for TLS. This should fix projects.maemo.org bug NB#58460.
1675 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1677 * src/maemo/easysetup/modest-easysetup-wizard.c:
1678 (create_account): Correct the position of the gconf sanity check warning.
1679 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1680 of using the g_idle_add() hack, because this does not seem to be necessary
1681 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1682 caused by something other than maemo's gconf.
1683 This fixes projects.maemo.org bug #59022.
1685 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1687 * src/modest-account-mgr-helpers.c:
1688 (modest_account_mgr_get_default_account): Do not check that the account
1689 exists if there is no default account (NULL), to fix a runtime warning.
1691 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1693 * src/widgets/modest-folder-view.c: (update_model):
1694 Do not unref the treemodel before we have finished with it.
1695 This prevents a valgrind warning and an occasional crash at startup.
1697 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1699 * libmodest-dbus-client/libmodest-dbus-client.h:
1700 added libmodest_dbus_client_compose_mail()
1701 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1703 added functions needed for SendAsMail() functionality
1704 * src/maemo/modest-msg-edit-window.c:
1705 (modest_msg_edit_window_attach_file_noninteractive):
1706 non interactively attaching files to message edit window
1707 * src/widgets/modest-msg-edit-window.h:
1708 * tests/dbus_api/Makefile.am:
1709 added test_compose_mail.c
1710 * tests/dbus_api/test_compose_mail.c: (main):
1712 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1714 * src/modest-account-view.c:
1715 Fixed bug projects.maemo.org bug NB#59307
1717 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1719 * src/maemo/easysetup/modest-easysetup-wizard.c:
1720 (get_serverport_incoming), (on_before_next), (create_account):
1721 * src/maemo/modest-account-settings-dialog.c:
1722 (modest_account_settings_dialog_set_account_name):
1723 * src/maemo/modest-maemo-utils.c:
1724 (on_camel_account_get_supported_secure_authentication_status),
1725 (on_camel_account_get_supported_secure_authentication),
1726 (on_secure_auth_cancel),
1727 (modest_maemo_utils_get_supported_secure_authentication_methods):
1729 Implemented security authentication for settings and easysetup.
1731 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1733 * src/maemo/modest-main-window.c: (create_details_widget):
1734 Show the total size for memory card accounts too, instead of showing
1735 the name again. Fixes bug projects.maemo.org bug NB#59307.
1737 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1740 * src/modest-tny-simple-folder-store.c:
1741 * src/modest-tny-simple-folder-store.h: Removed.
1743 * src/modest-tny-local-folders-account.h
1744 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1745 for the local-folders maildir, with an extra TnyMergedFolder containing
1746 the folders of the per-account outbox store accounts.
1747 * src/modest-tny-account-store.c: (get_server_accounts):
1748 Add the outboxes to the special local folders account after creating it.
1750 * src/modest-tny-account.c:
1751 (modest_tny_account_new_for_local_folders): Create the derived
1752 account when creating the main local-folders account.
1754 * src/maemo/modest-main-window.c: (create_details_widget),
1755 (modest_main_window_set_contents_style):
1756 Adapted to the use of the derived account instead of the folder store.
1758 * src/modest-ui-actions.c:
1759 (modest_ui_actions_on_folder_selection_changed):
1760 * src/modest-ui-dimming-rules.c:
1761 (modest_ui_dimming_rules_on_new_folder):
1762 * src/widgets/modest-folder-view.c: (text_cell_data),
1763 (icon_cell_data), (filter_row), (update_model),
1764 (get_cmp_rows_type_pos):
1767 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1768 Do not get the priv struct, because no priv struct has been set,
1769 to avoid a runtime warning.
1771 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1772 #ifelse with #else, to fix a warning, to fix the build.
1775 2007-06-05 Christian Kellner <ckellner@openismus.com>
1777 * libmodest-dbus-client/libmodest-dbus-client.c:
1778 Fix small typo in doc (why do you always see them
1779 AFTER committing stuff?)
1782 2007-06-05 Christian Kellner <ckellner@openismus.com>
1784 * libmodest-dbus-client/libmodest-dbus-client.c:
1785 (libmodest_dbus_client_search):
1786 Initialize hit list with NULL. Also set folder list
1787 to "" if NULL was supplied.
1790 2007-06-03 Christian Kellner <ckellner@openismus.com>
1792 * libmodest-dbus-client/libmodest-dbus-client.c:
1793 (modest_search_hit_list_free):
1794 Make it save to call it with NULL.
1796 * src/dbus_api/modest-dbus-callbacks.c:
1797 * src/modest-search.c:
1798 Return full ModestSearchHits as the search result list not TnyHeader
1799 since can't be around withouth the correspoding TnyFolder.
1801 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1803 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1804 Added currently commented code to check for secure auth
1806 * src/maemo/modest-account-settings-dialog.c: (on_response),
1807 (save_configuration), (show_ok):
1808 Fixed projects.maemo.org bugs NB #59248 and #59251
1810 * src/maemo/modest-maemo-utils.c:
1811 (on_camel_account_get_supported_secure_authentication_status),
1812 (on_camel_account_get_supported_secure_authentication),
1813 (modest_maemo_utils_get_supported_secure_authentication_methods):
1814 * src/maemo/modest-maemo-utils.h:
1815 Moved get_supported_secure_authentication() method here to be able
1816 to use it from easysetup wizard.
1818 * src/modest-pair.c: (on_pair_compare_as_string):
1819 Should compare string with first part of pair and not
1820 strcmp pairs which will crash.
1822 * src/modest-protocol-info.c:
1823 (modest_protocol_info_protocol_is_store):
1824 * src/modest-protocol-info.h:
1825 Added modest_protocol_info_get_auth_protocol_name()
1827 2007-06-03 Armin Burgmeier <armin@openismus.com>
1829 * src/modest-mail-operation.c:
1830 (modest_mail_operation_get_msgs_full): Set priv->account also when
1831 only retrieving a single message. This avoids a crash when canceling
1834 (modest_mail_operation_notify_end): Do not explicitely remove the
1835 operation from the queue but only emit the progress_changed signal.
1836 The queue itself listens to that signal to remove the operation when
1837 it is finished. This reduces coupling and removes a potential deadlock
1838 when modest_mail_operation_notify_end() is called from the queue
1839 itself. If that is a problem performance-wise, I would suggest to
1840 implement a status-changed signal or something.
1842 * src/modest-mail-operation-queue.c: Make sure to never call a
1843 function from another file while the queue is locked. This (hopefully)
1844 fixes another deadlock when exiting the application while retrieving
1847 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1849 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1850 Fixed build if libogs is not available
1852 2007-06-03 Christian Kellner <ckellner@openismus.com>
1854 * libmodest-dbus-client/libmodest-dbus-client.h:
1855 * libmodest-dbus-client/libmodest-dbus-client.c:
1856 (libmodest_dbus_client_delete_message):
1857 Implement deletion of messages (Client side).
1859 (modest_search_hit_free),
1860 (modest_search_hit_list_free):
1861 Utility functions to free the result hits.
1863 * src/dbus_api/modest-dbus-api.h:
1864 * src/dbus_api/modest-dbus-callbacks.c:
1865 (on_delete_message),
1866 (modest_dbus_req_handler):
1867 Implement deletion of messages (Server side).
1869 * tests/dbus_api/test_search.c: (main):
1872 * tests/dbus_api/Makefile.am:
1873 * tests/dbus_api/test_delete_message:
1874 Add little test for the message deletion logic
1876 2007-06-03 Armin Burgmeier <armin@openismus.com>
1878 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1879 when the operation queue was not empty. projects.maemo.org bug
1882 2007-06-03 Armin Burgmeier <armin@openismus.com>
1884 * src/widgets/modest-account-view.c
1885 (on_account_default_toggled): Toggle default account column
1886 explicitely instead of waiting for gconf notification (which is
1887 currently ignored). This should fix projects.maemo.org bug NB#56910
1888 for now. It should probably be removed when gconf notifications are
1891 2007-06-03 Christian Kellner <ckellner@openismus.com>
1893 * libmodest-dbus-client/libmodest-dbus-client.c:
1894 Removed debugging spew.
1896 * src/dbus_api/modest-dbus-callbacks.c:
1897 Added debugging info.
1899 * src/modest-search.c:
1900 (modest_search_all_accounts):
1901 Use tny_account_store_get_accounts () on the account store
1902 to get all accounts which is the way to get all accounts.
1904 * tests/dbus_api/test_search.c: (main):
1905 Make it possible to supply the search term on the command line.
1907 2007-06-03 Christian Kellner <ckellner@openismus.com>
1909 * libmodest-dbus-client/libmodest-dbus-client.c:
1910 * libmodest-dbus-client/libmodest-dbus-client.h:
1911 Implement searching for mesages over raw dbus. (Client side)
1913 * src/dbus_api/Makefile.am:
1914 * src/dbus_api/modest-dbus-api.h:
1915 * src/dbus_api/modest-dbus-callbacks.c:
1916 * src/dbus_api/modest-dbus-callbacks.h:
1917 Search framework (Server side). Also implement on_idle_open_message().
1919 * src/maemo/modest-platform.c: (modest_platform_init):
1920 Prepare for raw dbus/osso rpc interaction.
1922 * src/modest-search.h:
1923 Changed minsize from unspecific guint to guint32.
1925 * src/modest-search.c:
1927 Added strange hack which magically made tnymail work.
1929 (modest_search_folder),
1930 (modest_search_account),
1931 (modest_search_all_accounts):
1932 Implement helper functions to search all accounts, specific account
1935 * tests/dbus_api/Makefile.am:
1936 * tests/dbus_api/test_open_message.c:
1937 Read url to open from commandline.
1939 * tests/dbus_api/test_search.c:
1940 Implement small test for dbus search stuff
1942 2007-06-02 Armin Burgmeier <armin@openismus.com>
1944 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1945 include account type and account title. This fixes projects.maemo.org
1948 * src/maemo/modest-account-view-window.c: Set a title for the window.
1950 2007-06-02 Armin Burgmeier <armin@openismus.com>
1952 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1953 incoming and outgoing server name based on email address and server
1954 types as long as the names have not been edited manually. This fixes
1955 projects.maemo.org bug NB#58671.
1957 2007-06-02 Armin Burgmeier <armin@openismus.com>
1959 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1960 server type cannot be changed in future to the incoming details page
1961 when creating an account. This fixes projects.maemo.org bug NB#59029.
1963 2007-06-02 Armin Burgmeier <armin@openismus.com>
1965 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1966 and assigned max width chars so that they wrap instead of being
1967 truncated. Fixes projects.maemo.org bug NB#56126.
1969 2007-06-02 Armin Burgmeier <armin@openismus.com>
1971 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1972 introductory note to the connection specific smtp servers dialog, as
1973 section 8.12 of the email UI specification requires. This fixes
1974 projects.maemo.org bug NB#59212.
1976 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1978 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1979 Check for running mail operations, and offer to cancel them, as per the UI
1980 spec. This fixes projects.maemo.org bug NB#59041 .
1981 However, I suspect that tinymail may still use the network connection
1982 in ways that we cannot detect or cancel. But it should at least adapt to
1983 changes fairly well.
1985 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1987 * src/modest-tny-account-store.c: (recreate_all_accounts),
1988 (get_cached_accounts), (get_server_accounts): Do more sensible
1989 ref-counting of the temporarily-cached outbox accounts list. This seems
1990 to fix a crash when entering the password when the password was wrong.
1992 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1994 * src/gnome/modest-main-window.c: (connect_signals):
1995 * src/modest-tny-account-store.c: (get_password),
1996 (modest_tny_account_store_alert): Added comments and clues and
1997 commented-out code about how we currently fail to deal with connection
1998 errors and wrong passwords, and how we should.
2000 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2002 * src/widgets/modest-retrieve-combo-box.c:
2003 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2004 This fixes projects.maemo.org bug NB#58472 .
2006 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2008 * src/maemo/easysetup/modest-easysetup-wizard.c:
2009 (create_page_complete_easysetup):
2010 (create_page_complete_custom): Correct the last commit,
2011 putting the correct sentences in the correct pages.
2013 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2015 * src/maemo/easysetup/modest-easysetup-wizard.c:
2016 (create_page_complete_custom): Show the second sentence of text
2017 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2020 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2022 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2023 Set the leave-on-server conf key by default. This fixes
2024 projects.maemo.org bug NB#59258 .
2026 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2028 * src/maemo/modest-account-view-window.c:
2029 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2030 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2033 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2035 * src/maemo/easysetup/modest-easysetup-wizard.c:
2036 (create_caption_new_with_asterisk):
2037 * src/maemo/modest-account-settings-dialog.c:
2038 (create_caption_new_with_asterisk):
2039 Uncomment the code to add the asterisk, because they are no longer in the
2040 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2041 (update_incoming_server_title): Add an asterisk here too.
2043 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2045 * src/maemo/modest-maemo-global-settings-dialog.c:
2046 (current_connection): Check that we are even connected before trying to
2047 get the current connection name, to prevent a warning.
2049 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2050 Change the comments because tny_maemo_conic_device_connect() is now meant to
2052 * src/modest-mail-operation.c:
2053 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2054 make sure we have a connection and fail if we can't connect.
2056 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2058 * src/maemo/modest-main-window.c:
2059 (on_account_store_connecting_finished): Do not try to get the
2060 connection ID if we are not really connected. I am surprised that
2061 this signal handler is called when we are not connected.
2063 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2065 * src/modest-error.h:
2066 * src/modest-ui-actions.c:
2067 (modest_ui_actions_get_msgs_full_error_handler):
2068 Renamed an enum, added comments, added an enum
2069 for retrieve-limit errors.
2071 * src/modest-mail-operation.c: (foreach_add_item),
2072 (internal_folder_observer_update), (update_account_thread),
2073 (modest_mail_operation_get_msgs_full):
2074 (modest_mail_operation_update_account),
2075 Added comments about how this works, and some code that should
2076 (but does not) check the retrieve-limit. See the TODO comment.
2078 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2080 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2081 Initialize help_id to fix the build. Warnings are good.
2083 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2085 * src/widgets/modest-hbox-cell-renderer.c:
2086 (modest_hbox_cell_renderer_append):
2087 * src/widgets/modest-vbox-cell-renderer.c:
2088 (modest_vbox_cell_renderer_append):
2089 Fix the last commit by doing an extra ref.
2091 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2093 * src/widgets/modest-hbox-cell-renderer.c:
2094 (modest_hbox_cell_renderer_append):
2095 * src/widgets/modest-vbox-cell-renderer.c:
2096 (modest_vbox_cell_renderer_append):
2097 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2098 to fix the build with Maemo Bora.
2099 However, there seems to be a remaining crash, probably due to reference
2102 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2104 * src/modest-tny-account.c:
2105 (modest_tny_account_new_for_local_folders):
2106 Use hildon_file_system_info_async_new() to get a better name for
2107 the memory card account, setting it as the account name.
2108 The timing seems to work, but this is probably
2109 not the best place to do this. See the TODO comment.
2110 * src/maemo/modest-main-window.c: (create_details_widget):
2111 * src/widgets/modest-folder-view.c: (text_cell_data):
2112 Use the tny account name instead of hardcoding a name.
2114 2007-05-30 Christian Kellner <ckellner@openismus.com>
2116 * src/modest-search.c: (modest_search):
2117 Correctly set part_search_func even if we have already parsed
2118 the query and thus a valid OgsTextSearcher object.
2120 2007-05-30 Christian Kellner <ckellner@openismus.com>
2123 Search and check for libogs.
2126 Incooparte the ogs build env.
2128 * src/modest-mime-part-search-stream.c:
2129 * src/modest-mime-part-search-stream.h:
2130 Removed since we do the real searching now in modest-search.c.
2132 * src/modest-search.c:
2133 * src/modest-search.h:
2134 Implement support for ogs. We use that if available and requested
2135 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2136 should now handle the corner case when the search term is spread
2137 across multiple reads.
2138 Also the logic in modest_search () was corrected to search all
2139 requested fields until one is found.
2141 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2143 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2145 * src/modest-init.h:
2146 * src/modest-init.c: Made modest_init_local_folders() take a
2147 path and be public so we can iniitialize maildir folders on
2150 * src/modest-local-folder-info.h:
2151 * src/modest-local-folder-info.c:
2152 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2154 * src/modest-tny-account.c:
2155 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2156 still means the standard local-folders path on the local volume.
2158 * src/modest-tny-account-store.c:
2159 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2160 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2161 all accounts when that happens.
2162 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2163 this too, so it shows up in the treeview.
2165 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2167 * src/maemo/modest-maemo-global-settings-dialog.c:
2168 (current_connection):
2169 * src/widgets/modest-global-settings-dialog.c:
2170 (current_connection_default):
2171 Use the enum values instead of 0, 1 and -1,
2172 to make the code clearer.
2174 * src/modest-account-mgr-helpers.c:
2175 (modest_account_mgr_get_connection_specific_smtp): Make this code
2178 * src/modest-runtime.h:
2179 * src/modest-runtime.c:
2180 Added modest_runtime_remove_all_send_queues().
2181 * src/maemo/modest-main-window.c:
2182 (on_account_store_connecting_finished): Recreate the send queues,
2183 using the appropriate transport accounts for this new connection.
2184 Some futher adapting might be needed if the old send queues are not
2185 automatically stopped at this point.
2187 * src/modest-tny-account-store.c: (get_server_accounts):
2188 Create the connection-specific transport accounts, so that they can
2189 be found later by their ID.
2191 * src/modest-tny-account.h:
2192 * src/modest-tny-account.c:
2193 Added modest_tny_account_new_from_server_account_name().
2194 modest_tny_account_new_from_server_account(): Do not create the
2195 send queues here, because they will be
2196 recreated anyway when the connection changes for the first time.
2198 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2200 * src/modest-local-folder-info.h:
2201 * src/modest-local-folder-info.c:
2202 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2203 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2204 tbox_folder): Take a modest account name instead of a server TnyAccount,
2205 so we can have per-modest-account rather than per-transport-account
2207 We must make sure that we change or recreate the exisitng send queues
2208 when the connection changes for connection-specific transport accounts.
2210 * src/modest-tny-account-store.c:
2211 (create_per_account_local_outbox_folders): Create outboxed per modest
2212 account, not per transport account.
2214 * src/modest-tny-account.h:
2215 * src/modest-tny-account.c:
2216 (modest_tny_account_get_special_folder): For outboxes, get the
2217 parent modest account name. The account is ignored for other folders.
2218 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2219 modest account name rather than a server TnyAccount.
2221 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2223 * src/modest-tny-account.c:
2224 (modest_tny_account_new_from_server_account):
2225 Call modest_runtime_get_send_queue() immediately after creating transport
2226 accounts, so that they start trying to send email from the outbox as soon
2227 as possible at startup. This is probably what we want.
2229 * src/modest-mail-operation.c: (update_account_thread):
2230 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2231 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2232 * src/modest-tny-send-queue.h:
2233 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2234 (modest_ui_actions_on_send):
2235 Added comments about how sending works, though it needs some more work.
2237 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2239 * src/modest-tny-account.c:
2240 (modest_tny_account_get_special_folder): Add TODO because this fails when
2241 the network is busy.
2242 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2243 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2244 Do not try to show this window when there is no active account. The UI
2245 specs does not tell us what to do in this case.
2247 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2251 * src/maemo/Makefile.am:
2252 * src/widgets/Makefile.am: Some dist fixes.
2254 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2256 * src/maemo/modest-connection-specific-smtp-window.c:
2257 (on_button_edit): Make the code clearer, to prevent a double free.
2259 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2261 * src/maemo/modest-account-settings-dialog.c:
2262 (modest_account_settings_dialog_set_account_name),
2263 Check the connection-specific smtp servers checkbox if there are any.
2265 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2266 (modest_connection_specific_smtp_edit_window_init):
2267 Start with a suitable port number.
2269 * src/modest-account-mgr-helpers.h:
2270 * src/modest-account-mgr-helpers.c: Added
2271 modest_account_mgr_get_has_connection_specific_smtp().
2273 (modest_account_mgr_set_connection_specific_smtp),
2274 (modest_account_mgr_remove_connection_specific_smtp),
2275 (modest_account_mgr_get_has_connection_specific_smtp),
2276 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2277 connection-specific smtp server accounts in the account, rather than
2278 the server account conf dir.
2280 This fixes bug projects.maemo.org bug NB#58263 .
2282 * src/modest-tny-account-store.c:
2283 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2284 if there are no server accounts yet, to prevent an infinite loop when there
2285 are no accounts. Document that one must be called before the other.
2287 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2289 * src/modest-account-mgr-helpers.c:
2290 (modest_account_mgr_get_default_account): Make sure that at least
2291 one account is always the default, if there are any enabled accounts.
2292 This is just a sanity check that shouldn't be necessary.
2294 * src/modest-account-mgr-priv.c:
2295 (_modest_account_mgr_account_from_key): Unescape the conf key to
2296 get the real account name. For instance, this is an issue if a space
2297 was in the account name, which can happen because the account name
2298 is generated from the display name.
2299 (_modest_account_mgr_get_account_keyname): Always escape the
2301 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2302 Unescape the conf keys to get the real account names.
2304 For instance, previously the is-default radio button in the accounts
2305 list was not checked for any accounts at first. This fixes that,
2306 and might fix several similar bugs.
2308 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2310 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2311 Removed some debug printfs.
2313 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2315 Modest on-disk outbox directories are now here, for instance:
2316 $HOME/.modest/outboxes/<account-id-1>/outbox
2317 $HOME/.modest/outboxes/<account-id-2>/outbox
2319 $HOME/.modest/local-folders/outbox
2320 so we can have a separate outbox for each account.
2321 But they are shown as one outbox in the GtkTreeView, by using a
2322 TnyMergeFolder in a ModestTnySimpleFolderStore.
2325 * src/modest-tny-simple-folder-store.c:
2326 * src/modest-tny-simple-folder-store.h:
2327 Added ModestTnySimpleFolderStore, used to contain folders from
2328 other folder stores, such as other accounts.
2330 * src/modest-tny-outbox-account.h:
2331 * src/modest-tny-outbox-account.c:
2332 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2333 used for the per-account local outbox folders.
2335 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2336 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2337 only use this (internally) now for the non-outbox local folders.
2339 * src/modest-init.h:
2340 * src/modest-init.c: Added modest_init_one_local_folder(), for
2341 setting up the directory structure for each local folder.
2343 * src/modest-local-folder-info.c:
2344 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2345 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2347 * src/modest-local-folder-info.h:
2348 * src/modest-tny-account-store.c: (on_account_removed),
2349 (on_account_changed), (create_per_account_local_outbox_folders),
2350 (get_server_accounts), (modest_tny_account_store_get_accounts),
2351 (modest_tny_account_store_get_tny_account_by_account),
2352 (modest_tny_folder_store_is_virtual_local_folders):
2354 * src/modest-tny-account.h:
2355 * src/modest-tny-account.c:
2356 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2357 to create an on-disk per-account local outbox folder for each
2359 (create_per_account_local_outbox_folders): Create a local outbox folder
2360 for each transport account.
2361 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2362 for all local folders.
2364 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2365 instead of using g_object_get/set() directly. It is clearer.
2367 (modest_tny_folder_store_get_message_count),
2368 (modest_tny_folder_store_get_local_size
2369 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2370 because we now use these with non-acount folder stores.
2372 (modest_tny_account_get_special_folder),
2373 (modest_tny_account_new_from_server_account),
2374 (modest_tny_account_new_from_account):
2375 (recurse_folders): Adjust to the new outbox system.
2377 * src/modest-tny-folder.h:
2378 * src/modest-tny-folder.c:
2379 (modest_tny_folder_is_local_folder),
2380 (modest_tny_folder_get_local_folder_type),
2381 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2383 * src/widgets/modest-main-window.h:
2384 * src/maemo/modest-main-window.c: (create_details_widget),
2385 (modest_main_window_set_contents_style): Show details for any folder store,
2388 (modest_tny_folder_get_rules):
2389 Remove the const. C does not support constness enough for this.
2391 * src/modest-ui-actions.c:
2392 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2393 make all outboxes appear as one, in the usual local-folders tree node.
2395 (set_active_account_from_tny_account),
2396 (modest_ui_actions_on_folder_selection_changed):
2397 * src/widgets/modest-folder-view.c: (text_cell_data),
2398 (icon_cell_data), (filter_row),
2399 (add_account_folders_to_merged_folder),
2400 (add_account_folders_to_simple_folder_store), (),
2401 (get_cmp_rows_type_pos), (cmp_rows),
2402 (modest_folder_view_set_account_id_of_visible_server_account):
2403 Adjust to the new outbox system, using generic folder stores and folders
2404 in the GtkTreeModel.
2406 2007-05-23 Christian Kellner <ckellner@openismus.com>
2408 * src/modest-mail-operation.c:
2409 (modest_mail_operation_update_account):
2410 Use info->max_size instead of unintialized local var [small
2411 build fix]. (Added TODO to review that change since I don't
2414 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2416 * libmodest-dbus-client/libmodest-dbus-client.c:
2417 (libmodest_dbus_client_compose_mail): function added
2418 * src/dbus_api/modest-dbus-api.h:
2419 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2420 (on_compose_mail): Implementation of the SendAsMail functionality
2422 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2424 * src/modest-account-mgr.c:
2425 (modest_account_mgr_add_server_account): Set the secure-connection
2426 conf key for transport accounts as well as store accounts. I don't know
2427 why the if was there. For instance, this makes sure that we use SSL
2428 for the gmail preset from the easysetup wizard.
2430 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2432 * src/gnome/modest-main-window.c:
2433 (on_account_store_connecting_finished), (connect_signals):
2434 * src/maemo/modest-main-window.c:
2435 (on_account_store_connecting_finished), (connect_signals),
2436 (modest_main_window_new):
2437 Handle TnyAccountStore::connecting-finished instead of
2438 TnyDevice::connection-changed, because we cannot actually perform
2439 operations on accounts until TnyAccountStore has itself responded to
2440 the TnyDevice::connection-changed signal. This prevents a GError from
2442 Do not try to update at startup, because we (at least on scratchbox)
2443 already do an update at startup when the device goes online.
2444 This prevents a GError from tinymail.
2445 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2446 Added TODO about stopping simultaneous operations.
2448 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2450 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2451 * src/modest-mail-operation-queue.c:
2452 (modest_mail_operation_queue_remove):
2453 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2454 about where they happened.
2456 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2458 * src/modest-ui-actions.c:
2459 (modest_ui_actions_on_password_requested): Make sure that the remember
2460 output parameter is always TRUE.
2462 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2464 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2465 Show a OK/Cancel dialog if the error is a question, though we still do not
2466 know anything more about what we are asking the user.
2467 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2468 Fix an uninitialized variable (helper). This is a logic error, however.
2470 2007-05-21 Christian Kellner <ckellner@openismus.com>
2472 * src/modest-search.h:
2473 Correct bit shifting in the ModestSearchFlags enum.
2475 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2477 * src/modest-tny-account.c:
2478 (modest_tny_account_new_from_server_account): Do not use the lsub and
2479 check-all hard-coded IMAP options when using POP.
2481 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2483 * src/modest-tny-account.c:
2484 (modest_tny_account_new_from_server_account):
2485 Use NULL for the secure-auth method for POP when Password auth has been
2486 specified by the user, as we already do for IMAP. "auth=Login" causes
2487 an error from camel or the server.
2489 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2491 * src/maemo/modest-account-settings-dialog.c:
2492 (create_page_account_details),
2493 (modest_account_settings_dialog_set_account_name):
2494 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2495 for the leave-on-server checkbox, rathr than just the checkbox, when
2496 the protocol is not POP.
2498 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2500 * src/widgets/modest-account-view.c:
2501 * src/widgets/modest-account-view.h:
2502 Added modest_account_view_select_account() which will be useful later
2503 to asynchronously re-select the edited account.
2505 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2507 * src/maemo/modest-account-settings-dialog.c:
2508 (modest_account_settings_dialog_set_account_name):
2509 Automatically choose the port numbers based on the secure authentication
2510 methods, if they have not been chosen before.
2511 This fixes projects.maemo.org bug NB#56273 .
2513 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2515 * src/maemo/modest-main-window-ui.h:
2516 * src/modest-ui-actions.c:
2517 * src/modest-ui-actions.h:
2518 Connect the Tools/SMTP Servers menu item to
2519 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2520 SMTP servers dialog, as in the UI specification and saves changes when it
2521 is closed. This fixed projects.maemo.org bug NB#56305 .
2523 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2525 * src/maemo/modest-connection-specific-smtp-window.c:
2526 (modest_connection_specific_smtp_window_init):
2527 Use gtk_window_set_default_size() to make this window big enough, so
2528 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2530 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2532 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2533 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2534 (modest_connection_specific_smtp_edit_window_init),
2535 Do not try to connect to a combobox signal before the combobox exists.
2536 This fixes the cras in projects.maemo.org bug NB#56288 .
2537 (modest_connection_specific_smtp_edit_window_get_settings):
2538 Remove the server_account_name parameter which was being checked for NULL
2539 though it was not used.
2541 * src/maemo/modest-connection-specific-smtp-window.c:
2542 (modest_connection_specific_smtp_window_fill_with_connections),
2543 (on_button_edit), (modest_connection_specific_smtp_window_init):
2544 Correct the number of treemodel columns to prevent a warning.
2545 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2546 libconic does not work.
2548 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2550 * src/modest-tny-account.c:
2551 (modest_tny_account_new_from_server_account):
2552 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2553 SMTP when "None" was chosen by the user. However, with my SMTP server that
2554 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2557 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2559 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2560 to explain the memory management issue with the ID in the ModestPair.
2562 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2563 (add_sending_page), (modest_account_assistant_finalize):
2564 * src/gnome/modest-gnome-global-settings-dialog.c:
2565 (create_updating_page), (create_composing_page):
2566 * src/gnome/modest-msg-edit-window.c: (get_transports),
2567 (init_window), (modest_msg_edit_window_finalize),
2568 (modest_msg_edit_window_get_msg_data):
2569 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2570 * src/gnome/modest-transport-widget.c:
2571 (modest_transport_widget_finalize), (smtp_configuration):
2572 * src/maemo/modest-maemo-global-settings-dialog.c:
2573 (create_updating_page), (create_composing_page):
2574 * src/maemo/modest-msg-edit-window.c: (get_transports),
2575 (init_window), (modest_msg_edit_window_finalize),
2576 (modest_msg_edit_window_get_msg_data),
2577 (modest_msg_edit_window_free_msg_data):
2578 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2579 (modest_store_widget_finalize):
2580 * src/maemo/modest-transport-widget.c:
2581 (modest_transport_widget_finalize), (smtp_configuration):
2582 * src/modest-main.c: (send_mail):
2583 * src/widgets/modest-combo-box.h:
2584 * src/widgets/modest-global-settings-dialog-priv.h:
2585 * src/widgets/modest-global-settings-dialog.c:
2586 (modest_global_settings_dialog_finalize):
2587 * src/widgets/modest-msg-edit-window.h:
2588 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2589 as long as the combo box, to prevent use of freed memory for the ID.
2591 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2593 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2594 get_accounts(), to make this clearer. Do not check for the enabled gconf
2595 key, because we do not use this for server accounts (at least, not yet).
2596 This allows us to send email again.
2598 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2600 * src/maemo/modest-platform.c:
2601 (on_modest_conf_update_interval_changed), (modest_platform_init):
2602 Only respond to this particular key change. All these strcmp()s cannot be
2605 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2607 * src/maemo/modest-maemo-global-settings-dialog.c:
2608 (current_connection): Prevent a crash in scratchbox when
2609 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2610 * src/maemo/modest-platform.c:
2611 (on_modest_conf_update_interval_changed), (modest_platform_init):
2612 Get the update interval from gconf and reset it when the gconf key changes.
2614 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2616 * src/modest-protocol-info.c:
2617 * src/modest-protocol-info.h: Adde enum-specific get functions,
2618 instead of using a ModestProtocolType enum parameter.
2620 * src/gnome/modest-account-assistant.c:
2621 * src/gnome/modest-store-widget.c:
2622 * src/gnome/modest-store-widget.h:
2623 * src/gnome/modest-transport-widget.c:
2624 * src/gnome/modest-transport-widget.h:
2625 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2626 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2627 * src/maemo/easysetup/modest-easysetup-wizard.c:
2628 * src/maemo/modest-account-settings-dialog.c:
2629 * src/maemo/modest-account-settings-dialog.h:
2630 * src/maemo/modest-store-widget.c:
2631 * src/maemo/modest-store-widget.h:
2632 * src/maemo/modest-transport-widget.c:
2633 * src/maemo/modest-transport-widget.h:
2634 * src/modest-account-mgr-helpers.c:
2635 * src/modest-account-mgr-helpers.h:
2636 * src/modest-account-mgr.c:
2637 * src/modest-account-mgr.h:
2638 * src/modest-tny-account.c:
2639 * src/modest-tny-folder.c:
2640 * src/widgets/modest-account-view.c:
2641 * src/widgets/modest-retrieve-combo-box.c:
2642 * src/widgets/modest-retrieve-combo-box.h:
2643 * src/widgets/modest-secureauth-combo-box.c:
2644 * src/widgets/modest-serversecurity-combo-box.c:
2645 * src/widgets/modest-serversecurity-combo-box.h:
2646 * tests/check_account-mgr.c:
2647 Use the specific functions, and use the re-renamed enum values for GNOME too.
2649 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2651 * src/modest-pair.h:
2652 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2653 so we can get the second based on the first.
2655 * src/maemo/modest-account-settings-dialog.h:
2656 * src/maemo/modest-account-settings-dialog.c:
2657 Added get_supported_secure_authentication_methods(), though it is mostly
2658 commented-out for now until the necessary API is committed to tinymail.
2659 (modest_account_settings_dialog_set_account_name),
2660 (save_configuration): Request the supported authentication methods from the
2661 server, so we can choose a working method.
2663 * src/modest-tny-account-store.h:
2664 * src/modest-tny-account-store.c:
2665 (modest_tny_account_store_get_session): Rename from
2666 tny_account_store_get_session().
2668 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2670 * src/modest-protocol-info.h: Split the ModestProtocol enum
2671 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2672 There was no need to have these unrelated values in one enum.
2674 * src/: many files: Adapted to changed enum. This makes the code a bit
2675 clearer, and the compiler could catch some errors.
2677 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2679 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2680 Show the detailed internal camel error message when an error happens
2681 during the configuration, so that our testers can give us more clues.
2682 For instance, in projects.maemo.org bug NB#56910 .
2684 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2686 * src/modest-tny-account.c:
2687 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2688 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2690 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2692 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2693 * src/maemo/modest-account-settings-dialog.c:
2694 (modest_account_settings_dialog_set_account_name),
2695 (save_configuration): For the incoming secure authentication checkbox,
2696 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2697 the UI specification. PLAIN does not seem to be supported for most IMAP
2698 servers anyway, and I am not sure what it would mean.
2699 However, we probably need to discover which of the secure-authentication
2700 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2701 * src/modest-account-mgr-helpers.c:
2702 (modest_account_mgr_get_server_account_data):
2704 * src/modest-tny-account.c:
2705 (modest_tny_account_new_from_server_account):
2706 Use tny_account_set_mech() to set secure-authentication methods,
2707 with some special-casing for IMAP, based on my observations of how
2710 * src/modest-account-mgr-helpers.h:
2711 * src/modest-account-mgr.c:
2712 * src/modest-defs.h: Comment that the URI is only used for local folders.
2714 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2716 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2717 parameter const, just to be neat.
2718 * src/modest-text-utils.c: (modest_text_utils_inline):
2719 End g_strconcat() with NULL, as its documentation says. This is almost
2720 certainly the cause of my crash at startup on the device. Interestingly,
2721 valgrind doesn't tell us about these errors.
2723 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2725 * scripts/build-packages: Added more precise comments about how to use
2726 this script, though I still get this error:
2727 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2728 error building tinymail
2730 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2732 * src/maemo/modest-main-window.c: (on_account_update):
2733 Very slight cleanup, hoping to make it simpler to discover what causes
2734 a crash here sometimes.
2736 * src/modest-tny-account.c:
2737 (modest_tny_account_new_from_server_account): Set the port. Added
2738 comments about the options and a TODO comment because I need to find out
2739 how to specify the secure authentication method.
2741 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2743 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2744 changed CFlags paths form modest to libmodest
2746 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2748 * src/modest-account-mgr-helpers.c:
2749 (modest_account_mgr_get_server_account_data),
2750 (modest_account_mgr_free_server_account_data):
2751 * src/modest-account-mgr-helpers.h:
2752 * src/modest-account-mgr.c:
2753 (modest_account_mgr_add_server_account):
2754 * src/modest-defs.h:
2755 * src/modest-tny-account.c:
2756 (modest_tny_account_new_from_server_account):
2757 Determine the options for tny_camel_account_add_option() here,
2758 based on the settings, rather than storing them directly in gconf.
2760 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2762 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2763 Show a more friendly error dialog now that we expect (from the tinymail
2764 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2766 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2768 * src/maemo/modest-main-window.c: (on_account_update): Check that
2769 account_name is not NULL, to prevent a crash at startup that I am
2770 seeing on the N800. I do wonder why it is NULL.
2772 * src/maemo/easysetup/modest-easysetup-wizard.c:
2773 (create_page_user_details):
2774 * src/maemo/modest-account-settings-dialog.c:
2775 (create_page_user_details), (create_page_outgoing):
2776 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2777 (modest_connection_specific_smtp_edit_window_init):
2778 * src/modest-ui-actions.c:
2779 (modest_ui_actions_on_password_requested):
2780 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2781 might do something useful with the on-screen keyboard.
2783 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2785 * src/maemo/modest-main-window.c: (on_account_update):
2786 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2787 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2789 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2791 * src/modest-tny-account-store.c: (on_account_changed):
2792 Correct the signature of this signal handler.
2794 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2796 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2797 Show a HildonNote instead of a GtkDialog for Maemo.
2799 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2801 * src/widgets/modest-account-view.h:
2802 * src/widgets/modest-account-view.c: (on_account_changed),
2803 (on_account_removed). Added a boolean flag, set/unset by
2804 modest_account_view_block_conf_updates(),
2805 modest_account_view_unblock_conf_updates() to prevent unnecessary
2806 updates, but this is not very useful because the gconf notifications are
2807 so delays (maybe only on Maemo Bora).
2808 So auto-updating is turned off, and these functions do an explicit
2809 update when necessary.
2810 However, something else is still doing too much work when adding/removing
2811 accounts, probably in another part of the application.
2813 * src/maemo/modest-account-view-window.c:
2814 (on_delete_button_clicked), (on_edit_button_clicked),
2815 (on_new_button_clicked): Use the new functions.
2817 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2819 * src/modest-account-mgr-helpers.c:
2820 (modest_account_mgr_set_first_account_as_default):
2821 Sort the list of names alphabetically-by-title, so we choose the first one
2823 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2824 alphabetically by the title.
2826 This fixes projects.maemo.org bug NB#56418 .
2828 * src/modest-account-mgr-priv.c:
2829 (_modest_account_mgr_account_from_key):
2830 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2831 avoid a valgrind error, and possible random behaviour.
2833 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2835 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2836 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2837 tinymail documentation to say that this can be expected.
2838 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2839 pretty, and should not happen, but I would prefer to know when it does.
2841 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2843 * configure.ac: When using the older hildon version, probably on Bora,
2844 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2846 * src/widgets/modest-attachment-view.c:
2847 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2850 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2852 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2853 Implemented the prototype. Can be tested with
2854 tests/dbus_api/test_open_message:
2856 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2858 * src/modest-tny-account-store.c:
2859 (modest_tny_account_store_instance_init), (get_password):
2860 * src/modest-ui-actions.c:
2861 (modest_ui_actions_on_password_requested):
2862 Do not store the password in gconf, because this function is called
2863 for non-remembered passwords. Actually use the cached (in the hash map)
2864 password instead of releasing it.
2865 The password will now not be remembered if it is asked via the protected
2866 password dialog, as per the UI spec.
2868 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2870 * src/modest-defs.h:
2871 * src/modest-account-mgr-helpers.h:
2872 * src/modest-account-mgr-helpers.c:
2873 Added modest_server_account_get_username_has_succeeded(),
2874 modest_server_account_set_username_has_succeeded().
2875 (modest_server_account_set_username),
2876 Reset the has-succeeded flag if the username changes.
2878 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2879 * src/maemo/modest-connection-specific-smtp-window.c:
2880 (modest_connection_specific_smtp_window_save_server_accounts):
2881 Use modest_server_account_set_username() instead of using
2882 modest_conf_set_string() directly, so that the has-succeeded flag is always
2885 * src/modest-ui-actions.c:
2886 (modest_ui_actions_on_password_requested): Dim the username entry if
2887 the username has ever worked, as per the UI spec.
2889 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2891 * src/modest-tny-account-store.c: (get_password):
2892 * src/modest-ui-actions.c:
2893 (modest_ui_actions_on_password_requested):
2894 Allow the username to be changed too, though there is more work to
2895 be done on exactly how this behaves.
2897 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2899 * src/modest-account-mgr-helpers.h:
2900 * src/modest-account-mgr-helpers.c:
2901 Added modest_account_mgr_get_display_name(),
2902 modest_server_account_get_username(),
2903 modest_server_account_set_username(),
2904 modest_server_account_set_password(),
2905 modest_server_account_get_hostname() functions so we do not need to
2906 use the conf API directly.
2908 * src/maemo/modest-main-window.c: (connect_signals):
2909 Actually connect ot the ModestAccountStore::request-password signal,
2910 so that we show the dialog when the password is requested by Tinymail,
2911 for isntance if it is empty.
2913 * src/modest-marshal.list:
2914 * src/modest-tny-account-store.c:
2915 (modest_tny_account_store_class_init), (get_password),
2916 (modest_tny_account_store_alert):
2917 * src/modest-tny-account-store.h:
2918 * src/modest-ui-actions.h:
2919 * src/modest-ui-actions.c:
2920 (modest_ui_actions_on_password_requested):
2921 Change the signal parameters, so it is obvious that we are providing
2922 the non human-readable server name, and receiving both the username
2923 and password, though changing of the username is not yet implemented.
2924 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2925 for the GNOME version.
2927 This should fix the projects.maemo.org bug NB#56209, though it does not
2928 work on Bora, because the gconf_client_get() for the password fails
2929 immediately after we save it with gconf_client_set().
2931 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2934 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2935 caused an undefined symbol error:
2936 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2938 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2940 * src/modest-tny-account-store.c:
2941 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2942 using a GError instead of a string message, so we can translate it in
2945 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2947 * src/maemo/modest-address-book.c:
2948 (modest_address_book_check_names):
2949 * src/maemo/modest-msg-view-window.c:
2950 (modest_msg_view_window_clipboard_owner_change):
2951 * src/modest-init.c: (modest_init_init_ui):
2952 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2953 (update_folders_cb), (modest_mail_operation_update_account):
2954 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2955 (modest_ui_actions_on_msg_attachment_clicked),
2956 (modest_ui_actions_on_msg_recpt_activated):
2957 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2958 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2959 (modest_msg_view_search_next):
2960 * src/widgets/modest-recpt-editor.c:
2961 (modest_recpt_editor_on_button_release_event),
2962 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2963 g_message(). At this point we should only be seeing interesting errors on
2964 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2966 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2968 (modest_wizard_dialog_force_title_update):
2969 * src/maemo/easysetup/modest-wizard-dialog.h:
2970 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2971 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2972 can update the title when appropriate. Otherwise the title is wrong if the
2973 pages are added after adding the notebook to the dialog.
2974 This must be a problem in HildonWizardDialog too.
2975 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2977 * src/maemo/easysetup/modest-easysetup-wizard.c:
2978 (create_subsequent_customsetup_pages),
2979 (create_subsequent_easysetup_pages):
2980 Call modest_wizard_dialog_force_title_update() so that the title is
2981 correct even with GTK+ < 2.10.
2982 This fixes projects.maemo.org bug NB#56145 .
2984 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2986 * src/maemo/modest-platform.c:
2987 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2988 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2991 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2993 * src/widgets/modest-window.h:
2994 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2995 and modest_window_save_state(), which invokes it.
2997 * src/widgets/modest-window-mgr.h:
2998 * src/widgets/modest-window-mgr.c:
2999 Added modest_window_mgr_save_state_for_all_windows(), which calls
3000 the save_state vfunc on all registered windows, if implemented.
3002 * src/gnome/modest-msg-edit-window.c:
3003 * src/gnome/modest-msg-view-window.c:
3004 * src/maemo/modest-msg-edit-window.c:
3005 * src/maemo/modest-msg-view-window.c:
3006 * src/maemo/modest-main-window.c:
3007 Specify the existing save_settings functions as implementations of
3008 ModestWindow::save_state_func().
3010 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3011 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3012 enabling hibernation, for instance.
3014 We may need to do the same thing for restoring settings.
3017 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3019 * src/widgets/modest-window-mgr.c:
3020 * src/widgets/modest-window-mgr.h:
3021 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3022 modest_window_mgr_get_hibernation_is_prevented().
3024 * src/maemo/modest-main-window.c:
3025 (on_hildon_program_is_topmost_notify): Prevent hibernation
3026 (possible when the application goes to the background in the WM),
3027 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3029 * src/maemo/easysetup/modest-easysetup-wizard.c:
3030 (modest_easysetup_wizard_dialog_init):
3031 * src/maemo/modest-account-settings-dialog.c:
3032 (modest_account_settings_dialog_init):
3033 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3034 (modest_connection_specific_smtp_edit_window_init):
3035 * src/maemo/modest-connection-specific-smtp-window.c:
3036 (modest_connection_specific_smtp_window_init):
3037 * src/maemo/modest-signature-editor-dialog.c:
3038 (modest_signature_editor_dialog_init):
3039 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3040 prevent hibernation while any of these account settings dialogs are open.
3042 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3044 * src/maemo/Makefile.am:
3045 * src/maemo/modest-osso-state-saving.c:
3046 * src/maemo/modest-osso-state-saving.h: Added
3047 modest_osso_load_state() and modest_osso_save_state() though they do
3048 nothing now. They should iterate through all the open windows and load/save
3050 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3051 save state when closing.
3053 * src/maemo/modest-main-window.c:
3054 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3055 Add a notification handler for the HildonProgram::is-topmost property,
3056 so we can allow hibernation when the application goes into the background.
3057 But we still need to detect when the accounts setup windows are open so
3058 we can stop hibernation when they are open.
3059 To do this, I also added the main window the HildonProgram. This might have
3060 other side-effects/benefits, and should maybe be done for other windows.
3062 * src/maemo/modest-osso-autosave-callbacks.h:
3063 * src/maemo/modest-osso-autosave-callbacks.c:
3064 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3065 though it does not do anything yet, and we might never need this to do
3066 anything. For instance, we already save drafts.
3068 * src/maemo/modest-platform.c: (modest_platform_init):
3069 Specify the libosso auto-save callback.
3071 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3073 * src/maemo/modest-platform.c:
3074 (modest_platform_set_update_interval):
3075 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3076 aparently stays valid between application instances, so we can use this
3077 to remove and reset it later. According to a maemo-developers email from
3080 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3082 * configure.ac: Depend on libalarm for Maemo.
3084 * src/dbus_api/modest-dbus-api.h:
3085 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3086 (on_send_receive), (modest_dbus_req_handler):
3087 Handle a SEND_RECEIVE D-Bus method.
3089 * libmodest-dbus-client/libmodest-dbus-client.c:
3090 (libmodest_dbus_client_send_and_receive):
3091 * libmodest-dbus-client/libmodest-dbus-client.h:
3092 Add C convenience functions for calling the new D-Bus method.
3094 * src/modest-platform.h:
3095 * src/gnome/modest-platform.c:
3096 * src/maemo/modest-platform.c:
3097 Added modest_platform_set_update_interval(), which uses the
3098 alarmd API on Maemo.
3099 (modest_platform_init),
3100 Call modest_platform_set_update_interval(), using a hard-coded
3101 interval for now (until the global settings dialog is implemented),
3102 though I am not sure that this makes sense yet.
3104 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3106 * src/dbus_api/modest-dbus-callbacks.c:
3107 (modest_osso_cb_hw_state_handler):
3108 * src/dbus_api/modest-dbus-callbacks.h:
3109 * src/maemo/modest-platform.c: (modest_platform_init):
3110 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3111 in case this has some effect on the ability for Maemo to ping the
3114 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3116 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3117 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3118 warning. It is probably a logic error, but I need to fix the build.
3120 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3122 * src/modest-account-mgr.h:
3123 * src/modest-account-mgr.c:
3124 (modest_account_mgr_account_names): Add a gboolean enabled_only
3125 parameter, so we can get lists of onlt the enabled accounts.
3127 (modest_account_mgr_add_account),,
3128 (modest_account_mgr_account_with_display_name_exists):
3129 * src/maemo/modest-msg-edit-window.c: (get_transports):
3130 * src/modest-account-mgr-helpers.c:
3131 (modest_account_mgr_set_first_account_as_default):
3132 * src/modest-init.c: (init_default_account_maybe):
3133 * src/modest-tny-account-store.c: (get_accounts):
3134 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3135 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3136 * tests/check_account-mgr.c: (START_TEST):
3137 Provide the extra parameter, as appropriate.
3139 * src/widgets/modest-account-view.c: (update_account_view):
3140 Do not show disabled accounts (meaning that there is no way to
3141 enable/disable accounts in the UI (the feature is not in our UI
3142 specification), so we can use this internally only to mark unfinished
3143 or temporary account data.
3145 * src/maemo/easysetup/modest-easysetup-wizard.c:
3146 (create_account): Add boolean enable parameter, so we can specify FALSE
3147 to create the temporary account.
3148 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3149 (on_before_next): When finishing, when there is a temporary account, just
3151 Also, use a timeout to delay the showing of the dialog until gconf is likely
3152 to return correct information, due to a maemo gconf bug that is fixed in
3153 osso 1.1, but not yet in Bora.
3154 However, the dialog stays on screen after it is destroyed.
3156 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3157 for invalid data when cancelling. Use a hildon note instead of a dialog
3158 to complain about invalid data. Do not show the account-saved note if the
3159 account is disabled (a temporary account that will not really be saved for use
3162 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3164 * src/modest-account-mgr-helpers.h:
3165 * src/modest-account-mgr-helpers.c:
3166 Added modest_account_mgr_unset_default_account(),
3167 Added modest_account_mgr_set_first_account_as_default().
3169 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3170 If it was the default account, unset the default account name.
3172 * src/maemo/modest-account-view-window.c:
3173 (on_delete_button_clicked): If it was the default account,
3174 set the first remaining account as the default instead.
3176 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3177 a NULL account or a NULL default account, to prevent a crash. This should
3178 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3181 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3183 * src/widgets/modest-recpt-editor.c:
3184 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3185 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3186 TODO comment for this. This fixes the build.
3188 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3189 be the best place for it. This will in future update all auto-update accounts,
3190 rather than just the current/default account, when that gconf key exists.
3191 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3192 if there are no accounts, before calling do_send_receive().
3193 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3195 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3196 * src/maemo/modest-main-window-ui.h:
3197 * src/maemo/modest-main-window.c: (on_connection_changed),
3198 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3199 directly, becaue the signal handler does more.
3201 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3203 * src/modest-account-mgr-helpers.c:
3204 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3205 for the case that the account does not exist.
3207 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3208 (equivalent to the modest account name) rather than the tinymail account name
3209 (equivalent to the modest account title - human readable) to get the account data.
3210 Check for null account data to prevent the crash, and add a TODO comment saying that
3211 this needs fixing because it is using the server account name instead of the account name.
3213 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3215 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3216 * src/maemo/modest-account-settings-dialog.c: (show_error),
3218 Use hildon_note_new_information() for informative and error messages,
3219 which seems to be expected for Maemo applications (no documentation that I know of
3220 says this). I am surprised that there is no distinction between info and error
3223 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3225 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3226 it is easy to find where this is used.
3228 * src/maemo/easysetup/modest-easysetup-wizard.c:
3229 (create_page_welcome), (create_page_account_details),
3230 (create_page_user_details), (create_page_complete_easysetup),
3231 (create_page_custom_incoming), (create_page_custom_outgoing),
3232 (create_page_complete_custom):
3233 * src/maemo/modest-account-settings-dialog.c:
3234 (create_page_account_details), (create_page_user_details),
3235 (create_page_incoming), (create_page_outgoing):
3236 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3237 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3238 (modest_connection_specific_smtp_edit_window_init):
3239 * src/maemo/modest-connection-specific-smtp-window.c:
3240 (modest_connection_specific_smtp_window_init):
3241 * src/maemo/modest-signature-editor-dialog.c:
3242 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3243 and scrolling policy as per the Email Application Layout Guide, if I have
3246 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3248 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3249 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3250 which were empty, because these vfuncs have been removed from TnyAccountStore.
3251 This fixes the build.
3253 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3255 * src/maemo/modest-main-window.c:
3256 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3257 showing/hiding it. Added TODO because it probably should not be NULL.
3258 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3259 because unnecessary g_warnings() make degugging difficult.
3261 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3263 * src/maemo/modest-msg-edit-window.c:
3264 (modest_msg_edit_window_select_color),
3265 (modest_msg_edit_window_select_background_color): 2 const corrections and
3266 moving 2 #endifs before closing brackets, to fix the build.
3268 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3270 * src/maemo/easysetup/modest-easysetup-wizard.h:
3271 * src/maemo/easysetup/modest-easysetup-wizard.c:
3272 (modest_easysetup_wizard_dialog_finalize),
3273 (on_button_edit_advanced_settings), (create_page_complete_custom),
3274 (on_response), (create_account):
3275 Implement the Advanced Settings edit button, by saving the account information,
3276 for the Advanded Settings dialog to use directly from gconf, and removing it
3277 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3278 Bug #5533 in the projects.maemo.org bugzilla.
3280 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3282 * src/maemo/modest-msg-view-window.c:
3283 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3284 when opening a message window.
3286 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3288 * src/maemo/easysetup/modest-easysetup-wizard.c:
3289 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3292 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3293 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3294 gconf settings. I probably added more checks than necessary, but that is safer.
3296 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3297 variable to fix the build, but this seems to be used when it is still NULL.
3299 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3301 * src/modest-platform.h:
3302 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3303 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3304 * src/modest-main.c: Implement this function so we can avoid using
3305 maemo-specific API from cross-platform code.
3307 * src/modest-tny-account-store.c:
3308 (get_smtp_specific_transport_account_for_open_connection):
3309 * src/modest-ui-actions.c: (check_for_connection),
3310 (modest_ui_actions_on_item_not_found):
3311 Use modest_platform_connect_and_wait() and put #idefs around other
3312 maemo-specific code, because only maemo currently has a way to
3313 identify connection names.
3315 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3317 * src/modest-tny-account-store.h:
3318 * src/modest-tny-account-store.c:
3319 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3320 the connection-specific SMTP server settings in the configuration.
3322 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3324 * src/maemo/modest-main-window.c: (on_connection_changed),
3326 * src/modest-main.c: (main), (start_ui), (send_mail):
3327 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3328 that is what is intended.
3330 * src/modest-ui-actions.c: (action_send), (action_receive),
3331 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3332 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3333 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3334 SMTP server is used when it is specified.
3336 (modest_ui_actions_on_send_receive):
3337 Check that a connection is open before proceeding.
3338 Receive and then send, instead of vice-versa, as per the specification.
3340 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3342 * src/modest-mail-operation.c:
3343 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3344 though I guess it should be something other than NULL.
3346 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3348 * src/maemo/easysetup/modest-easysetup-wizard.c:
3349 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3350 combo twice, to avoid an g_warning and to make it visible again.
3351 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3352 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3353 (already intended) dereference when detaching, because we then recreate the menu.
3354 But I am not sure why the warning was happening, and it is possible that this is a memory
3357 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3359 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3360 and uri_parse_mailto() utility functions.
3361 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3363 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3365 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3367 * src/dbus_api/modest-dbus-api.h:
3368 * src/dbus_api/modest-dbus-callbacks.c:
3369 Use an idle callback to execute the modest code in the application's own thread.
3370 Remove the helloworld example method.
3371 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3372 parsed, and the open-message method is not implemented because this is not yet implemented in
3374 * libmodest-dbus-client/libmodest-dbus-client.c:
3375 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3376 (libmodest_dbus_client_open_message):
3377 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3379 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3380 body without crashing.
3382 * tests/dbus_api/Makefile.am:
3383 * tests/dbus_api/test_mail_to.c:
3384 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3386 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3388 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3389 Added file to fix the build. Sorry.
3391 * src/dbus_api/Makefile.am:
3392 * src/dbus_api/modest-dbus-api.h:
3393 * src/dbus_api/modest-dbus-callbacks.h:
3394 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3395 (modest_dbus_req_handler):
3396 Put constants in a separate header so it can be reused by the
3397 client library, without duplication
3399 * libmodest-dbus-client/Makefile.am:
3400 * libmodest-dbus-client/libmodest-dbus-client.c:
3401 (libmodest_dbus_client_call_helloworld),
3402 (libmodfest_dbus_client_send_mail),
3403 (libmodfest_dbus_client_mailto),
3404 (libmodfest_dbus_client_open_message):
3405 * libmodest-dbus-client/libmodest-dbus-client.h:
3406 (Partly) Implement a send_mail D-Bus method.
3408 * tests/dbus_api/Makefile.am:
3409 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3410 the send_email D-Bus method.
3412 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3416 * libmodest-dbus-client/Makefile.am:
3417 * libmodest-dbus-client/libmodest-dbus-client.c:
3418 * libmodest-dbus-client/libmodest-dbus-client.h:
3419 * tests/dbus_api/Makefile.am:
3420 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3421 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3423 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3425 * src/maemo/easysetup/modest-easysetup-wizard.c:
3426 (create_page_account_details):
3427 * src/maemo/modest-account-settings-dialog.c:
3428 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3429 widgets, because this might not be the default in future versions of the Maemo GTK+.
3430 However, I can not not get capitalization to work even in a simple test case.
3432 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3434 * src/maemo/easysetup/modest-easysetup-wizard.c:
3435 (create_page_custom_incoming), (create_page_custom_outgoing):
3436 * src/maemo/modest-account-settings-dialog.c:
3437 (create_page_account_details), (create_page_incoming),
3438 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3439 instead of using gtk_check_button_with_label(), so they are aligned like the other
3440 widgets, as per the UI spec.
3442 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3444 * src/maemo/easysetup/modest-easysetup-wizard.c:
3445 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3446 * src/widgets/modest-validating-entry.c:
3447 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3448 Modest prefix instead of an EasySetup prefix.
3450 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3452 * src/widgets/modest-validating-entry.h:
3453 * src/widgets/modest-validating-entry.c: (on_insert_text),
3454 Added easysetup_validating_entry_set_max_func(), used to set a callback
3455 to call when the max number of characters is reached. GtkEntry has a max-length
3456 already but is silent about it.
3458 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3459 (create_page_account_details), (create_page_user_details),
3461 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3462 (create_page_account_details), (create_page_user_details),
3463 (create_page_outgoing):
3464 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3465 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3466 the UI spec, when the user tries to enter more than the max number of characters.
3468 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3470 * src/maemo/easysetup/modest-easysetup-wizard.c:
3471 (create_page_user_details), (create_page_custom_incoming),
3472 (create_page_custom_outgoing):
3473 * src/maemo/modest-account-settings-dialog.c:
3474 (create_page_user_details), (create_page_incoming),
3475 (create_page_outgoing):
3476 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3477 (modest_connection_specific_smtp_edit_window_init):
3478 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3479 not appropriate. Bad Maemo-specific defaults!.
3481 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3483 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3484 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3485 (modest_signature_editor_dialog_set_settings):
3486 Disable the label and textview when the checkbox is disabled, and use the
3487 specified (UI spec) default signature text.
3489 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3491 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3492 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3494 * src/modest-defs.h:
3495 * src/modest-account-mgr-helpers.h:
3496 * src/modest-account-mgr-helpers.c:
3497 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3499 * src/maemo/Makefile.am:
3500 * src/maemo/modest-signature-editor-dialog.c:
3501 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3504 * src/maemo/modest-account-settings-dialog.h:
3505 * src/maemo/modest-account-settings-dialog.c:
3506 (modest_account_settings_dialog_finalize), (on_button_signature),
3507 (save_configuration): Use the new dialog when the Edit button is pressed, and
3508 save the changes if necessary, as per the UI spec.
3510 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3512 * src/maemo/Makefile.am:
3513 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3514 based on maemo-develoers email from Dirk.
3516 * src/maemo/easysetup/modest-easysetup-wizard.c:
3517 (create_page_welcome), (create_page_account_details),
3518 (create_page_user_details), (create_page_complete_easysetup),
3519 (create_page_custom_incoming), (create_page_custom_outgoing),
3520 (create_page_complete_custom),
3521 (modest_easysetup_wizard_dialog_init):
3522 * src/maemo/modest-account-settings-dialog.c:
3523 (create_page_account_details), (create_page_user_details),
3524 (create_page_incoming), (create_page_outgoing),
3525 (modest_account_settings_dialog_init):
3526 * src/maemo/modest-connection-specific-smtp-window.c:
3527 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3529 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3531 * src/maemo/easysetup/modest-easysetup-wizard.c:
3532 (create_page_account_details), (create_page_custom_outgoing),
3533 (create_page_complete_custom):
3534 * src/maemo/modest-account-settings-dialog.c:
3535 (create_page_user_details), (create_page_incoming),
3536 (create_page_outgoing):
3537 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3538 (modest_connection_specific_smtp_edit_window_init):
3539 Use the correct (UI spec) port min/max, and use horizontal separators,
3542 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3544 * src/maemo/easysetup/modest-easysetup-wizard.c:
3545 (set_default_custom_servernames):
3546 * src/maemo/modest-account-settings-dialog.c:
3547 (create_page_incoming), (on_combo_outgoing_security_changed),
3548 (on_combo_incoming_security_changed), (create_page_outgoing),
3549 (modest_account_settings_dialog_set_account_name),
3550 (save_configuration):
3551 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3552 (on_combo_security_changed),
3553 (modest_connection_specific_smtp_edit_window_init),
3554 (modest_connection_specific_smtp_edit_window_set_connection),
3555 (modest_connection_specific_smtp_edit_window_get_settings):
3556 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3559 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3562 * src/maemo/easysetup/modest-easysetup-wizard.c:
3563 (create_page_custom_outgoing), (create_page_complete_custom):
3564 * src/maemo/modest-account-settings-dialog.c:
3565 (create_page_user_details), (create_page_outgoing):
3566 * src/maemo/modest-account-view-window.c: (button_box_new):
3567 Use changed logical IDs as per the most recent UI spec:
3568 mcen_bd_emailsetup_edit -> mcen_bd_edit
3569 mcen_bd_emailsetup_delete -> mcen_bd_delete
3570 mcen_bd_emailsetup_close -> mcen_bd_close
3572 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3576 * src/dbus_api/Makefile.am:
3577 * src/dbus_api/modest-dbus-callbacks.c:
3578 * src/dbus_api/modest-dbus-callbacks.h:
3579 * src/maemo/modest-platform.c: (modest_platform_init):
3580 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3582 * tests/Makefile.am:
3583 * tests/dbus_api/Makefile.am:
3584 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3586 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3588 * src/maemo/modest-account-settings-dialog.c:
3589 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3590 Removed unnecessary includes.
3592 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3594 * src/maemo/easysetup/modest-easysetup-wizard.c:
3595 * src/maemo/modest-account-settings-dialog.c:
3596 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3597 * src/widgets/Makefile.am:
3598 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3599 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3600 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3601 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3602 * src/widgets/modest-secureauth-combo-box.c:
3603 * src/widgets/modest-secureauth-combo-box.h:
3604 * src/widgets/modest-serversecurity-combo-box.c:
3605 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3606 made the GObject names more consistent with the rest of the Modest code.
3608 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3610 * src/maemo/easysetup/Makefile.am:
3611 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3612 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3613 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3614 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3615 * src/maemo/easysetup/modest-easysetup-wizard.c:
3616 * src/maemo/easysetup/modest-validating-entry.c:
3617 * src/maemo/easysetup/modest-validating-entry.h:
3618 * src/maemo/modest-account-settings-dialog.c:
3619 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3620 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3621 widgets/ because they are used outside of easysetup too. After checking in,
3622 svn will allow me to rename them too.
3624 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3626 * src/gnome/modest-msg-edit-window.c:
3627 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3628 linker error, to fix the build on the GNOME platform.
3629 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3630 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3631 ifdefed out to avoid a warning.
3633 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3635 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3636 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3637 some alternative for GTK+ 2.6.
3639 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3641 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3643 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3644 specified for EmailAccountsDialog in UI spec.
3646 * src/maemo/easysetup/modest-easysetup-wizard.c:
3647 * src/maemo/easysetup/modest-easysetup-wizard.h:
3648 * src/maemo/modest-account-settings-dialog.c:
3649 * src/maemo/modest-account-settings-dialog.h:
3650 Reuse a member window widget for the connection-specific SMTP server accounts,
3651 so we can tell it to create/save the accounts only if we actually save changes.
3653 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3654 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3655 (modest_connection_specific_smtp_edit_window_get_settings):
3656 Return a struct instance for temporarily remembering the entered data.
3658 * src/maemo/modest-connection-specific-smtp-window.h:
3659 * src/maemo/modest-connection-specific-smtp-window.c:
3660 (modest_connection_specific_smtp_window_finalize),
3661 (modest_connection_specific_smtp_window_fill_with_connections),
3663 (modest_connection_specific_smtp_window_save_server_accounts),
3664 (update_model_server_names): Do not actually save data until asked,
3665 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3667 (on_selection_changed),
3668 (modest_connection_specific_smtp_window_init): Disable the edit
3669 button when nothing is selected.
3671 * src/modest-account-mgr-helpers.c:
3672 * src/modest-account-mgr-helpers.h:
3673 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3676 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3678 * src/modest-account-mgr-helpers.h:
3679 * src/modest-account-mgr-helpers.c:
3680 (modest_account_mgr_get_unused_account_name),
3681 (modest_account_mgr_get_unused_account_display_name): Added these
3682 utility functions, to avoid code duplication.
3684 * src/maemo/easysetup/modest-easysetup-wizard.c:
3685 (create_page_account_details), (create_account):
3686 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3687 (on_combo_security_changed),
3688 (modest_connection_specific_smtp_edit_window_init),
3689 (modest_connection_specific_smtp_edit_window_save_settings):
3690 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3691 * src/maemo/modest-connection-specific-smtp-window.c:
3692 (modest_connection_specific_smtp_window_finalize),
3693 (modest_connection_specific_smtp_window_fill_with_connections),
3694 (on_button_edit), (modest_connection_specific_smtp_window_init):
3695 * src/maemo/modest-connection-specific-smtp-window.h:
3696 Implementing saving of connection-specific server accounts.
3698 But I need to refactor this so we can save the data for each
3699 possible connection-specific account and only actually create the server accounts
3700 when the easysetup finished, or the OK button is pressed on the account settings
3703 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3705 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3706 (on_combo_security_changed):
3707 (modest_connection_specific_smtp_edit_window_init):
3708 Auto-fill the port number as in the account settings.
3710 (modest_connection_specific_smtp_edit_window_set_connection):
3711 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3712 * src/maemo/modest-connection-specific-smtp-window.c:
3713 (fill_with_connections), (on_button_edit),
3714 (modest_connection_specific_smtp_window_init):
3715 Turn the edit window into a dialog to simplify the code, and
3716 set a WM hint as in a GtkDialog, because only a popup can be on top of
3717 another window in Maemo, and popups usually have no WM decoration.
3719 * src/modest-defs.h:
3720 * src/modest-account-mgr-helpers.c:
3721 (modest_account_mgr_set_connection_specific_smtp),
3722 (modest_account_mgr_remove_connection_specific_smtp),
3723 (modest_account_mgr_get_connection_specific_smtp):
3724 * src/modest-account-mgr-helpers.h: Some functions to write the
3725 connection-specific SMTP server information. Not yet used.
3728 * src/widgets/modest-folder-view.c: (text_cell_data):
3729 Fix a warning about an uninitialized variable.
3730 (on_configuration_key_changed): Put an #ifdef around the use
3731 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3733 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3735 * src/maemo/modest-account-settings-dialog.h:
3736 * src/maemo/modest-account-settings-dialog.c:
3737 Added connect_for_modified() utility function to mark the new modified boolean.
3739 (create_page_account_details), (create_page_user_details),
3740 (create_page_incoming), (create_page_outgoing), (on_response),
3741 (modest_account_settings_dialog_init),
3742 (modest_account_settings_dialog_set_account_name):
3743 Only warn about unsaved changes when there are actually unsaved changes.
3745 * src/modest-account-mgr-helpers.c:
3746 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3747 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3748 to get the data from there in future.
3750 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3752 * src/modest-defs.h:
3754 * src/modest-account-mgr-helpers.h:
3755 * src/modest-account-mgr-helpers.c:
3756 Store the security account setting in a single conf key instead of using
3757 the options list, so that the list is left for just the to-be-removed camel hack,
3758 and because gconf_client_set_list() is failing for some reason.
3760 * src/modest-account-mgr.c:
3761 (modest_account_mgr_add_server_account):
3762 * src/maemo/modest-account-settings-dialog.c:
3763 (modest_account_settings_dialog_set_account_name),
3764 (save_configuration): Use the renamed functions.
3767 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3769 * src/widgets/Makefile.am:
3770 * src/widgets/modest-limit-retrieve-combo-box.c:
3771 * src/widgets/modest-limit-retrieve-combo-box.h:
3772 * src/widgets/modest-retrieve-combo-box.c:
3773 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3774 the account settings dialog.
3776 * src/modest-defs.h:
3777 * src/modest-account-mgr-helpers.h:
3778 * src/modest-account-mgr-helpers.c:
3779 (modest_server_account_get_option_secure_auth),
3780 (modest_server_account_set_option_secure_auth):
3781 * src/modest-account-mgr.c:
3782 (modest_account_mgr_add_server_account):
3783 Use the existing AUTH_MECH conf key for the secure-auth setting,
3784 instead of putting it in the list options, because this was actually used already.
3786 * src/maemo/modest-account-settings-dialog.c:
3787 (create_page_account_details),
3788 (modest_account_settings_dialog_set_account_name),
3789 (save_configuration):
3790 * src/maemo/modest-account-settings-dialog.h:
3791 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3792 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3794 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3796 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3797 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3798 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3800 * src/modest-defs.h:
3801 * src/maemo/modest-account-settings-dialog.c:
3802 (create_page_incoming), (on_combo_outgoing_security_changed),
3803 (on_combo_incoming_security_changed), (create_page_outgoing),
3804 (modest_account_settings_dialog_set_account_name),
3805 (save_configuration): Load/Save the port number, and change it when the
3806 security combo changes, to suitable defaults.
3808 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3810 * src/modest-account-mgr.c:
3811 (modest_account_mgr_add_server_account): Set the security and secure-auth
3812 options, and add a comment saying that the other camel-specific options should be
3815 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3817 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3819 * src/modest-tny-account-store.c: (account_list_free),
3820 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3821 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3824 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3826 * src/modest-protocol-info.c:
3827 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3828 is required by our UI spec. Maybe something in our implementation will use this eventually.
3829 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3830 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3831 instead of the previous 0 placeholder.
3833 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3834 secure-auth settings.
3835 * src/modest-account-mgr-helpers.h:
3836 * src/modest-account-mgr-helpers.c:
3837 (modest_server_account_data_get_option_secure_auth),
3838 (modest_server_account_set_option_secure_auth),
3839 (modest_server_account_data_get_option_security),
3840 (modest_server_account_set_option_security): Added this API for getting and setting the security
3841 and secure-auth settings.
3843 * src/maemo/modest-account-settings-dialog.h:
3844 * src/maemo/modest-account-settings-dialog.c:
3845 (modest_account_settings_dialog_finalize), (check_data),
3846 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3847 about changing titles.
3848 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3849 (save_configuration): Save the security and secure-auth settings.
3851 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3852 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3854 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3856 * src/modest-defs.h:
3857 * src/modest-account-mgr.c:
3858 (modest_account_mgr_add_server_account):
3859 Added and used defines for the options key and value pair strings,
3860 that are used so far, though they do not seem to correspond to anything in our
3861 UI specs or ModestProtocol enum.
3863 * src/modest-account-mgr-helpers.h:
3864 * src/modest-account-mgr-helpers.c:
3865 (compare_option_strings_for_name),
3866 (modest_server_account_data_get_option_value),
3867 (modest_server_account_data_get_option_bool),
3868 (modest_account_mgr_get_server_account_option):
3869 Added helper functions for parsing the options GSList.
3871 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3873 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3874 display name is based on the supplied account name.
3875 * src/modest-account-mgr.c:
3876 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3877 with an inefficient, but good-enough, implementation.
3879 * src/maemo/easysetup/modest-easysetup-wizard.c:
3880 (create_page_account_details), (on_before_next), (create_account):
3881 Check for existing display names rather than (non-user-visible) account names, and just
3882 create and set a unique account name at the end.
3884 * src/maemo/modest-account-settings-dialog.c:
3885 (modest_account_settings_dialog_init),
3886 (modest_account_settings_dialog_set_account_name),
3887 (create_page_incoming): Show the display name, instead of the account name.
3888 (on_response): Do some (not all) extra checks, as in the UI spec.
3889 (save_configuration): Save the display name if it was changed.
3891 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3893 * po/en_GB.po: Added needed logical ID and translation.
3894 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3895 (init_view): Made the is-default column clicking work.
3897 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3900 * src/maemo/easysetup/Makefile.am:
3901 * src/maemo/easysetup/modest-easysetup-wizard.c:
3902 (modest_easysetup_wizard_dialog_init):
3903 * src/maemo/easysetup/provider-data-test.keyfile:
3904 * src/maemo/easysetup/provider-data.keyfile:
3905 Moved the provider data file to the new modest-providers-data package and used it from there.
3907 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3909 * src/modest-local-folder-info.c:
3910 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3911 N_() was already used on the static strings, but this just marks it for translation without
3912 using the translation.
3914 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3916 * src/maemo/modest-account-settings-dialog.c:
3917 (create_page_incoming),
3918 (modest_account_settings_dialog_set_account_name):
3919 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3920 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3921 I will do this if nobody else gets there first.
3923 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3925 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3926 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3927 save the security stuff.
3929 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3931 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3932 Set the email address and user fullname, which I now see must be
3935 * src/maemo/modest-account-settings-dialog.h:
3936 * src/maemo/modest-account-settings-dialog.c:
3938 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3939 leave-on-server and authentication.
3940 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3943 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3946 * src/maemo/modest-account-settings-dialog.c:
3947 * src/maemo/modest-account-settings-dialog.h:
3948 Most (but not all) of the widgets are now present as specified by the UI spec.
3949 No changes are yet saved, and some details are not properly shown yet.
3951 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3953 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3955 * src/maemo/Makefile.am:
3956 * src/maemo/modest-account-settings-dialog.c:
3957 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3958 an existing account. Doesn't do much yet.
3960 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3961 Open the accounts settings dialog when Edit is clicked.
3963 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3965 * src/maemo/easysetup/Makefile.am:
3966 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3968 * src/maemo/easysetup/modest-easysetup-wizard.c:
3969 (modest_easysetup_wizard_dialog_init):
3970 Try to get the source directory from the build system,
3971 instead of hard-coding "./" into the source code, when opening our local
3972 copies of the configuration files.
3973 But this still fails when opening the wizard from the Accounts window,
3974 maybe because the working directory seems to change at runtime.
3975 So the wizard will fail the second time unless you copy the files into their
3976 proper locations - see the stdout warnings for the paths.
3978 (create_page_account_details),(on_before_next):
3979 Check for existing non-server accounts instead of server accounts,
3980 so the default account name is useful again, and to prevent trying to
3983 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3984 Show the wizard when New is clicked.
3986 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3987 (init_view): Show the column headers, and show the columns that are
3988 specified in the UI specs. However, something in Maemo's GTK+ prevents
3989 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3990 change the default account. This is despite unsetting the special properties.
3992 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3994 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3995 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3996 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3997 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3998 to make that clearer.
3999 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4001 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4003 * src/maemo/modest-account-view-window.c:
4004 (modest_account_view_window_init),
4005 (modest_account_view_window_new):
4006 Use the same buttons as specified in the
4007 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4008 the existing widgets, which never had a chance of working.
4009 Put the ModestAccountView treeview in a scrolled window.
4010 Do not repeat the initialization in both _init() and _new().
4012 * src/widgets/modest-account-view.c: (update_account_view):
4013 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4014 this widget and window shows no accounts.
4016 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4018 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4020 * src/maemo/easysetup/modest-easysetup-wizard.c:
4021 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4022 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4023 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4026 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4027 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4028 accounts exist yet, as in the UI spec.
4030 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4032 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4034 * src/maemo/Makefile.am:
4035 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4036 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4037 New window for editing connection-specific smtp details.
4038 Not fully implemented.
4040 * src/maemo/modest-connection-specific-smtp-window.c:
4041 (modest_connection_specific_smtp_window_finalize) :
4042 unref the tree model.
4043 (on_button_edit): Show the edit window.
4045 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4047 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4050 * src/maemo/Makefile.am:
4051 * src/maemo/modest-connection-specific-smtp-window.c:
4052 * src/maemo/modest-connection-specific-smtp-window.h:
4053 New window for showing the list of connections, for connection-specific
4054 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4055 * src/maemo/easysetup/modest-easysetup-wizard.c:
4056 (create_page_custom_outgoing): Show the new window when the button is clicked.
4058 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4060 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4061 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4062 * src/maemo/modest-msg-edit-window.c:
4063 (modest_msg_edit_window_insert_image):
4064 * src/modest-conf.c: (modest_conf_key_escape):
4065 * src/modest-mail-operation.c:
4066 (modest_mail_operation_send_new_mail):
4067 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4068 (modest_ui_actions_on_new_account):
4069 * src/widgets/modest-attachment-view.c: (update_filename_request):
4070 * src/widgets/modest-mail-header-view.c:
4071 Corrected warnings that were breaking the build, by commenting out unused variables,
4072 and a function, and by including a header.
4074 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4076 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4077 so we can #ifdef around platform-specific code when necessary.
4078 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4079 to allow this to build for the GNOME platform too.
4081 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4083 * src/maemo/easysetup/modest-easysetup-wizard.c:
4084 Added util_increment_name() and used it in create_page_account_details()
4085 to make sure that the default account name is always a new name.
4087 (modest_easysetup_wizard_dialog_init),
4088 (set_default_custom_servernames): Some minor memory management fixes.
4090 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4094 * src/modest-runtime.c: (init_i18n): Restored the translation
4095 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4096 are defined in config.h, and the translations are installed.
4098 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4099 is defined for translation.
4101 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4103 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4105 * src/maemo/easysetup/modest-easysetup-wizard.c:
4106 (modest_easysetup_wizard_dialog_init):
4107 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4108 Use realistic paths (though they should use $prefix generically) to the
4109 mcc_mapping and provider-data.keyfile files which might work when they
4110 are installed by the future version of the operator-wizard package,
4111 and then fallback to paths in our source code, with an explanatory
4114 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4118 * src/maemo/Makefile.am:
4119 * src/maemo/easysetup/: Added files from the previously-exernal
4120 osso-modest-easysetup.
4121 * src/maemo/modest-main-window-ui.h:
4122 * src/modest-ui-actions.c:
4123 * src/modest-ui-actions.h:
4124 Added modest_ui_actions_on_new_account() as a signal handler for the
4125 New Account menu item. It shows the easysetup wizard.
4126 * po/en_GB.po: Added additional needed logical IDs and translations.