1 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
3 reviewed by: <delete if not using a buddy>
5 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
6 * src/modest-ui-actions.c: (folder_refreshed_cb):
8 2007-06-14 Murray Cumming <murrayc@murrayc.com>
10 * src/widgets/modest-folder-view.c: (filter_row):
11 Explictly filter out the per-account outbox accounts. I don't know why
12 these only sometimes show up, but now they should never show up in the UI.
13 This should fix projects.maemo.org bug NB#60160.
15 2007-06-14 Murray Cumming <murrayc@murrayc.com>
17 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
18 when the toolbar does not exist yet.
19 * src/modest-widget-memory.c: (save_settings_header_view):
20 Added g_warnings() to help us to discover when we are trying to set
21 an empty columns list in gconf.
23 2007-06-14 Murray Cumming <murrayc@murrayc.com>
27 Added modest_init_get_default_header_view_column_ids().
29 * src/modest-widget-memory.c: (restore_settings_header_view):
30 Use the new function to get defaults, if the gconf key is empty,
31 instead of not creating any columns. This seems to fix the
32 empty right-hand pane problems.
34 * src/widgets/modest-header-view.h: Improved documentation.
36 2007-06-13 Murray Cumming <murrayc@murrayc.com>
38 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
39 Revert the use of the display name as the account name, because this
40 is generally wrong and would break the code that follows.
42 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
44 * src/maemo/easysetup/modest-easysetup-wizard.c:
45 (check_for_supported_auth_methods), (on_before_next),
48 More correct fix for projects.maemo.org bug NB# 58991
49 Do not longer accept AUTH_PASSWORD as secure method and choose
50 correct method when creating the account.
52 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
54 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
55 Fixed projects.maemo.org bug NB# 58991
57 2007-06-13 Murray Cumming <murrayc@murrayc.com>
59 * src/modest-init.c: (modest_init_init_core),
60 (modest_init_local_folders): Fixed compilation errors.
62 2007-06-13 Murray Cumming <murrayc@murrayc.com>
64 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
65 Remove unnecessary lib/include, though it is good in principle when needed.
67 * src/modest-init.c: (modest_init_one_local_folder),
68 (modest_init_local_folders):
69 * src/modest-init.h: Initialize the .modest library for memory cards,
70 instead of just doing nothing for them. This should allow us to create
71 folders there, fixing projects.maemo.org bug NB#59297.
73 2007-06-13 Murray Cumming <murrayc@murrayc.com>
75 * libmodest-dbus-client/libmodest-dbus-client.c:
76 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
77 (libmodest_dbus_client_compose_mail),
78 (libmodest_dbus_client_open_message),
79 (libmodest_dbus_client_send_and_receive),
80 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
82 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
83 (on_idle_open_message), (modest_dbus_req_handler),
84 (search_result_to_message), (modest_dbus_req_filter):
85 * src/modest-search.c: (add_hit), (modest_search_folder),
86 (modest_search_all_accounts): Improved debug messages.
88 * tests/dbus_api/test_open_message.c: (main): Improved comments.
90 * src/modest-tny-account-store.c:
91 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
94 2007-06-13 Murray Cumming <murrayc@murrayc.com>
97 2007-06-12 Murray Cumming <murrayc@murrayc.com>
99 * src/modest-tny-account-store.c: (get_server_accounts):
100 Call modest_tny_local_folders_account_add_merged_outbox_folders()
101 even when there are no accounts, so that the Outbox folder is always
102 visible. This fixes projects.maemo.org bug NB#60158.
104 2007-06-12 Murray Cumming <murrayc@murrayc.com>
106 * src/maemo/modest-main-window.c: (create_details_widget):
107 Use the mcen_va_never logical ID.
109 2007-06-12 Murray Cumming <murrayc@murrayc.com>
111 * src/dbus_api/modest-dbus-api.h:
112 * src/dbus_api/modest-dbus-callbacks.c:
113 (on_idle_open_default_inbox), (on_open_default_inbox),
114 (modest_dbus_req_handler):
115 Added a new OpenDefaultInbox method.
117 * libmodest-dbus-client/libmodest-dbus-client.h:
118 * libmodest-dbus-client/libmodest-dbus-client.c:
119 Added libmodest_dbus_client_open_default_inbox() to call the new
120 dbus method. This should be useful to projects.maemo.org bug NB#57214,
121 though it should maybe be used by a new osso-email-interface function.
123 * tests/dbus_api/Makefile.am:
124 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
127 2007-06-12 Murray Cumming <murrayc@murrayc.com>
129 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
130 NULL, so that the signals get all the keys. This should not actually
131 change any behaviour because we currently update everything when anything
134 2007-06-12 Murray Cumming <murrayc@murrayc.com>
136 * src/widgets/modest-folder-view.c: (text_cell_data),
137 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
138 (find_inbox_iter): If tinymail tells us that the folder is
139 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
140 This causes the inbox to be selected at startup, fixing part of
141 projects.maemo.org bug NB#56305.
143 * src/modest-ui-dimming-rules.c:
144 (modest_ui_dimming_rules_on_tools_smtp_servers):
145 * src/modest-ui-dimming-rules.h: Added a callback function to dim
146 the SMTP servers menu item.
147 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
148 that the SMTP Servers menu item is dimmed when there are no accounts,
149 as a future version of the UI spec will require. This fixes
150 projects.maemo.org bug NB#56305.
152 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
154 * src/maemo/modest-maemo-utils.c:
155 (modest_maemo_utils_get_supported_secure_authentication_methods):
156 Added label to dialog instead of unreadable title
158 * src/maemo/modest-main-window.c: (sync_accounts_cb),
159 (modest_main_window_new):
160 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
163 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
164 * src/modest-account-mgr.h:
165 Added method to avoid code duplication
167 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
168 (modest_ui_actions_on_send_receive):
169 Use modest_account_mgr_has_accounts
171 2007-06-11 Murray Cumming <murrayc@murrayc.com>
173 * src/maemo/easysetup/modest-presets.c:
174 (modest_presets_get_info_server_security): Do not report secure auth
176 * src/modest-protocol-info.c: Use the defines for the gconf key names
177 for secure authentication. This was not working because we were writing
178 Password and reading password, and the check was case sensitive.
179 With this, gmail now works for receiving and sending when created via
182 2007-06-11 Murray Cumming <murrayc@murrayc.com>
184 * src/maemo/easysetup/modest-presets.c:
185 (modest_presets_get_info_server_security): Correct the key name for
186 SecureSmtp, because it seems to be case-sensitive.
187 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
188 Do not try to get the 0th notebook page if there are 0 pages, to
191 2007-06-11 Murray Cumming <murrayc@murrayc.com>
193 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
194 Prevent use of the new notification feature for now, because it currently
195 shows one dialog for each new email, which is annoying.
197 2007-06-11 Murray Cumming <murrayc@murrayc.com>
199 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
200 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
201 when no country was selected, so that we show the global ones.
202 * src/maemo/easysetup/modest-presets.c:
203 (modest_presets_get_providers): Return only the global providers, not
204 all providers when mmc=0 was requested.
206 2007-06-11 Murray Cumming <murrayc@murrayc.com>
208 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
209 (easysetup_provider_combo_box_fill): Remove debug code that showed the
210 provider ID in the combo.
212 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
213 Do not show the page numbers, because it would be confusing when we add
214 the 2 extra pages for the custom setup, when the user chooses the "Other"
215 provider. This fixes projects.maemo.org bug NB#59028
217 * src/modest-init.c: (modest_init_init_core),
218 (modest_init_local_folders):
220 * src/modest-tny-account.c:
221 (modest_tny_account_new_for_local_folders): Do not create default folders
222 for the memory card. This should fix projects.maemo.org bug NB#59328.
224 2007-06-11 Murray Cumming <murrayc@murrayc.com>
226 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
227 Free the changed_conf_keys string items. They are already freed in the
228 idle handler if that runs first.
230 2007-06-11 Murray Cumming <murrayc@murrayc.com>
232 * src/modest-ui-actions.c:
233 (modest_ui_actions_on_password_requested): Check that the server name
234 is not NULL, because I just saw a password dialog with (null) as the
237 * src/modest-tny-folder.[h|c]: Added
238 modest_tny_folder_is_memory_card_folder().
239 * src/modest-ui-dimming-rules.c:
240 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
241 menu item for memory cards, as per the UI spec (section 7.4). This should
242 fix projects.maemo.org bug NB#59297.
244 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
246 * src/maemo/modest-main-window.c: (sync_accounts_cb):
247 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
248 is another problem with the code, see Murray's comment at line 772)
250 2007-06-08 Murray Cumming <murrayc@murrayc.com>
252 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
253 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
254 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
255 (load_from_file), (easysetup_country_combo_box_init),
256 (easysetup_country_combo_box_get_active_country_ids),
257 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
258 instead of just one ID, to avoid duplicate country names in the UI.
260 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
261 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
262 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
263 a single ID, avoiding duplicate providers.
264 * src/maemo/easysetup/modest-easysetup-wizard.c:
265 (on_combo_account_country): Adapt to use a list.
267 2007-06-08 Murray Cumming <murrayc@murrayc.com>
269 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
270 keys changed in the last X seconds.
272 * src/modest-account-mgr.h:
273 * src/modest-account-mgr.c: (on_timeout_notify_changes),
274 (on_key_change), (modest_account_mgr_class_init),
275 (modest_account_mgr_init), (modest_account_mgr_finalize):
276 As the keys are changed, save them in a GSList* and signal that GSList*
277 further every X seconds, to batch changes, to allow us to do just one
278 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
279 bug NB#56941 and other (UI-blocking) delays when changing account settings.
281 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
282 changed signal signature.
284 * src/modest-conf.c: (modest_conf_set_list),
285 (modest_conf_on_change): Reenable notification.
287 (modest_conf_maemo_fake_on_change): Comment out the hack that
288 notified immediately instead of asynchronously.
290 * src/widgets/modest-account-view.h:
291 * src/widgets/modest-account-view.c:
292 (update_account_view): Select the previously-selected account ID,
293 if possible. This fixes projects.maemo.org bug NB#56933.
295 (on_account_changed), (on_account_removed),
296 (modest_account_view_select_account):
298 Remove the block/unblock functions
299 because they were not useful.
301 * src/maemo/modest-account-view-window.c:
302 (on_delete_button_clicked), (on_edit_button_clicked),
303 (on_new_button_clicked): Remove the use of the non-working block/unblock.
305 2007-06-08 Murray Cumming <murrayc@murrayc.com>
307 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
308 Improve the error dialog to show Incorrect Account Settings, which seems
309 clearer, and say that the internal error message (to be removed from the
310 dialog later) is often misleading.
311 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
313 * src/modest-tny-account.c:
314 (modest_tny_account_new_from_server_account): Uncomment the printf of the
315 URL because this is so useful for debugging on the device.
317 * src/widgets/modest-serversecurity-combo-box.c:
318 (modest_serversecurity_combo_box_fill): Correct a logical ID.
320 2007-06-08 Murray Cumming <murrayc@murrayc.com>
322 * src/modest-mail-operation.c:
323 (modest_mail_operation_send_new_mail):
324 Added a comment about a nasty but apparently harmless message. Details
325 added to the wiki g_warnings() page.
327 2007-06-08 Murray Cumming <murrayc@murrayc.com>
329 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
330 (modest_tny_send_queue_class_init):
331 Do not use the priv struct because it is empty, to avoid g_warnings
332 about a non-existant priv struct.
334 * src/modest-tny-account-store.c:
335 (modest_tny_account_store_get_server_account),
336 (modest_tny_account_store_get_transport_account_for_open_connection
337 ): Do not try to get transport server accounts for local folders,
338 because they don't have any. This avoids a g_warning().
340 * src/maemo/modest-main-window.c:
341 (modest_main_window_notify_send_receive_initied),
342 (on_configuration_key_changed):
343 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
345 * src/modest-mail-operation.c:
346 (modest_mail_operation_update_account):
347 * src/modest-tny-account-store.h:
348 * src/modest-tny-account.c:
349 (modest_tny_account_get_special_folder),
350 (modest_tny_account_new_for_local_folders),
351 (modest_tny_account_new_for_per_account_local_outbox_folder):
352 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
353 * src/modest-tny-local-folders-account.c:
354 (add_account_folders_to_merged_folder):
355 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
356 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
357 (modest_ui_actions_on_send):
358 * src/widgets/modest-folder-view.c: (update_model):
359 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
360 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
361 modest_tny_account_store_get_tny_account_by_account() to
362 modest_tny_account_store_get_server_account() to make the code clearer.
364 2007-06-07 Marcus Bauer <marcusb@openismus.com>
366 * src/dbus_api/modest-dbus-api.h:
367 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
368 * src/maemo/modest-msg-edit-window.c:
369 (modest_msg_edit_window_attach_file_noninteractive):
370 added g_warning in case the file to be attached does not exist
371 * tests/dbus_api/test_compose_mail.c: (main):
372 removed obsolete comment, added generic files as test case
374 2007-06-07 Murray Cumming <murrayc@murrayc.com>
376 * src/modest-tny-account-store.c: (get_server_accounts):
377 Create the local folders account only once, not once for each outbox, and
378 not only when there are some outboxes.
380 2007-06-07 Murray Cumming <murrayc@murrayc.com>
382 * src/widgets/modest-folder-view.c: (update_model): Comment out some
383 code that is causing a crash at startup. Sergio says that he is fixing this.
385 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
387 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
388 * src/maemo/modest-account-settings-dialog.c:
389 (create_page_outgoing),
390 (modest_account_settings_dialog_set_account_name),
391 (save_configuration):
392 - Fixed handling of the "Use secure authentication" toggle to comply with
393 the ui specification. See also projects.maemo.org bug NB#58400
395 - Restore the Secure connection setting combo correctly when loading
398 * src/maemo/modest-maemo-utils.c:
399 (on_camel_account_get_supported_secure_authentication),
400 (modest_maemo_utils_get_supported_secure_authentication_methods):
401 Fixed a crasher if operation is canceled
403 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
404 (modest_protocol_info_auth_is_secure):
405 * src/modest-protocol-info.h:
407 Added two new methods to determine if a protocol/auth method is secure/encrypted in
408 the sense of the "Use secure authentication" toggle.
410 2007-06-07 Murray Cumming <murrayc@murrayc.com>
412 * src/modest-tny-account-store.h:
413 * src/modest-tny-account-store.c:
414 Added modest_tny_account_store_get_local_folders_account().
416 * src/modest-tny-folder.h:
417 * src/modest-tny-folder.c:
418 (modest_tny_folder_get_account):
419 Added this replacement for tny_folder_get_account() which returns
420 the local-folders account for TnyMergeFolders, to avoid the
421 warning about the unimplemented get_account_func() vfunc().
423 (modest_tny_folder_get_rules),
424 * src/modest-ui-actions.c:
425 (modest_ui_actions_on_folder_selection_changed):
426 * src/modest-mail-operation.c:
427 (modest_mail_operation_remove_folder),
428 (modest_mail_operation_xfer_folder),
429 (modest_mail_operation_rename_folder),
430 (modest_mail_operation_get_msg),
431 (modest_mail_operation_get_msgs_full),
432 (modest_mail_operation_remove_msg),
433 (modest_mail_operation_xfer_msgs),
434 (modest_mail_operation_refresh_folder):
435 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
437 2007-06-07 Murray Cumming <murrayc@murrayc.com>
439 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
440 (modest_server_account_set_security):
441 * src/modest-defs.h: Add comments explaining that our
442 UI spec means TLS when it says Normal, so these do not look like errors.
444 * src/modest-tny-account.c:
445 (modest_tny_account_new_from_server_account): Use the new tinymail
446 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
447 for TLS. This should fix projects.maemo.org bug NB#58460.
449 2007-06-06 Murray Cumming <murrayc@murrayc.com>
451 * src/maemo/easysetup/modest-easysetup-wizard.c:
452 (create_account): Correct the position of the gconf sanity check warning.
453 (on_button_edit_advanced_settings): Show the dialog immediately, instead
454 of using the g_idle_add() hack, because this does not seem to be necessary
455 on osso 1.1. It might even work on Maemo Bora if the problems were actually
456 caused by something other than maemo's gconf.
457 This fixes projects.maemo.org bug #59022.
459 2007-06-06 Murray Cumming <murrayc@murrayc.com>
461 * src/modest-account-mgr-helpers.c:
462 (modest_account_mgr_get_default_account): Do not check that the account
463 exists if there is no default account (NULL), to fix a runtime warning.
465 2007-06-06 Murray Cumming <murrayc@murrayc.com>
467 * src/widgets/modest-folder-view.c: (update_model):
468 Do not unref the treemodel before we have finished with it.
469 This prevents a valgrind warning and an occasional crash at startup.
471 2007-06-06 Marcus Bauer <marcusb@openismus.com>
473 * libmodest-dbus-client/libmodest-dbus-client.h:
474 added libmodest_dbus_client_compose_mail()
475 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
477 added functions needed for SendAsMail() functionality
478 * src/maemo/modest-msg-edit-window.c:
479 (modest_msg_edit_window_attach_file_noninteractive):
480 non interactively attaching files to message edit window
481 * src/widgets/modest-msg-edit-window.h:
482 * tests/dbus_api/Makefile.am:
483 added test_compose_mail.c
484 * tests/dbus_api/test_compose_mail.c: (main):
486 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
488 * src/modest-account-view.c:
489 Fixed bug projects.maemo.org bug NB#59307
491 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
493 * src/maemo/easysetup/modest-easysetup-wizard.c:
494 (get_serverport_incoming), (on_before_next), (create_account):
495 * src/maemo/modest-account-settings-dialog.c:
496 (modest_account_settings_dialog_set_account_name):
497 * src/maemo/modest-maemo-utils.c:
498 (on_camel_account_get_supported_secure_authentication_status),
499 (on_camel_account_get_supported_secure_authentication),
500 (on_secure_auth_cancel),
501 (modest_maemo_utils_get_supported_secure_authentication_methods):
503 Implemented security authentication for settings and easysetup.
505 2007-06-05 Murray Cumming <murrayc@murrayc.com>
507 * src/maemo/modest-main-window.c: (create_details_widget):
508 Show the total size for memory card accounts too, instead of showing
509 the name again. Fixes bug projects.maemo.org bug NB#59307.
511 2007-06-05 Murray Cumming <murrayc@murrayc.com>
514 * src/modest-tny-simple-folder-store.c:
515 * src/modest-tny-simple-folder-store.h: Removed.
517 * src/modest-tny-local-folders-account.h
518 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
519 for the local-folders maildir, with an extra TnyMergedFolder containing
520 the folders of the per-account outbox store accounts.
521 * src/modest-tny-account-store.c: (get_server_accounts):
522 Add the outboxes to the special local folders account after creating it.
524 * src/modest-tny-account.c:
525 (modest_tny_account_new_for_local_folders): Create the derived
526 account when creating the main local-folders account.
528 * src/maemo/modest-main-window.c: (create_details_widget),
529 (modest_main_window_set_contents_style):
530 Adapted to the use of the derived account instead of the folder store.
532 * src/modest-ui-actions.c:
533 (modest_ui_actions_on_folder_selection_changed):
534 * src/modest-ui-dimming-rules.c:
535 (modest_ui_dimming_rules_on_new_folder):
536 * src/widgets/modest-folder-view.c: (text_cell_data),
537 (icon_cell_data), (filter_row), (update_model),
538 (get_cmp_rows_type_pos):
541 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
542 Do not get the priv struct, because no priv struct has been set,
543 to avoid a runtime warning.
545 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
546 #ifelse with #else, to fix a warning, to fix the build.
549 2007-06-05 Christian Kellner <ckellner@openismus.com>
551 * libmodest-dbus-client/libmodest-dbus-client.c:
552 Fix small typo in doc (why do you always see them
553 AFTER committing stuff?)
556 2007-06-05 Christian Kellner <ckellner@openismus.com>
558 * libmodest-dbus-client/libmodest-dbus-client.c:
559 (libmodest_dbus_client_search):
560 Initialize hit list with NULL. Also set folder list
561 to "" if NULL was supplied.
564 2007-06-03 Christian Kellner <ckellner@openismus.com>
566 * libmodest-dbus-client/libmodest-dbus-client.c:
567 (modest_search_hit_list_free):
568 Make it save to call it with NULL.
570 * src/dbus_api/modest-dbus-callbacks.c:
571 * src/modest-search.c:
572 Return full ModestSearchHits as the search result list not TnyHeader
573 since can't be around withouth the correspoding TnyFolder.
575 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
577 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
578 Added currently commented code to check for secure auth
580 * src/maemo/modest-account-settings-dialog.c: (on_response),
581 (save_configuration), (show_ok):
582 Fixed projects.maemo.org bugs NB #59248 and #59251
584 * src/maemo/modest-maemo-utils.c:
585 (on_camel_account_get_supported_secure_authentication_status),
586 (on_camel_account_get_supported_secure_authentication),
587 (modest_maemo_utils_get_supported_secure_authentication_methods):
588 * src/maemo/modest-maemo-utils.h:
589 Moved get_supported_secure_authentication() method here to be able
590 to use it from easysetup wizard.
592 * src/modest-pair.c: (on_pair_compare_as_string):
593 Should compare string with first part of pair and not
594 strcmp pairs which will crash.
596 * src/modest-protocol-info.c:
597 (modest_protocol_info_protocol_is_store):
598 * src/modest-protocol-info.h:
599 Added modest_protocol_info_get_auth_protocol_name()
601 2007-06-03 Armin Burgmeier <armin@openismus.com>
603 * src/modest-mail-operation.c:
604 (modest_mail_operation_get_msgs_full): Set priv->account also when
605 only retrieving a single message. This avoids a crash when canceling
608 (modest_mail_operation_notify_end): Do not explicitely remove the
609 operation from the queue but only emit the progress_changed signal.
610 The queue itself listens to that signal to remove the operation when
611 it is finished. This reduces coupling and removes a potential deadlock
612 when modest_mail_operation_notify_end() is called from the queue
613 itself. If that is a problem performance-wise, I would suggest to
614 implement a status-changed signal or something.
616 * src/modest-mail-operation-queue.c: Make sure to never call a
617 function from another file while the queue is locked. This (hopefully)
618 fixes another deadlock when exiting the application while retrieving
621 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
623 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
624 Fixed build if libogs is not available
626 2007-06-03 Christian Kellner <ckellner@openismus.com>
628 * libmodest-dbus-client/libmodest-dbus-client.h:
629 * libmodest-dbus-client/libmodest-dbus-client.c:
630 (libmodest_dbus_client_delete_message):
631 Implement deletion of messages (Client side).
633 (modest_search_hit_free),
634 (modest_search_hit_list_free):
635 Utility functions to free the result hits.
637 * src/dbus_api/modest-dbus-api.h:
638 * src/dbus_api/modest-dbus-callbacks.c:
640 (modest_dbus_req_handler):
641 Implement deletion of messages (Server side).
643 * tests/dbus_api/test_search.c: (main):
646 * tests/dbus_api/Makefile.am:
647 * tests/dbus_api/test_delete_message:
648 Add little test for the message deletion logic
650 2007-06-03 Armin Burgmeier <armin@openismus.com>
652 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
653 when the operation queue was not empty. projects.maemo.org bug
656 2007-06-03 Armin Burgmeier <armin@openismus.com>
658 * src/widgets/modest-account-view.c
659 (on_account_default_toggled): Toggle default account column
660 explicitely instead of waiting for gconf notification (which is
661 currently ignored). This should fix projects.maemo.org bug NB#56910
662 for now. It should probably be removed when gconf notifications are
665 2007-06-03 Christian Kellner <ckellner@openismus.com>
667 * libmodest-dbus-client/libmodest-dbus-client.c:
668 Removed debugging spew.
670 * src/dbus_api/modest-dbus-callbacks.c:
671 Added debugging info.
673 * src/modest-search.c:
674 (modest_search_all_accounts):
675 Use tny_account_store_get_accounts () on the account store
676 to get all accounts which is the way to get all accounts.
678 * tests/dbus_api/test_search.c: (main):
679 Make it possible to supply the search term on the command line.
681 2007-06-03 Christian Kellner <ckellner@openismus.com>
683 * libmodest-dbus-client/libmodest-dbus-client.c:
684 * libmodest-dbus-client/libmodest-dbus-client.h:
685 Implement searching for mesages over raw dbus. (Client side)
687 * src/dbus_api/Makefile.am:
688 * src/dbus_api/modest-dbus-api.h:
689 * src/dbus_api/modest-dbus-callbacks.c:
690 * src/dbus_api/modest-dbus-callbacks.h:
691 Search framework (Server side). Also implement on_idle_open_message().
693 * src/maemo/modest-platform.c: (modest_platform_init):
694 Prepare for raw dbus/osso rpc interaction.
696 * src/modest-search.h:
697 Changed minsize from unspecific guint to guint32.
699 * src/modest-search.c:
701 Added strange hack which magically made tnymail work.
703 (modest_search_folder),
704 (modest_search_account),
705 (modest_search_all_accounts):
706 Implement helper functions to search all accounts, specific account
709 * tests/dbus_api/Makefile.am:
710 * tests/dbus_api/test_open_message.c:
711 Read url to open from commandline.
713 * tests/dbus_api/test_search.c:
714 Implement small test for dbus search stuff
716 2007-06-02 Armin Burgmeier <armin@openismus.com>
718 * src/maemo/modest-account-settings-dialog.c: Changed window title to
719 include account type and account title. This fixes projects.maemo.org
722 * src/maemo/modest-account-view-window.c: Set a title for the window.
724 2007-06-02 Armin Burgmeier <armin@openismus.com>
726 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
727 incoming and outgoing server name based on email address and server
728 types as long as the names have not been edited manually. This fixes
729 projects.maemo.org bug NB#58671.
731 2007-06-02 Armin Burgmeier <armin@openismus.com>
733 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
734 server type cannot be changed in future to the incoming details page
735 when creating an account. This fixes projects.maemo.org bug NB#59029.
737 2007-06-02 Armin Burgmeier <armin@openismus.com>
739 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
740 and assigned max width chars so that they wrap instead of being
741 truncated. Fixes projects.maemo.org bug NB#56126.
743 2007-06-02 Armin Burgmeier <armin@openismus.com>
745 * src/maemo/modest-connection-specific-smtp-window.c: Add an
746 introductory note to the connection specific smtp servers dialog, as
747 section 8.12 of the email UI specification requires. This fixes
748 projects.maemo.org bug NB#59212.
750 2007-06-01 Murray Cumming <murrayc@murrayc.com>
752 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
753 Check for running mail operations, and offer to cancel them, as per the UI
754 spec. This fixes projects.maemo.org bug NB#59041 .
755 However, I suspect that tinymail may still use the network connection
756 in ways that we cannot detect or cancel. But it should at least adapt to
759 2007-06-01 Murray Cumming <murrayc@murrayc.com>
761 * src/modest-tny-account-store.c: (recreate_all_accounts),
762 (get_cached_accounts), (get_server_accounts): Do more sensible
763 ref-counting of the temporarily-cached outbox accounts list. This seems
764 to fix a crash when entering the password when the password was wrong.
766 2007-06-01 Murray Cumming <murrayc@murrayc.com>
768 * src/gnome/modest-main-window.c: (connect_signals):
769 * src/modest-tny-account-store.c: (get_password),
770 (modest_tny_account_store_alert): Added comments and clues and
771 commented-out code about how we currently fail to deal with connection
772 errors and wrong passwords, and how we should.
774 2007-06-01 Murray Cumming <murrayc@murrayc.com>
776 * src/widgets/modest-retrieve-combo-box.c:
777 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
778 This fixes projects.maemo.org bug NB#58472 .
780 2007-06-01 Murray Cumming <murrayc@murrayc.com>
782 * src/maemo/easysetup/modest-easysetup-wizard.c:
783 (create_page_complete_easysetup):
784 (create_page_complete_custom): Correct the last commit,
785 putting the correct sentences in the correct pages.
787 2007-06-01 Murray Cumming <murrayc@murrayc.com>
789 * src/maemo/easysetup/modest-easysetup-wizard.c:
790 (create_page_complete_custom): Show the second sentence of text
791 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
794 2007-06-01 Murray Cumming <murrayc@murrayc.com>
796 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
797 Set the leave-on-server conf key by default. This fixes
798 projects.maemo.org bug NB#59258 .
800 2007-06-01 Murray Cumming <murrayc@murrayc.com>
802 * src/maemo/modest-account-view-window.c:
803 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
804 logical ID for the confirmation messages. Fixed projects.maemo.org bug
807 2007-06-01 Murray Cumming <murrayc@murrayc.com>
809 * src/maemo/easysetup/modest-easysetup-wizard.c:
810 (create_caption_new_with_asterisk):
811 * src/maemo/modest-account-settings-dialog.c:
812 (create_caption_new_with_asterisk):
813 Uncomment the code to add the asterisk, because they are no longer in the
814 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
815 (update_incoming_server_title): Add an asterisk here too.
817 2007-06-01 Murray Cumming <murrayc@murrayc.com>
819 * src/maemo/modest-maemo-global-settings-dialog.c:
820 (current_connection): Check that we are even connected before trying to
821 get the current connection name, to prevent a warning.
823 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
824 Change the comments because tny_maemo_conic_device_connect() is now meant to
826 * src/modest-mail-operation.c:
827 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
828 make sure we have a connection and fail if we can't connect.
830 2007-05-31 Murray Cumming <murrayc@murrayc.com>
832 * src/maemo/modest-main-window.c:
833 (on_account_store_connecting_finished): Do not try to get the
834 connection ID if we are not really connected. I am surprised that
835 this signal handler is called when we are not connected.
837 2007-05-31 Murray Cumming <murrayc@murrayc.com>
839 * src/modest-error.h:
840 * src/modest-ui-actions.c:
841 (modest_ui_actions_get_msgs_full_error_handler):
842 Renamed an enum, added comments, added an enum
843 for retrieve-limit errors.
845 * src/modest-mail-operation.c: (foreach_add_item),
846 (internal_folder_observer_update), (update_account_thread),
847 (modest_mail_operation_get_msgs_full):
848 (modest_mail_operation_update_account),
849 Added comments about how this works, and some code that should
850 (but does not) check the retrieve-limit. See the TODO comment.
852 2007-05-31 Murray Cumming <murrayc@murrayc.com>
854 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
855 Initialize help_id to fix the build. Warnings are good.
857 2007-05-31 Murray Cumming <murrayc@murrayc.com>
859 * src/widgets/modest-hbox-cell-renderer.c:
860 (modest_hbox_cell_renderer_append):
861 * src/widgets/modest-vbox-cell-renderer.c:
862 (modest_vbox_cell_renderer_append):
863 Fix the last commit by doing an extra ref.
865 2007-05-31 Murray Cumming <murrayc@murrayc.com>
867 * src/widgets/modest-hbox-cell-renderer.c:
868 (modest_hbox_cell_renderer_append):
869 * src/widgets/modest-vbox-cell-renderer.c:
870 (modest_vbox_cell_renderer_append):
871 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
872 to fix the build with Maemo Bora.
873 However, there seems to be a remaining crash, probably due to reference
876 2007-05-30 Murray Cumming <murrayc@murrayc.com>
878 * src/modest-tny-account.c:
879 (modest_tny_account_new_for_local_folders):
880 Use hildon_file_system_info_async_new() to get a better name for
881 the memory card account, setting it as the account name.
882 The timing seems to work, but this is probably
883 not the best place to do this. See the TODO comment.
884 * src/maemo/modest-main-window.c: (create_details_widget):
885 * src/widgets/modest-folder-view.c: (text_cell_data):
886 Use the tny account name instead of hardcoding a name.
888 2007-05-30 Christian Kellner <ckellner@openismus.com>
890 * src/modest-search.c: (modest_search):
891 Correctly set part_search_func even if we have already parsed
892 the query and thus a valid OgsTextSearcher object.
894 2007-05-30 Christian Kellner <ckellner@openismus.com>
897 Search and check for libogs.
900 Incooparte the ogs build env.
902 * src/modest-mime-part-search-stream.c:
903 * src/modest-mime-part-search-stream.h:
904 Removed since we do the real searching now in modest-search.c.
906 * src/modest-search.c:
907 * src/modest-search.h:
908 Implement support for ogs. We use that if available and requested
909 and fall back to modest_text_utils_utf8_strcmp (). The search logic
910 should now handle the corner case when the search term is spread
911 across multiple reads.
912 Also the logic in modest_search () was corrected to search all
913 requested fields until one is found.
915 2007-05-30 Murray Cumming <murrayc@murrayc.com>
917 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
920 * src/modest-init.c: Made modest_init_local_folders() take a
921 path and be public so we can iniitialize maildir folders on
924 * src/modest-local-folder-info.h:
925 * src/modest-local-folder-info.c:
926 (modest_local_folder_info_get_maildir_path): Add a path parameter.
928 * src/modest-tny-account.c:
929 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
930 still means the standard local-folders path on the local volume.
932 * src/modest-tny-account-store.c:
933 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
934 signal so we can detect mount/unmount of the MMC1 card, and do an update of
935 all accounts when that happens.
936 (get_server_accounts): If the MMC1 card is mounted, create a store account for
937 this too, so it shows up in the treeview.
939 2007-05-28 Murray Cumming <murrayc@murrayc.com>
941 * src/maemo/modest-maemo-global-settings-dialog.c:
942 (current_connection):
943 * src/widgets/modest-global-settings-dialog.c:
944 (current_connection_default):
945 Use the enum values instead of 0, 1 and -1,
946 to make the code clearer.
948 * src/modest-account-mgr-helpers.c:
949 (modest_account_mgr_get_connection_specific_smtp): Make this code
952 * src/modest-runtime.h:
953 * src/modest-runtime.c:
954 Added modest_runtime_remove_all_send_queues().
955 * src/maemo/modest-main-window.c:
956 (on_account_store_connecting_finished): Recreate the send queues,
957 using the appropriate transport accounts for this new connection.
958 Some futher adapting might be needed if the old send queues are not
959 automatically stopped at this point.
961 * src/modest-tny-account-store.c: (get_server_accounts):
962 Create the connection-specific transport accounts, so that they can
963 be found later by their ID.
965 * src/modest-tny-account.h:
966 * src/modest-tny-account.c:
967 Added modest_tny_account_new_from_server_account_name().
968 modest_tny_account_new_from_server_account(): Do not create the
969 send queues here, because they will be
970 recreated anyway when the connection changes for the first time.
972 2007-05-28 Murray Cumming <murrayc@murrayc.com>
974 * src/modest-local-folder-info.h:
975 * src/modest-local-folder-info.c:
976 (modest_per_account_local_outbox_folder_info_get_maildir_path),
977 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
978 tbox_folder): Take a modest account name instead of a server TnyAccount,
979 so we can have per-modest-account rather than per-transport-account
981 We must make sure that we change or recreate the exisitng send queues
982 when the connection changes for connection-specific transport accounts.
984 * src/modest-tny-account-store.c:
985 (create_per_account_local_outbox_folders): Create outboxed per modest
986 account, not per transport account.
988 * src/modest-tny-account.h:
989 * src/modest-tny-account.c:
990 (modest_tny_account_get_special_folder): For outboxes, get the
991 parent modest account name. The account is ignored for other folders.
992 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
993 modest account name rather than a server TnyAccount.
995 2007-05-25 Murray Cumming <murrayc@murrayc.com>
997 * src/modest-tny-account.c:
998 (modest_tny_account_new_from_server_account):
999 Call modest_runtime_get_send_queue() immediately after creating transport
1000 accounts, so that they start trying to send email from the outbox as soon
1001 as possible at startup. This is probably what we want.
1003 * src/modest-mail-operation.c: (update_account_thread):
1004 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1005 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1006 * src/modest-tny-send-queue.h:
1007 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1008 (modest_ui_actions_on_send):
1009 Added comments about how sending works, though it needs some more work.
1011 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1013 * src/modest-tny-account.c:
1014 (modest_tny_account_get_special_folder): Add TODO because this fails when
1015 the network is busy.
1016 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1017 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1018 Do not try to show this window when there is no active account. The UI
1019 specs does not tell us what to do in this case.
1021 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1025 * src/maemo/Makefile.am:
1026 * src/widgets/Makefile.am: Some dist fixes.
1028 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1030 * src/maemo/modest-connection-specific-smtp-window.c:
1031 (on_button_edit): Make the code clearer, to prevent a double free.
1033 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1035 * src/maemo/modest-account-settings-dialog.c:
1036 (modest_account_settings_dialog_set_account_name),
1037 Check the connection-specific smtp servers checkbox if there are any.
1039 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1040 (modest_connection_specific_smtp_edit_window_init):
1041 Start with a suitable port number.
1043 * src/modest-account-mgr-helpers.h:
1044 * src/modest-account-mgr-helpers.c: Added
1045 modest_account_mgr_get_has_connection_specific_smtp().
1047 (modest_account_mgr_set_connection_specific_smtp),
1048 (modest_account_mgr_remove_connection_specific_smtp),
1049 (modest_account_mgr_get_has_connection_specific_smtp),
1050 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1051 connection-specific smtp server accounts in the account, rather than
1052 the server account conf dir.
1054 This fixes bug projects.maemo.org bug NB#58263 .
1056 * src/modest-tny-account-store.c:
1057 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1058 if there are no server accounts yet, to prevent an infinite loop when there
1059 are no accounts. Document that one must be called before the other.
1061 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1063 * src/modest-account-mgr-helpers.c:
1064 (modest_account_mgr_get_default_account): Make sure that at least
1065 one account is always the default, if there are any enabled accounts.
1066 This is just a sanity check that shouldn't be necessary.
1068 * src/modest-account-mgr-priv.c:
1069 (_modest_account_mgr_account_from_key): Unescape the conf key to
1070 get the real account name. For instance, this is an issue if a space
1071 was in the account name, which can happen because the account name
1072 is generated from the display name.
1073 (_modest_account_mgr_get_account_keyname): Always escape the
1075 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1076 Unescape the conf keys to get the real account names.
1078 For instance, previously the is-default radio button in the accounts
1079 list was not checked for any accounts at first. This fixes that,
1080 and might fix several similar bugs.
1082 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1084 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1085 Removed some debug printfs.
1087 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1089 Modest on-disk outbox directories are now here, for instance:
1090 $HOME/.modest/outboxes/<account-id-1>/outbox
1091 $HOME/.modest/outboxes/<account-id-2>/outbox
1093 $HOME/.modest/local-folders/outbox
1094 so we can have a separate outbox for each account.
1095 But they are shown as one outbox in the GtkTreeView, by using a
1096 TnyMergeFolder in a ModestTnySimpleFolderStore.
1099 * src/modest-tny-simple-folder-store.c:
1100 * src/modest-tny-simple-folder-store.h:
1101 Added ModestTnySimpleFolderStore, used to contain folders from
1102 other folder stores, such as other accounts.
1104 * src/modest-tny-outbox-account.h:
1105 * src/modest-tny-outbox-account.c:
1106 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1107 used for the per-account local outbox folders.
1109 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1110 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1111 only use this (internally) now for the non-outbox local folders.
1113 * src/modest-init.h:
1114 * src/modest-init.c: Added modest_init_one_local_folder(), for
1115 setting up the directory structure for each local folder.
1117 * src/modest-local-folder-info.c:
1118 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1119 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1121 * src/modest-local-folder-info.h:
1122 * src/modest-tny-account-store.c: (on_account_removed),
1123 (on_account_changed), (create_per_account_local_outbox_folders),
1124 (get_server_accounts), (modest_tny_account_store_get_accounts),
1125 (modest_tny_account_store_get_tny_account_by_account),
1126 (modest_tny_folder_store_is_virtual_local_folders):
1128 * src/modest-tny-account.h:
1129 * src/modest-tny-account.c:
1130 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1131 to create an on-disk per-account local outbox folder for each
1133 (create_per_account_local_outbox_folders): Create a local outbox folder
1134 for each transport account.
1135 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1136 for all local folders.
1138 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1139 instead of using g_object_get/set() directly. It is clearer.
1141 (modest_tny_folder_store_get_message_count),
1142 (modest_tny_folder_store_get_local_size
1143 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1144 because we now use these with non-acount folder stores.
1146 (modest_tny_account_get_special_folder),
1147 (modest_tny_account_new_from_server_account),
1148 (modest_tny_account_new_from_account):
1149 (recurse_folders): Adjust to the new outbox system.
1151 * src/modest-tny-folder.h:
1152 * src/modest-tny-folder.c:
1153 (modest_tny_folder_is_local_folder),
1154 (modest_tny_folder_get_local_folder_type),
1155 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1157 * src/widgets/modest-main-window.h:
1158 * src/maemo/modest-main-window.c: (create_details_widget),
1159 (modest_main_window_set_contents_style): Show details for any folder store,
1162 (modest_tny_folder_get_rules):
1163 Remove the const. C does not support constness enough for this.
1165 * src/modest-ui-actions.c:
1166 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1167 make all outboxes appear as one, in the usual local-folders tree node.
1169 (set_active_account_from_tny_account),
1170 (modest_ui_actions_on_folder_selection_changed):
1171 * src/widgets/modest-folder-view.c: (text_cell_data),
1172 (icon_cell_data), (filter_row),
1173 (add_account_folders_to_merged_folder),
1174 (add_account_folders_to_simple_folder_store), (),
1175 (get_cmp_rows_type_pos), (cmp_rows),
1176 (modest_folder_view_set_account_id_of_visible_server_account):
1177 Adjust to the new outbox system, using generic folder stores and folders
1178 in the GtkTreeModel.
1180 2007-05-23 Christian Kellner <ckellner@openismus.com>
1182 * src/modest-mail-operation.c:
1183 (modest_mail_operation_update_account):
1184 Use info->max_size instead of unintialized local var [small
1185 build fix]. (Added TODO to review that change since I don't
1188 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1190 * libmodest-dbus-client/libmodest-dbus-client.c:
1191 (libmodest_dbus_client_compose_mail): function added
1192 * src/dbus_api/modest-dbus-api.h:
1193 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1194 (on_compose_mail): Implementation of the SendAsMail functionality
1196 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1198 * src/modest-account-mgr.c:
1199 (modest_account_mgr_add_server_account): Set the secure-connection
1200 conf key for transport accounts as well as store accounts. I don't know
1201 why the if was there. For instance, this makes sure that we use SSL
1202 for the gmail preset from the easysetup wizard.
1204 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1206 * src/gnome/modest-main-window.c:
1207 (on_account_store_connecting_finished), (connect_signals):
1208 * src/maemo/modest-main-window.c:
1209 (on_account_store_connecting_finished), (connect_signals),
1210 (modest_main_window_new):
1211 Handle TnyAccountStore::connecting-finished instead of
1212 TnyDevice::connection-changed, because we cannot actually perform
1213 operations on accounts until TnyAccountStore has itself responded to
1214 the TnyDevice::connection-changed signal. This prevents a GError from
1216 Do not try to update at startup, because we (at least on scratchbox)
1217 already do an update at startup when the device goes online.
1218 This prevents a GError from tinymail.
1219 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1220 Added TODO about stopping simultaneous operations.
1222 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1224 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1225 * src/modest-mail-operation-queue.c:
1226 (modest_mail_operation_queue_remove):
1227 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1228 about where they happened.
1230 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1232 * src/modest-ui-actions.c:
1233 (modest_ui_actions_on_password_requested): Make sure that the remember
1234 output parameter is always TRUE.
1236 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1238 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1239 Show a OK/Cancel dialog if the error is a question, though we still do not
1240 know anything more about what we are asking the user.
1241 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1242 Fix an uninitialized variable (helper). This is a logic error, however.
1244 2007-05-21 Christian Kellner <ckellner@openismus.com>
1246 * src/modest-search.h:
1247 Correct bit shifting in the ModestSearchFlags enum.
1249 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1251 * src/modest-tny-account.c:
1252 (modest_tny_account_new_from_server_account): Do not use the lsub and
1253 check-all hard-coded IMAP options when using POP.
1255 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1257 * src/modest-tny-account.c:
1258 (modest_tny_account_new_from_server_account):
1259 Use NULL for the secure-auth method for POP when Password auth has been
1260 specified by the user, as we already do for IMAP. "auth=Login" causes
1261 an error from camel or the server.
1263 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1265 * src/maemo/modest-account-settings-dialog.c:
1266 (create_page_account_details),
1267 (modest_account_settings_dialog_set_account_name):
1268 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1269 for the leave-on-server checkbox, rathr than just the checkbox, when
1270 the protocol is not POP.
1272 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1274 * src/widgets/modest-account-view.c:
1275 * src/widgets/modest-account-view.h:
1276 Added modest_account_view_select_account() which will be useful later
1277 to asynchronously re-select the edited account.
1279 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1281 * src/maemo/modest-account-settings-dialog.c:
1282 (modest_account_settings_dialog_set_account_name):
1283 Automatically choose the port numbers based on the secure authentication
1284 methods, if they have not been chosen before.
1285 This fixes projects.maemo.org bug NB#56273 .
1287 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1289 * src/maemo/modest-main-window-ui.h:
1290 * src/modest-ui-actions.c:
1291 * src/modest-ui-actions.h:
1292 Connect the Tools/SMTP Servers menu item to
1293 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1294 SMTP servers dialog, as in the UI specification and saves changes when it
1295 is closed. This fixed projects.maemo.org bug NB#56305 .
1297 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1299 * src/maemo/modest-connection-specific-smtp-window.c:
1300 (modest_connection_specific_smtp_window_init):
1301 Use gtk_window_set_default_size() to make this window big enough, so
1302 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1304 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1306 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1307 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1308 (modest_connection_specific_smtp_edit_window_init),
1309 Do not try to connect to a combobox signal before the combobox exists.
1310 This fixes the cras in projects.maemo.org bug NB#56288 .
1311 (modest_connection_specific_smtp_edit_window_get_settings):
1312 Remove the server_account_name parameter which was being checked for NULL
1313 though it was not used.
1315 * src/maemo/modest-connection-specific-smtp-window.c:
1316 (modest_connection_specific_smtp_window_fill_with_connections),
1317 (on_button_edit), (modest_connection_specific_smtp_window_init):
1318 Correct the number of treemodel columns to prevent a warning.
1319 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1320 libconic does not work.
1322 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1324 * src/modest-tny-account.c:
1325 (modest_tny_account_new_from_server_account):
1326 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1327 SMTP when "None" was chosen by the user. However, with my SMTP server that
1328 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1331 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1333 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1334 to explain the memory management issue with the ID in the ModestPair.
1336 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1337 (add_sending_page), (modest_account_assistant_finalize):
1338 * src/gnome/modest-gnome-global-settings-dialog.c:
1339 (create_updating_page), (create_composing_page):
1340 * src/gnome/modest-msg-edit-window.c: (get_transports),
1341 (init_window), (modest_msg_edit_window_finalize),
1342 (modest_msg_edit_window_get_msg_data):
1343 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1344 * src/gnome/modest-transport-widget.c:
1345 (modest_transport_widget_finalize), (smtp_configuration):
1346 * src/maemo/modest-maemo-global-settings-dialog.c:
1347 (create_updating_page), (create_composing_page):
1348 * src/maemo/modest-msg-edit-window.c: (get_transports),
1349 (init_window), (modest_msg_edit_window_finalize),
1350 (modest_msg_edit_window_get_msg_data),
1351 (modest_msg_edit_window_free_msg_data):
1352 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1353 (modest_store_widget_finalize):
1354 * src/maemo/modest-transport-widget.c:
1355 (modest_transport_widget_finalize), (smtp_configuration):
1356 * src/modest-main.c: (send_mail):
1357 * src/widgets/modest-combo-box.h:
1358 * src/widgets/modest-global-settings-dialog-priv.h:
1359 * src/widgets/modest-global-settings-dialog.c:
1360 (modest_global_settings_dialog_finalize):
1361 * src/widgets/modest-msg-edit-window.h:
1362 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1363 as long as the combo box, to prevent use of freed memory for the ID.
1365 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1367 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1368 get_accounts(), to make this clearer. Do not check for the enabled gconf
1369 key, because we do not use this for server accounts (at least, not yet).
1370 This allows us to send email again.
1372 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1374 * src/maemo/modest-platform.c:
1375 (on_modest_conf_update_interval_changed), (modest_platform_init):
1376 Only respond to this particular key change. All these strcmp()s cannot be
1379 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1381 * src/maemo/modest-maemo-global-settings-dialog.c:
1382 (current_connection): Prevent a crash in scratchbox when
1383 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1384 * src/maemo/modest-platform.c:
1385 (on_modest_conf_update_interval_changed), (modest_platform_init):
1386 Get the update interval from gconf and reset it when the gconf key changes.
1388 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1390 * src/modest-protocol-info.c:
1391 * src/modest-protocol-info.h: Adde enum-specific get functions,
1392 instead of using a ModestProtocolType enum parameter.
1394 * src/gnome/modest-account-assistant.c:
1395 * src/gnome/modest-store-widget.c:
1396 * src/gnome/modest-store-widget.h:
1397 * src/gnome/modest-transport-widget.c:
1398 * src/gnome/modest-transport-widget.h:
1399 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1400 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1401 * src/maemo/easysetup/modest-easysetup-wizard.c:
1402 * src/maemo/modest-account-settings-dialog.c:
1403 * src/maemo/modest-account-settings-dialog.h:
1404 * src/maemo/modest-store-widget.c:
1405 * src/maemo/modest-store-widget.h:
1406 * src/maemo/modest-transport-widget.c:
1407 * src/maemo/modest-transport-widget.h:
1408 * src/modest-account-mgr-helpers.c:
1409 * src/modest-account-mgr-helpers.h:
1410 * src/modest-account-mgr.c:
1411 * src/modest-account-mgr.h:
1412 * src/modest-tny-account.c:
1413 * src/modest-tny-folder.c:
1414 * src/widgets/modest-account-view.c:
1415 * src/widgets/modest-retrieve-combo-box.c:
1416 * src/widgets/modest-retrieve-combo-box.h:
1417 * src/widgets/modest-secureauth-combo-box.c:
1418 * src/widgets/modest-serversecurity-combo-box.c:
1419 * src/widgets/modest-serversecurity-combo-box.h:
1420 * tests/check_account-mgr.c:
1421 Use the specific functions, and use the re-renamed enum values for GNOME too.
1423 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1425 * src/modest-pair.h:
1426 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1427 so we can get the second based on the first.
1429 * src/maemo/modest-account-settings-dialog.h:
1430 * src/maemo/modest-account-settings-dialog.c:
1431 Added get_supported_secure_authentication_methods(), though it is mostly
1432 commented-out for now until the necessary API is committed to tinymail.
1433 (modest_account_settings_dialog_set_account_name),
1434 (save_configuration): Request the supported authentication methods from the
1435 server, so we can choose a working method.
1437 * src/modest-tny-account-store.h:
1438 * src/modest-tny-account-store.c:
1439 (modest_tny_account_store_get_session): Rename from
1440 tny_account_store_get_session().
1442 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1444 * src/modest-protocol-info.h: Split the ModestProtocol enum
1445 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1446 There was no need to have these unrelated values in one enum.
1448 * src/: many files: Adapted to changed enum. This makes the code a bit
1449 clearer, and the compiler could catch some errors.
1451 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1453 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1454 Show the detailed internal camel error message when an error happens
1455 during the configuration, so that our testers can give us more clues.
1456 For instance, in projects.maemo.org bug NB#56910 .
1458 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1460 * src/modest-tny-account.c:
1461 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1462 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1464 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1466 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1467 * src/maemo/modest-account-settings-dialog.c:
1468 (modest_account_settings_dialog_set_account_name),
1469 (save_configuration): For the incoming secure authentication checkbox,
1470 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1471 the UI specification. PLAIN does not seem to be supported for most IMAP
1472 servers anyway, and I am not sure what it would mean.
1473 However, we probably need to discover which of the secure-authentication
1474 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1475 * src/modest-account-mgr-helpers.c:
1476 (modest_account_mgr_get_server_account_data):
1478 * src/modest-tny-account.c:
1479 (modest_tny_account_new_from_server_account):
1480 Use tny_account_set_mech() to set secure-authentication methods,
1481 with some special-casing for IMAP, based on my observations of how
1484 * src/modest-account-mgr-helpers.h:
1485 * src/modest-account-mgr.c:
1486 * src/modest-defs.h: Comment that the URI is only used for local folders.
1488 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1490 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1491 parameter const, just to be neat.
1492 * src/modest-text-utils.c: (modest_text_utils_inline):
1493 End g_strconcat() with NULL, as its documentation says. This is almost
1494 certainly the cause of my crash at startup on the device. Interestingly,
1495 valgrind doesn't tell us about these errors.
1497 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1499 * scripts/build-packages: Added more precise comments about how to use
1500 this script, though I still get this error:
1501 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1502 error building tinymail
1504 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1506 * src/maemo/modest-main-window.c: (on_account_update):
1507 Very slight cleanup, hoping to make it simpler to discover what causes
1508 a crash here sometimes.
1510 * src/modest-tny-account.c:
1511 (modest_tny_account_new_from_server_account): Set the port. Added
1512 comments about the options and a TODO comment because I need to find out
1513 how to specify the secure authentication method.
1515 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1517 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1518 changed CFlags paths form modest to libmodest
1520 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1522 * src/modest-account-mgr-helpers.c:
1523 (modest_account_mgr_get_server_account_data),
1524 (modest_account_mgr_free_server_account_data):
1525 * src/modest-account-mgr-helpers.h:
1526 * src/modest-account-mgr.c:
1527 (modest_account_mgr_add_server_account):
1528 * src/modest-defs.h:
1529 * src/modest-tny-account.c:
1530 (modest_tny_account_new_from_server_account):
1531 Determine the options for tny_camel_account_add_option() here,
1532 based on the settings, rather than storing them directly in gconf.
1534 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1536 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1537 Show a more friendly error dialog now that we expect (from the tinymail
1538 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1540 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1542 * src/maemo/modest-main-window.c: (on_account_update): Check that
1543 account_name is not NULL, to prevent a crash at startup that I am
1544 seeing on the N800. I do wonder why it is NULL.
1546 * src/maemo/easysetup/modest-easysetup-wizard.c:
1547 (create_page_user_details):
1548 * src/maemo/modest-account-settings-dialog.c:
1549 (create_page_user_details), (create_page_outgoing):
1550 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1551 (modest_connection_specific_smtp_edit_window_init):
1552 * src/modest-ui-actions.c:
1553 (modest_ui_actions_on_password_requested):
1554 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1555 might do something useful with the on-screen keyboard.
1557 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1559 * src/maemo/modest-main-window.c: (on_account_update):
1560 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1561 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1563 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1565 * src/modest-tny-account-store.c: (on_account_changed):
1566 Correct the signature of this signal handler.
1568 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1570 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1571 Show a HildonNote instead of a GtkDialog for Maemo.
1573 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1575 * src/widgets/modest-account-view.h:
1576 * src/widgets/modest-account-view.c: (on_account_changed),
1577 (on_account_removed). Added a boolean flag, set/unset by
1578 modest_account_view_block_conf_updates(),
1579 modest_account_view_unblock_conf_updates() to prevent unnecessary
1580 updates, but this is not very useful because the gconf notifications are
1581 so delays (maybe only on Maemo Bora).
1582 So auto-updating is turned off, and these functions do an explicit
1583 update when necessary.
1584 However, something else is still doing too much work when adding/removing
1585 accounts, probably in another part of the application.
1587 * src/maemo/modest-account-view-window.c:
1588 (on_delete_button_clicked), (on_edit_button_clicked),
1589 (on_new_button_clicked): Use the new functions.
1591 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1593 * src/modest-account-mgr-helpers.c:
1594 (modest_account_mgr_set_first_account_as_default):
1595 Sort the list of names alphabetically-by-title, so we choose the first one
1597 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1598 alphabetically by the title.
1600 This fixes projects.maemo.org bug NB#56418 .
1602 * src/modest-account-mgr-priv.c:
1603 (_modest_account_mgr_account_from_key):
1604 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1605 avoid a valgrind error, and possible random behaviour.
1607 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1609 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1610 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1611 tinymail documentation to say that this can be expected.
1612 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1613 pretty, and should not happen, but I would prefer to know when it does.
1615 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1617 * configure.ac: When using the older hildon version, probably on Bora,
1618 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1620 * src/widgets/modest-attachment-view.c:
1621 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1624 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1626 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1627 Implemented the prototype. Can be tested with
1628 tests/dbus_api/test_open_message:
1630 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1632 * src/modest-tny-account-store.c:
1633 (modest_tny_account_store_instance_init), (get_password):
1634 * src/modest-ui-actions.c:
1635 (modest_ui_actions_on_password_requested):
1636 Do not store the password in gconf, because this function is called
1637 for non-remembered passwords. Actually use the cached (in the hash map)
1638 password instead of releasing it.
1639 The password will now not be remembered if it is asked via the protected
1640 password dialog, as per the UI spec.
1642 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1644 * src/modest-defs.h:
1645 * src/modest-account-mgr-helpers.h:
1646 * src/modest-account-mgr-helpers.c:
1647 Added modest_server_account_get_username_has_succeeded(),
1648 modest_server_account_set_username_has_succeeded().
1649 (modest_server_account_set_username),
1650 Reset the has-succeeded flag if the username changes.
1652 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1653 * src/maemo/modest-connection-specific-smtp-window.c:
1654 (modest_connection_specific_smtp_window_save_server_accounts):
1655 Use modest_server_account_set_username() instead of using
1656 modest_conf_set_string() directly, so that the has-succeeded flag is always
1659 * src/modest-ui-actions.c:
1660 (modest_ui_actions_on_password_requested): Dim the username entry if
1661 the username has ever worked, as per the UI spec.
1663 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1665 * src/modest-tny-account-store.c: (get_password):
1666 * src/modest-ui-actions.c:
1667 (modest_ui_actions_on_password_requested):
1668 Allow the username to be changed too, though there is more work to
1669 be done on exactly how this behaves.
1671 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1673 * src/modest-account-mgr-helpers.h:
1674 * src/modest-account-mgr-helpers.c:
1675 Added modest_account_mgr_get_display_name(),
1676 modest_server_account_get_username(),
1677 modest_server_account_set_username(),
1678 modest_server_account_set_password(),
1679 modest_server_account_get_hostname() functions so we do not need to
1680 use the conf API directly.
1682 * src/maemo/modest-main-window.c: (connect_signals):
1683 Actually connect ot the ModestAccountStore::request-password signal,
1684 so that we show the dialog when the password is requested by Tinymail,
1685 for isntance if it is empty.
1687 * src/modest-marshal.list:
1688 * src/modest-tny-account-store.c:
1689 (modest_tny_account_store_class_init), (get_password),
1690 (modest_tny_account_store_alert):
1691 * src/modest-tny-account-store.h:
1692 * src/modest-ui-actions.h:
1693 * src/modest-ui-actions.c:
1694 (modest_ui_actions_on_password_requested):
1695 Change the signal parameters, so it is obvious that we are providing
1696 the non human-readable server name, and receiving both the username
1697 and password, though changing of the username is not yet implemented.
1698 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1699 for the GNOME version.
1701 This should fix the projects.maemo.org bug NB#56209, though it does not
1702 work on Bora, because the gconf_client_get() for the password fails
1703 immediately after we save it with gconf_client_set().
1705 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1708 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1709 caused an undefined symbol error:
1710 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1712 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1714 * src/modest-tny-account-store.c:
1715 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1716 using a GError instead of a string message, so we can translate it in
1719 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1721 * src/maemo/modest-address-book.c:
1722 (modest_address_book_check_names):
1723 * src/maemo/modest-msg-view-window.c:
1724 (modest_msg_view_window_clipboard_owner_change):
1725 * src/modest-init.c: (modest_init_init_ui):
1726 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1727 (update_folders_cb), (modest_mail_operation_update_account):
1728 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1729 (modest_ui_actions_on_msg_attachment_clicked),
1730 (modest_ui_actions_on_msg_recpt_activated):
1731 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1732 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1733 (modest_msg_view_search_next):
1734 * src/widgets/modest-recpt-editor.c:
1735 (modest_recpt_editor_on_button_release_event),
1736 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1737 g_message(). At this point we should only be seeing interesting errors on
1738 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1740 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1742 (modest_wizard_dialog_force_title_update):
1743 * src/maemo/easysetup/modest-wizard-dialog.h:
1744 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1745 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1746 can update the title when appropriate. Otherwise the title is wrong if the
1747 pages are added after adding the notebook to the dialog.
1748 This must be a problem in HildonWizardDialog too.
1749 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1751 * src/maemo/easysetup/modest-easysetup-wizard.c:
1752 (create_subsequent_customsetup_pages),
1753 (create_subsequent_easysetup_pages):
1754 Call modest_wizard_dialog_force_title_update() so that the title is
1755 correct even with GTK+ < 2.10.
1756 This fixes projects.maemo.org bug NB#56145 .
1758 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1760 * src/maemo/modest-platform.c:
1761 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1762 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1765 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1767 * src/widgets/modest-window.h:
1768 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1769 and modest_window_save_state(), which invokes it.
1771 * src/widgets/modest-window-mgr.h:
1772 * src/widgets/modest-window-mgr.c:
1773 Added modest_window_mgr_save_state_for_all_windows(), which calls
1774 the save_state vfunc on all registered windows, if implemented.
1776 * src/gnome/modest-msg-edit-window.c:
1777 * src/gnome/modest-msg-view-window.c:
1778 * src/maemo/modest-msg-edit-window.c:
1779 * src/maemo/modest-msg-view-window.c:
1780 * src/maemo/modest-main-window.c:
1781 Specify the existing save_settings functions as implementations of
1782 ModestWindow::save_state_func().
1784 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1785 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1786 enabling hibernation, for instance.
1788 We may need to do the same thing for restoring settings.
1791 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1793 * src/widgets/modest-window-mgr.c:
1794 * src/widgets/modest-window-mgr.h:
1795 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1796 modest_window_mgr_get_hibernation_is_prevented().
1798 * src/maemo/modest-main-window.c:
1799 (on_hildon_program_is_topmost_notify): Prevent hibernation
1800 (possible when the application goes to the background in the WM),
1801 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1803 * src/maemo/easysetup/modest-easysetup-wizard.c:
1804 (modest_easysetup_wizard_dialog_init):
1805 * src/maemo/modest-account-settings-dialog.c:
1806 (modest_account_settings_dialog_init):
1807 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1808 (modest_connection_specific_smtp_edit_window_init):
1809 * src/maemo/modest-connection-specific-smtp-window.c:
1810 (modest_connection_specific_smtp_window_init):
1811 * src/maemo/modest-signature-editor-dialog.c:
1812 (modest_signature_editor_dialog_init):
1813 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1814 prevent hibernation while any of these account settings dialogs are open.
1816 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1818 * src/maemo/Makefile.am:
1819 * src/maemo/modest-osso-state-saving.c:
1820 * src/maemo/modest-osso-state-saving.h: Added
1821 modest_osso_load_state() and modest_osso_save_state() though they do
1822 nothing now. They should iterate through all the open windows and load/save
1824 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1825 save state when closing.
1827 * src/maemo/modest-main-window.c:
1828 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1829 Add a notification handler for the HildonProgram::is-topmost property,
1830 so we can allow hibernation when the application goes into the background.
1831 But we still need to detect when the accounts setup windows are open so
1832 we can stop hibernation when they are open.
1833 To do this, I also added the main window the HildonProgram. This might have
1834 other side-effects/benefits, and should maybe be done for other windows.
1836 * src/maemo/modest-osso-autosave-callbacks.h:
1837 * src/maemo/modest-osso-autosave-callbacks.c:
1838 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1839 though it does not do anything yet, and we might never need this to do
1840 anything. For instance, we already save drafts.
1842 * src/maemo/modest-platform.c: (modest_platform_init):
1843 Specify the libosso auto-save callback.
1845 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1847 * src/maemo/modest-platform.c:
1848 (modest_platform_set_update_interval):
1849 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1850 aparently stays valid between application instances, so we can use this
1851 to remove and reset it later. According to a maemo-developers email from
1854 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1856 * configure.ac: Depend on libalarm for Maemo.
1858 * src/dbus_api/modest-dbus-api.h:
1859 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1860 (on_send_receive), (modest_dbus_req_handler):
1861 Handle a SEND_RECEIVE D-Bus method.
1863 * libmodest-dbus-client/libmodest-dbus-client.c:
1864 (libmodest_dbus_client_send_and_receive):
1865 * libmodest-dbus-client/libmodest-dbus-client.h:
1866 Add C convenience functions for calling the new D-Bus method.
1868 * src/modest-platform.h:
1869 * src/gnome/modest-platform.c:
1870 * src/maemo/modest-platform.c:
1871 Added modest_platform_set_update_interval(), which uses the
1872 alarmd API on Maemo.
1873 (modest_platform_init),
1874 Call modest_platform_set_update_interval(), using a hard-coded
1875 interval for now (until the global settings dialog is implemented),
1876 though I am not sure that this makes sense yet.
1878 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1880 * src/dbus_api/modest-dbus-callbacks.c:
1881 (modest_osso_cb_hw_state_handler):
1882 * src/dbus_api/modest-dbus-callbacks.h:
1883 * src/maemo/modest-platform.c: (modest_platform_init):
1884 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1885 in case this has some effect on the ability for Maemo to ping the
1888 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1890 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1891 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1892 warning. It is probably a logic error, but I need to fix the build.
1894 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1896 * src/modest-account-mgr.h:
1897 * src/modest-account-mgr.c:
1898 (modest_account_mgr_account_names): Add a gboolean enabled_only
1899 parameter, so we can get lists of onlt the enabled accounts.
1901 (modest_account_mgr_add_account),,
1902 (modest_account_mgr_account_with_display_name_exists):
1903 * src/maemo/modest-msg-edit-window.c: (get_transports):
1904 * src/modest-account-mgr-helpers.c:
1905 (modest_account_mgr_set_first_account_as_default):
1906 * src/modest-init.c: (init_default_account_maybe):
1907 * src/modest-tny-account-store.c: (get_accounts):
1908 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1909 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1910 * tests/check_account-mgr.c: (START_TEST):
1911 Provide the extra parameter, as appropriate.
1913 * src/widgets/modest-account-view.c: (update_account_view):
1914 Do not show disabled accounts (meaning that there is no way to
1915 enable/disable accounts in the UI (the feature is not in our UI
1916 specification), so we can use this internally only to mark unfinished
1917 or temporary account data.
1919 * src/maemo/easysetup/modest-easysetup-wizard.c:
1920 (create_account): Add boolean enable parameter, so we can specify FALSE
1921 to create the temporary account.
1922 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1923 (on_before_next): When finishing, when there is a temporary account, just
1925 Also, use a timeout to delay the showing of the dialog until gconf is likely
1926 to return correct information, due to a maemo gconf bug that is fixed in
1927 osso 1.1, but not yet in Bora.
1928 However, the dialog stays on screen after it is destroyed.
1930 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1931 for invalid data when cancelling. Use a hildon note instead of a dialog
1932 to complain about invalid data. Do not show the account-saved note if the
1933 account is disabled (a temporary account that will not really be saved for use
1936 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1938 * src/modest-account-mgr-helpers.h:
1939 * src/modest-account-mgr-helpers.c:
1940 Added modest_account_mgr_unset_default_account(),
1941 Added modest_account_mgr_set_first_account_as_default().
1943 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1944 If it was the default account, unset the default account name.
1946 * src/maemo/modest-account-view-window.c:
1947 (on_delete_button_clicked): If it was the default account,
1948 set the first remaining account as the default instead.
1950 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1951 a NULL account or a NULL default account, to prevent a crash. This should
1952 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1955 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1957 * src/widgets/modest-recpt-editor.c:
1958 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1959 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1960 TODO comment for this. This fixes the build.
1962 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1963 be the best place for it. This will in future update all auto-update accounts,
1964 rather than just the current/default account, when that gconf key exists.
1965 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1966 if there are no accounts, before calling do_send_receive().
1967 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1969 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1970 * src/maemo/modest-main-window-ui.h:
1971 * src/maemo/modest-main-window.c: (on_connection_changed),
1972 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1973 directly, becaue the signal handler does more.
1975 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1977 * src/modest-account-mgr-helpers.c:
1978 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1979 for the case that the account does not exist.
1981 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1982 (equivalent to the modest account name) rather than the tinymail account name
1983 (equivalent to the modest account title - human readable) to get the account data.
1984 Check for null account data to prevent the crash, and add a TODO comment saying that
1985 this needs fixing because it is using the server account name instead of the account name.
1987 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1989 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1990 * src/maemo/modest-account-settings-dialog.c: (show_error),
1992 Use hildon_note_new_information() for informative and error messages,
1993 which seems to be expected for Maemo applications (no documentation that I know of
1994 says this). I am surprised that there is no distinction between info and error
1997 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1999 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2000 it is easy to find where this is used.
2002 * src/maemo/easysetup/modest-easysetup-wizard.c:
2003 (create_page_welcome), (create_page_account_details),
2004 (create_page_user_details), (create_page_complete_easysetup),
2005 (create_page_custom_incoming), (create_page_custom_outgoing),
2006 (create_page_complete_custom):
2007 * src/maemo/modest-account-settings-dialog.c:
2008 (create_page_account_details), (create_page_user_details),
2009 (create_page_incoming), (create_page_outgoing):
2010 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2011 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2012 (modest_connection_specific_smtp_edit_window_init):
2013 * src/maemo/modest-connection-specific-smtp-window.c:
2014 (modest_connection_specific_smtp_window_init):
2015 * src/maemo/modest-signature-editor-dialog.c:
2016 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2017 and scrolling policy as per the Email Application Layout Guide, if I have
2020 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2022 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2023 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2024 which were empty, because these vfuncs have been removed from TnyAccountStore.
2025 This fixes the build.
2027 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2029 * src/maemo/modest-main-window.c:
2030 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2031 showing/hiding it. Added TODO because it probably should not be NULL.
2032 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2033 because unnecessary g_warnings() make degugging difficult.
2035 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2037 * src/maemo/modest-msg-edit-window.c:
2038 (modest_msg_edit_window_select_color),
2039 (modest_msg_edit_window_select_background_color): 2 const corrections and
2040 moving 2 #endifs before closing brackets, to fix the build.
2042 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2044 * src/maemo/easysetup/modest-easysetup-wizard.h:
2045 * src/maemo/easysetup/modest-easysetup-wizard.c:
2046 (modest_easysetup_wizard_dialog_finalize),
2047 (on_button_edit_advanced_settings), (create_page_complete_custom),
2048 (on_response), (create_account):
2049 Implement the Advanced Settings edit button, by saving the account information,
2050 for the Advanded Settings dialog to use directly from gconf, and removing it
2051 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2052 Bug #5533 in the projects.maemo.org bugzilla.
2054 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2056 * src/maemo/modest-msg-view-window.c:
2057 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2058 when opening a message window.
2060 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2062 * src/maemo/easysetup/modest-easysetup-wizard.c:
2063 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2066 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2067 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2068 gconf settings. I probably added more checks than necessary, but that is safer.
2070 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2071 variable to fix the build, but this seems to be used when it is still NULL.
2073 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2075 * src/modest-platform.h:
2076 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2077 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2078 * src/modest-main.c: Implement this function so we can avoid using
2079 maemo-specific API from cross-platform code.
2081 * src/modest-tny-account-store.c:
2082 (get_smtp_specific_transport_account_for_open_connection):
2083 * src/modest-ui-actions.c: (check_for_connection),
2084 (modest_ui_actions_on_item_not_found):
2085 Use modest_platform_connect_and_wait() and put #idefs around other
2086 maemo-specific code, because only maemo currently has a way to
2087 identify connection names.
2089 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2091 * src/modest-tny-account-store.h:
2092 * src/modest-tny-account-store.c:
2093 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2094 the connection-specific SMTP server settings in the configuration.
2096 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2098 * src/maemo/modest-main-window.c: (on_connection_changed),
2100 * src/modest-main.c: (main), (start_ui), (send_mail):
2101 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2102 that is what is intended.
2104 * src/modest-ui-actions.c: (action_send), (action_receive),
2105 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2106 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2107 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2108 SMTP server is used when it is specified.
2110 (modest_ui_actions_on_send_receive):
2111 Check that a connection is open before proceeding.
2112 Receive and then send, instead of vice-versa, as per the specification.
2114 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2116 * src/modest-mail-operation.c:
2117 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2118 though I guess it should be something other than NULL.
2120 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2122 * src/maemo/easysetup/modest-easysetup-wizard.c:
2123 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2124 combo twice, to avoid an g_warning and to make it visible again.
2125 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2126 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2127 (already intended) dereference when detaching, because we then recreate the menu.
2128 But I am not sure why the warning was happening, and it is possible that this is a memory
2131 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2133 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2134 and uri_parse_mailto() utility functions.
2135 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2137 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2139 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2141 * src/dbus_api/modest-dbus-api.h:
2142 * src/dbus_api/modest-dbus-callbacks.c:
2143 Use an idle callback to execute the modest code in the application's own thread.
2144 Remove the helloworld example method.
2145 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2146 parsed, and the open-message method is not implemented because this is not yet implemented in
2148 * libmodest-dbus-client/libmodest-dbus-client.c:
2149 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2150 (libmodest_dbus_client_open_message):
2151 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2153 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2154 body without crashing.
2156 * tests/dbus_api/Makefile.am:
2157 * tests/dbus_api/test_mail_to.c:
2158 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2160 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2162 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2163 Added file to fix the build. Sorry.
2165 * src/dbus_api/Makefile.am:
2166 * src/dbus_api/modest-dbus-api.h:
2167 * src/dbus_api/modest-dbus-callbacks.h:
2168 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2169 (modest_dbus_req_handler):
2170 Put constants in a separate header so it can be reused by the
2171 client library, without duplication
2173 * libmodest-dbus-client/Makefile.am:
2174 * libmodest-dbus-client/libmodest-dbus-client.c:
2175 (libmodest_dbus_client_call_helloworld),
2176 (libmodfest_dbus_client_send_mail),
2177 (libmodfest_dbus_client_mailto),
2178 (libmodfest_dbus_client_open_message):
2179 * libmodest-dbus-client/libmodest-dbus-client.h:
2180 (Partly) Implement a send_mail D-Bus method.
2182 * tests/dbus_api/Makefile.am:
2183 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2184 the send_email D-Bus method.
2186 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2190 * libmodest-dbus-client/Makefile.am:
2191 * libmodest-dbus-client/libmodest-dbus-client.c:
2192 * libmodest-dbus-client/libmodest-dbus-client.h:
2193 * tests/dbus_api/Makefile.am:
2194 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2195 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2197 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2199 * src/maemo/easysetup/modest-easysetup-wizard.c:
2200 (create_page_account_details):
2201 * src/maemo/modest-account-settings-dialog.c:
2202 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2203 widgets, because this might not be the default in future versions of the Maemo GTK+.
2204 However, I can not not get capitalization to work even in a simple test case.
2206 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2208 * src/maemo/easysetup/modest-easysetup-wizard.c:
2209 (create_page_custom_incoming), (create_page_custom_outgoing):
2210 * src/maemo/modest-account-settings-dialog.c:
2211 (create_page_account_details), (create_page_incoming),
2212 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2213 instead of using gtk_check_button_with_label(), so they are aligned like the other
2214 widgets, as per the UI spec.
2216 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2218 * src/maemo/easysetup/modest-easysetup-wizard.c:
2219 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2220 * src/widgets/modest-validating-entry.c:
2221 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2222 Modest prefix instead of an EasySetup prefix.
2224 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2226 * src/widgets/modest-validating-entry.h:
2227 * src/widgets/modest-validating-entry.c: (on_insert_text),
2228 Added easysetup_validating_entry_set_max_func(), used to set a callback
2229 to call when the max number of characters is reached. GtkEntry has a max-length
2230 already but is silent about it.
2232 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2233 (create_page_account_details), (create_page_user_details),
2235 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2236 (create_page_account_details), (create_page_user_details),
2237 (create_page_outgoing):
2238 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2239 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2240 the UI spec, when the user tries to enter more than the max number of characters.
2242 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2244 * src/maemo/easysetup/modest-easysetup-wizard.c:
2245 (create_page_user_details), (create_page_custom_incoming),
2246 (create_page_custom_outgoing):
2247 * src/maemo/modest-account-settings-dialog.c:
2248 (create_page_user_details), (create_page_incoming),
2249 (create_page_outgoing):
2250 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2251 (modest_connection_specific_smtp_edit_window_init):
2252 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2253 not appropriate. Bad Maemo-specific defaults!.
2255 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2257 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2258 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2259 (modest_signature_editor_dialog_set_settings):
2260 Disable the label and textview when the checkbox is disabled, and use the
2261 specified (UI spec) default signature text.
2263 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2265 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2266 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2268 * src/modest-defs.h:
2269 * src/modest-account-mgr-helpers.h:
2270 * src/modest-account-mgr-helpers.c:
2271 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2273 * src/maemo/Makefile.am:
2274 * src/maemo/modest-signature-editor-dialog.c:
2275 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2278 * src/maemo/modest-account-settings-dialog.h:
2279 * src/maemo/modest-account-settings-dialog.c:
2280 (modest_account_settings_dialog_finalize), (on_button_signature),
2281 (save_configuration): Use the new dialog when the Edit button is pressed, and
2282 save the changes if necessary, as per the UI spec.
2284 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2286 * src/maemo/Makefile.am:
2287 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2288 based on maemo-develoers email from Dirk.
2290 * src/maemo/easysetup/modest-easysetup-wizard.c:
2291 (create_page_welcome), (create_page_account_details),
2292 (create_page_user_details), (create_page_complete_easysetup),
2293 (create_page_custom_incoming), (create_page_custom_outgoing),
2294 (create_page_complete_custom),
2295 (modest_easysetup_wizard_dialog_init):
2296 * src/maemo/modest-account-settings-dialog.c:
2297 (create_page_account_details), (create_page_user_details),
2298 (create_page_incoming), (create_page_outgoing),
2299 (modest_account_settings_dialog_init):
2300 * src/maemo/modest-connection-specific-smtp-window.c:
2301 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2303 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2305 * src/maemo/easysetup/modest-easysetup-wizard.c:
2306 (create_page_account_details), (create_page_custom_outgoing),
2307 (create_page_complete_custom):
2308 * src/maemo/modest-account-settings-dialog.c:
2309 (create_page_user_details), (create_page_incoming),
2310 (create_page_outgoing):
2311 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2312 (modest_connection_specific_smtp_edit_window_init):
2313 Use the correct (UI spec) port min/max, and use horizontal separators,
2316 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2318 * src/maemo/easysetup/modest-easysetup-wizard.c:
2319 (set_default_custom_servernames):
2320 * src/maemo/modest-account-settings-dialog.c:
2321 (create_page_incoming), (on_combo_outgoing_security_changed),
2322 (on_combo_incoming_security_changed), (create_page_outgoing),
2323 (modest_account_settings_dialog_set_account_name),
2324 (save_configuration):
2325 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2326 (on_combo_security_changed),
2327 (modest_connection_specific_smtp_edit_window_init),
2328 (modest_connection_specific_smtp_edit_window_set_connection),
2329 (modest_connection_specific_smtp_edit_window_get_settings):
2330 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2333 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2336 * src/maemo/easysetup/modest-easysetup-wizard.c:
2337 (create_page_custom_outgoing), (create_page_complete_custom):
2338 * src/maemo/modest-account-settings-dialog.c:
2339 (create_page_user_details), (create_page_outgoing):
2340 * src/maemo/modest-account-view-window.c: (button_box_new):
2341 Use changed logical IDs as per the most recent UI spec:
2342 mcen_bd_emailsetup_edit -> mcen_bd_edit
2343 mcen_bd_emailsetup_delete -> mcen_bd_delete
2344 mcen_bd_emailsetup_close -> mcen_bd_close
2346 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2350 * src/dbus_api/Makefile.am:
2351 * src/dbus_api/modest-dbus-callbacks.c:
2352 * src/dbus_api/modest-dbus-callbacks.h:
2353 * src/maemo/modest-platform.c: (modest_platform_init):
2354 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2356 * tests/Makefile.am:
2357 * tests/dbus_api/Makefile.am:
2358 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2360 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2362 * src/maemo/modest-account-settings-dialog.c:
2363 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2364 Removed unnecessary includes.
2366 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2368 * src/maemo/easysetup/modest-easysetup-wizard.c:
2369 * src/maemo/modest-account-settings-dialog.c:
2370 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2371 * src/widgets/Makefile.am:
2372 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2373 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2374 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2375 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2376 * src/widgets/modest-secureauth-combo-box.c:
2377 * src/widgets/modest-secureauth-combo-box.h:
2378 * src/widgets/modest-serversecurity-combo-box.c:
2379 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2380 made the GObject names more consistent with the rest of the Modest code.
2382 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2384 * src/maemo/easysetup/Makefile.am:
2385 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2386 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2387 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2388 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2389 * src/maemo/easysetup/modest-easysetup-wizard.c:
2390 * src/maemo/easysetup/modest-validating-entry.c:
2391 * src/maemo/easysetup/modest-validating-entry.h:
2392 * src/maemo/modest-account-settings-dialog.c:
2393 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2394 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2395 widgets/ because they are used outside of easysetup too. After checking in,
2396 svn will allow me to rename them too.
2398 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2400 * src/gnome/modest-msg-edit-window.c:
2401 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2402 linker error, to fix the build on the GNOME platform.
2403 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2404 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2405 ifdefed out to avoid a warning.
2407 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2409 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2410 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2411 some alternative for GTK+ 2.6.
2413 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2415 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2417 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2418 specified for EmailAccountsDialog in UI spec.
2420 * src/maemo/easysetup/modest-easysetup-wizard.c:
2421 * src/maemo/easysetup/modest-easysetup-wizard.h:
2422 * src/maemo/modest-account-settings-dialog.c:
2423 * src/maemo/modest-account-settings-dialog.h:
2424 Reuse a member window widget for the connection-specific SMTP server accounts,
2425 so we can tell it to create/save the accounts only if we actually save changes.
2427 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2428 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2429 (modest_connection_specific_smtp_edit_window_get_settings):
2430 Return a struct instance for temporarily remembering the entered data.
2432 * src/maemo/modest-connection-specific-smtp-window.h:
2433 * src/maemo/modest-connection-specific-smtp-window.c:
2434 (modest_connection_specific_smtp_window_finalize),
2435 (modest_connection_specific_smtp_window_fill_with_connections),
2437 (modest_connection_specific_smtp_window_save_server_accounts),
2438 (update_model_server_names): Do not actually save data until asked,
2439 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2441 (on_selection_changed),
2442 (modest_connection_specific_smtp_window_init): Disable the edit
2443 button when nothing is selected.
2445 * src/modest-account-mgr-helpers.c:
2446 * src/modest-account-mgr-helpers.h:
2447 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2450 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2452 * src/modest-account-mgr-helpers.h:
2453 * src/modest-account-mgr-helpers.c:
2454 (modest_account_mgr_get_unused_account_name),
2455 (modest_account_mgr_get_unused_account_display_name): Added these
2456 utility functions, to avoid code duplication.
2458 * src/maemo/easysetup/modest-easysetup-wizard.c:
2459 (create_page_account_details), (create_account):
2460 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2461 (on_combo_security_changed),
2462 (modest_connection_specific_smtp_edit_window_init),
2463 (modest_connection_specific_smtp_edit_window_save_settings):
2464 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2465 * src/maemo/modest-connection-specific-smtp-window.c:
2466 (modest_connection_specific_smtp_window_finalize),
2467 (modest_connection_specific_smtp_window_fill_with_connections),
2468 (on_button_edit), (modest_connection_specific_smtp_window_init):
2469 * src/maemo/modest-connection-specific-smtp-window.h:
2470 Implementing saving of connection-specific server accounts.
2472 But I need to refactor this so we can save the data for each
2473 possible connection-specific account and only actually create the server accounts
2474 when the easysetup finished, or the OK button is pressed on the account settings
2477 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2479 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2480 (on_combo_security_changed):
2481 (modest_connection_specific_smtp_edit_window_init):
2482 Auto-fill the port number as in the account settings.
2484 (modest_connection_specific_smtp_edit_window_set_connection):
2485 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2486 * src/maemo/modest-connection-specific-smtp-window.c:
2487 (fill_with_connections), (on_button_edit),
2488 (modest_connection_specific_smtp_window_init):
2489 Turn the edit window into a dialog to simplify the code, and
2490 set a WM hint as in a GtkDialog, because only a popup can be on top of
2491 another window in Maemo, and popups usually have no WM decoration.
2493 * src/modest-defs.h:
2494 * src/modest-account-mgr-helpers.c:
2495 (modest_account_mgr_set_connection_specific_smtp),
2496 (modest_account_mgr_remove_connection_specific_smtp),
2497 (modest_account_mgr_get_connection_specific_smtp):
2498 * src/modest-account-mgr-helpers.h: Some functions to write the
2499 connection-specific SMTP server information. Not yet used.
2502 * src/widgets/modest-folder-view.c: (text_cell_data):
2503 Fix a warning about an uninitialized variable.
2504 (on_configuration_key_changed): Put an #ifdef around the use
2505 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2507 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2509 * src/maemo/modest-account-settings-dialog.h:
2510 * src/maemo/modest-account-settings-dialog.c:
2511 Added connect_for_modified() utility function to mark the new modified boolean.
2513 (create_page_account_details), (create_page_user_details),
2514 (create_page_incoming), (create_page_outgoing), (on_response),
2515 (modest_account_settings_dialog_init),
2516 (modest_account_settings_dialog_set_account_name):
2517 Only warn about unsaved changes when there are actually unsaved changes.
2519 * src/modest-account-mgr-helpers.c:
2520 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2521 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2522 to get the data from there in future.
2524 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2526 * src/modest-defs.h:
2528 * src/modest-account-mgr-helpers.h:
2529 * src/modest-account-mgr-helpers.c:
2530 Store the security account setting in a single conf key instead of using
2531 the options list, so that the list is left for just the to-be-removed camel hack,
2532 and because gconf_client_set_list() is failing for some reason.
2534 * src/modest-account-mgr.c:
2535 (modest_account_mgr_add_server_account):
2536 * src/maemo/modest-account-settings-dialog.c:
2537 (modest_account_settings_dialog_set_account_name),
2538 (save_configuration): Use the renamed functions.
2541 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2543 * src/widgets/Makefile.am:
2544 * src/widgets/modest-limit-retrieve-combo-box.c:
2545 * src/widgets/modest-limit-retrieve-combo-box.h:
2546 * src/widgets/modest-retrieve-combo-box.c:
2547 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2548 the account settings dialog.
2550 * src/modest-defs.h:
2551 * src/modest-account-mgr-helpers.h:
2552 * src/modest-account-mgr-helpers.c:
2553 (modest_server_account_get_option_secure_auth),
2554 (modest_server_account_set_option_secure_auth):
2555 * src/modest-account-mgr.c:
2556 (modest_account_mgr_add_server_account):
2557 Use the existing AUTH_MECH conf key for the secure-auth setting,
2558 instead of putting it in the list options, because this was actually used already.
2560 * src/maemo/modest-account-settings-dialog.c:
2561 (create_page_account_details),
2562 (modest_account_settings_dialog_set_account_name),
2563 (save_configuration):
2564 * src/maemo/modest-account-settings-dialog.h:
2565 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2566 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2568 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2570 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2571 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2572 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2574 * src/modest-defs.h:
2575 * src/maemo/modest-account-settings-dialog.c:
2576 (create_page_incoming), (on_combo_outgoing_security_changed),
2577 (on_combo_incoming_security_changed), (create_page_outgoing),
2578 (modest_account_settings_dialog_set_account_name),
2579 (save_configuration): Load/Save the port number, and change it when the
2580 security combo changes, to suitable defaults.
2582 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2584 * src/modest-account-mgr.c:
2585 (modest_account_mgr_add_server_account): Set the security and secure-auth
2586 options, and add a comment saying that the other camel-specific options should be
2589 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2591 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2593 * src/modest-tny-account-store.c: (account_list_free),
2594 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2595 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2598 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2600 * src/modest-protocol-info.c:
2601 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2602 is required by our UI spec. Maybe something in our implementation will use this eventually.
2603 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2604 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2605 instead of the previous 0 placeholder.
2607 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2608 secure-auth settings.
2609 * src/modest-account-mgr-helpers.h:
2610 * src/modest-account-mgr-helpers.c:
2611 (modest_server_account_data_get_option_secure_auth),
2612 (modest_server_account_set_option_secure_auth),
2613 (modest_server_account_data_get_option_security),
2614 (modest_server_account_set_option_security): Added this API for getting and setting the security
2615 and secure-auth settings.
2617 * src/maemo/modest-account-settings-dialog.h:
2618 * src/maemo/modest-account-settings-dialog.c:
2619 (modest_account_settings_dialog_finalize), (check_data),
2620 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2621 about changing titles.
2622 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2623 (save_configuration): Save the security and secure-auth settings.
2625 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2626 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2628 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2630 * src/modest-defs.h:
2631 * src/modest-account-mgr.c:
2632 (modest_account_mgr_add_server_account):
2633 Added and used defines for the options key and value pair strings,
2634 that are used so far, though they do not seem to correspond to anything in our
2635 UI specs or ModestProtocol enum.
2637 * src/modest-account-mgr-helpers.h:
2638 * src/modest-account-mgr-helpers.c:
2639 (compare_option_strings_for_name),
2640 (modest_server_account_data_get_option_value),
2641 (modest_server_account_data_get_option_bool),
2642 (modest_account_mgr_get_server_account_option):
2643 Added helper functions for parsing the options GSList.
2645 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2647 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2648 display name is based on the supplied account name.
2649 * src/modest-account-mgr.c:
2650 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2651 with an inefficient, but good-enough, implementation.
2653 * src/maemo/easysetup/modest-easysetup-wizard.c:
2654 (create_page_account_details), (on_before_next), (create_account):
2655 Check for existing display names rather than (non-user-visible) account names, and just
2656 create and set a unique account name at the end.
2658 * src/maemo/modest-account-settings-dialog.c:
2659 (modest_account_settings_dialog_init),
2660 (modest_account_settings_dialog_set_account_name),
2661 (create_page_incoming): Show the display name, instead of the account name.
2662 (on_response): Do some (not all) extra checks, as in the UI spec.
2663 (save_configuration): Save the display name if it was changed.
2665 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2667 * po/en_GB.po: Added needed logical ID and translation.
2668 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2669 (init_view): Made the is-default column clicking work.
2671 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2674 * src/maemo/easysetup/Makefile.am:
2675 * src/maemo/easysetup/modest-easysetup-wizard.c:
2676 (modest_easysetup_wizard_dialog_init):
2677 * src/maemo/easysetup/provider-data-test.keyfile:
2678 * src/maemo/easysetup/provider-data.keyfile:
2679 Moved the provider data file to the new modest-providers-data package and used it from there.
2681 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2683 * src/modest-local-folder-info.c:
2684 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2685 N_() was already used on the static strings, but this just marks it for translation without
2686 using the translation.
2688 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2690 * src/maemo/modest-account-settings-dialog.c:
2691 (create_page_incoming),
2692 (modest_account_settings_dialog_set_account_name):
2693 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2694 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2695 I will do this if nobody else gets there first.
2697 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2699 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2700 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2701 save the security stuff.
2703 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2705 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2706 Set the email address and user fullname, which I now see must be
2709 * src/maemo/modest-account-settings-dialog.h:
2710 * src/maemo/modest-account-settings-dialog.c:
2712 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2713 leave-on-server and authentication.
2714 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2717 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2720 * src/maemo/modest-account-settings-dialog.c:
2721 * src/maemo/modest-account-settings-dialog.h:
2722 Most (but not all) of the widgets are now present as specified by the UI spec.
2723 No changes are yet saved, and some details are not properly shown yet.
2725 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2727 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2729 * src/maemo/Makefile.am:
2730 * src/maemo/modest-account-settings-dialog.c:
2731 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2732 an existing account. Doesn't do much yet.
2734 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2735 Open the accounts settings dialog when Edit is clicked.
2737 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2739 * src/maemo/easysetup/Makefile.am:
2740 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2742 * src/maemo/easysetup/modest-easysetup-wizard.c:
2743 (modest_easysetup_wizard_dialog_init):
2744 Try to get the source directory from the build system,
2745 instead of hard-coding "./" into the source code, when opening our local
2746 copies of the configuration files.
2747 But this still fails when opening the wizard from the Accounts window,
2748 maybe because the working directory seems to change at runtime.
2749 So the wizard will fail the second time unless you copy the files into their
2750 proper locations - see the stdout warnings for the paths.
2752 (create_page_account_details),(on_before_next):
2753 Check for existing non-server accounts instead of server accounts,
2754 so the default account name is useful again, and to prevent trying to
2757 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2758 Show the wizard when New is clicked.
2760 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2761 (init_view): Show the column headers, and show the columns that are
2762 specified in the UI specs. However, something in Maemo's GTK+ prevents
2763 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2764 change the default account. This is despite unsetting the special properties.
2766 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2768 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2769 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2770 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2771 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2772 to make that clearer.
2773 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2775 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2777 * src/maemo/modest-account-view-window.c:
2778 (modest_account_view_window_init),
2779 (modest_account_view_window_new):
2780 Use the same buttons as specified in the
2781 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2782 the existing widgets, which never had a chance of working.
2783 Put the ModestAccountView treeview in a scrolled window.
2784 Do not repeat the initialization in both _init() and _new().
2786 * src/widgets/modest-account-view.c: (update_account_view):
2787 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2788 this widget and window shows no accounts.
2790 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2792 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2794 * src/maemo/easysetup/modest-easysetup-wizard.c:
2795 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2796 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2797 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2800 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2801 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2802 accounts exist yet, as in the UI spec.
2804 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2806 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2808 * src/maemo/Makefile.am:
2809 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2810 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2811 New window for editing connection-specific smtp details.
2812 Not fully implemented.
2814 * src/maemo/modest-connection-specific-smtp-window.c:
2815 (modest_connection_specific_smtp_window_finalize) :
2816 unref the tree model.
2817 (on_button_edit): Show the edit window.
2819 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2821 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2824 * src/maemo/Makefile.am:
2825 * src/maemo/modest-connection-specific-smtp-window.c:
2826 * src/maemo/modest-connection-specific-smtp-window.h:
2827 New window for showing the list of connections, for connection-specific
2828 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2829 * src/maemo/easysetup/modest-easysetup-wizard.c:
2830 (create_page_custom_outgoing): Show the new window when the button is clicked.
2832 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2834 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2835 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2836 * src/maemo/modest-msg-edit-window.c:
2837 (modest_msg_edit_window_insert_image):
2838 * src/modest-conf.c: (modest_conf_key_escape):
2839 * src/modest-mail-operation.c:
2840 (modest_mail_operation_send_new_mail):
2841 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2842 (modest_ui_actions_on_new_account):
2843 * src/widgets/modest-attachment-view.c: (update_filename_request):
2844 * src/widgets/modest-mail-header-view.c:
2845 Corrected warnings that were breaking the build, by commenting out unused variables,
2846 and a function, and by including a header.
2848 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2850 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2851 so we can #ifdef around platform-specific code when necessary.
2852 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2853 to allow this to build for the GNOME platform too.
2855 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2857 * src/maemo/easysetup/modest-easysetup-wizard.c:
2858 Added util_increment_name() and used it in create_page_account_details()
2859 to make sure that the default account name is always a new name.
2861 (modest_easysetup_wizard_dialog_init),
2862 (set_default_custom_servernames): Some minor memory management fixes.
2864 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2868 * src/modest-runtime.c: (init_i18n): Restored the translation
2869 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2870 are defined in config.h, and the translations are installed.
2872 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2873 is defined for translation.
2875 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2877 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2879 * src/maemo/easysetup/modest-easysetup-wizard.c:
2880 (modest_easysetup_wizard_dialog_init):
2881 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2882 Use realistic paths (though they should use $prefix generically) to the
2883 mcc_mapping and provider-data.keyfile files which might work when they
2884 are installed by the future version of the operator-wizard package,
2885 and then fallback to paths in our source code, with an explanatory
2888 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2892 * src/maemo/Makefile.am:
2893 * src/maemo/easysetup/: Added files from the previously-exernal
2894 osso-modest-easysetup.
2895 * src/maemo/modest-main-window-ui.h:
2896 * src/modest-ui-actions.c:
2897 * src/modest-ui-actions.h:
2898 Added modest_ui_actions_on_new_account() as a signal handler for the
2899 New Account menu item. It shows the easysetup wizard.
2900 * po/en_GB.po: Added additional needed logical IDs and translations.
2902 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2903 Apparently ChangeLog is not used for some vague Nokia legal reasons.