git.maemo.org Git - modest/blob - ChangeLog2

   1 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
   2
   3         * src/modest-account-mgr-helpers.h:
   4         * src/modest-account-mgr-helpers.c:
   5         Added modest_account_mgr_get_display_name(),
   6         modest_server_account_get_username(),
   7         modest_server_account_set_username(),
   8         modest_server_account_set_password(),
   9         modest_server_account_get_hostname() functions so we do not need to
  10         use the conf API directly.
  11
  12         * src/maemo/modest-main-window.c: (connect_signals):
  13         Actually connect ot the ModestAccountStore::request-password signal,
  14         so that we show the dialog when the password is requested by Tinymail,
  15         for isntance if it is empty.
  16
  17         * src/modest-marshal.list:
  18         * src/modest-tny-account-store.c:
  19         (modest_tny_account_store_class_init), (get_password),
  20         (modest_tny_account_store_alert):
  21         * src/modest-tny-account-store.h:
  22         * src/modest-ui-actions.h:
  23         * src/modest-ui-actions.c:
  24         (modest_ui_actions_on_password_requested):
  25         Change the signal parameters, so it is obvious that we are providing
  26         the non human-readable server name, and receiving both the username
  27         and password, though changing of the username is not yet implemented.
  28         Change the dialog UI to match the Maemo UI specifications, with #idfefing
  29         for the GNOME version.
  30
  31         This should fix the projects.maemo.org bug NB#56209, though it does not
  32         work on Bora, because the gconf_client_get() for the password fails
  33         immediately after we save it with gconf_client_set().
  34
  35 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
  36
  37         * configure.ac:
  38         * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
  39         caused an undefined symbol error:
  40         modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
  41
  42 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
  43
  44         * src/modest-tny-account-store.c:
  45         (modest_tny_account_store_alert): Adapt to the changed tinymail API,
  46         using a GError instead of a string message, so we can translate it in
  47         Modest.
  48
  49 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
  50
  51         * src/maemo/modest-address-book.c:
  52         (modest_address_book_check_names):
  53         * src/maemo/modest-msg-view-window.c:
  54         (modest_msg_view_window_clipboard_owner_change):
  55         * src/modest-init.c: (modest_init_init_ui):
  56         * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
  57         (update_folders_cb), (modest_mail_operation_update_account):
  58         * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
  59         (modest_ui_actions_on_msg_attachment_clicked),
  60         (modest_ui_actions_on_msg_recpt_activated):
  61         * src/widgets/modest-header-view.c: (drag_data_get_cb):
  62         * src/widgets/modest-msg-view.c: (modest_msg_view_search),
  63         (modest_msg_view_search_next):
  64         * src/widgets/modest-recpt-editor.c:
  65         (modest_recpt_editor_on_button_release_event),
  66         (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
  67         g_message(). At this point we should only be seeing interesting errors on
  68         stdout. Debugging messages could be #ifdefed-out if they are still useful.
  69
  70 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
  71
  72         (modest_wizard_dialog_force_title_update):
  73         * src/maemo/easysetup/modest-wizard-dialog.h:
  74         * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
  75         For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
  76         can update the title when appropriate. Otherwise the title is wrong if the
  77         pages are added after adding the notebook to the dialog.
  78         This must be a problem in HildonWizardDialog too.
  79         Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
  80
  81         * src/maemo/easysetup/modest-easysetup-wizard.c:
  82         (create_subsequent_customsetup_pages),
  83         (create_subsequent_easysetup_pages):
  84         Call modest_wizard_dialog_force_title_update() so that the title is
  85         correct even with GTK+ < 2.10.
  86         This fixes projects.maemo.org bug NB#56145 .
  87
  88 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
  89
  90         * src/maemo/modest-platform.c:
  91         (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
  92         flag (awful lack of namespacing in this API) to prevent a useless %s dialog
  93         from being shown.
  94
  95 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
  96
  97         * src/widgets/modest-window.h:
  98         * src/widgets/modest-window.c: Added a save_state_func vfunc,
  99         and modest_window_save_state(), which invokes it.
 100
 101         * src/widgets/modest-window-mgr.h:
 102         * src/widgets/modest-window-mgr.c:
 103         Added modest_window_mgr_save_state_for_all_windows(), which calls
 104         the save_state vfunc on all registered windows, if implemented.
 105
 106         * src/gnome/modest-msg-edit-window.c:
 107         * src/gnome/modest-msg-view-window.c:
 108         * src/maemo/modest-msg-edit-window.c:
 109         * src/maemo/modest-msg-view-window.c:
 110         * src/maemo/modest-main-window.c:
 111         Specify the existing save_settings functions as implementations of
 112         ModestWindow::save_state_func().
 113
 114         * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
 115         Call modest_window_mgr_save_state_for_all_windows(). This happens before
 116         enabling hibernation, for instance.
 117
 118         We may need to do the same thing for restoring settings.
 119
 120
 121 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 122
 123         * src/widgets/modest-window-mgr.c:
 124         * src/widgets/modest-window-mgr.h:
 125         Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
 126         modest_window_mgr_get_hibernation_is_prevented().
 127
 128         * src/maemo/modest-main-window.c:
 129         (on_hildon_program_is_topmost_notify): Prevent hibernation
 130         (possible when the application goes to the background in the WM),
 131         if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
 132
 133         * src/maemo/easysetup/modest-easysetup-wizard.c:
 134         (modest_easysetup_wizard_dialog_init):
 135         * src/maemo/modest-account-settings-dialog.c:
 136         (modest_account_settings_dialog_init):
 137         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 138         (modest_connection_specific_smtp_edit_window_init):
 139         * src/maemo/modest-connection-specific-smtp-window.c:
 140         (modest_connection_specific_smtp_window_init):
 141         * src/maemo/modest-signature-editor-dialog.c:
 142         (modest_signature_editor_dialog_init):
 143         Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
 144         prevent hibernation while any of these account settings dialogs are open.
 145
 146 2007-05-04  Murray Cumming  <murrayc@murrayc.com>
 147
 148         * src/maemo/Makefile.am:
 149         * src/maemo/modest-osso-state-saving.c:
 150         * src/maemo/modest-osso-state-saving.h: Added
 151         modest_osso_load_state() and modest_osso_save_state() though they do
 152         nothing now. They should iterate through all the open windows and load/save
 153         their state.
 154         * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
 155         save state when closing.
 156
 157         * src/maemo/modest-main-window.c:
 158         (on_hildon_program_is_topmost_notify), (modest_main_window_new):
 159         Add a notification handler for the HildonProgram::is-topmost property,
 160         so we can allow hibernation when the application goes into the background.
 161         But we still need to detect when the accounts setup windows are open so
 162         we can stop hibernation when they are open.
 163         To do this, I also added the main window the HildonProgram. This might have
 164         other side-effects/benefits, and should maybe be done for other windows.
 165
 166         * src/maemo/modest-osso-autosave-callbacks.h:
 167         * src/maemo/modest-osso-autosave-callbacks.c:
 168         (modest_on_osso_application_autosave): Add a libosso auto-save callback,
 169         though it does not do anything yet, and we might never need this to do
 170         anything. For instance, we already save drafts.
 171
 172         * src/maemo/modest-platform.c: (modest_platform_init):
 173         Specify the libosso auto-save callback.
 174
 175 2007-05-03  Murray Cumming  <murrayc@murrayc.com>
 176
 177         * src/maemo/modest-platform.c:
 178         (modest_platform_set_update_interval):
 179         * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
 180         aparently stays valid between application instances, so we can use this
 181         to remove and reset it later. According to a maemo-developers email from
 182         David Weinehall.
 183
 184 2007-05-03  Murray Cumming  <murrayc@murrayc.com>
 185
 186         * configure.ac: Depend on libalarm for Maemo.
 187
 188         * src/dbus_api/modest-dbus-api.h:
 189         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
 190         (on_send_receive), (modest_dbus_req_handler):
 191         Handle a SEND_RECEIVE D-Bus method.
 192
 193         * libmodest-dbus-client/libmodest-dbus-client.c:
 194         (libmodest_dbus_client_send_and_receive):
 195         * libmodest-dbus-client/libmodest-dbus-client.h:
 196         Add C convenience functions for calling the new D-Bus method.
 197
 198         * src/modest-platform.h:
 199         * src/gnome/modest-platform.c:
 200         * src/maemo/modest-platform.c:
 201         Added modest_platform_set_update_interval(), which uses the
 202         alarmd API on Maemo.
 203         (modest_platform_init),
 204         Call modest_platform_set_update_interval(), using a hard-coded
 205         interval for now (until the global settings dialog is implemented),
 206         though I am not sure that this makes sense yet.
 207
 208 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 209
 210         * src/dbus_api/modest-dbus-callbacks.c:
 211         (modest_osso_cb_hw_state_handler):
 212         * src/dbus_api/modest-dbus-callbacks.h:
 213         * src/maemo/modest-platform.c: (modest_platform_init):
 214         Registered (empty) callbacks for the osso hardware state D-Bus signals,
 215         in case this has some effect on the ability for Maemo to ping the
 216         application.
 217
 218 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 219
 220         * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
 221         Comment out an if() that checks a gchar for < 0, causing a build-breaking
 222         warning. It is probably a logic error, but I need to fix the build.
 223
 224 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 225
 226         * src/modest-account-mgr.h:
 227         * src/modest-account-mgr.c:
 228         (modest_account_mgr_account_names): Add a gboolean enabled_only
 229         parameter, so we can get lists of onlt the enabled accounts.
 230
 231         (modest_account_mgr_add_account),,
 232         (modest_account_mgr_account_with_display_name_exists):
 233         * src/maemo/modest-msg-edit-window.c: (get_transports):
 234         * src/modest-account-mgr-helpers.c:
 235         (modest_account_mgr_set_first_account_as_default):
 236         * src/modest-init.c: (init_default_account_maybe):
 237         * src/modest-tny-account-store.c: (get_accounts):
 238         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
 239         (do_send_receive_auto), (modest_ui_actions_on_send_receive):
 240         * tests/check_account-mgr.c: (START_TEST):
 241         Provide the extra parameter, as appropriate.
 242
 243         * src/widgets/modest-account-view.c: (update_account_view):
 244         Do not show disabled accounts (meaning that there is no way to
 245         enable/disable accounts in the UI (the feature is not in our UI
 246         specification), so we can use this internally only to mark unfinished
 247         or temporary account data.
 248
 249         * src/maemo/easysetup/modest-easysetup-wizard.c:
 250         (create_account): Add boolean enable parameter, so we can specify FALSE
 251         to create the temporary account.
 252         (on_button_edit_advanced_settings): Create the temporary account as disabled.
 253         (on_before_next): When finishing, when there is a temporary account, just
 254         set it as enabled.
 255         Also, use a timeout to delay the showing of the dialog until gconf is likely
 256         to return correct information, due to a maemo gconf bug that is fixed in
 257         osso 1.1, but not yet in Bora.
 258         However, the dialog stays on screen after it is destroyed.
 259
 260         * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
 261         for invalid data when cancelling. Use a hildon note instead of a dialog
 262         to complain about invalid data. Do not show the account-saved note if the
 263         account is disabled (a temporary account that will not really be saved for use
 264         until later.)
 265
 266 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 267
 268         * src/modest-account-mgr-helpers.h:
 269         * src/modest-account-mgr-helpers.c:
 270         Added modest_account_mgr_unset_default_account(),
 271         Added modest_account_mgr_set_first_account_as_default().
 272
 273         * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
 274         If it was the default account, unset the default account name.
 275
 276         * src/maemo/modest-account-view-window.c:
 277         (on_delete_button_clicked): If it was the default account,
 278         set the first remaining account as the default instead.
 279
 280         * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
 281         a NULL account or a NULL default account, to prevent a crash. This should
 282         not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
 283
 284
 285 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 286
 287         * src/widgets/modest-recpt-editor.c:
 288         (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
 289         use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
 290         TODO comment for this. This fixes the build.
 291
 292         * src/modest-ui-actions.c: Add do_send_receive(), though it might not
 293         be the best place for it. This will in future update all auto-update accounts,
 294         rather than just the current/default account, when that gconf key exists.
 295         (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
 296         if there are no accounts, before calling do_send_receive().
 297         * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
 298
 299         * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
 300         * src/maemo/modest-main-window-ui.h:
 301         * src/maemo/modest-main-window.c: (on_connection_changed),
 302         (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
 303         directly, becaue the signal handler does more.
 304
 305 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 306
 307         * src/modest-account-mgr-helpers.c:
 308         (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
 309         for the case that the account does not exist.
 310
 311         * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
 312         (equivalent to the modest account name) rather than the tinymail account name
 313         (equivalent to the modest account title - human readable) to get the account data.
 314         Check for null account data to prevent the crash, and add a TODO comment saying that
 315         this needs fixing because it is using the server account name instead of the account name.
 316
 317 2007-04-29  Murray Cumming  <murrayc@murrayc.com>
 318
 319         * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
 320         * src/maemo/modest-account-settings-dialog.c: (show_error),
 321         (show_ok):
 322         Use hildon_note_new_information() for informative and error messages,
 323         which seems to be expected for Maemo applications (no documentation that I know of
 324         says this). I am surprised that there is no distinction between info and error
 325         dialogs.
 326
 327 2007-04-29  Murray Cumming  <murrayc@murrayc.com>
 328
 329         * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
 330         it is easy to find where this is used.
 331
 332         * src/maemo/easysetup/modest-easysetup-wizard.c:
 333         (create_page_welcome), (create_page_account_details),
 334         (create_page_user_details), (create_page_complete_easysetup),
 335         (create_page_custom_incoming), (create_page_custom_outgoing),
 336         (create_page_complete_custom):
 337         * src/maemo/modest-account-settings-dialog.c:
 338         (create_page_account_details), (create_page_user_details),
 339         (create_page_incoming), (create_page_outgoing):
 340         * src/maemo/modest-account-view-window.c: (window_vbox_new):
 341         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 342         (modest_connection_specific_smtp_edit_window_init):
 343         * src/maemo/modest-connection-specific-smtp-window.c:
 344         (modest_connection_specific_smtp_window_init):
 345         * src/maemo/modest-signature-editor-dialog.c:
 346         (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
 347         and scrolling policy as per the Email Application Layout Guide, if I have
 348         understood it.
 349
 350 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 351
 352         * src/modest-tny-account-store.c: (modest_tny_account_store_init):
 353         Remove the add_transport_account_func and add_store_account_func vfunc implementations,
 354         which were empty, because these vfuncs have been removed from TnyAccountStore.
 355         This fixes the build.
 356
 357 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 358
 359         * src/maemo/modest-main-window.c:
 360         (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
 361         showing/hiding it. Added TODO because it probably should not be NULL.
 362         * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
 363         because unnecessary g_warnings() make degugging difficult.
 364
 365 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 366
 367         * src/maemo/modest-msg-edit-window.c:
 368         (modest_msg_edit_window_select_color),
 369         (modest_msg_edit_window_select_background_color): 2 const corrections and
 370         moving 2 #endifs before closing brackets, to fix the build.
 371
 372 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 373
 374         * src/maemo/easysetup/modest-easysetup-wizard.h:
 375         * src/maemo/easysetup/modest-easysetup-wizard.c:
 376         (modest_easysetup_wizard_dialog_finalize),
 377         (on_button_edit_advanced_settings), (create_page_complete_custom),
 378         (on_response), (create_account):
 379         Implement the Advanced Settings edit button, by saving the account information,
 380         for the Advanded Settings dialog to use directly from gconf, and removing it
 381         if Finish is never clicked. There is still some UI strangeness, so this is not finished.
 382         Bug #5533 in the projects.maemo.org bugzilla.
 383
 384 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 385
 386         * src/maemo/modest-msg-view-window.c:
 387         (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
 388         when opening a message window.
 389
 390 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 391
 392         * src/maemo/easysetup/modest-easysetup-wizard.c:
 393         (create_page_custom_outgoing): Correct the position of the horizontal separator to
 394         match the UI spec.
 395
 396         * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
 397         before showing/hiding them, to avoid a crash when clicking on folders when there are no
 398         gconf settings. I probably added more checks than necessary, but that is safer.
 399
 400         * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
 401         variable to fix the build, but this seems to be used when it is still NULL.
 402
 403 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 404
 405         * src/modest-platform.h:
 406         * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
 407         * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
 408         * src/modest-main.c: Implement this function so we can avoid using
 409         maemo-specific API from cross-platform code.
 410         (main):
 411         * src/modest-tny-account-store.c:
 412         (get_smtp_specific_transport_account_for_open_connection):
 413         * src/modest-ui-actions.c: (check_for_connection),
 414         (modest_ui_actions_on_item_not_found):
 415         Use modest_platform_connect_and_wait() and put #idefs around other
 416         maemo-specific code, because only maemo currently has a way to
 417         identify connection names.
 418
 419 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 420
 421         * src/modest-tny-account-store.h:
 422         * src/modest-tny-account-store.c:
 423         Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
 424         the connection-specific SMTP server settings in the configuration.
 425
 426         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
 427         (on_idle_mail_to):
 428         * src/maemo/modest-main-window.c: (on_connection_changed),
 429         (connect_signals):
 430         * src/modest-main.c: (main), (start_ui), (send_mail):
 431         Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
 432         that is what is intended.
 433
 434         * src/modest-ui-actions.c: (action_send), (action_receive),
 435         (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
 436         Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
 437         modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
 438         SMTP server is used when it is specified.
 439
 440         (modest_ui_actions_on_send_receive):
 441         Check that a connection is open before proceeding.
 442         Receive and then send, instead of vice-versa, as per the specification.
 443
 444 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 445
 446         * src/modest-mail-operation.c:
 447         (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
 448         though I guess it should be something other than NULL.
 449
 450 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 451
 452         * src/maemo/easysetup/modest-easysetup-wizard.c:
 453         (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
 454         combo twice, to avoid an g_warning and to make it visible again.
 455         * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
 456         attached before detaching it, to avoid a g_warning, and add comment about the implicit
 457         (already intended) dereference when detaching, because we then recreate the menu.
 458         But I am not sure why the warning was happening, and it is possible that this is a memory
 459         leak.
 460
 461 2007-04-25  Murray Cumming  <murrayc@murrayc.com>
 462
 463         * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
 464         and uri_parse_mailto() utility functions.
 465         (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
 466         the mailto URI.
 467         * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
 468
 469 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 470
 471         * src/dbus_api/modest-dbus-api.h:
 472         * src/dbus_api/modest-dbus-callbacks.c:
 473         Use an idle callback to execute the modest code in the application's own thread.
 474         Remove the helloworld example method.
 475         Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
 476         parsed, and the open-message method is not implemented because this is not yet implemented in
 477         modest itself.
 478         * libmodest-dbus-client/libmodest-dbus-client.c:
 479         (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
 480         (libmodest_dbus_client_open_message):
 481         * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
 482
 483         * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
 484         body without crashing.
 485
 486         * tests/dbus_api/Makefile.am:
 487         * tests/dbus_api/test_mail_to.c:
 488         * tests/dbus_api/test_open_message.c: New tests for the new methods.
 489
 490 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 491
 492         * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
 493         Added file to fix the build. Sorry.
 494
 495         * src/dbus_api/Makefile.am:
 496         * src/dbus_api/modest-dbus-api.h:
 497         * src/dbus_api/modest-dbus-callbacks.h:
 498         * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
 499         (modest_dbus_req_handler):
 500         Put constants in a separate header so it can be reused by the
 501         client library, without duplication
 502
 503         * libmodest-dbus-client/Makefile.am:
 504         * libmodest-dbus-client/libmodest-dbus-client.c:
 505         (libmodest_dbus_client_call_helloworld),
 506         (libmodfest_dbus_client_send_mail),
 507         (libmodfest_dbus_client_mailto),
 508         (libmodfest_dbus_client_open_message):
 509         * libmodest-dbus-client/libmodest-dbus-client.h:
 510         (Partly) Implement a send_mail D-Bus method.
 511
 512         * tests/dbus_api/Makefile.am:
 513         * tests/dbus_api/test_send_mail.c: (main): Added a test for
 514         the send_email D-Bus method.
 515
 516 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 517
 518         * Makefile.am:
 519         * configure.ac:
 520         * libmodest-dbus-client/Makefile.am:
 521         * libmodest-dbus-client/libmodest-dbus-client.c:
 522         * libmodest-dbus-client/libmodest-dbus-client.h:
 523         * tests/dbus_api/Makefile.am:
 524         * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
 525         for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
 526
 527 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 528
 529         * src/maemo/easysetup/modest-easysetup-wizard.c:
 530         (create_page_account_details):
 531         * src/maemo/modest-account-settings-dialog.c:
 532         (create_page_account_details): Explicitly set auto-capitalization mode for the title
 533         widgets, because this might not be the default in future versions of the Maemo GTK+.
 534         However, I can not not get capitalization to work even in a simple test case.
 535
 536 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 537
 538         * src/maemo/easysetup/modest-easysetup-wizard.c:
 539         (create_page_custom_incoming), (create_page_custom_outgoing):
 540         * src/maemo/modest-account-settings-dialog.c:
 541         (create_page_account_details), (create_page_incoming),
 542         (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
 543         instead of using gtk_check_button_with_label(), so they are aligned like the other
 544         widgets, as per the UI spec.
 545
 546 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 547
 548         * src/maemo/easysetup/modest-easysetup-wizard.c:
 549         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 550         * src/widgets/modest-validating-entry.c:
 551         * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
 552         Modest prefix instead of an EasySetup prefix.
 553
 554 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 555
 556         * src/widgets/modest-validating-entry.h:
 557         * src/widgets/modest-validating-entry.c: (on_insert_text),
 558         Added easysetup_validating_entry_set_max_func(), used to set a callback
 559         to call when the max number of characters is reached. GtkEntry has a max-length
 560         already but is silent about it.
 561
 562         * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
 563         (create_page_account_details), (create_page_user_details),
 564         (create_account):
 565         * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
 566         (create_page_account_details), (create_page_user_details),
 567         (create_page_outgoing):
 568         * src/modest-ui-actions.c: (modest_ui_actions_on_details):
 569         Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
 570         the UI spec, when the user tries to enter more than the max number of characters.
 571
 572 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 573
 574         * src/maemo/easysetup/modest-easysetup-wizard.c:
 575         (create_page_user_details), (create_page_custom_incoming),
 576         (create_page_custom_outgoing):
 577         * src/maemo/modest-account-settings-dialog.c:
 578         (create_page_user_details), (create_page_incoming),
 579         (create_page_outgoing):
 580         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 581         (modest_connection_specific_smtp_edit_window_init):
 582         Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
 583         not appropriate. Bad Maemo-specific defaults!.
 584
 585 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 586
 587         * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
 588         (on_toggle_button_changed), (modest_signature_editor_dialog_init),
 589         (modest_signature_editor_dialog_set_settings):
 590         Disable the label and textview when the checkbox is disabled, and use the
 591         specified (UI spec) default signature text.
 592
 593 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 594
 595         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 596         (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
 597
 598         * src/modest-defs.h:
 599         * src/modest-account-mgr-helpers.h:
 600         * src/modest-account-mgr-helpers.c:
 601         Added modest_account_mgr_get/set_signature(), using new gconf keys.
 602
 603         * src/maemo/Makefile.am:
 604         * src/maemo/modest-signature-editor-dialog.c:
 605         * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
 606         as per the UI spec.
 607
 608         * src/maemo/modest-account-settings-dialog.h:
 609         * src/maemo/modest-account-settings-dialog.c:
 610         (modest_account_settings_dialog_finalize), (on_button_signature),
 611         (save_configuration): Use the new dialog when the Edit button is pressed, and
 612         save the changes if necessary, as per the UI spec.
 613
 614 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 615
 616         * src/maemo/Makefile.am:
 617         * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
 618         based on maemo-develoers email from Dirk.
 619
 620         * src/maemo/easysetup/modest-easysetup-wizard.c:
 621         (create_page_welcome), (create_page_account_details),
 622         (create_page_user_details), (create_page_complete_easysetup),
 623         (create_page_custom_incoming), (create_page_custom_outgoing),
 624         (create_page_complete_custom),
 625         (modest_easysetup_wizard_dialog_init):
 626         * src/maemo/modest-account-settings-dialog.c:
 627         (create_page_account_details), (create_page_user_details),
 628         (create_page_incoming), (create_page_outgoing),
 629         (modest_account_settings_dialog_init):
 630         * src/maemo/modest-connection-specific-smtp-window.c:
 631         (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
 632
 633 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 634
 635         * src/maemo/easysetup/modest-easysetup-wizard.c:
 636         (create_page_account_details), (create_page_custom_outgoing),
 637         (create_page_complete_custom):
 638         * src/maemo/modest-account-settings-dialog.c:
 639         (create_page_user_details), (create_page_incoming),
 640         (create_page_outgoing):
 641         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 642         (modest_connection_specific_smtp_edit_window_init):
 643         Use the correct (UI spec) port min/max, and use horizontal separators,
 644         as per the UI spec.
 645
 646 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 647
 648         * src/maemo/easysetup/modest-easysetup-wizard.c:
 649         (set_default_custom_servernames):
 650         * src/maemo/modest-account-settings-dialog.c:
 651         (create_page_incoming), (on_combo_outgoing_security_changed),
 652         (on_combo_incoming_security_changed), (create_page_outgoing),
 653         (modest_account_settings_dialog_set_account_name),
 654         (save_configuration):
 655         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 656         (on_combo_security_changed),
 657         (modest_connection_specific_smtp_edit_window_init),
 658         (modest_connection_specific_smtp_edit_window_set_connection),
 659         (modest_connection_specific_smtp_edit_window_get_settings):
 660         Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
 661         as per the UI spec.
 662
 663 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 664
 665         * po/en_GB.po:
 666         * src/maemo/easysetup/modest-easysetup-wizard.c:
 667         (create_page_custom_outgoing), (create_page_complete_custom):
 668         * src/maemo/modest-account-settings-dialog.c:
 669         (create_page_user_details), (create_page_outgoing):
 670         * src/maemo/modest-account-view-window.c: (button_box_new):
 671         Use changed logical IDs as per the most recent UI spec:
 672         mcen_bd_emailsetup_edit -> mcen_bd_edit
 673         mcen_bd_emailsetup_delete -> mcen_bd_delete
 674         mcen_bd_emailsetup_close -> mcen_bd_close
 675
 676 2007-04-20  2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 677
 678         * configure.ac:
 679         * src/Makefile.am:
 680         * src/dbus_api/Makefile.am:
 681         * src/dbus_api/modest-dbus-callbacks.c:
 682         * src/dbus_api/modest-dbus-callbacks.h:
 683         * src/maemo/modest-platform.c: (modest_platform_init):
 684         Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
 685         method.
 686         * tests/Makefile.am:
 687         * tests/dbus_api/Makefile.am:
 688         * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
 689
 690 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 691
 692         * src/maemo/modest-account-settings-dialog.c:
 693         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 694         Removed unnecessary includes.
 695
 696 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 697
 698         * src/maemo/easysetup/modest-easysetup-wizard.c:
 699         * src/maemo/modest-account-settings-dialog.c:
 700         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 701         * src/widgets/Makefile.am:
 702         * src/widgets/modest-easysetup-secureauth-combo-box.c:
 703         * src/widgets/modest-easysetup-secureauth-combo-box.h:
 704         * src/widgets/modest-easysetup-serversecurity-combo-box.c:
 705         * src/widgets/modest-easysetup-serversecurity-combo-box.h:
 706         * src/widgets/modest-secureauth-combo-box.c:
 707         * src/widgets/modest-secureauth-combo-box.h:
 708         * src/widgets/modest-serversecurity-combo-box.c:
 709         * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
 710         made the GObject names more consistent with the rest of the Modest code.
 711
 712 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 713
 714         * src/maemo/easysetup/Makefile.am:
 715         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 716         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
 717         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 718         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 719         * src/maemo/easysetup/modest-easysetup-wizard.c:
 720         * src/maemo/easysetup/modest-validating-entry.c:
 721         * src/maemo/easysetup/modest-validating-entry.h:
 722         * src/maemo/modest-account-settings-dialog.c:
 723         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 724         * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
 725         widgets/ because they are used outside of easysetup too. After checking in,
 726         svn will allow me to rename them too.
 727
 728 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 729
 730         * src/gnome/modest-msg-edit-window.c:
 731         (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
 732         linker error, to fix the build on the GNOME platform.
 733         modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
 734         modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
 735         ifdefed out to avoid a warning.
 736
 737 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 738
 739         * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
 740         use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
 741         some alternative for GTK+ 2.6.
 742
 743 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 744
 745         * src/maemo/modest-address-book.c: Added include to avoid a warning.
 746
 747         * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
 748         specified for EmailAccountsDialog in UI spec.
 749
 750         * src/maemo/easysetup/modest-easysetup-wizard.c:
 751         * src/maemo/easysetup/modest-easysetup-wizard.h:
 752         * src/maemo/modest-account-settings-dialog.c:
 753         * src/maemo/modest-account-settings-dialog.h:
 754         Reuse a member window widget for the connection-specific SMTP server accounts,
 755         so we can tell it to create/save the accounts only if we actually save changes.
 756
 757         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 758         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 759         (modest_connection_specific_smtp_edit_window_get_settings):
 760         Return a struct instance for temporarily remembering the entered data.
 761
 762         * src/maemo/modest-connection-specific-smtp-window.h:
 763         * src/maemo/modest-connection-specific-smtp-window.c:
 764         (modest_connection_specific_smtp_window_finalize),
 765         (modest_connection_specific_smtp_window_fill_with_connections),
 766         (on_button_edit),
 767         (modest_connection_specific_smtp_window_save_server_accounts),
 768         (update_model_server_names): Do not actually save data until asked,
 769         when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
 770
 771         (on_selection_changed),
 772         (modest_connection_specific_smtp_window_init): Disable the edit
 773         button when nothing is selected.
 774
 775         * src/modest-account-mgr-helpers.c:
 776         * src/modest-account-mgr-helpers.h:
 777         Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
 778         elsewhere.
 779
 780 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 781
 782         * src/modest-account-mgr-helpers.h:
 783         * src/modest-account-mgr-helpers.c:
 784         (modest_account_mgr_get_unused_account_name),
 785         (modest_account_mgr_get_unused_account_display_name): Added these
 786         utility functions, to avoid code duplication.
 787
 788         * src/maemo/easysetup/modest-easysetup-wizard.c:
 789         (create_page_account_details), (create_account):
 790         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 791         (on_combo_security_changed),
 792         (modest_connection_specific_smtp_edit_window_init),
 793         (modest_connection_specific_smtp_edit_window_save_settings):
 794         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 795         * src/maemo/modest-connection-specific-smtp-window.c:
 796         (modest_connection_specific_smtp_window_finalize),
 797         (modest_connection_specific_smtp_window_fill_with_connections),
 798         (on_button_edit), (modest_connection_specific_smtp_window_init):
 799         * src/maemo/modest-connection-specific-smtp-window.h:
 800         Implementing saving of connection-specific server accounts.
 801
 802         But I need to refactor this so we can save the data for each
 803         possible connection-specific account and only actually create the server accounts
 804         when the easysetup finished, or the OK button is pressed on the account settings
 805         dialog.
 806
 807 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 808
 809         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 810         (on_combo_security_changed):
 811         (modest_connection_specific_smtp_edit_window_init):
 812         Auto-fill the port number as in the account settings.
 813
 814         (modest_connection_specific_smtp_edit_window_set_connection):
 815         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 816         * src/maemo/modest-connection-specific-smtp-window.c:
 817         (fill_with_connections), (on_button_edit),
 818         (modest_connection_specific_smtp_window_init):
 819         Turn the edit window into a dialog to simplify the code, and
 820         set a WM hint as in a GtkDialog, because only a popup can be on top of
 821         another window in Maemo, and popups usually have no WM decoration.
 822
 823         * src/modest-defs.h:
 824         * src/modest-account-mgr-helpers.c:
 825         (modest_account_mgr_set_connection_specific_smtp),
 826         (modest_account_mgr_remove_connection_specific_smtp),
 827         (modest_account_mgr_get_connection_specific_smtp):
 828         * src/modest-account-mgr-helpers.h: Some functions to write the
 829         connection-specific SMTP server information. Not yet used.
 830
 831
 832         * src/widgets/modest-folder-view.c: (text_cell_data):
 833         Fix a warning about an uninitialized variable.
 834         (on_configuration_key_changed): Put an #ifdef around the use
 835         of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
 836
 837 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 838
 839         * src/maemo/modest-account-settings-dialog.h:
 840         * src/maemo/modest-account-settings-dialog.c:
 841         Added connect_for_modified() utility function to mark the new modified boolean.
 842
 843         (create_page_account_details), (create_page_user_details),
 844         (create_page_incoming), (create_page_outgoing), (on_response),
 845         (modest_account_settings_dialog_init),
 846         (modest_account_settings_dialog_set_account_name):
 847         Only warn about unsaved changes when there are actually unsaved changes.
 848
 849         * src/modest-account-mgr-helpers.c:
 850         * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
 851         into the ModestServerAccountData struct. I do not use it yet, but someone might expect
 852         to get the data from there in future.
 853
 854 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 855
 856         * src/modest-defs.h:
 857
 858         * src/modest-account-mgr-helpers.h:
 859         * src/modest-account-mgr-helpers.c:
 860         Store the security account setting in a single conf key instead of using
 861         the options list, so that the list is left for just the to-be-removed camel hack,
 862         and because gconf_client_set_list() is failing for some reason.
 863
 864         * src/modest-account-mgr.c:
 865         (modest_account_mgr_add_server_account):
 866         * src/maemo/modest-account-settings-dialog.c:
 867         (modest_account_settings_dialog_set_account_name),
 868         (save_configuration): Use the renamed functions.
 869
 870
 871 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 872
 873         * src/widgets/Makefile.am:
 874         * src/widgets/modest-limit-retrieve-combo-box.c:
 875         * src/widgets/modest-limit-retrieve-combo-box.h:
 876         * src/widgets/modest-retrieve-combo-box.c:
 877         * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
 878         the account settings dialog.
 879
 880         * src/modest-defs.h:
 881         * src/modest-account-mgr-helpers.h:
 882         * src/modest-account-mgr-helpers.c:
 883         (modest_server_account_get_option_secure_auth),
 884         (modest_server_account_set_option_secure_auth):
 885         * src/modest-account-mgr.c:
 886         (modest_account_mgr_add_server_account):
 887         Use the existing AUTH_MECH conf key for the secure-auth setting,
 888         instead of putting it in the list options, because this was actually used already.
 889
 890         * src/maemo/modest-account-settings-dialog.c:
 891         (create_page_account_details),
 892         (modest_account_settings_dialog_set_account_name),
 893         (save_configuration):
 894         * src/maemo/modest-account-settings-dialog.h:
 895         Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
 896         Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
 897
 898 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 899
 900         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 901         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 902         Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
 903
 904         * src/modest-defs.h:
 905         * src/maemo/modest-account-settings-dialog.c:
 906         (create_page_incoming), (on_combo_outgoing_security_changed),
 907         (on_combo_incoming_security_changed), (create_page_outgoing),
 908         (modest_account_settings_dialog_set_account_name),
 909         (save_configuration): Load/Save the port number, and change it when the
 910         security combo changes, to suitable defaults.
 911
 912 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 913
 914         * src/modest-account-mgr.c:
 915         (modest_account_mgr_add_server_account): Set the security and secure-auth
 916         options, and add a comment saying that the other camel-specific options should be
 917         removed in future.
 918
 919 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 920
 921         * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
 922         found by valgrind.
 923         * src/modest-tny-account-store.c: (account_list_free),
 924         (on_account_changed): Add a TODO comment about a valgrind error, caused by using
 925         cursor->data after unreffing it. But there is some strange stuff there so it might not be
 926         easy to fix.
 927
 928 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 929
 930         * src/modest-protocol-info.c:
 931         * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
 932         is required by our UI spec. Maybe something in our implementation will use this eventually.
 933         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 934         (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
 935         instead of the previous 0 placeholder.
 936
 937         * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
 938         secure-auth settings.
 939         * src/modest-account-mgr-helpers.h:
 940         * src/modest-account-mgr-helpers.c:
 941         (modest_server_account_data_get_option_secure_auth),
 942         (modest_server_account_set_option_secure_auth),
 943         (modest_server_account_data_get_option_security),
 944         (modest_server_account_set_option_security): Added this API for getting and setting the security
 945         and secure-auth settings.
 946
 947         * src/maemo/modest-account-settings-dialog.h:
 948         * src/maemo/modest-account-settings-dialog.c:
 949         (modest_account_settings_dialog_finalize), (check_data),
 950         (on_response): Store the original title as well as the name, to avoid unnececessary warnings
 951         about changing titles.
 952         (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
 953         (save_configuration): Save the security and secure-auth settings.
 954
 955         * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
 956         is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
 957
 958 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 959
 960         * src/modest-defs.h:
 961         * src/modest-account-mgr.c:
 962         (modest_account_mgr_add_server_account):
 963         Added and used defines for the options key and value pair strings,
 964         that are used so far, though they do not seem to correspond to anything in our
 965         UI specs or ModestProtocol enum.
 966
 967         * src/modest-account-mgr-helpers.h:
 968         * src/modest-account-mgr-helpers.c:
 969         (compare_option_strings_for_name),
 970         (modest_server_account_data_get_option_value),
 971         (modest_server_account_data_get_option_bool),
 972         (modest_account_mgr_get_server_account_option):
 973         Added helper functions for parsing the options GSList.
 974
 975 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 976
 977         * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
 978         display name is based on the supplied account name.
 979         * src/modest-account-mgr.c:
 980         * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
 981         with an inefficient, but good-enough, implementation.
 982
 983         * src/maemo/easysetup/modest-easysetup-wizard.c:
 984         (create_page_account_details), (on_before_next), (create_account):
 985         Check for existing display names rather than (non-user-visible) account names, and just
 986         create and set a unique account name at the end.
 987
 988         * src/maemo/modest-account-settings-dialog.c:
 989         (modest_account_settings_dialog_init),
 990         (modest_account_settings_dialog_set_account_name),
 991         (create_page_incoming): Show the display name, instead of the account name.
 992         (on_response): Do some (not all) extra checks, as in the UI spec.
 993         (save_configuration): Save the display name if it was changed.
 994
 995 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 996
 997         * po/en_GB.po: Added needed logical ID and translation.
 998         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 999         (init_view): Made the is-default column clicking work.
1000
1001 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1002
1003         * configure.ac:
1004         * src/maemo/easysetup/Makefile.am:
1005         * src/maemo/easysetup/modest-easysetup-wizard.c:
1006         (modest_easysetup_wizard_dialog_init):
1007         * src/maemo/easysetup/provider-data-test.keyfile:
1008         * src/maemo/easysetup/provider-data.keyfile:
1009         Moved the provider data file to the new modest-providers-data package and used it from there.
1010
1011 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1012
1013         * src/modest-local-folder-info.c:
1014         (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1015         N_() was already used on the static strings, but this just marks it for translation without
1016         using the translation.
1017
1018 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1019
1020         * src/maemo/modest-account-settings-dialog.c:
1021         (create_page_incoming),
1022         (modest_account_settings_dialog_set_account_name):
1023         Added comments about the need for new API in ModestAccountMgr to handle the authentication
1024         and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1025         I will do this if nobody else gets there first.
1026
1027 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1028
1029         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1030         Saved much of the incoming and outgoing data too, though I cannot yet see how to
1031         save the security stuff.
1032
1033 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1034
1035         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1036         Set the email address and user fullname, which I now see must be
1037         done separately.
1038
1039         * src/maemo/modest-account-settings-dialog.h:
1040         * src/maemo/modest-account-settings-dialog.c:
1041          (on_response),
1042         (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1043         leave-on-server and authentication.
1044         (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1045         how to do the rest.
1046
1047 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1048
1049
1050         * src/maemo/modest-account-settings-dialog.c:
1051         * src/maemo/modest-account-settings-dialog.h:
1052         Most (but not all) of the widgets are now present as specified by the UI spec.
1053         No changes are yet saved, and some details are not properly shown yet.
1054
1055         * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1056
1057 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1058
1059         * src/maemo/Makefile.am:
1060         * src/maemo/modest-account-settings-dialog.c:
1061         * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1062         an existing account. Doesn't do much yet.
1063
1064         * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1065         Open the accounts settings dialog when Edit is clicked.
1066
1067 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1068
1069         * src/maemo/easysetup/Makefile.am:
1070         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1071         (load_from_file):
1072         * src/maemo/easysetup/modest-easysetup-wizard.c:
1073         (modest_easysetup_wizard_dialog_init):
1074         Try to get the source directory from the build system,
1075         instead of hard-coding "./" into the source code, when opening our local
1076         copies of the configuration files.
1077         But this still fails when opening the wizard from the Accounts window,
1078         maybe because the working directory seems to change at runtime.
1079         So the wizard will fail the second time unless you copy the files into their
1080         proper locations - see the stdout warnings for the paths.
1081
1082         (create_page_account_details),(on_before_next):
1083         Check for existing non-server accounts instead of server accounts,
1084         so the default account name is useful again, and to prevent trying to
1085         recreate accounts.
1086
1087         * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1088         Show the wizard when New is clicked.
1089
1090         * src/widgets/modest-account-view.c: (on_account_default_toggled),
1091         (init_view): Show the column headers, and show the columns that are
1092         specified in the UI specs. However, something in Maemo's GTK+ prevents
1093         us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1094         change the default account. This is despite unsetting the special properties.
1095
1096 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1097
1098         * docs/reference/modest-design.sgml: Corrected spelling mistake.
1099         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1100         Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1101         This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1102         to make that clearer.
1103         * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1104
1105 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1106
1107         * src/maemo/modest-account-view-window.c:
1108         (modest_account_view_window_init),
1109         (modest_account_view_window_new):
1110         Use the same buttons as specified in the
1111         UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1112         the existing widgets, which never had a chance of working.
1113         Put the ModestAccountView treeview in a scrolled window.
1114         Do not repeat the initialization in both _init() and _new().
1115
1116         * src/widgets/modest-account-view.c: (update_account_view):
1117         Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1118         this widget and window shows no accounts.
1119
1120         * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1121
1122 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1123
1124         * src/maemo/easysetup/modest-easysetup-wizard.c:
1125         (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1126         (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1127         returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1128         which seems wrong.
1129
1130         * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1131         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1132         accounts exist yet, as in the UI spec.
1133
1134         * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
1135
1136 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1137
1138         * src/maemo/Makefile.am:
1139         * src/maemo/modest-connection-specific-smtp-edit-window.c:
1140         * src/maemo/modest-connection-specific-smtp-edit-window.h:
1141         New window for editing connection-specific smtp details.
1142         Not fully implemented.
1143
1144         * src/maemo/modest-connection-specific-smtp-window.c:
1145         (modest_connection_specific_smtp_window_finalize) :
1146         unref the tree model.
1147         (on_button_edit): Show the edit window.
1148
1149 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1150
1151         * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
1152         error for me.
1153
1154         * src/maemo/Makefile.am:
1155         * src/maemo/modest-connection-specific-smtp-window.c:
1156         * src/maemo/modest-connection-specific-smtp-window.h:
1157         New window for showing the list of connections, for connection-specific
1158         SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
1159         * src/maemo/easysetup/modest-easysetup-wizard.c:
1160         (create_page_custom_outgoing): Show the new window when the button is clicked.
1161
1162 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1163
1164         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1165         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1166         * src/maemo/modest-msg-edit-window.c:
1167         (modest_msg_edit_window_insert_image):
1168         * src/modest-conf.c: (modest_conf_key_escape):
1169         * src/modest-mail-operation.c:
1170         (modest_mail_operation_send_new_mail):
1171         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1172         (modest_ui_actions_on_new_account):
1173         * src/widgets/modest-attachment-view.c: (update_filename_request):
1174         * src/widgets/modest-mail-header-view.c:
1175         Corrected warnings that were breaking the build, by commenting out unused variables,
1176         and a function, and by including a header.
1177
1178 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1179
1180         * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
1181         so we can #ifdef around platform-specific code when necessary.
1182         * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
1183         to allow this to build for the GNOME platform too.
1184
1185 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1186
1187         * src/maemo/easysetup/modest-easysetup-wizard.c:
1188         Added util_increment_name() and used it in create_page_account_details()
1189         to make sure that the default account name is always a new name.
1190
1191         (modest_easysetup_wizard_dialog_init),
1192         (set_default_custom_servernames): Some minor memory management fixes.
1193
1194 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1195
1196         * Makefile.am:
1197         * configure.ac:
1198         * src/modest-runtime.c: (init_i18n): Restored the translation
1199         infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
1200         are defined in config.h, and the translations are installed.
1201
1202         * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
1203         is defined for translation.
1204
1205 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
1206
1207         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1208         (load_from_file):
1209         * src/maemo/easysetup/modest-easysetup-wizard.c:
1210         (modest_easysetup_wizard_dialog_init):
1211         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1212         Use realistic paths (though they should use $prefix generically) to the
1213         mcc_mapping and provider-data.keyfile files which might work when they
1214         are installed by the future version of the operator-wizard package,
1215         and then fallback to paths in our source code, with an explanatory
1216         warning.
1217
1218 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
1219
1220         * configure.ac:
1221         * src/Makefile.am:
1222         * src/maemo/Makefile.am:
1223         * src/maemo/easysetup/: Added files from the previously-exernal
1224         osso-modest-easysetup.
1225         * src/maemo/modest-main-window-ui.h:
1226         * src/modest-ui-actions.c:
1227         * src/modest-ui-actions.h:
1228         Added modest_ui_actions_on_new_account() as a signal handler for the
1229         New Account menu item. It shows the easysetup wizard.
1230         * po/en_GB.po: Added additional needed logical IDs and translations.
1231
1232 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
1233 Apparently ChangeLog is not used for some vague Nokia legal reasons.
1234