1 2007-06-20 Murray Cumming <murrayc@murrayc-desktop>
3 * src/modest-search.c: (modest_search_folder): Check for a GError
4 when calling tny_folder_get_headers(), to show that this is not the cause
7 2007-06-20 Murray Cumming <murrayc@murrayc.com>
9 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
10 Actually set the body query instead of the subject query.
12 * src/modest-search.c: (search_mime_part_ogs),
13 (search_mime_part_strcmp): Remove extra space from the text/* regex,
14 which would probably cause it to fail if we got this far.
16 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
18 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
19 be causing search-in-body to fail.
21 2007-06-20 Murray Cumming <murrayc@murrayc.com>
23 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
25 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
26 Better debug message when the folder cannot be found.
27 This should help with fixing projects.maemo.org bug #61287.
28 * src/modest-search.c: (add_hit): Do not leak the furl string.
30 2007-06-20 Murray Cumming <murrayc@murrayc.com>
32 * src/modest-ui-actions.c:
33 (modest_ui_actions_on_folder_selection_changed):
34 Do not special-case TNY_MERGE_FOLDER here, because
35 modest_tny_folder_get_account() already does that. This fixes
36 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
37 shown when the Outbox was selected).
39 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
41 * libmodest-dbus-client/libmodest-dbus-client.c:
42 (_dbus_iter_get_string_or_null): Initialize the string variable in
43 case this helps with Dirk's crash.
45 2007-06-19 Murray Cumming <murrayc@murrayc.com>
47 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
48 though it is not implemented yet (this function is maybe not even used),
49 to avoid breaking ABI in future.
50 * libmodest-dbus-client/libmodest-dbus-client.c:
51 (get_attachments_string): Moved some code into this generic function.
52 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
53 sends email. It is maybe not used.
54 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
55 (on_send_mail): Use attachments.
57 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
58 * src/maemo/modest-msg-edit-window.c:
59 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
60 a filename before using it, to fix projects.maemo.org bug NB#58233.
62 2007-06-19 Murray Cumming <murrayc@murrayc.com>
64 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
65 Initialize the continue_download variable to fix the build, and probably
66 to fix randome behaviour.
68 2007-06-18 Armin Burgmeier <armin@openismus.com>
70 * src/modest-tny-send-queue.h:
71 * src/modest-tny-send-queue.c: Keep track of the status of messages in
72 the queue so we can later show it in the UI. Replaced
73 modest_tny_send_queue_msg_is_being_sent() by
74 modest_tny_send_queue_get_msg_status().
76 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
78 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
79 gpointer. This probably was not harmful, but just to be sure.
81 2007-06-18 Murray Cumming <murrayc@murrayc.com>
83 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
84 Fix the build, but leave the function broken on Bora, because
85 hildon_uri_action_get_service() does not exist.
86 osso_uri_action_get_service() does not exist either, it seems.
88 2007-06-18 Murray Cumming <murrayc@murrayc.com>
90 * src/modest-tny-account.c:
91 (modest_tny_account_new_from_server_account):
92 Uncommented the url debug output again, because it is useful for
93 debugging, as I said in the comment.
95 2007-06-18 Murray Cumming <murrayc@murrayc.com>
97 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
99 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
100 for Mameo Bora, to fix the build.
102 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
105 Fixed build with hildon < 0.99
107 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
108 Check if the selected account is busy instead of checking all accounts
110 * src/modest-account-mgr-priv.h:
111 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
112 (modest_account_mgr_init), (compare_account_name),
113 (modest_account_mgr_set_account_busy),
114 (modest_account_mgr_account_is_busy):
115 * src/modest-account-mgr.h:
116 Added busy information to the account manager. It possible to
117 set an account to busy or not busy now.
119 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
120 (modest_mail_operation_update_account),
121 (modest_mail_operation_notify_end):
122 Set the account to busy/not busy depending on the operation state.
124 * src/widgets/modest-account-view.c:
125 (modest_account_view_finalize), (get_last_updated_string),
126 (update_account_view), (on_account_busy_changed), (init_view):
127 Show string "Refreshing..." if the account is currently busy.
129 All this fixes projects.maemo.org bug NB#59711
131 2007-06-14 Armin Burgmeier <armin@openismus.com>
133 * src/widgets/modest-attachments-view.h:
134 * src/widgets/modest-attachments-view.c: Added
135 modest_attachments_view_has_attachments() and fixed coordinate
136 transformation in get_att_view_at_coords(). This fixes attachment
139 * src/widgets/modest-msg-view.c: Make use of
140 modest_attachments_view_has_attachments() to decide whether to show
141 attachments in the header.
143 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
145 * src/maemo/modest-connection-specific-smtp-edit-window.c:
146 (on_change), (on_combo_security_changed),
147 (modest_connection_specific_smtp_edit_window_init),
148 (modest_connection_specific_smtp_edit_window_set_connection),
149 (modest_connection_specific_smtp_edit_window_is_dirty):
150 * src/maemo/modest-connection-specific-smtp-edit-window.h:
151 * src/maemo/modest-connection-specific-smtp-window.c:
154 Show an comfirmation dialog for the smpt-edit-window if there are
155 unsaved changes and the user hits cancel.
156 (projects.maemo.org bug NB#60479)
158 2007-06-14 Armin Burgmeier <armin@openismus.com>
160 * src/maemo/easysetup/modest-easysetup-wizard.c:
161 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
162 address" info in banner instead of node, and select all the text as
163 per UI spec. This fixes projects.maemo.org bug NB#60550.
165 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
167 reviewed by: <delete if not using a buddy>
169 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
170 * src/modest-ui-actions.c: (folder_refreshed_cb):
172 2007-06-14 Murray Cumming <murrayc@murrayc.com>
174 * src/widgets/modest-folder-view.c: (filter_row):
175 Explictly filter out the per-account outbox accounts. I don't know why
176 these only sometimes show up, but now they should never show up in the UI.
177 This should fix projects.maemo.org bug NB#60160.
179 2007-06-14 Murray Cumming <murrayc@murrayc.com>
181 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
182 when the toolbar does not exist yet.
183 * src/modest-widget-memory.c: (save_settings_header_view):
184 Added g_warnings() to help us to discover when we are trying to set
185 an empty columns list in gconf.
187 2007-06-14 Murray Cumming <murrayc@murrayc.com>
191 Added modest_init_get_default_header_view_column_ids().
193 * src/modest-widget-memory.c: (restore_settings_header_view):
194 Use the new function to get defaults, if the gconf key is empty,
195 instead of not creating any columns. This seems to fix the
196 empty right-hand pane problems.
198 * src/widgets/modest-header-view.h: Improved documentation.
200 2007-06-13 Murray Cumming <murrayc@murrayc.com>
202 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
203 Revert the use of the display name as the account name, because this
204 is generally wrong and would break the code that follows.
206 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
208 * src/maemo/easysetup/modest-easysetup-wizard.c:
209 (check_for_supported_auth_methods), (on_before_next),
212 More correct fix for projects.maemo.org bug NB# 58991
213 Do not longer accept AUTH_PASSWORD as secure method and choose
214 correct method when creating the account.
216 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
218 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
219 Fixed projects.maemo.org bug NB# 58991
221 2007-06-13 Murray Cumming <murrayc@murrayc.com>
223 * src/modest-init.c: (modest_init_init_core),
224 (modest_init_local_folders): Fixed compilation errors.
226 2007-06-13 Murray Cumming <murrayc@murrayc.com>
228 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
229 Remove unnecessary lib/include, though it is good in principle when needed.
231 * src/modest-init.c: (modest_init_one_local_folder),
232 (modest_init_local_folders):
233 * src/modest-init.h: Initialize the .modest library for memory cards,
234 instead of just doing nothing for them. This should allow us to create
235 folders there, fixing projects.maemo.org bug NB#59297.
237 2007-06-13 Murray Cumming <murrayc@murrayc.com>
239 * libmodest-dbus-client/libmodest-dbus-client.c:
240 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
241 (libmodest_dbus_client_compose_mail),
242 (libmodest_dbus_client_open_message),
243 (libmodest_dbus_client_send_and_receive),
244 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
246 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
247 (on_idle_open_message), (modest_dbus_req_handler),
248 (search_result_to_message), (modest_dbus_req_filter):
249 * src/modest-search.c: (add_hit), (modest_search_folder),
250 (modest_search_all_accounts): Improved debug messages.
252 * tests/dbus_api/test_open_message.c: (main): Improved comments.
254 * src/modest-tny-account-store.c:
255 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
258 2007-06-13 Murray Cumming <murrayc@murrayc.com>
261 2007-06-12 Murray Cumming <murrayc@murrayc.com>
263 * src/modest-tny-account-store.c: (get_server_accounts):
264 Call modest_tny_local_folders_account_add_merged_outbox_folders()
265 even when there are no accounts, so that the Outbox folder is always
266 visible. This fixes projects.maemo.org bug NB#60158.
268 2007-06-12 Murray Cumming <murrayc@murrayc.com>
270 * src/maemo/modest-main-window.c: (create_details_widget):
271 Use the mcen_va_never logical ID.
273 2007-06-12 Murray Cumming <murrayc@murrayc.com>
275 * src/dbus_api/modest-dbus-api.h:
276 * src/dbus_api/modest-dbus-callbacks.c:
277 (on_idle_open_default_inbox), (on_open_default_inbox),
278 (modest_dbus_req_handler):
279 Added a new OpenDefaultInbox method.
281 * libmodest-dbus-client/libmodest-dbus-client.h:
282 * libmodest-dbus-client/libmodest-dbus-client.c:
283 Added libmodest_dbus_client_open_default_inbox() to call the new
284 dbus method. This should be useful to projects.maemo.org bug NB#57214,
285 though it should maybe be used by a new osso-email-interface function.
287 * tests/dbus_api/Makefile.am:
288 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
291 2007-06-12 Murray Cumming <murrayc@murrayc.com>
293 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
294 NULL, so that the signals get all the keys. This should not actually
295 change any behaviour because we currently update everything when anything
298 2007-06-12 Murray Cumming <murrayc@murrayc.com>
300 * src/widgets/modest-folder-view.c: (text_cell_data),
301 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
302 (find_inbox_iter): If tinymail tells us that the folder is
303 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
304 This causes the inbox to be selected at startup, fixing part of
305 projects.maemo.org bug NB#56305.
307 * src/modest-ui-dimming-rules.c:
308 (modest_ui_dimming_rules_on_tools_smtp_servers):
309 * src/modest-ui-dimming-rules.h: Added a callback function to dim
310 the SMTP servers menu item.
311 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
312 that the SMTP Servers menu item is dimmed when there are no accounts,
313 as a future version of the UI spec will require. This fixes
314 projects.maemo.org bug NB#56305.
316 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
318 * src/maemo/modest-maemo-utils.c:
319 (modest_maemo_utils_get_supported_secure_authentication_methods):
320 Added label to dialog instead of unreadable title
322 * src/maemo/modest-main-window.c: (sync_accounts_cb),
323 (modest_main_window_new):
324 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
327 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
328 * src/modest-account-mgr.h:
329 Added method to avoid code duplication
331 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
332 (modest_ui_actions_on_send_receive):
333 Use modest_account_mgr_has_accounts
335 2007-06-11 Murray Cumming <murrayc@murrayc.com>
337 * src/maemo/easysetup/modest-presets.c:
338 (modest_presets_get_info_server_security): Do not report secure auth
340 * src/modest-protocol-info.c: Use the defines for the gconf key names
341 for secure authentication. This was not working because we were writing
342 Password and reading password, and the check was case sensitive.
343 With this, gmail now works for receiving and sending when created via
346 2007-06-11 Murray Cumming <murrayc@murrayc.com>
348 * src/maemo/easysetup/modest-presets.c:
349 (modest_presets_get_info_server_security): Correct the key name for
350 SecureSmtp, because it seems to be case-sensitive.
351 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
352 Do not try to get the 0th notebook page if there are 0 pages, to
355 2007-06-11 Murray Cumming <murrayc@murrayc.com>
357 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
358 Prevent use of the new notification feature for now, because it currently
359 shows one dialog for each new email, which is annoying.
361 2007-06-11 Murray Cumming <murrayc@murrayc.com>
363 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
364 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
365 when no country was selected, so that we show the global ones.
366 * src/maemo/easysetup/modest-presets.c:
367 (modest_presets_get_providers): Return only the global providers, not
368 all providers when mmc=0 was requested.
370 2007-06-11 Murray Cumming <murrayc@murrayc.com>
372 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
373 (easysetup_provider_combo_box_fill): Remove debug code that showed the
374 provider ID in the combo.
376 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
377 Do not show the page numbers, because it would be confusing when we add
378 the 2 extra pages for the custom setup, when the user chooses the "Other"
379 provider. This fixes projects.maemo.org bug NB#59028
381 * src/modest-init.c: (modest_init_init_core),
382 (modest_init_local_folders):
384 * src/modest-tny-account.c:
385 (modest_tny_account_new_for_local_folders): Do not create default folders
386 for the memory card. This should fix projects.maemo.org bug NB#59328.
388 2007-06-11 Murray Cumming <murrayc@murrayc.com>
390 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
391 Free the changed_conf_keys string items. They are already freed in the
392 idle handler if that runs first.
394 2007-06-11 Murray Cumming <murrayc@murrayc.com>
396 * src/modest-ui-actions.c:
397 (modest_ui_actions_on_password_requested): Check that the server name
398 is not NULL, because I just saw a password dialog with (null) as the
401 * src/modest-tny-folder.[h|c]: Added
402 modest_tny_folder_is_memory_card_folder().
403 * src/modest-ui-dimming-rules.c:
404 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
405 menu item for memory cards, as per the UI spec (section 7.4). This should
406 fix projects.maemo.org bug NB#59297.
408 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
410 * src/maemo/modest-main-window.c: (sync_accounts_cb):
411 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
412 is another problem with the code, see Murray's comment at line 772)
414 2007-06-08 Murray Cumming <murrayc@murrayc.com>
416 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
417 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
418 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
419 (load_from_file), (easysetup_country_combo_box_init),
420 (easysetup_country_combo_box_get_active_country_ids),
421 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
422 instead of just one ID, to avoid duplicate country names in the UI.
424 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
425 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
426 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
427 a single ID, avoiding duplicate providers.
428 * src/maemo/easysetup/modest-easysetup-wizard.c:
429 (on_combo_account_country): Adapt to use a list.
431 2007-06-08 Murray Cumming <murrayc@murrayc.com>
433 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
434 keys changed in the last X seconds.
436 * src/modest-account-mgr.h:
437 * src/modest-account-mgr.c: (on_timeout_notify_changes),
438 (on_key_change), (modest_account_mgr_class_init),
439 (modest_account_mgr_init), (modest_account_mgr_finalize):
440 As the keys are changed, save them in a GSList* and signal that GSList*
441 further every X seconds, to batch changes, to allow us to do just one
442 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
443 bug NB#56941 and other (UI-blocking) delays when changing account settings.
445 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
446 changed signal signature.
448 * src/modest-conf.c: (modest_conf_set_list),
449 (modest_conf_on_change): Reenable notification.
451 (modest_conf_maemo_fake_on_change): Comment out the hack that
452 notified immediately instead of asynchronously.
454 * src/widgets/modest-account-view.h:
455 * src/widgets/modest-account-view.c:
456 (update_account_view): Select the previously-selected account ID,
457 if possible. This fixes projects.maemo.org bug NB#56933.
459 (on_account_changed), (on_account_removed),
460 (modest_account_view_select_account):
462 Remove the block/unblock functions
463 because they were not useful.
465 * src/maemo/modest-account-view-window.c:
466 (on_delete_button_clicked), (on_edit_button_clicked),
467 (on_new_button_clicked): Remove the use of the non-working block/unblock.
469 2007-06-08 Murray Cumming <murrayc@murrayc.com>
471 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
472 Improve the error dialog to show Incorrect Account Settings, which seems
473 clearer, and say that the internal error message (to be removed from the
474 dialog later) is often misleading.
475 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
477 * src/modest-tny-account.c:
478 (modest_tny_account_new_from_server_account): Uncomment the printf of the
479 URL because this is so useful for debugging on the device.
481 * src/widgets/modest-serversecurity-combo-box.c:
482 (modest_serversecurity_combo_box_fill): Correct a logical ID.
484 2007-06-08 Murray Cumming <murrayc@murrayc.com>
486 * src/modest-mail-operation.c:
487 (modest_mail_operation_send_new_mail):
488 Added a comment about a nasty but apparently harmless message. Details
489 added to the wiki g_warnings() page.
491 2007-06-08 Murray Cumming <murrayc@murrayc.com>
493 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
494 (modest_tny_send_queue_class_init):
495 Do not use the priv struct because it is empty, to avoid g_warnings
496 about a non-existant priv struct.
498 * src/modest-tny-account-store.c:
499 (modest_tny_account_store_get_server_account),
500 (modest_tny_account_store_get_transport_account_for_open_connection
501 ): Do not try to get transport server accounts for local folders,
502 because they don't have any. This avoids a g_warning().
504 * src/maemo/modest-main-window.c:
505 (modest_main_window_notify_send_receive_initied),
506 (on_configuration_key_changed):
507 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
509 * src/modest-mail-operation.c:
510 (modest_mail_operation_update_account):
511 * src/modest-tny-account-store.h:
512 * src/modest-tny-account.c:
513 (modest_tny_account_get_special_folder),
514 (modest_tny_account_new_for_local_folders),
515 (modest_tny_account_new_for_per_account_local_outbox_folder):
516 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
517 * src/modest-tny-local-folders-account.c:
518 (add_account_folders_to_merged_folder):
519 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
520 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
521 (modest_ui_actions_on_send):
522 * src/widgets/modest-folder-view.c: (update_model):
523 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
524 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
525 modest_tny_account_store_get_tny_account_by_account() to
526 modest_tny_account_store_get_server_account() to make the code clearer.
528 2007-06-07 Marcus Bauer <marcusb@openismus.com>
530 * src/dbus_api/modest-dbus-api.h:
531 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
532 * src/maemo/modest-msg-edit-window.c:
533 (modest_msg_edit_window_attach_file_noninteractive):
534 added g_warning in case the file to be attached does not exist
535 * tests/dbus_api/test_compose_mail.c: (main):
536 removed obsolete comment, added generic files as test case
538 2007-06-07 Murray Cumming <murrayc@murrayc.com>
540 * src/modest-tny-account-store.c: (get_server_accounts):
541 Create the local folders account only once, not once for each outbox, and
542 not only when there are some outboxes.
544 2007-06-07 Murray Cumming <murrayc@murrayc.com>
546 * src/widgets/modest-folder-view.c: (update_model): Comment out some
547 code that is causing a crash at startup. Sergio says that he is fixing this.
549 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
551 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
552 * src/maemo/modest-account-settings-dialog.c:
553 (create_page_outgoing),
554 (modest_account_settings_dialog_set_account_name),
555 (save_configuration):
556 - Fixed handling of the "Use secure authentication" toggle to comply with
557 the ui specification. See also projects.maemo.org bug NB#58400
559 - Restore the Secure connection setting combo correctly when loading
562 * src/maemo/modest-maemo-utils.c:
563 (on_camel_account_get_supported_secure_authentication),
564 (modest_maemo_utils_get_supported_secure_authentication_methods):
565 Fixed a crasher if operation is canceled
567 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
568 (modest_protocol_info_auth_is_secure):
569 * src/modest-protocol-info.h:
571 Added two new methods to determine if a protocol/auth method is secure/encrypted in
572 the sense of the "Use secure authentication" toggle.
574 2007-06-07 Murray Cumming <murrayc@murrayc.com>
576 * src/modest-tny-account-store.h:
577 * src/modest-tny-account-store.c:
578 Added modest_tny_account_store_get_local_folders_account().
580 * src/modest-tny-folder.h:
581 * src/modest-tny-folder.c:
582 (modest_tny_folder_get_account):
583 Added this replacement for tny_folder_get_account() which returns
584 the local-folders account for TnyMergeFolders, to avoid the
585 warning about the unimplemented get_account_func() vfunc().
587 (modest_tny_folder_get_rules),
588 * src/modest-ui-actions.c:
589 (modest_ui_actions_on_folder_selection_changed):
590 * src/modest-mail-operation.c:
591 (modest_mail_operation_remove_folder),
592 (modest_mail_operation_xfer_folder),
593 (modest_mail_operation_rename_folder),
594 (modest_mail_operation_get_msg),
595 (modest_mail_operation_get_msgs_full),
596 (modest_mail_operation_remove_msg),
597 (modest_mail_operation_xfer_msgs),
598 (modest_mail_operation_refresh_folder):
599 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
601 2007-06-07 Murray Cumming <murrayc@murrayc.com>
603 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
604 (modest_server_account_set_security):
605 * src/modest-defs.h: Add comments explaining that our
606 UI spec means TLS when it says Normal, so these do not look like errors.
608 * src/modest-tny-account.c:
609 (modest_tny_account_new_from_server_account): Use the new tinymail
610 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
611 for TLS. This should fix projects.maemo.org bug NB#58460.
613 2007-06-06 Murray Cumming <murrayc@murrayc.com>
615 * src/maemo/easysetup/modest-easysetup-wizard.c:
616 (create_account): Correct the position of the gconf sanity check warning.
617 (on_button_edit_advanced_settings): Show the dialog immediately, instead
618 of using the g_idle_add() hack, because this does not seem to be necessary
619 on osso 1.1. It might even work on Maemo Bora if the problems were actually
620 caused by something other than maemo's gconf.
621 This fixes projects.maemo.org bug #59022.
623 2007-06-06 Murray Cumming <murrayc@murrayc.com>
625 * src/modest-account-mgr-helpers.c:
626 (modest_account_mgr_get_default_account): Do not check that the account
627 exists if there is no default account (NULL), to fix a runtime warning.
629 2007-06-06 Murray Cumming <murrayc@murrayc.com>
631 * src/widgets/modest-folder-view.c: (update_model):
632 Do not unref the treemodel before we have finished with it.
633 This prevents a valgrind warning and an occasional crash at startup.
635 2007-06-06 Marcus Bauer <marcusb@openismus.com>
637 * libmodest-dbus-client/libmodest-dbus-client.h:
638 added libmodest_dbus_client_compose_mail()
639 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
641 added functions needed for SendAsMail() functionality
642 * src/maemo/modest-msg-edit-window.c:
643 (modest_msg_edit_window_attach_file_noninteractive):
644 non interactively attaching files to message edit window
645 * src/widgets/modest-msg-edit-window.h:
646 * tests/dbus_api/Makefile.am:
647 added test_compose_mail.c
648 * tests/dbus_api/test_compose_mail.c: (main):
650 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
652 * src/modest-account-view.c:
653 Fixed bug projects.maemo.org bug NB#59307
655 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
657 * src/maemo/easysetup/modest-easysetup-wizard.c:
658 (get_serverport_incoming), (on_before_next), (create_account):
659 * src/maemo/modest-account-settings-dialog.c:
660 (modest_account_settings_dialog_set_account_name):
661 * src/maemo/modest-maemo-utils.c:
662 (on_camel_account_get_supported_secure_authentication_status),
663 (on_camel_account_get_supported_secure_authentication),
664 (on_secure_auth_cancel),
665 (modest_maemo_utils_get_supported_secure_authentication_methods):
667 Implemented security authentication for settings and easysetup.
669 2007-06-05 Murray Cumming <murrayc@murrayc.com>
671 * src/maemo/modest-main-window.c: (create_details_widget):
672 Show the total size for memory card accounts too, instead of showing
673 the name again. Fixes bug projects.maemo.org bug NB#59307.
675 2007-06-05 Murray Cumming <murrayc@murrayc.com>
678 * src/modest-tny-simple-folder-store.c:
679 * src/modest-tny-simple-folder-store.h: Removed.
681 * src/modest-tny-local-folders-account.h
682 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
683 for the local-folders maildir, with an extra TnyMergedFolder containing
684 the folders of the per-account outbox store accounts.
685 * src/modest-tny-account-store.c: (get_server_accounts):
686 Add the outboxes to the special local folders account after creating it.
688 * src/modest-tny-account.c:
689 (modest_tny_account_new_for_local_folders): Create the derived
690 account when creating the main local-folders account.
692 * src/maemo/modest-main-window.c: (create_details_widget),
693 (modest_main_window_set_contents_style):
694 Adapted to the use of the derived account instead of the folder store.
696 * src/modest-ui-actions.c:
697 (modest_ui_actions_on_folder_selection_changed):
698 * src/modest-ui-dimming-rules.c:
699 (modest_ui_dimming_rules_on_new_folder):
700 * src/widgets/modest-folder-view.c: (text_cell_data),
701 (icon_cell_data), (filter_row), (update_model),
702 (get_cmp_rows_type_pos):
705 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
706 Do not get the priv struct, because no priv struct has been set,
707 to avoid a runtime warning.
709 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
710 #ifelse with #else, to fix a warning, to fix the build.
713 2007-06-05 Christian Kellner <ckellner@openismus.com>
715 * libmodest-dbus-client/libmodest-dbus-client.c:
716 Fix small typo in doc (why do you always see them
717 AFTER committing stuff?)
720 2007-06-05 Christian Kellner <ckellner@openismus.com>
722 * libmodest-dbus-client/libmodest-dbus-client.c:
723 (libmodest_dbus_client_search):
724 Initialize hit list with NULL. Also set folder list
725 to "" if NULL was supplied.
728 2007-06-03 Christian Kellner <ckellner@openismus.com>
730 * libmodest-dbus-client/libmodest-dbus-client.c:
731 (modest_search_hit_list_free):
732 Make it save to call it with NULL.
734 * src/dbus_api/modest-dbus-callbacks.c:
735 * src/modest-search.c:
736 Return full ModestSearchHits as the search result list not TnyHeader
737 since can't be around withouth the correspoding TnyFolder.
739 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
741 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
742 Added currently commented code to check for secure auth
744 * src/maemo/modest-account-settings-dialog.c: (on_response),
745 (save_configuration), (show_ok):
746 Fixed projects.maemo.org bugs NB #59248 and #59251
748 * src/maemo/modest-maemo-utils.c:
749 (on_camel_account_get_supported_secure_authentication_status),
750 (on_camel_account_get_supported_secure_authentication),
751 (modest_maemo_utils_get_supported_secure_authentication_methods):
752 * src/maemo/modest-maemo-utils.h:
753 Moved get_supported_secure_authentication() method here to be able
754 to use it from easysetup wizard.
756 * src/modest-pair.c: (on_pair_compare_as_string):
757 Should compare string with first part of pair and not
758 strcmp pairs which will crash.
760 * src/modest-protocol-info.c:
761 (modest_protocol_info_protocol_is_store):
762 * src/modest-protocol-info.h:
763 Added modest_protocol_info_get_auth_protocol_name()
765 2007-06-03 Armin Burgmeier <armin@openismus.com>
767 * src/modest-mail-operation.c:
768 (modest_mail_operation_get_msgs_full): Set priv->account also when
769 only retrieving a single message. This avoids a crash when canceling
772 (modest_mail_operation_notify_end): Do not explicitely remove the
773 operation from the queue but only emit the progress_changed signal.
774 The queue itself listens to that signal to remove the operation when
775 it is finished. This reduces coupling and removes a potential deadlock
776 when modest_mail_operation_notify_end() is called from the queue
777 itself. If that is a problem performance-wise, I would suggest to
778 implement a status-changed signal or something.
780 * src/modest-mail-operation-queue.c: Make sure to never call a
781 function from another file while the queue is locked. This (hopefully)
782 fixes another deadlock when exiting the application while retrieving
785 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
787 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
788 Fixed build if libogs is not available
790 2007-06-03 Christian Kellner <ckellner@openismus.com>
792 * libmodest-dbus-client/libmodest-dbus-client.h:
793 * libmodest-dbus-client/libmodest-dbus-client.c:
794 (libmodest_dbus_client_delete_message):
795 Implement deletion of messages (Client side).
797 (modest_search_hit_free),
798 (modest_search_hit_list_free):
799 Utility functions to free the result hits.
801 * src/dbus_api/modest-dbus-api.h:
802 * src/dbus_api/modest-dbus-callbacks.c:
804 (modest_dbus_req_handler):
805 Implement deletion of messages (Server side).
807 * tests/dbus_api/test_search.c: (main):
810 * tests/dbus_api/Makefile.am:
811 * tests/dbus_api/test_delete_message:
812 Add little test for the message deletion logic
814 2007-06-03 Armin Burgmeier <armin@openismus.com>
816 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
817 when the operation queue was not empty. projects.maemo.org bug
820 2007-06-03 Armin Burgmeier <armin@openismus.com>
822 * src/widgets/modest-account-view.c
823 (on_account_default_toggled): Toggle default account column
824 explicitely instead of waiting for gconf notification (which is
825 currently ignored). This should fix projects.maemo.org bug NB#56910
826 for now. It should probably be removed when gconf notifications are
829 2007-06-03 Christian Kellner <ckellner@openismus.com>
831 * libmodest-dbus-client/libmodest-dbus-client.c:
832 Removed debugging spew.
834 * src/dbus_api/modest-dbus-callbacks.c:
835 Added debugging info.
837 * src/modest-search.c:
838 (modest_search_all_accounts):
839 Use tny_account_store_get_accounts () on the account store
840 to get all accounts which is the way to get all accounts.
842 * tests/dbus_api/test_search.c: (main):
843 Make it possible to supply the search term on the command line.
845 2007-06-03 Christian Kellner <ckellner@openismus.com>
847 * libmodest-dbus-client/libmodest-dbus-client.c:
848 * libmodest-dbus-client/libmodest-dbus-client.h:
849 Implement searching for mesages over raw dbus. (Client side)
851 * src/dbus_api/Makefile.am:
852 * src/dbus_api/modest-dbus-api.h:
853 * src/dbus_api/modest-dbus-callbacks.c:
854 * src/dbus_api/modest-dbus-callbacks.h:
855 Search framework (Server side). Also implement on_idle_open_message().
857 * src/maemo/modest-platform.c: (modest_platform_init):
858 Prepare for raw dbus/osso rpc interaction.
860 * src/modest-search.h:
861 Changed minsize from unspecific guint to guint32.
863 * src/modest-search.c:
865 Added strange hack which magically made tnymail work.
867 (modest_search_folder),
868 (modest_search_account),
869 (modest_search_all_accounts):
870 Implement helper functions to search all accounts, specific account
873 * tests/dbus_api/Makefile.am:
874 * tests/dbus_api/test_open_message.c:
875 Read url to open from commandline.
877 * tests/dbus_api/test_search.c:
878 Implement small test for dbus search stuff
880 2007-06-02 Armin Burgmeier <armin@openismus.com>
882 * src/maemo/modest-account-settings-dialog.c: Changed window title to
883 include account type and account title. This fixes projects.maemo.org
886 * src/maemo/modest-account-view-window.c: Set a title for the window.
888 2007-06-02 Armin Burgmeier <armin@openismus.com>
890 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
891 incoming and outgoing server name based on email address and server
892 types as long as the names have not been edited manually. This fixes
893 projects.maemo.org bug NB#58671.
895 2007-06-02 Armin Burgmeier <armin@openismus.com>
897 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
898 server type cannot be changed in future to the incoming details page
899 when creating an account. This fixes projects.maemo.org bug NB#59029.
901 2007-06-02 Armin Burgmeier <armin@openismus.com>
903 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
904 and assigned max width chars so that they wrap instead of being
905 truncated. Fixes projects.maemo.org bug NB#56126.
907 2007-06-02 Armin Burgmeier <armin@openismus.com>
909 * src/maemo/modest-connection-specific-smtp-window.c: Add an
910 introductory note to the connection specific smtp servers dialog, as
911 section 8.12 of the email UI specification requires. This fixes
912 projects.maemo.org bug NB#59212.
914 2007-06-01 Murray Cumming <murrayc@murrayc.com>
916 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
917 Check for running mail operations, and offer to cancel them, as per the UI
918 spec. This fixes projects.maemo.org bug NB#59041 .
919 However, I suspect that tinymail may still use the network connection
920 in ways that we cannot detect or cancel. But it should at least adapt to
923 2007-06-01 Murray Cumming <murrayc@murrayc.com>
925 * src/modest-tny-account-store.c: (recreate_all_accounts),
926 (get_cached_accounts), (get_server_accounts): Do more sensible
927 ref-counting of the temporarily-cached outbox accounts list. This seems
928 to fix a crash when entering the password when the password was wrong.
930 2007-06-01 Murray Cumming <murrayc@murrayc.com>
932 * src/gnome/modest-main-window.c: (connect_signals):
933 * src/modest-tny-account-store.c: (get_password),
934 (modest_tny_account_store_alert): Added comments and clues and
935 commented-out code about how we currently fail to deal with connection
936 errors and wrong passwords, and how we should.
938 2007-06-01 Murray Cumming <murrayc@murrayc.com>
940 * src/widgets/modest-retrieve-combo-box.c:
941 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
942 This fixes projects.maemo.org bug NB#58472 .
944 2007-06-01 Murray Cumming <murrayc@murrayc.com>
946 * src/maemo/easysetup/modest-easysetup-wizard.c:
947 (create_page_complete_easysetup):
948 (create_page_complete_custom): Correct the last commit,
949 putting the correct sentences in the correct pages.
951 2007-06-01 Murray Cumming <murrayc@murrayc.com>
953 * src/maemo/easysetup/modest-easysetup-wizard.c:
954 (create_page_complete_custom): Show the second sentence of text
955 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
958 2007-06-01 Murray Cumming <murrayc@murrayc.com>
960 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
961 Set the leave-on-server conf key by default. This fixes
962 projects.maemo.org bug NB#59258 .
964 2007-06-01 Murray Cumming <murrayc@murrayc.com>
966 * src/maemo/modest-account-view-window.c:
967 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
968 logical ID for the confirmation messages. Fixed projects.maemo.org bug
971 2007-06-01 Murray Cumming <murrayc@murrayc.com>
973 * src/maemo/easysetup/modest-easysetup-wizard.c:
974 (create_caption_new_with_asterisk):
975 * src/maemo/modest-account-settings-dialog.c:
976 (create_caption_new_with_asterisk):
977 Uncomment the code to add the asterisk, because they are no longer in the
978 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
979 (update_incoming_server_title): Add an asterisk here too.
981 2007-06-01 Murray Cumming <murrayc@murrayc.com>
983 * src/maemo/modest-maemo-global-settings-dialog.c:
984 (current_connection): Check that we are even connected before trying to
985 get the current connection name, to prevent a warning.
987 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
988 Change the comments because tny_maemo_conic_device_connect() is now meant to
990 * src/modest-mail-operation.c:
991 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
992 make sure we have a connection and fail if we can't connect.
994 2007-05-31 Murray Cumming <murrayc@murrayc.com>
996 * src/maemo/modest-main-window.c:
997 (on_account_store_connecting_finished): Do not try to get the
998 connection ID if we are not really connected. I am surprised that
999 this signal handler is called when we are not connected.
1001 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1003 * src/modest-error.h:
1004 * src/modest-ui-actions.c:
1005 (modest_ui_actions_get_msgs_full_error_handler):
1006 Renamed an enum, added comments, added an enum
1007 for retrieve-limit errors.
1009 * src/modest-mail-operation.c: (foreach_add_item),
1010 (internal_folder_observer_update), (update_account_thread),
1011 (modest_mail_operation_get_msgs_full):
1012 (modest_mail_operation_update_account),
1013 Added comments about how this works, and some code that should
1014 (but does not) check the retrieve-limit. See the TODO comment.
1016 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1018 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1019 Initialize help_id to fix the build. Warnings are good.
1021 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1023 * src/widgets/modest-hbox-cell-renderer.c:
1024 (modest_hbox_cell_renderer_append):
1025 * src/widgets/modest-vbox-cell-renderer.c:
1026 (modest_vbox_cell_renderer_append):
1027 Fix the last commit by doing an extra ref.
1029 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1031 * src/widgets/modest-hbox-cell-renderer.c:
1032 (modest_hbox_cell_renderer_append):
1033 * src/widgets/modest-vbox-cell-renderer.c:
1034 (modest_vbox_cell_renderer_append):
1035 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1036 to fix the build with Maemo Bora.
1037 However, there seems to be a remaining crash, probably due to reference
1040 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1042 * src/modest-tny-account.c:
1043 (modest_tny_account_new_for_local_folders):
1044 Use hildon_file_system_info_async_new() to get a better name for
1045 the memory card account, setting it as the account name.
1046 The timing seems to work, but this is probably
1047 not the best place to do this. See the TODO comment.
1048 * src/maemo/modest-main-window.c: (create_details_widget):
1049 * src/widgets/modest-folder-view.c: (text_cell_data):
1050 Use the tny account name instead of hardcoding a name.
1052 2007-05-30 Christian Kellner <ckellner@openismus.com>
1054 * src/modest-search.c: (modest_search):
1055 Correctly set part_search_func even if we have already parsed
1056 the query and thus a valid OgsTextSearcher object.
1058 2007-05-30 Christian Kellner <ckellner@openismus.com>
1061 Search and check for libogs.
1064 Incooparte the ogs build env.
1066 * src/modest-mime-part-search-stream.c:
1067 * src/modest-mime-part-search-stream.h:
1068 Removed since we do the real searching now in modest-search.c.
1070 * src/modest-search.c:
1071 * src/modest-search.h:
1072 Implement support for ogs. We use that if available and requested
1073 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1074 should now handle the corner case when the search term is spread
1075 across multiple reads.
1076 Also the logic in modest_search () was corrected to search all
1077 requested fields until one is found.
1079 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1081 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1083 * src/modest-init.h:
1084 * src/modest-init.c: Made modest_init_local_folders() take a
1085 path and be public so we can iniitialize maildir folders on
1088 * src/modest-local-folder-info.h:
1089 * src/modest-local-folder-info.c:
1090 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1092 * src/modest-tny-account.c:
1093 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1094 still means the standard local-folders path on the local volume.
1096 * src/modest-tny-account-store.c:
1097 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1098 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1099 all accounts when that happens.
1100 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1101 this too, so it shows up in the treeview.
1103 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1105 * src/maemo/modest-maemo-global-settings-dialog.c:
1106 (current_connection):
1107 * src/widgets/modest-global-settings-dialog.c:
1108 (current_connection_default):
1109 Use the enum values instead of 0, 1 and -1,
1110 to make the code clearer.
1112 * src/modest-account-mgr-helpers.c:
1113 (modest_account_mgr_get_connection_specific_smtp): Make this code
1116 * src/modest-runtime.h:
1117 * src/modest-runtime.c:
1118 Added modest_runtime_remove_all_send_queues().
1119 * src/maemo/modest-main-window.c:
1120 (on_account_store_connecting_finished): Recreate the send queues,
1121 using the appropriate transport accounts for this new connection.
1122 Some futher adapting might be needed if the old send queues are not
1123 automatically stopped at this point.
1125 * src/modest-tny-account-store.c: (get_server_accounts):
1126 Create the connection-specific transport accounts, so that they can
1127 be found later by their ID.
1129 * src/modest-tny-account.h:
1130 * src/modest-tny-account.c:
1131 Added modest_tny_account_new_from_server_account_name().
1132 modest_tny_account_new_from_server_account(): Do not create the
1133 send queues here, because they will be
1134 recreated anyway when the connection changes for the first time.
1136 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1138 * src/modest-local-folder-info.h:
1139 * src/modest-local-folder-info.c:
1140 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1141 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1142 tbox_folder): Take a modest account name instead of a server TnyAccount,
1143 so we can have per-modest-account rather than per-transport-account
1145 We must make sure that we change or recreate the exisitng send queues
1146 when the connection changes for connection-specific transport accounts.
1148 * src/modest-tny-account-store.c:
1149 (create_per_account_local_outbox_folders): Create outboxed per modest
1150 account, not per transport account.
1152 * src/modest-tny-account.h:
1153 * src/modest-tny-account.c:
1154 (modest_tny_account_get_special_folder): For outboxes, get the
1155 parent modest account name. The account is ignored for other folders.
1156 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1157 modest account name rather than a server TnyAccount.
1159 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1161 * src/modest-tny-account.c:
1162 (modest_tny_account_new_from_server_account):
1163 Call modest_runtime_get_send_queue() immediately after creating transport
1164 accounts, so that they start trying to send email from the outbox as soon
1165 as possible at startup. This is probably what we want.
1167 * src/modest-mail-operation.c: (update_account_thread):
1168 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1169 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1170 * src/modest-tny-send-queue.h:
1171 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1172 (modest_ui_actions_on_send):
1173 Added comments about how sending works, though it needs some more work.
1175 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1177 * src/modest-tny-account.c:
1178 (modest_tny_account_get_special_folder): Add TODO because this fails when
1179 the network is busy.
1180 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1181 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1182 Do not try to show this window when there is no active account. The UI
1183 specs does not tell us what to do in this case.
1185 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1189 * src/maemo/Makefile.am:
1190 * src/widgets/Makefile.am: Some dist fixes.
1192 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1194 * src/maemo/modest-connection-specific-smtp-window.c:
1195 (on_button_edit): Make the code clearer, to prevent a double free.
1197 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1199 * src/maemo/modest-account-settings-dialog.c:
1200 (modest_account_settings_dialog_set_account_name),
1201 Check the connection-specific smtp servers checkbox if there are any.
1203 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1204 (modest_connection_specific_smtp_edit_window_init):
1205 Start with a suitable port number.
1207 * src/modest-account-mgr-helpers.h:
1208 * src/modest-account-mgr-helpers.c: Added
1209 modest_account_mgr_get_has_connection_specific_smtp().
1211 (modest_account_mgr_set_connection_specific_smtp),
1212 (modest_account_mgr_remove_connection_specific_smtp),
1213 (modest_account_mgr_get_has_connection_specific_smtp),
1214 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1215 connection-specific smtp server accounts in the account, rather than
1216 the server account conf dir.
1218 This fixes bug projects.maemo.org bug NB#58263 .
1220 * src/modest-tny-account-store.c:
1221 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1222 if there are no server accounts yet, to prevent an infinite loop when there
1223 are no accounts. Document that one must be called before the other.
1225 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1227 * src/modest-account-mgr-helpers.c:
1228 (modest_account_mgr_get_default_account): Make sure that at least
1229 one account is always the default, if there are any enabled accounts.
1230 This is just a sanity check that shouldn't be necessary.
1232 * src/modest-account-mgr-priv.c:
1233 (_modest_account_mgr_account_from_key): Unescape the conf key to
1234 get the real account name. For instance, this is an issue if a space
1235 was in the account name, which can happen because the account name
1236 is generated from the display name.
1237 (_modest_account_mgr_get_account_keyname): Always escape the
1239 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1240 Unescape the conf keys to get the real account names.
1242 For instance, previously the is-default radio button in the accounts
1243 list was not checked for any accounts at first. This fixes that,
1244 and might fix several similar bugs.
1246 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1248 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1249 Removed some debug printfs.
1251 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1253 Modest on-disk outbox directories are now here, for instance:
1254 $HOME/.modest/outboxes/<account-id-1>/outbox
1255 $HOME/.modest/outboxes/<account-id-2>/outbox
1257 $HOME/.modest/local-folders/outbox
1258 so we can have a separate outbox for each account.
1259 But they are shown as one outbox in the GtkTreeView, by using a
1260 TnyMergeFolder in a ModestTnySimpleFolderStore.
1263 * src/modest-tny-simple-folder-store.c:
1264 * src/modest-tny-simple-folder-store.h:
1265 Added ModestTnySimpleFolderStore, used to contain folders from
1266 other folder stores, such as other accounts.
1268 * src/modest-tny-outbox-account.h:
1269 * src/modest-tny-outbox-account.c:
1270 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1271 used for the per-account local outbox folders.
1273 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1274 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1275 only use this (internally) now for the non-outbox local folders.
1277 * src/modest-init.h:
1278 * src/modest-init.c: Added modest_init_one_local_folder(), for
1279 setting up the directory structure for each local folder.
1281 * src/modest-local-folder-info.c:
1282 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1283 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1285 * src/modest-local-folder-info.h:
1286 * src/modest-tny-account-store.c: (on_account_removed),
1287 (on_account_changed), (create_per_account_local_outbox_folders),
1288 (get_server_accounts), (modest_tny_account_store_get_accounts),
1289 (modest_tny_account_store_get_tny_account_by_account),
1290 (modest_tny_folder_store_is_virtual_local_folders):
1292 * src/modest-tny-account.h:
1293 * src/modest-tny-account.c:
1294 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1295 to create an on-disk per-account local outbox folder for each
1297 (create_per_account_local_outbox_folders): Create a local outbox folder
1298 for each transport account.
1299 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1300 for all local folders.
1302 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1303 instead of using g_object_get/set() directly. It is clearer.
1305 (modest_tny_folder_store_get_message_count),
1306 (modest_tny_folder_store_get_local_size
1307 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1308 because we now use these with non-acount folder stores.
1310 (modest_tny_account_get_special_folder),
1311 (modest_tny_account_new_from_server_account),
1312 (modest_tny_account_new_from_account):
1313 (recurse_folders): Adjust to the new outbox system.
1315 * src/modest-tny-folder.h:
1316 * src/modest-tny-folder.c:
1317 (modest_tny_folder_is_local_folder),
1318 (modest_tny_folder_get_local_folder_type),
1319 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1321 * src/widgets/modest-main-window.h:
1322 * src/maemo/modest-main-window.c: (create_details_widget),
1323 (modest_main_window_set_contents_style): Show details for any folder store,
1326 (modest_tny_folder_get_rules):
1327 Remove the const. C does not support constness enough for this.
1329 * src/modest-ui-actions.c:
1330 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1331 make all outboxes appear as one, in the usual local-folders tree node.
1333 (set_active_account_from_tny_account),
1334 (modest_ui_actions_on_folder_selection_changed):
1335 * src/widgets/modest-folder-view.c: (text_cell_data),
1336 (icon_cell_data), (filter_row),
1337 (add_account_folders_to_merged_folder),
1338 (add_account_folders_to_simple_folder_store), (),
1339 (get_cmp_rows_type_pos), (cmp_rows),
1340 (modest_folder_view_set_account_id_of_visible_server_account):
1341 Adjust to the new outbox system, using generic folder stores and folders
1342 in the GtkTreeModel.
1344 2007-05-23 Christian Kellner <ckellner@openismus.com>
1346 * src/modest-mail-operation.c:
1347 (modest_mail_operation_update_account):
1348 Use info->max_size instead of unintialized local var [small
1349 build fix]. (Added TODO to review that change since I don't
1352 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1354 * libmodest-dbus-client/libmodest-dbus-client.c:
1355 (libmodest_dbus_client_compose_mail): function added
1356 * src/dbus_api/modest-dbus-api.h:
1357 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1358 (on_compose_mail): Implementation of the SendAsMail functionality
1360 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1362 * src/modest-account-mgr.c:
1363 (modest_account_mgr_add_server_account): Set the secure-connection
1364 conf key for transport accounts as well as store accounts. I don't know
1365 why the if was there. For instance, this makes sure that we use SSL
1366 for the gmail preset from the easysetup wizard.
1368 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1370 * src/gnome/modest-main-window.c:
1371 (on_account_store_connecting_finished), (connect_signals):
1372 * src/maemo/modest-main-window.c:
1373 (on_account_store_connecting_finished), (connect_signals),
1374 (modest_main_window_new):
1375 Handle TnyAccountStore::connecting-finished instead of
1376 TnyDevice::connection-changed, because we cannot actually perform
1377 operations on accounts until TnyAccountStore has itself responded to
1378 the TnyDevice::connection-changed signal. This prevents a GError from
1380 Do not try to update at startup, because we (at least on scratchbox)
1381 already do an update at startup when the device goes online.
1382 This prevents a GError from tinymail.
1383 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1384 Added TODO about stopping simultaneous operations.
1386 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1388 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1389 * src/modest-mail-operation-queue.c:
1390 (modest_mail_operation_queue_remove):
1391 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1392 about where they happened.
1394 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1396 * src/modest-ui-actions.c:
1397 (modest_ui_actions_on_password_requested): Make sure that the remember
1398 output parameter is always TRUE.
1400 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1402 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1403 Show a OK/Cancel dialog if the error is a question, though we still do not
1404 know anything more about what we are asking the user.
1405 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1406 Fix an uninitialized variable (helper). This is a logic error, however.
1408 2007-05-21 Christian Kellner <ckellner@openismus.com>
1410 * src/modest-search.h:
1411 Correct bit shifting in the ModestSearchFlags enum.
1413 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1415 * src/modest-tny-account.c:
1416 (modest_tny_account_new_from_server_account): Do not use the lsub and
1417 check-all hard-coded IMAP options when using POP.
1419 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1421 * src/modest-tny-account.c:
1422 (modest_tny_account_new_from_server_account):
1423 Use NULL for the secure-auth method for POP when Password auth has been
1424 specified by the user, as we already do for IMAP. "auth=Login" causes
1425 an error from camel or the server.
1427 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1429 * src/maemo/modest-account-settings-dialog.c:
1430 (create_page_account_details),
1431 (modest_account_settings_dialog_set_account_name):
1432 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1433 for the leave-on-server checkbox, rathr than just the checkbox, when
1434 the protocol is not POP.
1436 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1438 * src/widgets/modest-account-view.c:
1439 * src/widgets/modest-account-view.h:
1440 Added modest_account_view_select_account() which will be useful later
1441 to asynchronously re-select the edited account.
1443 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1445 * src/maemo/modest-account-settings-dialog.c:
1446 (modest_account_settings_dialog_set_account_name):
1447 Automatically choose the port numbers based on the secure authentication
1448 methods, if they have not been chosen before.
1449 This fixes projects.maemo.org bug NB#56273 .
1451 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1453 * src/maemo/modest-main-window-ui.h:
1454 * src/modest-ui-actions.c:
1455 * src/modest-ui-actions.h:
1456 Connect the Tools/SMTP Servers menu item to
1457 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1458 SMTP servers dialog, as in the UI specification and saves changes when it
1459 is closed. This fixed projects.maemo.org bug NB#56305 .
1461 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1463 * src/maemo/modest-connection-specific-smtp-window.c:
1464 (modest_connection_specific_smtp_window_init):
1465 Use gtk_window_set_default_size() to make this window big enough, so
1466 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1468 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1470 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1471 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1472 (modest_connection_specific_smtp_edit_window_init),
1473 Do not try to connect to a combobox signal before the combobox exists.
1474 This fixes the cras in projects.maemo.org bug NB#56288 .
1475 (modest_connection_specific_smtp_edit_window_get_settings):
1476 Remove the server_account_name parameter which was being checked for NULL
1477 though it was not used.
1479 * src/maemo/modest-connection-specific-smtp-window.c:
1480 (modest_connection_specific_smtp_window_fill_with_connections),
1481 (on_button_edit), (modest_connection_specific_smtp_window_init):
1482 Correct the number of treemodel columns to prevent a warning.
1483 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1484 libconic does not work.
1486 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1488 * src/modest-tny-account.c:
1489 (modest_tny_account_new_from_server_account):
1490 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1491 SMTP when "None" was chosen by the user. However, with my SMTP server that
1492 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1495 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1497 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1498 to explain the memory management issue with the ID in the ModestPair.
1500 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1501 (add_sending_page), (modest_account_assistant_finalize):
1502 * src/gnome/modest-gnome-global-settings-dialog.c:
1503 (create_updating_page), (create_composing_page):
1504 * src/gnome/modest-msg-edit-window.c: (get_transports),
1505 (init_window), (modest_msg_edit_window_finalize),
1506 (modest_msg_edit_window_get_msg_data):
1507 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1508 * src/gnome/modest-transport-widget.c:
1509 (modest_transport_widget_finalize), (smtp_configuration):
1510 * src/maemo/modest-maemo-global-settings-dialog.c:
1511 (create_updating_page), (create_composing_page):
1512 * src/maemo/modest-msg-edit-window.c: (get_transports),
1513 (init_window), (modest_msg_edit_window_finalize),
1514 (modest_msg_edit_window_get_msg_data),
1515 (modest_msg_edit_window_free_msg_data):
1516 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1517 (modest_store_widget_finalize):
1518 * src/maemo/modest-transport-widget.c:
1519 (modest_transport_widget_finalize), (smtp_configuration):
1520 * src/modest-main.c: (send_mail):
1521 * src/widgets/modest-combo-box.h:
1522 * src/widgets/modest-global-settings-dialog-priv.h:
1523 * src/widgets/modest-global-settings-dialog.c:
1524 (modest_global_settings_dialog_finalize):
1525 * src/widgets/modest-msg-edit-window.h:
1526 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1527 as long as the combo box, to prevent use of freed memory for the ID.
1529 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1531 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1532 get_accounts(), to make this clearer. Do not check for the enabled gconf
1533 key, because we do not use this for server accounts (at least, not yet).
1534 This allows us to send email again.
1536 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1538 * src/maemo/modest-platform.c:
1539 (on_modest_conf_update_interval_changed), (modest_platform_init):
1540 Only respond to this particular key change. All these strcmp()s cannot be
1543 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1545 * src/maemo/modest-maemo-global-settings-dialog.c:
1546 (current_connection): Prevent a crash in scratchbox when
1547 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1548 * src/maemo/modest-platform.c:
1549 (on_modest_conf_update_interval_changed), (modest_platform_init):
1550 Get the update interval from gconf and reset it when the gconf key changes.
1552 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1554 * src/modest-protocol-info.c:
1555 * src/modest-protocol-info.h: Adde enum-specific get functions,
1556 instead of using a ModestProtocolType enum parameter.
1558 * src/gnome/modest-account-assistant.c:
1559 * src/gnome/modest-store-widget.c:
1560 * src/gnome/modest-store-widget.h:
1561 * src/gnome/modest-transport-widget.c:
1562 * src/gnome/modest-transport-widget.h:
1563 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1564 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1565 * src/maemo/easysetup/modest-easysetup-wizard.c:
1566 * src/maemo/modest-account-settings-dialog.c:
1567 * src/maemo/modest-account-settings-dialog.h:
1568 * src/maemo/modest-store-widget.c:
1569 * src/maemo/modest-store-widget.h:
1570 * src/maemo/modest-transport-widget.c:
1571 * src/maemo/modest-transport-widget.h:
1572 * src/modest-account-mgr-helpers.c:
1573 * src/modest-account-mgr-helpers.h:
1574 * src/modest-account-mgr.c:
1575 * src/modest-account-mgr.h:
1576 * src/modest-tny-account.c:
1577 * src/modest-tny-folder.c:
1578 * src/widgets/modest-account-view.c:
1579 * src/widgets/modest-retrieve-combo-box.c:
1580 * src/widgets/modest-retrieve-combo-box.h:
1581 * src/widgets/modest-secureauth-combo-box.c:
1582 * src/widgets/modest-serversecurity-combo-box.c:
1583 * src/widgets/modest-serversecurity-combo-box.h:
1584 * tests/check_account-mgr.c:
1585 Use the specific functions, and use the re-renamed enum values for GNOME too.
1587 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1589 * src/modest-pair.h:
1590 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1591 so we can get the second based on the first.
1593 * src/maemo/modest-account-settings-dialog.h:
1594 * src/maemo/modest-account-settings-dialog.c:
1595 Added get_supported_secure_authentication_methods(), though it is mostly
1596 commented-out for now until the necessary API is committed to tinymail.
1597 (modest_account_settings_dialog_set_account_name),
1598 (save_configuration): Request the supported authentication methods from the
1599 server, so we can choose a working method.
1601 * src/modest-tny-account-store.h:
1602 * src/modest-tny-account-store.c:
1603 (modest_tny_account_store_get_session): Rename from
1604 tny_account_store_get_session().
1606 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1608 * src/modest-protocol-info.h: Split the ModestProtocol enum
1609 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1610 There was no need to have these unrelated values in one enum.
1612 * src/: many files: Adapted to changed enum. This makes the code a bit
1613 clearer, and the compiler could catch some errors.
1615 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1617 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1618 Show the detailed internal camel error message when an error happens
1619 during the configuration, so that our testers can give us more clues.
1620 For instance, in projects.maemo.org bug NB#56910 .
1622 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1624 * src/modest-tny-account.c:
1625 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1626 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1628 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1630 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1631 * src/maemo/modest-account-settings-dialog.c:
1632 (modest_account_settings_dialog_set_account_name),
1633 (save_configuration): For the incoming secure authentication checkbox,
1634 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1635 the UI specification. PLAIN does not seem to be supported for most IMAP
1636 servers anyway, and I am not sure what it would mean.
1637 However, we probably need to discover which of the secure-authentication
1638 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1639 * src/modest-account-mgr-helpers.c:
1640 (modest_account_mgr_get_server_account_data):
1642 * src/modest-tny-account.c:
1643 (modest_tny_account_new_from_server_account):
1644 Use tny_account_set_mech() to set secure-authentication methods,
1645 with some special-casing for IMAP, based on my observations of how
1648 * src/modest-account-mgr-helpers.h:
1649 * src/modest-account-mgr.c:
1650 * src/modest-defs.h: Comment that the URI is only used for local folders.
1652 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1654 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1655 parameter const, just to be neat.
1656 * src/modest-text-utils.c: (modest_text_utils_inline):
1657 End g_strconcat() with NULL, as its documentation says. This is almost
1658 certainly the cause of my crash at startup on the device. Interestingly,
1659 valgrind doesn't tell us about these errors.
1661 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1663 * scripts/build-packages: Added more precise comments about how to use
1664 this script, though I still get this error:
1665 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1666 error building tinymail
1668 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1670 * src/maemo/modest-main-window.c: (on_account_update):
1671 Very slight cleanup, hoping to make it simpler to discover what causes
1672 a crash here sometimes.
1674 * src/modest-tny-account.c:
1675 (modest_tny_account_new_from_server_account): Set the port. Added
1676 comments about the options and a TODO comment because I need to find out
1677 how to specify the secure authentication method.
1679 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1681 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1682 changed CFlags paths form modest to libmodest
1684 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1686 * src/modest-account-mgr-helpers.c:
1687 (modest_account_mgr_get_server_account_data),
1688 (modest_account_mgr_free_server_account_data):
1689 * src/modest-account-mgr-helpers.h:
1690 * src/modest-account-mgr.c:
1691 (modest_account_mgr_add_server_account):
1692 * src/modest-defs.h:
1693 * src/modest-tny-account.c:
1694 (modest_tny_account_new_from_server_account):
1695 Determine the options for tny_camel_account_add_option() here,
1696 based on the settings, rather than storing them directly in gconf.
1698 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1700 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1701 Show a more friendly error dialog now that we expect (from the tinymail
1702 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1704 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1706 * src/maemo/modest-main-window.c: (on_account_update): Check that
1707 account_name is not NULL, to prevent a crash at startup that I am
1708 seeing on the N800. I do wonder why it is NULL.
1710 * src/maemo/easysetup/modest-easysetup-wizard.c:
1711 (create_page_user_details):
1712 * src/maemo/modest-account-settings-dialog.c:
1713 (create_page_user_details), (create_page_outgoing):
1714 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1715 (modest_connection_specific_smtp_edit_window_init):
1716 * src/modest-ui-actions.c:
1717 (modest_ui_actions_on_password_requested):
1718 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1719 might do something useful with the on-screen keyboard.
1721 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1723 * src/maemo/modest-main-window.c: (on_account_update):
1724 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1725 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1727 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1729 * src/modest-tny-account-store.c: (on_account_changed):
1730 Correct the signature of this signal handler.
1732 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1734 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1735 Show a HildonNote instead of a GtkDialog for Maemo.
1737 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1739 * src/widgets/modest-account-view.h:
1740 * src/widgets/modest-account-view.c: (on_account_changed),
1741 (on_account_removed). Added a boolean flag, set/unset by
1742 modest_account_view_block_conf_updates(),
1743 modest_account_view_unblock_conf_updates() to prevent unnecessary
1744 updates, but this is not very useful because the gconf notifications are
1745 so delays (maybe only on Maemo Bora).
1746 So auto-updating is turned off, and these functions do an explicit
1747 update when necessary.
1748 However, something else is still doing too much work when adding/removing
1749 accounts, probably in another part of the application.
1751 * src/maemo/modest-account-view-window.c:
1752 (on_delete_button_clicked), (on_edit_button_clicked),
1753 (on_new_button_clicked): Use the new functions.
1755 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1757 * src/modest-account-mgr-helpers.c:
1758 (modest_account_mgr_set_first_account_as_default):
1759 Sort the list of names alphabetically-by-title, so we choose the first one
1761 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1762 alphabetically by the title.
1764 This fixes projects.maemo.org bug NB#56418 .
1766 * src/modest-account-mgr-priv.c:
1767 (_modest_account_mgr_account_from_key):
1768 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1769 avoid a valgrind error, and possible random behaviour.
1771 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1773 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1774 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1775 tinymail documentation to say that this can be expected.
1776 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1777 pretty, and should not happen, but I would prefer to know when it does.
1779 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1781 * configure.ac: When using the older hildon version, probably on Bora,
1782 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1784 * src/widgets/modest-attachment-view.c:
1785 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1788 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1790 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1791 Implemented the prototype. Can be tested with
1792 tests/dbus_api/test_open_message:
1794 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1796 * src/modest-tny-account-store.c:
1797 (modest_tny_account_store_instance_init), (get_password):
1798 * src/modest-ui-actions.c:
1799 (modest_ui_actions_on_password_requested):
1800 Do not store the password in gconf, because this function is called
1801 for non-remembered passwords. Actually use the cached (in the hash map)
1802 password instead of releasing it.
1803 The password will now not be remembered if it is asked via the protected
1804 password dialog, as per the UI spec.
1806 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1808 * src/modest-defs.h:
1809 * src/modest-account-mgr-helpers.h:
1810 * src/modest-account-mgr-helpers.c:
1811 Added modest_server_account_get_username_has_succeeded(),
1812 modest_server_account_set_username_has_succeeded().
1813 (modest_server_account_set_username),
1814 Reset the has-succeeded flag if the username changes.
1816 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1817 * src/maemo/modest-connection-specific-smtp-window.c:
1818 (modest_connection_specific_smtp_window_save_server_accounts):
1819 Use modest_server_account_set_username() instead of using
1820 modest_conf_set_string() directly, so that the has-succeeded flag is always
1823 * src/modest-ui-actions.c:
1824 (modest_ui_actions_on_password_requested): Dim the username entry if
1825 the username has ever worked, as per the UI spec.
1827 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1829 * src/modest-tny-account-store.c: (get_password):
1830 * src/modest-ui-actions.c:
1831 (modest_ui_actions_on_password_requested):
1832 Allow the username to be changed too, though there is more work to
1833 be done on exactly how this behaves.
1835 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1837 * src/modest-account-mgr-helpers.h:
1838 * src/modest-account-mgr-helpers.c:
1839 Added modest_account_mgr_get_display_name(),
1840 modest_server_account_get_username(),
1841 modest_server_account_set_username(),
1842 modest_server_account_set_password(),
1843 modest_server_account_get_hostname() functions so we do not need to
1844 use the conf API directly.
1846 * src/maemo/modest-main-window.c: (connect_signals):
1847 Actually connect ot the ModestAccountStore::request-password signal,
1848 so that we show the dialog when the password is requested by Tinymail,
1849 for isntance if it is empty.
1851 * src/modest-marshal.list:
1852 * src/modest-tny-account-store.c:
1853 (modest_tny_account_store_class_init), (get_password),
1854 (modest_tny_account_store_alert):
1855 * src/modest-tny-account-store.h:
1856 * src/modest-ui-actions.h:
1857 * src/modest-ui-actions.c:
1858 (modest_ui_actions_on_password_requested):
1859 Change the signal parameters, so it is obvious that we are providing
1860 the non human-readable server name, and receiving both the username
1861 and password, though changing of the username is not yet implemented.
1862 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1863 for the GNOME version.
1865 This should fix the projects.maemo.org bug NB#56209, though it does not
1866 work on Bora, because the gconf_client_get() for the password fails
1867 immediately after we save it with gconf_client_set().
1869 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1872 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1873 caused an undefined symbol error:
1874 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1876 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1878 * src/modest-tny-account-store.c:
1879 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1880 using a GError instead of a string message, so we can translate it in
1883 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1885 * src/maemo/modest-address-book.c:
1886 (modest_address_book_check_names):
1887 * src/maemo/modest-msg-view-window.c:
1888 (modest_msg_view_window_clipboard_owner_change):
1889 * src/modest-init.c: (modest_init_init_ui):
1890 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1891 (update_folders_cb), (modest_mail_operation_update_account):
1892 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1893 (modest_ui_actions_on_msg_attachment_clicked),
1894 (modest_ui_actions_on_msg_recpt_activated):
1895 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1896 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1897 (modest_msg_view_search_next):
1898 * src/widgets/modest-recpt-editor.c:
1899 (modest_recpt_editor_on_button_release_event),
1900 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1901 g_message(). At this point we should only be seeing interesting errors on
1902 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1904 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1906 (modest_wizard_dialog_force_title_update):
1907 * src/maemo/easysetup/modest-wizard-dialog.h:
1908 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1909 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1910 can update the title when appropriate. Otherwise the title is wrong if the
1911 pages are added after adding the notebook to the dialog.
1912 This must be a problem in HildonWizardDialog too.
1913 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1915 * src/maemo/easysetup/modest-easysetup-wizard.c:
1916 (create_subsequent_customsetup_pages),
1917 (create_subsequent_easysetup_pages):
1918 Call modest_wizard_dialog_force_title_update() so that the title is
1919 correct even with GTK+ < 2.10.
1920 This fixes projects.maemo.org bug NB#56145 .
1922 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1924 * src/maemo/modest-platform.c:
1925 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1926 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1929 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1931 * src/widgets/modest-window.h:
1932 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1933 and modest_window_save_state(), which invokes it.
1935 * src/widgets/modest-window-mgr.h:
1936 * src/widgets/modest-window-mgr.c:
1937 Added modest_window_mgr_save_state_for_all_windows(), which calls
1938 the save_state vfunc on all registered windows, if implemented.
1940 * src/gnome/modest-msg-edit-window.c:
1941 * src/gnome/modest-msg-view-window.c:
1942 * src/maemo/modest-msg-edit-window.c:
1943 * src/maemo/modest-msg-view-window.c:
1944 * src/maemo/modest-main-window.c:
1945 Specify the existing save_settings functions as implementations of
1946 ModestWindow::save_state_func().
1948 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1949 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1950 enabling hibernation, for instance.
1952 We may need to do the same thing for restoring settings.
1955 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1957 * src/widgets/modest-window-mgr.c:
1958 * src/widgets/modest-window-mgr.h:
1959 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1960 modest_window_mgr_get_hibernation_is_prevented().
1962 * src/maemo/modest-main-window.c:
1963 (on_hildon_program_is_topmost_notify): Prevent hibernation
1964 (possible when the application goes to the background in the WM),
1965 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1967 * src/maemo/easysetup/modest-easysetup-wizard.c:
1968 (modest_easysetup_wizard_dialog_init):
1969 * src/maemo/modest-account-settings-dialog.c:
1970 (modest_account_settings_dialog_init):
1971 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1972 (modest_connection_specific_smtp_edit_window_init):
1973 * src/maemo/modest-connection-specific-smtp-window.c:
1974 (modest_connection_specific_smtp_window_init):
1975 * src/maemo/modest-signature-editor-dialog.c:
1976 (modest_signature_editor_dialog_init):
1977 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1978 prevent hibernation while any of these account settings dialogs are open.
1980 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1982 * src/maemo/Makefile.am:
1983 * src/maemo/modest-osso-state-saving.c:
1984 * src/maemo/modest-osso-state-saving.h: Added
1985 modest_osso_load_state() and modest_osso_save_state() though they do
1986 nothing now. They should iterate through all the open windows and load/save
1988 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1989 save state when closing.
1991 * src/maemo/modest-main-window.c:
1992 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1993 Add a notification handler for the HildonProgram::is-topmost property,
1994 so we can allow hibernation when the application goes into the background.
1995 But we still need to detect when the accounts setup windows are open so
1996 we can stop hibernation when they are open.
1997 To do this, I also added the main window the HildonProgram. This might have
1998 other side-effects/benefits, and should maybe be done for other windows.
2000 * src/maemo/modest-osso-autosave-callbacks.h:
2001 * src/maemo/modest-osso-autosave-callbacks.c:
2002 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2003 though it does not do anything yet, and we might never need this to do
2004 anything. For instance, we already save drafts.
2006 * src/maemo/modest-platform.c: (modest_platform_init):
2007 Specify the libosso auto-save callback.
2009 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2011 * src/maemo/modest-platform.c:
2012 (modest_platform_set_update_interval):
2013 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2014 aparently stays valid between application instances, so we can use this
2015 to remove and reset it later. According to a maemo-developers email from
2018 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2020 * configure.ac: Depend on libalarm for Maemo.
2022 * src/dbus_api/modest-dbus-api.h:
2023 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2024 (on_send_receive), (modest_dbus_req_handler):
2025 Handle a SEND_RECEIVE D-Bus method.
2027 * libmodest-dbus-client/libmodest-dbus-client.c:
2028 (libmodest_dbus_client_send_and_receive):
2029 * libmodest-dbus-client/libmodest-dbus-client.h:
2030 Add C convenience functions for calling the new D-Bus method.
2032 * src/modest-platform.h:
2033 * src/gnome/modest-platform.c:
2034 * src/maemo/modest-platform.c:
2035 Added modest_platform_set_update_interval(), which uses the
2036 alarmd API on Maemo.
2037 (modest_platform_init),
2038 Call modest_platform_set_update_interval(), using a hard-coded
2039 interval for now (until the global settings dialog is implemented),
2040 though I am not sure that this makes sense yet.
2042 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2044 * src/dbus_api/modest-dbus-callbacks.c:
2045 (modest_osso_cb_hw_state_handler):
2046 * src/dbus_api/modest-dbus-callbacks.h:
2047 * src/maemo/modest-platform.c: (modest_platform_init):
2048 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2049 in case this has some effect on the ability for Maemo to ping the
2052 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2054 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2055 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2056 warning. It is probably a logic error, but I need to fix the build.
2058 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2060 * src/modest-account-mgr.h:
2061 * src/modest-account-mgr.c:
2062 (modest_account_mgr_account_names): Add a gboolean enabled_only
2063 parameter, so we can get lists of onlt the enabled accounts.
2065 (modest_account_mgr_add_account),,
2066 (modest_account_mgr_account_with_display_name_exists):
2067 * src/maemo/modest-msg-edit-window.c: (get_transports):
2068 * src/modest-account-mgr-helpers.c:
2069 (modest_account_mgr_set_first_account_as_default):
2070 * src/modest-init.c: (init_default_account_maybe):
2071 * src/modest-tny-account-store.c: (get_accounts):
2072 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2073 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2074 * tests/check_account-mgr.c: (START_TEST):
2075 Provide the extra parameter, as appropriate.
2077 * src/widgets/modest-account-view.c: (update_account_view):
2078 Do not show disabled accounts (meaning that there is no way to
2079 enable/disable accounts in the UI (the feature is not in our UI
2080 specification), so we can use this internally only to mark unfinished
2081 or temporary account data.
2083 * src/maemo/easysetup/modest-easysetup-wizard.c:
2084 (create_account): Add boolean enable parameter, so we can specify FALSE
2085 to create the temporary account.
2086 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2087 (on_before_next): When finishing, when there is a temporary account, just
2089 Also, use a timeout to delay the showing of the dialog until gconf is likely
2090 to return correct information, due to a maemo gconf bug that is fixed in
2091 osso 1.1, but not yet in Bora.
2092 However, the dialog stays on screen after it is destroyed.
2094 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2095 for invalid data when cancelling. Use a hildon note instead of a dialog
2096 to complain about invalid data. Do not show the account-saved note if the
2097 account is disabled (a temporary account that will not really be saved for use
2100 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2102 * src/modest-account-mgr-helpers.h:
2103 * src/modest-account-mgr-helpers.c:
2104 Added modest_account_mgr_unset_default_account(),
2105 Added modest_account_mgr_set_first_account_as_default().
2107 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2108 If it was the default account, unset the default account name.
2110 * src/maemo/modest-account-view-window.c:
2111 (on_delete_button_clicked): If it was the default account,
2112 set the first remaining account as the default instead.
2114 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2115 a NULL account or a NULL default account, to prevent a crash. This should
2116 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2119 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2121 * src/widgets/modest-recpt-editor.c:
2122 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2123 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2124 TODO comment for this. This fixes the build.
2126 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2127 be the best place for it. This will in future update all auto-update accounts,
2128 rather than just the current/default account, when that gconf key exists.
2129 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2130 if there are no accounts, before calling do_send_receive().
2131 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2133 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2134 * src/maemo/modest-main-window-ui.h:
2135 * src/maemo/modest-main-window.c: (on_connection_changed),
2136 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2137 directly, becaue the signal handler does more.
2139 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2141 * src/modest-account-mgr-helpers.c:
2142 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2143 for the case that the account does not exist.
2145 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2146 (equivalent to the modest account name) rather than the tinymail account name
2147 (equivalent to the modest account title - human readable) to get the account data.
2148 Check for null account data to prevent the crash, and add a TODO comment saying that
2149 this needs fixing because it is using the server account name instead of the account name.
2151 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2153 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2154 * src/maemo/modest-account-settings-dialog.c: (show_error),
2156 Use hildon_note_new_information() for informative and error messages,
2157 which seems to be expected for Maemo applications (no documentation that I know of
2158 says this). I am surprised that there is no distinction between info and error
2161 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2163 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2164 it is easy to find where this is used.
2166 * src/maemo/easysetup/modest-easysetup-wizard.c:
2167 (create_page_welcome), (create_page_account_details),
2168 (create_page_user_details), (create_page_complete_easysetup),
2169 (create_page_custom_incoming), (create_page_custom_outgoing),
2170 (create_page_complete_custom):
2171 * src/maemo/modest-account-settings-dialog.c:
2172 (create_page_account_details), (create_page_user_details),
2173 (create_page_incoming), (create_page_outgoing):
2174 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2175 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2176 (modest_connection_specific_smtp_edit_window_init):
2177 * src/maemo/modest-connection-specific-smtp-window.c:
2178 (modest_connection_specific_smtp_window_init):
2179 * src/maemo/modest-signature-editor-dialog.c:
2180 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2181 and scrolling policy as per the Email Application Layout Guide, if I have
2184 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2186 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2187 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2188 which were empty, because these vfuncs have been removed from TnyAccountStore.
2189 This fixes the build.
2191 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2193 * src/maemo/modest-main-window.c:
2194 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2195 showing/hiding it. Added TODO because it probably should not be NULL.
2196 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2197 because unnecessary g_warnings() make degugging difficult.
2199 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2201 * src/maemo/modest-msg-edit-window.c:
2202 (modest_msg_edit_window_select_color),
2203 (modest_msg_edit_window_select_background_color): 2 const corrections and
2204 moving 2 #endifs before closing brackets, to fix the build.
2206 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2208 * src/maemo/easysetup/modest-easysetup-wizard.h:
2209 * src/maemo/easysetup/modest-easysetup-wizard.c:
2210 (modest_easysetup_wizard_dialog_finalize),
2211 (on_button_edit_advanced_settings), (create_page_complete_custom),
2212 (on_response), (create_account):
2213 Implement the Advanced Settings edit button, by saving the account information,
2214 for the Advanded Settings dialog to use directly from gconf, and removing it
2215 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2216 Bug #5533 in the projects.maemo.org bugzilla.
2218 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2220 * src/maemo/modest-msg-view-window.c:
2221 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2222 when opening a message window.
2224 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2226 * src/maemo/easysetup/modest-easysetup-wizard.c:
2227 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2230 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2231 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2232 gconf settings. I probably added more checks than necessary, but that is safer.
2234 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2235 variable to fix the build, but this seems to be used when it is still NULL.
2237 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2239 * src/modest-platform.h:
2240 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2241 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2242 * src/modest-main.c: Implement this function so we can avoid using
2243 maemo-specific API from cross-platform code.
2245 * src/modest-tny-account-store.c:
2246 (get_smtp_specific_transport_account_for_open_connection):
2247 * src/modest-ui-actions.c: (check_for_connection),
2248 (modest_ui_actions_on_item_not_found):
2249 Use modest_platform_connect_and_wait() and put #idefs around other
2250 maemo-specific code, because only maemo currently has a way to
2251 identify connection names.
2253 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2255 * src/modest-tny-account-store.h:
2256 * src/modest-tny-account-store.c:
2257 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2258 the connection-specific SMTP server settings in the configuration.
2260 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2262 * src/maemo/modest-main-window.c: (on_connection_changed),
2264 * src/modest-main.c: (main), (start_ui), (send_mail):
2265 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2266 that is what is intended.
2268 * src/modest-ui-actions.c: (action_send), (action_receive),
2269 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2270 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2271 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2272 SMTP server is used when it is specified.
2274 (modest_ui_actions_on_send_receive):
2275 Check that a connection is open before proceeding.
2276 Receive and then send, instead of vice-versa, as per the specification.
2278 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2280 * src/modest-mail-operation.c:
2281 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2282 though I guess it should be something other than NULL.
2284 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2286 * src/maemo/easysetup/modest-easysetup-wizard.c:
2287 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2288 combo twice, to avoid an g_warning and to make it visible again.
2289 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2290 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2291 (already intended) dereference when detaching, because we then recreate the menu.
2292 But I am not sure why the warning was happening, and it is possible that this is a memory
2295 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2297 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2298 and uri_parse_mailto() utility functions.
2299 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2301 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2303 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2305 * src/dbus_api/modest-dbus-api.h:
2306 * src/dbus_api/modest-dbus-callbacks.c:
2307 Use an idle callback to execute the modest code in the application's own thread.
2308 Remove the helloworld example method.
2309 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2310 parsed, and the open-message method is not implemented because this is not yet implemented in
2312 * libmodest-dbus-client/libmodest-dbus-client.c:
2313 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2314 (libmodest_dbus_client_open_message):
2315 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2317 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2318 body without crashing.
2320 * tests/dbus_api/Makefile.am:
2321 * tests/dbus_api/test_mail_to.c:
2322 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2324 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2326 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2327 Added file to fix the build. Sorry.
2329 * src/dbus_api/Makefile.am:
2330 * src/dbus_api/modest-dbus-api.h:
2331 * src/dbus_api/modest-dbus-callbacks.h:
2332 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2333 (modest_dbus_req_handler):
2334 Put constants in a separate header so it can be reused by the
2335 client library, without duplication
2337 * libmodest-dbus-client/Makefile.am:
2338 * libmodest-dbus-client/libmodest-dbus-client.c:
2339 (libmodest_dbus_client_call_helloworld),
2340 (libmodfest_dbus_client_send_mail),
2341 (libmodfest_dbus_client_mailto),
2342 (libmodfest_dbus_client_open_message):
2343 * libmodest-dbus-client/libmodest-dbus-client.h:
2344 (Partly) Implement a send_mail D-Bus method.
2346 * tests/dbus_api/Makefile.am:
2347 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2348 the send_email D-Bus method.
2350 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2354 * libmodest-dbus-client/Makefile.am:
2355 * libmodest-dbus-client/libmodest-dbus-client.c:
2356 * libmodest-dbus-client/libmodest-dbus-client.h:
2357 * tests/dbus_api/Makefile.am:
2358 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2359 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2361 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2363 * src/maemo/easysetup/modest-easysetup-wizard.c:
2364 (create_page_account_details):
2365 * src/maemo/modest-account-settings-dialog.c:
2366 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2367 widgets, because this might not be the default in future versions of the Maemo GTK+.
2368 However, I can not not get capitalization to work even in a simple test case.
2370 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2372 * src/maemo/easysetup/modest-easysetup-wizard.c:
2373 (create_page_custom_incoming), (create_page_custom_outgoing):
2374 * src/maemo/modest-account-settings-dialog.c:
2375 (create_page_account_details), (create_page_incoming),
2376 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2377 instead of using gtk_check_button_with_label(), so they are aligned like the other
2378 widgets, as per the UI spec.
2380 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2382 * src/maemo/easysetup/modest-easysetup-wizard.c:
2383 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2384 * src/widgets/modest-validating-entry.c:
2385 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2386 Modest prefix instead of an EasySetup prefix.
2388 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2390 * src/widgets/modest-validating-entry.h:
2391 * src/widgets/modest-validating-entry.c: (on_insert_text),
2392 Added easysetup_validating_entry_set_max_func(), used to set a callback
2393 to call when the max number of characters is reached. GtkEntry has a max-length
2394 already but is silent about it.
2396 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2397 (create_page_account_details), (create_page_user_details),
2399 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2400 (create_page_account_details), (create_page_user_details),
2401 (create_page_outgoing):
2402 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2403 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2404 the UI spec, when the user tries to enter more than the max number of characters.
2406 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2408 * src/maemo/easysetup/modest-easysetup-wizard.c:
2409 (create_page_user_details), (create_page_custom_incoming),
2410 (create_page_custom_outgoing):
2411 * src/maemo/modest-account-settings-dialog.c:
2412 (create_page_user_details), (create_page_incoming),
2413 (create_page_outgoing):
2414 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2415 (modest_connection_specific_smtp_edit_window_init):
2416 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2417 not appropriate. Bad Maemo-specific defaults!.
2419 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2421 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2422 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2423 (modest_signature_editor_dialog_set_settings):
2424 Disable the label and textview when the checkbox is disabled, and use the
2425 specified (UI spec) default signature text.
2427 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2429 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2430 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2432 * src/modest-defs.h:
2433 * src/modest-account-mgr-helpers.h:
2434 * src/modest-account-mgr-helpers.c:
2435 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2437 * src/maemo/Makefile.am:
2438 * src/maemo/modest-signature-editor-dialog.c:
2439 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2442 * src/maemo/modest-account-settings-dialog.h:
2443 * src/maemo/modest-account-settings-dialog.c:
2444 (modest_account_settings_dialog_finalize), (on_button_signature),
2445 (save_configuration): Use the new dialog when the Edit button is pressed, and
2446 save the changes if necessary, as per the UI spec.
2448 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2450 * src/maemo/Makefile.am:
2451 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2452 based on maemo-develoers email from Dirk.
2454 * src/maemo/easysetup/modest-easysetup-wizard.c:
2455 (create_page_welcome), (create_page_account_details),
2456 (create_page_user_details), (create_page_complete_easysetup),
2457 (create_page_custom_incoming), (create_page_custom_outgoing),
2458 (create_page_complete_custom),
2459 (modest_easysetup_wizard_dialog_init):
2460 * src/maemo/modest-account-settings-dialog.c:
2461 (create_page_account_details), (create_page_user_details),
2462 (create_page_incoming), (create_page_outgoing),
2463 (modest_account_settings_dialog_init):
2464 * src/maemo/modest-connection-specific-smtp-window.c:
2465 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2467 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2469 * src/maemo/easysetup/modest-easysetup-wizard.c:
2470 (create_page_account_details), (create_page_custom_outgoing),
2471 (create_page_complete_custom):
2472 * src/maemo/modest-account-settings-dialog.c:
2473 (create_page_user_details), (create_page_incoming),
2474 (create_page_outgoing):
2475 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2476 (modest_connection_specific_smtp_edit_window_init):
2477 Use the correct (UI spec) port min/max, and use horizontal separators,
2480 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2482 * src/maemo/easysetup/modest-easysetup-wizard.c:
2483 (set_default_custom_servernames):
2484 * src/maemo/modest-account-settings-dialog.c:
2485 (create_page_incoming), (on_combo_outgoing_security_changed),
2486 (on_combo_incoming_security_changed), (create_page_outgoing),
2487 (modest_account_settings_dialog_set_account_name),
2488 (save_configuration):
2489 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2490 (on_combo_security_changed),
2491 (modest_connection_specific_smtp_edit_window_init),
2492 (modest_connection_specific_smtp_edit_window_set_connection),
2493 (modest_connection_specific_smtp_edit_window_get_settings):
2494 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2497 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2500 * src/maemo/easysetup/modest-easysetup-wizard.c:
2501 (create_page_custom_outgoing), (create_page_complete_custom):
2502 * src/maemo/modest-account-settings-dialog.c:
2503 (create_page_user_details), (create_page_outgoing):
2504 * src/maemo/modest-account-view-window.c: (button_box_new):
2505 Use changed logical IDs as per the most recent UI spec:
2506 mcen_bd_emailsetup_edit -> mcen_bd_edit
2507 mcen_bd_emailsetup_delete -> mcen_bd_delete
2508 mcen_bd_emailsetup_close -> mcen_bd_close
2510 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2514 * src/dbus_api/Makefile.am:
2515 * src/dbus_api/modest-dbus-callbacks.c:
2516 * src/dbus_api/modest-dbus-callbacks.h:
2517 * src/maemo/modest-platform.c: (modest_platform_init):
2518 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2520 * tests/Makefile.am:
2521 * tests/dbus_api/Makefile.am:
2522 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2524 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2526 * src/maemo/modest-account-settings-dialog.c:
2527 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2528 Removed unnecessary includes.
2530 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2532 * src/maemo/easysetup/modest-easysetup-wizard.c:
2533 * src/maemo/modest-account-settings-dialog.c:
2534 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2535 * src/widgets/Makefile.am:
2536 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2537 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2538 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2539 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2540 * src/widgets/modest-secureauth-combo-box.c:
2541 * src/widgets/modest-secureauth-combo-box.h:
2542 * src/widgets/modest-serversecurity-combo-box.c:
2543 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2544 made the GObject names more consistent with the rest of the Modest code.
2546 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2548 * src/maemo/easysetup/Makefile.am:
2549 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2550 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2551 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2552 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2553 * src/maemo/easysetup/modest-easysetup-wizard.c:
2554 * src/maemo/easysetup/modest-validating-entry.c:
2555 * src/maemo/easysetup/modest-validating-entry.h:
2556 * src/maemo/modest-account-settings-dialog.c:
2557 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2558 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2559 widgets/ because they are used outside of easysetup too. After checking in,
2560 svn will allow me to rename them too.
2562 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2564 * src/gnome/modest-msg-edit-window.c:
2565 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2566 linker error, to fix the build on the GNOME platform.
2567 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2568 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2569 ifdefed out to avoid a warning.
2571 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2573 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2574 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2575 some alternative for GTK+ 2.6.
2577 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2579 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2581 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2582 specified for EmailAccountsDialog in UI spec.
2584 * src/maemo/easysetup/modest-easysetup-wizard.c:
2585 * src/maemo/easysetup/modest-easysetup-wizard.h:
2586 * src/maemo/modest-account-settings-dialog.c:
2587 * src/maemo/modest-account-settings-dialog.h:
2588 Reuse a member window widget for the connection-specific SMTP server accounts,
2589 so we can tell it to create/save the accounts only if we actually save changes.
2591 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2592 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2593 (modest_connection_specific_smtp_edit_window_get_settings):
2594 Return a struct instance for temporarily remembering the entered data.
2596 * src/maemo/modest-connection-specific-smtp-window.h:
2597 * src/maemo/modest-connection-specific-smtp-window.c:
2598 (modest_connection_specific_smtp_window_finalize),
2599 (modest_connection_specific_smtp_window_fill_with_connections),
2601 (modest_connection_specific_smtp_window_save_server_accounts),
2602 (update_model_server_names): Do not actually save data until asked,
2603 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2605 (on_selection_changed),
2606 (modest_connection_specific_smtp_window_init): Disable the edit
2607 button when nothing is selected.
2609 * src/modest-account-mgr-helpers.c:
2610 * src/modest-account-mgr-helpers.h:
2611 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2614 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2616 * src/modest-account-mgr-helpers.h:
2617 * src/modest-account-mgr-helpers.c:
2618 (modest_account_mgr_get_unused_account_name),
2619 (modest_account_mgr_get_unused_account_display_name): Added these
2620 utility functions, to avoid code duplication.
2622 * src/maemo/easysetup/modest-easysetup-wizard.c:
2623 (create_page_account_details), (create_account):
2624 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2625 (on_combo_security_changed),
2626 (modest_connection_specific_smtp_edit_window_init),
2627 (modest_connection_specific_smtp_edit_window_save_settings):
2628 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2629 * src/maemo/modest-connection-specific-smtp-window.c:
2630 (modest_connection_specific_smtp_window_finalize),
2631 (modest_connection_specific_smtp_window_fill_with_connections),
2632 (on_button_edit), (modest_connection_specific_smtp_window_init):
2633 * src/maemo/modest-connection-specific-smtp-window.h:
2634 Implementing saving of connection-specific server accounts.
2636 But I need to refactor this so we can save the data for each
2637 possible connection-specific account and only actually create the server accounts
2638 when the easysetup finished, or the OK button is pressed on the account settings
2641 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2643 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2644 (on_combo_security_changed):
2645 (modest_connection_specific_smtp_edit_window_init):
2646 Auto-fill the port number as in the account settings.
2648 (modest_connection_specific_smtp_edit_window_set_connection):
2649 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2650 * src/maemo/modest-connection-specific-smtp-window.c:
2651 (fill_with_connections), (on_button_edit),
2652 (modest_connection_specific_smtp_window_init):
2653 Turn the edit window into a dialog to simplify the code, and
2654 set a WM hint as in a GtkDialog, because only a popup can be on top of
2655 another window in Maemo, and popups usually have no WM decoration.
2657 * src/modest-defs.h:
2658 * src/modest-account-mgr-helpers.c:
2659 (modest_account_mgr_set_connection_specific_smtp),
2660 (modest_account_mgr_remove_connection_specific_smtp),
2661 (modest_account_mgr_get_connection_specific_smtp):
2662 * src/modest-account-mgr-helpers.h: Some functions to write the
2663 connection-specific SMTP server information. Not yet used.
2666 * src/widgets/modest-folder-view.c: (text_cell_data):
2667 Fix a warning about an uninitialized variable.
2668 (on_configuration_key_changed): Put an #ifdef around the use
2669 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2671 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2673 * src/maemo/modest-account-settings-dialog.h:
2674 * src/maemo/modest-account-settings-dialog.c:
2675 Added connect_for_modified() utility function to mark the new modified boolean.
2677 (create_page_account_details), (create_page_user_details),
2678 (create_page_incoming), (create_page_outgoing), (on_response),
2679 (modest_account_settings_dialog_init),
2680 (modest_account_settings_dialog_set_account_name):
2681 Only warn about unsaved changes when there are actually unsaved changes.
2683 * src/modest-account-mgr-helpers.c:
2684 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2685 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2686 to get the data from there in future.
2688 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2690 * src/modest-defs.h:
2692 * src/modest-account-mgr-helpers.h:
2693 * src/modest-account-mgr-helpers.c:
2694 Store the security account setting in a single conf key instead of using
2695 the options list, so that the list is left for just the to-be-removed camel hack,
2696 and because gconf_client_set_list() is failing for some reason.
2698 * src/modest-account-mgr.c:
2699 (modest_account_mgr_add_server_account):
2700 * src/maemo/modest-account-settings-dialog.c:
2701 (modest_account_settings_dialog_set_account_name),
2702 (save_configuration): Use the renamed functions.
2705 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2707 * src/widgets/Makefile.am:
2708 * src/widgets/modest-limit-retrieve-combo-box.c:
2709 * src/widgets/modest-limit-retrieve-combo-box.h:
2710 * src/widgets/modest-retrieve-combo-box.c:
2711 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2712 the account settings dialog.
2714 * src/modest-defs.h:
2715 * src/modest-account-mgr-helpers.h:
2716 * src/modest-account-mgr-helpers.c:
2717 (modest_server_account_get_option_secure_auth),
2718 (modest_server_account_set_option_secure_auth):
2719 * src/modest-account-mgr.c:
2720 (modest_account_mgr_add_server_account):
2721 Use the existing AUTH_MECH conf key for the secure-auth setting,
2722 instead of putting it in the list options, because this was actually used already.
2724 * src/maemo/modest-account-settings-dialog.c:
2725 (create_page_account_details),
2726 (modest_account_settings_dialog_set_account_name),
2727 (save_configuration):
2728 * src/maemo/modest-account-settings-dialog.h:
2729 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2730 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2732 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2734 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2735 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2736 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2738 * src/modest-defs.h:
2739 * src/maemo/modest-account-settings-dialog.c:
2740 (create_page_incoming), (on_combo_outgoing_security_changed),
2741 (on_combo_incoming_security_changed), (create_page_outgoing),
2742 (modest_account_settings_dialog_set_account_name),
2743 (save_configuration): Load/Save the port number, and change it when the
2744 security combo changes, to suitable defaults.
2746 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2748 * src/modest-account-mgr.c:
2749 (modest_account_mgr_add_server_account): Set the security and secure-auth
2750 options, and add a comment saying that the other camel-specific options should be
2753 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2755 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2757 * src/modest-tny-account-store.c: (account_list_free),
2758 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2759 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2762 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2764 * src/modest-protocol-info.c:
2765 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2766 is required by our UI spec. Maybe something in our implementation will use this eventually.
2767 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2768 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2769 instead of the previous 0 placeholder.
2771 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2772 secure-auth settings.
2773 * src/modest-account-mgr-helpers.h:
2774 * src/modest-account-mgr-helpers.c:
2775 (modest_server_account_data_get_option_secure_auth),
2776 (modest_server_account_set_option_secure_auth),
2777 (modest_server_account_data_get_option_security),
2778 (modest_server_account_set_option_security): Added this API for getting and setting the security
2779 and secure-auth settings.
2781 * src/maemo/modest-account-settings-dialog.h:
2782 * src/maemo/modest-account-settings-dialog.c:
2783 (modest_account_settings_dialog_finalize), (check_data),
2784 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2785 about changing titles.
2786 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2787 (save_configuration): Save the security and secure-auth settings.
2789 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2790 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2792 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2794 * src/modest-defs.h:
2795 * src/modest-account-mgr.c:
2796 (modest_account_mgr_add_server_account):
2797 Added and used defines for the options key and value pair strings,
2798 that are used so far, though they do not seem to correspond to anything in our
2799 UI specs or ModestProtocol enum.
2801 * src/modest-account-mgr-helpers.h:
2802 * src/modest-account-mgr-helpers.c:
2803 (compare_option_strings_for_name),
2804 (modest_server_account_data_get_option_value),
2805 (modest_server_account_data_get_option_bool),
2806 (modest_account_mgr_get_server_account_option):
2807 Added helper functions for parsing the options GSList.
2809 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2811 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2812 display name is based on the supplied account name.
2813 * src/modest-account-mgr.c:
2814 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2815 with an inefficient, but good-enough, implementation.
2817 * src/maemo/easysetup/modest-easysetup-wizard.c:
2818 (create_page_account_details), (on_before_next), (create_account):
2819 Check for existing display names rather than (non-user-visible) account names, and just
2820 create and set a unique account name at the end.
2822 * src/maemo/modest-account-settings-dialog.c:
2823 (modest_account_settings_dialog_init),
2824 (modest_account_settings_dialog_set_account_name),
2825 (create_page_incoming): Show the display name, instead of the account name.
2826 (on_response): Do some (not all) extra checks, as in the UI spec.
2827 (save_configuration): Save the display name if it was changed.
2829 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2831 * po/en_GB.po: Added needed logical ID and translation.
2832 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2833 (init_view): Made the is-default column clicking work.
2835 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2838 * src/maemo/easysetup/Makefile.am:
2839 * src/maemo/easysetup/modest-easysetup-wizard.c:
2840 (modest_easysetup_wizard_dialog_init):
2841 * src/maemo/easysetup/provider-data-test.keyfile:
2842 * src/maemo/easysetup/provider-data.keyfile:
2843 Moved the provider data file to the new modest-providers-data package and used it from there.
2845 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2847 * src/modest-local-folder-info.c:
2848 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2849 N_() was already used on the static strings, but this just marks it for translation without
2850 using the translation.
2852 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2854 * src/maemo/modest-account-settings-dialog.c:
2855 (create_page_incoming),
2856 (modest_account_settings_dialog_set_account_name):
2857 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2858 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2859 I will do this if nobody else gets there first.
2861 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2863 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2864 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2865 save the security stuff.
2867 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2869 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2870 Set the email address and user fullname, which I now see must be
2873 * src/maemo/modest-account-settings-dialog.h:
2874 * src/maemo/modest-account-settings-dialog.c:
2876 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2877 leave-on-server and authentication.
2878 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2881 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2884 * src/maemo/modest-account-settings-dialog.c:
2885 * src/maemo/modest-account-settings-dialog.h:
2886 Most (but not all) of the widgets are now present as specified by the UI spec.
2887 No changes are yet saved, and some details are not properly shown yet.
2889 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2891 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2893 * src/maemo/Makefile.am:
2894 * src/maemo/modest-account-settings-dialog.c:
2895 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2896 an existing account. Doesn't do much yet.
2898 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2899 Open the accounts settings dialog when Edit is clicked.
2901 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2903 * src/maemo/easysetup/Makefile.am:
2904 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2906 * src/maemo/easysetup/modest-easysetup-wizard.c:
2907 (modest_easysetup_wizard_dialog_init):
2908 Try to get the source directory from the build system,
2909 instead of hard-coding "./" into the source code, when opening our local
2910 copies of the configuration files.
2911 But this still fails when opening the wizard from the Accounts window,
2912 maybe because the working directory seems to change at runtime.
2913 So the wizard will fail the second time unless you copy the files into their
2914 proper locations - see the stdout warnings for the paths.
2916 (create_page_account_details),(on_before_next):
2917 Check for existing non-server accounts instead of server accounts,
2918 so the default account name is useful again, and to prevent trying to
2921 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2922 Show the wizard when New is clicked.
2924 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2925 (init_view): Show the column headers, and show the columns that are
2926 specified in the UI specs. However, something in Maemo's GTK+ prevents
2927 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2928 change the default account. This is despite unsetting the special properties.
2930 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2932 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2933 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2934 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2935 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2936 to make that clearer.
2937 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2939 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2941 * src/maemo/modest-account-view-window.c:
2942 (modest_account_view_window_init),
2943 (modest_account_view_window_new):
2944 Use the same buttons as specified in the
2945 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2946 the existing widgets, which never had a chance of working.
2947 Put the ModestAccountView treeview in a scrolled window.
2948 Do not repeat the initialization in both _init() and _new().
2950 * src/widgets/modest-account-view.c: (update_account_view):
2951 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2952 this widget and window shows no accounts.
2954 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2956 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2958 * src/maemo/easysetup/modest-easysetup-wizard.c:
2959 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2960 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2961 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2964 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2965 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2966 accounts exist yet, as in the UI spec.
2968 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2970 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2972 * src/maemo/Makefile.am:
2973 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2974 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2975 New window for editing connection-specific smtp details.
2976 Not fully implemented.
2978 * src/maemo/modest-connection-specific-smtp-window.c:
2979 (modest_connection_specific_smtp_window_finalize) :
2980 unref the tree model.
2981 (on_button_edit): Show the edit window.
2983 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2985 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2988 * src/maemo/Makefile.am:
2989 * src/maemo/modest-connection-specific-smtp-window.c:
2990 * src/maemo/modest-connection-specific-smtp-window.h:
2991 New window for showing the list of connections, for connection-specific
2992 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2993 * src/maemo/easysetup/modest-easysetup-wizard.c:
2994 (create_page_custom_outgoing): Show the new window when the button is clicked.
2996 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2998 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2999 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3000 * src/maemo/modest-msg-edit-window.c:
3001 (modest_msg_edit_window_insert_image):
3002 * src/modest-conf.c: (modest_conf_key_escape):
3003 * src/modest-mail-operation.c:
3004 (modest_mail_operation_send_new_mail):
3005 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3006 (modest_ui_actions_on_new_account):
3007 * src/widgets/modest-attachment-view.c: (update_filename_request):
3008 * src/widgets/modest-mail-header-view.c:
3009 Corrected warnings that were breaking the build, by commenting out unused variables,
3010 and a function, and by including a header.
3012 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3014 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3015 so we can #ifdef around platform-specific code when necessary.
3016 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3017 to allow this to build for the GNOME platform too.
3019 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3021 * src/maemo/easysetup/modest-easysetup-wizard.c:
3022 Added util_increment_name() and used it in create_page_account_details()
3023 to make sure that the default account name is always a new name.
3025 (modest_easysetup_wizard_dialog_init),
3026 (set_default_custom_servernames): Some minor memory management fixes.
3028 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3032 * src/modest-runtime.c: (init_i18n): Restored the translation
3033 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3034 are defined in config.h, and the translations are installed.
3036 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3037 is defined for translation.
3039 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3041 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3043 * src/maemo/easysetup/modest-easysetup-wizard.c:
3044 (modest_easysetup_wizard_dialog_init):
3045 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3046 Use realistic paths (though they should use $prefix generically) to the
3047 mcc_mapping and provider-data.keyfile files which might work when they
3048 are installed by the future version of the operator-wizard package,
3049 and then fallback to paths in our source code, with an explanatory
3052 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3056 * src/maemo/Makefile.am:
3057 * src/maemo/easysetup/: Added files from the previously-exernal
3058 osso-modest-easysetup.
3059 * src/maemo/modest-main-window-ui.h:
3060 * src/modest-ui-actions.c:
3061 * src/modest-ui-actions.h:
3062 Added modest_ui_actions_on_new_account() as a signal handler for the
3063 New Account menu item. It shows the easysetup wizard.
3064 * po/en_GB.po: Added additional needed logical IDs and translations.
3066 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
3067 Apparently ChangeLog is not used for some vague Nokia legal reasons.