1 2007-07-30 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-ui-actions.c: (run_account_setup_wizard),
4 (modest_ui_actions_on_accounts): Revert a change that set these
5 to modal dialogs, freezing the UI when they show secondary dialogs.
6 This fixed projects.maemo.org bug NB#64519.
8 2007-07-27 Murray Cumming <murrayc@murrayc.com>
10 * src/widgets/modest-header-view-render.c:
11 (_modest_header_view_compact_header_cell_data):
12 Some checks and initialization to try to deal with a crash,
15 2007-07-27 Murray Cumming <murrayc@murrayc.com>
17 * src/maemo/modest-maemo-utils.c:
18 (modest_maemo_utils_get_supported_secure_authentication_methods):
19 Make sure that we have a connection, asking the user for one
21 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
22 Check for a connection before showing the wizard, because
23 the wizard needs a connection to check for server capabilities.
25 2007-07-27 Murray Cumming <murrayc@murrayc.com>
27 * src/maemo/modest-account-view-window.c:
28 (on_new_button_clicked): Remember the wizard dialog instance,
29 so we can just present it again if necessary. This prevents
30 multiple windows from appearing if you click again quickly on the
31 New button before the dialog appears, fixing projects.maemo.org
34 2007-07-27 Murray Cumming <murrayc@murrayc.com>
36 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
37 Offer a connection dialog if there is no connection when
38 starting modest. This should fix projects.maemo.org bug NB#61134.
40 2007-07-27 Murray Cumming <murrayc@murrayc.com>
42 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
43 Reverted my last commit. I was able to fix the build by doing
44 apt-get install wpeditor0 (replacing other wpeditor packages) and
45 an explicit apt-get install wpeditor-dev to upgrade the -dev
48 2007-07-27 Murray Cumming <murrayc@murrayc.com>
50 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
51 Commented out the use of wp_text_buffer_replace_image()
52 because it does not exist, to break the build. Added a TODO for it.
54 2007-07-26 Murray Cumming <murrayc@murrayc.com>
56 * src/modest-tny-account-store.c: (recreate_all_accounts):
57 Recreate them even if they were NULL before. I guess something
58 else was already creating them before, or this would never
60 (modest_tny_account_store_get_server_account): Make sure that
61 the tny accounts have been created before trying to find one.
62 This allows libmodest_dbus_client_compose_mail() to work
63 when the UI is not yet visible.
64 This is probably useful in other cases too.
66 (get_password): When the password is wrong after it is entered
67 in the protected password dialog, show an info banner (in an
68 idle handler) before showing the protected password dialog
71 2007-07-26 Murray Cumming <murrayc@murrayc.com>
73 * src/modest-ui-actions.h:
74 * src/modest-ui-actions.c: Added
75 modest_do_refresh_current_folder() containing some code from
76 modest_ui_actions_on_send_receive().
77 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
78 Call modest_do_refresh_current_folder() before refreshing the
79 requested account, as in modest_ui_actions_on_send_receive().
80 This is strange, but seems to be necessary to show new mails.
81 Now new emails are finally visible in the UI when downloaded
82 via the automatic update interval, fixing bug NB#57458.
83 This also works because bug NB#57458 has been fixed somehow.
85 2007-07-26 Murray Cumming <murrayc@murrayc.com>
87 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
88 printf more details when we get unhandled D-Bus methods, because
91 * src/modest-mail-operation.c: (update_account_thread):
92 Comment out the tny_camel_pop_store_account_reconnect(), because this
93 is apparently no longer needed, and it did not work before anyway.
94 See the comment in the code.
96 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
97 by checking the header flags. This fixes projects.maemo.org bug
100 2007-07-25 Murray Cumming <murrayc@murrayc.com>
102 * src/maemo/modest-maemo-utils.h:
103 * src/maemo/modest-maemo-utils.c: Added
104 modest_maemo_show_information_note_in_main_context_and_forget().
105 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
106 Use the new function to show simple error dialogs in the main
107 context, though question dialogs are still in the current context,
108 which is unfortunately usually not the main context. This should
111 2007-07-25 Murray Cumming <murrayc@murrayc.com>
113 * src/modest-tny-account-store.c: (get_password):
114 Never save the entered username and password in gconf,
115 because the UI spec says we should not. This helps
116 slightly with projects.maemo.org bug NB#63671.
118 2007-07-25 Murray Cumming <murrayc@murrayc.com>
120 * src/widgets/modest-msg-edit-window.h:
121 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
122 Moved some code here to make it simpler.
123 (modest_msg_edit_window_attach_file_one): Renamed from
124 modest_msg_edit_window_attach_file_interactive().
125 (modest_msg_edit_window_offer_attach_file): Renamed from
126 modest_msg_edit_window_attach_file() and used
127 modest_msg_edit_window_attach_file_one() instead of
128 copy/pasting the code. The old code for one was not using
129 GnomeVFS. This allows use of smb:// URLs when using send-as
130 from external applications, fixing bug NB#63741.
132 (modest_msg_edit_window_insert_image),
133 (modest_msg_edit_window_add_attachment_clicked):
134 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
135 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
136 Adapted to the new function names.
138 2007-07-25 Murray Cumming <murrayc@murrayc.com>
140 (modest_platform_set_update_interval): Set the alarm recurrence
141 fields so that auto-update does not just happen the first time.
142 This should have fixed projects.maemo.org bug NB#63938.
144 When this happens you can see a printf when the D-Bus method is
146 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
148 However, I do not actually seem to get new POP messages even when
149 clicking the refresh button manually. A restart gets them.
150 This might be a problem in today's tinymail only.
152 2007-07-24 Murray Cumming <murrayc@murrayc.com>
154 * src/maemo/modest-maemo-global-settings-dialog.c:
155 (current_connection):
156 Avoid a crash (probably only in scratchbox) when strcmp()ing a
157 NULL when closing the dialog.
159 2007-07-24 Murray Cumming <murrayc@murrayc.com>
161 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
162 Remove the hacky send/receive that didn't work, and instead
163 refilter the treemodel to make the deleted email really vanish from
164 the UI (though the delete-from-menu code does has commented out
165 the code that does that). This fixes projects.maemo.org bug
168 2007-07-24 Murray Cumming <murrayc@murrayc.com>
170 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
171 Try a couple of tricks to force the treeview to update (
172 poke the folder, and do a send/receive refresh), but the deleted
173 email still appears with a strike-through instead of really being
176 2007-07-23 Murray Cumming <murrayc@murrayc.com>
178 * src/dbus_api/modest-dbus-callbacks.c:
179 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
180 because their ID is not human-readable (see the comment about
181 improvements needed to the osso-email-interface API) and
182 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
184 2007-07-23 Murray Cumming <murrayc@murrayc.com>
186 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
187 (add_folders_to_list), (on_dbus_method_get_folders),
188 (modest_dbus_req_filter):
189 * src/maemo/modest-maemo-utils.c:
190 (on_camel_account_get_supported_secure_authentication):
191 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
192 (on_header_view_focus_in):
193 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
194 * src/modest-formatter.c: (modest_formatter_create_body_part):
195 * src/modest-mail-operation.c: (recurse_folders),
196 (update_account_thread), (get_msgs_full_thread),
197 (modest_mail_operation_get_msgs_full),
198 (modest_mail_operation_xfer_msgs):
199 * src/modest-search.c: (search_mime_part_and_child_parts),
200 (modest_search_account), (modest_search_all_accounts):
201 * src/modest-tny-account.c:
202 (modest_tny_account_get_special_folder), (recurse_folders):
203 * src/modest-tny-local-folders-account.c:
204 (modest_tny_local_folders_account_query_passes):
205 * src/modest-tny-msg.c: (copy_mime_part),
206 (modest_tny_msg_find_body_part_from_mime_part):
207 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
208 (modest_tny_send_queue_try_to_send):
209 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
210 (_modest_ui_actions_open), (download_uncached_messages),
211 (reply_forward), (modest_ui_actions_on_copy),
212 (modest_ui_actions_on_details), (has_retrieved_msgs),
213 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
215 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
216 (_selected_msg_marked_as), (_msg_download_completed),
217 (_selected_msg_sent_in_progress):
218 * src/widgets/modest-attachments-view.c:
219 (modest_attachments_view_set_message):
220 * src/widgets/modest-msg-view.c: (find_cid_image):
221 * tests/check_folder-transfer.c: (find_folders):
222 * tests/check_update-account.c: (func):
223 * tests/dbus_api/test_get_folders.c: (main):
224 Checked all uses of tny_iterator_get_current(), making sure
225 that the object is unreferenced (3 or 4 places did not),
226 and adding checks for NULL.
228 2007-07-23 Murray Cumming <murrayc@murrayc.com>
230 * src/dbus_api/modest-dbus-callbacks.c:
231 (on_idle_open_default_inbox): Make sure that the application UI is
233 * src/maemo/easysetup/modest-easysetup-wizard.c:
234 (on_entry_invalid_character): Show the word whitespace instead
235 of (null) in the banner when whitespace was entered.
236 (show_error): Add a comment that this does not work in
237 Maemo Bora, though we do not know why.
239 2007-07-23 Murray Cumming <murrayc@murrayc.com>
241 * src/modest-tny-account.c:
242 (modest_tny_account_get_special_folder): Use an if instead of
243 an assert for when the parent account name is NULL, because this
244 might be causing a crash in projects.maemo.org bug 63192.
245 * src/modest-mail-operation.c:
246 (modest_mail_operation_send_new_mail_cb),
247 (modest_mail_operation_remove_folder): unref the folder that is
248 returned from modest_tny_account_get_special_folder().
250 2007-07-23 Murray Cumming <murrayc@murrayc.com>
252 * src/modest-ui-actions.c:
253 (modest_ui_actions_on_password_requested):
254 Show mail_ib_login_cancelled info banner when the user cancels
255 the protected password dialog, to fix projects.maemo.org
258 2007-07-23 Murray Cumming <murrayc@murrayc.com>
260 * src/maemo/modest-account-settings-dialog.c:
261 (create_page_outgoing): Put this page in a GtkScrolledWindow,
262 matching the UI mock-up in the UI spec, and allowing access
263 to all widgets even when the on-screen keyboard is active.
265 2007-07-23 Murray Cumming <murrayc@murrayc.com>
267 Reverted this previous commit from Johannes,
268 because the scrollbars are always visible and because
269 I think we only need it on onepage of the account
270 settings, not the account wizard.
271 (I wrote the wrong instructions in the bug.)
273 * src/maemo/easysetup/modest-easysetup-wizard.c:
274 Added scrollbars to account wizard dialog.
275 Fixed projects.maemo.org NB #62744
277 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
279 * src/maemo/easysetup/modest-easysetup-wizard.c:
280 (create_page_user_details):
281 Use auto-cap for name (projects.maemo.org NB#63716)
282 * src/widgets/modest-account-view.c: (on_account_busy_changed):
284 2007-07-22 Armin Burgmeier <armin@openismus.com>
286 * src/maemo/modest-ui-actions.c: Use current account instead of
287 default account for creating viewer windows, so that the viewer
288 window knows to which account the viewed message belongs.
290 * src/maemo/modest-msg-view-window.c: Destroy the window when the
291 corresponding account is deleted. This fixes projects.maemo.org bug
294 2007-07-18 Armin Burgmeier <armin@openismus.com>
296 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
297 the dialog close after entering an invalid port number and clicking
298 OK. This fixes projects.maemo.org bug NB#63602.
300 2007-07-18 Armin Burgmeier <armin@openismus.com>
302 * src/modest-tny-account-store.c:
303 (get_server_accounts): Set parent modest account name for each
304 connection-specific transport account so that special folders of such
305 an account can be looked up. This fixes a crash when changing account
306 settings. This might also be related to projects.maemo.org bug
309 2007-07-16 Armin Burgmeier <armin@openismus.com>
311 * src/modest-ui-actions.c: Added a button to create a folder to the
312 move-to dialog. This fixes projects.maemo.org bug NB#.
314 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
316 * src/maemo/easysetup/modest-easysetup-wizard.c:
317 Added scrollbars to account wizard dialog.
318 Fixed projects.maemo.org NB #62744
320 2007-07-16 Murray Cumming <murrayc@murrayc.com>
322 * src/widgets/modest-msg-view.h:
323 * src/widgets/modest-msg-view.c:
324 Added modest_msg_view_get_message_is_empty() but this needs
326 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
327 Check if there is any text in the message yet.
328 But this needs to be implemented properly.
329 (modest_msg_edit_window_toggle_find_toolbar):
330 * src/maemo/modest-msg-view-window.c:
331 (modest_msg_view_window_toggle_find_toolbar):
332 Show a banner warning if there is no text to search, when
333 trying to start a search. This partially fixes
334 projects.maemo.org bug NB#62350.
336 2007-07-13 Murray Cumming <murrayc@murrayc.com>
338 * src/modest-mail-operation.c: (update_account_thread):
339 Initialized num_new_headers to fix the build.
341 2007-07-13 Murray Cumming <murrayc@murrayc.com>
343 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
344 Ignore modest accounts whose server accounts don't exist in gconf.
345 This prevents us trying to create TnyAccount instances for those
346 server accounts when the server account has been removed from gconf,
347 but the parent modest account has not yet been removed from modest.
348 I don't know why this is only noticeable now. It was probably just
349 a harmeless g_warning() anyway.
351 2007-07-13 Murray Cumming <murrayc@murrayc.com>
353 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
354 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
356 2007-07-12 Armin Burgmeier <armin@openismus.com>
358 * src/maemo/modest-main-window.c: Make default account appear bold
359 in view, tools/send & receive and toolbar/send & receive SCM menus.
360 This fixes projects.maemo.org bug NB#59010.
362 2007-07-12 Murray Cumming <murrayc@murrayc.com>
364 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
365 Add a short-cut, by checking if the folder store is an account.
366 This ensures that the Sort menu item and toolbar is dimmed for
367 the local-folders account root item, fixing
368 projects.maemo.org bug NB#62545.
370 2007-07-12 Murray Cumming <murrayc@murrayc.com>
372 * src/modest-tny-account-store.c: (get_password):
373 Show the password dialog (via the signal) only in the mainloop, via
374 an idle handler that we wait for. This could theoretically prevent
375 hangs, though I worry that it could introduce some too.
377 2007-07-12 Murray Cumming <murrayc@murrayc.com>
379 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
380 * src/maemo/modest-platform.c:
381 (modest_platform_connect_and_wait):
382 Take a TnyAccount* parameter and try to set it to online
383 (a TnyCamel-only API), because tinymail sets accounts to offline
384 when the user cancels a password dialog, and doesn't ask again until
385 it has been set to online.
386 However, this is commented out because it causes a hang now.
388 (modest_platform_connect_and_wait_if_network_account):
389 * src/modest-mail-operation.c:
390 (modest_mail_operation_update_account):
391 * src/modest-platform.h:
392 * src/modest-ui-actions.c: (_modest_ui_actions_open),
393 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
395 2007-07-12 Armin Burgmeier <armin@openismus.com>
397 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
399 * src/modest-mail-operation.c:
400 * src/modest-ui-actions.c: Check for already existing folder before
401 querying the server, show error message from camel if the request
402 still fails. This fixes projects.maemo.org bug NB#58701.
404 2007-07-12 Murray Cumming <murrayc@murrayc.com>
406 * src/modest-tny-account-store.h:
407 * src/modest-tny-account-store.c:
408 Added modest_tny_account_store_forget_password_in_memory(),
409 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
410 when creating a new account, so that new passwords will be used, instead of
411 us thinking that it's a second request as a result of a failed password again.
413 2007-07-12 Murray Cumming <murrayc@murrayc.com>
415 * src/dbus_api/modest-dbus-callbacks.c:
416 (on_idle_open_message): If the message is in drafts then open it
417 in an edit window instead of a view window. This fixes
418 projects.maemo.org bug NB#63005.
420 2007-07-12 Murray Cumming <murrayc@murrayc.com>
422 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
423 Avoided a harmless g_warning().
425 2007-07-12 Murray Cumming <murrayc@murrayc.com>
427 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
428 Pass the modest account name, not the TnyAccount display name to
429 modest_msg_view_window_new() so that the reply feature works,
430 fixing projects.maemo.org bug NB#62892.
432 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
433 (modest_msg_view_window_new_with_header_model):
434 * src/maemo/modest-msg-view-window.c:
435 (modest_msg_view_window_new_with_header_model),
436 (modest_msg_view_window_new):
437 * src/modest-ui-actions.c: (reply_forward):
438 * src/widgets/modest-msg-view-window.h:
439 * src/widgets/modest-window.c: (modest_window_set_active_account):
440 Rename an account parameter to modest_account_name to make this clearer.
442 2007-07-11 Murray Cumming <murrayc@murrayc.com>
444 * src/modest-ui-actions.h:
445 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
446 modest_do_message_delete().
447 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
448 Call modest_do_message_delete(), hoping that this would cause messages
449 to be really deleted from search instead of just marked with strike through.
450 Does not seem to help.
452 2007-07-11 Armin Burgmeier <armin@openismus.com>
454 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
455 priv->reselect to FALSE prior to calling
456 modest_folder_view_select_first_inbox_or_local() to prevent endless
457 recursion and thus a crash on startup.
459 2007-07-11 Armin Burgmeier <armin@openismus.com>
461 * src/maemo/modest-account-settings-dialog.h: Include
462 <gtk/gtknotebook.h> to fix the build (at least for me).
464 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
465 Use "New FolderN" as default suggested name if "New folder" already
466 exists, with N being the first free number, though never exceed "New
467 folder99" in which case we just fall back to "New Folder" even though
468 it already exists. This fixes projects.maemo.org bug NB#58663.
470 2007-07-11 Murray Cumming <murrayc@murrayc.com>
472 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
473 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
474 projects.maemo.org bug NB#62778.
476 2007-07-11 Murray Cumming <murrayc@murrayc.com>
478 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
479 Ignore the wrong (for now) secure-smtp setting in the presets -
480 just default to requiring secure authentication for SMTP, because
483 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
485 * src/widgets/modest-folder-view.c: (filter_row)
486 Do not show drafts folder (see UI specs)
488 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
490 * src/modest-ui-actions.c:
491 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
492 place and also not necessary.
494 * src/widgets/modest-folder-view.c: (filter_row)
495 Guess folder type and hide Sent & Outbox if necessary.
496 Fixed project.maemo.org NB#57328
498 2007-07-11 Murray Cumming <murrayc@murrayc.com>
500 * src/modest-ui-actions.h:
501 * src/modest-ui-actions.c:
502 (modest_ui_actions_on_delete_message):
503 Move some code into a new
504 modest_ui_actions_refresh_message_window_after_delete()
505 function so we can use it from elsewhere.
507 * src/dbus_api/modest-dbus-callbacks.c:
508 (on_idle_delete_message), (on_delete_message): Used an idle
509 handler, as we do for the other D-Bus method handlers.
510 Call modest_ui_actions_refresh_message_window_after_delete()
511 if the deleted message was open in a window. This fixed
512 projects.maemo.org bug NB#62862.
514 2007-07-11 Murray Cumming <murrayc@murrayc.com>
516 * src/modest-main.c: (main): Only show the UI at the start if
517 the showui command line option was given. For instance,
518 run-standalone src/modest showui
519 Otherwise, we wait for the top_application D-Bus method to
520 be sent by hildon-desktop when the application is selected
522 This allows us to run without a UI when osso-global-search
523 uses our D-Bus methods.
525 2007-07-11 Murray Cumming <murrayc@murrayc.com>
527 * src/dbus_api/modest-dbus-api.h: Added a define for a
528 top-application D-Bus method.
529 * src/dbus_api/modest-dbus-callbacks.c:
530 (on_top_application),
531 (modest_dbus_req_handler): Handle the top-application D-Bus
532 method, which might be an undocumented D-Bus signal sent by
533 hildon-desktop when it starts the application from the menu.
534 But I am not sure and I need to test it on the device, because
535 my scratchbox does not have the application in the menu now.
536 This method shows the main window, so that it can be invisible
537 when started, for instance, just for email searching from
540 * src/maemo/modest-main-window.c: (restore_settings),
541 (modest_main_window_new): Do not show the window immediately
542 upon creation. We show it later.
543 * src/modest-widget-memory.c: (save_settings_paned):
544 Try (unsuccessfully) to avoid saving the paned position when
545 it is not even visible.
546 (restore_settings_paned): Do not allow a silly paned position.
547 This seems necessary when not showing the window at first.
549 * tests/dbus_api/Makefile.am:
550 * tests/dbus_api/test_top_application.c: (main): Test for the
553 2007-07-10 Murray Cumming <murrayc@murrayc.com>
555 * src/modest-ui-dimming-rules.c:
556 (modest_ui_dimming_rules_on_new_msg),
557 (modest_ui_dimming_rules_on_reply_msg),
558 (modest_ui_dimming_rules_on_delete_msg),
559 (modest_ui_dimming_rules_on_details),
560 (modest_ui_dimming_rules_on_view_window_move_to),
561 (modest_ui_dimming_rules_on_view_previous),
562 (modest_ui_dimming_rules_on_view_next),
563 (_invalid_folder_for_purge): Added checks before
564 casting the window. This looks like an actual
565 logic error in _invalid_folder_for_purge(), because it
566 tries to use a ModestMainWindow as a message window.
568 2007-07-10 Murray Cumming <murrayc@murrayc.com>
570 * src/maemo/modest-account-settings-dialog.c:
571 (show_error): Use the same implementation as in
572 modest-easysetup-wizard.c:
573 (on_entry_invalid_character): The logical ID contains a %s.
574 Guessed what it should be.
575 (on_entry_max), (check_data), (on_response): Adapt to
576 changed show_error().
577 (create_page_account_details): Really call
578 modest_validating_entry_set_func() on the correct widgets.
579 * src/maemo/easysetup/modest-easysetup-wizard.c:
580 (on_entry_invalid_character): Fix the logical ID here too.
581 (create_page_account_details),
582 (create_page_user_details):
584 modest_validating_entry_set_func() on the correct widgets.
586 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
587 Do not try to use the account if it is NULL.
589 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
591 * src/modest-ui-actions.c: (create_move_to_dialog),
592 (modest_ui_actions_on_main_window_move_to),
593 (modest_ui_actions_on_msg_view_window_move_to):
594 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
595 (filter_row), (modest_folder_view_show_non_move_folders):
596 * src/widgets/modest-folder-view.h:
598 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
599 the Sent folder yet as it does not report the correct folder type.
601 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
603 * src/maemo/modest-msg-edit-window.c: (init_window):
606 2007-07-10 Murray Cumming <murrayc@murrayc.com>
608 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
609 Take a parent widget instead of a parent window, and
610 implement this with hildon_banner_show_information() instead.
611 Non-Maemo builds can just ifdef that there.
612 This fixed projects.maemo.org bug NB#62766.
614 (on_entry_invalid_character): Use show_error() again instead
615 of using hildon directly, and use the _CS() macro to use the correct
617 (create_account), (check_for_supported_auth_methods), (on_entry_max):
618 Pass a widget instead od a window to show_error().
620 2007-07-10 Murray Cumming <murrayc@murrayc.com>
622 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
623 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
624 This allows us to show the server name in the error message, fixing
625 projects.maemo.org bug NB#62904.
626 Also, use the appropriate logical ID message for the account protocol.
628 2007-07-10 Murray Cumming <murrayc@murrayc.com>
630 * src/modest-tny-account-store.c: (on_idle_wrong_password):
631 A compilation fix, though the build wasn't broken for me.
633 2007-07-09 Murray Cumming <murrayc@murrayc.com>
635 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
636 Do not try to unref a NULL folder store, to avoid a runtime warning.
637 This seems to happen sometimes when changing accounts settings.
639 2007-07-09 Murray Cumming <murrayc@murrayc.com>
641 * src/modest-tny-account-store.c:
642 (modest_tny_account_store_instance_init),
643 (modest_tny_account_store_finalize),
644 (on_account_settings_hide), (on_idle_wrong_password):
645 Use a GHashTable to ensure that we only show one account settings
646 dialog per modest account. This avoids us having a dialog open for
647 both the store and transport accounts, or due to repeated get_password()
648 calls that shouldn't happen anyway.
650 2007-07-09 Murray Cumming <murrayc@murrayc.com>
652 * src/maemo/modest-maemo-utils.c: (on_hide),
653 (modest_maemo_show_dialog_and_forget): Handle the response, because
654 the window is not even hidden by default.
656 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
657 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
658 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
659 which seems to prevent some modality problems.
661 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
662 Ignore user cancellation errors.
664 * src/modest-account-mgr-helpers.h:
665 * src/modest-account-mgr-helpers.c:
666 Added modest_server_account_get_password() and
667 modest_server_account_get_has_password() to avoid direct use of
670 * src/maemo/modest-account-settings-dialog.h:
671 * src/maemo/modest-account-settings-dialog.c:
672 (modest_account_settings_dialog_init): Store the notebook so we can
674 Added modest_account_settings_dialog_switch_to_user_info().
676 * src/modest-tny-account-store.c:
677 (get_password): When the password in the account settings is wrong (we think),
678 show the relevant page of the account settings dialog, in the mainloop.
679 However, we currently get many of these at once because cancel does not
681 (forget_password): Do not forget the password
682 from the account settings, because this causes side-effects when
683 tinymail seems to call it at strange time, maybe because of how we
684 are cancelling get_password().
685 (modest_tny_account_store_alert): Ignore user cancellations.
687 2007-07-09 Murray Cumming <murrayc@murrayc.com>
689 * src/maemo/modest-maemo-utils.h:
690 * src/maemo/modest-maemo-utils.c:
691 Added modest_maemo_show_information_note_and_forget() for use instead of
692 gtk_dialog_run() when the response is not needed, to avoid an extra
693 mainloop which could cause a hang.
695 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
696 Use the logical IDs for the error message, though they are not
697 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
698 because gtk_dialog_run() caused a hang here (the window did not close).
699 This fixes projects.maemo.org bug NB#62646.
701 2007-07-09 Murray Cumming <murrayc@murrayc.com>
703 * src/modest-account-mgr-helpers.h:
704 * src/modest-account-mgr-helpers.c:
705 Added modest_account_mgr_get_store_protocol().
707 * src/maemo/modest-account-view-window.c:
708 (on_delete_button_clicked): Show different warning text depending on
709 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
710 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
713 2007-07-09 Murray Cumming <murrayc@murrayc.com>
715 * src/maemo/modest-msg-edit-window.c:
716 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
717 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
719 2007-07-07 Armin Burgmeier <armin@openismus.com>
721 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
722 ckdg_ib_maximum_characters_reached from correct package.
724 * src/modest-ui-actions.c: Show an error message when a folder could
725 not be created. Tinymail does not give us specific error codes about
726 what has gone wrong, so we assume that a folder with that name
727 already exists, though there might be other reasons.
729 2007-07-06 Murray Cumming <murrayc@murrayc.com>
731 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
732 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
733 give a more exact error message that can be partly translated.
735 2007-07-05 Murray Cumming <murrayc@murrayc.com>
737 * src/maemo/modest-address-book.c:
738 (select_email_addrs_for_contact): Specify a default window size for the
739 select-email-address dialog, so that it is probably big enough for the
740 title. This should fix projects.maemo.org bug NB#62277.
742 2007-07-05 Murray Cumming <murrayc@murrayc.com>
744 * src/maemo/easysetup/modest-easysetup-wizard.c:
745 (create_page_complete_easysetup): Use
746 gtk_widget_set_size() request to ensure that the text wraps
749 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
751 * src/maemo/easysetup/modest-easysetup-wizard.c:
752 (on_entry_invalid_character), (create_page_account_details),
753 (create_page_user_details):
754 Use new API of ModestValidatingEntry. But for some reason the banner is
755 not shown. I will have to investigate that further.
757 * src/widgets/modest-validating-entry.c: (on_insert_text),
758 (modest_validating_entry_set_func):
759 * src/widgets/modest-validating-entry.h:
760 Added a new callback function to be able to react to prevented
761 characters whitespaces to e.g show a banner.
763 2007-07-05 Armin Burgmeier <armin@openismus.com>
765 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
766 notification of HildonNumberEditor instead of remembering the port
767 number. Thanks to Johannes for pointing this out.
769 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
771 * src/maemo/easysetup/modest-easysetup-wizard.c:
772 Check if there are any user changes before showing a confirmation
773 dialog (projects.maemo.org NB#60946)
775 2007-07-05 Armin Burgmeier <armin@openismus.com>
777 * src/maemo/modest-account-settings-dialog.c: Remember custom port
778 number at the beginning of the dialog and set the modified flag at the
779 end if the port number has changed. This is necessary because
780 HildonNumberEditor does not support notification when the value has
783 2007-07-05 Murray Cumming <murrayc@murrayc.com>
785 * src/modest-ui-actions.c:
786 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
787 a connection before asking anything else. Correct the check for the destination
788 folder so that it succeeds when online.
789 This fixed projects.maemo.org bug NB#61645.
791 2007-07-05 Murray Cumming <murrayc@murrayc.com>
793 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
794 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
795 to fix projects.maemo.org bug NB#62439.
797 2007-07-05 Murray Cumming <murrayc@murrayc.com>
799 * src/modest-tny-account.c: (on_connection_status_changed):
800 Really do not use tny_device_force_offline() here. See the previous comment.
802 2007-07-04 Murray Cumming <murrayc@murrayc.com>
804 * src/modest-tny-account.c: (on_connection_status_changed):
805 Do not use tny_device_force_offline() when tinymail says that something
806 went wrong with the connection. It seems to report this unnecessarily.
808 2007-07-04 Murray Cumming <murrayc@murrayc.com>
810 * src/maemo/modest-connection-specific-smtp-window.c:
811 (modest_connection_specific_smtp_window_init):
812 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
813 does not seem to have any effect in osso 1.1 (though it works in
814 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
816 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
818 * src/maemo/modest-connection-specific-smtp-window.c:
819 Fix UI specification problems with projects.meamo.org NB#60479
821 2007-07-04 Murray Cumming <murrayc@murrayc.com>
823 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
824 clue when this has failed, because the error dialog is not always shown
825 (at least in earlier version).
827 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
828 GError message, because the generic error dialog is not helpful.
830 'This message is not currently available (can't let a new connection go online)'
831 when trying to open an IMAP message.
833 (_modest_ui_actions_open): Offer a connection when some messages would
834 have to be downloaded and we are offline.
836 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
838 * src/widgets/modest-folder-view.c:
839 Don't check for MERGE type anymore as we use the correct type
841 NOTE: For the last two changes you need to update your tinymail copy
842 because of API changes!
844 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
846 * src/modest-tny-local-folders-account.c:
847 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
848 (see projects.maemo.org NB#61580)
850 2007-07-04 Murray Cumming <murrayc@murrayc.com>
852 * src/modest-tny-account.c: (on_connection_status_changed):
853 Commented out the call to modest_platform_connect_and_wait() because this
854 seems to always hang, and I would like to know if this is the only thing
855 that causes a hang when showing the connection dialog.
856 It is not very useful anyway.
858 2007-07-04 Murray Cumming <murrayc@murrayc.com>
860 * src/maemo/modest-msg-view-window.c:
861 (modest_msg_view_window_select_next_message):
863 * src/modest-platform.h:
864 * src/maemo/modest-platform.c:
865 Added modest_platform_connect_and_wait(), which calls
866 tny_maemo_conic_device_connect() always in the main thread, by calling it
867 in an idle handler and waiting for the idle handler to run. It should be
868 in the main thread because it uses GTK+ UI code. It just returns TRUE
869 if the device is already online.
871 There is some nasty code to ensure that subsequent calls to
872 modest_platform_connect_and_wait() just wait for the first one to finish,
873 by checking repeatedly in another idle handler. This is necessary,
874 because other threads (or even the main thread, via another idle handler)
875 can call modest_platform_connect_and_wait() while
876 modest_platform_connect_and_wait() is running.
878 (modest_platform_connect_and_wait_if_network_account),
879 (modest_platform_connect_and_wait_if_network_folderstore):
880 Convenience functions that calls modest_platform_connect_and_wait() if
881 the account or folder might want network access.
883 * src/modest-mail-operation.c:
884 (modest_mail_operation_update_account):
885 * src/modest-ui-actions.c: (download_uncached_messages),
886 (modest_ui_actions_on_rename_folder), (delete_folder),
887 (modest_ui_actions_on_main_window_move_to),
888 (modest_ui_actions_on_msg_view_window_move_to):
889 * src/widgets/modest-folder-view.c:
890 (drag_and_drop_from_folder_view):
891 Offer a connection if we are offline.
893 * src/modest-tny-account.c: (on_connection_status_changed):
894 Document this as only handling errors during network operations in progress,
895 and replace the idle code with a simple call to
896 modest_platform_connect_and_wait(), which does this instead.
898 2007-07-03 Murray Cumming <murrayc@murrayc.com>
900 * src/modest-tny-account.c:
901 (modest_tny_account_get_special_folder): (util_on_idle),
902 Handle the GError so we can see when tny_folder_store_get_folders()
903 fails, as it currently does while something else is connecting.
905 Added util_run_in_main_thread_and_wait()
906 which uses an idlen handler and mainloop to ensure that the function
907 is called in the main thread.
908 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
909 to make sure that we call attempt the connection in the mainloop only,
910 which might solve some hangs.
912 2007-07-03 Murray Cumming <murrayc@murrayc.com>
914 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
915 be found by their display name. This is never useful.
916 * src/modest-tny-account-store.c: (on_account_removed): Find the account
917 by its ID, instead of trying to use its ID as its display name.
919 * src/modest-tny-account-store.h:
920 * src/modest-tny-account.c:
921 (modest_tny_account_get_special_folder): Add a g_warning() when
922 tny_folder_store_get_folders() returns an empty list for the maildir.
924 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
925 Add a g_warning() when this returns NULL, because that it not allowed
928 2007-07-02 Armin Burgmeier <armin@openismus.com>
930 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
931 note when trying to cancel the wizard. This fixes projects.maemo.org
934 2007-07-02 Murray Cumming <murrayc@murrayc.com>
936 * src/modest-tny-account.h:
937 * src/modest-tny-account.c:
938 (modest_tny_account_new_from_server_account),
939 (modest_tny_account_new_from_server_account_name),
940 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
941 because this must now be set before setting the proto. This is usd in
942 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
943 warning in camel_session_get_service() caused by
944 tny_camel_transport_account_prepare().
946 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
949 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
951 * src/maemo/modest-connection-specific-smtp-edit-window.c:
953 (modest_connection_specific_smtp_edit_window_init):
955 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
958 2007-06-29 Murray Cumming <murrayc@murrayc.com>
960 * src/modest-tny-account.c:
961 (modest_tny_account_new_from_server_account):
962 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
963 now uses to request a connection when it needs one, and which it uses
964 to tell us that something is wrong with the connection, so we can force
965 the accounts offline to prevent further problems.
968 * src/modest-init.c: (init_default_settings):
969 * src/modest-mail-operation.c:
970 (modest_mail_operation_update_account):
971 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
972 This should not be necessary anymore. Do not set the conf key that
973 determined this (it was always TRUE and not set anywhere else).
975 * src/modest-ui-actions.h: Remove unused and unimplemented
976 modest_ui_actions_on_online_toggle_toggled().
978 2007-06-29 Murray Cumming <murrayc@murrayc.com
980 * src/maemo/modest-main-window.c: (connect_signals):
981 Don't connect to delete_event twice. Maybe this was harmless.
983 2007-06-29 Murray Cumming <murrayc@murrayc.com
985 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
986 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
987 Debug output to give some more clue when a folder move is not allowed.
989 2007-06-28 Murray Cumming <murrayc@murrayc.com
991 * src/modest-tny-account.c: (on_modest_file_system_info),
992 (modest_tny_account_get_mmc_account_name):
993 Always call the callback, without checking whether the name has changed.
994 * src/widgets/modest-folder-view.c: (strings_are_equal),
995 (on_model_foreach_set_name), (on_get_mmc_account_name),
996 (text_cell_data): Compare the name here, and use the name from
997 the account rather than from the
998 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
999 if the name was changed after the account was added to the model.
1000 That's a tinymail bug but not one that I want to fix now.
1002 This finally fixes projects.maemo.org bug NB#59301.
1004 2007-06-27 Armin Burgmeier <armin@openismus.com>
1006 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
1009 2007-06-27 Murray Cumming <murrayc@murrayc.com
1011 * src/modest-tny-account.h:
1012 * src/modest-tny-account.c:
1013 Added modest_tny_account_get_mmc_account_name(), to set the memory
1014 card name asynchronously for the given account and then notify.
1015 (modest_tny_account_new_for_local_folders): Use this new function instead
1016 of using hildon_file_system_info_async_new() directly.
1018 * src/widgets/modest-folder-view.c: (text_cell_data):
1019 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
1020 gtk_tree_model_row_changed() when it is available.
1022 This should fix projects.maemo.org bug NB#59301.
1024 2007-06-27 Murray Cumming <murrayc@murrayc.com
1026 * src/modest-mail-operation.c: (update_account_thread),
1027 (get_msgs_full_thread): Fix typo failures in the revert
1030 2007-06-27 Murray Cumming <murrayc@murrayc.com
1032 * src/maemo/modest-maemo-global-settings-dialog.c:
1033 (idle_select_default_focus):
1034 * src/modest-mail-operation.c: (idle_notify_progress),
1035 (idle_notify_progress_once), (set_last_updated_idle),
1036 (update_account_thread), (get_msgs_full_thread):
1037 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1038 * src/widgets/modest-header-view.c:
1039 (idle_notify_headers_count_changed_destroy),
1040 (idle_notify_headers_count_changed):
1041 Reverted the additions of gdk_threads_enter/leave(), in case this
1042 helps with a startup hang on the device.
1044 2007-06-26 Armin Burgmeier <armin@openismus.com>
1046 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
1047 for supported secure authentication methods from server by
1048 gtk_dialog_run(), saving CPU time and a potential race condition.
1050 2007-06-26 Armin Burgmeier <armin@openismus.com>
1052 * src/maemo/modest-maemo-utils.h:
1053 * src/maemo/modest-maemo-utils.c: Added a
1054 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
1055 only error code to tell the calling code when the user canceled the
1058 * src/maemo/modest-account-settings-dialog.h:
1059 * src/maemo/modest-account-settings-dialog.c:
1060 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
1061 message if the retrieval of secure authentication methods was canceled
1062 by the user. Perform the check before saving anything to configuration
1063 to not end up with half-committed configuration changes, do not show
1064 a "Saving to configuration failed" note when authentication methods
1065 could not be retrieved.
1067 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
1070 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1072 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1073 Only return the first level of folders under accounts, because the
1074 osso-global-search UI spec doesn't want the rest.
1075 This fixed projects.maemo.org bug NB#61811.
1077 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1079 * src/modest-tny-account-store.c:
1080 * src/modest-tny-account-store.h:
1081 Added modest_tny_account_is_memory_card_account().
1082 * src/maemo/modest-main-window.c: (create_details_widget):
1083 Show the same information items for the memory card as we show for the
1084 local-folders, to fix projects.maemo.org bug NB#59307.
1086 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1088 * src/modest-tny-account-store.c: (get_password):
1089 Added some checks for NULL to maybe prevent crashes, though I think
1090 it was Philip's last commit that actually prevented the crash here
1091 when creating a first new account.
1092 But the new account is still not usable (no messages are shown)
1093 until a restart of the application.
1095 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1097 * src/maemo/modest-maemo-global-settings-dialog.c:
1098 (idle_select_default_focus):
1099 * src/modest-mail-operation.c: (idle_notify_progress),
1100 (idle_notify_progress_once), (idle_notify_update_account_queue),
1101 (set_last_updated_idle), (update_account_thread),
1102 (notify_get_msgs_full), (get_msgs_full_destroyer),
1103 (get_msgs_full_thread):
1104 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1105 * src/widgets/modest-header-view.c:
1106 (idle_notify_headers_count_changed_destroy),
1107 (idle_notify_headers_count_changed):
1108 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1109 all idle handlers, because some other thread could be blocking
1110 the GDK lock, so that it can do GUI stuff.
1112 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1114 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1115 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1116 (on_idle_send_receive), (on_idle_open_default_inbox):
1117 * src/maemo/modest-msg-edit-window.c:
1118 (modest_msg_edit_window_attach_file_noninteractive):
1119 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1120 to prevent a hang. I don't quite understand why these are necessary,
1121 beause we should already be in the main loop. I guess something outside
1122 of the main loop is taking the lock.
1124 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1125 we are really using URIs, and use files that are more likely to exist.
1127 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1129 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1130 necessary because configure.ac now defines different variables.
1132 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1134 * libmodest-dbus-client/libmodest-dbus-client.c:
1135 * libmodest-dbus-client/libmodest-dbus-client.h:
1136 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1137 libmodest_dbus_client_compose_mail() is what things actually use.
1139 * src/dbus_api/modest-dbus-api.h:
1140 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1141 * tests/dbus_api/Makefile.am:
1142 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1145 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1147 * src/modest-init.c: (modest_init_local_folders):
1148 For memory-card (or other non local-folders) maildir accounts,
1149 always create an Archive folder, so that there is somewhere to put
1150 messages. This should be less confusing, because the user does not need
1151 to guess that the need to create a folder.
1153 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1155 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1156 Fixed icon size by using (50, 50) which is the same as defined by
1159 2007-06-25 Armin Burgmeier <armin@openismus.com>
1161 * src/widgets/modest-window-mgr.c:
1162 * src/modest-init.c:
1163 * configure.ac: Correctly recognize hildon-notify presence and fixed
1164 the build without it being installed.
1166 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1168 * libmodest-dbus-client/libmodest-dbus-client.c:
1169 (libmodest_dbus_client_search): Fix the build. Sorry.
1170 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1171 (reply_forward_cb): Initialize variables to fix the build.
1173 * src/modest-tny-account-store.c:
1174 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1175 comparison (a silly typo) so that email search results can be opened
1176 when there are more than one account.
1178 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1180 * libmodest-dbus-client/libmodest-dbus-client.c:
1181 (libmodest_dbus_client_search),
1182 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1183 instead of 1 second, because the search gets folders and messages from
1184 the server, which can take a long time. When it times out,
1185 osso-global-search will report no results.
1187 We need to specify whether we should search only cached information
1188 (maybe with a user preference), and the osso-email-search-plugin
1189 API should really be improved to allow that option, and to allow results
1190 to be delivered asynchronously in batches.
1192 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1194 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1195 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1196 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1198 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1200 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1201 that is an empty string. D-Bus seems to give us these instead of NULL.
1203 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1205 * src/dbus_api/modest-dbus-callbacks.c:
1206 * src/maemo/easysetup/modest-easysetup-wizard.h:
1207 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1208 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1209 (modest_connection_specific_smtp_edit_window_init):
1210 * src/maemo/modest-maemo-global-settings-dialog.c:
1212 * src/maemo/modest-maemo-utils.c:
1213 (modest_maemo_utils_setup_images_filechooser):
1214 * src/maemo/modest-main-window.c: (create_details_widget):
1215 * src/maemo/modest-msg-edit-window.c:
1216 (modest_msg_edit_window_attach_file_noninteractive),
1217 (modest_msg_edit_window_color_button_change),
1218 (modest_msg_edit_window_set_zoom):
1219 * src/modest-mail-operation.c: (update_account_thread):
1220 * src/modest-tny-account-store.c:
1221 * src/modest-tny-account.c:
1222 * src/widgets/modest-global-settings-dialog.c:
1223 * src/widgets/modest-window.h:
1225 Fixed build on bora!
1227 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1229 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1230 * src/modest-search.c: (modest_search_folder),
1231 (modest_search_all_accounts): Actually search only in the specified folder,
1232 doing a simple match on the folder ID.
1233 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1234 and added some documentation.
1236 2007-06-22 Armin Burgmeier <armin@openismus.com>
1238 * src/maemo/modest-maemo-utils.h:
1239 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1240 modest_maemo_utils_get_supported_secure_authentication_methods.
1242 * src/maemo/easysetup/modest-easysetup-wizard.c:
1243 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1244 one occured, not just "Server does not support secure authentication".
1246 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1248 * src/modest-tny-account-store.c: (get_password):
1249 Restored the call to tny_account_set_user() because Philip seems to have
1250 stopped this from crashing (by not using the freed string). It still does
1251 not work, but now we can test it.
1253 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1255 * src/maemo/modest-msg-edit-window.c: (init_window):
1256 Comment out use of an uninitialzed GtkScrolledWindow variable,
1257 to fix the build and stop a crash. Yet again.
1259 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1261 * src/modest-tny-account-store.c: (get_password):
1262 Remove the call to tny_account_set_user() because this actually crashes.
1263 As mentioned in the last commit, it is known to not work anyway.
1265 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1267 * src/modest-tny-account-store.c: (get_password):
1268 Use tny_account_set_username() to tell tinymail that the username might
1269 have changed too. But tinymail ignores this: see projects.maemo.org
1271 * src/modest-ui-actions.c:
1272 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1273 reset the connection when changing the username, and improve the comments.
1274 Save the changed username to gconf at least, so it is used when Modest is
1277 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1279 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1280 Do not use a query, so that we get all folders, including for POP and
1281 local-folders. They work as search criteria too.
1282 This fixes projects.maemo.org bug NB#57740.
1284 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1286 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1287 Comment out the use of hildon_notification_set_sound() because it is
1288 not declared, to fix the build. Warnings are serious, people.
1290 2007-06-21 Armin Burgmeier <armin@openismus.com>
1292 * src/maemo/modest-maemo-utils.h:
1293 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1294 modest_maemo_utils_get_supported_secure_authentication_methods()
1295 to query authentication methods for a specific user. This should fix
1296 projects.maemo.org bug NB#61369.
1298 * src/maemo/easysetup/modest-easysetup-wizard.c:
1299 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1302 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1304 * libmodest-dbus-client/libmodest-dbus-client.h:
1305 * libmodest-dbus-client/libmodest-dbus-client.c:
1306 (modest_dbus_message_iter_get_search_hit),
1307 (libmodest_dbus_client_search):
1308 Reorganised and commented this.
1309 Removed modest_search_hit_free() from the public API because it
1312 Added libmodest_dbus_client_get_folders() and
1313 modest_folder_result_list_free().
1315 * src/dbus_api/modest-dbus-api.h:
1316 * src/dbus_api/modest-dbus-callbacks.c:
1317 (modest_dbus_req_filter): Commented. Moved most code to
1318 on_dbus_method_search() and added on_dbus_method_get_folders().
1320 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1321 of the extra D-Bus handler.
1323 * tests/dbus_api/Makefile.am:
1324 * tests/dbus_api/test_get_folders.c: New test for
1325 libmodest_dbus_client_get_folders(). This seems to return an empty list
1326 at the moment. That could be the same error that causes the message list
1327 to be empty sometimes.
1328 This should help with projects.maemo.org bug NB#57740.
1330 2007-06-21 Armin Burgmeier <armin@openismus.com>
1332 * src/modest-mail-operation.c: Do not call
1333 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1334 notify the operation's end after having set the status to CANCELED for
1335 the operation queue to listen on. This fixes a deadlock when there
1336 were mail operations in the queue during its finalization.
1338 * src/modest-singletons.c: Reordered uninitialization of the account
1339 manager to happen after the mail operation queue was uninitialized
1340 because the mail operation's in the queue might still try to access
1341 the account manager (see modest_mail_operation_notify_end()). This
1342 fixes a potential crash when terminating the application.
1344 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1346 * src/modest-search.c:
1347 (search_mime_part_and_child_parts): Moved some code here so we
1348 can search recursively in child folders.
1349 (modest_search_folder): Search in the message as a mime part, instead
1350 of just its child mime parts.
1351 (read_chunk), (search_mime_part_ogs):
1352 Check how many bytes were read, to prevent an endless loop.
1353 Searching in message bodies now works. This finishes the fix for
1354 projects.maemo.org bug NB#61007.
1356 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1358 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1359 Add a g_warning when the item is not a folder.
1361 * src/modest-ui-dimming-rules.c:
1362 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1363 when selected item is not a folder (for instance, an account), because
1364 the UI spec only talks about folders.
1365 I am not sure what the UI spec wants, so this might not totally fix
1366 projects.maemo.org bug NB#60794.
1368 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1370 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1371 (load_from_file): Sort the list. The unsorted list would be more noticeable
1372 in non-English locales.
1374 * src/maemo/modest-msg-edit-window.c:
1375 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1376 warning and fix the build.
1378 * src/maemo/modest-progress-bar-widget.c:
1379 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1380 avoid a g_warning, and probably to avoid a crash.
1382 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1384 * src/modest-search.c: (modest_search_folder): Check for a GError
1385 when calling tny_folder_get_headers(), to show that this is not the cause
1388 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1390 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1391 Actually set the body query instead of the subject query.
1393 * src/modest-search.c: (search_mime_part_ogs),
1394 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1395 which would probably cause it to fail if we got this far.
1397 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1398 to simplify the code.
1399 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1400 be causing search-in-body to fail.
1402 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1404 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1406 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1407 Better debug message when the folder cannot be found.
1408 This should help with fixing projects.maemo.org bug #61287.
1409 * src/modest-search.c: (add_hit): Do not leak the furl string.
1411 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1413 * src/modest-ui-actions.c:
1414 (modest_ui_actions_on_folder_selection_changed):
1415 Do not special-case TNY_MERGE_FOLDER here, because
1416 modest_tny_folder_get_account() already does that. This fixes
1417 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1418 shown when the Outbox was selected).
1420 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1422 * libmodest-dbus-client/libmodest-dbus-client.c:
1423 (_dbus_iter_get_string_or_null): Initialize the string variable in
1424 case this helps with Dirk's crash.
1426 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1428 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1429 though it is not implemented yet (this function is maybe not even used),
1430 to avoid breaking ABI in future.
1431 * libmodest-dbus-client/libmodest-dbus-client.c:
1432 (get_attachments_string): Moved some code into this generic function.
1433 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1434 sends email. It is maybe not used.
1435 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1436 (on_send_mail): Use attachments.
1438 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1439 * src/maemo/modest-msg-edit-window.c:
1440 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1441 a filename before using it, to fix projects.maemo.org bug NB#58233.
1443 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1445 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1446 Initialize the continue_download variable to fix the build, and probably
1447 to fix randome behaviour.
1449 2007-06-18 Armin Burgmeier <armin@openismus.com>
1451 * src/modest-tny-send-queue.h:
1452 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1453 the queue so we can later show it in the UI. Replaced
1454 modest_tny_send_queue_msg_is_being_sent() by
1455 modest_tny_send_queue_get_msg_status().
1457 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1459 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1460 gpointer. This probably was not harmful, but just to be sure.
1462 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1464 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1465 Fix the build, but leave the function broken on Bora, because
1466 hildon_uri_action_get_service() does not exist.
1467 osso_uri_action_get_service() does not exist either, it seems.
1469 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1471 * src/modest-tny-account.c:
1472 (modest_tny_account_new_from_server_account):
1473 Uncommented the url debug output again, because it is useful for
1474 debugging, as I said in the comment.
1476 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1478 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1480 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1481 for Mameo Bora, to fix the build.
1483 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1486 Fixed build with hildon < 0.99
1488 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1489 Check if the selected account is busy instead of checking all accounts
1491 * src/modest-account-mgr-priv.h:
1492 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1493 (modest_account_mgr_init), (compare_account_name),
1494 (modest_account_mgr_set_account_busy),
1495 (modest_account_mgr_account_is_busy):
1496 * src/modest-account-mgr.h:
1497 Added busy information to the account manager. It possible to
1498 set an account to busy or not busy now.
1500 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1501 (modest_mail_operation_update_account),
1502 (modest_mail_operation_notify_end):
1503 Set the account to busy/not busy depending on the operation state.
1505 * src/widgets/modest-account-view.c:
1506 (modest_account_view_finalize), (get_last_updated_string),
1507 (update_account_view), (on_account_busy_changed), (init_view):
1508 Show string "Refreshing..." if the account is currently busy.
1510 All this fixes projects.maemo.org bug NB#59711
1512 2007-06-14 Armin Burgmeier <armin@openismus.com>
1514 * src/widgets/modest-attachments-view.h:
1515 * src/widgets/modest-attachments-view.c: Added
1516 modest_attachments_view_has_attachments() and fixed coordinate
1517 transformation in get_att_view_at_coords(). This fixes attachment
1520 * src/widgets/modest-msg-view.c: Make use of
1521 modest_attachments_view_has_attachments() to decide whether to show
1522 attachments in the header.
1524 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1526 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1527 (on_change), (on_combo_security_changed),
1528 (modest_connection_specific_smtp_edit_window_init),
1529 (modest_connection_specific_smtp_edit_window_set_connection),
1530 (modest_connection_specific_smtp_edit_window_is_dirty):
1531 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1532 * src/maemo/modest-connection-specific-smtp-window.c:
1535 Show an comfirmation dialog for the smpt-edit-window if there are
1536 unsaved changes and the user hits cancel.
1537 (projects.maemo.org bug NB#60479)
1539 2007-06-14 Armin Burgmeier <armin@openismus.com>
1541 * src/maemo/easysetup/modest-easysetup-wizard.c:
1542 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1543 address" info in banner instead of node, and select all the text as
1544 per UI spec. This fixes projects.maemo.org bug NB#60550.
1546 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1548 reviewed by: <delete if not using a buddy>
1550 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1551 * src/modest-ui-actions.c: (folder_refreshed_cb):
1553 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1555 * src/widgets/modest-folder-view.c: (filter_row):
1556 Explictly filter out the per-account outbox accounts. I don't know why
1557 these only sometimes show up, but now they should never show up in the UI.
1558 This should fix projects.maemo.org bug NB#60160.
1560 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1562 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1563 when the toolbar does not exist yet.
1564 * src/modest-widget-memory.c: (save_settings_header_view):
1565 Added g_warnings() to help us to discover when we are trying to set
1566 an empty columns list in gconf.
1568 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1570 * src/modest-init.h:
1571 * src/modest-init.c:
1572 Added modest_init_get_default_header_view_column_ids().
1574 * src/modest-widget-memory.c: (restore_settings_header_view):
1575 Use the new function to get defaults, if the gconf key is empty,
1576 instead of not creating any columns. This seems to fix the
1577 empty right-hand pane problems.
1579 * src/widgets/modest-header-view.h: Improved documentation.
1581 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1583 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1584 Revert the use of the display name as the account name, because this
1585 is generally wrong and would break the code that follows.
1587 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1589 * src/maemo/easysetup/modest-easysetup-wizard.c:
1590 (check_for_supported_auth_methods), (on_before_next),
1593 More correct fix for projects.maemo.org bug NB# 58991
1594 Do not longer accept AUTH_PASSWORD as secure method and choose
1595 correct method when creating the account.
1597 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1599 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1600 Fixed projects.maemo.org bug NB# 58991
1602 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1604 * src/modest-init.c: (modest_init_init_core),
1605 (modest_init_local_folders): Fixed compilation errors.
1607 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1609 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1610 Remove unnecessary lib/include, though it is good in principle when needed.
1612 * src/modest-init.c: (modest_init_one_local_folder),
1613 (modest_init_local_folders):
1614 * src/modest-init.h: Initialize the .modest library for memory cards,
1615 instead of just doing nothing for them. This should allow us to create
1616 folders there, fixing projects.maemo.org bug NB#59297.
1618 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1620 * libmodest-dbus-client/libmodest-dbus-client.c:
1621 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1622 (libmodest_dbus_client_compose_mail),
1623 (libmodest_dbus_client_open_message),
1624 (libmodest_dbus_client_send_and_receive),
1625 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1627 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1628 (on_idle_open_message), (modest_dbus_req_handler),
1629 (search_result_to_message), (modest_dbus_req_filter):
1630 * src/modest-search.c: (add_hit), (modest_search_folder),
1631 (modest_search_all_accounts): Improved debug messages.
1633 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1635 * src/modest-tny-account-store.c:
1636 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1639 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1642 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1644 * src/modest-tny-account-store.c: (get_server_accounts):
1645 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1646 even when there are no accounts, so that the Outbox folder is always
1647 visible. This fixes projects.maemo.org bug NB#60158.
1649 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1651 * src/maemo/modest-main-window.c: (create_details_widget):
1652 Use the mcen_va_never logical ID.
1654 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1656 * src/dbus_api/modest-dbus-api.h:
1657 * src/dbus_api/modest-dbus-callbacks.c:
1658 (on_idle_open_default_inbox), (on_open_default_inbox),
1659 (modest_dbus_req_handler):
1660 Added a new OpenDefaultInbox method.
1662 * libmodest-dbus-client/libmodest-dbus-client.h:
1663 * libmodest-dbus-client/libmodest-dbus-client.c:
1664 Added libmodest_dbus_client_open_default_inbox() to call the new
1665 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1666 though it should maybe be used by a new osso-email-interface function.
1668 * tests/dbus_api/Makefile.am:
1669 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1672 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1674 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1675 NULL, so that the signals get all the keys. This should not actually
1676 change any behaviour because we currently update everything when anything
1679 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1681 * src/widgets/modest-folder-view.c: (text_cell_data),
1682 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1683 (find_inbox_iter): If tinymail tells us that the folder is
1684 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1685 This causes the inbox to be selected at startup, fixing part of
1686 projects.maemo.org bug NB#56305.
1688 * src/modest-ui-dimming-rules.c:
1689 (modest_ui_dimming_rules_on_tools_smtp_servers):
1690 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1691 the SMTP servers menu item.
1692 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1693 that the SMTP Servers menu item is dimmed when there are no accounts,
1694 as a future version of the UI spec will require. This fixes
1695 projects.maemo.org bug NB#56305.
1697 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1699 * src/maemo/modest-maemo-utils.c:
1700 (modest_maemo_utils_get_supported_secure_authentication_methods):
1701 Added label to dialog instead of unreadable title
1703 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1704 (modest_main_window_new):
1705 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1708 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1709 * src/modest-account-mgr.h:
1710 Added method to avoid code duplication
1712 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1713 (modest_ui_actions_on_send_receive):
1714 Use modest_account_mgr_has_accounts
1716 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1718 * src/maemo/easysetup/modest-presets.c:
1719 (modest_presets_get_info_server_security): Do not report secure auth
1721 * src/modest-protocol-info.c: Use the defines for the gconf key names
1722 for secure authentication. This was not working because we were writing
1723 Password and reading password, and the check was case sensitive.
1724 With this, gmail now works for receiving and sending when created via
1727 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1729 * src/maemo/easysetup/modest-presets.c:
1730 (modest_presets_get_info_server_security): Correct the key name for
1731 SecureSmtp, because it seems to be case-sensitive.
1732 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1733 Do not try to get the 0th notebook page if there are 0 pages, to
1734 avoid a g_warning().
1736 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1738 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1739 Prevent use of the new notification feature for now, because it currently
1740 shows one dialog for each new email, which is annoying.
1742 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1744 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1745 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1746 when no country was selected, so that we show the global ones.
1747 * src/maemo/easysetup/modest-presets.c:
1748 (modest_presets_get_providers): Return only the global providers, not
1749 all providers when mmc=0 was requested.
1751 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1753 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1754 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1755 provider ID in the combo.
1757 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1758 Do not show the page numbers, because it would be confusing when we add
1759 the 2 extra pages for the custom setup, when the user chooses the "Other"
1760 provider. This fixes projects.maemo.org bug NB#59028
1762 * src/modest-init.c: (modest_init_init_core),
1763 (modest_init_local_folders):
1764 * src/modest-init.h:
1765 * src/modest-tny-account.c:
1766 (modest_tny_account_new_for_local_folders): Do not create default folders
1767 for the memory card. This should fix projects.maemo.org bug NB#59328.
1769 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1771 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1772 Free the changed_conf_keys string items. They are already freed in the
1773 idle handler if that runs first.
1775 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1777 * src/modest-ui-actions.c:
1778 (modest_ui_actions_on_password_requested): Check that the server name
1779 is not NULL, because I just saw a password dialog with (null) as the
1782 * src/modest-tny-folder.[h|c]: Added
1783 modest_tny_folder_is_memory_card_folder().
1784 * src/modest-ui-dimming-rules.c:
1785 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1786 menu item for memory cards, as per the UI spec (section 7.4). This should
1787 fix projects.maemo.org bug NB#59297.
1789 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1791 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1792 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1793 is another problem with the code, see Murray's comment at line 772)
1795 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1797 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1798 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1799 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1800 (load_from_file), (easysetup_country_combo_box_init),
1801 (easysetup_country_combo_box_get_active_country_ids),
1802 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1803 instead of just one ID, to avoid duplicate country names in the UI.
1805 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1806 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1807 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1808 a single ID, avoiding duplicate providers.
1809 * src/maemo/easysetup/modest-easysetup-wizard.c:
1810 (on_combo_account_country): Adapt to use a list.
1812 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1814 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1815 keys changed in the last X seconds.
1817 * src/modest-account-mgr.h:
1818 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1819 (on_key_change), (modest_account_mgr_class_init),
1820 (modest_account_mgr_init), (modest_account_mgr_finalize):
1821 As the keys are changed, save them in a GSList* and signal that GSList*
1822 further every X seconds, to batch changes, to allow us to do just one
1823 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1824 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1826 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1827 changed signal signature.
1829 * src/modest-conf.c: (modest_conf_set_list),
1830 (modest_conf_on_change): Reenable notification.
1832 (modest_conf_maemo_fake_on_change): Comment out the hack that
1833 notified immediately instead of asynchronously.
1835 * src/widgets/modest-account-view.h:
1836 * src/widgets/modest-account-view.c:
1837 (update_account_view): Select the previously-selected account ID,
1838 if possible. This fixes projects.maemo.org bug NB#56933.
1840 (on_account_changed), (on_account_removed),
1841 (modest_account_view_select_account):
1843 Remove the block/unblock functions
1844 because they were not useful.
1846 * src/maemo/modest-account-view-window.c:
1847 (on_delete_button_clicked), (on_edit_button_clicked),
1848 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1850 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1852 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1853 Improve the error dialog to show Incorrect Account Settings, which seems
1854 clearer, and say that the internal error message (to be removed from the
1855 dialog later) is often misleading.
1856 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1858 * src/modest-tny-account.c:
1859 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1860 URL because this is so useful for debugging on the device.
1862 * src/widgets/modest-serversecurity-combo-box.c:
1863 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1865 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1867 * src/modest-mail-operation.c:
1868 (modest_mail_operation_send_new_mail):
1869 Added a comment about a nasty but apparently harmless message. Details
1870 added to the wiki g_warnings() page.
1872 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1874 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1875 (modest_tny_send_queue_class_init):
1876 Do not use the priv struct because it is empty, to avoid g_warnings
1877 about a non-existant priv struct.
1879 * src/modest-tny-account-store.c:
1880 (modest_tny_account_store_get_server_account),
1881 (modest_tny_account_store_get_transport_account_for_open_connection
1882 ): Do not try to get transport server accounts for local folders,
1883 because they don't have any. This avoids a g_warning().
1885 * src/maemo/modest-main-window.c:
1886 (modest_main_window_notify_send_receive_initied),
1887 (on_configuration_key_changed):
1888 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1889 * src/modest-defs.h:
1890 * src/modest-mail-operation.c:
1891 (modest_mail_operation_update_account):
1892 * src/modest-tny-account-store.h:
1893 * src/modest-tny-account.c:
1894 (modest_tny_account_get_special_folder),
1895 (modest_tny_account_new_for_local_folders),
1896 (modest_tny_account_new_for_per_account_local_outbox_folder):
1897 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1898 * src/modest-tny-local-folders-account.c:
1899 (add_account_folders_to_merged_folder):
1900 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1901 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1902 (modest_ui_actions_on_send):
1903 * src/widgets/modest-folder-view.c: (update_model):
1904 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1905 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1906 modest_tny_account_store_get_tny_account_by_account() to
1907 modest_tny_account_store_get_server_account() to make the code clearer.
1909 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1911 * src/dbus_api/modest-dbus-api.h:
1912 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1913 * src/maemo/modest-msg-edit-window.c:
1914 (modest_msg_edit_window_attach_file_noninteractive):
1915 added g_warning in case the file to be attached does not exist
1916 * tests/dbus_api/test_compose_mail.c: (main):
1917 removed obsolete comment, added generic files as test case
1919 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1921 * src/modest-tny-account-store.c: (get_server_accounts):
1922 Create the local folders account only once, not once for each outbox, and
1923 not only when there are some outboxes.
1925 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1927 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1928 code that is causing a crash at startup. Sergio says that he is fixing this.
1930 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1932 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1933 * src/maemo/modest-account-settings-dialog.c:
1934 (create_page_outgoing),
1935 (modest_account_settings_dialog_set_account_name),
1936 (save_configuration):
1937 - Fixed handling of the "Use secure authentication" toggle to comply with
1938 the ui specification. See also projects.maemo.org bug NB#58400
1940 - Restore the Secure connection setting combo correctly when loading
1943 * src/maemo/modest-maemo-utils.c:
1944 (on_camel_account_get_supported_secure_authentication),
1945 (modest_maemo_utils_get_supported_secure_authentication_methods):
1946 Fixed a crasher if operation is canceled
1948 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1949 (modest_protocol_info_auth_is_secure):
1950 * src/modest-protocol-info.h:
1952 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1953 the sense of the "Use secure authentication" toggle.
1955 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1957 * src/modest-tny-account-store.h:
1958 * src/modest-tny-account-store.c:
1959 Added modest_tny_account_store_get_local_folders_account().
1961 * src/modest-tny-folder.h:
1962 * src/modest-tny-folder.c:
1963 (modest_tny_folder_get_account):
1964 Added this replacement for tny_folder_get_account() which returns
1965 the local-folders account for TnyMergeFolders, to avoid the
1966 warning about the unimplemented get_account_func() vfunc().
1968 (modest_tny_folder_get_rules),
1969 * src/modest-ui-actions.c:
1970 (modest_ui_actions_on_folder_selection_changed):
1971 * src/modest-mail-operation.c:
1972 (modest_mail_operation_remove_folder),
1973 (modest_mail_operation_xfer_folder),
1974 (modest_mail_operation_rename_folder),
1975 (modest_mail_operation_get_msg),
1976 (modest_mail_operation_get_msgs_full),
1977 (modest_mail_operation_remove_msg),
1978 (modest_mail_operation_xfer_msgs),
1979 (modest_mail_operation_refresh_folder):
1980 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1982 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1984 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1985 (modest_server_account_set_security):
1986 * src/modest-defs.h: Add comments explaining that our
1987 UI spec means TLS when it says Normal, so these do not look like errors.
1989 * src/modest-tny-account.c:
1990 (modest_tny_account_new_from_server_account): Use the new tinymail
1991 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1992 for TLS. This should fix projects.maemo.org bug NB#58460.
1994 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1996 * src/maemo/easysetup/modest-easysetup-wizard.c:
1997 (create_account): Correct the position of the gconf sanity check warning.
1998 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1999 of using the g_idle_add() hack, because this does not seem to be necessary
2000 on osso 1.1. It might even work on Maemo Bora if the problems were actually
2001 caused by something other than maemo's gconf.
2002 This fixes projects.maemo.org bug #59022.
2004 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2006 * src/modest-account-mgr-helpers.c:
2007 (modest_account_mgr_get_default_account): Do not check that the account
2008 exists if there is no default account (NULL), to fix a runtime warning.
2010 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2012 * src/widgets/modest-folder-view.c: (update_model):
2013 Do not unref the treemodel before we have finished with it.
2014 This prevents a valgrind warning and an occasional crash at startup.
2016 2007-06-06 Marcus Bauer <marcusb@openismus.com>
2018 * libmodest-dbus-client/libmodest-dbus-client.h:
2019 added libmodest_dbus_client_compose_mail()
2020 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2022 added functions needed for SendAsMail() functionality
2023 * src/maemo/modest-msg-edit-window.c:
2024 (modest_msg_edit_window_attach_file_noninteractive):
2025 non interactively attaching files to message edit window
2026 * src/widgets/modest-msg-edit-window.h:
2027 * tests/dbus_api/Makefile.am:
2028 added test_compose_mail.c
2029 * tests/dbus_api/test_compose_mail.c: (main):
2031 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2033 * src/modest-account-view.c:
2034 Fixed bug projects.maemo.org bug NB#59307
2036 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2038 * src/maemo/easysetup/modest-easysetup-wizard.c:
2039 (get_serverport_incoming), (on_before_next), (create_account):
2040 * src/maemo/modest-account-settings-dialog.c:
2041 (modest_account_settings_dialog_set_account_name):
2042 * src/maemo/modest-maemo-utils.c:
2043 (on_camel_account_get_supported_secure_authentication_status),
2044 (on_camel_account_get_supported_secure_authentication),
2045 (on_secure_auth_cancel),
2046 (modest_maemo_utils_get_supported_secure_authentication_methods):
2048 Implemented security authentication for settings and easysetup.
2050 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2052 * src/maemo/modest-main-window.c: (create_details_widget):
2053 Show the total size for memory card accounts too, instead of showing
2054 the name again. Fixes bug projects.maemo.org bug NB#59307.
2056 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2059 * src/modest-tny-simple-folder-store.c:
2060 * src/modest-tny-simple-folder-store.h: Removed.
2062 * src/modest-tny-local-folders-account.h
2063 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
2064 for the local-folders maildir, with an extra TnyMergedFolder containing
2065 the folders of the per-account outbox store accounts.
2066 * src/modest-tny-account-store.c: (get_server_accounts):
2067 Add the outboxes to the special local folders account after creating it.
2069 * src/modest-tny-account.c:
2070 (modest_tny_account_new_for_local_folders): Create the derived
2071 account when creating the main local-folders account.
2073 * src/maemo/modest-main-window.c: (create_details_widget),
2074 (modest_main_window_set_contents_style):
2075 Adapted to the use of the derived account instead of the folder store.
2077 * src/modest-ui-actions.c:
2078 (modest_ui_actions_on_folder_selection_changed):
2079 * src/modest-ui-dimming-rules.c:
2080 (modest_ui_dimming_rules_on_new_folder):
2081 * src/widgets/modest-folder-view.c: (text_cell_data),
2082 (icon_cell_data), (filter_row), (update_model),
2083 (get_cmp_rows_type_pos):
2086 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2087 Do not get the priv struct, because no priv struct has been set,
2088 to avoid a runtime warning.
2090 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2091 #ifelse with #else, to fix a warning, to fix the build.
2094 2007-06-05 Christian Kellner <ckellner@openismus.com>
2096 * libmodest-dbus-client/libmodest-dbus-client.c:
2097 Fix small typo in doc (why do you always see them
2098 AFTER committing stuff?)
2101 2007-06-05 Christian Kellner <ckellner@openismus.com>
2103 * libmodest-dbus-client/libmodest-dbus-client.c:
2104 (libmodest_dbus_client_search):
2105 Initialize hit list with NULL. Also set folder list
2106 to "" if NULL was supplied.
2109 2007-06-03 Christian Kellner <ckellner@openismus.com>
2111 * libmodest-dbus-client/libmodest-dbus-client.c:
2112 (modest_search_hit_list_free):
2113 Make it save to call it with NULL.
2115 * src/dbus_api/modest-dbus-callbacks.c:
2116 * src/modest-search.c:
2117 Return full ModestSearchHits as the search result list not TnyHeader
2118 since can't be around withouth the correspoding TnyFolder.
2120 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2122 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2123 Added currently commented code to check for secure auth
2125 * src/maemo/modest-account-settings-dialog.c: (on_response),
2126 (save_configuration), (show_ok):
2127 Fixed projects.maemo.org bugs NB #59248 and #59251
2129 * src/maemo/modest-maemo-utils.c:
2130 (on_camel_account_get_supported_secure_authentication_status),
2131 (on_camel_account_get_supported_secure_authentication),
2132 (modest_maemo_utils_get_supported_secure_authentication_methods):
2133 * src/maemo/modest-maemo-utils.h:
2134 Moved get_supported_secure_authentication() method here to be able
2135 to use it from easysetup wizard.
2137 * src/modest-pair.c: (on_pair_compare_as_string):
2138 Should compare string with first part of pair and not
2139 strcmp pairs which will crash.
2141 * src/modest-protocol-info.c:
2142 (modest_protocol_info_protocol_is_store):
2143 * src/modest-protocol-info.h:
2144 Added modest_protocol_info_get_auth_protocol_name()
2146 2007-06-03 Armin Burgmeier <armin@openismus.com>
2148 * src/modest-mail-operation.c:
2149 (modest_mail_operation_get_msgs_full): Set priv->account also when
2150 only retrieving a single message. This avoids a crash when canceling
2153 (modest_mail_operation_notify_end): Do not explicitely remove the
2154 operation from the queue but only emit the progress_changed signal.
2155 The queue itself listens to that signal to remove the operation when
2156 it is finished. This reduces coupling and removes a potential deadlock
2157 when modest_mail_operation_notify_end() is called from the queue
2158 itself. If that is a problem performance-wise, I would suggest to
2159 implement a status-changed signal or something.
2161 * src/modest-mail-operation-queue.c: Make sure to never call a
2162 function from another file while the queue is locked. This (hopefully)
2163 fixes another deadlock when exiting the application while retrieving
2166 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2168 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2169 Fixed build if libogs is not available
2171 2007-06-03 Christian Kellner <ckellner@openismus.com>
2173 * libmodest-dbus-client/libmodest-dbus-client.h:
2174 * libmodest-dbus-client/libmodest-dbus-client.c:
2175 (libmodest_dbus_client_delete_message):
2176 Implement deletion of messages (Client side).
2178 (modest_search_hit_free),
2179 (modest_search_hit_list_free):
2180 Utility functions to free the result hits.
2182 * src/dbus_api/modest-dbus-api.h:
2183 * src/dbus_api/modest-dbus-callbacks.c:
2184 (on_delete_message),
2185 (modest_dbus_req_handler):
2186 Implement deletion of messages (Server side).
2188 * tests/dbus_api/test_search.c: (main):
2191 * tests/dbus_api/Makefile.am:
2192 * tests/dbus_api/test_delete_message:
2193 Add little test for the message deletion logic
2195 2007-06-03 Armin Burgmeier <armin@openismus.com>
2197 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2198 when the operation queue was not empty. projects.maemo.org bug
2201 2007-06-03 Armin Burgmeier <armin@openismus.com>
2203 * src/widgets/modest-account-view.c
2204 (on_account_default_toggled): Toggle default account column
2205 explicitely instead of waiting for gconf notification (which is
2206 currently ignored). This should fix projects.maemo.org bug NB#56910
2207 for now. It should probably be removed when gconf notifications are
2210 2007-06-03 Christian Kellner <ckellner@openismus.com>
2212 * libmodest-dbus-client/libmodest-dbus-client.c:
2213 Removed debugging spew.
2215 * src/dbus_api/modest-dbus-callbacks.c:
2216 Added debugging info.
2218 * src/modest-search.c:
2219 (modest_search_all_accounts):
2220 Use tny_account_store_get_accounts () on the account store
2221 to get all accounts which is the way to get all accounts.
2223 * tests/dbus_api/test_search.c: (main):
2224 Make it possible to supply the search term on the command line.
2226 2007-06-03 Christian Kellner <ckellner@openismus.com>
2228 * libmodest-dbus-client/libmodest-dbus-client.c:
2229 * libmodest-dbus-client/libmodest-dbus-client.h:
2230 Implement searching for mesages over raw dbus. (Client side)
2232 * src/dbus_api/Makefile.am:
2233 * src/dbus_api/modest-dbus-api.h:
2234 * src/dbus_api/modest-dbus-callbacks.c:
2235 * src/dbus_api/modest-dbus-callbacks.h:
2236 Search framework (Server side). Also implement on_idle_open_message().
2238 * src/maemo/modest-platform.c: (modest_platform_init):
2239 Prepare for raw dbus/osso rpc interaction.
2241 * src/modest-search.h:
2242 Changed minsize from unspecific guint to guint32.
2244 * src/modest-search.c:
2246 Added strange hack which magically made tnymail work.
2248 (modest_search_folder),
2249 (modest_search_account),
2250 (modest_search_all_accounts):
2251 Implement helper functions to search all accounts, specific account
2254 * tests/dbus_api/Makefile.am:
2255 * tests/dbus_api/test_open_message.c:
2256 Read url to open from commandline.
2258 * tests/dbus_api/test_search.c:
2259 Implement small test for dbus search stuff
2261 2007-06-02 Armin Burgmeier <armin@openismus.com>
2263 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2264 include account type and account title. This fixes projects.maemo.org
2267 * src/maemo/modest-account-view-window.c: Set a title for the window.
2269 2007-06-02 Armin Burgmeier <armin@openismus.com>
2271 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2272 incoming and outgoing server name based on email address and server
2273 types as long as the names have not been edited manually. This fixes
2274 projects.maemo.org bug NB#58671.
2276 2007-06-02 Armin Burgmeier <armin@openismus.com>
2278 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2279 server type cannot be changed in future to the incoming details page
2280 when creating an account. This fixes projects.maemo.org bug NB#59029.
2282 2007-06-02 Armin Burgmeier <armin@openismus.com>
2284 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2285 and assigned max width chars so that they wrap instead of being
2286 truncated. Fixes projects.maemo.org bug NB#56126.
2288 2007-06-02 Armin Burgmeier <armin@openismus.com>
2290 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2291 introductory note to the connection specific smtp servers dialog, as
2292 section 8.12 of the email UI specification requires. This fixes
2293 projects.maemo.org bug NB#59212.
2295 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2297 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2298 Check for running mail operations, and offer to cancel them, as per the UI
2299 spec. This fixes projects.maemo.org bug NB#59041 .
2300 However, I suspect that tinymail may still use the network connection
2301 in ways that we cannot detect or cancel. But it should at least adapt to
2302 changes fairly well.
2304 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2306 * src/modest-tny-account-store.c: (recreate_all_accounts),
2307 (get_cached_accounts), (get_server_accounts): Do more sensible
2308 ref-counting of the temporarily-cached outbox accounts list. This seems
2309 to fix a crash when entering the password when the password was wrong.
2311 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2313 * src/gnome/modest-main-window.c: (connect_signals):
2314 * src/modest-tny-account-store.c: (get_password),
2315 (modest_tny_account_store_alert): Added comments and clues and
2316 commented-out code about how we currently fail to deal with connection
2317 errors and wrong passwords, and how we should.
2319 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2321 * src/widgets/modest-retrieve-combo-box.c:
2322 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2323 This fixes projects.maemo.org bug NB#58472 .
2325 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2327 * src/maemo/easysetup/modest-easysetup-wizard.c:
2328 (create_page_complete_easysetup):
2329 (create_page_complete_custom): Correct the last commit,
2330 putting the correct sentences in the correct pages.
2332 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2334 * src/maemo/easysetup/modest-easysetup-wizard.c:
2335 (create_page_complete_custom): Show the second sentence of text
2336 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2339 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2341 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2342 Set the leave-on-server conf key by default. This fixes
2343 projects.maemo.org bug NB#59258 .
2345 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2347 * src/maemo/modest-account-view-window.c:
2348 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2349 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2352 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2354 * src/maemo/easysetup/modest-easysetup-wizard.c:
2355 (create_caption_new_with_asterisk):
2356 * src/maemo/modest-account-settings-dialog.c:
2357 (create_caption_new_with_asterisk):
2358 Uncomment the code to add the asterisk, because they are no longer in the
2359 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2360 (update_incoming_server_title): Add an asterisk here too.
2362 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2364 * src/maemo/modest-maemo-global-settings-dialog.c:
2365 (current_connection): Check that we are even connected before trying to
2366 get the current connection name, to prevent a warning.
2368 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2369 Change the comments because tny_maemo_conic_device_connect() is now meant to
2371 * src/modest-mail-operation.c:
2372 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2373 make sure we have a connection and fail if we can't connect.
2375 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2377 * src/maemo/modest-main-window.c:
2378 (on_account_store_connecting_finished): Do not try to get the
2379 connection ID if we are not really connected. I am surprised that
2380 this signal handler is called when we are not connected.
2382 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2384 * src/modest-error.h:
2385 * src/modest-ui-actions.c:
2386 (modest_ui_actions_get_msgs_full_error_handler):
2387 Renamed an enum, added comments, added an enum
2388 for retrieve-limit errors.
2390 * src/modest-mail-operation.c: (foreach_add_item),
2391 (internal_folder_observer_update), (update_account_thread),
2392 (modest_mail_operation_get_msgs_full):
2393 (modest_mail_operation_update_account),
2394 Added comments about how this works, and some code that should
2395 (but does not) check the retrieve-limit. See the TODO comment.
2397 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2399 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2400 Initialize help_id to fix the build. Warnings are good.
2402 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2404 * src/widgets/modest-hbox-cell-renderer.c:
2405 (modest_hbox_cell_renderer_append):
2406 * src/widgets/modest-vbox-cell-renderer.c:
2407 (modest_vbox_cell_renderer_append):
2408 Fix the last commit by doing an extra ref.
2410 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2412 * src/widgets/modest-hbox-cell-renderer.c:
2413 (modest_hbox_cell_renderer_append):
2414 * src/widgets/modest-vbox-cell-renderer.c:
2415 (modest_vbox_cell_renderer_append):
2416 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2417 to fix the build with Maemo Bora.
2418 However, there seems to be a remaining crash, probably due to reference
2421 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2423 * src/modest-tny-account.c:
2424 (modest_tny_account_new_for_local_folders):
2425 Use hildon_file_system_info_async_new() to get a better name for
2426 the memory card account, setting it as the account name.
2427 The timing seems to work, but this is probably
2428 not the best place to do this. See the TODO comment.
2429 * src/maemo/modest-main-window.c: (create_details_widget):
2430 * src/widgets/modest-folder-view.c: (text_cell_data):
2431 Use the tny account name instead of hardcoding a name.
2433 2007-05-30 Christian Kellner <ckellner@openismus.com>
2435 * src/modest-search.c: (modest_search):
2436 Correctly set part_search_func even if we have already parsed
2437 the query and thus a valid OgsTextSearcher object.
2439 2007-05-30 Christian Kellner <ckellner@openismus.com>
2442 Search and check for libogs.
2445 Incooparte the ogs build env.
2447 * src/modest-mime-part-search-stream.c:
2448 * src/modest-mime-part-search-stream.h:
2449 Removed since we do the real searching now in modest-search.c.
2451 * src/modest-search.c:
2452 * src/modest-search.h:
2453 Implement support for ogs. We use that if available and requested
2454 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2455 should now handle the corner case when the search term is spread
2456 across multiple reads.
2457 Also the logic in modest_search () was corrected to search all
2458 requested fields until one is found.
2460 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2462 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2464 * src/modest-init.h:
2465 * src/modest-init.c: Made modest_init_local_folders() take a
2466 path and be public so we can iniitialize maildir folders on
2469 * src/modest-local-folder-info.h:
2470 * src/modest-local-folder-info.c:
2471 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2473 * src/modest-tny-account.c:
2474 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2475 still means the standard local-folders path on the local volume.
2477 * src/modest-tny-account-store.c:
2478 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2479 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2480 all accounts when that happens.
2481 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2482 this too, so it shows up in the treeview.
2484 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2486 * src/maemo/modest-maemo-global-settings-dialog.c:
2487 (current_connection):
2488 * src/widgets/modest-global-settings-dialog.c:
2489 (current_connection_default):
2490 Use the enum values instead of 0, 1 and -1,
2491 to make the code clearer.
2493 * src/modest-account-mgr-helpers.c:
2494 (modest_account_mgr_get_connection_specific_smtp): Make this code
2497 * src/modest-runtime.h:
2498 * src/modest-runtime.c:
2499 Added modest_runtime_remove_all_send_queues().
2500 * src/maemo/modest-main-window.c:
2501 (on_account_store_connecting_finished): Recreate the send queues,
2502 using the appropriate transport accounts for this new connection.
2503 Some futher adapting might be needed if the old send queues are not
2504 automatically stopped at this point.
2506 * src/modest-tny-account-store.c: (get_server_accounts):
2507 Create the connection-specific transport accounts, so that they can
2508 be found later by their ID.
2510 * src/modest-tny-account.h:
2511 * src/modest-tny-account.c:
2512 Added modest_tny_account_new_from_server_account_name().
2513 modest_tny_account_new_from_server_account(): Do not create the
2514 send queues here, because they will be
2515 recreated anyway when the connection changes for the first time.
2517 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2519 * src/modest-local-folder-info.h:
2520 * src/modest-local-folder-info.c:
2521 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2522 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2523 tbox_folder): Take a modest account name instead of a server TnyAccount,
2524 so we can have per-modest-account rather than per-transport-account
2526 We must make sure that we change or recreate the exisitng send queues
2527 when the connection changes for connection-specific transport accounts.
2529 * src/modest-tny-account-store.c:
2530 (create_per_account_local_outbox_folders): Create outboxed per modest
2531 account, not per transport account.
2533 * src/modest-tny-account.h:
2534 * src/modest-tny-account.c:
2535 (modest_tny_account_get_special_folder): For outboxes, get the
2536 parent modest account name. The account is ignored for other folders.
2537 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2538 modest account name rather than a server TnyAccount.
2540 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2542 * src/modest-tny-account.c:
2543 (modest_tny_account_new_from_server_account):
2544 Call modest_runtime_get_send_queue() immediately after creating transport
2545 accounts, so that they start trying to send email from the outbox as soon
2546 as possible at startup. This is probably what we want.
2548 * src/modest-mail-operation.c: (update_account_thread):
2549 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2550 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2551 * src/modest-tny-send-queue.h:
2552 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2553 (modest_ui_actions_on_send):
2554 Added comments about how sending works, though it needs some more work.
2556 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2558 * src/modest-tny-account.c:
2559 (modest_tny_account_get_special_folder): Add TODO because this fails when
2560 the network is busy.
2561 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2562 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2563 Do not try to show this window when there is no active account. The UI
2564 specs does not tell us what to do in this case.
2566 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2570 * src/maemo/Makefile.am:
2571 * src/widgets/Makefile.am: Some dist fixes.
2573 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2575 * src/maemo/modest-connection-specific-smtp-window.c:
2576 (on_button_edit): Make the code clearer, to prevent a double free.
2578 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2580 * src/maemo/modest-account-settings-dialog.c:
2581 (modest_account_settings_dialog_set_account_name),
2582 Check the connection-specific smtp servers checkbox if there are any.
2584 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2585 (modest_connection_specific_smtp_edit_window_init):
2586 Start with a suitable port number.
2588 * src/modest-account-mgr-helpers.h:
2589 * src/modest-account-mgr-helpers.c: Added
2590 modest_account_mgr_get_has_connection_specific_smtp().
2592 (modest_account_mgr_set_connection_specific_smtp),
2593 (modest_account_mgr_remove_connection_specific_smtp),
2594 (modest_account_mgr_get_has_connection_specific_smtp),
2595 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2596 connection-specific smtp server accounts in the account, rather than
2597 the server account conf dir.
2599 This fixes bug projects.maemo.org bug NB#58263 .
2601 * src/modest-tny-account-store.c:
2602 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2603 if there are no server accounts yet, to prevent an infinite loop when there
2604 are no accounts. Document that one must be called before the other.
2606 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2608 * src/modest-account-mgr-helpers.c:
2609 (modest_account_mgr_get_default_account): Make sure that at least
2610 one account is always the default, if there are any enabled accounts.
2611 This is just a sanity check that shouldn't be necessary.
2613 * src/modest-account-mgr-priv.c:
2614 (_modest_account_mgr_account_from_key): Unescape the conf key to
2615 get the real account name. For instance, this is an issue if a space
2616 was in the account name, which can happen because the account name
2617 is generated from the display name.
2618 (_modest_account_mgr_get_account_keyname): Always escape the
2620 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2621 Unescape the conf keys to get the real account names.
2623 For instance, previously the is-default radio button in the accounts
2624 list was not checked for any accounts at first. This fixes that,
2625 and might fix several similar bugs.
2627 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2629 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2630 Removed some debug printfs.
2632 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2634 Modest on-disk outbox directories are now here, for instance:
2635 $HOME/.modest/outboxes/<account-id-1>/outbox
2636 $HOME/.modest/outboxes/<account-id-2>/outbox
2638 $HOME/.modest/local-folders/outbox
2639 so we can have a separate outbox for each account.
2640 But they are shown as one outbox in the GtkTreeView, by using a
2641 TnyMergeFolder in a ModestTnySimpleFolderStore.
2644 * src/modest-tny-simple-folder-store.c:
2645 * src/modest-tny-simple-folder-store.h:
2646 Added ModestTnySimpleFolderStore, used to contain folders from
2647 other folder stores, such as other accounts.
2649 * src/modest-tny-outbox-account.h:
2650 * src/modest-tny-outbox-account.c:
2651 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2652 used for the per-account local outbox folders.
2654 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2655 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2656 only use this (internally) now for the non-outbox local folders.
2658 * src/modest-init.h:
2659 * src/modest-init.c: Added modest_init_one_local_folder(), for
2660 setting up the directory structure for each local folder.
2662 * src/modest-local-folder-info.c:
2663 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2664 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2666 * src/modest-local-folder-info.h:
2667 * src/modest-tny-account-store.c: (on_account_removed),
2668 (on_account_changed), (create_per_account_local_outbox_folders),
2669 (get_server_accounts), (modest_tny_account_store_get_accounts),
2670 (modest_tny_account_store_get_tny_account_by_account),
2671 (modest_tny_folder_store_is_virtual_local_folders):
2673 * src/modest-tny-account.h:
2674 * src/modest-tny-account.c:
2675 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2676 to create an on-disk per-account local outbox folder for each
2678 (create_per_account_local_outbox_folders): Create a local outbox folder
2679 for each transport account.
2680 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2681 for all local folders.
2683 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2684 instead of using g_object_get/set() directly. It is clearer.
2686 (modest_tny_folder_store_get_message_count),
2687 (modest_tny_folder_store_get_local_size
2688 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2689 because we now use these with non-acount folder stores.
2691 (modest_tny_account_get_special_folder),
2692 (modest_tny_account_new_from_server_account),
2693 (modest_tny_account_new_from_account):
2694 (recurse_folders): Adjust to the new outbox system.
2696 * src/modest-tny-folder.h:
2697 * src/modest-tny-folder.c:
2698 (modest_tny_folder_is_local_folder),
2699 (modest_tny_folder_get_local_folder_type),
2700 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2702 * src/widgets/modest-main-window.h:
2703 * src/maemo/modest-main-window.c: (create_details_widget),
2704 (modest_main_window_set_contents_style): Show details for any folder store,
2707 (modest_tny_folder_get_rules):
2708 Remove the const. C does not support constness enough for this.
2710 * src/modest-ui-actions.c:
2711 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2712 make all outboxes appear as one, in the usual local-folders tree node.
2714 (set_active_account_from_tny_account),
2715 (modest_ui_actions_on_folder_selection_changed):
2716 * src/widgets/modest-folder-view.c: (text_cell_data),
2717 (icon_cell_data), (filter_row),
2718 (add_account_folders_to_merged_folder),
2719 (add_account_folders_to_simple_folder_store), (),
2720 (get_cmp_rows_type_pos), (cmp_rows),
2721 (modest_folder_view_set_account_id_of_visible_server_account):
2722 Adjust to the new outbox system, using generic folder stores and folders
2723 in the GtkTreeModel.
2725 2007-05-23 Christian Kellner <ckellner@openismus.com>
2727 * src/modest-mail-operation.c:
2728 (modest_mail_operation_update_account):
2729 Use info->max_size instead of unintialized local var [small
2730 build fix]. (Added TODO to review that change since I don't
2733 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2735 * libmodest-dbus-client/libmodest-dbus-client.c:
2736 (libmodest_dbus_client_compose_mail): function added
2737 * src/dbus_api/modest-dbus-api.h:
2738 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2739 (on_compose_mail): Implementation of the SendAsMail functionality
2741 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2743 * src/modest-account-mgr.c:
2744 (modest_account_mgr_add_server_account): Set the secure-connection
2745 conf key for transport accounts as well as store accounts. I don't know
2746 why the if was there. For instance, this makes sure that we use SSL
2747 for the gmail preset from the easysetup wizard.
2749 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2751 * src/gnome/modest-main-window.c:
2752 (on_account_store_connecting_finished), (connect_signals):
2753 * src/maemo/modest-main-window.c:
2754 (on_account_store_connecting_finished), (connect_signals),
2755 (modest_main_window_new):
2756 Handle TnyAccountStore::connecting-finished instead of
2757 TnyDevice::connection-changed, because we cannot actually perform
2758 operations on accounts until TnyAccountStore has itself responded to
2759 the TnyDevice::connection-changed signal. This prevents a GError from
2761 Do not try to update at startup, because we (at least on scratchbox)
2762 already do an update at startup when the device goes online.
2763 This prevents a GError from tinymail.
2764 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2765 Added TODO about stopping simultaneous operations.
2767 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2769 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2770 * src/modest-mail-operation-queue.c:
2771 (modest_mail_operation_queue_remove):
2772 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2773 about where they happened.
2775 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2777 * src/modest-ui-actions.c:
2778 (modest_ui_actions_on_password_requested): Make sure that the remember
2779 output parameter is always TRUE.
2781 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2783 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2784 Show a OK/Cancel dialog if the error is a question, though we still do not
2785 know anything more about what we are asking the user.
2786 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2787 Fix an uninitialized variable (helper). This is a logic error, however.
2789 2007-05-21 Christian Kellner <ckellner@openismus.com>
2791 * src/modest-search.h:
2792 Correct bit shifting in the ModestSearchFlags enum.
2794 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2796 * src/modest-tny-account.c:
2797 (modest_tny_account_new_from_server_account): Do not use the lsub and
2798 check-all hard-coded IMAP options when using POP.
2800 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2802 * src/modest-tny-account.c:
2803 (modest_tny_account_new_from_server_account):
2804 Use NULL for the secure-auth method for POP when Password auth has been
2805 specified by the user, as we already do for IMAP. "auth=Login" causes
2806 an error from camel or the server.
2808 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2810 * src/maemo/modest-account-settings-dialog.c:
2811 (create_page_account_details),
2812 (modest_account_settings_dialog_set_account_name):
2813 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2814 for the leave-on-server checkbox, rathr than just the checkbox, when
2815 the protocol is not POP.
2817 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2819 * src/widgets/modest-account-view.c:
2820 * src/widgets/modest-account-view.h:
2821 Added modest_account_view_select_account() which will be useful later
2822 to asynchronously re-select the edited account.
2824 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2826 * src/maemo/modest-account-settings-dialog.c:
2827 (modest_account_settings_dialog_set_account_name):
2828 Automatically choose the port numbers based on the secure authentication
2829 methods, if they have not been chosen before.
2830 This fixes projects.maemo.org bug NB#56273 .
2832 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2834 * src/maemo/modest-main-window-ui.h:
2835 * src/modest-ui-actions.c:
2836 * src/modest-ui-actions.h:
2837 Connect the Tools/SMTP Servers menu item to
2838 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2839 SMTP servers dialog, as in the UI specification and saves changes when it
2840 is closed. This fixed projects.maemo.org bug NB#56305 .
2842 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2844 * src/maemo/modest-connection-specific-smtp-window.c:
2845 (modest_connection_specific_smtp_window_init):
2846 Use gtk_window_set_default_size() to make this window big enough, so
2847 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2849 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2851 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2852 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2853 (modest_connection_specific_smtp_edit_window_init),
2854 Do not try to connect to a combobox signal before the combobox exists.
2855 This fixes the cras in projects.maemo.org bug NB#56288 .
2856 (modest_connection_specific_smtp_edit_window_get_settings):
2857 Remove the server_account_name parameter which was being checked for NULL
2858 though it was not used.
2860 * src/maemo/modest-connection-specific-smtp-window.c:
2861 (modest_connection_specific_smtp_window_fill_with_connections),
2862 (on_button_edit), (modest_connection_specific_smtp_window_init):
2863 Correct the number of treemodel columns to prevent a warning.
2864 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2865 libconic does not work.
2867 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2869 * src/modest-tny-account.c:
2870 (modest_tny_account_new_from_server_account):
2871 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2872 SMTP when "None" was chosen by the user. However, with my SMTP server that
2873 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2876 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2878 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2879 to explain the memory management issue with the ID in the ModestPair.
2881 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2882 (add_sending_page), (modest_account_assistant_finalize):
2883 * src/gnome/modest-gnome-global-settings-dialog.c:
2884 (create_updating_page), (create_composing_page):
2885 * src/gnome/modest-msg-edit-window.c: (get_transports),
2886 (init_window), (modest_msg_edit_window_finalize),
2887 (modest_msg_edit_window_get_msg_data):
2888 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2889 * src/gnome/modest-transport-widget.c:
2890 (modest_transport_widget_finalize), (smtp_configuration):
2891 * src/maemo/modest-maemo-global-settings-dialog.c:
2892 (create_updating_page), (create_composing_page):
2893 * src/maemo/modest-msg-edit-window.c: (get_transports),
2894 (init_window), (modest_msg_edit_window_finalize),
2895 (modest_msg_edit_window_get_msg_data),
2896 (modest_msg_edit_window_free_msg_data):
2897 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2898 (modest_store_widget_finalize):
2899 * src/maemo/modest-transport-widget.c:
2900 (modest_transport_widget_finalize), (smtp_configuration):
2901 * src/modest-main.c: (send_mail):
2902 * src/widgets/modest-combo-box.h:
2903 * src/widgets/modest-global-settings-dialog-priv.h:
2904 * src/widgets/modest-global-settings-dialog.c:
2905 (modest_global_settings_dialog_finalize):
2906 * src/widgets/modest-msg-edit-window.h:
2907 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2908 as long as the combo box, to prevent use of freed memory for the ID.
2910 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2912 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2913 get_accounts(), to make this clearer. Do not check for the enabled gconf
2914 key, because we do not use this for server accounts (at least, not yet).
2915 This allows us to send email again.
2917 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2919 * src/maemo/modest-platform.c:
2920 (on_modest_conf_update_interval_changed), (modest_platform_init):
2921 Only respond to this particular key change. All these strcmp()s cannot be
2924 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2926 * src/maemo/modest-maemo-global-settings-dialog.c:
2927 (current_connection): Prevent a crash in scratchbox when
2928 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2929 * src/maemo/modest-platform.c:
2930 (on_modest_conf_update_interval_changed), (modest_platform_init):
2931 Get the update interval from gconf and reset it when the gconf key changes.
2933 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2935 * src/modest-protocol-info.c:
2936 * src/modest-protocol-info.h: Adde enum-specific get functions,
2937 instead of using a ModestProtocolType enum parameter.
2939 * src/gnome/modest-account-assistant.c:
2940 * src/gnome/modest-store-widget.c:
2941 * src/gnome/modest-store-widget.h:
2942 * src/gnome/modest-transport-widget.c:
2943 * src/gnome/modest-transport-widget.h:
2944 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2945 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2946 * src/maemo/easysetup/modest-easysetup-wizard.c:
2947 * src/maemo/modest-account-settings-dialog.c:
2948 * src/maemo/modest-account-settings-dialog.h:
2949 * src/maemo/modest-store-widget.c:
2950 * src/maemo/modest-store-widget.h:
2951 * src/maemo/modest-transport-widget.c:
2952 * src/maemo/modest-transport-widget.h:
2953 * src/modest-account-mgr-helpers.c:
2954 * src/modest-account-mgr-helpers.h:
2955 * src/modest-account-mgr.c:
2956 * src/modest-account-mgr.h:
2957 * src/modest-tny-account.c:
2958 * src/modest-tny-folder.c:
2959 * src/widgets/modest-account-view.c:
2960 * src/widgets/modest-retrieve-combo-box.c:
2961 * src/widgets/modest-retrieve-combo-box.h:
2962 * src/widgets/modest-secureauth-combo-box.c:
2963 * src/widgets/modest-serversecurity-combo-box.c:
2964 * src/widgets/modest-serversecurity-combo-box.h:
2965 * tests/check_account-mgr.c:
2966 Use the specific functions, and use the re-renamed enum values for GNOME too.
2968 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2970 * src/modest-pair.h:
2971 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2972 so we can get the second based on the first.
2974 * src/maemo/modest-account-settings-dialog.h:
2975 * src/maemo/modest-account-settings-dialog.c:
2976 Added get_supported_secure_authentication_methods(), though it is mostly
2977 commented-out for now until the necessary API is committed to tinymail.
2978 (modest_account_settings_dialog_set_account_name),
2979 (save_configuration): Request the supported authentication methods from the
2980 server, so we can choose a working method.
2982 * src/modest-tny-account-store.h:
2983 * src/modest-tny-account-store.c:
2984 (modest_tny_account_store_get_session): Rename from
2985 tny_account_store_get_session().
2987 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2989 * src/modest-protocol-info.h: Split the ModestProtocol enum
2990 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2991 There was no need to have these unrelated values in one enum.
2993 * src/: many files: Adapted to changed enum. This makes the code a bit
2994 clearer, and the compiler could catch some errors.
2996 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2998 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2999 Show the detailed internal camel error message when an error happens
3000 during the configuration, so that our testers can give us more clues.
3001 For instance, in projects.maemo.org bug NB#56910 .
3003 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3005 * src/modest-tny-account.c:
3006 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
3007 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
3009 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3011 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3012 * src/maemo/modest-account-settings-dialog.c:
3013 (modest_account_settings_dialog_set_account_name),
3014 (save_configuration): For the incoming secure authentication checkbox,
3015 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
3016 the UI specification. PLAIN does not seem to be supported for most IMAP
3017 servers anyway, and I am not sure what it would mean.
3018 However, we probably need to discover which of the secure-authentication
3019 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
3020 * src/modest-account-mgr-helpers.c:
3021 (modest_account_mgr_get_server_account_data):
3023 * src/modest-tny-account.c:
3024 (modest_tny_account_new_from_server_account):
3025 Use tny_account_set_mech() to set secure-authentication methods,
3026 with some special-casing for IMAP, based on my observations of how
3029 * src/modest-account-mgr-helpers.h:
3030 * src/modest-account-mgr.c:
3031 * src/modest-defs.h: Comment that the URI is only used for local folders.
3033 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3035 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
3036 parameter const, just to be neat.
3037 * src/modest-text-utils.c: (modest_text_utils_inline):
3038 End g_strconcat() with NULL, as its documentation says. This is almost
3039 certainly the cause of my crash at startup on the device. Interestingly,
3040 valgrind doesn't tell us about these errors.
3042 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3044 * scripts/build-packages: Added more precise comments about how to use
3045 this script, though I still get this error:
3046 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
3047 error building tinymail
3049 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3051 * src/maemo/modest-main-window.c: (on_account_update):
3052 Very slight cleanup, hoping to make it simpler to discover what causes
3053 a crash here sometimes.
3055 * src/modest-tny-account.c:
3056 (modest_tny_account_new_from_server_account): Set the port. Added
3057 comments about the options and a TODO comment because I need to find out
3058 how to specify the secure authentication method.
3060 2007-05-11 Marcus Bauer <marcusb@openismus.com>
3062 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3063 changed CFlags paths form modest to libmodest
3065 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3067 * src/modest-account-mgr-helpers.c:
3068 (modest_account_mgr_get_server_account_data),
3069 (modest_account_mgr_free_server_account_data):
3070 * src/modest-account-mgr-helpers.h:
3071 * src/modest-account-mgr.c:
3072 (modest_account_mgr_add_server_account):
3073 * src/modest-defs.h:
3074 * src/modest-tny-account.c:
3075 (modest_tny_account_new_from_server_account):
3076 Determine the options for tny_camel_account_add_option() here,
3077 based on the settings, rather than storing them directly in gconf.
3079 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3081 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3082 Show a more friendly error dialog now that we expect (from the tinymail
3083 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3085 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3087 * src/maemo/modest-main-window.c: (on_account_update): Check that
3088 account_name is not NULL, to prevent a crash at startup that I am
3089 seeing on the N800. I do wonder why it is NULL.
3091 * src/maemo/easysetup/modest-easysetup-wizard.c:
3092 (create_page_user_details):
3093 * src/maemo/modest-account-settings-dialog.c:
3094 (create_page_user_details), (create_page_outgoing):
3095 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3096 (modest_connection_specific_smtp_edit_window_init):
3097 * src/modest-ui-actions.c:
3098 (modest_ui_actions_on_password_requested):
3099 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3100 might do something useful with the on-screen keyboard.
3102 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3104 * src/maemo/modest-main-window.c: (on_account_update):
3105 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3106 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3108 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3110 * src/modest-tny-account-store.c: (on_account_changed):
3111 Correct the signature of this signal handler.
3113 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3115 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3116 Show a HildonNote instead of a GtkDialog for Maemo.
3118 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3120 * src/widgets/modest-account-view.h:
3121 * src/widgets/modest-account-view.c: (on_account_changed),
3122 (on_account_removed). Added a boolean flag, set/unset by
3123 modest_account_view_block_conf_updates(),
3124 modest_account_view_unblock_conf_updates() to prevent unnecessary
3125 updates, but this is not very useful because the gconf notifications are
3126 so delays (maybe only on Maemo Bora).
3127 So auto-updating is turned off, and these functions do an explicit
3128 update when necessary.
3129 However, something else is still doing too much work when adding/removing
3130 accounts, probably in another part of the application.
3132 * src/maemo/modest-account-view-window.c:
3133 (on_delete_button_clicked), (on_edit_button_clicked),
3134 (on_new_button_clicked): Use the new functions.
3136 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3138 * src/modest-account-mgr-helpers.c:
3139 (modest_account_mgr_set_first_account_as_default):
3140 Sort the list of names alphabetically-by-title, so we choose the first one
3142 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3143 alphabetically by the title.
3145 This fixes projects.maemo.org bug NB#56418 .
3147 * src/modest-account-mgr-priv.c:
3148 (_modest_account_mgr_account_from_key):
3149 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3150 avoid a valgrind error, and possible random behaviour.
3152 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3154 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3155 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3156 tinymail documentation to say that this can be expected.
3157 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3158 pretty, and should not happen, but I would prefer to know when it does.
3160 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3162 * configure.ac: When using the older hildon version, probably on Bora,
3163 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3165 * src/widgets/modest-attachment-view.c:
3166 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3169 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3171 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3172 Implemented the prototype. Can be tested with
3173 tests/dbus_api/test_open_message:
3175 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3177 * src/modest-tny-account-store.c:
3178 (modest_tny_account_store_instance_init), (get_password):
3179 * src/modest-ui-actions.c:
3180 (modest_ui_actions_on_password_requested):
3181 Do not store the password in gconf, because this function is called
3182 for non-remembered passwords. Actually use the cached (in the hash map)
3183 password instead of releasing it.
3184 The password will now not be remembered if it is asked via the protected
3185 password dialog, as per the UI spec.
3187 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3189 * src/modest-defs.h:
3190 * src/modest-account-mgr-helpers.h:
3191 * src/modest-account-mgr-helpers.c:
3192 Added modest_server_account_get_username_has_succeeded(),
3193 modest_server_account_set_username_has_succeeded().
3194 (modest_server_account_set_username),
3195 Reset the has-succeeded flag if the username changes.
3197 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3198 * src/maemo/modest-connection-specific-smtp-window.c:
3199 (modest_connection_specific_smtp_window_save_server_accounts):
3200 Use modest_server_account_set_username() instead of using
3201 modest_conf_set_string() directly, so that the has-succeeded flag is always
3204 * src/modest-ui-actions.c:
3205 (modest_ui_actions_on_password_requested): Dim the username entry if
3206 the username has ever worked, as per the UI spec.
3208 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3210 * src/modest-tny-account-store.c: (get_password):
3211 * src/modest-ui-actions.c:
3212 (modest_ui_actions_on_password_requested):
3213 Allow the username to be changed too, though there is more work to
3214 be done on exactly how this behaves.
3216 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3218 * src/modest-account-mgr-helpers.h:
3219 * src/modest-account-mgr-helpers.c:
3220 Added modest_account_mgr_get_display_name(),
3221 modest_server_account_get_username(),
3222 modest_server_account_set_username(),
3223 modest_server_account_set_password(),
3224 modest_server_account_get_hostname() functions so we do not need to
3225 use the conf API directly.
3227 * src/maemo/modest-main-window.c: (connect_signals):
3228 Actually connect ot the ModestAccountStore::request-password signal,
3229 so that we show the dialog when the password is requested by Tinymail,
3230 for isntance if it is empty.
3232 * src/modest-marshal.list:
3233 * src/modest-tny-account-store.c:
3234 (modest_tny_account_store_class_init), (get_password),
3235 (modest_tny_account_store_alert):
3236 * src/modest-tny-account-store.h:
3237 * src/modest-ui-actions.h:
3238 * src/modest-ui-actions.c:
3239 (modest_ui_actions_on_password_requested):
3240 Change the signal parameters, so it is obvious that we are providing
3241 the non human-readable server name, and receiving both the username
3242 and password, though changing of the username is not yet implemented.
3243 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3244 for the GNOME version.
3246 This should fix the projects.maemo.org bug NB#56209, though it does not
3247 work on Bora, because the gconf_client_get() for the password fails
3248 immediately after we save it with gconf_client_set().
3250 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3253 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3254 caused an undefined symbol error:
3255 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3257 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3259 * src/modest-tny-account-store.c:
3260 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3261 using a GError instead of a string message, so we can translate it in
3264 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3266 * src/maemo/modest-address-book.c:
3267 (modest_address_book_check_names):
3268 * src/maemo/modest-msg-view-window.c:
3269 (modest_msg_view_window_clipboard_owner_change):
3270 * src/modest-init.c: (modest_init_init_ui):
3271 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3272 (update_folders_cb), (modest_mail_operation_update_account):
3273 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3274 (modest_ui_actions_on_msg_attachment_clicked),
3275 (modest_ui_actions_on_msg_recpt_activated):
3276 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3277 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3278 (modest_msg_view_search_next):
3279 * src/widgets/modest-recpt-editor.c:
3280 (modest_recpt_editor_on_button_release_event),
3281 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3282 g_message(). At this point we should only be seeing interesting errors on
3283 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3285 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3287 (modest_wizard_dialog_force_title_update):
3288 * src/maemo/easysetup/modest-wizard-dialog.h:
3289 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3290 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3291 can update the title when appropriate. Otherwise the title is wrong if the
3292 pages are added after adding the notebook to the dialog.
3293 This must be a problem in HildonWizardDialog too.
3294 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3296 * src/maemo/easysetup/modest-easysetup-wizard.c:
3297 (create_subsequent_customsetup_pages),
3298 (create_subsequent_easysetup_pages):
3299 Call modest_wizard_dialog_force_title_update() so that the title is
3300 correct even with GTK+ < 2.10.
3301 This fixes projects.maemo.org bug NB#56145 .
3303 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3305 * src/maemo/modest-platform.c:
3306 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3307 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3310 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3312 * src/widgets/modest-window.h:
3313 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3314 and modest_window_save_state(), which invokes it.
3316 * src/widgets/modest-window-mgr.h:
3317 * src/widgets/modest-window-mgr.c:
3318 Added modest_window_mgr_save_state_for_all_windows(), which calls
3319 the save_state vfunc on all registered windows, if implemented.
3321 * src/gnome/modest-msg-edit-window.c:
3322 * src/gnome/modest-msg-view-window.c:
3323 * src/maemo/modest-msg-edit-window.c:
3324 * src/maemo/modest-msg-view-window.c:
3325 * src/maemo/modest-main-window.c:
3326 Specify the existing save_settings functions as implementations of
3327 ModestWindow::save_state_func().
3329 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3330 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3331 enabling hibernation, for instance.
3333 We may need to do the same thing for restoring settings.
3336 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3338 * src/widgets/modest-window-mgr.c:
3339 * src/widgets/modest-window-mgr.h:
3340 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3341 modest_window_mgr_get_hibernation_is_prevented().
3343 * src/maemo/modest-main-window.c:
3344 (on_hildon_program_is_topmost_notify): Prevent hibernation
3345 (possible when the application goes to the background in the WM),
3346 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3348 * src/maemo/easysetup/modest-easysetup-wizard.c:
3349 (modest_easysetup_wizard_dialog_init):
3350 * src/maemo/modest-account-settings-dialog.c:
3351 (modest_account_settings_dialog_init):
3352 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3353 (modest_connection_specific_smtp_edit_window_init):
3354 * src/maemo/modest-connection-specific-smtp-window.c:
3355 (modest_connection_specific_smtp_window_init):
3356 * src/maemo/modest-signature-editor-dialog.c:
3357 (modest_signature_editor_dialog_init):
3358 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3359 prevent hibernation while any of these account settings dialogs are open.
3361 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3363 * src/maemo/Makefile.am:
3364 * src/maemo/modest-osso-state-saving.c:
3365 * src/maemo/modest-osso-state-saving.h: Added
3366 modest_osso_load_state() and modest_osso_save_state() though they do
3367 nothing now. They should iterate through all the open windows and load/save
3369 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3370 save state when closing.
3372 * src/maemo/modest-main-window.c:
3373 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3374 Add a notification handler for the HildonProgram::is-topmost property,
3375 so we can allow hibernation when the application goes into the background.
3376 But we still need to detect when the accounts setup windows are open so
3377 we can stop hibernation when they are open.
3378 To do this, I also added the main window the HildonProgram. This might have
3379 other side-effects/benefits, and should maybe be done for other windows.
3381 * src/maemo/modest-osso-autosave-callbacks.h:
3382 * src/maemo/modest-osso-autosave-callbacks.c:
3383 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3384 though it does not do anything yet, and we might never need this to do
3385 anything. For instance, we already save drafts.
3387 * src/maemo/modest-platform.c: (modest_platform_init):
3388 Specify the libosso auto-save callback.
3390 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3392 * src/maemo/modest-platform.c:
3393 (modest_platform_set_update_interval):
3394 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3395 aparently stays valid between application instances, so we can use this
3396 to remove and reset it later. According to a maemo-developers email from
3399 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3401 * configure.ac: Depend on libalarm for Maemo.
3403 * src/dbus_api/modest-dbus-api.h:
3404 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3405 (on_send_receive), (modest_dbus_req_handler):
3406 Handle a SEND_RECEIVE D-Bus method.
3408 * libmodest-dbus-client/libmodest-dbus-client.c:
3409 (libmodest_dbus_client_send_and_receive):
3410 * libmodest-dbus-client/libmodest-dbus-client.h:
3411 Add C convenience functions for calling the new D-Bus method.
3413 * src/modest-platform.h:
3414 * src/gnome/modest-platform.c:
3415 * src/maemo/modest-platform.c:
3416 Added modest_platform_set_update_interval(), which uses the
3417 alarmd API on Maemo.
3418 (modest_platform_init),
3419 Call modest_platform_set_update_interval(), using a hard-coded
3420 interval for now (until the global settings dialog is implemented),
3421 though I am not sure that this makes sense yet.
3423 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3425 * src/dbus_api/modest-dbus-callbacks.c:
3426 (modest_osso_cb_hw_state_handler):
3427 * src/dbus_api/modest-dbus-callbacks.h:
3428 * src/maemo/modest-platform.c: (modest_platform_init):
3429 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3430 in case this has some effect on the ability for Maemo to ping the
3433 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3435 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3436 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3437 warning. It is probably a logic error, but I need to fix the build.
3439 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3441 * src/modest-account-mgr.h:
3442 * src/modest-account-mgr.c:
3443 (modest_account_mgr_account_names): Add a gboolean enabled_only
3444 parameter, so we can get lists of onlt the enabled accounts.
3446 (modest_account_mgr_add_account),,
3447 (modest_account_mgr_account_with_display_name_exists):
3448 * src/maemo/modest-msg-edit-window.c: (get_transports):
3449 * src/modest-account-mgr-helpers.c:
3450 (modest_account_mgr_set_first_account_as_default):
3451 * src/modest-init.c: (init_default_account_maybe):
3452 * src/modest-tny-account-store.c: (get_accounts):
3453 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3454 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3455 * tests/check_account-mgr.c: (START_TEST):
3456 Provide the extra parameter, as appropriate.
3458 * src/widgets/modest-account-view.c: (update_account_view):
3459 Do not show disabled accounts (meaning that there is no way to
3460 enable/disable accounts in the UI (the feature is not in our UI
3461 specification), so we can use this internally only to mark unfinished
3462 or temporary account data.
3464 * src/maemo/easysetup/modest-easysetup-wizard.c:
3465 (create_account): Add boolean enable parameter, so we can specify FALSE
3466 to create the temporary account.
3467 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3468 (on_before_next): When finishing, when there is a temporary account, just
3470 Also, use a timeout to delay the showing of the dialog until gconf is likely
3471 to return correct information, due to a maemo gconf bug that is fixed in
3472 osso 1.1, but not yet in Bora.
3473 However, the dialog stays on screen after it is destroyed.
3475 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3476 for invalid data when cancelling. Use a hildon note instead of a dialog
3477 to complain about invalid data. Do not show the account-saved note if the
3478 account is disabled (a temporary account that will not really be saved for use
3481 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3483 * src/modest-account-mgr-helpers.h:
3484 * src/modest-account-mgr-helpers.c:
3485 Added modest_account_mgr_unset_default_account(),
3486 Added modest_account_mgr_set_first_account_as_default().
3488 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3489 If it was the default account, unset the default account name.
3491 * src/maemo/modest-account-view-window.c:
3492 (on_delete_button_clicked): If it was the default account,
3493 set the first remaining account as the default instead.
3495 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3496 a NULL account or a NULL default account, to prevent a crash. This should
3497 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3500 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3502 * src/widgets/modest-recpt-editor.c:
3503 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3504 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3505 TODO comment for this. This fixes the build.
3507 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3508 be the best place for it. This will in future update all auto-update accounts,
3509 rather than just the current/default account, when that gconf key exists.
3510 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3511 if there are no accounts, before calling do_send_receive().
3512 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3514 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3515 * src/maemo/modest-main-window-ui.h:
3516 * src/maemo/modest-main-window.c: (on_connection_changed),
3517 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3518 directly, becaue the signal handler does more.
3520 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3522 * src/modest-account-mgr-helpers.c:
3523 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3524 for the case that the account does not exist.
3526 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3527 (equivalent to the modest account name) rather than the tinymail account name
3528 (equivalent to the modest account title - human readable) to get the account data.
3529 Check for null account data to prevent the crash, and add a TODO comment saying that
3530 this needs fixing because it is using the server account name instead of the account name.
3532 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3534 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3535 * src/maemo/modest-account-settings-dialog.c: (show_error),
3537 Use hildon_note_new_information() for informative and error messages,
3538 which seems to be expected for Maemo applications (no documentation that I know of
3539 says this). I am surprised that there is no distinction between info and error
3542 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3544 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3545 it is easy to find where this is used.
3547 * src/maemo/easysetup/modest-easysetup-wizard.c:
3548 (create_page_welcome), (create_page_account_details),
3549 (create_page_user_details), (create_page_complete_easysetup),
3550 (create_page_custom_incoming), (create_page_custom_outgoing),
3551 (create_page_complete_custom):
3552 * src/maemo/modest-account-settings-dialog.c:
3553 (create_page_account_details), (create_page_user_details),
3554 (create_page_incoming), (create_page_outgoing):
3555 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3556 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3557 (modest_connection_specific_smtp_edit_window_init):
3558 * src/maemo/modest-connection-specific-smtp-window.c:
3559 (modest_connection_specific_smtp_window_init):
3560 * src/maemo/modest-signature-editor-dialog.c:
3561 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3562 and scrolling policy as per the Email Application Layout Guide, if I have
3565 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3567 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3568 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3569 which were empty, because these vfuncs have been removed from TnyAccountStore.
3570 This fixes the build.
3572 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3574 * src/maemo/modest-main-window.c:
3575 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3576 showing/hiding it. Added TODO because it probably should not be NULL.
3577 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3578 because unnecessary g_warnings() make degugging difficult.
3580 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3582 * src/maemo/modest-msg-edit-window.c:
3583 (modest_msg_edit_window_select_color),
3584 (modest_msg_edit_window_select_background_color): 2 const corrections and
3585 moving 2 #endifs before closing brackets, to fix the build.
3587 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3589 * src/maemo/easysetup/modest-easysetup-wizard.h:
3590 * src/maemo/easysetup/modest-easysetup-wizard.c:
3591 (modest_easysetup_wizard_dialog_finalize),
3592 (on_button_edit_advanced_settings), (create_page_complete_custom),
3593 (on_response), (create_account):
3594 Implement the Advanced Settings edit button, by saving the account information,
3595 for the Advanded Settings dialog to use directly from gconf, and removing it
3596 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3597 Bug #5533 in the projects.maemo.org bugzilla.
3599 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3601 * src/maemo/modest-msg-view-window.c:
3602 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3603 when opening a message window.
3605 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3607 * src/maemo/easysetup/modest-easysetup-wizard.c:
3608 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3611 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3612 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3613 gconf settings. I probably added more checks than necessary, but that is safer.
3615 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3616 variable to fix the build, but this seems to be used when it is still NULL.
3618 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3620 * src/modest-platform.h:
3621 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3622 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3623 * src/modest-main.c: Implement this function so we can avoid using
3624 maemo-specific API from cross-platform code.
3626 * src/modest-tny-account-store.c:
3627 (get_smtp_specific_transport_account_for_open_connection):
3628 * src/modest-ui-actions.c: (check_for_connection),
3629 (modest_ui_actions_on_item_not_found):
3630 Use modest_platform_connect_and_wait() and put #idefs around other
3631 maemo-specific code, because only maemo currently has a way to
3632 identify connection names.
3634 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3636 * src/modest-tny-account-store.h:
3637 * src/modest-tny-account-store.c:
3638 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3639 the connection-specific SMTP server settings in the configuration.
3641 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3643 * src/maemo/modest-main-window.c: (on_connection_changed),
3645 * src/modest-main.c: (main), (start_ui), (send_mail):
3646 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3647 that is what is intended.
3649 * src/modest-ui-actions.c: (action_send), (action_receive),
3650 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3651 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3652 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3653 SMTP server is used when it is specified.
3655 (modest_ui_actions_on_send_receive):
3656 Check that a connection is open before proceeding.
3657 Receive and then send, instead of vice-versa, as per the specification.
3659 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3661 * src/modest-mail-operation.c:
3662 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3663 though I guess it should be something other than NULL.
3665 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3667 * src/maemo/easysetup/modest-easysetup-wizard.c:
3668 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3669 combo twice, to avoid an g_warning and to make it visible again.
3670 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3671 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3672 (already intended) dereference when detaching, because we then recreate the menu.
3673 But I am not sure why the warning was happening, and it is possible that this is a memory
3676 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3678 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3679 and uri_parse_mailto() utility functions.
3680 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3682 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3684 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3686 * src/dbus_api/modest-dbus-api.h:
3687 * src/dbus_api/modest-dbus-callbacks.c:
3688 Use an idle callback to execute the modest code in the application's own thread.
3689 Remove the helloworld example method.
3690 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3691 parsed, and the open-message method is not implemented because this is not yet implemented in
3693 * libmodest-dbus-client/libmodest-dbus-client.c:
3694 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3695 (libmodest_dbus_client_open_message):
3696 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3698 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3699 body without crashing.
3701 * tests/dbus_api/Makefile.am:
3702 * tests/dbus_api/test_mail_to.c:
3703 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3705 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3707 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3708 Added file to fix the build. Sorry.
3710 * src/dbus_api/Makefile.am:
3711 * src/dbus_api/modest-dbus-api.h:
3712 * src/dbus_api/modest-dbus-callbacks.h:
3713 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3714 (modest_dbus_req_handler):
3715 Put constants in a separate header so it can be reused by the
3716 client library, without duplication
3718 * libmodest-dbus-client/Makefile.am:
3719 * libmodest-dbus-client/libmodest-dbus-client.c:
3720 (libmodest_dbus_client_call_helloworld),
3721 (libmodfest_dbus_client_send_mail),
3722 (libmodfest_dbus_client_mailto),
3723 (libmodfest_dbus_client_open_message):
3724 * libmodest-dbus-client/libmodest-dbus-client.h:
3725 (Partly) Implement a send_mail D-Bus method.
3727 * tests/dbus_api/Makefile.am:
3728 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3729 the send_email D-Bus method.
3731 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3735 * libmodest-dbus-client/Makefile.am:
3736 * libmodest-dbus-client/libmodest-dbus-client.c:
3737 * libmodest-dbus-client/libmodest-dbus-client.h:
3738 * tests/dbus_api/Makefile.am:
3739 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3740 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3742 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3744 * src/maemo/easysetup/modest-easysetup-wizard.c:
3745 (create_page_account_details):
3746 * src/maemo/modest-account-settings-dialog.c:
3747 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3748 widgets, because this might not be the default in future versions of the Maemo GTK+.
3749 However, I can not not get capitalization to work even in a simple test case.
3751 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3753 * src/maemo/easysetup/modest-easysetup-wizard.c:
3754 (create_page_custom_incoming), (create_page_custom_outgoing):
3755 * src/maemo/modest-account-settings-dialog.c:
3756 (create_page_account_details), (create_page_incoming),
3757 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3758 instead of using gtk_check_button_with_label(), so they are aligned like the other
3759 widgets, as per the UI spec.
3761 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3763 * src/maemo/easysetup/modest-easysetup-wizard.c:
3764 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3765 * src/widgets/modest-validating-entry.c:
3766 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3767 Modest prefix instead of an EasySetup prefix.
3769 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3771 * src/widgets/modest-validating-entry.h:
3772 * src/widgets/modest-validating-entry.c: (on_insert_text),
3773 Added easysetup_validating_entry_set_max_func(), used to set a callback
3774 to call when the max number of characters is reached. GtkEntry has a max-length
3775 already but is silent about it.
3777 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3778 (create_page_account_details), (create_page_user_details),
3780 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3781 (create_page_account_details), (create_page_user_details),
3782 (create_page_outgoing):
3783 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3784 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3785 the UI spec, when the user tries to enter more than the max number of characters.
3787 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3789 * src/maemo/easysetup/modest-easysetup-wizard.c:
3790 (create_page_user_details), (create_page_custom_incoming),
3791 (create_page_custom_outgoing):
3792 * src/maemo/modest-account-settings-dialog.c:
3793 (create_page_user_details), (create_page_incoming),
3794 (create_page_outgoing):
3795 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3796 (modest_connection_specific_smtp_edit_window_init):
3797 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3798 not appropriate. Bad Maemo-specific defaults!.
3800 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3802 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3803 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3804 (modest_signature_editor_dialog_set_settings):
3805 Disable the label and textview when the checkbox is disabled, and use the
3806 specified (UI spec) default signature text.
3808 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3810 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3811 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3813 * src/modest-defs.h:
3814 * src/modest-account-mgr-helpers.h:
3815 * src/modest-account-mgr-helpers.c:
3816 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3818 * src/maemo/Makefile.am:
3819 * src/maemo/modest-signature-editor-dialog.c:
3820 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3823 * src/maemo/modest-account-settings-dialog.h:
3824 * src/maemo/modest-account-settings-dialog.c:
3825 (modest_account_settings_dialog_finalize), (on_button_signature),
3826 (save_configuration): Use the new dialog when the Edit button is pressed, and
3827 save the changes if necessary, as per the UI spec.
3829 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3831 * src/maemo/Makefile.am:
3832 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3833 based on maemo-develoers email from Dirk.
3835 * src/maemo/easysetup/modest-easysetup-wizard.c:
3836 (create_page_welcome), (create_page_account_details),
3837 (create_page_user_details), (create_page_complete_easysetup),
3838 (create_page_custom_incoming), (create_page_custom_outgoing),
3839 (create_page_complete_custom),
3840 (modest_easysetup_wizard_dialog_init):
3841 * src/maemo/modest-account-settings-dialog.c:
3842 (create_page_account_details), (create_page_user_details),
3843 (create_page_incoming), (create_page_outgoing),
3844 (modest_account_settings_dialog_init):
3845 * src/maemo/modest-connection-specific-smtp-window.c:
3846 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3848 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3850 * src/maemo/easysetup/modest-easysetup-wizard.c:
3851 (create_page_account_details), (create_page_custom_outgoing),
3852 (create_page_complete_custom):
3853 * src/maemo/modest-account-settings-dialog.c:
3854 (create_page_user_details), (create_page_incoming),
3855 (create_page_outgoing):
3856 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3857 (modest_connection_specific_smtp_edit_window_init):
3858 Use the correct (UI spec) port min/max, and use horizontal separators,
3861 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3863 * src/maemo/easysetup/modest-easysetup-wizard.c:
3864 (set_default_custom_servernames):
3865 * src/maemo/modest-account-settings-dialog.c:
3866 (create_page_incoming), (on_combo_outgoing_security_changed),
3867 (on_combo_incoming_security_changed), (create_page_outgoing),
3868 (modest_account_settings_dialog_set_account_name),
3869 (save_configuration):
3870 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3871 (on_combo_security_changed),
3872 (modest_connection_specific_smtp_edit_window_init),
3873 (modest_connection_specific_smtp_edit_window_set_connection),
3874 (modest_connection_specific_smtp_edit_window_get_settings):
3875 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3878 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3881 * src/maemo/easysetup/modest-easysetup-wizard.c:
3882 (create_page_custom_outgoing), (create_page_complete_custom):
3883 * src/maemo/modest-account-settings-dialog.c:
3884 (create_page_user_details), (create_page_outgoing):
3885 * src/maemo/modest-account-view-window.c: (button_box_new):
3886 Use changed logical IDs as per the most recent UI spec:
3887 mcen_bd_emailsetup_edit -> mcen_bd_edit
3888 mcen_bd_emailsetup_delete -> mcen_bd_delete
3889 mcen_bd_emailsetup_close -> mcen_bd_close
3891 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3895 * src/dbus_api/Makefile.am:
3896 * src/dbus_api/modest-dbus-callbacks.c:
3897 * src/dbus_api/modest-dbus-callbacks.h:
3898 * src/maemo/modest-platform.c: (modest_platform_init):
3899 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3901 * tests/Makefile.am:
3902 * tests/dbus_api/Makefile.am:
3903 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3905 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3907 * src/maemo/modest-account-settings-dialog.c:
3908 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3909 Removed unnecessary includes.
3911 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3913 * src/maemo/easysetup/modest-easysetup-wizard.c:
3914 * src/maemo/modest-account-settings-dialog.c:
3915 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3916 * src/widgets/Makefile.am:
3917 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3918 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3919 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3920 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3921 * src/widgets/modest-secureauth-combo-box.c:
3922 * src/widgets/modest-secureauth-combo-box.h:
3923 * src/widgets/modest-serversecurity-combo-box.c:
3924 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3925 made the GObject names more consistent with the rest of the Modest code.
3927 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3929 * src/maemo/easysetup/Makefile.am:
3930 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3931 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3932 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3933 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3934 * src/maemo/easysetup/modest-easysetup-wizard.c:
3935 * src/maemo/easysetup/modest-validating-entry.c:
3936 * src/maemo/easysetup/modest-validating-entry.h:
3937 * src/maemo/modest-account-settings-dialog.c:
3938 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3939 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3940 widgets/ because they are used outside of easysetup too. After checking in,
3941 svn will allow me to rename them too.
3943 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3945 * src/gnome/modest-msg-edit-window.c:
3946 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3947 linker error, to fix the build on the GNOME platform.
3948 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3949 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3950 ifdefed out to avoid a warning.
3952 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3954 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3955 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3956 some alternative for GTK+ 2.6.
3958 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3960 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3962 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3963 specified for EmailAccountsDialog in UI spec.
3965 * src/maemo/easysetup/modest-easysetup-wizard.c:
3966 * src/maemo/easysetup/modest-easysetup-wizard.h:
3967 * src/maemo/modest-account-settings-dialog.c:
3968 * src/maemo/modest-account-settings-dialog.h:
3969 Reuse a member window widget for the connection-specific SMTP server accounts,
3970 so we can tell it to create/save the accounts only if we actually save changes.
3972 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3973 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3974 (modest_connection_specific_smtp_edit_window_get_settings):
3975 Return a struct instance for temporarily remembering the entered data.
3977 * src/maemo/modest-connection-specific-smtp-window.h:
3978 * src/maemo/modest-connection-specific-smtp-window.c:
3979 (modest_connection_specific_smtp_window_finalize),
3980 (modest_connection_specific_smtp_window_fill_with_connections),
3982 (modest_connection_specific_smtp_window_save_server_accounts),
3983 (update_model_server_names): Do not actually save data until asked,
3984 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3986 (on_selection_changed),
3987 (modest_connection_specific_smtp_window_init): Disable the edit
3988 button when nothing is selected.
3990 * src/modest-account-mgr-helpers.c:
3991 * src/modest-account-mgr-helpers.h:
3992 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3995 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3997 * src/modest-account-mgr-helpers.h:
3998 * src/modest-account-mgr-helpers.c:
3999 (modest_account_mgr_get_unused_account_name),
4000 (modest_account_mgr_get_unused_account_display_name): Added these
4001 utility functions, to avoid code duplication.
4003 * src/maemo/easysetup/modest-easysetup-wizard.c:
4004 (create_page_account_details), (create_account):
4005 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4006 (on_combo_security_changed),
4007 (modest_connection_specific_smtp_edit_window_init),
4008 (modest_connection_specific_smtp_edit_window_save_settings):
4009 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4010 * src/maemo/modest-connection-specific-smtp-window.c:
4011 (modest_connection_specific_smtp_window_finalize),
4012 (modest_connection_specific_smtp_window_fill_with_connections),
4013 (on_button_edit), (modest_connection_specific_smtp_window_init):
4014 * src/maemo/modest-connection-specific-smtp-window.h:
4015 Implementing saving of connection-specific server accounts.
4017 But I need to refactor this so we can save the data for each
4018 possible connection-specific account and only actually create the server accounts
4019 when the easysetup finished, or the OK button is pressed on the account settings
4022 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4024 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4025 (on_combo_security_changed):
4026 (modest_connection_specific_smtp_edit_window_init):
4027 Auto-fill the port number as in the account settings.
4029 (modest_connection_specific_smtp_edit_window_set_connection):
4030 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4031 * src/maemo/modest-connection-specific-smtp-window.c:
4032 (fill_with_connections), (on_button_edit),
4033 (modest_connection_specific_smtp_window_init):
4034 Turn the edit window into a dialog to simplify the code, and
4035 set a WM hint as in a GtkDialog, because only a popup can be on top of
4036 another window in Maemo, and popups usually have no WM decoration.
4038 * src/modest-defs.h:
4039 * src/modest-account-mgr-helpers.c:
4040 (modest_account_mgr_set_connection_specific_smtp),
4041 (modest_account_mgr_remove_connection_specific_smtp),
4042 (modest_account_mgr_get_connection_specific_smtp):
4043 * src/modest-account-mgr-helpers.h: Some functions to write the
4044 connection-specific SMTP server information. Not yet used.
4047 * src/widgets/modest-folder-view.c: (text_cell_data):
4048 Fix a warning about an uninitialized variable.
4049 (on_configuration_key_changed): Put an #ifdef around the use
4050 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
4052 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4054 * src/maemo/modest-account-settings-dialog.h:
4055 * src/maemo/modest-account-settings-dialog.c:
4056 Added connect_for_modified() utility function to mark the new modified boolean.
4058 (create_page_account_details), (create_page_user_details),
4059 (create_page_incoming), (create_page_outgoing), (on_response),
4060 (modest_account_settings_dialog_init),
4061 (modest_account_settings_dialog_set_account_name):
4062 Only warn about unsaved changes when there are actually unsaved changes.
4064 * src/modest-account-mgr-helpers.c:
4065 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
4066 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
4067 to get the data from there in future.
4069 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4071 * src/modest-defs.h:
4073 * src/modest-account-mgr-helpers.h:
4074 * src/modest-account-mgr-helpers.c:
4075 Store the security account setting in a single conf key instead of using
4076 the options list, so that the list is left for just the to-be-removed camel hack,
4077 and because gconf_client_set_list() is failing for some reason.
4079 * src/modest-account-mgr.c:
4080 (modest_account_mgr_add_server_account):
4081 * src/maemo/modest-account-settings-dialog.c:
4082 (modest_account_settings_dialog_set_account_name),
4083 (save_configuration): Use the renamed functions.
4086 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4088 * src/widgets/Makefile.am:
4089 * src/widgets/modest-limit-retrieve-combo-box.c:
4090 * src/widgets/modest-limit-retrieve-combo-box.h:
4091 * src/widgets/modest-retrieve-combo-box.c:
4092 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4093 the account settings dialog.
4095 * src/modest-defs.h:
4096 * src/modest-account-mgr-helpers.h:
4097 * src/modest-account-mgr-helpers.c:
4098 (modest_server_account_get_option_secure_auth),
4099 (modest_server_account_set_option_secure_auth):
4100 * src/modest-account-mgr.c:
4101 (modest_account_mgr_add_server_account):
4102 Use the existing AUTH_MECH conf key for the secure-auth setting,
4103 instead of putting it in the list options, because this was actually used already.
4105 * src/maemo/modest-account-settings-dialog.c:
4106 (create_page_account_details),
4107 (modest_account_settings_dialog_set_account_name),
4108 (save_configuration):
4109 * src/maemo/modest-account-settings-dialog.h:
4110 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4111 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4113 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4115 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4116 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4117 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4119 * src/modest-defs.h:
4120 * src/maemo/modest-account-settings-dialog.c:
4121 (create_page_incoming), (on_combo_outgoing_security_changed),
4122 (on_combo_incoming_security_changed), (create_page_outgoing),
4123 (modest_account_settings_dialog_set_account_name),
4124 (save_configuration): Load/Save the port number, and change it when the
4125 security combo changes, to suitable defaults.
4127 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4129 * src/modest-account-mgr.c:
4130 (modest_account_mgr_add_server_account): Set the security and secure-auth
4131 options, and add a comment saying that the other camel-specific options should be
4134 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4136 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4138 * src/modest-tny-account-store.c: (account_list_free),
4139 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4140 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4143 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4145 * src/modest-protocol-info.c:
4146 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4147 is required by our UI spec. Maybe something in our implementation will use this eventually.
4148 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4149 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4150 instead of the previous 0 placeholder.
4152 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4153 secure-auth settings.
4154 * src/modest-account-mgr-helpers.h:
4155 * src/modest-account-mgr-helpers.c:
4156 (modest_server_account_data_get_option_secure_auth),
4157 (modest_server_account_set_option_secure_auth),
4158 (modest_server_account_data_get_option_security),
4159 (modest_server_account_set_option_security): Added this API for getting and setting the security
4160 and secure-auth settings.
4162 * src/maemo/modest-account-settings-dialog.h:
4163 * src/maemo/modest-account-settings-dialog.c:
4164 (modest_account_settings_dialog_finalize), (check_data),
4165 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4166 about changing titles.
4167 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4168 (save_configuration): Save the security and secure-auth settings.
4170 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4171 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4173 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4175 * src/modest-defs.h:
4176 * src/modest-account-mgr.c:
4177 (modest_account_mgr_add_server_account):
4178 Added and used defines for the options key and value pair strings,
4179 that are used so far, though they do not seem to correspond to anything in our
4180 UI specs or ModestProtocol enum.
4182 * src/modest-account-mgr-helpers.h:
4183 * src/modest-account-mgr-helpers.c:
4184 (compare_option_strings_for_name),
4185 (modest_server_account_data_get_option_value),
4186 (modest_server_account_data_get_option_bool),
4187 (modest_account_mgr_get_server_account_option):
4188 Added helper functions for parsing the options GSList.
4190 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4192 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4193 display name is based on the supplied account name.
4194 * src/modest-account-mgr.c:
4195 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4196 with an inefficient, but good-enough, implementation.
4198 * src/maemo/easysetup/modest-easysetup-wizard.c:
4199 (create_page_account_details), (on_before_next), (create_account):
4200 Check for existing display names rather than (non-user-visible) account names, and just
4201 create and set a unique account name at the end.
4203 * src/maemo/modest-account-settings-dialog.c:
4204 (modest_account_settings_dialog_init),
4205 (modest_account_settings_dialog_set_account_name),
4206 (create_page_incoming): Show the display name, instead of the account name.
4207 (on_response): Do some (not all) extra checks, as in the UI spec.
4208 (save_configuration): Save the display name if it was changed.
4210 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4212 * po/en_GB.po: Added needed logical ID and translation.
4213 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4214 (init_view): Made the is-default column clicking work.
4216 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4219 * src/maemo/easysetup/Makefile.am:
4220 * src/maemo/easysetup/modest-easysetup-wizard.c:
4221 (modest_easysetup_wizard_dialog_init):
4222 * src/maemo/easysetup/provider-data-test.keyfile:
4223 * src/maemo/easysetup/provider-data.keyfile:
4224 Moved the provider data file to the new modest-providers-data package and used it from there.
4226 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4228 * src/modest-local-folder-info.c:
4229 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4230 N_() was already used on the static strings, but this just marks it for translation without
4231 using the translation.
4233 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4235 * src/maemo/modest-account-settings-dialog.c:
4236 (create_page_incoming),
4237 (modest_account_settings_dialog_set_account_name):
4238 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4239 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4240 I will do this if nobody else gets there first.
4242 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4244 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4245 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4246 save the security stuff.
4248 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4250 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4251 Set the email address and user fullname, which I now see must be
4254 * src/maemo/modest-account-settings-dialog.h:
4255 * src/maemo/modest-account-settings-dialog.c:
4257 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4258 leave-on-server and authentication.
4259 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4262 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4265 * src/maemo/modest-account-settings-dialog.c:
4266 * src/maemo/modest-account-settings-dialog.h:
4267 Most (but not all) of the widgets are now present as specified by the UI spec.
4268 No changes are yet saved, and some details are not properly shown yet.
4270 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4272 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4274 * src/maemo/Makefile.am:
4275 * src/maemo/modest-account-settings-dialog.c:
4276 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4277 an existing account. Doesn't do much yet.
4279 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4280 Open the accounts settings dialog when Edit is clicked.
4282 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4284 * src/maemo/easysetup/Makefile.am:
4285 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4287 * src/maemo/easysetup/modest-easysetup-wizard.c:
4288 (modest_easysetup_wizard_dialog_init):
4289 Try to get the source directory from the build system,
4290 instead of hard-coding "./" into the source code, when opening our local
4291 copies of the configuration files.
4292 But this still fails when opening the wizard from the Accounts window,
4293 maybe because the working directory seems to change at runtime.
4294 So the wizard will fail the second time unless you copy the files into their
4295 proper locations - see the stdout warnings for the paths.
4297 (create_page_account_details),(on_before_next):
4298 Check for existing non-server accounts instead of server accounts,
4299 so the default account name is useful again, and to prevent trying to
4302 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4303 Show the wizard when New is clicked.
4305 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4306 (init_view): Show the column headers, and show the columns that are
4307 specified in the UI specs. However, something in Maemo's GTK+ prevents
4308 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4309 change the default account. This is despite unsetting the special properties.
4311 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4313 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4314 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4315 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4316 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4317 to make that clearer.
4318 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4320 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4322 * src/maemo/modest-account-view-window.c:
4323 (modest_account_view_window_init),
4324 (modest_account_view_window_new):
4325 Use the same buttons as specified in the
4326 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4327 the existing widgets, which never had a chance of working.
4328 Put the ModestAccountView treeview in a scrolled window.
4329 Do not repeat the initialization in both _init() and _new().
4331 * src/widgets/modest-account-view.c: (update_account_view):
4332 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4333 this widget and window shows no accounts.
4335 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4337 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4339 * src/maemo/easysetup/modest-easysetup-wizard.c:
4340 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4341 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4342 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4345 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4346 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4347 accounts exist yet, as in the UI spec.
4349 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4351 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4353 * src/maemo/Makefile.am:
4354 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4355 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4356 New window for editing connection-specific smtp details.
4357 Not fully implemented.
4359 * src/maemo/modest-connection-specific-smtp-window.c:
4360 (modest_connection_specific_smtp_window_finalize) :
4361 unref the tree model.
4362 (on_button_edit): Show the edit window.
4364 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4366 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4369 * src/maemo/Makefile.am:
4370 * src/maemo/modest-connection-specific-smtp-window.c:
4371 * src/maemo/modest-connection-specific-smtp-window.h:
4372 New window for showing the list of connections, for connection-specific
4373 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4374 * src/maemo/easysetup/modest-easysetup-wizard.c:
4375 (create_page_custom_outgoing): Show the new window when the button is clicked.
4377 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4379 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4380 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4381 * src/maemo/modest-msg-edit-window.c:
4382 (modest_msg_edit_window_insert_image):
4383 * src/modest-conf.c: (modest_conf_key_escape):
4384 * src/modest-mail-operation.c:
4385 (modest_mail_operation_send_new_mail):
4386 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4387 (modest_ui_actions_on_new_account):
4388 * src/widgets/modest-attachment-view.c: (update_filename_request):
4389 * src/widgets/modest-mail-header-view.c:
4390 Corrected warnings that were breaking the build, by commenting out unused variables,
4391 and a function, and by including a header.
4393 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4395 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4396 so we can #ifdef around platform-specific code when necessary.
4397 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4398 to allow this to build for the GNOME platform too.
4400 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4402 * src/maemo/easysetup/modest-easysetup-wizard.c:
4403 Added util_increment_name() and used it in create_page_account_details()
4404 to make sure that the default account name is always a new name.
4406 (modest_easysetup_wizard_dialog_init),
4407 (set_default_custom_servernames): Some minor memory management fixes.
4409 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4413 * src/modest-runtime.c: (init_i18n): Restored the translation
4414 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4415 are defined in config.h, and the translations are installed.
4417 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4418 is defined for translation.
4420 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4422 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4424 * src/maemo/easysetup/modest-easysetup-wizard.c:
4425 (modest_easysetup_wizard_dialog_init):
4426 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4427 Use realistic paths (though they should use $prefix generically) to the
4428 mcc_mapping and provider-data.keyfile files which might work when they
4429 are installed by the future version of the operator-wizard package,
4430 and then fallback to paths in our source code, with an explanatory
4433 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4437 * src/maemo/Makefile.am:
4438 * src/maemo/easysetup/: Added files from the previously-exernal
4439 osso-modest-easysetup.
4440 * src/maemo/modest-main-window-ui.h:
4441 * src/modest-ui-actions.c:
4442 * src/modest-ui-actions.h:
4443 Added modest_ui_actions_on_new_account() as a signal handler for the
4444 New Account menu item. It shows the easysetup wizard.
4445 * po/en_GB.po: Added additional needed logical IDs and translations.