1 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
3 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
4 Added currently commented code to check for secure auth
6 * src/maemo/modest-account-settings-dialog.c: (on_response),
7 (save_configuration), (show_ok):
8 Fixed projects.maemo.org bugs NB #59248 and #59251
10 * src/maemo/modest-maemo-utils.c:
11 (on_camel_account_get_supported_secure_authentication_status),
12 (on_camel_account_get_supported_secure_authentication),
13 (modest_maemo_utils_get_supported_secure_authentication_methods):
14 * src/maemo/modest-maemo-utils.h:
15 Moved get_supported_secure_authentication() method here to be able
16 to use it from easysetup wizard.
18 * src/modest-pair.c: (on_pair_compare_as_string):
19 Should compare string with first part of pair and not
20 strcmp pairs which will crash.
22 * src/modest-protocol-info.c:
23 (modest_protocol_info_protocol_is_store):
24 * src/modest-protocol-info.h:
25 Added modest_protocol_info_get_auth_protocol_name()
27 2007-06-03 Armin Burgmeier <armin@openismus.com>
29 * src/modest-mail-operation.c:
30 (modest_mail_operation_get_msgs_full): Set priv->account also when
31 only retrieving a single message. This avoids a crash when canceling
34 (modest_mail_operation_notify_end): Do not explicitely remove the
35 operation from the queue but only emit the progress_changed signal.
36 The queue itself listens to that signal to remove the operation when
37 it is finished. This reduces coupling and removes a potential deadlock
38 when modest_mail_operation_notify_end() is called from the queue
39 itself. If that is a problem performance-wise, I would suggest to
40 implement a status-changed signal or something.
42 * src/modest-mail-operation-queue.c: Make sure to never call a
43 function from another file while the queue is locked. This (hopefully)
44 fixes another deadlock when exiting the application while retrieving
47 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
49 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
50 Fixed build if libogs is not available
52 2007-06-03 Christian Kellner <ckellner@openismus.com>
54 * libmodest-dbus-client/libmodest-dbus-client.h:
55 * libmodest-dbus-client/libmodest-dbus-client.c:
56 (libmodest_dbus_client_delete_message):
57 Implement deletion of messages (Client side).
59 (modest_search_hit_free),
60 (modest_search_hit_list_free):
61 Utility functions to free the result hits.
63 * src/dbus_api/modest-dbus-api.h:
64 * src/dbus_api/modest-dbus-callbacks.c:
66 (modest_dbus_req_handler):
67 Implement deletion of messages (Server side).
69 * tests/dbus_api/test_search.c: (main):
72 * tests/dbus_api/Makefile.am:
73 * tests/dbus_api/test_delete_message:
74 Add little test for the message deletion logic
76 2007-06-03 Armin Burgmeier <armin@openismus.com>
78 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
79 when the operation queue was not empty. projects.maemo.org bug
82 2007-06-03 Armin Burgmeier <armin@openismus.com>
84 * src/widgets/modest-account-view.c
85 (on_account_default_toggled): Toggle default account column
86 explicitely instead of waiting for gconf notification (which is
87 currently ignored). This should fix projects.maemo.org bug NB#56910
88 for now. It should probably be removed when gconf notifications are
91 2007-06-03 Christian Kellner <ckellner@openismus.com>
93 * libmodest-dbus-client/libmodest-dbus-client.c:
94 Removed debugging spew.
96 * src/dbus_api/modest-dbus-callbacks.c:
99 * src/modest-search.c:
100 (modest_search_all_accounts):
101 Use tny_account_store_get_accounts () on the account store
102 to get all accounts which is the way to get all accounts.
104 * tests/dbus_api/test_search.c: (main):
105 Make it possible to supply the search term on the command line.
107 2007-06-03 Christian Kellner <ckellner@openismus.com>
109 * libmodest-dbus-client/libmodest-dbus-client.c:
110 * libmodest-dbus-client/libmodest-dbus-client.h:
111 Implement searching for mesages over raw dbus. (Client side)
113 * src/dbus_api/Makefile.am:
114 * src/dbus_api/modest-dbus-api.h:
115 * src/dbus_api/modest-dbus-callbacks.c:
116 * src/dbus_api/modest-dbus-callbacks.h:
117 Search framework (Server side). Also implement on_idle_open_message().
119 * src/maemo/modest-platform.c: (modest_platform_init):
120 Prepare for raw dbus/osso rpc interaction.
122 * src/modest-search.h:
123 Changed minsize from unspecific guint to guint32.
125 * src/modest-search.c:
127 Added strange hack which magically made tnymail work.
129 (modest_search_folder),
130 (modest_search_account),
131 (modest_search_all_accounts):
132 Implement helper functions to search all accounts, specific account
135 * tests/dbus_api/Makefile.am:
136 * tests/dbus_api/test_open_message.c:
137 Read url to open from commandline.
139 * tests/dbus_api/test_search.c:
140 Implement small test for dbus search stuff
142 2007-06-02 Armin Burgmeier <armin@openismus.com>
144 * src/maemo/modest-account-settings-dialog.c: Changed window title to
145 include account type and account title. This fixes projects.maemo.org
148 * src/maemo/modest-account-view-window.c: Set a title for the window.
150 2007-06-02 Armin Burgmeier <armin@openismus.com>
152 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
153 incoming and outgoing server name based on email address and server
154 types as long as the names have not been edited manually. This fixes
155 projects.maemo.org bug NB#58671.
157 2007-06-02 Armin Burgmeier <armin@openismus.com>
159 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
160 server type cannot be changed in future to the incoming details page
161 when creating an account. This fixes projects.maemo.org bug NB#59029.
163 2007-06-02 Armin Burgmeier <armin@openismus.com>
165 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
166 and assigned max width chars so that they wrap instead of being
167 truncated. Fixes projects.maemo.org bug NB#56126.
169 2007-06-02 Armin Burgmeier <armin@openismus.com>
171 * src/maemo/modest-connection-specific-smtp-window.c: Add an
172 introductory note to the connection specific smtp servers dialog, as
173 section 8.12 of the email UI specification requires. This fixes
174 projects.maemo.org bug NB#59212.
176 2007-06-01 Murray Cumming <murrayc@murrayc.com>
178 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
179 Check for running mail operations, and offer to cancel them, as per the UI
180 spec. This fixes projects.maemo.org bug NB#59041 .
181 However, I suspect that tinymail may still use the network connection
182 in ways that we cannot detect or cancel. But it should at least adapt to
185 2007-06-01 Murray Cumming <murrayc@murrayc.com>
187 * src/modest-tny-account-store.c: (recreate_all_accounts),
188 (get_cached_accounts), (get_server_accounts): Do more sensible
189 ref-counting of the temporarily-cached outbox accounts list. This seems
190 to fix a crash when entering the password when the password was wrong.
192 2007-06-01 Murray Cumming <murrayc@murrayc.com>
194 * src/gnome/modest-main-window.c: (connect_signals):
195 * src/modest-tny-account-store.c: (get_password),
196 (modest_tny_account_store_alert): Added comments and clues and
197 commented-out code about how we currently fail to deal with connection
198 errors and wrong passwords, and how we should.
200 2007-06-01 Murray Cumming <murrayc@murrayc.com>
202 * src/widgets/modest-retrieve-combo-box.c:
203 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
204 This fixes projects.maemo.org bug NB#58472 .
206 2007-06-01 Murray Cumming <murrayc@murrayc.com>
208 * src/maemo/easysetup/modest-easysetup-wizard.c:
209 (create_page_complete_easysetup):
210 (create_page_complete_custom): Correct the last commit,
211 putting the correct sentences in the correct pages.
213 2007-06-01 Murray Cumming <murrayc@murrayc.com>
215 * src/maemo/easysetup/modest-easysetup-wizard.c:
216 (create_page_complete_custom): Show the second sentence of text
217 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
220 2007-06-01 Murray Cumming <murrayc@murrayc.com>
222 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
223 Set the leave-on-server conf key by default. This fixes
224 projects.maemo.org bug NB#59258 .
226 2007-06-01 Murray Cumming <murrayc@murrayc.com>
228 * src/maemo/modest-account-view-window.c:
229 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
230 logical ID for the confirmation messages. Fixed projects.maemo.org bug
233 2007-06-01 Murray Cumming <murrayc@murrayc.com>
235 * src/maemo/easysetup/modest-easysetup-wizard.c:
236 (create_caption_new_with_asterisk):
237 * src/maemo/modest-account-settings-dialog.c:
238 (create_caption_new_with_asterisk):
239 Uncomment the code to add the asterisk, because they are no longer in the
240 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
241 (update_incoming_server_title): Add an asterisk here too.
243 2007-06-01 Murray Cumming <murrayc@murrayc.com>
245 * src/maemo/modest-maemo-global-settings-dialog.c:
246 (current_connection): Check that we are even connected before trying to
247 get the current connection name, to prevent a warning.
249 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
250 Change the comments because tny_maemo_conic_device_connect() is now meant to
252 * src/modest-mail-operation.c:
253 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
254 make sure we have a connection and fail if we can't connect.
256 2007-05-31 Murray Cumming <murrayc@murrayc.com>
258 * src/maemo/modest-main-window.c:
259 (on_account_store_connecting_finished): Do not try to get the
260 connection ID if we are not really connected. I am surprised that
261 this signal handler is called when we are not connected.
263 2007-05-31 Murray Cumming <murrayc@murrayc.com>
265 * src/modest-error.h:
266 * src/modest-ui-actions.c:
267 (modest_ui_actions_get_msgs_full_error_handler):
268 Renamed an enum, added comments, added an enum
269 for retrieve-limit errors.
271 * src/modest-mail-operation.c: (foreach_add_item),
272 (internal_folder_observer_update), (update_account_thread),
273 (modest_mail_operation_get_msgs_full):
274 (modest_mail_operation_update_account),
275 Added comments about how this works, and some code that should
276 (but does not) check the retrieve-limit. See the TODO comment.
278 2007-05-31 Murray Cumming <murrayc@murrayc.com>
280 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
281 Initialize help_id to fix the build. Warnings are good.
283 2007-05-31 Murray Cumming <murrayc@murrayc.com>
285 * src/widgets/modest-hbox-cell-renderer.c:
286 (modest_hbox_cell_renderer_append):
287 * src/widgets/modest-vbox-cell-renderer.c:
288 (modest_vbox_cell_renderer_append):
289 Fix the last commit by doing an extra ref.
291 2007-05-31 Murray Cumming <murrayc@murrayc.com>
293 * src/widgets/modest-hbox-cell-renderer.c:
294 (modest_hbox_cell_renderer_append):
295 * src/widgets/modest-vbox-cell-renderer.c:
296 (modest_vbox_cell_renderer_append):
297 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
298 to fix the build with Maemo Bora.
299 However, there seems to be a remaining crash, probably due to reference
302 2007-05-30 Murray Cumming <murrayc@murrayc.com>
304 * src/modest-tny-account.c:
305 (modest_tny_account_new_for_local_folders):
306 Use hildon_file_system_info_async_new() to get a better name for
307 the memory card account, setting it as the account name.
308 The timing seems to work, but this is probably
309 not the best place to do this. See the TODO comment.
310 * src/maemo/modest-main-window.c: (create_details_widget):
311 * src/widgets/modest-folder-view.c: (text_cell_data):
312 Use the tny account name instead of hardcoding a name.
314 2007-05-30 Christian Kellner <ckellner@openismus.com>
316 * src/modest-search.c: (modest_search):
317 Correctly set part_search_func even if we have already parsed
318 the query and thus a valid OgsTextSearcher object.
320 2007-05-30 Christian Kellner <ckellner@openismus.com>
323 Search and check for libogs.
326 Incooparte the ogs build env.
328 * src/modest-mime-part-search-stream.c:
329 * src/modest-mime-part-search-stream.h:
330 Removed since we do the real searching now in modest-search.c.
332 * src/modest-search.c:
333 * src/modest-search.h:
334 Implement support for ogs. We use that if available and requested
335 and fall back to modest_text_utils_utf8_strcmp (). The search logic
336 should now handle the corner case when the search term is spread
337 across multiple reads.
338 Also the logic in modest_search () was corrected to search all
339 requested fields until one is found.
341 2007-05-30 Murray Cumming <murrayc@murrayc.com>
343 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
346 * src/modest-init.c: Made modest_init_local_folders() take a
347 path and be public so we can iniitialize maildir folders on
350 * src/modest-local-folder-info.h:
351 * src/modest-local-folder-info.c:
352 (modest_local_folder_info_get_maildir_path): Add a path parameter.
354 * src/modest-tny-account.c:
355 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
356 still means the standard local-folders path on the local volume.
358 * src/modest-tny-account-store.c:
359 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
360 signal so we can detect mount/unmount of the MMC1 card, and do an update of
361 all accounts when that happens.
362 (get_server_accounts): If the MMC1 card is mounted, create a store account for
363 this too, so it shows up in the treeview.
365 2007-05-28 Murray Cumming <murrayc@murrayc.com>
367 * src/maemo/modest-maemo-global-settings-dialog.c:
368 (current_connection):
369 * src/widgets/modest-global-settings-dialog.c:
370 (current_connection_default):
371 Use the enum values instead of 0, 1 and -1,
372 to make the code clearer.
374 * src/modest-account-mgr-helpers.c:
375 (modest_account_mgr_get_connection_specific_smtp): Make this code
378 * src/modest-runtime.h:
379 * src/modest-runtime.c:
380 Added modest_runtime_remove_all_send_queues().
381 * src/maemo/modest-main-window.c:
382 (on_account_store_connecting_finished): Recreate the send queues,
383 using the appropriate transport accounts for this new connection.
384 Some futher adapting might be needed if the old send queues are not
385 automatically stopped at this point.
387 * src/modest-tny-account-store.c: (get_server_accounts):
388 Create the connection-specific transport accounts, so that they can
389 be found later by their ID.
391 * src/modest-tny-account.h:
392 * src/modest-tny-account.c:
393 Added modest_tny_account_new_from_server_account_name().
394 modest_tny_account_new_from_server_account(): Do not create the
395 send queues here, because they will be
396 recreated anyway when the connection changes for the first time.
398 2007-05-28 Murray Cumming <murrayc@murrayc.com>
400 * src/modest-local-folder-info.h:
401 * src/modest-local-folder-info.c:
402 (modest_per_account_local_outbox_folder_info_get_maildir_path),
403 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
404 tbox_folder): Take a modest account name instead of a server TnyAccount,
405 so we can have per-modest-account rather than per-transport-account
407 We must make sure that we change or recreate the exisitng send queues
408 when the connection changes for connection-specific transport accounts.
410 * src/modest-tny-account-store.c:
411 (create_per_account_local_outbox_folders): Create outboxed per modest
412 account, not per transport account.
414 * src/modest-tny-account.h:
415 * src/modest-tny-account.c:
416 (modest_tny_account_get_special_folder): For outboxes, get the
417 parent modest account name. The account is ignored for other folders.
418 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
419 modest account name rather than a server TnyAccount.
421 2007-05-25 Murray Cumming <murrayc@murrayc.com>
423 * src/modest-tny-account.c:
424 (modest_tny_account_new_from_server_account):
425 Call modest_runtime_get_send_queue() immediately after creating transport
426 accounts, so that they start trying to send email from the outbox as soon
427 as possible at startup. This is probably what we want.
429 * src/modest-mail-operation.c: (update_account_thread):
430 * src/modest-runtime.c: (modest_runtime_get_send_queue):
431 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
432 * src/modest-tny-send-queue.h:
433 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
434 (modest_ui_actions_on_send):
435 Added comments about how sending works, though it needs some more work.
437 2007-05-25 Murray Cumming <murrayc@murrayc.com>
439 * src/modest-tny-account.c:
440 (modest_tny_account_get_special_folder): Add TODO because this fails when
442 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
443 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
444 Do not try to show this window when there is no active account. The UI
445 specs does not tell us what to do in this case.
447 2007-05-24 Murray Cumming <murrayc@murrayc.com>
451 * src/maemo/Makefile.am:
452 * src/widgets/Makefile.am: Some dist fixes.
454 2007-05-24 Murray Cumming <murrayc@murrayc.com>
456 * src/maemo/modest-connection-specific-smtp-window.c:
457 (on_button_edit): Make the code clearer, to prevent a double free.
459 2007-05-24 Murray Cumming <murrayc@murrayc.com>
461 * src/maemo/modest-account-settings-dialog.c:
462 (modest_account_settings_dialog_set_account_name),
463 Check the connection-specific smtp servers checkbox if there are any.
465 * src/maemo/modest-connection-specific-smtp-edit-window.c:
466 (modest_connection_specific_smtp_edit_window_init):
467 Start with a suitable port number.
469 * src/modest-account-mgr-helpers.h:
470 * src/modest-account-mgr-helpers.c: Added
471 modest_account_mgr_get_has_connection_specific_smtp().
473 (modest_account_mgr_set_connection_specific_smtp),
474 (modest_account_mgr_remove_connection_specific_smtp),
475 (modest_account_mgr_get_has_connection_specific_smtp),
476 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
477 connection-specific smtp server accounts in the account, rather than
478 the server account conf dir.
480 This fixes bug projects.maemo.org bug NB#58263 .
482 * src/modest-tny-account-store.c:
483 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
484 if there are no server accounts yet, to prevent an infinite loop when there
485 are no accounts. Document that one must be called before the other.
487 2007-05-24 Murray Cumming <murrayc@murrayc.com>
489 * src/modest-account-mgr-helpers.c:
490 (modest_account_mgr_get_default_account): Make sure that at least
491 one account is always the default, if there are any enabled accounts.
492 This is just a sanity check that shouldn't be necessary.
494 * src/modest-account-mgr-priv.c:
495 (_modest_account_mgr_account_from_key): Unescape the conf key to
496 get the real account name. For instance, this is an issue if a space
497 was in the account name, which can happen because the account name
498 is generated from the display name.
499 (_modest_account_mgr_get_account_keyname): Always escape the
501 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
502 Unescape the conf keys to get the real account names.
504 For instance, previously the is-default radio button in the accounts
505 list was not checked for any accounts at first. This fixes that,
506 and might fix several similar bugs.
508 2007-05-23 Murray Cumming <murrayc@murrayc.com>
510 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
511 Removed some debug printfs.
513 2007-05-23 Murray Cumming <murrayc@murrayc.com>
515 Modest on-disk outbox directories are now here, for instance:
516 $HOME/.modest/outboxes/<account-id-1>/outbox
517 $HOME/.modest/outboxes/<account-id-2>/outbox
519 $HOME/.modest/local-folders/outbox
520 so we can have a separate outbox for each account.
521 But they are shown as one outbox in the GtkTreeView, by using a
522 TnyMergeFolder in a ModestTnySimpleFolderStore.
525 * src/modest-tny-simple-folder-store.c:
526 * src/modest-tny-simple-folder-store.h:
527 Added ModestTnySimpleFolderStore, used to contain folders from
528 other folder stores, such as other accounts.
530 * src/modest-tny-outbox-account.h:
531 * src/modest-tny-outbox-account.c:
532 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
533 used for the per-account local outbox folders.
535 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
536 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
537 only use this (internally) now for the non-outbox local folders.
540 * src/modest-init.c: Added modest_init_one_local_folder(), for
541 setting up the directory structure for each local folder.
543 * src/modest-local-folder-info.c:
544 (modest_per_account_local_outbox_folder_info_get_maildir_path),
545 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
547 * src/modest-local-folder-info.h:
548 * src/modest-tny-account-store.c: (on_account_removed),
549 (on_account_changed), (create_per_account_local_outbox_folders),
550 (get_server_accounts), (modest_tny_account_store_get_accounts),
551 (modest_tny_account_store_get_tny_account_by_account),
552 (modest_tny_folder_store_is_virtual_local_folders):
554 * src/modest-tny-account.h:
555 * src/modest-tny-account.c:
556 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
557 to create an on-disk per-account local outbox folder for each
559 (create_per_account_local_outbox_folders): Create a local outbox folder
560 for each transport account.
561 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
562 for all local folders.
564 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
565 instead of using g_object_get/set() directly. It is clearer.
567 (modest_tny_folder_store_get_message_count),
568 (modest_tny_folder_store_get_local_size
569 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
570 because we now use these with non-acount folder stores.
572 (modest_tny_account_get_special_folder),
573 (modest_tny_account_new_from_server_account),
574 (modest_tny_account_new_from_account):
575 (recurse_folders): Adjust to the new outbox system.
577 * src/modest-tny-folder.h:
578 * src/modest-tny-folder.c:
579 (modest_tny_folder_is_local_folder),
580 (modest_tny_folder_get_local_folder_type),
581 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
583 * src/widgets/modest-main-window.h:
584 * src/maemo/modest-main-window.c: (create_details_widget),
585 (modest_main_window_set_contents_style): Show details for any folder store,
588 (modest_tny_folder_get_rules):
589 Remove the const. C does not support constness enough for this.
591 * src/modest-ui-actions.c:
592 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
593 make all outboxes appear as one, in the usual local-folders tree node.
595 (set_active_account_from_tny_account),
596 (modest_ui_actions_on_folder_selection_changed):
597 * src/widgets/modest-folder-view.c: (text_cell_data),
598 (icon_cell_data), (filter_row),
599 (add_account_folders_to_merged_folder),
600 (add_account_folders_to_simple_folder_store), (),
601 (get_cmp_rows_type_pos), (cmp_rows),
602 (modest_folder_view_set_account_id_of_visible_server_account):
603 Adjust to the new outbox system, using generic folder stores and folders
606 2007-05-23 Christian Kellner <ckellner@openismus.com>
608 * src/modest-mail-operation.c:
609 (modest_mail_operation_update_account):
610 Use info->max_size instead of unintialized local var [small
611 build fix]. (Added TODO to review that change since I don't
614 2007-05-23 Marcus Bauer <marcusb@openismus.com>
616 * libmodest-dbus-client/libmodest-dbus-client.c:
617 (libmodest_dbus_client_compose_mail): function added
618 * src/dbus_api/modest-dbus-api.h:
619 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
620 (on_compose_mail): Implementation of the SendAsMail functionality
622 2007-05-22 Murray Cumming <murrayc@murrayc.com>
624 * src/modest-account-mgr.c:
625 (modest_account_mgr_add_server_account): Set the secure-connection
626 conf key for transport accounts as well as store accounts. I don't know
627 why the if was there. For instance, this makes sure that we use SSL
628 for the gmail preset from the easysetup wizard.
630 2007-05-22 Murray Cumming <murrayc@murrayc.com>
632 * src/gnome/modest-main-window.c:
633 (on_account_store_connecting_finished), (connect_signals):
634 * src/maemo/modest-main-window.c:
635 (on_account_store_connecting_finished), (connect_signals),
636 (modest_main_window_new):
637 Handle TnyAccountStore::connecting-finished instead of
638 TnyDevice::connection-changed, because we cannot actually perform
639 operations on accounts until TnyAccountStore has itself responded to
640 the TnyDevice::connection-changed signal. This prevents a GError from
642 Do not try to update at startup, because we (at least on scratchbox)
643 already do an update at startup when the device goes online.
644 This prevents a GError from tinymail.
645 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
646 Added TODO about stopping simultaneous operations.
648 2007-05-21 Murray Cumming <murrayc@murrayc.com>
650 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
651 * src/modest-mail-operation-queue.c:
652 (modest_mail_operation_queue_remove):
653 * src/modest-tny-account-store.c: When GErrors happen, give more clues
654 about where they happened.
656 2007-05-21 Murray Cumming <murrayc@murrayc.com>
658 * src/modest-ui-actions.c:
659 (modest_ui_actions_on_password_requested): Make sure that the remember
660 output parameter is always TRUE.
662 2007-05-21 Murray Cumming <murrayc@murrayc.com>
664 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
665 Show a OK/Cancel dialog if the error is a question, though we still do not
666 know anything more about what we are asking the user.
667 * src/widgets/modest-folder-view.c: (on_drag_data_received):
668 Fix an uninitialized variable (helper). This is a logic error, however.
670 2007-05-21 Christian Kellner <ckellner@openismus.com>
672 * src/modest-search.h:
673 Correct bit shifting in the ModestSearchFlags enum.
675 2007-05-21 Murray Cumming <murrayc@murrayc.com>
677 * src/modest-tny-account.c:
678 (modest_tny_account_new_from_server_account): Do not use the lsub and
679 check-all hard-coded IMAP options when using POP.
681 2007-05-21 Murray Cumming <murrayc@murrayc.com>
683 * src/modest-tny-account.c:
684 (modest_tny_account_new_from_server_account):
685 Use NULL for the secure-auth method for POP when Password auth has been
686 specified by the user, as we already do for IMAP. "auth=Login" causes
687 an error from camel or the server.
689 2007-05-17 Murray Cumming <murrayc@murrayc.com>
691 * src/maemo/modest-account-settings-dialog.c:
692 (create_page_account_details),
693 (modest_account_settings_dialog_set_account_name):
694 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
695 for the leave-on-server checkbox, rathr than just the checkbox, when
696 the protocol is not POP.
698 2007-05-17 Murray Cumming <murrayc@murrayc.com>
700 * src/widgets/modest-account-view.c:
701 * src/widgets/modest-account-view.h:
702 Added modest_account_view_select_account() which will be useful later
703 to asynchronously re-select the edited account.
705 2007-05-17 Murray Cumming <murrayc@murrayc.com>
707 * src/maemo/modest-account-settings-dialog.c:
708 (modest_account_settings_dialog_set_account_name):
709 Automatically choose the port numbers based on the secure authentication
710 methods, if they have not been chosen before.
711 This fixes projects.maemo.org bug NB#56273 .
713 2007-05-17 Murray Cumming <murrayc@murrayc.com>
715 * src/maemo/modest-main-window-ui.h:
716 * src/modest-ui-actions.c:
717 * src/modest-ui-actions.h:
718 Connect the Tools/SMTP Servers menu item to
719 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
720 SMTP servers dialog, as in the UI specification and saves changes when it
721 is closed. This fixed projects.maemo.org bug NB#56305 .
723 2007-05-17 Murray Cumming <murrayc@murrayc.com>
725 * src/maemo/modest-connection-specific-smtp-window.c:
726 (modest_connection_specific_smtp_window_init):
727 Use gtk_window_set_default_size() to make this window big enough, so
728 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
730 2007-05-17 Murray Cumming <murrayc@murrayc.com>
732 * src/maemo/modest-connection-specific-smtp-edit-window.h:
733 * src/maemo/modest-connection-specific-smtp-edit-window.c:
734 (modest_connection_specific_smtp_edit_window_init),
735 Do not try to connect to a combobox signal before the combobox exists.
736 This fixes the cras in projects.maemo.org bug NB#56288 .
737 (modest_connection_specific_smtp_edit_window_get_settings):
738 Remove the server_account_name parameter which was being checked for NULL
739 though it was not used.
741 * src/maemo/modest-connection-specific-smtp-window.c:
742 (modest_connection_specific_smtp_window_fill_with_connections),
743 (on_button_edit), (modest_connection_specific_smtp_window_init):
744 Correct the number of treemodel columns to prevent a warning.
745 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
746 libconic does not work.
748 2007-05-16 Murray Cumming <murrayc@murrayc.com>
750 * src/modest-tny-account.c:
751 (modest_tny_account_new_from_server_account):
752 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
753 SMTP when "None" was chosen by the user. However, with my SMTP server that
754 does not support ANONYMOUS, the emails do not leave the Outbox and I see
757 2007-05-16 Murray Cumming <murrayc@murrayc.com>
759 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
760 to explain the memory management issue with the ID in the ModestPair.
762 * src/gnome/modest-account-assistant.c: (add_receiving_page),
763 (add_sending_page), (modest_account_assistant_finalize):
764 * src/gnome/modest-gnome-global-settings-dialog.c:
765 (create_updating_page), (create_composing_page):
766 * src/gnome/modest-msg-edit-window.c: (get_transports),
767 (init_window), (modest_msg_edit_window_finalize),
768 (modest_msg_edit_window_get_msg_data):
769 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
770 * src/gnome/modest-transport-widget.c:
771 (modest_transport_widget_finalize), (smtp_configuration):
772 * src/maemo/modest-maemo-global-settings-dialog.c:
773 (create_updating_page), (create_composing_page):
774 * src/maemo/modest-msg-edit-window.c: (get_transports),
775 (init_window), (modest_msg_edit_window_finalize),
776 (modest_msg_edit_window_get_msg_data),
777 (modest_msg_edit_window_free_msg_data):
778 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
779 (modest_store_widget_finalize):
780 * src/maemo/modest-transport-widget.c:
781 (modest_transport_widget_finalize), (smtp_configuration):
782 * src/modest-main.c: (send_mail):
783 * src/widgets/modest-combo-box.h:
784 * src/widgets/modest-global-settings-dialog-priv.h:
785 * src/widgets/modest-global-settings-dialog.c:
786 (modest_global_settings_dialog_finalize):
787 * src/widgets/modest-msg-edit-window.h:
788 Whenever using modest_combo_box_new(), keep the ModestPairList alive
789 as long as the combo box, to prevent use of freed memory for the ID.
791 2007-05-15 Murray Cumming <murrayc@murrayc.com>
793 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
794 get_accounts(), to make this clearer. Do not check for the enabled gconf
795 key, because we do not use this for server accounts (at least, not yet).
796 This allows us to send email again.
798 2007-05-15 Murray Cumming <murrayc@murrayc.com>
800 * src/maemo/modest-platform.c:
801 (on_modest_conf_update_interval_changed), (modest_platform_init):
802 Only respond to this particular key change. All these strcmp()s cannot be
805 2007-05-15 Murray Cumming <murrayc@murrayc.com>
807 * src/maemo/modest-maemo-global-settings-dialog.c:
808 (current_connection): Prevent a crash in scratchbox when
809 ny_maemo_conic_device_get_current_iap_id() returns NULL.
810 * src/maemo/modest-platform.c:
811 (on_modest_conf_update_interval_changed), (modest_platform_init):
812 Get the update interval from gconf and reset it when the gconf key changes.
814 2007-05-15 Murray Cumming <murrayc@murrayc.com>
816 * src/modest-protocol-info.c:
817 * src/modest-protocol-info.h: Adde enum-specific get functions,
818 instead of using a ModestProtocolType enum parameter.
820 * src/gnome/modest-account-assistant.c:
821 * src/gnome/modest-store-widget.c:
822 * src/gnome/modest-store-widget.h:
823 * src/gnome/modest-transport-widget.c:
824 * src/gnome/modest-transport-widget.h:
825 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
826 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
827 * src/maemo/easysetup/modest-easysetup-wizard.c:
828 * src/maemo/modest-account-settings-dialog.c:
829 * src/maemo/modest-account-settings-dialog.h:
830 * src/maemo/modest-store-widget.c:
831 * src/maemo/modest-store-widget.h:
832 * src/maemo/modest-transport-widget.c:
833 * src/maemo/modest-transport-widget.h:
834 * src/modest-account-mgr-helpers.c:
835 * src/modest-account-mgr-helpers.h:
836 * src/modest-account-mgr.c:
837 * src/modest-account-mgr.h:
838 * src/modest-tny-account.c:
839 * src/modest-tny-folder.c:
840 * src/widgets/modest-account-view.c:
841 * src/widgets/modest-retrieve-combo-box.c:
842 * src/widgets/modest-retrieve-combo-box.h:
843 * src/widgets/modest-secureauth-combo-box.c:
844 * src/widgets/modest-serversecurity-combo-box.c:
845 * src/widgets/modest-serversecurity-combo-box.h:
846 * tests/check_account-mgr.c:
847 Use the specific functions, and use the re-renamed enum values for GNOME too.
849 2007-05-15 Murray Cumming <murrayc@murrayc.com>
852 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
853 so we can get the second based on the first.
855 * src/maemo/modest-account-settings-dialog.h:
856 * src/maemo/modest-account-settings-dialog.c:
857 Added get_supported_secure_authentication_methods(), though it is mostly
858 commented-out for now until the necessary API is committed to tinymail.
859 (modest_account_settings_dialog_set_account_name),
860 (save_configuration): Request the supported authentication methods from the
861 server, so we can choose a working method.
863 * src/modest-tny-account-store.h:
864 * src/modest-tny-account-store.c:
865 (modest_tny_account_store_get_session): Rename from
866 tny_account_store_get_session().
868 2007-05-14 Murray Cumming <murrayc@murrayc.com>
870 * src/modest-protocol-info.h: Split the ModestProtocol enum
871 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
872 There was no need to have these unrelated values in one enum.
874 * src/: many files: Adapted to changed enum. This makes the code a bit
875 clearer, and the compiler could catch some errors.
877 2007-05-14 Murray Cumming <murrayc@murrayc.com>
879 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
880 Show the detailed internal camel error message when an error happens
881 during the configuration, so that our testers can give us more clues.
882 For instance, in projects.maemo.org bug NB#56910 .
884 2007-05-14 Murray Cumming <murrayc@murrayc.com>
886 * src/modest-tny-account.c:
887 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
888 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
890 2007-05-14 Murray Cumming <murrayc@murrayc.com>
892 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
893 * src/maemo/modest-account-settings-dialog.c:
894 (modest_account_settings_dialog_set_account_name),
895 (save_configuration): For the incoming secure authentication checkbox,
896 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
897 the UI specification. PLAIN does not seem to be supported for most IMAP
898 servers anyway, and I am not sure what it would mean.
899 However, we probably need to discover which of the secure-authentication
900 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
901 * src/modest-account-mgr-helpers.c:
902 (modest_account_mgr_get_server_account_data):
904 * src/modest-tny-account.c:
905 (modest_tny_account_new_from_server_account):
906 Use tny_account_set_mech() to set secure-authentication methods,
907 with some special-casing for IMAP, based on my observations of how
910 * src/modest-account-mgr-helpers.h:
911 * src/modest-account-mgr.c:
912 * src/modest-defs.h: Comment that the URI is only used for local folders.
914 2007-05-11 Murray Cumming <murrayc@murrayc.com>
916 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
917 parameter const, just to be neat.
918 * src/modest-text-utils.c: (modest_text_utils_inline):
919 End g_strconcat() with NULL, as its documentation says. This is almost
920 certainly the cause of my crash at startup on the device. Interestingly,
921 valgrind doesn't tell us about these errors.
923 2007-05-11 Murray Cumming <murrayc@murrayc.com>
925 * scripts/build-packages: Added more precise comments about how to use
926 this script, though I still get this error:
927 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
928 error building tinymail
930 2007-05-11 Murray Cumming <murrayc@murrayc.com>
932 * src/maemo/modest-main-window.c: (on_account_update):
933 Very slight cleanup, hoping to make it simpler to discover what causes
934 a crash here sometimes.
936 * src/modest-tny-account.c:
937 (modest_tny_account_new_from_server_account): Set the port. Added
938 comments about the options and a TODO comment because I need to find out
939 how to specify the secure authentication method.
941 2007-05-11 Marcus Bauer <marcusb@openismus.com>
943 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
944 changed CFlags paths form modest to libmodest
946 2007-05-10 Murray Cumming <murrayc@murrayc.com>
948 * src/modest-account-mgr-helpers.c:
949 (modest_account_mgr_get_server_account_data),
950 (modest_account_mgr_free_server_account_data):
951 * src/modest-account-mgr-helpers.h:
952 * src/modest-account-mgr.c:
953 (modest_account_mgr_add_server_account):
955 * src/modest-tny-account.c:
956 (modest_tny_account_new_from_server_account):
957 Determine the options for tny_camel_account_add_option() here,
958 based on the settings, rather than storing them directly in gconf.
960 2007-05-10 Murray Cumming <murrayc@murrayc.com>
962 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
963 Show a more friendly error dialog now that we expect (from the tinymail
964 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
966 2007-05-10 Murray Cumming <murrayc@murrayc.com>
968 * src/maemo/modest-main-window.c: (on_account_update): Check that
969 account_name is not NULL, to prevent a crash at startup that I am
970 seeing on the N800. I do wonder why it is NULL.
972 * src/maemo/easysetup/modest-easysetup-wizard.c:
973 (create_page_user_details):
974 * src/maemo/modest-account-settings-dialog.c:
975 (create_page_user_details), (create_page_outgoing):
976 * src/maemo/modest-connection-specific-smtp-edit-window.c:
977 (modest_connection_specific_smtp_edit_window_init):
978 * src/modest-ui-actions.c:
979 (modest_ui_actions_on_password_requested):
980 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
981 might do something useful with the on-screen keyboard.
983 2007-05-10 Murray Cumming <murrayc@murrayc.com>
985 * src/maemo/modest-main-window.c: (on_account_update):
986 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
987 NULL, to avoid lots of warnings. However, it probably should not be NULL.
989 2007-05-09 Murray Cumming <murrayc@murrayc.com>
991 * src/modest-tny-account-store.c: (on_account_changed):
992 Correct the signature of this signal handler.
994 2007-05-09 Murray Cumming <murrayc@murrayc.com>
996 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
997 Show a HildonNote instead of a GtkDialog for Maemo.
999 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1001 * src/widgets/modest-account-view.h:
1002 * src/widgets/modest-account-view.c: (on_account_changed),
1003 (on_account_removed). Added a boolean flag, set/unset by
1004 modest_account_view_block_conf_updates(),
1005 modest_account_view_unblock_conf_updates() to prevent unnecessary
1006 updates, but this is not very useful because the gconf notifications are
1007 so delays (maybe only on Maemo Bora).
1008 So auto-updating is turned off, and these functions do an explicit
1009 update when necessary.
1010 However, something else is still doing too much work when adding/removing
1011 accounts, probably in another part of the application.
1013 * src/maemo/modest-account-view-window.c:
1014 (on_delete_button_clicked), (on_edit_button_clicked),
1015 (on_new_button_clicked): Use the new functions.
1017 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1019 * src/modest-account-mgr-helpers.c:
1020 (modest_account_mgr_set_first_account_as_default):
1021 Sort the list of names alphabetically-by-title, so we choose the first one
1023 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1024 alphabetically by the title.
1026 This fixes projects.maemo.org bug NB#56418 .
1028 * src/modest-account-mgr-priv.c:
1029 (_modest_account_mgr_account_from_key):
1030 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1031 avoid a valgrind error, and possible random behaviour.
1033 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1035 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1036 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1037 tinymail documentation to say that this can be expected.
1038 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1039 pretty, and should not happen, but I would prefer to know when it does.
1041 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1043 * configure.ac: When using the older hildon version, probably on Bora,
1044 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1046 * src/widgets/modest-attachment-view.c:
1047 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1050 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1052 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1053 Implemented the prototype. Can be tested with
1054 tests/dbus_api/test_open_message:
1056 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1058 * src/modest-tny-account-store.c:
1059 (modest_tny_account_store_instance_init), (get_password):
1060 * src/modest-ui-actions.c:
1061 (modest_ui_actions_on_password_requested):
1062 Do not store the password in gconf, because this function is called
1063 for non-remembered passwords. Actually use the cached (in the hash map)
1064 password instead of releasing it.
1065 The password will now not be remembered if it is asked via the protected
1066 password dialog, as per the UI spec.
1068 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1070 * src/modest-defs.h:
1071 * src/modest-account-mgr-helpers.h:
1072 * src/modest-account-mgr-helpers.c:
1073 Added modest_server_account_get_username_has_succeeded(),
1074 modest_server_account_set_username_has_succeeded().
1075 (modest_server_account_set_username),
1076 Reset the has-succeeded flag if the username changes.
1078 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1079 * src/maemo/modest-connection-specific-smtp-window.c:
1080 (modest_connection_specific_smtp_window_save_server_accounts):
1081 Use modest_server_account_set_username() instead of using
1082 modest_conf_set_string() directly, so that the has-succeeded flag is always
1085 * src/modest-ui-actions.c:
1086 (modest_ui_actions_on_password_requested): Dim the username entry if
1087 the username has ever worked, as per the UI spec.
1089 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1091 * src/modest-tny-account-store.c: (get_password):
1092 * src/modest-ui-actions.c:
1093 (modest_ui_actions_on_password_requested):
1094 Allow the username to be changed too, though there is more work to
1095 be done on exactly how this behaves.
1097 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1099 * src/modest-account-mgr-helpers.h:
1100 * src/modest-account-mgr-helpers.c:
1101 Added modest_account_mgr_get_display_name(),
1102 modest_server_account_get_username(),
1103 modest_server_account_set_username(),
1104 modest_server_account_set_password(),
1105 modest_server_account_get_hostname() functions so we do not need to
1106 use the conf API directly.
1108 * src/maemo/modest-main-window.c: (connect_signals):
1109 Actually connect ot the ModestAccountStore::request-password signal,
1110 so that we show the dialog when the password is requested by Tinymail,
1111 for isntance if it is empty.
1113 * src/modest-marshal.list:
1114 * src/modest-tny-account-store.c:
1115 (modest_tny_account_store_class_init), (get_password),
1116 (modest_tny_account_store_alert):
1117 * src/modest-tny-account-store.h:
1118 * src/modest-ui-actions.h:
1119 * src/modest-ui-actions.c:
1120 (modest_ui_actions_on_password_requested):
1121 Change the signal parameters, so it is obvious that we are providing
1122 the non human-readable server name, and receiving both the username
1123 and password, though changing of the username is not yet implemented.
1124 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1125 for the GNOME version.
1127 This should fix the projects.maemo.org bug NB#56209, though it does not
1128 work on Bora, because the gconf_client_get() for the password fails
1129 immediately after we save it with gconf_client_set().
1131 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1134 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1135 caused an undefined symbol error:
1136 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1138 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1140 * src/modest-tny-account-store.c:
1141 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1142 using a GError instead of a string message, so we can translate it in
1145 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1147 * src/maemo/modest-address-book.c:
1148 (modest_address_book_check_names):
1149 * src/maemo/modest-msg-view-window.c:
1150 (modest_msg_view_window_clipboard_owner_change):
1151 * src/modest-init.c: (modest_init_init_ui):
1152 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1153 (update_folders_cb), (modest_mail_operation_update_account):
1154 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1155 (modest_ui_actions_on_msg_attachment_clicked),
1156 (modest_ui_actions_on_msg_recpt_activated):
1157 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1158 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1159 (modest_msg_view_search_next):
1160 * src/widgets/modest-recpt-editor.c:
1161 (modest_recpt_editor_on_button_release_event),
1162 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1163 g_message(). At this point we should only be seeing interesting errors on
1164 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1166 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1168 (modest_wizard_dialog_force_title_update):
1169 * src/maemo/easysetup/modest-wizard-dialog.h:
1170 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1171 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1172 can update the title when appropriate. Otherwise the title is wrong if the
1173 pages are added after adding the notebook to the dialog.
1174 This must be a problem in HildonWizardDialog too.
1175 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1177 * src/maemo/easysetup/modest-easysetup-wizard.c:
1178 (create_subsequent_customsetup_pages),
1179 (create_subsequent_easysetup_pages):
1180 Call modest_wizard_dialog_force_title_update() so that the title is
1181 correct even with GTK+ < 2.10.
1182 This fixes projects.maemo.org bug NB#56145 .
1184 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1186 * src/maemo/modest-platform.c:
1187 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1188 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1191 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1193 * src/widgets/modest-window.h:
1194 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1195 and modest_window_save_state(), which invokes it.
1197 * src/widgets/modest-window-mgr.h:
1198 * src/widgets/modest-window-mgr.c:
1199 Added modest_window_mgr_save_state_for_all_windows(), which calls
1200 the save_state vfunc on all registered windows, if implemented.
1202 * src/gnome/modest-msg-edit-window.c:
1203 * src/gnome/modest-msg-view-window.c:
1204 * src/maemo/modest-msg-edit-window.c:
1205 * src/maemo/modest-msg-view-window.c:
1206 * src/maemo/modest-main-window.c:
1207 Specify the existing save_settings functions as implementations of
1208 ModestWindow::save_state_func().
1210 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1211 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1212 enabling hibernation, for instance.
1214 We may need to do the same thing for restoring settings.
1217 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1219 * src/widgets/modest-window-mgr.c:
1220 * src/widgets/modest-window-mgr.h:
1221 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1222 modest_window_mgr_get_hibernation_is_prevented().
1224 * src/maemo/modest-main-window.c:
1225 (on_hildon_program_is_topmost_notify): Prevent hibernation
1226 (possible when the application goes to the background in the WM),
1227 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1229 * src/maemo/easysetup/modest-easysetup-wizard.c:
1230 (modest_easysetup_wizard_dialog_init):
1231 * src/maemo/modest-account-settings-dialog.c:
1232 (modest_account_settings_dialog_init):
1233 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1234 (modest_connection_specific_smtp_edit_window_init):
1235 * src/maemo/modest-connection-specific-smtp-window.c:
1236 (modest_connection_specific_smtp_window_init):
1237 * src/maemo/modest-signature-editor-dialog.c:
1238 (modest_signature_editor_dialog_init):
1239 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1240 prevent hibernation while any of these account settings dialogs are open.
1242 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1244 * src/maemo/Makefile.am:
1245 * src/maemo/modest-osso-state-saving.c:
1246 * src/maemo/modest-osso-state-saving.h: Added
1247 modest_osso_load_state() and modest_osso_save_state() though they do
1248 nothing now. They should iterate through all the open windows and load/save
1250 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1251 save state when closing.
1253 * src/maemo/modest-main-window.c:
1254 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1255 Add a notification handler for the HildonProgram::is-topmost property,
1256 so we can allow hibernation when the application goes into the background.
1257 But we still need to detect when the accounts setup windows are open so
1258 we can stop hibernation when they are open.
1259 To do this, I also added the main window the HildonProgram. This might have
1260 other side-effects/benefits, and should maybe be done for other windows.
1262 * src/maemo/modest-osso-autosave-callbacks.h:
1263 * src/maemo/modest-osso-autosave-callbacks.c:
1264 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1265 though it does not do anything yet, and we might never need this to do
1266 anything. For instance, we already save drafts.
1268 * src/maemo/modest-platform.c: (modest_platform_init):
1269 Specify the libosso auto-save callback.
1271 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1273 * src/maemo/modest-platform.c:
1274 (modest_platform_set_update_interval):
1275 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1276 aparently stays valid between application instances, so we can use this
1277 to remove and reset it later. According to a maemo-developers email from
1280 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1282 * configure.ac: Depend on libalarm for Maemo.
1284 * src/dbus_api/modest-dbus-api.h:
1285 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1286 (on_send_receive), (modest_dbus_req_handler):
1287 Handle a SEND_RECEIVE D-Bus method.
1289 * libmodest-dbus-client/libmodest-dbus-client.c:
1290 (libmodest_dbus_client_send_and_receive):
1291 * libmodest-dbus-client/libmodest-dbus-client.h:
1292 Add C convenience functions for calling the new D-Bus method.
1294 * src/modest-platform.h:
1295 * src/gnome/modest-platform.c:
1296 * src/maemo/modest-platform.c:
1297 Added modest_platform_set_update_interval(), which uses the
1298 alarmd API on Maemo.
1299 (modest_platform_init),
1300 Call modest_platform_set_update_interval(), using a hard-coded
1301 interval for now (until the global settings dialog is implemented),
1302 though I am not sure that this makes sense yet.
1304 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1306 * src/dbus_api/modest-dbus-callbacks.c:
1307 (modest_osso_cb_hw_state_handler):
1308 * src/dbus_api/modest-dbus-callbacks.h:
1309 * src/maemo/modest-platform.c: (modest_platform_init):
1310 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1311 in case this has some effect on the ability for Maemo to ping the
1314 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1316 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1317 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1318 warning. It is probably a logic error, but I need to fix the build.
1320 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1322 * src/modest-account-mgr.h:
1323 * src/modest-account-mgr.c:
1324 (modest_account_mgr_account_names): Add a gboolean enabled_only
1325 parameter, so we can get lists of onlt the enabled accounts.
1327 (modest_account_mgr_add_account),,
1328 (modest_account_mgr_account_with_display_name_exists):
1329 * src/maemo/modest-msg-edit-window.c: (get_transports):
1330 * src/modest-account-mgr-helpers.c:
1331 (modest_account_mgr_set_first_account_as_default):
1332 * src/modest-init.c: (init_default_account_maybe):
1333 * src/modest-tny-account-store.c: (get_accounts):
1334 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1335 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1336 * tests/check_account-mgr.c: (START_TEST):
1337 Provide the extra parameter, as appropriate.
1339 * src/widgets/modest-account-view.c: (update_account_view):
1340 Do not show disabled accounts (meaning that there is no way to
1341 enable/disable accounts in the UI (the feature is not in our UI
1342 specification), so we can use this internally only to mark unfinished
1343 or temporary account data.
1345 * src/maemo/easysetup/modest-easysetup-wizard.c:
1346 (create_account): Add boolean enable parameter, so we can specify FALSE
1347 to create the temporary account.
1348 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1349 (on_before_next): When finishing, when there is a temporary account, just
1351 Also, use a timeout to delay the showing of the dialog until gconf is likely
1352 to return correct information, due to a maemo gconf bug that is fixed in
1353 osso 1.1, but not yet in Bora.
1354 However, the dialog stays on screen after it is destroyed.
1356 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1357 for invalid data when cancelling. Use a hildon note instead of a dialog
1358 to complain about invalid data. Do not show the account-saved note if the
1359 account is disabled (a temporary account that will not really be saved for use
1362 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1364 * src/modest-account-mgr-helpers.h:
1365 * src/modest-account-mgr-helpers.c:
1366 Added modest_account_mgr_unset_default_account(),
1367 Added modest_account_mgr_set_first_account_as_default().
1369 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1370 If it was the default account, unset the default account name.
1372 * src/maemo/modest-account-view-window.c:
1373 (on_delete_button_clicked): If it was the default account,
1374 set the first remaining account as the default instead.
1376 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1377 a NULL account or a NULL default account, to prevent a crash. This should
1378 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1381 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1383 * src/widgets/modest-recpt-editor.c:
1384 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1385 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1386 TODO comment for this. This fixes the build.
1388 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1389 be the best place for it. This will in future update all auto-update accounts,
1390 rather than just the current/default account, when that gconf key exists.
1391 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1392 if there are no accounts, before calling do_send_receive().
1393 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1395 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1396 * src/maemo/modest-main-window-ui.h:
1397 * src/maemo/modest-main-window.c: (on_connection_changed),
1398 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1399 directly, becaue the signal handler does more.
1401 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1403 * src/modest-account-mgr-helpers.c:
1404 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1405 for the case that the account does not exist.
1407 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1408 (equivalent to the modest account name) rather than the tinymail account name
1409 (equivalent to the modest account title - human readable) to get the account data.
1410 Check for null account data to prevent the crash, and add a TODO comment saying that
1411 this needs fixing because it is using the server account name instead of the account name.
1413 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1415 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1416 * src/maemo/modest-account-settings-dialog.c: (show_error),
1418 Use hildon_note_new_information() for informative and error messages,
1419 which seems to be expected for Maemo applications (no documentation that I know of
1420 says this). I am surprised that there is no distinction between info and error
1423 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1425 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1426 it is easy to find where this is used.
1428 * src/maemo/easysetup/modest-easysetup-wizard.c:
1429 (create_page_welcome), (create_page_account_details),
1430 (create_page_user_details), (create_page_complete_easysetup),
1431 (create_page_custom_incoming), (create_page_custom_outgoing),
1432 (create_page_complete_custom):
1433 * src/maemo/modest-account-settings-dialog.c:
1434 (create_page_account_details), (create_page_user_details),
1435 (create_page_incoming), (create_page_outgoing):
1436 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1437 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1438 (modest_connection_specific_smtp_edit_window_init):
1439 * src/maemo/modest-connection-specific-smtp-window.c:
1440 (modest_connection_specific_smtp_window_init):
1441 * src/maemo/modest-signature-editor-dialog.c:
1442 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1443 and scrolling policy as per the Email Application Layout Guide, if I have
1446 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1448 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1449 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1450 which were empty, because these vfuncs have been removed from TnyAccountStore.
1451 This fixes the build.
1453 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1455 * src/maemo/modest-main-window.c:
1456 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1457 showing/hiding it. Added TODO because it probably should not be NULL.
1458 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1459 because unnecessary g_warnings() make degugging difficult.
1461 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1463 * src/maemo/modest-msg-edit-window.c:
1464 (modest_msg_edit_window_select_color),
1465 (modest_msg_edit_window_select_background_color): 2 const corrections and
1466 moving 2 #endifs before closing brackets, to fix the build.
1468 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1470 * src/maemo/easysetup/modest-easysetup-wizard.h:
1471 * src/maemo/easysetup/modest-easysetup-wizard.c:
1472 (modest_easysetup_wizard_dialog_finalize),
1473 (on_button_edit_advanced_settings), (create_page_complete_custom),
1474 (on_response), (create_account):
1475 Implement the Advanced Settings edit button, by saving the account information,
1476 for the Advanded Settings dialog to use directly from gconf, and removing it
1477 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1478 Bug #5533 in the projects.maemo.org bugzilla.
1480 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1482 * src/maemo/modest-msg-view-window.c:
1483 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1484 when opening a message window.
1486 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1488 * src/maemo/easysetup/modest-easysetup-wizard.c:
1489 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1492 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1493 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1494 gconf settings. I probably added more checks than necessary, but that is safer.
1496 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1497 variable to fix the build, but this seems to be used when it is still NULL.
1499 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1501 * src/modest-platform.h:
1502 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1503 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1504 * src/modest-main.c: Implement this function so we can avoid using
1505 maemo-specific API from cross-platform code.
1507 * src/modest-tny-account-store.c:
1508 (get_smtp_specific_transport_account_for_open_connection):
1509 * src/modest-ui-actions.c: (check_for_connection),
1510 (modest_ui_actions_on_item_not_found):
1511 Use modest_platform_connect_and_wait() and put #idefs around other
1512 maemo-specific code, because only maemo currently has a way to
1513 identify connection names.
1515 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1517 * src/modest-tny-account-store.h:
1518 * src/modest-tny-account-store.c:
1519 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1520 the connection-specific SMTP server settings in the configuration.
1522 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1524 * src/maemo/modest-main-window.c: (on_connection_changed),
1526 * src/modest-main.c: (main), (start_ui), (send_mail):
1527 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1528 that is what is intended.
1530 * src/modest-ui-actions.c: (action_send), (action_receive),
1531 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1532 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1533 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1534 SMTP server is used when it is specified.
1536 (modest_ui_actions_on_send_receive):
1537 Check that a connection is open before proceeding.
1538 Receive and then send, instead of vice-versa, as per the specification.
1540 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1542 * src/modest-mail-operation.c:
1543 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1544 though I guess it should be something other than NULL.
1546 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1548 * src/maemo/easysetup/modest-easysetup-wizard.c:
1549 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1550 combo twice, to avoid an g_warning and to make it visible again.
1551 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1552 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1553 (already intended) dereference when detaching, because we then recreate the menu.
1554 But I am not sure why the warning was happening, and it is possible that this is a memory
1557 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1559 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1560 and uri_parse_mailto() utility functions.
1561 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1563 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1565 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1567 * src/dbus_api/modest-dbus-api.h:
1568 * src/dbus_api/modest-dbus-callbacks.c:
1569 Use an idle callback to execute the modest code in the application's own thread.
1570 Remove the helloworld example method.
1571 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1572 parsed, and the open-message method is not implemented because this is not yet implemented in
1574 * libmodest-dbus-client/libmodest-dbus-client.c:
1575 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1576 (libmodest_dbus_client_open_message):
1577 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1579 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1580 body without crashing.
1582 * tests/dbus_api/Makefile.am:
1583 * tests/dbus_api/test_mail_to.c:
1584 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1586 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1588 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1589 Added file to fix the build. Sorry.
1591 * src/dbus_api/Makefile.am:
1592 * src/dbus_api/modest-dbus-api.h:
1593 * src/dbus_api/modest-dbus-callbacks.h:
1594 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1595 (modest_dbus_req_handler):
1596 Put constants in a separate header so it can be reused by the
1597 client library, without duplication
1599 * libmodest-dbus-client/Makefile.am:
1600 * libmodest-dbus-client/libmodest-dbus-client.c:
1601 (libmodest_dbus_client_call_helloworld),
1602 (libmodfest_dbus_client_send_mail),
1603 (libmodfest_dbus_client_mailto),
1604 (libmodfest_dbus_client_open_message):
1605 * libmodest-dbus-client/libmodest-dbus-client.h:
1606 (Partly) Implement a send_mail D-Bus method.
1608 * tests/dbus_api/Makefile.am:
1609 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1610 the send_email D-Bus method.
1612 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1616 * libmodest-dbus-client/Makefile.am:
1617 * libmodest-dbus-client/libmodest-dbus-client.c:
1618 * libmodest-dbus-client/libmodest-dbus-client.h:
1619 * tests/dbus_api/Makefile.am:
1620 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1621 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1623 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1625 * src/maemo/easysetup/modest-easysetup-wizard.c:
1626 (create_page_account_details):
1627 * src/maemo/modest-account-settings-dialog.c:
1628 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1629 widgets, because this might not be the default in future versions of the Maemo GTK+.
1630 However, I can not not get capitalization to work even in a simple test case.
1632 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1634 * src/maemo/easysetup/modest-easysetup-wizard.c:
1635 (create_page_custom_incoming), (create_page_custom_outgoing):
1636 * src/maemo/modest-account-settings-dialog.c:
1637 (create_page_account_details), (create_page_incoming),
1638 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1639 instead of using gtk_check_button_with_label(), so they are aligned like the other
1640 widgets, as per the UI spec.
1642 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1644 * src/maemo/easysetup/modest-easysetup-wizard.c:
1645 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1646 * src/widgets/modest-validating-entry.c:
1647 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1648 Modest prefix instead of an EasySetup prefix.
1650 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1652 * src/widgets/modest-validating-entry.h:
1653 * src/widgets/modest-validating-entry.c: (on_insert_text),
1654 Added easysetup_validating_entry_set_max_func(), used to set a callback
1655 to call when the max number of characters is reached. GtkEntry has a max-length
1656 already but is silent about it.
1658 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1659 (create_page_account_details), (create_page_user_details),
1661 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1662 (create_page_account_details), (create_page_user_details),
1663 (create_page_outgoing):
1664 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1665 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1666 the UI spec, when the user tries to enter more than the max number of characters.
1668 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1670 * src/maemo/easysetup/modest-easysetup-wizard.c:
1671 (create_page_user_details), (create_page_custom_incoming),
1672 (create_page_custom_outgoing):
1673 * src/maemo/modest-account-settings-dialog.c:
1674 (create_page_user_details), (create_page_incoming),
1675 (create_page_outgoing):
1676 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1677 (modest_connection_specific_smtp_edit_window_init):
1678 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1679 not appropriate. Bad Maemo-specific defaults!.
1681 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1683 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1684 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1685 (modest_signature_editor_dialog_set_settings):
1686 Disable the label and textview when the checkbox is disabled, and use the
1687 specified (UI spec) default signature text.
1689 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1691 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1692 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1694 * src/modest-defs.h:
1695 * src/modest-account-mgr-helpers.h:
1696 * src/modest-account-mgr-helpers.c:
1697 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1699 * src/maemo/Makefile.am:
1700 * src/maemo/modest-signature-editor-dialog.c:
1701 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1704 * src/maemo/modest-account-settings-dialog.h:
1705 * src/maemo/modest-account-settings-dialog.c:
1706 (modest_account_settings_dialog_finalize), (on_button_signature),
1707 (save_configuration): Use the new dialog when the Edit button is pressed, and
1708 save the changes if necessary, as per the UI spec.
1710 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1712 * src/maemo/Makefile.am:
1713 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1714 based on maemo-develoers email from Dirk.
1716 * src/maemo/easysetup/modest-easysetup-wizard.c:
1717 (create_page_welcome), (create_page_account_details),
1718 (create_page_user_details), (create_page_complete_easysetup),
1719 (create_page_custom_incoming), (create_page_custom_outgoing),
1720 (create_page_complete_custom),
1721 (modest_easysetup_wizard_dialog_init):
1722 * src/maemo/modest-account-settings-dialog.c:
1723 (create_page_account_details), (create_page_user_details),
1724 (create_page_incoming), (create_page_outgoing),
1725 (modest_account_settings_dialog_init):
1726 * src/maemo/modest-connection-specific-smtp-window.c:
1727 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1729 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1731 * src/maemo/easysetup/modest-easysetup-wizard.c:
1732 (create_page_account_details), (create_page_custom_outgoing),
1733 (create_page_complete_custom):
1734 * src/maemo/modest-account-settings-dialog.c:
1735 (create_page_user_details), (create_page_incoming),
1736 (create_page_outgoing):
1737 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1738 (modest_connection_specific_smtp_edit_window_init):
1739 Use the correct (UI spec) port min/max, and use horizontal separators,
1742 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1744 * src/maemo/easysetup/modest-easysetup-wizard.c:
1745 (set_default_custom_servernames):
1746 * src/maemo/modest-account-settings-dialog.c:
1747 (create_page_incoming), (on_combo_outgoing_security_changed),
1748 (on_combo_incoming_security_changed), (create_page_outgoing),
1749 (modest_account_settings_dialog_set_account_name),
1750 (save_configuration):
1751 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1752 (on_combo_security_changed),
1753 (modest_connection_specific_smtp_edit_window_init),
1754 (modest_connection_specific_smtp_edit_window_set_connection),
1755 (modest_connection_specific_smtp_edit_window_get_settings):
1756 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1759 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1762 * src/maemo/easysetup/modest-easysetup-wizard.c:
1763 (create_page_custom_outgoing), (create_page_complete_custom):
1764 * src/maemo/modest-account-settings-dialog.c:
1765 (create_page_user_details), (create_page_outgoing):
1766 * src/maemo/modest-account-view-window.c: (button_box_new):
1767 Use changed logical IDs as per the most recent UI spec:
1768 mcen_bd_emailsetup_edit -> mcen_bd_edit
1769 mcen_bd_emailsetup_delete -> mcen_bd_delete
1770 mcen_bd_emailsetup_close -> mcen_bd_close
1772 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1776 * src/dbus_api/Makefile.am:
1777 * src/dbus_api/modest-dbus-callbacks.c:
1778 * src/dbus_api/modest-dbus-callbacks.h:
1779 * src/maemo/modest-platform.c: (modest_platform_init):
1780 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1782 * tests/Makefile.am:
1783 * tests/dbus_api/Makefile.am:
1784 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1786 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1788 * src/maemo/modest-account-settings-dialog.c:
1789 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1790 Removed unnecessary includes.
1792 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1794 * src/maemo/easysetup/modest-easysetup-wizard.c:
1795 * src/maemo/modest-account-settings-dialog.c:
1796 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1797 * src/widgets/Makefile.am:
1798 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1799 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1800 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1801 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1802 * src/widgets/modest-secureauth-combo-box.c:
1803 * src/widgets/modest-secureauth-combo-box.h:
1804 * src/widgets/modest-serversecurity-combo-box.c:
1805 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1806 made the GObject names more consistent with the rest of the Modest code.
1808 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1810 * src/maemo/easysetup/Makefile.am:
1811 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1812 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1813 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1814 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1815 * src/maemo/easysetup/modest-easysetup-wizard.c:
1816 * src/maemo/easysetup/modest-validating-entry.c:
1817 * src/maemo/easysetup/modest-validating-entry.h:
1818 * src/maemo/modest-account-settings-dialog.c:
1819 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1820 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1821 widgets/ because they are used outside of easysetup too. After checking in,
1822 svn will allow me to rename them too.
1824 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1826 * src/gnome/modest-msg-edit-window.c:
1827 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1828 linker error, to fix the build on the GNOME platform.
1829 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1830 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1831 ifdefed out to avoid a warning.
1833 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1835 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1836 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1837 some alternative for GTK+ 2.6.
1839 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1841 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1843 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1844 specified for EmailAccountsDialog in UI spec.
1846 * src/maemo/easysetup/modest-easysetup-wizard.c:
1847 * src/maemo/easysetup/modest-easysetup-wizard.h:
1848 * src/maemo/modest-account-settings-dialog.c:
1849 * src/maemo/modest-account-settings-dialog.h:
1850 Reuse a member window widget for the connection-specific SMTP server accounts,
1851 so we can tell it to create/save the accounts only if we actually save changes.
1853 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1854 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1855 (modest_connection_specific_smtp_edit_window_get_settings):
1856 Return a struct instance for temporarily remembering the entered data.
1858 * src/maemo/modest-connection-specific-smtp-window.h:
1859 * src/maemo/modest-connection-specific-smtp-window.c:
1860 (modest_connection_specific_smtp_window_finalize),
1861 (modest_connection_specific_smtp_window_fill_with_connections),
1863 (modest_connection_specific_smtp_window_save_server_accounts),
1864 (update_model_server_names): Do not actually save data until asked,
1865 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1867 (on_selection_changed),
1868 (modest_connection_specific_smtp_window_init): Disable the edit
1869 button when nothing is selected.
1871 * src/modest-account-mgr-helpers.c:
1872 * src/modest-account-mgr-helpers.h:
1873 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1876 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1878 * src/modest-account-mgr-helpers.h:
1879 * src/modest-account-mgr-helpers.c:
1880 (modest_account_mgr_get_unused_account_name),
1881 (modest_account_mgr_get_unused_account_display_name): Added these
1882 utility functions, to avoid code duplication.
1884 * src/maemo/easysetup/modest-easysetup-wizard.c:
1885 (create_page_account_details), (create_account):
1886 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1887 (on_combo_security_changed),
1888 (modest_connection_specific_smtp_edit_window_init),
1889 (modest_connection_specific_smtp_edit_window_save_settings):
1890 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1891 * src/maemo/modest-connection-specific-smtp-window.c:
1892 (modest_connection_specific_smtp_window_finalize),
1893 (modest_connection_specific_smtp_window_fill_with_connections),
1894 (on_button_edit), (modest_connection_specific_smtp_window_init):
1895 * src/maemo/modest-connection-specific-smtp-window.h:
1896 Implementing saving of connection-specific server accounts.
1898 But I need to refactor this so we can save the data for each
1899 possible connection-specific account and only actually create the server accounts
1900 when the easysetup finished, or the OK button is pressed on the account settings
1903 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1905 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1906 (on_combo_security_changed):
1907 (modest_connection_specific_smtp_edit_window_init):
1908 Auto-fill the port number as in the account settings.
1910 (modest_connection_specific_smtp_edit_window_set_connection):
1911 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1912 * src/maemo/modest-connection-specific-smtp-window.c:
1913 (fill_with_connections), (on_button_edit),
1914 (modest_connection_specific_smtp_window_init):
1915 Turn the edit window into a dialog to simplify the code, and
1916 set a WM hint as in a GtkDialog, because only a popup can be on top of
1917 another window in Maemo, and popups usually have no WM decoration.
1919 * src/modest-defs.h:
1920 * src/modest-account-mgr-helpers.c:
1921 (modest_account_mgr_set_connection_specific_smtp),
1922 (modest_account_mgr_remove_connection_specific_smtp),
1923 (modest_account_mgr_get_connection_specific_smtp):
1924 * src/modest-account-mgr-helpers.h: Some functions to write the
1925 connection-specific SMTP server information. Not yet used.
1928 * src/widgets/modest-folder-view.c: (text_cell_data):
1929 Fix a warning about an uninitialized variable.
1930 (on_configuration_key_changed): Put an #ifdef around the use
1931 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1933 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1935 * src/maemo/modest-account-settings-dialog.h:
1936 * src/maemo/modest-account-settings-dialog.c:
1937 Added connect_for_modified() utility function to mark the new modified boolean.
1939 (create_page_account_details), (create_page_user_details),
1940 (create_page_incoming), (create_page_outgoing), (on_response),
1941 (modest_account_settings_dialog_init),
1942 (modest_account_settings_dialog_set_account_name):
1943 Only warn about unsaved changes when there are actually unsaved changes.
1945 * src/modest-account-mgr-helpers.c:
1946 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1947 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1948 to get the data from there in future.
1950 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1952 * src/modest-defs.h:
1954 * src/modest-account-mgr-helpers.h:
1955 * src/modest-account-mgr-helpers.c:
1956 Store the security account setting in a single conf key instead of using
1957 the options list, so that the list is left for just the to-be-removed camel hack,
1958 and because gconf_client_set_list() is failing for some reason.
1960 * src/modest-account-mgr.c:
1961 (modest_account_mgr_add_server_account):
1962 * src/maemo/modest-account-settings-dialog.c:
1963 (modest_account_settings_dialog_set_account_name),
1964 (save_configuration): Use the renamed functions.
1967 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1969 * src/widgets/Makefile.am:
1970 * src/widgets/modest-limit-retrieve-combo-box.c:
1971 * src/widgets/modest-limit-retrieve-combo-box.h:
1972 * src/widgets/modest-retrieve-combo-box.c:
1973 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1974 the account settings dialog.
1976 * src/modest-defs.h:
1977 * src/modest-account-mgr-helpers.h:
1978 * src/modest-account-mgr-helpers.c:
1979 (modest_server_account_get_option_secure_auth),
1980 (modest_server_account_set_option_secure_auth):
1981 * src/modest-account-mgr.c:
1982 (modest_account_mgr_add_server_account):
1983 Use the existing AUTH_MECH conf key for the secure-auth setting,
1984 instead of putting it in the list options, because this was actually used already.
1986 * src/maemo/modest-account-settings-dialog.c:
1987 (create_page_account_details),
1988 (modest_account_settings_dialog_set_account_name),
1989 (save_configuration):
1990 * src/maemo/modest-account-settings-dialog.h:
1991 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1992 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1994 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1996 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1997 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1998 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2000 * src/modest-defs.h:
2001 * src/maemo/modest-account-settings-dialog.c:
2002 (create_page_incoming), (on_combo_outgoing_security_changed),
2003 (on_combo_incoming_security_changed), (create_page_outgoing),
2004 (modest_account_settings_dialog_set_account_name),
2005 (save_configuration): Load/Save the port number, and change it when the
2006 security combo changes, to suitable defaults.
2008 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2010 * src/modest-account-mgr.c:
2011 (modest_account_mgr_add_server_account): Set the security and secure-auth
2012 options, and add a comment saying that the other camel-specific options should be
2015 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2017 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2019 * src/modest-tny-account-store.c: (account_list_free),
2020 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2021 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2024 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2026 * src/modest-protocol-info.c:
2027 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2028 is required by our UI spec. Maybe something in our implementation will use this eventually.
2029 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2030 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2031 instead of the previous 0 placeholder.
2033 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2034 secure-auth settings.
2035 * src/modest-account-mgr-helpers.h:
2036 * src/modest-account-mgr-helpers.c:
2037 (modest_server_account_data_get_option_secure_auth),
2038 (modest_server_account_set_option_secure_auth),
2039 (modest_server_account_data_get_option_security),
2040 (modest_server_account_set_option_security): Added this API for getting and setting the security
2041 and secure-auth settings.
2043 * src/maemo/modest-account-settings-dialog.h:
2044 * src/maemo/modest-account-settings-dialog.c:
2045 (modest_account_settings_dialog_finalize), (check_data),
2046 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2047 about changing titles.
2048 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2049 (save_configuration): Save the security and secure-auth settings.
2051 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2052 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2054 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2056 * src/modest-defs.h:
2057 * src/modest-account-mgr.c:
2058 (modest_account_mgr_add_server_account):
2059 Added and used defines for the options key and value pair strings,
2060 that are used so far, though they do not seem to correspond to anything in our
2061 UI specs or ModestProtocol enum.
2063 * src/modest-account-mgr-helpers.h:
2064 * src/modest-account-mgr-helpers.c:
2065 (compare_option_strings_for_name),
2066 (modest_server_account_data_get_option_value),
2067 (modest_server_account_data_get_option_bool),
2068 (modest_account_mgr_get_server_account_option):
2069 Added helper functions for parsing the options GSList.
2071 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2073 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2074 display name is based on the supplied account name.
2075 * src/modest-account-mgr.c:
2076 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2077 with an inefficient, but good-enough, implementation.
2079 * src/maemo/easysetup/modest-easysetup-wizard.c:
2080 (create_page_account_details), (on_before_next), (create_account):
2081 Check for existing display names rather than (non-user-visible) account names, and just
2082 create and set a unique account name at the end.
2084 * src/maemo/modest-account-settings-dialog.c:
2085 (modest_account_settings_dialog_init),
2086 (modest_account_settings_dialog_set_account_name),
2087 (create_page_incoming): Show the display name, instead of the account name.
2088 (on_response): Do some (not all) extra checks, as in the UI spec.
2089 (save_configuration): Save the display name if it was changed.
2091 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2093 * po/en_GB.po: Added needed logical ID and translation.
2094 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2095 (init_view): Made the is-default column clicking work.
2097 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2100 * src/maemo/easysetup/Makefile.am:
2101 * src/maemo/easysetup/modest-easysetup-wizard.c:
2102 (modest_easysetup_wizard_dialog_init):
2103 * src/maemo/easysetup/provider-data-test.keyfile:
2104 * src/maemo/easysetup/provider-data.keyfile:
2105 Moved the provider data file to the new modest-providers-data package and used it from there.
2107 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2109 * src/modest-local-folder-info.c:
2110 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2111 N_() was already used on the static strings, but this just marks it for translation without
2112 using the translation.
2114 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2116 * src/maemo/modest-account-settings-dialog.c:
2117 (create_page_incoming),
2118 (modest_account_settings_dialog_set_account_name):
2119 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2120 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2121 I will do this if nobody else gets there first.
2123 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2125 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2126 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2127 save the security stuff.
2129 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2131 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2132 Set the email address and user fullname, which I now see must be
2135 * src/maemo/modest-account-settings-dialog.h:
2136 * src/maemo/modest-account-settings-dialog.c:
2138 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2139 leave-on-server and authentication.
2140 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2143 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2146 * src/maemo/modest-account-settings-dialog.c:
2147 * src/maemo/modest-account-settings-dialog.h:
2148 Most (but not all) of the widgets are now present as specified by the UI spec.
2149 No changes are yet saved, and some details are not properly shown yet.
2151 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2153 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2155 * src/maemo/Makefile.am:
2156 * src/maemo/modest-account-settings-dialog.c:
2157 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2158 an existing account. Doesn't do much yet.
2160 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2161 Open the accounts settings dialog when Edit is clicked.
2163 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2165 * src/maemo/easysetup/Makefile.am:
2166 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2168 * src/maemo/easysetup/modest-easysetup-wizard.c:
2169 (modest_easysetup_wizard_dialog_init):
2170 Try to get the source directory from the build system,
2171 instead of hard-coding "./" into the source code, when opening our local
2172 copies of the configuration files.
2173 But this still fails when opening the wizard from the Accounts window,
2174 maybe because the working directory seems to change at runtime.
2175 So the wizard will fail the second time unless you copy the files into their
2176 proper locations - see the stdout warnings for the paths.
2178 (create_page_account_details),(on_before_next):
2179 Check for existing non-server accounts instead of server accounts,
2180 so the default account name is useful again, and to prevent trying to
2183 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2184 Show the wizard when New is clicked.
2186 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2187 (init_view): Show the column headers, and show the columns that are
2188 specified in the UI specs. However, something in Maemo's GTK+ prevents
2189 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2190 change the default account. This is despite unsetting the special properties.
2192 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2194 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2195 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2196 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2197 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2198 to make that clearer.
2199 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2201 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2203 * src/maemo/modest-account-view-window.c:
2204 (modest_account_view_window_init),
2205 (modest_account_view_window_new):
2206 Use the same buttons as specified in the
2207 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2208 the existing widgets, which never had a chance of working.
2209 Put the ModestAccountView treeview in a scrolled window.
2210 Do not repeat the initialization in both _init() and _new().
2212 * src/widgets/modest-account-view.c: (update_account_view):
2213 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2214 this widget and window shows no accounts.
2216 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2218 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2220 * src/maemo/easysetup/modest-easysetup-wizard.c:
2221 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2222 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2223 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2226 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2227 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2228 accounts exist yet, as in the UI spec.
2230 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2232 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2234 * src/maemo/Makefile.am:
2235 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2236 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2237 New window for editing connection-specific smtp details.
2238 Not fully implemented.
2240 * src/maemo/modest-connection-specific-smtp-window.c:
2241 (modest_connection_specific_smtp_window_finalize) :
2242 unref the tree model.
2243 (on_button_edit): Show the edit window.
2245 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2247 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2250 * src/maemo/Makefile.am:
2251 * src/maemo/modest-connection-specific-smtp-window.c:
2252 * src/maemo/modest-connection-specific-smtp-window.h:
2253 New window for showing the list of connections, for connection-specific
2254 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2255 * src/maemo/easysetup/modest-easysetup-wizard.c:
2256 (create_page_custom_outgoing): Show the new window when the button is clicked.
2258 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2260 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2261 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2262 * src/maemo/modest-msg-edit-window.c:
2263 (modest_msg_edit_window_insert_image):
2264 * src/modest-conf.c: (modest_conf_key_escape):
2265 * src/modest-mail-operation.c:
2266 (modest_mail_operation_send_new_mail):
2267 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2268 (modest_ui_actions_on_new_account):
2269 * src/widgets/modest-attachment-view.c: (update_filename_request):
2270 * src/widgets/modest-mail-header-view.c:
2271 Corrected warnings that were breaking the build, by commenting out unused variables,
2272 and a function, and by including a header.
2274 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2276 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2277 so we can #ifdef around platform-specific code when necessary.
2278 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2279 to allow this to build for the GNOME platform too.
2281 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2283 * src/maemo/easysetup/modest-easysetup-wizard.c:
2284 Added util_increment_name() and used it in create_page_account_details()
2285 to make sure that the default account name is always a new name.
2287 (modest_easysetup_wizard_dialog_init),
2288 (set_default_custom_servernames): Some minor memory management fixes.
2290 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2294 * src/modest-runtime.c: (init_i18n): Restored the translation
2295 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2296 are defined in config.h, and the translations are installed.
2298 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2299 is defined for translation.
2301 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2303 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2305 * src/maemo/easysetup/modest-easysetup-wizard.c:
2306 (modest_easysetup_wizard_dialog_init):
2307 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2308 Use realistic paths (though they should use $prefix generically) to the
2309 mcc_mapping and provider-data.keyfile files which might work when they
2310 are installed by the future version of the operator-wizard package,
2311 and then fallback to paths in our source code, with an explanatory
2314 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2318 * src/maemo/Makefile.am:
2319 * src/maemo/easysetup/: Added files from the previously-exernal
2320 osso-modest-easysetup.
2321 * src/maemo/modest-main-window-ui.h:
2322 * src/modest-ui-actions.c:
2323 * src/modest-ui-actions.h:
2324 Added modest_ui_actions_on_new_account() as a signal handler for the
2325 New Account menu item. It shows the easysetup wizard.
2326 * po/en_GB.po: Added additional needed logical IDs and translations.
2328 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2329 Apparently ChangeLog is not used for some vague Nokia legal reasons.