1 2007-06-08 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-mail-operation.c:
4 (modest_mail_operation_send_new_mail):
5 Added a comment about a nasty but apparently harmless message. Details
6 added to the wiki g_warnings() page.
8 2007-06-08 Murray Cumming <murrayc@murrayc.com>
10 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
11 (modest_tny_send_queue_class_init):
12 Do not use the priv struct because it is empty, to avoid g_warnings
13 about a non-existant priv struct.
15 * src/modest-tny-account-store.c:
16 (modest_tny_account_store_get_server_account),
17 (modest_tny_account_store_get_transport_account_for_open_connection
18 ): Do not try to get transport server accounts for local folders,
19 because they don't have any. This avoids a g_warning().
21 * src/maemo/modest-main-window.c:
22 (modest_main_window_notify_send_receive_initied),
23 (on_configuration_key_changed):
24 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
26 * src/modest-mail-operation.c:
27 (modest_mail_operation_update_account):
28 * src/modest-tny-account-store.h:
29 * src/modest-tny-account.c:
30 (modest_tny_account_get_special_folder),
31 (modest_tny_account_new_for_local_folders),
32 (modest_tny_account_new_for_per_account_local_outbox_folder):
33 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
34 * src/modest-tny-local-folders-account.c:
35 (add_account_folders_to_merged_folder):
36 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
37 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
38 (modest_ui_actions_on_send):
39 * src/widgets/modest-folder-view.c: (update_model):
40 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
41 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
42 modest_tny_account_store_get_tny_account_by_account() to
43 modest_tny_account_store_get_server_account() to make the code clearer.
45 2007-06-07 Marcus Bauer <marcusb@openismus.com>
47 * src/dbus_api/modest-dbus-api.h:
48 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
49 * src/maemo/modest-msg-edit-window.c:
50 (modest_msg_edit_window_attach_file_noninteractive):
51 added g_warning in case the file to be attached does not exist
52 * tests/dbus_api/test_compose_mail.c: (main):
53 removed obsolete comment, added generic files as test case
55 2007-06-07 Murray Cumming <murrayc@murrayc.com>
57 * src/modest-tny-account-store.c: (get_server_accounts):
58 Create the local folders account only once, not once for each outbox, and
59 not only when there are some outboxes.
61 2007-06-07 Murray Cumming <murrayc@murrayc.com>
63 * src/widgets/modest-folder-view.c: (update_model): Comment out some
64 code that is causing a crash at startup. Sergio says that he is fixing this.
66 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
68 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
69 * src/maemo/modest-account-settings-dialog.c:
70 (create_page_outgoing),
71 (modest_account_settings_dialog_set_account_name),
73 - Fixed handling of the "Use secure authentication" toggle to comply with
74 the ui specification. See also projects.maemo.org bug NB#58400
76 - Restore the Secure connection setting combo correctly when loading
79 * src/maemo/modest-maemo-utils.c:
80 (on_camel_account_get_supported_secure_authentication),
81 (modest_maemo_utils_get_supported_secure_authentication_methods):
82 Fixed a crasher if operation is canceled
84 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
85 (modest_protocol_info_auth_is_secure):
86 * src/modest-protocol-info.h:
88 Added two new methods to determine if a protocol/auth method is secure/encrypted in
89 the sense of the "Use secure authentication" toggle.
91 2007-06-07 Murray Cumming <murrayc@murrayc.com>
93 * src/modest-tny-account-store.h:
94 * src/modest-tny-account-store.c:
95 Added modest_tny_account_store_get_local_folders_account().
97 * src/modest-tny-folder.h:
98 * src/modest-tny-folder.c:
99 (modest_tny_folder_get_account):
100 Added this replacement for tny_folder_get_account() which returns
101 the local-folders account for TnyMergeFolders, to avoid the
102 warning about the unimplemented get_account_func() vfunc().
104 (modest_tny_folder_get_rules),
105 * src/modest-ui-actions.c:
106 (modest_ui_actions_on_folder_selection_changed):
107 * src/modest-mail-operation.c:
108 (modest_mail_operation_remove_folder),
109 (modest_mail_operation_xfer_folder),
110 (modest_mail_operation_rename_folder),
111 (modest_mail_operation_get_msg),
112 (modest_mail_operation_get_msgs_full),
113 (modest_mail_operation_remove_msg),
114 (modest_mail_operation_xfer_msgs),
115 (modest_mail_operation_refresh_folder):
116 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
118 2007-06-07 Murray Cumming <murrayc@murrayc.com>
120 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
121 (modest_server_account_set_security):
122 * src/modest-defs.h: Add comments explaining that our
123 UI spec means TLS when it says Normal, so these do not look like errors.
125 * src/modest-tny-account.c:
126 (modest_tny_account_new_from_server_account): Use the new tinymail
127 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
128 for TLS. This should fix projects.maemo.org bug NB#58460.
130 2007-06-06 Murray Cumming <murrayc@murrayc.com>
132 * src/maemo/easysetup/modest-easysetup-wizard.c:
133 (create_account): Correct the position of the gconf sanity check warning.
134 (on_button_edit_advanced_settings): Show the dialog immediately, instead
135 of using the g_idle_add() hack, because this does not seem to be necessary
136 on osso 1.1. It might even work on Maemo Bora if the problems were actually
137 caused by something other than maemo's gconf.
138 This fixes projects.maemo.org bug #59022.
140 2007-06-06 Murray Cumming <murrayc@murrayc.com>
142 * src/modest-account-mgr-helpers.c:
143 (modest_account_mgr_get_default_account): Do not check that the account
144 exists if there is no default account (NULL), to fix a runtime warning.
146 2007-06-06 Murray Cumming <murrayc@murrayc.com>
148 * src/widgets/modest-folder-view.c: (update_model):
149 Do not unref the treemodel before we have finished with it.
150 This prevents a valgrind warning and an occasional crash at startup.
152 2007-06-06 Marcus Bauer <marcusb@openismus.com>
154 * libmodest-dbus-client/libmodest-dbus-client.h:
155 added libmodest_dbus_client_compose_mail()
156 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
158 added functions needed for SendAsMail() functionality
159 * src/maemo/modest-msg-edit-window.c:
160 (modest_msg_edit_window_attach_file_noninteractive):
161 non interactively attaching files to message edit window
162 * src/widgets/modest-msg-edit-window.h:
163 * tests/dbus_api/Makefile.am:
164 added test_compose_mail.c
165 * tests/dbus_api/test_compose_mail.c: (main):
167 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
169 * src/modest-account-view.c:
170 Fixed bug projects.maemo.org bug NB#59307
172 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
174 * src/maemo/easysetup/modest-easysetup-wizard.c:
175 (get_serverport_incoming), (on_before_next), (create_account):
176 * src/maemo/modest-account-settings-dialog.c:
177 (modest_account_settings_dialog_set_account_name):
178 * src/maemo/modest-maemo-utils.c:
179 (on_camel_account_get_supported_secure_authentication_status),
180 (on_camel_account_get_supported_secure_authentication),
181 (on_secure_auth_cancel),
182 (modest_maemo_utils_get_supported_secure_authentication_methods):
184 Implemented security authentication for settings and easysetup.
186 2007-06-05 Murray Cumming <murrayc@murrayc.com>
188 * src/maemo/modest-main-window.c: (create_details_widget):
189 Show the total size for memory card accounts too, instead of showing
190 the name again. Fixes bug projects.maemo.org bug NB#59307.
192 2007-06-05 Murray Cumming <murrayc@murrayc.com>
195 * src/modest-tny-simple-folder-store.c:
196 * src/modest-tny-simple-folder-store.h: Removed.
198 * src/modest-tny-local-folders-account.h
199 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
200 for the local-folders maildir, with an extra TnyMergedFolder containing
201 the folders of the per-account outbox store accounts.
202 * src/modest-tny-account-store.c: (get_server_accounts):
203 Add the outboxes to the special local folders account after creating it.
205 * src/modest-tny-account.c:
206 (modest_tny_account_new_for_local_folders): Create the derived
207 account when creating the main local-folders account.
209 * src/maemo/modest-main-window.c: (create_details_widget),
210 (modest_main_window_set_contents_style):
211 Adapted to the use of the derived account instead of the folder store.
213 * src/modest-ui-actions.c:
214 (modest_ui_actions_on_folder_selection_changed):
215 * src/modest-ui-dimming-rules.c:
216 (modest_ui_dimming_rules_on_new_folder):
217 * src/widgets/modest-folder-view.c: (text_cell_data),
218 (icon_cell_data), (filter_row), (update_model),
219 (get_cmp_rows_type_pos):
222 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
223 Do not get the priv struct, because no priv struct has been set,
224 to avoid a runtime warning.
226 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
227 #ifelse with #else, to fix a warning, to fix the build.
230 2007-06-05 Christian Kellner <ckellner@openismus.com>
232 * libmodest-dbus-client/libmodest-dbus-client.c:
233 Fix small typo in doc (why do you always see them
234 AFTER committing stuff?)
237 2007-06-05 Christian Kellner <ckellner@openismus.com>
239 * libmodest-dbus-client/libmodest-dbus-client.c:
240 (libmodest_dbus_client_search):
241 Initialize hit list with NULL. Also set folder list
242 to "" if NULL was supplied.
245 2007-06-03 Christian Kellner <ckellner@openismus.com>
247 * libmodest-dbus-client/libmodest-dbus-client.c:
248 (modest_search_hit_list_free):
249 Make it save to call it with NULL.
251 * src/dbus_api/modest-dbus-callbacks.c:
252 * src/modest-search.c:
253 Return full ModestSearchHits as the search result list not TnyHeader
254 since can't be around withouth the correspoding TnyFolder.
256 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
258 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
259 Added currently commented code to check for secure auth
261 * src/maemo/modest-account-settings-dialog.c: (on_response),
262 (save_configuration), (show_ok):
263 Fixed projects.maemo.org bugs NB #59248 and #59251
265 * src/maemo/modest-maemo-utils.c:
266 (on_camel_account_get_supported_secure_authentication_status),
267 (on_camel_account_get_supported_secure_authentication),
268 (modest_maemo_utils_get_supported_secure_authentication_methods):
269 * src/maemo/modest-maemo-utils.h:
270 Moved get_supported_secure_authentication() method here to be able
271 to use it from easysetup wizard.
273 * src/modest-pair.c: (on_pair_compare_as_string):
274 Should compare string with first part of pair and not
275 strcmp pairs which will crash.
277 * src/modest-protocol-info.c:
278 (modest_protocol_info_protocol_is_store):
279 * src/modest-protocol-info.h:
280 Added modest_protocol_info_get_auth_protocol_name()
282 2007-06-03 Armin Burgmeier <armin@openismus.com>
284 * src/modest-mail-operation.c:
285 (modest_mail_operation_get_msgs_full): Set priv->account also when
286 only retrieving a single message. This avoids a crash when canceling
289 (modest_mail_operation_notify_end): Do not explicitely remove the
290 operation from the queue but only emit the progress_changed signal.
291 The queue itself listens to that signal to remove the operation when
292 it is finished. This reduces coupling and removes a potential deadlock
293 when modest_mail_operation_notify_end() is called from the queue
294 itself. If that is a problem performance-wise, I would suggest to
295 implement a status-changed signal or something.
297 * src/modest-mail-operation-queue.c: Make sure to never call a
298 function from another file while the queue is locked. This (hopefully)
299 fixes another deadlock when exiting the application while retrieving
302 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
304 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
305 Fixed build if libogs is not available
307 2007-06-03 Christian Kellner <ckellner@openismus.com>
309 * libmodest-dbus-client/libmodest-dbus-client.h:
310 * libmodest-dbus-client/libmodest-dbus-client.c:
311 (libmodest_dbus_client_delete_message):
312 Implement deletion of messages (Client side).
314 (modest_search_hit_free),
315 (modest_search_hit_list_free):
316 Utility functions to free the result hits.
318 * src/dbus_api/modest-dbus-api.h:
319 * src/dbus_api/modest-dbus-callbacks.c:
321 (modest_dbus_req_handler):
322 Implement deletion of messages (Server side).
324 * tests/dbus_api/test_search.c: (main):
327 * tests/dbus_api/Makefile.am:
328 * tests/dbus_api/test_delete_message:
329 Add little test for the message deletion logic
331 2007-06-03 Armin Burgmeier <armin@openismus.com>
333 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
334 when the operation queue was not empty. projects.maemo.org bug
337 2007-06-03 Armin Burgmeier <armin@openismus.com>
339 * src/widgets/modest-account-view.c
340 (on_account_default_toggled): Toggle default account column
341 explicitely instead of waiting for gconf notification (which is
342 currently ignored). This should fix projects.maemo.org bug NB#56910
343 for now. It should probably be removed when gconf notifications are
346 2007-06-03 Christian Kellner <ckellner@openismus.com>
348 * libmodest-dbus-client/libmodest-dbus-client.c:
349 Removed debugging spew.
351 * src/dbus_api/modest-dbus-callbacks.c:
352 Added debugging info.
354 * src/modest-search.c:
355 (modest_search_all_accounts):
356 Use tny_account_store_get_accounts () on the account store
357 to get all accounts which is the way to get all accounts.
359 * tests/dbus_api/test_search.c: (main):
360 Make it possible to supply the search term on the command line.
362 2007-06-03 Christian Kellner <ckellner@openismus.com>
364 * libmodest-dbus-client/libmodest-dbus-client.c:
365 * libmodest-dbus-client/libmodest-dbus-client.h:
366 Implement searching for mesages over raw dbus. (Client side)
368 * src/dbus_api/Makefile.am:
369 * src/dbus_api/modest-dbus-api.h:
370 * src/dbus_api/modest-dbus-callbacks.c:
371 * src/dbus_api/modest-dbus-callbacks.h:
372 Search framework (Server side). Also implement on_idle_open_message().
374 * src/maemo/modest-platform.c: (modest_platform_init):
375 Prepare for raw dbus/osso rpc interaction.
377 * src/modest-search.h:
378 Changed minsize from unspecific guint to guint32.
380 * src/modest-search.c:
382 Added strange hack which magically made tnymail work.
384 (modest_search_folder),
385 (modest_search_account),
386 (modest_search_all_accounts):
387 Implement helper functions to search all accounts, specific account
390 * tests/dbus_api/Makefile.am:
391 * tests/dbus_api/test_open_message.c:
392 Read url to open from commandline.
394 * tests/dbus_api/test_search.c:
395 Implement small test for dbus search stuff
397 2007-06-02 Armin Burgmeier <armin@openismus.com>
399 * src/maemo/modest-account-settings-dialog.c: Changed window title to
400 include account type and account title. This fixes projects.maemo.org
403 * src/maemo/modest-account-view-window.c: Set a title for the window.
405 2007-06-02 Armin Burgmeier <armin@openismus.com>
407 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
408 incoming and outgoing server name based on email address and server
409 types as long as the names have not been edited manually. This fixes
410 projects.maemo.org bug NB#58671.
412 2007-06-02 Armin Burgmeier <armin@openismus.com>
414 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
415 server type cannot be changed in future to the incoming details page
416 when creating an account. This fixes projects.maemo.org bug NB#59029.
418 2007-06-02 Armin Burgmeier <armin@openismus.com>
420 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
421 and assigned max width chars so that they wrap instead of being
422 truncated. Fixes projects.maemo.org bug NB#56126.
424 2007-06-02 Armin Burgmeier <armin@openismus.com>
426 * src/maemo/modest-connection-specific-smtp-window.c: Add an
427 introductory note to the connection specific smtp servers dialog, as
428 section 8.12 of the email UI specification requires. This fixes
429 projects.maemo.org bug NB#59212.
431 2007-06-01 Murray Cumming <murrayc@murrayc.com>
433 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
434 Check for running mail operations, and offer to cancel them, as per the UI
435 spec. This fixes projects.maemo.org bug NB#59041 .
436 However, I suspect that tinymail may still use the network connection
437 in ways that we cannot detect or cancel. But it should at least adapt to
440 2007-06-01 Murray Cumming <murrayc@murrayc.com>
442 * src/modest-tny-account-store.c: (recreate_all_accounts),
443 (get_cached_accounts), (get_server_accounts): Do more sensible
444 ref-counting of the temporarily-cached outbox accounts list. This seems
445 to fix a crash when entering the password when the password was wrong.
447 2007-06-01 Murray Cumming <murrayc@murrayc.com>
449 * src/gnome/modest-main-window.c: (connect_signals):
450 * src/modest-tny-account-store.c: (get_password),
451 (modest_tny_account_store_alert): Added comments and clues and
452 commented-out code about how we currently fail to deal with connection
453 errors and wrong passwords, and how we should.
455 2007-06-01 Murray Cumming <murrayc@murrayc.com>
457 * src/widgets/modest-retrieve-combo-box.c:
458 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
459 This fixes projects.maemo.org bug NB#58472 .
461 2007-06-01 Murray Cumming <murrayc@murrayc.com>
463 * src/maemo/easysetup/modest-easysetup-wizard.c:
464 (create_page_complete_easysetup):
465 (create_page_complete_custom): Correct the last commit,
466 putting the correct sentences in the correct pages.
468 2007-06-01 Murray Cumming <murrayc@murrayc.com>
470 * src/maemo/easysetup/modest-easysetup-wizard.c:
471 (create_page_complete_custom): Show the second sentence of text
472 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
475 2007-06-01 Murray Cumming <murrayc@murrayc.com>
477 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
478 Set the leave-on-server conf key by default. This fixes
479 projects.maemo.org bug NB#59258 .
481 2007-06-01 Murray Cumming <murrayc@murrayc.com>
483 * src/maemo/modest-account-view-window.c:
484 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
485 logical ID for the confirmation messages. Fixed projects.maemo.org bug
488 2007-06-01 Murray Cumming <murrayc@murrayc.com>
490 * src/maemo/easysetup/modest-easysetup-wizard.c:
491 (create_caption_new_with_asterisk):
492 * src/maemo/modest-account-settings-dialog.c:
493 (create_caption_new_with_asterisk):
494 Uncomment the code to add the asterisk, because they are no longer in the
495 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
496 (update_incoming_server_title): Add an asterisk here too.
498 2007-06-01 Murray Cumming <murrayc@murrayc.com>
500 * src/maemo/modest-maemo-global-settings-dialog.c:
501 (current_connection): Check that we are even connected before trying to
502 get the current connection name, to prevent a warning.
504 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
505 Change the comments because tny_maemo_conic_device_connect() is now meant to
507 * src/modest-mail-operation.c:
508 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
509 make sure we have a connection and fail if we can't connect.
511 2007-05-31 Murray Cumming <murrayc@murrayc.com>
513 * src/maemo/modest-main-window.c:
514 (on_account_store_connecting_finished): Do not try to get the
515 connection ID if we are not really connected. I am surprised that
516 this signal handler is called when we are not connected.
518 2007-05-31 Murray Cumming <murrayc@murrayc.com>
520 * src/modest-error.h:
521 * src/modest-ui-actions.c:
522 (modest_ui_actions_get_msgs_full_error_handler):
523 Renamed an enum, added comments, added an enum
524 for retrieve-limit errors.
526 * src/modest-mail-operation.c: (foreach_add_item),
527 (internal_folder_observer_update), (update_account_thread),
528 (modest_mail_operation_get_msgs_full):
529 (modest_mail_operation_update_account),
530 Added comments about how this works, and some code that should
531 (but does not) check the retrieve-limit. See the TODO comment.
533 2007-05-31 Murray Cumming <murrayc@murrayc.com>
535 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
536 Initialize help_id to fix the build. Warnings are good.
538 2007-05-31 Murray Cumming <murrayc@murrayc.com>
540 * src/widgets/modest-hbox-cell-renderer.c:
541 (modest_hbox_cell_renderer_append):
542 * src/widgets/modest-vbox-cell-renderer.c:
543 (modest_vbox_cell_renderer_append):
544 Fix the last commit by doing an extra ref.
546 2007-05-31 Murray Cumming <murrayc@murrayc.com>
548 * src/widgets/modest-hbox-cell-renderer.c:
549 (modest_hbox_cell_renderer_append):
550 * src/widgets/modest-vbox-cell-renderer.c:
551 (modest_vbox_cell_renderer_append):
552 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
553 to fix the build with Maemo Bora.
554 However, there seems to be a remaining crash, probably due to reference
557 2007-05-30 Murray Cumming <murrayc@murrayc.com>
559 * src/modest-tny-account.c:
560 (modest_tny_account_new_for_local_folders):
561 Use hildon_file_system_info_async_new() to get a better name for
562 the memory card account, setting it as the account name.
563 The timing seems to work, but this is probably
564 not the best place to do this. See the TODO comment.
565 * src/maemo/modest-main-window.c: (create_details_widget):
566 * src/widgets/modest-folder-view.c: (text_cell_data):
567 Use the tny account name instead of hardcoding a name.
569 2007-05-30 Christian Kellner <ckellner@openismus.com>
571 * src/modest-search.c: (modest_search):
572 Correctly set part_search_func even if we have already parsed
573 the query and thus a valid OgsTextSearcher object.
575 2007-05-30 Christian Kellner <ckellner@openismus.com>
578 Search and check for libogs.
581 Incooparte the ogs build env.
583 * src/modest-mime-part-search-stream.c:
584 * src/modest-mime-part-search-stream.h:
585 Removed since we do the real searching now in modest-search.c.
587 * src/modest-search.c:
588 * src/modest-search.h:
589 Implement support for ogs. We use that if available and requested
590 and fall back to modest_text_utils_utf8_strcmp (). The search logic
591 should now handle the corner case when the search term is spread
592 across multiple reads.
593 Also the logic in modest_search () was corrected to search all
594 requested fields until one is found.
596 2007-05-30 Murray Cumming <murrayc@murrayc.com>
598 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
601 * src/modest-init.c: Made modest_init_local_folders() take a
602 path and be public so we can iniitialize maildir folders on
605 * src/modest-local-folder-info.h:
606 * src/modest-local-folder-info.c:
607 (modest_local_folder_info_get_maildir_path): Add a path parameter.
609 * src/modest-tny-account.c:
610 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
611 still means the standard local-folders path on the local volume.
613 * src/modest-tny-account-store.c:
614 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
615 signal so we can detect mount/unmount of the MMC1 card, and do an update of
616 all accounts when that happens.
617 (get_server_accounts): If the MMC1 card is mounted, create a store account for
618 this too, so it shows up in the treeview.
620 2007-05-28 Murray Cumming <murrayc@murrayc.com>
622 * src/maemo/modest-maemo-global-settings-dialog.c:
623 (current_connection):
624 * src/widgets/modest-global-settings-dialog.c:
625 (current_connection_default):
626 Use the enum values instead of 0, 1 and -1,
627 to make the code clearer.
629 * src/modest-account-mgr-helpers.c:
630 (modest_account_mgr_get_connection_specific_smtp): Make this code
633 * src/modest-runtime.h:
634 * src/modest-runtime.c:
635 Added modest_runtime_remove_all_send_queues().
636 * src/maemo/modest-main-window.c:
637 (on_account_store_connecting_finished): Recreate the send queues,
638 using the appropriate transport accounts for this new connection.
639 Some futher adapting might be needed if the old send queues are not
640 automatically stopped at this point.
642 * src/modest-tny-account-store.c: (get_server_accounts):
643 Create the connection-specific transport accounts, so that they can
644 be found later by their ID.
646 * src/modest-tny-account.h:
647 * src/modest-tny-account.c:
648 Added modest_tny_account_new_from_server_account_name().
649 modest_tny_account_new_from_server_account(): Do not create the
650 send queues here, because they will be
651 recreated anyway when the connection changes for the first time.
653 2007-05-28 Murray Cumming <murrayc@murrayc.com>
655 * src/modest-local-folder-info.h:
656 * src/modest-local-folder-info.c:
657 (modest_per_account_local_outbox_folder_info_get_maildir_path),
658 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
659 tbox_folder): Take a modest account name instead of a server TnyAccount,
660 so we can have per-modest-account rather than per-transport-account
662 We must make sure that we change or recreate the exisitng send queues
663 when the connection changes for connection-specific transport accounts.
665 * src/modest-tny-account-store.c:
666 (create_per_account_local_outbox_folders): Create outboxed per modest
667 account, not per transport account.
669 * src/modest-tny-account.h:
670 * src/modest-tny-account.c:
671 (modest_tny_account_get_special_folder): For outboxes, get the
672 parent modest account name. The account is ignored for other folders.
673 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
674 modest account name rather than a server TnyAccount.
676 2007-05-25 Murray Cumming <murrayc@murrayc.com>
678 * src/modest-tny-account.c:
679 (modest_tny_account_new_from_server_account):
680 Call modest_runtime_get_send_queue() immediately after creating transport
681 accounts, so that they start trying to send email from the outbox as soon
682 as possible at startup. This is probably what we want.
684 * src/modest-mail-operation.c: (update_account_thread):
685 * src/modest-runtime.c: (modest_runtime_get_send_queue):
686 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
687 * src/modest-tny-send-queue.h:
688 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
689 (modest_ui_actions_on_send):
690 Added comments about how sending works, though it needs some more work.
692 2007-05-25 Murray Cumming <murrayc@murrayc.com>
694 * src/modest-tny-account.c:
695 (modest_tny_account_get_special_folder): Add TODO because this fails when
697 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
698 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
699 Do not try to show this window when there is no active account. The UI
700 specs does not tell us what to do in this case.
702 2007-05-24 Murray Cumming <murrayc@murrayc.com>
706 * src/maemo/Makefile.am:
707 * src/widgets/Makefile.am: Some dist fixes.
709 2007-05-24 Murray Cumming <murrayc@murrayc.com>
711 * src/maemo/modest-connection-specific-smtp-window.c:
712 (on_button_edit): Make the code clearer, to prevent a double free.
714 2007-05-24 Murray Cumming <murrayc@murrayc.com>
716 * src/maemo/modest-account-settings-dialog.c:
717 (modest_account_settings_dialog_set_account_name),
718 Check the connection-specific smtp servers checkbox if there are any.
720 * src/maemo/modest-connection-specific-smtp-edit-window.c:
721 (modest_connection_specific_smtp_edit_window_init):
722 Start with a suitable port number.
724 * src/modest-account-mgr-helpers.h:
725 * src/modest-account-mgr-helpers.c: Added
726 modest_account_mgr_get_has_connection_specific_smtp().
728 (modest_account_mgr_set_connection_specific_smtp),
729 (modest_account_mgr_remove_connection_specific_smtp),
730 (modest_account_mgr_get_has_connection_specific_smtp),
731 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
732 connection-specific smtp server accounts in the account, rather than
733 the server account conf dir.
735 This fixes bug projects.maemo.org bug NB#58263 .
737 * src/modest-tny-account-store.c:
738 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
739 if there are no server accounts yet, to prevent an infinite loop when there
740 are no accounts. Document that one must be called before the other.
742 2007-05-24 Murray Cumming <murrayc@murrayc.com>
744 * src/modest-account-mgr-helpers.c:
745 (modest_account_mgr_get_default_account): Make sure that at least
746 one account is always the default, if there are any enabled accounts.
747 This is just a sanity check that shouldn't be necessary.
749 * src/modest-account-mgr-priv.c:
750 (_modest_account_mgr_account_from_key): Unescape the conf key to
751 get the real account name. For instance, this is an issue if a space
752 was in the account name, which can happen because the account name
753 is generated from the display name.
754 (_modest_account_mgr_get_account_keyname): Always escape the
756 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
757 Unescape the conf keys to get the real account names.
759 For instance, previously the is-default radio button in the accounts
760 list was not checked for any accounts at first. This fixes that,
761 and might fix several similar bugs.
763 2007-05-23 Murray Cumming <murrayc@murrayc.com>
765 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
766 Removed some debug printfs.
768 2007-05-23 Murray Cumming <murrayc@murrayc.com>
770 Modest on-disk outbox directories are now here, for instance:
771 $HOME/.modest/outboxes/<account-id-1>/outbox
772 $HOME/.modest/outboxes/<account-id-2>/outbox
774 $HOME/.modest/local-folders/outbox
775 so we can have a separate outbox for each account.
776 But they are shown as one outbox in the GtkTreeView, by using a
777 TnyMergeFolder in a ModestTnySimpleFolderStore.
780 * src/modest-tny-simple-folder-store.c:
781 * src/modest-tny-simple-folder-store.h:
782 Added ModestTnySimpleFolderStore, used to contain folders from
783 other folder stores, such as other accounts.
785 * src/modest-tny-outbox-account.h:
786 * src/modest-tny-outbox-account.c:
787 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
788 used for the per-account local outbox folders.
790 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
791 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
792 only use this (internally) now for the non-outbox local folders.
795 * src/modest-init.c: Added modest_init_one_local_folder(), for
796 setting up the directory structure for each local folder.
798 * src/modest-local-folder-info.c:
799 (modest_per_account_local_outbox_folder_info_get_maildir_path),
800 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
802 * src/modest-local-folder-info.h:
803 * src/modest-tny-account-store.c: (on_account_removed),
804 (on_account_changed), (create_per_account_local_outbox_folders),
805 (get_server_accounts), (modest_tny_account_store_get_accounts),
806 (modest_tny_account_store_get_tny_account_by_account),
807 (modest_tny_folder_store_is_virtual_local_folders):
809 * src/modest-tny-account.h:
810 * src/modest-tny-account.c:
811 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
812 to create an on-disk per-account local outbox folder for each
814 (create_per_account_local_outbox_folders): Create a local outbox folder
815 for each transport account.
816 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
817 for all local folders.
819 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
820 instead of using g_object_get/set() directly. It is clearer.
822 (modest_tny_folder_store_get_message_count),
823 (modest_tny_folder_store_get_local_size
824 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
825 because we now use these with non-acount folder stores.
827 (modest_tny_account_get_special_folder),
828 (modest_tny_account_new_from_server_account),
829 (modest_tny_account_new_from_account):
830 (recurse_folders): Adjust to the new outbox system.
832 * src/modest-tny-folder.h:
833 * src/modest-tny-folder.c:
834 (modest_tny_folder_is_local_folder),
835 (modest_tny_folder_get_local_folder_type),
836 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
838 * src/widgets/modest-main-window.h:
839 * src/maemo/modest-main-window.c: (create_details_widget),
840 (modest_main_window_set_contents_style): Show details for any folder store,
843 (modest_tny_folder_get_rules):
844 Remove the const. C does not support constness enough for this.
846 * src/modest-ui-actions.c:
847 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
848 make all outboxes appear as one, in the usual local-folders tree node.
850 (set_active_account_from_tny_account),
851 (modest_ui_actions_on_folder_selection_changed):
852 * src/widgets/modest-folder-view.c: (text_cell_data),
853 (icon_cell_data), (filter_row),
854 (add_account_folders_to_merged_folder),
855 (add_account_folders_to_simple_folder_store), (),
856 (get_cmp_rows_type_pos), (cmp_rows),
857 (modest_folder_view_set_account_id_of_visible_server_account):
858 Adjust to the new outbox system, using generic folder stores and folders
861 2007-05-23 Christian Kellner <ckellner@openismus.com>
863 * src/modest-mail-operation.c:
864 (modest_mail_operation_update_account):
865 Use info->max_size instead of unintialized local var [small
866 build fix]. (Added TODO to review that change since I don't
869 2007-05-23 Marcus Bauer <marcusb@openismus.com>
871 * libmodest-dbus-client/libmodest-dbus-client.c:
872 (libmodest_dbus_client_compose_mail): function added
873 * src/dbus_api/modest-dbus-api.h:
874 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
875 (on_compose_mail): Implementation of the SendAsMail functionality
877 2007-05-22 Murray Cumming <murrayc@murrayc.com>
879 * src/modest-account-mgr.c:
880 (modest_account_mgr_add_server_account): Set the secure-connection
881 conf key for transport accounts as well as store accounts. I don't know
882 why the if was there. For instance, this makes sure that we use SSL
883 for the gmail preset from the easysetup wizard.
885 2007-05-22 Murray Cumming <murrayc@murrayc.com>
887 * src/gnome/modest-main-window.c:
888 (on_account_store_connecting_finished), (connect_signals):
889 * src/maemo/modest-main-window.c:
890 (on_account_store_connecting_finished), (connect_signals),
891 (modest_main_window_new):
892 Handle TnyAccountStore::connecting-finished instead of
893 TnyDevice::connection-changed, because we cannot actually perform
894 operations on accounts until TnyAccountStore has itself responded to
895 the TnyDevice::connection-changed signal. This prevents a GError from
897 Do not try to update at startup, because we (at least on scratchbox)
898 already do an update at startup when the device goes online.
899 This prevents a GError from tinymail.
900 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
901 Added TODO about stopping simultaneous operations.
903 2007-05-21 Murray Cumming <murrayc@murrayc.com>
905 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
906 * src/modest-mail-operation-queue.c:
907 (modest_mail_operation_queue_remove):
908 * src/modest-tny-account-store.c: When GErrors happen, give more clues
909 about where they happened.
911 2007-05-21 Murray Cumming <murrayc@murrayc.com>
913 * src/modest-ui-actions.c:
914 (modest_ui_actions_on_password_requested): Make sure that the remember
915 output parameter is always TRUE.
917 2007-05-21 Murray Cumming <murrayc@murrayc.com>
919 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
920 Show a OK/Cancel dialog if the error is a question, though we still do not
921 know anything more about what we are asking the user.
922 * src/widgets/modest-folder-view.c: (on_drag_data_received):
923 Fix an uninitialized variable (helper). This is a logic error, however.
925 2007-05-21 Christian Kellner <ckellner@openismus.com>
927 * src/modest-search.h:
928 Correct bit shifting in the ModestSearchFlags enum.
930 2007-05-21 Murray Cumming <murrayc@murrayc.com>
932 * src/modest-tny-account.c:
933 (modest_tny_account_new_from_server_account): Do not use the lsub and
934 check-all hard-coded IMAP options when using POP.
936 2007-05-21 Murray Cumming <murrayc@murrayc.com>
938 * src/modest-tny-account.c:
939 (modest_tny_account_new_from_server_account):
940 Use NULL for the secure-auth method for POP when Password auth has been
941 specified by the user, as we already do for IMAP. "auth=Login" causes
942 an error from camel or the server.
944 2007-05-17 Murray Cumming <murrayc@murrayc.com>
946 * src/maemo/modest-account-settings-dialog.c:
947 (create_page_account_details),
948 (modest_account_settings_dialog_set_account_name):
949 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
950 for the leave-on-server checkbox, rathr than just the checkbox, when
951 the protocol is not POP.
953 2007-05-17 Murray Cumming <murrayc@murrayc.com>
955 * src/widgets/modest-account-view.c:
956 * src/widgets/modest-account-view.h:
957 Added modest_account_view_select_account() which will be useful later
958 to asynchronously re-select the edited account.
960 2007-05-17 Murray Cumming <murrayc@murrayc.com>
962 * src/maemo/modest-account-settings-dialog.c:
963 (modest_account_settings_dialog_set_account_name):
964 Automatically choose the port numbers based on the secure authentication
965 methods, if they have not been chosen before.
966 This fixes projects.maemo.org bug NB#56273 .
968 2007-05-17 Murray Cumming <murrayc@murrayc.com>
970 * src/maemo/modest-main-window-ui.h:
971 * src/modest-ui-actions.c:
972 * src/modest-ui-actions.h:
973 Connect the Tools/SMTP Servers menu item to
974 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
975 SMTP servers dialog, as in the UI specification and saves changes when it
976 is closed. This fixed projects.maemo.org bug NB#56305 .
978 2007-05-17 Murray Cumming <murrayc@murrayc.com>
980 * src/maemo/modest-connection-specific-smtp-window.c:
981 (modest_connection_specific_smtp_window_init):
982 Use gtk_window_set_default_size() to make this window big enough, so
983 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
985 2007-05-17 Murray Cumming <murrayc@murrayc.com>
987 * src/maemo/modest-connection-specific-smtp-edit-window.h:
988 * src/maemo/modest-connection-specific-smtp-edit-window.c:
989 (modest_connection_specific_smtp_edit_window_init),
990 Do not try to connect to a combobox signal before the combobox exists.
991 This fixes the cras in projects.maemo.org bug NB#56288 .
992 (modest_connection_specific_smtp_edit_window_get_settings):
993 Remove the server_account_name parameter which was being checked for NULL
994 though it was not used.
996 * src/maemo/modest-connection-specific-smtp-window.c:
997 (modest_connection_specific_smtp_window_fill_with_connections),
998 (on_button_edit), (modest_connection_specific_smtp_window_init):
999 Correct the number of treemodel columns to prevent a warning.
1000 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1001 libconic does not work.
1003 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1005 * src/modest-tny-account.c:
1006 (modest_tny_account_new_from_server_account):
1007 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1008 SMTP when "None" was chosen by the user. However, with my SMTP server that
1009 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1012 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1014 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1015 to explain the memory management issue with the ID in the ModestPair.
1017 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1018 (add_sending_page), (modest_account_assistant_finalize):
1019 * src/gnome/modest-gnome-global-settings-dialog.c:
1020 (create_updating_page), (create_composing_page):
1021 * src/gnome/modest-msg-edit-window.c: (get_transports),
1022 (init_window), (modest_msg_edit_window_finalize),
1023 (modest_msg_edit_window_get_msg_data):
1024 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1025 * src/gnome/modest-transport-widget.c:
1026 (modest_transport_widget_finalize), (smtp_configuration):
1027 * src/maemo/modest-maemo-global-settings-dialog.c:
1028 (create_updating_page), (create_composing_page):
1029 * src/maemo/modest-msg-edit-window.c: (get_transports),
1030 (init_window), (modest_msg_edit_window_finalize),
1031 (modest_msg_edit_window_get_msg_data),
1032 (modest_msg_edit_window_free_msg_data):
1033 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1034 (modest_store_widget_finalize):
1035 * src/maemo/modest-transport-widget.c:
1036 (modest_transport_widget_finalize), (smtp_configuration):
1037 * src/modest-main.c: (send_mail):
1038 * src/widgets/modest-combo-box.h:
1039 * src/widgets/modest-global-settings-dialog-priv.h:
1040 * src/widgets/modest-global-settings-dialog.c:
1041 (modest_global_settings_dialog_finalize):
1042 * src/widgets/modest-msg-edit-window.h:
1043 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1044 as long as the combo box, to prevent use of freed memory for the ID.
1046 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1048 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1049 get_accounts(), to make this clearer. Do not check for the enabled gconf
1050 key, because we do not use this for server accounts (at least, not yet).
1051 This allows us to send email again.
1053 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1055 * src/maemo/modest-platform.c:
1056 (on_modest_conf_update_interval_changed), (modest_platform_init):
1057 Only respond to this particular key change. All these strcmp()s cannot be
1060 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1062 * src/maemo/modest-maemo-global-settings-dialog.c:
1063 (current_connection): Prevent a crash in scratchbox when
1064 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1065 * src/maemo/modest-platform.c:
1066 (on_modest_conf_update_interval_changed), (modest_platform_init):
1067 Get the update interval from gconf and reset it when the gconf key changes.
1069 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1071 * src/modest-protocol-info.c:
1072 * src/modest-protocol-info.h: Adde enum-specific get functions,
1073 instead of using a ModestProtocolType enum parameter.
1075 * src/gnome/modest-account-assistant.c:
1076 * src/gnome/modest-store-widget.c:
1077 * src/gnome/modest-store-widget.h:
1078 * src/gnome/modest-transport-widget.c:
1079 * src/gnome/modest-transport-widget.h:
1080 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1081 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1082 * src/maemo/easysetup/modest-easysetup-wizard.c:
1083 * src/maemo/modest-account-settings-dialog.c:
1084 * src/maemo/modest-account-settings-dialog.h:
1085 * src/maemo/modest-store-widget.c:
1086 * src/maemo/modest-store-widget.h:
1087 * src/maemo/modest-transport-widget.c:
1088 * src/maemo/modest-transport-widget.h:
1089 * src/modest-account-mgr-helpers.c:
1090 * src/modest-account-mgr-helpers.h:
1091 * src/modest-account-mgr.c:
1092 * src/modest-account-mgr.h:
1093 * src/modest-tny-account.c:
1094 * src/modest-tny-folder.c:
1095 * src/widgets/modest-account-view.c:
1096 * src/widgets/modest-retrieve-combo-box.c:
1097 * src/widgets/modest-retrieve-combo-box.h:
1098 * src/widgets/modest-secureauth-combo-box.c:
1099 * src/widgets/modest-serversecurity-combo-box.c:
1100 * src/widgets/modest-serversecurity-combo-box.h:
1101 * tests/check_account-mgr.c:
1102 Use the specific functions, and use the re-renamed enum values for GNOME too.
1104 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1106 * src/modest-pair.h:
1107 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1108 so we can get the second based on the first.
1110 * src/maemo/modest-account-settings-dialog.h:
1111 * src/maemo/modest-account-settings-dialog.c:
1112 Added get_supported_secure_authentication_methods(), though it is mostly
1113 commented-out for now until the necessary API is committed to tinymail.
1114 (modest_account_settings_dialog_set_account_name),
1115 (save_configuration): Request the supported authentication methods from the
1116 server, so we can choose a working method.
1118 * src/modest-tny-account-store.h:
1119 * src/modest-tny-account-store.c:
1120 (modest_tny_account_store_get_session): Rename from
1121 tny_account_store_get_session().
1123 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1125 * src/modest-protocol-info.h: Split the ModestProtocol enum
1126 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1127 There was no need to have these unrelated values in one enum.
1129 * src/: many files: Adapted to changed enum. This makes the code a bit
1130 clearer, and the compiler could catch some errors.
1132 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1134 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1135 Show the detailed internal camel error message when an error happens
1136 during the configuration, so that our testers can give us more clues.
1137 For instance, in projects.maemo.org bug NB#56910 .
1139 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1141 * src/modest-tny-account.c:
1142 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1143 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1145 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1147 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1148 * src/maemo/modest-account-settings-dialog.c:
1149 (modest_account_settings_dialog_set_account_name),
1150 (save_configuration): For the incoming secure authentication checkbox,
1151 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1152 the UI specification. PLAIN does not seem to be supported for most IMAP
1153 servers anyway, and I am not sure what it would mean.
1154 However, we probably need to discover which of the secure-authentication
1155 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1156 * src/modest-account-mgr-helpers.c:
1157 (modest_account_mgr_get_server_account_data):
1159 * src/modest-tny-account.c:
1160 (modest_tny_account_new_from_server_account):
1161 Use tny_account_set_mech() to set secure-authentication methods,
1162 with some special-casing for IMAP, based on my observations of how
1165 * src/modest-account-mgr-helpers.h:
1166 * src/modest-account-mgr.c:
1167 * src/modest-defs.h: Comment that the URI is only used for local folders.
1169 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1171 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1172 parameter const, just to be neat.
1173 * src/modest-text-utils.c: (modest_text_utils_inline):
1174 End g_strconcat() with NULL, as its documentation says. This is almost
1175 certainly the cause of my crash at startup on the device. Interestingly,
1176 valgrind doesn't tell us about these errors.
1178 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1180 * scripts/build-packages: Added more precise comments about how to use
1181 this script, though I still get this error:
1182 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1183 error building tinymail
1185 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1187 * src/maemo/modest-main-window.c: (on_account_update):
1188 Very slight cleanup, hoping to make it simpler to discover what causes
1189 a crash here sometimes.
1191 * src/modest-tny-account.c:
1192 (modest_tny_account_new_from_server_account): Set the port. Added
1193 comments about the options and a TODO comment because I need to find out
1194 how to specify the secure authentication method.
1196 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1198 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1199 changed CFlags paths form modest to libmodest
1201 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1203 * src/modest-account-mgr-helpers.c:
1204 (modest_account_mgr_get_server_account_data),
1205 (modest_account_mgr_free_server_account_data):
1206 * src/modest-account-mgr-helpers.h:
1207 * src/modest-account-mgr.c:
1208 (modest_account_mgr_add_server_account):
1209 * src/modest-defs.h:
1210 * src/modest-tny-account.c:
1211 (modest_tny_account_new_from_server_account):
1212 Determine the options for tny_camel_account_add_option() here,
1213 based on the settings, rather than storing them directly in gconf.
1215 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1217 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1218 Show a more friendly error dialog now that we expect (from the tinymail
1219 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1221 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1223 * src/maemo/modest-main-window.c: (on_account_update): Check that
1224 account_name is not NULL, to prevent a crash at startup that I am
1225 seeing on the N800. I do wonder why it is NULL.
1227 * src/maemo/easysetup/modest-easysetup-wizard.c:
1228 (create_page_user_details):
1229 * src/maemo/modest-account-settings-dialog.c:
1230 (create_page_user_details), (create_page_outgoing):
1231 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1232 (modest_connection_specific_smtp_edit_window_init):
1233 * src/modest-ui-actions.c:
1234 (modest_ui_actions_on_password_requested):
1235 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1236 might do something useful with the on-screen keyboard.
1238 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1240 * src/maemo/modest-main-window.c: (on_account_update):
1241 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1242 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1244 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1246 * src/modest-tny-account-store.c: (on_account_changed):
1247 Correct the signature of this signal handler.
1249 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1251 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1252 Show a HildonNote instead of a GtkDialog for Maemo.
1254 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1256 * src/widgets/modest-account-view.h:
1257 * src/widgets/modest-account-view.c: (on_account_changed),
1258 (on_account_removed). Added a boolean flag, set/unset by
1259 modest_account_view_block_conf_updates(),
1260 modest_account_view_unblock_conf_updates() to prevent unnecessary
1261 updates, but this is not very useful because the gconf notifications are
1262 so delays (maybe only on Maemo Bora).
1263 So auto-updating is turned off, and these functions do an explicit
1264 update when necessary.
1265 However, something else is still doing too much work when adding/removing
1266 accounts, probably in another part of the application.
1268 * src/maemo/modest-account-view-window.c:
1269 (on_delete_button_clicked), (on_edit_button_clicked),
1270 (on_new_button_clicked): Use the new functions.
1272 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1274 * src/modest-account-mgr-helpers.c:
1275 (modest_account_mgr_set_first_account_as_default):
1276 Sort the list of names alphabetically-by-title, so we choose the first one
1278 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1279 alphabetically by the title.
1281 This fixes projects.maemo.org bug NB#56418 .
1283 * src/modest-account-mgr-priv.c:
1284 (_modest_account_mgr_account_from_key):
1285 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1286 avoid a valgrind error, and possible random behaviour.
1288 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1290 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1291 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1292 tinymail documentation to say that this can be expected.
1293 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1294 pretty, and should not happen, but I would prefer to know when it does.
1296 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1298 * configure.ac: When using the older hildon version, probably on Bora,
1299 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1301 * src/widgets/modest-attachment-view.c:
1302 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1305 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1307 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1308 Implemented the prototype. Can be tested with
1309 tests/dbus_api/test_open_message:
1311 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1313 * src/modest-tny-account-store.c:
1314 (modest_tny_account_store_instance_init), (get_password):
1315 * src/modest-ui-actions.c:
1316 (modest_ui_actions_on_password_requested):
1317 Do not store the password in gconf, because this function is called
1318 for non-remembered passwords. Actually use the cached (in the hash map)
1319 password instead of releasing it.
1320 The password will now not be remembered if it is asked via the protected
1321 password dialog, as per the UI spec.
1323 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1325 * src/modest-defs.h:
1326 * src/modest-account-mgr-helpers.h:
1327 * src/modest-account-mgr-helpers.c:
1328 Added modest_server_account_get_username_has_succeeded(),
1329 modest_server_account_set_username_has_succeeded().
1330 (modest_server_account_set_username),
1331 Reset the has-succeeded flag if the username changes.
1333 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1334 * src/maemo/modest-connection-specific-smtp-window.c:
1335 (modest_connection_specific_smtp_window_save_server_accounts):
1336 Use modest_server_account_set_username() instead of using
1337 modest_conf_set_string() directly, so that the has-succeeded flag is always
1340 * src/modest-ui-actions.c:
1341 (modest_ui_actions_on_password_requested): Dim the username entry if
1342 the username has ever worked, as per the UI spec.
1344 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1346 * src/modest-tny-account-store.c: (get_password):
1347 * src/modest-ui-actions.c:
1348 (modest_ui_actions_on_password_requested):
1349 Allow the username to be changed too, though there is more work to
1350 be done on exactly how this behaves.
1352 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1354 * src/modest-account-mgr-helpers.h:
1355 * src/modest-account-mgr-helpers.c:
1356 Added modest_account_mgr_get_display_name(),
1357 modest_server_account_get_username(),
1358 modest_server_account_set_username(),
1359 modest_server_account_set_password(),
1360 modest_server_account_get_hostname() functions so we do not need to
1361 use the conf API directly.
1363 * src/maemo/modest-main-window.c: (connect_signals):
1364 Actually connect ot the ModestAccountStore::request-password signal,
1365 so that we show the dialog when the password is requested by Tinymail,
1366 for isntance if it is empty.
1368 * src/modest-marshal.list:
1369 * src/modest-tny-account-store.c:
1370 (modest_tny_account_store_class_init), (get_password),
1371 (modest_tny_account_store_alert):
1372 * src/modest-tny-account-store.h:
1373 * src/modest-ui-actions.h:
1374 * src/modest-ui-actions.c:
1375 (modest_ui_actions_on_password_requested):
1376 Change the signal parameters, so it is obvious that we are providing
1377 the non human-readable server name, and receiving both the username
1378 and password, though changing of the username is not yet implemented.
1379 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1380 for the GNOME version.
1382 This should fix the projects.maemo.org bug NB#56209, though it does not
1383 work on Bora, because the gconf_client_get() for the password fails
1384 immediately after we save it with gconf_client_set().
1386 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1389 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1390 caused an undefined symbol error:
1391 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1393 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1395 * src/modest-tny-account-store.c:
1396 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1397 using a GError instead of a string message, so we can translate it in
1400 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1402 * src/maemo/modest-address-book.c:
1403 (modest_address_book_check_names):
1404 * src/maemo/modest-msg-view-window.c:
1405 (modest_msg_view_window_clipboard_owner_change):
1406 * src/modest-init.c: (modest_init_init_ui):
1407 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1408 (update_folders_cb), (modest_mail_operation_update_account):
1409 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1410 (modest_ui_actions_on_msg_attachment_clicked),
1411 (modest_ui_actions_on_msg_recpt_activated):
1412 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1413 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1414 (modest_msg_view_search_next):
1415 * src/widgets/modest-recpt-editor.c:
1416 (modest_recpt_editor_on_button_release_event),
1417 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1418 g_message(). At this point we should only be seeing interesting errors on
1419 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1421 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1423 (modest_wizard_dialog_force_title_update):
1424 * src/maemo/easysetup/modest-wizard-dialog.h:
1425 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1426 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1427 can update the title when appropriate. Otherwise the title is wrong if the
1428 pages are added after adding the notebook to the dialog.
1429 This must be a problem in HildonWizardDialog too.
1430 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1432 * src/maemo/easysetup/modest-easysetup-wizard.c:
1433 (create_subsequent_customsetup_pages),
1434 (create_subsequent_easysetup_pages):
1435 Call modest_wizard_dialog_force_title_update() so that the title is
1436 correct even with GTK+ < 2.10.
1437 This fixes projects.maemo.org bug NB#56145 .
1439 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1441 * src/maemo/modest-platform.c:
1442 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1443 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1446 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1448 * src/widgets/modest-window.h:
1449 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1450 and modest_window_save_state(), which invokes it.
1452 * src/widgets/modest-window-mgr.h:
1453 * src/widgets/modest-window-mgr.c:
1454 Added modest_window_mgr_save_state_for_all_windows(), which calls
1455 the save_state vfunc on all registered windows, if implemented.
1457 * src/gnome/modest-msg-edit-window.c:
1458 * src/gnome/modest-msg-view-window.c:
1459 * src/maemo/modest-msg-edit-window.c:
1460 * src/maemo/modest-msg-view-window.c:
1461 * src/maemo/modest-main-window.c:
1462 Specify the existing save_settings functions as implementations of
1463 ModestWindow::save_state_func().
1465 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1466 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1467 enabling hibernation, for instance.
1469 We may need to do the same thing for restoring settings.
1472 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1474 * src/widgets/modest-window-mgr.c:
1475 * src/widgets/modest-window-mgr.h:
1476 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1477 modest_window_mgr_get_hibernation_is_prevented().
1479 * src/maemo/modest-main-window.c:
1480 (on_hildon_program_is_topmost_notify): Prevent hibernation
1481 (possible when the application goes to the background in the WM),
1482 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1484 * src/maemo/easysetup/modest-easysetup-wizard.c:
1485 (modest_easysetup_wizard_dialog_init):
1486 * src/maemo/modest-account-settings-dialog.c:
1487 (modest_account_settings_dialog_init):
1488 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1489 (modest_connection_specific_smtp_edit_window_init):
1490 * src/maemo/modest-connection-specific-smtp-window.c:
1491 (modest_connection_specific_smtp_window_init):
1492 * src/maemo/modest-signature-editor-dialog.c:
1493 (modest_signature_editor_dialog_init):
1494 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1495 prevent hibernation while any of these account settings dialogs are open.
1497 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1499 * src/maemo/Makefile.am:
1500 * src/maemo/modest-osso-state-saving.c:
1501 * src/maemo/modest-osso-state-saving.h: Added
1502 modest_osso_load_state() and modest_osso_save_state() though they do
1503 nothing now. They should iterate through all the open windows and load/save
1505 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1506 save state when closing.
1508 * src/maemo/modest-main-window.c:
1509 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1510 Add a notification handler for the HildonProgram::is-topmost property,
1511 so we can allow hibernation when the application goes into the background.
1512 But we still need to detect when the accounts setup windows are open so
1513 we can stop hibernation when they are open.
1514 To do this, I also added the main window the HildonProgram. This might have
1515 other side-effects/benefits, and should maybe be done for other windows.
1517 * src/maemo/modest-osso-autosave-callbacks.h:
1518 * src/maemo/modest-osso-autosave-callbacks.c:
1519 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1520 though it does not do anything yet, and we might never need this to do
1521 anything. For instance, we already save drafts.
1523 * src/maemo/modest-platform.c: (modest_platform_init):
1524 Specify the libosso auto-save callback.
1526 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1528 * src/maemo/modest-platform.c:
1529 (modest_platform_set_update_interval):
1530 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1531 aparently stays valid between application instances, so we can use this
1532 to remove and reset it later. According to a maemo-developers email from
1535 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1537 * configure.ac: Depend on libalarm for Maemo.
1539 * src/dbus_api/modest-dbus-api.h:
1540 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1541 (on_send_receive), (modest_dbus_req_handler):
1542 Handle a SEND_RECEIVE D-Bus method.
1544 * libmodest-dbus-client/libmodest-dbus-client.c:
1545 (libmodest_dbus_client_send_and_receive):
1546 * libmodest-dbus-client/libmodest-dbus-client.h:
1547 Add C convenience functions for calling the new D-Bus method.
1549 * src/modest-platform.h:
1550 * src/gnome/modest-platform.c:
1551 * src/maemo/modest-platform.c:
1552 Added modest_platform_set_update_interval(), which uses the
1553 alarmd API on Maemo.
1554 (modest_platform_init),
1555 Call modest_platform_set_update_interval(), using a hard-coded
1556 interval for now (until the global settings dialog is implemented),
1557 though I am not sure that this makes sense yet.
1559 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1561 * src/dbus_api/modest-dbus-callbacks.c:
1562 (modest_osso_cb_hw_state_handler):
1563 * src/dbus_api/modest-dbus-callbacks.h:
1564 * src/maemo/modest-platform.c: (modest_platform_init):
1565 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1566 in case this has some effect on the ability for Maemo to ping the
1569 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1571 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1572 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1573 warning. It is probably a logic error, but I need to fix the build.
1575 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1577 * src/modest-account-mgr.h:
1578 * src/modest-account-mgr.c:
1579 (modest_account_mgr_account_names): Add a gboolean enabled_only
1580 parameter, so we can get lists of onlt the enabled accounts.
1582 (modest_account_mgr_add_account),,
1583 (modest_account_mgr_account_with_display_name_exists):
1584 * src/maemo/modest-msg-edit-window.c: (get_transports):
1585 * src/modest-account-mgr-helpers.c:
1586 (modest_account_mgr_set_first_account_as_default):
1587 * src/modest-init.c: (init_default_account_maybe):
1588 * src/modest-tny-account-store.c: (get_accounts):
1589 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1590 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1591 * tests/check_account-mgr.c: (START_TEST):
1592 Provide the extra parameter, as appropriate.
1594 * src/widgets/modest-account-view.c: (update_account_view):
1595 Do not show disabled accounts (meaning that there is no way to
1596 enable/disable accounts in the UI (the feature is not in our UI
1597 specification), so we can use this internally only to mark unfinished
1598 or temporary account data.
1600 * src/maemo/easysetup/modest-easysetup-wizard.c:
1601 (create_account): Add boolean enable parameter, so we can specify FALSE
1602 to create the temporary account.
1603 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1604 (on_before_next): When finishing, when there is a temporary account, just
1606 Also, use a timeout to delay the showing of the dialog until gconf is likely
1607 to return correct information, due to a maemo gconf bug that is fixed in
1608 osso 1.1, but not yet in Bora.
1609 However, the dialog stays on screen after it is destroyed.
1611 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1612 for invalid data when cancelling. Use a hildon note instead of a dialog
1613 to complain about invalid data. Do not show the account-saved note if the
1614 account is disabled (a temporary account that will not really be saved for use
1617 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1619 * src/modest-account-mgr-helpers.h:
1620 * src/modest-account-mgr-helpers.c:
1621 Added modest_account_mgr_unset_default_account(),
1622 Added modest_account_mgr_set_first_account_as_default().
1624 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1625 If it was the default account, unset the default account name.
1627 * src/maemo/modest-account-view-window.c:
1628 (on_delete_button_clicked): If it was the default account,
1629 set the first remaining account as the default instead.
1631 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1632 a NULL account or a NULL default account, to prevent a crash. This should
1633 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1636 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1638 * src/widgets/modest-recpt-editor.c:
1639 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1640 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1641 TODO comment for this. This fixes the build.
1643 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1644 be the best place for it. This will in future update all auto-update accounts,
1645 rather than just the current/default account, when that gconf key exists.
1646 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1647 if there are no accounts, before calling do_send_receive().
1648 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1650 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1651 * src/maemo/modest-main-window-ui.h:
1652 * src/maemo/modest-main-window.c: (on_connection_changed),
1653 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1654 directly, becaue the signal handler does more.
1656 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1658 * src/modest-account-mgr-helpers.c:
1659 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1660 for the case that the account does not exist.
1662 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1663 (equivalent to the modest account name) rather than the tinymail account name
1664 (equivalent to the modest account title - human readable) to get the account data.
1665 Check for null account data to prevent the crash, and add a TODO comment saying that
1666 this needs fixing because it is using the server account name instead of the account name.
1668 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1670 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1671 * src/maemo/modest-account-settings-dialog.c: (show_error),
1673 Use hildon_note_new_information() for informative and error messages,
1674 which seems to be expected for Maemo applications (no documentation that I know of
1675 says this). I am surprised that there is no distinction between info and error
1678 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1680 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1681 it is easy to find where this is used.
1683 * src/maemo/easysetup/modest-easysetup-wizard.c:
1684 (create_page_welcome), (create_page_account_details),
1685 (create_page_user_details), (create_page_complete_easysetup),
1686 (create_page_custom_incoming), (create_page_custom_outgoing),
1687 (create_page_complete_custom):
1688 * src/maemo/modest-account-settings-dialog.c:
1689 (create_page_account_details), (create_page_user_details),
1690 (create_page_incoming), (create_page_outgoing):
1691 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1692 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1693 (modest_connection_specific_smtp_edit_window_init):
1694 * src/maemo/modest-connection-specific-smtp-window.c:
1695 (modest_connection_specific_smtp_window_init):
1696 * src/maemo/modest-signature-editor-dialog.c:
1697 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1698 and scrolling policy as per the Email Application Layout Guide, if I have
1701 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1703 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1704 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1705 which were empty, because these vfuncs have been removed from TnyAccountStore.
1706 This fixes the build.
1708 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1710 * src/maemo/modest-main-window.c:
1711 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1712 showing/hiding it. Added TODO because it probably should not be NULL.
1713 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1714 because unnecessary g_warnings() make degugging difficult.
1716 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1718 * src/maemo/modest-msg-edit-window.c:
1719 (modest_msg_edit_window_select_color),
1720 (modest_msg_edit_window_select_background_color): 2 const corrections and
1721 moving 2 #endifs before closing brackets, to fix the build.
1723 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1725 * src/maemo/easysetup/modest-easysetup-wizard.h:
1726 * src/maemo/easysetup/modest-easysetup-wizard.c:
1727 (modest_easysetup_wizard_dialog_finalize),
1728 (on_button_edit_advanced_settings), (create_page_complete_custom),
1729 (on_response), (create_account):
1730 Implement the Advanced Settings edit button, by saving the account information,
1731 for the Advanded Settings dialog to use directly from gconf, and removing it
1732 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1733 Bug #5533 in the projects.maemo.org bugzilla.
1735 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1737 * src/maemo/modest-msg-view-window.c:
1738 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1739 when opening a message window.
1741 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1743 * src/maemo/easysetup/modest-easysetup-wizard.c:
1744 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1747 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1748 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1749 gconf settings. I probably added more checks than necessary, but that is safer.
1751 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1752 variable to fix the build, but this seems to be used when it is still NULL.
1754 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1756 * src/modest-platform.h:
1757 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1758 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1759 * src/modest-main.c: Implement this function so we can avoid using
1760 maemo-specific API from cross-platform code.
1762 * src/modest-tny-account-store.c:
1763 (get_smtp_specific_transport_account_for_open_connection):
1764 * src/modest-ui-actions.c: (check_for_connection),
1765 (modest_ui_actions_on_item_not_found):
1766 Use modest_platform_connect_and_wait() and put #idefs around other
1767 maemo-specific code, because only maemo currently has a way to
1768 identify connection names.
1770 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1772 * src/modest-tny-account-store.h:
1773 * src/modest-tny-account-store.c:
1774 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1775 the connection-specific SMTP server settings in the configuration.
1777 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1779 * src/maemo/modest-main-window.c: (on_connection_changed),
1781 * src/modest-main.c: (main), (start_ui), (send_mail):
1782 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1783 that is what is intended.
1785 * src/modest-ui-actions.c: (action_send), (action_receive),
1786 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1787 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1788 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1789 SMTP server is used when it is specified.
1791 (modest_ui_actions_on_send_receive):
1792 Check that a connection is open before proceeding.
1793 Receive and then send, instead of vice-versa, as per the specification.
1795 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1797 * src/modest-mail-operation.c:
1798 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1799 though I guess it should be something other than NULL.
1801 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1803 * src/maemo/easysetup/modest-easysetup-wizard.c:
1804 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1805 combo twice, to avoid an g_warning and to make it visible again.
1806 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1807 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1808 (already intended) dereference when detaching, because we then recreate the menu.
1809 But I am not sure why the warning was happening, and it is possible that this is a memory
1812 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1814 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1815 and uri_parse_mailto() utility functions.
1816 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1818 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1820 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1822 * src/dbus_api/modest-dbus-api.h:
1823 * src/dbus_api/modest-dbus-callbacks.c:
1824 Use an idle callback to execute the modest code in the application's own thread.
1825 Remove the helloworld example method.
1826 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1827 parsed, and the open-message method is not implemented because this is not yet implemented in
1829 * libmodest-dbus-client/libmodest-dbus-client.c:
1830 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1831 (libmodest_dbus_client_open_message):
1832 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1834 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1835 body without crashing.
1837 * tests/dbus_api/Makefile.am:
1838 * tests/dbus_api/test_mail_to.c:
1839 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1841 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1843 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1844 Added file to fix the build. Sorry.
1846 * src/dbus_api/Makefile.am:
1847 * src/dbus_api/modest-dbus-api.h:
1848 * src/dbus_api/modest-dbus-callbacks.h:
1849 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1850 (modest_dbus_req_handler):
1851 Put constants in a separate header so it can be reused by the
1852 client library, without duplication
1854 * libmodest-dbus-client/Makefile.am:
1855 * libmodest-dbus-client/libmodest-dbus-client.c:
1856 (libmodest_dbus_client_call_helloworld),
1857 (libmodfest_dbus_client_send_mail),
1858 (libmodfest_dbus_client_mailto),
1859 (libmodfest_dbus_client_open_message):
1860 * libmodest-dbus-client/libmodest-dbus-client.h:
1861 (Partly) Implement a send_mail D-Bus method.
1863 * tests/dbus_api/Makefile.am:
1864 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1865 the send_email D-Bus method.
1867 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1871 * libmodest-dbus-client/Makefile.am:
1872 * libmodest-dbus-client/libmodest-dbus-client.c:
1873 * libmodest-dbus-client/libmodest-dbus-client.h:
1874 * tests/dbus_api/Makefile.am:
1875 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1876 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1878 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1880 * src/maemo/easysetup/modest-easysetup-wizard.c:
1881 (create_page_account_details):
1882 * src/maemo/modest-account-settings-dialog.c:
1883 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1884 widgets, because this might not be the default in future versions of the Maemo GTK+.
1885 However, I can not not get capitalization to work even in a simple test case.
1887 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1889 * src/maemo/easysetup/modest-easysetup-wizard.c:
1890 (create_page_custom_incoming), (create_page_custom_outgoing):
1891 * src/maemo/modest-account-settings-dialog.c:
1892 (create_page_account_details), (create_page_incoming),
1893 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1894 instead of using gtk_check_button_with_label(), so they are aligned like the other
1895 widgets, as per the UI spec.
1897 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1899 * src/maemo/easysetup/modest-easysetup-wizard.c:
1900 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1901 * src/widgets/modest-validating-entry.c:
1902 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1903 Modest prefix instead of an EasySetup prefix.
1905 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1907 * src/widgets/modest-validating-entry.h:
1908 * src/widgets/modest-validating-entry.c: (on_insert_text),
1909 Added easysetup_validating_entry_set_max_func(), used to set a callback
1910 to call when the max number of characters is reached. GtkEntry has a max-length
1911 already but is silent about it.
1913 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1914 (create_page_account_details), (create_page_user_details),
1916 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1917 (create_page_account_details), (create_page_user_details),
1918 (create_page_outgoing):
1919 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1920 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1921 the UI spec, when the user tries to enter more than the max number of characters.
1923 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1925 * src/maemo/easysetup/modest-easysetup-wizard.c:
1926 (create_page_user_details), (create_page_custom_incoming),
1927 (create_page_custom_outgoing):
1928 * src/maemo/modest-account-settings-dialog.c:
1929 (create_page_user_details), (create_page_incoming),
1930 (create_page_outgoing):
1931 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1932 (modest_connection_specific_smtp_edit_window_init):
1933 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1934 not appropriate. Bad Maemo-specific defaults!.
1936 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1938 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1939 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1940 (modest_signature_editor_dialog_set_settings):
1941 Disable the label and textview when the checkbox is disabled, and use the
1942 specified (UI spec) default signature text.
1944 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1946 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1947 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1949 * src/modest-defs.h:
1950 * src/modest-account-mgr-helpers.h:
1951 * src/modest-account-mgr-helpers.c:
1952 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1954 * src/maemo/Makefile.am:
1955 * src/maemo/modest-signature-editor-dialog.c:
1956 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1959 * src/maemo/modest-account-settings-dialog.h:
1960 * src/maemo/modest-account-settings-dialog.c:
1961 (modest_account_settings_dialog_finalize), (on_button_signature),
1962 (save_configuration): Use the new dialog when the Edit button is pressed, and
1963 save the changes if necessary, as per the UI spec.
1965 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1967 * src/maemo/Makefile.am:
1968 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1969 based on maemo-develoers email from Dirk.
1971 * src/maemo/easysetup/modest-easysetup-wizard.c:
1972 (create_page_welcome), (create_page_account_details),
1973 (create_page_user_details), (create_page_complete_easysetup),
1974 (create_page_custom_incoming), (create_page_custom_outgoing),
1975 (create_page_complete_custom),
1976 (modest_easysetup_wizard_dialog_init):
1977 * src/maemo/modest-account-settings-dialog.c:
1978 (create_page_account_details), (create_page_user_details),
1979 (create_page_incoming), (create_page_outgoing),
1980 (modest_account_settings_dialog_init):
1981 * src/maemo/modest-connection-specific-smtp-window.c:
1982 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1984 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1986 * src/maemo/easysetup/modest-easysetup-wizard.c:
1987 (create_page_account_details), (create_page_custom_outgoing),
1988 (create_page_complete_custom):
1989 * src/maemo/modest-account-settings-dialog.c:
1990 (create_page_user_details), (create_page_incoming),
1991 (create_page_outgoing):
1992 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1993 (modest_connection_specific_smtp_edit_window_init):
1994 Use the correct (UI spec) port min/max, and use horizontal separators,
1997 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1999 * src/maemo/easysetup/modest-easysetup-wizard.c:
2000 (set_default_custom_servernames):
2001 * src/maemo/modest-account-settings-dialog.c:
2002 (create_page_incoming), (on_combo_outgoing_security_changed),
2003 (on_combo_incoming_security_changed), (create_page_outgoing),
2004 (modest_account_settings_dialog_set_account_name),
2005 (save_configuration):
2006 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2007 (on_combo_security_changed),
2008 (modest_connection_specific_smtp_edit_window_init),
2009 (modest_connection_specific_smtp_edit_window_set_connection),
2010 (modest_connection_specific_smtp_edit_window_get_settings):
2011 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2014 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2017 * src/maemo/easysetup/modest-easysetup-wizard.c:
2018 (create_page_custom_outgoing), (create_page_complete_custom):
2019 * src/maemo/modest-account-settings-dialog.c:
2020 (create_page_user_details), (create_page_outgoing):
2021 * src/maemo/modest-account-view-window.c: (button_box_new):
2022 Use changed logical IDs as per the most recent UI spec:
2023 mcen_bd_emailsetup_edit -> mcen_bd_edit
2024 mcen_bd_emailsetup_delete -> mcen_bd_delete
2025 mcen_bd_emailsetup_close -> mcen_bd_close
2027 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2031 * src/dbus_api/Makefile.am:
2032 * src/dbus_api/modest-dbus-callbacks.c:
2033 * src/dbus_api/modest-dbus-callbacks.h:
2034 * src/maemo/modest-platform.c: (modest_platform_init):
2035 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2037 * tests/Makefile.am:
2038 * tests/dbus_api/Makefile.am:
2039 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2041 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2043 * src/maemo/modest-account-settings-dialog.c:
2044 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2045 Removed unnecessary includes.
2047 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2049 * src/maemo/easysetup/modest-easysetup-wizard.c:
2050 * src/maemo/modest-account-settings-dialog.c:
2051 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2052 * src/widgets/Makefile.am:
2053 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2054 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2055 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2056 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2057 * src/widgets/modest-secureauth-combo-box.c:
2058 * src/widgets/modest-secureauth-combo-box.h:
2059 * src/widgets/modest-serversecurity-combo-box.c:
2060 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2061 made the GObject names more consistent with the rest of the Modest code.
2063 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2065 * src/maemo/easysetup/Makefile.am:
2066 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2067 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2068 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2069 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2070 * src/maemo/easysetup/modest-easysetup-wizard.c:
2071 * src/maemo/easysetup/modest-validating-entry.c:
2072 * src/maemo/easysetup/modest-validating-entry.h:
2073 * src/maemo/modest-account-settings-dialog.c:
2074 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2075 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2076 widgets/ because they are used outside of easysetup too. After checking in,
2077 svn will allow me to rename them too.
2079 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2081 * src/gnome/modest-msg-edit-window.c:
2082 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2083 linker error, to fix the build on the GNOME platform.
2084 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2085 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2086 ifdefed out to avoid a warning.
2088 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2090 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2091 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2092 some alternative for GTK+ 2.6.
2094 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2096 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2098 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2099 specified for EmailAccountsDialog in UI spec.
2101 * src/maemo/easysetup/modest-easysetup-wizard.c:
2102 * src/maemo/easysetup/modest-easysetup-wizard.h:
2103 * src/maemo/modest-account-settings-dialog.c:
2104 * src/maemo/modest-account-settings-dialog.h:
2105 Reuse a member window widget for the connection-specific SMTP server accounts,
2106 so we can tell it to create/save the accounts only if we actually save changes.
2108 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2109 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2110 (modest_connection_specific_smtp_edit_window_get_settings):
2111 Return a struct instance for temporarily remembering the entered data.
2113 * src/maemo/modest-connection-specific-smtp-window.h:
2114 * src/maemo/modest-connection-specific-smtp-window.c:
2115 (modest_connection_specific_smtp_window_finalize),
2116 (modest_connection_specific_smtp_window_fill_with_connections),
2118 (modest_connection_specific_smtp_window_save_server_accounts),
2119 (update_model_server_names): Do not actually save data until asked,
2120 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2122 (on_selection_changed),
2123 (modest_connection_specific_smtp_window_init): Disable the edit
2124 button when nothing is selected.
2126 * src/modest-account-mgr-helpers.c:
2127 * src/modest-account-mgr-helpers.h:
2128 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2131 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2133 * src/modest-account-mgr-helpers.h:
2134 * src/modest-account-mgr-helpers.c:
2135 (modest_account_mgr_get_unused_account_name),
2136 (modest_account_mgr_get_unused_account_display_name): Added these
2137 utility functions, to avoid code duplication.
2139 * src/maemo/easysetup/modest-easysetup-wizard.c:
2140 (create_page_account_details), (create_account):
2141 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2142 (on_combo_security_changed),
2143 (modest_connection_specific_smtp_edit_window_init),
2144 (modest_connection_specific_smtp_edit_window_save_settings):
2145 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2146 * src/maemo/modest-connection-specific-smtp-window.c:
2147 (modest_connection_specific_smtp_window_finalize),
2148 (modest_connection_specific_smtp_window_fill_with_connections),
2149 (on_button_edit), (modest_connection_specific_smtp_window_init):
2150 * src/maemo/modest-connection-specific-smtp-window.h:
2151 Implementing saving of connection-specific server accounts.
2153 But I need to refactor this so we can save the data for each
2154 possible connection-specific account and only actually create the server accounts
2155 when the easysetup finished, or the OK button is pressed on the account settings
2158 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2160 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2161 (on_combo_security_changed):
2162 (modest_connection_specific_smtp_edit_window_init):
2163 Auto-fill the port number as in the account settings.
2165 (modest_connection_specific_smtp_edit_window_set_connection):
2166 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2167 * src/maemo/modest-connection-specific-smtp-window.c:
2168 (fill_with_connections), (on_button_edit),
2169 (modest_connection_specific_smtp_window_init):
2170 Turn the edit window into a dialog to simplify the code, and
2171 set a WM hint as in a GtkDialog, because only a popup can be on top of
2172 another window in Maemo, and popups usually have no WM decoration.
2174 * src/modest-defs.h:
2175 * src/modest-account-mgr-helpers.c:
2176 (modest_account_mgr_set_connection_specific_smtp),
2177 (modest_account_mgr_remove_connection_specific_smtp),
2178 (modest_account_mgr_get_connection_specific_smtp):
2179 * src/modest-account-mgr-helpers.h: Some functions to write the
2180 connection-specific SMTP server information. Not yet used.
2183 * src/widgets/modest-folder-view.c: (text_cell_data):
2184 Fix a warning about an uninitialized variable.
2185 (on_configuration_key_changed): Put an #ifdef around the use
2186 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2188 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2190 * src/maemo/modest-account-settings-dialog.h:
2191 * src/maemo/modest-account-settings-dialog.c:
2192 Added connect_for_modified() utility function to mark the new modified boolean.
2194 (create_page_account_details), (create_page_user_details),
2195 (create_page_incoming), (create_page_outgoing), (on_response),
2196 (modest_account_settings_dialog_init),
2197 (modest_account_settings_dialog_set_account_name):
2198 Only warn about unsaved changes when there are actually unsaved changes.
2200 * src/modest-account-mgr-helpers.c:
2201 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2202 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2203 to get the data from there in future.
2205 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2207 * src/modest-defs.h:
2209 * src/modest-account-mgr-helpers.h:
2210 * src/modest-account-mgr-helpers.c:
2211 Store the security account setting in a single conf key instead of using
2212 the options list, so that the list is left for just the to-be-removed camel hack,
2213 and because gconf_client_set_list() is failing for some reason.
2215 * src/modest-account-mgr.c:
2216 (modest_account_mgr_add_server_account):
2217 * src/maemo/modest-account-settings-dialog.c:
2218 (modest_account_settings_dialog_set_account_name),
2219 (save_configuration): Use the renamed functions.
2222 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2224 * src/widgets/Makefile.am:
2225 * src/widgets/modest-limit-retrieve-combo-box.c:
2226 * src/widgets/modest-limit-retrieve-combo-box.h:
2227 * src/widgets/modest-retrieve-combo-box.c:
2228 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2229 the account settings dialog.
2231 * src/modest-defs.h:
2232 * src/modest-account-mgr-helpers.h:
2233 * src/modest-account-mgr-helpers.c:
2234 (modest_server_account_get_option_secure_auth),
2235 (modest_server_account_set_option_secure_auth):
2236 * src/modest-account-mgr.c:
2237 (modest_account_mgr_add_server_account):
2238 Use the existing AUTH_MECH conf key for the secure-auth setting,
2239 instead of putting it in the list options, because this was actually used already.
2241 * src/maemo/modest-account-settings-dialog.c:
2242 (create_page_account_details),
2243 (modest_account_settings_dialog_set_account_name),
2244 (save_configuration):
2245 * src/maemo/modest-account-settings-dialog.h:
2246 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2247 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2249 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2251 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2252 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2253 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2255 * src/modest-defs.h:
2256 * src/maemo/modest-account-settings-dialog.c:
2257 (create_page_incoming), (on_combo_outgoing_security_changed),
2258 (on_combo_incoming_security_changed), (create_page_outgoing),
2259 (modest_account_settings_dialog_set_account_name),
2260 (save_configuration): Load/Save the port number, and change it when the
2261 security combo changes, to suitable defaults.
2263 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2265 * src/modest-account-mgr.c:
2266 (modest_account_mgr_add_server_account): Set the security and secure-auth
2267 options, and add a comment saying that the other camel-specific options should be
2270 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2272 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2274 * src/modest-tny-account-store.c: (account_list_free),
2275 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2276 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2279 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2281 * src/modest-protocol-info.c:
2282 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2283 is required by our UI spec. Maybe something in our implementation will use this eventually.
2284 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2285 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2286 instead of the previous 0 placeholder.
2288 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2289 secure-auth settings.
2290 * src/modest-account-mgr-helpers.h:
2291 * src/modest-account-mgr-helpers.c:
2292 (modest_server_account_data_get_option_secure_auth),
2293 (modest_server_account_set_option_secure_auth),
2294 (modest_server_account_data_get_option_security),
2295 (modest_server_account_set_option_security): Added this API for getting and setting the security
2296 and secure-auth settings.
2298 * src/maemo/modest-account-settings-dialog.h:
2299 * src/maemo/modest-account-settings-dialog.c:
2300 (modest_account_settings_dialog_finalize), (check_data),
2301 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2302 about changing titles.
2303 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2304 (save_configuration): Save the security and secure-auth settings.
2306 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2307 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2309 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2311 * src/modest-defs.h:
2312 * src/modest-account-mgr.c:
2313 (modest_account_mgr_add_server_account):
2314 Added and used defines for the options key and value pair strings,
2315 that are used so far, though they do not seem to correspond to anything in our
2316 UI specs or ModestProtocol enum.
2318 * src/modest-account-mgr-helpers.h:
2319 * src/modest-account-mgr-helpers.c:
2320 (compare_option_strings_for_name),
2321 (modest_server_account_data_get_option_value),
2322 (modest_server_account_data_get_option_bool),
2323 (modest_account_mgr_get_server_account_option):
2324 Added helper functions for parsing the options GSList.
2326 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2328 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2329 display name is based on the supplied account name.
2330 * src/modest-account-mgr.c:
2331 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2332 with an inefficient, but good-enough, implementation.
2334 * src/maemo/easysetup/modest-easysetup-wizard.c:
2335 (create_page_account_details), (on_before_next), (create_account):
2336 Check for existing display names rather than (non-user-visible) account names, and just
2337 create and set a unique account name at the end.
2339 * src/maemo/modest-account-settings-dialog.c:
2340 (modest_account_settings_dialog_init),
2341 (modest_account_settings_dialog_set_account_name),
2342 (create_page_incoming): Show the display name, instead of the account name.
2343 (on_response): Do some (not all) extra checks, as in the UI spec.
2344 (save_configuration): Save the display name if it was changed.
2346 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2348 * po/en_GB.po: Added needed logical ID and translation.
2349 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2350 (init_view): Made the is-default column clicking work.
2352 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2355 * src/maemo/easysetup/Makefile.am:
2356 * src/maemo/easysetup/modest-easysetup-wizard.c:
2357 (modest_easysetup_wizard_dialog_init):
2358 * src/maemo/easysetup/provider-data-test.keyfile:
2359 * src/maemo/easysetup/provider-data.keyfile:
2360 Moved the provider data file to the new modest-providers-data package and used it from there.
2362 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2364 * src/modest-local-folder-info.c:
2365 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2366 N_() was already used on the static strings, but this just marks it for translation without
2367 using the translation.
2369 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2371 * src/maemo/modest-account-settings-dialog.c:
2372 (create_page_incoming),
2373 (modest_account_settings_dialog_set_account_name):
2374 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2375 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2376 I will do this if nobody else gets there first.
2378 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2380 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2381 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2382 save the security stuff.
2384 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2386 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2387 Set the email address and user fullname, which I now see must be
2390 * src/maemo/modest-account-settings-dialog.h:
2391 * src/maemo/modest-account-settings-dialog.c:
2393 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2394 leave-on-server and authentication.
2395 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2398 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2401 * src/maemo/modest-account-settings-dialog.c:
2402 * src/maemo/modest-account-settings-dialog.h:
2403 Most (but not all) of the widgets are now present as specified by the UI spec.
2404 No changes are yet saved, and some details are not properly shown yet.
2406 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2408 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2410 * src/maemo/Makefile.am:
2411 * src/maemo/modest-account-settings-dialog.c:
2412 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2413 an existing account. Doesn't do much yet.
2415 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2416 Open the accounts settings dialog when Edit is clicked.
2418 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2420 * src/maemo/easysetup/Makefile.am:
2421 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2423 * src/maemo/easysetup/modest-easysetup-wizard.c:
2424 (modest_easysetup_wizard_dialog_init):
2425 Try to get the source directory from the build system,
2426 instead of hard-coding "./" into the source code, when opening our local
2427 copies of the configuration files.
2428 But this still fails when opening the wizard from the Accounts window,
2429 maybe because the working directory seems to change at runtime.
2430 So the wizard will fail the second time unless you copy the files into their
2431 proper locations - see the stdout warnings for the paths.
2433 (create_page_account_details),(on_before_next):
2434 Check for existing non-server accounts instead of server accounts,
2435 so the default account name is useful again, and to prevent trying to
2438 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2439 Show the wizard when New is clicked.
2441 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2442 (init_view): Show the column headers, and show the columns that are
2443 specified in the UI specs. However, something in Maemo's GTK+ prevents
2444 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2445 change the default account. This is despite unsetting the special properties.
2447 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2449 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2450 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2451 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2452 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2453 to make that clearer.
2454 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2456 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2458 * src/maemo/modest-account-view-window.c:
2459 (modest_account_view_window_init),
2460 (modest_account_view_window_new):
2461 Use the same buttons as specified in the
2462 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2463 the existing widgets, which never had a chance of working.
2464 Put the ModestAccountView treeview in a scrolled window.
2465 Do not repeat the initialization in both _init() and _new().
2467 * src/widgets/modest-account-view.c: (update_account_view):
2468 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2469 this widget and window shows no accounts.
2471 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2473 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2475 * src/maemo/easysetup/modest-easysetup-wizard.c:
2476 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2477 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2478 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2481 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2482 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2483 accounts exist yet, as in the UI spec.
2485 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2487 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2489 * src/maemo/Makefile.am:
2490 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2491 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2492 New window for editing connection-specific smtp details.
2493 Not fully implemented.
2495 * src/maemo/modest-connection-specific-smtp-window.c:
2496 (modest_connection_specific_smtp_window_finalize) :
2497 unref the tree model.
2498 (on_button_edit): Show the edit window.
2500 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2502 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2505 * src/maemo/Makefile.am:
2506 * src/maemo/modest-connection-specific-smtp-window.c:
2507 * src/maemo/modest-connection-specific-smtp-window.h:
2508 New window for showing the list of connections, for connection-specific
2509 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2510 * src/maemo/easysetup/modest-easysetup-wizard.c:
2511 (create_page_custom_outgoing): Show the new window when the button is clicked.
2513 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2515 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2516 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2517 * src/maemo/modest-msg-edit-window.c:
2518 (modest_msg_edit_window_insert_image):
2519 * src/modest-conf.c: (modest_conf_key_escape):
2520 * src/modest-mail-operation.c:
2521 (modest_mail_operation_send_new_mail):
2522 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2523 (modest_ui_actions_on_new_account):
2524 * src/widgets/modest-attachment-view.c: (update_filename_request):
2525 * src/widgets/modest-mail-header-view.c:
2526 Corrected warnings that were breaking the build, by commenting out unused variables,
2527 and a function, and by including a header.
2529 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2531 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2532 so we can #ifdef around platform-specific code when necessary.
2533 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2534 to allow this to build for the GNOME platform too.
2536 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2538 * src/maemo/easysetup/modest-easysetup-wizard.c:
2539 Added util_increment_name() and used it in create_page_account_details()
2540 to make sure that the default account name is always a new name.
2542 (modest_easysetup_wizard_dialog_init),
2543 (set_default_custom_servernames): Some minor memory management fixes.
2545 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2549 * src/modest-runtime.c: (init_i18n): Restored the translation
2550 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2551 are defined in config.h, and the translations are installed.
2553 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2554 is defined for translation.
2556 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2558 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2560 * src/maemo/easysetup/modest-easysetup-wizard.c:
2561 (modest_easysetup_wizard_dialog_init):
2562 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2563 Use realistic paths (though they should use $prefix generically) to the
2564 mcc_mapping and provider-data.keyfile files which might work when they
2565 are installed by the future version of the operator-wizard package,
2566 and then fallback to paths in our source code, with an explanatory
2569 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2573 * src/maemo/Makefile.am:
2574 * src/maemo/easysetup/: Added files from the previously-exernal
2575 osso-modest-easysetup.
2576 * src/maemo/modest-main-window-ui.h:
2577 * src/modest-ui-actions.c:
2578 * src/modest-ui-actions.h:
2579 Added modest_ui_actions_on_new_account() as a signal handler for the
2580 New Account menu item. It shows the easysetup wizard.
2581 * po/en_GB.po: Added additional needed logical IDs and translations.
2583 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2584 Apparently ChangeLog is not used for some vague Nokia legal reasons.