1 2007-06-14 Murray Cumming <murrayc@murrayc.com>
3 * src/widgets/modest-folder-view.c: (filter_row):
4 Explictly filter out the per-account outbox accounts. I don't know why
5 these only sometimes show up, but now they should never show up in the UI.
6 This should fix projects.maemo.org bug NB#60160.
8 2007-06-14 Murray Cumming <murrayc@murrayc.com>
10 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
11 when the toolbar does not exist yet.
12 * src/modest-widget-memory.c: (save_settings_header_view):
13 Added g_warnings() to help us to discover when we are trying to set
14 an empty columns list in gconf.
16 2007-06-14 Murray Cumming <murrayc@murrayc.com>
20 Added modest_init_get_default_header_view_column_ids().
22 * src/modest-widget-memory.c: (restore_settings_header_view):
23 Use the new function to get defaults, if the gconf key is empty,
24 instead of not creating any columns. This seems to fix the
25 empty right-hand pane problems.
27 * src/widgets/modest-header-view.h: Improved documentation.
29 2007-06-13 Murray Cumming <murrayc@murrayc.com>
31 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
32 Revert the use of the display name as the account name, because this
33 is generally wrong and would break the code that follows.
35 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
37 * src/maemo/easysetup/modest-easysetup-wizard.c:
38 (check_for_supported_auth_methods), (on_before_next),
41 More correct fix for projects.maemo.org bug NB# 58991
42 Do not longer accept AUTH_PASSWORD as secure method and choose
43 correct method when creating the account.
45 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
47 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
48 Fixed projects.maemo.org bug NB# 58991
50 2007-06-13 Murray Cumming <murrayc@murrayc.com>
52 * src/modest-init.c: (modest_init_init_core),
53 (modest_init_local_folders): Fixed compilation errors.
55 2007-06-13 Murray Cumming <murrayc@murrayc.com>
57 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
58 Remove unnecessary lib/include, though it is good in principle when needed.
60 * src/modest-init.c: (modest_init_one_local_folder),
61 (modest_init_local_folders):
62 * src/modest-init.h: Initialize the .modest library for memory cards,
63 instead of just doing nothing for them. This should allow us to create
64 folders there, fixing projects.maemo.org bug NB#59297.
66 2007-06-13 Murray Cumming <murrayc@murrayc.com>
68 * libmodest-dbus-client/libmodest-dbus-client.c:
69 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
70 (libmodest_dbus_client_compose_mail),
71 (libmodest_dbus_client_open_message),
72 (libmodest_dbus_client_send_and_receive),
73 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
75 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
76 (on_idle_open_message), (modest_dbus_req_handler),
77 (search_result_to_message), (modest_dbus_req_filter):
78 * src/modest-search.c: (add_hit), (modest_search_folder),
79 (modest_search_all_accounts): Improved debug messages.
81 * tests/dbus_api/test_open_message.c: (main): Improved comments.
83 * src/modest-tny-account-store.c:
84 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
87 2007-06-13 Murray Cumming <murrayc@murrayc.com>
90 2007-06-12 Murray Cumming <murrayc@murrayc.com>
92 * src/modest-tny-account-store.c: (get_server_accounts):
93 Call modest_tny_local_folders_account_add_merged_outbox_folders()
94 even when there are no accounts, so that the Outbox folder is always
95 visible. This fixes projects.maemo.org bug NB#60158.
97 2007-06-12 Murray Cumming <murrayc@murrayc.com>
99 * src/maemo/modest-main-window.c: (create_details_widget):
100 Use the mcen_va_never logical ID.
102 2007-06-12 Murray Cumming <murrayc@murrayc.com>
104 * src/dbus_api/modest-dbus-api.h:
105 * src/dbus_api/modest-dbus-callbacks.c:
106 (on_idle_open_default_inbox), (on_open_default_inbox),
107 (modest_dbus_req_handler):
108 Added a new OpenDefaultInbox method.
110 * libmodest-dbus-client/libmodest-dbus-client.h:
111 * libmodest-dbus-client/libmodest-dbus-client.c:
112 Added libmodest_dbus_client_open_default_inbox() to call the new
113 dbus method. This should be useful to projects.maemo.org bug NB#57214,
114 though it should maybe be used by a new osso-email-interface function.
116 * tests/dbus_api/Makefile.am:
117 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
120 2007-06-12 Murray Cumming <murrayc@murrayc.com>
122 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
123 NULL, so that the signals get all the keys. This should not actually
124 change any behaviour because we currently update everything when anything
127 2007-06-12 Murray Cumming <murrayc@murrayc.com>
129 * src/widgets/modest-folder-view.c: (text_cell_data),
130 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
131 (find_inbox_iter): If tinymail tells us that the folder is
132 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
133 This causes the inbox to be selected at startup, fixing part of
134 projects.maemo.org bug NB#56305.
136 * src/modest-ui-dimming-rules.c:
137 (modest_ui_dimming_rules_on_tools_smtp_servers):
138 * src/modest-ui-dimming-rules.h: Added a callback function to dim
139 the SMTP servers menu item.
140 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
141 that the SMTP Servers menu item is dimmed when there are no accounts,
142 as a future version of the UI spec will require. This fixes
143 projects.maemo.org bug NB#56305.
145 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
147 * src/maemo/modest-maemo-utils.c:
148 (modest_maemo_utils_get_supported_secure_authentication_methods):
149 Added label to dialog instead of unreadable title
151 * src/maemo/modest-main-window.c: (sync_accounts_cb),
152 (modest_main_window_new):
153 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
156 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
157 * src/modest-account-mgr.h:
158 Added method to avoid code duplication
160 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
161 (modest_ui_actions_on_send_receive):
162 Use modest_account_mgr_has_accounts
164 2007-06-11 Murray Cumming <murrayc@murrayc.com>
166 * src/maemo/easysetup/modest-presets.c:
167 (modest_presets_get_info_server_security): Do not report secure auth
169 * src/modest-protocol-info.c: Use the defines for the gconf key names
170 for secure authentication. This was not working because we were writing
171 Password and reading password, and the check was case sensitive.
172 With this, gmail now works for receiving and sending when created via
175 2007-06-11 Murray Cumming <murrayc@murrayc.com>
177 * src/maemo/easysetup/modest-presets.c:
178 (modest_presets_get_info_server_security): Correct the key name for
179 SecureSmtp, because it seems to be case-sensitive.
180 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
181 Do not try to get the 0th notebook page if there are 0 pages, to
184 2007-06-11 Murray Cumming <murrayc@murrayc.com>
186 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
187 Prevent use of the new notification feature for now, because it currently
188 shows one dialog for each new email, which is annoying.
190 2007-06-11 Murray Cumming <murrayc@murrayc.com>
192 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
193 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
194 when no country was selected, so that we show the global ones.
195 * src/maemo/easysetup/modest-presets.c:
196 (modest_presets_get_providers): Return only the global providers, not
197 all providers when mmc=0 was requested.
199 2007-06-11 Murray Cumming <murrayc@murrayc.com>
201 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
202 (easysetup_provider_combo_box_fill): Remove debug code that showed the
203 provider ID in the combo.
205 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
206 Do not show the page numbers, because it would be confusing when we add
207 the 2 extra pages for the custom setup, when the user chooses the "Other"
208 provider. This fixes projects.maemo.org bug NB#59028
210 * src/modest-init.c: (modest_init_init_core),
211 (modest_init_local_folders):
213 * src/modest-tny-account.c:
214 (modest_tny_account_new_for_local_folders): Do not create default folders
215 for the memory card. This should fix projects.maemo.org bug NB#59328.
217 2007-06-11 Murray Cumming <murrayc@murrayc.com>
219 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
220 Free the changed_conf_keys string items. They are already freed in the
221 idle handler if that runs first.
223 2007-06-11 Murray Cumming <murrayc@murrayc.com>
225 * src/modest-ui-actions.c:
226 (modest_ui_actions_on_password_requested): Check that the server name
227 is not NULL, because I just saw a password dialog with (null) as the
230 * src/modest-tny-folder.[h|c]: Added
231 modest_tny_folder_is_memory_card_folder().
232 * src/modest-ui-dimming-rules.c:
233 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
234 menu item for memory cards, as per the UI spec (section 7.4). This should
235 fix projects.maemo.org bug NB#59297.
237 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
239 * src/maemo/modest-main-window.c: (sync_accounts_cb):
240 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
241 is another problem with the code, see Murray's comment at line 772)
243 2007-06-08 Murray Cumming <murrayc@murrayc.com>
245 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
246 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
247 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
248 (load_from_file), (easysetup_country_combo_box_init),
249 (easysetup_country_combo_box_get_active_country_ids),
250 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
251 instead of just one ID, to avoid duplicate country names in the UI.
253 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
254 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
255 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
256 a single ID, avoiding duplicate providers.
257 * src/maemo/easysetup/modest-easysetup-wizard.c:
258 (on_combo_account_country): Adapt to use a list.
260 2007-06-08 Murray Cumming <murrayc@murrayc.com>
262 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
263 keys changed in the last X seconds.
265 * src/modest-account-mgr.h:
266 * src/modest-account-mgr.c: (on_timeout_notify_changes),
267 (on_key_change), (modest_account_mgr_class_init),
268 (modest_account_mgr_init), (modest_account_mgr_finalize):
269 As the keys are changed, save them in a GSList* and signal that GSList*
270 further every X seconds, to batch changes, to allow us to do just one
271 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
272 bug NB#56941 and other (UI-blocking) delays when changing account settings.
274 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
275 changed signal signature.
277 * src/modest-conf.c: (modest_conf_set_list),
278 (modest_conf_on_change): Reenable notification.
280 (modest_conf_maemo_fake_on_change): Comment out the hack that
281 notified immediately instead of asynchronously.
283 * src/widgets/modest-account-view.h:
284 * src/widgets/modest-account-view.c:
285 (update_account_view): Select the previously-selected account ID,
286 if possible. This fixes projects.maemo.org bug NB#56933.
288 (on_account_changed), (on_account_removed),
289 (modest_account_view_select_account):
291 Remove the block/unblock functions
292 because they were not useful.
294 * src/maemo/modest-account-view-window.c:
295 (on_delete_button_clicked), (on_edit_button_clicked),
296 (on_new_button_clicked): Remove the use of the non-working block/unblock.
298 2007-06-08 Murray Cumming <murrayc@murrayc.com>
300 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
301 Improve the error dialog to show Incorrect Account Settings, which seems
302 clearer, and say that the internal error message (to be removed from the
303 dialog later) is often misleading.
304 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
306 * src/modest-tny-account.c:
307 (modest_tny_account_new_from_server_account): Uncomment the printf of the
308 URL because this is so useful for debugging on the device.
310 * src/widgets/modest-serversecurity-combo-box.c:
311 (modest_serversecurity_combo_box_fill): Correct a logical ID.
313 2007-06-08 Murray Cumming <murrayc@murrayc.com>
315 * src/modest-mail-operation.c:
316 (modest_mail_operation_send_new_mail):
317 Added a comment about a nasty but apparently harmless message. Details
318 added to the wiki g_warnings() page.
320 2007-06-08 Murray Cumming <murrayc@murrayc.com>
322 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
323 (modest_tny_send_queue_class_init):
324 Do not use the priv struct because it is empty, to avoid g_warnings
325 about a non-existant priv struct.
327 * src/modest-tny-account-store.c:
328 (modest_tny_account_store_get_server_account),
329 (modest_tny_account_store_get_transport_account_for_open_connection
330 ): Do not try to get transport server accounts for local folders,
331 because they don't have any. This avoids a g_warning().
333 * src/maemo/modest-main-window.c:
334 (modest_main_window_notify_send_receive_initied),
335 (on_configuration_key_changed):
336 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
338 * src/modest-mail-operation.c:
339 (modest_mail_operation_update_account):
340 * src/modest-tny-account-store.h:
341 * src/modest-tny-account.c:
342 (modest_tny_account_get_special_folder),
343 (modest_tny_account_new_for_local_folders),
344 (modest_tny_account_new_for_per_account_local_outbox_folder):
345 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
346 * src/modest-tny-local-folders-account.c:
347 (add_account_folders_to_merged_folder):
348 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
349 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
350 (modest_ui_actions_on_send):
351 * src/widgets/modest-folder-view.c: (update_model):
352 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
353 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
354 modest_tny_account_store_get_tny_account_by_account() to
355 modest_tny_account_store_get_server_account() to make the code clearer.
357 2007-06-07 Marcus Bauer <marcusb@openismus.com>
359 * src/dbus_api/modest-dbus-api.h:
360 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
361 * src/maemo/modest-msg-edit-window.c:
362 (modest_msg_edit_window_attach_file_noninteractive):
363 added g_warning in case the file to be attached does not exist
364 * tests/dbus_api/test_compose_mail.c: (main):
365 removed obsolete comment, added generic files as test case
367 2007-06-07 Murray Cumming <murrayc@murrayc.com>
369 * src/modest-tny-account-store.c: (get_server_accounts):
370 Create the local folders account only once, not once for each outbox, and
371 not only when there are some outboxes.
373 2007-06-07 Murray Cumming <murrayc@murrayc.com>
375 * src/widgets/modest-folder-view.c: (update_model): Comment out some
376 code that is causing a crash at startup. Sergio says that he is fixing this.
378 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
380 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
381 * src/maemo/modest-account-settings-dialog.c:
382 (create_page_outgoing),
383 (modest_account_settings_dialog_set_account_name),
384 (save_configuration):
385 - Fixed handling of the "Use secure authentication" toggle to comply with
386 the ui specification. See also projects.maemo.org bug NB#58400
388 - Restore the Secure connection setting combo correctly when loading
391 * src/maemo/modest-maemo-utils.c:
392 (on_camel_account_get_supported_secure_authentication),
393 (modest_maemo_utils_get_supported_secure_authentication_methods):
394 Fixed a crasher if operation is canceled
396 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
397 (modest_protocol_info_auth_is_secure):
398 * src/modest-protocol-info.h:
400 Added two new methods to determine if a protocol/auth method is secure/encrypted in
401 the sense of the "Use secure authentication" toggle.
403 2007-06-07 Murray Cumming <murrayc@murrayc.com>
405 * src/modest-tny-account-store.h:
406 * src/modest-tny-account-store.c:
407 Added modest_tny_account_store_get_local_folders_account().
409 * src/modest-tny-folder.h:
410 * src/modest-tny-folder.c:
411 (modest_tny_folder_get_account):
412 Added this replacement for tny_folder_get_account() which returns
413 the local-folders account for TnyMergeFolders, to avoid the
414 warning about the unimplemented get_account_func() vfunc().
416 (modest_tny_folder_get_rules),
417 * src/modest-ui-actions.c:
418 (modest_ui_actions_on_folder_selection_changed):
419 * src/modest-mail-operation.c:
420 (modest_mail_operation_remove_folder),
421 (modest_mail_operation_xfer_folder),
422 (modest_mail_operation_rename_folder),
423 (modest_mail_operation_get_msg),
424 (modest_mail_operation_get_msgs_full),
425 (modest_mail_operation_remove_msg),
426 (modest_mail_operation_xfer_msgs),
427 (modest_mail_operation_refresh_folder):
428 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
430 2007-06-07 Murray Cumming <murrayc@murrayc.com>
432 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
433 (modest_server_account_set_security):
434 * src/modest-defs.h: Add comments explaining that our
435 UI spec means TLS when it says Normal, so these do not look like errors.
437 * src/modest-tny-account.c:
438 (modest_tny_account_new_from_server_account): Use the new tinymail
439 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
440 for TLS. This should fix projects.maemo.org bug NB#58460.
442 2007-06-06 Murray Cumming <murrayc@murrayc.com>
444 * src/maemo/easysetup/modest-easysetup-wizard.c:
445 (create_account): Correct the position of the gconf sanity check warning.
446 (on_button_edit_advanced_settings): Show the dialog immediately, instead
447 of using the g_idle_add() hack, because this does not seem to be necessary
448 on osso 1.1. It might even work on Maemo Bora if the problems were actually
449 caused by something other than maemo's gconf.
450 This fixes projects.maemo.org bug #59022.
452 2007-06-06 Murray Cumming <murrayc@murrayc.com>
454 * src/modest-account-mgr-helpers.c:
455 (modest_account_mgr_get_default_account): Do not check that the account
456 exists if there is no default account (NULL), to fix a runtime warning.
458 2007-06-06 Murray Cumming <murrayc@murrayc.com>
460 * src/widgets/modest-folder-view.c: (update_model):
461 Do not unref the treemodel before we have finished with it.
462 This prevents a valgrind warning and an occasional crash at startup.
464 2007-06-06 Marcus Bauer <marcusb@openismus.com>
466 * libmodest-dbus-client/libmodest-dbus-client.h:
467 added libmodest_dbus_client_compose_mail()
468 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
470 added functions needed for SendAsMail() functionality
471 * src/maemo/modest-msg-edit-window.c:
472 (modest_msg_edit_window_attach_file_noninteractive):
473 non interactively attaching files to message edit window
474 * src/widgets/modest-msg-edit-window.h:
475 * tests/dbus_api/Makefile.am:
476 added test_compose_mail.c
477 * tests/dbus_api/test_compose_mail.c: (main):
479 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
481 * src/modest-account-view.c:
482 Fixed bug projects.maemo.org bug NB#59307
484 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
486 * src/maemo/easysetup/modest-easysetup-wizard.c:
487 (get_serverport_incoming), (on_before_next), (create_account):
488 * src/maemo/modest-account-settings-dialog.c:
489 (modest_account_settings_dialog_set_account_name):
490 * src/maemo/modest-maemo-utils.c:
491 (on_camel_account_get_supported_secure_authentication_status),
492 (on_camel_account_get_supported_secure_authentication),
493 (on_secure_auth_cancel),
494 (modest_maemo_utils_get_supported_secure_authentication_methods):
496 Implemented security authentication for settings and easysetup.
498 2007-06-05 Murray Cumming <murrayc@murrayc.com>
500 * src/maemo/modest-main-window.c: (create_details_widget):
501 Show the total size for memory card accounts too, instead of showing
502 the name again. Fixes bug projects.maemo.org bug NB#59307.
504 2007-06-05 Murray Cumming <murrayc@murrayc.com>
507 * src/modest-tny-simple-folder-store.c:
508 * src/modest-tny-simple-folder-store.h: Removed.
510 * src/modest-tny-local-folders-account.h
511 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
512 for the local-folders maildir, with an extra TnyMergedFolder containing
513 the folders of the per-account outbox store accounts.
514 * src/modest-tny-account-store.c: (get_server_accounts):
515 Add the outboxes to the special local folders account after creating it.
517 * src/modest-tny-account.c:
518 (modest_tny_account_new_for_local_folders): Create the derived
519 account when creating the main local-folders account.
521 * src/maemo/modest-main-window.c: (create_details_widget),
522 (modest_main_window_set_contents_style):
523 Adapted to the use of the derived account instead of the folder store.
525 * src/modest-ui-actions.c:
526 (modest_ui_actions_on_folder_selection_changed):
527 * src/modest-ui-dimming-rules.c:
528 (modest_ui_dimming_rules_on_new_folder):
529 * src/widgets/modest-folder-view.c: (text_cell_data),
530 (icon_cell_data), (filter_row), (update_model),
531 (get_cmp_rows_type_pos):
534 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
535 Do not get the priv struct, because no priv struct has been set,
536 to avoid a runtime warning.
538 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
539 #ifelse with #else, to fix a warning, to fix the build.
542 2007-06-05 Christian Kellner <ckellner@openismus.com>
544 * libmodest-dbus-client/libmodest-dbus-client.c:
545 Fix small typo in doc (why do you always see them
546 AFTER committing stuff?)
549 2007-06-05 Christian Kellner <ckellner@openismus.com>
551 * libmodest-dbus-client/libmodest-dbus-client.c:
552 (libmodest_dbus_client_search):
553 Initialize hit list with NULL. Also set folder list
554 to "" if NULL was supplied.
557 2007-06-03 Christian Kellner <ckellner@openismus.com>
559 * libmodest-dbus-client/libmodest-dbus-client.c:
560 (modest_search_hit_list_free):
561 Make it save to call it with NULL.
563 * src/dbus_api/modest-dbus-callbacks.c:
564 * src/modest-search.c:
565 Return full ModestSearchHits as the search result list not TnyHeader
566 since can't be around withouth the correspoding TnyFolder.
568 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
570 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
571 Added currently commented code to check for secure auth
573 * src/maemo/modest-account-settings-dialog.c: (on_response),
574 (save_configuration), (show_ok):
575 Fixed projects.maemo.org bugs NB #59248 and #59251
577 * src/maemo/modest-maemo-utils.c:
578 (on_camel_account_get_supported_secure_authentication_status),
579 (on_camel_account_get_supported_secure_authentication),
580 (modest_maemo_utils_get_supported_secure_authentication_methods):
581 * src/maemo/modest-maemo-utils.h:
582 Moved get_supported_secure_authentication() method here to be able
583 to use it from easysetup wizard.
585 * src/modest-pair.c: (on_pair_compare_as_string):
586 Should compare string with first part of pair and not
587 strcmp pairs which will crash.
589 * src/modest-protocol-info.c:
590 (modest_protocol_info_protocol_is_store):
591 * src/modest-protocol-info.h:
592 Added modest_protocol_info_get_auth_protocol_name()
594 2007-06-03 Armin Burgmeier <armin@openismus.com>
596 * src/modest-mail-operation.c:
597 (modest_mail_operation_get_msgs_full): Set priv->account also when
598 only retrieving a single message. This avoids a crash when canceling
601 (modest_mail_operation_notify_end): Do not explicitely remove the
602 operation from the queue but only emit the progress_changed signal.
603 The queue itself listens to that signal to remove the operation when
604 it is finished. This reduces coupling and removes a potential deadlock
605 when modest_mail_operation_notify_end() is called from the queue
606 itself. If that is a problem performance-wise, I would suggest to
607 implement a status-changed signal or something.
609 * src/modest-mail-operation-queue.c: Make sure to never call a
610 function from another file while the queue is locked. This (hopefully)
611 fixes another deadlock when exiting the application while retrieving
614 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
616 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
617 Fixed build if libogs is not available
619 2007-06-03 Christian Kellner <ckellner@openismus.com>
621 * libmodest-dbus-client/libmodest-dbus-client.h:
622 * libmodest-dbus-client/libmodest-dbus-client.c:
623 (libmodest_dbus_client_delete_message):
624 Implement deletion of messages (Client side).
626 (modest_search_hit_free),
627 (modest_search_hit_list_free):
628 Utility functions to free the result hits.
630 * src/dbus_api/modest-dbus-api.h:
631 * src/dbus_api/modest-dbus-callbacks.c:
633 (modest_dbus_req_handler):
634 Implement deletion of messages (Server side).
636 * tests/dbus_api/test_search.c: (main):
639 * tests/dbus_api/Makefile.am:
640 * tests/dbus_api/test_delete_message:
641 Add little test for the message deletion logic
643 2007-06-03 Armin Burgmeier <armin@openismus.com>
645 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
646 when the operation queue was not empty. projects.maemo.org bug
649 2007-06-03 Armin Burgmeier <armin@openismus.com>
651 * src/widgets/modest-account-view.c
652 (on_account_default_toggled): Toggle default account column
653 explicitely instead of waiting for gconf notification (which is
654 currently ignored). This should fix projects.maemo.org bug NB#56910
655 for now. It should probably be removed when gconf notifications are
658 2007-06-03 Christian Kellner <ckellner@openismus.com>
660 * libmodest-dbus-client/libmodest-dbus-client.c:
661 Removed debugging spew.
663 * src/dbus_api/modest-dbus-callbacks.c:
664 Added debugging info.
666 * src/modest-search.c:
667 (modest_search_all_accounts):
668 Use tny_account_store_get_accounts () on the account store
669 to get all accounts which is the way to get all accounts.
671 * tests/dbus_api/test_search.c: (main):
672 Make it possible to supply the search term on the command line.
674 2007-06-03 Christian Kellner <ckellner@openismus.com>
676 * libmodest-dbus-client/libmodest-dbus-client.c:
677 * libmodest-dbus-client/libmodest-dbus-client.h:
678 Implement searching for mesages over raw dbus. (Client side)
680 * src/dbus_api/Makefile.am:
681 * src/dbus_api/modest-dbus-api.h:
682 * src/dbus_api/modest-dbus-callbacks.c:
683 * src/dbus_api/modest-dbus-callbacks.h:
684 Search framework (Server side). Also implement on_idle_open_message().
686 * src/maemo/modest-platform.c: (modest_platform_init):
687 Prepare for raw dbus/osso rpc interaction.
689 * src/modest-search.h:
690 Changed minsize from unspecific guint to guint32.
692 * src/modest-search.c:
694 Added strange hack which magically made tnymail work.
696 (modest_search_folder),
697 (modest_search_account),
698 (modest_search_all_accounts):
699 Implement helper functions to search all accounts, specific account
702 * tests/dbus_api/Makefile.am:
703 * tests/dbus_api/test_open_message.c:
704 Read url to open from commandline.
706 * tests/dbus_api/test_search.c:
707 Implement small test for dbus search stuff
709 2007-06-02 Armin Burgmeier <armin@openismus.com>
711 * src/maemo/modest-account-settings-dialog.c: Changed window title to
712 include account type and account title. This fixes projects.maemo.org
715 * src/maemo/modest-account-view-window.c: Set a title for the window.
717 2007-06-02 Armin Burgmeier <armin@openismus.com>
719 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
720 incoming and outgoing server name based on email address and server
721 types as long as the names have not been edited manually. This fixes
722 projects.maemo.org bug NB#58671.
724 2007-06-02 Armin Burgmeier <armin@openismus.com>
726 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
727 server type cannot be changed in future to the incoming details page
728 when creating an account. This fixes projects.maemo.org bug NB#59029.
730 2007-06-02 Armin Burgmeier <armin@openismus.com>
732 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
733 and assigned max width chars so that they wrap instead of being
734 truncated. Fixes projects.maemo.org bug NB#56126.
736 2007-06-02 Armin Burgmeier <armin@openismus.com>
738 * src/maemo/modest-connection-specific-smtp-window.c: Add an
739 introductory note to the connection specific smtp servers dialog, as
740 section 8.12 of the email UI specification requires. This fixes
741 projects.maemo.org bug NB#59212.
743 2007-06-01 Murray Cumming <murrayc@murrayc.com>
745 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
746 Check for running mail operations, and offer to cancel them, as per the UI
747 spec. This fixes projects.maemo.org bug NB#59041 .
748 However, I suspect that tinymail may still use the network connection
749 in ways that we cannot detect or cancel. But it should at least adapt to
752 2007-06-01 Murray Cumming <murrayc@murrayc.com>
754 * src/modest-tny-account-store.c: (recreate_all_accounts),
755 (get_cached_accounts), (get_server_accounts): Do more sensible
756 ref-counting of the temporarily-cached outbox accounts list. This seems
757 to fix a crash when entering the password when the password was wrong.
759 2007-06-01 Murray Cumming <murrayc@murrayc.com>
761 * src/gnome/modest-main-window.c: (connect_signals):
762 * src/modest-tny-account-store.c: (get_password),
763 (modest_tny_account_store_alert): Added comments and clues and
764 commented-out code about how we currently fail to deal with connection
765 errors and wrong passwords, and how we should.
767 2007-06-01 Murray Cumming <murrayc@murrayc.com>
769 * src/widgets/modest-retrieve-combo-box.c:
770 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
771 This fixes projects.maemo.org bug NB#58472 .
773 2007-06-01 Murray Cumming <murrayc@murrayc.com>
775 * src/maemo/easysetup/modest-easysetup-wizard.c:
776 (create_page_complete_easysetup):
777 (create_page_complete_custom): Correct the last commit,
778 putting the correct sentences in the correct pages.
780 2007-06-01 Murray Cumming <murrayc@murrayc.com>
782 * src/maemo/easysetup/modest-easysetup-wizard.c:
783 (create_page_complete_custom): Show the second sentence of text
784 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
787 2007-06-01 Murray Cumming <murrayc@murrayc.com>
789 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
790 Set the leave-on-server conf key by default. This fixes
791 projects.maemo.org bug NB#59258 .
793 2007-06-01 Murray Cumming <murrayc@murrayc.com>
795 * src/maemo/modest-account-view-window.c:
796 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
797 logical ID for the confirmation messages. Fixed projects.maemo.org bug
800 2007-06-01 Murray Cumming <murrayc@murrayc.com>
802 * src/maemo/easysetup/modest-easysetup-wizard.c:
803 (create_caption_new_with_asterisk):
804 * src/maemo/modest-account-settings-dialog.c:
805 (create_caption_new_with_asterisk):
806 Uncomment the code to add the asterisk, because they are no longer in the
807 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
808 (update_incoming_server_title): Add an asterisk here too.
810 2007-06-01 Murray Cumming <murrayc@murrayc.com>
812 * src/maemo/modest-maemo-global-settings-dialog.c:
813 (current_connection): Check that we are even connected before trying to
814 get the current connection name, to prevent a warning.
816 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
817 Change the comments because tny_maemo_conic_device_connect() is now meant to
819 * src/modest-mail-operation.c:
820 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
821 make sure we have a connection and fail if we can't connect.
823 2007-05-31 Murray Cumming <murrayc@murrayc.com>
825 * src/maemo/modest-main-window.c:
826 (on_account_store_connecting_finished): Do not try to get the
827 connection ID if we are not really connected. I am surprised that
828 this signal handler is called when we are not connected.
830 2007-05-31 Murray Cumming <murrayc@murrayc.com>
832 * src/modest-error.h:
833 * src/modest-ui-actions.c:
834 (modest_ui_actions_get_msgs_full_error_handler):
835 Renamed an enum, added comments, added an enum
836 for retrieve-limit errors.
838 * src/modest-mail-operation.c: (foreach_add_item),
839 (internal_folder_observer_update), (update_account_thread),
840 (modest_mail_operation_get_msgs_full):
841 (modest_mail_operation_update_account),
842 Added comments about how this works, and some code that should
843 (but does not) check the retrieve-limit. See the TODO comment.
845 2007-05-31 Murray Cumming <murrayc@murrayc.com>
847 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
848 Initialize help_id to fix the build. Warnings are good.
850 2007-05-31 Murray Cumming <murrayc@murrayc.com>
852 * src/widgets/modest-hbox-cell-renderer.c:
853 (modest_hbox_cell_renderer_append):
854 * src/widgets/modest-vbox-cell-renderer.c:
855 (modest_vbox_cell_renderer_append):
856 Fix the last commit by doing an extra ref.
858 2007-05-31 Murray Cumming <murrayc@murrayc.com>
860 * src/widgets/modest-hbox-cell-renderer.c:
861 (modest_hbox_cell_renderer_append):
862 * src/widgets/modest-vbox-cell-renderer.c:
863 (modest_vbox_cell_renderer_append):
864 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
865 to fix the build with Maemo Bora.
866 However, there seems to be a remaining crash, probably due to reference
869 2007-05-30 Murray Cumming <murrayc@murrayc.com>
871 * src/modest-tny-account.c:
872 (modest_tny_account_new_for_local_folders):
873 Use hildon_file_system_info_async_new() to get a better name for
874 the memory card account, setting it as the account name.
875 The timing seems to work, but this is probably
876 not the best place to do this. See the TODO comment.
877 * src/maemo/modest-main-window.c: (create_details_widget):
878 * src/widgets/modest-folder-view.c: (text_cell_data):
879 Use the tny account name instead of hardcoding a name.
881 2007-05-30 Christian Kellner <ckellner@openismus.com>
883 * src/modest-search.c: (modest_search):
884 Correctly set part_search_func even if we have already parsed
885 the query and thus a valid OgsTextSearcher object.
887 2007-05-30 Christian Kellner <ckellner@openismus.com>
890 Search and check for libogs.
893 Incooparte the ogs build env.
895 * src/modest-mime-part-search-stream.c:
896 * src/modest-mime-part-search-stream.h:
897 Removed since we do the real searching now in modest-search.c.
899 * src/modest-search.c:
900 * src/modest-search.h:
901 Implement support for ogs. We use that if available and requested
902 and fall back to modest_text_utils_utf8_strcmp (). The search logic
903 should now handle the corner case when the search term is spread
904 across multiple reads.
905 Also the logic in modest_search () was corrected to search all
906 requested fields until one is found.
908 2007-05-30 Murray Cumming <murrayc@murrayc.com>
910 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
913 * src/modest-init.c: Made modest_init_local_folders() take a
914 path and be public so we can iniitialize maildir folders on
917 * src/modest-local-folder-info.h:
918 * src/modest-local-folder-info.c:
919 (modest_local_folder_info_get_maildir_path): Add a path parameter.
921 * src/modest-tny-account.c:
922 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
923 still means the standard local-folders path on the local volume.
925 * src/modest-tny-account-store.c:
926 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
927 signal so we can detect mount/unmount of the MMC1 card, and do an update of
928 all accounts when that happens.
929 (get_server_accounts): If the MMC1 card is mounted, create a store account for
930 this too, so it shows up in the treeview.
932 2007-05-28 Murray Cumming <murrayc@murrayc.com>
934 * src/maemo/modest-maemo-global-settings-dialog.c:
935 (current_connection):
936 * src/widgets/modest-global-settings-dialog.c:
937 (current_connection_default):
938 Use the enum values instead of 0, 1 and -1,
939 to make the code clearer.
941 * src/modest-account-mgr-helpers.c:
942 (modest_account_mgr_get_connection_specific_smtp): Make this code
945 * src/modest-runtime.h:
946 * src/modest-runtime.c:
947 Added modest_runtime_remove_all_send_queues().
948 * src/maemo/modest-main-window.c:
949 (on_account_store_connecting_finished): Recreate the send queues,
950 using the appropriate transport accounts for this new connection.
951 Some futher adapting might be needed if the old send queues are not
952 automatically stopped at this point.
954 * src/modest-tny-account-store.c: (get_server_accounts):
955 Create the connection-specific transport accounts, so that they can
956 be found later by their ID.
958 * src/modest-tny-account.h:
959 * src/modest-tny-account.c:
960 Added modest_tny_account_new_from_server_account_name().
961 modest_tny_account_new_from_server_account(): Do not create the
962 send queues here, because they will be
963 recreated anyway when the connection changes for the first time.
965 2007-05-28 Murray Cumming <murrayc@murrayc.com>
967 * src/modest-local-folder-info.h:
968 * src/modest-local-folder-info.c:
969 (modest_per_account_local_outbox_folder_info_get_maildir_path),
970 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
971 tbox_folder): Take a modest account name instead of a server TnyAccount,
972 so we can have per-modest-account rather than per-transport-account
974 We must make sure that we change or recreate the exisitng send queues
975 when the connection changes for connection-specific transport accounts.
977 * src/modest-tny-account-store.c:
978 (create_per_account_local_outbox_folders): Create outboxed per modest
979 account, not per transport account.
981 * src/modest-tny-account.h:
982 * src/modest-tny-account.c:
983 (modest_tny_account_get_special_folder): For outboxes, get the
984 parent modest account name. The account is ignored for other folders.
985 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
986 modest account name rather than a server TnyAccount.
988 2007-05-25 Murray Cumming <murrayc@murrayc.com>
990 * src/modest-tny-account.c:
991 (modest_tny_account_new_from_server_account):
992 Call modest_runtime_get_send_queue() immediately after creating transport
993 accounts, so that they start trying to send email from the outbox as soon
994 as possible at startup. This is probably what we want.
996 * src/modest-mail-operation.c: (update_account_thread):
997 * src/modest-runtime.c: (modest_runtime_get_send_queue):
998 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
999 * src/modest-tny-send-queue.h:
1000 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1001 (modest_ui_actions_on_send):
1002 Added comments about how sending works, though it needs some more work.
1004 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1006 * src/modest-tny-account.c:
1007 (modest_tny_account_get_special_folder): Add TODO because this fails when
1008 the network is busy.
1009 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1010 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1011 Do not try to show this window when there is no active account. The UI
1012 specs does not tell us what to do in this case.
1014 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1018 * src/maemo/Makefile.am:
1019 * src/widgets/Makefile.am: Some dist fixes.
1021 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1023 * src/maemo/modest-connection-specific-smtp-window.c:
1024 (on_button_edit): Make the code clearer, to prevent a double free.
1026 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1028 * src/maemo/modest-account-settings-dialog.c:
1029 (modest_account_settings_dialog_set_account_name),
1030 Check the connection-specific smtp servers checkbox if there are any.
1032 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1033 (modest_connection_specific_smtp_edit_window_init):
1034 Start with a suitable port number.
1036 * src/modest-account-mgr-helpers.h:
1037 * src/modest-account-mgr-helpers.c: Added
1038 modest_account_mgr_get_has_connection_specific_smtp().
1040 (modest_account_mgr_set_connection_specific_smtp),
1041 (modest_account_mgr_remove_connection_specific_smtp),
1042 (modest_account_mgr_get_has_connection_specific_smtp),
1043 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1044 connection-specific smtp server accounts in the account, rather than
1045 the server account conf dir.
1047 This fixes bug projects.maemo.org bug NB#58263 .
1049 * src/modest-tny-account-store.c:
1050 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1051 if there are no server accounts yet, to prevent an infinite loop when there
1052 are no accounts. Document that one must be called before the other.
1054 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1056 * src/modest-account-mgr-helpers.c:
1057 (modest_account_mgr_get_default_account): Make sure that at least
1058 one account is always the default, if there are any enabled accounts.
1059 This is just a sanity check that shouldn't be necessary.
1061 * src/modest-account-mgr-priv.c:
1062 (_modest_account_mgr_account_from_key): Unescape the conf key to
1063 get the real account name. For instance, this is an issue if a space
1064 was in the account name, which can happen because the account name
1065 is generated from the display name.
1066 (_modest_account_mgr_get_account_keyname): Always escape the
1068 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1069 Unescape the conf keys to get the real account names.
1071 For instance, previously the is-default radio button in the accounts
1072 list was not checked for any accounts at first. This fixes that,
1073 and might fix several similar bugs.
1075 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1077 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1078 Removed some debug printfs.
1080 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1082 Modest on-disk outbox directories are now here, for instance:
1083 $HOME/.modest/outboxes/<account-id-1>/outbox
1084 $HOME/.modest/outboxes/<account-id-2>/outbox
1086 $HOME/.modest/local-folders/outbox
1087 so we can have a separate outbox for each account.
1088 But they are shown as one outbox in the GtkTreeView, by using a
1089 TnyMergeFolder in a ModestTnySimpleFolderStore.
1092 * src/modest-tny-simple-folder-store.c:
1093 * src/modest-tny-simple-folder-store.h:
1094 Added ModestTnySimpleFolderStore, used to contain folders from
1095 other folder stores, such as other accounts.
1097 * src/modest-tny-outbox-account.h:
1098 * src/modest-tny-outbox-account.c:
1099 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1100 used for the per-account local outbox folders.
1102 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1103 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1104 only use this (internally) now for the non-outbox local folders.
1106 * src/modest-init.h:
1107 * src/modest-init.c: Added modest_init_one_local_folder(), for
1108 setting up the directory structure for each local folder.
1110 * src/modest-local-folder-info.c:
1111 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1112 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1114 * src/modest-local-folder-info.h:
1115 * src/modest-tny-account-store.c: (on_account_removed),
1116 (on_account_changed), (create_per_account_local_outbox_folders),
1117 (get_server_accounts), (modest_tny_account_store_get_accounts),
1118 (modest_tny_account_store_get_tny_account_by_account),
1119 (modest_tny_folder_store_is_virtual_local_folders):
1121 * src/modest-tny-account.h:
1122 * src/modest-tny-account.c:
1123 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1124 to create an on-disk per-account local outbox folder for each
1126 (create_per_account_local_outbox_folders): Create a local outbox folder
1127 for each transport account.
1128 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1129 for all local folders.
1131 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1132 instead of using g_object_get/set() directly. It is clearer.
1134 (modest_tny_folder_store_get_message_count),
1135 (modest_tny_folder_store_get_local_size
1136 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1137 because we now use these with non-acount folder stores.
1139 (modest_tny_account_get_special_folder),
1140 (modest_tny_account_new_from_server_account),
1141 (modest_tny_account_new_from_account):
1142 (recurse_folders): Adjust to the new outbox system.
1144 * src/modest-tny-folder.h:
1145 * src/modest-tny-folder.c:
1146 (modest_tny_folder_is_local_folder),
1147 (modest_tny_folder_get_local_folder_type),
1148 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1150 * src/widgets/modest-main-window.h:
1151 * src/maemo/modest-main-window.c: (create_details_widget),
1152 (modest_main_window_set_contents_style): Show details for any folder store,
1155 (modest_tny_folder_get_rules):
1156 Remove the const. C does not support constness enough for this.
1158 * src/modest-ui-actions.c:
1159 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1160 make all outboxes appear as one, in the usual local-folders tree node.
1162 (set_active_account_from_tny_account),
1163 (modest_ui_actions_on_folder_selection_changed):
1164 * src/widgets/modest-folder-view.c: (text_cell_data),
1165 (icon_cell_data), (filter_row),
1166 (add_account_folders_to_merged_folder),
1167 (add_account_folders_to_simple_folder_store), (),
1168 (get_cmp_rows_type_pos), (cmp_rows),
1169 (modest_folder_view_set_account_id_of_visible_server_account):
1170 Adjust to the new outbox system, using generic folder stores and folders
1171 in the GtkTreeModel.
1173 2007-05-23 Christian Kellner <ckellner@openismus.com>
1175 * src/modest-mail-operation.c:
1176 (modest_mail_operation_update_account):
1177 Use info->max_size instead of unintialized local var [small
1178 build fix]. (Added TODO to review that change since I don't
1181 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1183 * libmodest-dbus-client/libmodest-dbus-client.c:
1184 (libmodest_dbus_client_compose_mail): function added
1185 * src/dbus_api/modest-dbus-api.h:
1186 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1187 (on_compose_mail): Implementation of the SendAsMail functionality
1189 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1191 * src/modest-account-mgr.c:
1192 (modest_account_mgr_add_server_account): Set the secure-connection
1193 conf key for transport accounts as well as store accounts. I don't know
1194 why the if was there. For instance, this makes sure that we use SSL
1195 for the gmail preset from the easysetup wizard.
1197 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1199 * src/gnome/modest-main-window.c:
1200 (on_account_store_connecting_finished), (connect_signals):
1201 * src/maemo/modest-main-window.c:
1202 (on_account_store_connecting_finished), (connect_signals),
1203 (modest_main_window_new):
1204 Handle TnyAccountStore::connecting-finished instead of
1205 TnyDevice::connection-changed, because we cannot actually perform
1206 operations on accounts until TnyAccountStore has itself responded to
1207 the TnyDevice::connection-changed signal. This prevents a GError from
1209 Do not try to update at startup, because we (at least on scratchbox)
1210 already do an update at startup when the device goes online.
1211 This prevents a GError from tinymail.
1212 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1213 Added TODO about stopping simultaneous operations.
1215 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1217 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1218 * src/modest-mail-operation-queue.c:
1219 (modest_mail_operation_queue_remove):
1220 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1221 about where they happened.
1223 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1225 * src/modest-ui-actions.c:
1226 (modest_ui_actions_on_password_requested): Make sure that the remember
1227 output parameter is always TRUE.
1229 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1231 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1232 Show a OK/Cancel dialog if the error is a question, though we still do not
1233 know anything more about what we are asking the user.
1234 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1235 Fix an uninitialized variable (helper). This is a logic error, however.
1237 2007-05-21 Christian Kellner <ckellner@openismus.com>
1239 * src/modest-search.h:
1240 Correct bit shifting in the ModestSearchFlags enum.
1242 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1244 * src/modest-tny-account.c:
1245 (modest_tny_account_new_from_server_account): Do not use the lsub and
1246 check-all hard-coded IMAP options when using POP.
1248 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1250 * src/modest-tny-account.c:
1251 (modest_tny_account_new_from_server_account):
1252 Use NULL for the secure-auth method for POP when Password auth has been
1253 specified by the user, as we already do for IMAP. "auth=Login" causes
1254 an error from camel or the server.
1256 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1258 * src/maemo/modest-account-settings-dialog.c:
1259 (create_page_account_details),
1260 (modest_account_settings_dialog_set_account_name):
1261 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1262 for the leave-on-server checkbox, rathr than just the checkbox, when
1263 the protocol is not POP.
1265 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1267 * src/widgets/modest-account-view.c:
1268 * src/widgets/modest-account-view.h:
1269 Added modest_account_view_select_account() which will be useful later
1270 to asynchronously re-select the edited account.
1272 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1274 * src/maemo/modest-account-settings-dialog.c:
1275 (modest_account_settings_dialog_set_account_name):
1276 Automatically choose the port numbers based on the secure authentication
1277 methods, if they have not been chosen before.
1278 This fixes projects.maemo.org bug NB#56273 .
1280 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1282 * src/maemo/modest-main-window-ui.h:
1283 * src/modest-ui-actions.c:
1284 * src/modest-ui-actions.h:
1285 Connect the Tools/SMTP Servers menu item to
1286 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1287 SMTP servers dialog, as in the UI specification and saves changes when it
1288 is closed. This fixed projects.maemo.org bug NB#56305 .
1290 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1292 * src/maemo/modest-connection-specific-smtp-window.c:
1293 (modest_connection_specific_smtp_window_init):
1294 Use gtk_window_set_default_size() to make this window big enough, so
1295 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1297 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1299 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1300 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1301 (modest_connection_specific_smtp_edit_window_init),
1302 Do not try to connect to a combobox signal before the combobox exists.
1303 This fixes the cras in projects.maemo.org bug NB#56288 .
1304 (modest_connection_specific_smtp_edit_window_get_settings):
1305 Remove the server_account_name parameter which was being checked for NULL
1306 though it was not used.
1308 * src/maemo/modest-connection-specific-smtp-window.c:
1309 (modest_connection_specific_smtp_window_fill_with_connections),
1310 (on_button_edit), (modest_connection_specific_smtp_window_init):
1311 Correct the number of treemodel columns to prevent a warning.
1312 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1313 libconic does not work.
1315 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1317 * src/modest-tny-account.c:
1318 (modest_tny_account_new_from_server_account):
1319 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1320 SMTP when "None" was chosen by the user. However, with my SMTP server that
1321 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1324 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1326 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1327 to explain the memory management issue with the ID in the ModestPair.
1329 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1330 (add_sending_page), (modest_account_assistant_finalize):
1331 * src/gnome/modest-gnome-global-settings-dialog.c:
1332 (create_updating_page), (create_composing_page):
1333 * src/gnome/modest-msg-edit-window.c: (get_transports),
1334 (init_window), (modest_msg_edit_window_finalize),
1335 (modest_msg_edit_window_get_msg_data):
1336 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1337 * src/gnome/modest-transport-widget.c:
1338 (modest_transport_widget_finalize), (smtp_configuration):
1339 * src/maemo/modest-maemo-global-settings-dialog.c:
1340 (create_updating_page), (create_composing_page):
1341 * src/maemo/modest-msg-edit-window.c: (get_transports),
1342 (init_window), (modest_msg_edit_window_finalize),
1343 (modest_msg_edit_window_get_msg_data),
1344 (modest_msg_edit_window_free_msg_data):
1345 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1346 (modest_store_widget_finalize):
1347 * src/maemo/modest-transport-widget.c:
1348 (modest_transport_widget_finalize), (smtp_configuration):
1349 * src/modest-main.c: (send_mail):
1350 * src/widgets/modest-combo-box.h:
1351 * src/widgets/modest-global-settings-dialog-priv.h:
1352 * src/widgets/modest-global-settings-dialog.c:
1353 (modest_global_settings_dialog_finalize):
1354 * src/widgets/modest-msg-edit-window.h:
1355 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1356 as long as the combo box, to prevent use of freed memory for the ID.
1358 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1360 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1361 get_accounts(), to make this clearer. Do not check for the enabled gconf
1362 key, because we do not use this for server accounts (at least, not yet).
1363 This allows us to send email again.
1365 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1367 * src/maemo/modest-platform.c:
1368 (on_modest_conf_update_interval_changed), (modest_platform_init):
1369 Only respond to this particular key change. All these strcmp()s cannot be
1372 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1374 * src/maemo/modest-maemo-global-settings-dialog.c:
1375 (current_connection): Prevent a crash in scratchbox when
1376 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1377 * src/maemo/modest-platform.c:
1378 (on_modest_conf_update_interval_changed), (modest_platform_init):
1379 Get the update interval from gconf and reset it when the gconf key changes.
1381 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1383 * src/modest-protocol-info.c:
1384 * src/modest-protocol-info.h: Adde enum-specific get functions,
1385 instead of using a ModestProtocolType enum parameter.
1387 * src/gnome/modest-account-assistant.c:
1388 * src/gnome/modest-store-widget.c:
1389 * src/gnome/modest-store-widget.h:
1390 * src/gnome/modest-transport-widget.c:
1391 * src/gnome/modest-transport-widget.h:
1392 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1393 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1394 * src/maemo/easysetup/modest-easysetup-wizard.c:
1395 * src/maemo/modest-account-settings-dialog.c:
1396 * src/maemo/modest-account-settings-dialog.h:
1397 * src/maemo/modest-store-widget.c:
1398 * src/maemo/modest-store-widget.h:
1399 * src/maemo/modest-transport-widget.c:
1400 * src/maemo/modest-transport-widget.h:
1401 * src/modest-account-mgr-helpers.c:
1402 * src/modest-account-mgr-helpers.h:
1403 * src/modest-account-mgr.c:
1404 * src/modest-account-mgr.h:
1405 * src/modest-tny-account.c:
1406 * src/modest-tny-folder.c:
1407 * src/widgets/modest-account-view.c:
1408 * src/widgets/modest-retrieve-combo-box.c:
1409 * src/widgets/modest-retrieve-combo-box.h:
1410 * src/widgets/modest-secureauth-combo-box.c:
1411 * src/widgets/modest-serversecurity-combo-box.c:
1412 * src/widgets/modest-serversecurity-combo-box.h:
1413 * tests/check_account-mgr.c:
1414 Use the specific functions, and use the re-renamed enum values for GNOME too.
1416 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1418 * src/modest-pair.h:
1419 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1420 so we can get the second based on the first.
1422 * src/maemo/modest-account-settings-dialog.h:
1423 * src/maemo/modest-account-settings-dialog.c:
1424 Added get_supported_secure_authentication_methods(), though it is mostly
1425 commented-out for now until the necessary API is committed to tinymail.
1426 (modest_account_settings_dialog_set_account_name),
1427 (save_configuration): Request the supported authentication methods from the
1428 server, so we can choose a working method.
1430 * src/modest-tny-account-store.h:
1431 * src/modest-tny-account-store.c:
1432 (modest_tny_account_store_get_session): Rename from
1433 tny_account_store_get_session().
1435 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1437 * src/modest-protocol-info.h: Split the ModestProtocol enum
1438 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1439 There was no need to have these unrelated values in one enum.
1441 * src/: many files: Adapted to changed enum. This makes the code a bit
1442 clearer, and the compiler could catch some errors.
1444 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1446 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1447 Show the detailed internal camel error message when an error happens
1448 during the configuration, so that our testers can give us more clues.
1449 For instance, in projects.maemo.org bug NB#56910 .
1451 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1453 * src/modest-tny-account.c:
1454 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1455 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1457 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1459 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1460 * src/maemo/modest-account-settings-dialog.c:
1461 (modest_account_settings_dialog_set_account_name),
1462 (save_configuration): For the incoming secure authentication checkbox,
1463 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1464 the UI specification. PLAIN does not seem to be supported for most IMAP
1465 servers anyway, and I am not sure what it would mean.
1466 However, we probably need to discover which of the secure-authentication
1467 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1468 * src/modest-account-mgr-helpers.c:
1469 (modest_account_mgr_get_server_account_data):
1471 * src/modest-tny-account.c:
1472 (modest_tny_account_new_from_server_account):
1473 Use tny_account_set_mech() to set secure-authentication methods,
1474 with some special-casing for IMAP, based on my observations of how
1477 * src/modest-account-mgr-helpers.h:
1478 * src/modest-account-mgr.c:
1479 * src/modest-defs.h: Comment that the URI is only used for local folders.
1481 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1483 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1484 parameter const, just to be neat.
1485 * src/modest-text-utils.c: (modest_text_utils_inline):
1486 End g_strconcat() with NULL, as its documentation says. This is almost
1487 certainly the cause of my crash at startup on the device. Interestingly,
1488 valgrind doesn't tell us about these errors.
1490 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1492 * scripts/build-packages: Added more precise comments about how to use
1493 this script, though I still get this error:
1494 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1495 error building tinymail
1497 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1499 * src/maemo/modest-main-window.c: (on_account_update):
1500 Very slight cleanup, hoping to make it simpler to discover what causes
1501 a crash here sometimes.
1503 * src/modest-tny-account.c:
1504 (modest_tny_account_new_from_server_account): Set the port. Added
1505 comments about the options and a TODO comment because I need to find out
1506 how to specify the secure authentication method.
1508 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1510 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1511 changed CFlags paths form modest to libmodest
1513 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1515 * src/modest-account-mgr-helpers.c:
1516 (modest_account_mgr_get_server_account_data),
1517 (modest_account_mgr_free_server_account_data):
1518 * src/modest-account-mgr-helpers.h:
1519 * src/modest-account-mgr.c:
1520 (modest_account_mgr_add_server_account):
1521 * src/modest-defs.h:
1522 * src/modest-tny-account.c:
1523 (modest_tny_account_new_from_server_account):
1524 Determine the options for tny_camel_account_add_option() here,
1525 based on the settings, rather than storing them directly in gconf.
1527 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1529 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1530 Show a more friendly error dialog now that we expect (from the tinymail
1531 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1533 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1535 * src/maemo/modest-main-window.c: (on_account_update): Check that
1536 account_name is not NULL, to prevent a crash at startup that I am
1537 seeing on the N800. I do wonder why it is NULL.
1539 * src/maemo/easysetup/modest-easysetup-wizard.c:
1540 (create_page_user_details):
1541 * src/maemo/modest-account-settings-dialog.c:
1542 (create_page_user_details), (create_page_outgoing):
1543 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1544 (modest_connection_specific_smtp_edit_window_init):
1545 * src/modest-ui-actions.c:
1546 (modest_ui_actions_on_password_requested):
1547 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1548 might do something useful with the on-screen keyboard.
1550 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1552 * src/maemo/modest-main-window.c: (on_account_update):
1553 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1554 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1556 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1558 * src/modest-tny-account-store.c: (on_account_changed):
1559 Correct the signature of this signal handler.
1561 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1563 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1564 Show a HildonNote instead of a GtkDialog for Maemo.
1566 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1568 * src/widgets/modest-account-view.h:
1569 * src/widgets/modest-account-view.c: (on_account_changed),
1570 (on_account_removed). Added a boolean flag, set/unset by
1571 modest_account_view_block_conf_updates(),
1572 modest_account_view_unblock_conf_updates() to prevent unnecessary
1573 updates, but this is not very useful because the gconf notifications are
1574 so delays (maybe only on Maemo Bora).
1575 So auto-updating is turned off, and these functions do an explicit
1576 update when necessary.
1577 However, something else is still doing too much work when adding/removing
1578 accounts, probably in another part of the application.
1580 * src/maemo/modest-account-view-window.c:
1581 (on_delete_button_clicked), (on_edit_button_clicked),
1582 (on_new_button_clicked): Use the new functions.
1584 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1586 * src/modest-account-mgr-helpers.c:
1587 (modest_account_mgr_set_first_account_as_default):
1588 Sort the list of names alphabetically-by-title, so we choose the first one
1590 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1591 alphabetically by the title.
1593 This fixes projects.maemo.org bug NB#56418 .
1595 * src/modest-account-mgr-priv.c:
1596 (_modest_account_mgr_account_from_key):
1597 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1598 avoid a valgrind error, and possible random behaviour.
1600 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1602 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1603 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1604 tinymail documentation to say that this can be expected.
1605 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1606 pretty, and should not happen, but I would prefer to know when it does.
1608 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1610 * configure.ac: When using the older hildon version, probably on Bora,
1611 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1613 * src/widgets/modest-attachment-view.c:
1614 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1617 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1619 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1620 Implemented the prototype. Can be tested with
1621 tests/dbus_api/test_open_message:
1623 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1625 * src/modest-tny-account-store.c:
1626 (modest_tny_account_store_instance_init), (get_password):
1627 * src/modest-ui-actions.c:
1628 (modest_ui_actions_on_password_requested):
1629 Do not store the password in gconf, because this function is called
1630 for non-remembered passwords. Actually use the cached (in the hash map)
1631 password instead of releasing it.
1632 The password will now not be remembered if it is asked via the protected
1633 password dialog, as per the UI spec.
1635 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1637 * src/modest-defs.h:
1638 * src/modest-account-mgr-helpers.h:
1639 * src/modest-account-mgr-helpers.c:
1640 Added modest_server_account_get_username_has_succeeded(),
1641 modest_server_account_set_username_has_succeeded().
1642 (modest_server_account_set_username),
1643 Reset the has-succeeded flag if the username changes.
1645 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1646 * src/maemo/modest-connection-specific-smtp-window.c:
1647 (modest_connection_specific_smtp_window_save_server_accounts):
1648 Use modest_server_account_set_username() instead of using
1649 modest_conf_set_string() directly, so that the has-succeeded flag is always
1652 * src/modest-ui-actions.c:
1653 (modest_ui_actions_on_password_requested): Dim the username entry if
1654 the username has ever worked, as per the UI spec.
1656 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1658 * src/modest-tny-account-store.c: (get_password):
1659 * src/modest-ui-actions.c:
1660 (modest_ui_actions_on_password_requested):
1661 Allow the username to be changed too, though there is more work to
1662 be done on exactly how this behaves.
1664 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1666 * src/modest-account-mgr-helpers.h:
1667 * src/modest-account-mgr-helpers.c:
1668 Added modest_account_mgr_get_display_name(),
1669 modest_server_account_get_username(),
1670 modest_server_account_set_username(),
1671 modest_server_account_set_password(),
1672 modest_server_account_get_hostname() functions so we do not need to
1673 use the conf API directly.
1675 * src/maemo/modest-main-window.c: (connect_signals):
1676 Actually connect ot the ModestAccountStore::request-password signal,
1677 so that we show the dialog when the password is requested by Tinymail,
1678 for isntance if it is empty.
1680 * src/modest-marshal.list:
1681 * src/modest-tny-account-store.c:
1682 (modest_tny_account_store_class_init), (get_password),
1683 (modest_tny_account_store_alert):
1684 * src/modest-tny-account-store.h:
1685 * src/modest-ui-actions.h:
1686 * src/modest-ui-actions.c:
1687 (modest_ui_actions_on_password_requested):
1688 Change the signal parameters, so it is obvious that we are providing
1689 the non human-readable server name, and receiving both the username
1690 and password, though changing of the username is not yet implemented.
1691 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1692 for the GNOME version.
1694 This should fix the projects.maemo.org bug NB#56209, though it does not
1695 work on Bora, because the gconf_client_get() for the password fails
1696 immediately after we save it with gconf_client_set().
1698 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1701 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1702 caused an undefined symbol error:
1703 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1705 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1707 * src/modest-tny-account-store.c:
1708 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1709 using a GError instead of a string message, so we can translate it in
1712 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1714 * src/maemo/modest-address-book.c:
1715 (modest_address_book_check_names):
1716 * src/maemo/modest-msg-view-window.c:
1717 (modest_msg_view_window_clipboard_owner_change):
1718 * src/modest-init.c: (modest_init_init_ui):
1719 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1720 (update_folders_cb), (modest_mail_operation_update_account):
1721 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1722 (modest_ui_actions_on_msg_attachment_clicked),
1723 (modest_ui_actions_on_msg_recpt_activated):
1724 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1725 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1726 (modest_msg_view_search_next):
1727 * src/widgets/modest-recpt-editor.c:
1728 (modest_recpt_editor_on_button_release_event),
1729 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1730 g_message(). At this point we should only be seeing interesting errors on
1731 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1733 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1735 (modest_wizard_dialog_force_title_update):
1736 * src/maemo/easysetup/modest-wizard-dialog.h:
1737 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1738 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1739 can update the title when appropriate. Otherwise the title is wrong if the
1740 pages are added after adding the notebook to the dialog.
1741 This must be a problem in HildonWizardDialog too.
1742 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1744 * src/maemo/easysetup/modest-easysetup-wizard.c:
1745 (create_subsequent_customsetup_pages),
1746 (create_subsequent_easysetup_pages):
1747 Call modest_wizard_dialog_force_title_update() so that the title is
1748 correct even with GTK+ < 2.10.
1749 This fixes projects.maemo.org bug NB#56145 .
1751 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1753 * src/maemo/modest-platform.c:
1754 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1755 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1758 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1760 * src/widgets/modest-window.h:
1761 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1762 and modest_window_save_state(), which invokes it.
1764 * src/widgets/modest-window-mgr.h:
1765 * src/widgets/modest-window-mgr.c:
1766 Added modest_window_mgr_save_state_for_all_windows(), which calls
1767 the save_state vfunc on all registered windows, if implemented.
1769 * src/gnome/modest-msg-edit-window.c:
1770 * src/gnome/modest-msg-view-window.c:
1771 * src/maemo/modest-msg-edit-window.c:
1772 * src/maemo/modest-msg-view-window.c:
1773 * src/maemo/modest-main-window.c:
1774 Specify the existing save_settings functions as implementations of
1775 ModestWindow::save_state_func().
1777 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1778 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1779 enabling hibernation, for instance.
1781 We may need to do the same thing for restoring settings.
1784 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1786 * src/widgets/modest-window-mgr.c:
1787 * src/widgets/modest-window-mgr.h:
1788 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1789 modest_window_mgr_get_hibernation_is_prevented().
1791 * src/maemo/modest-main-window.c:
1792 (on_hildon_program_is_topmost_notify): Prevent hibernation
1793 (possible when the application goes to the background in the WM),
1794 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1796 * src/maemo/easysetup/modest-easysetup-wizard.c:
1797 (modest_easysetup_wizard_dialog_init):
1798 * src/maemo/modest-account-settings-dialog.c:
1799 (modest_account_settings_dialog_init):
1800 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1801 (modest_connection_specific_smtp_edit_window_init):
1802 * src/maemo/modest-connection-specific-smtp-window.c:
1803 (modest_connection_specific_smtp_window_init):
1804 * src/maemo/modest-signature-editor-dialog.c:
1805 (modest_signature_editor_dialog_init):
1806 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1807 prevent hibernation while any of these account settings dialogs are open.
1809 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1811 * src/maemo/Makefile.am:
1812 * src/maemo/modest-osso-state-saving.c:
1813 * src/maemo/modest-osso-state-saving.h: Added
1814 modest_osso_load_state() and modest_osso_save_state() though they do
1815 nothing now. They should iterate through all the open windows and load/save
1817 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1818 save state when closing.
1820 * src/maemo/modest-main-window.c:
1821 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1822 Add a notification handler for the HildonProgram::is-topmost property,
1823 so we can allow hibernation when the application goes into the background.
1824 But we still need to detect when the accounts setup windows are open so
1825 we can stop hibernation when they are open.
1826 To do this, I also added the main window the HildonProgram. This might have
1827 other side-effects/benefits, and should maybe be done for other windows.
1829 * src/maemo/modest-osso-autosave-callbacks.h:
1830 * src/maemo/modest-osso-autosave-callbacks.c:
1831 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1832 though it does not do anything yet, and we might never need this to do
1833 anything. For instance, we already save drafts.
1835 * src/maemo/modest-platform.c: (modest_platform_init):
1836 Specify the libosso auto-save callback.
1838 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1840 * src/maemo/modest-platform.c:
1841 (modest_platform_set_update_interval):
1842 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1843 aparently stays valid between application instances, so we can use this
1844 to remove and reset it later. According to a maemo-developers email from
1847 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1849 * configure.ac: Depend on libalarm for Maemo.
1851 * src/dbus_api/modest-dbus-api.h:
1852 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1853 (on_send_receive), (modest_dbus_req_handler):
1854 Handle a SEND_RECEIVE D-Bus method.
1856 * libmodest-dbus-client/libmodest-dbus-client.c:
1857 (libmodest_dbus_client_send_and_receive):
1858 * libmodest-dbus-client/libmodest-dbus-client.h:
1859 Add C convenience functions for calling the new D-Bus method.
1861 * src/modest-platform.h:
1862 * src/gnome/modest-platform.c:
1863 * src/maemo/modest-platform.c:
1864 Added modest_platform_set_update_interval(), which uses the
1865 alarmd API on Maemo.
1866 (modest_platform_init),
1867 Call modest_platform_set_update_interval(), using a hard-coded
1868 interval for now (until the global settings dialog is implemented),
1869 though I am not sure that this makes sense yet.
1871 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1873 * src/dbus_api/modest-dbus-callbacks.c:
1874 (modest_osso_cb_hw_state_handler):
1875 * src/dbus_api/modest-dbus-callbacks.h:
1876 * src/maemo/modest-platform.c: (modest_platform_init):
1877 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1878 in case this has some effect on the ability for Maemo to ping the
1881 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1883 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1884 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1885 warning. It is probably a logic error, but I need to fix the build.
1887 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1889 * src/modest-account-mgr.h:
1890 * src/modest-account-mgr.c:
1891 (modest_account_mgr_account_names): Add a gboolean enabled_only
1892 parameter, so we can get lists of onlt the enabled accounts.
1894 (modest_account_mgr_add_account),,
1895 (modest_account_mgr_account_with_display_name_exists):
1896 * src/maemo/modest-msg-edit-window.c: (get_transports):
1897 * src/modest-account-mgr-helpers.c:
1898 (modest_account_mgr_set_first_account_as_default):
1899 * src/modest-init.c: (init_default_account_maybe):
1900 * src/modest-tny-account-store.c: (get_accounts):
1901 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1902 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1903 * tests/check_account-mgr.c: (START_TEST):
1904 Provide the extra parameter, as appropriate.
1906 * src/widgets/modest-account-view.c: (update_account_view):
1907 Do not show disabled accounts (meaning that there is no way to
1908 enable/disable accounts in the UI (the feature is not in our UI
1909 specification), so we can use this internally only to mark unfinished
1910 or temporary account data.
1912 * src/maemo/easysetup/modest-easysetup-wizard.c:
1913 (create_account): Add boolean enable parameter, so we can specify FALSE
1914 to create the temporary account.
1915 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1916 (on_before_next): When finishing, when there is a temporary account, just
1918 Also, use a timeout to delay the showing of the dialog until gconf is likely
1919 to return correct information, due to a maemo gconf bug that is fixed in
1920 osso 1.1, but not yet in Bora.
1921 However, the dialog stays on screen after it is destroyed.
1923 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1924 for invalid data when cancelling. Use a hildon note instead of a dialog
1925 to complain about invalid data. Do not show the account-saved note if the
1926 account is disabled (a temporary account that will not really be saved for use
1929 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1931 * src/modest-account-mgr-helpers.h:
1932 * src/modest-account-mgr-helpers.c:
1933 Added modest_account_mgr_unset_default_account(),
1934 Added modest_account_mgr_set_first_account_as_default().
1936 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1937 If it was the default account, unset the default account name.
1939 * src/maemo/modest-account-view-window.c:
1940 (on_delete_button_clicked): If it was the default account,
1941 set the first remaining account as the default instead.
1943 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1944 a NULL account or a NULL default account, to prevent a crash. This should
1945 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1948 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1950 * src/widgets/modest-recpt-editor.c:
1951 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1952 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1953 TODO comment for this. This fixes the build.
1955 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1956 be the best place for it. This will in future update all auto-update accounts,
1957 rather than just the current/default account, when that gconf key exists.
1958 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1959 if there are no accounts, before calling do_send_receive().
1960 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1962 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1963 * src/maemo/modest-main-window-ui.h:
1964 * src/maemo/modest-main-window.c: (on_connection_changed),
1965 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1966 directly, becaue the signal handler does more.
1968 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1970 * src/modest-account-mgr-helpers.c:
1971 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1972 for the case that the account does not exist.
1974 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1975 (equivalent to the modest account name) rather than the tinymail account name
1976 (equivalent to the modest account title - human readable) to get the account data.
1977 Check for null account data to prevent the crash, and add a TODO comment saying that
1978 this needs fixing because it is using the server account name instead of the account name.
1980 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1982 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1983 * src/maemo/modest-account-settings-dialog.c: (show_error),
1985 Use hildon_note_new_information() for informative and error messages,
1986 which seems to be expected for Maemo applications (no documentation that I know of
1987 says this). I am surprised that there is no distinction between info and error
1990 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1992 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1993 it is easy to find where this is used.
1995 * src/maemo/easysetup/modest-easysetup-wizard.c:
1996 (create_page_welcome), (create_page_account_details),
1997 (create_page_user_details), (create_page_complete_easysetup),
1998 (create_page_custom_incoming), (create_page_custom_outgoing),
1999 (create_page_complete_custom):
2000 * src/maemo/modest-account-settings-dialog.c:
2001 (create_page_account_details), (create_page_user_details),
2002 (create_page_incoming), (create_page_outgoing):
2003 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2004 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2005 (modest_connection_specific_smtp_edit_window_init):
2006 * src/maemo/modest-connection-specific-smtp-window.c:
2007 (modest_connection_specific_smtp_window_init):
2008 * src/maemo/modest-signature-editor-dialog.c:
2009 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2010 and scrolling policy as per the Email Application Layout Guide, if I have
2013 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2015 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2016 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2017 which were empty, because these vfuncs have been removed from TnyAccountStore.
2018 This fixes the build.
2020 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2022 * src/maemo/modest-main-window.c:
2023 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2024 showing/hiding it. Added TODO because it probably should not be NULL.
2025 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2026 because unnecessary g_warnings() make degugging difficult.
2028 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2030 * src/maemo/modest-msg-edit-window.c:
2031 (modest_msg_edit_window_select_color),
2032 (modest_msg_edit_window_select_background_color): 2 const corrections and
2033 moving 2 #endifs before closing brackets, to fix the build.
2035 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2037 * src/maemo/easysetup/modest-easysetup-wizard.h:
2038 * src/maemo/easysetup/modest-easysetup-wizard.c:
2039 (modest_easysetup_wizard_dialog_finalize),
2040 (on_button_edit_advanced_settings), (create_page_complete_custom),
2041 (on_response), (create_account):
2042 Implement the Advanced Settings edit button, by saving the account information,
2043 for the Advanded Settings dialog to use directly from gconf, and removing it
2044 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2045 Bug #5533 in the projects.maemo.org bugzilla.
2047 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2049 * src/maemo/modest-msg-view-window.c:
2050 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2051 when opening a message window.
2053 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2055 * src/maemo/easysetup/modest-easysetup-wizard.c:
2056 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2059 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2060 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2061 gconf settings. I probably added more checks than necessary, but that is safer.
2063 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2064 variable to fix the build, but this seems to be used when it is still NULL.
2066 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2068 * src/modest-platform.h:
2069 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2070 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2071 * src/modest-main.c: Implement this function so we can avoid using
2072 maemo-specific API from cross-platform code.
2074 * src/modest-tny-account-store.c:
2075 (get_smtp_specific_transport_account_for_open_connection):
2076 * src/modest-ui-actions.c: (check_for_connection),
2077 (modest_ui_actions_on_item_not_found):
2078 Use modest_platform_connect_and_wait() and put #idefs around other
2079 maemo-specific code, because only maemo currently has a way to
2080 identify connection names.
2082 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2084 * src/modest-tny-account-store.h:
2085 * src/modest-tny-account-store.c:
2086 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2087 the connection-specific SMTP server settings in the configuration.
2089 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2091 * src/maemo/modest-main-window.c: (on_connection_changed),
2093 * src/modest-main.c: (main), (start_ui), (send_mail):
2094 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2095 that is what is intended.
2097 * src/modest-ui-actions.c: (action_send), (action_receive),
2098 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2099 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2100 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2101 SMTP server is used when it is specified.
2103 (modest_ui_actions_on_send_receive):
2104 Check that a connection is open before proceeding.
2105 Receive and then send, instead of vice-versa, as per the specification.
2107 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2109 * src/modest-mail-operation.c:
2110 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2111 though I guess it should be something other than NULL.
2113 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2115 * src/maemo/easysetup/modest-easysetup-wizard.c:
2116 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2117 combo twice, to avoid an g_warning and to make it visible again.
2118 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2119 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2120 (already intended) dereference when detaching, because we then recreate the menu.
2121 But I am not sure why the warning was happening, and it is possible that this is a memory
2124 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2126 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2127 and uri_parse_mailto() utility functions.
2128 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2130 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2132 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2134 * src/dbus_api/modest-dbus-api.h:
2135 * src/dbus_api/modest-dbus-callbacks.c:
2136 Use an idle callback to execute the modest code in the application's own thread.
2137 Remove the helloworld example method.
2138 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2139 parsed, and the open-message method is not implemented because this is not yet implemented in
2141 * libmodest-dbus-client/libmodest-dbus-client.c:
2142 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2143 (libmodest_dbus_client_open_message):
2144 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2146 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2147 body without crashing.
2149 * tests/dbus_api/Makefile.am:
2150 * tests/dbus_api/test_mail_to.c:
2151 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2153 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2155 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2156 Added file to fix the build. Sorry.
2158 * src/dbus_api/Makefile.am:
2159 * src/dbus_api/modest-dbus-api.h:
2160 * src/dbus_api/modest-dbus-callbacks.h:
2161 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2162 (modest_dbus_req_handler):
2163 Put constants in a separate header so it can be reused by the
2164 client library, without duplication
2166 * libmodest-dbus-client/Makefile.am:
2167 * libmodest-dbus-client/libmodest-dbus-client.c:
2168 (libmodest_dbus_client_call_helloworld),
2169 (libmodfest_dbus_client_send_mail),
2170 (libmodfest_dbus_client_mailto),
2171 (libmodfest_dbus_client_open_message):
2172 * libmodest-dbus-client/libmodest-dbus-client.h:
2173 (Partly) Implement a send_mail D-Bus method.
2175 * tests/dbus_api/Makefile.am:
2176 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2177 the send_email D-Bus method.
2179 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2183 * libmodest-dbus-client/Makefile.am:
2184 * libmodest-dbus-client/libmodest-dbus-client.c:
2185 * libmodest-dbus-client/libmodest-dbus-client.h:
2186 * tests/dbus_api/Makefile.am:
2187 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2188 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2190 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2192 * src/maemo/easysetup/modest-easysetup-wizard.c:
2193 (create_page_account_details):
2194 * src/maemo/modest-account-settings-dialog.c:
2195 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2196 widgets, because this might not be the default in future versions of the Maemo GTK+.
2197 However, I can not not get capitalization to work even in a simple test case.
2199 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2201 * src/maemo/easysetup/modest-easysetup-wizard.c:
2202 (create_page_custom_incoming), (create_page_custom_outgoing):
2203 * src/maemo/modest-account-settings-dialog.c:
2204 (create_page_account_details), (create_page_incoming),
2205 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2206 instead of using gtk_check_button_with_label(), so they are aligned like the other
2207 widgets, as per the UI spec.
2209 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2211 * src/maemo/easysetup/modest-easysetup-wizard.c:
2212 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2213 * src/widgets/modest-validating-entry.c:
2214 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2215 Modest prefix instead of an EasySetup prefix.
2217 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2219 * src/widgets/modest-validating-entry.h:
2220 * src/widgets/modest-validating-entry.c: (on_insert_text),
2221 Added easysetup_validating_entry_set_max_func(), used to set a callback
2222 to call when the max number of characters is reached. GtkEntry has a max-length
2223 already but is silent about it.
2225 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2226 (create_page_account_details), (create_page_user_details),
2228 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2229 (create_page_account_details), (create_page_user_details),
2230 (create_page_outgoing):
2231 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2232 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2233 the UI spec, when the user tries to enter more than the max number of characters.
2235 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2237 * src/maemo/easysetup/modest-easysetup-wizard.c:
2238 (create_page_user_details), (create_page_custom_incoming),
2239 (create_page_custom_outgoing):
2240 * src/maemo/modest-account-settings-dialog.c:
2241 (create_page_user_details), (create_page_incoming),
2242 (create_page_outgoing):
2243 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2244 (modest_connection_specific_smtp_edit_window_init):
2245 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2246 not appropriate. Bad Maemo-specific defaults!.
2248 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2250 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2251 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2252 (modest_signature_editor_dialog_set_settings):
2253 Disable the label and textview when the checkbox is disabled, and use the
2254 specified (UI spec) default signature text.
2256 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2258 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2259 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2261 * src/modest-defs.h:
2262 * src/modest-account-mgr-helpers.h:
2263 * src/modest-account-mgr-helpers.c:
2264 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2266 * src/maemo/Makefile.am:
2267 * src/maemo/modest-signature-editor-dialog.c:
2268 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2271 * src/maemo/modest-account-settings-dialog.h:
2272 * src/maemo/modest-account-settings-dialog.c:
2273 (modest_account_settings_dialog_finalize), (on_button_signature),
2274 (save_configuration): Use the new dialog when the Edit button is pressed, and
2275 save the changes if necessary, as per the UI spec.
2277 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2279 * src/maemo/Makefile.am:
2280 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2281 based on maemo-develoers email from Dirk.
2283 * src/maemo/easysetup/modest-easysetup-wizard.c:
2284 (create_page_welcome), (create_page_account_details),
2285 (create_page_user_details), (create_page_complete_easysetup),
2286 (create_page_custom_incoming), (create_page_custom_outgoing),
2287 (create_page_complete_custom),
2288 (modest_easysetup_wizard_dialog_init):
2289 * src/maemo/modest-account-settings-dialog.c:
2290 (create_page_account_details), (create_page_user_details),
2291 (create_page_incoming), (create_page_outgoing),
2292 (modest_account_settings_dialog_init):
2293 * src/maemo/modest-connection-specific-smtp-window.c:
2294 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2296 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2298 * src/maemo/easysetup/modest-easysetup-wizard.c:
2299 (create_page_account_details), (create_page_custom_outgoing),
2300 (create_page_complete_custom):
2301 * src/maemo/modest-account-settings-dialog.c:
2302 (create_page_user_details), (create_page_incoming),
2303 (create_page_outgoing):
2304 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2305 (modest_connection_specific_smtp_edit_window_init):
2306 Use the correct (UI spec) port min/max, and use horizontal separators,
2309 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2311 * src/maemo/easysetup/modest-easysetup-wizard.c:
2312 (set_default_custom_servernames):
2313 * src/maemo/modest-account-settings-dialog.c:
2314 (create_page_incoming), (on_combo_outgoing_security_changed),
2315 (on_combo_incoming_security_changed), (create_page_outgoing),
2316 (modest_account_settings_dialog_set_account_name),
2317 (save_configuration):
2318 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2319 (on_combo_security_changed),
2320 (modest_connection_specific_smtp_edit_window_init),
2321 (modest_connection_specific_smtp_edit_window_set_connection),
2322 (modest_connection_specific_smtp_edit_window_get_settings):
2323 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2326 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2329 * src/maemo/easysetup/modest-easysetup-wizard.c:
2330 (create_page_custom_outgoing), (create_page_complete_custom):
2331 * src/maemo/modest-account-settings-dialog.c:
2332 (create_page_user_details), (create_page_outgoing):
2333 * src/maemo/modest-account-view-window.c: (button_box_new):
2334 Use changed logical IDs as per the most recent UI spec:
2335 mcen_bd_emailsetup_edit -> mcen_bd_edit
2336 mcen_bd_emailsetup_delete -> mcen_bd_delete
2337 mcen_bd_emailsetup_close -> mcen_bd_close
2339 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2343 * src/dbus_api/Makefile.am:
2344 * src/dbus_api/modest-dbus-callbacks.c:
2345 * src/dbus_api/modest-dbus-callbacks.h:
2346 * src/maemo/modest-platform.c: (modest_platform_init):
2347 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2349 * tests/Makefile.am:
2350 * tests/dbus_api/Makefile.am:
2351 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2353 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2355 * src/maemo/modest-account-settings-dialog.c:
2356 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2357 Removed unnecessary includes.
2359 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2361 * src/maemo/easysetup/modest-easysetup-wizard.c:
2362 * src/maemo/modest-account-settings-dialog.c:
2363 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2364 * src/widgets/Makefile.am:
2365 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2366 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2367 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2368 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2369 * src/widgets/modest-secureauth-combo-box.c:
2370 * src/widgets/modest-secureauth-combo-box.h:
2371 * src/widgets/modest-serversecurity-combo-box.c:
2372 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2373 made the GObject names more consistent with the rest of the Modest code.
2375 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2377 * src/maemo/easysetup/Makefile.am:
2378 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2379 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2380 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2381 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2382 * src/maemo/easysetup/modest-easysetup-wizard.c:
2383 * src/maemo/easysetup/modest-validating-entry.c:
2384 * src/maemo/easysetup/modest-validating-entry.h:
2385 * src/maemo/modest-account-settings-dialog.c:
2386 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2387 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2388 widgets/ because they are used outside of easysetup too. After checking in,
2389 svn will allow me to rename them too.
2391 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2393 * src/gnome/modest-msg-edit-window.c:
2394 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2395 linker error, to fix the build on the GNOME platform.
2396 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2397 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2398 ifdefed out to avoid a warning.
2400 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2402 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2403 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2404 some alternative for GTK+ 2.6.
2406 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2408 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2410 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2411 specified for EmailAccountsDialog in UI spec.
2413 * src/maemo/easysetup/modest-easysetup-wizard.c:
2414 * src/maemo/easysetup/modest-easysetup-wizard.h:
2415 * src/maemo/modest-account-settings-dialog.c:
2416 * src/maemo/modest-account-settings-dialog.h:
2417 Reuse a member window widget for the connection-specific SMTP server accounts,
2418 so we can tell it to create/save the accounts only if we actually save changes.
2420 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2421 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2422 (modest_connection_specific_smtp_edit_window_get_settings):
2423 Return a struct instance for temporarily remembering the entered data.
2425 * src/maemo/modest-connection-specific-smtp-window.h:
2426 * src/maemo/modest-connection-specific-smtp-window.c:
2427 (modest_connection_specific_smtp_window_finalize),
2428 (modest_connection_specific_smtp_window_fill_with_connections),
2430 (modest_connection_specific_smtp_window_save_server_accounts),
2431 (update_model_server_names): Do not actually save data until asked,
2432 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2434 (on_selection_changed),
2435 (modest_connection_specific_smtp_window_init): Disable the edit
2436 button when nothing is selected.
2438 * src/modest-account-mgr-helpers.c:
2439 * src/modest-account-mgr-helpers.h:
2440 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2443 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2445 * src/modest-account-mgr-helpers.h:
2446 * src/modest-account-mgr-helpers.c:
2447 (modest_account_mgr_get_unused_account_name),
2448 (modest_account_mgr_get_unused_account_display_name): Added these
2449 utility functions, to avoid code duplication.
2451 * src/maemo/easysetup/modest-easysetup-wizard.c:
2452 (create_page_account_details), (create_account):
2453 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2454 (on_combo_security_changed),
2455 (modest_connection_specific_smtp_edit_window_init),
2456 (modest_connection_specific_smtp_edit_window_save_settings):
2457 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2458 * src/maemo/modest-connection-specific-smtp-window.c:
2459 (modest_connection_specific_smtp_window_finalize),
2460 (modest_connection_specific_smtp_window_fill_with_connections),
2461 (on_button_edit), (modest_connection_specific_smtp_window_init):
2462 * src/maemo/modest-connection-specific-smtp-window.h:
2463 Implementing saving of connection-specific server accounts.
2465 But I need to refactor this so we can save the data for each
2466 possible connection-specific account and only actually create the server accounts
2467 when the easysetup finished, or the OK button is pressed on the account settings
2470 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2472 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2473 (on_combo_security_changed):
2474 (modest_connection_specific_smtp_edit_window_init):
2475 Auto-fill the port number as in the account settings.
2477 (modest_connection_specific_smtp_edit_window_set_connection):
2478 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2479 * src/maemo/modest-connection-specific-smtp-window.c:
2480 (fill_with_connections), (on_button_edit),
2481 (modest_connection_specific_smtp_window_init):
2482 Turn the edit window into a dialog to simplify the code, and
2483 set a WM hint as in a GtkDialog, because only a popup can be on top of
2484 another window in Maemo, and popups usually have no WM decoration.
2486 * src/modest-defs.h:
2487 * src/modest-account-mgr-helpers.c:
2488 (modest_account_mgr_set_connection_specific_smtp),
2489 (modest_account_mgr_remove_connection_specific_smtp),
2490 (modest_account_mgr_get_connection_specific_smtp):
2491 * src/modest-account-mgr-helpers.h: Some functions to write the
2492 connection-specific SMTP server information. Not yet used.
2495 * src/widgets/modest-folder-view.c: (text_cell_data):
2496 Fix a warning about an uninitialized variable.
2497 (on_configuration_key_changed): Put an #ifdef around the use
2498 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2500 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2502 * src/maemo/modest-account-settings-dialog.h:
2503 * src/maemo/modest-account-settings-dialog.c:
2504 Added connect_for_modified() utility function to mark the new modified boolean.
2506 (create_page_account_details), (create_page_user_details),
2507 (create_page_incoming), (create_page_outgoing), (on_response),
2508 (modest_account_settings_dialog_init),
2509 (modest_account_settings_dialog_set_account_name):
2510 Only warn about unsaved changes when there are actually unsaved changes.
2512 * src/modest-account-mgr-helpers.c:
2513 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2514 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2515 to get the data from there in future.
2517 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2519 * src/modest-defs.h:
2521 * src/modest-account-mgr-helpers.h:
2522 * src/modest-account-mgr-helpers.c:
2523 Store the security account setting in a single conf key instead of using
2524 the options list, so that the list is left for just the to-be-removed camel hack,
2525 and because gconf_client_set_list() is failing for some reason.
2527 * src/modest-account-mgr.c:
2528 (modest_account_mgr_add_server_account):
2529 * src/maemo/modest-account-settings-dialog.c:
2530 (modest_account_settings_dialog_set_account_name),
2531 (save_configuration): Use the renamed functions.
2534 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2536 * src/widgets/Makefile.am:
2537 * src/widgets/modest-limit-retrieve-combo-box.c:
2538 * src/widgets/modest-limit-retrieve-combo-box.h:
2539 * src/widgets/modest-retrieve-combo-box.c:
2540 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2541 the account settings dialog.
2543 * src/modest-defs.h:
2544 * src/modest-account-mgr-helpers.h:
2545 * src/modest-account-mgr-helpers.c:
2546 (modest_server_account_get_option_secure_auth),
2547 (modest_server_account_set_option_secure_auth):
2548 * src/modest-account-mgr.c:
2549 (modest_account_mgr_add_server_account):
2550 Use the existing AUTH_MECH conf key for the secure-auth setting,
2551 instead of putting it in the list options, because this was actually used already.
2553 * src/maemo/modest-account-settings-dialog.c:
2554 (create_page_account_details),
2555 (modest_account_settings_dialog_set_account_name),
2556 (save_configuration):
2557 * src/maemo/modest-account-settings-dialog.h:
2558 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2559 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2561 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2563 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2564 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2565 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2567 * src/modest-defs.h:
2568 * src/maemo/modest-account-settings-dialog.c:
2569 (create_page_incoming), (on_combo_outgoing_security_changed),
2570 (on_combo_incoming_security_changed), (create_page_outgoing),
2571 (modest_account_settings_dialog_set_account_name),
2572 (save_configuration): Load/Save the port number, and change it when the
2573 security combo changes, to suitable defaults.
2575 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2577 * src/modest-account-mgr.c:
2578 (modest_account_mgr_add_server_account): Set the security and secure-auth
2579 options, and add a comment saying that the other camel-specific options should be
2582 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2584 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2586 * src/modest-tny-account-store.c: (account_list_free),
2587 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2588 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2591 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2593 * src/modest-protocol-info.c:
2594 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2595 is required by our UI spec. Maybe something in our implementation will use this eventually.
2596 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2597 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2598 instead of the previous 0 placeholder.
2600 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2601 secure-auth settings.
2602 * src/modest-account-mgr-helpers.h:
2603 * src/modest-account-mgr-helpers.c:
2604 (modest_server_account_data_get_option_secure_auth),
2605 (modest_server_account_set_option_secure_auth),
2606 (modest_server_account_data_get_option_security),
2607 (modest_server_account_set_option_security): Added this API for getting and setting the security
2608 and secure-auth settings.
2610 * src/maemo/modest-account-settings-dialog.h:
2611 * src/maemo/modest-account-settings-dialog.c:
2612 (modest_account_settings_dialog_finalize), (check_data),
2613 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2614 about changing titles.
2615 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2616 (save_configuration): Save the security and secure-auth settings.
2618 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2619 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2621 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2623 * src/modest-defs.h:
2624 * src/modest-account-mgr.c:
2625 (modest_account_mgr_add_server_account):
2626 Added and used defines for the options key and value pair strings,
2627 that are used so far, though they do not seem to correspond to anything in our
2628 UI specs or ModestProtocol enum.
2630 * src/modest-account-mgr-helpers.h:
2631 * src/modest-account-mgr-helpers.c:
2632 (compare_option_strings_for_name),
2633 (modest_server_account_data_get_option_value),
2634 (modest_server_account_data_get_option_bool),
2635 (modest_account_mgr_get_server_account_option):
2636 Added helper functions for parsing the options GSList.
2638 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2640 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2641 display name is based on the supplied account name.
2642 * src/modest-account-mgr.c:
2643 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2644 with an inefficient, but good-enough, implementation.
2646 * src/maemo/easysetup/modest-easysetup-wizard.c:
2647 (create_page_account_details), (on_before_next), (create_account):
2648 Check for existing display names rather than (non-user-visible) account names, and just
2649 create and set a unique account name at the end.
2651 * src/maemo/modest-account-settings-dialog.c:
2652 (modest_account_settings_dialog_init),
2653 (modest_account_settings_dialog_set_account_name),
2654 (create_page_incoming): Show the display name, instead of the account name.
2655 (on_response): Do some (not all) extra checks, as in the UI spec.
2656 (save_configuration): Save the display name if it was changed.
2658 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2660 * po/en_GB.po: Added needed logical ID and translation.
2661 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2662 (init_view): Made the is-default column clicking work.
2664 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2667 * src/maemo/easysetup/Makefile.am:
2668 * src/maemo/easysetup/modest-easysetup-wizard.c:
2669 (modest_easysetup_wizard_dialog_init):
2670 * src/maemo/easysetup/provider-data-test.keyfile:
2671 * src/maemo/easysetup/provider-data.keyfile:
2672 Moved the provider data file to the new modest-providers-data package and used it from there.
2674 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2676 * src/modest-local-folder-info.c:
2677 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2678 N_() was already used on the static strings, but this just marks it for translation without
2679 using the translation.
2681 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2683 * src/maemo/modest-account-settings-dialog.c:
2684 (create_page_incoming),
2685 (modest_account_settings_dialog_set_account_name):
2686 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2687 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2688 I will do this if nobody else gets there first.
2690 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2692 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2693 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2694 save the security stuff.
2696 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2698 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2699 Set the email address and user fullname, which I now see must be
2702 * src/maemo/modest-account-settings-dialog.h:
2703 * src/maemo/modest-account-settings-dialog.c:
2705 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2706 leave-on-server and authentication.
2707 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2710 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2713 * src/maemo/modest-account-settings-dialog.c:
2714 * src/maemo/modest-account-settings-dialog.h:
2715 Most (but not all) of the widgets are now present as specified by the UI spec.
2716 No changes are yet saved, and some details are not properly shown yet.
2718 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2720 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2722 * src/maemo/Makefile.am:
2723 * src/maemo/modest-account-settings-dialog.c:
2724 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2725 an existing account. Doesn't do much yet.
2727 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2728 Open the accounts settings dialog when Edit is clicked.
2730 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2732 * src/maemo/easysetup/Makefile.am:
2733 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2735 * src/maemo/easysetup/modest-easysetup-wizard.c:
2736 (modest_easysetup_wizard_dialog_init):
2737 Try to get the source directory from the build system,
2738 instead of hard-coding "./" into the source code, when opening our local
2739 copies of the configuration files.
2740 But this still fails when opening the wizard from the Accounts window,
2741 maybe because the working directory seems to change at runtime.
2742 So the wizard will fail the second time unless you copy the files into their
2743 proper locations - see the stdout warnings for the paths.
2745 (create_page_account_details),(on_before_next):
2746 Check for existing non-server accounts instead of server accounts,
2747 so the default account name is useful again, and to prevent trying to
2750 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2751 Show the wizard when New is clicked.
2753 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2754 (init_view): Show the column headers, and show the columns that are
2755 specified in the UI specs. However, something in Maemo's GTK+ prevents
2756 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2757 change the default account. This is despite unsetting the special properties.
2759 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2761 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2762 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2763 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2764 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2765 to make that clearer.
2766 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2768 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2770 * src/maemo/modest-account-view-window.c:
2771 (modest_account_view_window_init),
2772 (modest_account_view_window_new):
2773 Use the same buttons as specified in the
2774 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2775 the existing widgets, which never had a chance of working.
2776 Put the ModestAccountView treeview in a scrolled window.
2777 Do not repeat the initialization in both _init() and _new().
2779 * src/widgets/modest-account-view.c: (update_account_view):
2780 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2781 this widget and window shows no accounts.
2783 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2785 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2787 * src/maemo/easysetup/modest-easysetup-wizard.c:
2788 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2789 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2790 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2793 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2794 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2795 accounts exist yet, as in the UI spec.
2797 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2799 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2801 * src/maemo/Makefile.am:
2802 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2803 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2804 New window for editing connection-specific smtp details.
2805 Not fully implemented.
2807 * src/maemo/modest-connection-specific-smtp-window.c:
2808 (modest_connection_specific_smtp_window_finalize) :
2809 unref the tree model.
2810 (on_button_edit): Show the edit window.
2812 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2814 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2817 * src/maemo/Makefile.am:
2818 * src/maemo/modest-connection-specific-smtp-window.c:
2819 * src/maemo/modest-connection-specific-smtp-window.h:
2820 New window for showing the list of connections, for connection-specific
2821 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2822 * src/maemo/easysetup/modest-easysetup-wizard.c:
2823 (create_page_custom_outgoing): Show the new window when the button is clicked.
2825 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2827 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2828 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2829 * src/maemo/modest-msg-edit-window.c:
2830 (modest_msg_edit_window_insert_image):
2831 * src/modest-conf.c: (modest_conf_key_escape):
2832 * src/modest-mail-operation.c:
2833 (modest_mail_operation_send_new_mail):
2834 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2835 (modest_ui_actions_on_new_account):
2836 * src/widgets/modest-attachment-view.c: (update_filename_request):
2837 * src/widgets/modest-mail-header-view.c:
2838 Corrected warnings that were breaking the build, by commenting out unused variables,
2839 and a function, and by including a header.
2841 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2843 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2844 so we can #ifdef around platform-specific code when necessary.
2845 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2846 to allow this to build for the GNOME platform too.
2848 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2850 * src/maemo/easysetup/modest-easysetup-wizard.c:
2851 Added util_increment_name() and used it in create_page_account_details()
2852 to make sure that the default account name is always a new name.
2854 (modest_easysetup_wizard_dialog_init),
2855 (set_default_custom_servernames): Some minor memory management fixes.
2857 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2861 * src/modest-runtime.c: (init_i18n): Restored the translation
2862 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2863 are defined in config.h, and the translations are installed.
2865 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2866 is defined for translation.
2868 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2870 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2872 * src/maemo/easysetup/modest-easysetup-wizard.c:
2873 (modest_easysetup_wizard_dialog_init):
2874 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2875 Use realistic paths (though they should use $prefix generically) to the
2876 mcc_mapping and provider-data.keyfile files which might work when they
2877 are installed by the future version of the operator-wizard package,
2878 and then fallback to paths in our source code, with an explanatory
2881 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2885 * src/maemo/Makefile.am:
2886 * src/maemo/easysetup/: Added files from the previously-exernal
2887 osso-modest-easysetup.
2888 * src/maemo/modest-main-window-ui.h:
2889 * src/modest-ui-actions.c:
2890 * src/modest-ui-actions.h:
2891 Added modest_ui_actions_on_new_account() as a signal handler for the
2892 New Account menu item. It shows the easysetup wizard.
2893 * po/en_GB.po: Added additional needed logical IDs and translations.
2895 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2896 Apparently ChangeLog is not used for some vague Nokia legal reasons.