git.maemo.org Git - modest/blob - ChangeLog2

   1 2007-05-17  Murray Cumming  <murrayc@murrayc.com>
   2
   3         * src/maemo/modest-connection-specific-smtp-edit-window.h:
   4         * src/maemo/modest-connection-specific-smtp-edit-window.c:
   5         (modest_connection_specific_smtp_edit_window_init),
   6         Do not try to connect to a combobox signal before the combobox exists.
   7         This fixes the cras in projects.maemo.org bug NB#56288 .
   8         (modest_connection_specific_smtp_edit_window_get_settings):
   9         Remove the server_account_name parameter which was being checked for NULL
  10         though it was not used.
  11
  12         * src/maemo/modest-connection-specific-smtp-window.c:
  13         (modest_connection_specific_smtp_window_fill_with_connections),
  14         (on_button_edit), (modest_connection_specific_smtp_window_init):
  15         Correct the number of treemodel columns to prevent a warning.
  16         Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
  17         libconic does not work.
  18
  19 2007-05-16  Murray Cumming  <murrayc@murrayc.com>
  20
  21         * src/modest-tny-account.c:
  22         (modest_tny_account_new_from_server_account):
  23         Excplicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
  24         SMTP when "None" was chosen by the user. However, with my SMTP server that
  25         does not support ANONYMOUS, the emails do not leave the Outbox and I see
  26         no error dialog.
  27
  28 2007-05-16  Murray Cumming  <murrayc@murrayc.com>
  29
  30         * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
  31         to explain the memory management issue with the ID in the ModestPair.
  32
  33         * src/gnome/modest-account-assistant.c: (add_receiving_page),
  34         (add_sending_page), (modest_account_assistant_finalize):
  35         * src/gnome/modest-gnome-global-settings-dialog.c:
  36         (create_updating_page), (create_composing_page):
  37         * src/gnome/modest-msg-edit-window.c: (get_transports),
  38         (init_window), (modest_msg_edit_window_finalize),
  39         (modest_msg_edit_window_get_msg_data):
  40         * src/gnome/modest-store-widget.c: (imap_pop_configuration):
  41         * src/gnome/modest-transport-widget.c:
  42         (modest_transport_widget_finalize), (smtp_configuration):
  43         * src/maemo/modest-maemo-global-settings-dialog.c:
  44         (create_updating_page), (create_composing_page):
  45         * src/maemo/modest-msg-edit-window.c: (get_transports),
  46         (init_window), (modest_msg_edit_window_finalize),
  47         (modest_msg_edit_window_get_msg_data),
  48         (modest_msg_edit_window_free_msg_data):
  49         * src/maemo/modest-store-widget.c: (imap_pop_configuration),
  50         (modest_store_widget_finalize):
  51         * src/maemo/modest-transport-widget.c:
  52         (modest_transport_widget_finalize), (smtp_configuration):
  53         * src/modest-main.c: (send_mail):
  54         * src/widgets/modest-combo-box.h:
  55         * src/widgets/modest-global-settings-dialog-priv.h:
  56         * src/widgets/modest-global-settings-dialog.c:
  57         (modest_global_settings_dialog_finalize):
  58         * src/widgets/modest-msg-edit-window.h:
  59         Whenever using modest_combo_box_new(), keep the ModestPairList alive
  60         as long as the combo box, to prevent use of freed memory for the ID.
  61
  62 2007-05-15  Murray Cumming  <murrayc@murrayc.com>
  63
  64         * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
  65         get_accounts(), to make this clearer. Do not check for the enabled gconf
  66         key, because we do not use this for server accounts (at least, not yet).
  67         This allows us to send email again.
  68
  69 2007-05-15  Murray Cumming  <murrayc@murrayc.com>
  70
  71         * src/maemo/modest-platform.c:
  72         (on_modest_conf_update_interval_changed), (modest_platform_init):
  73         Only respond to this particular key change. All these strcmp()s cannot be
  74         efficient.
  75
  76 2007-05-15  Murray Cumming  <murrayc@murrayc.com>
  77
  78         * src/maemo/modest-maemo-global-settings-dialog.c:
  79         (current_connection): Prevent a crash in scratchbox when
  80         ny_maemo_conic_device_get_current_iap_id() returns NULL.
  81         * src/maemo/modest-platform.c:
  82         (on_modest_conf_update_interval_changed), (modest_platform_init):
  83         Get the update interval from gconf and reset it when the gconf key changes.
  84
  85 2007-05-15  Murray Cumming  <murrayc@murrayc.com>
  86
  87         * src/modest-protocol-info.c:
  88         * src/modest-protocol-info.h: Adde enum-specific get functions,
  89         instead of using a ModestProtocolType enum parameter.
  90
  91         * src/gnome/modest-account-assistant.c:
  92         * src/gnome/modest-store-widget.c:
  93         * src/gnome/modest-store-widget.h:
  94         * src/gnome/modest-transport-widget.c:
  95         * src/gnome/modest-transport-widget.h:
  96         * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
  97         * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
  98         * src/maemo/easysetup/modest-easysetup-wizard.c:
  99         * src/maemo/modest-account-settings-dialog.c:
 100         * src/maemo/modest-account-settings-dialog.h:
 101         * src/maemo/modest-store-widget.c:
 102         * src/maemo/modest-store-widget.h:
 103         * src/maemo/modest-transport-widget.c:
 104         * src/maemo/modest-transport-widget.h:
 105         * src/modest-account-mgr-helpers.c:
 106         * src/modest-account-mgr-helpers.h:
 107         * src/modest-account-mgr.c:
 108         * src/modest-account-mgr.h:
 109         * src/modest-tny-account.c:
 110         * src/modest-tny-folder.c:
 111         * src/widgets/modest-account-view.c:
 112         * src/widgets/modest-retrieve-combo-box.c:
 113         * src/widgets/modest-retrieve-combo-box.h:
 114         * src/widgets/modest-secureauth-combo-box.c:
 115         * src/widgets/modest-serversecurity-combo-box.c:
 116         * src/widgets/modest-serversecurity-combo-box.h:
 117         * tests/check_account-mgr.c:
 118         Use the specific functions, and use the re-renamed enum values for GNOME too.
 119
 120 2007-05-15  Murray Cumming  <murrayc@murrayc.com>
 121
 122         * src/modest-pair.h:
 123         * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
 124         so we can get the second based on the first.
 125
 126         * src/maemo/modest-account-settings-dialog.h:
 127         * src/maemo/modest-account-settings-dialog.c:
 128         Added get_supported_secure_authentication_methods(), though it is mostly
 129         commented-out for now until the necessary API is committed to tinymail.
 130         (modest_account_settings_dialog_set_account_name),
 131         (save_configuration): Request the supported authentication methods from the
 132         server, so we can choose a working method.
 133
 134         * src/modest-tny-account-store.h:
 135         * src/modest-tny-account-store.c:
 136         (modest_tny_account_store_get_session): Rename from
 137         tny_account_store_get_session().
 138
 139 2007-05-14  Murray Cumming  <murrayc@murrayc.com>
 140
 141         * src/modest-protocol-info.h: Split the ModestProtocol enum
 142         into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
 143         There was no need to have these unrelated values in one enum.
 144
 145         * src/: many files: Adapted to changed enum. This makes the code a bit
 146         clearer, and the compiler could catch some errors.
 147
 148 2007-05-14  Murray Cumming  <murrayc@murrayc.com>
 149
 150         * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
 151         Show the detailed internal camel error message when an error happens
 152         during the configuration, so that our testers can give us more clues.
 153         For instance, in projects.maemo.org bug NB#56910 .
 154
 155 2007-05-14  Murray Cumming  <murrayc@murrayc.com>
 156
 157         * src/modest-tny-account.c:
 158         (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
 159         change tny_account_set_mech() to tny_account_set_secure_auth_mech().
 160
 161 2007-05-14  Murray Cumming  <murrayc@murrayc.com>
 162
 163         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 164         * src/maemo/modest-account-settings-dialog.c:
 165         (modest_account_settings_dialog_set_account_name),
 166         (save_configuration): For the incoming secure authentication checkbox,
 167         use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
 168         the UI specification. PLAIN does not seem to be supported for most IMAP
 169         servers anyway, and I am not sure what it would mean.
 170         However, we probably need to discover which of the secure-authentication
 171         mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
 172         * src/modest-account-mgr-helpers.c:
 173         (modest_account_mgr_get_server_account_data):
 174
 175         * src/modest-tny-account.c:
 176         (modest_tny_account_new_from_server_account):
 177         Use tny_account_set_mech() to set secure-authentication methods,
 178         with some special-casing for IMAP, based on my observations of how
 179         evolution behaves.
 180
 181         * src/modest-account-mgr-helpers.h:
 182         * src/modest-account-mgr.c:
 183         * src/modest-defs.h: Comment that the URI is only used for local folders.
 184
 185 2007-05-11  Murray Cumming  <murrayc@murrayc.com>
 186
 187         * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
 188         parameter const, just to be neat.
 189         * src/modest-text-utils.c: (modest_text_utils_inline):
 190         End g_strconcat() with NULL, as its documentation says. This is almost
 191         certainly the cause of my crash at startup on the device. Interestingly,
 192         valgrind doesn't tell us about these errors.
 193
 194 2007-05-11  Murray Cumming  <murrayc@murrayc.com>
 195
 196         * scripts/build-packages: Added more precise comments about how to use
 197         this script, though I still get this error:
 198         dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
 199         error building tinymail
 200
 201 2007-05-11  Murray Cumming  <murrayc@murrayc.com>
 202
 203         * src/maemo/modest-main-window.c: (on_account_update):
 204         Very slight cleanup, hoping to make it simpler to discover what causes
 205         a crash here sometimes.
 206
 207         * src/modest-tny-account.c:
 208         (modest_tny_account_new_from_server_account): Set the port. Added
 209         comments about the options and a TODO comment because I need to find out
 210         how to specify the secure authentication method.
 211
 212 2007-05-11  Marcus Bauer  <marcusb@openismus.com>
 213
 214         * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
 215         changed CFlags paths form modest to libmodest
 216
 217 2007-05-10  Murray Cumming  <murrayc@murrayc.com>
 218
 219         * src/modest-account-mgr-helpers.c:
 220         (modest_account_mgr_get_server_account_data),
 221         (modest_account_mgr_free_server_account_data):
 222         * src/modest-account-mgr-helpers.h:
 223         * src/modest-account-mgr.c:
 224         (modest_account_mgr_add_server_account):
 225         * src/modest-defs.h:
 226         * src/modest-tny-account.c:
 227         (modest_tny_account_new_from_server_account):
 228         Determine the options for tny_camel_account_add_option() here,
 229         based on the settings, rather than storing them directly in gconf.
 230
 231 2007-05-10  Murray Cumming  <murrayc@murrayc.com>
 232
 233         * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
 234         Show a more friendly error dialog now that we expect (from the tinymail
 235         documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
 236
 237 2007-05-10  Murray Cumming  <murrayc@murrayc.com>
 238
 239         * src/maemo/modest-main-window.c: (on_account_update): Check that
 240         account_name is not NULL, to prevent a crash at startup that I am
 241         seeing on the N800. I do wonder why it is NULL.
 242
 243         * src/maemo/easysetup/modest-easysetup-wizard.c:
 244         (create_page_user_details):
 245         * src/maemo/modest-account-settings-dialog.c:
 246         (create_page_user_details), (create_page_outgoing):
 247         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 248         (modest_connection_specific_smtp_edit_window_init):
 249         * src/modest-ui-actions.c:
 250         (modest_ui_actions_on_password_requested):
 251         Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
 252         might do something useful with the on-screen keyboard.
 253
 254 2007-05-10  Murray Cumming  <murrayc@murrayc.com>
 255
 256         * src/maemo/modest-main-window.c: (on_account_update):
 257         Avoid adding a menu item to priv->accounts_popup if accounts_popup is
 258         NULL, to avoid lots of warnings. However, it probably should not be NULL.
 259
 260 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
 261
 262         * src/modest-tny-account-store.c: (on_account_changed):
 263         Correct the signature of this signal handler.
 264
 265 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
 266
 267         * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
 268         Show a HildonNote instead of a GtkDialog for Maemo.
 269
 270 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
 271
 272         * src/widgets/modest-account-view.h:
 273         * src/widgets/modest-account-view.c: (on_account_changed),
 274         (on_account_removed). Added a boolean flag, set/unset by
 275         modest_account_view_block_conf_updates(),
 276         modest_account_view_unblock_conf_updates() to prevent unnecessary
 277         updates, but this is not very useful because the gconf notifications are
 278         so delays (maybe only on Maemo Bora).
 279         So auto-updating is turned off, and these functions do an explicit
 280         update when necessary.
 281         However, something else is still doing too much work when adding/removing
 282         accounts, probably in another part of the application.
 283
 284         * src/maemo/modest-account-view-window.c:
 285         (on_delete_button_clicked), (on_edit_button_clicked),
 286         (on_new_button_clicked): Use the new functions.
 287
 288 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
 289
 290         * src/modest-account-mgr-helpers.c:
 291         (modest_account_mgr_set_first_account_as_default):
 292         Sort the list of names alphabetically-by-title, so we choose the first one
 293         based on that.
 294         * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
 295         alphabetically by the title.
 296
 297         This fixes projects.maemo.org bug NB#56418 .
 298
 299         * src/modest-account-mgr-priv.c:
 300         (_modest_account_mgr_account_from_key):
 301         * src/modest-account-mgr.c: (on_key_change): Initialize variables to
 302         avoid a valgrind error, and possible random behaviour.
 303
 304 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
 305
 306         * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
 307         Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
 308         tinymail documentation to say that this can be expected.
 309         Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
 310         pretty, and should not happen, but I would prefer to know when it does.
 311
 312 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
 313
 314         * configure.ac: When using the older hildon version, probably on Bora,
 315         require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
 316         to fix the build.
 317         * src/widgets/modest-attachment-view.c:
 318         (modest_attachment_view_set_part_default): Initialize variables, to fix the
 319         build.
 320
 321 2007-05-09  Marcus Bauer  <marcusb@openismus.com>
 322
 323         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
 324         Implemented the prototype. Can be tested with
 325         tests/dbus_api/test_open_message:
 326
 327 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 328
 329         * src/modest-tny-account-store.c:
 330         (modest_tny_account_store_instance_init), (get_password):
 331         * src/modest-ui-actions.c:
 332         (modest_ui_actions_on_password_requested):
 333         Do not store the password in gconf, because this function is called
 334         for non-remembered passwords. Actually use the cached (in the hash map)
 335         password instead of releasing it.
 336         The password will now not be remembered if it is asked via the protected
 337         password dialog, as per the UI spec.
 338
 339 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 340
 341         * src/modest-defs.h:
 342         * src/modest-account-mgr-helpers.h:
 343         * src/modest-account-mgr-helpers.c:
 344         Added modest_server_account_get_username_has_succeeded(),
 345         modest_server_account_set_username_has_succeeded().
 346         (modest_server_account_set_username),
 347         Reset the has-succeeded flag if the username changes.
 348
 349         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
 350         * src/maemo/modest-connection-specific-smtp-window.c:
 351         (modest_connection_specific_smtp_window_save_server_accounts):
 352         Use modest_server_account_set_username() instead of using
 353         modest_conf_set_string() directly, so that the has-succeeded flag is always
 354         reset.
 355
 356         * src/modest-ui-actions.c:
 357         (modest_ui_actions_on_password_requested): Dim the username entry if
 358         the username has ever worked, as per the UI spec.
 359
 360 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 361
 362         * src/modest-tny-account-store.c: (get_password):
 363         * src/modest-ui-actions.c:
 364         (modest_ui_actions_on_password_requested):
 365         Allow the username to be changed too, though there is more work to
 366         be done on exactly how this behaves.
 367
 368 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 369
 370         * src/modest-account-mgr-helpers.h:
 371         * src/modest-account-mgr-helpers.c:
 372         Added modest_account_mgr_get_display_name(),
 373         modest_server_account_get_username(),
 374         modest_server_account_set_username(),
 375         modest_server_account_set_password(),
 376         modest_server_account_get_hostname() functions so we do not need to
 377         use the conf API directly.
 378
 379         * src/maemo/modest-main-window.c: (connect_signals):
 380         Actually connect ot the ModestAccountStore::request-password signal,
 381         so that we show the dialog when the password is requested by Tinymail,
 382         for isntance if it is empty.
 383
 384         * src/modest-marshal.list:
 385         * src/modest-tny-account-store.c:
 386         (modest_tny_account_store_class_init), (get_password),
 387         (modest_tny_account_store_alert):
 388         * src/modest-tny-account-store.h:
 389         * src/modest-ui-actions.h:
 390         * src/modest-ui-actions.c:
 391         (modest_ui_actions_on_password_requested):
 392         Change the signal parameters, so it is obvious that we are providing
 393         the non human-readable server name, and receiving both the username
 394         and password, though changing of the username is not yet implemented.
 395         Change the dialog UI to match the Maemo UI specifications, with #idfefing
 396         for the GNOME version.
 397
 398         This should fix the projects.maemo.org bug NB#56209, though it does not
 399         work on Bora, because the gconf_client_get() for the password fails
 400         immediately after we save it with gconf_client_set().
 401
 402 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 403
 404         * configure.ac:
 405         * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
 406         caused an undefined symbol error:
 407         modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
 408
 409 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 410
 411         * src/modest-tny-account-store.c:
 412         (modest_tny_account_store_alert): Adapt to the changed tinymail API,
 413         using a GError instead of a string message, so we can translate it in
 414         Modest.
 415
 416 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 417
 418         * src/maemo/modest-address-book.c:
 419         (modest_address_book_check_names):
 420         * src/maemo/modest-msg-view-window.c:
 421         (modest_msg_view_window_clipboard_owner_change):
 422         * src/modest-init.c: (modest_init_init_ui):
 423         * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
 424         (update_folders_cb), (modest_mail_operation_update_account):
 425         * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
 426         (modest_ui_actions_on_msg_attachment_clicked),
 427         (modest_ui_actions_on_msg_recpt_activated):
 428         * src/widgets/modest-header-view.c: (drag_data_get_cb):
 429         * src/widgets/modest-msg-view.c: (modest_msg_view_search),
 430         (modest_msg_view_search_next):
 431         * src/widgets/modest-recpt-editor.c:
 432         (modest_recpt_editor_on_button_release_event),
 433         (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
 434         g_message(). At this point we should only be seeing interesting errors on
 435         stdout. Debugging messages could be #ifdefed-out if they are still useful.
 436
 437 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 438
 439         (modest_wizard_dialog_force_title_update):
 440         * src/maemo/easysetup/modest-wizard-dialog.h:
 441         * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
 442         For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
 443         can update the title when appropriate. Otherwise the title is wrong if the
 444         pages are added after adding the notebook to the dialog.
 445         This must be a problem in HildonWizardDialog too.
 446         Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
 447
 448         * src/maemo/easysetup/modest-easysetup-wizard.c:
 449         (create_subsequent_customsetup_pages),
 450         (create_subsequent_easysetup_pages):
 451         Call modest_wizard_dialog_force_title_update() so that the title is
 452         correct even with GTK+ < 2.10.
 453         This fixes projects.maemo.org bug NB#56145 .
 454
 455 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 456
 457         * src/maemo/modest-platform.c:
 458         (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
 459         flag (awful lack of namespacing in this API) to prevent a useless %s dialog
 460         from being shown.
 461
 462 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 463
 464         * src/widgets/modest-window.h:
 465         * src/widgets/modest-window.c: Added a save_state_func vfunc,
 466         and modest_window_save_state(), which invokes it.
 467
 468         * src/widgets/modest-window-mgr.h:
 469         * src/widgets/modest-window-mgr.c:
 470         Added modest_window_mgr_save_state_for_all_windows(), which calls
 471         the save_state vfunc on all registered windows, if implemented.
 472
 473         * src/gnome/modest-msg-edit-window.c:
 474         * src/gnome/modest-msg-view-window.c:
 475         * src/maemo/modest-msg-edit-window.c:
 476         * src/maemo/modest-msg-view-window.c:
 477         * src/maemo/modest-main-window.c:
 478         Specify the existing save_settings functions as implementations of
 479         ModestWindow::save_state_func().
 480
 481         * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
 482         Call modest_window_mgr_save_state_for_all_windows(). This happens before
 483         enabling hibernation, for instance.
 484
 485         We may need to do the same thing for restoring settings.
 486
 487
 488 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 489
 490         * src/widgets/modest-window-mgr.c:
 491         * src/widgets/modest-window-mgr.h:
 492         Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
 493         modest_window_mgr_get_hibernation_is_prevented().
 494
 495         * src/maemo/modest-main-window.c:
 496         (on_hildon_program_is_topmost_notify): Prevent hibernation
 497         (possible when the application goes to the background in the WM),
 498         if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
 499
 500         * src/maemo/easysetup/modest-easysetup-wizard.c:
 501         (modest_easysetup_wizard_dialog_init):
 502         * src/maemo/modest-account-settings-dialog.c:
 503         (modest_account_settings_dialog_init):
 504         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 505         (modest_connection_specific_smtp_edit_window_init):
 506         * src/maemo/modest-connection-specific-smtp-window.c:
 507         (modest_connection_specific_smtp_window_init):
 508         * src/maemo/modest-signature-editor-dialog.c:
 509         (modest_signature_editor_dialog_init):
 510         Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
 511         prevent hibernation while any of these account settings dialogs are open.
 512
 513 2007-05-04  Murray Cumming  <murrayc@murrayc.com>
 514
 515         * src/maemo/Makefile.am:
 516         * src/maemo/modest-osso-state-saving.c:
 517         * src/maemo/modest-osso-state-saving.h: Added
 518         modest_osso_load_state() and modest_osso_save_state() though they do
 519         nothing now. They should iterate through all the open windows and load/save
 520         their state.
 521         * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
 522         save state when closing.
 523
 524         * src/maemo/modest-main-window.c:
 525         (on_hildon_program_is_topmost_notify), (modest_main_window_new):
 526         Add a notification handler for the HildonProgram::is-topmost property,
 527         so we can allow hibernation when the application goes into the background.
 528         But we still need to detect when the accounts setup windows are open so
 529         we can stop hibernation when they are open.
 530         To do this, I also added the main window the HildonProgram. This might have
 531         other side-effects/benefits, and should maybe be done for other windows.
 532
 533         * src/maemo/modest-osso-autosave-callbacks.h:
 534         * src/maemo/modest-osso-autosave-callbacks.c:
 535         (modest_on_osso_application_autosave): Add a libosso auto-save callback,
 536         though it does not do anything yet, and we might never need this to do
 537         anything. For instance, we already save drafts.
 538
 539         * src/maemo/modest-platform.c: (modest_platform_init):
 540         Specify the libosso auto-save callback.
 541
 542 2007-05-03  Murray Cumming  <murrayc@murrayc.com>
 543
 544         * src/maemo/modest-platform.c:
 545         (modest_platform_set_update_interval):
 546         * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
 547         aparently stays valid between application instances, so we can use this
 548         to remove and reset it later. According to a maemo-developers email from
 549         David Weinehall.
 550
 551 2007-05-03  Murray Cumming  <murrayc@murrayc.com>
 552
 553         * configure.ac: Depend on libalarm for Maemo.
 554
 555         * src/dbus_api/modest-dbus-api.h:
 556         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
 557         (on_send_receive), (modest_dbus_req_handler):
 558         Handle a SEND_RECEIVE D-Bus method.
 559
 560         * libmodest-dbus-client/libmodest-dbus-client.c:
 561         (libmodest_dbus_client_send_and_receive):
 562         * libmodest-dbus-client/libmodest-dbus-client.h:
 563         Add C convenience functions for calling the new D-Bus method.
 564
 565         * src/modest-platform.h:
 566         * src/gnome/modest-platform.c:
 567         * src/maemo/modest-platform.c:
 568         Added modest_platform_set_update_interval(), which uses the
 569         alarmd API on Maemo.
 570         (modest_platform_init),
 571         Call modest_platform_set_update_interval(), using a hard-coded
 572         interval for now (until the global settings dialog is implemented),
 573         though I am not sure that this makes sense yet.
 574
 575 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 576
 577         * src/dbus_api/modest-dbus-callbacks.c:
 578         (modest_osso_cb_hw_state_handler):
 579         * src/dbus_api/modest-dbus-callbacks.h:
 580         * src/maemo/modest-platform.c: (modest_platform_init):
 581         Registered (empty) callbacks for the osso hardware state D-Bus signals,
 582         in case this has some effect on the ability for Maemo to ping the
 583         application.
 584
 585 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 586
 587         * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
 588         Comment out an if() that checks a gchar for < 0, causing a build-breaking
 589         warning. It is probably a logic error, but I need to fix the build.
 590
 591 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 592
 593         * src/modest-account-mgr.h:
 594         * src/modest-account-mgr.c:
 595         (modest_account_mgr_account_names): Add a gboolean enabled_only
 596         parameter, so we can get lists of onlt the enabled accounts.
 597
 598         (modest_account_mgr_add_account),,
 599         (modest_account_mgr_account_with_display_name_exists):
 600         * src/maemo/modest-msg-edit-window.c: (get_transports):
 601         * src/modest-account-mgr-helpers.c:
 602         (modest_account_mgr_set_first_account_as_default):
 603         * src/modest-init.c: (init_default_account_maybe):
 604         * src/modest-tny-account-store.c: (get_accounts):
 605         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
 606         (do_send_receive_auto), (modest_ui_actions_on_send_receive):
 607         * tests/check_account-mgr.c: (START_TEST):
 608         Provide the extra parameter, as appropriate.
 609
 610         * src/widgets/modest-account-view.c: (update_account_view):
 611         Do not show disabled accounts (meaning that there is no way to
 612         enable/disable accounts in the UI (the feature is not in our UI
 613         specification), so we can use this internally only to mark unfinished
 614         or temporary account data.
 615
 616         * src/maemo/easysetup/modest-easysetup-wizard.c:
 617         (create_account): Add boolean enable parameter, so we can specify FALSE
 618         to create the temporary account.
 619         (on_button_edit_advanced_settings): Create the temporary account as disabled.
 620         (on_before_next): When finishing, when there is a temporary account, just
 621         set it as enabled.
 622         Also, use a timeout to delay the showing of the dialog until gconf is likely
 623         to return correct information, due to a maemo gconf bug that is fixed in
 624         osso 1.1, but not yet in Bora.
 625         However, the dialog stays on screen after it is destroyed.
 626
 627         * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
 628         for invalid data when cancelling. Use a hildon note instead of a dialog
 629         to complain about invalid data. Do not show the account-saved note if the
 630         account is disabled (a temporary account that will not really be saved for use
 631         until later.)
 632
 633 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 634
 635         * src/modest-account-mgr-helpers.h:
 636         * src/modest-account-mgr-helpers.c:
 637         Added modest_account_mgr_unset_default_account(),
 638         Added modest_account_mgr_set_first_account_as_default().
 639
 640         * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
 641         If it was the default account, unset the default account name.
 642
 643         * src/maemo/modest-account-view-window.c:
 644         (on_delete_button_clicked): If it was the default account,
 645         set the first remaining account as the default instead.
 646
 647         * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
 648         a NULL account or a NULL default account, to prevent a crash. This should
 649         not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
 650
 651
 652 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 653
 654         * src/widgets/modest-recpt-editor.c:
 655         (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
 656         use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
 657         TODO comment for this. This fixes the build.
 658
 659         * src/modest-ui-actions.c: Add do_send_receive(), though it might not
 660         be the best place for it. This will in future update all auto-update accounts,
 661         rather than just the current/default account, when that gconf key exists.
 662         (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
 663         if there are no accounts, before calling do_send_receive().
 664         * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
 665
 666         * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
 667         * src/maemo/modest-main-window-ui.h:
 668         * src/maemo/modest-main-window.c: (on_connection_changed),
 669         (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
 670         directly, becaue the signal handler does more.
 671
 672 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 673
 674         * src/modest-account-mgr-helpers.c:
 675         (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
 676         for the case that the account does not exist.
 677
 678         * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
 679         (equivalent to the modest account name) rather than the tinymail account name
 680         (equivalent to the modest account title - human readable) to get the account data.
 681         Check for null account data to prevent the crash, and add a TODO comment saying that
 682         this needs fixing because it is using the server account name instead of the account name.
 683
 684 2007-04-29  Murray Cumming  <murrayc@murrayc.com>
 685
 686         * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
 687         * src/maemo/modest-account-settings-dialog.c: (show_error),
 688         (show_ok):
 689         Use hildon_note_new_information() for informative and error messages,
 690         which seems to be expected for Maemo applications (no documentation that I know of
 691         says this). I am surprised that there is no distinction between info and error
 692         dialogs.
 693
 694 2007-04-29  Murray Cumming  <murrayc@murrayc.com>
 695
 696         * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
 697         it is easy to find where this is used.
 698
 699         * src/maemo/easysetup/modest-easysetup-wizard.c:
 700         (create_page_welcome), (create_page_account_details),
 701         (create_page_user_details), (create_page_complete_easysetup),
 702         (create_page_custom_incoming), (create_page_custom_outgoing),
 703         (create_page_complete_custom):
 704         * src/maemo/modest-account-settings-dialog.c:
 705         (create_page_account_details), (create_page_user_details),
 706         (create_page_incoming), (create_page_outgoing):
 707         * src/maemo/modest-account-view-window.c: (window_vbox_new):
 708         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 709         (modest_connection_specific_smtp_edit_window_init):
 710         * src/maemo/modest-connection-specific-smtp-window.c:
 711         (modest_connection_specific_smtp_window_init):
 712         * src/maemo/modest-signature-editor-dialog.c:
 713         (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
 714         and scrolling policy as per the Email Application Layout Guide, if I have
 715         understood it.
 716
 717 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 718
 719         * src/modest-tny-account-store.c: (modest_tny_account_store_init):
 720         Remove the add_transport_account_func and add_store_account_func vfunc implementations,
 721         which were empty, because these vfuncs have been removed from TnyAccountStore.
 722         This fixes the build.
 723
 724 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 725
 726         * src/maemo/modest-main-window.c:
 727         (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
 728         showing/hiding it. Added TODO because it probably should not be NULL.
 729         * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
 730         because unnecessary g_warnings() make degugging difficult.
 731
 732 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 733
 734         * src/maemo/modest-msg-edit-window.c:
 735         (modest_msg_edit_window_select_color),
 736         (modest_msg_edit_window_select_background_color): 2 const corrections and
 737         moving 2 #endifs before closing brackets, to fix the build.
 738
 739 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 740
 741         * src/maemo/easysetup/modest-easysetup-wizard.h:
 742         * src/maemo/easysetup/modest-easysetup-wizard.c:
 743         (modest_easysetup_wizard_dialog_finalize),
 744         (on_button_edit_advanced_settings), (create_page_complete_custom),
 745         (on_response), (create_account):
 746         Implement the Advanced Settings edit button, by saving the account information,
 747         for the Advanded Settings dialog to use directly from gconf, and removing it
 748         if Finish is never clicked. There is still some UI strangeness, so this is not finished.
 749         Bug #5533 in the projects.maemo.org bugzilla.
 750
 751 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 752
 753         * src/maemo/modest-msg-view-window.c:
 754         (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
 755         when opening a message window.
 756
 757 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 758
 759         * src/maemo/easysetup/modest-easysetup-wizard.c:
 760         (create_page_custom_outgoing): Correct the position of the horizontal separator to
 761         match the UI spec.
 762
 763         * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
 764         before showing/hiding them, to avoid a crash when clicking on folders when there are no
 765         gconf settings. I probably added more checks than necessary, but that is safer.
 766
 767         * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
 768         variable to fix the build, but this seems to be used when it is still NULL.
 769
 770 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 771
 772         * src/modest-platform.h:
 773         * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
 774         * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
 775         * src/modest-main.c: Implement this function so we can avoid using
 776         maemo-specific API from cross-platform code.
 777         (main):
 778         * src/modest-tny-account-store.c:
 779         (get_smtp_specific_transport_account_for_open_connection):
 780         * src/modest-ui-actions.c: (check_for_connection),
 781         (modest_ui_actions_on_item_not_found):
 782         Use modest_platform_connect_and_wait() and put #idefs around other
 783         maemo-specific code, because only maemo currently has a way to
 784         identify connection names.
 785
 786 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 787
 788         * src/modest-tny-account-store.h:
 789         * src/modest-tny-account-store.c:
 790         Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
 791         the connection-specific SMTP server settings in the configuration.
 792
 793         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
 794         (on_idle_mail_to):
 795         * src/maemo/modest-main-window.c: (on_connection_changed),
 796         (connect_signals):
 797         * src/modest-main.c: (main), (start_ui), (send_mail):
 798         Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
 799         that is what is intended.
 800
 801         * src/modest-ui-actions.c: (action_send), (action_receive),
 802         (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
 803         Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
 804         modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
 805         SMTP server is used when it is specified.
 806
 807         (modest_ui_actions_on_send_receive):
 808         Check that a connection is open before proceeding.
 809         Receive and then send, instead of vice-versa, as per the specification.
 810
 811 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 812
 813         * src/modest-mail-operation.c:
 814         (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
 815         though I guess it should be something other than NULL.
 816
 817 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 818
 819         * src/maemo/easysetup/modest-easysetup-wizard.c:
 820         (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
 821         combo twice, to avoid an g_warning and to make it visible again.
 822         * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
 823         attached before detaching it, to avoid a g_warning, and add comment about the implicit
 824         (already intended) dereference when detaching, because we then recreate the menu.
 825         But I am not sure why the warning was happening, and it is possible that this is a memory
 826         leak.
 827
 828 2007-04-25  Murray Cumming  <murrayc@murrayc.com>
 829
 830         * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
 831         and uri_parse_mailto() utility functions.
 832         (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
 833         the mailto URI.
 834         * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
 835
 836 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 837
 838         * src/dbus_api/modest-dbus-api.h:
 839         * src/dbus_api/modest-dbus-callbacks.c:
 840         Use an idle callback to execute the modest code in the application's own thread.
 841         Remove the helloworld example method.
 842         Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
 843         parsed, and the open-message method is not implemented because this is not yet implemented in
 844         modest itself.
 845         * libmodest-dbus-client/libmodest-dbus-client.c:
 846         (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
 847         (libmodest_dbus_client_open_message):
 848         * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
 849
 850         * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
 851         body without crashing.
 852
 853         * tests/dbus_api/Makefile.am:
 854         * tests/dbus_api/test_mail_to.c:
 855         * tests/dbus_api/test_open_message.c: New tests for the new methods.
 856
 857 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 858
 859         * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
 860         Added file to fix the build. Sorry.
 861
 862         * src/dbus_api/Makefile.am:
 863         * src/dbus_api/modest-dbus-api.h:
 864         * src/dbus_api/modest-dbus-callbacks.h:
 865         * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
 866         (modest_dbus_req_handler):
 867         Put constants in a separate header so it can be reused by the
 868         client library, without duplication
 869
 870         * libmodest-dbus-client/Makefile.am:
 871         * libmodest-dbus-client/libmodest-dbus-client.c:
 872         (libmodest_dbus_client_call_helloworld),
 873         (libmodfest_dbus_client_send_mail),
 874         (libmodfest_dbus_client_mailto),
 875         (libmodfest_dbus_client_open_message):
 876         * libmodest-dbus-client/libmodest-dbus-client.h:
 877         (Partly) Implement a send_mail D-Bus method.
 878
 879         * tests/dbus_api/Makefile.am:
 880         * tests/dbus_api/test_send_mail.c: (main): Added a test for
 881         the send_email D-Bus method.
 882
 883 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 884
 885         * Makefile.am:
 886         * configure.ac:
 887         * libmodest-dbus-client/Makefile.am:
 888         * libmodest-dbus-client/libmodest-dbus-client.c:
 889         * libmodest-dbus-client/libmodest-dbus-client.h:
 890         * tests/dbus_api/Makefile.am:
 891         * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
 892         for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
 893
 894 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 895
 896         * src/maemo/easysetup/modest-easysetup-wizard.c:
 897         (create_page_account_details):
 898         * src/maemo/modest-account-settings-dialog.c:
 899         (create_page_account_details): Explicitly set auto-capitalization mode for the title
 900         widgets, because this might not be the default in future versions of the Maemo GTK+.
 901         However, I can not not get capitalization to work even in a simple test case.
 902
 903 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 904
 905         * src/maemo/easysetup/modest-easysetup-wizard.c:
 906         (create_page_custom_incoming), (create_page_custom_outgoing):
 907         * src/maemo/modest-account-settings-dialog.c:
 908         (create_page_account_details), (create_page_incoming),
 909         (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
 910         instead of using gtk_check_button_with_label(), so they are aligned like the other
 911         widgets, as per the UI spec.
 912
 913 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 914
 915         * src/maemo/easysetup/modest-easysetup-wizard.c:
 916         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 917         * src/widgets/modest-validating-entry.c:
 918         * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
 919         Modest prefix instead of an EasySetup prefix.
 920
 921 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 922
 923         * src/widgets/modest-validating-entry.h:
 924         * src/widgets/modest-validating-entry.c: (on_insert_text),
 925         Added easysetup_validating_entry_set_max_func(), used to set a callback
 926         to call when the max number of characters is reached. GtkEntry has a max-length
 927         already but is silent about it.
 928
 929         * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
 930         (create_page_account_details), (create_page_user_details),
 931         (create_account):
 932         * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
 933         (create_page_account_details), (create_page_user_details),
 934         (create_page_outgoing):
 935         * src/modest-ui-actions.c: (modest_ui_actions_on_details):
 936         Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
 937         the UI spec, when the user tries to enter more than the max number of characters.
 938
 939 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 940
 941         * src/maemo/easysetup/modest-easysetup-wizard.c:
 942         (create_page_user_details), (create_page_custom_incoming),
 943         (create_page_custom_outgoing):
 944         * src/maemo/modest-account-settings-dialog.c:
 945         (create_page_user_details), (create_page_incoming),
 946         (create_page_outgoing):
 947         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 948         (modest_connection_specific_smtp_edit_window_init):
 949         Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
 950         not appropriate. Bad Maemo-specific defaults!.
 951
 952 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 953
 954         * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
 955         (on_toggle_button_changed), (modest_signature_editor_dialog_init),
 956         (modest_signature_editor_dialog_set_settings):
 957         Disable the label and textview when the checkbox is disabled, and use the
 958         specified (UI spec) default signature text.
 959
 960 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 961
 962         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 963         (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
 964
 965         * src/modest-defs.h:
 966         * src/modest-account-mgr-helpers.h:
 967         * src/modest-account-mgr-helpers.c:
 968         Added modest_account_mgr_get/set_signature(), using new gconf keys.
 969
 970         * src/maemo/Makefile.am:
 971         * src/maemo/modest-signature-editor-dialog.c:
 972         * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
 973         as per the UI spec.
 974
 975         * src/maemo/modest-account-settings-dialog.h:
 976         * src/maemo/modest-account-settings-dialog.c:
 977         (modest_account_settings_dialog_finalize), (on_button_signature),
 978         (save_configuration): Use the new dialog when the Edit button is pressed, and
 979         save the changes if necessary, as per the UI spec.
 980
 981 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 982
 983         * src/maemo/Makefile.am:
 984         * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
 985         based on maemo-develoers email from Dirk.
 986
 987         * src/maemo/easysetup/modest-easysetup-wizard.c:
 988         (create_page_welcome), (create_page_account_details),
 989         (create_page_user_details), (create_page_complete_easysetup),
 990         (create_page_custom_incoming), (create_page_custom_outgoing),
 991         (create_page_complete_custom),
 992         (modest_easysetup_wizard_dialog_init):
 993         * src/maemo/modest-account-settings-dialog.c:
 994         (create_page_account_details), (create_page_user_details),
 995         (create_page_incoming), (create_page_outgoing),
 996         (modest_account_settings_dialog_init):
 997         * src/maemo/modest-connection-specific-smtp-window.c:
 998         (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
 999
1000 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
1001
1002         * src/maemo/easysetup/modest-easysetup-wizard.c:
1003         (create_page_account_details), (create_page_custom_outgoing),
1004         (create_page_complete_custom):
1005         * src/maemo/modest-account-settings-dialog.c:
1006         (create_page_user_details), (create_page_incoming),
1007         (create_page_outgoing):
1008         * src/maemo/modest-connection-specific-smtp-edit-window.c:
1009         (modest_connection_specific_smtp_edit_window_init):
1010         Use the correct (UI spec) port min/max, and use horizontal separators,
1011         as per the UI spec.
1012
1013 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
1014
1015         * src/maemo/easysetup/modest-easysetup-wizard.c:
1016         (set_default_custom_servernames):
1017         * src/maemo/modest-account-settings-dialog.c:
1018         (create_page_incoming), (on_combo_outgoing_security_changed),
1019         (on_combo_incoming_security_changed), (create_page_outgoing),
1020         (modest_account_settings_dialog_set_account_name),
1021         (save_configuration):
1022         * src/maemo/modest-connection-specific-smtp-edit-window.c:
1023         (on_combo_security_changed),
1024         (modest_connection_specific_smtp_edit_window_init),
1025         (modest_connection_specific_smtp_edit_window_set_connection),
1026         (modest_connection_specific_smtp_edit_window_get_settings):
1027         Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1028         as per the UI spec.
1029
1030 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
1031
1032         * po/en_GB.po:
1033         * src/maemo/easysetup/modest-easysetup-wizard.c:
1034         (create_page_custom_outgoing), (create_page_complete_custom):
1035         * src/maemo/modest-account-settings-dialog.c:
1036         (create_page_user_details), (create_page_outgoing):
1037         * src/maemo/modest-account-view-window.c: (button_box_new):
1038         Use changed logical IDs as per the most recent UI spec:
1039         mcen_bd_emailsetup_edit -> mcen_bd_edit
1040         mcen_bd_emailsetup_delete -> mcen_bd_delete
1041         mcen_bd_emailsetup_close -> mcen_bd_close
1042
1043 2007-04-20  2007-04-20  Murray Cumming  <murrayc@murrayc.com>
1044
1045         * configure.ac:
1046         * src/Makefile.am:
1047         * src/dbus_api/Makefile.am:
1048         * src/dbus_api/modest-dbus-callbacks.c:
1049         * src/dbus_api/modest-dbus-callbacks.h:
1050         * src/maemo/modest-platform.c: (modest_platform_init):
1051         Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1052         method.
1053         * tests/Makefile.am:
1054         * tests/dbus_api/Makefile.am:
1055         * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1056
1057 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
1058
1059         * src/maemo/modest-account-settings-dialog.c:
1060         * src/maemo/modest-connection-specific-smtp-edit-window.c:
1061         Removed unnecessary includes.
1062
1063 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
1064
1065         * src/maemo/easysetup/modest-easysetup-wizard.c:
1066         * src/maemo/modest-account-settings-dialog.c:
1067         * src/maemo/modest-connection-specific-smtp-edit-window.c:
1068         * src/widgets/Makefile.am:
1069         * src/widgets/modest-easysetup-secureauth-combo-box.c:
1070         * src/widgets/modest-easysetup-secureauth-combo-box.h:
1071         * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1072         * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1073         * src/widgets/modest-secureauth-combo-box.c:
1074         * src/widgets/modest-secureauth-combo-box.h:
1075         * src/widgets/modest-serversecurity-combo-box.c:
1076         * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1077         made the GObject names more consistent with the rest of the Modest code.
1078
1079 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
1080
1081         * src/maemo/easysetup/Makefile.am:
1082         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1083         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1084         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1085         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1086         * src/maemo/easysetup/modest-easysetup-wizard.c:
1087         * src/maemo/easysetup/modest-validating-entry.c:
1088         * src/maemo/easysetup/modest-validating-entry.h:
1089         * src/maemo/modest-account-settings-dialog.c:
1090         * src/maemo/modest-connection-specific-smtp-edit-window.c:
1091         * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1092         widgets/ because they are used outside of easysetup too. After checking in,
1093         svn will allow me to rename them too.
1094
1095 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
1096
1097         * src/gnome/modest-msg-edit-window.c:
1098         (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1099         linker error, to fix the build on the GNOME platform.
1100         modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1101         modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1102         ifdefed out to avoid a warning.
1103
1104 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
1105
1106         * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1107         use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1108         some alternative for GTK+ 2.6.
1109
1110 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
1111
1112         * src/maemo/modest-address-book.c: Added include to avoid a warning.
1113
1114         * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1115         specified for EmailAccountsDialog in UI spec.
1116
1117         * src/maemo/easysetup/modest-easysetup-wizard.c:
1118         * src/maemo/easysetup/modest-easysetup-wizard.h:
1119         * src/maemo/modest-account-settings-dialog.c:
1120         * src/maemo/modest-account-settings-dialog.h:
1121         Reuse a member window widget for the connection-specific SMTP server accounts,
1122         so we can tell it to create/save the accounts only if we actually save changes.
1123
1124         * src/maemo/modest-connection-specific-smtp-edit-window.h:
1125         * src/maemo/modest-connection-specific-smtp-edit-window.c:
1126         (modest_connection_specific_smtp_edit_window_get_settings):
1127         Return a struct instance for temporarily remembering the entered data.
1128
1129         * src/maemo/modest-connection-specific-smtp-window.h:
1130         * src/maemo/modest-connection-specific-smtp-window.c:
1131         (modest_connection_specific_smtp_window_finalize),
1132         (modest_connection_specific_smtp_window_fill_with_connections),
1133         (on_button_edit),
1134         (modest_connection_specific_smtp_window_save_server_accounts),
1135         (update_model_server_names): Do not actually save data until asked,
1136         when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1137
1138         (on_selection_changed),
1139         (modest_connection_specific_smtp_window_init): Disable the edit
1140         button when nothing is selected.
1141
1142         * src/modest-account-mgr-helpers.c:
1143         * src/modest-account-mgr-helpers.h:
1144         Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1145         elsewhere.
1146
1147 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
1148
1149         * src/modest-account-mgr-helpers.h:
1150         * src/modest-account-mgr-helpers.c:
1151         (modest_account_mgr_get_unused_account_name),
1152         (modest_account_mgr_get_unused_account_display_name): Added these
1153         utility functions, to avoid code duplication.
1154
1155         * src/maemo/easysetup/modest-easysetup-wizard.c:
1156         (create_page_account_details), (create_account):
1157         * src/maemo/modest-connection-specific-smtp-edit-window.c:
1158         (on_combo_security_changed),
1159         (modest_connection_specific_smtp_edit_window_init),
1160         (modest_connection_specific_smtp_edit_window_save_settings):
1161         * src/maemo/modest-connection-specific-smtp-edit-window.h:
1162         * src/maemo/modest-connection-specific-smtp-window.c:
1163         (modest_connection_specific_smtp_window_finalize),
1164         (modest_connection_specific_smtp_window_fill_with_connections),
1165         (on_button_edit), (modest_connection_specific_smtp_window_init):
1166         * src/maemo/modest-connection-specific-smtp-window.h:
1167         Implementing saving of connection-specific server accounts.
1168
1169         But I need to refactor this so we can save the data for each
1170         possible connection-specific account and only actually create the server accounts
1171         when the easysetup finished, or the OK button is pressed on the account settings
1172         dialog.
1173
1174 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
1175
1176         * src/maemo/modest-connection-specific-smtp-edit-window.c:
1177         (on_combo_security_changed):
1178         (modest_connection_specific_smtp_edit_window_init):
1179         Auto-fill the port number as in the account settings.
1180
1181         (modest_connection_specific_smtp_edit_window_set_connection):
1182         * src/maemo/modest-connection-specific-smtp-edit-window.h:
1183         * src/maemo/modest-connection-specific-smtp-window.c:
1184         (fill_with_connections), (on_button_edit),
1185         (modest_connection_specific_smtp_window_init):
1186         Turn the edit window into a dialog to simplify the code, and
1187         set a WM hint as in a GtkDialog, because only a popup can be on top of
1188         another window in Maemo, and popups usually have no WM decoration.
1189
1190         * src/modest-defs.h:
1191         * src/modest-account-mgr-helpers.c:
1192         (modest_account_mgr_set_connection_specific_smtp),
1193         (modest_account_mgr_remove_connection_specific_smtp),
1194         (modest_account_mgr_get_connection_specific_smtp):
1195         * src/modest-account-mgr-helpers.h: Some functions to write the
1196         connection-specific SMTP server information. Not yet used.
1197
1198
1199         * src/widgets/modest-folder-view.c: (text_cell_data):
1200         Fix a warning about an uninitialized variable.
1201         (on_configuration_key_changed): Put an #ifdef around the use
1202         of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1203
1204 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
1205
1206         * src/maemo/modest-account-settings-dialog.h:
1207         * src/maemo/modest-account-settings-dialog.c:
1208         Added connect_for_modified() utility function to mark the new modified boolean.
1209
1210         (create_page_account_details), (create_page_user_details),
1211         (create_page_incoming), (create_page_outgoing), (on_response),
1212         (modest_account_settings_dialog_init),
1213         (modest_account_settings_dialog_set_account_name):
1214         Only warn about unsaved changes when there are actually unsaved changes.
1215
1216         * src/modest-account-mgr-helpers.c:
1217         * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1218         into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1219         to get the data from there in future.
1220
1221 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
1222
1223         * src/modest-defs.h:
1224
1225         * src/modest-account-mgr-helpers.h:
1226         * src/modest-account-mgr-helpers.c:
1227         Store the security account setting in a single conf key instead of using
1228         the options list, so that the list is left for just the to-be-removed camel hack,
1229         and because gconf_client_set_list() is failing for some reason.
1230
1231         * src/modest-account-mgr.c:
1232         (modest_account_mgr_add_server_account):
1233         * src/maemo/modest-account-settings-dialog.c:
1234         (modest_account_settings_dialog_set_account_name),
1235         (save_configuration): Use the renamed functions.
1236
1237
1238 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
1239
1240         * src/widgets/Makefile.am:
1241         * src/widgets/modest-limit-retrieve-combo-box.c:
1242         * src/widgets/modest-limit-retrieve-combo-box.h:
1243         * src/widgets/modest-retrieve-combo-box.c:
1244         * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1245         the account settings dialog.
1246
1247         * src/modest-defs.h:
1248         * src/modest-account-mgr-helpers.h:
1249         * src/modest-account-mgr-helpers.c:
1250         (modest_server_account_get_option_secure_auth),
1251         (modest_server_account_set_option_secure_auth):
1252         * src/modest-account-mgr.c:
1253         (modest_account_mgr_add_server_account):
1254         Use the existing AUTH_MECH conf key for the secure-auth setting,
1255         instead of putting it in the list options, because this was actually used already.
1256
1257         * src/maemo/modest-account-settings-dialog.c:
1258         (create_page_account_details),
1259         (modest_account_settings_dialog_set_account_name),
1260         (save_configuration):
1261         * src/maemo/modest-account-settings-dialog.h:
1262         Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1263         Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1264
1265 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
1266
1267         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1268         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1269         Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1270
1271         * src/modest-defs.h:
1272         * src/maemo/modest-account-settings-dialog.c:
1273         (create_page_incoming), (on_combo_outgoing_security_changed),
1274         (on_combo_incoming_security_changed), (create_page_outgoing),
1275         (modest_account_settings_dialog_set_account_name),
1276         (save_configuration): Load/Save the port number, and change it when the
1277         security combo changes, to suitable defaults.
1278
1279 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
1280
1281         * src/modest-account-mgr.c:
1282         (modest_account_mgr_add_server_account): Set the security and secure-auth
1283         options, and add a comment saying that the other camel-specific options should be
1284         removed in future.
1285
1286 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
1287
1288         * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1289         found by valgrind.
1290         * src/modest-tny-account-store.c: (account_list_free),
1291         (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1292         cursor->data after unreffing it. But there is some strange stuff there so it might not be
1293         easy to fix.
1294
1295 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
1296
1297         * src/modest-protocol-info.c:
1298         * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1299         is required by our UI spec. Maybe something in our implementation will use this eventually.
1300         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1301         (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1302         instead of the previous 0 placeholder.
1303
1304         * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1305         secure-auth settings.
1306         * src/modest-account-mgr-helpers.h:
1307         * src/modest-account-mgr-helpers.c:
1308         (modest_server_account_data_get_option_secure_auth),
1309         (modest_server_account_set_option_secure_auth),
1310         (modest_server_account_data_get_option_security),
1311         (modest_server_account_set_option_security): Added this API for getting and setting the security
1312         and secure-auth settings.
1313
1314         * src/maemo/modest-account-settings-dialog.h:
1315         * src/maemo/modest-account-settings-dialog.c:
1316         (modest_account_settings_dialog_finalize), (check_data),
1317         (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1318         about changing titles.
1319         (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1320         (save_configuration): Save the security and secure-auth settings.
1321
1322         * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1323         is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1324
1325 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
1326
1327         * src/modest-defs.h:
1328         * src/modest-account-mgr.c:
1329         (modest_account_mgr_add_server_account):
1330         Added and used defines for the options key and value pair strings,
1331         that are used so far, though they do not seem to correspond to anything in our
1332         UI specs or ModestProtocol enum.
1333
1334         * src/modest-account-mgr-helpers.h:
1335         * src/modest-account-mgr-helpers.c:
1336         (compare_option_strings_for_name),
1337         (modest_server_account_data_get_option_value),
1338         (modest_server_account_data_get_option_bool),
1339         (modest_account_mgr_get_server_account_option):
1340         Added helper functions for parsing the options GSList.
1341
1342 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1343
1344         * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1345         display name is based on the supplied account name.
1346         * src/modest-account-mgr.c:
1347         * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1348         with an inefficient, but good-enough, implementation.
1349
1350         * src/maemo/easysetup/modest-easysetup-wizard.c:
1351         (create_page_account_details), (on_before_next), (create_account):
1352         Check for existing display names rather than (non-user-visible) account names, and just
1353         create and set a unique account name at the end.
1354
1355         * src/maemo/modest-account-settings-dialog.c:
1356         (modest_account_settings_dialog_init),
1357         (modest_account_settings_dialog_set_account_name),
1358         (create_page_incoming): Show the display name, instead of the account name.
1359         (on_response): Do some (not all) extra checks, as in the UI spec.
1360         (save_configuration): Save the display name if it was changed.
1361
1362 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1363
1364         * po/en_GB.po: Added needed logical ID and translation.
1365         * src/widgets/modest-account-view.c: (on_account_default_toggled),
1366         (init_view): Made the is-default column clicking work.
1367
1368 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1369
1370         * configure.ac:
1371         * src/maemo/easysetup/Makefile.am:
1372         * src/maemo/easysetup/modest-easysetup-wizard.c:
1373         (modest_easysetup_wizard_dialog_init):
1374         * src/maemo/easysetup/provider-data-test.keyfile:
1375         * src/maemo/easysetup/provider-data.keyfile:
1376         Moved the provider data file to the new modest-providers-data package and used it from there.
1377
1378 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1379
1380         * src/modest-local-folder-info.c:
1381         (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1382         N_() was already used on the static strings, but this just marks it for translation without
1383         using the translation.
1384
1385 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1386
1387         * src/maemo/modest-account-settings-dialog.c:
1388         (create_page_incoming),
1389         (modest_account_settings_dialog_set_account_name):
1390         Added comments about the need for new API in ModestAccountMgr to handle the authentication
1391         and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1392         I will do this if nobody else gets there first.
1393
1394 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1395
1396         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1397         Saved much of the incoming and outgoing data too, though I cannot yet see how to
1398         save the security stuff.
1399
1400 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1401
1402         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1403         Set the email address and user fullname, which I now see must be
1404         done separately.
1405
1406         * src/maemo/modest-account-settings-dialog.h:
1407         * src/maemo/modest-account-settings-dialog.c:
1408          (on_response),
1409         (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1410         leave-on-server and authentication.
1411         (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1412         how to do the rest.
1413
1414 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1415
1416
1417         * src/maemo/modest-account-settings-dialog.c:
1418         * src/maemo/modest-account-settings-dialog.h:
1419         Most (but not all) of the widgets are now present as specified by the UI spec.
1420         No changes are yet saved, and some details are not properly shown yet.
1421
1422         * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1423
1424 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1425
1426         * src/maemo/Makefile.am:
1427         * src/maemo/modest-account-settings-dialog.c:
1428         * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1429         an existing account. Doesn't do much yet.
1430
1431         * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1432         Open the accounts settings dialog when Edit is clicked.
1433
1434 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1435
1436         * src/maemo/easysetup/Makefile.am:
1437         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1438         (load_from_file):
1439         * src/maemo/easysetup/modest-easysetup-wizard.c:
1440         (modest_easysetup_wizard_dialog_init):
1441         Try to get the source directory from the build system,
1442         instead of hard-coding "./" into the source code, when opening our local
1443         copies of the configuration files.
1444         But this still fails when opening the wizard from the Accounts window,
1445         maybe because the working directory seems to change at runtime.
1446         So the wizard will fail the second time unless you copy the files into their
1447         proper locations - see the stdout warnings for the paths.
1448
1449         (create_page_account_details),(on_before_next):
1450         Check for existing non-server accounts instead of server accounts,
1451         so the default account name is useful again, and to prevent trying to
1452         recreate accounts.
1453
1454         * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1455         Show the wizard when New is clicked.
1456
1457         * src/widgets/modest-account-view.c: (on_account_default_toggled),
1458         (init_view): Show the column headers, and show the columns that are
1459         specified in the UI specs. However, something in Maemo's GTK+ prevents
1460         us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1461         change the default account. This is despite unsetting the special properties.
1462
1463 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1464
1465         * docs/reference/modest-design.sgml: Corrected spelling mistake.
1466         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1467         Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1468         This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1469         to make that clearer.
1470         * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1471
1472 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1473
1474         * src/maemo/modest-account-view-window.c:
1475         (modest_account_view_window_init),
1476         (modest_account_view_window_new):
1477         Use the same buttons as specified in the
1478         UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1479         the existing widgets, which never had a chance of working.
1480         Put the ModestAccountView treeview in a scrolled window.
1481         Do not repeat the initialization in both _init() and _new().
1482
1483         * src/widgets/modest-account-view.c: (update_account_view):
1484         Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1485         this widget and window shows no accounts.
1486
1487         * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1488
1489 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1490
1491         * src/maemo/easysetup/modest-easysetup-wizard.c:
1492         (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1493         (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1494         returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1495         which seems wrong.
1496
1497         * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1498         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1499         accounts exist yet, as in the UI spec.
1500
1501         * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
1502
1503 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1504
1505         * src/maemo/Makefile.am:
1506         * src/maemo/modest-connection-specific-smtp-edit-window.c:
1507         * src/maemo/modest-connection-specific-smtp-edit-window.h:
1508         New window for editing connection-specific smtp details.
1509         Not fully implemented.
1510
1511         * src/maemo/modest-connection-specific-smtp-window.c:
1512         (modest_connection_specific_smtp_window_finalize) :
1513         unref the tree model.
1514         (on_button_edit): Show the edit window.
1515
1516 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1517
1518         * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
1519         error for me.
1520
1521         * src/maemo/Makefile.am:
1522         * src/maemo/modest-connection-specific-smtp-window.c:
1523         * src/maemo/modest-connection-specific-smtp-window.h:
1524         New window for showing the list of connections, for connection-specific
1525         SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
1526         * src/maemo/easysetup/modest-easysetup-wizard.c:
1527         (create_page_custom_outgoing): Show the new window when the button is clicked.
1528
1529 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1530
1531         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1532         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1533         * src/maemo/modest-msg-edit-window.c:
1534         (modest_msg_edit_window_insert_image):
1535         * src/modest-conf.c: (modest_conf_key_escape):
1536         * src/modest-mail-operation.c:
1537         (modest_mail_operation_send_new_mail):
1538         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1539         (modest_ui_actions_on_new_account):
1540         * src/widgets/modest-attachment-view.c: (update_filename_request):
1541         * src/widgets/modest-mail-header-view.c:
1542         Corrected warnings that were breaking the build, by commenting out unused variables,
1543         and a function, and by including a header.
1544
1545 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1546
1547         * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
1548         so we can #ifdef around platform-specific code when necessary.
1549         * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
1550         to allow this to build for the GNOME platform too.
1551
1552 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1553
1554         * src/maemo/easysetup/modest-easysetup-wizard.c:
1555         Added util_increment_name() and used it in create_page_account_details()
1556         to make sure that the default account name is always a new name.
1557
1558         (modest_easysetup_wizard_dialog_init),
1559         (set_default_custom_servernames): Some minor memory management fixes.
1560
1561 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1562
1563         * Makefile.am:
1564         * configure.ac:
1565         * src/modest-runtime.c: (init_i18n): Restored the translation
1566         infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
1567         are defined in config.h, and the translations are installed.
1568
1569         * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
1570         is defined for translation.
1571
1572 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
1573
1574         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1575         (load_from_file):
1576         * src/maemo/easysetup/modest-easysetup-wizard.c:
1577         (modest_easysetup_wizard_dialog_init):
1578         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1579         Use realistic paths (though they should use $prefix generically) to the
1580         mcc_mapping and provider-data.keyfile files which might work when they
1581         are installed by the future version of the operator-wizard package,
1582         and then fallback to paths in our source code, with an explanatory
1583         warning.
1584
1585 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
1586
1587         * configure.ac:
1588         * src/Makefile.am:
1589         * src/maemo/Makefile.am:
1590         * src/maemo/easysetup/: Added files from the previously-exernal
1591         osso-modest-easysetup.
1592         * src/maemo/modest-main-window-ui.h:
1593         * src/modest-ui-actions.c:
1594         * src/modest-ui-actions.h:
1595         Added modest_ui_actions_on_new_account() as a signal handler for the
1596         New Account menu item. It shows the easysetup wizard.
1597         * po/en_GB.po: Added additional needed logical IDs and translations.
1598
1599 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
1600 Apparently ChangeLog is not used for some vague Nokia legal reasons.
1601